1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360
|
# SPDX-License-Identifier: MIT OR Apache-2.0
# This file is dual licensed under the terms of the Apache License, Version
# 2.0, and the MIT License. See the LICENSE file in the root of this
# repository for complete details.
import json
import pytest
from pretend import call_recorder
from structlog import ReturnLogger
from structlog._config import _CONFIG
from structlog.processors import KeyValueRenderer
try:
from twisted.python.failure import Failure
from twisted.python.log import ILogObserver
from structlog.twisted import (
BoundLogger,
EventAdapter,
JSONLogObserverWrapper,
JSONRenderer,
LoggerFactory,
PlainFileLogObserver,
ReprWrapper,
_extractStuffAndWhy,
plainJSONStdOutLogger,
)
except ImportError:
pytest.skip(allow_module_level=True)
def test_LoggerFactory():
"""
Logger factory ultimately returns twisted.python.log for output.
"""
from twisted.python import log
assert log is LoggerFactory()()
def _render_repr(_, __, event_dict):
return repr(event_dict)
def build_bl(logger=None, processors=None, context=None):
"""
Convenience function to build BoundLoggerses with sane defaults.
"""
return BoundLogger(
logger or ReturnLogger(),
processors or [KeyValueRenderer()],
context if context is not None else _CONFIG.default_context_class(),
)
class TestBoundLogger:
def test_msg(self):
"""
log.msg renders correctly.
"""
bl = build_bl()
assert "foo=42 event='event'" == bl.msg("event", foo=42)
def test_errVanilla(self):
"""
log.err renders correctly if no failure is attached.
"""
bl = build_bl()
assert "foo=42 event='event'" == bl.err("event", foo=42)
def test_errWithFailure(self):
"""
Failures are correctly injected into the log entries.
"""
bl = build_bl(
processors=[EventAdapter(dictRenderer=KeyValueRenderer())]
)
try:
raise ValueError
except ValueError:
# Use str() for comparison to avoid tricky
# deep-compares of Failures.
assert str(
(
(),
{
"_stuff": Failure(ValueError()),
"_why": "foo=42 event='event'",
},
)
) == str(bl.err("event", foo=42))
class TestExtractStuffAndWhy:
def test_extractFailsOnTwoFailures(self):
"""
Raise ValueError if both _stuff and event contain exceptions.
"""
with pytest.raises(
ValueError,
match="Both _stuff and event contain an Exception/Failure.",
):
_extractStuffAndWhy(
{
"_stuff": Failure(ValueError()),
"event": Failure(TypeError()),
}
)
def test_failsOnConflictingEventAnd_why(self):
"""
Raise ValueError if both _why and event are in the event_dict.
"""
with pytest.raises(
ValueError, match="Both `_why` and `event` supplied."
):
_extractStuffAndWhy({"_why": "foo", "event": "bar"})
def test_handlesFailures(self):
"""
Extracts failures and events.
"""
f = Failure(ValueError())
assert ({"value": f}, "foo", {}) == _extractStuffAndWhy(
{"_why": "foo", "_stuff": {"value": f}}
)
assert ({"value": f}, None, {}) == _extractStuffAndWhy(
{"_stuff": {"value": f}}
)
def test_handlesMissingFailure(self):
"""
Missing failures extract a None.
"""
assert (None, "foo", {}) == _extractStuffAndWhy({"event": "foo"})
class TestEventAdapter:
"""
Some tests here are redundant because they predate _extractStuffAndWhy.
"""
def test_EventAdapterFormatsLog(self):
"""
EventAdapter formats log entries correctly.
"""
la = EventAdapter(_render_repr)
assert "{'foo': 'bar'}" == la(None, "msg", {"foo": "bar"})
def test_transforms_whyIntoEvent(self):
"""
log.err(_stuff=exc, _why='foo') makes the output 'event="foo"'
"""
la = EventAdapter(_render_repr)
error = ValueError("test")
rv = la(None, "err", {"_stuff": error, "_why": "foo", "event": None})
assert () == rv[0]
assert isinstance(rv[1]["_stuff"], Failure)
assert error == rv[1]["_stuff"].value
assert "{'event': 'foo'}" == rv[1]["_why"]
def test_worksUsualCase(self):
"""
log.err(exc, _why='foo') makes the output 'event="foo"'
"""
la = EventAdapter(_render_repr)
error = ValueError("test")
rv = la(None, "err", {"event": error, "_why": "foo"})
assert () == rv[0]
assert isinstance(rv[1]["_stuff"], Failure)
assert error == rv[1]["_stuff"].value
assert "{'event': 'foo'}" == rv[1]["_why"]
def test_allKeywords(self):
"""
log.err(_stuff=exc, _why='event')
"""
la = EventAdapter(_render_repr)
error = ValueError("test")
rv = la(None, "err", {"_stuff": error, "_why": "foo"})
assert () == rv[0]
assert isinstance(rv[1]["_stuff"], Failure)
assert error == rv[1]["_stuff"].value
assert "{'event': 'foo'}" == rv[1]["_why"]
def test_noFailure(self):
"""
log.err('event')
"""
la = EventAdapter(_render_repr)
assert ((), {"_stuff": None, "_why": "{'event': 'someEvent'}"}) == la(
None, "err", {"event": "someEvent"}
)
def test_noFailureWithKeyword(self):
"""
log.err(_why='event')
"""
la = EventAdapter(_render_repr)
assert ((), {"_stuff": None, "_why": "{'event': 'someEvent'}"}) == la(
None, "err", {"_why": "someEvent"}
)
def test_catchesConflictingEventAnd_why(self):
"""
Passing both _why and event raises a ValueError.
"""
la = EventAdapter(_render_repr)
with pytest.raises(
ValueError, match="Both `_why` and `event` supplied."
):
la(None, "err", {"event": "someEvent", "_why": "someReason"})
@pytest.fixture
def jr():
"""
A plain Twisted JSONRenderer.
"""
return JSONRenderer()
class TestJSONRenderer:
def test_dumpsKWsAreHandedThrough(self, jr):
"""
JSONRenderer allows for setting arguments that are passed to
json.dumps(). Make sure they are passed.
"""
d = {"x": "foo"}
d.update(a="bar")
jr_sorted = JSONRenderer(sort_keys=True)
assert jr_sorted(None, "err", d) != jr(None, "err", d)
def test_handlesMissingFailure(self, jr):
"""
Calling err without an actual failure works and returns the event as
a string wrapped in ReprWrapper.
"""
assert (
ReprWrapper('{"event": "foo"}')
== jr(None, "err", {"event": "foo"})[0][0]
)
assert (
ReprWrapper('{"event": "foo"}')
== jr(None, "err", {"_why": "foo"})[0][0]
)
def test_msgWorksToo(self, jr):
"""
msg renders the event as a string and wraps it using ReprWrapper.
"""
assert (
ReprWrapper('{"event": "foo"}')
== jr(None, "msg", {"_why": "foo"})[0][0]
)
def test_handlesFailure(self, jr):
"""
JSONRenderer renders failures correctly.
"""
rv = jr(None, "err", {"event": Failure(ValueError())})[0][0].string
assert "Failure: builtins.ValueError" in rv
assert '"event": "error"' in rv
def test_setsStructLogField(self, jr):
"""
Formatted entries are marked so they can be identified without guessing
for example in JSONLogObserverWrapper.
"""
assert {"_structlog": True} == jr(None, "msg", {"_why": "foo"})[1]
class TestReprWrapper:
def test_repr(self):
"""
The repr of the wrapped string is the vanilla string without quotes.
"""
assert "foo" == repr(ReprWrapper("foo"))
class TestPlainFileLogObserver:
def test_isLogObserver(self, sio):
"""
PlainFileLogObserver is an ILogObserver.
"""
assert ILogObserver.providedBy(PlainFileLogObserver(sio))
def test_writesOnlyMessageWithLF(self, sio):
"""
PlainFileLogObserver writes only the message and a line feed.
"""
PlainFileLogObserver(sio)(
{"system": "some system", "message": ("hello",)}
)
assert "hello\n" == sio.getvalue()
class TestJSONObserverWrapper:
def test_IsAnObserver(self):
"""
JSONLogObserverWrapper is an ILogObserver.
"""
assert ILogObserver.implementedBy(JSONLogObserverWrapper)
def test_callsWrappedObserver(self):
"""
The wrapper always runs the wrapped observer in the end.
"""
o = call_recorder(lambda *a, **kw: None)
JSONLogObserverWrapper(o)({"message": ("hello",)})
assert 1 == len(o.calls)
def test_jsonifiesPlainLogEntries(self):
"""
Entries that aren't formatted by JSONRenderer are rendered as JSON
now.
"""
o = call_recorder(lambda *a, **kw: None)
JSONLogObserverWrapper(o)({"message": ("hello",), "system": "-"})
msg = json.loads(o.calls[0].args[0]["message"][0])
assert msg == {"event": "hello", "system": "-"}
def test_leavesStructLogAlone(self):
"""
Entries that are formatted by JSONRenderer are left alone.
"""
d = {"message": ("hello",), "_structlog": True}
def verify(eventDict):
assert d == eventDict
JSONLogObserverWrapper(verify)(d)
class TestPlainJSONStdOutLogger:
def test_isLogObserver(self):
"""
plainJSONStdOutLogger is an ILogObserver.
"""
assert ILogObserver.providedBy(plainJSONStdOutLogger())
|