1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700
|
# (C) Copyright 2005-2023 Enthought, Inc., Austin, TX
# All rights reserved.
#
# This software is provided without warranty under the terms of the BSD
# license included in LICENSE.txt and may be redistributed only under
# the conditions described in the aforementioned license. The license
# is also available online at http://www.enthought.com/licenses/BSD.txt
#
# Thanks for using Enthought open source!
""" General regression tests for a variety of bugs. """
import gc
import sys
import unittest
from traits.constants import DefaultValue
from traits.has_traits import (
HasStrictTraits,
HasTraits,
Property,
on_trait_change,
)
from traits.testing.optional_dependencies import numpy, requires_numpy
from traits.trait_errors import TraitError
from traits.trait_list_object import TraitListObject
from traits.trait_type import NoDefaultSpecified, TraitType
from traits.trait_types import (
Bool,
DelegatesTo,
Dict,
Either,
Enum,
Expression,
Instance,
Int,
List,
self,
Set,
Str,
Union,
)
if numpy is not None:
from traits.trait_numeric import Array
class Dummy(HasTraits):
x = Int(10)
def _create_subclass():
class Subclass(HasTraits):
pass
return Subclass
class Dummy2(HasTraits):
y = Int(20)
dummy = Instance(Dummy)
class DelegateMess(HasTraits):
dummy1 = Instance(Dummy, args=())
dummy2 = Instance(Dummy2)
y = DelegatesTo("dummy2")
handler_called = Bool(False)
def _dummy2_default(self):
# Create `self.dummy1`
return Dummy2(dummy=self.dummy1)
@on_trait_change("dummy1.x")
def _on_dummy1_x(self):
self.handler_called = True
def _init_trait_listeners(self):
""" Force the DelegatesTo listener to hook up first to exercise the
worst case.
"""
for name in ["y", "_on_dummy1_x"]:
data = self.__class__.__listener_traits__[name]
getattr(self, "_init_trait_%s_listener" % data[0])(name, *data)
class DelegateLeak(HasTraits):
visible = Property(Bool, depends_on="can_enable")
can_enable = DelegatesTo("flag", prefix="x")
flag = Instance(Dummy, kw={"x": 42})
class Presenter(HasTraits):
obj = Instance(Dummy)
y = Property(Int(), depends_on="obj.x")
def _get_y(self):
return self.obj.x
class ListUpdatesTest(HasTraits):
a = List
b = List
events_received = Int(0)
@on_trait_change("a[], b[]")
def _receive_events(self):
self.events_received += 1
class SimpleProperty(HasTraits):
x = Int
y = Property(Int, depends_on="x")
def _get_y(self):
return self.x + 1
class ExtendedListenerInList(HasTraits):
# Used in regression test for enthought/traits#403.
dummy = Instance(Dummy)
changed = Bool(False)
@on_trait_change(["dummy:x"])
def set_changed(self):
self.changed = True
class RaisingValidator(TraitType):
""" Trait type whose ``validate`` method raises an inappropriate exception.
Used for testing propagation of that exception.
"""
info_text = "bogus"
#: The default value type to use.
default_value_type = DefaultValue.constant
#: The default value for the trait:
default_value = None
def validate(self, object, name, value):
raise ZeroDivisionError("Just testing")
class Wrapper(HasTraits):
value = Str()
class WrapperTrait(TraitType):
def __init__(self, default_value="", **metadata):
self.default_value_type, default_value = self._get_default_value(
self.validate(None, None, default_value)
)
super().__init__(default_value, **metadata)
def validate(self, object, name, value):
if isinstance(value, str):
return Wrapper(value=value)
elif isinstance(value, Wrapper):
return value
else:
self.error(None, None, value)
def _get_default_value(self, value):
return (
DefaultValue.callable_and_args,
(Wrapper, (), {"value": value.value}),
)
class CloneWrapperTrait(TraitType):
def __init__(self, default_value="", **metadata):
self.default_value_type, default_value = self._get_default_value(
self.validate(None, None, default_value)
)
super().__init__(default_value, **metadata)
def validate(self, object, name, value):
if isinstance(value, str):
return Wrapper(value=value)
elif isinstance(value, Wrapper):
return value
else:
self.error(None, None, value)
def _get_default_value(self, value):
return (
DefaultValue.callable_and_args,
(Wrapper, (), {"value": value.value}),
)
def clone(self, default_value=NoDefaultSpecified, **metadata):
new = super().clone(default_value, **metadata)
if default_value is not NoDefaultSpecified:
default_value = new.validate(None, None, default_value)
type, value = new._get_default_value(default_value)
new.default_value_type = type
new.default_value = value
return new
class DisallowDefaultValue(TraitType):
default_value_type = DefaultValue.disallow
class SubclassDefaultsSuper(HasTraits):
a_str = Str()
an_expr = Expression("[]")
a_list = List()
an_instance = Instance(Wrapper)
a_wrapper_1 = WrapperTrait("bar")
a_wrapper_2 = WrapperTrait()
clone_wrapper_1 = CloneWrapperTrait("bar")
clone_wrapper_2 = CloneWrapperTrait()
disallow_default = DisallowDefaultValue()
self_trait = self()
class SubclassDefaultsSub(SubclassDefaultsSuper):
a_str = "foo"
an_expr = Expression("[1, 2, 3]")
a_list = [1, 2, 3]
an_instance = Wrapper()
a_wrapper_1 = "foo"
a_wrapper_2 = Wrapper(value="foo")
clone_wrapper_1 = "foo"
clone_wrapper_2 = Wrapper(value="foo")
# self effectively becomes a This() trait if default is overriden
self_trait = SubclassDefaultsSuper()
class TestRegression(unittest.TestCase):
def test_default_value_for_no_cache(self):
""" Make sure that CTrait.default_value_for() does not cache the
result.
"""
dummy = Dummy()
# Nothing in the __dict__ yet.
self.assertEqual(dummy.__dict__, {})
ctrait = dummy.trait("x")
default = ctrait.default_value_for(dummy, "x")
self.assertEqual(default, 10)
self.assertEqual(dummy.__dict__, {})
def test_default_value_for_property(self):
""" Don't segfault when calling default_value_for on a Property trait.
"""
# Regression test for enthought/traits#336.
y_trait = SimpleProperty.class_traits()["y"]
simple_property = SimpleProperty()
self.assertIsNone(y_trait.default_value_for(simple_property, "y"))
def test_subclasses_weakref(self):
""" Make sure that dynamically created subclasses are not held
strongly by HasTraits.
"""
previous_subclasses = HasTraits.__subclasses__()
_create_subclass()
_create_subclass()
_create_subclass()
_create_subclass()
gc.collect()
# In Python < 3.6, we can end up seeing the same subclasses but in
# a different order, so use assertCountEqual rather than assertEqual.
# Ref: enthought/traits#1282.
self.assertCountEqual(previous_subclasses, HasTraits.__subclasses__())
def test_leaked_property_tuple(self):
""" the property ctrait constructor shouldn't leak a tuple. """
class A(HasTraits):
prop = Property()
a = A()
self.assertEqual(sys.getrefcount(a.trait("prop").property_fields), 1)
def test_delegate_initializer(self):
mess = DelegateMess()
self.assertFalse(mess.handler_called)
mess.dummy1.x = 20
self.assertTrue(mess.handler_called)
def test_no_leaking_notifiers(self):
""" Extended trait change notifications should not leaf
TraitChangeNotifyWrappers.
"""
dummy = Dummy()
ctrait = dummy._trait("x", 2)
self.assertEqual(len(ctrait._notifiers(True)), 0)
presenter = Presenter(obj=dummy)
self.assertEqual(len(ctrait._notifiers(True)), 1)
del presenter
self.assertEqual(len(ctrait._notifiers(True)), 0)
def test_init_list_depends(self):
""" Using two lists with bracket notation in extended name notation
should not raise an error.
"""
list_test = ListUpdatesTest()
# Updates to list items and the list trait itself should be counted.
list_test.a.append(0)
list_test.b = [1, 2, 3]
list_test.b[0] = 0
self.assertEqual(list_test.events_received, 3)
def test_has_traits_notifiers_refleak(self):
# Regression test for issue described in
# https://github.com/enthought/traits/pull/248
warmup = 5
cycles = 10
counts = []
def handler():
pass
def f():
obj = HasTraits()
obj.on_trait_change(handler)
# Warmup.
for _ in range(cycles):
f()
gc.collect()
counts.append(len(gc.get_objects()))
# All the counts beyond the warmup period should be the same.
self.assertEqual(counts[warmup:-1], counts[warmup + 1:])
def test_delegation_refleak(self):
warmup = 5
cycles = 10
counts = []
for _ in range(cycles):
DelegateLeak()
gc.collect()
counts.append(len(gc.get_objects()))
# All the counts should be the same.
self.assertEqual(counts[warmup:-1], counts[warmup + 1:])
@requires_numpy
def test_exception_from_numpy_comparison_ignored(self):
# Regression test for enthought/traits#376.
class MultiArrayDataSource(HasTraits):
data = Either(None, Array)
b = MultiArrayDataSource(data=numpy.array([1, 2])) # noqa: F841
# The following line was necessary to trigger the bug: the previous
# line set a Python exception, but didn't return the correct result to
# the CPython interpreter, so the exception wasn't triggered until
# later.
round(3.14159, 2)
def test_on_trait_change_with_list_of_extended_names(self):
# Regression test for enthought/traits#403
dummy = Dummy(x=10)
model = ExtendedListenerInList(dummy=dummy)
self.assertFalse(model.changed)
dummy.x = 11
self.assertTrue(model.changed)
def test_set_disallowed_exception(self):
# Regression test for enthought/traits#415
class StrictDummy(HasStrictTraits):
foo = Int
with self.assertRaises(TraitError):
StrictDummy(forbidden=53)
# This is the case that used to fail on Python 2.
with self.assertRaises(TraitError):
StrictDummy(**{"forbidden": 53})
a = StrictDummy()
with self.assertRaises(TraitError):
setattr(a, "forbidden", 53)
def test_validate_exception_propagates(self):
class A(HasTraits):
foo = RaisingValidator()
bar = Either(None, RaisingValidator())
a = A()
with self.assertRaises(ZeroDivisionError):
a.foo = "foo"
with self.assertRaises(ZeroDivisionError):
a.bar = "foo"
def test_clone_list_of_enum_trait(self):
# Regression test for enthought/traits#1622.
class Order(HasTraits):
menu = List(Str)
selection = List(Enum(values="menu"))
order = Order(menu=["fish"], selection=["fish"])
clone = order.clone_traits()
self.assertEqual(clone.selection, ["fish"])
order.selection.append('fish')
self.assertEqual(clone.selection, ['fish'])
with self.assertRaises(TraitError):
clone.selection.append("bouillabaisse")
def test_clone_list_trait_default(self):
# Regression test for #1630
t = List()
new_default = [1, 2, 3]
t_clone = t(new_default)
default_value_kind, default_value = t_clone.default_value()
self.assertEqual(default_value_kind, DefaultValue.trait_list_object)
self.assertEqual(default_value, new_default)
self.assertIsNot(default_value, new_default)
def test_clone_dict_trait_default(self):
# Regression test for #1630
t = Dict()
new_default = {'a': 1, 'b': 2, 'c': 3}
t_clone = t(new_default)
default_value_kind, default_value = t_clone.default_value()
self.assertEqual(default_value_kind, DefaultValue.trait_dict_object)
self.assertEqual(default_value, new_default)
self.assertIsNot(default_value, new_default)
def test_clone_set_trait_default(self):
# Regression test for #1630
t = Set()
new_default = {1, 2, 3}
t_clone = t(new_default)
default_value_kind, default_value = t_clone.default_value()
self.assertEqual(default_value_kind, DefaultValue.trait_set_object)
self.assertEqual(default_value, new_default)
self.assertIsNot(default_value, new_default)
def test_clone_disallow_default_value(self):
t = DisallowDefaultValue()
with self.assertRaises(TraitError):
t("default value")
def test_clone_setattr_original_value(self):
t = Expression()
t_clone = t("3")
default_value_kind, default_value = t_clone.default_value()
self.assertEqual(default_value_kind, DefaultValue.constant)
self.assertEqual(default_value, "3")
def test_subclass_default_constant(self):
# Regression test for #1630 and similar issues
s1 = SubclassDefaultsSub()
s2 = SubclassDefaultsSub()
# existing behaviour that should not be affected
self.assertEqual(s1.a_str, "foo")
self.assertEqual(s1.an_expr, "[1, 2, 3]")
self.assertEqual(s2.an_expr, "[1, 2, 3]")
def test_subclass_default_callable_and_args(self):
# Regression test for #1630 and similar issues
s1 = SubclassDefaultsSub()
s2 = SubclassDefaultsSub()
# the following is a bit questionable, but is existing behaviour
self.assertIsInstance(s1.an_instance, Wrapper)
self.assertIsInstance(s2.an_instance, Wrapper)
self.assertIs(s1.an_instance, s2.an_instance)
self.assertIsInstance(s1.a_wrapper_1, Wrapper)
self.assertIsInstance(s2.a_wrapper_1, Wrapper)
self.assertIs(s1.a_wrapper_1, s2.a_wrapper_1)
self.assertIsInstance(s1.a_wrapper_2, Wrapper)
self.assertIsInstance(s2.a_wrapper_2, Wrapper)
self.assertIs(s1.a_wrapper_2, s2.a_wrapper_2)
def test_subclass_default_object_kind(self):
# Regression test for #1630 and similar issues
s1 = SubclassDefaultsSub()
s2 = SubclassDefaultsSub()
# the following is a bit odd, but is existing behaviour
self.assertIsInstance(s1.self_trait, SubclassDefaultsSuper)
self.assertIsInstance(s2.self_trait, SubclassDefaultsSuper)
self.assertIs(s1.self_trait, s2.self_trait)
self.assertIsNot(s1, s1.self_trait)
def test_subclass_default_trait_list_object(self):
# Regression test for #1630 and similar issues
s1 = SubclassDefaultsSub()
s2 = SubclassDefaultsSub()
# behaviour which is broken in #1630
# things which need to be copied:
self.assertEqual(s1.a_list, [1, 2, 3])
self.assertEqual(s2.a_list, [1, 2, 3])
self.assertIsNot(s1.a_list, s2.a_list)
self.assertIsInstance(s1.a_list, TraitListObject)
def test_subclass_callable_and_args_overrides_clone(self):
# Regression test for #1630 and similar issues
s1 = SubclassDefaultsSub()
s2 = SubclassDefaultsSub()
# callable_with_args case - handle overriding clone
self.assertIsInstance(s1.clone_wrapper_1, Wrapper)
self.assertIsInstance(s2.clone_wrapper_1, Wrapper)
self.assertIsNot(s1.clone_wrapper_1, s2.clone_wrapper_1)
self.assertIsInstance(s1.clone_wrapper_2, Wrapper)
self.assertIsInstance(s2.clone_wrapper_2, Wrapper)
self.assertIsNot(s1.clone_wrapper_2, s2.clone_wrapper_2)
def test_subclass_disallow_default_value(self):
with self.assertRaises(TraitError):
class OverrideDisallow(SubclassDefaultsSuper):
disallow_default = "a default value"
class NestedContainerClass(HasTraits):
# Used in regression test for changes to nested containers
# Nested list
list_of_list = List(List)
# enthought/traits#281
dict_of_list = Dict(Str, List(Str))
# Similar to enthought/traits#281
dict_of_union_none_or_list = Dict(Str, Union(List(), None))
# Nested dict
# enthought/traits#25
list_of_dict = List(Dict)
dict_of_dict = Dict(Str, Dict)
dict_of_union_none_or_dict = Dict(Str, Union(Dict(), None))
# Nested set
list_of_set = List(Set)
dict_of_set = Dict(Str, Set)
dict_of_union_none_or_set = Dict(Str, Union(Set(), None))
class TestRegressionNestedContainerEvent(unittest.TestCase):
""" Regression tests for enthought/traits#281 and enthought/traits#25
"""
def setUp(self):
self.events = []
def change_handler(*args):
self.events.append(args)
self.change_handler = change_handler
def test_modify_list_in_dict(self):
# Regression test for enthought/traits#281
instance = NestedContainerClass(dict_of_list={"name": []})
try:
instance.dict_of_list["name"].append("word")
except Exception:
self.fail("Mutating a nested list should not fail.")
def test_modify_list_in_dict_wrapped_in_union(self):
instance = NestedContainerClass(
dict_of_union_none_or_list={"name": []},
)
try:
instance.dict_of_union_none_or_list["name"].append("word")
except Exception:
self.fail("Mutating a nested list should not fail.")
def test_modify_list_in_list_no_events(self):
instance = NestedContainerClass(list_of_list=[[]])
instance.on_trait_change(self.change_handler, "list_of_list_items")
instance.list_of_list[0].append(1)
self.assertEqual(len(self.events), 0, "Expected no events.")
def test_modify_dict_in_list(self):
instance = NestedContainerClass(list_of_dict=[{}])
try:
instance.list_of_dict[0]["key"] = 1
except Exception:
self.fail("Mutating a nested dict should not fail.")
def test_modify_dict_in_list_with_new_value(self):
instance = NestedContainerClass(list_of_dict=[{}])
instance.list_of_dict.append(dict())
try:
instance.list_of_dict[-1]["key"] = 1
except Exception:
self.fail("Mutating a nested dict should not fail.")
def test_modify_dict_in_dict_no_events(self):
# Related to enthought/traits#25
instance = NestedContainerClass(dict_of_dict={"1": {"2": 2}})
instance.on_trait_change(self.change_handler, "dict_of_dict_items")
instance.dict_of_dict["1"]["3"] = 3
self.assertEqual(len(self.events), 0, "Expected no events.")
def test_modify_dict_in_union_in_dict_no_events(self):
instance = NestedContainerClass(
dict_of_union_none_or_dict={"1": {"2": 2}},
)
instance.on_trait_change(
self.change_handler, "dict_of_union_none_or_dict_items")
instance.dict_of_union_none_or_dict["1"]["3"] = 3
self.assertEqual(len(self.events), 0, "Expected no events.")
def test_modify_set_in_list(self):
instance = NestedContainerClass(list_of_set=[set()])
try:
instance.list_of_set[0].add(1)
except Exception:
self.fail("Mutating a nested set should not fail.")
def test_modify_set_in_list_with_new_value(self):
instance = NestedContainerClass(list_of_set=[])
instance.list_of_set.append(set())
try:
instance.list_of_set[0].add(1)
except Exception:
self.fail("Mutating a nested set should not fail.")
def test_modify_set_in_dict(self):
instance = NestedContainerClass(dict_of_set={"1": set()})
try:
instance.dict_of_set["1"].add(1)
except Exception:
self.fail("Mutating a nested set should not fail.")
def test_modify_set_in_union_in_dict(self):
instance = NestedContainerClass(
dict_of_union_none_or_set={"1": set()}
)
try:
instance.dict_of_union_none_or_set["1"].add(1)
except Exception:
self.fail("Mutating a nested set should not fail.")
def test_modify_nested_set_no_events(self):
instance = NestedContainerClass(list_of_set=[set()])
instance.on_trait_change(
self.change_handler, "list_of_set_items")
instance.list_of_set[0].add(1)
self.assertEqual(len(self.events), 0, "Expected no events.")
|