1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474
|
# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.
import argparse
import ast
import os
import sys
from typing import Any, Dict, List, Set, Tuple # type: ignore[attr-defined]
from tools.flight_recorder.components.fr_logger import FlightRecorderLogger
from tools.flight_recorder.components.types import (
Collective,
Database,
EntryState,
Group,
MatchState,
Membership,
NCCLCall,
Op,
Traceback,
)
from tools.flight_recorder.components.utils import (
align_trace_from_beginning,
check_no_missing_dump_files,
check_size_alltoall,
check_version,
find_coalesced_group,
format_frames,
get_version_detail,
just_print_entries,
match_coalesced_groups,
match_one_event,
)
# Set up logging
logger: FlightRecorderLogger = FlightRecorderLogger()
try:
from tabulate import tabulate
except ModuleNotFoundError:
logger.warning("tabulate is not installed. Proceeding without it.")
# Define a no-op tabulate function
def tabulate(data: Any, headers: Any = None) -> Any: # type: ignore[misc]
return data
"""
Flat DB builder
"""
def build_groups_memberships(
pg_config: Any,
) -> Tuple[
List[Group],
Dict[Any, Group],
List[Membership],
Dict[str, Set[Any]],
Dict[Tuple[str, int], str],
]:
"""
pg_config: {
global_rank: {
(pg_guid, desc, ranks)
}
}
`pg_guid` is a system generated id, but depending on the mode of PG creation it could be a globally incrementing int
or a hash of the ranks. See `_process_group_name` in distributed_c10d.py.
`desc` is provided by the user (optionally) and should be 'meaningful' (e.g. TP/PP/DP group)
`ranks` is a list of the 'global ranks' that are members of the PG.
(pg_guid, desc, ranks) tuples are appended lazily to the flight buffer when `getNCCLComm` is called on a PG and
the `enabled_` flag is true for that PG.
- the order of calling (init_process_group, new_group, etc) does not affect the order of the tuples in the list
Returns:
`groups`: a groups table where each row is a Group namedtuple.
`_groups`: a dict that is indexed by pg_guid with Group namedtuple as value.
`memberships`: a membership table where each row is a Membership namedtuple.
`_memberships`: a dict that is indexed by pg_guid with set of ranks (int) as value.
`_pg_guids`: a dict that is indexed by (pg_uid, global_rank) with pg_guid as value.
"""
# flat lists for return
groups = []
memberships = []
# dicts for faster cross-rank validation
_groups = {}
_memberships = {}
_pg_guids = {}
for global_rank in pg_config:
for pg_uid in pg_config[global_rank]:
desc = pg_config[global_rank][pg_uid]["desc"]
ranks = ast.literal_eval(pg_config[global_rank][pg_uid]["ranks"])
# With the adoption of the split_group API, we can have multiple PGs with the same pg_guid (PG Name)
# So we need to add the hash of all its ranks within the PG as well.
# Also guid must be a string because `_process_group_name` returns a string.
pg_guid = pg_uid + str(hash(frozenset(ranks)))
_pg_guids[(pg_uid, global_rank)] = pg_guid
if isinstance(ranks, str):
# TODO Bug in FR data format? ranks is '[0, 1,...]'
ranks = eval(ranks)
if pg_guid not in _groups:
groups.append(Group(id=pg_guid, desc=desc, size=len(ranks)))
for rank in ranks:
memberships.append(Membership(group_id=pg_guid, global_rank=rank))
_groups[pg_guid] = groups[-1]
_memberships[pg_guid] = set(ranks)
else:
# validation across ranks
assert (
_groups[pg_guid].desc == desc
), f"mismatch in desc {_groups[pg_guid].desc} vs {desc} for group {pg_guid}"
assert (
_memberships[pg_guid] == set(ranks)
), f"mismatch in membership for group {pg_guid} {_memberships[pg_guid]} vs {set(ranks)}"
return groups, _groups, memberships, _memberships, _pg_guids
def build_collectives(
all_entries: Dict[int, List[Dict[str, Any]]],
_groups: Dict[str, Group],
_memberships: Dict[str, Set[Any]],
_pg_guids: Dict[Tuple[str, int], str],
version: str,
) -> Tuple[List[Traceback], List[Collective], List[NCCLCall]]:
"""
groups, memberships are the non-flat dicts that are indexable
all_entries is a raw dict from the original dumps:
all_entries: {
global_rank: [
{
record_id: ordered id of the event in the trace buffer
pg_id: ProcessGroupNCCL::uid_
*note: `pg_id` corresponds to nothing in groups table
process_group: (pg_name, desc)
*note: `pg_name`, `desc` corresponds to `pg_id`, `desc` in groups table
collective_seq_id: ordered id for collective operations and coalesced group operations
p2p_seq_id: ordered id for point-to-point operations
op_id: ordered id including individual ops inside coalescing group
profiling_name: descriptive name of the operation
'time_created_ns',
'input_sizes',
'output_sizes',
'state',
'time_discovered_started_ns',
'time_discovered_completed_ns',
'retired',
'frames',
}
]
}
"""
major_v, minor_v = get_version_detail(version)
tracebacks: List[Traceback] = []
collectives: List[Collective] = []
nccl_calls: List[NCCLCall] = []
# once we find one mismatch, we stop pairing up collectives since the pairing is possibly incorrect
# instead, just record the remaining ops as NCCLCalls
mismatch = {_groups[g].id: 0 for g in _groups}
MISMATCH_TAIL = 10
# For best effort partial analysis.
dumps_ranks = {int(key) for key in all_entries.keys()}
"""
- it doesn't matter what order I put collectives/ncclops into their table. we can later on re-sort it by start time
- there could be multiple options for the "first" collective to pair up (rank 0,1 might do a bcast while rank 2,3 do a bcast)
- within a group, the first collective must be the same on all ranks in the group, then it can be marked as a
collective and removed
"""
while all_entries:
# we greedily match collectives, starting arbitrarily with the trace from the first rank
# later, if we exhaust the first rank, we continue with the next 'first rank'
rank_iter = iter(all_entries)
first_rank = next(rank_iter)
other_ranks = list(rank_iter)
if len(all_entries[first_rank]) == 0:
all_entries.pop(first_rank)
continue
# lets match the first collective! we need to know which ranks are involved, and ensure that this same
# collective is also the first one on those ranks within that group
entries = all_entries[first_rank]
desc = entries[0]["process_group"][1]
# For db build and logs printing, we want to use the original pg_name, not the hash one.
original_pg_name = entries[0]["process_group"][0]
pg_name = _pg_guids[(original_pg_name, first_rank)]
expected_ranks = set(_memberships[pg_name])
entry_state = EntryState(entries[0], expected_ranks)
candidate_ranks = {first_rank}
candidate_idx = {}
found_ranks = set()
found_idx = {}
errors = set()
if find_coalesced_group(pg_name, entries, _pg_guids, first_rank):
expected_ranks.add(first_rank)
done_ranks = set()
all_coalesced_entries = {}
while expected_ranks:
curr = expected_ranks.pop()
done_ranks.add(curr)
grp = (
find_coalesced_group(pg_name, all_entries[curr], _pg_guids, curr) # type: ignore[index]
if curr in all_entries # type: ignore[comparison-overlap]
else []
)
all_coalesced_entries[curr] = grp
for _, entry in grp:
op = Op(entry, _memberships, pg_name)
peer = None
if op.type == "send":
assert op._src_g == curr, (op._src_g, curr)
peer = op._dst_g
elif op.type == "recv":
assert op._dst_g == curr, (op._dst_g, curr)
peer = op._src_g
if peer and peer not in done_ranks:
expected_ranks.add(peer)
match = match_coalesced_groups(
all_coalesced_entries,
group_size=_groups[pg_name].size,
groups=_groups,
memberships=_memberships,
_pg_guids=_pg_guids,
)
if match and mismatch[pg_name] == 0:
collectives.append(entry_state.to_collective(len(collectives)))
else:
mismatch[pg_name] += 1
for r in all_coalesced_entries:
idx_map = {r: i for i, _ in reversed(all_coalesced_entries[r])} # noqa: B035
nccl_calls.extend(
reversed(
entry_state.to_nccl_call(
all_entries,
idx_map,
len(nccl_calls),
collectives[-1].id if match else None,
)
)
)
else:
has_undecided_case = False
for o in expected_ranks.intersection(set(other_ranks)):
for i, e in enumerate(all_entries[o]): # type: ignore[index]
# step over ops from other PGs
# only check match state when seq_id matches
if (
_pg_guids[(e["process_group"][0], o)] == pg_name
and e["process_group"][1] == desc
and e["collective_seq_id"] == entry_state.collective_seq_id
):
match_state = match_one_event(
entries[0], e, _memberships, pg_name
)
if (
match_state
in [MatchState.FULLY_MATCHED, MatchState.UNDECIDED]
and mismatch[pg_name] == 0
):
found_ranks.add(o)
found_idx[o] = i
has_undecided_case = match_state == MatchState.UNDECIDED
else:
candidate_ranks.add(o)
candidate_idx[o] = i
if match_state not in [
MatchState.FULLY_MATCHED,
MatchState.UNDECIDED,
]:
# Here we assume the current rank is not the source of the error.
# But it's possible that the current rank is the culprit, then users will
# see lots of normal ranks reported as culprit.
# TODO: we need to figure out a better way to handle the case mentioned above.
errors.add((o, match_state))
break
# case one: not every rank join the collective or in the flight recorder.
if (candidate_ranks | found_ranks) != expected_ranks and expected_ranks - (
candidate_ranks | found_ranks
) <= dumps_ranks:
mismatch[pg_name] += 1
logger_msg = "Not all ranks joining collective, sequence number: %s"
missing_ranks = expected_ranks - (candidate_ranks | found_ranks)
entry_state.log(
logger, logger_msg, format_frames, missing_ranks=missing_ranks
)
candidate_ranks.update(found_ranks)
candidate_idx.update(found_idx)
found_idx.clear()
found_ranks.clear()
elif len(candidate_ranks) == 1 and dumps_ranks == expected_ranks:
# case two: alltoall or alltoall_base case.
if has_undecided_case:
alltoall_cases = [entries[0]] + [
all_entries[o][found_idx[o]] for o in found_ranks
]
fail_check, total_input_numel, total_output_numel = (
check_size_alltoall(alltoall_cases)
)
if major_v <= 2 and minor_v <= 3:
# We don't log the input/output sizes for alltoall before v2.4,
# so we don't consider the size mismatch as an error for now.
fail_check = False
if fail_check:
# When we see errors in all_to_all, it's hard to tell which rank is the source of the error.
mismatch[pg_name] += 1
logger_msg = "Input/output mismatch in the collective sequence number: %s"
entry_state.log(
logger,
logger_msg,
format_frames,
total_numel=(total_input_numel, total_output_numel),
)
candidate_ranks.update(found_ranks)
candidate_idx.update(found_idx)
found_idx.clear()
found_ranks.clear()
errors.add((first_rank, MatchState.SIZE_OR_SYNTAX_MISMATCH))
else:
found_ranks.update(candidate_ranks)
found_idx.update(candidate_idx)
candidate_idx.clear()
candidate_ranks.clear()
# case three: all joined and everything matches on all ranks.
else:
found_ranks.update(candidate_ranks)
found_idx.update(candidate_idx)
candidate_idx.clear()
candidate_ranks.clear()
# case four: mismatch cases due to not same type, size mismatch or state mismatch.
elif len(errors) > 0:
mismatch[pg_name] += 1
logger_msg = "Collective sequence number: %s has errors"
entry_state.log(logger, logger_msg, format_frames, errors=errors)
candidate_ranks.update(found_ranks)
candidate_idx.update(found_idx)
found_idx.clear()
found_ranks.clear()
# partial analysis case when we cannot decide what's wrong with this collective entry.
else:
candidate_ranks.update(found_ranks)
candidate_idx.update(found_idx)
found_idx.clear()
found_ranks.clear()
mismatch[pg_name] += 1
if expected_ranks - dumps_ranks:
logger.info(
"We cannot decide what's wrong with this collective entry "
"because we missed FR dumps from ranks (%s) so we don't have enough "
"information. If you want to debug further use -j to dump all raw trace",
str(expected_ranks - dumps_ranks),
)
else:
logger.info(
"No errors found for this collective entry, There could be some "
"other reasons why we see collective timeout."
)
# at this point there are 3 possibilities
# 1. we found a match on all the ranks that are members of the group
# -> we create a Collective and remove the individual entries from their original lists
if found_ranks == expected_ranks and mismatch[pg_name] == 0:
collectives.append(entry_state.to_collective(len(collectives)))
idx_map = {
r: found_idx[r] if r != first_rank else 0 for r in found_ranks
}
nccl_calls.extend(
entry_state.to_nccl_call(
all_entries, idx_map, len(nccl_calls), collectives[-1].id
)
)
# 2. we found a partial match but some ranks are missing
# 3. we found no match
# -> since its not a complete collective, no entry goes into collectives but we still record a nccl call
# TODO should there be a way to mark 'mismatches'?
else:
logger.debug("appending a non-matching collective")
idx_map = {
r: candidate_idx[r] if r != first_rank else 0
for r in candidate_ranks
}
collectives.append(
entry_state.to_collective(
len(collectives),
errors=errors,
idx_map=idx_map,
all_entries=all_entries,
)
)
nccl_calls.extend(
entry_state.to_nccl_call(
all_entries, idx_map, len(nccl_calls), None
)
)
if mismatch[pg_name] > MISMATCH_TAIL:
logger.error(
"Too many mismatches for process_group %s: %s aborting", pg_name, desc
)
break
return tracebacks, collectives, nccl_calls
def build_db(
details: Dict[str, Dict[str, Any]], args: argparse.Namespace, version: str
) -> Database:
if args.verbose:
os.environ["FR_TRACE_VERBOSE_OUTPUT"] = "1"
# temporary state used for building database
entries = {}
pg_config = {}
version_by_ranks = {}
for dump in details.values():
rank = dump["rank"]
entries[rank] = dump["entries"]
version_by_ranks[rank] = dump["version"]
pg_config[rank] = dump["pg_config"]
# Ensure version is consistent across all ranks.
check_version(version_by_ranks, version)
entries = align_trace_from_beginning(entries)
# flattened database
groups, _groups, memberships, _memberships, _pg_guids = build_groups_memberships(
pg_config
)
logger.debug("built groups, memberships")
if not args.allow_incomplete_ranks:
check_no_missing_dump_files(entries, memberships)
if args.just_print_entries:
just_print_entries(entries, _groups, _memberships, _pg_guids, args)
sys.exit(0)
tracebacks, collectives, nccl_calls = build_collectives(
entries, _groups, _memberships, _pg_guids, version
)
logger.debug("built collectives, nccl_calls")
if args.verbose:
logger.debug("Groups")
logger.debug(tabulate(groups, headers=Group._fields))
logger.debug("Memberships")
logger.debug(tabulate(memberships, headers=Membership._fields))
logger.debug("Collectives")
logger.debug(tabulate(collectives, headers=Collective._fields))
logger.debug("NCCLCalls")
logger.debug(tabulate(nccl_calls, headers=NCCLCall._fields))
db = Database(
tracebacks=tracebacks,
collectives=collectives,
ncclcalls=nccl_calls,
groups=groups,
memberships=memberships,
)
return db
|