1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472
|
# Owner(s): ["oncall: r2p"]
# Copyright (c) Facebook, Inc. and its affiliates.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.
import copy
import os
import pickle
import socket
import threading
import time
from abc import ABC, abstractmethod
from base64 import b64encode
from datetime import datetime, timedelta
from typing import Callable, Optional, Tuple, cast
from unittest import TestCase
from unittest.mock import MagicMock, Mock, call, patch
from torch.distributed import Store
from torch.distributed.elastic.rendezvous import (
RendezvousClosedError,
RendezvousError,
RendezvousParameters,
RendezvousStateError,
RendezvousTimeoutError,
)
from torch.distributed.elastic.rendezvous.dynamic_rendezvous import (
DynamicRendezvousHandler,
RendezvousBackend,
RendezvousSettings,
RendezvousTimeout,
Token,
_Action,
_BackendRendezvousStateHolder,
_DistributedRendezvousOpExecutor,
_NodeDesc,
_NodeDescGenerator,
_RendezvousCloseOp,
_RendezvousContext,
_RendezvousExitOp,
_RendezvousJoinOp,
_RendezvousKeepAliveOp,
_RendezvousState,
_RendezvousStateHolder,
create_handler,
)
class CustomAssertMixin:
assertDictEqual: Callable
def assert_state_equal(self, actual: _RendezvousState, expected: _RendezvousState) -> None:
self.assertDictEqual(vars(actual), vars(expected))
def assert_state_empty(self, actual: _RendezvousState) -> None:
self.assertDictEqual(vars(actual), vars(_RendezvousState()))
class RendezvousTimeoutTest(TestCase):
def test_init_initializes_timeout(self) -> None:
timeout = RendezvousTimeout(
timedelta(seconds=50),
timedelta(seconds=60),
timedelta(seconds=70),
timedelta(seconds=80),
)
self.assertEqual(timeout.join, timedelta(seconds=50))
self.assertEqual(timeout.last_call, timedelta(seconds=60))
self.assertEqual(timeout.close, timedelta(seconds=70))
self.assertEqual(timeout.heartbeat, timedelta(seconds=80))
def test_init_initializes_timeout_if_no_timeout_is_specified(self) -> None:
timeout = RendezvousTimeout()
self.assertEqual(timeout.join, timedelta(seconds=600))
self.assertEqual(timeout.last_call, timedelta(seconds=30))
self.assertEqual(timeout.close, timedelta(seconds=30))
self.assertEqual(timeout.heartbeat, timedelta(seconds=5))
def test_init_raises_error_if_timeout_is_not_positive(self) -> None:
join_timeouts = [timedelta(seconds=0), timedelta(seconds=-1)]
for join_timeout in join_timeouts:
with self.subTest(join_timeout=join_timeout):
with self.assertRaisesRegex(
ValueError, rf"^The join timeout \({join_timeout}\) must be positive.$"
):
timeout = RendezvousTimeout(join_timeout)
class NodeDescTest(TestCase):
def test_repr(self) -> None:
desc = _NodeDesc("dummy_fqdn", 3, 5)
self.assertEqual(repr(desc), "dummy_fqdn_3_5")
def test_hash(self) -> None:
desc1 = _NodeDesc("dummy_fqdn", 2, 4)
desc2 = _NodeDesc("dummy_fqdn", 3, 5)
descs = {desc1, desc2}
self.assertIn(desc1, descs)
self.assertIn(desc2, descs)
class NodeDescGeneratorTest(TestCase):
def test_generate(self) -> None:
desc_generator = _NodeDescGenerator()
fqdn = socket.getfqdn()
pid = os.getpid()
for local_id in range(4):
with self.subTest(fqdn=fqdn, pid=pid, local_id=local_id):
desc = desc_generator.generate()
self.assertEqual(repr(desc), f"{fqdn}_{pid}_{local_id}")
class RendezvousStateTest(TestCase):
def test_encoded_size_is_within_expected_limit(self) -> None:
state = _RendezvousState()
state.round = 1
state.complete = True
state.deadline = datetime.utcnow()
state.closed = True
# fmt: off
expected_max_sizes = (
( 5, 2 * (2 ** 10),), # 10 machines <= 2KB # noqa: E201, E241, E262
( 50, 16 * (2 ** 10),), # 100 machines <= 16KB # noqa: E201, E241, E262
( 500, 160 * (2 ** 10),), # 1000 machines <= 160KB # noqa: E201, E241, E262
(5000, 1600 * (2 ** 10),), # 10000 machines <= 1.6MB # noqa: E201, E241, E262
)
# fmt: on
for num_nodes, max_byte_size in expected_max_sizes:
with self.subTest(num_nodes=num_nodes, max_byte_size=max_byte_size):
for i in range(num_nodes):
node_running = _NodeDesc(f"dummy{i}.dummy1-dummy1-dummy1-dummy1.com", 12345, i)
node_waiting = _NodeDesc(f"dummy{i}.dummy2-dummy2-dummy2-dummy2.com", 67890, i)
state.participants[node_running] = i
state.wait_list.add(node_waiting)
state.last_heartbeats[node_running] = datetime.utcnow()
state.last_heartbeats[node_waiting] = datetime.utcnow()
bits = pickle.dumps(state)
base64_bits = b64encode(bits)
self.assertLessEqual(len(base64_bits), max_byte_size)
class FakeRendezvousBackend(RendezvousBackend):
_state: Optional[bytes]
_token: int
def __init__(self) -> None:
self._state = None
self._token = 0
@property
def name(self) -> str:
return "fake_backend"
def get_state(self) -> Optional[Tuple[bytes, Token]]:
if self._token == 0:
return None
return self._state, self._token # type: ignore[return-value]
def set_state(
self, state: bytes, token: Optional[Token] = None
) -> Optional[Tuple[bytes, Token, bool]]:
if token is None:
token = 0
if token == self._token:
self._state = state
self._token += 1
has_set = True
else:
has_set = False
return self._state, self._token, has_set # type: ignore[return-value]
def get_state_internal(self) -> _RendezvousState:
return pickle.loads(cast(bytes, self._state))
def set_state_internal(self, state: _RendezvousState) -> None:
self._state = pickle.dumps(state)
self._token += 1
def corrupt_state(self) -> None:
self._state = b"corrupt_state"
self._token += 1
class BackendRendezvousStateHolderTest(TestCase, CustomAssertMixin):
def setUp(self) -> None:
self._backend = FakeRendezvousBackend()
mock_get_state = MagicMock(wraps=self._backend.get_state)
mock_set_state = MagicMock(wraps=self._backend.set_state)
self._mock_backend = Mock()
self._mock_backend.get_state = mock_get_state
self._mock_backend.set_state = mock_set_state
setattr(self._backend, "get_state", mock_get_state) # noqa: B010
setattr(self._backend, "set_state", mock_set_state) # noqa: B010
self._settings = RendezvousSettings(
run_id="dummy_run_id",
min_nodes=1,
max_nodes=1,
timeout=RendezvousTimeout(),
keep_alive_interval=timedelta(seconds=30),
keep_alive_max_attempt=3,
)
self._cache_duration = 0
self._now = datetime(2000, 1, 1, hour=0, minute=0)
self._datetime_patch = patch(
"torch.distributed.elastic.rendezvous.dynamic_rendezvous.datetime"
)
mock_datetime = self._datetime_patch.start()
mock_datetime.utcnow.return_value = self._now
def tearDown(self) -> None:
self._datetime_patch.stop()
def _create_state(self) -> _RendezvousState:
state = _RendezvousState()
state.round = 999
state.complete = True
state.deadline = self._now
state.closed = True
state.participants = {
_NodeDesc("dummy1", 1, 1): 0,
_NodeDesc("dummy2", 1, 1): 1,
_NodeDesc("dummy3", 1, 1): 2,
}
state.wait_list = {
_NodeDesc("dummy4", 1, 1),
_NodeDesc("dummy5", 1, 1),
}
state.last_heartbeats = {
_NodeDesc("dummy1", 1, 1): self._now,
_NodeDesc("dummy2", 1, 1): self._now - timedelta(seconds=15),
_NodeDesc("dummy3", 1, 1): self._now - timedelta(seconds=30),
_NodeDesc("dummy4", 1, 1): self._now - timedelta(seconds=60),
_NodeDesc("dummy5", 1, 1): self._now - timedelta(seconds=90),
}
return state
def _create_state_holder(self) -> _BackendRendezvousStateHolder:
return _BackendRendezvousStateHolder(self._backend, self._settings, self._cache_duration)
def test_init_initializes_state_holder(self) -> None:
state_holder = self._create_state_holder()
self.assert_state_empty(state_holder.state)
self._mock_backend.assert_not_called()
def test_sync_gets_empty_state_if_backend_state_does_not_exist(self) -> None:
state_holder = self._create_state_holder()
has_set = state_holder.sync()
self.assertIsNone(has_set)
self.assert_state_empty(state_holder.state)
self.assertEqual(self._mock_backend.get_state.call_count, 1)
self.assertEqual(self._mock_backend.set_state.call_count, 0)
def test_sync_gets_backend_state_if_local_state_is_clean(self) -> None:
state_holder = self._create_state_holder()
expected_state = self._create_state()
for attempt in range(1, 4):
with self.subTest(attempt=attempt):
expected_state.round = attempt
self._backend.set_state_internal(expected_state)
has_set = state_holder.sync()
self.assertIsNone(has_set)
self.assert_state_equal(state_holder.state, expected_state)
self.assertEqual(self._mock_backend.get_state.call_count, 1)
self.assertEqual(self._mock_backend.set_state.call_count, 0)
self._mock_backend.reset_mock()
def test_sync_gets_backend_state_if_local_state_is_old_and_dirty(self) -> None:
state_holder = self._create_state_holder()
expected_state = self._create_state()
for attempt in range(1, 4):
with self.subTest(attempt=attempt):
self._backend.set_state_internal(expected_state) # Increment token.
state_holder.state.round = attempt
state_holder.mark_dirty()
has_set = state_holder.sync()
self.assertFalse(has_set)
self.assert_state_equal(state_holder.state, expected_state)
self.assertEqual(self._mock_backend.get_state.call_count, 0)
self.assertEqual(self._mock_backend.set_state.call_count, 1)
self._mock_backend.reset_mock()
def test_sync_sets_backend_state_if_local_state_is_new_and_dirty(self) -> None:
state_holder = self._create_state_holder()
for attempt in range(1, 4):
with self.subTest(attempt=attempt):
state_holder.state.round = attempt
state_holder.mark_dirty()
has_set = state_holder.sync()
self.assertTrue(has_set)
expected_state = self._backend.get_state_internal()
self.assert_state_equal(state_holder.state, expected_state)
self.assertEqual(self._mock_backend.get_state.call_count, 0)
self.assertEqual(self._mock_backend.set_state.call_count, 1)
self._mock_backend.reset_mock()
def test_sync_uses_cached_state_if_cache_duration_is_specified(self) -> None:
state = self._create_state()
self._backend.set_state_internal(state)
with patch("torch.distributed.elastic.rendezvous.dynamic_rendezvous.time") as mock_time:
for cache_duration in [1, 5, 10]:
with self.subTest(cache_duration=cache_duration):
self._cache_duration = cache_duration
state_holder = self._create_state_holder()
mock_time.monotonic.return_value = 5
state_holder.sync()
has_set = state_holder.sync()
self.assertIsNone(has_set)
self.assertEqual(self._mock_backend.get_state.call_count, 1)
self.assertEqual(self._mock_backend.set_state.call_count, 0)
mock_time.monotonic.return_value = 5 + self._cache_duration
state_holder.sync()
has_set = state_holder.sync()
self.assertIsNone(has_set)
self.assertEqual(self._mock_backend.get_state.call_count, 1)
self.assertEqual(self._mock_backend.set_state.call_count, 0)
self._mock_backend.get_state.reset_mock()
def test_sync_gets_backend_state_if_cached_state_has_expired(self) -> None:
state = self._create_state()
self._backend.set_state_internal(state)
with patch("torch.distributed.elastic.rendezvous.dynamic_rendezvous.time") as mock_time:
self._cache_duration = 1
state_holder = self._create_state_holder()
mock_time.monotonic.return_value = 5
state_holder.sync()
has_set = state_holder.sync()
self.assertIsNone(has_set)
self.assertEqual(self._mock_backend.get_state.call_count, 1)
self.assertEqual(self._mock_backend.set_state.call_count, 0)
mock_time.monotonic.return_value = 5 + self._cache_duration + 0.01
state_holder.sync()
has_set = state_holder.sync()
self.assertIsNone(has_set)
self.assertEqual(self._mock_backend.get_state.call_count, 2)
self.assertEqual(self._mock_backend.set_state.call_count, 0)
def test_sync_sanitizes_state(self) -> None:
state = self._create_state()
expected_state = copy.deepcopy(state)
dead_node1 = _NodeDesc("dead1", 1, 1)
dead_node2 = _NodeDesc("dead2", 1, 1)
dead_node3 = _NodeDesc("dead3", 1, 1)
dead_node4 = _NodeDesc("dead4", 1, 1)
dead_node5 = _NodeDesc("dead5", 1, 1)
state.last_heartbeats[dead_node1] = self._now - timedelta(seconds=91)
state.last_heartbeats[dead_node2] = self._now - timedelta(seconds=100)
state.last_heartbeats[dead_node3] = self._now - timedelta(seconds=110)
state.last_heartbeats[dead_node4] = self._now - timedelta(seconds=120)
state.last_heartbeats[dead_node5] = self._now - timedelta(seconds=130)
state.participants[dead_node1] = 0
state.participants[dead_node2] = 0
state.participants[dead_node3] = 0
state.wait_list.add(dead_node4)
state.wait_list.add(dead_node5)
self._backend.set_state_internal(state)
state_holder = self._create_state_holder()
state_holder.sync()
self.assert_state_equal(state_holder.state, expected_state)
def test_sync_sanitizes_state_if_no_participants_is_left(self) -> None:
state = self._create_state()
expected_state = copy.deepcopy(state)
for node in state.last_heartbeats:
state.last_heartbeats[node] = self._now - timedelta(seconds=100)
expected_state.complete = False
expected_state.round = 1000
expected_state.participants = {}
expected_state.wait_list = set()
expected_state.last_heartbeats = {}
self._backend.set_state_internal(state)
state_holder = self._create_state_holder()
state_holder.sync()
self.assert_state_equal(state_holder.state, expected_state)
def test_sync_raises_error_if_backend_state_is_corrupt(self) -> None:
self._backend.corrupt_state()
state_holder = self._create_state_holder()
with self.assertRaisesRegex(
RendezvousStateError,
r"^The rendezvous state is corrupt. See inner exception for details.$",
):
state_holder.sync()
class FakeRendezvousStateHolder(_RendezvousStateHolder):
_state: _RendezvousState
_dirty: Optional[bool]
def __init__(self) -> None:
self._state = _RendezvousState()
self._dirty = None
@property
def state(self) -> _RendezvousState:
return self._state
@state.setter
def state(self, value) -> None:
self._state = value
def sync(self) -> Optional[bool]:
self._dirty, dirty = None, self._dirty
return dirty
def mark_dirty(self) -> None:
self._dirty = True
class DistributedRendezvousOpExecutorTest(TestCase, CustomAssertMixin):
def setUp(self) -> None:
self._node = _NodeDesc("this_node", 1, 1)
self._state_holder = FakeRendezvousStateHolder()
mock_sync = MagicMock(wraps=self._state_holder.sync)
mock_mark = MagicMock(wraps=self._state_holder.mark_dirty)
self._mock_state_holder = Mock()
self._mock_state_holder.sync = mock_sync
self._mock_state_holder.mark = mock_mark
setattr(self._state_holder, "sync", mock_sync) # noqa: B010
setattr(self._state_holder, "mark_dirty", mock_mark) # noqa: B010
self._state = self._state_holder.state
self._min_nodes = 1
self._max_nodes = 1
self._timeout = RendezvousTimeout()
self._now = datetime(2000, 1, 1, hour=0, minute=0)
self._datetime_patch = patch(
"torch.distributed.elastic.rendezvous.dynamic_rendezvous.datetime"
)
mock_datetime = self._datetime_patch.start()
mock_datetime.utcnow.return_value = self._now
def tearDown(self) -> None:
self._datetime_patch.stop()
def _create_settings(self) -> RendezvousSettings:
return RendezvousSettings(
run_id="dummy_run_id",
min_nodes=self._min_nodes,
max_nodes=self._max_nodes,
timeout=self._timeout,
keep_alive_interval=timedelta(seconds=30),
keep_alive_max_attempt=3,
)
def _create_op_executor(
self, settings: Optional[RendezvousSettings] = None
) -> _DistributedRendezvousOpExecutor:
self._state_holder.state = self._state
if settings is None:
settings = self._create_settings()
return _DistributedRendezvousOpExecutor(self._node, self._state_holder, settings)
def _run_action(self, action: _Action) -> None:
op_executor = self._create_op_executor()
op = MagicMock(side_effect=[action, _Action.FINISH])
op_executor.run(op, deadline=1)
def _assert_action(self, action: _Action, expected_state: _RendezvousState) -> None:
self._run_action(action)
self.assert_state_equal(self._state, expected_state)
self.assertListEqual(
self._mock_state_holder.mock_calls, [call.sync(), call.mark(), call.sync()]
)
def test_run_passes_expected_context_and_deadline_to_state_handler(self) -> None:
settings = self._create_settings()
op_executor = self._create_op_executor(settings)
op = MagicMock(return_value=_Action.FINISH)
op_executor.run(op, deadline=3)
ctx, deadline = op.call_args[0] # args
self.assertIs(ctx.node, self._node)
self.assertIs(ctx.state, self._state)
self.assertIs(ctx.settings, settings)
self.assertEqual(deadline, 3)
def test_run_keeps_alive(self) -> None:
expected_state = _RendezvousState()
expected_state.last_heartbeats[self._node] = self._now
self._assert_action(_Action.KEEP_ALIVE, expected_state)
def test_run_adds_to_participants(self) -> None:
expected_state = _RendezvousState()
expected_state.participants[self._node] = 0
expected_state.last_heartbeats[self._node] = self._now
self._min_nodes = 2
self._max_nodes = 2
self._assert_action(_Action.ADD_TO_PARTICIPANTS, expected_state)
def test_run_adds_to_participants_if_node_was_in_waitlist(self) -> None:
self._state.wait_list.add(self._node)
expected_state = _RendezvousState()
expected_state.participants[self._node] = 0
expected_state.last_heartbeats[self._node] = self._now
self._min_nodes = 2
self._max_nodes = 2
self._assert_action(_Action.ADD_TO_PARTICIPANTS, expected_state)
def _add_participants(
self, num_participants: int, state: _RendezvousState, ranked: bool = False
) -> None:
for i in range(num_participants):
if ranked:
node = _NodeDesc(f"dummy{i}", 1, 1)
rank = i
else:
node = _NodeDesc(f"dummy{num_participants - i - 1}", 1, 1) # Add in reverse.
rank = 0
state.participants[node] = rank
state.last_heartbeats[node] = self._now
def test_run_adds_to_participants_and_starts_last_call_if_min_nodes_is_reached(self) -> None:
for num_participants in range(3):
self._state = _RendezvousState()
self._add_participants(num_participants, self._state)
self._state.wait_list.add(self._node)
expected_state = _RendezvousState()
self._add_participants(num_participants, expected_state)
expected_state.participants[self._node] = 0
expected_state.last_heartbeats[self._node] = self._now
expected_state.deadline = self._now + self._timeout.last_call
with self.subTest(num_participants=num_participants):
self._min_nodes = num_participants + 1
self._max_nodes = num_participants + 2
self._assert_action(_Action.ADD_TO_PARTICIPANTS, expected_state)
self._mock_state_holder.reset_mock()
def test_run_adds_to_participants_and_completes_rendezvous_if_max_nodes_is_reached(
self,
) -> None:
for min_max_nodes_equal in [False, True]:
for num_participants in range(3):
rank = num_participants
self._state = _RendezvousState()
self._add_participants(num_participants, self._state)
self._state.wait_list.add(self._node)
self._state.deadline = self._now + self._timeout.last_call
expected_state = _RendezvousState()
self._add_participants(num_participants, expected_state, ranked=True)
expected_state.participants[self._node] = rank
expected_state.last_heartbeats[self._node] = self._now
expected_state.complete = True
expected_state.deadline = None
with self.subTest(num_participants=num_participants):
self._min_nodes = num_participants + 1 if min_max_nodes_equal else 0
self._max_nodes = num_participants + 1
self._assert_action(_Action.ADD_TO_PARTICIPANTS, expected_state)
self._mock_state_holder.reset_mock()
def test_run_adds_to_waitlist(self) -> None:
expected_state = _RendezvousState()
expected_state.wait_list.add(self._node)
expected_state.last_heartbeats[self._node] = self._now
self._assert_action(_Action.ADD_TO_WAIT_LIST, expected_state)
def test_run_removes_from_participants(self) -> None:
for complete, last_call_deadline in [(False, self._now), (True, None)]:
self._state = _RendezvousState()
self._add_participants(2, self._state)
self._state.participants[self._node] = 0
self._state.last_heartbeats[self._node] = self._now
self._state.complete = complete
self._state.deadline = last_call_deadline
self._state.round = 1
expected_state = _RendezvousState()
self._add_participants(2, expected_state)
expected_state.complete = complete
expected_state.deadline = last_call_deadline
expected_state.round = 1
with self.subTest(complete=complete):
self._assert_action(_Action.REMOVE_FROM_PARTICIPANTS, expected_state)
self._mock_state_holder.reset_mock()
def test_run_removes_from_participants_and_moves_to_next_round_if_node_is_last_participant(
self,
) -> None:
self._state.participants[self._node] = 0
self._state.last_heartbeats[self._node] = self._now
self._state.complete = True
self._state.round = 1
expected_state = _RendezvousState()
expected_state.complete = False
expected_state.round = 2
self._assert_action(_Action.REMOVE_FROM_PARTICIPANTS, expected_state)
def test_run_removes_from_participants_and_clears_last_call_if_rendezvous_has_less_than_min_nodes(
self,
) -> None:
self._add_participants(2, self._state)
self._state.participants[self._node] = 0
self._state.last_heartbeats[self._node] = self._now
self._state.deadline = self._now
expected_state = _RendezvousState()
self._add_participants(2, expected_state)
self._min_nodes = 3
self._max_nodes = 4
self._assert_action(_Action.REMOVE_FROM_PARTICIPANTS, expected_state)
def test_run_removes_from_waitlist(self) -> None:
self._state.wait_list.add(self._node)
self._state.last_heartbeats[self._node] = self._now
expected_state = _RendezvousState()
self._assert_action(_Action.REMOVE_FROM_WAIT_LIST, expected_state)
def test_run_marks_rendezvous_closed(self) -> None:
expected_state = _RendezvousState()
expected_state.closed = True
self._assert_action(_Action.MARK_RENDEZVOUS_CLOSED, expected_state)
def test_run_raises_error_if_rendezvous_is_closed(self) -> None:
with self.assertRaises(RendezvousClosedError):
self._run_action(_Action.ERROR_CLOSED)
self.assertListEqual(self._mock_state_holder.mock_calls, [call.sync()])
def test_run_raises_error_if_operation_timed_out(self) -> None:
with self.assertRaises(RendezvousTimeoutError):
self._run_action(_Action.ERROR_TIMEOUT)
self.assertListEqual(self._mock_state_holder.mock_calls, [call.sync()])
def test_run_delays_execution_if_sync_requested(self) -> None:
with patch("torch.distributed.elastic.rendezvous.dynamic_rendezvous._delay") as mock_delay:
self._run_action(_Action.SYNC)
mock_delay.assert_called_once_with(seconds=1)
self.assertListEqual(self._mock_state_holder.mock_calls, [call.sync(), call.sync()])
class AbstractTestRendezvousOp(ABC):
assertEqual: Callable
def setUp(self) -> None:
self._node = _NodeDesc("this_node", 1, 1)
self._min_nodes = 1
self._max_nodes = 2
self._keep_alive_interval = timedelta(seconds=30)
self._state = _RendezvousState()
self._state.participants[_NodeDesc("dummy1", 1, 1)] = 1
self._now = datetime(2000, 1, 1, hour=0, minute=0)
self._deadline = 10
self._datetime_patch = patch(
"torch.distributed.elastic.rendezvous.dynamic_rendezvous.datetime"
)
mock_datetime = self._datetime_patch.start()
mock_datetime.utcnow.return_value = self._now
self._time_patch = patch("torch.distributed.elastic.rendezvous.dynamic_rendezvous.time")
mock_time = self._time_patch.start()
mock_time.monotonic.return_value = self._deadline
def tearDown(self) -> None:
self._time_patch.stop()
self._datetime_patch.stop()
def _get_next_action(self) -> _Action:
op = self._create_op()
settings = RendezvousSettings(
run_id="dummy_run_id",
min_nodes=self._min_nodes,
max_nodes=self._max_nodes,
timeout=RendezvousTimeout(),
keep_alive_interval=self._keep_alive_interval,
keep_alive_max_attempt=3,
)
ctx = _RendezvousContext(self._node, self._state, settings)
return op(ctx, self._deadline)
@abstractmethod
def _create_op(self) -> Callable:
pass
def _assert_action(self, expected_action) -> None:
action = self._get_next_action()
self.assertEqual(action, expected_action)
class TestRendezvousExitOp(AbstractTestRendezvousOp, TestCase):
def _create_op(self) -> Callable:
return _RendezvousExitOp()
def test_removes_from_participants_if_node_is_participant(self) -> None:
self._state.participants[self._node] = 1
self._assert_action(_Action.REMOVE_FROM_PARTICIPANTS)
def test_raises_timeout_if_deadline_exceeded(self) -> None:
self._deadline = 0
self._state.participants[self._node] = 1
self._assert_action(_Action.ERROR_TIMEOUT)
def test_finishes_if_node_is_not_participant(self) -> None:
self._assert_action(_Action.FINISH)
class TestRendezvousJoinOp(AbstractTestRendezvousOp, TestCase):
def _create_op(self) -> Callable:
return _RendezvousJoinOp()
def test_raises_closed_if_rendezvous_is_closed(self) -> None:
self._state.closed = True
self._assert_action(_Action.ERROR_CLOSED)
def test_finishes_if_rendezvous_is_complete_and_node_is_participant(self) -> None:
self._state.participants[self._node] = 0
self._state.complete = True
self._assert_action(_Action.FINISH)
def _assert_waits_rendezvous_completion(self) -> None:
keep_alive_time = self._now - self._keep_alive_interval
for delta, expected_action in [
(timedelta(seconds=0), _Action.KEEP_ALIVE),
(timedelta(seconds=1), _Action.SYNC),
]:
self._state.last_heartbeats[self._node] = keep_alive_time + delta
self._assert_action(expected_action)
def test_waits_next_round_if_rendezvous_is_complete(self) -> None:
self._max_nodes = 1
self._state.complete = True
self._assert_waits_rendezvous_completion()
def test_waits_next_round_if_rendezvous_is_complete_and_node_is_in_wait_list(self) -> None:
self._state.wait_list.add(self._node)
self._state.complete = True
self._assert_waits_rendezvous_completion()
def test_adds_to_wait_list_if_rendezvous_is_complete_and_num_nodes_is_less_than_max_nodes(
self,
) -> None:
self._state.complete = True
self._assert_action(_Action.ADD_TO_WAIT_LIST)
def test_waits_rendezvous_to_complete_if_node_is_participant(self) -> None:
self._max_nodes = 3
self._state.participants[self._node] = 0
self._state.deadline = self._now
self._assert_waits_rendezvous_completion()
def test_marks_rendezvous_complete_if_node_is_participant_and_last_call_deadline_exceeded(
self,
) -> None:
self._max_nodes = 3
self._state.participants[self._node] = 0
self._state.deadline = self._now - timedelta(seconds=1)
self._assert_action(_Action.MARK_RENDEZVOUS_COMPLETE)
def test_adds_to_participants(self) -> None:
self._assert_action(_Action.ADD_TO_PARTICIPANTS)
def test_raises_timeout_if_deadline_exceeded(self) -> None:
self._deadline = 0
self._assert_action(_Action.ERROR_TIMEOUT)
def test_raises_timeout_if_rollback_deadline_exceeded_and_node_is_participant(self) -> None:
self._deadline = 0
self._state.participants[self._node] = 0
self._assert_action(_Action.ERROR_TIMEOUT)
def test_raises_timeout_if_rollback_deadline_exceeded_and_node_is_in_wait_list(self) -> None:
self._deadline = 0
self._state.wait_list.add(self._node)
self._assert_action(_Action.ERROR_TIMEOUT)
def test_removes_from_participants_if_timed_out_but_rollback_deadline_is_not_reached(
self,
) -> None:
self._deadline = 5
self._state.participants[self._node] = 0
self._assert_action(_Action.REMOVE_FROM_PARTICIPANTS)
def test_removes_from_wait_list_if_timed_out_but_rollback_deadline_is_not_reached(self) -> None:
self._deadline = 5
self._state.wait_list.add(self._node)
self._assert_action(_Action.REMOVE_FROM_WAIT_LIST)
class TestRendezvousCloseOp(AbstractTestRendezvousOp, TestCase):
def _create_op(self) -> Callable:
return _RendezvousCloseOp()
def test_finishes_if_rendezvous_is_closed(self) -> None:
self._state.closed = True
self._assert_action(_Action.FINISH)
def test_raises_timeout_if_deadline_exceeded(self) -> None:
self._deadline = 0
self._assert_action(_Action.ERROR_TIMEOUT)
def test_marks_rendezvous_closed(self) -> None:
self._assert_action(_Action.MARK_RENDEZVOUS_CLOSED)
class TestRendezvousKeepAliveOp(AbstractTestRendezvousOp, TestCase):
def _create_op(self) -> Callable:
return _RendezvousKeepAliveOp()
def test_updates_keep_alive_if_needed(self) -> None:
keep_alive_time = self._now - self._keep_alive_interval
for delta in [timedelta(seconds=0), timedelta(seconds=-1)]:
with self.subTest(delta=delta):
self._state.last_heartbeats[self._node] = keep_alive_time + delta
self._assert_action(_Action.KEEP_ALIVE)
def test_raises_timeout_if_deadlined_exceeded(self) -> None:
self._deadline = 0
self._state.last_heartbeats[self._node] = self._now - self._keep_alive_interval
self._assert_action(_Action.ERROR_TIMEOUT)
def test_finishes_if_no_keep_alive_update_is_needed(self) -> None:
delta = timedelta(seconds=1)
self._state.last_heartbeats[self._node] = self._now - self._keep_alive_interval + delta
self._assert_action(_Action.FINISH)
class DummyStore(Store):
pass
class DynamicRendezvousHandlerTest(TestCase):
def setUp(self) -> None:
self._node = _NodeDesc("this_node", 1, 1)
self._min_nodes = 1
self._max_nodes = 1
self._join_timeout: Optional[timedelta] = None
self._close_timeout: Optional[timedelta] = None
self._heartbeat_timeout: Optional[timedelta] = None
self._keep_alive_interval = timedelta(seconds=30)
self._store = DummyStore()
self._mock_store_get = MagicMock(return_value=b"dummy_value")
setattr(self._store, "get", self._mock_store_get) # noqa: B010
self._state_holder = FakeRendezvousStateHolder()
self._mock_sync = MagicMock(wraps=self._state_holder.sync)
setattr(self._state_holder, "sync", self._mock_sync) # noqa: B010
self._state = self._state_holder.state
def _create_handler(self) -> DynamicRendezvousHandler:
settings = RendezvousSettings(
run_id="dummy_run_id",
min_nodes=self._min_nodes,
max_nodes=self._max_nodes,
timeout=RendezvousTimeout(
join=self._join_timeout,
close=self._close_timeout,
heartbeat=self._heartbeat_timeout,
),
keep_alive_interval=self._keep_alive_interval,
keep_alive_max_attempt=3,
)
self._state_holder.state = self._state
return DynamicRendezvousHandler(
self._node, settings, "dummy_backend", self._store, self._state_holder
)
@patch("torch.distributed.elastic.rendezvous.dynamic_rendezvous._delay")
def test_next_rendezvous_skews_the_first_join_attempt(self, mock_delay) -> None:
for round, expected_call_count in [(0, True), (1, False)]:
with self.subTest(round=round):
self._state.round = round
handler = self._create_handler()
handler.next_rendezvous()
self.assertEqual(mock_delay.call_count, expected_call_count)
mock_delay.reset_mock()
def test_next_rendezvous_returns_expected_value(self) -> None:
self._state.participants[_NodeDesc("dummy1", 1, 1)] = 0
self._state.participants[_NodeDesc("dummy2", 1, 1)] = 0
self._max_nodes = 3
handler = self._create_handler()
store, rank, world_size = handler.next_rendezvous()
self.assertEqual(rank, 2)
self.assertEqual(world_size, 3)
_ = store.get("dummy_key")
self._mock_store_get.assert_called_once_with("torch.rendezvous.dummy_run_id.0/dummy_key")
def test_next_rendezvous_respects_the_requested_timeout(self) -> None:
self._mock_sync.side_effect = lambda: time.sleep(0.3)
self._join_timeout = timedelta(seconds=0.2)
handler = self._create_handler()
with self.assertRaises(RendezvousTimeoutError):
handler.next_rendezvous()
def test_next_rendezvous_moves_to_next_round_if_called_repeatedly(self) -> None:
handler = self._create_handler()
for i in range(4):
handler.next_rendezvous()
self.assertEqual(self._state.round, i)
def test_is_closed_returns_expected_value(self) -> None:
for closed in [False, True]:
with self.subTest(closed=closed):
self._state.closed = closed
handler = self._create_handler()
self.assertEqual(handler.is_closed(), closed)
self._mock_sync.assert_called_once()
self._mock_sync.reset_mock()
@patch("torch.distributed.elastic.events.record_rdzv_event")
def test_is_closed_records_and_raises_exceptions(self, record_mock) -> None:
self._mock_sync.side_effect = RendezvousError("test error")
handler = self._create_handler()
with self.assertRaises(RendezvousError):
handler.is_closed()
record_mock.assert_called_once()
def test_set_closed_closes_rendezvous(self) -> None:
handler = self._create_handler()
handler.set_closed()
self.assertTrue(self._state.closed)
def test_set_closed_respects_the_requested_timeout(self) -> None:
self._mock_sync.side_effect = lambda: time.sleep(0.3)
self._close_timeout = timedelta(seconds=0.2)
handler = self._create_handler()
with self.assertRaises(RendezvousTimeoutError):
handler.set_closed()
def test_set_closed_can_be_called_multiple_times(self) -> None:
handler = self._create_handler()
handler.set_closed()
handler.set_closed()
self.assertTrue(self._state.closed)
@patch("torch.distributed.elastic.events.record_rdzv_event")
def test_set_closed_records_and_raises_exceptions(self, record_mock) -> None:
with patch.object(DynamicRendezvousHandler, "_close") as close_mock:
close_mock.side_effect = RendezvousError("test error")
handler = self._create_handler()
with self.assertRaises(RendezvousError):
handler.set_closed()
record_mock.assert_called_once()
def test_num_nodes_waiting_returns_expected_value(self) -> None:
self._state.wait_list.add(_NodeDesc("dummy1", 1, 1))
self._state.wait_list.add(_NodeDesc("dummy2", 1, 1))
handler = self._create_handler()
self.assertEqual(handler.num_nodes_waiting(), 2)
self._mock_sync.assert_called_once()
@patch("torch.distributed.elastic.events.record_rdzv_event")
def test_num_nodes_waiting_records_and_raises_exceptions(self, record_mock) -> None:
self._mock_sync.side_effect = RendezvousError("test error")
handler = self._create_handler()
with self.assertRaises(RendezvousError):
handler.num_nodes_waiting()
record_mock.assert_called_once()
def test_shutdown_closes_rendezvous_and_returns_true(self) -> None:
handler = self._create_handler()
result = handler.shutdown()
self.assertTrue(result)
self.assertTrue(self._state.closed)
def test_shutdown_returns_false_if_rendezvous_cannot_be_closed(self) -> None:
self._mock_sync.side_effect = [RendezvousError]
handler = self._create_handler()
result = handler.shutdown()
self.assertFalse(result)
def test_shutdown_can_be_called_multiple_times(self) -> None:
handler = self._create_handler()
handler.shutdown()
handler.shutdown()
self.assertTrue(self._state.closed)
@patch("torch.distributed.elastic.events.record_rdzv_event")
def test_shutdown_records_and_raises_exceptions(self, record_mock) -> None:
with patch.object(DynamicRendezvousHandler, "_close") as close_mock:
close_mock.side_effect = RuntimeError("test error")
handler = self._create_handler()
with self.assertRaises(RuntimeError):
handler.shutdown()
record_mock.assert_called_once()
@patch("torch.distributed.elastic.rendezvous.dynamic_rendezvous.datetime")
def test_keep_alive_updates_last_heartbeat(self, mock_datetime) -> None:
now = datetime(2000, 1, 1, hour=0, minute=0)
mock_datetime.utcnow.return_value = now
self._state.last_heartbeats[self._node] = now - (self._keep_alive_interval * 2)
handler = self._create_handler()
handler._keep_alive()
self.assertEqual(self._state.last_heartbeats[self._node], now)
def _assert_keep_alive_swallows_rendezvous_errors(self) -> None:
last_heartbeat_time = datetime.utcnow() - (self._keep_alive_interval * 2)
self._state.last_heartbeats[self._node] = last_heartbeat_time
handler = self._create_handler()
handler._keep_alive()
self.assertEqual(self._state.last_heartbeats[self._node], last_heartbeat_time)
def test_keep_alive_swallows_rendezvous_errors(self) -> None:
self._mock_sync.side_effect = [RendezvousError]
self._assert_keep_alive_swallows_rendezvous_errors()
def test_keep_alive_respects_the_requested_timeout(self) -> None:
self._mock_sync.side_effect = lambda: time.sleep(0.3)
self._heartbeat_timeout = timedelta(seconds=0.2)
self._assert_keep_alive_swallows_rendezvous_errors()
def test_keep_alive_thread_is_started_with_next_rendezvous_and_stopped_with_shutdown(
self,
) -> None:
self._node = _NodeDesc("this_node", 1, 2)
name = "RendezvousKeepAliveTimer_2"
handler = self._create_handler()
self.assertTrue(all(t.name != name for t in threading.enumerate()))
handler.next_rendezvous()
self.assertTrue(any(t.name == name for t in threading.enumerate()))
handler.shutdown()
self.assertTrue(all(t.name != name for t in threading.enumerate()))
def test_keep_alive_thread_is_started_with_next_rendezvous_and_stopped_with_finalizer(
self,
) -> None:
self._node = _NodeDesc("this_node", 1, 3)
name = "RendezvousKeepAliveTimer_3"
handler = self._create_handler()
self.assertTrue(all(t.name != name for t in threading.enumerate()))
handler.next_rendezvous()
self.assertTrue(any(t.name == name for t in threading.enumerate()))
del handler
self.assertTrue(all(t.name != name for t in threading.enumerate()))
class DummyRendezvousBackend(RendezvousBackend):
@property
def name(self):
return "dummy_backend"
def get_state(self):
return None
def set_state(self, state, token):
return None
class DynamicRendezvousHandlerFromBackendTest(TestCase):
def setUp(self) -> None:
self._run_id = "dummy_run_id"
self._store = DummyStore()
self._backend = DummyRendezvousBackend()
self._min_nodes = 3
self._max_nodes = 6
self._timeout: Optional[RendezvousTimeout] = RendezvousTimeout()
def _create_handler(self) -> DynamicRendezvousHandler:
return DynamicRendezvousHandler.from_backend(
run_id=self._run_id,
store=self._store,
backend=self._backend,
min_nodes=self._min_nodes,
max_nodes=self._max_nodes,
timeout=self._timeout,
)
def test_init_initializes_handler(self) -> None:
handler = self._create_handler()
self.assertEqual(handler.get_backend(), self._backend.name)
self.assertEqual(handler.get_run_id(), self._run_id)
self.assertEqual(handler.settings.run_id, self._run_id)
self.assertEqual(handler.settings.min_nodes, self._min_nodes)
self.assertEqual(handler.settings.max_nodes, self._max_nodes)
if self._timeout is None:
self.assertIsNotNone(handler.settings.timeout)
else:
self.assertIs(handler.settings.timeout, self._timeout)
def test_init_initializes_handler_if_timeout_is_not_specified(self) -> None:
self._timeout = None
self.test_init_initializes_handler()
def test_init_initializes_handler_if_min_and_max_nodes_are_equal(self) -> None:
self._min_nodes = 3
self._max_nodes = 3
self.test_init_initializes_handler()
def test_init_raises_error_if_min_nodes_is_not_positive(self) -> None:
for num in [0, -10]:
with self.subTest(min_nodes=num):
self._min_nodes = num
with self.assertRaisesRegex(
ValueError,
rf"^The minimum number of nodes \({num}\) must be greater than zero.$",
):
self._create_handler()
def test_init_raises_error_if_max_nodes_is_less_than_min(self) -> None:
self._min_nodes = 3
self._max_nodes = 2
with self.assertRaisesRegex(
ValueError,
rf"^The maximum number of nodes \({self._max_nodes}\) must be greater than or equal to "
"the minimum number of nodes "
rf"\({self._min_nodes}\).$",
):
self._create_handler()
class CreateHandlerTest(TestCase):
def setUp(self) -> None:
self._store = DummyStore()
self._backend = DummyRendezvousBackend()
self._params = RendezvousParameters(
backend=self._backend.name,
endpoint="dummy_endpoint",
run_id="dummy_run_id",
min_nodes=3,
max_nodes=6,
join_timeout="50",
last_call_timeout="60",
close_timeout="70",
)
self._expected_timeout = RendezvousTimeout(
timedelta(seconds=50), timedelta(seconds=60), timedelta(seconds=70)
)
def test_create_handler_returns_handler(self) -> None:
handler = create_handler(self._store, self._backend, self._params)
self.assertEqual(handler.get_backend(), self._backend.name)
self.assertEqual(handler.get_run_id(), self._params.run_id)
self.assertEqual(handler.settings.min_nodes, self._params.min_nodes)
self.assertEqual(handler.settings.max_nodes, self._params.max_nodes)
self.assertEqual(handler.settings.timeout.join, self._expected_timeout.join)
self.assertEqual(handler.settings.timeout.last_call, self._expected_timeout.last_call)
self.assertEqual(handler.settings.timeout.close, self._expected_timeout.close)
def test_create_handler_returns_handler_if_timeout_is_not_specified(self) -> None:
del self._params.config["join_timeout"]
del self._params.config["last_call_timeout"]
del self._params.config["close_timeout"]
self._expected_timeout = RendezvousTimeout()
self.test_create_handler_returns_handler()
@patch("torch.distributed.elastic.events.record_rdzv_event")
def test_create_handler_records_and_raises_exceptions(self, record_mock) -> None:
with patch.object(DynamicRendezvousHandler, "from_backend") as from_mock:
from_mock.side_effect = RendezvousError("test error")
with self.assertRaises(RendezvousError):
create_handler(self._store, self._backend, self._params)
record_mock.assert_called_once()
|