1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173
|
# Owner(s): ["module: fx"]
import torch
import torch.fx as fx
from torch.testing._internal.common_utils import TestCase
from torch.fx.passes.infra.pass_base import PassResult
from torch.fx.passes.infra.pass_manager import (
PassManager,
this_before_that_pass_constraint,
_topological_sort_passes,
)
def replace_add_with_mul_pass(gm):
modified = False
for node in gm.graph.nodes:
if node.op == "call_function" and node.target == torch.add:
node.target = torch.mul
modified = True
return PassResult(gm, modified)
def replace_mul_with_div_pass(gm):
modified = False
for node in gm.graph.nodes:
if node.op == "call_function" and node.target == torch.mul:
node.target = torch.div
modified = True
return PassResult(gm, modified)
class AddModule(torch.nn.Module):
def __init__(self):
super().__init__()
def forward(self, x):
y = torch.add(x, x)
z = torch.add(y, x)
return z
class TestPassManager(TestCase):
def test_pass_manager(self):
"""
Tests that the pass manager runs the passes correctly.
"""
m = AddModule()
traced_m = torch.fx.symbolic_trace(m)
pm = PassManager(passes=[replace_add_with_mul_pass, replace_mul_with_div_pass], steps=5)
pm.validate_constraints()
self.assertEqual(len(pm.passes), 2)
res = pm(traced_m)
modified_m = res.graph_module
assert isinstance(modified_m, fx.GraphModule)
# Check that all call_function nodes are divs
for node in modified_m.graph.nodes:
if node.op == "call_function":
self.assertEqual(node.target, torch.div)
def test_this_before_that_pass_constraint(self):
"""
Tests the construction of constraints
"""
passes = [lambda x: 2 * x for _ in range(10)]
pm = PassManager(passes)
# add unfulfillable constraint
pm.add_constraint(this_before_that_pass_constraint(passes[-1], passes[0]))
with self.assertRaises(RuntimeError):
pm.validate_constraints()
def test_pass_manager_checks(self):
"""
Tests that users can add in check functions correctly
"""
m = AddModule()
traced_m = fx.symbolic_trace(m)
pm = PassManager(passes=[replace_add_with_mul_pass, replace_mul_with_div_pass])
def check_div_target(graph_module):
for node in graph_module.graph.nodes:
if node.op == "call_function" and node.target != torch.div:
raise ValueError("Target should be div!")
pm.add_checks(check_div_target)
with self.assertRaises(ValueError):
pm(traced_m)
def test_pass_manager_bad_checks(self):
"""
Checks that we error if we pass in a check function with the wrong parameters
"""
def check_bad_args(graph_module, i):
pass
pm = PassManager()
self.assertRaises(TypeError, pm.add_checks, check_bad_args)
def test_topological_sort(self):
"""
Tests that passes are correctly ordered based on contraints.
"""
def pass0(x):
return x
def pass1(x):
return x + 1
def pass2(x):
return x + 2
def pass3(x):
return x + 3
def pass4(x):
return x + 4
def pass5(x):
return x + 5
# Not passing any constraints should keep the original order
passes = [pass0, pass1, pass2, pass3, pass4, pass5]
sorted = _topological_sort_passes(passes, [])
self.assertEqual(sorted, passes)
# Graph that we are constructing:
# 5 ----> 0 <---- 4
# | |
# +-> 2 -> 3 -> 1 <-+
# Which has a possible topological order of: [4, 5, 0, 2, 3, 1]
passes = [pass0, pass1, pass2, pass3, pass4, pass5]
constraints = [
this_before_that_pass_constraint(pass5, pass0),
this_before_that_pass_constraint(pass5, pass2),
this_before_that_pass_constraint(pass4, pass0),
this_before_that_pass_constraint(pass4, pass1),
this_before_that_pass_constraint(pass2, pass3),
this_before_that_pass_constraint(pass3, pass1),
]
sorted = _topological_sort_passes(passes, constraints)
self.assertEqual(sorted, [pass4, pass5, pass0, pass2, pass3, pass1])
# Circular dependency should result in the circular_dep flag being set
passes = [pass0, pass1, pass2]
constraints = [
this_before_that_pass_constraint(passes[0], passes[1]),
this_before_that_pass_constraint(passes[1], passes[2]),
this_before_that_pass_constraint(passes[2], passes[0]),
]
with self.assertRaises(RuntimeError) as e:
_topological_sort_passes(passes, constraints)
expected_error_msg = f"Circular dependency detected within the following passes: {passes}"
self.assertEqual(e.exception.args[0], expected_error_msg)
def test_pass_manager_error(self):
"""
Tests error catching + debug
"""
def pass_fail(graph_module):
raise RuntimeError("bad")
m = AddModule()
traced_m = torch.fx.symbolic_trace(m)
pm = PassManager(passes=[replace_add_with_mul_pass, replace_mul_with_div_pass, pass_fail])
# Comment out this line to see the actual error message
with self.assertRaises(RuntimeError):
pm(traced_m)
|