1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
|
// Copyright (C) 2021 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
#include <QtQml/QQmlEngine>
#include <QtQml/QQmlComponent>
#include <QtCore/QScopedPointer>
#include <QtQml/private/qqmlanybinding_p.h>
#include <QtQuickTestUtils/private/qmlutils_p.h>
#include <QtCore/private/qobject_p.h>
#include "withbindable.h"
class tst_qqmlanybinding : public QQmlDataTest
{
Q_OBJECT
public:
tst_qqmlanybinding();
private slots:
void basicActions_data();
void basicActions();
void unboundQQmlPropertyBindingDoesNotCrash();
void ofDynamicMetaObject();
};
tst_qqmlanybinding::tst_qqmlanybinding()
: QQmlDataTest(QT_QMLTEST_DATADIR)
{
}
void tst_qqmlanybinding::basicActions_data()
{
QTest::addColumn<QString>("fileName");
QTest::addRow("old style") << QStringLiteral("oldstylebinding.qml");
QTest::addRow("new style") << QStringLiteral("newstylebinding.qml");
}
static int getRefCount(const QQmlAnyBinding &binding)
{
if (binding.isAbstractPropertyBinding()) {
return binding.asAbstractBinding()->ref;
} else {
// this temporarily adds a refcount because we construc a new untypedpropertybinding
// thus -1
return QPropertyBindingPrivate::get(binding.asUntypedPropertyBinding())->refCount() - 1;
}
}
void tst_qqmlanybinding::basicActions()
{
QQmlEngine engine;
QFETCH(QString, fileName);
QQmlComponent comp(&engine, testFileUrl(fileName));
QScopedPointer<QObject> root(comp.create());
QVERIFY2(root, qPrintable(comp.errorString()));
QQmlProperty prop(root.get(), "prop");
QQmlProperty trigger(root.get(), "trigger");
// sanity check
QCOMPARE(prop.read().toInt(), 1);
// We can take the binding from a property
auto binding = QQmlAnyBinding::ofProperty(prop);
if (fileName == u"oldstylebinding.qml") {
// and it is a QQmlAbstractBinding,
QVERIFY(binding.isAbstractPropertyBinding());
} else {
// and it is a new style binding,
QVERIFY(binding.isUntypedPropertyBinding());
}
// which is not null.
QVERIFY(binding);
// Getting the binding did not remove it.
trigger.write(42);
QCOMPARE(prop.read().toInt(), 42);
// remove does that,
QQmlAnyBinding::removeBindingFrom(prop);
QVERIFY(!QQmlAnyBinding::ofProperty(prop));
// but does not change the value.
QCOMPARE(prop.read().toInt(), 42);
// As there is no binding anymore, there won't be any change if trigger changes.
trigger.write(2);
QCOMPARE(prop.read().toInt(), 42);
// The binding we took is still valid (and we are currently the sole owner).
QVERIFY(getRefCount(binding) == 1);
// We can reinstall the binding
binding.installOn(prop);
// This changes the value to reflect that trigger has changed
QCOMPARE(prop.read().toInt(), 2);
// The binding behaves normally.
trigger.write(3);
QCOMPARE(prop.read().toInt(), 3);
// "binding" still has a reference to the binding
QVERIFY(getRefCount(binding) == 2);
// aliases are resolved correctly
QQmlProperty a2(root.get(), "a2");
QCOMPARE(QQmlAnyBinding::ofProperty(a2), binding);
}
void tst_qqmlanybinding::unboundQQmlPropertyBindingDoesNotCrash()
{
QQmlEngine engine;
QQmlComponent comp(&engine, testFileUrl("unboundBinding.qml"));
QScopedPointer<QObject> root(comp.create());
QVERIFY2(root, qPrintable(comp.errorString()));
QQmlProperty prop(root.get(), "prop");
QQmlProperty trigger(root.get(), "trigger");
// Store a reference to the binding of prop.
auto binding = QQmlAnyBinding::ofProperty(prop);
QVERIFY(binding.isUntypedPropertyBinding());
QVERIFY(!binding.asUntypedPropertyBinding().isNull());
// If we break the binding,
prop.write(42);
QCOMPARE(prop.read(), 42);
{
auto noBinding = QQmlAnyBinding::ofProperty(prop);
QVERIFY(noBinding.asUntypedPropertyBinding().isNull());
}
// and trigger binding reevaluation
trigger.write(1);
// there is no crash.
// When we reinstall the binding,
binding.installOn(prop);
// the value is correctly updated.
QCOMPARE(prop.read(), 1);
}
class QObjectDynamicMetaObject : public QDynamicMetaObjectData
{
public:
#if QT_VERSION >= QT_VERSION_CHECK(7, 0, 0)
const QMetaObject *toDynamicMetaObject(QObject *) const final
{
return &QObject::staticMetaObject;
}
#else
QMetaObject *toDynamicMetaObject(QObject *) final
{
return const_cast<QMetaObject *>(&QObject::staticMetaObject);
}
#endif
int metaCall(QObject *o, QMetaObject::Call c, int id, void **argv) final
{
return o->qt_metacall(c, id, argv);
}
};
void tst_qqmlanybinding::ofDynamicMetaObject()
{
QObject o;
const QQmlPropertyIndex objectNameIndex(
QObject::staticMetaObject.indexOfProperty("objectName"));
QObjectPrivate::get(&o)->metaObject = new QObjectDynamicMetaObject;
QQmlAnyBinding a = QQmlAnyBinding::ofProperty(&o, objectNameIndex);
QVERIFY(!a);
QPropertyBinding<QString> binding
= Qt::makePropertyBinding([]() { return QStringLiteral("foo"); });
o.bindableObjectName().setBinding(binding);
QQmlAnyBinding b = QQmlAnyBinding::ofProperty(&o, objectNameIndex);
QVERIFY(b);
QCOMPARE(QPropertyBindingPrivate::get(b.asUntypedPropertyBinding()),
QPropertyBindingPrivate::get(binding));
}
QTEST_MAIN(tst_qqmlanybinding)
#include "tst_qqmlanybinding.moc"
|
