1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
|
// Copyright (C) 2024 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
#include "testmodel.h"
#include <QtQuickTest/quicktest.h>
#include <QtQuick/qquickview.h>
#include <QtQuick/private/qquicktableview_p.h>
#include <QtQuick/private/qquicktableview_p_p.h>
#include <QtQuickTemplates2/private/qquicktableviewdelegate_p.h>
#include <QtQuickTestUtils/private/viewtestutils_p.h>
#include <QtQuickTestUtils/private/visualtestutils_p.h>
#include <QtTest/QTest>
#include <QtTest/QSignalSpy>
using namespace QQuickViewTestUtils;
using namespace QQuickVisualTestUtils;
#define LOAD_TABLEVIEW(fileName) \
view->setSource(testFileUrl(fileName)); \
view->show(); \
QVERIFY(QTest::qWaitForWindowActive(view.get())); \
QQuickTableView *tableView = getTableView(); \
QVERIFY(tableView); \
[[maybe_unused]] auto tableViewPrivate = QQuickTableViewPrivate::get(tableView); \
[[maybe_unused]] auto model = tableView->model().value<TestModel *>()
// ########################################################
class tst_qquicktableviewdelegate : public QQmlDataTest
{
Q_OBJECT
public:
tst_qquicktableviewdelegate();
private slots:
void initTestCase() override;
void showTableView();
void checkProperties();
void checkCurrentIndex();
void checkClickedSignal_data();
void checkClickedSignal();
void clearSelectionOnClick();
void dragToSelect();
void pressAndHoldToSelect();
private:
QQuickTableView *getTableView();
QQuickTableViewDelegate *getDelegateItem(int row, int column);
private:
std::unique_ptr<QQuickView> view = nullptr;
};
tst_qquicktableviewdelegate::tst_qquicktableviewdelegate()
: QQmlDataTest(QT_QMLTEST_DATADIR)
{
}
void tst_qquicktableviewdelegate::initTestCase()
{
QQmlDataTest::initTestCase();
qmlRegisterType<TestModel>("TestModel", 1, 0, "TestModel");
view.reset(createView());
}
void tst_qquicktableviewdelegate::showTableView()
{
LOAD_TABLEVIEW("unmodified.qml");
QCOMPARE(tableViewPrivate->loadedRows.count(), 1);
QCOMPARE(tableViewPrivate->loadedColumns.count(), 1);
}
void tst_qquicktableviewdelegate::checkProperties()
{
LOAD_TABLEVIEW("unmodified.qml");
QCOMPARE(tableViewPrivate->loadedRows.count(), 1);
QCOMPARE(tableViewPrivate->loadedColumns.count(), 1);
const QQuickTableViewDelegate *item = getDelegateItem(0, 0);
QVERIFY(item);
QCOMPARE(item->property("displayText"), "0,0");
QCOMPARE(item->tableView(), tableView);
constexpr auto TEXT_0_1 = "0,1";
model->appendColumn();
model->setData(0, 1, TEXT_0_1, Qt::DisplayRole);
QVERIFY(QQuickTest::qWaitForPolish(tableView));
QCOMPARE(tableViewPrivate->loadedRows.count(), 1);
QCOMPARE(tableViewPrivate->loadedColumns.count(), 2);
item = getDelegateItem(0, 1);
QVERIFY(item);
QCOMPARE(item->property("displayText"), TEXT_0_1);
QCOMPARE(item->tableView(), tableView);
constexpr auto TEXT_1_0 = "1,0";
constexpr auto TEXT_1_1 = "1,1";
model->appendRow();
model->setData(1, 0, TEXT_1_0, Qt::DisplayRole);
model->setData(1, 1, TEXT_1_1, Qt::DisplayRole);
QVERIFY(QQuickTest::qWaitForPolish(tableView));
QCOMPARE(tableViewPrivate->loadedRows.count(), 2);
QCOMPARE(tableViewPrivate->loadedColumns.count(), 2);
item = getDelegateItem(1, 0);
QVERIFY(item);
QCOMPARE(item->property("displayText"), TEXT_1_0);
QCOMPARE(item->tableView(), tableView);
item = getDelegateItem(1, 1);
QVERIFY(item);
QCOMPARE(item->property("displayText"), TEXT_1_1);
QCOMPARE(item->tableView(), tableView);
}
void tst_qquicktableviewdelegate::checkCurrentIndex()
{
// Check that that a cell becomes current when you click on it
LOAD_TABLEVIEW("unmodified.qml");
QCOMPARE(tableViewPrivate->loadedRows.count(), 1);
const QQuickTableViewDelegate *item = getDelegateItem(0, 0);
QVERIFY(item);
QVERIFY(!item->current());
QVERIFY(!item->selected());
QVERIFY(!item->editing());
QVERIFY(!tableView->hasActiveFocus());
// Click on the label
const QPoint localPos = QPoint(item->width() / 2, item->height() / 2);
const QPoint pos = item->window()->contentItem()->mapFromItem(item, localPos).toPoint();
QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos);
QVERIFY(item->current());
QVERIFY(!item->selected());
QVERIFY(!item->editing());
QVERIFY(tableView->hasActiveFocus());
// Select the cell
tableView->selectionModel()->setCurrentIndex(tableView->modelIndex({0, 0}), QItemSelectionModel::Select);
QVERIFY(item->current());
QVERIFY(item->selected());
QVERIFY(!item->editing());
}
void tst_qquicktableviewdelegate::checkClickedSignal_data()
{
QTest::addColumn<bool>("pointerNavigationEnabled");
QTest::newRow("pointer navigation enabled") << true;
QTest::newRow("pointer navigation disabled") << false;
}
void tst_qquicktableviewdelegate::checkClickedSignal()
{
// Check that the delegate emits clicked when clicking on the
// label, but not when clicking on the indicator. This API is
// a part of the AbstractButton API, and should work with or
// without TableView.pointerNavigationEnabled set.
QFETCH(bool, pointerNavigationEnabled);
LOAD_TABLEVIEW("unmodified.qml");
tableView->setPointerNavigationEnabled(pointerNavigationEnabled);
const auto item = tableView->itemAtIndex(tableView->index(0, 0));
QVERIFY(item);
QSignalSpy clickedSpy(item, SIGNAL(clicked()));
// Click on the label
const QPoint localPos = QPoint(item->width() / 2, item->height() / 2);
const QPoint pos = item->window()->contentItem()->mapFromItem(item, localPos).toPoint();
QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos);
QCOMPARE(clickedSpy.size(), 1);
clickedSpy.clear();
}
void tst_qquicktableviewdelegate::clearSelectionOnClick()
{
LOAD_TABLEVIEW("unmodified.qml");
// Select root item
const auto index = tableView->selectionModel()->model()->index(0, 0);
tableView->selectionModel()->select(index, QItemSelectionModel::Select);
QCOMPARE(tableView->selectionModel()->selectedIndexes().size(), 1);
// Click on a cell. This should remove the selection
const auto item = getDelegateItem(0, 0);
QVERIFY(item);
const QPoint localPos = QPoint(item->width() / 2, item->height() / 2);
const QPoint pos = item->window()->contentItem()->mapFromItem(item, localPos).toPoint();
QTest::mouseClick(item->window(), Qt::LeftButton, Qt::NoModifier, pos);
QCOMPARE(tableView->selectionModel()->selectedIndexes().size(), 0);
}
void tst_qquicktableviewdelegate::dragToSelect()
{
// Check that the delegate is not blocking the user from
// being able to select cells using Drag.
LOAD_TABLEVIEW("unmodified.qml");
// When TableView is not interactive, SelectionRectangle
// will use Drag by default.
tableView->setInteractive(false);
QVERIFY(!tableView->selectionModel()->hasSelection());
QCOMPARE(tableView->selectionBehavior(), QQuickTableView::SelectCells);
model->appendColumn();
model->setData(0, 1, "0,1", Qt::DisplayRole);
QCOMPARE(model->columnCount(), 2);
QCOMPARE(model->rowCount(), 1);
QVERIFY(QQuickTest::qWaitForPolish(tableView));
// Drag on from cell 0,0 to 0,1
const auto item0_0 = getDelegateItem(0, 0);
QVERIFY(item0_0);
const auto item0_1 = getDelegateItem(0, 1);
QVERIFY(item0_1);
QQuickWindow *window = tableView->window();
const QPoint localPos0_0(item0_0->width() / 2, item0_0->height() / 2);
const QPoint windowPos0_0 = window->contentItem()->mapFromItem(item0_0, localPos0_0).toPoint();
const QPoint localPos0_1(item0_1->width() / 2, item0_1->height() / 2);
const QPoint windowPos0_1 = window->contentItem()->mapFromItem(item0_1, localPos0_1).toPoint();
QTest::mousePress(window, Qt::LeftButton, Qt::NoModifier, windowPos0_0);
QTest::mouseMove(window, windowPos0_1);
QTest::mouseRelease(window, Qt::LeftButton, Qt::NoModifier, windowPos0_1);
QCOMPARE(tableView->selectionModel()->selectedIndexes().size(), 2);
QVERIFY(item0_0->selected());
QVERIFY(item0_1->selected());
}
void tst_qquicktableviewdelegate::pressAndHoldToSelect()
{
// Check that the delegate is not blocking the user from
// being able to select cells using PressAndHold
LOAD_TABLEVIEW("unmodified.qml");
// When TableView is interactive, SelectionRectangle
// will use PressAndHold by default.
tableView->setInteractive(true);
QVERIFY(!tableView->selectionModel()->hasSelection());
QCOMPARE(tableView->selectionBehavior(), QQuickTableView::SelectCells);
// PressAndHold on cell 0,0
const auto item0_0 = getDelegateItem(0, 0);
QVERIFY(item0_0);
QQuickWindow *window = tableView->window();
const QPoint localPos0_0(item0_0->width() / 2, item0_0->height() / 2);
const QPoint windowPos0_0 = window->contentItem()->mapFromItem(item0_0, localPos0_0).toPoint();
QTest::mousePress(window, Qt::LeftButton, Qt::NoModifier, windowPos0_0);
QTRY_VERIFY(tableView->selectionModel()->hasSelection());
QCOMPARE(tableView->selectionModel()->selectedIndexes().size(), 1);
QVERIFY(item0_0->selected());
QTest::mouseRelease(window, Qt::LeftButton, Qt::NoModifier, windowPos0_0);
}
QQuickTableView *tst_qquicktableviewdelegate::getTableView()
{
return view->rootObject()->property("tableView").value<QQuickTableView *>();
}
QQuickTableViewDelegate *tst_qquicktableviewdelegate::getDelegateItem(int row, int column)
{
auto tableView = getTableView();
if (!tableView)
return nullptr;
return qobject_cast<QQuickTableViewDelegate *>(tableView->itemAtCell({column, row}));
}
QTEST_MAIN(tst_qquicktableviewdelegate)
#include "tst_qquicktableviewdelegate.moc"
|
