1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612
|
/* SPDX-License-Identifier: GPL-3.0-or-later
* Copyright © 2022 by The qTox Project Contributors
* Copyright © 2024-2025 The TokTok team.
*/
#include "src/model/friendlist/friendlistmanager.h"
#include <QSignalSpy>
#include <QTest>
#include <memory>
#include <utility>
class MockFriend : public IFriendListItem
{
public:
MockFriend()
: name("No Name")
, lastActivity(QDateTime::currentDateTime())
, online(false)
{
}
MockFriend(QString nameStr, bool onlineRes, QDateTime lastAct)
: name(std::move(nameStr))
, lastActivity(std::move(lastAct))
, online(onlineRes)
{
}
~MockFriend() override;
bool isFriend() const override
{
return true;
}
bool isConference() const override
{
return false;
}
bool isOnline() const override
{
return online;
}
bool widgetIsVisible() const override
{
return visible;
}
QString getNameItem() const override
{
return name;
}
QDateTime getLastActivity() const override
{
return lastActivity;
}
QWidget* getWidget() override
{
return nullptr;
}
void setWidgetVisible(bool v) override
{
visible = v;
}
private:
QString name;
QDateTime lastActivity;
bool online = false;
bool visible = true;
};
MockFriend::~MockFriend() = default;
class MockConference : public IFriendListItem
{
public:
MockConference()
: name("conference")
{
}
explicit MockConference(QString nameStr)
: name(std::move(nameStr))
{
}
~MockConference() override;
bool isFriend() const override
{
return false;
}
bool isConference() const override
{
return true;
}
bool isOnline() const override
{
return true;
}
bool widgetIsVisible() const override
{
return visible;
}
QString getNameItem() const override
{
return name;
}
QDateTime getLastActivity() const override
{
return QDateTime::currentDateTime();
}
QWidget* getWidget() override
{
return nullptr;
}
void setWidgetVisible(bool v) override
{
visible = v;
}
private:
QString name;
bool visible = true;
};
MockConference::~MockConference() = default;
class FriendItemsBuilder
{
public:
FriendItemsBuilder* addOfflineFriends()
{
QStringList testNames{".test",
"123",
"A test user",
"Aatest user",
"atest",
"btest",
"ctest",
"Test user",
"user with long nickname one",
"user with long nickname two"};
for (int i = 0; i < testNames.size(); ++i) {
int unsortedIndex = (i % 2) != 0 ? i - 1 : testNames.size() - i - 1; // Mixes positions
int sortedByActivityIndex = testNames.size() - i - 1;
unsortedAllFriends.append(testNames[unsortedIndex]);
sortedByNameOfflineFriends.append(testNames[i]);
sortedByActivityFriends.append(testNames[sortedByActivityIndex]);
}
return this;
}
FriendItemsBuilder* addOnlineFriends()
{
QStringList testNames{".test online",
"123 online",
"A test user online",
"Aatest user online",
"atest online",
"btest online",
"ctest online",
"Test user online",
"user with long nickname one online",
"user with long nickname two online"};
for (int i = 0; i < testNames.size(); ++i) {
int unsortedIndex = (i % 2) != 0 ? i - 1 : testNames.size() - i - 1;
int sortedByActivityIndex = testNames.size() - i - 1;
unsortedAllFriends.append(testNames[unsortedIndex]);
sortedByNameOnlineFriends.append(testNames[i]);
sortedByActivityFriends.append(testNames[sortedByActivityIndex]);
}
return this;
}
FriendItemsBuilder* addConferences()
{
unsortedConferences.append("Test Conference");
unsortedConferences.append("A Conference");
unsortedConferences.append("Test Conference long name");
unsortedConferences.append("Test Conference long aname");
unsortedConferences.append("123");
sortedByNameConferences.push_back("123");
sortedByNameConferences.push_back("A Conference");
sortedByNameConferences.push_back("Test Conference");
sortedByNameConferences.push_back("Test Conference long aname");
sortedByNameConferences.push_back("Test Conference long name");
return this;
}
FriendItemsBuilder* setConferencesOnTop(bool val)
{
conferencesOnTop = val;
return this;
}
bool getConferencesOnTop() const
{
return conferencesOnTop;
}
/**
* @brief buildUnsorted Creates items to init the FriendListManager.
* FriendListManager will own and manage these items
* @return Unsorted vector of items
*/
QVector<IFriendListItem*> buildUnsorted()
{
checkDifferentNames();
QVector<IFriendListItem*> vec;
for (auto name : unsortedAllFriends) {
vec.push_back(new MockFriend(name, isOnline(name), getDateTime(name)));
}
for (auto name : unsortedConferences) {
vec.push_back(new MockConference(name));
}
clear();
return vec;
}
/**
* @brief buildSortedByName Create items to compare with items
* from the FriendListManager. FriendItemsBuilder owns these items
* @return Sorted by name vector of items
*/
QVector<std::shared_ptr<IFriendListItem>> buildSortedByName()
{
QVector<std::shared_ptr<IFriendListItem>> vec;
if (!conferencesOnTop) {
for (auto name : sortedByNameOnlineFriends) {
vec.push_back(std::shared_ptr<IFriendListItem>(
new MockFriend(name, true, QDateTime::currentDateTime())));
}
for (auto name : sortedByNameConferences) {
vec.push_back(std::shared_ptr<IFriendListItem>(new MockConference(name)));
}
} else {
for (auto name : sortedByNameConferences) {
vec.push_back(std::shared_ptr<IFriendListItem>(new MockConference(name)));
}
for (auto name : sortedByNameOnlineFriends) {
vec.push_back(std::shared_ptr<IFriendListItem>(
new MockFriend(name, true, QDateTime::currentDateTime())));
}
}
for (auto name : sortedByNameOfflineFriends) {
vec.push_back(
std::shared_ptr<IFriendListItem>(new MockFriend(name, false, getDateTime(name))));
}
clear();
return vec;
}
/**
* @brief buildSortedByActivity Creates items to compare with items
* from FriendListManager. FriendItemsBuilder owns these items
* @return Sorted by activity vector of items
*/
QVector<std::shared_ptr<IFriendListItem>> buildSortedByActivity()
{
QVector<std::shared_ptr<IFriendListItem>> vec;
// Add conferences on top
for (auto name : sortedByNameConferences) {
vec.push_back(std::shared_ptr<IFriendListItem>(new MockConference(name)));
}
// Add friends and set the date of the last activity by index
QDateTime dateTime = QDateTime::currentDateTime();
for (auto name : sortedByActivityFriends) {
vec.push_back(std::shared_ptr<IFriendListItem>(
new MockFriend(name, isOnline(name), getDateTime(name))));
}
clear();
return vec;
}
private:
void clear()
{
sortedByNameOfflineFriends.clear();
sortedByNameOnlineFriends.clear();
sortedByNameConferences.clear();
sortedByActivityFriends.clear();
sortedByActivityConferences.clear();
unsortedAllFriends.clear();
unsortedConferences.clear();
conferencesOnTop = true;
}
bool isOnline(const QString& name)
{
return sortedByNameOnlineFriends.indexOf(name) != -1;
}
/**
* @brief checkDifferentNames The check is necessary for
* the correct setting of the online status
*/
void checkDifferentNames()
{
for (auto name : sortedByNameOnlineFriends) {
if (sortedByNameOfflineFriends.contains(name, Qt::CaseInsensitive)) {
QFAIL("Names in sortedByNameOnlineFriends and sortedByNameOfflineFriends "
"should be different");
break;
}
}
}
QDateTime getDateTime(const QString& name)
{
QDateTime dateTime = QDateTime::currentDateTime();
int pos = sortedByActivityFriends.indexOf(name);
if (pos == -1) {
return dateTime;
}
const int dayRatio = -1;
return dateTime.addDays(dayRatio * pos * pos);
}
QStringList sortedByNameOfflineFriends;
QStringList sortedByNameOnlineFriends;
QStringList sortedByNameConferences;
QStringList sortedByActivityFriends;
QStringList sortedByActivityConferences;
QStringList unsortedAllFriends;
QStringList unsortedConferences;
bool conferencesOnTop = true;
};
class TestFriendListManager : public QObject
{
Q_OBJECT
private slots:
void testAddFriendListItem();
void testSortByName();
void testSortByActivity();
void testSetFilter();
void testApplyFilterSearchString();
void testApplyFilterByStatus();
void testSetConferencesOnTop();
private:
std::unique_ptr<FriendListManager> createManagerWithItems(QVector<IFriendListItem*> itemsVec);
};
void TestFriendListManager::testAddFriendListItem()
{
auto manager = std::make_unique<FriendListManager>(0, this);
QSignalSpy spy(manager.get(), &FriendListManager::itemsChanged);
FriendItemsBuilder listBuilder;
auto checkFunc = [&](const QVector<IFriendListItem*> itemsVec) {
for (auto* item : itemsVec) {
manager->addFriendListItem(item);
}
QCOMPARE(manager->getItems().size(), itemsVec.size());
QCOMPARE(spy.count(), itemsVec.size());
spy.clear();
for (auto* item : itemsVec) {
manager->removeFriendListItem(item);
}
QCOMPARE(manager->getItems().size(), 0);
QCOMPARE(spy.count(), itemsVec.size());
spy.clear();
};
// Only friends
checkFunc(listBuilder.addOfflineFriends()->buildUnsorted());
checkFunc(listBuilder.addOfflineFriends()->addOnlineFriends()->buildUnsorted());
// Friends and conferences
checkFunc(listBuilder.addOfflineFriends()->addConferences()->buildUnsorted());
checkFunc(listBuilder.addOfflineFriends()->addOnlineFriends()->addConferences()->buildUnsorted());
// Only conferences
checkFunc(listBuilder.addConferences()->buildUnsorted());
}
void TestFriendListManager::testSortByName()
{
FriendItemsBuilder listBuilder;
auto unsortedVec =
listBuilder.addOfflineFriends()->addOnlineFriends()->addConferences()->buildUnsorted();
auto sortedVec =
listBuilder.addOfflineFriends()->addOnlineFriends()->addConferences()->buildSortedByName();
auto manager = createManagerWithItems(unsortedVec);
manager->sortByName();
bool success = manager->getPositionsChanged();
manager->sortByName();
QCOMPARE(success, true);
QCOMPARE(manager->getPositionsChanged(), false);
QCOMPARE(manager->getItems().size(), sortedVec.size());
QCOMPARE(manager->getConferencesOnTop(), listBuilder.getConferencesOnTop());
for (int i = 0; i < sortedVec.size(); ++i) {
IFriendListItem* fromManager = manager->getItems().at(i).get();
std::shared_ptr<IFriendListItem> fromSortedVec = sortedVec.at(i);
QCOMPARE(fromManager->getNameItem(), fromSortedVec->getNameItem());
}
}
void TestFriendListManager::testSortByActivity()
{
FriendItemsBuilder listBuilder;
auto unsortedVec =
listBuilder.addOfflineFriends()->addOnlineFriends()->addConferences()->buildUnsorted();
auto sortedVec =
listBuilder.addOfflineFriends()->addOnlineFriends()->addConferences()->buildSortedByActivity();
std::unique_ptr<FriendListManager> manager = createManagerWithItems(unsortedVec);
manager->sortByActivity();
bool success = manager->getPositionsChanged();
manager->sortByActivity();
QCOMPARE(success, true);
QCOMPARE(manager->getPositionsChanged(), false);
QCOMPARE(manager->getItems().size(), sortedVec.size());
for (int i = 0; i < sortedVec.size(); ++i) {
auto* fromManager = manager->getItems().at(i).get();
auto fromSortedVec = sortedVec.at(i);
QCOMPARE(fromManager->getNameItem(), fromSortedVec->getNameItem());
}
}
void TestFriendListManager::testSetFilter()
{
FriendItemsBuilder listBuilder;
auto manager = createManagerWithItems(
listBuilder.addOfflineFriends()->addOnlineFriends()->addConferences()->buildUnsorted());
QSignalSpy spy(manager.get(), &FriendListManager::itemsChanged);
manager->setFilter("", false, false, false);
QCOMPARE(spy.count(), 0);
manager->setFilter("Test", true, false, false);
manager->setFilter("Test", true, false, false);
QCOMPARE(spy.count(), 1);
}
void TestFriendListManager::testApplyFilterSearchString()
{
FriendItemsBuilder listBuilder;
auto manager = createManagerWithItems(
listBuilder.addOfflineFriends()->addOnlineFriends()->addConferences()->buildUnsorted());
QVector<std::shared_ptr<IFriendListItem>> resultVec;
QString testNameA = "NO_ITEMS_WITH_THIS_NAME";
QString testNameB = "Test Name B";
manager->sortByName();
manager->setFilter(testNameA, false, false, false);
manager->applyFilter();
resultVec = manager->getItems();
for (auto item : resultVec) {
QCOMPARE(item->widgetIsVisible(), false);
}
manager->sortByActivity();
manager->addFriendListItem(new MockFriend(testNameB, true, QDateTime::currentDateTime()));
manager->applyFilter();
resultVec = manager->getItems();
for (auto item : resultVec) {
QCOMPARE(item->widgetIsVisible(), false);
}
manager->addFriendListItem(new MockFriend(testNameA, true, QDateTime::currentDateTime()));
manager->applyFilter();
resultVec = manager->getItems();
for (auto item : resultVec) {
if (item->getNameItem() == testNameA) {
QCOMPARE(item->widgetIsVisible(), true);
} else {
QCOMPARE(item->widgetIsVisible(), false);
}
}
manager->setFilter("", false, false, false);
manager->applyFilter();
resultVec = manager->getItems();
for (auto item : resultVec) {
QCOMPARE(item->widgetIsVisible(), true);
}
}
void TestFriendListManager::testApplyFilterByStatus()
{
FriendItemsBuilder listBuilder;
auto manager = createManagerWithItems(
listBuilder.addOfflineFriends()->addOnlineFriends()->addConferences()->buildUnsorted());
auto onlineItems = listBuilder.addOnlineFriends()->buildSortedByName();
auto offlineItems = listBuilder.addOfflineFriends()->buildSortedByName();
auto conferenceItems = listBuilder.addConferences()->buildSortedByName();
manager->sortByName();
manager->setFilter("", true /*hideOnline*/, false /*hideOffline*/, false /*hideConferences*/);
manager->applyFilter();
for (auto item : manager->getItems()) {
if (item->isOnline() && item->isFriend()) {
QCOMPARE(item->widgetIsVisible(), false);
} else {
QCOMPARE(item->widgetIsVisible(), true);
}
}
manager->setFilter("", false /*hideOnline*/, true /*hideOffline*/, false /*hideConferences*/);
manager->applyFilter();
for (auto item : manager->getItems()) {
if (item->isOnline()) {
QCOMPARE(item->widgetIsVisible(), true);
} else {
QCOMPARE(item->widgetIsVisible(), false);
}
}
manager->setFilter("", false /*hideOnline*/, false /*hideOffline*/, true /*hideConferences*/);
manager->applyFilter();
for (auto item : manager->getItems()) {
if (item->isConference()) {
QCOMPARE(item->widgetIsVisible(), false);
} else {
QCOMPARE(item->widgetIsVisible(), true);
}
}
manager->setFilter("", true /*hideOnline*/, true /*hideOffline*/, true /*hideConferences*/);
manager->applyFilter();
for (auto item : manager->getItems()) {
QCOMPARE(item->widgetIsVisible(), false);
}
manager->setFilter("", false /*hideOnline*/, false /*hideOffline*/, false /*hideConferences*/);
manager->applyFilter();
for (auto item : manager->getItems()) {
QCOMPARE(item->widgetIsVisible(), true);
}
}
void TestFriendListManager::testSetConferencesOnTop()
{
FriendItemsBuilder listBuilder;
auto manager = createManagerWithItems(
listBuilder.addOfflineFriends()->addOnlineFriends()->addConferences()->buildUnsorted());
auto sortedVecOnlineOnTop = listBuilder.addOfflineFriends()
->addOnlineFriends()
->addConferences()
->setConferencesOnTop(false)
->buildSortedByName();
auto sortedVecConferencesOnTop = listBuilder.addOfflineFriends()
->addOnlineFriends()
->addConferences()
->setConferencesOnTop(true)
->buildSortedByName();
manager->setConferencesOnTop(false);
manager->sortByName();
for (int i = 0; i < manager->getItems().size(); ++i) {
auto fromManager = manager->getItems().at(i);
auto fromSortedVec = sortedVecOnlineOnTop.at(i);
QCOMPARE(fromManager->getNameItem(), fromSortedVec->getNameItem());
}
manager->setConferencesOnTop(true);
manager->sortByName();
for (int i = 0; i < manager->getItems().size(); ++i) {
auto fromManager = manager->getItems().at(i);
auto fromSortedVec = sortedVecConferencesOnTop.at(i);
QCOMPARE(fromManager->getNameItem(), fromSortedVec->getNameItem());
}
}
std::unique_ptr<FriendListManager>
TestFriendListManager::createManagerWithItems(const QVector<IFriendListItem*> itemsVec)
{
std::unique_ptr<FriendListManager> manager = std::make_unique<FriendListManager>(0, this);
for (auto* item : itemsVec) {
manager->addFriendListItem(item);
}
return manager;
}
QTEST_GUILESS_MAIN(TestFriendListManager)
#include "friendlistmanager_test.moc"
|