1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112 6113 6114 6115 6116 6117 6118 6119 6120 6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152 6153 6154 6155 6156 6157 6158 6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179 6180 6181 6182 6183 6184 6185 6186 6187 6188 6189 6190 6191 6192 6193 6194 6195 6196 6197 6198 6199 6200 6201 6202 6203 6204 6205 6206 6207 6208 6209 6210 6211 6212 6213 6214 6215 6216 6217 6218 6219 6220 6221 6222 6223 6224 6225 6226 6227 6228 6229 6230 6231 6232 6233 6234 6235 6236 6237 6238 6239 6240 6241 6242 6243 6244 6245 6246 6247 6248 6249 6250 6251 6252 6253 6254 6255 6256 6257 6258 6259 6260 6261 6262 6263 6264 6265 6266 6267 6268 6269 6270 6271 6272 6273 6274 6275 6276 6277 6278 6279 6280 6281 6282 6283 6284 6285 6286 6287 6288 6289 6290 6291 6292 6293 6294 6295 6296 6297 6298 6299 6300 6301 6302 6303 6304 6305 6306 6307 6308 6309 6310 6311 6312 6313 6314 6315 6316 6317 6318 6319 6320 6321 6322 6323 6324 6325 6326 6327 6328 6329 6330 6331 6332 6333 6334 6335 6336 6337 6338 6339 6340 6341 6342 6343 6344 6345 6346 6347 6348 6349 6350 6351 6352 6353 6354 6355 6356 6357 6358 6359 6360 6361 6362 6363 6364 6365 6366 6367 6368 6369 6370 6371 6372 6373 6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441 6442 6443 6444 6445 6446 6447 6448 6449 6450 6451 6452 6453 6454 6455 6456 6457 6458 6459 6460 6461 6462 6463 6464 6465 6466 6467 6468 6469 6470 6471 6472 6473 6474 6475 6476 6477 6478 6479 6480 6481 6482 6483 6484 6485 6486 6487 6488 6489 6490 6491 6492 6493 6494 6495 6496 6497 6498 6499 6500 6501 6502 6503 6504 6505 6506 6507 6508 6509 6510 6511 6512 6513 6514 6515 6516 6517 6518 6519 6520 6521 6522 6523 6524 6525 6526 6527 6528 6529 6530 6531 6532 6533 6534 6535 6536 6537 6538 6539 6540 6541 6542 6543 6544 6545 6546 6547 6548 6549 6550 6551 6552 6553 6554 6555 6556 6557 6558 6559 6560 6561 6562 6563 6564 6565 6566 6567 6568 6569 6570 6571 6572 6573 6574 6575 6576 6577 6578 6579 6580 6581 6582 6583 6584 6585 6586 6587 6588 6589 6590 6591 6592 6593 6594 6595 6596 6597 6598 6599 6600 6601 6602 6603 6604 6605 6606 6607 6608 6609 6610 6611 6612 6613 6614 6615 6616 6617 6618 6619 6620 6621 6622 6623 6624 6625 6626 6627 6628 6629 6630 6631 6632 6633 6634 6635 6636 6637 6638 6639 6640 6641 6642 6643 6644 6645 6646 6647 6648 6649 6650 6651 6652 6653 6654 6655 6656 6657 6658 6659 6660 6661 6662 6663 6664 6665 6666 6667 6668 6669 6670 6671 6672 6673 6674 6675 6676 6677 6678 6679 6680 6681 6682 6683 6684 6685 6686 6687 6688 6689 6690 6691 6692 6693 6694 6695 6696 6697 6698 6699 6700 6701 6702 6703 6704 6705 6706 6707 6708 6709 6710 6711 6712 6713 6714 6715 6716 6717 6718 6719 6720 6721 6722 6723 6724 6725 6726 6727 6728 6729 6730 6731 6732 6733 6734 6735 6736 6737 6738 6739 6740 6741 6742 6743 6744 6745 6746 6747 6748 6749 6750 6751 6752 6753 6754 6755 6756 6757 6758 6759 6760 6761 6762 6763 6764 6765 6766 6767 6768 6769 6770 6771 6772 6773 6774 6775 6776 6777 6778 6779 6780 6781 6782 6783 6784 6785 6786 6787 6788 6789 6790 6791 6792 6793 6794 6795 6796 6797 6798 6799 6800 6801 6802 6803 6804 6805 6806 6807 6808 6809 6810 6811 6812 6813 6814 6815 6816 6817 6818 6819 6820 6821 6822 6823 6824 6825 6826 6827 6828 6829 6830 6831 6832 6833 6834 6835 6836 6837 6838 6839 6840 6841 6842 6843 6844 6845 6846 6847 6848 6849 6850 6851 6852 6853 6854 6855 6856 6857 6858 6859 6860 6861 6862 6863 6864 6865 6866 6867 6868 6869 6870 6871 6872 6873 6874 6875 6876 6877 6878 6879 6880 6881 6882 6883 6884 6885 6886 6887 6888 6889 6890 6891 6892 6893 6894 6895 6896 6897 6898 6899 6900 6901 6902 6903 6904 6905 6906 6907 6908 6909 6910 6911 6912 6913 6914 6915 6916 6917 6918 6919 6920 6921 6922 6923 6924 6925 6926 6927 6928 6929 6930 6931 6932 6933 6934 6935 6936 6937 6938 6939 6940 6941 6942 6943 6944 6945 6946 6947 6948 6949 6950 6951 6952 6953 6954 6955 6956 6957 6958 6959 6960 6961 6962 6963 6964 6965 6966 6967 6968 6969 6970 6971 6972 6973 6974 6975 6976 6977 6978 6979 6980 6981 6982 6983 6984 6985 6986 6987 6988 6989 6990 6991 6992 6993 6994 6995 6996 6997 6998 6999 7000 7001 7002 7003 7004 7005 7006 7007 7008 7009 7010 7011 7012 7013 7014 7015 7016 7017 7018 7019 7020 7021 7022 7023 7024 7025 7026 7027 7028 7029 7030 7031 7032 7033 7034 7035 7036 7037 7038 7039 7040 7041 7042 7043 7044 7045 7046 7047 7048 7049 7050 7051 7052 7053 7054 7055 7056 7057 7058 7059 7060 7061 7062 7063 7064 7065 7066 7067 7068 7069 7070 7071 7072 7073 7074 7075 7076 7077 7078 7079 7080 7081 7082 7083 7084 7085 7086 7087 7088 7089 7090 7091 7092 7093 7094 7095 7096 7097 7098 7099 7100 7101 7102 7103 7104 7105 7106 7107 7108 7109 7110 7111 7112 7113 7114 7115 7116 7117 7118 7119 7120 7121 7122 7123 7124 7125 7126 7127 7128 7129 7130 7131 7132 7133 7134 7135 7136 7137 7138 7139 7140 7141 7142 7143 7144 7145 7146 7147 7148 7149 7150 7151 7152 7153 7154 7155 7156 7157 7158 7159 7160 7161 7162 7163 7164 7165 7166 7167 7168 7169 7170 7171 7172 7173 7174 7175 7176 7177 7178 7179 7180 7181 7182 7183 7184 7185 7186 7187 7188 7189 7190 7191 7192 7193 7194 7195 7196 7197 7198 7199 7200 7201 7202 7203 7204 7205 7206 7207 7208 7209 7210 7211 7212 7213 7214 7215 7216 7217 7218 7219 7220 7221 7222 7223 7224 7225 7226 7227 7228 7229 7230 7231 7232 7233 7234 7235 7236 7237 7238 7239 7240 7241 7242 7243 7244 7245 7246 7247 7248 7249 7250 7251 7252 7253 7254 7255 7256 7257 7258 7259 7260 7261 7262 7263 7264 7265 7266 7267 7268 7269 7270 7271 7272 7273 7274 7275 7276 7277 7278 7279 7280 7281 7282 7283 7284 7285 7286 7287 7288 7289 7290 7291 7292 7293 7294 7295 7296 7297 7298 7299 7300 7301 7302 7303 7304 7305 7306 7307 7308 7309 7310 7311 7312 7313 7314 7315 7316 7317 7318 7319 7320 7321 7322 7323 7324 7325 7326 7327 7328 7329 7330 7331 7332 7333 7334 7335 7336 7337 7338 7339 7340 7341 7342 7343 7344 7345 7346 7347 7348 7349 7350 7351 7352 7353 7354 7355 7356 7357 7358 7359 7360 7361 7362 7363 7364 7365 7366 7367 7368 7369 7370 7371 7372 7373 7374 7375 7376 7377 7378 7379 7380 7381 7382 7383 7384 7385 7386 7387 7388 7389 7390 7391 7392 7393 7394 7395 7396 7397 7398 7399 7400 7401 7402 7403 7404 7405 7406 7407 7408 7409 7410 7411 7412 7413 7414 7415 7416 7417 7418 7419 7420 7421 7422 7423 7424 7425 7426 7427 7428 7429 7430 7431 7432 7433 7434 7435 7436 7437 7438 7439 7440 7441 7442 7443 7444 7445 7446 7447 7448 7449 7450 7451 7452 7453 7454 7455 7456 7457 7458 7459 7460 7461 7462 7463 7464 7465 7466 7467 7468 7469 7470 7471 7472 7473 7474 7475 7476 7477 7478 7479 7480 7481 7482 7483 7484 7485 7486 7487 7488 7489 7490 7491 7492 7493 7494 7495 7496 7497 7498 7499 7500 7501 7502 7503 7504 7505 7506 7507 7508 7509 7510 7511 7512 7513 7514 7515 7516 7517 7518 7519 7520 7521 7522 7523 7524 7525 7526 7527 7528 7529 7530 7531 7532 7533 7534 7535 7536 7537 7538 7539 7540 7541 7542 7543 7544 7545 7546 7547 7548 7549 7550 7551 7552 7553 7554 7555 7556 7557 7558 7559 7560 7561 7562 7563 7564 7565 7566 7567 7568 7569 7570 7571 7572 7573 7574 7575 7576 7577 7578 7579 7580 7581 7582 7583 7584 7585 7586 7587 7588 7589 7590 7591 7592 7593 7594 7595 7596 7597 7598 7599 7600 7601 7602 7603 7604 7605 7606 7607 7608 7609 7610 7611 7612 7613 7614 7615 7616 7617 7618 7619 7620 7621 7622 7623 7624 7625 7626 7627 7628 7629 7630 7631 7632 7633 7634 7635 7636 7637 7638 7639 7640 7641 7642 7643 7644 7645 7646 7647 7648 7649 7650 7651 7652 7653 7654 7655 7656 7657 7658 7659 7660 7661 7662 7663 7664 7665 7666 7667 7668 7669 7670 7671 7672 7673 7674 7675 7676 7677 7678 7679 7680 7681 7682 7683 7684 7685 7686 7687 7688 7689 7690 7691 7692 7693 7694 7695 7696 7697 7698 7699 7700 7701 7702 7703 7704 7705 7706 7707 7708 7709 7710 7711 7712 7713 7714 7715 7716 7717 7718 7719 7720 7721 7722 7723 7724 7725 7726 7727 7728 7729 7730 7731 7732 7733 7734 7735 7736 7737 7738 7739 7740 7741 7742 7743 7744 7745 7746 7747 7748 7749 7750 7751 7752 7753 7754 7755 7756 7757 7758 7759 7760 7761 7762 7763 7764 7765 7766 7767 7768 7769 7770 7771 7772 7773 7774 7775 7776 7777 7778 7779 7780 7781 7782 7783 7784 7785 7786 7787 7788 7789 7790 7791 7792 7793 7794 7795 7796 7797 7798 7799 7800 7801 7802 7803 7804 7805 7806 7807 7808 7809 7810 7811 7812 7813 7814 7815 7816 7817 7818 7819 7820 7821 7822 7823 7824 7825 7826 7827 7828 7829 7830 7831 7832 7833 7834 7835 7836 7837 7838 7839 7840 7841 7842 7843 7844 7845 7846 7847 7848 7849 7850 7851 7852 7853 7854 7855 7856 7857 7858 7859 7860 7861 7862 7863 7864 7865 7866 7867 7868 7869 7870 7871 7872 7873 7874 7875 7876 7877 7878 7879 7880 7881 7882 7883 7884 7885 7886 7887 7888 7889 7890 7891 7892 7893 7894 7895 7896 7897 7898 7899 7900 7901 7902 7903 7904 7905 7906 7907 7908 7909 7910 7911 7912 7913 7914 7915 7916 7917 7918 7919 7920 7921 7922 7923 7924 7925 7926 7927 7928 7929 7930 7931 7932 7933 7934 7935 7936 7937 7938 7939 7940 7941 7942 7943 7944 7945 7946 7947 7948 7949 7950 7951 7952 7953 7954 7955 7956 7957 7958 7959 7960 7961 7962 7963 7964 7965 7966 7967 7968 7969 7970 7971 7972 7973 7974 7975 7976 7977 7978 7979 7980 7981 7982 7983 7984 7985 7986 7987 7988 7989 7990 7991 7992 7993 7994 7995 7996 7997 7998 7999 8000 8001 8002 8003 8004 8005 8006 8007 8008 8009 8010 8011 8012 8013 8014 8015 8016 8017 8018 8019 8020 8021 8022 8023 8024 8025 8026 8027 8028 8029 8030 8031 8032 8033 8034 8035 8036 8037 8038 8039 8040 8041 8042 8043 8044 8045 8046 8047 8048 8049 8050 8051 8052 8053 8054 8055 8056 8057 8058 8059 8060 8061 8062 8063 8064 8065 8066 8067 8068 8069 8070 8071 8072 8073 8074 8075 8076 8077 8078 8079 8080 8081 8082 8083 8084 8085 8086 8087 8088 8089 8090 8091 8092 8093 8094 8095 8096 8097 8098 8099 8100 8101 8102 8103 8104 8105 8106 8107 8108 8109 8110 8111 8112 8113 8114 8115 8116 8117 8118 8119 8120 8121 8122 8123 8124 8125 8126 8127 8128 8129 8130 8131 8132 8133 8134 8135 8136 8137 8138 8139 8140 8141 8142 8143 8144 8145 8146 8147 8148 8149 8150 8151 8152 8153 8154 8155 8156 8157 8158 8159 8160 8161 8162 8163 8164 8165 8166 8167 8168 8169 8170 8171 8172 8173 8174 8175 8176 8177 8178 8179 8180 8181 8182 8183 8184 8185 8186 8187 8188 8189 8190 8191 8192 8193 8194 8195 8196 8197 8198 8199 8200 8201 8202 8203 8204 8205 8206 8207 8208 8209 8210 8211 8212 8213 8214 8215 8216 8217 8218 8219 8220 8221 8222 8223 8224 8225 8226 8227 8228 8229 8230 8231 8232 8233 8234 8235 8236 8237 8238 8239 8240 8241 8242 8243 8244 8245 8246 8247 8248 8249 8250 8251 8252 8253 8254 8255 8256 8257 8258 8259 8260 8261 8262 8263 8264 8265 8266 8267 8268 8269 8270 8271 8272 8273 8274 8275 8276 8277 8278 8279 8280 8281 8282 8283 8284 8285 8286 8287 8288 8289 8290 8291 8292 8293 8294 8295 8296 8297 8298 8299 8300 8301 8302 8303 8304 8305 8306 8307 8308 8309 8310 8311 8312 8313 8314 8315 8316 8317 8318 8319 8320 8321 8322 8323 8324 8325 8326 8327 8328 8329 8330 8331 8332 8333 8334 8335 8336 8337 8338 8339 8340 8341 8342 8343 8344 8345 8346 8347 8348 8349 8350 8351 8352 8353 8354 8355 8356 8357 8358 8359 8360 8361 8362 8363 8364 8365 8366 8367 8368 8369 8370 8371 8372 8373 8374 8375 8376 8377 8378 8379 8380 8381 8382 8383 8384 8385 8386 8387 8388 8389 8390 8391 8392 8393 8394 8395 8396 8397 8398 8399 8400 8401 8402 8403 8404 8405 8406 8407 8408 8409 8410 8411 8412 8413 8414 8415 8416 8417 8418 8419 8420 8421 8422 8423 8424 8425 8426 8427 8428 8429 8430 8431 8432 8433 8434 8435 8436 8437 8438 8439 8440 8441 8442 8443 8444 8445 8446 8447 8448 8449 8450 8451 8452 8453 8454 8455 8456 8457 8458 8459 8460 8461 8462 8463 8464 8465 8466 8467 8468 8469 8470 8471 8472 8473 8474 8475 8476 8477 8478 8479 8480 8481 8482 8483 8484 8485 8486 8487 8488 8489 8490 8491 8492 8493 8494 8495 8496 8497 8498 8499 8500 8501 8502 8503 8504 8505 8506 8507 8508 8509 8510 8511 8512 8513 8514 8515 8516 8517 8518 8519 8520 8521 8522 8523 8524 8525 8526 8527 8528 8529 8530 8531 8532 8533 8534 8535 8536 8537 8538 8539 8540 8541 8542 8543 8544 8545 8546 8547 8548 8549 8550 8551 8552 8553 8554 8555 8556 8557 8558 8559 8560 8561 8562 8563 8564 8565 8566 8567 8568 8569 8570 8571 8572 8573 8574 8575 8576 8577 8578 8579 8580 8581 8582 8583 8584 8585 8586 8587 8588 8589 8590 8591 8592 8593 8594 8595 8596 8597 8598 8599 8600 8601 8602 8603 8604 8605 8606 8607 8608 8609 8610 8611 8612 8613 8614 8615 8616 8617 8618 8619 8620 8621 8622 8623 8624 8625 8626 8627 8628 8629 8630 8631 8632 8633 8634 8635 8636 8637 8638 8639 8640 8641 8642 8643 8644 8645 8646 8647 8648 8649 8650 8651 8652 8653 8654 8655 8656 8657 8658 8659 8660 8661 8662 8663 8664 8665 8666 8667 8668 8669 8670 8671 8672 8673 8674 8675 8676 8677 8678 8679 8680 8681 8682 8683 8684 8685 8686 8687 8688 8689 8690 8691 8692 8693 8694 8695 8696 8697 8698 8699 8700 8701 8702 8703 8704 8705 8706 8707 8708 8709 8710 8711 8712 8713 8714 8715 8716 8717 8718 8719 8720 8721 8722 8723 8724 8725 8726 8727 8728 8729 8730 8731 8732 8733 8734 8735 8736 8737 8738 8739 8740 8741 8742 8743 8744 8745 8746 8747 8748 8749 8750 8751 8752 8753 8754 8755 8756 8757 8758 8759 8760 8761 8762 8763 8764 8765 8766 8767 8768 8769 8770 8771 8772 8773 8774 8775 8776 8777 8778 8779 8780 8781 8782 8783 8784 8785 8786 8787 8788 8789 8790 8791 8792 8793 8794 8795 8796 8797 8798 8799 8800 8801 8802 8803 8804 8805 8806 8807 8808 8809 8810 8811 8812 8813 8814 8815 8816 8817 8818 8819 8820 8821 8822 8823 8824 8825 8826 8827 8828 8829 8830 8831 8832 8833 8834 8835 8836 8837 8838 8839 8840 8841 8842 8843 8844 8845 8846 8847 8848 8849 8850 8851 8852 8853 8854 8855 8856 8857 8858 8859 8860 8861 8862 8863 8864 8865 8866 8867 8868 8869 8870 8871 8872 8873 8874 8875 8876 8877 8878 8879 8880 8881 8882 8883 8884 8885 8886 8887 8888 8889 8890 8891 8892 8893 8894 8895 8896 8897 8898 8899 8900 8901 8902 8903 8904 8905 8906 8907 8908 8909 8910 8911 8912 8913 8914 8915 8916 8917 8918 8919 8920 8921 8922 8923 8924 8925 8926 8927 8928 8929 8930 8931 8932 8933 8934 8935 8936 8937 8938 8939 8940 8941 8942 8943 8944 8945 8946 8947 8948 8949 8950 8951 8952 8953 8954 8955 8956 8957 8958 8959 8960 8961 8962 8963 8964 8965 8966 8967 8968 8969 8970 8971 8972 8973 8974 8975 8976 8977 8978 8979 8980 8981 8982 8983 8984 8985 8986 8987 8988 8989 8990 8991 8992 8993 8994 8995 8996 8997 8998 8999 9000 9001 9002 9003 9004 9005 9006 9007 9008 9009 9010 9011 9012 9013 9014 9015 9016 9017 9018 9019 9020 9021 9022 9023 9024 9025 9026 9027 9028 9029 9030 9031 9032 9033 9034 9035 9036 9037 9038 9039 9040 9041 9042 9043 9044 9045 9046 9047 9048 9049 9050 9051 9052 9053 9054 9055 9056 9057 9058 9059 9060 9061 9062 9063 9064 9065 9066 9067 9068 9069 9070 9071 9072 9073 9074 9075 9076 9077 9078 9079 9080 9081 9082 9083 9084 9085 9086 9087 9088 9089 9090 9091 9092 9093 9094 9095 9096 9097 9098 9099 9100 9101 9102 9103 9104 9105 9106 9107 9108 9109 9110 9111 9112 9113 9114 9115 9116 9117 9118 9119 9120 9121 9122 9123 9124 9125 9126 9127 9128 9129 9130 9131 9132 9133 9134 9135 9136 9137 9138 9139 9140 9141 9142 9143 9144 9145 9146 9147 9148 9149 9150 9151 9152 9153 9154 9155 9156 9157 9158 9159 9160 9161 9162 9163 9164 9165 9166 9167 9168 9169 9170 9171 9172 9173 9174 9175 9176 9177 9178 9179 9180 9181 9182 9183 9184 9185 9186 9187 9188 9189 9190 9191 9192 9193 9194 9195 9196 9197 9198 9199 9200 9201 9202 9203 9204 9205 9206 9207 9208 9209 9210 9211 9212 9213 9214 9215 9216 9217 9218 9219 9220 9221 9222 9223 9224 9225 9226 9227 9228 9229 9230 9231 9232 9233 9234 9235 9236 9237 9238 9239 9240 9241 9242 9243 9244 9245 9246 9247 9248 9249 9250 9251 9252 9253 9254 9255 9256 9257 9258 9259 9260 9261 9262 9263 9264 9265 9266 9267 9268 9269 9270 9271 9272 9273 9274 9275 9276 9277 9278 9279 9280 9281 9282 9283 9284 9285 9286 9287 9288 9289 9290 9291 9292 9293 9294 9295 9296 9297 9298 9299 9300 9301 9302 9303 9304 9305 9306 9307 9308 9309 9310 9311 9312 9313 9314 9315 9316 9317 9318 9319 9320 9321 9322 9323 9324 9325 9326 9327 9328 9329 9330 9331 9332 9333 9334 9335 9336 9337 9338 9339 9340 9341 9342 9343 9344 9345 9346 9347 9348 9349 9350 9351 9352 9353 9354 9355 9356 9357 9358 9359 9360 9361 9362 9363 9364 9365 9366 9367 9368 9369 9370 9371 9372 9373 9374 9375 9376 9377 9378 9379 9380 9381 9382 9383 9384 9385 9386 9387 9388 9389 9390 9391 9392 9393 9394 9395 9396 9397 9398 9399 9400 9401 9402 9403 9404 9405 9406 9407 9408 9409 9410 9411 9412 9413 9414 9415 9416 9417 9418 9419 9420 9421 9422 9423 9424 9425 9426 9427 9428 9429 9430 9431 9432 9433 9434 9435 9436 9437 9438 9439 9440 9441 9442 9443 9444 9445 9446 9447 9448 9449 9450 9451 9452 9453 9454 9455 9456 9457 9458 9459 9460 9461 9462 9463 9464 9465 9466 9467 9468 9469 9470 9471 9472 9473 9474 9475 9476 9477 9478 9479 9480 9481 9482 9483 9484 9485 9486 9487 9488 9489 9490 9491 9492 9493 9494 9495 9496 9497 9498 9499 9500 9501 9502 9503 9504 9505 9506 9507 9508 9509 9510 9511 9512 9513 9514 9515 9516 9517 9518 9519 9520 9521 9522 9523 9524 9525 9526 9527 9528 9529 9530 9531 9532 9533 9534 9535 9536 9537 9538 9539 9540 9541 9542 9543 9544 9545 9546 9547 9548 9549 9550 9551 9552 9553 9554 9555 9556 9557 9558 9559 9560 9561 9562 9563 9564 9565 9566 9567 9568 9569 9570 9571 9572 9573 9574 9575 9576 9577 9578 9579 9580 9581 9582 9583 9584 9585 9586 9587 9588 9589 9590 9591 9592 9593 9594 9595 9596 9597 9598 9599 9600 9601 9602 9603 9604 9605 9606 9607 9608 9609 9610 9611 9612 9613 9614 9615 9616 9617 9618 9619 9620 9621 9622 9623 9624 9625 9626 9627 9628 9629 9630 9631 9632 9633 9634 9635 9636 9637 9638 9639 9640 9641 9642 9643 9644 9645 9646 9647 9648 9649 9650 9651 9652 9653 9654 9655 9656 9657 9658 9659 9660 9661 9662 9663 9664 9665 9666 9667 9668 9669 9670 9671 9672 9673 9674 9675 9676 9677 9678 9679 9680 9681 9682 9683 9684 9685 9686 9687 9688 9689 9690 9691 9692 9693 9694 9695 9696 9697 9698 9699 9700 9701 9702 9703 9704 9705 9706 9707 9708 9709 9710 9711 9712 9713 9714 9715 9716 9717 9718 9719 9720 9721 9722 9723 9724 9725 9726 9727 9728 9729 9730 9731 9732 9733 9734 9735 9736 9737 9738 9739 9740 9741 9742 9743 9744 9745 9746 9747 9748 9749 9750 9751 9752 9753 9754 9755 9756 9757 9758 9759 9760 9761 9762 9763 9764 9765 9766 9767 9768 9769 9770 9771 9772 9773 9774 9775 9776 9777 9778 9779 9780 9781 9782 9783 9784 9785 9786 9787 9788 9789 9790 9791 9792 9793 9794 9795 9796 9797 9798 9799 9800 9801 9802 9803 9804 9805 9806 9807 9808 9809 9810 9811 9812 9813 9814 9815 9816 9817 9818 9819 9820 9821 9822 9823 9824 9825 9826 9827 9828 9829 9830 9831 9832 9833 9834 9835 9836 9837 9838 9839 9840 9841 9842 9843 9844 9845 9846 9847 9848 9849 9850 9851 9852 9853 9854 9855 9856 9857 9858 9859 9860 9861 9862 9863 9864 9865 9866 9867 9868 9869 9870 9871 9872 9873 9874 9875 9876 9877 9878 9879 9880 9881 9882 9883 9884 9885 9886 9887 9888 9889 9890 9891 9892 9893 9894 9895 9896 9897 9898 9899 9900 9901 9902 9903 9904 9905 9906 9907 9908 9909 9910 9911 9912 9913 9914 9915 9916 9917 9918 9919 9920 9921 9922 9923 9924 9925 9926 9927 9928 9929 9930 9931 9932 9933 9934 9935 9936 9937 9938 9939 9940 9941 9942 9943 9944 9945 9946 9947 9948 9949 9950 9951 9952 9953 9954 9955 9956 9957 9958 9959 9960 9961 9962 9963 9964 9965 9966 9967 9968 9969 9970 9971 9972 9973 9974 9975 9976 9977 9978 9979 9980 9981 9982 9983 9984 9985 9986 9987 9988 9989 9990 9991 9992 9993 9994 9995 9996 9997 9998 9999 10000 10001 10002 10003 10004 10005 10006 10007 10008 10009 10010 10011 10012 10013 10014 10015 10016 10017 10018 10019 10020 10021 10022 10023 10024 10025 10026 10027 10028 10029 10030 10031 10032 10033 10034 10035 10036 10037 10038 10039 10040 10041 10042 10043 10044 10045 10046 10047 10048 10049 10050 10051 10052 10053 10054 10055 10056 10057 10058 10059 10060 10061 10062 10063 10064 10065 10066 10067 10068 10069 10070 10071 10072 10073 10074 10075 10076 10077 10078 10079 10080 10081 10082 10083 10084 10085 10086 10087 10088 10089 10090 10091 10092 10093 10094 10095 10096 10097 10098 10099 10100 10101 10102 10103 10104 10105 10106 10107 10108 10109 10110 10111 10112 10113 10114 10115 10116 10117 10118 10119 10120 10121 10122 10123 10124 10125 10126 10127 10128 10129 10130 10131 10132 10133 10134 10135 10136 10137 10138 10139 10140 10141 10142 10143 10144 10145 10146 10147 10148 10149 10150 10151 10152 10153 10154 10155 10156 10157 10158 10159 10160 10161 10162 10163 10164 10165 10166 10167 10168 10169 10170 10171 10172 10173 10174 10175 10176 10177 10178 10179 10180 10181 10182 10183 10184 10185 10186 10187 10188 10189 10190 10191 10192 10193 10194 10195 10196 10197 10198 10199 10200 10201 10202 10203 10204 10205 10206 10207 10208 10209 10210 10211 10212 10213 10214 10215 10216 10217 10218 10219 10220 10221 10222 10223 10224 10225 10226 10227 10228 10229 10230 10231 10232 10233 10234 10235 10236 10237 10238 10239 10240 10241 10242 10243 10244 10245 10246 10247 10248 10249 10250 10251 10252 10253 10254 10255 10256 10257 10258 10259 10260 10261 10262 10263 10264 10265 10266 10267 10268 10269 10270 10271 10272 10273 10274 10275 10276 10277 10278 10279 10280 10281 10282 10283 10284 10285 10286 10287 10288 10289 10290 10291 10292 10293 10294 10295 10296 10297 10298 10299 10300 10301 10302 10303 10304 10305 10306 10307 10308 10309 10310 10311 10312 10313 10314 10315 10316 10317 10318 10319 10320 10321 10322 10323 10324 10325 10326 10327 10328 10329 10330 10331 10332 10333 10334 10335 10336 10337 10338 10339 10340 10341 10342 10343 10344 10345 10346 10347 10348 10349 10350 10351 10352 10353 10354 10355 10356 10357 10358 10359 10360 10361 10362 10363 10364 10365 10366 10367 10368 10369 10370 10371 10372 10373 10374 10375 10376 10377 10378 10379 10380 10381 10382 10383 10384 10385 10386 10387 10388 10389 10390 10391 10392 10393 10394 10395 10396 10397 10398 10399 10400 10401 10402 10403 10404 10405 10406 10407 10408 10409 10410 10411 10412 10413 10414 10415 10416 10417 10418 10419 10420 10421 10422 10423 10424 10425 10426 10427 10428 10429 10430 10431 10432 10433 10434 10435 10436 10437 10438 10439 10440 10441 10442 10443 10444 10445 10446 10447 10448 10449 10450 10451 10452 10453 10454 10455 10456 10457 10458 10459 10460 10461 10462 10463 10464 10465 10466 10467 10468 10469 10470 10471 10472 10473 10474 10475 10476 10477 10478 10479 10480 10481 10482 10483 10484 10485 10486 10487 10488 10489 10490 10491 10492 10493 10494 10495 10496 10497 10498 10499 10500 10501 10502 10503 10504 10505 10506 10507 10508 10509 10510 10511 10512 10513 10514 10515 10516 10517 10518 10519 10520 10521 10522 10523 10524 10525 10526 10527 10528 10529 10530 10531 10532 10533 10534 10535 10536 10537 10538 10539 10540 10541 10542 10543 10544 10545 10546 10547 10548 10549 10550 10551 10552 10553 10554 10555 10556 10557 10558 10559 10560 10561 10562 10563 10564 10565 10566 10567 10568 10569 10570 10571 10572 10573 10574 10575 10576 10577 10578 10579 10580 10581 10582 10583 10584 10585 10586 10587 10588 10589 10590 10591 10592 10593 10594 10595 10596 10597 10598 10599 10600 10601 10602 10603 10604 10605 10606 10607 10608 10609 10610 10611 10612 10613 10614 10615 10616 10617 10618 10619 10620 10621 10622 10623 10624 10625 10626 10627 10628 10629 10630 10631 10632 10633 10634 10635 10636 10637 10638 10639 10640 10641 10642 10643 10644 10645 10646 10647 10648 10649 10650 10651 10652 10653 10654 10655 10656 10657 10658 10659 10660 10661 10662 10663 10664 10665 10666 10667 10668 10669 10670 10671 10672 10673 10674 10675 10676 10677 10678 10679 10680 10681 10682 10683 10684 10685 10686 10687 10688 10689 10690 10691 10692 10693 10694 10695 10696 10697 10698 10699 10700 10701 10702 10703 10704 10705 10706 10707 10708 10709 10710 10711 10712 10713 10714 10715 10716 10717 10718 10719 10720 10721 10722 10723 10724 10725 10726 10727 10728 10729 10730 10731 10732 10733 10734 10735 10736 10737 10738 10739 10740 10741 10742 10743 10744 10745 10746 10747 10748 10749 10750 10751 10752 10753 10754 10755 10756 10757 10758 10759 10760 10761 10762 10763 10764 10765 10766 10767 10768 10769 10770 10771 10772 10773 10774 10775 10776 10777 10778 10779 10780 10781 10782 10783 10784 10785 10786 10787 10788 10789 10790 10791 10792 10793 10794 10795 10796 10797 10798 10799 10800 10801 10802 10803 10804 10805 10806 10807 10808 10809 10810 10811 10812 10813 10814 10815 10816 10817 10818 10819 10820 10821 10822 10823 10824 10825 10826 10827 10828 10829 10830 10831 10832 10833 10834 10835 10836 10837 10838 10839 10840 10841 10842 10843 10844 10845 10846 10847 10848 10849 10850 10851 10852 10853 10854 10855 10856 10857 10858 10859 10860 10861 10862 10863 10864 10865 10866 10867 10868 10869 10870 10871 10872 10873 10874 10875 10876 10877 10878 10879 10880 10881 10882 10883 10884 10885 10886 10887 10888 10889 10890 10891 10892 10893 10894 10895 10896 10897 10898 10899 10900 10901 10902 10903 10904 10905 10906 10907 10908 10909 10910 10911 10912 10913 10914 10915 10916 10917 10918 10919 10920 10921 10922 10923 10924 10925 10926 10927 10928 10929 10930 10931 10932 10933 10934 10935 10936 10937 10938 10939 10940 10941 10942 10943 10944 10945 10946 10947 10948 10949 10950 10951 10952 10953 10954 10955 10956 10957 10958 10959 10960 10961 10962 10963 10964 10965 10966 10967 10968 10969 10970 10971 10972 10973 10974 10975 10976 10977 10978 10979 10980 10981 10982 10983 10984 10985 10986 10987 10988 10989 10990 10991 10992 10993 10994 10995 10996 10997 10998 10999 11000 11001 11002 11003 11004 11005 11006 11007 11008 11009 11010 11011 11012 11013 11014 11015 11016 11017 11018 11019 11020 11021 11022 11023 11024 11025 11026 11027 11028 11029 11030 11031 11032 11033 11034 11035 11036 11037 11038 11039 11040 11041 11042 11043 11044 11045 11046 11047 11048 11049 11050 11051 11052 11053 11054 11055 11056 11057 11058 11059 11060 11061 11062 11063 11064 11065 11066 11067 11068 11069 11070 11071 11072 11073 11074 11075 11076 11077 11078 11079 11080 11081 11082 11083 11084 11085 11086 11087 11088 11089 11090 11091 11092 11093 11094 11095 11096 11097 11098 11099 11100 11101 11102 11103 11104 11105 11106 11107 11108 11109 11110 11111 11112 11113 11114 11115 11116 11117 11118 11119 11120 11121 11122 11123 11124 11125 11126 11127 11128 11129 11130 11131 11132 11133 11134 11135 11136 11137 11138 11139 11140 11141 11142 11143 11144 11145 11146 11147 11148 11149 11150 11151 11152 11153 11154 11155 11156 11157 11158 11159 11160 11161 11162 11163 11164 11165 11166 11167 11168 11169 11170 11171 11172 11173 11174 11175 11176 11177 11178 11179 11180 11181 11182 11183 11184 11185 11186 11187 11188 11189 11190 11191 11192 11193 11194 11195 11196 11197 11198 11199 11200 11201 11202 11203 11204 11205 11206 11207 11208 11209 11210 11211 11212 11213 11214 11215 11216 11217 11218 11219 11220 11221 11222 11223 11224 11225 11226 11227 11228 11229 11230 11231 11232 11233 11234 11235 11236 11237 11238 11239 11240 11241 11242 11243 11244 11245 11246 11247 11248 11249 11250 11251 11252 11253 11254 11255 11256 11257 11258 11259 11260 11261 11262 11263 11264 11265 11266 11267 11268 11269 11270 11271 11272 11273 11274 11275 11276 11277 11278 11279 11280 11281 11282 11283 11284 11285 11286 11287 11288 11289 11290 11291 11292 11293 11294 11295 11296 11297 11298 11299 11300 11301 11302 11303 11304 11305 11306 11307 11308 11309 11310 11311 11312 11313 11314 11315 11316 11317 11318 11319 11320 11321 11322 11323 11324 11325 11326 11327 11328 11329 11330 11331 11332 11333 11334 11335 11336 11337 11338 11339 11340 11341 11342 11343 11344 11345 11346 11347 11348 11349 11350 11351 11352 11353 11354 11355 11356 11357 11358 11359 11360 11361 11362 11363 11364 11365 11366 11367 11368 11369 11370 11371 11372 11373 11374 11375 11376 11377 11378 11379 11380 11381 11382 11383 11384 11385 11386 11387 11388 11389 11390 11391 11392 11393 11394 11395 11396 11397 11398 11399 11400 11401 11402 11403 11404 11405 11406 11407 11408 11409 11410 11411 11412 11413 11414 11415 11416 11417 11418 11419 11420 11421 11422 11423 11424 11425 11426 11427 11428 11429 11430 11431 11432 11433 11434 11435 11436 11437 11438 11439 11440 11441 11442 11443 11444 11445 11446 11447 11448 11449 11450 11451 11452 11453 11454 11455 11456 11457 11458 11459 11460 11461 11462 11463 11464 11465 11466 11467 11468 11469 11470 11471 11472 11473 11474 11475 11476 11477 11478 11479 11480 11481 11482 11483 11484 11485 11486 11487 11488 11489 11490 11491 11492 11493 11494 11495 11496 11497 11498 11499 11500 11501 11502 11503 11504 11505 11506 11507 11508 11509 11510 11511 11512 11513 11514 11515 11516 11517 11518 11519 11520 11521 11522 11523 11524 11525 11526 11527 11528 11529 11530 11531 11532 11533 11534 11535 11536 11537 11538 11539 11540 11541 11542 11543 11544 11545 11546 11547 11548 11549 11550 11551 11552 11553 11554 11555 11556 11557 11558 11559 11560 11561 11562 11563 11564 11565 11566 11567 11568 11569 11570 11571 11572 11573 11574 11575 11576 11577 11578 11579 11580 11581 11582 11583 11584 11585 11586 11587 11588 11589 11590 11591 11592 11593 11594 11595 11596 11597 11598 11599 11600 11601 11602 11603 11604 11605 11606 11607 11608 11609 11610 11611 11612 11613 11614 11615 11616 11617 11618 11619 11620 11621 11622 11623 11624 11625 11626 11627 11628 11629 11630 11631 11632 11633 11634 11635 11636 11637 11638 11639 11640 11641 11642 11643 11644 11645 11646 11647 11648 11649 11650 11651 11652 11653 11654 11655 11656 11657 11658 11659 11660 11661 11662 11663 11664 11665 11666 11667 11668 11669 11670 11671 11672 11673 11674 11675 11676 11677 11678 11679 11680 11681 11682 11683 11684 11685 11686 11687 11688 11689 11690 11691 11692 11693 11694 11695 11696 11697 11698 11699 11700 11701 11702 11703 11704 11705 11706 11707 11708 11709 11710 11711 11712 11713 11714 11715 11716 11717 11718 11719 11720 11721 11722 11723 11724 11725 11726 11727 11728 11729 11730 11731 11732 11733 11734 11735 11736 11737 11738 11739 11740 11741 11742 11743 11744 11745 11746 11747 11748 11749 11750 11751 11752 11753 11754 11755 11756 11757 11758 11759 11760 11761 11762 11763 11764 11765 11766 11767 11768 11769 11770 11771 11772 11773 11774 11775 11776 11777 11778 11779 11780 11781 11782 11783 11784 11785 11786 11787 11788 11789 11790 11791 11792 11793 11794 11795 11796 11797 11798 11799 11800 11801 11802 11803 11804 11805 11806 11807 11808 11809 11810 11811 11812 11813 11814 11815 11816 11817 11818 11819 11820 11821 11822 11823 11824 11825 11826 11827 11828 11829 11830 11831 11832 11833 11834 11835 11836 11837 11838 11839 11840 11841 11842 11843 11844 11845 11846 11847 11848 11849 11850 11851 11852 11853 11854 11855 11856 11857 11858 11859 11860 11861 11862 11863 11864 11865 11866 11867 11868 11869 11870 11871 11872 11873 11874 11875 11876 11877 11878 11879 11880 11881 11882 11883 11884 11885 11886 11887 11888 11889 11890 11891 11892 11893 11894 11895 11896 11897 11898 11899 11900 11901 11902 11903 11904 11905 11906 11907 11908 11909 11910 11911 11912 11913 11914 11915 11916 11917 11918 11919 11920 11921 11922 11923 11924 11925 11926 11927 11928 11929 11930 11931 11932 11933 11934 11935 11936 11937 11938 11939 11940 11941 11942 11943 11944 11945 11946 11947 11948 11949 11950 11951 11952 11953 11954 11955 11956 11957 11958 11959 11960 11961 11962 11963 11964 11965 11966 11967 11968 11969 11970 11971 11972 11973 11974 11975 11976 11977 11978 11979 11980 11981 11982 11983 11984 11985 11986 11987 11988 11989 11990 11991 11992 11993 11994 11995 11996 11997 11998 11999 12000 12001 12002 12003 12004 12005 12006 12007 12008 12009 12010 12011 12012 12013 12014 12015 12016 12017 12018 12019 12020 12021 12022 12023 12024 12025 12026 12027 12028 12029 12030 12031 12032 12033 12034 12035 12036 12037 12038 12039 12040 12041 12042 12043 12044 12045 12046 12047 12048 12049 12050 12051 12052 12053 12054 12055 12056 12057 12058 12059 12060 12061 12062 12063 12064 12065 12066 12067 12068 12069 12070 12071 12072 12073 12074 12075 12076 12077 12078 12079 12080 12081 12082 12083 12084 12085 12086 12087 12088 12089 12090 12091 12092 12093 12094 12095 12096 12097 12098 12099 12100 12101 12102 12103 12104 12105 12106 12107 12108 12109 12110 12111 12112 12113 12114 12115 12116 12117 12118 12119 12120 12121 12122 12123 12124 12125 12126 12127 12128 12129 12130 12131 12132 12133 12134 12135 12136 12137 12138 12139 12140 12141 12142 12143 12144 12145 12146 12147 12148 12149 12150 12151 12152 12153 12154 12155 12156 12157 12158 12159 12160 12161 12162 12163 12164 12165 12166 12167 12168 12169 12170 12171 12172 12173 12174 12175 12176 12177 12178 12179 12180 12181 12182 12183 12184 12185 12186 12187 12188 12189 12190 12191 12192 12193 12194 12195 12196 12197 12198 12199 12200 12201 12202 12203 12204 12205 12206 12207 12208 12209 12210 12211 12212 12213 12214 12215 12216 12217 12218 12219 12220 12221 12222 12223 12224 12225 12226 12227 12228 12229 12230 12231 12232 12233 12234 12235 12236 12237 12238 12239 12240 12241 12242 12243 12244 12245 12246 12247 12248 12249 12250 12251 12252 12253 12254 12255 12256 12257 12258 12259 12260 12261 12262 12263 12264 12265 12266 12267 12268 12269 12270 12271 12272 12273 12274 12275 12276 12277 12278 12279 12280 12281 12282 12283 12284 12285 12286 12287 12288 12289 12290 12291 12292 12293 12294 12295 12296 12297 12298 12299 12300 12301 12302 12303 12304 12305 12306 12307 12308 12309 12310 12311 12312 12313 12314 12315 12316 12317 12318 12319 12320 12321 12322 12323 12324 12325 12326 12327 12328 12329 12330 12331 12332 12333 12334 12335 12336 12337 12338 12339 12340 12341 12342 12343 12344 12345 12346 12347 12348 12349 12350 12351 12352 12353 12354 12355 12356 12357 12358 12359 12360 12361 12362 12363 12364 12365 12366 12367 12368 12369 12370 12371 12372 12373 12374 12375 12376 12377 12378 12379 12380 12381 12382 12383 12384 12385 12386 12387 12388 12389 12390 12391 12392 12393 12394 12395 12396 12397 12398 12399 12400 12401 12402 12403 12404 12405 12406 12407 12408 12409 12410 12411 12412 12413 12414 12415 12416 12417 12418 12419 12420 12421 12422 12423 12424 12425 12426 12427 12428 12429 12430 12431 12432 12433 12434 12435 12436 12437 12438 12439 12440 12441 12442 12443 12444 12445 12446 12447 12448 12449 12450 12451 12452 12453 12454 12455 12456 12457 12458 12459 12460 12461 12462 12463 12464 12465 12466 12467 12468 12469 12470 12471 12472 12473 12474 12475 12476 12477 12478 12479 12480 12481 12482 12483 12484 12485 12486 12487 12488 12489 12490 12491 12492 12493 12494 12495 12496 12497 12498 12499 12500 12501 12502 12503 12504 12505 12506 12507 12508 12509 12510 12511 12512 12513 12514 12515 12516 12517 12518 12519 12520 12521 12522 12523 12524 12525 12526 12527 12528 12529 12530 12531 12532 12533 12534 12535 12536 12537 12538 12539 12540 12541 12542 12543 12544 12545 12546 12547 12548 12549 12550 12551 12552 12553 12554 12555 12556 12557 12558 12559 12560 12561 12562 12563 12564 12565 12566 12567 12568 12569 12570 12571 12572 12573 12574 12575 12576 12577 12578 12579 12580 12581 12582 12583 12584 12585 12586 12587 12588 12589 12590 12591 12592 12593 12594 12595 12596 12597 12598 12599 12600 12601 12602 12603 12604 12605 12606 12607 12608 12609 12610 12611 12612 12613 12614 12615 12616 12617 12618 12619 12620 12621 12622 12623 12624 12625 12626 12627 12628 12629 12630 12631 12632 12633 12634 12635 12636 12637 12638 12639 12640 12641 12642 12643 12644 12645 12646 12647 12648 12649 12650 12651 12652 12653 12654 12655 12656 12657 12658 12659 12660 12661 12662 12663 12664 12665 12666 12667 12668 12669 12670 12671 12672 12673 12674 12675 12676 12677 12678 12679 12680 12681 12682 12683 12684 12685 12686 12687 12688 12689 12690 12691 12692 12693 12694 12695 12696 12697 12698 12699 12700 12701 12702 12703 12704 12705 12706 12707 12708 12709 12710 12711 12712 12713 12714 12715 12716 12717 12718 12719 12720 12721 12722 12723 12724 12725 12726 12727 12728 12729 12730 12731 12732 12733 12734 12735 12736 12737 12738 12739 12740 12741 12742 12743 12744 12745 12746 12747 12748 12749 12750 12751 12752 12753 12754 12755 12756 12757 12758 12759 12760 12761 12762 12763 12764 12765 12766 12767 12768 12769 12770 12771 12772 12773 12774 12775 12776 12777 12778 12779 12780 12781 12782 12783 12784 12785 12786 12787 12788 12789 12790 12791 12792 12793 12794 12795 12796 12797 12798 12799 12800 12801 12802 12803 12804 12805 12806 12807 12808 12809 12810 12811 12812 12813 12814 12815 12816 12817 12818 12819 12820 12821 12822 12823 12824 12825 12826 12827 12828 12829 12830 12831 12832 12833 12834 12835 12836 12837 12838 12839 12840 12841 12842 12843 12844 12845 12846 12847 12848 12849 12850 12851 12852 12853 12854 12855 12856 12857 12858 12859 12860 12861 12862 12863 12864 12865 12866 12867 12868 12869 12870 12871 12872 12873 12874 12875 12876 12877 12878 12879 12880 12881 12882 12883 12884 12885 12886 12887 12888 12889 12890 12891 12892 12893 12894 12895 12896 12897 12898 12899 12900 12901 12902 12903 12904 12905 12906 12907 12908 12909 12910 12911 12912 12913 12914 12915 12916 12917 12918 12919 12920 12921 12922 12923 12924 12925 12926 12927 12928 12929 12930 12931 12932 12933 12934 12935 12936 12937 12938 12939 12940 12941 12942 12943 12944 12945 12946 12947 12948 12949 12950 12951 12952 12953 12954 12955 12956 12957 12958 12959 12960 12961 12962 12963 12964 12965 12966 12967 12968 12969 12970 12971 12972 12973 12974 12975 12976 12977 12978 12979 12980 12981 12982 12983 12984 12985 12986 12987 12988 12989 12990 12991 12992 12993 12994 12995 12996 12997 12998 12999 13000 13001 13002 13003 13004 13005 13006 13007 13008 13009 13010 13011 13012 13013 13014 13015 13016 13017 13018 13019 13020 13021 13022 13023 13024 13025 13026 13027 13028 13029 13030 13031 13032 13033 13034 13035 13036 13037 13038 13039 13040 13041 13042 13043 13044 13045 13046 13047 13048 13049 13050 13051 13052 13053 13054 13055 13056 13057 13058 13059 13060 13061 13062 13063 13064 13065 13066 13067 13068 13069 13070 13071 13072 13073 13074 13075 13076 13077 13078 13079 13080 13081 13082 13083 13084 13085 13086 13087 13088 13089 13090 13091 13092 13093 13094 13095 13096 13097 13098 13099 13100 13101 13102 13103 13104 13105 13106 13107 13108 13109 13110 13111 13112 13113 13114 13115 13116 13117 13118 13119 13120 13121 13122 13123 13124 13125 13126 13127 13128 13129 13130 13131 13132 13133 13134 13135 13136 13137 13138 13139 13140 13141 13142 13143 13144 13145 13146 13147 13148 13149 13150 13151 13152 13153 13154 13155 13156 13157 13158 13159 13160 13161 13162 13163 13164 13165 13166 13167 13168 13169 13170 13171 13172 13173 13174 13175 13176 13177 13178 13179 13180 13181 13182 13183 13184 13185 13186 13187 13188 13189 13190 13191 13192 13193 13194 13195 13196 13197 13198 13199 13200 13201 13202 13203 13204 13205 13206 13207 13208 13209 13210 13211 13212 13213 13214 13215 13216 13217 13218 13219 13220 13221 13222 13223 13224 13225 13226 13227 13228 13229 13230 13231 13232 13233 13234 13235 13236 13237 13238 13239 13240 13241 13242 13243 13244 13245 13246 13247 13248 13249 13250 13251 13252 13253 13254 13255 13256 13257 13258 13259 13260 13261 13262 13263 13264 13265 13266 13267 13268 13269 13270 13271 13272 13273 13274 13275 13276 13277 13278 13279 13280 13281 13282 13283 13284 13285 13286 13287 13288 13289 13290 13291 13292 13293 13294 13295 13296 13297 13298 13299 13300 13301 13302 13303 13304 13305 13306 13307 13308 13309 13310 13311 13312 13313 13314 13315 13316 13317 13318 13319 13320 13321 13322 13323 13324 13325 13326 13327 13328 13329 13330 13331 13332 13333 13334 13335 13336 13337 13338 13339 13340 13341 13342 13343 13344 13345 13346 13347 13348 13349 13350 13351 13352 13353 13354 13355 13356 13357 13358 13359 13360 13361 13362 13363 13364 13365 13366 13367 13368 13369 13370 13371 13372 13373 13374 13375 13376 13377 13378 13379 13380 13381 13382 13383 13384 13385 13386 13387 13388 13389 13390 13391 13392 13393 13394 13395 13396 13397 13398 13399 13400 13401 13402 13403 13404 13405 13406 13407 13408 13409 13410 13411 13412 13413 13414 13415 13416 13417 13418 13419 13420 13421 13422 13423 13424 13425 13426 13427 13428 13429 13430 13431 13432 13433 13434 13435 13436 13437 13438 13439 13440 13441 13442 13443 13444 13445 13446 13447 13448 13449 13450 13451 13452 13453 13454 13455 13456 13457 13458 13459 13460 13461 13462 13463 13464 13465 13466 13467 13468 13469 13470 13471 13472 13473 13474 13475 13476 13477 13478 13479 13480 13481 13482 13483 13484 13485 13486 13487 13488 13489 13490 13491 13492 13493 13494 13495 13496 13497 13498 13499 13500 13501 13502 13503 13504 13505 13506 13507 13508 13509 13510 13511 13512 13513 13514 13515 13516 13517 13518 13519 13520 13521 13522 13523 13524 13525 13526 13527 13528 13529 13530 13531 13532 13533 13534 13535 13536 13537 13538 13539 13540 13541 13542 13543 13544 13545 13546 13547 13548 13549 13550 13551 13552 13553 13554 13555 13556 13557 13558 13559 13560 13561 13562 13563 13564 13565 13566 13567 13568 13569 13570 13571 13572 13573 13574 13575 13576 13577 13578 13579 13580 13581 13582 13583 13584 13585 13586 13587 13588 13589 13590 13591 13592 13593 13594 13595 13596 13597 13598 13599 13600 13601 13602 13603 13604 13605 13606 13607 13608 13609 13610 13611 13612 13613 13614 13615 13616 13617 13618 13619 13620 13621 13622 13623 13624 13625 13626 13627 13628 13629 13630 13631 13632 13633 13634 13635 13636 13637 13638 13639 13640 13641 13642 13643 13644 13645 13646 13647 13648 13649 13650 13651 13652 13653 13654 13655 13656 13657 13658 13659 13660 13661 13662 13663 13664 13665 13666 13667 13668 13669 13670 13671 13672 13673 13674 13675 13676 13677 13678 13679 13680 13681 13682 13683 13684 13685 13686 13687 13688 13689 13690 13691 13692 13693 13694 13695 13696 13697 13698 13699 13700 13701 13702 13703 13704 13705 13706 13707 13708 13709 13710 13711 13712 13713 13714 13715 13716 13717 13718 13719 13720 13721 13722 13723 13724 13725 13726 13727 13728 13729 13730 13731 13732 13733 13734 13735 13736 13737 13738 13739 13740 13741 13742 13743 13744 13745 13746 13747 13748 13749 13750 13751 13752 13753 13754 13755 13756 13757 13758 13759 13760 13761 13762 13763 13764 13765 13766 13767 13768 13769 13770 13771 13772 13773 13774 13775 13776 13777 13778 13779 13780 13781 13782 13783 13784 13785 13786 13787 13788 13789 13790 13791 13792 13793 13794 13795 13796 13797 13798 13799 13800 13801 13802 13803 13804 13805 13806 13807 13808 13809 13810 13811 13812 13813 13814 13815 13816 13817 13818 13819 13820 13821 13822 13823 13824 13825 13826 13827 13828 13829 13830 13831 13832 13833 13834 13835 13836 13837 13838 13839 13840 13841 13842 13843 13844 13845 13846 13847 13848 13849 13850 13851 13852 13853 13854 13855 13856 13857 13858 13859 13860 13861 13862 13863 13864 13865 13866 13867 13868 13869 13870 13871 13872 13873 13874 13875 13876 13877 13878 13879 13880 13881 13882 13883 13884 13885 13886 13887 13888 13889 13890 13891 13892 13893 13894 13895 13896 13897 13898 13899 13900 13901 13902 13903 13904 13905 13906 13907 13908 13909 13910 13911 13912 13913 13914 13915 13916 13917 13918 13919 13920 13921 13922 13923 13924 13925 13926 13927 13928 13929 13930 13931 13932 13933 13934 13935 13936 13937 13938 13939 13940 13941 13942 13943 13944 13945 13946 13947 13948 13949 13950 13951 13952 13953 13954 13955 13956 13957 13958 13959 13960 13961 13962 13963 13964 13965 13966 13967 13968 13969 13970 13971 13972 13973 13974 13975 13976 13977 13978 13979 13980 13981 13982 13983 13984 13985 13986 13987 13988 13989 13990 13991 13992 13993 13994 13995 13996 13997 13998 13999 14000 14001 14002 14003 14004 14005 14006 14007 14008 14009 14010 14011 14012 14013 14014 14015 14016 14017 14018 14019 14020 14021 14022 14023 14024 14025 14026 14027 14028 14029 14030 14031 14032 14033 14034 14035 14036 14037 14038 14039 14040 14041 14042 14043 14044 14045 14046 14047 14048 14049 14050 14051 14052 14053 14054 14055 14056 14057 14058 14059 14060 14061 14062 14063 14064 14065 14066 14067 14068 14069 14070 14071 14072 14073 14074 14075 14076 14077 14078 14079 14080 14081 14082 14083 14084 14085 14086 14087 14088 14089 14090 14091 14092 14093 14094 14095 14096 14097 14098 14099 14100 14101 14102 14103 14104 14105 14106 14107 14108 14109 14110 14111 14112 14113 14114 14115 14116 14117 14118 14119 14120 14121 14122 14123 14124 14125 14126 14127 14128 14129 14130 14131 14132 14133 14134 14135 14136 14137 14138 14139 14140 14141 14142 14143 14144 14145 14146 14147 14148 14149 14150 14151 14152 14153 14154 14155 14156 14157 14158 14159 14160 14161 14162 14163 14164 14165 14166 14167 14168 14169 14170 14171 14172 14173 14174 14175 14176 14177 14178 14179 14180 14181 14182 14183 14184 14185 14186 14187 14188 14189 14190 14191 14192 14193 14194 14195 14196 14197 14198 14199 14200 14201 14202 14203 14204 14205 14206 14207 14208 14209 14210 14211 14212 14213 14214 14215 14216 14217 14218 14219 14220 14221 14222 14223 14224 14225 14226 14227 14228 14229 14230 14231 14232 14233 14234 14235 14236 14237 14238 14239 14240 14241 14242 14243 14244 14245 14246 14247 14248 14249 14250 14251 14252 14253 14254 14255 14256 14257 14258 14259 14260 14261 14262 14263 14264 14265 14266 14267 14268 14269 14270 14271 14272 14273 14274 14275 14276 14277 14278 14279 14280 14281 14282 14283 14284 14285 14286 14287 14288 14289 14290 14291 14292 14293 14294 14295 14296 14297 14298 14299 14300 14301 14302 14303 14304 14305 14306 14307 14308 14309 14310 14311 14312 14313 14314 14315 14316 14317 14318 14319 14320 14321 14322 14323 14324 14325 14326 14327 14328 14329 14330 14331 14332 14333 14334 14335 14336 14337 14338 14339 14340 14341 14342 14343 14344 14345 14346 14347 14348 14349 14350 14351 14352 14353 14354 14355 14356 14357 14358 14359 14360 14361 14362 14363 14364 14365 14366 14367 14368 14369 14370 14371 14372 14373 14374 14375 14376 14377 14378 14379 14380 14381 14382 14383 14384 14385 14386 14387 14388 14389 14390 14391 14392 14393 14394 14395 14396 14397 14398 14399 14400 14401 14402 14403 14404 14405 14406 14407 14408 14409 14410 14411 14412 14413 14414 14415 14416 14417 14418 14419 14420 14421 14422 14423 14424 14425 14426 14427 14428 14429 14430 14431 14432 14433 14434 14435 14436 14437 14438 14439 14440 14441 14442 14443 14444 14445 14446 14447 14448 14449 14450 14451 14452 14453 14454 14455 14456 14457 14458 14459 14460 14461 14462 14463 14464 14465 14466 14467 14468 14469 14470 14471 14472 14473 14474 14475 14476 14477 14478 14479 14480 14481 14482 14483 14484 14485 14486 14487 14488 14489 14490 14491 14492 14493 14494 14495 14496 14497 14498 14499 14500 14501 14502 14503 14504 14505 14506 14507 14508 14509 14510 14511 14512 14513 14514 14515 14516 14517 14518 14519 14520 14521 14522 14523 14524 14525 14526 14527 14528 14529 14530 14531 14532 14533 14534 14535 14536 14537 14538 14539 14540 14541 14542 14543 14544 14545 14546 14547 14548 14549 14550 14551 14552 14553 14554 14555 14556 14557 14558 14559 14560 14561 14562 14563 14564 14565 14566 14567 14568 14569 14570 14571 14572 14573 14574 14575 14576 14577 14578 14579 14580 14581 14582 14583 14584 14585 14586 14587 14588 14589 14590 14591 14592 14593 14594 14595 14596 14597 14598 14599 14600 14601 14602 14603 14604 14605 14606 14607 14608 14609 14610 14611 14612 14613 14614 14615 14616 14617 14618 14619 14620 14621 14622 14623 14624 14625 14626 14627 14628 14629 14630 14631 14632 14633 14634 14635 14636 14637 14638 14639 14640 14641 14642 14643 14644 14645 14646 14647 14648 14649 14650 14651 14652 14653 14654 14655 14656 14657 14658 14659 14660 14661 14662 14663 14664 14665 14666 14667 14668 14669 14670 14671 14672 14673 14674 14675 14676 14677 14678 14679 14680 14681 14682 14683 14684 14685 14686 14687 14688 14689 14690 14691 14692 14693 14694 14695 14696 14697 14698 14699 14700 14701 14702 14703 14704 14705 14706 14707 14708 14709 14710 14711 14712 14713 14714 14715 14716 14717 14718 14719 14720 14721 14722 14723 14724 14725 14726 14727 14728 14729 14730 14731 14732 14733 14734 14735 14736 14737 14738 14739 14740 14741 14742 14743 14744 14745 14746 14747 14748 14749 14750 14751 14752 14753 14754 14755 14756 14757 14758 14759 14760 14761 14762 14763 14764 14765 14766 14767 14768 14769 14770 14771 14772 14773 14774 14775 14776 14777 14778 14779 14780 14781 14782 14783 14784 14785 14786 14787 14788 14789 14790 14791 14792 14793 14794 14795 14796 14797 14798 14799 14800 14801 14802 14803 14804 14805 14806 14807 14808 14809 14810 14811 14812 14813 14814 14815 14816 14817 14818 14819 14820 14821 14822 14823 14824 14825 14826 14827 14828 14829 14830 14831 14832 14833 14834 14835 14836 14837 14838 14839 14840 14841 14842 14843 14844 14845 14846 14847 14848 14849 14850 14851 14852 14853 14854 14855 14856 14857 14858 14859 14860 14861 14862 14863 14864 14865 14866 14867 14868 14869 14870 14871 14872 14873 14874 14875 14876 14877 14878 14879 14880 14881 14882 14883 14884 14885 14886 14887 14888 14889 14890 14891 14892 14893 14894 14895 14896 14897 14898 14899 14900 14901 14902 14903 14904 14905 14906 14907 14908 14909 14910 14911 14912 14913 14914 14915 14916 14917 14918 14919 14920 14921 14922 14923 14924 14925 14926 14927 14928 14929 14930 14931 14932 14933 14934 14935 14936 14937 14938 14939 14940 14941 14942 14943 14944 14945 14946 14947 14948 14949 14950 14951 14952 14953 14954 14955 14956 14957 14958 14959 14960 14961 14962 14963 14964 14965 14966 14967 14968 14969 14970 14971 14972 14973 14974 14975 14976 14977 14978 14979 14980 14981 14982 14983 14984 14985 14986 14987 14988 14989 14990 14991 14992 14993 14994 14995 14996 14997 14998 14999 15000 15001 15002 15003 15004 15005 15006 15007 15008 15009 15010 15011 15012 15013 15014 15015 15016 15017 15018 15019 15020 15021 15022 15023 15024 15025 15026 15027 15028 15029 15030 15031 15032 15033 15034 15035 15036 15037 15038 15039 15040 15041 15042 15043 15044 15045 15046 15047 15048 15049 15050 15051 15052 15053 15054 15055 15056 15057 15058 15059 15060 15061 15062 15063 15064 15065 15066 15067 15068 15069 15070 15071 15072 15073 15074 15075 15076 15077 15078 15079 15080 15081 15082 15083 15084 15085 15086 15087 15088 15089 15090 15091 15092 15093 15094 15095 15096 15097 15098 15099 15100 15101 15102 15103 15104 15105 15106 15107 15108 15109 15110 15111 15112 15113 15114 15115 15116 15117 15118 15119 15120 15121 15122 15123 15124 15125 15126 15127 15128 15129 15130 15131 15132 15133 15134 15135 15136 15137 15138 15139 15140 15141 15142 15143 15144 15145 15146 15147 15148 15149 15150 15151 15152 15153 15154 15155 15156 15157 15158 15159 15160 15161 15162 15163 15164 15165 15166 15167 15168 15169 15170 15171 15172 15173 15174 15175 15176 15177 15178 15179 15180 15181 15182 15183 15184 15185 15186 15187 15188 15189 15190 15191 15192 15193 15194 15195 15196 15197 15198 15199 15200 15201 15202 15203 15204 15205 15206 15207 15208 15209 15210 15211 15212 15213 15214 15215 15216 15217 15218 15219 15220 15221 15222 15223 15224 15225 15226 15227 15228 15229 15230 15231 15232 15233 15234 15235 15236 15237 15238 15239 15240 15241 15242 15243 15244 15245 15246 15247 15248 15249 15250 15251 15252 15253 15254 15255 15256 15257 15258 15259 15260 15261 15262 15263 15264 15265 15266 15267 15268 15269 15270 15271 15272 15273 15274 15275 15276 15277 15278 15279 15280 15281 15282 15283 15284 15285 15286 15287 15288 15289 15290 15291 15292 15293 15294 15295 15296 15297 15298 15299 15300 15301 15302 15303 15304 15305 15306 15307 15308 15309 15310 15311 15312 15313 15314 15315 15316 15317 15318 15319 15320 15321 15322 15323 15324 15325 15326 15327 15328 15329 15330 15331 15332 15333 15334 15335 15336 15337 15338 15339 15340 15341 15342 15343 15344 15345 15346 15347 15348 15349 15350 15351 15352 15353 15354 15355 15356 15357 15358 15359 15360 15361 15362 15363 15364 15365 15366 15367 15368 15369 15370 15371 15372 15373 15374 15375 15376 15377 15378 15379 15380 15381 15382 15383 15384 15385 15386 15387 15388 15389 15390 15391 15392 15393 15394 15395 15396 15397 15398 15399 15400 15401 15402 15403 15404 15405 15406 15407 15408 15409 15410 15411 15412 15413 15414 15415 15416 15417 15418 15419 15420 15421 15422 15423 15424 15425 15426 15427 15428 15429 15430 15431 15432 15433 15434 15435 15436 15437 15438 15439 15440 15441 15442 15443 15444 15445 15446 15447 15448 15449 15450 15451 15452 15453 15454 15455 15456 15457 15458 15459 15460 15461 15462 15463 15464 15465 15466 15467 15468 15469 15470 15471 15472 15473 15474 15475 15476 15477 15478 15479 15480 15481 15482 15483 15484 15485 15486 15487 15488 15489 15490 15491 15492 15493 15494 15495 15496 15497 15498 15499 15500 15501 15502 15503 15504 15505 15506 15507 15508 15509 15510 15511 15512 15513 15514 15515 15516 15517 15518 15519 15520 15521 15522 15523 15524 15525 15526 15527 15528 15529 15530 15531 15532 15533 15534 15535 15536 15537 15538 15539 15540 15541 15542 15543 15544 15545 15546 15547 15548 15549 15550 15551 15552 15553 15554 15555 15556 15557 15558 15559 15560 15561 15562 15563 15564 15565 15566 15567 15568 15569 15570 15571 15572 15573 15574 15575 15576 15577 15578 15579 15580 15581 15582 15583 15584 15585 15586 15587 15588 15589 15590 15591 15592 15593 15594 15595 15596 15597 15598 15599 15600 15601 15602 15603 15604 15605 15606 15607 15608 15609 15610 15611 15612 15613 15614 15615 15616 15617 15618 15619 15620 15621 15622 15623 15624 15625 15626 15627 15628 15629 15630 15631 15632 15633 15634 15635 15636 15637 15638 15639 15640 15641 15642 15643 15644 15645 15646 15647 15648 15649 15650 15651 15652 15653 15654 15655 15656 15657 15658 15659 15660 15661 15662 15663 15664 15665 15666 15667 15668 15669 15670 15671 15672 15673 15674 15675 15676 15677 15678 15679 15680 15681 15682 15683 15684 15685 15686 15687 15688 15689 15690 15691 15692 15693 15694 15695 15696 15697 15698 15699 15700 15701 15702 15703 15704 15705 15706 15707 15708 15709 15710 15711 15712 15713 15714 15715 15716 15717 15718 15719 15720 15721 15722 15723 15724 15725 15726 15727 15728 15729 15730 15731 15732 15733 15734 15735 15736 15737 15738 15739 15740 15741 15742 15743 15744 15745 15746 15747 15748 15749 15750 15751 15752 15753 15754 15755 15756 15757 15758 15759 15760 15761 15762 15763 15764 15765 15766 15767 15768 15769 15770 15771 15772 15773 15774 15775 15776 15777 15778 15779 15780 15781 15782 15783 15784 15785 15786 15787 15788 15789 15790 15791 15792 15793 15794 15795 15796 15797 15798 15799 15800 15801 15802 15803 15804 15805 15806 15807 15808 15809 15810 15811 15812 15813 15814 15815 15816 15817 15818 15819 15820 15821 15822 15823 15824 15825 15826 15827 15828 15829 15830 15831 15832 15833 15834 15835 15836 15837 15838 15839 15840 15841 15842 15843 15844 15845 15846 15847 15848 15849 15850 15851 15852 15853 15854 15855 15856 15857 15858 15859 15860 15861 15862 15863 15864 15865 15866 15867 15868 15869 15870 15871 15872 15873 15874 15875 15876 15877 15878 15879 15880 15881 15882 15883 15884 15885 15886 15887 15888 15889 15890 15891 15892 15893 15894 15895 15896 15897 15898 15899 15900 15901 15902 15903 15904 15905 15906 15907 15908 15909 15910 15911 15912 15913 15914 15915 15916 15917 15918 15919 15920 15921 15922 15923 15924 15925 15926 15927 15928 15929 15930 15931 15932 15933 15934 15935 15936 15937 15938 15939 15940 15941 15942 15943 15944 15945 15946 15947 15948 15949 15950 15951 15952 15953 15954 15955 15956 15957 15958 15959 15960 15961 15962 15963 15964 15965 15966 15967 15968 15969 15970 15971 15972 15973 15974 15975 15976 15977 15978 15979 15980 15981 15982 15983 15984 15985 15986 15987 15988 15989 15990 15991 15992 15993 15994 15995 15996 15997 15998 15999 16000 16001 16002 16003 16004 16005 16006 16007 16008 16009 16010 16011 16012 16013 16014 16015 16016 16017 16018 16019 16020 16021 16022 16023 16024 16025 16026 16027 16028 16029 16030 16031 16032 16033 16034 16035 16036 16037 16038 16039 16040 16041 16042 16043 16044 16045 16046 16047 16048 16049 16050 16051 16052 16053 16054 16055 16056 16057 16058 16059 16060 16061 16062 16063 16064 16065 16066 16067 16068 16069 16070 16071 16072 16073 16074 16075 16076 16077 16078 16079 16080 16081 16082 16083 16084 16085 16086 16087 16088 16089 16090 16091 16092 16093 16094 16095 16096 16097 16098 16099 16100 16101 16102 16103 16104 16105 16106 16107 16108 16109 16110 16111 16112 16113 16114 16115 16116 16117 16118 16119 16120 16121 16122 16123 16124 16125 16126 16127 16128 16129 16130 16131 16132 16133 16134 16135 16136 16137 16138 16139 16140 16141 16142 16143 16144 16145 16146 16147 16148 16149 16150 16151 16152 16153 16154 16155 16156 16157 16158 16159 16160 16161 16162 16163 16164 16165 16166 16167 16168 16169 16170 16171 16172 16173 16174 16175 16176 16177 16178 16179 16180 16181 16182 16183 16184 16185 16186 16187 16188 16189 16190 16191 16192 16193 16194 16195 16196 16197 16198 16199 16200 16201 16202 16203 16204 16205 16206 16207 16208 16209 16210 16211 16212 16213 16214 16215 16216 16217 16218 16219 16220 16221 16222 16223 16224 16225 16226 16227 16228 16229 16230 16231 16232 16233 16234 16235 16236 16237 16238 16239 16240 16241 16242 16243 16244 16245 16246 16247 16248 16249 16250 16251 16252 16253 16254 16255 16256 16257 16258 16259 16260 16261 16262 16263 16264 16265 16266 16267 16268 16269 16270 16271 16272 16273 16274 16275 16276 16277 16278 16279 16280 16281 16282 16283 16284 16285 16286 16287 16288 16289 16290 16291 16292 16293 16294 16295 16296 16297 16298 16299 16300 16301 16302 16303 16304 16305 16306 16307 16308 16309 16310 16311 16312 16313 16314 16315 16316 16317 16318 16319 16320 16321 16322 16323 16324 16325 16326 16327 16328 16329 16330 16331 16332 16333 16334 16335 16336 16337 16338 16339 16340 16341 16342 16343 16344 16345 16346 16347 16348 16349 16350 16351 16352 16353 16354 16355 16356 16357 16358 16359 16360 16361 16362 16363 16364 16365 16366 16367 16368 16369 16370 16371 16372 16373 16374 16375 16376 16377 16378 16379 16380 16381 16382 16383 16384 16385 16386 16387 16388 16389 16390 16391 16392 16393 16394 16395 16396 16397 16398 16399 16400 16401 16402 16403 16404 16405 16406 16407 16408 16409 16410 16411 16412 16413 16414 16415 16416 16417 16418 16419 16420 16421 16422 16423 16424 16425 16426 16427 16428 16429 16430 16431 16432 16433 16434 16435 16436 16437 16438 16439 16440 16441 16442 16443 16444 16445 16446 16447 16448 16449 16450 16451 16452 16453 16454 16455 16456 16457 16458 16459 16460 16461 16462 16463 16464 16465 16466 16467 16468 16469 16470 16471 16472 16473 16474 16475 16476 16477 16478 16479 16480 16481 16482 16483 16484 16485 16486 16487 16488 16489 16490 16491 16492 16493 16494 16495 16496 16497 16498 16499 16500 16501 16502 16503 16504 16505 16506 16507 16508 16509 16510 16511 16512 16513 16514 16515 16516 16517 16518 16519 16520 16521 16522 16523 16524 16525 16526 16527 16528 16529 16530 16531 16532 16533 16534 16535 16536 16537 16538 16539 16540 16541 16542 16543 16544 16545 16546 16547 16548 16549 16550 16551 16552 16553 16554 16555 16556 16557 16558 16559 16560 16561 16562 16563 16564 16565 16566 16567 16568 16569 16570 16571 16572 16573 16574 16575 16576 16577 16578 16579 16580 16581 16582 16583 16584 16585 16586 16587 16588 16589 16590 16591 16592 16593 16594 16595 16596 16597 16598 16599 16600 16601 16602 16603 16604 16605 16606 16607 16608 16609 16610 16611 16612 16613 16614 16615 16616 16617 16618 16619 16620 16621 16622 16623 16624 16625 16626 16627 16628 16629 16630 16631 16632 16633 16634 16635 16636 16637 16638 16639 16640 16641 16642 16643 16644 16645 16646 16647 16648 16649 16650 16651 16652 16653 16654 16655 16656 16657 16658 16659 16660 16661 16662 16663 16664 16665 16666 16667 16668 16669 16670 16671 16672 16673 16674 16675 16676 16677 16678 16679 16680 16681 16682 16683 16684 16685 16686 16687 16688 16689 16690 16691 16692 16693 16694 16695 16696 16697 16698 16699 16700 16701 16702 16703 16704 16705 16706 16707 16708 16709 16710 16711 16712 16713 16714 16715 16716 16717 16718 16719 16720 16721 16722 16723 16724 16725 16726 16727 16728 16729 16730 16731 16732 16733 16734 16735 16736 16737 16738 16739 16740 16741 16742 16743 16744 16745 16746 16747 16748 16749 16750 16751 16752 16753 16754 16755 16756 16757 16758 16759 16760 16761 16762 16763 16764 16765 16766 16767 16768 16769 16770 16771 16772 16773 16774 16775 16776 16777 16778 16779 16780 16781 16782 16783 16784 16785 16786 16787 16788 16789 16790 16791 16792 16793 16794 16795 16796 16797 16798 16799 16800 16801 16802 16803 16804 16805 16806 16807 16808 16809 16810 16811 16812 16813 16814 16815 16816 16817 16818 16819 16820 16821 16822 16823 16824 16825 16826 16827 16828 16829 16830 16831 16832 16833 16834 16835 16836 16837 16838 16839 16840 16841 16842 16843 16844 16845 16846 16847 16848 16849 16850 16851 16852 16853 16854 16855 16856 16857 16858 16859 16860 16861 16862 16863 16864 16865 16866 16867 16868 16869 16870 16871 16872 16873 16874 16875 16876 16877 16878 16879 16880 16881 16882 16883 16884 16885 16886 16887 16888 16889 16890 16891 16892 16893 16894 16895 16896 16897 16898 16899 16900 16901 16902 16903 16904 16905 16906 16907 16908 16909 16910 16911 16912 16913 16914 16915 16916 16917 16918 16919 16920 16921 16922 16923 16924 16925 16926 16927 16928 16929 16930 16931 16932 16933 16934 16935 16936 16937 16938 16939 16940 16941 16942 16943 16944 16945 16946 16947 16948 16949 16950 16951 16952 16953 16954 16955 16956 16957 16958 16959 16960 16961 16962 16963 16964 16965 16966 16967 16968 16969 16970 16971 16972 16973 16974 16975 16976 16977 16978 16979 16980 16981 16982 16983 16984 16985 16986 16987 16988 16989 16990 16991 16992 16993 16994 16995 16996 16997 16998 16999 17000 17001 17002 17003 17004 17005 17006 17007 17008 17009 17010 17011 17012 17013 17014 17015 17016 17017 17018 17019 17020 17021 17022 17023 17024 17025 17026 17027 17028 17029 17030 17031 17032 17033 17034 17035 17036 17037 17038 17039 17040 17041 17042 17043 17044 17045 17046 17047 17048 17049 17050 17051 17052 17053 17054 17055 17056 17057 17058 17059 17060 17061 17062 17063 17064 17065 17066 17067 17068 17069 17070 17071 17072 17073 17074 17075 17076 17077 17078 17079 17080 17081 17082 17083 17084 17085 17086 17087 17088 17089 17090 17091 17092 17093 17094 17095 17096 17097 17098 17099 17100 17101 17102 17103 17104 17105 17106 17107 17108 17109 17110 17111 17112 17113 17114 17115 17116 17117 17118 17119 17120 17121 17122 17123 17124 17125 17126 17127 17128 17129 17130 17131 17132 17133 17134 17135 17136 17137 17138 17139 17140 17141 17142 17143 17144 17145 17146 17147 17148 17149 17150 17151 17152 17153 17154 17155 17156 17157 17158 17159 17160 17161 17162 17163 17164 17165 17166 17167 17168 17169 17170 17171 17172 17173 17174 17175 17176 17177 17178 17179 17180 17181 17182 17183 17184 17185 17186 17187 17188 17189 17190 17191 17192 17193 17194 17195 17196 17197 17198 17199 17200 17201 17202 17203 17204 17205 17206 17207 17208 17209 17210 17211 17212 17213 17214 17215 17216 17217 17218 17219 17220 17221 17222 17223 17224 17225 17226 17227 17228 17229 17230 17231 17232 17233 17234 17235 17236 17237 17238 17239 17240 17241 17242 17243 17244 17245 17246 17247 17248 17249 17250 17251 17252 17253 17254 17255 17256 17257 17258 17259 17260 17261 17262 17263 17264 17265 17266 17267 17268 17269 17270 17271 17272 17273 17274 17275 17276 17277 17278 17279 17280 17281 17282 17283 17284 17285 17286 17287 17288 17289 17290 17291 17292 17293 17294 17295 17296 17297 17298 17299 17300 17301 17302 17303 17304 17305 17306 17307 17308 17309 17310 17311 17312 17313 17314 17315 17316 17317 17318 17319 17320 17321 17322 17323 17324 17325 17326 17327 17328 17329 17330 17331 17332 17333 17334 17335 17336 17337 17338 17339 17340 17341 17342 17343 17344 17345 17346 17347 17348 17349 17350 17351 17352 17353 17354 17355 17356 17357 17358 17359 17360 17361 17362 17363 17364 17365 17366 17367 17368 17369 17370 17371 17372 17373 17374 17375 17376 17377 17378 17379 17380 17381 17382 17383 17384 17385 17386 17387 17388 17389 17390 17391 17392 17393 17394 17395 17396 17397 17398 17399 17400 17401 17402 17403 17404 17405 17406 17407 17408 17409 17410 17411 17412 17413 17414 17415 17416 17417 17418 17419 17420 17421 17422 17423 17424 17425 17426 17427 17428 17429 17430 17431 17432 17433 17434 17435 17436 17437 17438 17439 17440 17441 17442 17443 17444 17445 17446 17447 17448 17449 17450 17451 17452 17453 17454 17455 17456 17457 17458 17459 17460 17461 17462 17463 17464 17465 17466 17467 17468 17469 17470 17471 17472 17473 17474 17475 17476 17477 17478 17479 17480 17481 17482 17483 17484 17485 17486 17487 17488 17489 17490 17491 17492 17493 17494 17495 17496 17497 17498 17499 17500 17501 17502 17503 17504 17505 17506 17507 17508 17509 17510 17511 17512 17513 17514 17515 17516 17517 17518 17519 17520 17521 17522 17523 17524 17525 17526 17527 17528 17529 17530 17531 17532 17533 17534 17535 17536 17537 17538 17539 17540 17541 17542 17543 17544 17545 17546 17547 17548 17549 17550 17551 17552 17553 17554 17555 17556 17557 17558 17559 17560 17561 17562 17563 17564 17565 17566 17567 17568 17569 17570 17571 17572 17573 17574 17575 17576 17577 17578 17579 17580 17581 17582 17583 17584 17585 17586 17587 17588 17589 17590 17591 17592 17593 17594 17595 17596 17597 17598 17599 17600 17601 17602 17603 17604 17605 17606 17607 17608 17609 17610 17611 17612 17613 17614 17615 17616 17617 17618 17619 17620 17621 17622 17623 17624 17625 17626 17627 17628 17629 17630 17631 17632 17633 17634 17635 17636 17637 17638 17639 17640 17641 17642 17643 17644 17645 17646 17647 17648 17649 17650 17651 17652 17653 17654 17655 17656 17657 17658 17659 17660 17661 17662 17663 17664 17665 17666 17667 17668 17669 17670 17671 17672 17673 17674 17675 17676 17677 17678 17679 17680 17681 17682 17683 17684 17685 17686 17687 17688 17689 17690 17691 17692 17693 17694 17695 17696 17697 17698 17699 17700 17701 17702 17703 17704 17705 17706 17707 17708 17709 17710 17711 17712 17713 17714 17715 17716 17717 17718 17719 17720 17721 17722 17723 17724 17725 17726 17727 17728 17729 17730 17731 17732 17733 17734 17735 17736 17737 17738 17739 17740 17741 17742 17743 17744 17745 17746 17747 17748 17749 17750 17751 17752 17753 17754 17755 17756 17757 17758 17759 17760 17761 17762 17763 17764 17765 17766 17767 17768 17769 17770 17771 17772 17773 17774 17775 17776 17777 17778 17779 17780 17781 17782 17783 17784 17785 17786 17787 17788 17789 17790 17791 17792 17793 17794 17795 17796 17797 17798 17799 17800 17801 17802 17803 17804 17805 17806 17807 17808 17809 17810 17811 17812 17813 17814 17815 17816 17817 17818 17819 17820 17821 17822 17823 17824 17825 17826 17827 17828 17829 17830 17831 17832 17833 17834 17835 17836 17837 17838 17839 17840 17841 17842 17843 17844 17845 17846 17847 17848 17849 17850 17851 17852 17853 17854 17855 17856 17857 17858 17859 17860 17861 17862 17863 17864 17865 17866 17867 17868 17869 17870 17871 17872 17873 17874 17875 17876 17877 17878 17879 17880 17881 17882 17883 17884 17885 17886 17887 17888 17889 17890 17891 17892 17893 17894 17895 17896 17897 17898 17899 17900 17901 17902 17903 17904 17905 17906 17907 17908 17909 17910 17911 17912 17913 17914 17915 17916 17917 17918 17919 17920 17921 17922 17923 17924 17925 17926 17927 17928 17929 17930 17931 17932 17933 17934 17935 17936 17937 17938 17939 17940 17941 17942 17943 17944 17945 17946 17947 17948 17949 17950 17951 17952 17953 17954 17955 17956 17957 17958 17959 17960 17961 17962 17963 17964 17965 17966 17967 17968 17969 17970 17971 17972 17973 17974 17975 17976 17977 17978 17979 17980 17981 17982 17983 17984 17985 17986 17987 17988 17989 17990 17991 17992 17993 17994 17995 17996 17997 17998 17999 18000 18001 18002 18003 18004 18005 18006 18007 18008 18009 18010 18011 18012 18013 18014 18015 18016 18017 18018 18019 18020 18021 18022 18023 18024 18025 18026 18027 18028 18029 18030 18031 18032 18033 18034 18035 18036 18037 18038 18039 18040 18041 18042 18043 18044 18045 18046 18047 18048 18049 18050 18051 18052 18053 18054 18055 18056 18057 18058 18059 18060 18061 18062 18063 18064 18065 18066 18067 18068 18069 18070 18071 18072 18073 18074 18075 18076 18077 18078 18079 18080 18081 18082 18083 18084 18085 18086 18087 18088 18089 18090 18091 18092 18093 18094 18095 18096 18097 18098 18099 18100 18101 18102 18103 18104 18105 18106 18107 18108 18109 18110 18111 18112 18113 18114 18115 18116 18117 18118 18119 18120 18121 18122 18123 18124 18125 18126 18127 18128 18129 18130 18131 18132 18133 18134 18135 18136 18137 18138 18139 18140 18141 18142 18143 18144 18145 18146 18147 18148 18149 18150 18151 18152 18153 18154 18155 18156 18157 18158 18159 18160 18161 18162 18163 18164 18165 18166 18167 18168 18169 18170 18171 18172 18173 18174 18175 18176 18177 18178 18179 18180 18181 18182 18183 18184 18185 18186 18187 18188 18189 18190 18191 18192 18193 18194 18195 18196 18197 18198 18199 18200 18201 18202 18203 18204 18205 18206 18207 18208 18209 18210 18211 18212 18213 18214 18215 18216 18217 18218 18219 18220 18221 18222 18223 18224 18225 18226 18227 18228 18229 18230 18231 18232 18233 18234 18235 18236 18237 18238 18239 18240 18241 18242 18243 18244 18245 18246 18247 18248 18249 18250 18251 18252 18253 18254 18255 18256 18257 18258 18259 18260 18261 18262 18263 18264 18265 18266 18267 18268 18269 18270 18271 18272 18273 18274 18275 18276 18277 18278 18279 18280 18281 18282 18283 18284 18285 18286 18287 18288 18289 18290 18291 18292 18293 18294 18295 18296 18297 18298 18299 18300 18301 18302 18303 18304 18305 18306 18307 18308 18309 18310 18311 18312 18313 18314 18315 18316 18317 18318 18319 18320 18321 18322 18323 18324 18325 18326 18327 18328 18329 18330 18331 18332 18333 18334 18335 18336 18337 18338 18339 18340 18341 18342 18343 18344 18345 18346 18347 18348 18349 18350 18351 18352 18353 18354 18355 18356 18357 18358 18359 18360 18361 18362 18363 18364 18365 18366 18367 18368 18369 18370 18371 18372 18373 18374 18375 18376 18377 18378 18379 18380 18381 18382 18383 18384 18385 18386 18387 18388 18389 18390 18391 18392 18393 18394 18395 18396 18397 18398 18399 18400 18401 18402 18403 18404 18405 18406 18407 18408 18409 18410 18411 18412 18413 18414 18415 18416 18417 18418 18419 18420 18421 18422 18423 18424 18425 18426 18427 18428 18429 18430 18431 18432 18433 18434 18435 18436 18437 18438 18439 18440 18441 18442 18443 18444 18445 18446 18447 18448 18449 18450 18451 18452 18453 18454 18455 18456 18457 18458 18459 18460 18461 18462 18463 18464 18465 18466 18467 18468 18469 18470 18471 18472 18473 18474 18475 18476 18477 18478 18479 18480 18481 18482 18483 18484 18485 18486 18487 18488 18489 18490 18491 18492 18493 18494 18495 18496 18497 18498 18499 18500 18501 18502 18503 18504 18505 18506 18507 18508 18509 18510 18511 18512 18513 18514 18515 18516 18517 18518 18519 18520 18521 18522 18523 18524 18525 18526 18527 18528 18529 18530 18531 18532 18533 18534 18535 18536 18537 18538 18539 18540 18541 18542 18543 18544 18545 18546 18547 18548 18549 18550 18551 18552 18553 18554 18555 18556 18557 18558 18559 18560 18561 18562 18563 18564 18565 18566 18567 18568 18569 18570 18571 18572 18573 18574 18575 18576 18577 18578 18579 18580 18581 18582 18583 18584 18585 18586 18587 18588 18589 18590 18591 18592 18593 18594 18595 18596 18597 18598 18599 18600 18601 18602 18603 18604 18605 18606 18607 18608 18609 18610 18611 18612 18613 18614 18615 18616 18617 18618 18619 18620 18621 18622 18623 18624 18625 18626 18627 18628 18629 18630 18631 18632 18633 18634 18635 18636 18637 18638 18639 18640 18641 18642 18643 18644 18645 18646 18647 18648 18649 18650 18651 18652 18653 18654 18655 18656 18657 18658 18659 18660 18661 18662 18663 18664 18665 18666 18667 18668 18669 18670 18671 18672 18673 18674 18675 18676 18677 18678 18679 18680 18681 18682 18683 18684 18685 18686 18687 18688 18689 18690 18691 18692 18693 18694 18695 18696 18697 18698 18699 18700 18701 18702 18703 18704 18705 18706 18707 18708 18709 18710 18711 18712 18713 18714 18715 18716 18717 18718 18719 18720 18721 18722 18723 18724 18725 18726 18727 18728 18729 18730 18731 18732 18733 18734 18735 18736 18737 18738 18739 18740 18741 18742 18743 18744 18745 18746 18747 18748 18749 18750 18751 18752 18753 18754 18755 18756 18757 18758 18759 18760 18761 18762 18763 18764 18765 18766 18767 18768 18769 18770 18771 18772 18773 18774 18775 18776 18777 18778 18779 18780 18781 18782 18783 18784 18785 18786 18787 18788 18789 18790 18791 18792 18793 18794 18795 18796 18797 18798 18799 18800 18801 18802 18803 18804 18805 18806 18807 18808 18809 18810 18811 18812 18813 18814 18815 18816 18817 18818 18819 18820 18821 18822 18823 18824 18825 18826 18827 18828 18829 18830 18831 18832 18833 18834 18835 18836 18837 18838 18839 18840 18841 18842 18843 18844 18845 18846 18847 18848 18849 18850 18851 18852 18853 18854 18855 18856 18857 18858 18859 18860 18861 18862 18863 18864 18865 18866 18867 18868 18869 18870 18871 18872 18873 18874 18875 18876 18877 18878 18879 18880 18881 18882 18883 18884 18885 18886 18887 18888 18889 18890 18891 18892 18893 18894 18895 18896 18897 18898 18899 18900 18901 18902 18903 18904 18905 18906 18907 18908 18909 18910 18911 18912 18913 18914 18915 18916 18917 18918 18919 18920 18921 18922 18923 18924 18925 18926 18927 18928 18929 18930 18931 18932 18933 18934 18935 18936 18937 18938 18939 18940 18941 18942 18943 18944 18945 18946 18947 18948 18949 18950 18951 18952 18953 18954 18955 18956 18957 18958 18959 18960 18961 18962 18963 18964 18965 18966 18967 18968 18969 18970 18971 18972 18973 18974 18975 18976 18977 18978 18979 18980 18981 18982 18983 18984 18985 18986 18987 18988 18989 18990 18991 18992 18993 18994 18995 18996 18997 18998 18999 19000 19001 19002 19003 19004 19005 19006 19007 19008 19009 19010 19011 19012 19013 19014 19015 19016 19017 19018 19019 19020 19021 19022 19023 19024 19025 19026 19027 19028 19029 19030 19031 19032 19033 19034 19035 19036 19037 19038 19039 19040 19041 19042 19043 19044 19045 19046 19047 19048 19049 19050 19051 19052 19053 19054 19055 19056 19057 19058 19059 19060 19061 19062 19063 19064 19065 19066 19067 19068 19069 19070 19071 19072 19073 19074 19075 19076 19077 19078 19079 19080 19081 19082 19083 19084 19085 19086 19087 19088 19089 19090 19091 19092 19093 19094 19095 19096 19097 19098 19099 19100 19101 19102 19103 19104 19105 19106 19107 19108 19109 19110 19111 19112 19113 19114 19115 19116 19117 19118 19119 19120 19121 19122 19123 19124 19125 19126 19127 19128 19129 19130 19131 19132 19133 19134 19135 19136 19137 19138 19139 19140 19141 19142 19143 19144 19145 19146 19147 19148 19149 19150 19151 19152 19153 19154 19155 19156 19157 19158 19159 19160 19161 19162 19163 19164 19165 19166 19167 19168 19169 19170 19171 19172 19173 19174 19175 19176 19177 19178 19179 19180 19181 19182 19183 19184 19185 19186 19187 19188 19189 19190 19191 19192 19193 19194 19195 19196 19197 19198 19199 19200 19201 19202 19203 19204 19205 19206 19207 19208 19209 19210 19211 19212 19213 19214 19215 19216 19217 19218 19219 19220 19221 19222 19223 19224 19225 19226 19227 19228 19229 19230 19231 19232 19233 19234 19235 19236 19237 19238 19239 19240 19241 19242 19243 19244 19245 19246 19247 19248 19249 19250 19251 19252 19253 19254 19255 19256 19257 19258 19259 19260 19261 19262 19263 19264 19265 19266 19267 19268 19269 19270 19271 19272 19273 19274 19275 19276 19277 19278 19279 19280 19281 19282 19283 19284 19285 19286 19287 19288 19289 19290 19291 19292 19293 19294 19295 19296 19297 19298 19299 19300 19301 19302 19303 19304 19305 19306 19307 19308 19309 19310 19311 19312 19313 19314 19315 19316 19317 19318 19319 19320 19321 19322 19323 19324 19325 19326 19327 19328 19329 19330 19331 19332 19333 19334 19335 19336 19337 19338 19339 19340 19341 19342 19343 19344 19345 19346 19347 19348 19349 19350 19351 19352 19353 19354 19355 19356 19357 19358 19359 19360 19361 19362 19363 19364 19365 19366 19367 19368 19369 19370 19371 19372 19373 19374 19375 19376 19377 19378 19379 19380 19381 19382 19383 19384 19385 19386 19387 19388 19389 19390 19391 19392 19393 19394 19395 19396 19397 19398 19399 19400 19401 19402 19403 19404 19405 19406 19407 19408 19409 19410 19411 19412 19413 19414 19415 19416 19417 19418 19419 19420 19421 19422 19423 19424 19425 19426 19427 19428 19429 19430 19431 19432 19433 19434 19435 19436 19437 19438 19439 19440 19441 19442 19443 19444 19445 19446 19447 19448 19449 19450 19451 19452 19453 19454 19455 19456 19457 19458 19459 19460 19461 19462 19463 19464 19465 19466 19467 19468 19469 19470 19471 19472 19473 19474 19475 19476 19477 19478 19479 19480 19481 19482 19483 19484 19485 19486 19487 19488 19489 19490 19491 19492 19493 19494 19495 19496 19497 19498 19499 19500 19501 19502 19503 19504 19505 19506 19507 19508 19509 19510 19511 19512 19513 19514 19515 19516 19517 19518 19519 19520 19521 19522 19523 19524 19525 19526 19527 19528 19529 19530 19531 19532 19533 19534 19535 19536 19537 19538 19539 19540 19541 19542 19543 19544 19545 19546 19547 19548 19549 19550 19551 19552 19553 19554 19555 19556 19557 19558 19559 19560 19561 19562 19563 19564 19565 19566 19567 19568 19569 19570 19571 19572 19573 19574 19575 19576 19577 19578 19579 19580 19581 19582 19583 19584 19585 19586 19587 19588 19589 19590 19591 19592 19593 19594 19595 19596 19597 19598 19599 19600 19601 19602 19603 19604 19605 19606 19607 19608 19609 19610 19611 19612 19613 19614 19615 19616 19617 19618 19619 19620 19621 19622 19623 19624 19625 19626 19627 19628 19629 19630 19631 19632 19633 19634 19635 19636 19637 19638 19639 19640 19641 19642 19643 19644 19645 19646 19647 19648 19649 19650 19651 19652 19653 19654 19655 19656 19657 19658 19659 19660 19661 19662 19663 19664 19665 19666 19667 19668 19669 19670 19671 19672 19673 19674 19675 19676 19677 19678 19679 19680 19681 19682 19683 19684 19685 19686 19687 19688 19689 19690 19691 19692 19693 19694 19695 19696 19697 19698 19699 19700 19701 19702 19703 19704 19705 19706 19707 19708 19709 19710 19711 19712 19713 19714 19715 19716 19717 19718 19719 19720 19721 19722 19723 19724 19725 19726 19727 19728 19729 19730 19731 19732 19733 19734 19735 19736 19737 19738 19739 19740 19741 19742 19743 19744 19745 19746 19747 19748 19749 19750 19751 19752 19753 19754 19755 19756 19757 19758 19759 19760 19761 19762 19763 19764 19765 19766 19767 19768 19769 19770 19771 19772 19773 19774 19775 19776 19777 19778 19779 19780 19781 19782 19783 19784 19785 19786 19787 19788 19789 19790 19791 19792 19793 19794 19795 19796 19797 19798 19799 19800 19801 19802 19803 19804 19805 19806 19807 19808 19809 19810 19811 19812 19813 19814 19815 19816 19817 19818 19819 19820 19821 19822 19823 19824 19825 19826 19827 19828 19829 19830 19831 19832 19833 19834 19835 19836 19837 19838 19839 19840 19841 19842 19843 19844 19845 19846 19847 19848 19849 19850 19851 19852 19853 19854 19855 19856 19857 19858 19859 19860 19861 19862 19863 19864 19865 19866 19867 19868 19869 19870 19871 19872 19873 19874 19875 19876 19877 19878 19879 19880 19881 19882 19883 19884 19885 19886 19887 19888 19889 19890 19891 19892 19893 19894 19895 19896 19897 19898 19899 19900 19901 19902 19903 19904 19905 19906 19907 19908 19909 19910 19911 19912 19913 19914 19915 19916 19917 19918 19919 19920 19921 19922 19923 19924 19925 19926 19927 19928 19929 19930 19931 19932 19933 19934 19935 19936 19937 19938 19939 19940 19941 19942 19943 19944 19945 19946 19947 19948 19949 19950 19951 19952 19953 19954 19955 19956 19957 19958 19959 19960 19961 19962 19963 19964 19965 19966 19967 19968 19969 19970 19971 19972 19973 19974 19975 19976 19977 19978 19979 19980 19981 19982 19983 19984 19985 19986 19987 19988 19989 19990 19991 19992 19993 19994 19995 19996 19997 19998 19999 20000 20001 20002 20003 20004 20005 20006 20007 20008 20009 20010 20011 20012 20013 20014 20015 20016 20017 20018 20019 20020 20021 20022 20023 20024 20025 20026 20027 20028 20029 20030 20031 20032 20033 20034 20035 20036 20037 20038 20039 20040 20041 20042 20043 20044 20045 20046 20047 20048 20049 20050 20051 20052 20053 20054 20055 20056 20057 20058 20059 20060 20061 20062 20063 20064 20065 20066 20067 20068 20069 20070 20071 20072 20073 20074 20075 20076 20077 20078 20079 20080 20081 20082 20083 20084 20085 20086 20087 20088 20089 20090 20091 20092 20093 20094 20095 20096 20097 20098 20099 20100 20101 20102 20103 20104 20105 20106 20107 20108 20109 20110 20111 20112 20113 20114 20115 20116 20117 20118 20119 20120 20121 20122 20123 20124 20125 20126 20127 20128 20129 20130 20131 20132 20133 20134 20135 20136 20137 20138 20139 20140 20141 20142 20143 20144 20145 20146 20147 20148 20149 20150 20151 20152 20153 20154 20155 20156 20157 20158 20159 20160 20161 20162 20163 20164 20165 20166 20167 20168 20169 20170 20171 20172 20173 20174 20175 20176 20177 20178 20179 20180 20181 20182 20183 20184 20185 20186 20187 20188 20189 20190 20191 20192 20193 20194 20195 20196 20197 20198 20199 20200 20201 20202 20203 20204 20205 20206 20207 20208 20209 20210 20211 20212 20213 20214 20215 20216 20217 20218 20219 20220 20221 20222 20223 20224 20225 20226 20227 20228 20229 20230 20231 20232 20233 20234 20235 20236 20237 20238 20239 20240 20241 20242 20243 20244 20245 20246 20247 20248 20249 20250 20251 20252 20253 20254 20255 20256 20257 20258 20259 20260 20261 20262 20263 20264 20265 20266 20267 20268 20269 20270 20271 20272 20273 20274 20275 20276 20277 20278 20279 20280 20281 20282 20283 20284 20285 20286 20287 20288 20289 20290 20291 20292 20293 20294 20295 20296 20297 20298 20299 20300 20301 20302 20303 20304 20305 20306 20307 20308 20309 20310 20311 20312 20313 20314 20315 20316 20317 20318 20319 20320 20321 20322 20323 20324 20325 20326 20327 20328 20329 20330 20331 20332 20333 20334 20335 20336 20337 20338 20339 20340 20341 20342 20343 20344 20345 20346 20347 20348 20349 20350 20351 20352 20353 20354 20355 20356 20357 20358 20359 20360 20361 20362 20363 20364 20365 20366 20367 20368 20369 20370 20371 20372 20373 20374 20375 20376 20377 20378 20379 20380 20381 20382 20383 20384 20385 20386 20387 20388 20389 20390 20391 20392 20393 20394 20395 20396 20397 20398 20399 20400 20401 20402 20403 20404 20405 20406 20407 20408 20409 20410 20411 20412 20413 20414 20415 20416 20417 20418 20419 20420 20421 20422 20423 20424 20425 20426 20427 20428 20429 20430 20431 20432 20433 20434 20435 20436 20437 20438 20439 20440 20441 20442 20443 20444 20445 20446 20447 20448 20449 20450 20451 20452 20453 20454 20455 20456 20457 20458 20459 20460 20461 20462 20463 20464 20465 20466 20467 20468 20469 20470 20471 20472 20473 20474 20475 20476 20477 20478 20479 20480 20481 20482 20483 20484 20485 20486 20487 20488 20489 20490 20491 20492 20493 20494 20495 20496 20497 20498 20499 20500 20501 20502 20503 20504 20505 20506 20507 20508 20509 20510 20511 20512 20513 20514 20515 20516 20517 20518 20519 20520 20521 20522 20523 20524 20525 20526 20527 20528 20529 20530 20531 20532 20533 20534 20535 20536 20537 20538 20539 20540 20541 20542 20543 20544 20545 20546 20547 20548 20549 20550 20551 20552 20553 20554 20555 20556 20557 20558 20559 20560 20561 20562 20563 20564 20565 20566 20567 20568 20569 20570 20571 20572 20573 20574 20575 20576 20577 20578 20579 20580 20581 20582 20583 20584 20585 20586 20587 20588 20589 20590 20591 20592 20593 20594 20595 20596 20597 20598 20599 20600 20601 20602 20603 20604 20605 20606 20607 20608 20609 20610 20611 20612 20613 20614 20615 20616 20617 20618 20619 20620 20621 20622 20623 20624 20625 20626 20627 20628 20629 20630 20631 20632 20633 20634 20635 20636 20637 20638 20639 20640 20641 20642 20643 20644 20645 20646 20647 20648 20649 20650 20651 20652 20653 20654 20655 20656 20657 20658 20659 20660 20661 20662 20663 20664 20665 20666 20667 20668 20669 20670 20671 20672 20673 20674 20675 20676 20677 20678 20679 20680 20681 20682 20683 20684 20685 20686 20687 20688 20689 20690 20691 20692 20693 20694 20695 20696 20697 20698 20699 20700 20701 20702 20703 20704 20705 20706 20707 20708 20709 20710 20711 20712 20713 20714 20715 20716 20717 20718 20719 20720 20721 20722 20723 20724 20725 20726 20727 20728 20729 20730 20731 20732 20733 20734 20735 20736 20737 20738 20739 20740 20741 20742 20743 20744 20745 20746 20747 20748 20749 20750 20751 20752 20753 20754 20755 20756 20757 20758 20759 20760 20761 20762 20763 20764 20765 20766 20767 20768 20769 20770 20771 20772 20773 20774 20775 20776 20777 20778 20779 20780 20781 20782 20783 20784 20785 20786 20787 20788 20789 20790 20791 20792 20793 20794 20795 20796 20797 20798 20799 20800 20801 20802 20803 20804 20805 20806 20807 20808 20809 20810 20811 20812 20813 20814 20815 20816 20817 20818 20819 20820 20821 20822 20823 20824 20825 20826 20827 20828 20829 20830 20831 20832 20833 20834 20835 20836 20837 20838 20839 20840 20841 20842 20843 20844 20845 20846 20847 20848 20849 20850 20851 20852 20853 20854 20855 20856 20857 20858 20859 20860 20861 20862 20863 20864 20865 20866 20867 20868 20869 20870 20871 20872 20873 20874 20875 20876 20877 20878 20879 20880 20881 20882 20883 20884 20885 20886 20887 20888 20889 20890 20891 20892 20893 20894 20895 20896 20897 20898 20899 20900 20901 20902 20903 20904 20905 20906 20907 20908 20909 20910 20911 20912 20913 20914 20915 20916 20917 20918 20919 20920 20921 20922 20923 20924 20925 20926 20927 20928 20929 20930 20931 20932 20933 20934 20935 20936 20937 20938 20939 20940 20941 20942 20943 20944 20945 20946 20947 20948 20949 20950 20951 20952 20953 20954 20955 20956 20957 20958 20959 20960 20961 20962 20963 20964 20965 20966 20967 20968 20969 20970 20971 20972 20973 20974 20975 20976 20977 20978 20979 20980 20981 20982 20983 20984 20985 20986 20987 20988 20989 20990 20991 20992 20993 20994 20995 20996 20997 20998 20999 21000 21001 21002 21003 21004 21005 21006 21007 21008 21009 21010 21011 21012 21013 21014 21015 21016 21017 21018 21019 21020 21021 21022 21023 21024 21025 21026 21027 21028 21029 21030 21031 21032 21033 21034 21035 21036 21037 21038 21039 21040 21041 21042 21043 21044 21045 21046 21047 21048 21049 21050 21051 21052 21053 21054 21055 21056 21057 21058 21059 21060 21061 21062 21063 21064 21065 21066 21067 21068 21069 21070 21071 21072 21073 21074 21075 21076 21077 21078 21079 21080 21081 21082 21083 21084 21085 21086 21087 21088 21089 21090 21091 21092 21093 21094 21095 21096 21097 21098 21099 21100 21101 21102 21103 21104 21105 21106 21107 21108 21109 21110 21111 21112 21113 21114 21115 21116 21117 21118 21119 21120 21121 21122 21123 21124 21125 21126 21127 21128 21129 21130 21131 21132 21133 21134 21135 21136 21137 21138 21139 21140 21141 21142 21143 21144 21145 21146 21147 21148 21149 21150 21151 21152 21153 21154 21155 21156 21157 21158 21159 21160 21161 21162 21163 21164 21165 21166 21167 21168 21169 21170 21171 21172 21173 21174 21175 21176 21177 21178 21179 21180 21181 21182 21183 21184 21185 21186 21187 21188 21189 21190 21191 21192 21193 21194 21195 21196 21197 21198 21199 21200 21201 21202 21203 21204 21205 21206 21207 21208 21209 21210 21211 21212 21213 21214 21215 21216 21217 21218 21219 21220 21221 21222 21223 21224 21225 21226 21227 21228 21229 21230 21231 21232 21233 21234 21235 21236 21237 21238 21239 21240 21241 21242 21243 21244 21245 21246 21247 21248 21249 21250 21251 21252 21253 21254 21255 21256 21257 21258 21259 21260 21261 21262 21263 21264 21265 21266 21267 21268 21269 21270 21271 21272 21273 21274 21275 21276 21277 21278 21279 21280 21281 21282 21283 21284 21285 21286 21287 21288 21289 21290 21291 21292 21293 21294 21295 21296 21297 21298 21299 21300 21301 21302 21303 21304 21305 21306 21307 21308 21309 21310 21311 21312 21313 21314 21315 21316 21317 21318 21319 21320 21321 21322 21323 21324 21325 21326 21327 21328 21329 21330 21331 21332 21333 21334 21335 21336 21337 21338 21339 21340 21341 21342 21343 21344 21345 21346 21347 21348 21349 21350 21351 21352 21353 21354 21355 21356 21357 21358 21359 21360 21361 21362 21363 21364 21365 21366 21367 21368 21369 21370 21371 21372 21373 21374 21375 21376 21377 21378 21379 21380 21381 21382 21383 21384 21385 21386 21387 21388 21389 21390 21391 21392 21393 21394 21395 21396 21397 21398 21399 21400 21401 21402 21403 21404 21405 21406 21407 21408 21409 21410 21411 21412 21413 21414 21415 21416 21417 21418 21419 21420 21421 21422 21423 21424 21425 21426 21427 21428 21429 21430 21431 21432 21433 21434 21435 21436 21437 21438 21439 21440 21441 21442 21443 21444 21445 21446 21447 21448 21449 21450 21451 21452 21453 21454 21455 21456 21457 21458 21459 21460 21461 21462 21463 21464 21465 21466 21467 21468 21469 21470 21471 21472 21473 21474 21475 21476 21477 21478 21479 21480 21481 21482 21483 21484 21485 21486 21487 21488 21489 21490 21491 21492 21493 21494 21495 21496 21497 21498 21499 21500 21501 21502 21503 21504 21505 21506 21507 21508 21509 21510 21511 21512 21513 21514 21515 21516 21517 21518 21519 21520 21521 21522 21523 21524 21525 21526 21527 21528 21529 21530 21531 21532 21533 21534 21535 21536 21537 21538 21539 21540 21541 21542 21543 21544 21545 21546 21547 21548 21549 21550 21551 21552 21553 21554 21555 21556 21557 21558 21559 21560 21561 21562 21563 21564 21565 21566 21567 21568 21569 21570 21571 21572 21573 21574 21575 21576 21577 21578 21579 21580 21581 21582 21583 21584 21585 21586 21587 21588 21589 21590 21591 21592 21593 21594 21595 21596 21597 21598 21599 21600 21601 21602 21603 21604 21605 21606 21607 21608 21609 21610 21611 21612 21613 21614 21615 21616 21617 21618 21619 21620 21621 21622 21623 21624 21625 21626 21627 21628 21629 21630 21631 21632 21633 21634 21635 21636 21637 21638 21639 21640 21641 21642 21643 21644 21645 21646 21647 21648 21649 21650 21651 21652 21653 21654 21655 21656 21657 21658 21659 21660 21661 21662 21663 21664 21665 21666 21667 21668 21669 21670 21671 21672 21673 21674 21675 21676 21677 21678 21679 21680 21681 21682 21683 21684 21685 21686 21687 21688 21689 21690 21691 21692 21693 21694 21695 21696 21697 21698 21699 21700 21701 21702 21703 21704 21705 21706 21707 21708 21709 21710 21711 21712 21713 21714 21715 21716 21717 21718 21719 21720 21721 21722 21723 21724 21725 21726 21727 21728 21729 21730 21731 21732 21733 21734 21735 21736 21737 21738 21739 21740 21741 21742 21743 21744 21745 21746 21747 21748 21749 21750 21751 21752 21753 21754 21755 21756 21757 21758 21759 21760 21761 21762 21763 21764 21765 21766 21767 21768 21769 21770 21771 21772 21773 21774 21775 21776 21777 21778 21779 21780 21781 21782 21783 21784 21785 21786 21787 21788 21789 21790 21791 21792 21793 21794 21795 21796 21797 21798 21799 21800 21801 21802 21803 21804 21805 21806 21807 21808 21809 21810 21811 21812 21813 21814 21815 21816 21817 21818 21819 21820 21821 21822 21823 21824 21825 21826 21827 21828 21829 21830 21831 21832 21833 21834 21835 21836 21837 21838 21839 21840 21841 21842 21843 21844 21845 21846 21847 21848 21849 21850 21851 21852 21853 21854 21855 21856 21857 21858 21859 21860 21861 21862 21863 21864 21865 21866 21867 21868 21869 21870 21871 21872 21873 21874 21875 21876 21877 21878 21879 21880 21881 21882 21883 21884 21885 21886 21887 21888 21889 21890 21891 21892 21893 21894 21895 21896 21897 21898 21899 21900 21901 21902 21903 21904 21905 21906 21907 21908 21909 21910 21911 21912 21913 21914 21915 21916 21917 21918 21919 21920 21921 21922 21923 21924 21925 21926 21927 21928 21929 21930 21931 21932 21933 21934 21935 21936 21937 21938 21939 21940 21941 21942 21943 21944 21945 21946 21947 21948 21949 21950 21951 21952 21953 21954 21955 21956 21957 21958 21959 21960 21961 21962 21963 21964 21965 21966 21967 21968 21969 21970 21971 21972 21973 21974 21975 21976 21977 21978 21979 21980 21981 21982 21983 21984 21985 21986 21987 21988 21989 21990 21991 21992 21993 21994 21995 21996 21997 21998 21999 22000 22001 22002 22003 22004 22005 22006 22007 22008 22009 22010 22011 22012 22013 22014 22015 22016 22017 22018 22019 22020 22021 22022 22023 22024 22025 22026 22027 22028 22029 22030 22031 22032 22033 22034 22035 22036 22037 22038 22039 22040 22041 22042 22043 22044 22045 22046 22047 22048 22049 22050 22051 22052 22053 22054 22055 22056 22057 22058 22059 22060 22061 22062 22063 22064 22065 22066 22067 22068 22069 22070 22071 22072 22073 22074 22075 22076 22077 22078 22079 22080 22081 22082 22083 22084 22085 22086 22087 22088 22089 22090 22091 22092 22093 22094 22095 22096 22097 22098 22099 22100 22101 22102 22103 22104 22105 22106 22107 22108 22109 22110 22111 22112 22113 22114 22115 22116 22117 22118 22119 22120 22121 22122 22123 22124 22125 22126 22127 22128 22129 22130 22131 22132 22133 22134 22135 22136 22137 22138 22139 22140 22141 22142 22143 22144 22145 22146 22147 22148 22149 22150 22151 22152 22153 22154 22155 22156 22157 22158 22159 22160 22161 22162 22163 22164 22165 22166 22167 22168 22169 22170 22171 22172 22173 22174 22175 22176 22177 22178 22179 22180 22181 22182 22183 22184 22185 22186 22187 22188 22189 22190 22191 22192 22193 22194 22195 22196 22197 22198 22199 22200 22201 22202 22203 22204 22205 22206 22207 22208 22209 22210 22211 22212 22213 22214 22215 22216 22217 22218 22219 22220 22221 22222 22223 22224 22225 22226 22227 22228 22229 22230 22231 22232 22233 22234 22235 22236 22237 22238 22239 22240 22241 22242 22243 22244 22245 22246 22247 22248 22249 22250 22251 22252 22253 22254 22255 22256 22257 22258 22259 22260 22261 22262 22263 22264 22265 22266 22267 22268 22269 22270 22271 22272 22273 22274 22275 22276 22277 22278 22279 22280 22281 22282 22283 22284 22285 22286 22287 22288 22289 22290 22291 22292 22293 22294 22295 22296 22297 22298 22299 22300 22301 22302 22303 22304 22305 22306 22307 22308 22309 22310 22311 22312 22313 22314 22315 22316 22317 22318 22319 22320 22321 22322 22323 22324 22325 22326 22327 22328 22329 22330 22331 22332 22333 22334 22335 22336 22337 22338 22339 22340 22341 22342 22343 22344 22345 22346 22347 22348 22349 22350 22351 22352 22353 22354 22355 22356 22357 22358 22359 22360 22361 22362 22363 22364 22365 22366 22367 22368 22369 22370 22371 22372 22373 22374 22375 22376 22377 22378 22379 22380 22381 22382 22383 22384 22385 22386 22387 22388 22389 22390 22391 22392 22393 22394 22395 22396 22397 22398 22399 22400 22401 22402 22403 22404 22405 22406 22407 22408 22409 22410 22411 22412 22413 22414 22415 22416 22417 22418 22419 22420 22421 22422 22423 22424 22425 22426 22427 22428 22429 22430 22431 22432 22433 22434 22435 22436 22437 22438 22439 22440 22441 22442 22443 22444 22445 22446 22447 22448 22449 22450 22451 22452 22453 22454 22455 22456 22457 22458 22459 22460 22461 22462 22463 22464 22465 22466 22467 22468 22469 22470 22471 22472 22473 22474 22475 22476 22477 22478 22479 22480 22481 22482 22483 22484 22485 22486 22487 22488 22489 22490 22491 22492 22493 22494 22495 22496 22497 22498 22499 22500 22501 22502 22503 22504 22505 22506 22507 22508 22509 22510 22511 22512 22513 22514 22515 22516 22517 22518 22519 22520 22521 22522 22523 22524 22525 22526 22527 22528 22529 22530 22531 22532 22533 22534 22535 22536 22537 22538 22539 22540 22541 22542 22543 22544 22545 22546 22547 22548 22549 22550 22551 22552 22553 22554 22555 22556 22557 22558 22559 22560 22561 22562 22563 22564 22565 22566 22567 22568 22569 22570 22571 22572 22573 22574 22575 22576 22577 22578 22579 22580 22581 22582 22583 22584 22585 22586 22587 22588 22589 22590 22591 22592 22593 22594 22595 22596 22597 22598 22599 22600 22601 22602 22603 22604 22605 22606 22607 22608 22609 22610 22611 22612 22613 22614 22615 22616 22617 22618 22619 22620 22621 22622 22623 22624 22625 22626 22627 22628 22629 22630 22631 22632 22633 22634 22635 22636 22637 22638 22639 22640 22641 22642 22643 22644 22645 22646 22647 22648 22649 22650 22651 22652 22653 22654 22655 22656 22657 22658 22659 22660 22661 22662 22663 22664 22665 22666 22667 22668 22669 22670 22671 22672 22673 22674 22675 22676 22677 22678 22679 22680 22681 22682 22683 22684 22685 22686 22687 22688 22689 22690 22691 22692 22693 22694 22695 22696 22697 22698 22699 22700 22701 22702 22703 22704 22705 22706 22707 22708 22709 22710 22711 22712 22713 22714 22715 22716 22717 22718 22719 22720 22721 22722 22723 22724 22725 22726 22727 22728 22729 22730 22731 22732 22733 22734 22735 22736 22737 22738 22739 22740 22741 22742 22743 22744 22745 22746 22747 22748 22749 22750 22751 22752 22753 22754 22755 22756 22757 22758 22759 22760 22761 22762 22763 22764 22765 22766 22767 22768 22769 22770 22771 22772 22773 22774 22775 22776 22777 22778 22779 22780 22781 22782 22783 22784 22785 22786 22787 22788 22789 22790 22791 22792 22793 22794 22795 22796 22797 22798 22799 22800 22801 22802 22803 22804 22805 22806 22807 22808 22809 22810 22811 22812 22813 22814 22815 22816 22817 22818 22819 22820 22821 22822 22823 22824 22825 22826 22827 22828 22829 22830 22831 22832 22833 22834 22835 22836 22837 22838 22839 22840 22841 22842 22843 22844 22845 22846 22847 22848 22849 22850 22851 22852 22853 22854 22855 22856 22857 22858 22859 22860 22861 22862 22863 22864 22865 22866 22867 22868 22869 22870 22871 22872 22873 22874 22875 22876 22877 22878 22879 22880 22881 22882 22883 22884 22885 22886 22887 22888 22889 22890 22891 22892 22893 22894 22895 22896 22897 22898 22899 22900 22901 22902 22903 22904 22905 22906 22907 22908 22909 22910 22911 22912 22913 22914 22915 22916 22917 22918 22919 22920 22921 22922 22923 22924 22925 22926 22927 22928 22929 22930 22931 22932 22933 22934 22935 22936 22937 22938 22939 22940 22941 22942 22943 22944 22945 22946 22947 22948 22949 22950 22951 22952 22953 22954 22955 22956 22957 22958 22959 22960 22961 22962 22963 22964 22965 22966 22967 22968 22969 22970 22971 22972 22973 22974 22975 22976 22977 22978 22979 22980 22981 22982 22983 22984 22985 22986 22987 22988 22989 22990 22991 22992 22993 22994 22995 22996 22997 22998 22999 23000 23001 23002 23003 23004 23005 23006 23007 23008 23009 23010 23011 23012 23013 23014 23015 23016 23017 23018 23019 23020 23021 23022 23023 23024 23025 23026 23027 23028 23029 23030 23031 23032 23033 23034 23035 23036 23037 23038 23039 23040 23041 23042 23043 23044 23045 23046 23047 23048 23049 23050 23051 23052 23053 23054 23055 23056 23057 23058 23059 23060 23061 23062 23063 23064 23065 23066 23067 23068 23069 23070 23071 23072 23073 23074 23075 23076 23077 23078 23079 23080 23081 23082 23083 23084 23085 23086 23087 23088 23089 23090 23091 23092 23093 23094 23095 23096 23097 23098 23099 23100 23101 23102 23103 23104 23105 23106 23107 23108 23109 23110 23111 23112 23113 23114 23115 23116 23117 23118 23119 23120 23121 23122 23123 23124 23125 23126 23127 23128 23129 23130 23131 23132 23133 23134 23135 23136 23137 23138 23139 23140 23141 23142 23143 23144 23145 23146 23147 23148 23149 23150 23151 23152 23153 23154 23155 23156 23157 23158 23159 23160 23161 23162 23163 23164 23165 23166 23167 23168 23169 23170 23171 23172 23173 23174 23175 23176 23177 23178 23179 23180 23181 23182 23183 23184 23185 23186 23187 23188 23189 23190 23191 23192 23193 23194 23195 23196 23197 23198 23199 23200 23201 23202 23203 23204 23205 23206 23207 23208 23209 23210 23211 23212 23213 23214 23215 23216 23217 23218 23219 23220 23221 23222 23223 23224 23225 23226 23227 23228 23229 23230 23231 23232 23233 23234 23235 23236 23237 23238 23239 23240 23241 23242 23243 23244 23245 23246 23247 23248 23249 23250 23251 23252 23253 23254 23255 23256 23257 23258 23259 23260 23261 23262 23263 23264 23265 23266 23267 23268 23269 23270 23271 23272 23273 23274 23275 23276 23277 23278 23279 23280 23281 23282 23283 23284 23285 23286 23287 23288 23289 23290 23291 23292 23293 23294 23295 23296 23297 23298 23299 23300 23301 23302 23303 23304 23305 23306 23307 23308 23309 23310 23311 23312 23313 23314 23315 23316 23317 23318 23319 23320 23321 23322 23323 23324 23325 23326 23327 23328 23329 23330 23331 23332 23333 23334 23335 23336 23337 23338 23339 23340 23341 23342 23343 23344 23345 23346 23347 23348 23349 23350 23351 23352 23353 23354 23355 23356 23357 23358 23359 23360 23361 23362 23363 23364 23365 23366 23367 23368 23369 23370 23371 23372 23373 23374 23375 23376 23377 23378 23379 23380 23381 23382 23383 23384 23385 23386 23387 23388 23389 23390 23391 23392 23393 23394 23395 23396 23397 23398 23399 23400 23401 23402 23403 23404 23405 23406 23407 23408 23409 23410 23411 23412 23413 23414 23415 23416 23417 23418 23419 23420 23421 23422 23423 23424 23425 23426 23427 23428 23429 23430 23431 23432 23433 23434 23435 23436 23437 23438 23439 23440 23441 23442 23443 23444 23445 23446 23447 23448 23449 23450 23451 23452 23453 23454 23455 23456 23457 23458 23459 23460 23461 23462 23463 23464 23465 23466 23467 23468 23469 23470 23471 23472 23473 23474 23475 23476 23477 23478 23479 23480 23481 23482 23483 23484 23485 23486 23487 23488 23489 23490 23491 23492 23493 23494 23495 23496 23497 23498 23499 23500 23501 23502 23503 23504 23505 23506 23507 23508 23509 23510 23511 23512 23513 23514 23515 23516 23517 23518 23519 23520 23521 23522 23523 23524 23525 23526 23527 23528 23529 23530 23531 23532 23533 23534 23535 23536 23537 23538 23539 23540 23541 23542 23543 23544 23545 23546 23547 23548 23549 23550 23551 23552 23553 23554 23555 23556 23557 23558 23559 23560 23561 23562 23563 23564 23565 23566 23567 23568 23569 23570 23571 23572 23573 23574 23575 23576 23577 23578 23579 23580 23581 23582 23583 23584 23585 23586 23587 23588 23589 23590 23591 23592 23593 23594 23595 23596 23597 23598 23599 23600 23601 23602 23603 23604 23605 23606 23607 23608 23609 23610 23611 23612 23613 23614 23615 23616 23617 23618 23619 23620 23621 23622 23623 23624 23625 23626 23627 23628 23629 23630 23631 23632 23633 23634 23635 23636 23637 23638 23639 23640 23641 23642 23643 23644 23645 23646 23647 23648 23649 23650 23651 23652 23653 23654 23655 23656 23657 23658 23659 23660 23661 23662 23663 23664 23665 23666 23667 23668 23669 23670 23671 23672 23673 23674 23675 23676 23677 23678 23679 23680 23681 23682 23683 23684 23685 23686 23687 23688 23689 23690 23691 23692 23693 23694 23695 23696 23697 23698 23699 23700 23701 23702 23703 23704 23705 23706 23707 23708 23709 23710 23711 23712 23713 23714 23715 23716 23717 23718 23719 23720 23721 23722 23723 23724 23725 23726 23727 23728 23729 23730 23731 23732 23733 23734 23735 23736 23737 23738 23739 23740 23741 23742 23743 23744 23745 23746 23747 23748 23749 23750 23751 23752 23753 23754 23755 23756 23757 23758 23759 23760 23761 23762 23763 23764 23765 23766 23767 23768 23769 23770 23771 23772 23773 23774 23775 23776 23777 23778 23779 23780 23781 23782 23783 23784 23785 23786 23787 23788 23789 23790 23791 23792 23793 23794 23795 23796 23797 23798 23799 23800 23801 23802 23803 23804 23805 23806 23807 23808 23809 23810 23811 23812 23813 23814 23815 23816 23817 23818 23819 23820 23821 23822 23823 23824 23825 23826 23827 23828 23829 23830 23831 23832 23833 23834 23835 23836 23837 23838 23839 23840 23841 23842 23843 23844 23845 23846 23847 23848 23849 23850 23851 23852 23853 23854 23855 23856 23857 23858 23859 23860 23861 23862 23863 23864 23865 23866 23867 23868 23869 23870 23871 23872 23873 23874 23875 23876 23877 23878 23879 23880 23881 23882 23883 23884 23885 23886 23887 23888 23889 23890 23891 23892 23893 23894 23895 23896 23897 23898 23899 23900 23901 23902 23903 23904 23905 23906 23907 23908 23909 23910 23911 23912 23913 23914 23915 23916 23917 23918 23919 23920 23921 23922 23923 23924 23925 23926 23927 23928 23929 23930 23931 23932 23933 23934 23935 23936 23937 23938 23939 23940 23941 23942 23943 23944 23945 23946 23947 23948 23949 23950 23951 23952 23953 23954 23955 23956 23957 23958 23959 23960 23961 23962 23963 23964 23965 23966 23967 23968 23969 23970 23971 23972 23973 23974 23975 23976 23977 23978 23979 23980 23981 23982 23983 23984 23985 23986 23987 23988 23989 23990 23991 23992 23993 23994 23995 23996 23997 23998 23999 24000 24001 24002 24003 24004 24005 24006 24007 24008 24009 24010 24011 24012 24013 24014 24015 24016 24017 24018 24019 24020 24021 24022 24023 24024 24025 24026 24027 24028 24029 24030 24031 24032 24033 24034 24035 24036 24037 24038 24039 24040 24041 24042 24043 24044 24045 24046 24047 24048 24049 24050 24051 24052 24053 24054 24055 24056 24057 24058 24059 24060 24061 24062 24063 24064 24065 24066 24067 24068 24069 24070 24071 24072 24073 24074 24075 24076 24077 24078 24079 24080 24081 24082 24083 24084 24085 24086 24087 24088 24089 24090 24091 24092 24093 24094 24095 24096 24097 24098 24099 24100 24101 24102 24103 24104 24105 24106 24107 24108 24109 24110 24111 24112 24113 24114 24115 24116 24117 24118 24119 24120 24121 24122 24123 24124 24125 24126 24127 24128 24129 24130 24131 24132 24133 24134 24135 24136 24137 24138 24139 24140 24141 24142 24143 24144 24145 24146 24147 24148 24149 24150 24151 24152 24153 24154 24155 24156 24157 24158 24159 24160 24161 24162 24163 24164 24165 24166 24167 24168 24169 24170 24171 24172 24173 24174 24175 24176 24177 24178 24179 24180 24181 24182 24183 24184 24185 24186 24187 24188 24189 24190 24191 24192 24193 24194 24195 24196 24197 24198 24199 24200 24201 24202 24203 24204 24205 24206 24207 24208 24209 24210 24211 24212 24213 24214 24215 24216 24217 24218 24219 24220 24221 24222 24223 24224 24225 24226 24227 24228 24229 24230 24231 24232 24233 24234 24235 24236 24237 24238 24239 24240 24241 24242 24243 24244 24245 24246 24247 24248 24249 24250 24251 24252 24253 24254 24255 24256 24257 24258 24259 24260 24261 24262 24263 24264 24265 24266 24267 24268 24269 24270 24271 24272 24273 24274 24275 24276 24277 24278 24279 24280 24281 24282 24283 24284 24285 24286 24287 24288 24289 24290 24291 24292 24293 24294 24295 24296 24297 24298 24299 24300 24301 24302 24303 24304 24305 24306 24307 24308 24309 24310 24311 24312 24313 24314 24315 24316 24317 24318 24319 24320 24321 24322 24323 24324 24325 24326 24327 24328 24329 24330 24331 24332 24333 24334 24335 24336 24337 24338 24339 24340 24341 24342 24343 24344 24345 24346 24347 24348 24349 24350 24351 24352 24353 24354 24355 24356 24357 24358 24359 24360 24361 24362 24363 24364 24365 24366 24367 24368 24369 24370 24371 24372 24373 24374 24375 24376 24377 24378 24379 24380 24381 24382 24383 24384 24385 24386 24387 24388 24389 24390 24391 24392 24393 24394 24395 24396 24397 24398 24399 24400 24401 24402 24403 24404 24405 24406 24407 24408 24409 24410 24411 24412 24413 24414 24415 24416 24417 24418 24419 24420 24421 24422 24423 24424 24425 24426 24427 24428 24429 24430 24431 24432 24433 24434 24435 24436 24437 24438 24439 24440 24441 24442 24443 24444 24445 24446 24447 24448 24449 24450 24451 24452 24453 24454 24455 24456 24457 24458 24459 24460 24461 24462 24463 24464 24465 24466 24467 24468 24469 24470 24471 24472 24473 24474 24475 24476 24477 24478 24479 24480 24481 24482 24483 24484 24485 24486 24487 24488 24489 24490 24491 24492 24493 24494 24495 24496 24497 24498 24499 24500 24501 24502 24503 24504 24505 24506 24507 24508 24509 24510 24511 24512 24513 24514 24515 24516 24517 24518 24519 24520 24521 24522 24523 24524 24525 24526 24527 24528 24529 24530 24531 24532 24533 24534 24535 24536 24537 24538 24539 24540 24541 24542 24543 24544 24545 24546 24547 24548 24549 24550 24551 24552 24553 24554 24555 24556 24557 24558 24559 24560 24561 24562 24563 24564 24565 24566 24567 24568 24569 24570 24571 24572 24573 24574 24575 24576 24577 24578 24579 24580 24581 24582 24583 24584 24585 24586 24587 24588 24589 24590 24591 24592 24593 24594 24595 24596 24597 24598 24599 24600 24601 24602 24603 24604 24605 24606 24607 24608 24609 24610 24611 24612 24613 24614 24615 24616 24617 24618 24619 24620 24621 24622 24623 24624 24625 24626 24627 24628 24629 24630 24631 24632 24633 24634 24635 24636 24637 24638 24639 24640 24641 24642 24643 24644 24645 24646 24647 24648 24649 24650 24651 24652 24653 24654 24655 24656 24657 24658 24659 24660 24661 24662 24663 24664 24665 24666 24667 24668 24669 24670 24671 24672 24673 24674 24675 24676 24677 24678 24679 24680 24681 24682 24683 24684 24685 24686 24687 24688 24689 24690 24691 24692 24693 24694 24695 24696 24697 24698 24699 24700 24701 24702 24703 24704 24705 24706 24707 24708 24709 24710 24711 24712 24713 24714 24715 24716 24717 24718 24719 24720 24721 24722 24723 24724 24725 24726 24727 24728 24729 24730 24731 24732 24733 24734 24735 24736 24737 24738 24739 24740 24741 24742 24743 24744 24745 24746 24747 24748 24749 24750 24751 24752 24753 24754 24755 24756 24757 24758 24759 24760 24761 24762 24763 24764 24765 24766 24767 24768 24769 24770 24771 24772 24773 24774 24775 24776 24777 24778 24779 24780 24781 24782 24783 24784 24785 24786 24787 24788 24789 24790 24791 24792 24793 24794 24795 24796 24797 24798 24799 24800 24801 24802 24803 24804 24805 24806 24807 24808 24809 24810 24811 24812 24813 24814 24815 24816 24817 24818 24819 24820 24821 24822 24823 24824 24825 24826 24827 24828 24829 24830 24831 24832 24833 24834 24835 24836 24837 24838 24839 24840 24841 24842 24843 24844 24845 24846 24847 24848 24849 24850 24851 24852 24853 24854 24855 24856 24857 24858 24859 24860 24861 24862 24863 24864 24865 24866 24867 24868 24869 24870 24871 24872 24873 24874 24875 24876 24877 24878 24879 24880 24881 24882 24883 24884 24885 24886 24887 24888 24889 24890 24891 24892 24893 24894 24895 24896 24897 24898 24899 24900 24901 24902 24903 24904 24905 24906 24907 24908 24909 24910 24911 24912 24913 24914 24915 24916 24917 24918 24919 24920 24921 24922 24923 24924 24925 24926 24927 24928 24929 24930 24931 24932 24933 24934 24935 24936 24937 24938 24939 24940 24941 24942 24943 24944 24945 24946 24947 24948 24949 24950 24951 24952 24953 24954 24955 24956 24957 24958 24959 24960 24961 24962 24963 24964 24965 24966 24967 24968 24969 24970 24971 24972 24973 24974 24975 24976 24977 24978 24979 24980 24981 24982 24983 24984 24985 24986 24987 24988 24989 24990 24991 24992 24993 24994 24995 24996 24997 24998 24999 25000 25001 25002 25003 25004 25005 25006 25007 25008 25009 25010 25011 25012 25013 25014 25015 25016 25017 25018 25019 25020 25021 25022 25023 25024 25025 25026 25027 25028 25029 25030 25031 25032 25033 25034 25035 25036 25037 25038 25039 25040 25041 25042 25043 25044 25045 25046 25047 25048 25049 25050 25051 25052 25053 25054 25055 25056 25057 25058 25059 25060 25061 25062 25063 25064 25065 25066 25067 25068 25069 25070 25071 25072 25073 25074 25075 25076 25077 25078 25079 25080 25081 25082 25083 25084 25085 25086 25087 25088 25089 25090 25091 25092 25093 25094 25095 25096 25097 25098 25099 25100 25101 25102 25103 25104 25105 25106 25107 25108 25109 25110 25111 25112 25113 25114 25115 25116 25117 25118 25119 25120 25121 25122 25123 25124 25125 25126 25127 25128 25129 25130 25131 25132 25133 25134 25135 25136 25137 25138 25139 25140 25141 25142 25143 25144 25145 25146 25147 25148 25149 25150 25151 25152 25153 25154 25155 25156 25157 25158 25159 25160 25161 25162 25163 25164 25165 25166 25167 25168 25169 25170 25171 25172 25173 25174 25175 25176 25177 25178 25179 25180 25181 25182 25183 25184 25185 25186 25187 25188 25189 25190 25191 25192 25193 25194 25195 25196 25197 25198 25199 25200 25201 25202 25203 25204 25205 25206 25207 25208 25209 25210 25211 25212 25213 25214 25215 25216 25217 25218 25219 25220 25221 25222 25223 25224 25225 25226 25227 25228 25229 25230 25231 25232 25233 25234 25235 25236 25237 25238 25239 25240 25241 25242 25243 25244 25245 25246 25247 25248 25249 25250 25251 25252 25253 25254 25255 25256 25257 25258 25259 25260 25261 25262 25263 25264 25265 25266 25267 25268 25269 25270 25271 25272 25273 25274 25275 25276 25277 25278 25279 25280 25281 25282 25283 25284 25285 25286 25287 25288 25289 25290 25291 25292 25293 25294 25295 25296 25297 25298 25299 25300 25301 25302 25303 25304 25305 25306 25307 25308 25309 25310 25311 25312 25313 25314 25315 25316 25317 25318 25319 25320 25321 25322 25323 25324 25325 25326 25327 25328 25329 25330 25331 25332 25333 25334 25335 25336 25337 25338 25339 25340 25341 25342 25343 25344 25345 25346 25347 25348 25349 25350 25351 25352 25353 25354 25355 25356 25357 25358 25359 25360 25361 25362 25363 25364 25365 25366 25367 25368 25369 25370 25371 25372 25373 25374 25375 25376 25377 25378 25379 25380 25381 25382 25383 25384 25385 25386 25387 25388 25389 25390 25391 25392 25393 25394 25395 25396 25397 25398 25399 25400 25401 25402 25403 25404 25405 25406 25407 25408 25409 25410 25411 25412 25413 25414 25415 25416 25417 25418 25419 25420 25421 25422 25423 25424 25425 25426 25427 25428 25429 25430 25431 25432 25433 25434 25435 25436 25437 25438 25439 25440 25441 25442 25443 25444 25445 25446 25447 25448 25449 25450 25451 25452 25453 25454 25455 25456 25457 25458 25459 25460 25461 25462 25463 25464 25465 25466 25467 25468 25469 25470 25471 25472 25473 25474 25475 25476 25477 25478 25479 25480 25481 25482 25483 25484 25485 25486 25487 25488 25489 25490 25491 25492 25493 25494 25495 25496 25497 25498 25499 25500 25501 25502 25503 25504 25505 25506 25507 25508 25509 25510 25511 25512 25513 25514 25515 25516 25517 25518 25519 25520 25521 25522 25523 25524 25525 25526 25527 25528 25529 25530 25531 25532 25533 25534 25535 25536 25537 25538 25539 25540 25541 25542 25543 25544 25545 25546 25547 25548 25549 25550 25551 25552 25553 25554 25555 25556 25557 25558 25559 25560 25561 25562 25563 25564 25565 25566 25567 25568 25569 25570 25571 25572 25573 25574 25575 25576 25577 25578 25579 25580 25581 25582 25583 25584 25585 25586 25587 25588 25589 25590 25591 25592 25593 25594 25595 25596 25597 25598 25599 25600 25601 25602 25603 25604 25605 25606 25607 25608 25609 25610 25611 25612 25613 25614 25615 25616 25617 25618 25619 25620 25621 25622 25623 25624 25625 25626 25627 25628 25629 25630 25631 25632 25633 25634 25635 25636 25637 25638 25639 25640 25641 25642 25643 25644 25645 25646 25647 25648 25649 25650 25651 25652 25653 25654 25655 25656 25657 25658 25659 25660 25661 25662 25663 25664 25665 25666 25667 25668 25669 25670 25671 25672 25673 25674 25675 25676 25677 25678 25679 25680 25681 25682 25683 25684 25685 25686 25687 25688 25689 25690 25691 25692 25693 25694 25695 25696 25697 25698 25699 25700 25701 25702 25703 25704 25705 25706 25707 25708 25709 25710 25711 25712 25713 25714 25715 25716 25717 25718 25719 25720 25721 25722 25723 25724 25725 25726 25727 25728 25729 25730 25731 25732 25733 25734 25735 25736 25737 25738 25739 25740 25741 25742 25743 25744 25745 25746 25747 25748 25749 25750 25751 25752 25753 25754 25755 25756 25757 25758 25759 25760 25761 25762 25763 25764 25765 25766 25767 25768 25769 25770 25771 25772 25773 25774 25775 25776 25777 25778 25779 25780 25781 25782 25783 25784 25785 25786 25787 25788 25789 25790 25791 25792 25793 25794 25795 25796 25797 25798 25799 25800 25801 25802 25803 25804 25805 25806 25807 25808 25809 25810 25811 25812 25813 25814 25815 25816 25817 25818 25819 25820 25821 25822 25823 25824 25825 25826 25827 25828 25829 25830 25831 25832 25833 25834 25835 25836 25837 25838 25839 25840 25841 25842 25843 25844 25845 25846 25847 25848 25849 25850 25851 25852 25853 25854 25855 25856 25857 25858 25859 25860 25861 25862 25863 25864 25865 25866 25867 25868 25869 25870 25871 25872 25873 25874 25875 25876 25877 25878 25879 25880 25881 25882 25883 25884 25885 25886 25887 25888 25889 25890 25891 25892 25893 25894 25895 25896 25897 25898 25899 25900 25901 25902 25903 25904 25905 25906 25907 25908 25909 25910 25911 25912 25913 25914 25915 25916 25917 25918 25919 25920 25921 25922 25923 25924 25925 25926 25927 25928 25929 25930 25931 25932 25933 25934 25935 25936 25937 25938 25939 25940 25941 25942 25943 25944 25945 25946 25947 25948 25949 25950 25951 25952 25953 25954 25955 25956 25957 25958 25959 25960 25961 25962 25963 25964 25965 25966 25967 25968 25969 25970 25971 25972 25973 25974 25975 25976 25977 25978 25979 25980 25981 25982 25983 25984 25985 25986 25987 25988 25989 25990 25991 25992 25993 25994 25995 25996 25997 25998 25999 26000 26001 26002 26003 26004 26005 26006 26007 26008 26009 26010 26011 26012 26013 26014 26015 26016 26017 26018 26019 26020 26021 26022 26023 26024 26025 26026 26027 26028 26029 26030 26031 26032 26033 26034 26035 26036 26037 26038 26039 26040 26041 26042 26043 26044 26045 26046 26047 26048 26049 26050 26051 26052 26053 26054 26055 26056 26057 26058 26059 26060 26061 26062 26063 26064 26065 26066 26067 26068 26069 26070 26071 26072 26073 26074 26075 26076 26077 26078 26079 26080 26081 26082 26083 26084 26085 26086 26087 26088 26089 26090 26091 26092 26093 26094 26095 26096 26097 26098 26099 26100 26101 26102 26103 26104 26105 26106 26107 26108 26109 26110 26111 26112 26113 26114 26115 26116 26117 26118 26119 26120 26121 26122 26123 26124 26125 26126 26127 26128 26129 26130 26131 26132 26133 26134 26135 26136 26137 26138 26139 26140 26141 26142 26143 26144 26145 26146 26147 26148 26149 26150 26151 26152 26153 26154 26155 26156 26157 26158 26159 26160 26161 26162 26163 26164 26165 26166 26167 26168 26169 26170 26171 26172 26173 26174 26175 26176 26177 26178 26179 26180 26181 26182 26183 26184 26185 26186 26187 26188 26189 26190 26191 26192 26193 26194 26195 26196 26197 26198 26199 26200 26201 26202 26203 26204 26205 26206 26207 26208 26209 26210 26211 26212 26213 26214 26215 26216 26217 26218 26219 26220 26221 26222 26223 26224 26225 26226 26227 26228 26229 26230 26231 26232 26233 26234 26235 26236 26237 26238 26239 26240 26241 26242 26243 26244 26245 26246 26247 26248 26249 26250 26251 26252 26253 26254 26255 26256 26257 26258 26259 26260 26261 26262 26263 26264 26265 26266 26267 26268 26269 26270 26271 26272 26273 26274 26275 26276 26277 26278 26279 26280 26281 26282 26283 26284 26285 26286 26287 26288 26289 26290 26291 26292 26293 26294 26295 26296 26297 26298 26299 26300 26301 26302 26303 26304 26305 26306 26307 26308 26309 26310 26311 26312 26313 26314 26315 26316 26317 26318 26319 26320 26321 26322 26323 26324 26325 26326 26327 26328 26329 26330 26331 26332 26333 26334 26335 26336 26337 26338 26339 26340 26341 26342 26343 26344 26345 26346 26347 26348 26349 26350 26351 26352 26353 26354 26355 26356 26357 26358 26359 26360 26361 26362 26363 26364 26365 26366 26367 26368 26369 26370 26371 26372 26373 26374 26375 26376 26377 26378 26379 26380 26381 26382 26383 26384 26385 26386 26387 26388 26389 26390 26391 26392 26393 26394 26395 26396 26397 26398 26399 26400 26401 26402 26403 26404 26405 26406 26407 26408 26409 26410 26411 26412 26413 26414 26415 26416 26417 26418 26419 26420 26421 26422 26423 26424 26425 26426 26427 26428 26429 26430 26431 26432 26433 26434 26435 26436 26437 26438 26439 26440 26441 26442 26443 26444 26445 26446 26447 26448 26449 26450 26451 26452 26453 26454 26455 26456 26457 26458 26459 26460 26461 26462 26463 26464 26465 26466 26467 26468 26469 26470 26471 26472 26473 26474 26475 26476 26477 26478 26479 26480 26481 26482 26483 26484 26485 26486 26487 26488 26489 26490 26491 26492 26493 26494 26495 26496 26497 26498 26499 26500 26501 26502 26503 26504 26505 26506 26507 26508 26509 26510 26511 26512 26513 26514 26515 26516 26517 26518 26519 26520 26521 26522 26523 26524 26525 26526 26527 26528 26529 26530 26531 26532 26533 26534 26535 26536 26537 26538 26539 26540 26541 26542 26543 26544 26545 26546 26547 26548 26549 26550 26551 26552 26553 26554 26555 26556 26557 26558 26559 26560 26561 26562 26563 26564 26565 26566 26567 26568 26569 26570 26571 26572 26573 26574 26575 26576 26577 26578 26579 26580 26581 26582 26583 26584 26585 26586 26587 26588 26589 26590 26591 26592 26593 26594 26595 26596 26597 26598 26599 26600 26601 26602 26603 26604 26605 26606 26607 26608 26609 26610 26611 26612 26613 26614 26615 26616 26617 26618 26619 26620 26621 26622 26623 26624 26625 26626 26627 26628 26629 26630 26631 26632 26633 26634 26635 26636 26637 26638 26639 26640 26641 26642 26643 26644 26645 26646 26647 26648 26649 26650 26651 26652 26653 26654 26655 26656 26657 26658 26659 26660 26661 26662 26663 26664 26665 26666 26667 26668 26669 26670 26671 26672 26673 26674 26675 26676 26677 26678 26679 26680 26681 26682 26683 26684 26685 26686 26687 26688 26689 26690 26691 26692 26693 26694 26695 26696 26697 26698 26699 26700 26701 26702 26703 26704 26705 26706 26707 26708 26709 26710 26711 26712 26713 26714 26715 26716 26717 26718 26719 26720 26721 26722 26723 26724 26725 26726 26727 26728 26729 26730 26731 26732 26733 26734 26735 26736 26737 26738 26739 26740 26741 26742 26743 26744 26745 26746 26747 26748 26749 26750 26751 26752 26753 26754 26755 26756 26757 26758 26759 26760 26761 26762 26763 26764 26765 26766 26767 26768 26769 26770 26771 26772 26773 26774 26775 26776 26777 26778 26779 26780 26781 26782 26783 26784 26785 26786 26787 26788 26789 26790 26791 26792 26793 26794 26795 26796 26797 26798 26799 26800 26801 26802 26803 26804 26805 26806 26807 26808 26809 26810 26811 26812 26813 26814 26815 26816 26817 26818 26819 26820 26821 26822 26823 26824 26825 26826 26827 26828 26829 26830 26831 26832 26833 26834 26835 26836 26837 26838 26839 26840 26841 26842 26843 26844 26845 26846 26847 26848 26849 26850 26851 26852 26853 26854 26855 26856 26857 26858 26859 26860 26861 26862 26863 26864 26865 26866 26867 26868 26869 26870 26871 26872 26873 26874 26875 26876 26877 26878 26879 26880 26881 26882 26883 26884 26885 26886 26887 26888 26889 26890 26891 26892 26893 26894 26895 26896 26897 26898 26899 26900 26901 26902 26903 26904 26905 26906 26907 26908 26909 26910 26911 26912 26913 26914 26915 26916 26917 26918 26919 26920 26921 26922 26923 26924 26925 26926 26927 26928 26929 26930 26931 26932 26933 26934 26935 26936 26937 26938 26939 26940 26941 26942 26943 26944 26945 26946 26947 26948 26949 26950 26951 26952 26953 26954 26955 26956 26957 26958 26959 26960 26961 26962 26963 26964 26965 26966 26967 26968 26969 26970 26971 26972 26973 26974 26975 26976 26977 26978 26979 26980 26981 26982 26983 26984 26985 26986 26987 26988 26989 26990 26991 26992 26993 26994 26995 26996 26997 26998 26999 27000 27001 27002 27003 27004 27005 27006 27007 27008 27009 27010 27011 27012 27013 27014 27015 27016 27017 27018 27019 27020 27021 27022 27023 27024 27025 27026 27027 27028 27029 27030 27031 27032 27033 27034 27035 27036 27037 27038 27039 27040 27041 27042 27043 27044 27045 27046 27047 27048 27049 27050 27051 27052 27053 27054 27055 27056 27057 27058 27059 27060 27061 27062 27063 27064 27065 27066 27067 27068 27069 27070 27071 27072 27073 27074 27075 27076 27077 27078 27079 27080 27081 27082 27083 27084 27085 27086 27087 27088 27089 27090 27091 27092 27093 27094 27095 27096 27097 27098 27099 27100 27101 27102 27103 27104 27105 27106 27107 27108 27109 27110 27111 27112 27113 27114 27115 27116 27117 27118 27119 27120 27121 27122 27123 27124 27125 27126 27127 27128 27129 27130 27131 27132 27133 27134 27135 27136 27137 27138 27139 27140 27141 27142 27143 27144 27145 27146 27147 27148 27149 27150 27151 27152 27153 27154 27155 27156 27157 27158 27159 27160 27161 27162 27163 27164 27165 27166 27167 27168 27169 27170 27171 27172 27173 27174 27175 27176 27177 27178 27179 27180 27181 27182 27183 27184 27185 27186 27187 27188 27189 27190 27191 27192 27193 27194 27195 27196 27197 27198 27199 27200 27201 27202 27203 27204 27205 27206 27207 27208 27209 27210 27211 27212 27213 27214 27215 27216 27217 27218 27219 27220 27221 27222 27223 27224 27225 27226 27227 27228 27229 27230 27231 27232 27233 27234 27235 27236 27237 27238 27239 27240 27241 27242 27243 27244 27245 27246 27247 27248 27249 27250 27251 27252 27253 27254 27255 27256 27257 27258 27259 27260 27261 27262 27263 27264 27265 27266 27267 27268 27269 27270 27271 27272 27273 27274 27275 27276 27277 27278 27279 27280 27281 27282 27283 27284 27285 27286 27287 27288 27289 27290 27291 27292 27293 27294 27295 27296 27297 27298 27299 27300 27301 27302 27303 27304 27305 27306 27307 27308 27309 27310 27311 27312 27313 27314 27315 27316 27317 27318 27319 27320 27321 27322 27323 27324 27325 27326 27327 27328 27329 27330 27331 27332 27333 27334 27335 27336 27337 27338 27339 27340 27341 27342 27343 27344 27345 27346 27347 27348 27349 27350 27351 27352 27353 27354 27355 27356 27357 27358 27359 27360 27361 27362 27363 27364 27365 27366 27367 27368 27369 27370 27371 27372 27373 27374 27375 27376 27377 27378 27379 27380 27381 27382 27383 27384 27385 27386 27387 27388 27389 27390 27391 27392 27393 27394 27395 27396 27397 27398 27399 27400 27401 27402 27403 27404 27405 27406 27407 27408 27409 27410 27411 27412 27413 27414 27415 27416 27417 27418 27419 27420 27421 27422 27423 27424 27425 27426 27427 27428 27429 27430 27431 27432 27433 27434 27435 27436 27437 27438 27439 27440 27441 27442 27443 27444 27445 27446 27447 27448 27449 27450 27451 27452 27453 27454 27455 27456 27457 27458 27459 27460 27461 27462 27463 27464 27465 27466 27467 27468 27469 27470 27471 27472 27473 27474 27475 27476 27477 27478 27479 27480 27481 27482 27483 27484 27485 27486 27487 27488 27489 27490 27491 27492 27493 27494 27495 27496 27497 27498 27499 27500 27501 27502 27503 27504 27505 27506 27507 27508 27509 27510 27511 27512 27513 27514 27515 27516 27517 27518 27519 27520 27521 27522 27523 27524 27525 27526 27527 27528 27529 27530 27531 27532 27533 27534 27535 27536 27537 27538 27539 27540 27541 27542 27543 27544 27545 27546 27547 27548 27549 27550 27551 27552 27553 27554 27555 27556 27557 27558 27559 27560 27561 27562 27563 27564 27565 27566 27567 27568 27569 27570 27571 27572 27573 27574 27575 27576 27577 27578 27579 27580 27581 27582 27583 27584 27585 27586 27587 27588 27589 27590 27591 27592 27593 27594 27595 27596 27597 27598 27599 27600 27601 27602 27603 27604 27605 27606 27607 27608 27609 27610 27611 27612 27613 27614 27615 27616 27617 27618 27619 27620 27621 27622 27623 27624 27625 27626 27627 27628 27629 27630 27631 27632 27633 27634 27635 27636 27637 27638 27639 27640 27641 27642 27643 27644 27645 27646 27647 27648 27649 27650 27651 27652 27653 27654 27655 27656 27657 27658 27659 27660 27661 27662 27663 27664 27665 27666 27667 27668 27669 27670 27671 27672 27673 27674 27675 27676 27677 27678 27679 27680 27681 27682 27683 27684 27685 27686 27687 27688 27689 27690 27691 27692 27693 27694 27695 27696 27697 27698 27699 27700 27701 27702 27703 27704 27705 27706 27707 27708 27709 27710 27711 27712 27713 27714 27715 27716 27717 27718 27719 27720 27721 27722 27723 27724 27725 27726 27727 27728 27729 27730 27731 27732 27733 27734 27735 27736 27737 27738 27739 27740 27741 27742 27743 27744 27745 27746 27747 27748 27749 27750 27751 27752 27753 27754 27755 27756 27757 27758 27759 27760 27761 27762 27763 27764 27765 27766 27767 27768 27769 27770 27771 27772 27773 27774 27775 27776 27777 27778 27779 27780 27781 27782 27783 27784 27785 27786 27787 27788 27789 27790 27791 27792 27793 27794 27795 27796 27797 27798 27799 27800 27801 27802 27803 27804 27805 27806 27807 27808 27809 27810 27811 27812 27813 27814 27815 27816 27817 27818 27819 27820 27821 27822 27823 27824 27825 27826 27827 27828 27829 27830 27831 27832 27833 27834 27835 27836 27837 27838 27839 27840 27841 27842 27843 27844 27845 27846 27847 27848 27849 27850 27851 27852 27853 27854 27855 27856 27857 27858 27859 27860 27861 27862 27863 27864 27865 27866 27867 27868 27869 27870 27871 27872 27873 27874 27875 27876 27877 27878 27879 27880 27881 27882 27883 27884 27885 27886 27887 27888 27889 27890 27891 27892 27893 27894 27895 27896 27897 27898 27899 27900 27901 27902 27903 27904 27905 27906 27907 27908 27909 27910 27911 27912 27913 27914 27915 27916 27917 27918 27919 27920 27921 27922 27923 27924 27925 27926 27927 27928 27929 27930 27931 27932 27933 27934 27935 27936 27937 27938 27939 27940 27941 27942 27943 27944 27945 27946 27947 27948 27949 27950 27951 27952 27953 27954 27955 27956 27957 27958 27959 27960 27961 27962 27963 27964 27965 27966 27967 27968 27969 27970 27971 27972 27973 27974 27975 27976 27977 27978 27979 27980 27981 27982 27983 27984 27985 27986 27987 27988 27989 27990 27991 27992 27993 27994 27995 27996 27997 27998 27999 28000 28001 28002 28003 28004 28005 28006 28007 28008 28009 28010 28011 28012 28013 28014 28015 28016 28017 28018 28019 28020 28021 28022 28023 28024 28025 28026 28027 28028 28029 28030 28031 28032 28033 28034 28035 28036 28037 28038 28039 28040 28041 28042 28043 28044 28045 28046 28047 28048 28049 28050 28051 28052 28053 28054 28055 28056 28057 28058 28059 28060 28061 28062 28063 28064 28065 28066 28067 28068 28069 28070 28071 28072 28073 28074 28075 28076 28077 28078 28079 28080 28081 28082 28083 28084 28085 28086 28087 28088 28089 28090 28091 28092 28093 28094 28095 28096 28097 28098 28099 28100 28101 28102 28103 28104 28105 28106 28107 28108 28109 28110 28111 28112 28113 28114 28115 28116 28117 28118 28119 28120 28121 28122 28123 28124 28125 28126 28127 28128 28129 28130 28131 28132 28133 28134 28135 28136 28137 28138 28139 28140 28141 28142 28143 28144 28145 28146 28147 28148 28149 28150 28151 28152 28153 28154 28155 28156 28157 28158 28159 28160 28161 28162 28163 28164 28165 28166 28167 28168 28169 28170 28171 28172 28173 28174 28175 28176 28177 28178 28179 28180 28181 28182 28183 28184 28185 28186 28187 28188 28189 28190 28191 28192 28193 28194 28195 28196 28197 28198 28199 28200 28201 28202 28203 28204 28205 28206 28207 28208 28209 28210 28211
|
2010-05-24 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Sam Weinig.
Accidentally committed double write of codeblock in Interpreter.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2010-05-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=39583
Move creation of 'this' object from caller to callee in construction.
Presently the caller of a constructor is responsible for providing a this
object. Instead, move the object creation into a new op_create_this opcode,
planted in the head of the contructor bytecode for a function. Since the
prototype for the object is provided by performing a get_by_id on the callee,
also add a new get_callee opcode (this is used to get the callee JSFunction
into a register so that a normal get_by_id can be used).
Currently the caller is also responsible for detecting when op_construct is
performed on a JSFunction representing a host function, in which case an
exception is thrown – and this check currently takes place when constructing
the this object. Instead, mirroring the recent changes for non-host functions,
add a parallel code-path for native constructors to follow, with a thunk for
invoking native constructors provided by JITStubs, and a constructor-specific
NativeFunction on NativeExecutable. Provide an implementation of a host
constructor which will throw an exception.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
* bytecode/CodeBlock.h:
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitGetByIdExceptionInfo):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emit_op_create_this):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emit_op_create_this):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
(JSC::JITThunks::ctiNativeConstruct):
(JSC::):
* runtime/ExceptionHelpers.cpp:
(JSC::createNotAnObjectError):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
* runtime/JSFunction.cpp:
(JSC::callHostFunctionAsConstructor):
* runtime/JSFunction.h:
2010-05-23 Sam Weinig <sam@webkit.org>
Fix windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-23 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=39575
Make JS DOMObject inherit from JSObjectWithGlobalObject instead of JSObject
Expose the global object stored in JSObjectWithGlobalObject.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSObjectWithGlobalObject.cpp:
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
(JSC::JSObjectWithGlobalObject::globalObject):
* runtime/JSObjectWithGlobalObject.h:
2010-05-21 Oliver Hunt <oliver@apple.com>
"asm volatile" isn't valid outside of functions.
Reviewed by Gavin Barraclough.
* jit/JITStubs.cpp:
2010-05-21 Gavin Barraclough <barraclough@apple.com>
Unreviewed build fix.
Interpreter fix following r59974.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::get):
* runtime/JSPropertyNameIterator.h:
2010-05-21 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Oliver Hunt.
Interpreter fix following r59939.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2010-05-21 David Levin <levin@chromium.org>
Unreviewed build fix.
* wtf/SizeLimits.cpp: Removed a check while I figure out how to write it properly.
2010-05-21 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Enforce size constraints on various data structures in JavaScriptCore/wtf.
https://bugs.webkit.org/show_bug.cgi?id=39327
I only modified the default build for OSX and Chromium's build file to include WTFCompileAsserts.cpp
as those should be sufficient to catch regressions on the size of the data structures.
* JavaScriptCore.gypi: Added the WTFCompileAsserts.cpp file.
* JavaScriptCore.xcodeproj/project.pbxproj: Added the WTFCompileAsserts.cpp file.
* runtime/UString.cpp: Added a compile assert for UString size.
* wtf/SizeLimits.cpp: Added compile asserts for data structures that didn't have cpp files.
* wtf/text/StringImpl.cpp: Added a compile assert for StringImpl size.
2010-05-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 39509 - Exceptions raised when JSString::value() is called not always properly thrown.
Missing some CHECK_FOR_EXCEPTION()s, cleanup NativeError construction (adding a property
via the prototype was inefficient, and whilst trivially true that the property is is not
a rope - and thus couldn't except - it would be hard to prove this).
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::name):
(JSC::InternalFunction::displayName):
* runtime/JSFunction.cpp:
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSPropertyNameIterator.cpp:
* runtime/JSPropertyNameIterator.h:
* runtime/JSString.h:
(JSC::RopeBuilder::tryGetValue):
(JSC::JSString::getIndex):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
* runtime/NativeErrorPrototype.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
2010-05-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Fix interpreter build.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2010-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Split out JITCall32_64.cpp, and tightened up some #ifdefs in the hopes
of improving compile times.
https://bugs.webkit.org/show_bug.cgi?id=39507
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JIT.cpp:
* jit/JITArithmetic.cpp:
* jit/JITArithmetic32_64.cpp:
* jit/JITCall.cpp:
* jit/JITCall32_64.cpp: Copied from jit/JITCall.cpp.
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
* jit/JITStubs.cpp:
2010-05-21 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix for Qt after r59941.
* JavaScriptCore.pro: missing runtime/JSObjectWithGlobalObject.cpp added to SOURCES.
2010-05-21 Oliver Hunt <oliver@apple.com>
Windows build fix #3
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-21 Oliver Hunt <oliver@apple.com>
Windows build fix #2
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-21 Oliver Hunt <oliver@apple.com>
Windows build fix #1
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
All callable objects should have a global object reference
https://bugs.webkit.org/show_bug.cgi?id=39495
All objects that may ever return a value other CallTypeNone
or ConstructTypeNone now get a global object in their constructor
and store that in their first anonymous slot. We add a new type
JSObjectWithGlobalObject to allow us to share this logic as much
as possible, however some objects have specific inheritance
requirements so we can't just use it universally.
To enforce this requirement JSValue::getCallData and getConstructData
make use of a new "isValidCallee" function to assert that any object
that returns a value other than CallType/ConstructTypeNone has a
global object in anonymous slot 0.
In order to ensure that static function slots are converted into
function objects with the correct global object, all prototype objects
and other classes with static function slots also gain a global object
reference. Happily this fixes the long standing issue where host
function objects get a prototype from the lexical global object of the
first function that calls them, instead of the global object that they
are defined on.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
* API/JSCallbackConstructor.h:
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::JSCallbackFunction):
* API/JSCallbackFunction.h:
* API/JSCallbackObject.cpp:
(JSC::):
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
(JSC::::staticFunctionGetter):
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
* API/JSContextRef.cpp:
* API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
* API/JSValueRef.cpp:
(JSValueIsObjectOfClass):
* API/JSWeakObjectMapRefPrivate.cpp:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jsc.cpp:
(GlobalObject::GlobalObject):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::createStructure):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
* runtime/BooleanConstructor.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
* runtime/ErrorConstructor.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
(JSC::FunctionPrototype::addFunctionProperties):
* runtime/FunctionPrototype.h:
* runtime/GlobalEvalFunction.cpp:
(JSC::GlobalEvalFunction::GlobalEvalFunction):
* runtime/GlobalEvalFunction.h:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
* runtime/JSCell.h:
(JSC::JSValue::getCallData):
(JSC::JSValue::getConstructData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
* runtime/JSONObject.h:
* runtime/JSObject.h:
* runtime/JSObjectWithGlobalObject.cpp: Added.
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
* runtime/JSObjectWithGlobalObject.h: Added.
(JSC::JSObjectWithGlobalObject::createStructure):
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
* runtime/JSValue.cpp:
(JSC::JSValue::isValidCallee):
* runtime/JSValue.h:
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
* runtime/MathObject.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
* runtime/PrototypeFunction.cpp:
(JSC::PrototypeFunction::PrototypeFunction):
* runtime/PrototypeFunction.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::constructRegExp):
* runtime/RegExpConstructor.h:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
2010-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed the unused entry in the CallFrame
https://bugs.webkit.org/show_bug.cgi?id=39470
Removed the unused entry in the CallFrame, and reordered CallFrame
writes on the hot path to be in forwards order.
SunSpider says 0.3% faster.
* interpreter/RegisterFile.h:
(JSC::RegisterFile::):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
2010-05-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Split the QScriptValue autotest into smaller chunks.
File tst_qscriptvalue_generated.cpp was huge and it was difficult to compile
it with MSVS2008, because of the code optimization.
Tests were splited into a few files for better use of distributed
compilation.
Repeated calls to insert() and operator<<() where replaced by loops,
that should reduce time of code optimizing.
New files were generated by the same application, test logic wasn't changed.
[Qt] The QScriptValue autotest should be refactored.
https://bugs.webkit.org/show_bug.cgi?id=38987
* qt/tests/qscriptvalue/qscriptvalue.pro:
* qt/tests/qscriptvalue/tst_qscriptvalue.h:
* qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: Added.
(tst_QScriptValue::initScriptValues):
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: Added.
(tst_QScriptValue::isValid_initData):
(tst_QScriptValue::isValid_makeData):
(tst_QScriptValue::isValid_test):
(tst_QScriptValue::isBool_initData):
(tst_QScriptValue::isBool_makeData):
(tst_QScriptValue::isBool_test):
(tst_QScriptValue::isBoolean_initData):
(tst_QScriptValue::isBoolean_makeData):
(tst_QScriptValue::isBoolean_test):
(tst_QScriptValue::isNumber_initData):
(tst_QScriptValue::isNumber_makeData):
(tst_QScriptValue::isNumber_test):
(tst_QScriptValue::isFunction_initData):
(tst_QScriptValue::isFunction_makeData):
(tst_QScriptValue::isFunction_test):
(tst_QScriptValue::isNull_initData):
(tst_QScriptValue::isNull_makeData):
(tst_QScriptValue::isNull_test):
(tst_QScriptValue::isString_initData):
(tst_QScriptValue::isString_makeData):
(tst_QScriptValue::isString_test):
(tst_QScriptValue::isUndefined_initData):
(tst_QScriptValue::isUndefined_makeData):
(tst_QScriptValue::isUndefined_test):
(tst_QScriptValue::isObject_initData):
(tst_QScriptValue::isObject_makeData):
(tst_QScriptValue::isObject_test):
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: Added.
(tst_QScriptValue::toString_initData):
(tst_QScriptValue::toString_makeData):
(tst_QScriptValue::toString_test):
(tst_QScriptValue::toNumber_initData):
(tst_QScriptValue::toNumber_makeData):
(tst_QScriptValue::toNumber_test):
(tst_QScriptValue::toBool_initData):
(tst_QScriptValue::toBool_makeData):
(tst_QScriptValue::toBool_test):
(tst_QScriptValue::toBoolean_initData):
(tst_QScriptValue::toBoolean_makeData):
(tst_QScriptValue::toBoolean_test):
(tst_QScriptValue::toInteger_initData):
(tst_QScriptValue::toInteger_makeData):
(tst_QScriptValue::toInteger_test):
(tst_QScriptValue::toInt32_initData):
(tst_QScriptValue::toInt32_makeData):
(tst_QScriptValue::toInt32_test):
(tst_QScriptValue::toUInt32_initData):
(tst_QScriptValue::toUInt32_makeData):
(tst_QScriptValue::toUInt32_test):
(tst_QScriptValue::toUInt16_initData):
(tst_QScriptValue::toUInt16_makeData):
(tst_QScriptValue::toUInt16_test):
2010-05-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Add COMPILER(MSVC) guard for strnstr
https://bugs.webkit.org/show_bug.cgi?id=39397
BREWMP uses MSVC for simulator build, but it is not OS(WINDOWS).
Add COMPILER(MSVC) guard for strnstr.
* wtf/StringExtras.h:
2010-05-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add !PLATFORM(BREWMP) guard for isMainThread
https://bugs.webkit.org/show_bug.cgi?id=39396
BREWMP sets ENABLE(SINGLE_THREADED), so it uses isMainThread from ThreadingNone.cpp.
Exclude isMainThread in MainThread.cpp.
* wtf/MainThread.cpp:
2010-05-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Use skia as BREW MP's graphics backend.
https://bugs.webkit.org/show_bug.cgi?id=39407
Define WTF_PLATFORM_SKIA=1 for BREW MP.
* wtf/Platform.h:
2010-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Beth Dakin.
Fixed naming mixup: it's op_call_put_result, not ret_result.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2010-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Whittling away at CodeBlock use: Removed a little wonkiness in closure lookup
https://bugs.webkit.org/show_bug.cgi?id=39444
Calculate all lookup depths at compile time. I'm not sure why we couldn't
do this before, but whatever the reason, it seems to be gone now.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::findScopedProperty):
* bytecompiler/BytecodeGenerator.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::privateExecute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global_dynamic):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_resolve_skip):
2010-05-20 Darin Adler <darin@apple.com>
Reviewed by Eric Seidel.
Fix warnings seen on the buildbots today
https://bugs.webkit.org/show_bug.cgi?id=39368
* profiler/ProfileNode.cpp:
(JSC::getCount): Removed unneeded initialization of global variable.
These are all initialized to zero anyway, so no need to try to initialize
it and get a warning.
* wtf/CurrentTime.cpp:
(WTF::currentTime): Removed unused global variable.
2010-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a
local variable in the Interpreter.
https://bugs.webkit.org/show_bug.cgi?id=39447
Small speedup on SunSpider in Interpreter mode.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jsc.cpp:
* wtf/Platform.h:
2010-05-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 39408 - Unify JIT/interpreter return behaviour.
Presently the JIT and the interpreter have differing implementations in how
they handle storing the result of a function call back to the register file.
In both cases the op_call ( / _eval / _varargs / op_construct) opcode has an
operand indicating the VM register in which the result should be stored.
The JIT plants code after the call to store the result, so the value will be
stored as soon as the callee has returned. In the interpreter the call
passes the return value register id into the callee via the callee callframe,
and the callee is responsible for writing the result back into its callers
register file after it has restored the parents callframe pointer, but before
returning.
Instead, move the task of writing the call result to the register file into a
new opcode (op_call_put_result), and after returning the callee should leave
the return value in a canonical location. In the case of the interpreter,
this canonical location is a local variable in privateExecute
(functionReturnValue), in the case of the JIT this is the normal return value
registers (regT0, or regT1:regT0 in JSVALUE32_64). op_call_put_result stores
the result from the canonical location to the registerfile.
In addition to unifying JIT & interpreter behaviour this change allows us to
remove a slot from the callframe, omit the write of the result where the
return value from the call is not used, and provides a 2% speedup on sunspider
in the interpreter.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::finalDestinationOrIgnored):
* bytecompiler/NodesCodegen.cpp:
(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
* interpreter/CallFrame.h:
(JSC::ExecState::init):
(JSC::ExecState::noCaller):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::emit_op_call_put_result):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::compileOpCallVarargsSetupArgs):
2010-05-20 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210
Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.
* Configurations/FeatureDefines.xcconfig:
2010-05-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Errk! rename op_constructor_ret as requested in review of Bug 39399.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitReturn):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_ret_object_or_this):
2010-05-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 39399 - Move responsibility for verifying constructors return objects from the caller to the callee.
This is a necessary step to move object creation from caller to callee.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::isConstructor):
* bytecompiler/NodesCodegen.cpp:
(JSC::FunctionBodyNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::emit_op_constructor_ret):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_constructor_ret):
2010-05-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Fix windows build II.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Fix windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 39393 - JSFunction need not be a subclass of InternalFunction.
re-landing r59800.
* JavaScriptCore.exp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveCaller):
(JSC::Interpreter::findFunctionCallFrame):
* interpreter/Interpreter.h:
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSFunction.cpp:
(JSC::):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::calculatedDisplayName):
* runtime/JSFunction.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):
* runtime/JSObject.h:
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
2010-05-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Reverting r59800, this b0rked stuff.
* JavaScriptCore.exp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveCaller):
(JSC::Interpreter::findFunctionCallFrame):
* interpreter/Interpreter.h:
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSFunction.cpp:
(JSC::):
(JSC::JSFunction::JSFunction):
* runtime/JSFunction.h:
* runtime/JSObject.cpp:
* runtime/JSObject.h:
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
2010-05-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 39393 - JSFunction need not be a subclass of InternalFunction.
This may prevent us from introducing a more useful parent class to
JSFunction, e.g. a JSObject that holds an executable, which could
also reference an eval or program executable.
* JavaScriptCore.exp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveCaller):
(JSC::Interpreter::findFunctionCallFrame):
* interpreter/Interpreter.h:
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSFunction.cpp:
(JSC::):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::calculatedDisplayName):
* runtime/JSFunction.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):
* runtime/JSObject.h:
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
2010-05-19 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
emitJumpIfNotJSCell should special case constant immediate values
https://bugs.webkit.org/show_bug.cgi?id=39392
<rdar://problem/8001324>
Make emitJumpSlowCaseIfNotJSCell special case constant immediate
values, in addition to the immediate JSCell optimisation.
Also add assertions to make sure no one else produces code that
attempts to load constants from the register file.
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
(JSC::JSInterfaceJIT::emitLoadInt32):
(JSC::JSInterfaceJIT::tagFor):
(JSC::JSInterfaceJIT::payloadFor):
(JSC::JSInterfaceJIT::emitLoadDouble):
(JSC::JSInterfaceJIT::addressFor):
* jit/ThunkGenerators.cpp:
2010-05-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Slight refactoring to CodeBlock bytecode access
https://bugs.webkit.org/show_bug.cgi?id=39384
* bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffset):
* interpreter/CallFrame.h:
(JSC::ExecState::returnPC):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::retrieveLastCaller): Moved bytecode access into a
CodeBlock helper function. Changed CallFrame to accurately represent
how the returnPC is stored in JIT vs Interpreter.
2010-05-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Don't build the Interpreter into JIT builds.
https://bugs.webkit.org/show_bug.cgi?id=39373
SunSpider says no change.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
* wtf/Platform.h:
2010-05-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Standardized naming: "bytecode offset" wins; "bytecode index" loses.
Also renamed getBytecodeOffset to bytecodeOffset, to match the WebKit
naming style.
* bytecode/CodeBlock.h:
(JSC::CallReturnOffsetToBytecodeOffset::CallReturnOffsetToBytecodeOffset):
(JSC::getCallReturnOffset):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::callReturnIndexVector):
* interpreter/Interpreter.cpp:
(JSC::bytecodeOffsetForPC):
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileLinkPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::CallRecord::CallRecord):
(JSC::JumpTable::JumpTable):
(JSC::SwitchRecord::SwitchRecord):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCall):
* jit/JITInlineMethods.h:
(JSC::JIT::emitNakedCall):
(JSC::JIT::addSlowCase):
(JSC::JIT::addJump):
(JSC::JIT::emitJumpSlowToHot):
(JSC::JIT::isLabeled):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag):
(JSC::JIT::emitGetVirtualRegister):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_new_error):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_new_error):
(JSC::JIT::emit_op_convert_this):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_pname):
* jit/JITStubCall.h:
(JSC::JITStubCall::call):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
2010-05-19 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Darin Adler.
The backtrackParenthesesOnceEnd function should store the start position
of the subpattern's non-greedy match at the place of the subpattern's
start index in the output array instead of the place of the
subpattern's end index.
Add layout test for checking of non-greedy matching of subpattern in
regular expressions.
https://bugs.webkit.org/show_bug.cgi?id=39289
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
2010-05-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 39343 - Dynamically generate a native call thunk per NativeFunction
https://bugs.webkit.org/show_bug.cgi?id=39252 regressed performance on i386,
by adding an extra indirection to making a native call. By introducing per-
NativeFunction thunks we can hard code the function pointer into the thunk
so that it need not be loaded from the callee.
* jit/JIT.h:
(JSC::JIT::compileCTINativeCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITStubs.cpp:
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::getCTIStub):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* wtf/Platform.h:
2010-05-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Simplified handling of 'arguments' -- 1.2% SunSpider speedup
https://bugs.webkit.org/show_bug.cgi?id=39200
Removed the reserved OptionalCalleeArguments slot from the CallFrame.
Now, slots for 'arguments' are allocated and initialized only by
functions that might need them.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump): Updated for new bytecode operands.
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(JSC::unmodifiedArgumentsRegister): Added a helper function for mapping
from the arguments register to its unmodified counterpart.
(JSC::CodeBlock::setArgumentsRegister):
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::usesArguments): Changed from a "usesArguments" bool to
an optional int index representing the arguments register.
* bytecode/Opcode.h: Updated for new bytecode operands.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.
(JSC::BytecodeGenerator::BytecodeGenerator): Merged / simplified some
arguments vs activation logic, and added code to allocate the arguments
registers when needed.
(JSC::BytecodeGenerator::createArgumentsIfNecessary): Updated for new bytecode operands.
(JSC::BytecodeGenerator::emitCallEval): No need to create the arguments
object before calling eval; the activation object will lazily create the
arguments object if eval resolves it.
(JSC::BytecodeGenerator::emitReturn): Updated for new bytecode operands.
(JSC::BytecodeGenerator::emitPushScope):
(JSC::BytecodeGenerator::emitPushNewScope): Ditto emitCallEval.
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.
(JSC::BytecodeGenerator::registerFor): No more need for special handling
of the arguments registers; they're allocated just like normal registers
now.
* interpreter/CallFrame.h:
(JSC::ExecState::callerFrame):
(JSC::ExecState::init):
* interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::resetCallFrame): Nixed optionalCalleeArguments.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments): Opcodes accessing 'arguments' now
take operands specifying registers, just like all other opcodes.
JSActivation::copyRegisters is no longer responsible for tearing off the
arguments object; instead, the VM is responsible for both.
Also, a behavior change: Each access to f.arguments creates a new object,
unless f itself uses 'arguments'. This matches Chrome, and is necessary
for the optimization. f.arguments is a nonstandard, deprecated feature,
so high fidelity to a given implementation is not necessarily a goal.
Also, as illustrated by the new test case, the identity of f.arguments
has been broken since 2008, except in the case where f itself accesses
f.arguments -- but nobody seemed to notice. So, hopefully this change won't
break the web.
* interpreter/Register.h: Nixed the special arguments accessor. It's no
longer needed.
* interpreter/RegisterFile.h:
(JSC::RegisterFile::):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments): The actual optimization: Removed
OptionalCalleeArguments from the callframe slot. Now, it doesn't need
to be initialized for most calls.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::): Updated stubs to support arbitrary 'arguments' registers,
instead of hard-coding something in the call frame.
* runtime/Arguments.h:
(JSC::JSActivation::copyRegisters): Removed some obfuscatory abstraction.
* runtime/Executable.h:
(JSC::FunctionExecutable::generatedByteCode): Added a helper for accessing
the 'arguments' register. In a future patch, that kind of data should
probably move out of CodeBlock and into Executable.
* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h: Simplified / fixed access to 'arguments' via
the activation object. It now implements the same behavior implemented
by optimized variable access in the VM. This simplifies some other
things, too -- like eval code generation.
2010-05-18 Sam Weinig <sam@webkit.org>
Try to fix the windows build.
* API/JSStringRefBSTR.cpp:
2010-05-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
https://bugs.webkit.org/show_bug.cgi?id=39304
<rdar://problem/7998366>
Add an inlineCapacity template parameter to ListHashSet.
* wtf/ListHashSet.h:
(WTF::::ListHashSet):
(WTF::::operator):
(WTF::::swap):
(WTF::::~ListHashSet):
(WTF::::size):
(WTF::::capacity):
(WTF::::isEmpty):
(WTF::::begin):
(WTF::::end):
(WTF::::find):
(WTF::::contains):
(WTF::::add):
(WTF::::insertBefore):
(WTF::::remove):
(WTF::::clear):
(WTF::::unlinkAndDelete):
(WTF::::appendNode):
(WTF::::insertNodeBefore):
(WTF::::deleteAllNodes):
(WTF::::makeIterator):
(WTF::::makeConstIterator):
(WTF::deleteAllValues):
2010-05-18 Gabor Loki <loki@webkit.org>
Reviewed by Darin Adler.
Fix the interpreter after r59637
https://bugs.webkit.org/show_bug.cgi?id=39287
* runtime/Executable.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalData.h:
2010-05-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Oops, meant ebx not eax there. Fix Qt (and probably Win too).
* jit/JITOpcodes32_64.cpp:
2010-05-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 39252 - Move host/native JSFunction's NativeFunction onto NativeExecutable.
Currently host functions reuse JSFunction's ScopeChain as storage for their
NativeFunction (the C function pointer to the host function implementation).
Instead, move this onto NativeExecutable. This will allow host functions to
have a scopechain (which will be implemented as a separate patch).
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITStubs.cpp:
(JSC::JITThunks::specializedThunk):
* jit/JITStubs.h:
(JSC::JITThunks::ctiNativeCall):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):
* jit/ThunkGenerators.h:
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::function):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):
* runtime/JSFunction.h:
(JSC::JSFunction::scope):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::getThunk):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
2010-05-17 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
[Qt] Remove WinCE endian dedection.
https://bugs.webkit.org/show_bug.cgi?id=38511
Windows CE supports little-endian format only.
Correct dedection was added in r57804.
* wtf/Platform.h:
2010-05-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Reduce the size of FunctionExecutable
https://bugs.webkit.org/show_bug.cgi?id=39180
Change m_numVariables from a size_t to 31 bits in a bitfield,
packed with another bit for m_forceUsesArguments (which in turn
get packed with the base class).
Reduces the size of FunctionExecutable from 160 to 152 bytes.
* runtime/Executable.h:
(JSC::FunctionExecutable::variableCount):
(JSC::FunctionExecutable::FunctionExecutable):
2010-05-15 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Incorrect codegen for slowcase of < in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=39151
Call the correct stud for the slowcases of the < operator.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jless):
2010-05-15 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Darin Adler.
Fix bug https://bugs.webkit.org/show_bug.cgi?id=38890
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
2010-05-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Adam Treat.
[EFL] Add build system for the EFL port.
http://webkit.org/b/37945
* CMakeLists.txt: Added.
* CMakeListsEfl.txt: Added.
* config.h: Add conditional to look for cmakeconfig.h.
* jsc/CMakeLists.txt: Added.
* jsc/CMakeListsEfl.txt: Added.
* wtf/CMakeLists.txt: Added.
* wtf/CMakeListsEfl.txt: Added.
2010-05-15 Chao-ying Fu <fu@mips.com>
Reviewed by Oliver Hunt.
Update MIPS JIT for unsigned right shift, Math.sqrt, load16
https://bugs.webkit.org/show_bug.cgi?id=38412
Fixed MIPS build failure.
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::srl):
(JSC::MIPSAssembler::srlv):
(JSC::MIPSAssembler::sqrtd):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::urshift32):
(JSC::MacroAssemblerMIPS::sqrtDouble):
(JSC::MacroAssemblerMIPS::load16):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
* jit/JSInterfaceJIT.h:
2010-05-15 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Geoffrey Garen.
WebInspector: JSC Should provide heap size info for Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=38420
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/Collector.cpp:
(JSC::Heap::size):
* runtime/Collector.h:
2010-05-15 Dave Tapuska <dtapuska@rim.com>
Reviewed by Darin Adler.
Add a new define for we need strict arena alignment. ARMv5 with
double word instructions set this value.
* wtf/Platform.h:
2010-05-14 Stephanie Lewis <slewis@apple.com>
Rubber-stamped by Mark Rowe.
Update order files.
* JavaScriptCore.order:
2010-05-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Implementation of QtScript API that provide method to convert a value to an object.
[Qt] QtScript is missing toObject API
https://bugs.webkit.org/show_bug.cgi?id=36594
* qt/api/qscriptengine.cpp:
(QScriptEngine::toObject):
* qt/api/qscriptengine.h:
* qt/api/qscriptvalue.cpp:
(QScriptValue::toObject):
* qt/api/qscriptvalue.h:
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::toObject):
* qt/tests/qscriptengine/tst_qscriptengine.cpp:
(tst_QScriptEngine::toObject):
(tst_QScriptEngine::toObjectTwoEngines):
* qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
(tst_QScriptValue::toObjectSimple):
* qt/tests/qscriptvalue/tst_qscriptvalue.h:
2010-05-14 Chao-ying Fu <fu@mips.com>
Reviewed by Oliver Hunt.
String Indexing Failure on JSVALUE32 targets
https://bugs.webkit.org/show_bug.cgi?id=39034
Remove zero-extend/shift-right code on regT1, because we already have
it in emit_op_get_by_val().
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
2010-05-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Alexey Proskuryakov.
Fix a VS2010 assert in std::copy
https://bugs.webkit.org/show_bug.cgi?id=38630
The assert complains that the output iterator is null.
* wtf/Vector.h:
(WTF::::operator):
2010-05-13 Maciej Stachowiak <mjs@apple.com>
No review, attempted build fix.
Try to fix Tiger build with some gratuitous initialization of
seemingly uninitialized variables.
* wtf/text/StringImpl.h:
(WebCore::StringImpl::tryCreateUninitialized):
2010-05-13 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Various JavaScript string optimizations
https://bugs.webkit.org/show_bug.cgi?id=39051
Approximately 1% SunSpider speedup.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin): Remove branches from the hot code path
by moving the first pass outside the loop, and duplicating the hot loop
to extract the loop-invariant branch.
* runtime/RegExp.cpp:
(JSC::RegExp::match): resize ovector to 0 instead of clearing to avoid
thrash in case of large matches.
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::performMatch): Mark ALWAYS_INLINE to make the
compiler respect our authority.
* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstringsWithSeparators): Inline.
(JSC::stringProtoFuncSubstring): Rewrite boundary condition checks to
reduce the number of floating point comparisons and branches.
2010-05-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=39039
Provide support for separate bytecode/JIT code translations for call/construct usage
This will allow us to produce code generated specifically for use as a constructor, not for general function use.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::unlinkCallers):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::unlinkCallOrConstruct):
(JSC::JIT::linkConstruct):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::JITThunks::ctiVirtualConstructLink):
(JSC::JITThunks::ctiVirtualConstruct):
(JSC::):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* runtime/Arguments.h:
(JSC::JSActivation::copyRegisters):
* runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCodeForCall):
(JSC::FunctionExecutable::generateJITCodeForConstruct):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::isHostFunction):
(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ExecutableBase::generatedJITCodeForConstruct):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::bytecodeForCall):
(JSC::FunctionExecutable::isGeneratedForCall):
(JSC::FunctionExecutable::generatedBytecodeForCall):
(JSC::FunctionExecutable::bytecodeForConstruct):
(JSC::FunctionExecutable::isGeneratedForConstruct):
(JSC::FunctionExecutable::generatedBytecodeForConstruct):
(JSC::FunctionExecutable::symbolTable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::jitCodeForCall):
(JSC::FunctionExecutable::jitCodeForConstruct):
* runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::call):
(JSC::JSFunction::construct):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::numericCompareFunction):
2010-05-12 Oliver Hunt <oliver@apple.com>
build fix
<rdar://problem/7977960> REGRESSION (r59282): Tiger PPC build broken
* runtime/UString.h:
(JSC::tryMakeString):
2010-05-12 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
<rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
https://bugs.webkit.org/show_bug.cgi?id=39038
Correct the use of incorrect comparison operators.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emitBinaryDoubleOp):
2010-05-12 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Eric Seidel.
JavaScriptCore: fix build when some optimizations are disabled
https://bugs.webkit.org/show_bug.cgi?id=38800
Remove outdated UNUSED_PARAMs when using JIT but with
ENABLE_JIT_OPTIMIZE_CALL and ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
disabled.
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
2010-05-12 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Work around GCC stupidity by either explicitly inlining or by
using ALWAYS_INLINE
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
* runtime/UString.h:
(JSC::UString::~UString):
* wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::~RefPtr):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):
2010-05-12 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Detect debug mode consistently
https://bugs.webkit.org/show_bug.cgi?id=38863
* JavaScriptCore.pri:
* JavaScriptCore.pro:
* jsc.pro:
* qt/api/QtScript.pro:
2010-05-12 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Remove a direct jump in generatePatternCharacterGreedy() and
generatePatternCharacterClassGreedy() functions if quantityCount of the term
is unlimited.
https://bugs.webkit.org/show_bug.cgi?id=38898
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
2010-05-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Slight simplification to the calling convention: read RegisterFile::end()
from an absolute address, instead of from a pointer to the RegisterFile
on the stack.
SunSpider reports no change.
This should free us to remove the RegisterFile argument from the stack.
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
2010-05-11 Brian Weinstein <bweinstein@apple.com>
Possible Gtk build fix - use ALWAYS_INLINE on functions that were inlined.
* wtf/text/AtomicString.h:
(WebCore::AtomicString::add): Use ALWAYS_INLINE.
* wtf/text/WTFString.h:
(WebCore::String::length): Ditto.
(WebCore::String::isEmpty): Ditto.
2010-05-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a compile time assert that sizeof(String) == sizeof(AtomicString).
* wtf/text/AtomicString.cpp:
2010-05-11 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.
Make AtomicString no longer inherit from FastAllocBase.
Since AtomicString's first (and only) member variable, a RefPtr, also inherits from FastAllocBase this
was causing the size of AtomicString to contain sizeof(void*) bytes of padding.
* wtf/text/AtomicString.h:
2010-05-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Maciej Stachowiak.
Patch by Gavin Barraclough.
Rest of REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
Inline string functions that are commonly used in WTFString, CString, and AtomicString.
* JavaScriptCore.exp: Remove exports of inline functions.
* wtf/text/AtomicString.cpp:
(WebCore::AtomicString::addSlowCase): Rename add to addSlowCase, and inline the fast path
of add.
* wtf/text/AtomicString.h:
(WebCore::AtomicString::add): Inline the fast path of add.
* wtf/text/CString.cpp: Inline implementation of data and length in the header.
* wtf/text/CString.h:
(WTF::CString::data): Inline implementation of data.
(WTF::CString::length): Inline implementation of length.
* wtf/text/WTFString.cpp: Remove implementations of functions to be inlined.
* wtf/text/WTFString.h:
(WebCore::String::String): Inline implementation.
(WebCore::String::length): Ditto.
(WebCore::String::characters): Ditto.
(WebCore::String::operator[]): Ditto.
(WebCore::String::isEmpty): Ditto.
2010-05-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg and Jon Honeycutt.
Patch by Gavin Barraclough.
REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).
We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.
* GNUmakefile.am: Add new file to build system.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.pro: Ditto.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove string exports, because these are now
handled in WebCore.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added
here (the post build step is in JavaScriptCoreCommon.vsprops).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled
by WebCore into the WebKitOutputDir directory.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
* JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
* wtf/text/AtomicString.cpp: Moved code to StringStatics.
* wtf/text/StringImpl.cpp: Ditto.
* wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so
the rest of the files can be compiled in WebCore.
(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.
2010-05-11 Alice Liu <alice.liu@apple.com>
Rubber-stamped by Gavin Barraclough.
Fix build error when enabling debugging block in WebKit win painting code
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-11 Mark Rowe <mrowe@apple.com>
Fix the world.
In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
function in WebCore being called.
We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
has been reverted.
* Configurations/FeatureDefines.xcconfig:
2010-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r59171.
http://trac.webkit.org/changeset/59171
https://bugs.webkit.org/show_bug.cgi?id=38933
"Broke the world" (Requested by bweinstein on #webkit).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/text/AtomicString.cpp:
(WebCore::AtomicString::init):
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::empty):
* wtf/text/StringStatics.cpp: Removed.
2010-05-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
Patch by Gavin Barraclough.
REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>
When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).
We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove string exports, because these are now
handled in WebCore.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added
here (the post build step is in JavaScriptCoreCommon.vsprops).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled
by WebCore into the WebKitOutputDir directory.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
* JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
* wtf/text/AtomicString.cpp: Moved code to StringStatics.
* wtf/text/StringImpl.cpp: Ditto.
* wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so
the rest of the files can be compiled in WebCore.
(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.
2010-05-11 Geoffrey Garen <ggaren@apple.com>
Fixed test failures seen on SnowLeopard buildbot.
* runtime/JSString.cpp:
(JSC::JSString::replaceCharacter): Don't use size_t and wtf::notFound.
Instead, use the individual types and notFound values of the string APIs
we're using, since they're not necessarily the same in 64bit.
2010-05-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Darin Adler.
Start using ropes in String.prototype.replace.
1%-1.5% speedup on SunSpider.
* runtime/JSString.cpp:
(JSC::JSString::resolveRope): Updated for RopeImpl refactoring.
(JSC::JSString::replaceCharacter): Added a replaceCharacter function, which creates
a rope for the resulting replacement.
* runtime/JSString.h: A few changes here:
(JSC::):
(JSC::RopeBuilder::RopeIterator::RopeIterator):
(JSC::RopeBuilder::RopeIterator::operator++):
(JSC::RopeBuilder::RopeIterator::operator*):
(JSC::RopeBuilder::RopeIterator::operator!=):
(JSC::RopeBuilder::RopeIterator::WorkItem::WorkItem):
(JSC::RopeBuilder::RopeIterator::WorkItem::operator!=):
(JSC::RopeBuilder::RopeIterator::skipRopes): Created a RopeIterator abstraction.
We use this to do a substring find without having to resolve the rope.
(We could use this iterator when resolving ropes, too, but resolving
ropes backwards is usually more efficient.)
(JSC::RopeBuilder::JSString): Added constructors for 2 & 3 UStrings.
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::size): Updated for RopeImpl refactoring.
* runtime/Operations.h: Updated for RopeImpl refactoring.
(JSC::jsString): Added jsString functions for 2 & 3 UStrings.
* runtime/RopeImpl.cpp:
(JSC::RopeImpl::derefFibersNonRecursive):
* runtime/RopeImpl.h:
(JSC::RopeImpl::initializeFiber):
(JSC::RopeImpl::size):
(JSC::RopeImpl::fibers):
(JSC::RopeImpl::deref):
(JSC::RopeImpl::RopeImpl): A little refactoring to make this patch easier:
Moved statics to the top of the class; put multi-statement functions on
multiple lines; renamed "fiberCount" to "size" to match other collections;
changed the "fibers" accessor to return the fibers buffer, instead of an
item in the buffer, to make iteration easier.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace): Don't resolve a rope unless we need to. Do
use our new replaceCharacter function if possible. Do use a rope to
represent splicing three strings together.
2010-05-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
[Qt] Disable JIT support for mingw-w64
https://bugs.webkit.org/show_bug.cgi?id=38747
Disale JIT for mingw-w64 as it is reportedly
unstable.
Thanks for Vanboxem Rruben for the investigation.
* wtf/Platform.h:
2010-05-09 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
https://bugs.webkit.org/show_bug.cgi?id=38723
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/MD5.cpp:
(WTF::expectMD5):
Fix for checksum change.
(WTF::MD5::checksum):
Take a reference to output, instead of returning the result by value, to reduce coping for performance.
* wtf/MD5.h:
2010-05-09 Oliver Hunt <oliver@apple.com>
Build fix.
Fix accidental repeat addition of emit_op_new_regexp
* jit/JITOpcodes.cpp:
2010-05-09 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION(r57955): RegExp literals should not actually be cached, so r57955 should be rolled out.
https://bugs.webkit.org/show_bug.cgi?id=38828
<rdar://problem/7961634>
Rollout r57955
* bytecode/CodeBlock.cpp:
(JSC::regexpToSourceString):
(JSC::regexpName):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addRegExp):
(JSC::CodeBlock::regexp):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addRegExp):
(JSC::BytecodeGenerator::emitNewRegExp):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_regexp):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::):
2010-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Reserve a large-ish initial capacity for Lexer::m_buffer16.
SunSpider says 0.3% faster.
m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.
The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.
* parser/Lexer.cpp:
(JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor,
since setCode will be called before we're asked to lex anything.
(JSC::Lexer::setCode): Reserve enough space to lex half the source code
as a complex string without having to copy.
(JSC::Lexer::clear): No need to reserve initial capacity here either,
since setCode will be called before we're asked to lex anything.
2010-05-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] Remove YARR configuration rules from Qt make system
https://bugs.webkit.org/show_bug.cgi?id=38819
Setting YARR based on JIT seeting is now in Platform.h
for all ports. This patch essentially reverses r49238.
* JavaScriptCore.pri:
2010-05-09 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Improve string indexing performance
https://bugs.webkit.org/show_bug.cgi?id=38814
Add an assembly stub to do indexed loads from strings much
more cheaply than the current stub dispatch logic. We can
do this because we are able to make guarantees about the
register contents when entering the stub so the call overhead
is negligible.
* jit/JIT.h:
* jit/JITInlineMethods.h:
* jit/JITOpcodes.cpp:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
Moved from JITOpcodes.cpp to keep the slowcase next to
the normal case codegen as we do for everything else.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::emitFastArithImmToInt):
2010-05-09 Maciej Stachowiak <mjs@apple.com>
Fixed version of: "Optimized o[s] where o is a cell and s is a string"
https://bugs.webkit.org/show_bug.cgi?id=38815
Fixed the previous patch for this from Geoff Garen.
The two problems were a missing exception check and a PropertySlot
initialized improperly, leading to crashes and failures in the case
of getters accessed with bracket syntax.
Previous patch:
Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.
SunSpider says 0.8% faster.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, build fix.
Fix missing terminating ' character warning
The warning has been only seen on the Gtk buildbots.
* wtf/Platform.h:
2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Gavin Barraclough.
Refactor YARR and YARR_JIT default rules in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=38727
Turn on YARR and YARR JIT by default of JIT is enabled.
Ports can overrule this default decisions as they wish.
* wtf/Platform.h:
2010-05-08 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Split JSVALUE32_64 code out of JITOpcodes.cpp and into JITOpcodes32_64.cpp
https://bugs.webkit.org/show_bug.cgi?id=38808
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp: Added.
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emit_op_strcat):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_not):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_sret):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_stricteq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emit_op_nstricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_push_scope):
(JSC::JIT::emit_op_pop_scope):
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emitSlow_op_to_jsnumber):
(JSC::JIT::emit_op_push_new_scope):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_jmp_scopes):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_new_error):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_enter_with_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
2010-05-08 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Fix halfword loads on ARM
https://bugs.webkit.org/show_bug.cgi?id=38741
The BaseIndex and ImplicitAddress are contain 32bit wide offset, but
the load16 functions were working with 8 bit data (encoded in the
instruction). If the offset cannot be encoded in an instruction, it
should be stored in a temporary register.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::getOffsetForHalfwordDataTransfer):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load16):
2010-05-08 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Fix spanning branch instruction on Cortex-A8 with Thumb-2 JIT
https://bugs.webkit.org/show_bug.cgi?id=38280
If the 32-bit Thumb-2 branch instruction spans two 4KiB regions and
the target of the branch falls within the first region it is
possible for the processor to incorrectly determine the branch
instruction, and it is also possible in some cases for the processor
to enter a deadlock state.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::linkJumpAbsolute):
2010-05-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[WTFURL] Add a buffer for managing the output of the canonicalizer
https://bugs.webkit.org/show_bug.cgi?id=38671
The canonicalizer produces a stream of canonicalized characters, which
we will store in a URLBuffer. URLBuffer is quite similar to Vector,
but serves as an abstraction to isolate us from the underlying
character storage. In the case of WebKit, we'll probably implement a
subclass of URLBuffer with Vector. In Chromium, the backing store is a
std::string, which avoids an unnecessary memcpy that would be caused by
using Vector instead.
* wtf/url/src/URLBuffer.h: Added.
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):
2010-05-08 Eric Seidel <eric@webkit.org>
Unreviewed, just reverting commit.
REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_global):
2010-05-04 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak
Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>
Added cancelCallOnMainThread. callOnMainThread should always now be paired
with cancelCallOnMainThread in situations where the refcon passed to callOnMainThread
may be dealloced before the main thread function can be dispatched.
* wtf/MainThread.cpp:
(WTF::FunctionWithContext::operator == ): Supports the FunctionWithContextFinder predicate functor.
(WTF::FunctionWithContextFinder::FunctionWithContextFinder): Predicate functor for use with Dequeue::findIf
(WTF::FunctionWithContextFinder::operator()):
(WTF::cancelCallOnMainThread):
* wtf/MainThread.h:
2010-05-07 Oliver Hunt <oliver@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-07 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r58990.
http://trac.webkit.org/changeset/58990
Broke 4 tests on Snow Leopard and Qt.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
2010-05-07 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Optimize access to the global object from a function that uses eval
https://bugs.webkit.org/show_bug.cgi?id=38644
Fix bug where cross scope access to a global var (vs. property) would
be allowed without checking for intervening dynamic scopes.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
2010-05-07 Oliver Hunt <oliver@apple.com>
32-bit buildfix.
Macro expansion I stab at thee!
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_global):
2010-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.
SunSpider says 0.8% faster.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
2010-05-07 Oliver Hunt <oliver@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-07 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Optimize access to the global object from a function that uses eval
https://bugs.webkit.org/show_bug.cgi?id=38644
Add op_resolve_global_dynamic, a variant of op_resolve_global that
checks each node in the scope chain for dynamically inserted properties
and falls back to the normal resolve logic in that case.
* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::isGlobalResolve):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::derefStructures):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::findScopedProperty):
Now take an additional reference parameter to used to indicate that
there were nodes that may gain dynamic properties
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveWithBase):
deal with additional argument to findScopedProperty
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
These functions use findScopedProperty directly in order to
optimise lookup. They cannot trivially handle any degree of
dynamism in the lookup so we just give up in such case.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emit_op_resolve_global_dynamic):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):
Happily resolve_global_dynamic can share the slow case!
* jit/JITStubs.h:
(JSC::):
* runtime/JSActivation.cpp:
(JSC::JSActivation::isDynamicScope):
* runtime/JSActivation.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::isDynamicScope):
* runtime/JSGlobalObject.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::isDynamicScope):
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.h:
2010-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Fixed Sputnik failure seen on buildbot.
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString): Cast to unsigned before checking magnitude,
to efficiently exclude negative numbers, which require two characters
instead of one.
2010-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Alexey Proskuryakov.
Slightly more effective way to guarantee a compile-time constant, at
least on gcc.
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString): Use pointer notation instead of array
notation, so the compiler treats the string and its contents as constant.
2010-05-07 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
[WTFURL] Add core URL parser
https://bugs.webkit.org/show_bug.cgi?id=38572
This patch adds the core of the URL parser. The URL parser uses a
templated notion of a code unit to support different string types.
Later we'll add some non-templated APIs with concrete types that
clients can use more conveniently.
The URLParser has a couple calls to ASSERT(), which I've commented out
for now. I'm not 100% sure how to handle the dependency issues there
yet, so I've punted on the issue for now.
Also, there are a number of methods that are declared public in this
patch that are only used by the canonicalizer. My plan is to make
those private or protected and make the canonicalizer a friend of the
parser. The details will be in a later patch.
* wtf/url/src/URLComponent.h:
(WTF::URLComponent::fromRange):
(WTF::URLComponent::isNonEmpty):
(WTF::URLComponent::isEmptyOrInvalid):
* wtf/url/src/URLParser.h: Added.
(WTF::URLParser::):
(WTF::URLParser::isPossibleAuthorityTerminator):
(WTF::URLParser::parseAuthority):
(WTF::URLParser::extractScheme):
(WTF::URLParser::parseAfterScheme):
(WTF::URLParser::parseStandardURL):
(WTF::URLParser::parsePath):
(WTF::URLParser::parsePathURL):
(WTF::URLParser::parseMailtoURL):
(WTF::URLParser::parsePort):
(WTF::URLParser::extractFileName):
(WTF::URLParser::extractQueryKeyValue):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::consecutiveSlashes):
(WTF::URLParser::isPortDigit):
(WTF::URLParser::nextAuthorityTerminator):
(WTF::URLParser::parseUserInfo):
(WTF::URLParser::parseServerInfo):
2010-05-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added a fast path for number-to-character conversion via
Number.prototype.toString base 36.
0.7% speedup on SunSpider.
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString): Made radix interpretation a little more
efficient by keeping it in int space. Turned "const char" into
"static const char" just in case. Added a fast path for base 36
conversion of something that will turn into a character.
2010-05-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[WTFURL] Add a malloc-backed URLBuffer
https://bugs.webkit.org/show_bug.cgi?id=38694
This patch adds a URLBuffer that uses new/delete to manage the backing
store for the buffer.
* wtf/url/src/RawURLBuffer.h: Added.
(WTF::RawURLBuffer::RawURLBuffer):
(WTF::RawURLBuffer::~RawURLBuffer):
(WTF::RawURLBuffer::resize):
2010-05-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
JavaScriptCore/wtf/RandomNumber.h should provide using WTF::*
https://bugs.webkit.org/show_bug.cgi?id=38719
* wtf/RandomNumber.h:
Add using directives.
2010-05-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable YARR_JIT for X86 Mac for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=38668
* wtf/Platform.h:
2010-05-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 38714 - Add result caching for Math.sin
Math.sin is frequently called with the same operand, caching the result should
improve performance. CachedTranscendentalFunction adds a generic mechanism to
cache results for pure functions with the signature "double func(double)", and
where NaN maps to NaN.
CachedTranscendentalFunction uses a very simple hash function designed to be
fast to execute since we cannot cache the result, and trivial to JIT generate,
should we wish to do so.
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/CachedTranscendentalFunction.h: Added.
(JSC::CachedTranscendentalFunction::CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::~CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::operator()):
(JSC::CachedTranscendentalFunction::initialize):
(JSC::CachedTranscendentalFunction::hash):
* runtime/JSGlobalData.h:
* runtime/MathObject.cpp:
(JSC::mathProtoFuncSin):
* wtf/Platform.h:
2010-05-06 Geoffrey Garen <ggaren@apple.com>
Windows build fix.
* bytecode/SamplingTool.cpp:
(JSC::SamplingFlags::sample): Use a cast, so Windows will be happy when
this code is enabled.
* wtf/Platform.h: Reverted last change to this file, which seems to have
been accidental.
2010-05-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add compile switch to make debugger keyword plant breakpoint instructions.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
* wtf/Platform.h:
2010-05-06 Oliver Hunt <oliver@apple.com>
Build fix
Fix ARM builds
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load16):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16):
2010-05-06 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Improve performance of single character string compares
https://bugs.webkit.org/show_bug.cgi?id=38659
Add logic to the jit to identify comparisons to single character string literals
and then just perform the comparison inline, rather than ignoring the evidence
and attempting to perform an integer comparison.
Multiple changes required -- add jnlesseq opcode, add helper function to identify
single character string constants, add a helper to load single character strings.
Then add the 32_64 and normal codepaths to the JIT.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load16):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfTrue):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadCharacterString):
(JSC::JIT::isOperandConstantImmediateChar):
* jit/JSInterfaceJIT.h:
(JSC::ThunkHelpers::stringImplDataOffset):
(JSC::ThunkHelpers::jsStringLengthOffset):
(JSC::ThunkHelpers::jsStringValueOffset):
Moved from ThunkGenerators to make it possible to share.
* jit/ThunkGenerators.cpp:
2010-05-06 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Convert dragging portion of drag-and-drop to use DataObjectGtk.
* wtf/gobject/GRefPtr.h: Add forward declarations for GObject functions.
2010-05-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544
* wtf/Platform.h:
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
[WTFURL] Add a class to represent the segments of a URL
https://bugs.webkit.org/show_bug.cgi?id=38566
When paired with a string, this class represents a parsed URL.
* wtf/url/src/URLSegments.cpp: Added.
(WTF::URLSegments::length):
(WTF::URLSegments::charactersBefore):
* wtf/url/src/URLSegments.h: Added.
(WTF::URLSegments::):
(WTF::URLSegments::URLSegments):
* wtf/url/wtfurl.gyp:
2010-05-05 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Adding comment with link to RefPtr documentation.
https://bugs.webkit.org/show_bug.cgi?id=38601
* wtf/RefPtr.h:
2010-05-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Bug 38604 - workers-gc2 crashing on Qt
This appears to be due to a couple of issues.
(1) When the atomic string table is deleted it does not clear the 'inTable' bit
on AtomicStrings - it implicitly assumes that all AtomicStrings have already
been deleted at this point (otherwise they will crash in their destructor when
they try to remove themselves from the atomic string table).
(2) We don't fix the ordering in which WTF::WTFThreadData and
WebCore::ThreadGlobalData are destructed.
We should make sure that ThreadGlobalData is cleaned up before worker threads
terminate and WTF::WTFThreadData is destroyed, and we should clear the inTable
bit of members on atomic string table destruction.
WTF changes (fix issue 1, above) - ensure inTable property is cleared when the
atomic string table is destroyed (also, rename InTable to IsAtomic, to make it
clear which table we are refering to!)
* wtf/text/AtomicString.cpp:
(WebCore::AtomicStringTable::destroy):
(WebCore::CStringTranslator::translate):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::add):
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):
* wtf/text/StringImplBase.h:
2010-05-05 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make Array.join specialised for actual arrays
https://bugs.webkit.org/show_bug.cgi?id=38592
Bring Array.join in line with the other array methods by specialising for
this === an array.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
2010-05-04 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Darin Adler.
WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
https://bugs.webkit.org/show_bug.cgi?id=38535
Don't call asFunction if callee is not a FunctionType to prevent assertion failure
in JSCell::isObject().
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::calculatedFunctionName):
2010-05-04 Steve Falkenburg <sfalken@apple.com>
Remove redundant exports to fix Windows build warnings.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-05-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Holger Freyther.
Fix a memory leak inside the QScriptValue.
QSciptValuePrivate::toString should release all temporary variables.
[Qt] QScriptValue::toString have a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=38112
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::toString):
2010-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Darin Adler.
Does not work on SPARC because of alignment issues
https://bugs.webkit.org/show_bug.cgi?id=38455
Use AllocAlignmentInteger instead of void* on pageheap_memory to
avoid crashing at runtime in some architectures. Investigated by
Mike Hommey <mh@glandium.org>, change suggested by Darin Adler.
* wtf/FastMalloc.cpp:
2010-05-04 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Add first WTFURL file
https://bugs.webkit.org/show_bug.cgi?id=38470
This class represents a component of a URL, such as the scheme or path.
Essentially, the class is an index into a string buffer.
* wtf/url: Added.
- There was some discussion about where to put the URL library.
There are a number of reasonable options, but putting the library
in the WTF directory seems like a reasonable alternative. This
location will make more sense once WTF is moved out of
JavaScriptCore and into a top-level directory.
* wtf/url/src: Added.
- I've added this extra directory to the usual structure because we
eventually want a "public" folder that defines the public
interface to this library that clients outside of svn.webkit.org
can rely upon, much like the various subfolders of the WebKit
directory often define a public API.
* wtf/url/src/URLComponent.h: Added.
- I've added this somewhat trivial class to get the ball rolling.
(WTF::URLComponent::URLComponent):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonempty):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):
* wtf/url/wtfurl.gyp: Added.
- WTFURL will be an independently buildable library, hence the
beginnings of a wtfurl.gyp file.
2010-05-03 Stephanie Lewis <slewis@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=38368
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028
(return memory quicker).
Instead of returning everything but the smallest spans spread out
the spans kept over several size lists.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavenge):
2010-05-03 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Clean up a few compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=38073
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::ascii):
2010-05-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (reverting previous commit).
Rolling out r58114 - this introduced memory leaks of
AtomicStrings then workers terminated.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ThunkGenerators.cpp:
(JSC::ThunkHelpers::stringImplDataOffset):
* runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::IdentifierUCharBufferTranslator::hash):
(JSC::IdentifierUCharBufferTranslator::equal):
(JSC::IdentifierUCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):
* runtime/Identifier.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
* wtf/WTFThreadData.h:
(JSC::IdentifierTable::remove):
(JSC::IdentifierTable::literalTable):
(WTF::WTFThreadData::atomicStringTable):
* wtf/text/AtomicString.cpp:
(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):
(WebCore::CStringTranslator::hash):
(WebCore::CStringTranslator::equal):
(WebCore::CStringTranslator::translate):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::equal):
(WebCore::UCharBufferTranslator::hash):
(WebCore::UCharBufferTranslator::equal):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::hash):
(WebCore::HashAndCharactersTranslator::equal):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):
* wtf/text/AtomicStringTable.h: Removed.
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::equal):
* wtf/text/StringImplBase.h:
(WTF::StringImplBase::StringImplBase):
2010-05-03 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Implement scheduleDispatchFunctionsOnMainThread for wx port.
https://bugs.webkit.org/show_bug.cgi?id=38480
* wtf/wx/MainThreadWx.cpp:
(wxCallAfter::wxCallAfter):
(wxCallAfter::OnCallback):
(WTF::scheduleDispatchFunctionsOnMainThread):
2010-05-03 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Build and use Mac's ComplexTextController to support complex text in wx.
https://bugs.webkit.org/show_bug.cgi?id=38482
* wtf/Platform.h:
2010-05-03 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Interpreter crashes due to incorrect refcounting of cached structures.
https://bugs.webkit.org/show_bug.cgi?id=38491
rdar://problem/7926160
Make sure we ref/deref structures used for cached custom property getters
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
2010-05-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] Enable JIT for QtWebKit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=38339
JIT on Symbian has been stable for quite some time, it
is time to turn it on by default.
* wtf/Platform.h:
2010-04-29 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add codegen support for unsigned right shift
https://bugs.webkit.org/show_bug.cgi?id=38375
Expose unsigned right shift in the macro assembler, and make use of it
from the jit. Currently if the result is outside the range 0..2^31-1
we simply fall back to the slow case, even in JSVALUE64 and JSVALUE32_64
where technically we could still return an immediate value.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::urshift32):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::urshift32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::urshift32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::):
(JSC::X86Assembler::shrl_i8r):
(JSC::X86Assembler::shrl_CLr):
Add unsigned right shift to the x86 assembler
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
op_rshift no longer simply get thrown to a stub function
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_urshift):
(JSC::JIT::emitSlow_op_urshift):
JSVALUE32 and JSVALUE64 implementation. Only supports
double lhs in JSVALUE64.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_urshift):
(JSC::JIT::emitSlow_op_urshift):
Refactor right shift code to have shared implementation between signed
and unsigned versions.
2010-04-29 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Handle double on righthand side of a right shift
https://bugs.webkit.org/show_bug.cgi?id=38363
In 64-bit we support right shift of a double, and there's no
reason not to in 32-bit either. This is a 1.1% sunspider
improvement in 32bit.
Given high performance javascript code frequently makes
use of bit operators to perform double->int conversion i'll
follow this patch up with similar patches for bitwise 'and'
and 'or'.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
2010-04-29 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Hoist JSVALUE32_64 arithmetic implementations into a separate file.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_div):
(JSC::JIT::compileBinaryArithOp):
* jit/JITArithmetic32_64.cpp: Added.
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emitSlow_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emitSlow_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emitSlow_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emitSlow_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emitSlow_op_pre_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSub32Constant):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
2010-04-29 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Oliver Hunt
Add sqrt() instruction support for ARM assembler (using VFP)
https://bugs.webkit.org/show_bug.cgi?id=38312
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::fsqrtd_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::sqrtDouble):
2010-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Refactor qtscriptglobal.h
https://bugs.webkit.org/show_bug.cgi?id=37953
Use the same pattern in qtscriptglobal.h as in
qwebkitglobal.h without checking for specific OSs.
* qt/api/qtscriptglobal.h:
2010-04-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Small cleanup.
QScriptValuePrivate constructor shouldn't take QScriptEngine pointer
as a parameter, because it breaks a private / public separation rule.
QScriptEnginePrivate::get(QScriptEngine*) should return
a QScriptEnginePrivate pointer instead of a QScriptEnginePtr, it simplifies
implementation.
[Qt] QScriptValuePrivate class needs some cleanup.
https://bugs.webkit.org/show_bug.cgi?id=37729
* qt/api/qscriptengine_p.h:
(QScriptEnginePrivate::get):
* qt/api/qscriptvalue.cpp:
(QScriptValue::QScriptValue):
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::QScriptValuePrivate):
2010-04-29 Kwang Yul Seo <skyul@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Export g_stackBase with JS_EXPORTDATA
https://bugs.webkit.org/show_bug.cgi?id=37437
Export g_stackBase with JS_EXPORTDATA as it is used by SharedTimerWince.cpp.
* runtime/Collector.cpp:
2010-04-28 Oliver Hunt <oliver@apple.com>
Do an unordered compare so that we don't treat NaN incorrectly.
RS=Gavin Barraclough
* jit/ThunkGenerators.cpp:
(JSC::powThunkGenerator):
2010-04-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add fast paths for Math.pow and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=38294
Add specialized thunks for Math.pow and Math.sqrt.
This requires adding a sqrtDouble function to the MacroAssembler
and sqrtsd to the x86 assembler.
Math.pow is slightly more complicated, in that we have
to implement exponentiation ourselves rather than relying
on hardware support. The inline exponentiation is restricted
to positive integer exponents on a numeric base. Exponentiation
is finally performed through the "Exponentiation by Squaring"
algorithm.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::sqrtDouble):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::loadDouble):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::sqrtDouble):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::loadDouble):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
* assembler/X86Assembler.h:
(JSC::X86Assembler::):
(JSC::X86Assembler::movsd_mr):
(JSC::X86Assembler::sqrtsd_rr):
(JSC::X86Assembler::X86InstructionFormatter::twoByteOp):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
* create_hash_table:
* jit/JIT.h:
* jit/JITInlineMethods.h:
* jit/JITOpcodes.cpp:
* jit/JITStubs.h:
(JSC::JITThunks::ctiNativeCallThunk):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::emitLoadDouble):
(JSC::JSInterfaceJIT::emitJumpIfImmediateNumber):
(JSC::JSInterfaceJIT::emitJumpIfNotImmediateNumber):
(JSC::JSInterfaceJIT::emitLoadInt32):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::loadDoubleArgument):
(JSC::SpecializedThunkJIT::loadInt32Argument):
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):
* jit/ThunkGenerators.h:
* runtime/Executable.h:
(JSC::NativeExecutable::NativeExecutable):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
2010-04-28 Mike Thole <mthole@apple.com>
Reviewed by Mark Rowe.
Reenable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK now that an
exports file for it has been added.
* wtf/Platform.h:
2010-04-28 Mike Thole <mthole@apple.com>
Build fix, not reviewed.
* wtf/Platform.h:
Disable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK until an exports file is created.
2010-04-28 Mike Thole <mthole@apple.com>
Reviewed by David Kilzer.
Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
can be inspected before attempting to authenticate against it
https://bugs.webkit.org/show_bug.cgi?id=38271
* wtf/Platform.h: Add WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK define.
2010-04-28 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Don't use CFAbsoluteTimeGetCurrent on Mac OS X, since it's just a cover
for gettimeofday anyway.
* wtf/CurrentTime.cpp:
(WTF::currentTime): Remove the CF version of this. Change the "other POSIX"
version to pass 0 for the time zone instead of ignoring a return value.
Also get rid of unneeded type casts, since operations involving both
integers and doubles are always evaluated as doubles in C without explicit
type casting.
2010-04-28 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
[Chromium] callOnMainThread should equate to MessageLoop::PostTask
https://bugs.webkit.org/show_bug.cgi?id=38276
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* wtf/MainThread.cpp:
* wtf/chromium/ChromiumThreading.h:
* wtf/chromium/MainThreadChromium.cpp:
(WTF::initializeMainThread):
(WTF::callOnMainThread):
(WTF::callOnMainThreadAndWait):
(WTF::setMainThreadCallbacksPaused):
(WTF::isMainThread):
2010-04-28 Simon Hausmann <simon.hausmann@nokia.com>, Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
JSC's currentThreadStackBase is not reentrant on some platforms
https://bugs.webkit.org/show_bug.cgi?id=37195
This function needs to be reentrant to avoid memory corruption on platforms where
the implementation uses global variables.
This patch adds a mutex lock where necessary and makes the Symbian implementation
reentrant.
* runtime/Collector.cpp:
(JSC::currentThreadStackBaseMutex):
(JSC::currentThreadStackBase):
2010-04-28 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Fix compilation with gcc 3.4.
AtomicStringImpl.h:29: error: base `WebCore::StringImpl' with only
non-default constructor in class without a constructor
* wtf/text/AtomicStringImpl.h:
(WebCore::AtomicStringImpl::AtomicStringImpl): Provide a default constructor.
* wtf/text/StringImpl.h: Allow AtomicStringImpl to call a StringImpl constructor through a friend declaration.
2010-04-27 Stephanie Lewis <slewis@apple.com>
Fix Tiger build.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::Carve):
2010-04-26 Stephanie Lewis <slewis@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=38154 FastMalloc calls madvise too often.
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028 (return memory quicker).
To save on madvise calls when recommitting memory recommit the entire span and then carve it
instead of carving the span up and only committing the part that will be used immediately.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Carve):
2010-04-26 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Add specialized thunks for a char code related string functions
https://bugs.webkit.org/show_bug.cgi?id=38177
This is a simple extension to my prior patch. Basically hoist the
existing character loading logic from the charCodeAt thunk and into
a helper function, then add a helper to load strings from the small
string cache. This allows trivial implementations of fromCharCode
and charAt.
* create_hash_table:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnJSCell):
(JSC::SpecializedThunkJIT::tagReturnAsJSCell):
* jit/ThunkGenerators.cpp:
(JSC::stringCharLoad):
(JSC::charToString):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
* jit/ThunkGenerators.h:
* runtime/SmallStrings.h:
(JSC::SmallStrings::singleCharacterStrings):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
2010-04-27 Thomas Zander <t.zander@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix the build on Symbian on Linux using the Makefile based mkspec
* JavaScriptCore.pri: It is necessary to specify the library search path
when linking against JavaScriptCore.
2010-04-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
Compile fix for Visual Studio 2010
https://bugs.webkit.org/show_bug.cgi?id=37867
Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com>
* runtime/Structure.cpp:
(JSC::Structure::transitionTableAdd):
* wtf/MathExtras.h:
* wtf/Platform.h:
2010-04-27 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
Rename COMPILER(MSVC7) to COMPILER(MSVC7_OR_LOWER)
* config.h:
(JSC::Structure::transitionTableAdd):
* wtf/Assertions.h:
* wtf/Atomics.h:
* wtf/CurrentTime.h:
(WTF::getLocalTime):
* wtf/Platform.h:
* wtf/StaticConstructors.h:
* wtf/StringExtras.h:
* wtf/Vector.h:
(WTF::::append):
2010-04-15 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix Mac build break.
https://bugs.webkit.org/show_bug.cgi?id=37867
- Make sure JavaScriptCore's debug_and_release config follows that
of WebCore.
- Use different name for JavaScriptCore target in debug and release
since they might be written in the same path at the same time on
parallel builds
- Consolidate the DESTDIR determination logic in JavaScriptCore.pri
* JavaScriptCore.pri:
* JavaScriptCore.pro:
2010-04-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make sure WebKit is not compiled using C++0x.
https://bugs.webkit.org/show_bug.cgi?id=37867
As the rest of Qt compiles in the C++0x mode, people might start
compiling it in this mode. WebKit don't support this yet.
Patch by Thiago Macieira <thiago.macieira@nokia.com>
* JavaScriptCore.pro:
2010-04-26 Oliver Hunt <oliver@apple.com>
Fix windows
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::argumentToVirtualRegister):
2010-04-26 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Need to support more efficient dispatch of lightweight builtins
https://bugs.webkit.org/show_bug.cgi?id=38155
The problem with calling lightweight builtins is that marshalling
the call from the nitro calling convention to the system calling
convention is very expensive relative to the cost of the actually
evaluating the function. To work around this problem this patch
adds the ability to define a custom thunk for a builtin.
This allows us to use high performance custom implementations of
the common and sensible versions of simple builtins. This patch
includes a simple (use of which is currently hardcoded) thunk for
charCodeAt.
This adds a JSInterfaceJIT subclass called SpecializedThunkJIT
that has helper functions to remove (or at least reduce) the need
to have separate thunk implementations for each JSValue encoding.
* GNUmakefile.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
Many project file updates
* create_hash_table:
Add thunk generation callbacks to the hash tables, currently
we hardcode the script to only support charCodeAt
* jit/JITStubCall.h:
* jit/JITStubs.cpp:
(JSC::JITThunks::~JITThunks):
(JSC::JITThunks::specializedThunk):
* jit/JITStubs.h:
* jit/SpecializedThunkJIT.h: Added.
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::loadCellArgument):
(JSC::SpecializedThunkJIT::loadJSStringArgument):
(JSC::SpecializedThunkJIT::loadInt32Argument):
(JSC::SpecializedThunkJIT::appendFailure):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::finalize):
(JSC::SpecializedThunkJIT::argumentToVirtualRegister):
(JSC::SpecializedThunkJIT::tagReturnAsInt32):
* jit/ThunkGenerators.cpp: Added.
(JSC::ThunkHelpers::stringImplDataOffset):
(JSC::ThunkHelpers::jsStringLengthOffset):
(JSC::ThunkHelpers::jsStringValueOffset):
(JSC::charCodeAtThunkGenerator):
* jit/ThunkGenerators.h: Added.
* runtime/Executable.h:
(JSC::NativeExecutable::NativeExecutable):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSFunction.h:
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::getThunk):
* runtime/JSString.h:
(JSC::):
* runtime/JSValue.h:
Protect some of the JSVALUE32 and JSVALUE32_64 only constants
and function behind appropriate USE() guards to make it harder
to use the wrong flags for the target build.
* runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::generator):
(JSC::HashEntry::):
Make the lookup tables use a specialized thunkGenerator
if present
* wtf/text/StringImpl.h:
2010-04-26 Oliver Hunt <oliver@apple.com>
Build fix
* runtime/JSImmediate.h:
* runtime/JSValue.h:
2010-04-26 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Factor some basic JS interface logic out of JIT and into a superclass
https://bugs.webkit.org/show_bug.cgi?id=38163
Create JSInterfaceJIT to hold some common low level functions for
interacting with the JS RegisterFile. Doing this separately from
https://bugs.webkit.org/show_bug.cgi?id=38155 to ease reviewing.
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):
* jit/JSInterfaceJIT.h: Added.
(JSC::JSInterfaceJIT::emitLoadJSCell):
(JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
(JSC::JSInterfaceJIT::emitLoadInt32):
(JSC::JSInterfaceJIT::tagFor):
(JSC::JSInterfaceJIT::payloadFor):
(JSC::JSInterfaceJIT::addressFor):
2010-04-26 Sam Weinig <sam@webkit.org>
Fix Tiger build.
* wtf/mac/MainThreadMac.mm:
(WTF::isMainThread):
2010-04-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/7766413>
Fixed a crash seen when using the JavaScriptCore API with WebKit.
No layout test because DumpRenderTree doesn't use the JavaScriptCore API
in this way.
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::setGlobalObject):
(JSC::RegisterFile::clearGlobalObject):
(JSC::RegisterFile::globalObject):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile): Use WeakGCPtr for managing m_globalObject,
since it's a weak pointer. (We never noticed this error before because,
in WebKit, global objects always have a self-reference in a global variable,
so marking the register file's global variables would keep m_globalObject
alive. In the JavaScriptCore API, you can allocate a global object with
no self-reference.)
* runtime/JSActivation.h: Removed unneeded #include.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject): Don't use ==, since a weak
pointer is 0 when the object it points to runs its destructor.
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::clear): Changed to return a bool indicating whether the
clear actually happened.
(JSC::WeakGCPtr::assign): Changed to forbid assignment of 0 as a shorthand
for calling clear(). A client should never clear by assigning 0, since
clear() should be conditional on whether the object doing the clearing
is still pointed to by the weak pointer. (Otherwise, a zombie object might
clear a pointer to a new, valid object.)
2010-04-25 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
Disentangle initializing the main thread from initializing threading
This is the first step in getting rid of the WEB_THREAD #define and
paving the way to allowing mac both WebKit and WebKit2 to use the same
WebCore.
* JavaScriptCore.exp: Export initializeMainThread and initializeMainThreadToProcessMainThread.
* JavaScriptCore.xcodeproj/project.pbxproj: Sort files.
* wtf/MainThread.cpp:
(WTF::mainThreadInitializationMutex):
(WTF::mainThreadFunctionQueueMutex):
(WTF::initializeMainThread):
(WTF::deprecatedInitializeMainThread):
* wtf/MainThread.h:
Added Mac only initializeMainThreadToProcessMainThread which sets up callOnMainThread
and isMainThead calls to assume that WebCore's main thread is also the
process's main thread. Since it is possible that both initializeMainThread
and initializeMainThreadToProcessMainThread could be called, the first one called
wins (either will work).
* wtf/Threading.h: Moved to top of file.
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): Remove call to initializeMainThread.
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading): Ditto.
* wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeThreading): Ditto.
* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThread):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::isMainThread):
Add runtime switch between the old behavior of using the system's main
thread and a stored pointer to the main thread. Tiger always uses the
system's main thread.
* wtf/qt/ThreadingQt.cpp:
(WTF::initializeThreading): Remove call to initializeMainThread.
* wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform): Add call to initializeCurrentThreadInternal
removed from initializeThreading.
2010-04-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix a memory leak in the QScriptString.
QScriptStringPrivate's constructor shouldn't call JSStringRetain as
QScriptConverter implicitly pass a JSStringRef ownership.
[Qt] QScriptStringPrivate c'tor problem
https://bugs.webkit.org/show_bug.cgi?id=38110
* qt/api/qscriptstring_p.h:
(QScriptStringPrivate::QScriptStringPrivate):
2010-04-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r56560): Crash in parseFloat if passed invalid UTF-16 data
https://bugs.webkit.org/show_bug.cgi?id=38083
rdar://problem/7901044
Tests: fast/js/ToNumber.html
fast/js/parseFloat.html
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt): Added a FIXME comment about a problem I noticed.
(JSC::parseFloat): Added a FIXME comment about a problem I noticed;
covered by test cases in the test I added.
* runtime/UString.cpp:
(JSC::UString::toDouble): Added FIXME comments about two problems I
noticed; covered by test cases in the tests I added. Added a return
statement so we don't crash when illegal UTF-16 sequences are present.
2010-04-24 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Adler.
Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue
Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
https://bugs.webkit.org/show_bug.cgi?id=37722
* wtf/RefPtr.h: expose hash table deleted value
2010-04-23 Sam Weinig <sam@webkit.org>
Reviewed by David Levin.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
Split up Threading.h
Move bits for of Threading.h into 3 new files.
- Atomics.h for atomic operations.
- ThreadSafeShared.h for the ThreadSafeShared class.
- ThreadingPrimitives.h for the primitives and platform types.
Basic threading operations (creation, etc.) remain in Threading.h.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Atomics.h: Copied from wtf/Threading.h.
* wtf/ThreadSafeShared.h: Copied from wtf/Threading.h.
* wtf/Threading.h:
* wtf/ThreadingPrimitives.h: Copied from wtf/Threading.h.
2010-04-23 Sam Weinig <sam@webkit.org>
Fix Qt build.
* wtf/qt/MainThreadQt.cpp: #include <QThread>
2010-04-22 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
Move isMainThread predicate function to MainThread.h
* wtf/MainThread.cpp:
(WTF::initializeMainThread):
(WTF::isMainThread):
* wtf/MainThread.h:
* wtf/Threading.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
* wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeThreading):
* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::isMainThread):
* wtf/qt/MainThreadQt.cpp:
(WTF::isMainThread):
* wtf/qt/ThreadingQt.cpp:
(WTF::initializeThreading):
* wtf/text/AtomicString.cpp:
2010-04-23 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Laszlo Gombos.
Add RVCT support for Linux
Developed in cooperation with Gabor Loki.
* API/JSStringRef.h:
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorPosix.cpp:
(JSC::ExecutableAllocator::cacheFlush):
* jit/JITStubs.cpp:
* wtf/MathExtras.h:
* wtf/unicode/qt4/UnicodeQt4.h:
2010-04-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
[WIN] Move OwnPtrWin.cpp into platform specific folder.
https://bugs.webkit.org/show_bug.cgi?id=38042
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* wtf/OwnPtrWin.cpp: Removed.
* wtf/win/OwnPtrWin.cpp: Copied from JavaScriptCore/wtf/OwnPtrWin.cpp.
2010-04-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
[BREWMP] Move OwnPtrBrew.cpp into platform specific folder.
https://bugs.webkit.org/show_bug.cgi?id=38042
* wtf/OwnPtrBrew.cpp: Removed.
* wtf/brew/OwnPtrBrew.cpp: Copied from JavaScriptCore/wtf/OwnPtrBrew.cpp.
2010-04-22 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Update Android to use isfinite, isinf, isnan and signbit from namespace std.
https://bugs.webkit.org/show_bug.cgi?id=37948
* wtf/MathExtras.h:
2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed build fix.
* wtf/MD5.cpp: fix include path of CString.h
2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
MD5 is required for WebSocket new protocol implementation
https://bugs.webkit.org/show_bug.cgi?id=37913
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/MD5.cpp: Added.
* wtf/MD5.h: Added.
2010-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Errk, accidentally committed commenting out two ASSERTs! reverting.
* runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
2010-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=38006
Change lifetime of JSC::IdentifierTables used by WebCores to match AtomicStringTable
Presently JSC's IdentifierTables are owned by the JSGlobalData. For
JSGlobalData objects created via the API this should continue to be the case,
but for the JSGlobalData objects used by WebCore (the main thread's common
global data, and those for workers) use a IdentifierTable provided (and owned)
by wtfThreadData. This allow the lifetime of these IdentifierTable to match
those of the corresponding AtomicStringTables.
* API/APIShims.h:
(JSC::APIEntryShim::APIEntryShim):
* API/JSContextRef.cpp:
(JSContextGroupCreate):
* runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::):
(JSC::JSGlobalData::isSharedInstance):
* runtime/JSLock.cpp:
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
2010-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58110.
http://trac.webkit.org/changeset/58110
https://bugs.webkit.org/show_bug.cgi?id=38007
Caused an internal compiler error on Qt (Requested by abarth
on #webkit).
* wtf/MathExtras.h:
2010-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix).
* API/JSWeakObjectMapRefPrivate.cpp:
2010-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix).
* API/JSBase.cpp:
* API/JSCallbackObject.cpp:
2010-04-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=37978
Unify JSC::IdentifierTable and WebCore::AtomicStringTable implementations.
These two classes both implement a HashSet of uniqued StringImpls, with
translator classes to avoid unnecessary object creation. The only difference
between the classes is which flag (isIdentifier or inTable) is set.
Combine the two classes using a template predicated on which flag to use.
New class AtomicStringTable created, containing all the goodness from
IdentifierTable & AtomicStringTable, expect for Identifier's literalTable,
which has been moved onto JSGlobalData. Removed duplicate string translator
classes. Renamed StringImpl's inTable flag to more explicit 'isAtomic',
and set this on the empty string (which matches Identifier behaviour, and
removes a redundant check for zero-length).
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Identifier.cpp:
(JSC::createLiteralTable):
(JSC::deleteLiteralTable):
(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):
* runtime/Identifier.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
* wtf/WTFThreadData.h:
(WTF::WTFThreadData::atomicStringTable):
* wtf/text/AtomicString.cpp:
(WebCore::table):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):
* wtf/text/AtomicStringTable.h: Added.
(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::UCharBufferTranslator::hash):
(WTF::UCharBufferTranslator::equal):
(WTF::UCharBufferTranslator::translate):
(WTF::HashAndCharactersTranslator::hash):
(WTF::HashAndCharactersTranslator::equal):
(WTF::HashAndCharactersTranslator::translate):
(WTF::IdentifierOrAtomicStringTable::remove):
(WTF::::~IdentifierOrAtomicStringTable):
(WTF::::add):
(WTF::::find):
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):
(WebCore::equal):
* wtf/text/StringImplBase.h:
(WTF::StringImplBase::StringImplBase):
2010-04-22 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Update Android to use isfinite, isinf, isnan and signbit from namespace std.
https://bugs.webkit.org/show_bug.cgi?id=37948
* wtf/MathExtras.h:
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove dependency of JSC to QtGui
https://bugs.webkit.org/show_bug.cgi?id=37867
The patch also make sure that hal.h is in the include path on Symbian.
The dependency to QtGui took care of that before.
Patch by Thiago Macieira <thiago.macieira@nokia.com>
and Rohan McGovern <rohan.mcgovern@nokia.com>
* JavaScriptCore.pri:
* JavaScriptCore.pro:
2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Corrects symbols visibility for JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=37867
* JavaScriptCore.pro:
2010-04-22 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Use BLX and BX to keep happy the return stack predictor above ARMv4
https://bugs.webkit.org/show_bug.cgi?id=37862
Inspired by Jacob Bramley's patch from JaegerMonkey
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::bx):
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::getLdrImmAddress):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::jump):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::ret):
(JSC::MacroAssemblerARM::prepareCall):
(JSC::MacroAssemblerARM::call32):
2010-04-21 Andy Estes <aestes@apple.com>
Rubber stamped by Mark Rowe.
Export WTF::deleteOwnedPtr(HFONT).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-04-21 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Oliver Hunt.
Make SmallStrings store an array of RefPtr<StringImpl>,
instead of a direct array of StringImpls. This allows
us to remove a friend (and a layering violation) from
WTF::StringImpl, and makes it so that all StringImpls
are individually heap allocated.
* runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::rep):
(JSC::SmallStringsStorage::SmallStringsStorage):
* wtf/text/StringImpl.h:
2010-04-21 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix for https://bugs.webkit.org/show_bug.cgi?id=37937
Wean JavaScriptCore off calls to isMainThread()
- Replace use of isMainThread() for interpreter reentry checks
with a stored value on the JSGlobalData.
- Replace use of isMainThread() for useMainThread only check in the
collector with a stored exclusive thread.
* API/JSContextRef.cpp:
(JSContextGroupCreate):
Always default to a small stack type for uses of the JSC API. It is
unlikely that the interpreter reentry required on the web will be as
important for other uses of JavaScriptCore.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Update exports.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
Use new stored JSGlobalData::maxReentryDepth instead of isMainThread().
* interpreter/Interpreter.h:
Rename MaxMainThreadReentryDepth to MaxLargeThreadReentryDepth and
MaxSecondaryThreadReentryDepth to MaxSmallThreadReentryDepth.
* jsc.cpp:
(main): Use the a large stack for jsc since it is always using the
main thread.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
Use new stored JSGlobalData::maxReentryDepth instead of isMainThread().
* runtime/Collector.cpp:
(JSC::Heap::registerThread):
Use the concept of making JSC run on an exclusiveThread instead of
forcing a mainThreadOnly assertion.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):
* runtime/JSGlobalData.h:
Add ThreadStackType argument to JSGlobalData constructors and set
maxReentryDepth based on it.
2010-04-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix pt. 3).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-04-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix pt. 2).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-04-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Qt build fix).
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* wtf/qt/StringQt.cpp: Copied from WebCore/platform/text/qt/StringQt.cpp.
2010-04-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix).
* API/JSValueRef.cpp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
* runtime/Identifier.h:
* wtf/WTFThreadData.h:
(JSC::IdentifierTable::remove):
(JSC::IdentifierTable::literalTable):
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt, Darin Adler.
Bug 37906 - Remove JSC::UStringImpl; unify with StringImpl.
JSC::UStringImpl and WebCore::StringImpl (soon to be renamed to
WTF::StringImpl) are almost identical. Remove duplication of code by unifying
the two, move missing features from UStringImpl into StringImpl & delete the
class UStringImpl.
* API/JSClassRef.cpp:
* API/JSContextRef.cpp:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.pro:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/EvalCodeCache.h:
* bytecode/JumpTable.cpp:
* profiler/ProfileNode.cpp:
* runtime/Identifier.cpp:
(JSC::Identifier::add):
* runtime/Identifier.h:
(JSC::Identifier::equal):
* runtime/UString.cpp:
* runtime/UString.h:
(WTF::):
* runtime/UStringImpl.cpp: Removed.
* runtime/UStringImpl.h:
* wtf/text/StringHash.h:
(WebCore::StringHash::equal):
(WebCore::CaseFoldingHash::equal):
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::empty):
(WebCore::StringImpl::sharedBuffer):
(WebCore::equal):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):
(WebCore::StringImpl::cost):
(WebCore::StringImpl::isIdentifier):
(WebCore::StringImpl::setIsIdentifier):
(WebCore::StringImpl::computeHash):
(WebCore::StringImpl::copyChars):
(WebCore::StringImpl::):
2010-04-21 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Added missing #include "Lookup.h" in LUT source files.
https://bugs.webkit.org/show_bug.cgi?id=37903
* runtime/ArrayPrototype.cpp:
* runtime/DatePrototype.cpp:
* runtime/JSONObject.cpp:
* runtime/MathObject.cpp:
* runtime/NumberConstructor.cpp:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpObject.cpp:
* runtime/StringPrototype.cpp:
2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
Reviewed by Nikolas Zimmermann.
Add missing EFL JavaScriptCore file.
http://webkit.org/b/37854
* wtf/efl: Added.
* wtf/efl/MainThreadEfl.cpp: Added.
(WTF::initializeMainThreadPlatform):
(WTF::timeoutFired):
(WTF::scheduleDispatchFunctionsOnMainThread):
2010-04-20 Xan Lopez <xlopez@igalia.com>
Another attempt to fix the build.
* GNUmakefile.am:
2010-04-20 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
[ES5] RegExp literals are constants that should be persistent across multiple function calls.
https://bugs.webkit.org/show_bug.cgi?id=37908
Dump the separate RegExp constant pool, and just use the standard JS constant pool
in codeblock. This allows us to drop op_new_regexp and all associated code as well.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoad):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
* jit/JITStubs.cpp:
* jit/JITStubs.h:
(JSC::):
2010-04-20 Oliver Hunt <oliver@apple.com>
Fix license on create_regex_tables
* create_regex_tables:
2010-04-20 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Fix gtk
* GNUmakefile.am:
* make-generated-sources.sh:
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 37895 - Share common code from UStringImplBase with StringImpl
The implementation of StringImpl & UStringImpl is very similar. Restructure
StringImpl to match UStringImpl, moving the flags and length into a base class,
so that this can be shared between both string types to increase code reuse.
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RopeImpl.h:
(JSC::RopeImpl::RopeImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::UStringImpl):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::characters):
* wtf/text/StringImplBase.h: Copied from JavaScriptCore/runtime/UStringImpl.h.
(WTF::StringImplBase::length):
(WTF::StringImplBase::operator new):
(WTF::StringImplBase::StringImplBase):
2010-04-20 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Autogenerate yarr character tables
https://bugs.webkit.org/show_bug.cgi?id=37877
Use a python script to automatically generate character tables
for the builtin YARR character classes. This allows us to generate
actual tables as well, by using these tables we can both increase
performance of the check (for complex builtins) and reduce the actual
code size.
4-8% win on string-unpack-code, but lots of noise on other tests so
i'm only confident saying its a 1% win overall.
* DerivedSources.make:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::ExtendedAddress::ExtendedAddress):
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::branchTest8):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchTest8):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchTest8):
* assembler/X86Assembler.h:
(JSC::X86Assembler::cmpb_im):
(JSC::X86Assembler::testb_im):
* bytecode/SamplingTool.cpp:
(JSC::SamplingTool::dump):
* create_regex_tables: Added.
* yarr/RegexCompiler.cpp:
(JSC::Yarr::CharacterClassConstructor::charClass):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::matchCharacterClass):
(JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
* yarr/RegexPattern.h:
(JSC::Yarr::CharacterClassTable::create):
(JSC::Yarr::CharacterClassTable::CharacterClassTable):
(JSC::Yarr::CharacterClass::CharacterClass):
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (speculative windows fix - missed a bit!).
* wtf/text/AtomicString.h:
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (speculative windows fix).
* wtf/text/AtomicString.h:
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix).
Add missing .def file entries.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 37869 - Move URopeImpl to its own .h/.cpp
Currently Ropes are implemented by the class URopeImpl, which is defined in
UStringImpl.h, and then typedefed to the name JSString::Rope. Remove the
typedef, and rename all uses of URopeImpl and JSString::Rope to just RopeImpl.
Move RopeImpl to its own header, and remove all remaining references to ropes
from UStringImpl (rename UStringOrRopeImpl to UStringImplBase, rename or move
the isRope & deref methods from UStringOrRopeImpl).
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
* runtime/JSString.h:
(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::JSStringFinalizerStruct::):
* runtime/RopeImpl.cpp: Copied from JavaScriptCore/runtime/UStringImpl.cpp.
(JSC::RopeImpl::derefFibersNonRecursive):
(JSC::RopeImpl::destructNonRecursive):
* runtime/RopeImpl.h: Copied from JavaScriptCore/runtime/UStringImpl.h.
(JSC::RopeImpl::tryCreateUninitialized):
(JSC::RopeImpl::isRope):
(JSC::RopeImpl::deref):
(JSC::RopeImpl::RopeImpl):
* runtime/UStringImpl.cpp:
* runtime/UStringImpl.h:
(JSC::UStringImplBase::isInvalid):
(JSC::UStringImplBase::ref):
(JSC::UStringImplBase::UStringImplBase):
(JSC::UStringImplBase::):
(JSC::UStringImpl::UStringImpl):
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 37828 - Move WebCore's String classes to WTF
Move these classes up to WTF so they are available to all clients of WTF (in
particular JSC).
As a first patch, making the most minimal change possible, since this patch
could easily grow rather large since we'll have to change every class forward
declaration ( e.g. every "namespace WebCore { class String; }" much change to
"namespace WTF { class String; }").
Moving the files, but leaving the classes logically in the WebCore namespace -
which is technically a layering violation - I'll come back and fix this up in a
subsequent patch.
* Android.mk:
* Android.v8.wtf.mk:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* config.h:
* wtf/StaticConstructors.h: Copied from WebCore/platform/StaticConstructors.h.
* wtf/text/AtomicString.cpp: Copied from WebCore/platform/text/AtomicString.cpp.
* wtf/text/AtomicString.h: Copied from WebCore/platform/text/AtomicString.h.
* wtf/text/AtomicStringImpl.h: Copied from WebCore/platform/text/AtomicStringImpl.h.
* wtf/text/StringBuffer.h: Copied from WebCore/platform/text/StringBuffer.h.
* wtf/text/StringHash.h: Copied from WebCore/platform/text/StringHash.h.
* wtf/text/StringImpl.cpp: Copied from WebCore/platform/text/StringImpl.cpp.
* wtf/text/StringImpl.h: Copied from WebCore/platform/text/StringImpl.h.
* wtf/text/WTFString.cpp: Copied from WebCore/platform/text/String.cpp.
(WebCore::charactersToFloat):
* wtf/text/WTFString.h: Copied from WebCore/platform/text/PlatformString.h.
2010-04-20 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed speculative buildfix for WinCE after r57882
https://bugs.webkit.org/show_bug.cgi?id=37701
* JavaScriptCore.pri: missing wince* case added.
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Speculative Chromium/Win build fix, attempt #2.
* config.h:
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Speculative Chromium/Win build fix.
* config.h: JS_EXPORTDATA should do nothing on !JSC builds.
2010-04-20 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Target(WebCore,jsc,...) must depends on static library of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=37701
* JavaScriptCore.pri: dependency added.
2010-04-20 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Maciej Stachowiak (relanding r57829).
Added missing JS_EXPORTDATA
* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
* API/JSContextRef.cpp:
* Android.mk:
* Android.v8.wtf.mk:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
* runtime/Identifier.h:
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
* wtf/WTFThreadData.cpp: Copied from JavaScriptCore/wtf/WTFThreadData.cpp.
* wtf/WTFThreadData.h: Copied from JavaScriptCore/wtf/WTFThreadData.h.
2010-04-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (rolling out r57829).
This broke windows.
* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
* API/JSContextRef.cpp:
* Android.mk:
* Android.v8.wtf.mk:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
* runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
* wtf/WTFThreadData.cpp: Removed.
* wtf/WTFThreadData.h: Removed.
2010-04-19 Douglas Gregor <dgregor@apple.com>
Reviewed and landed by Anders Carlsson.
* runtime/UStringImpl.h:
Fix class/struct declaration mismatches.
2010-04-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Beth Dakin.
Checked in these tests I wrote becuase Balazs Kelemen wanted to use them.
* tests/perf: Added.
* tests/perf/bench-allocate-nonretained.js: Added.
* tests/perf/bench-allocate-retained.js: Added.
2010-04-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-04-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=37745
Move string uniquing tables to (new) WTFThreadData class.
Remove AtomicString's dependency on ThreadGlobalData so that we can move
WebCore's string classes up to WTF.
WTFThreadData.cpp/.h are based on ThreadGlobalData from WebCore.
Moved JSC & WebCore's string uniquing tables to this class.
This patch introduces a temporary layering violation in providing forward
declarations of classes from JSC and WTF; this will be resolved as we move
more string code up to WTF.
* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
* API/JSContextRef.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
* runtime/Identifier.h:
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
* wtf/WTFThreadData.cpp: Copied from WebCore/platform/ThreadGlobalData.cpp.
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
* wtf/WTFThreadData.h: Copied from WebCore/platform/ThreadGlobalData.h.
(WTF::WTFThreadData::atomicStringTable):
(WTF::WTFThreadData::initializeIdentifierTable):
(WTF::WTFThreadData::currentIdentifierTable):
(WTF::WTFThreadData::setCurrentIdentifierTable):
(WTF::WTFThreadData::resetCurrentIdentifierTable):
(WTF::wtfThreadData):
2010-04-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Build fix for WinCE.
Moved the include of the non-existing errno.h header file inside
platform guard macros.
* jit/ExecutableAllocatorFixedVMPool.cpp:
2010-04-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
[WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1
https://bugs.webkit.org/show_bug.cgi?id=37434
Windows CE supports little-endian format only, so don't define
WTF_CPU_MIDDLE_ENDIAN=1.
* wtf/Platform.h:
2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix JavaScriptCore's include path for WinCE builds
https://bugs.webkit.org/show_bug.cgi?id=36751
* JavaScriptCore.pri:
2010-04-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by nobody, build fix.
2010-04-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by nobody, build fix.
2010-04-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).
Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.
* JavaScriptCore.exp:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:
2010-04-15 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix memory leak in QScriptEngine::evaluate().
QScriptEnginePrivate::evaluate should release temporary variables.
[Qt] QScriptEngine::evaluate has memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37596
* qt/api/qscriptengine_p.cpp:
(QScriptEnginePrivate::evaluate):
* qt/api/qscriptengine_p.h:
2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix a memory leak in QScriptValue::inherits.
[Qt] QScriptValue::inherits has a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37617
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::inherits):
2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix a few memory leaks in QScriptEngine.
Syntax checking caused memory leak, not all temporary variables were released.
[Qt] Syntax checking in the QtScript cause a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37610
* qt/api/qscriptengine_p.cpp:
(QScriptEnginePrivate::checkSyntax):
* qt/api/qscriptsyntaxcheckresult.cpp:
(QScriptSyntaxCheckResultPrivate::errorMessage):
(QScriptSyntaxCheckResultPrivate::errorLineNumber):
2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix memory leak inside QScriptEnginePrivate::makeJSValue.
QScriptEnginePrivate::makeJSValue should release temporary JSStringRef variable.
[Qt] tst_QScriptValue::toString has a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37598
* qt/api/qscriptengine_p.h:
(QScriptEnginePrivate::makeJSValue):
2010-04-14 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Geoffrey Garen.
Move the YARR JIT fallback detection from RegexJIT.cpp to
RegexCompiler.cpp.
https://bugs.webkit.org/show_bug.cgi?id=37571
* yarr/RegexCompiler.cpp:
(JSC::Yarr::RegexPatternConstructor::atomBackReference):
(JSC::Yarr::RegexPatternConstructor::quantifyAtom):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateTerm):
(JSC::Yarr::RegexGenerator::RegexGenerator):
(JSC::Yarr::jitCompileRegex):
* yarr/RegexJIT.h:
(JSC::Yarr::RegexCodeBlock::operator!):
* yarr/RegexPattern.h:
(JSC::Yarr::RegexPattern::RegexPattern):
(JSC::Yarr::RegexPattern::reset):
2010-04-14 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Maciej Stachowiak.
Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888
When building on (Snow) Leopard but targeting Tiger
(TARGETING_TIGER defined, BUILDING_ON_TIGER not defined),
WebKit would crash on Tiger because the tags passed to mmap
caused those function calls to fail.
Conversely, when building on Tiger but targeting Leopard
(BUILDING_ON_TIGER defined, TARGETING_LEOPARD defined), WebKit
would crash on Leopard because the tags passed to vm_map and
vm_allocate caused those function calls to fail.
Solution: Use TARGETING_TIGER rather than BUILDING_ON_TIGER to
govern the tag definitions. Use the same tags for vm_map and
vm_allocate regardless of target, since they work on
both. Fall back to the mmap tags that work on Tiger (that is,
"no tags") if targeting Tiger, since those tags also work on
Leopard.
* wtf/VMTags.h:
2010-04-12 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by nobody, build fix.
[Qt] Build fix for Mac when building with build-webkit --qt
Specifying no configuration on Mac builds WebCore both in debug
and release. JavaScriptCore has to follow this rule as well.
* JavaScriptCore.pro:
2010-04-11 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/7851332> Fix the build.
* wtf/FastMalloc.cpp:
(WTF::TCMallocStats::): Initialize extra members of malloc_introspection_t to zero.
2010-04-09 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Make CallIdentifier constructor to handle null urls.
https://bugs.webkit.org/show_bug.cgi?id=37341
* profiler/CallIdentifier.h:
(JSC::CallIdentifier::CallIdentifier):
2010-04-09 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix crashes with package builds in release
Add NDEBUG to the defines for package build in JavaScriptCore.pri,
so that it's consistently used for JavaScriptCore, WebCore, jsc and all
other tools using wtf, etc. data structures directly. Mixing NDEBUG with
non-NDEBUG builds causes crashes due to differences in data structures when
assertions/checks are enabled.
* JavaScriptCore.pri:
2010-04-09 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Implement NO_RETURN for COMPILER(MSVC).
https://bugs.webkit.org/show_bug.cgi?id=33056
Added NO_RETURN_WITH_VALUE for functions with non-void return type.
* jsc.cpp:
* wtf/AlwaysInline.h:
* wtf/FastMalloc.cpp:
2010-04-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Simon Hausmann.
[WINCE] Check if ARM or _ARM_ is defined
https://bugs.webkit.org/show_bug.cgi?id=37200
MSVC defines ARM and _ARM_ for Windows CE ARM. Define WTF_CPU_ARM=1
when either ARM or _ARM_ is defined.
* wtf/Platform.h:
2010-04-08 Csaba Osztrogonác <ossy@webkit.org>
Reviewed Oliver Hunt.
[Qt]r57240 broke Qt build (might be a gcc bug)
https://bugs.webkit.org/show_bug.cgi?id=37253
Workaround until fix. On PLATFORM(QT) use inline instead of ALWAYS_INLINE.
* wtf/PassRefPtr.h: Qt guards added.
2010-04-07 Oliver Hunt <oliver@apple.com>
Reviewed by Anders Carlsson.
Vector<UString> makes many needless calls to UString::UString and UString::~UString
Add a VectorTrait<UString> specialisation to allow vector to simply memset/memcpy
data around. Only difference from the VectorTrait<RefPtr<T> > traits is the inability
to use memset to initialize data.
* runtime/UString.h:
(WTF::):
2010-04-07 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Beat gcc with a clue bat -- force inlining of refIfNotNull and derefIfNotNull
* wtf/PassRefPtr.h:
2010-04-07 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Replace isprint with isASCIIPrintable
https://bugs.webkit.org/show_bug.cgi?id=37223
WebKit does not use functions in <ctype.h> as they are dependent on the current
locale. Use the equivalent functions in <wtf/ASCIICType.h>. isASCIIPrintable
replaces isprint.
* pcre/pcre_exec.cpp:
(pchars):
2010-04-07 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37219
This change disables text caret for the iPhone platflorm.
* wtf/Platform.h: Disabled text caret for iPhone.
2010-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646
Add a new exception type for forcibly terminating a JavaScript stack.
The new exception functions similarly to the
InterruptedExecutionException but is conceptually different because
execution is terminated instead of just interrupted.
* GNUmakefile.am:
- Added new Terminator.h file.
* JavaScriptCore.gypi:
- Added new Terminator.h file.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- Added new Terminator.h file.
* JavaScriptCore.xcodeproj/project.pbxproj:
- Added new Terminator.h file.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
- Fully unwind the stack for TerminatedExecutionException.
(JSC::Interpreter::privateExecute):
- Check if we've been terminated at the same time we check if we've
timed out.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Check if we've been terminated at the same time we check if we've
timed out.
* runtime/Completion.cpp:
- Some exceptions define special completion types so that calls can
see why we terminated evaluation.
(JSC::evaluate):
* runtime/Completion.h:
- Define a new completion type for termination.
(JSC::):
* runtime/ExceptionHelpers.cpp:
- Define TerminatedExecutionException and refactor pseudo-RTTI
virtual function to be more semantic.
(JSC::InterruptedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::toString):
(JSC::createTerminatedExecutionException):
* runtime/ExceptionHelpers.h:
- Entry point for generating a TerminatedExecutionException.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- Add a Terminator object that can be used to asynchronously
terminate a JavaScript execution stack.
* runtime/JSGlobalData.h:
* runtime/JSObject.h:
(JSC::JSObject::exceptionType):
- Define that, by default, thrown objects have a normal exception
type.
* runtime/Terminator.h: Added.
- Added a new controller object that can be used to terminate
execution asynchronously. This object is more or less a
glorified bool.
(JSC::Terminator::Terminator):
(JSC::Terminator::termianteSoon):
(JSC::Terminator::shouldTerminate):
2010-04-05 Oliver Hunt <oliver@apple.com>
And another one.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
2010-04-05 Oliver Hunt <oliver@apple.com>
And another build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
2010-04-05 Oliver Hunt <oliver@apple.com>
Build fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
2010-04-05 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Support weak maps in JSC
https://bugs.webkit.org/show_bug.cgi?id=37132
Expose an API to allow creation of a map for storing
weak JS references.
* API/JSWeakObjectMapRefInternal.h: Added.
(OpaqueJSWeakObjectMap::create):
(OpaqueJSWeakObjectMap::map):
(OpaqueJSWeakObjectMap::~OpaqueJSWeakObjectMap):
(OpaqueJSWeakObjectMap::OpaqueJSWeakObjectMap):
* API/JSWeakObjectMapRefPrivate.cpp: Added.
* API/JSWeakObjectMapRefPrivate.h: Added.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::registerWeakMap):
(JSC::JSGlobalObject::deregisterWeakMap):
2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Symbian] Consolidate Symbian WINSCW environment configuration
https://bugs.webkit.org/show_bug.cgi?id=37100
Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.
PLATFORM(WIN) and OS(WIN) no longer needs to be undefined as
undefining WIN32 takes care of it.
* wtf/Platform.h:
2010-04-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=37068
Change UString to use a 0 rep for null strings instead of a null object.
No performance impact.
* JavaScriptCore.exp:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
* runtime/UString.cpp:
(JSC::initializeUString):
* runtime/UString.h:
(JSC::UString::UString):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::cost):
2010-04-03 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Fix uninitalised members in CallLinkInfo and BytecodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=36816
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(JSC::CallLinkInfo::CallLinkInfo):
2010-04-03 yael aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961
* Configurations/FeatureDefines.xcconfig:
2010-04-02 Ruben Van Boxem <vanboxem.ruben@gmail.com>
Reviewed by Eric Seidel.
Mingw-w64 fixes for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=35607
* runtime/Collector.cpp: use the msvc code for mingw-w64 (but not mingw-w32)
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlockPtr):
(JSC::currentThreadStackBase):
(JSC::currentThreadStackBase):
* wtf/Platform.h: added COMPILER(MINGW64) check to differentiate between mingw.org and mingw-w64 functions
2010-04-02 Geoffrey Garen <ggaren@apple.com>
Build fix: updated the .def file.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-04-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Inlined toThisString and toThisJSString to avoid virtual function call overhead
https://bugs.webkit.org/show_bug.cgi?id=37039
Maybe a 1% speedup on iBench JS.
* JavaScriptCore.exp: New exports.
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSNumberCell.cpp:
* runtime/JSNumberCell.h:
* runtime/JSString.cpp:
* runtime/JSString.h:
* runtime/JSValue.h:
* runtime/JSZombie.h:
(JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.
* runtime/JSObject.h:
(JSC::JSValue::toThisString):
(JSC::JSValue::toThisJSString): Added the inlined implementation.
2010-04-02 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Geoffrey Garen.
Beef up documentation for ASSERT* and CRASH macros a bit.
https://bugs.webkit.org/show_bug.cgi?id=36527
* wtf/Assertions.h:
2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, minor build fix.
Change the order of the member initialisation list
in constructor to match declaration order
* runtime/Collector.cpp:
(JSC::Heap::Heap):
2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dmitry Titov.
Add FileThread for async file operation support in FileReader and FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36896
Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.
* Configurations/FeatureDefines.xcconfig:
2010-03-31 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix pt II).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-31 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-31 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 36871 - Remove JSC::CString
Use WTF::CString instead (which until recently was WebCore::CString).
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/UString.cpp:
* runtime/UString.h:
2010-03-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, fix after r56842.
Add UNUSED_PARAM a to silence warning.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
2010-03-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, Symbian build fix.
Refactor JITStubs.cpp so that the list of STUB_FUNCTIONs
are not dependent on the JSVALUE32_64 guard.
* jit/JITStubs.cpp: Place the JSVALUE32_64 guard inside
the body of cti_op_eq_strings.
* jit/JITStubs.h: Remove JSVALUE32_64 guard from
cti_op_eq_strings stub.
2010-03-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix).
Fixing b0rked version of JavaScriptCore.vcproj - added lines were truncated.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
2010-03-30 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=36866
Move CString to WTF
* Android.mk:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/text: Added.
* wtf/text/CString.cpp: Copied from WebCore/platform/text/CString.cpp.
* wtf/text/CString.h: Copied from WebCore/platform/text/CString.h.
(WTF::CStringBuffer::data):
(WTF::CStringBuffer::length):
(WTF::CStringBuffer::create):
(WTF::CStringBuffer::CStringBuffer):
(WTF::CStringBuffer::mutableData):
(WTF::CString::CString):
(WTF::CString::isNull):
(WTF::CString::buffer):
(WTF::operator!=):
2010-03-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by nobody, build break.
[Qt] Fix build break on Qt Mac.
DESTDIR path on Mac do not include the configuration path by default
like on Windows. Have to force it.
* JavaScriptCore.pro:
2010-03-29 Alice Liu <alice.liu@apple.com>
Reviewed by NOBODY (build fix).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
add JSObjectRefPrivate.h
2010-03-29 Chao-ying Fu <fu@mips.com>
Reviewed by Oliver Hunt.
MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144
The following changes enable MIPS JIT.
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::lbu):
(JSC::MIPSAssembler::linkWithOffset):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load8):
(JSC::MacroAssemblerMIPS::branch8):
(JSC::MacroAssemblerMIPS::branchTest8):
(JSC::MacroAssemblerMIPS::setTest8):
(JSC::MacroAssemblerMIPS::setTest32):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::preserveReturnAddressAfterCall):
(JSC::JIT::restoreReturnAddressBeforeReturn):
* jit/JITOpcodes.cpp:
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
(JSC::JITStackFrame::returnAddressSlot):
* wtf/Platform.h:
2010-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Fraser.
Add support for Widgets 1.0: View Mode Media Feature
https://bugs.webkit.org/show_bug.cgi?id=35446
Add an enable flag for the Widgets (http://www.w3.org/TR/widgets-reqs/)
and turn it on for Qt only.
* wtf/Platform.h:
2010-03-29 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Corrected name of (u)int64_t compile time assert.
https://bugs.webkit.org/show_bug.cgi?id=36739
int64_t_is_four_bytes -> int64_t_is_eight_bytes
* os-win32/stdint.h:
2010-03-29 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Use the -l syntax for linking against JavaScriptCore on Windows.
This allow qmake to extract dependencies correctly when generating VS
solutions.
* JavaScriptCore.pri:
2010-03-29 Thomas Zander <t.zander@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=36742
gcc for Symbian doesn't support gcc extensions like atomicity.h - disable
* wtf/Threading.h: also detect os symbian
2010-03-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Remove the definition of WTF_CHANGES guards from the build system
https://bugs.webkit.org/show_bug.cgi?id=31670
* JavaScriptCore.pro: Remove the definition of WTF_CHANGES
as it is already defined in config.h
2010-03-28 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Add API for reporting additional memory cost of JavaScript objects
https://bugs.webkit.org/show_bug.cgi?id=36650
* qt/api/qscriptengine.cpp:
(QScriptEngine::reportAdditionalMemoryCost):
* qt/api/qscriptengine.h:
* qt/api/qscriptengine_p.h:
(QScriptEnginePrivate::reportAdditionalMemoryCost):
* qt/tests/qscriptengine/tst_qscriptengine.cpp:
(tst_QScriptEngine::reportAdditionalMemoryCost):
2010-03-28 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QScriptEngine API was enriched by globalObject() method
which give an access to the global object.
[Qt] QScriptEngine doesn't give an access to global object
https://bugs.webkit.org/show_bug.cgi?id=36603
* qt/api/qscriptengine.cpp:
(QScriptEngine::globalObject):
* qt/api/qscriptengine.h:
* qt/api/qscriptengine_p.cpp:
(QScriptEnginePrivate::globalObject):
* qt/api/qscriptengine_p.h:
* qt/tests/qscriptengine/tst_qscriptengine.cpp:
(tst_QScriptEngine::globalObject):
2010-03-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Build JavaScriptCore as a static library.
https://bugs.webkit.org/show_bug.cgi?id=36590
This patch takes what was left of the unused JavaScriptCore.pro
and moved the compilation logic from JavaScriptCore.pri to
JavaScriptCore.pro.
* JavaScriptCore.pri:
* JavaScriptCore.pro:
* jsc.pro:
* qt/api/QtScript.pro:
2010-03-25 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
2010-03-25 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 36611 - Cleanup JSC::CString
Rename CString::c_str() -> CString::data(), CString::size() -> CString::length(),
remove UString::getCString() (all uses are wrong, should use UString::UTF8String()).
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
* jsc.cpp:
(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):
* profiler/CallIdentifier.h:
(JSC::CallIdentifier::c_str):
* profiler/Profile.cpp:
(JSC::Profile::debugPrintDataSampleStyle):
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
* runtime/DateConversion.cpp:
(JSC::parseDate):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncJSCPrint):
* runtime/UString.cpp:
(JSC::operator==):
(JSC::UString::toDouble):
* runtime/UString.h:
(JSC::CString::length):
(JSC::CString::data):
2010-03-25 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by nobody, build fix.
[Qt] Build fix on MSVC. Reverts r55633 for stdint.h
This file gets included in generated moc files which don't
include the prefix header.
* os-win32/stdint.h:
2010-03-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (windows build fix).
2010-03-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.
* JavaScriptCore.exp:
2010-03-24 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoff Garen.
* wtf/FastMalloc.h: Added a using directive for fastMallocSize, like we do for all public
WTF symbols. Also sorted the list alphabetically.
2010-03-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (speculative windows build fix part II).
2010-03-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (speculative windows build fix).
2010-03-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 36519 - JSGlobalContextRelease is unnecessarily slow
Since [ http://trac.webkit.org/changeset/35917 ], calling
JSGlobalContextRelease always triggers a GC heap collection
(if not a full destroy). As per 35917's changelog "This is
only really necessary when the (JSGlobalObject's) last
reference is released, but there is no way to determine that,
and no harm in collecting slightly more often."
Well, we now know of cases of API clients who are harmed by
the performance penalty of collecting too often, so it's time
to add a way to determine whether a call to JSGlobalContextRelease
is removing the last protect from it's global object. If further
protects are retaining the global object (likely from other
JSGlobalContextRefs), then don't trigger a GC collection.
* API/JSContextRef.cpp:
* runtime/Collector.cpp:
(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.
* runtime/Collector.h:
* wtf/HashCountedSet.h:
(WTF::::remove): return a boolean indicating whether the value was removed from the set.
2010-03-23 Mark Rowe <mrowe@apple.com>
Build fix.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice): Some versions of GCC emit a warning about the implicit 64- to 32-bit truncation
that takes place here. An explicit cast is sufficient to silence it.
2010-03-23 Alexey Proskuryakov <ap@apple.com>
Build fix.
* runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): Fixed a typo - length doesn't
need to be converted with toInteger().
2010-03-23 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=36511
<rdar://problem/7753498> Safari freezes when using SPUTNIK JavaScript conformance check
Test: fast/js/sputnik-S15.4.4.12_A3_T3.html
* runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): We were incorrectly computing
the start offset, and iterated over (almost) all integers. Note that this can be fixed
without using doubles, but the code would be much more complicated, and there is no important
reason to stick to integers here.
2010-03-23 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Fix compilation on Itanium in 32-bit mode
https://bugs.webkit.org/show_bug.cgi?id=36494
* wtf/Platform.h: Introduce CPU(IA64_32). Don't define
WTF_USE_JSVALUE64 if the CPU is in 32-bit mode.
2010-03-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Interpreter fix for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Only take the fast negate path if
a bit other than bit 31 is set. If none of bits 0-30 are set, then the
value we're negating can only be 0 or -2147483648, and neither can be
negated in int space.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate): Updated the JIT implementation to match
the interpreter, since it's slightly simpler.
2010-03-22 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] More efficient aligned memory allocation for JSC Collector
https://bugs.webkit.org/show_bug.cgi?id=34350
* JavaScriptCore.pri: Added 2 new Symbian source files and HAL linkage
* runtime/Collector.cpp: Reduced port-specific code and added private data member
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlockPtr):
* runtime/Collector.h: Added private data member
* wtf/symbian: Added.
* wtf/symbian/BlockAllocatorSymbian.cpp: Added.
(WTF::AlignedBlockAllocator::AlignedBlockAllocator): Helper class to allocate
aligned blocks more efficiently as required by Collector
(WTF::AlignedBlockAllocator::alloc):
(WTF::AlignedBlockAllocator::free):
(WTF::AlignedBlockAllocator::destroy):
(WTF::AlignedBlockAllocator::~AlignedBlockAllocator):
* wtf/symbian/BlockAllocatorSymbian.h: Added.
2010-03-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)
Two ways to fix the same bug:
1. Check for overflow when negating, since negating the largest negative
int causes overflow.
2. Constant-fold even when negating a negative, since, like they say in
high school, "math works."
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchNeg32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchNeg32): Added a branching version
of the negate operator.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate): Use the branching version of the negate
operator to check for overflow.
(JSC::JIT::emitSlow_op_negate): Link the check for overflow to a slow case.
(We could emit inline code for this, since we know what the result would
be, but that's probably just a waste of generated code.)
* parser/Grammar.y: Constant fold even when negating a negative.
2010-03-22 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/36431> Clean up 'int' use in UString.cpp after r54789
Reviewed by Darin Adler.
* runtime/UString.cpp:
(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
(JSC::UString::find): Changed static_cast<int>() to
static_cast<unsigned>() now that this method returns unsigned.
(JSC::UString::rfind): Ditto.
* runtime/UString.h:
(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
2010-03-22 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Add support for syntax checking in the QtScript API.
New class was created; the QScriptSyntaxCheckResult which main
responsibility is to provide results of the ECMA Script code
syntax check. The class is not fully functional as the JSC C API
doesn't expose an error column number, but it is a good start point
for a future development.
[Qt] QtScript functionality should be extended by syntax checking.
https://bugs.webkit.org/show_bug.cgi?id=36123
* qt/api/QtScript.pro:
* qt/api/qscriptengine.cpp:
(QScriptEngine::checkSyntax):
* qt/api/qscriptengine.h:
* qt/api/qscriptengine_p.cpp:
(QScriptEnginePrivate::checkSyntax):
* qt/api/qscriptengine_p.h:
* qt/api/qscriptsyntaxcheckresult.cpp: Added.
(QScriptSyntaxCheckResult::QScriptSyntaxCheckResult):
(QScriptSyntaxCheckResult::~QScriptSyntaxCheckResult):
(QScriptSyntaxCheckResult::operator=):
(QScriptSyntaxCheckResult::state):
(QScriptSyntaxCheckResult::errorLineNumber):
(QScriptSyntaxCheckResult::errorColumnNumber):
(QScriptSyntaxCheckResult::errorMessage):
* qt/api/qscriptsyntaxcheckresult.h: Added.
* qt/api/qscriptsyntaxcheckresult_p.cpp: Added.
(QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate):
(QScriptSyntaxCheckResultPrivate::errorMessage):
(QScriptSyntaxCheckResultPrivate::errorLineNumber):
* qt/api/qscriptsyntaxcheckresult_p.h: Added.
(QScriptSyntaxCheckResultPrivate::get):
(QScriptSyntaxCheckResultPrivate::QScriptSyntaxCheckResultPrivate):
(QScriptSyntaxCheckResultPrivate::state):
(QScriptSyntaxCheckResultPrivate::errorColumnNumber):
* qt/tests/qscriptengine/tst_qscriptengine.cpp:
(tst_QScriptEngine::checkSyntax_data):
(tst_QScriptEngine::checkSyntax):
2010-03-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
New class; QScriptProgram.
The class should be used to evaluate the same script multiple times
more efficiently.
[Qt] QtScript should have QScriptProgram class
https://bugs.webkit.org/show_bug.cgi?id=36008
* qt/api/QtScript.pro:
* qt/api/qscriptengine.cpp:
(QScriptEngine::evaluate):
* qt/api/qscriptengine.h:
* qt/api/qscriptengine_p.cpp:
(QScriptEnginePrivate::evaluate):
* qt/api/qscriptengine_p.h:
(QScriptEnginePrivate::evaluate):
* qt/api/qscriptprogram.cpp: Added.
(QScriptProgram::QScriptProgram):
(QScriptProgram::~QScriptProgram):
(QScriptProgram::operator=):
(QScriptProgram::isNull):
(QScriptProgram::sourceCode):
(QScriptProgram::fileName):
(QScriptProgram::firstLineNumber):
(QScriptProgram::operator==):
(QScriptProgram::operator!=):
* qt/api/qscriptprogram.h: Added.
* qt/api/qscriptprogram_p.h: Added.
(QScriptProgramPrivate::get):
(QScriptProgramPrivate::QScriptProgramPrivate):
(QScriptProgramPrivate::~QScriptProgramPrivate):
(QScriptProgramPrivate::isNull):
(QScriptProgramPrivate::sourceCode):
(QScriptProgramPrivate::fileName):
(QScriptProgramPrivate::firstLineNumber):
(QScriptProgramPrivate::operator==):
(QScriptProgramPrivate::operator!=):
(QScriptProgramPrivate::program):
(QScriptProgramPrivate::file):
(QScriptProgramPrivate::line):
* qt/tests/qscriptengine/tst_qscriptengine.cpp:
(tst_QScriptEngine::evaluateProgram):
2010-03-21 David Kilzer <ddkilzer@apple.com>
Blind attempt #2 to fix the Windows build after r56314
* API/tests/testapi.c: Include JSObjectRefPrivate.h for the new
methods instead of declaring them locally (and non-extern).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Backed out previous change.
2010-03-21 David Kilzer <ddkilzer@apple.com>
Blind attempt to fix the Windows build after r56314
Try to fix the following errors on the Windows buildbot:
Linking...
testapi.obj : error LNK2001: unresolved external symbol "bool __cdecl JSObjectSetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *,struct OpaqueJSValue const *)" (?JSObjectSetPrivateProperty@@YA_NPBUOpaqueJSContext@@PAUOpaqueJSValue@@PAUOpaqueJSString@@PBU2@@Z)
testapi.obj : error LNK2001: unresolved external symbol "struct OpaqueJSValue const * __cdecl JSObjectGetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *)" (?JSObjectGetPrivateProperty@@YAPBUOpaqueJSValue@@PBUOpaqueJSContext@@PAU1@PAUOpaqueJSString@@@Z)
C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\bin\testapi.exe : fatal error LNK1120: 2 unresolved externals
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added
missing symbols to be exported.
2010-03-21 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Documentation fix for previous patch.
* API/JSObjectRefPrivate.h:
2010-03-20 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
JSC needs an API to allow custom objects to have aprivate GC-accessible properties
https://bugs.webkit.org/show_bug.cgi?id=36420
Add new API methods to support "private" properties on custom
objects.
* API/JSCallbackObject.h:
(JSC::JSCallbackObjectData::JSCallbackObjectData):
(JSC::JSCallbackObjectData::~JSCallbackObjectData):
(JSC::JSCallbackObjectData::getPrivateProperty):
(JSC::JSCallbackObjectData::setPrivateProperty):
(JSC::JSCallbackObjectData::deletePrivateProperty):
(JSC::JSCallbackObjectData::markChildren):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren):
(JSC::JSCallbackObject::getPrivateProperty):
(JSC::JSCallbackObject::setPrivateProperty):
(JSC::JSCallbackObject::deletePrivateProperty):
(JSC::JSCallbackObject::markChildren):
* API/JSObjectRef.cpp:
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
* API/JSObjectRefPrivate.h: Added.
* API/tests/testapi.c:
(main):
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
2010-03-20 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fixes after introduction of Brew files.
* wscript:
2010-03-18 Tom Callaway <tcallawa@redhat.com>
Reviewed by Darin Adler.
Bug 35429: Fix compile on SPARC64
https://bugs.webkit.org/show_bug.cgi?id=35429
* wtf/Platform.h: Set WTF_USE_JSVALUE64 for SPARC64
2010-03-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Add API to directly expose JSON parsing
https://bugs.webkit.org/show_bug.cgi?id=34887
Add API to expose JSON parsing directly, and add tests to testapi
* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
(JSValueCreateJSONString):
* API/tests/testapi.c:
(main):
* JavaScriptCore.exp:
* runtime/JSONObject.cpp:
(JSC::JSONStringify):
* runtime/JSONObject.h:
2010-03-16 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler and Mark Rowe.
Update WebKit availability macros for release after 4.0.
* API/WebKitAvailability.h:
2010-03-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
undefined, NaN, and Infinity should be ReadOnly
https://bugs.webkit.org/show_bug.cgi?id=36263
Simply add the ReadOnly flag to these properties.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
2010-03-17 Darin Adler <darin@apple.com>
Reviewed by Oliver Hunt.
Speed up Math.round a little by removing unneeded special case
https://bugs.webkit.org/show_bug.cgi?id=36107
Test: fast/js/math.html
* runtime/MathObject.cpp:
(JSC::mathProtoFuncRound): This function had a special case for numbers
between -0.5 and -0.0 to return -0.0. But the algorithm in the function
already yields -0.0 for those cases, so the extra checking and branching
is unneeded.
2010-03-17 Mike Homey <glandium@debian.org>
Reviewed by Gustavo Noronha.
Build fix for SPARC. Fix missing macro value.
* wtf/Platform.h:
2010-03-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt, Darin Adler.
Bug 36083 - REGRESSION (r55772-r55834): Crash in JavaScriptCore RegExp code on PowerPC
The problem is a bug in our port of PCRE - that a read may take place from the first character in an
empty string. For the time being, revert to using a valid pointer in the data segment rather than
an invalid non-null pointer into the zero-page for the empty string's data pointer. A better fix for
this will be to remove PCRE.
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::empty):
2010-03-16 Darin Adler <darin@apple.com>
Rolled out r56081 since it broke the Windows build.
2010-03-16 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Remove extra <new> include and add guards to operator new/delete definitions
https://bugs.webkit.org/show_bug.cgi?id=35967
Remove extra <new> header include from FastAlloc.cpp since it is included in
FastAlloc.h. Add ENABLE(GLOBAL_FASTMALLOC_NEW) macro guard to operator
new/delete/new []/delete [] definitions.
* wtf/FastMalloc.cpp:
2010-03-15 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add a function to create a BREW instance without local variable declarations.
https://bugs.webkit.org/show_bug.cgi?id=34705
Add a template function to create a BREW instance in one line.
* wtf/brew/ShellBrew.h: Added.
(WTF::createInstance):
2010-03-15 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Removed a now-incorrect comment I forgot to remove in my last check-in.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavenge):
2010-03-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a portion of:
<rdar://problem/7165917> | https://bugs.webkit.org/show_bug.cgi?id=28676
Safari 4 does not release memory back to the operating system fast enough (28676)
Every few seconds, release a percentage of the minimum unused page count
during that time period.
SunSpider reports no change, command-line or in-browser, Mac or Windows.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMalloc_PageHeap::initializeScavenger): Renamed shouldContinueScavenging
to shouldScavenge, since scavenging is no longer something that we interrupt.
(WTF::TCMalloc_PageHeap::scavenge): The new scavenging algorithm. Fixes
a bug where the old code would release only one item from each size class
per scavenge, potentially leaving large numbers of large-sized objects
unreleased for a long time.
(WTF::TCMalloc_PageHeap::shouldScavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::GrowHeap):
(WTF::TCMalloc_PageHeap::scavengerThread):
(WTF::TCMalloc_PageHeap::periodicScavenge): Updated to track the minimum
value of free_committed_pages_ during a given scavenge period.
2010-03-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=35843
Re-land reverted fix to JSString::getIndex()
Calling getIndex() on a JSString in rope form may result in a JSException being thrown
if there is insuficient memory so value(exec) returns UString() with length zero,
which will be passed to jsSingleCharacterSubstring.
Add a slow case function to trap the error & return a safe null value, until the
exception is handled.
* runtime/JSString.cpp:
(JSC::JSString::getIndexSlowCase):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):
2010-03-04 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Adam Roben.
Add a long long version of abs() for MSVC.
* wtf/MathExtras.h:
(abs):
2010-03-15 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Combine ctiTrampolines on ARM and Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=36014
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
2010-03-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 36075 - Clean up screwyness re static string impls & Identifiers.
* API/JSClassRef.cpp:
(OpaqueJSClass::~OpaqueJSClass): Classname may be null/empty, and these are an identifer. This is okay, since the null/empty strings are shared across all threads.
* JavaScriptCore.exp:
* runtime/Identifier.cpp:
(JSC::Identifier::add): No need to explicitly hash null reps, this is done in the ststic UStringImpl constructor.
(JSC::Identifier::addSlowCase): UStringImpl::empty() handled & checkCurrentIdentifierTable now called in the header.
(JSC::Identifier::checkCurrentIdentifierTable): Replaces checkSameIdentifierTable (this no longer checked the rep since the identifierTable pointer was removed from UString::Rep long ago).
* runtime/Identifier.h:
(JSC::Identifier::add): Replace call to checkSameIdentifierTable with call to checkCurrentIdentifierTable at head of function.
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::~UStringImpl): Remove call to checkConsistency - this function no longer checks anything interesting.
* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::UStringOrRopeImpl): Set s_refCountFlagIsIdentifier in static constructor.
(JSC::UStringImpl::UStringImpl): remove calls to checkConsistency (see above), add new ASSERT to substring constructor.
(JSC::UStringImpl::setHash): ASSERT not static (static strings set the hash in their constructor, should not reach this code path).
(JSC::UStringImpl::create): Add missing ASSERT.
(JSC::UStringImpl::setIsIdentifier): ASSERT !isStatic() (static strings hash set in constructor).
2010-03-12 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by David Levin.
Two functions tryConsumeCharacter() and tryConsumeCharacterClass() are
removed from yarr/RegexInterpreter.cpp because they are never called.
* yarr/RegexInterpreter.cpp:
2010-03-11 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
The JSNative state was renamed to JSPrimitive. The new name better
coresponds to the ECMAScript standard.
Enum QScriptValuePrivate::States was renamed to State to obey Qt
coding style rules ("States" name suggests that a state could
mixed together with an other state using bitwise logic operators.
[Qt] QScriptValuePrivate::States has naming issues
https://bugs.webkit.org/show_bug.cgi?id=35968
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::):
(QScriptValuePrivate::QScriptValuePrivate):
(QScriptValuePrivate::isBool):
(QScriptValuePrivate::isNumber):
(QScriptValuePrivate::isNull):
(QScriptValuePrivate::isString):
(QScriptValuePrivate::isUndefined):
(QScriptValuePrivate::toString):
(QScriptValuePrivate::toNumber):
(QScriptValuePrivate::toBool):
(QScriptValuePrivate::assignEngine):
(QScriptValuePrivate::refinedJSValue):
2010-03-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
Add export.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
Add export.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-11 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Oliver Hunt.
Remove nonsense comments used in development & commited in error.
* runtime/UStringImpl.h:
2010-03-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
Remove export.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=36041
Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl
Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar,
but has trivial and unnecessary formatting differences, such as the exact wording
of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.
* runtime/Identifier.cpp:
(JSC::Identifier::add): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
(JSC::Identifier::addSlowCase): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::~UStringImpl): Only call bufferOwnership() once, add missing ASSERTs.
(JSC::UStringImpl::createUninitialized): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::create): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::sharedBuffer): Rewritten to more closely match WebCore implementation, remove need for separate baseSharedBuffer() method.
* runtime/UStringImpl.h:
(JSC::UStringImpl::UStringImpl): Automatically hash static strings, ASSERT m_data & m_length are non-null/non-zero in non-static strings.
(JSC::UStringImpl::setHash): Add missing ASSERT.
(JSC::UStringImpl::create): Moved to .cpp / added missing check for empty string creation.
(JSC::UStringImpl::adopt): Vector.size() returns size_t, not unsigned.
(JSC::UStringImpl::cost): Renamed m_bufferSubstring -> m_substringBuffer
(JSC::UStringImpl::hash): Reordered in file.
(JSC::UStringImpl::existingHash): Reordered in file.
(JSC::UStringImpl::computeHash): Reordered in file, renamed parameter.
(JSC::UStringImpl::checkConsistency): rewrote ASSERT.
(JSC::UStringImpl::bufferOwnership): Return type should be BufferOwnership.
(JSC::UStringImpl::): Moved friends to head of class.
2010-03-11 Mark Rowe <mrowe@apple.com>
Reviewed by David Kilzer.
<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
* Configurations/Base.xcconfig:
2010-03-11 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
current Mac OS X version unless otherwise specified.
Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
may not be usable when targetting a different Mac OS X version.
Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/FeatureDefines.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* Configurations/Version.xcconfig:
2010-03-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Mark Rowe.
Sort the project file.
* JavaScriptCore.xcodeproj/project.pbxproj:
2010-03-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Mark Rowe.
Sort the project file .
* JavaScriptCore.xcodeproj/project.pbxproj:
2010-03-11 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Buildfix for Thumb-2 after r55684. Add branch8 and branchTest8 functions.
https://bugs.webkit.org/show_bug.cgi?id=35892
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::ldrb):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::setTest8):
2010-03-10 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Oliver Hunt.
Rename JSC::UStringImpl::data() to characters(), to match WebCore::StringImpl.
* API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::keyForCharacterSwitch):
* bytecompiler/NodesCodegen.cpp:
(JSC::processClauseList):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
* runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
* runtime/UString.cpp:
(JSC::UString::toStrictUInt32):
(JSC::equal):
* runtime/UString.h:
(JSC::UString::data):
* runtime/UStringImpl.h:
(JSC::UStringImpl::characters):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::setHash):
2010-03-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler, Geoffrey Garen, Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35991
Would be faster to not use a thread specific to implement StringImpl::empty()
Change JSC::UStringImpl's implementation of empty() match to match StringImpl's new implementation
(use a static defined within the empty() method), and change the interface to match too (return
a pointer not a reference).
~0% performance impact (possible minor progression from moving empty() from .h to .cpp).
* JavaScriptCore.exp:
* runtime/Identifier.cpp:
(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::empty):
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:
(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
2010-03-10 Dmitry Titov <dimich@chromium.org>
Not reviewed, fixing Snow Leopard build.
* wtf/mac/MainThreadMac.mm: Forgot 'static' for a new local function.
(WTF::postTimer):
2010-03-10 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Make Document::postTask to use a single queue of tasks, to fire them in order
https://bugs.webkit.org/show_bug.cgi?id=35943
The patch uses CFRunLoopTimer to schedule execution of tasks instead of performSelectorOnMainThread which apparently can starve other event sources.
The timer is used when the schedule request is coming on the main thread itself. This happens when the task is posted on the main thread or
when too many tasks are posted and the queue does 'stop and re-schedule' to make sure run loop has a chance to execute other events.
* wtf/mac/MainThreadMac.mm:
(WTF::timerFired):
(WTF::postTimer):
(WTF::scheduleDispatchFunctionsOnMainThread): Use timer posted to the current RunLoop if scheduling the task execution while on the main thread.
2010-03-10 Geoffrey Garen <ggaren@apple.com>
Windows build fix: added new symbol.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-10 Geoffrey Garen <ggaren@apple.com>
Windows build fix: removed old symbol.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Alexey Proskuryakov, Darin Adler, and Sam Weinig.
Refactored fastCheckConsistency to match some review comments:
- renamed fastCheckConsistency to fastMallocSize, and changed ValueCheck
to ASSERT that a pointer's fastMallocSize is not 0.
- implemented a version of fastMallocSize for tcmalloc.
Also moved some pre-existing code around to avoid a problem related to
mismatched #define/#undef of malloc/free in this source file.
* JavaScriptCore.exp:
* wtf/FastMalloc.cpp:
(WTF::fastMallocSize): Renamed. Fixed indentation.
(WTF::TCMalloc_PageHeap::scavenge): Removed an incorrect ASSERT that
got in the way of testing the tcmalloc implementation. (More information
on why this ASSERT is incorrect is in <rdar://problem/7165917>.)
(WTF::TCMallocStats::fastMallocSize): Implemented for tcmalloc.
* wtf/FastMalloc.h: Updated for rename.
* wtf/ValueCheck.h:
(WTF::): Moved the ASSERT that used to be in fastCheckConsistency here.
2010-03-10 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Eric Seidel.
Make global new/delete operators configurable for all ports and disable it
for the wx port for now.
* wtf/FastMalloc.h:
* wtf/Platform.h:
2010-03-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (reverting r54510).
This caused a performance regression, by breaking the code
generator's logic to calculate the skip level for resolving
variables (traced by rdar:7683350) Reverting for now.
* parser/Grammar.y:
* parser/NodeConstructors.h:
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):
* runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
* runtime/CommonIdentifiers.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
* runtime/Identifier.cpp:
(JSC::Identifier::add):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
2010-03-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Changed FastMalloc statistics reporting to be a bit clearer. We now
report:
- Reserved VM Bytes: the VM that has been mapped into the process.
- Committed VM Bytes: the subset of Reserved VM Bytes actually in use.
- Free List Bytes: the subset of Committed VM Bytes in a free list.
* wtf/FastMalloc.cpp:
(WTF::fastMallocStatistics):
(WTF::TCMallocStats::fastMallocStatistics): Updated to report the statistics
above. Standardized use of "ifdef WTF_CHANGES". Added a SpinLockHolder
around all statistics gathering, since it reads from the page heap.
* wtf/FastMalloc.h: Updated to report the statistics above.
2010-03-09 Gabor Loki <loki@webkit.org>
Rubber-stamped by Maciej Stachowiak.
Buildfix for ARM after r55684. Add branch8 and branchTest8 functions.
https://bugs.webkit.org/show_bug.cgi?id=35892
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::dataTransfer32):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branchTest8):
2010-03-08 Geoffrey Garen <ggaren@apple.com>
Windows build fix: 'P' is not a type. Luckily, 'void' is.
* wtf/FastMalloc.cpp:
(WTF::fastCheckConsistency):
2010-03-08 Geoffrey Garen <ggaren@apple.com>
Windows build fix: export a new symbol.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Switching malloc implementations requires a world rebuild
https://bugs.webkit.org/show_bug.cgi?id=35899
* wtf/FastMalloc.cpp:
(WTF::fastCheckConsistency):
(WTF::TCMallocStats::fastCheckConsistency):
* wtf/FastMalloc.h:
* wtf/ValueCheck.h:
(WTF::): Moved pointer checking into a helper function in FastMalloc.cpp,
so you can switch malloc implementations without rebuilding the world.
2010-03-07 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
TypeInfo is unnecessarily large
https://bugs.webkit.org/show_bug.cgi?id=35850
Reduce the size of the type and flags members to a single
byte each, reducing the size of Structure by 8 bytes.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branch8):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::setTest8):
Add single byte branches, and correct setTest8 to do a
single byte read from memory, and actually store the result
* assembler/X86Assembler.h:
(JSC::X86Assembler::):
(JSC::X86Assembler::cmpb_im):
(JSC::X86Assembler::testb_im):
* jit/JITCall.cpp:
(JSC::JIT::emit_op_construct_verify):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emit_op_construct_verify):
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
(JSC::TypeInfo::type):
2010-03-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (reverting regression).
Reverting 55035, this caused a regression.
(https://bugs.webkit.org/show_bug.cgi?id=35843)
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::JSString::getStringPropertySlot):
* runtime/UStringImpl.cpp:
* runtime/UStringImpl.h:
2010-03-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Adler.
Added a new USE definition for secure text mode on the Mac.
https://bugs.webkit.org/show_bug.cgi?id=31265
* wtf/Platform.h:
2010-03-08 Jian Li <jianli@chromium.org>
Reviewed by Dmitry Titov.
Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993
Add ENABLE_BLOB_SLICE feature define.
Also fix a problem that JSValue.toInteger is not exposed on Windows.
* Configurations/FeatureDefines.xcconfig:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-07 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Small performance fix in the QScriptConverter::toString().
The QByteArray was replaced by the QVarLengthArray which doesn't
have to allocate any memory on heap.
[Qt] QScriptConverter::toString() should use QVarLengthArray instead of QByteArray
https://bugs.webkit.org/show_bug.cgi?id=35577
* qt/api/qscriptconverter_p.h:
(QScriptConverter::toString):
2010-03-06 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Sam Weinig.
Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.
* API/APICast.h:
* API/JSCallbackFunction.cpp:
* API/JSContextRef.cpp:
* API/JSObjectRef.cpp:
* API/JSValueRef.cpp:
* assembler/ARMAssembler.h:
* assembler/ARMv7Assembler.h:
* assembler/AbstractMacroAssembler.h:
* assembler/AssemblerBuffer.h:
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/CodeLocation.h:
* assembler/LinkBuffer.h:
* assembler/MIPSAssembler.h:
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerCodeRef.h:
* assembler/MacroAssemblerMIPS.h:
* assembler/MacroAssemblerX86.h:
* assembler/MacroAssemblerX86Common.h:
* assembler/MacroAssemblerX86_64.h:
* assembler/RepatchBuffer.h:
* assembler/X86Assembler.h:
* jit/JIT.h:
* jit/JITCode.h:
* jit/JITInlineMethods.h:
* jit/JITStubs.h:
* os-win32/stdint.h:
* runtime/JSAPIValueWrapper.h:
* runtime/JSImmediate.h:
* wtf/ASCIICType.h:
* wtf/StdLibExtras.h:
* wtf/VMTags.h:
* yarr/RegexCompiler.h:
* yarr/RegexInterpreter.h:
* yarr/RegexJIT.h:
* yarr/RegexParser.h:
* yarr/RegexPattern.h:
2010-03-06 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Share OwnPtr.
https://bugs.webkit.org/show_bug.cgi?id=35776
Share OwnPtr implementation with BREW MP and remove OwnPtrBrew.
* wtf/OwnPtrBrew.cpp: Added.
(WTF::deleteOwnedPtr):
* wtf/OwnPtrCommon.h:
* wtf/brew/OwnPtrBrew.cpp: Removed.
* wtf/brew/OwnPtrBrew.h: Removed.
2010-03-06 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Implemented JIT_OPTIMIZE_NATIVE_CALL for WinCE
https://bugs.webkit.org/show_bug.cgi?id=33426
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
2010-03-05 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (build fix).
Add enw exports to windows
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-05 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
JSC should cache int to Identifier conversion as it does for ordinary strings
https://bugs.webkit.org/show_bug.cgi?id=35814
Make the NumericStrings cache cache unsigned ints in addition to signed.
We keep them separate from the int cache as it both simplifies code, and
also because the unsigned path is exclusive to property access and therefore
seems to have different usage patterns.
The primary trigger for the unsigned to Identifier propertyName conversion
is the construction of array-like objects out of normal objects. Given these
tend to be relative small numbers, and the array-like behaviour lends itself
to sequential values this patch also adds a non-colliding cache for all small
numbers.
* JavaScriptCore.exp:
* runtime/Identifier.cpp:
(JSC::Identifier::from):
* runtime/Identifier.h:
* runtime/NumericStrings.h:
(JSC::NumericStrings::add):
(JSC::NumericStrings::lookup):
(JSC::NumericStrings::lookupSmallString):
2010-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716
Add new opcodes for handling cached lookup of static value getters.
More or less the same as with JS getters, all that changes is that
instead of calling through a JSFunction we always know that we have
a C function to call.
For the patching routines in the JIT we now need to pass a few
new parameters to allow us to pass enough information to the stub
function to allow us to call the C function correctly. Logically
this shouldn't actually be necessary as all of these functions ignore
the identifier, but removing the ident parameter would require
somewhat involved changes to the way we implement getOwnPropertySlot,
etc.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
* bytecode/Instruction.h:
(JSC::Instruction::Instruction):
(JSC::Instruction::):
* bytecode/Opcode.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
* runtime/Lookup.h:
(JSC::getStaticPropertySlot):
(JSC::getStaticValueSlot):
* runtime/PropertySlot.h:
(JSC::PropertySlot::):
(JSC::PropertySlot::PropertySlot):
(JSC::PropertySlot::cachedPropertyType):
(JSC::PropertySlot::isCacheable):
(JSC::PropertySlot::isCacheableValue):
(JSC::PropertySlot::setValueSlot):
(JSC::PropertySlot::setCacheableCustom):
(JSC::PropertySlot::setGetterSlot):
(JSC::PropertySlot::setCacheableGetterSlot):
(JSC::PropertySlot::clearOffset):
(JSC::PropertySlot::customGetter):
2010-03-04 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Remove a non-ASCII character introduced in the following bug.
put_by_id does will incorrectly cache writes where a specific value exists, where at the point of caching the same value is being written.
https://bugs.webkit.org/show_bug.cgi?id=35537
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
2010-03-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic.
This also allows shadow builds relying only on qmake to work properly.
* jsc.pro:
* qt/api/QtScript.pro:
* qt/tests/qscriptengine/qscriptengine.pro:
* qt/tests/qscriptvalue/qscriptvalue.pro:
* qt/tests/tests.pri:
2010-03-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
QScriptValue::isObject fix.
Fix broken internal state evaluation from JSValue to JSNative / JSObject.
New function was introduced which should take care about promoting
JSValue state inside QScriptValuePrivate. It should be used instead of a
direct JSC C API call.
The bug exposed a weakness in autotest suite, as the QScriptValuePrivate
is based on state machine with lazy state evaluation, there is a possibility
that serial sequencial calls to the same public const function could return
different results. The patch fix the issue.
[Qt] Sometimes QScriptValue::isObject returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=35387
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::isBool):
(QScriptValuePrivate::isNumber):
(QScriptValuePrivate::isNull):
(QScriptValuePrivate::isString):
(QScriptValuePrivate::isUndefined):
(QScriptValuePrivate::isError):
(QScriptValuePrivate::isObject):
(QScriptValuePrivate::isFunction):
(QScriptValuePrivate::call):
(QScriptValuePrivate::refineJSValue):
* qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:
(tst_QScriptValue::initScriptValues):
(tst_QScriptValue::isValid_makeData):
(tst_QScriptValue::isValid_test):
(tst_QScriptValue::isBool_makeData):
(tst_QScriptValue::isBool_test):
(tst_QScriptValue::isBoolean_makeData):
(tst_QScriptValue::isBoolean_test):
(tst_QScriptValue::isNumber_makeData):
(tst_QScriptValue::isNumber_test):
(tst_QScriptValue::isFunction_test):
(tst_QScriptValue::isNull_makeData):
(tst_QScriptValue::isNull_test):
(tst_QScriptValue::isString_makeData):
(tst_QScriptValue::isString_test):
(tst_QScriptValue::isUndefined_makeData):
(tst_QScriptValue::isUndefined_test):
(tst_QScriptValue::isObject_makeData):
(tst_QScriptValue::isObject_test):
(tst_QScriptValue::toString_makeData):
(tst_QScriptValue::toString_test):
(tst_QScriptValue::toNumber_makeData):
(tst_QScriptValue::toNumber_test):
(tst_QScriptValue::toBool_makeData):
(tst_QScriptValue::toBool_test):
(tst_QScriptValue::toBoolean_makeData):
(tst_QScriptValue::toBoolean_test):
(tst_QScriptValue::toInteger_makeData):
(tst_QScriptValue::toInteger_test):
(tst_QScriptValue::toInt32_makeData):
(tst_QScriptValue::toInt32_test):
(tst_QScriptValue::toUInt32_makeData):
(tst_QScriptValue::toUInt32_test):
(tst_QScriptValue::toUInt16_makeData):
(tst_QScriptValue::toUInt16_test):
2010-03-03 Chao-ying Fu <fu@mips.com>
Reviewed by Gavin Barraclough.
MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144
The following changes enable MIPS YARR and YARR_JIT.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Imm32::Imm32):
* assembler/MIPSAssembler.h: Added.
(JSC::MIPSRegisters::):
(JSC::MIPSAssembler::MIPSAssembler):
(JSC::MIPSAssembler::):
(JSC::MIPSAssembler::JmpSrc::JmpSrc):
(JSC::MIPSAssembler::JmpDst::JmpDst):
(JSC::MIPSAssembler::JmpDst::isUsed):
(JSC::MIPSAssembler::JmpDst::used):
(JSC::MIPSAssembler::emitInst):
(JSC::MIPSAssembler::nop):
(JSC::MIPSAssembler::loadDelayNop):
(JSC::MIPSAssembler::copDelayNop):
(JSC::MIPSAssembler::move):
(JSC::MIPSAssembler::li):
(JSC::MIPSAssembler::lui):
(JSC::MIPSAssembler::addiu):
(JSC::MIPSAssembler::addu):
(JSC::MIPSAssembler::subu):
(JSC::MIPSAssembler::mult):
(JSC::MIPSAssembler::mfhi):
(JSC::MIPSAssembler::mflo):
(JSC::MIPSAssembler::mul):
(JSC::MIPSAssembler::andInsn):
(JSC::MIPSAssembler::andi):
(JSC::MIPSAssembler::nor):
(JSC::MIPSAssembler::orInsn):
(JSC::MIPSAssembler::ori):
(JSC::MIPSAssembler::xorInsn):
(JSC::MIPSAssembler::xori):
(JSC::MIPSAssembler::slt):
(JSC::MIPSAssembler::sltu):
(JSC::MIPSAssembler::sltiu):
(JSC::MIPSAssembler::sll):
(JSC::MIPSAssembler::sllv):
(JSC::MIPSAssembler::sra):
(JSC::MIPSAssembler::srav):
(JSC::MIPSAssembler::lw):
(JSC::MIPSAssembler::lwl):
(JSC::MIPSAssembler::lwr):
(JSC::MIPSAssembler::lhu):
(JSC::MIPSAssembler::sw):
(JSC::MIPSAssembler::jr):
(JSC::MIPSAssembler::jalr):
(JSC::MIPSAssembler::jal):
(JSC::MIPSAssembler::bkpt):
(JSC::MIPSAssembler::bgez):
(JSC::MIPSAssembler::bltz):
(JSC::MIPSAssembler::beq):
(JSC::MIPSAssembler::bne):
(JSC::MIPSAssembler::bc1t):
(JSC::MIPSAssembler::bc1f):
(JSC::MIPSAssembler::newJmpSrc):
(JSC::MIPSAssembler::appendJump):
(JSC::MIPSAssembler::addd):
(JSC::MIPSAssembler::subd):
(JSC::MIPSAssembler::muld):
(JSC::MIPSAssembler::lwc1):
(JSC::MIPSAssembler::ldc1):
(JSC::MIPSAssembler::swc1):
(JSC::MIPSAssembler::sdc1):
(JSC::MIPSAssembler::mtc1):
(JSC::MIPSAssembler::mfc1):
(JSC::MIPSAssembler::truncwd):
(JSC::MIPSAssembler::cvtdw):
(JSC::MIPSAssembler::ceqd):
(JSC::MIPSAssembler::cngtd):
(JSC::MIPSAssembler::cnged):
(JSC::MIPSAssembler::cltd):
(JSC::MIPSAssembler::cled):
(JSC::MIPSAssembler::cueqd):
(JSC::MIPSAssembler::coled):
(JSC::MIPSAssembler::coltd):
(JSC::MIPSAssembler::culed):
(JSC::MIPSAssembler::cultd):
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::align):
(JSC::MIPSAssembler::getRelocatedAddress):
(JSC::MIPSAssembler::getDifferenceBetweenLabels):
(JSC::MIPSAssembler::size):
(JSC::MIPSAssembler::executableCopy):
(JSC::MIPSAssembler::getCallReturnOffset):
(JSC::MIPSAssembler::linkJump):
(JSC::MIPSAssembler::linkCall):
(JSC::MIPSAssembler::linkPointer):
(JSC::MIPSAssembler::relinkJump):
(JSC::MIPSAssembler::relinkCall):
(JSC::MIPSAssembler::repatchInt32):
(JSC::MIPSAssembler::repatchPointer):
(JSC::MIPSAssembler::repatchLoadPtrToLEA):
(JSC::MIPSAssembler::relocateJumps):
(JSC::MIPSAssembler::linkWithOffset):
(JSC::MIPSAssembler::linkCallInternal):
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerMIPS.h: Added.
(JSC::MacroAssemblerMIPS::MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::):
(JSC::MacroAssemblerMIPS::add32):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::lshift32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::not32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::rshift32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::xor32):
(JSC::MacroAssemblerMIPS::load32):
(JSC::MacroAssemblerMIPS::load32WithUnalignedHalfWords):
(JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerMIPS::loadPtrWithPatchToLEA):
(JSC::MacroAssemblerMIPS::loadPtrWithAddressOffsetPatch):
(JSC::MacroAssemblerMIPS::load16):
(JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::pop):
(JSC::MacroAssemblerMIPS::push):
(JSC::MacroAssemblerMIPS::move):
(JSC::MacroAssemblerMIPS::swap):
(JSC::MacroAssemblerMIPS::signExtend32ToPtr):
(JSC::MacroAssemblerMIPS::zeroExtend32ToPtr):
(JSC::MacroAssemblerMIPS::branch32):
(JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerMIPS::branch16):
(JSC::MacroAssemblerMIPS::branchTest32):
(JSC::MacroAssemblerMIPS::jump):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
(JSC::MacroAssemblerMIPS::breakpoint):
(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::ret):
(JSC::MacroAssemblerMIPS::set32):
(JSC::MacroAssemblerMIPS::setTest32):
(JSC::MacroAssemblerMIPS::moveWithPatch):
(JSC::MacroAssemblerMIPS::branchPtrWithPatch):
(JSC::MacroAssemblerMIPS::storePtrWithPatch):
(JSC::MacroAssemblerMIPS::tailRecursiveCall):
(JSC::MacroAssemblerMIPS::makeTailRecursiveCall):
(JSC::MacroAssemblerMIPS::loadDouble):
(JSC::MacroAssemblerMIPS::storeDouble):
(JSC::MacroAssemblerMIPS::addDouble):
(JSC::MacroAssemblerMIPS::subDouble):
(JSC::MacroAssemblerMIPS::mulDouble):
(JSC::MacroAssemblerMIPS::convertInt32ToDouble):
(JSC::MacroAssemblerMIPS::insertRelaxationWords):
(JSC::MacroAssemblerMIPS::branchTrue):
(JSC::MacroAssemblerMIPS::branchFalse):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):
(JSC::MacroAssemblerMIPS::branchDouble):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerMIPS::linkCall):
(JSC::MacroAssemblerMIPS::repatchCall):
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
* wtf/Platform.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):
2010-03-03 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
2010-03-03 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
2010-03-03 Mark Rowe <mrowe@apple.com>
Reviewed by Geoff Garen.
Add virtual memory tags for TCMalloc and WebCore's purgeable buffers.
* wtf/TCSystemAlloc.cpp:
(TryMmap): Use the VM tag.
* wtf/VMTags.h: Make use of VM_MEMORY_TCMALLOC and VM_MEMORY_WEBCORE_PURGEABLE_BUFFERS.
2010-03-03 Steve Falkenburg <sfalken@apple.com>
Rubber stamped by Adam Roben.
Fix bogus xcopy that was polluting source tree at build time.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Oliver Hunt.
Allow building smoothly on win32 and win64 using GCC
https://bugs.webkit.org/show_bug.cgi?id=35607
* jit/JITStubs.h:
* runtime/Collector.cpp:
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlockPtr):
(JSC::currentThreadStackBase):
2010-03-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by David Levin.
Revert database thread changes that are no longer required
https://bugs.webkit.org/show_bug.cgi?id=35519
Jochen Eisinger created 55214 and 55247 to track which database
owns which thread. Dmitry suggested that this could also
be done via TLS, though. After exploring the options, Jochen
chose to go the TLS route, so these patches are no longer needed.
* wtf/Threading.h:
* wtf/ThreadingNone.cpp:
(WTF::isMainThread):
* wtf/ThreadingPthreads.cpp:
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
* wtf/ThreadingWin.cpp:
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::createThreadInternal):
2010-03-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::toString().
More ECMA Script compliance, especially for values as NaN, Inifinite
and really big/small numbers.
[Qt] QScriptValue::toString() returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34850
* qt/api/qscriptconverter_p.h:
(QScriptConverter::toString):
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::toString):
* qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
* qt/tests/qscriptvalue/tst_qscriptvalue.h:
* qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:
(tst_QScriptValue::toString_initData):
(tst_QScriptValue::toString_makeData):
(tst_QScriptValue::toString_test):
2010-03-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Introduce a new class; QScriptString.
The QScriptString class should act as a handle to "interned"
strings in a QScriptEngine.
[Qt] QtScript should provide QScriptString
https://bugs.webkit.org/show_bug.cgi?id=34843
* qt/api/QtScript.pro:
* qt/api/qscriptengine.cpp:
(QScriptEngine::toStringHandle):
* qt/api/qscriptengine.h:
* qt/api/qscriptengine_p.h:
(QScriptEnginePrivate::toStringHandle):
* qt/api/qscriptstring.cpp: Added.
(QScriptString::QScriptString):
(QScriptString::~QScriptString):
(QScriptString::operator=):
(QScriptString::isValid):
(QScriptString::operator==):
(QScriptString::operator!=):
(QScriptString::toArrayIndex):
(QScriptString::toString):
(QScriptString::operator QString):
(qHash):
* qt/api/qscriptstring.h: Added.
* qt/api/qscriptstring_p.h: Added.
(QScriptStringPrivate::QScriptStringPrivate):
(QScriptStringPrivate::~QScriptStringPrivate):
(QScriptStringPrivate::get):
(QScriptStringPrivate::isValid):
(QScriptStringPrivate::operator==):
(QScriptStringPrivate::operator!=):
(QScriptStringPrivate::toArrayIndex):
(QScriptStringPrivate::toString):
(QScriptStringPrivate::id):
* qt/tests/qscriptstring/qscriptstring.pro: Added.
* qt/tests/qscriptstring/tst_qscriptstring.cpp: Added.
(tst_QScriptString::tst_QScriptString):
(tst_QScriptString::~tst_QScriptString):
(tst_QScriptString::test):
(tst_QScriptString::hash):
(tst_QScriptString::toArrayIndex_data):
(tst_QScriptString::toArrayIndex):
* qt/tests/tests.pro:
2010-03-02 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Export function on windows.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563
This removes the PropertySlot argument from getter functions, and makes them directly
pass the slot base. This makes the semantics for the functions match that of the
indexing getters.
On the down side, this means that we can no longer simply use a proxy function for
JS getters, so we now add another marker value to indicate that a getter is present
and branch accordingly.
Against all rationality sunspider reports this as a perf win, but i suspect it's just noise.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::staticValueGetter):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
* JavaScriptCore.exp:
* runtime/JSActivation.cpp:
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
* runtime/JSFunction.h:
* runtime/NumberConstructor.cpp:
(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
* runtime/PropertySlot.h:
(JSC::PropertySlot::getValue):
(JSC::PropertySlot::setGetterSlot):
(JSC::PropertySlot::setCacheableGetterSlot):
* runtime/RegExpConstructor.cpp:
(JSC::regExpConstructorDollar1):
(JSC::regExpConstructorDollar2):
(JSC::regExpConstructorDollar3):
(JSC::regExpConstructorDollar4):
(JSC::regExpConstructorDollar5):
(JSC::regExpConstructorDollar6):
(JSC::regExpConstructorDollar7):
(JSC::regExpConstructorDollar8):
(JSC::regExpConstructorDollar9):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
* runtime/RegExpObject.cpp:
(JSC::regExpObjectGlobal):
(JSC::regExpObjectIgnoreCase):
(JSC::regExpObjectMultiline):
(JSC::regExpObjectSource):
(JSC::regExpObjectLastIndex):
2010-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
https://bugs.webkit.org/show_bug.cgi?id=35561
Fix this by defining a separate property getter function for index getters. This allows
us to pass an unsigned number without the conversion to an Identifier. We then update
setCustomIndex to take this new getter type.
* runtime/PropertySlot.h:
(JSC::PropertySlot::getValue):
(JSC::PropertySlot::setCustom):
(JSC::PropertySlot::setCustomIndex):
2010-03-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 35537 - put_by_id does will incorrectly cache writes where a specific value exists,
where at the point of caching the same value is being written.
When performing a put_by_id that is replacing a property already present on the object,
there are three interesting cases regarding the state of the specific value:
(1) No specific value set - nothing to do, leave the structure in it's current state,
can cache.
(2) A specific value was set, the new put is not of a specified value (i.e. function),
or is of a different specific value - in these cases we need to perform a despecifying
transition to clear the specific value in the structure, but having done so this is a
normal property so as such we can again cache normally.
(3) A specific value was set, and we are overwriting with the same value - in these cases
leave the structure unchanged, but since a specific value is set we cannot cache this
put (we would need the JIT to dynamically check the value being written matched).
Unfortunately, the current behaviour does not match this. the checks for a specific value
being present & the value matching are combined in such a way that in case (2), above we
will unnecessarily prevent the transition being cached, but in case (3) we will incorrectly
fail to prevent caching.
The bug exposes itself if multiple puts of the same specific value are performed to a
property, and erroneously the put is allowed to be cached by the JIT. Method checks may be
generated caching calls of this structure. Subsequent puts performed from JIT code may
write different values without triggering a despecify transition, and as such cached method
checks will continue to pass, despite the value having changed.
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
2010-03-01 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix the Qt build on Mac OS X/Cocoa 64-bit
* JavaScriptCore.pri: Add missing implementation file to resolve JSC symbols
2010-02-26 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Geoff Garen.
Remove wrec. All builds should have switched to yarr by now.
* Android.mk:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RegExp.cpp:
(JSC::RegExp::match):
* runtime/RegExp.h:
* wrec: Removed.
* wrec/CharacterClass.cpp: Removed.
* wrec/CharacterClass.h: Removed.
* wrec/CharacterClassConstructor.cpp: Removed.
* wrec/CharacterClassConstructor.h: Removed.
* wrec/Escapes.h: Removed.
* wrec/Quantifier.h: Removed.
* wrec/WREC.cpp: Removed.
* wrec/WREC.h: Removed.
* wrec/WRECFunctors.cpp: Removed.
* wrec/WRECFunctors.h: Removed.
* wrec/WRECGenerator.cpp: Removed.
* wrec/WRECGenerator.h: Removed.
* wrec/WRECParser.cpp: Removed.
* wrec/WRECParser.h: Removed.
* wscript:
2010-02-26 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Make the lookup table generator include an explicit cast to expected
type of the function. We do this because otherwise the blind intptr_t
cast that is subsequently applied allows incorrectly typed functions
to be inserted into the table, where they will only fail at runtime.
This change makes such errors produce a compile time failure.
* create_hash_table:
2010-02-26 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] Symbian specific getCPUTime implemetation
https://bugs.webkit.org/show_bug.cgi?id=34742
Default implementation doesn't work on Symbian devices.
This change adds a proper implementation by
asking thread execution time from the current thread.
* runtime/TimeoutChecker.cpp:
(JSC::getCPUTime):
2010-02-25 Alexey Proskuryakov <ap@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=35406
<rdar://problem/6945502> Make generic array methods work with JavaArray
Renamed lazyCreationData to subclassData. This is extra data that can be used by JSArray
subclasses (you can't add new data members, because it wouldn't fit in JSCell otherwise).
* JavaScriptCore.exp:
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::subclassData):
(JSC::JSArray::setSubclassData):
* runtime/JSArray.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::~RegExpMatchesArray):
(JSC::RegExpMatchesArray::fillArrayInstance):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::getOwnPropertyNames):
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
JSC crashes like crazy in the JSPropertyNameIterator destructor
Add back null check of m_cachedStructure. Curse last minute changes.
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
2010-02-25 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Race condition in JSPropertyNameIterator and Structure destruction
https://bugs.webkit.org/show_bug.cgi?id=35398
JSPropertyNameIterator and Structure have a cyclic dependency that they
manage by clearing the appropriate reference in each other during their
destruction. However if the Structure is destroyed while the
JSPropertyNameIterator is dead but not yet finalized the Structures
WeakGCPtr will return null, and so prevent Structure from clearing
the m_cachedStructure pointer of the iterator. When the iterator is
then finalised the m_cachedStructure is invalid, and the attempt to
clear the structures back reference fails.
To fix this we simply make JSPropertyNameIterator keep the Structure
alive, using the weak pointer to break the ref cycle.
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
The iterator now keeps m_cachedStructure alive itself, so no longer needs
to check for it being cleared
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::setCachedStructure):
Add an assertion to ensure correct usage
(JSC::JSPropertyNameIterator::cachedStructure):
Add .get()
* runtime/Structure.cpp:
(JSC::Structure::~Structure):
Add an assertion that our iterator isn't already dead, and remove
the now unnecessary attempt to clear the ref in the iterator
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::hasDeadObject):
An assert-only function to allow us to assert correct behaviour
in the Structure destructor
2010-02-25 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Make the context that was passed to the ThreadFunction accessible.
https://bugs.webkit.org/show_bug.cgi?id=35379
When a database is opened, right now you
don't have any context from where it is opened. The problem is that
the actual calls that open a database go through the sqlite3 vfs
layer, so there's no easy way to pass this function down to to
platform/sql/chromium/SQLFileSystemChromium*.cpp
This patch will allow you to get from anywhere within webkit a pointer
to the Thread object that actually created the thread you're currently
on (in case of the database, this can be either a thread forked of
from the main thread or from a worker thread), and query the object
for context information.
* wtf/Threading.h:
* wtf/ThreadingNone.cpp:
(WTF::threadContext):
* wtf/ThreadingPthreads.cpp:
(WTF::):
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
(WTF::threadContext):
* wtf/ThreadingWin.cpp:
(WTF::):
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::threadContext):
2010-02-25 Jeremy Orlow <jorlow@chromium.org>
Reverting to re-submit with better change log.
* wtf/Threading.h:
* wtf/ThreadingNone.cpp:
(WTF::isMainThread):
* wtf/ThreadingPthreads.cpp:
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
* wtf/ThreadingWin.cpp:
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::createThreadInternal):
2010-02-25 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Make the context that was passed to the ThreadFunction accessible.
https://bugs.webkit.org/show_bug.cgi?id=35379
* wtf/Threading.h:
* wtf/ThreadingNone.cpp:
(WTF::threadContext):
* wtf/ThreadingPthreads.cpp:
(WTF::):
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::pthreadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::currentThread):
(WTF::threadContext):
* wtf/ThreadingWin.cpp:
(WTF::):
(WTF::threadMap):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::contextForIdentifier):
(WTF::createThreadInternal):
(WTF::threadContext):
2010-02-24 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
[REGRESSION in r55185] EXC_BAD_ACCESS on opening inspector.
https://bugs.webkit.org/show_bug.cgi?id=35335
compileGetDirectOffset modifies the contents of the object register
when the object is not using the inline storage array. As the object
register contains our 'this' pointer we can't allow it to be clobbered.
The fix is simply to copy the register into a separate scratch register
when we're loading off an object that doesn't use inline storage.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
2010-02-24 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Speed up getter performance in the jit
https://bugs.webkit.org/show_bug.cgi?id=35332
Implement getter lookup caching in the interpreter.
The getter stubs are generated through basically the
same code paths as the normal get_by_id caching.
Instead of simply loading a property and returning,
we load the getter slot, and pass the getter, base value
and return address to a shared stub used for getter
dispatch.
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::):
* runtime/GetterSetter.h:
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Web Inspector: Regression: r55027+: Inspector broken
https://bugs.webkit.org/show_bug.cgi?id=35253
op_get_by_id_getter_chain was not passing the correct this parameter.
The bug was caused by incorrect use of baseCell instead of baseValue,
baseValue contains the original object for the lookup (and hence the
correct this object), baseCell is clobbered as part of walking the
prototype chain.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2010-02-23 Gustavo Noronha Silva <gns@gnome.org>
Rubber-stamped by Dimitri Glazkov.
Chromium build fix.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Changes references of GOwnPtr to reflect their new place.
http://webkit.org/b/35084
* JavaScriptCore/JavaScriptCore.gypi:
* JavaScriptCore/wtf/Threading.h:
* JavaScriptCore/wtf/unicode/glib/UnicodeGLib.h:
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Adding the EFL implementation of JavaScriptCore.
See https://bugs.webkit.org/show_bug.cgi?id=35084 for details.
* GNUmakefile.am: Updated to reflect the new location of GOwnPtr and
GRefPtr.
* wtf/efl/MainThreadEfl.cpp: Added.
* wtf/gobject/GOwnPtr.cpp: Moved from wtf/gtk.
* wtf/gobject/GOwnPtr.h: Moved from wtf/gtk.
* wtf/gobject/GRefPtr.cpp: Moved from wtf/gtk.
* wtf/gobject/GRefPtr.h: Moved from wtf/gtk.
2010-02-22 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Remove auto_ptr usage in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=35221
* parser/Nodes.h: Removed now unneeded adopt method.
* parser/Parser.cpp: Removed <memory> include as it is not required anymore.
* wtf/OwnPtr.h: Removed the constructor from auto_ptr.
* wtf/VectorTraits.h: Removed a template specialization for auto_ptr.
* wtf/unicode/Collator.h: Made userDefault return a PassOwnPtr.
* wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault): Changed the method to match the next signature.
* wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault): Ditto.
2010-02-22 Huahui Wu <hwu@google.com>
Reviewed by Eric Seidel.
Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
in Android. It's disabled by default, but is enabled when the
enveronment variable ENABLE_JSC_JIT is set to true.
https://bugs.webkit.org/show_bug.cgi?id=34855
* Android.mk:
* wtf/Platform.h:
2010-02-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
JSStringBuilder should not CRASH if allocation fails, it should throw a JSException.
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::build):
* runtime/StringBuilder.h:
(JSC::StringBuilder::build):
* wtf/Vector.h:
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::::tryExpandCapacity):
(WTF::::tryReserveCapacity):
(WTF::::tryAppend):
2010-02-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Map FastMalloc to BREW memory allocator
https://bugs.webkit.org/show_bug.cgi?id=33570
Use MALLOC macro instead of the standard malloc function.
Although RVCT provides malloc, we can't use it in BREW
because the loader does not initialize the base address properly.
* wtf/FastMalloc.cpp:
* wtf/brew/SystemMallocBrew.h: Added.
(mallocBrew):
(callocBrew):
(freeBrew):
(reallocBrew):
2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Build fix for make distcheck.
* GNUmakefile.am:
2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed build fix.
[Qt] Build fix for RVCT.
Fix after r55024. The "-i" option is for perl not for the
script.
* DerivedSources.pro:
2010-02-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Make UString::m_data be const, and make the UChar owned/ref-counted by CrossThreadRefCounted be const too.
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::create):
(JSC::UStringImpl::data):
(JSC::UStringImpl::UStringImpl):
* wtf/OwnFastMallocPtr.h:
(WTF::OwnFastMallocPtr::~OwnFastMallocPtr):
2010-02-21 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
HashMapTranslatorAdapter::translate() needs to set the mapped value.
HTTPHeaderMap::add(const char*, const String&) does not work
https://bugs.webkit.org/show_bug.cgi?id=35227
* wtf/HashMap.h:
(WTF::HashMapTranslatorAdapter::translate):
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
* Configurations/FeatureDefines.xcconfig:
2010-02-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
JSString::getIndex() calls value() to resolve the string value (is a rope)
to a UString, then passes the result to jsSingleCharacterSubstring without
checking for an exception. In case of out-of-memory the returned UString
is null(), which may result in an out-of-buounds substring being created.
This is bad.
Simple fix is to be able to get an index from a rope without resolving to
UString. This may be a useful optimization in some test cases.
The same bug exists in some other methods is JSString, these can be fixed
by changing them to call getIndex().
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):
* runtime/UStringImpl.cpp:
(JSC::singleCharacterSubstring):
* runtime/UStringImpl.h:
(JSC::UStringImpl::singleCharacterSubstring):
2010-02-19 Oliver Hunt <oliver@apple.com>
RS = Gavin Barraclough.
Split the 32/64 version of JITPropertyAccess into a separate file.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp: Added.
(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter):
(JSC::JIT::emit_op_put_setter):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchMethodCallProto):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::emitSlow_op_get_by_pname):
2010-02-19 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
Added additional parameter to create_rvct_stubs
for setting the regularexpression prefix.
Renamed it because it now works for other platforms too.
https://bugs.webkit.org/show_bug.cgi?id=34951
* DerivedSources.pro:
* create_jit_stubs: Copied from JavaScriptCore/create_rvct_stubs.
* create_rvct_stubs: Removed.
2010-02-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Improve interpreter getter performance
https://bugs.webkit.org/show_bug.cgi?id=35138
Improve the performance of getter dispatch by making it possible
for the interpreter to cache the GetterSetter object lookup.
To do this we simply need to make PropertySlot aware of getters
as a potentially cacheable property, and record the base and this
objects for a getter access. This allows us to use more-or-less
identical code to that used by the normal get_by_id caching, with
the dispatch being the only actual difference.
I'm holding off of implementing this in the JIT until I do some
cleanup to try and making coding in the JIT not be as horrible
as it is currently.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
* bytecode/Opcode.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::fillGetterPropertySlot):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
* runtime/PropertySlot.h:
(JSC::PropertySlot::isGetter):
(JSC::PropertySlot::isCacheable):
(JSC::PropertySlot::isCacheableValue):
(JSC::PropertySlot::setValueSlot):
(JSC::PropertySlot::setGetterSlot):
(JSC::PropertySlot::setCacheableGetterSlot):
(JSC::PropertySlot::clearOffset):
(JSC::PropertySlot::thisValue):
2010-02-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed a portion of:
<rdar://problem/7165917> | https://bugs.webkit.org/show_bug.cgi?id=28676
Safari 4 does not release memory back to the operating system fast enough (28676)
This patch fixes a surprisingly common edge case in which the page heap
would have only one free span, but that span would be larger than the
minimum free size, so we would decide not to free it, even though it
could be as large as 100MB or more!
SunSpider reports no change on Mac or Windows.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavenge): Call shouldContinueScavenging() instead
of doing the math ourselves. Don't keep a local value for pagesDecommitted
because that lets free_committed_pages_ be wrong temporarily. Instead,
update free_committed_pages_ as we go. ASSERT that we aren't releasing
a span that has already been released, because we think this is impossible.
Finally, don't be afraid to release all free memory in the page heap when
scavenging. We only scavenge after 5 seconds of the application's working
set not growing, and we keep both thread caches and a central cache on
top of the page heap, so the extra free pages in the page heap were just
overkill.
2010-02-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=35070
Addition of 2 strings of length 2^31 may result in a string of length 0.
Check for overflow when creating a new JSString as a result of an addition
or concatenation, throw an out of memory exception.
* runtime/JSString.h:
(JSC::):
* runtime/Operations.h:
(JSC::jsString):
2010-02-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[Linux] Webkit incompatible with Java plugins
https://bugs.webkit.org/show_bug.cgi?id=24912
Add support for GFile to GOwnPtr.
Based on original work by Gustavo Noronha.
* wtf/gtk/GOwnPtr.cpp:
(WTF::GFile):
* wtf/gtk/GOwnPtr.h:
2010-02-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
Fix a handful of other leaks seen on the buildbot.
* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::deref): Delegate through to the subclass version of deref to ensure that
the correct cleanup takes place. This function previously featured some code that attempted to
skip deletion of static UStringImpl's. Closer inspection revealed that it was in fact equivalent
to "if (false)", meaning that UStringImpl's which had their final deref performed via this function
were leaked.
2010-02-16 Mark Rowe <mrowe@apple.com>
Reviewed by Gavin Barraclough.
Fix a handful of leaks seen on the buildbot.
* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::deref): Call URopeImpl::destructNonRecursive rather than delete
to ensure that the rope's fibers are also destroyed.
2010-02-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=34964
Leaks tool reports false memory leaks due to Rope implementation.
A rope is a recursive data structure where each node in the rope holds a set of
pointers, each of which may reference either a string (in UStringImpl form) or
another rope node. A low bit in each pointer is used to distinguish between
rope & string elements, in a fashion similar to the recently-removed
PtrAndFlags class (see https://bugs.webkit.org/show_bug.cgi?id=33731 ). Again,
this causes a problem for Leaks - refactor to remove the magic pointer
mangling.
Move Rope out from JSString.h and rename to URopeImpl, to match UStringImpl.
Give UStringImpl and URopeImpl a common parent class, UStringOrRopeImpl.
Repurpose an otherwise invalid permutation to flags (static & should report
memory cost) to identify ropes.
This allows us to change the rope's fibers to interrogate the object rather
than storing a bool within the low bits of the pointer (or in some cases the
use of a common parent class removes the need to determine the type at all -
there is a common interface to ref or get the length of either ropes or strings).
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::keyForCharacterSwitch):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
* runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
* runtime/JSString.h:
(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::JSStringFinalizerStruct::JSStringFinalizerStruct):
(JSC::RopeBuilder::JSStringFinalizerStruct::):
* runtime/UString.cpp:
(JSC::UString::toStrictUInt32):
(JSC::equal):
* runtime/UString.h:
(JSC::UString::isEmpty):
(JSC::UString::size):
* runtime/UStringImpl.cpp:
(JSC::URopeImpl::derefFibersNonRecursive):
(JSC::URopeImpl::destructNonRecursive):
* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::isRope):
(JSC::UStringOrRopeImpl::length):
(JSC::UStringOrRopeImpl::ref):
(JSC::UStringOrRopeImpl::):
(JSC::UStringOrRopeImpl::operator new):
(JSC::UStringOrRopeImpl::UStringOrRopeImpl):
(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::):
(JSC::URopeImpl::tryCreateUninitialized):
(JSC::URopeImpl::initializeFiber):
(JSC::URopeImpl::fiberCount):
(JSC::URopeImpl::fibers):
(JSC::URopeImpl::deref):
(JSC::URopeImpl::URopeImpl):
(JSC::URopeImpl::hasOneRef):
(JSC::UStringOrRopeImpl::deref):
2010-02-15 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Fix the SP at ctiOpThrowNotCaught on Thumb2 (JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=34939
* jit/JITStubs.cpp:
2010-02-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Build Fix!).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-02-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Some general Rope related refactoring.
Rename Rope::m_ropeLength to m_fiberCount, to be more descriptive.
Rename Rope::m_stringLength to simply m_length (since this is the
more conventional name for the length of a string). Move append
behaviour out into a new RopeBuilder class, so that Rope no longer
needs any knowledge of the JSString or UString implementation.
Make Rope no longer be nested within JSString.
(Rope now no-longer need reside within JSString.h, but leaving
the change of moving this out to a different header as a separate
change from these renames).
* JavaScriptCore.exp:
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* runtime/JSString.cpp:
(JSC::Rope::destructNonRecursive):
(JSC::Rope::~Rope):
(JSC::JSString::resolveRope):
(JSC::JSString::toBoolean):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::Rope::Fiber::Fiber):
(JSC::Rope::Fiber::deref):
(JSC::Rope::Fiber::ref):
(JSC::Rope::Fiber::refAndGetLength):
(JSC::Rope::Fiber::isRope):
(JSC::Rope::Fiber::rope):
(JSC::Rope::Fiber::isString):
(JSC::Rope::Fiber::string):
(JSC::Rope::Fiber::nonFiber):
(JSC::Rope::tryCreateUninitialized):
(JSC::Rope::append):
(JSC::Rope::fiberCount):
(JSC::Rope::length):
(JSC::Rope::fibers):
(JSC::Rope::Rope):
(JSC::Rope::operator new):
(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::length):
(JSC::RopeBuilder::canGetIndex):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::isRope):
(JSC::RopeBuilder::fiberCount):
(JSC::JSString::getStringPropertySlot):
* runtime/Operations.h:
(JSC::jsString):
2010-02-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Build fix).
Add missing cast for !YARR (PPC) builds.
* runtime/RegExp.cpp:
(JSC::RegExp::match):
2010-02-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33731
Many false leaks in release builds due to PtrAndFlags
StructureTransitionTable was effectively a smart pointer type,
one machine word in size and wholly contained as a member of
of Structure. It either pointed to an actual table, or could
be used to describe a single transtion entry without use of a
table.
This, however, worked by using a PtrAndFlags, which is not
compatible with the leaks tool. Since there is no clear way to
obtain another bit for 'free' here, and since there are bits
available up in Structure, merge this functionality back up into
Structure. Having this in a separate class was quite clean
from an enacapsulation perspective, but this solution doesn't
seem to bad - all table access is now intermediated through the
Structure::structureTransitionTableFoo methods, keeping the
optimization fairly well contained.
This was the last use of PtrAndFlags, so removing the file too.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::hasTransition):
* runtime/Structure.h:
(JSC::Structure::):
(JSC::Structure::structureTransitionTableContains):
(JSC::Structure::structureTransitionTableGet):
(JSC::Structure::structureTransitionTableHasTransition):
(JSC::Structure::structureTransitionTableRemove):
(JSC::Structure::structureTransitionTableAdd):
(JSC::Structure::structureTransitionTable):
(JSC::Structure::setStructureTransitionTable):
(JSC::Structure::singleTransition):
(JSC::Structure::setSingleTransition):
* runtime/StructureTransitionTable.h:
* wtf/PtrAndFlags.h: Removed.
2010-02-15 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Geoff Garen.
Bug 34948 - tryMakeString should fail on error in length calculation
Ooops! - "bool overflow" argument should have been "bool& overflow".
* runtime/UString.h:
(JSC::sumWithOverflow):
(JSC::tryMakeString):
2010-02-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Build Fix (pt 2!)).
Some symbol names have changed, remove, will readd if required.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-02-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Build Fix (pt 1?)).
Some symbol names have changed, remove, will readd if required.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-02-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed some mistaken code added in http://trac.webkit.org/changeset/53860.
* API/APIShims.h:
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim): No need to start/stop the
timeout checker when calling out from the API to the client; we want to
monitor the VM for timeouts, not the client. This mistake was harmless /
undetectable, since it's totally redundant with the APIEntryShim, which
also starts / stops the timeout checker.
2010-02-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 34952 - String lengths in UString should be unsigned.
This matches WebCore::StringImpl, and better unifies behaviour throughout JSC.
* JavaScriptCore.exp:
* bytecode/EvalCodeCache.h:
* runtime/Identifier.cpp:
(JSC::Identifier::equal):
* runtime/Identifier.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEscape):
* runtime/JSONObject.cpp:
(JSC::gap):
(JSC::Stringifier::indent):
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
* runtime/RegExp.cpp:
(JSC::RegExp::match):
* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncSplit):
(JSC::trimString):
* runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::getCString):
(JSC::UString::ascii):
(JSC::UString::operator[]):
(JSC::UString::toStrictUInt32):
(JSC::UString::find):
(JSC::UString::rfind):
(JSC::UString::substr):
(JSC::operator<):
(JSC::operator>):
(JSC::compare):
(JSC::equal):
(JSC::UString::UTF8String):
* runtime/UString.h:
(JSC::UString::size):
(JSC::operator==):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:
(JSC::UStringImpl::create):
(JSC::UStringImpl::size):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::UStringImpl):
2010-02-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 34948 - tryMakeString should fail on error in length calculation
The sum of the length of substrings could overflow.
* runtime/UString.h:
(JSC::sumWithOverflow):
(JSC::tryMakeString):
2010-02-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed <rdar://problem/7628524> Crash beneath JSGlobalContextRelease when
typing in Google search field with GuardMalloc/full page heap enabled
* API/JSContextRef.cpp: Don't use APIEntryShim, since that requires
a JSGlobalData, which this function destroys. Do use setCurrentIdentifierTable
and JSLock instead, since those are the two features of APIEntryShim we
require.
2010-02-15 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
Added additional parameter to create_rvct_stubs
for setting the offset of thunkReturnAddress.
https://bugs.webkit.org/show_bug.cgi?id=34657
* create_rvct_stubs:
* jit/JITStubs.cpp:
2010-02-15 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::toIntXX methods.
More ECMA Script compliance.
[Qt] QScriptValue::toIntXX returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34847
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::toInteger):
(QScriptValuePrivate::toInt32):
(QScriptValuePrivate::toUInt32):
(QScriptValuePrivate::toUInt16):
* qt/tests/qscriptvalue/tst_qscriptvalue.h:
* qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:
(tst_QScriptValue::toInteger_initData):
(tst_QScriptValue::toInteger_makeData):
(tst_QScriptValue::toInteger_test):
(tst_QScriptValue::toInt32_initData):
(tst_QScriptValue::toInt32_makeData):
(tst_QScriptValue::toInt32_test):
(tst_QScriptValue::toUInt32_initData):
(tst_QScriptValue::toUInt32_makeData):
(tst_QScriptValue::toUInt32_test):
(tst_QScriptValue::toUInt16_initData):
(tst_QScriptValue::toUInt16_makeData):
(tst_QScriptValue::toUInt16_test):
2010-02-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Adam Barth.
Implement NEVER_INLINE and NO_RETURN for RVCT
https://bugs.webkit.org/show_bug.cgi?id=34740
* wtf/AlwaysInline.h:
2010-02-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from JIT data stuctures.
These break the OS X Leaks tool. Free up a bit in CallLinkInfo, and invalid
permutation of pointer states in MethodCallLinkInfo to represent the removed bits.
* bytecode/CodeBlock.h:
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
* jit/JIT.cpp:
(JSC::JIT::unlinkCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* runtime/UString.h:
2010-02-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33731
Many false leaks in release builds due to PtrAndFlags
Remove UntypedPtrAndBitfield (similar to PtrAndFlags) in UStringImpl,
and steal bits from the refCount instead.
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
(JSC::UStringImpl::):
2010-02-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Removed an unnecessary data dependency from my last patch.
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::markChildren): Since isAnyStringMarked being false
is a condition of entering the loop, we can just use '=' instead of '|='.
2010-02-12 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Tor Arne Vestbø.
Additional refptr/passrefptr workarounds for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=28054
* wtf/PassRefPtr.h:
(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):
* wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::::operator):
2010-02-12 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Tor Arne Vestbø.
Additional refptr/passrefptr workarounds for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=28054
* wtf/PassRefPtr.h:
(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):
* wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::::operator):
2010-02-12 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Tor Arne Vestbø.
Additional refptr/passrefptr workarounds for WINSCW compiler
https://bugs.webkit.org/show_bug.cgi?id=28054
* wtf/PassRefPtr.h:
(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):
* wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::::operator):
2010-02-12 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
Don't import the cmath functions from std:: for WINSCW.
* wtf/MathExtras.h:
2010-02-12 Kwang Yul Seo <skyul@company100.net>
Reviewed by Adam Barth.
Typedef both JSChar and UChar to wchar_t in RVCT.
https://bugs.webkit.org/show_bug.cgi?id=34560
Define both JSChar and UChar to wchar_t as the size
of wchar_t is 2 bytes in RVCT.
* API/JSStringRef.h:
* wtf/unicode/qt4/UnicodeQt4.h:
2010-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Darin Adler.
The rest of the fix for
https://bugs.webkit.org/show_bug.cgi?id=34864 | <rdar://problem/7594198>
Many objects left uncollected after visiting mail.google.com and closing
window
Don't unconditionally hang onto small strings. Instead, hang onto all
small strings as long as any small string is still referenced.
SunSpider reports no change.
* runtime/Collector.cpp:
(JSC::Heap::markRoots): Mark the small strings cache last, so it can
check if anything else has kept any strings alive.
* runtime/SmallStrings.cpp:
(JSC::isMarked):
(JSC::SmallStrings::markChildren): Only keep our strings alive if some
other reference to at least one of them exists, too.
2010-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Some progress toward fixing
https://bugs.webkit.org/show_bug.cgi?id=34864 | <rdar://problem/7594198>
Many objects left uncollected after visiting mail.google.com and closing
window
SunSpider reports no change.
Keep weak references, rather than protected references, to cached for-in
property name enumerators.
One problem with protected references is that a chain like
[ gc object 1 ] => [ non-gc object ] => [ gc object 2 ]
takes two GC passes to break, since the first pass collects [ gc object 1 ],
releasing [ non-gc object ] and unprotecting [ gc object 2 ], and only
then can a second pass collect [ gc object 2 ].
Another problem with protected references is that they can keep a bunch
of strings alive long after they're useful. In SunSpider and a few popular
websites, the size-speed tradeoff seems to favor weak references.
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator): Moved this constructor
into the .cpp file, since it's not used elsewhere.
(JSC::JSPropertyNameIterator::~JSPropertyNameIterator): Added a destructor
to support our weak reference.
* runtime/JSPropertyNameIterator.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::clearEnumerationCache):
(JSC::Structure::enumerationCache): Added a function for clearing a
Structure's enumeration cache, used by our new destructor. Also fixed
indentation to match the rest of the file.
* runtime/Structure.h: Changed from protected pointer to weak pointer.
2010-02-11 Chris Rogers <crogers@google.com>
Reviewed by David Levin.
audio engine: add Complex number class
https://bugs.webkit.org/show_bug.cgi?id=34538
* wtf/Complex.h: Added.
(WebCore::complexFromMagnitudePhase):
2010-02-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added an SPI for asking about all the different live objects on the heap.
Useful for memory debugging.
* JavaScriptCore.exp: Export the new SPI.
* runtime/Collector.cpp:
(JSC::typeName): Use a little capitalization. Don't crash in the case of
a non-object cell, since it might just be an uninitialized cell.
(JSC::Heap::objectTypeCounts): The new SPI.
* runtime/Collector.h:
* runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::advance):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::operator++): Made 2 tweaks to these iterators:
(1) Skip the last cell in the block, since it's a dummy sentinel, and
we don't want it to confuse the object count; (2) Fixed a logic error
in LiveObjectIterator that could cause it to iterate dead objects if
m_block were equal to m_heap.nextBlock and m_cell were less than
m_heap.nextCell. No test for this since I can't think of a way that this
could make WebKit behave badly.
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Guard cmath using declarations in MathExtras.h on Android
https://bugs.webkit.org/show_bug.cgi?id=34840
Android does not provide these functions.
* wtf/MathExtras.h:
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
* Configurations/FeatureDefines.xcconfig:
2010-02-10 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Add Windows complex text support and Mac support for containsCharacters.
https://bugs.webkit.org/show_bug.cgi?id=34759
* wscript:
2010-02-10 Alexey Proskuryakov <ap@apple.com>
Addressing issues found by style bot.
* wtf/ValueCheck.h: Renamed header guard to match final file name.
* wtf/Vector.h: (WTF::::checkConsistency): Remove braces around a one-line clause.
2010-02-09 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=34490
WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
Added ValueCheck.h.
* wtf/ValueCheck.h: Added. Moved code out of HashTraits, since it would be awkward to
include that from Vector.h.
(WTF::ValueCheck::checkConsistency): Allow null pointers, those are pretty consistent.
* wtf/HashTraits.h: Moved value checking code out of here.
* wtf/HashTable.h: (WTF::::checkTableConsistencyExceptSize): Updated for the above changes.
* wtf/Vector.h:
(WTF::::checkConsistency): Check all vector elements.
(WTF::ValueCheck): Support checking a Vector as an element in other containers. Currently
unused.
2010-02-10 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::toBool.
Fix ECMA compliance in the QScriptValue for values like 0, NaN and
empty strings.
[Qt] QScriptValue::toBool problem
https://bugs.webkit.org/show_bug.cgi?id=34793
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::toBool):
* qt/tests/qscriptvalue/tst_qscriptvalue.h:
* qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:
(tst_QScriptValue::toBool_initData):
(tst_QScriptValue::toBool_makeData):
(tst_QScriptValue::toBool_test):
(tst_QScriptValue::toBoolean_initData):
(tst_QScriptValue::toBoolean_makeData):
(tst_QScriptValue::toBoolean_test):
2009-10-06 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
Use derefIfNotNull() to work around WINSCW compiler forward declaration bug
The compiler bug is reported at
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
The change should be reverted when the above bug is fixed in WINSCW compiler.
https://bugs.webkit.org/show_bug.cgi?id=28054
2009-10-06 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
Get rid of WINSCW hack for UnSpecifiedBoolType
Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make the WINSCW
compiler work with the default UnSpecifiedBoolType() operator.
https://bugs.webkit.org/show_bug.cgi?id=28054
* wtf/RefPtr.h:
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
New functions nullValue() and undefinedValue().
[Qt] QScriptEngine should contain nullValue and undefinedValue methods
https://bugs.webkit.org/show_bug.cgi?id=34749
* qt/api/qscriptengine.cpp:
(QScriptEngine::nullValue):
(QScriptEngine::undefinedValue):
* qt/api/qscriptengine.h:
* qt/tests/qscriptengine/tst_qscriptengine.cpp:
(tst_QScriptEngine::nullValue):
(tst_QScriptEngine::undefinedValue):
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fixes for QScriptValue::toNumber().
Fix ECMA compliance in QScriptValue for values unbound
to a QScriptEngine.
[Qt] QScriptValue::toNumber() is broken
https://bugs.webkit.org/show_bug.cgi?id=34592
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::toNumber):
* qt/tests/qscriptvalue/tst_qscriptvalue.h:
* qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:
(tst_QScriptValue::toNumber_initData):
(tst_QScriptValue::toNumber_makeData):
(tst_QScriptValue::toNumber_test):
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::isNumber().
The isNumber() should return 'true' if the value is in the CNumber
state.
[Qt] QScriptValue::isNumber() returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=34575
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::isNumber):
* qt/tests/qscriptvalue/tst_qscriptvalue.h:
* qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:
(tst_QScriptValue::isNumber_initData):
(tst_QScriptValue::isNumber_makeData):
(tst_QScriptValue::isNumber_test):
2010-02-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Small refactoring to the small strings cache to allow it to be cleared
dynamically.
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::clear):
* runtime/SmallStrings.h: Moved initialization code into a shared function,
and changed the constructor to call it.
2010-02-09 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Geoff Garen.
Rename StringBuilder::release && JSStringBuilder::releaseJSString
to 'build()'.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::paramString):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
* runtime/JSONObject.cpp:
(JSC::Stringifier::stringify):
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::build):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lexString):
* runtime/NumberPrototype.cpp:
(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):
* runtime/StringBuilder.h:
(JSC::StringBuilder::build):
2010-02-09 John Sullivan <sullivan@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=34772
Overzealous new assertion in URStringImpl::adopt()
Reviewed by Adam Barth.
* runtime/UStringImpl.h:
(JSC::UStringImpl::adopt):
Only assert that vector.data() is non-zero if vector.size() is non-zero.
2010-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to fix build problem on SnowLeopard slaves to bring them back.
* API/JSClassRef.cpp:
(tryCreateStringFromUTF8): Mark method as 'static inline' to suppress "warning: no previous prototype for ..."
2010-02-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Three small string fixes:
(1) StringBuilder::release should CRASH if the buffer allocation failed.
(2) Remove weird, dead code from JSString::tryGetValue, replace with an ASSERT.
(3) Move UString::createFromUTF8 out to the API, as tryCreateStringFromUTF8.
This is only used from the API, and (now) unlike other UString::create
methods may return UString::null() to indicate failure cases. Better
handle these in the API.
* API/JSClassRef.cpp:
(tryCreateStringFromUTF8):
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
* runtime/JSString.h:
(JSC::Fiber::tryGetValue):
* runtime/StringBuilder.h:
(JSC::StringBuilder::release):
* runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::find):
* runtime/UString.h:
2010-02-09 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Laszlo Gombos.
[Qt] use nanval() for Symbian as nonInlineNaN
https://bugs.webkit.org/show_bug.cgi?id=34170
numeric_limits<double>::quiet_NaN is broken in Symbian
causing NaN to be evaluated as a number.
* runtime/JSValue.cpp:
(JSC::nonInlineNaN):
2010-02-09 Tamas Szirbucz <szirbucz@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add a soft modulo operation to ARM JIT using a trampoline function.
The performance progression is about ~1.8% on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=34424
Developed in cooperation with Gabor Loki.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
* jit/JITOpcodes.cpp:
(JSC::JIT::softModulo):
* jit/JITStubs.h:
(JSC::JITThunks::ctiSoftModulo):
* wtf/Platform.h:
2010-02-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (SL/win build fixes).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/StringPrototype.cpp:
2010-02-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt
Make String.replace throw an exception on out-of-memory, rather than
returning a null (err, empty-ish) string. Move String::replaceRange
and String::spliceSubstringsWithSeparators out to StringPrototype -
these were fairly specific use anyway, and we can better integrate
throwing the JS expcetion this way.
Also removes redundant assignment operator from UString.
* JavaScriptCore.exp:
* runtime/StringPrototype.cpp:
(JSC::StringRange::StringRange):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::jsReplaceRange):
(JSC::stringProtoFuncReplace):
* runtime/UString.cpp:
* runtime/UString.h:
2010-02-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Undefine WTF_OS_WINDOWS and WTF_PLATFORM_WIN
https://bugs.webkit.org/show_bug.cgi?id=34561
As the binary for simulator is built with MSVC 2005,
WTF_OS_WINDOWS and WTF_PLATFORM_WIN are defined.
Undefine them as we don't target Windows.
* wtf/Platform.h:
2010-02-08 Chris Rogers <crogers@google.com>
Reviewed by Darin Adler.
audio engine: add Vector3 class
https://bugs.webkit.org/show_bug.cgi?id=34548
* wtf/Vector3.h: Added.
(WebCore::Vector3::Vector3):
(WebCore::Vector3::abs):
(WebCore::Vector3::isZero):
(WebCore::Vector3::normalize):
(WebCore::Vector3::x):
(WebCore::Vector3::y):
(WebCore::Vector3::z):
(WebCore::operator+):
(WebCore::operator-):
(WebCore::operator*):
(WebCore::dot):
(WebCore::cross):
(WebCore::distance):
2010-02-08 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Fix warning in clang++
* runtime/Structure.h:
(JSC::Structure::propertyStorageSize):
2010-02-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Make makeString CRASH if we fail to allocate a string.
(tryMakeString or jsMakeNontrivialString can be used where we
expect allocation may fail and want to handle the error).
* runtime/JSStringBuilder.h:
(JSC::jsMakeNontrivialString):
* runtime/UString.h:
(JSC::tryMakeString):
(JSC::makeString):
2010-02-08 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Oliver Hunt.
Remove a couple of unnecesary C-style casts spotted by Darin.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncEscape):
2010-02-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Switch some more StringBuilder/jsNontrivialString code to use
JSStringBuilder/jsMakeNontrivialString - these methods will
throw an exception if we hit out-of-memory, rather than just
CRASHing.
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
2010-02-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Use an empty identifier instead of a null identifier for parse
tokens without an identifier.
This helps encapsulate the null UStringImpl within UString.
* parser/Grammar.y:
* parser/NodeConstructors.h:
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):
* runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
* runtime/CommonIdentifiers.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
2010-02-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Build fix for make distcheck.
* GNUmakefile.am:
2010-02-08 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed RVCT build fix.
Similar to r54391, don't import the cmath functions from std:: for RVCT.
* wtf/MathExtras.h:
2010-02-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Change UStringImpl::create to CRASH if the string cannot be allocated,
rather than returning a null string (which will behave like a zero-length
string if used).
Also move createRep function from UString to become new overloaded
UStringImpl::create methods. In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.
With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.
* JavaScriptCore.exp:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
* parser/Parser.cpp:
(JSC::Parser::parse):
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
* runtime/Error.cpp:
(JSC::Error::create):
(JSC::throwError):
* runtime/ExceptionHelpers.cpp:
(JSC::createError):
* runtime/Identifier.cpp:
(JSC::Identifier::add):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):
* runtime/UString.h:
(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:
2010-02-05 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Define SYSTEM_MALLOC 1
https://bugs.webkit.org/show_bug.cgi?id=34640
Make BREWMP use system malloc because FastMalloc is not ported.
* wtf/Platform.h:
2010-02-05 Kwang Yul Seo <skyul@company100.net>
Reviewed by Alexey Proskuryakov.
Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569
With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.
However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.
If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.
* wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
2010-02-04 Mark Rowe <mrowe@apple.com>
Reviewed by Timothy Hatcher.
Build fix. Remove a symbol corresponding to an inline function from the linker export
file to prevent a weak external failure.
* JavaScriptCore.xcodeproj/project.pbxproj: Accommodate rename of script.
2010-02-04 Daniel Bates <dbates@webkit.org>
[Qt] Unreviewed, build fix for Qt bot.
* runtime/JSStringBuilder.h: Changed #include <X.h> notation #include "X.h".
2010-02-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Clearing a WeakGCPtr is weird
https://bugs.webkit.org/show_bug.cgi?id=34627
Added a WeakGCPtr::clear interface.
As discussed in https://bugs.webkit.org/show_bug.cgi?id=33383, the old
interface made it pretty weird for a client to conditionally clear a
WeakGCPtr, which is exactly what clients want to do when objects are
finalized.
* API/JSClassRef.cpp:
(clearReferenceToPrototype): Use the new WeakGCPtr::clear() interface.
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::clear): Added an interface for clearing a WeakGCPtr,
iff its current value is the value passed in. It's cumbersome for the
client to do this test, since WeakGCPtr sometimes pretends to be null.
2010-02-04 Geoffrey Garen <ggaren@apple.com>
Build fix: export a header.
* JavaScriptCore.xcodeproj/project.pbxproj:
2010-02-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
construct JSStrings, throwing a JS exception should we run out of memory whilst
allocating storage for the string.
Similarly, add jsMakeNontrivialString methods to use in cases where previously
we were calling makeString & passing the result to jsNontrivialString. Again,
these new methods throw if we hit an out of memory condition.
Move throwOutOfMemoryError into ExceptionHelpers, to make it more widely available.
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
* runtime/DateConstructor.cpp:
(JSC::callDate):
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToGMTString):
* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
* runtime/ExceptionHelpers.cpp:
(JSC::throwOutOfMemoryError):
* runtime/ExceptionHelpers.h:
* runtime/JSStringBuilder.h: Added.
(JSC::JSStringBuilder::releaseJSString):
(JSC::jsMakeNontrivialString):
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToPrecision):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
* runtime/Operations.cpp:
* runtime/Operations.h:
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
* runtime/StringBuilder.h:
(JSC::StringBuilder::append):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
2010-02-04 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
* wtf/MathExtras.h:
2010-02-04 Darin Adler <darin@apple.com>
Reviewed by David Levin.
Make MathExtras.h compatible with <cmath>
https://bugs.webkit.org/show_bug.cgi?id=34618
* wtf/MathExtras.h: Include <cmath> instead of <math.h>.
Use "using" as we do elsewhere in WTF for the four functions from <cmath>
we want to use without the prefix. Later we could consider making the std
explicit at call sites instead.
2010-02-04 Tamas Szirbucz <szirbucz@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Use an easily appendable structure for trampolines instead of pointer parameters.
https://bugs.webkit.org/show_bug.cgi?id=34424
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiNativeCallThunk):
2010-02-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Increase test coverage for the QScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=34533
* qt/tests/qscriptvalue/qscriptvalue.pro:
* qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
(tst_QScriptValue::tst_QScriptValue):
(tst_QScriptValue::~tst_QScriptValue):
(tst_QScriptValue::dataHelper):
(tst_QScriptValue::newRow):
(tst_QScriptValue::testHelper):
(tst_QScriptValue::ctor):
* qt/tests/qscriptvalue/tst_qscriptvalue.h: Added.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Added.
(tst_QScriptValue::initScriptValues):
(tst_QScriptValue::isValid_initData):
(tst_QScriptValue::isValid_makeData):
(tst_QScriptValue::isValid_test):
(tst_QScriptValue::isBool_initData):
(tst_QScriptValue::isBool_makeData):
(tst_QScriptValue::isBool_test):
(tst_QScriptValue::isBoolean_initData):
(tst_QScriptValue::isBoolean_makeData):
(tst_QScriptValue::isBoolean_test):
(tst_QScriptValue::isFunction_initData):
(tst_QScriptValue::isFunction_makeData):
(tst_QScriptValue::isFunction_test):
(tst_QScriptValue::isNull_initData):
(tst_QScriptValue::isNull_makeData):
(tst_QScriptValue::isNull_test):
(tst_QScriptValue::isString_initData):
(tst_QScriptValue::isString_makeData):
(tst_QScriptValue::isString_test):
(tst_QScriptValue::isUndefined_initData):
(tst_QScriptValue::isUndefined_makeData):
(tst_QScriptValue::isUndefined_test):
(tst_QScriptValue::isObject_initData):
(tst_QScriptValue::isObject_makeData):
(tst_QScriptValue::isObject_test):
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
https://bugs.webkit.org/show_bug.cgi?id=34514
PLATFORM(BREWMP_SIMULATOR) guard is needed to make distinction between BREWMP
and BREWMP simulator.
* wtf/Platform.h:
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
https://bugs.webkit.org/show_bug.cgi?id=34190
COMPILE_ASSERT conflicts with the underlying PLATFORM because it is defined
both in WTF's Assertions.h and BREWMP's AEEClassIDs.h. Include AEEClassIDs.h
in Assertions.h and undef COMPILE_ASSERT to avoid redefining COMPILE_ASSERT.
* wtf/Assertions.h:
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
https://bugs.webkit.org/show_bug.cgi?id=34518
Add OwnPtrBrew to release IFile, IFileMgr and IBitmap instances.
* wtf/brew/OwnPtrBrew.cpp: Added.
(WTF::IFileMgr):
(WTF::IFile):
(WTF::IBitmap):
(WTF::freeOwnedPtrBrew):
* wtf/brew/OwnPtrBrew.h: Added.
(WTF::OwnPtrBrew::OwnPtrBrew):
(WTF::OwnPtrBrew::~OwnPtrBrew):
(WTF::OwnPtrBrew::get):
(WTF::OwnPtrBrew::release):
(WTF::OwnPtrBrew::outPtr):
(WTF::OwnPtrBrew::set):
(WTF::OwnPtrBrew::clear):
(WTF::OwnPtrBrew::operator*):
(WTF::OwnPtrBrew::operator->):
(WTF::OwnPtrBrew::operator!):
(WTF::OwnPtrBrew::operator UnspecifiedBoolType):
(WTF::OwnPtrBrew::swap):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::getPtr):
2010-02-03 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Export WTF::fastStrDup symbol
https://bugs.webkit.org/show_bug.cgi?id=34526
* JavaScriptCore.exp:
2010-02-03 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Enable JIT compilation for wx.
https://bugs.webkit.org/show_bug.cgi?id=34536
* wtf/Platform.h:
2010-02-02 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Crash in CollectorBitmap::get at nbcolympics.com
https://bugs.webkit.org/show_bug.cgi?id=34504
This was caused by the use of m_offset to determine the offset of
a new property into the property storage. This patch corrects
the effected cases by incorporating the anonymous slot count. It
also removes the duplicate copy of anonymous slot count from the
property table as keeping this up to date merely increased the
chance of a mismatch. Finally I've added a large number of
assertions in an attempt to prevent such a bug from happening
again.
With the new assertions in place the existing anonymous slot tests
all fail without the m_offset fixes.
* runtime/PropertyMapHashTable.h:
* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::insertIntoPropertyMapHashTable):
(JSC::Structure::createPropertyMapHashTable):
(JSC::Structure::rehashPropertyMapHashTable):
(JSC::Structure::checkConsistency):
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy main thread functions
https://bugs.webkit.org/show_bug.cgi?id=33569
Add dummy initializeMainThreadPlatform and
scheduleDispatchFunctionsOnMainThread.
* wtf/brew/MainThreadBrew.cpp: Added.
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Add using WTF::getLocalTime to CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=34493
* wtf/CurrentTime.h:
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add HAVE_XXX definitions
https://bugs.webkit.org/show_bug.cgi?id=34414
Add HAVE_ERRNO_H=1
* wtf/Platform.h:
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Don't define HAVE_TM_GMTOFF, HAVE_TM_ZONE and HAVE_TIMEGM
https://bugs.webkit.org/show_bug.cgi?id=34388
BREWMP does not have these features.
* wtf/Platform.h:
2010-02-02 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Define WTF_PLATFORM_BREWMP=1 when BUILDING_BREWMP is defined
https://bugs.webkit.org/show_bug.cgi?id=34386
Define WTF_PLATFORM_BREWMP=1 so that PLATFORM(BREWMP) guard can be used.
* wtf/Platform.h:
2010-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Date.UTC() should apply TimeClip operation.
https://bugs.webkit.org/show_bug.cgi?id=34461
ECMAScript 5 15.9.4.3:
> 9 Return TimeClip(MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli))).
* runtime/DateConstructor.cpp:
(JSC::dateUTC): Calls WTF::timeClip().
2010-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that Math.round() retunrs incorrect results for huge integers
https://bugs.webkit.org/show_bug.cgi?id=34462
* runtime/MathObject.cpp:
(JSC::mathProtoFuncRound): Avoid "arg + 0.5".
2010-02-01 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port WTF's currentTime
https://bugs.webkit.org/show_bug.cgi?id=33567
Combine GETUTCSECONDS and GETTIMEMS to calculate the number
of milliseconds since 1970/01/01 00:00:00 UTC.
* wtf/CurrentTime.cpp:
(WTF::currentTime):
2010-02-01 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
[Qt] WinCE buildfix after r52729 and fix for Q_BIG_ENDIAN typo.
https://bugs.webkit.org/show_bug.cgi?id=34378
* wtf/Platform.h:
2010-02-01 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Structure not accounting for anonymous slots when computing property storage size
https://bugs.webkit.org/show_bug.cgi?id=34441
Previously any Structure with anonymous storage would have a property map, so we
were only including anonymous slot size if there was a property map. Given this
is no longer the case we should always include the anonymous slot count in the
property storage size.
* runtime/Structure.h:
(JSC::Structure::propertyStorageSize):
2010-02-01 Oliver Hunt <oliver@apple.com>
Windows build fix, update exports file (again)
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-02-01 Oliver Hunt <oliver@apple.com>
Windows build fix, update exports file
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-01-31 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321
Remove secondary Structure constructor, and make Structure store a copy
of the number of anonymous slots directly so saving an immediate allocation
of a property map for all structures with anonymous storage, which also
avoids the leaked property map on new property transition in the original
version of this patch.
We need to propagate the the anonymous slot count otherwise we can end up
with a structure recording incorrect information about the available and
needed space for property storage, or alternatively incorrectly reusing
some slots.
* JavaScriptCore.exp:
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::insertIntoPropertyMapHashTable):
(JSC::Structure::createPropertyMapHashTable):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::hasAnonymousSlots):
(JSC::Structure::anonymousSlotCount):
2010-01-31 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Buildfix for WinCE + style fixes (TLS_OUT_OF_INDEXES is not defined).
https://bugs.webkit.org/show_bug.cgi?id=34380
* wtf/ThreadSpecific.h:
2010-01-31 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
[Windows] Fix a bug of round() with huge integral numbers
https://bugs.webkit.org/show_bug.cgi?id=34297
Fix a bug that round() for huge integral numbers returns incorrect
results. For example, round(8639999913600001) returns
8639999913600002 without this change though the double type can
represent 8639999913600001 precisely.
Math.round() of JavaScript has a similar problem. But this change
doesn't fix it because Math.round() doesn't use round() of
MathExtra.h.
* wtf/MathExtras.h:
(round): Avoid to do "num + 0.5" or "num - 0.5".
(roundf): Fixed similarly.
(llround): Calls round().
(llroundf): Calls roundf().
(lround): Calls round().
(lroundf): Calls roundf().
2010-01-29 Mark Rowe <mrowe@apple.com>
Sort Xcode projects.
* JavaScriptCore.xcodeproj/project.pbxproj:
2010-01-29 Mark Rowe <mrowe@apple.com>
Fix the Mac build.
Disable ENABLE_INDEXED_DATABASE since it is "completely non-functional".
As the comment in FeatureDefines.xcconfig notes, the list of feature defines
needs to be kept in sync across the various files. The default values also
need to be kept in sync between these files and build-webkit.
* Configurations/FeatureDefines.xcconfig:
2010-01-29 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Maciej Stachowiak.
Fix the ARM build.
* runtime/JSNumberCell.h:
(JSC::JSNumberCell::createStructure): Call the right Structure::create overload.
2010-01-28 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
implements pthread_t in a way that makes it impossible to check its validity,
which is needed by ThreadingPthreads.cpp.
* wscript:
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
DOM Objects shouldn't all require custom mark functions
https://bugs.webkit.org/show_bug.cgi?id=34291
Make getAnonymousValue const-friendly
* runtime/JSObject.h:
(JSC::JSObject::getAnonymousValue):
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
A class must now specify the number of slots it needs at construction time
rather than later on with a transition. This makes many things simpler,
we no longer need to need an additional transition on object creation to
add the anonymous slots, and we remove the need for a number of transition
type checks.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* JavaScriptCore.exp:
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
* runtime/GlobalEvalFunction.h:
(JSC::GlobalEvalFunction::createStructure):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSCell.h:
(JSC::JSCell::createDummyStructure):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createStructure):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
(JSC::JSObject::putAnonymousValue):
(JSC::JSObject::getAnonymousValue):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSString.h:
(JSC::Fiber::createStructure):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
* runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::materializePropertyMap):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::anonymousSlotCount):
* runtime/StructureTransitionTable.h:
2010-01-27 Oliver Hunt <oliver@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Add logic to allow us to create an Object, Array, or Date instance
so we can create them in the context of a specific global object,
rather than just using the current lexical global object.
* JavaScriptCore.exp:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
* runtime/JSGlobalObject.h:
(JSC::constructEmptyObject):
(JSC::constructEmptyArray):
2010-01-27 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34150
WebKit needs a mechanism to catch stale HashMap entries
It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
is just its value, it is very unlikely that any observable problem is reproducible.
This extends hash table consistency checks to check that pointers are referencing allocated
memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).
* wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can
add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems
with those yet.
* wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by
CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
* wtf/HashTable.h:
(WTF::HashTable::internalCheckTableConsistency):
(WTF::HashTable::internalCheckTableConsistencyExceptSize):
(WTF::HashTable::checkTableConsistencyExceptSize):
Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off.
(WTF::::add): Updated for checkTableConsistency renaming.
(WTF::::addPassingHashCode): Ditto.
(WTF::::removeAndInvalidate): Ditto.
(WTF::::remove): Ditto.
(WTF::::rehash): Ditto.
(WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this
function returns true for tables with m_table == 0.
(WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially,
we could do the same for values.
* wtf/HashTraits.h:
(WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden
to add checks. Currently, the only override is for pointer hashes.
* wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
2010-01-27 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Adler.
Remove trailing \ from inline function code
https://bugs.webkit.org/show_bug.cgi?id=34223
* assembler/ARMv7Assembler.h:
(JSC::ARMThumbImmediate::countLeadingZerosPartial):
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port WTF's randomNumber
https://bugs.webkit.org/show_bug.cgi?id=33566
Use GETRAND to generate 4 byte random byte sequence to implement
weakRandomNumber. Create a secure random number generator with
AEECLSID_RANDOM to implement randomNumber.
* wtf/RandomNumber.cpp:
(WTF::weakRandomNumber):
(WTF::randomNumber):
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port getCPUTime
https://bugs.webkit.org/show_bug.cgi?id=33572
Use GETUPTIMEMS which returns a continuously and
linearly increasing millisecond timer from the time the device
was powered on. This function is enough to implement getCPUTime.
* runtime/TimeoutChecker.cpp:
(JSC::getCPUTime):
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Oliver Hunt.
[BREWMP] Add MarkStack fastMalloc implementation for platforms without VirtualAlloc or mmap.
https://bugs.webkit.org/show_bug.cgi?id=33582
Use fastMalloc and fastFree to implement MarkStack::allocateStack and
MarkStack::releaseStack for platforms without page level allocation.
* runtime/MarkStack.h:
(JSC::MarkStack::MarkStackArray::shrinkAllocation):
* runtime/MarkStackNone.cpp: Added.
(JSC::MarkStack::initializePagesize):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Don't use time function
https://bugs.webkit.org/show_bug.cgi?id=33577
Calling time(0) in BREW devices causes a crash because time
is not properly ported in most devices. Cast currentTime() to
time_t to get the same result as time(0).
* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
2010-01-27 Alexey Proskuryakov <ap@apple.com>
Revert r53899 (HashMap<AtomicStringImpl*, Value> key checks) and subsequent build fixes,
because they make SVG tests crash in release builds.
* wtf/HashMap.h:
(WTF::::remove):
* wtf/HashSet.h:
(WTF::::remove):
* wtf/HashTable.h:
(WTF::::add):
(WTF::::addPassingHashCode):
(WTF::::removeAndInvalidate):
(WTF::::remove):
(WTF::::rehash):
(WTF::::checkTableConsistency):
(WTF::::checkTableConsistencyExceptSize):
* wtf/HashTraits.h:
(WTF::GenericHashTraits::emptyValue):
(WTF::):
* wtf/RefPtrHashMap.h:
(WTF::::remove):
2010-01-26 Alexey Proskuryakov <ap@apple.com>
More Windows build fixing.
* wtf/HashTraits.h: _msize takes void*, remove const qualifier from type.
2010-01-26 Alexey Proskuryakov <ap@apple.com>
Windows build fix.
* wtf/HashTraits.h: Include malloc.h for _msize().
2010-01-26 Alexey Proskuryakov <ap@apple.com>
Build fix.
* wtf/HashTable.h: (WTF::HashTable::checkTableConsistencyExceptSize): Remove const from a
static (empty) version of this function.
2010-01-26 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34150
WebKit needs a mechanism to catch stale HashMap entries
It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
is just its value, it is very unlikely that any observable problem is reproducible.
This extends hash table consistency checks to check that pointers are referencing allocated
memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).
* wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can
add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems
with those yet.
* wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by
CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
* wtf/HashTable.h:
(WTF::HashTable::internalCheckTableConsistency):
(WTF::HashTable::internalCheckTableConsistencyExceptSize):
(WTF::HashTable::checkTableConsistencyExceptSize):
Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off.
(WTF::::add): Updated for checkTableConsistency renaming.
(WTF::::addPassingHashCode): Ditto.
(WTF::::removeAndInvalidate): Ditto.
(WTF::::remove): Ditto.
(WTF::::rehash): Ditto.
(WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this
function returns true for tables with m_table == 0.
(WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially,
we could do the same for values.
* wtf/HashTraits.h:
(WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden
to add checks. Currently, the only override is for pointer hashes.
* wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
2010-01-26 Lyon Chen <liachen@rim.com>
Reviewed by Maciej Stachowiak.
Opcode.h use const void* for Opcode cause error #1211 for RVCT compiler
https://bugs.webkit.org/show_bug.cgi?id=33902
* bytecode/Opcode.h:
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
2010-01-26 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Using JavaScriptCore API with a webkit vended context can result in slow script dialog
https://bugs.webkit.org/show_bug.cgi?id=34172
Make the APIShim correctly increment and decrement the timeout
entry counter.
* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
2010-01-26 Simon Hausmann <simon.hausmann@nokia.com>
[Qt] Fix compilation of QtScript with non-gcc compilers
Variable length stack arrays are a gcc extension. Use QVarLengthArray
as a more portable solution that still tries to allocate on the stack
first.
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::call):
2010-01-26 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix the build on platforms without JIT support.
The JIT support should be determined at compile-time via wtf/Platform.h
* qt/api/QtScript.pro:
2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
First steps of the QtScript API.
Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.
This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.
https://bugs.webkit.org/show_bug.cgi?id=32565
* qt/api/QtScript.pro: Added.
* qt/api/qscriptconverter_p.h: Added.
(QScriptConverter::toString):
* qt/api/qscriptengine.cpp: Added.
(QScriptEngine::QScriptEngine):
(QScriptEngine::~QScriptEngine):
(QScriptEngine::evaluate):
(QScriptEngine::collectGarbage):
* qt/api/qscriptengine.h: Added.
* qt/api/qscriptengine_p.cpp: Added.
(QScriptEnginePrivate::QScriptEnginePrivate):
(QScriptEnginePrivate::~QScriptEnginePrivate):
(QScriptEnginePrivate::evaluate):
* qt/api/qscriptengine_p.h: Added.
(QScriptEnginePrivate::get):
(QScriptEnginePrivate::collectGarbage):
(QScriptEnginePrivate::makeJSValue):
(QScriptEnginePrivate::context):
* qt/api/qscriptvalue.cpp: Added.
(QScriptValue::QScriptValue):
(QScriptValue::~QScriptValue):
(QScriptValue::isValid):
(QScriptValue::isBool):
(QScriptValue::isBoolean):
(QScriptValue::isNumber):
(QScriptValue::isNull):
(QScriptValue::isString):
(QScriptValue::isUndefined):
(QScriptValue::isError):
(QScriptValue::isObject):
(QScriptValue::isFunction):
(QScriptValue::toString):
(QScriptValue::toNumber):
(QScriptValue::toBool):
(QScriptValue::toBoolean):
(QScriptValue::toInteger):
(QScriptValue::toInt32):
(QScriptValue::toUInt32):
(QScriptValue::toUInt16):
(QScriptValue::call):
(QScriptValue::engine):
(QScriptValue::operator=):
(QScriptValue::equals):
(QScriptValue::strictlyEquals):
* qt/api/qscriptvalue.h: Added.
(QScriptValue::):
* qt/api/qscriptvalue_p.h: Added.
(QScriptValuePrivate::):
(QScriptValuePrivate::get):
(QScriptValuePrivate::QScriptValuePrivate):
(QScriptValuePrivate::isValid):
(QScriptValuePrivate::isBool):
(QScriptValuePrivate::isNumber):
(QScriptValuePrivate::isNull):
(QScriptValuePrivate::isString):
(QScriptValuePrivate::isUndefined):
(QScriptValuePrivate::isError):
(QScriptValuePrivate::isObject):
(QScriptValuePrivate::isFunction):
(QScriptValuePrivate::toString):
(QScriptValuePrivate::toNumber):
(QScriptValuePrivate::toBool):
(QScriptValuePrivate::toInteger):
(QScriptValuePrivate::toInt32):
(QScriptValuePrivate::toUInt32):
(QScriptValuePrivate::toUInt16):
(QScriptValuePrivate::equals):
(QScriptValuePrivate::strictlyEquals):
(QScriptValuePrivate::assignEngine):
(QScriptValuePrivate::call):
(QScriptValuePrivate::engine):
(QScriptValuePrivate::context):
(QScriptValuePrivate::value):
(QScriptValuePrivate::object):
(QScriptValuePrivate::inherits):
(QScriptValuePrivate::isJSBased):
(QScriptValuePrivate::isNumberBased):
(QScriptValuePrivate::isStringBased):
* qt/api/qtscriptglobal.h: Added.
* qt/tests/qscriptengine/qscriptengine.pro: Added.
* qt/tests/qscriptengine/tst_qscriptengine.cpp: Added.
(tst_QScriptEngine::tst_QScriptEngine):
(tst_QScriptEngine::~tst_QScriptEngine):
(tst_QScriptEngine::init):
(tst_QScriptEngine::cleanup):
(tst_QScriptEngine::collectGarbage):
(tst_QScriptEngine::evaluate):
* qt/tests/qscriptvalue/qscriptvalue.pro: Added.
* qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Added.
(tst_QScriptValue::tst_QScriptValue):
(tst_QScriptValue::~tst_QScriptValue):
(tst_QScriptValue::init):
(tst_QScriptValue::cleanup):
(tst_QScriptValue::ctor):
(tst_QScriptValue::toString_data):
(tst_QScriptValue::toString):
(tst_QScriptValue::copyConstructor_data):
(tst_QScriptValue::copyConstructor):
(tst_QScriptValue::assignOperator_data):
(tst_QScriptValue::assignOperator):
(tst_QScriptValue::dataSharing):
(tst_QScriptValue::constructors_data):
(tst_QScriptValue::constructors):
(tst_QScriptValue::call):
* qt/tests/tests.pri: Added.
* qt/tests/tests.pro: Added.
2010-01-25 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
Fix Chromium Linux tests: the pthread functions on Linux produce segfault if they receive 0 thread handle.
After r53714, we can have 0 thread handles passed to pthread_join and pthread_detach if corresponding threads
were already terminated and their threadMap entries cleared.
Add a 0 check.
* wtf/ThreadingPthreads.cpp:
(WTF::waitForThreadCompletion):
(WTF::detachThread):
2010-01-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Maciej Stachowiak.
Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function
https://bugs.webkit.org/show_bug.cgi?id=33866
Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION
macro for those functions that are always present.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
2010-01-22 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Remove the Bakefile build system, which is no longer being used.
https://bugs.webkit.org/show_bug.cgi?id=34022
* JavaScriptCoreSources.bkl: Removed.
* jscore.bkl: Removed.
2010-01-22 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34025
Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
* Configurations/FeatureDefines.xcconfig:
2010-01-22 Dmitry Titov <dimich@chromium.org>
Not reviewed, attempted Snow Leopard build fix.
* wtf/ThreadingPthreads.cpp: Add a forward declaration of a function which is not 'static'.
2009-01-22 Dmitry Titov <dimich@chromium.org>
Reviewed by Maciej Stachowiak.
Fix the leak of ThreadIdentifiers in threadMap across threads.
https://bugs.webkit.org/show_bug.cgi?id=32689
Test is added to DumpRenderTree.mm.
* Android.mk: Added file ThreadIdentifierDataPthreads.(h|cpp) to build.
* Android.v8.wtf.mk: Ditto.
* GNUmakefile.am: Ditto.
* JavaScriptCore.gyp/JavaScriptCore.gyp: Ditto.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* wtf/ThreadIdentifierDataPthreads.cpp: Added. Contains custom implementation of thread-specific data that uses custom destructor.
(WTF::ThreadIdentifierData::~ThreadIdentifierData): Removes the ThreadIdentifier from the threadMap.
(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::destruct): Custom thread-specific destructor. Resets the value for the key again to cause second invoke.
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce): Need to use pthread_once since initialization may come on any thread(s).
* wtf/ThreadIdentifierDataPthreads.h: Added.
(WTF::ThreadIdentifierData::ThreadIdentifierData):
* wtf/Threading.cpp:
(WTF::threadEntryPoint): Move initializeCurrentThreadInternal to after the lock to make
sure it is invoked when ThreadIdentifier is already established.
* wtf/Threading.h: Rename setThreadNameInternal -> initializeCurrentThreadInternal since it does more then only set the name now.
* wtf/ThreadingNone.cpp:
(WTF::initializeCurrentThreadInternal): Ditto.
* wtf/ThreadingWin.cpp:
(WTF::initializeCurrentThreadInternal): Ditto.
(WTF::initializeThreading): Ditto.
* wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeCurrentThreadInternal): Ditto.
* wtf/qt/ThreadingQt.cpp:
(WTF::initializeCurrentThreadInternal): Ditto.
* wtf/ThreadingPthreads.cpp:
(WTF::establishIdentifierForPthreadHandle):
(WTF::clearPthreadHandleForIdentifier): Make it not 'static' so the ~ThreadIdentifierData() in another file can call it.
(WTF::initializeCurrentThreadInternal): Set the thread-specific data. The ThreadIdentifier is already established by creating thread.
(WTF::waitForThreadCompletion): Remove call to clearPthreadHandleForIdentifier(threadID) since it is now done in ~ThreadIdentifierData().
(WTF::detachThread): Ditto.
(WTF::currentThread): Use the thread-specific data to get the ThreadIdentifier. It's many times faster then Mutex-protected iteration through the map.
Also, set the thread-specific data if called first time on the thread.
2010-01-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Alexey Proskuryakov.
Add ThreadSpecific for ENABLE(SINGLE_THREADED)
https://bugs.webkit.org/show_bug.cgi?id=33878
Implement ThreadSpecific with a simple getter/setter
when ENABLE(SINGLE_THREADED) is true.
Due to the change in https://bugs.webkit.org/show_bug.cgi?id=33236,
an implementation of ThreadSpecific must be available to build WebKit.
This causes a build failure for platforms without a proper
ThreadSpecific implementation.
* wtf/ThreadSpecific.h:
(WTF::::ThreadSpecific):
(WTF::::~ThreadSpecific):
(WTF::::get):
(WTF::::set):
(WTF::::destroy):
2010-01-21 Kwang Yul Seo <skyul@company100.net>
Reviewed by Maciej Stachowiak.
Add fastStrDup to FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=33937
The new string returned by fastStrDup is obtained with fastMalloc,
and can be freed with fastFree. This makes the memory management
more consistent because we don't need to keep strdup allocated pointers
and free them with free(). Instead we can use fastFree everywhere.
* wtf/FastMalloc.cpp:
(WTF::fastStrDup):
* wtf/FastMalloc.h:
2010-01-21 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak.
history.back() for same-document history traversals isn't synchronous as the specification states.
<rdar://problem/7535011> and https://bugs.webkit.org/show_bug.cgi?id=33538
* wtf/Platform.h: Add a "HISTORY_ALWAYS_ASYNC" enable and turn it on for Chromium.
2010-01-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Always create a prototype for automatically managed classes.
This fixes some errors where prototype chains were not correctly hooked
up, and also ensures that API classes work correctly with features like
instanceof.
* API/JSClassRef.cpp:
(OpaqueJSClass::create): Cleaned up some of this code. Also changed it
to always create a prototype class.
* API/tests/testapi.c:
(Derived2_class):
(main): Fixed a null value crash in the exception checking code.
* API/tests/testapi.js: Added some tests for the case where a prototype
chain would not be hooked up correctly.
2010-01-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Force JSC to create a prototype chain for API classes with a
parent class but no static functions.
* API/JSClassRef.cpp:
(OpaqueJSClass::create):
2010-01-21 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
Object.getOwnPropertyDescriptor always returns undefined for JS API objects
https://bugs.webkit.org/show_bug.cgi?id=33946
Ideally the getOwnPropertyDescriptor() reimplementation should return an
access descriptor that wraps the property getter and setter callbacks, but
that approach is much more involved than returning a value descriptor.
Keep it simple for now.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyDescriptor):
* API/tests/testapi.js:
2010-01-20 Mark Rowe <mrowe@apple.com>
Build fix.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::initializeScavenger): Remove unnecessary function call.
2010-01-20 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
Use the inline i386 assembly for x86_64 as well rather than falling back to using pthread mutexes.
* wtf/TCSpinLock.h:
(TCMalloc_SpinLock::Lock):
(TCMalloc_SpinLock::Unlock):
(TCMalloc_SlowLock):
2010-01-20 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/7215063> Use GCD instead of an extra thread for FastMalloc scavenging on platforms where it is supported
Abstract the background scavenging slightly so that an alternate implementation that uses GCD can be used on platforms
where it is supported.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::initializeScavenger):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMalloc_PageHeap::shouldContinueScavenging):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::periodicScavenge):
* wtf/Platform.h:
2010-01-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/7562708> REGRESSION(53460): Heap::destroy may not run
all destructors
* runtime/Collector.cpp:
(JSC::Heap::freeBlocks): Instead of fully marking protected objects,
just set their mark bits. This prevents protected objects from keeping
unprotected objects alive. Destructor order is not guaranteed, so it's
OK to destroy objects pointed to by protected objects before destroying
protected objects.
2010-01-19 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
CrossThreadCopier needs to support ThreadSafeShared better.
https://bugs.webkit.org/show_bug.cgi?id=33698
* wtf/TypeTraits.cpp: Added tests for the new type traits.
* wtf/TypeTraits.h:
(WTF::IsSubclass): Determines if a class is a derived from another class.
(WTF::IsSubclassOfTemplate): Determines if a class is a derived from a
template class (with one parameter that is unknown).
(WTF::RemoveTemplate): Reveals the type for a template parameter.
2010-01-20 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler and Adam Roben.
Feature defines are difficult to maintain on Windows builds
https://bugs.webkit.org/show_bug.cgi?id=33883
FeatureDefines.vsprops are now maintained in a way similar to
Configurations/FeatureDefines.xcconfig, with the added advantage
of having a single FeatureDefines file across all projects.
* Configurations/FeatureDefines.xcconfig: Add comments about keeping feature definitions in sync.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add FeatureDefines.vsprops inherited property sheet.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Add FeatureDefines.vsprops inherited property sheet.
2010-01-20 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed buildfix for r53547.
* DerivedSources.pro:
2010-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Make extraCompilers for generated sources depend on their scripts
* DerivedSources.pro:
2010-01-19 Brian Weinstein <bweinstein@apple.com>
Reviewed by Tim Hatcher.
When JavaScriptCore calls Debugger::Exception, have it pass a
hasHandler variable that represents if exception is being handled
in the same function (not in a parent on the call stack).
This just adds a new parameter, no behavior is changed.
* debugger/Debugger.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
2010-01-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Inline functions that are hot in DOM manipulation
https://bugs.webkit.org/show_bug.cgi?id=33820
(3% speedup on Dromaeo DOM Core tests)
* runtime/WeakGCMap.h:
(JSC::::get): inline
2010-01-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed build fix for JIT with RVCT.
Remove IMPORT statement; cti_vm_throw is already defined in JITStubs.h.
Remove extra ')'.
* jit/JITStubs.cpp:
(JSC::ctiVMThrowTrampoline):
2010-01-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826
This bug was caused by a GC-protected object being destroyed early by
Heap::destroy. Clients of the GC protect APIs (reasonably) expect pointers
to GC-protected memory to be valid.
The solution is to do two passes of tear-down in Heap::destroy. The first
pass tears down all unprotected objects. The second pass ASSERTs that all
previously protected objects are now unprotected, and then tears down
all perviously protected objects. These two passes simulate the two passes
that would have been required to free a protected object during normal GC.
* API/JSContextRef.cpp: Removed some ASSERTs that have moved into Heap.
* runtime/Collector.cpp:
(JSC::Heap::destroy): Moved ASSERTs to here.
(JSC::Heap::freeBlock): Tidied up the use of didShrink by moving its
setter to the function that does the shrinking.
(JSC::Heap::freeBlocks): Implemented above algorithm.
(JSC::Heap::shrinkBlocks): Tidied up the use of didShrink.
2010-01-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Reverting r53455, breaks 2 javascriptcore tests.
* API/JSContextRef.cpp:
* runtime/Collector.cpp:
(JSC::Heap::destroy):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrinkBlocks):
2010-01-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Revert r53454, since it causes much sadness in this world.
* runtime/UString.cpp:
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
* wtf/StringHashFunctions.h:
(WTF::stringHash):
2010-01-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (52082): Crash on worker thread when reloading http://radnan.public.iastate.edu/procedural/
https://bugs.webkit.org/show_bug.cgi?id=33826
This bug was caused by a GC-protected object being destroyed early by
Heap::destroy. Clients of the GC protect APIs (reasonably) expect pointers
to GC-protected memory to be valid.
The solution is to do two passes of tear-down in Heap::destroy. The first
pass tears down all unprotected objects. The second pass ASSERTs that all
previously protected objects are now unprotected, and then tears down
all perviously protected objects. These two passes simulate the two passes
that would have been required to free a protected object during normal GC.
* API/JSContextRef.cpp: Removed some ASSERTs that have moved into Heap.
* runtime/Collector.cpp:
(JSC::Heap::destroy): Moved ASSERTs to here.
(JSC::Heap::freeBlock): Tidied up the use of didShrink by moving its
setter to the function that does the shrinking.
(JSC::Heap::freeBlocks): Implemented above algorithm.
(JSC::Heap::shrinkBlocks): Tidied up the use of didShrink.
2010-01-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove UntypedPtrAndBitfield from UStringImpl (akin to PtrAndFlags).
This break the OS X Leaks tool. Instead, free up some more bits from the refCount.
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::):
* wtf/StringHashFunctions.h:
(WTF::stringHash):
2010-01-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=month.
https://bugs.webkit.org/show_bug.cgi?id=33021
Expose the following functions to be used by WebCore:
- WTF::msToyear()
- WTF::dayInYear()
- WTF::monthFromDayInYear()
- WTF::dayInMonthFromDayInYear()
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/DateMath.cpp:
(WTF::msToYear): Remove "static inline".
(WTF::dayInYear): Remove "static inline".
(WTF::monthFromDayInYear): Remove "static inline".
(WTF::dayInMonthFromDayInYear): Remove "static inline".
* wtf/DateMath.h: Declare the above functions.
2010-01-18 Darin Adler <darin@apple.com>
Fix build by reverting the previous change.
* runtime/UString.h: Rolled out the FastAllocBase base class.
It was making UString larger, and therefore JSString larger,
and too big for a garbage collection cell.
This raises the unpleasant possibility that many classes became
larger because we added the FastAllocBase base class. I am
worried about this, and it needs to be investigated.
2010-01-18 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for UString class
https://bugs.webkit.org/show_bug.cgi?id=27831
Inherits the following class from FastAllocBase because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at:
classs UString - JavaScriptCore/runtime/UString.cpp:160
* runtime/UString.h:
2010-01-18 Evan Cheng <evan.cheng@apple.com>
Reviewed by Darin Adler.
Add some ALWAYS_INLINE for key functions not inlined by some versions of GCC.
rdar://problem/7553780
* runtime/JSObject.h:
(JSC::JSObject::getPropertySlot): ALWAYS_INLINE both overloads.
* runtime/JSString.h:
(JSC::JSString::JSString): ALWAYS_INLINE the version that takes a UString.
* runtime/UString.h:
(JSC::operator==): ALWAYS_INLINE the version that compares two UString objects.
2010-01-18 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Darin Adler.
Delete dftables-xxxxxxxx.in files automatically.
https://bugs.webkit.org/show_bug.cgi?id=33796
* pcre/dftables: unlink unnecessary temporary file.
2010-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Force qmake to generate a single makefile for DerivedSources.pro
* DerivedSources.pro:
2010-01-18 Csaba Osztrogonác <ossy@webkit.org>
Rubber-stamped by Gustavo Noronha Silva.
Rolling out r53391 and r53392 because of random crashes on buildbots.
https://bugs.webkit.org/show_bug.cgi?id=33731
* bytecode/CodeBlock.h:
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
* jit/JIT.cpp:
(JSC::JIT::unlinkCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* runtime/UString.cpp:
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
* runtime/UString.h:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
* wtf/StringHashFunctions.h:
(WTF::stringHash):
2010-01-18 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix the build with strict gcc and RVCT versions: It's not legal to cast a
pointer to a function to a void* without an intermediate cast to a non-pointer
type. A cast to a ptrdiff_t inbetween fixes it.
* runtime/JSString.h:
(JSC::Fiber::JSString):
2010-01-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove UntypedPtrAndBitfield from UStringImpl (akin to PtrAndFlags).
This break the OS X Leaks tool. Instead, free up some more bits from the refCount.
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::):
* wtf/StringHashFunctions.h:
(WTF::stringHash):
2010-01-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from JIT data stuctures.
These break the OS X Leaks tool. Free up a bit in CallLinkInfo, and invalid
permutation of pointer states in MethodCallLinkInfo to represent the removed bits.
* bytecode/CodeBlock.h:
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
* jit/JIT.cpp:
(JSC::JIT::unlinkCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* runtime/UString.h:
2010-01-16 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Cache JS string values made from DOM strings (Dromaeo speedup)
https://bugs.webkit.org/show_bug.cgi?id=33768
<rdar://problem/7353576>
* runtime/JSString.h:
(JSC::jsStringWithFinalizer): Added new mechanism for a string to have an optional
finalizer callback, for the benefit of weak-referencing caches.
(JSC::):
(JSC::Fiber::JSString):
(JSC::Fiber::~JSString):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope): Clear fibers so this doesn't look like a string with a finalizer.
* runtime/WeakGCMap.h: Include "Collector.h" to make this header includable by itself.
2010-01-15 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Fix for <rdar://problem/7548432>
Add ALWAYS_INLINE to jsLess for a 1% speedup on llvm-gcc.
* runtime/Operations.h:
(JSC::jsLess):
2010-01-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
REGRESISON: Google maps buttons not working properly
https://bugs.webkit.org/show_bug.cgi?id=31871
REGRESSION(r52948): JavaScript exceptions thrown on Google Maps when
getting directions for a second time
https://bugs.webkit.org/show_bug.cgi?id=33446
SunSpider and v8 report no change.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCacheGetByID): Update our cached offset in case
flattening the dictionary changed any of its offsets.
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Operations.h:
(JSC::normalizePrototypeChain): ditto
2010-01-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=33705
UStringImpl::create() should use internal storage
When creating a UStringImpl copying of a UChar*, we can use an internal buffer,
by calling UStringImpl::tryCreateUninitialized().
Also, remove duplicate of copyChars from JSString, call UStringImpl's version.
Small (max 0.5%) progression on Sunspidey.
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
* runtime/UStringImpl.h:
(JSC::UStringImpl::create):
2010-01-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Make naming & behaviour of UString[Impl] methods more consistent.
https://bugs.webkit.org/show_bug.cgi?id=33702
UString::create() creates a copy of the UChar* passed, but UStringImpl::create() assumes
that it should assume ownership of the provided buffer (with UString::createNonCopying()
and UStringImpl::createCopying() providing the alternate behaviours). Unify on create()
taking a copy of the provided buffer. For non-copying cases, use the name 'adopt', and
make this method take a Vector<UChar>&. For cases where non-copying construction was being
used, other than from a Vector<UChar>, change the code to allocate the storage along with
the UStringImpl using UStringImpl::createUninitialized(). (The adopt() method also more
closely matches that of WebCore::StringImpl).
Also, UString::createUninitialized() and UStringImpl::createUninitialized() have incompatible
behaviours, in that the UString form sets the provided UChar* to a null or non-null value to
indicate success or failure, but UStringImpl uses the returned PassRefPtr<UStringImpl> to
indicate when allocation has failed (potentially leaving the output Char* uninitialized).
This is also incompatible with WebCore::StringImpl's behaviour, in that
StringImpl::createUninitialized() will CRASH() if unable to allocate. Some uses of
createUninitialized() in JSC are unsafe, since they do not test the result for null.
UStringImpl's indication is preferable, since we may want a successful call to set the result
buffer to 0 (specifically, StringImpl returns 0 for the buffer where createUninitialized()
returns the empty string, which seems reasonable to catch bugs early). UString's method
cannot support UStringImpl's behaviour directly, since it returns an object rather than a
pointer.
- remove UString::createUninitialized(), replace with calls to UStringImpl::createUninitialized()
- create a UStringImpl::tryCreateUninitialized() form UStringImpl::createUninitialized(),
with current behaviour, make createUninitialized() crash on failure to allocate.
- make cases in JSC that do not check the result call createUninitialized(), and cases that do
check call tryCreateUninitialized().
Rename computedHash() to existingHash(), to bring this in line wih WebCore::StringImpl.
* API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
* JavaScriptCore.exp:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
* runtime/Identifier.cpp:
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
* runtime/Lookup.cpp:
(JSC::HashTable::createTable):
* runtime/Lookup.h:
(JSC::HashTable::entry):
* runtime/StringBuilder.h:
(JSC::StringBuilder::release):
* runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase):
* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
* runtime/Structure.cpp:
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::insertIntoPropertyMapHashTable):
(JSC::Structure::checkConsistency):
* runtime/Structure.h:
(JSC::Structure::get):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTableHash::hash):
* runtime/UString.cpp:
(JSC::createRep):
(JSC::UString::UString):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::operator=):
* runtime/UString.h:
(JSC::UString::adopt):
(JSC::IdentifierRepHash::hash):
(JSC::makeString):
* runtime/UStringImpl.h:
(JSC::UStringImpl::adopt):
(JSC::UStringImpl::create):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
(JSC::UStringImpl::existingHash):
2010-01-13 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Oliver Hunt.
JSON.stringify and JSON.parse needlessly process properties in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=33053
* runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
2010-01-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (buildfix).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-01-13 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33641
Assertion failure in Lexer.cpp if input stream ends while in string escape
Test: fast/js/end-in-string-escape.html
* parser/Lexer.cpp: (JSC::Lexer::lex): Bail out quickly on end of stream, not giving the
assertion a chance to fire.
2010-01-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (buildfix).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-01-13 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam Weinig & Darin Adler.
Three quick fixes to UStringImpl.
- The destroy() method can be switched back to a normal destructor; since we've switched
the way we protect static strings to be using an odd ref-count the destroy() won't abort.
- The cost() calculation logic was wrong. If you have multiple JSStrings wrapping substrings
of a base string, they would each report the full cost of the base string to the heap.
Instead we should only be reporting once for the base string.
- Remove the overloaded new operator calling fastMalloc, replace this with a 'using' to pick
up the implementation from the parent class.
* JavaScriptCore.exp:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):
2010-01-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Split the build process in two different .pro files.
This allows qmake to be run once all source files are available.
* DerivedSources.pro: Added.
* JavaScriptCore.pri: Moved source generation to DerivedSources.pro
* pcre/pcre.pri: Moved source generation to DerivedSources.pro
2010-01-12 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242
Add an extra argument to getPropertyNames() and getOwnPropertyNames()
(and all reimplementations thereof) that indicates whether non-enumerable
properties should be added.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyNames):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyNames):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyNames):
* runtime/Arguments.h:
* runtime/CommonIdentifiers.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertyNames):
* runtime/JSByteArray.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyNames):
* runtime/JSFunction.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertyNames):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::getClassPropertyNames):
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::getOwnPropertyNames):
* runtime/JSVariableObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::objectConstructorGetOwnPropertyNames):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertyNames):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
* runtime/StringObject.h:
* runtime/Structure.cpp: Rename getEnumerablePropertyNames() to getPropertyNames(), which takes an extra argument.
(JSC::Structure::getPropertyNames):
* runtime/Structure.h:
(JSC::):
2010-01-12 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33540
Make it possible to build in debug mode with assertions disabled
* jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
* runtime/Identifier.cpp: (JSC::Identifier::checkSameIdentifierTable):
* wtf/FastMalloc.cpp:
* wtf/HashTable.h: (WTF::HashTableConstIterator::checkValidity):
* yarr/RegexCompiler.cpp: (JSC::Yarr::compileRegex):
2009-11-23 Yong Li <yoli@rim.com>
Reviewed by Adam Treat.
Make GIF decoder support down-sampling
https://bugs.webkit.org/show_bug.cgi?id=31806
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::upperBoundScaledY):
(WebCore::ImageDecoder::lowerBoundScaledY):
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::scaledRect):
(WebCore::RGBA32Buffer::setScaledRect):
(WebCore::ImageDecoder::scaledSize):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::initFrameBuffer):
(WebCore::copyOnePixel):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
2010-01-12 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
ecma/Date/15.9.5.12-1.js fails every night at midnight
https://bugs.webkit.org/show_bug.cgi?id=28041
Change the test to use a concrete time instead of "now".
* tests/mozilla/ecma/Date/15.9.5.10-1.js:
* tests/mozilla/ecma/Date/15.9.5.12-1.js:
2010-01-11 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] Enable JIT and YARR_JIT if (CPU(X86_64) && OS(LINUX) && GCC_VERSION >= 40100)
* wtf/Platform.h:
2010-01-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=33481
Uninitialized data members in ArrayStorage
SunSpider reports no change.
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray): Initialize missing data members in the two cases
where we don't use fastZeroedMalloc, so it doesn't happen automatically.
2010-01-11 Steve Falkenburg <sfalken@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=33480
Improve debugging reliability for WTF on Windows.
Store WTF static library's PDB file into a better location.
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
2010-01-11 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
Remove extraneous entries from def file causing build warning.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-01-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
RegExp.prototype.toString returns "//" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319
"//" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
* tests/mozilla/ecma_2/RegExp/properties-001.js:
(AddRegExpCases):
* tests/mozilla/js1_2/regexp/toString.js:
Update relevant Mozilla tests (Mozilla has had this behavior since November 2003).
2010-01-10 Darin Adler <darin@apple.com>
* tests/mozilla/ecma/Array/15.4.1.1.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.1.2.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.2.1-1.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.2.2-1.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.2.2-2.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.2.3.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.3.2.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.3.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.4.1.js: Added property allow-tabs.
* tests/mozilla/ecma/Array/15.4.4.js: Added property allow-tabs.
* tests/mozilla/ecma/LexicalConventions/7.7.4.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.13.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.16.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.18.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.2.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.4.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.5.js: Added property allow-tabs.
* tests/mozilla/ecma/Math/15.8.2.7.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.1.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.2.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.3.1-3.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.3.1-4.js: Added property allow-tabs.
* tests/mozilla/ecma/String/15.5.3.js: Added property allow-tabs.
* tests/mozilla/ecma/TypeConversion/9.5-2.js: Added property allow-tabs.
* tests/mozilla/ecma/jsref.js: Modified property allow-tabs.
* tests/mozilla/ecma/shell.js: Modified property allow-tabs.
* tests/mozilla/ecma_2/LexicalConventions/keywords-001.js: Added property allow-tabs.
* tests/mozilla/ecma_2/RegExp/exec-001.js: Added property allow-tabs.
* tests/mozilla/ecma_2/String/match-004.js: Added property allow-tabs.
* tests/mozilla/ecma_2/String/replace-001.js: Added property allow-tabs.
* tests/mozilla/ecma_2/String/split-002.js: Added property allow-tabs.
* tests/mozilla/ecma_2/jsref.js: Modified property allow-tabs.
* tests/mozilla/ecma_2/shell.js: Added property allow-tabs.
* tests/mozilla/ecma_3/Date/shell.js: Modified property allow-tabs.
* tests/mozilla/ecma_3/Exceptions/regress-181654.js: Added property allow-tabs.
* tests/mozilla/ecma_3/RegExp/regress-209067.js: Added property allow-tabs.
* tests/mozilla/ecma_3/RegExp/regress-85721.js: Added property allow-tabs.
* tests/mozilla/importList.html: Added property allow-tabs.
* tests/mozilla/js1_1/shell.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/general1.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/general2.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/slice.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/splice1.js: Added property allow-tabs.
* tests/mozilla/js1_2/Array/splice2.js: Added property allow-tabs.
* tests/mozilla/js1_2/Objects/toString-001.js: Added property allow-tabs.
* tests/mozilla/js1_2/String/charCodeAt.js: Added property allow-tabs.
* tests/mozilla/js1_2/String/concat.js: Modified property allow-tabs.
* tests/mozilla/js1_2/String/match.js: Added property allow-tabs.
* tests/mozilla/js1_2/String/slice.js: Added property allow-tabs.
* tests/mozilla/js1_2/function/Function_object.js: Added property allow-tabs.
* tests/mozilla/js1_2/function/Number.js: Modified property allow-tabs.
* tests/mozilla/js1_2/function/String.js: Modified property allow-tabs.
* tests/mozilla/js1_2/function/nesting.js: Added property allow-tabs.
* tests/mozilla/js1_2/function/regexparg-1.js: Added property allow-tabs.
* tests/mozilla/js1_2/function/regexparg-2-n.js: Added property allow-tabs.
* tests/mozilla/js1_2/jsref.js: Added property allow-tabs.
* tests/mozilla/js1_2/operator/equality.js: Added property allow-tabs.
* tests/mozilla/js1_2/operator/strictEquality.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_dollar_number.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_input.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_input_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastIndex.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastMatch.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastMatch_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastParen.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_lastParen_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_leftContext.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_leftContext_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_multiline.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_object.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_rightContext.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/RegExp_rightContext_as_array.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/alphanumeric.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/asterisk.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/backslash.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/backspace.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/beginLine.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/character_class.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/compile.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/control_characters.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/digit.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/dot.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/endLine.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/everything.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/exec.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/flags.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/global.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/hexadecimal.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/ignoreCase.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/interval.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/octal.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/parentheses.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/plus.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/question_mark.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/simple_form.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/source.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/special_characters.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/string_replace.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/string_search.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/string_split.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/test.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/toString.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/vertical_bar.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/whitespace.js: Added property allow-tabs.
* tests/mozilla/js1_2/regexp/word_boundary.js: Added property allow-tabs.
* tests/mozilla/js1_2/shell.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/break.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/continue.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/do_while.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/switch.js: Added property allow-tabs.
* tests/mozilla/js1_2/statements/switch2.js: Added property allow-tabs.
* tests/mozilla/js1_3/shell.js: Added property allow-tabs.
* tests/mozilla/js1_4/shell.js: Added property allow-tabs.
* tests/mozilla/js1_5/Regress/regress-111557.js: Added property allow-tabs.
* tests/mozilla/js1_5/Regress/regress-216320.js: Added property allow-tabs.
* tests/mozilla/menuhead.html: Added property allow-tabs.
* tests/mozilla/mklistpage.pl: Added property allow-tabs.
* tests/mozilla/runtests.pl: Added property allow-tabs.
2010-01-08 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=33417
Cleans up style errors exposed by the patch for bug #33198.
Moreover, fixes all "Weird number of spaces at line-start. Are you using a 4-space indent?"
errors reported by check-webkit-style.
No functionality was changed. So, no new tests.
* wtf/Platform.h:
2010-01-08 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Eric Seidel.
Don't store RegExp flags string representation
https://bugs.webkit.org/show_bug.cgi?id=33321
It's unused; the string representation is reconstructed from flags.
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
* runtime/RegExp.h:
2010-01-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Memory use grows grows possibly unbounded in this JavaScript Array test case
https://bugs.webkit.org/show_bug.cgi?id=31675
This fixes one observed bug in this test case, which is that
arrays don't report extra cost for the sparse value maps.
SunSpider reports a small speedup.
* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase): Report extra memory cost for
the sparse value map.
* runtime/JSArray.h:
2010-01-08 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Remove unnecessary #include from FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=33393
* wtf/FastMalloc.cpp:
2010-01-08 Eric Seidel <eric@webkit.org>
No review, rolling out r52983.
http://trac.webkit.org/changeset/52983
https://bugs.webkit.org/show_bug.cgi?id=33321
Broke 59 JavaScriptCore tests. I don't think Kent knew about
run-javascriptcore-tests. Sadly neither does the commit-bot,
yet.
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
* runtime/RegExp.h:
(JSC::RegExp::flags):
2010-01-08 Eric Seidel <eric@webkit.org>
No review, rolling out r52981.
http://trac.webkit.org/changeset/52981
https://bugs.webkit.org/show_bug.cgi?id=33319
Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
2010-01-08 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
Don't store RegExp flags string representation
https://bugs.webkit.org/show_bug.cgi?id=33321
It's unused; the string representation is reconstructed from flags.
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
* runtime/RegExp.h:
2010-01-08 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
RegExp.prototype.toString returns "//" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319
"//" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
2010-01-08 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
RVCT compiler with "-Otime -O3" optimization tries to optimize out
inline new'ed pointers that are passed as arguments.
Proposed patch assigns new'ed pointer explicitly outside function call.
https://bugs.webkit.org/show_bug.cgi?id=33084
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
2010-01-08 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Remove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
https://bugs.webkit.org/show_bug.cgi?id=33203
* assembler/ARMAssembler.cpp: Remove obsolete linkBranch function.
(JSC::ARMAssembler::executableCopy): Inline a clean linkBranch code.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::getLdrImmAddress): Use inline function.
(JSC::ARMAssembler::getLdrImmAddressOnPool): Ditto.
(JSC::ARMAssembler::patchPointerInternal): Remove an unnecessary cacheFlush.
(JSC::ARMAssembler::linkJump): Use patchPointerInternal instead of linkBranch.
(JSC::ARMAssembler::linkCall): Ditto.
(JSC::ARMAssembler::relinkCall): Ditto.
2010-01-07 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
https://bugs.webkit.org/show_bug.cgi?id=33311
Move compileGetDirectOffset function to common part of JSVALUE32
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
2010-01-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Maciej Stachowiak.
Allow call sites to determine if ASSERT_* and LOG_* macros are operational
https://bugs.webkit.org/show_bug.cgi?id=33020
* wtf/Assertions.h: Set ASSERT_MSG_DISABLED, FATAL_DISABLED,
ERROR_DISABLED, LOG_DISABLED to 1 if the compiler does not support
variadic macros. Refactor for better readibility.
2010-01-07 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=32987
Added ENABLE_XHTMLMP flag. Disabled by default.
* Configurations/FeatureDefines.xcconfig:
2010-01-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Gavin Barraclough.
[Symbian] Port ARM traditional JIT Trampolines to RVCT
https://bugs.webkit.org/show_bug.cgi?id=30552
Take the GCC implementation and mechanically convert
it to RVCT syntax.
Use 'bx rX' instead of 'mov pc, rX' when it is available.
Developed in cooperation with Iain Campbell and Gabor Loki.
* JavaScriptCore.pri: Extra step to generate RVCT stubs. The
script generation intentionally executed all the time not just
for RVCT targets.
* create_rvct_stubs: Added. Perl script to expand precompiler macros
for RVCT assembler - the template is defined in JITStubs.cpp.
* jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
2010-01-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fix a crash seen on the buildbots.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Disable specific function tracking here,
instead of in WebCore, to ensure that the disabling happens before a
specific function can be registered.
2010-01-07 Alexey Proskuryakov <ap@apple.com>
Mac build fix.
* JavaScriptCore.exp: Export new JSGlobalData static data members.
2010-01-07 Alexey Proskuryakov <ap@apple.com>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=33057
REGRESSION(r49365): typeof(xhr.responseText) != "string" in Windows
<rdar://problem/7296920> REGRESSION: WebKit fails to start PeaceKeeper benchmark
Test: fast/js/webcore-string-comparison.html
In r49365, some code was moved from JSString.cpp to JSString.h, and as a result, WebCore
got a way to directly instantiate JSStrings over DLL borders. Since vftable for JSString was
not exported, objects created from WebCore got a different vptr, and JavaScriptCore
optimizations that relied on vptr of all JSString objects being equal failed.
* config.h: Added a JS_EXPORTCLASS macro for exporting classes. It's currently the same as
JS_EXPORTDATA, but it clearly needed a new name.
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):
* runtime/JSGlobalData.h:
Store vptrs just once, no need to repeatedly pick and copy them. This makes it possible to
assert vptr correctness in object destructors (which don't have access to JSGlobalData,
and even Heap::heap(this) will fail for fake objects created from storeVPtrs()).
* runtime/JSArray.cpp: (JSC::JSArray::~JSArray): Assert that vptr is what we expect it to be.
It's important to assert in destructor, because MSVC changes the vptr after constructor
is invoked.
* runtime/JSByteArray.cpp: (JSC::JSByteArray::~JSByteArray): Ditto.
* runtime/JSByteArray.h: Ditto.
* runtime/JSFunction.h: Ditto.
* runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction): Ditto.
* runtime/JSCell.h: (JSC::JSCell::setVPtr): Added a method to substitute vptr for another
one.
* runtime/JSString.h: Export JSString class together with its vftable, and tell other
libraries tp import it. This is needed on platforms that have a separate JavaScriptCore
dynamic library - and on Mac, we already did the export via JavaScriptCore.exp.
(JSC::JSString::~JSString): Assert tha vptr is what we expect it to be.
(JSC::fixupVPtr): Store a previously saved primary vftable pointer (do nothing if building
JavaScriptCore itself).
(JSC::jsSingleCharacterString): Call fixupVPtr in case this is call across DLL boundary.
(JSC::jsSingleCharacterSubstring): Ditto.
(JSC::jsNontrivialString): Ditto.
(JSC::jsString): Ditto.
(JSC::jsSubstring): Ditto.
(JSC::jsOwnedString): Ditto.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new static
JSGlobalData members that are used in WebCore via inline functions.
2010-01-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Safari memory usage skyrockets using new Google AdWords interface
https://bugs.webkit.org/show_bug.cgi?id=33343
The memory use was caused by the global object creating too many structures
as it thrashed between different specific functions.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::addAnonymousSlotsTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::despecifyAllFunctions):
* runtime/Structure.h:
(JSC::Structure::disableSpecificFunctionTracking): Track a thrash count
for specific functions. Disable specific function tracking once the
thrash count has been hit.
2010-01-07 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.
* JavaScriptCore.pri:
2010-01-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Holger Freyther.
[Mac] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312
Using of operator += cause compile error on Mac, so it is changed to
"= static_cast<AllocAlignmentInteger*>(old_ptr) + 1".
* wtf/FastMalloc.cpp:
(WTF::TCMallocStats::realloc):
2010-01-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Holger Freyther.
[Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312
Remove pByte (committed in r42344 from #20422), because pByte doesn't
exist and it is unnecessary.
* wtf/FastMalloc.cpp:
(WTF::TCMallocStats::realloc):
2010-01-06 Gavin Barraclough <barraclough@apple.com>
QT build fix.
* runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecific):
2010-01-06 Gavin Barraclough <barraclough@apple.com>
Windows build fix part I.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2010-01-06 Dan Bernstein <mitz@apple.com>
Build fix
* runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecificCallback):
2010-01-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=33236
Remove m_identifierTable pointer from UString
Currently every string holds a pointer so that during destruction,
if a string has been used as an identifier, it can remove itself
from the table. By instead accessing the identifierTable via a
thread specific tracking the table associated with the current
globaldata, we can save the memory cost of this pointer.
* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
- change the API shims to track the identifierTable of the current JSGlobalData.
* API/JSContextRef.cpp:
(JSContextGroupCreate):
- update creation of JSGlobalData for API usage to use new create method.
- fix shim instanciation bug in JSGlobalContextCreateInGroup.
* JavaScriptCore.exp:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
- add asserts to check the identifierTable is being tracked correctly.
* runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::Identifier::remove):
(JSC::Identifier::checkSameIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
(JSC::createDefaultDataSpecific):
- Use currentIdentifierTable() instead of UStringImpl::m_identifierTable.
- Define methods to access the thread specific identifier tables.
* runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):
- Declare methods to access the thread specific identifier tables.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):
- creation of JSGlobalData objects, other than for API usage, associate themselves with the current thread.
* runtime/JSGlobalData.h:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::destroy):
- destroy() method should be using isIdentifier().
* runtime/UStringImpl.h:
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
- replace m_identifierTable with a single m_isIdentifier bit.
* wtf/StringHashFunctions.h:
(WTF::stringHash):
- change string hash result from 32-bit to 31-bit, to free a bit in UStringImpl for m_isIdentifier.
2009-12-25 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Buildfix for WinCE + style fixes.
https://bugs.webkit.org/show_bug.cgi?id=32939
* jsc.cpp:
(functionPrint):
(functionQuit):
(parseArguments):
(fillBufferWithContentsOfFile):
2010-01-05 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
WinCE buildfix after r52791 (renamed PLATFORM(WINCE) to OS(WINCE)).
https://bugs.webkit.org/show_bug.cgi?id=33205
* jit/ExecutableAllocator.h:
2010-01-05 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Added compiler error for unsupported platforms.
https://bugs.webkit.org/show_bug.cgi?id=33112
* jit/JITStubs.cpp:
2010-01-05 Gabor Loki <loki@webkit.org>
Reviewed by Maciej Stachowiak.
Follow r52729 in ARMAssembler.
https://bugs.webkit.org/show_bug.cgi?id=33208
Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::encodeComplexImm): Move tmp declaration to ARMv7
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::bkpt):
2010-01-05 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix for Gtk+
Don't use // comments in Platform.h, at least some of them seem to make the version of GCC
used on the Gtk buildbot unhappy.
* wtf/Platform.h:
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Fisher.
Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198
* wtf/Platform.h: Rename, reorganize and document OS() macros.
Adapt to name changes. Also fixed a few incorrect OS checks.
* API/JSContextRef.cpp:
* assembler/MacroAssemblerARM.cpp:
(JSC::isVFPPresent):
* assembler/MacroAssemblerX86Common.h:
* bytecode/SamplingTool.cpp:
* config.h:
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::~RegisterFile):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
* jit/ExecutableAllocatorPosix.cpp:
* jit/ExecutableAllocatorSymbian.cpp:
* jit/ExecutableAllocatorWin.cpp:
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITStubs.cpp:
* jsc.cpp:
(main):
* parser/Grammar.y:
* profiler/ProfileNode.cpp:
(JSC::getCount):
* runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlockPtr):
(JSC::currentThreadStackBase):
(JSC::getCurrentPlatformThread):
(JSC::suspendThread):
(JSC::resumeThread):
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
* runtime/Collector.h:
* runtime/DateConstructor.cpp:
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreading):
* runtime/MarkStack.h:
(JSC::MarkStack::MarkStackArray::shrinkAllocation):
* runtime/MarkStackPosix.cpp:
* runtime/MarkStackSymbian.cpp:
* runtime/MarkStackWin.cpp:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncLastIndexOf):
* runtime/TimeoutChecker.cpp:
(JSC::getCPUTime):
* runtime/UString.cpp:
(JSC::UString::from):
* wtf/Assertions.cpp:
* wtf/Assertions.h:
* wtf/CurrentTime.cpp:
(WTF::lowResUTCTime):
* wtf/CurrentTime.h:
(WTF::getLocalTime):
* wtf/DateMath.cpp:
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::InitModule):
(WTF::TCMallocStats::):
* wtf/FastMalloc.h:
* wtf/MathExtras.h:
* wtf/RandomNumber.cpp:
(WTF::randomNumber):
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
* wtf/StringExtras.h:
* wtf/TCSpinLock.h:
(TCMalloc_SpinLock::Unlock):
(TCMalloc_SlowLock):
* wtf/TCSystemAlloc.cpp:
* wtf/ThreadSpecific.h:
(WTF::::destroy):
* wtf/Threading.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
(WTF::isMainThread):
* wtf/ThreadingWin.cpp:
(WTF::wtfThreadEntryPoint):
(WTF::createThreadInternal):
* wtf/VMTags.h:
* wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
* wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform):
2010-01-04 Gustavo Noronha Silva <gns@gnome.org>
Add missing files to the build system - make distcheck build fix.
* GNUmakefile.am:
2010-01-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig, additional coding by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=33163
Add string hashing functions to WTF.
Use WTF's string hashing functions from UStringImpl.
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/UStringImpl.cpp:
* runtime/UStringImpl.h:
(JSC::UStringImpl::computeHash):
* wtf/HashFunctions.h:
* wtf/StringHashFunctions.h: Added.
(WTF::stringHash):
2010-01-04 Dmitry Titov <dimich@chromium.org>
Not reviewed, attempt to fix ARM bulid.
* wtf/Platform.h:
2010-01-04 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Geoff Garen.
Add an 'isIdentifier' to UStringImpl, use this where appropriate
(where previously 'identifierTable' was being tested).
* API/JSClassRef.cpp:
(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
* runtime/Identifier.cpp:
(JSC::Identifier::addSlowCase):
* runtime/Identifier.h:
(JSC::Identifier::add):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/UStringImpl.h:
(JSC::UStringImpl::isIdentifier):
2010-01-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam "Shimmey Shimmey" Weinig.
https://bugs.webkit.org/show_bug.cgi?id=33158
Refactor JSC API entry/exit to use RAII instead of copy/pasting code.
Make it easier to change set of actions taken when passing across the API boundary.
* API/APIShims.h: Added.
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
(JSGarbageCollect):
(JSReportExtraMemoryCost):
* API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::call):
* API/JSCallbackObjectFunctions.h:
(JSC::::init):
(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::call):
(JSC::::getOwnPropertyNames):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::staticValueGetter):
(JSC::::callbackGetter):
* API/JSContextRef.cpp:
* API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetPrototype):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
(JSObjectCopyPropertyNames):
(JSPropertyNameArrayRelease):
(JSPropertyNameAccumulatorAddName):
* API/JSValueRef.cpp:
(JSValueGetType):
(JSValueIsUndefined):
(JSValueIsNull):
(JSValueIsBoolean):
(JSValueIsNumber):
(JSValueIsString):
(JSValueIsObject):
(JSValueIsObjectOfClass):
(JSValueIsEqual):
(JSValueIsStrictEqual):
(JSValueIsInstanceOfConstructor):
(JSValueMakeUndefined):
(JSValueMakeNull):
(JSValueMakeBoolean):
(JSValueMakeNumber):
(JSValueMakeString):
(JSValueToBoolean):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
(JSValueProtect):
(JSValueUnprotect):
* JavaScriptCore.xcodeproj/project.pbxproj:
2010-01-04 Dan Bernstein <mitz@apple.com>
Reviewed by Ada Chan and Mark Rowe.
Updated copyright string
* Info.plist:
* JavaScriptCore.vcproj/JavaScriptCore.resources/Info.plist:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:
2010-01-04 Adam Roben <aroben@apple.com>
No review, rolling out r52741.
http://trac.webkit.org/changeset/52741
https://bugs.webkit.org/show_bug.cgi?id=33056
* wtf/AlwaysInline.h:
2010-01-04 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Add cacheFlush support for WinCE
https://bugs.webkit.org/show_bug.cgi?id=33110
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
2010-01-04 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Implement NO_RETURN for COMPILER(MSVC).
https://bugs.webkit.org/show_bug.cgi?id=33056
* wtf/AlwaysInline.h:
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Simon Hausmann.
Fix some PLATFORM(*_ENDIAN) uses to CPU()
https://bugs.webkit.org/show_bug.cgi?id=33148
* runtime/JSCell.cpp:
(JSC::):
* runtime/JSValue.h:
(JSC::JSValue::):
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Document CPU() macros in comments.
https://bugs.webkit.org/show_bug.cgi?id=33147
* wtf/Platform.h:
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145
ExecutableAllocatorSymbian appears to have buggy ARM version check
https://bugs.webkit.org/show_bug.cgi?id=33138
* wtf/Platform.h:
Rename all macros related to detection of particular CPUs or
classes of CPUs to CPU(), reorganize and document them.
All remaining changes are adapting to the renames, plus fixing the
second bug cited above.
* assembler/ARMAssembler.cpp:
* assembler/ARMAssembler.h:
* assembler/ARMv7Assembler.h:
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Imm32::Imm32):
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.cpp:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
* assembler/MacroAssemblerX86.h:
* assembler/MacroAssemblerX86Common.h:
* assembler/MacroAssemblerX86_64.h:
* assembler/X86Assembler.h:
(JSC::X86Registers::):
(JSC::X86Assembler::):
(JSC::X86Assembler::movl_mEAX):
(JSC::X86Assembler::movl_EAXm):
(JSC::X86Assembler::repatchLoadPtrToLEA):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
* jit/ExecutableAllocatorPosix.cpp:
* jit/ExecutableAllocatorSymbian.cpp:
(JSC::ExecutableAllocator::intializePageSize):
* jit/JIT.cpp:
* jit/JIT.h:
* jit/JITArithmetic.cpp:
* jit/JITInlineMethods.h:
(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::restoreArgumentReferenceForTrampoline):
(JSC::JIT::emitCount):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
* runtime/Collector.cpp:
(JSC::currentThreadStackBase):
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
* wrec/WREC.h:
* wrec/WRECGenerator.cpp:
(JSC::WREC::Generator::generateEnter):
(JSC::WREC::Generator::generateReturnSuccess):
(JSC::WREC::Generator::generateReturnFailure):
* wrec/WRECGenerator.h:
* wtf/FastMalloc.cpp:
* wtf/TCSpinLock.h:
(TCMalloc_SpinLock::Lock):
(TCMalloc_SpinLock::Unlock):
(TCMalloc_SlowLock):
* wtf/Threading.h:
* wtf/dtoa.cpp:
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):
* yarr/RegexJIT.h:
2010-01-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Clean up COMPILER macros and remove unused ones.
https://bugs.webkit.org/show_bug.cgi?id=33132
Removed values are COMPILER(BORLAND) and COMPILER(CYGWIN) - they were
not used anywhere.
* wtf/Platform.h:
2010-01-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
Update wtf/Platform.h to document the new system for porting macros.
https://bugs.webkit.org/show_bug.cgi?id=33130
* wtf/Platform.h:
2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Maciej Stachowiak.
PLATFORM(CAIRO) should be defined by WIN_CAIRO define
https://bugs.webkit.org/show_bug.cgi?id=22250
* wtf/Platform.h: Define WTF_PLATFORM_CAIRO for GTK port only
For the WinCairo port WTF_PLATFORM_CAIRO is already defined in config.h
2009-12-28 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Delete ThreadPrivate instance after it is finished.
https://bugs.webkit.org/show_bug.cgi?id=32614
* wtf/qt/ThreadingQt.cpp:
(WTF::ThreadMonitor::instance):
(WTF::ThreadMonitor::threadFinished):
(WTF::createThreadInternal):
(WTF::detachThread):
2009-12-28 Patrick Gansterer <paroga@paroga.com>
Reviewed by Maciej Stachowiak.
Cleanup of #define JS_EXPORT.
* API/JSBase.h:
2009-12-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Barth.
WinCE buildfix (HWND_MESSAGE isn't supported there)
* wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform):
2009-12-27 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Barth.
Added a file with WinMain function to link agains in WinCE.
* os-win32/WinMain.cpp: Added.
(convertToUtf8):
(WinMain):
2009-12-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed; revert of r52550.
The change regressed the following LayoutTests for QtWebKit.
fast/workers/worker-call.html -> crashed
fast/workers/worker-close.html -> crashed
* wtf/qt/ThreadingQt.cpp:
(WTF::waitForThreadCompletion):
(WTF::detachThread):
2009-12-24 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix memory leak by deleting instance of ThreadPrivate
in function waitForThreadCompletion(), synchronously, or in
detachThread(), asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=32614
* wtf/qt/ThreadingQt.cpp:
(WTF::waitForThreadCompletion):
(WTF::detachThread):
2009-12-23 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
Include stddef.h for ptrdiff_t
https://bugs.webkit.org/show_bug.cgi?id=32891
ptrdiff_t is typedef-ed in stddef.h.
Include stddef.h in jit/ExecutableAllocator.h.
* jit/ExecutableAllocator.h:
2009-12-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Buildfix after r47092.
* wtf/wince/MemoryManager.cpp:
(WTF::tryFastMalloc):
(WTF::tryFastZeroedMalloc):
(WTF::tryFastCalloc):
(WTF::tryFastRealloc):
2009-12-23 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate getter support.
https://bugs.webkit.org/show_bug.cgi?id=32876
Expose dateToDaysFrom1970().
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/DateMath.cpp:
(WTF::dateToDaysFrom1970):
* wtf/DateMath.h:
2009-12-22 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
Turn off datagrid by default, at least for all platforms Apple ships.
The datagrid implementation isn't ready for general web use yet.
* Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.
2009-12-22 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Updates Android's scheduleDispatchFunctionsOnMainThread() to use new
AndroidThreading class, rather than using JavaSharedClient directly.
This fixes the current layering violation.
https://bugs.webkit.org/show_bug.cgi?id=32651
The pattern is copied from Chromium, which uses the ChromiumThreading
class. This patch also fixes the style in ChromiumThreading.h.
* wtf/android/AndroidThreading.h: Added. Declares AndroidThreading.
* wtf/android/MainThreadAndroid.cpp: Modified
(WTF::scheduleDispatchFunctionsOnMainThread): Uses AndroidThreading.
* wtf/chromium/ChromiumThreading.h: Modified. Fixes style.
2009-12-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Fix a couple of problems with UntypedPtrAndBitfield.
Add a m_leaksPtr to reduce false positives from leaks in debug builds
(this isn't perfect because we'd like a solution for release builds,
but this is now at least as good as a PtrAndFlags would be).
Switch SmallStringsto use a regular string for the base, rather than
a static one. UntypedPtrAndBitfield assumes all strings are at least
8 byte aligned; this migt not be true of static strings. Shared buffers
are heap allocated, as are all UStringImpls other than static strings.
Static strings cannot end up being the owner string of substrings,
since the only static strings are length 0.
* runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::SmallStringsStorage):
* runtime/UStringImpl.h:
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UStringImpl::UStringImpl):
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
RVCT (__ARMCC_VERSION < 400000) does not provide strcasecmp and strncasecmp
https://bugs.webkit.org/show_bug.cgi?id=32857
Add implementation of strcasecmp and strncasecmp for RVCT < 4.0
because earlier versions of RVCT 4.0 does not provide these functions.
* wtf/StringExtras.cpp: Added.
(strcasecmp):
(strncasecmp):
* wtf/StringExtras.h:
2009-12-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to __forceinline for RVCT
https://bugs.webkit.org/show_bug.cgi?id=32853
Use __forceinline forces RVCT to compile a C or C++ function
inline. The compiler attempts to inline the function, regardless of
the characteristics of the function.
* wtf/AlwaysInline.h:
* wtf/FastMalloc.h:
2009-12-21 Simon Hausmann <simon.hausmann@nokia.com>
Prospective GTK build fix: Add UStringImpl.cpp/h to the build.
* GNUmakefile.am:
2009-12-21 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build, add UStringImpl.cpp to the build.
* JavaScriptCore.pri:
2009-12-21 Gavin Barraclough <barraclough@apple.com>
Windows Build fix part 5.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
2009-12-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix).
Fix breakage of world introduced in build fix to r52463.
* runtime/UStringImpl.h:
2009-12-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32831
Replace UString::Rep implementation, following introduction of ropes to JSC.
* Remove redundant overcapacity mechanisms.
* Reduce memory cost of Rep's.
* Add an inline storage mechanism akin to that in WebCore's StringImpl.
~1% Sunspider progression.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
* runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::SmallStringsStorage):
* runtime/UString.cpp:
(JSC::initializeUString):
(JSC::createRep):
(JSC::UString::createFromUTF8):
(JSC::UString::createUninitialized):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::ascii):
(JSC::UString::operator=):
(JSC::UString::toStrictUInt32):
(JSC::equal):
* runtime/UString.h:
(JSC::UString::isEmpty):
(JSC::UString::cost):
(JSC::makeString):
* runtime/UStringImpl.cpp: Added.
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::destroy):
(JSC::UStringImpl::computeHash):
* runtime/UStringImpl.h: Added.
(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::createCopying):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::size):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::computedHash):
(JSC::UStringImpl::setHash):
(JSC::UStringImpl::identifierTable):
(JSC::UStringImpl::setIdentifierTable):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::allocChars):
(JSC::UStringImpl::copyChars):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::null):
(JSC::UStringImpl::empty):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::operator new):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
2009-12-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Move some build decisions from Qt build system into source files
https://bugs.webkit.org/show_bug.cgi?id=31956
* JavaScriptCore.pri: Compile files unconditionally
* jit/ExecutableAllocatorPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
* jit/ExecutableAllocatorWin.cpp: Guard with PLATFORM(WIN_OS)
* runtime/MarkStackPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
* runtime/MarkStackSymbian.cpp: Guard with PLATFORM(SYMBIAN)
* runtime/MarkStackWin.cpp: Guard with PLATFORM(WIN_OS)
* wtf/Platform.h: Guard ENABLE_JSC_MULTIPLE_THREADS with ENABLE_SINGLE_THREADED for the Qt port
* wtf/ThreadingNone.cpp: Guard with ENABLE(SINGLE_THREADED)
* wtf/qt/ThreadingQt.cpp: Guard with !ENABLE(SINGLE_THREADED)
2009-12-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Add createNonCopying method to UString to make replace constructor passed bool,
to make behaviour more explicit. Add createFromUTF8 to UString (wrapping method
on UString::Rep), since other cases of transliteration (e.g. from ascii) are
performed in UString constructors. Add/use setHash & size() accessors on Rep,
rather than accessing _hash/len directly.
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
* API/OpaqueJSString.cpp:
(OpaqueJSString::ustring):
* JavaScriptCore.exp:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
* runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
* runtime/JSString.h:
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
* runtime/StringBuilder.h:
(JSC::StringBuilder::release):
* runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase):
* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
* runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::createNonCopying):
(JSC::UString::createFromUTF8):
* runtime/UString.h:
(JSC::UString::Rep::setHash):
(JSC::UString::~UString):
(JSC::makeString):
2009-12-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich and Gavin Barraclough.
Changed Register constructors to assignment operators, to streamline
moving values into registers. (In theory, there's no difference between
the two, since the constructor should just inline away, but there seems
to be a big difference in the addled mind of the GCC optimizer.)
In the interpreter, this is a 3.5% SunSpider speedup and a 1K-2K
reduction in stack usage per privateExecute stack frame.
* interpreter/CallFrame.h:
(JSC::ExecState::setCalleeArguments):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScopeChain):
(JSC::ExecState::init):
(JSC::ExecState::setArgumentCount):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock): Added a little bit of casting so these
functions could use the new Register assignment operators.
* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::Register):
(JSC::Register::operator=): Swapped in assignment operators for constructors.
2009-12-18 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=32713
[Qt] make wtf/Assertions.h compile in winscw compiler.
Add string arg before ellipsis to help winscw compiler resolve variadic
macro definitions in wtf/Assertions.h.
* wtf/Assertions.h:
2009-12-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Adam Roben.
Fixed intermittent failure seen on Windows buildbot, and in other JSC
API clients.
Added a WeakGCPtr class and changed OpaqueJSClass::cachedPrototype to
use it, to avoid vending a stale object as a prototype.
* API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::prototype):
* API/JSClassRef.h: Use WeakGCPtr.
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/WeakGCPtr.h: Added.
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::operator*):
(JSC::WeakGCPtr::operator->):
(JSC::WeakGCPtr::operator!):
(JSC::WeakGCPtr::operator bool):
(JSC::WeakGCPtr::operator UnspecifiedBoolType):
(JSC::WeakGCPtr::assign):
(JSC::::operator):
(JSC::operator==):
(JSC::operator!=):
(JSC::static_pointer_cast):
(JSC::const_pointer_cast):
(JSC::getPtr): Added WeakGCPtr to the project.
2009-12-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=32720
* JavaScriptCore.exp:
- Remove exports for UString::append
* JavaScriptCore.xcodeproj/project.pbxproj:
- Make StringBuilder a private header (was project).
2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] GRefPtr does not take a reference when assigned a raw pointer
https://bugs.webkit.org/show_bug.cgi?id=32709
Ensure that when assigning a raw pointer to a GRefPtr, the reference
count is incremented. Also remove the GRefPtr conversion overload as
GRefPtr types have necessarily incompatible reference counting.
* wtf/gtk/GRefPtr.h:
(WTF::GRefPtr::operator=):
2009-12-18 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Clean up the qmake build system to distinguish between trunk builds and package builds
https://bugs.webkit.org/show_bug.cgi?id=32716
* pcre/pcre.pri: Use standalone_package instead of QTDIR_build
2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Compile warning from line 29 of GRefPtr.cpp
https://bugs.webkit.org/show_bug.cgi?id=32703
Fix memory leak and compiler warning in GRefPtr GHashTable template
specialization.
* wtf/gtk/GRefPtr.cpp:
(WTF::refGPtr):
2009-12-17 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add BUILDING_ON_SNOW_LEOPARD and TARGETING_SNOW_LEOPARD #defines.
* wtf/Platform.h:
2009-12-17 Adam Roben <aroben@apple.com>
Sync JavaScriptCore.vcproj with JavaScriptCore.xcodeproj and the
source tree
Fixes <http://webkit.org/b/32665>.
Reviewed by Ada Chan.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Moved
around files and filters so that the structure matches
JavaScriptCore.xcodeproj and the source tree. A few headers that were
previously omitted have been added, as well as JSZombie.{cpp,h}.
2009-12-17 Adam Roben <aroben@apple.com>
Remove HeavyProfile and TreeProfile completely
These were mostly removed in r42808, but the empty files were left in
place.
Fixes <http://webkit.org/b/32664>.
Reviewed by John Sullivan.
* Android.mk:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCoreSources.bkl:
Removed HeavyProfile/TreeProfile source files.
* profiler/HeavyProfile.cpp: Removed.
* profiler/HeavyProfile.h: Removed.
* profiler/TreeProfile.cpp: Removed.
* profiler/TreeProfile.h: Removed.
2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
https://bugs.webkit.org/show_bug.cgi?id=21599
Implement GRefPtr, a smart pointer for reference counted GObject types.
* GNUmakefile.am:
* wtf/gtk/GOwnPtr.cpp:
(WTF::GDir):
* wtf/gtk/GRefPtr.h: Added.
(WTF::):
(WTF::GRefPtr::GRefPtr):
(WTF::GRefPtr::~GRefPtr):
(WTF::GRefPtr::clear):
(WTF::GRefPtr::get):
(WTF::GRefPtr::operator*):
(WTF::GRefPtr::operator->):
(WTF::GRefPtr::operator!):
(WTF::GRefPtr::operator UnspecifiedBoolType):
(WTF::GRefPtr::hashTableDeletedValue):
(WTF::::operator):
(WTF::::swap):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::static_pointer_cast):
(WTF::const_pointer_cast):
(WTF::getPtr):
(WTF::adoptGRef):
(WTF::refGPtr):
(WTF::derefGPtr):
2009-12-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Build fixes for make distcheck.
* GNUmakefile.am:
2009-12-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed <rdar://problem/7355025> Interpreter::privateExecute macro generates
bloated code
This patch cuts Interpreter stack use by about a third.
* bytecode/Opcode.h: Changed Opcode to const void* to work with the
const static initiliazation we want to do in Interpreter::privateExecute.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter): Moved hashtable initialization here to
avoid polluting Interpreter::privateExecute's stack, and changed it from a
series of add() calls to one add() call in a loop, to cut down on code size.
(JSC::Interpreter::privateExecute): Changed a series of label computations
to a copy of a compile-time constant array to cut down on code size.
2009-12-16 Mark Rowe <mrowe@apple.com>
Build fix. Disable debug variants of WebKit frameworks.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-12-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam "r=me" Weinig.
https://bugs.webkit.org/show_bug.cgi?id=32498
<rdar://problem/7471495>
REGRESSION(r51978-r52039): AJAX "Mark This Forum Read" function no longer
works
Fixed a tyop.
* runtime/Operations.h:
(JSC::jsAdd): Use the '&&' operator, not the ',' operator.
2009-12-15 Geoffrey Garen <ggaren@apple.com>
Try to fix the windows build: don't export this inlined function.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2009-12-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Beth Dakin.
Inlined JSCell's operator new.
3.7% speedup on bench-allocate-nonretained.js.
* JavaScriptCore.exp:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::operator new):
2009-12-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed the number heap, replacing it with a one-item free list for
numbers, taking advantage of the fact that two number cells fit inside
the space for one regular cell, and number cells don't require destruction.
SunSpider says 1.6% faster in JSVALUE32 mode (the only mode that
heap-allocates numbers).
SunSpider says 1.1% faster in JSVALUE32_64 mode. v8 says 0.8% faster
in JSVALUE32_64 mode. 10% speedup on bench-alloc-nonretained.js. 6%
speedup on bench-alloc-retained.js.
There's a lot of formulaic change in this patch, but not much substance.
* JavaScriptCore.exp:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlockPtr):
(JSC::Heap::freeBlocks):
(JSC::Heap::recordExtraCost):
(JSC::Heap::allocate):
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks):
(JSC::Heap::markConservatively):
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells):
(JSC::Heap::sweep):
(JSC::Heap::markRoots):
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics):
(JSC::Heap::isBusy):
(JSC::Heap::reset):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::primaryHeapBegin):
(JSC::Heap::primaryHeapEnd):
* runtime/Collector.h:
(JSC::): Removed all code pertaining to the number heap, and changed all
heap template functions and classes to non-template functions and classes.
(JSC::Heap::allocateNumber): A new optimization to replace the number
heap: allocate half-sized number cells in pairs, returning the first
cell and caching the second cell for the next allocation.
* runtime/CollectorHeapIterator.h:
(JSC::LiveObjectIterator::LiveObjectIterator):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::DeadObjectIterator):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::ObjectIterator):
(JSC::ObjectIterator::operator++):
* runtime/JSCell.h:
(JSC::JSCell::isNumber): Removed all code pertaining to the number heap,
and changed all heap template functions and classes to non-template functions
and classes.
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for WeakGCMap class
https://bugs.webkit.org/show_bug.cgi?id=32547
Inherits WeakGCMap from FastAllocBase because it is instantiated by
'new' at: WebCore/dom/Document.cpp:512.
* runtime/WeakGCMap.h:
2009-12-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for dtoa's P5Node struct
https://bugs.webkit.org/show_bug.cgi?id=32544
Inherits P5Node struct from Noncopyable because it is instantiated by
'new' at wtf/dtoa.cpp:588 and don't need to be copyable.
* wtf/dtoa.cpp:
2009-12-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=32524
REGRESSION(52084): fast/dom/prototypes.html failing two CSS tests
* wtf/StdLibExtras.h:
(WTF::bitCount): The original patch put the parentheses in the wrong
place, completely changing the calculation and making it almost always
wrong. Moved the parentheses around the '+' operation, like the original
compiler warning suggested.
2009-12-14 Gabor Loki <loki@inf.u-szeged.hu>
Unreviewed trivial buildfix.
Fix crosses initialization of usedPrimaryBlocks for JSValue32
* runtime/Collector.cpp:
(JSC::Heap::markConservatively):
2009-12-14 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Simon Hausmann.
GCC 4.3.x warning fixed. Suggested parantheses added.
warning: ../../../JavaScriptCore/wtf/StdLibExtras.h:77: warning: suggest parentheses around + or - in operand of &
* wtf/StdLibExtras.h:
(WTF::bitCount):
2009-12-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Changed GC from mark-sweep to mark-allocate.
Added WeakGCMap to keep WebCore blissfully ignorant about objects that
have become garbage but haven't run their destructors yet.
1% SunSpider speedup.
7.6% v8 speedup (37% splay speedup).
17% speedup on bench-alloc-nonretained.js.
18% speedup on bench-alloc-retained.js.
* API/JSBase.cpp:
(JSGarbageCollect):
* API/JSContextRef.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj: Updated for renames and new
files.
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Updated to use the Collector
iterator abstraction.
* jsc.cpp:
(functionGC): Updated for rename.
* runtime/Collector.cpp: Slightly reduced the number of allocations per
collection, so that small workloads only allocate on collector block,
rather than two.
(JSC::Heap::Heap): Updated to use the new allocateBlock function.
(JSC::Heap::destroy): Updated to use the new freeBlocks function.
(JSC::Heap::allocateBlock): New function to initialize a block when
allocating it.
(JSC::Heap::freeBlock): Consolidated the responsibility for running
destructors into this function.
(JSC::Heap::freeBlocks): Updated to use freeBlock.
(JSC::Heap::recordExtraCost): Sweep the heap in this reporting function,
so that allocation, which is more common, doesn't have to check extraCost.
(JSC::Heap::heapAllocate): Run destructors right before recycling a
garbage cell. This has better cache utilization than a separate sweep phase.
(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks): New set of functions for managing the size of
the heap, now that the heap doesn't maintain any information about its
size.
(JSC::isPointerAligned):
(JSC::isHalfCellAligned):
(JSC::isPossibleCell):
(JSC::isCellAligned):
(JSC::Heap::markConservatively): Cleaned up this code a bit.
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells): Some helper functions for examining the the mark
bitmap.
(JSC::Heap::sweep): Simplified this function by using a DeadObjectIterator.
(JSC::Heap::markRoots): Reordered some operations for clarity.
(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics): Rewrote these functions to calculate an object
count on demand, since the heap doesn't maintain this information by
itself.
(JSC::Heap::reset): New function for resetting the heap once we've
exhausted heap space.
(JSC::Heap::collectAllGarbage): This function matches the old collect()
behavior, but it's now an uncommon function used only by API.
* runtime/Collector.h:
(JSC::CollectorBitmap::count):
(JSC::CollectorBitmap::isEmpty): Added some helper functions for managing
the collector mark bitmap.
(JSC::Heap::reportExtraMemoryCost): Changed reporting from cell equivalents
to bytes, so it's easier to understand.
* runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::CollectorHeapIterator):
(JSC::CollectorHeapIterator::operator!=):
(JSC::CollectorHeapIterator::operator*):
(JSC::CollectorHeapIterator::advance):
(JSC::::LiveObjectIterator):
(JSC::::operator):
(JSC::::DeadObjectIterator):
(JSC::::ObjectIterator): New iterators for encapsulating details about
heap layout, and what's live and dead on the heap.
* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength): Delay reporting extra cost until
we're fully constructed, so the heap mark phase won't visit us in an
invalid state.
* runtime/JSCell.h:
(JSC::JSCell::):
(JSC::JSCell::createDummyStructure):
(JSC::JSCell::JSCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h: Added a dummy cell to simplify allocation logic.
* runtime/JSString.h:
(JSC::jsSubstring): Don't report extra cost for substrings, since they
share a buffer that's already reported extra cost.
* runtime/Tracing.d:
* runtime/Tracing.h: Changed these dtrace hooks not to report object
counts, since they're no longer cheap to compute.
* runtime/UString.h: Updated for renames.
* runtime/WeakGCMap.h: Added.
(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::uncheckedGet):
(JSC::WeakGCMap::uncheckedBegin):
(JSC::WeakGCMap::uncheckedEnd):
(JSC::::get):
(JSC::::take):
(JSC::::set):
(JSC::::uncheckedRemove): Mentioned above.
* wtf/StdLibExtras.h:
(WTF::bitCount): Added a bit population count function, so the heap can
count live objects to fulfill statistics questions.
The very last cell in the block is not allocated -- should not be marked.
2009-12-13 Geoffrey Garen <ggaren@apple.com>
Windows build fix: Export some new symbols.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2009-12-13 Geoffrey Garen <ggaren@apple.com>
Windows build fix: Removed some old exports.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2009-12-13 Geoffrey Garen <ggaren@apple.com>
Windows build fix: Use unsigned instead of uint32_t to avoid dependencies.
* wtf/StdLibExtras.h:
(WTF::bitCount):
2009-12-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (speculative Windows build fix).
* runtime/JSGlobalObjectFunctions.cpp:
2009-12-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=32496
Switch remaining cases of string construction to use StringBuilder.
Builds strings using a vector rather than using string append / addition.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Executable.cpp:
(JSC::FunctionExecutable::paramString):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
* runtime/JSONObject.cpp:
(JSC::Stringifier::stringify):
(JSC::Stringifier::indent):
* runtime/JSString.h:
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lexString):
* runtime/NumberPrototype.cpp:
(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
* runtime/Operations.h:
(JSC::jsString):
* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
(JSC::stringProtoFuncConcat):
2009-12-08 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Eric Seidel.
Add code to allow toggling ATSUI/Core Text rendering at runtime in ComplexTextController.
https://bugs.webkit.org/show_bug.cgi?id=31802
The goal here is to allow for a zero runtime hit for ports that decide to select
the API at compile time.
When both USE(ATSUI) and USE(CORE_TEXT) are true, the API is toggled
at runtime. Core Text is used for OS Versions >= 10.6.
* wtf/Platform.h: #define USE_CORE_TEXT and USE_ATSUI on Chrome/Mac.
2009-12-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Unify codegen for forward and backward variants of branches
https://bugs.webkit.org/show_bug.cgi?id=32463
* jit/JIT.h:
(JSC::JIT::emit_op_loop): Implemented in terms of forward variant.
(JSC::JIT::emit_op_loop_if_true): ditto
(JSC::JIT::emitSlow_op_loop_if_true): ditto
(JSC::JIT::emit_op_loop_if_false): ditto
(JSC::JIT::emitSlow_op_loop_if_false): ditto
(JSC::JIT::emit_op_loop_if_less): ditto
(JSC::JIT::emitSlow_op_loop_if_less): ditto
* jit/JITOpcodes.cpp:
2009-12-11 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Allow WTFs concept of the main thread to differ from pthreads when necessary.
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
(WTF::isMainThread):
* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
2009-12-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=32454
Refactor construction of simple strings to avoid string concatenation.
Building strings through concatenation has a memory and performance cost -
a memory cost since we must over-allocate the buffer to leave space to append
into, and performance in that the string may still require reallocation (and
thus copying during construction). Instead move the full construction to
within a single function call (makeString), so that the arguments' lengths
can be calculated and an appropriate sized buffer allocated before copying
any characters.
~No performance change (~2% progression on date tests).
* bytecode/CodeBlock.cpp:
(JSC::escapeQuotes):
(JSC::valueToSourceString):
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpToSourceString):
(JSC::regexpName):
* bytecompiler/NodesCodegen.cpp:
(JSC::substitute):
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
* runtime/DateConstructor.cpp:
(JSC::callDate):
* runtime/DateConversion.cpp:
(JSC::formatDate):
(JSC::formatDateUTCVariant):
(JSC::formatTime):
(JSC::formatTimeUTC):
* runtime/DateConversion.h:
(JSC::):
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToGMTString):
* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
* runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
(JSC::createErrorMessage):
(JSC::createInvalidParamError):
* runtime/FunctionPrototype.cpp:
(JSC::insertSemicolonIfNeeded):
(JSC::functionProtoFuncToString):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
* runtime/UString.h:
(JSC::):
(JSC::makeString):
2009-12-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=32400
Switch remaining cases of string addition to use ropes.
Re-landing r51975 - added toPrimitiveString method,
performs toPrimitive then subsequent toString operations.
~1% progression on Sunspidey.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSString.h:
(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):
* runtime/Operations.cpp:
(JSC::jsAddSlowCase):
* runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
2009-12-11 Adam Roben <aroben@apple.com>
Windows build fix
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added
$(WebKitOutputDir)/include/private to the include path.
2009-12-11 Adam Roben <aroben@apple.com>
Move QuartzCorePresent.h to include/private
This fixes other projects that use wtf/Platform.h
Rubber-stamped by Steve Falkenburg.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS do its thang.
* JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Write
QuartzCorePresent.h to $(WebKitOutputDir)/include/private.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
Added $(WebKitOutputDir)/include/private to the include path.
2009-12-11 Adam Roben <aroben@apple.com>
Fix clean builds and everything rebuilding on every build
Reviewed by Sam Weinig.
* JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Don't
write out QuartzCorePresent.h if it exists but is older than
QuartzCore.h. Also, create the directory we write QuartzCorePresent.h
into first.
2009-12-11 Adam Roben <aroben@apple.com>
Windows build fix for systems with spaces in their paths
* JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Quote some paths.
2009-12-11 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
Add check for presence of QuartzCore headers
https://bugs.webkit.org/show_bug.cgi?id=31856
The script now checks for the presence of QuartzCore.h. If present
it will turn on ACCELERATED_COMPOSITING and 3D_RENDERING to enable
HW compositing on Windows. The script writes QuartzCorePresent.h to
the build directory which has a define telling whether QuartzCore is
present.
* JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
* wtf/Platform.h:
2009-12-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a problem that JSC::gregorianDateTimeToMS() returns a negative
value for a huge year value.
https://bugs.webkit.org/show_bug.cgi?id=32304
* wtf/DateMath.cpp:
(WTF::dateToDaysFrom1970): Renamed from dateToDayInYear, and changed the return type to double.
(WTF::calculateDSTOffset): Follow the dateToDaysFrom1970() change.
(WTF::timeClip): Use maxECMAScriptTime.
(JSC::gregorianDateTimeToMS): Follow the dateToDaysFrom1970() change.
2009-12-10 Adam Barth <abarth@webkit.org>
No review, rolling out r51975.
http://trac.webkit.org/changeset/51975
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSString.h:
(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):
* runtime/Operations.cpp:
(JSC::jsAddSlowCase):
* runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
2009-12-10 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Incorrect caching of prototype lookup with dictionary base
https://bugs.webkit.org/show_bug.cgi?id=32402
Make sure we don't add cached prototype lookup to the proto_list
lookup chain if the top level object is a dictionary.
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
2009-12-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=32400
Switch remaining cases of string addition to use ropes.
~1% progression on Sunspidey.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSString.h:
(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):
* runtime/Operations.cpp:
(JSC::jsAddSlowCase):
* runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
2009-12-10 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Geoffrey Garen.
Remove JSObject::getPropertyAttributes() and all usage of it.
https://bugs.webkit.org/show_bug.cgi?id=31933
getOwnPropertyDescriptor() should be used instead.
* JavaScriptCore.exp:
* JavaScriptCore.order:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
* debugger/DebuggerActivation.h:
* runtime/JSObject.cpp:
(JSC::JSObject::propertyIsEnumerable):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
* runtime/JSVariableObject.h:
2009-12-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt & Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=32367
Add support for short Ropes (up to 3 entries) inline within JSString.
(rather than externally allocating an object to hold the rope).
Switch jsAdd of (JSString* + JSString*) to now make use of Ropes.
~1% progression on Sunspidey.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::toBoolean):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::JSString::Rope::Fiber::deref):
(JSC::JSString::Rope::Fiber::ref):
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
(JSC::JSString::JSString):
(JSC::JSString::~JSString):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::length):
(JSC::JSString::canGetIndex):
(JSC::JSString::appendStringInConstruct):
(JSC::JSString::appendValueInConstructAndIncrementLength):
(JSC::JSString::isRope):
(JSC::JSString::string):
(JSC::JSString::ropeLength):
(JSC::JSString::getStringPropertySlot):
* runtime/Operations.h:
(JSC::jsString):
(JSC::jsAdd):
(JSC::resolveBase):
2009-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Geoffrey Garen.
Fix three more things found by compiling with clang++.
* runtime/Structure.h:
(JSC::StructureTransitionTable::reifySingleTransition):
Add the 'std' qualifier to the call to make_pair.
* wtf/DateMath.cpp:
(WTF::initializeDates):
Incrementing a bool is deprecated according to the C++ specification.
* wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
Name lookup should not be done in dependent bases, so explicitly qualify the call to set.
2009-12-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
Google reader gets stuck in the "Loading..." state and does not complete
https://bugs.webkit.org/show_bug.cgi?id=32256
<rdar://problem/7456388>
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jless): Fix some backward branches.
2009-12-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=32228
Make destruction of ropes non-recursive to prevent stack exhaustion.
Also, pass a UString& into initializeFiber rather than a Ustring::Rep*,
since the Rep is not being ref counted this could result in usage of a
Rep with refcount zero (where the Rep comes from a temporary UString
returned from a function).
* runtime/JSString.cpp:
(JSC::JSString::Rope::destructNonRecursive):
(JSC::JSString::Rope::~Rope):
* runtime/JSString.h:
(JSC::JSString::Rope::initializeFiber):
* runtime/Operations.h:
(JSC::concatenateStrings):
2009-12-09 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=31930
Update to r51457. ASSERTs changed to COMPILE_ASSERTs.
The speedup is 25%.
* runtime/JSGlobalData.cpp:
(JSC::VPtrSet::VPtrSet):
2009-12-09 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Updates Android Makefiles with latest additions.
https://bugs.webkit.org/show_bug.cgi?id=32278
* Android.mk: Modified.
* Android.v8.wtf.mk: Modified.
2009-12-09 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix a bug found while trying to compile JavaScriptCore with clang++.
* yarr/RegexPattern.h:
(JSC::Yarr::PatternTerm::PatternTerm): Don't self assign here. Use false instead.
2009-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Attempt to fix the Windows build.
* wtf/FastMalloc.h:
2009-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix some things found while trying to compile JavaScriptCore with clang++.
* wtf/FastMalloc.h:
Add correct exception specifications for the allocation/deallocation operators.
* wtf/Vector.h:
* wtf/VectorTraits.h:
Fix a bunch of struct/class mismatches.
2009-12-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
move code generation portions of Nodes.cpp to bytecompiler directory
https://bugs.webkit.org/show_bug.cgi?id=32284
* bytecompiler/NodesCodegen.cpp: Copied from parser/Nodes.cpp. Removed parts that
are not about codegen.
* parser/Nodes.cpp: Removed everything that is about codegen.
Update build systems:
* Android.mk:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* JavaScriptCoreSources.bkl:
2009-12-08 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
[wx] Mac plugins support.
https://bugs.webkit.org/show_bug.cgi?id=32236
* wtf/Platform.h:
2009-12-08 Dmitry Titov <dimich@chromium.org>
Rubber-stamped by David Levin.
Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
It may have caused massive increase of reported leaks on the bots.
https://bugs.webkit.org/show_bug.cgi?id=31639
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* wtf/RefCounted.h:
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):
* wtf/ThreadVerifier.h: Removed.
2009-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Darin Adler.
Make WebKit build correctly on FreeBSD, IA64, and Alpha.
Based on work by Petr Salinger <Petr.Salinger@seznam.cz>,
and Colin Watson <cjwatson@ubuntu.com>.
* wtf/Platform.h:
2009-12-08 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639
* runtime/Structure.cpp:
(JSC::Structure::Structure): Disable thread verification on this class since it uses addressOfCount().
* wtf/RefCounted.h:
(WTF::RefCountedBase::ref): Add ASSERT.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::derefBase): Ditto.
(WTF::RefCountedBase::disableThreadVerification): delegate to ThreadVerifier method.
* wtf/ThreadVerifier.h: Added.
(WTF::ThreadVerifier::ThreadVerifier): New Debug-only class to verify that ref/deref of RefCounted is done on the same thread.
(WTF::ThreadVerifier::activate): Activates checks. Called when ref count becomes above 2.
(WTF::ThreadVerifier::deactivate): Deactivates checks. Called when ref count drops below 2.
(WTF::ThreadVerifier::disableThreadVerification): used on objects that should not be checked (StringImpl etc)
(WTF::ThreadVerifier::verifyThread):
* GNUmakefile.am: Add ThreadVerifier.h to the build file.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
2009-12-08 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325
* Android.mk: Added.
* Android.v8.wtf.mk: Added.
2009-12-07 Dmitry Titov <dimich@chromium.org>
Rubber-stamped by Darin Adler.
Remove ENABLE_SHARED_SCRIPT flags
https://bugs.webkit.org/show_bug.cgi?id=32245
This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2009-12-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fixage part I).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2009-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=32184
Handle out-of-memory conditions with JSC Ropes with a JS exception, rather than crashing.
Switch from using fastMalloc to tryFastMalloc, pass an ExecState to record the exception on.
* API/JSCallbackObjectFunctions.h:
(JSC::::toString):
* API/JSValueRef.cpp:
(JSValueIsStrictEqual):
* JavaScriptCore.exp:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEqualityOp):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::calculatedFunctionName):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
* profiler/Profiler.cpp:
(JSC::Profiler::willExecute):
(JSC::Profiler::didExecute):
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
* profiler/Profiler.h:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::name):
(JSC::InternalFunction::displayName):
(JSC::InternalFunction::calculatedDisplayName):
* runtime/InternalFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getString):
* runtime/JSCell.h:
(JSC::JSValue::getString):
* runtime/JSONObject.cpp:
(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::get):
* runtime/JSString.cpp:
(JSC::JSString::Rope::~Rope):
(JSC::JSString::resolveRope):
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):
(JSC::JSString::toString):
(JSC::JSString::toThisString):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::JSString::Rope::createOrNull):
(JSC::JSString::Rope::operator new):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::getIndex):
(JSC::JSString::getStringPropertySlot):
(JSC::JSValue::toString):
* runtime/JSValue.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/Operations.cpp:
(JSC::JSValue::strictEqualSlowCase):
* runtime/Operations.h:
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):
(JSC::JSValue::strictEqual):
(JSC::jsLess):
(JSC::jsLessEq):
(JSC::jsAdd):
(JSC::concatenateStrings):
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::equalTo):
* runtime/PropertyDescriptor.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Holger Freyther.
Turn on (SVG) Filters support, by default.
https://bugs.webkit.org/show_bug.cgi?id=32224
* Configurations/FeatureDefines.xcconfig: Enable FILTERS build flag.
2009-12-07 Steve Falkenburg <sfalken@apple.com>
Build fix. Be flexible about which version of ICU is used on Windows.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Add optional xcopy commands to copy ICU 4.2.
2009-12-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
op_loop_if_less JIT codegen is broken for 64-bit
https://bugs.webkit.org/show_bug.cgi?id=32221
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_false): Fix codegen in this version - test was backwards.
2009-12-07 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Object.create fails if properties on the descriptor are getters
https://bugs.webkit.org/show_bug.cgi?id=32219
Correctly initialise the PropertySlots with the descriptor object.
* runtime/ObjectConstructor.cpp:
(JSC::toPropertyDescriptor):
2009-12-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Actually tested 64-bit *and* 32-bit build this time.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_false):
2009-12-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Really really fix 64-bit build for prior patch (actually tested this time).
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_false):
(JSC::JIT::emitSlow_op_loop_if_false):
2009-12-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Really fix 64-bit build for prior patch.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jless):
2009-12-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Fix 64-bit build for prior patch.
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_loop_if_less):
2009-12-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
conway benchmark spends half it's time in op_less (jump fusion fails)
https://bugs.webkit.org/show_bug.cgi?id=32190
<1% speedup on SunSpider and V8
2x speedup on "conway" benchmark
Two optimizations:
1) Improve codegen for logical operators &&, || and ! in a condition context
When generating code for combinations of &&, || and !, in a
condition context (i.e. in an if statement or loop condition), we
used to produce a value, and then separately jump based on its
truthiness. Now we pass the false and true targets in, and let the
logical operators generate jumps directly. This helps in four
ways:
a) Individual clauses of a short-circuit logical operator can now
jump directly to the then or else clause of an if statement (or to
the top or exit of a loop) instead of jumping to a jump.
b) It used to be that jump fusion with the condition of the first
clause of a logical operator was inhibited, because the register
was ref'd to be used later, in the actual condition jump; this no
longer happens since a jump straight to the final target is
generated directly.
c) It used to be that jump fusion with the condition of the second
clause of a logical operator was inhibited, because there was a
jump target right after the second clause and before the actual
condition jump. But now it's no longer necessary for the first
clause to jump there so jump fusion is not blocked.
d) We avoid generating excess mov statements in some cases.
As a concrete example this source:
if (!((x < q && y < q) || (t < q && z < q))) {
// ...
}
Used to generate this bytecode:
[ 34] less r1, r-15, r-19
[ 38] jfalse r1, 7(->45)
[ 41] less r1, r-16, r-19
[ 45] jtrue r1, 14(->59)
[ 48] less r1, r-17, r-19
[ 52] jfalse r1, 7(->59)
[ 55] less r1, r-18, r-19
[ 59] jtrue r1, 17(->76)
And now generates this bytecode (also taking advantage of the second optimization below):
[ 34] jnless r-15, r-19, 8(->42)
[ 38] jless r-16, r-19, 26(->64)
[ 42] jnless r-17, r-19, 8(->50)
[ 46] jless r-18, r-19, 18(->64)
Note the jump fusion and the fact that there's less jump
indirection - three of the four jumps go straight to the target
clause instead of indirecting through another jump.
2) Implement jless opcode to take advantage of the above, since we'll now often generate
a less followed by a jtrue where fusion is not forbidden.
* parser/Nodes.h:
(JSC::ExpressionNode::hasConditionContextCodegen): Helper function to determine
whether a node supports special conditional codegen. Return false as this is the default.
(JSC::ExpressionNode::emitBytecodeInConditionContext): Assert not reached - only really
defined for nodes that do have conditional codegen.
(JSC::UnaryOpNode::expr): Add const version.
(JSC::LogicalNotNode::hasConditionContextCodegen): Returne true only if subexpression
supports it.
(JSC::LogicalOpNode::hasConditionContextCodegen): Return true.
* parser/Nodes.cpp:
(JSC::LogicalNotNode::emitBytecodeInConditionContext): Implemented - just swap
the true and false targets for the child node.
(JSC::LogicalOpNode::emitBytecodeInConditionContext): Implemented - handle jumps
directly, improving codegen quality. Also handles further nested conditional codegen.
(JSC::ConditionalNode::emitBytecode): Use condition context codegen when available.
(JSC::IfNode::emitBytecode): ditto
(JSC::IfElseNode::emitBytecode): ditto
(JSC::DoWhileNode::emitBytecode): ditto
(JSC::WhileNode::emitBytecode): ditto
(JSC::ForNode::emitBytecode): ditto
* bytecode/Opcode.h:
- Added loop_if_false opcode - needed now that falsey jumps can be backwards.
- Added jless opcode to take advantage of new fusion opportunities.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump): Handle above.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfTrue): Add peephole for less + jtrue ==> jless.
(JSC::BytecodeGenerator::emitJumpIfFalse): Add handling of backwrds falsey jumps.
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNodeInConditionContext): Wrapper to handle tracking of
overly deep expressions etc.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Implement the two new opcodes (loop_if_false, jless).
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass): Implement JIT support for the two new opcodes.
(JSC::JIT::privateCompileSlowCases): ditto
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jless):
(JSC::JIT::emitSlow_op_jless): ditto
(JSC::JIT::emitBinaryDoubleOp): ditto
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_loop_if_less): ditto
(JSC::JIT::emit_op_loop_if_false): ditto
(JSC::JIT::emitSlow_op_loop_if_false): ditto
* jit/JITStubs.cpp:
* jit/JITStubs.h:
(JSC::):
2009-12-04 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Darin Adler.
JavaScript delete operator should return false for string properties
https://bugs.webkit.org/show_bug.cgi?id=32012
* runtime/StringObject.cpp:
(JSC::StringObject::deleteProperty):
2009-12-03 Drew Wilson <atwilson@chromium.org>
Rolled back r51633 because it causes a perf regression in Chromium.
* wtf/Platform.h:
2009-12-03 Gavin Barraclough <barraclough@apple.com>
Try and fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a symbol that should be exported.
2009-12-03 Mark Rowe <mrowe@apple.com>
Try and fix the Mac build.
* JavaScriptCore.exp: Export a symbol that should be exported.
2009-12-03 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION(4.0.3-48777): Crash in JSC::ExecState::propertyNames() (Debug-only?)
https://bugs.webkit.org/show_bug.cgi?id=32133
Work around odd GCC-ism and correct the scopechain for use by
calls made while a cachedcall is active on the callstack.
* interpreter/CachedCall.h:
(JSC::CachedCall::newCallFrame):
* runtime/JSArray.cpp:
(JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
2009-12-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver "Brraaaaiiiinnnnnzzzzzzzz" Hunt.
https://bugs.webkit.org/show_bug.cgi?id=32136
Add a rope representation to JSString. Presently JSString always holds its data in UString form.
Instead, allow the result of a string concatenation to be represented in a tree form - with a
variable sized, reference-counted rope node retaining a set of UString::Reps (or other rope nopes).
Strings must still currently be resolved down to a flat UString representation before being used,
but by holding the string in a rope representation during construction we can avoid copying data
until we know the final size of the string.
~2% progression on SunSpider (~25% on date-format-xparb, ~20% on string-validate-input).
* JavaScriptCore.exp:
- Update exports.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- Make use of new JSString::length() method to avoid prematurely resolving ropes.
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- Switch the string length trampoline to read the length directly from JSString::m_length,
rather than from the JSString's UString::Rep's 'len' property.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Modify op_add such that addition of two strings, where either or both strings are already
in rope representation, produces a rope as a result.
* runtime/JSString.cpp:
(JSC::JSString::Rope::~Rope):
(JSC::copyChars):
(JSC::JSString::resolveRope):
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toBoolean):
(JSC::JSString::toNumber):
(JSC::JSString::toString):
(JSC::JSString::toThisString):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::JSString::Rope::Fiber::Fiber):
(JSC::JSString::Rope::Fiber::destroy):
(JSC::JSString::Rope::Fiber::isRope):
(JSC::JSString::Rope::Fiber::rope):
(JSC::JSString::Rope::Fiber::string):
(JSC::JSString::Rope::create):
(JSC::JSString::Rope::initializeFiber):
(JSC::JSString::Rope::ropeLength):
(JSC::JSString::Rope::stringLength):
(JSC::JSString::Rope::fibers):
(JSC::JSString::Rope::Rope):
(JSC::JSString::Rope::operator new):
(JSC::JSString::JSString):
(JSC::JSString::value):
(JSC::JSString::length):
(JSC::JSString::isRope):
(JSC::JSString::rope):
(JSC::JSString::string):
(JSC::JSString::canGetIndex):
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSubstring):
(JSC::JSString::getStringPropertySlot):
- Add rope form.
* runtime/Operations.h:
(JSC::jsAdd):
(JSC::concatenateStrings):
- Update string concatenation, and addition of ropes, to produce ropes.
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
- Make use of new JSString::length() method to avoid prematurely resolving ropes.
2009-11-23 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Eric Seidel.
Switch Chrome/Mac to use Core Text APIs rather than ATSUI APIs.
https://bugs.webkit.org/show_bug.cgi?id=31802
No test since this is already covered by existing pixel tests.
* wtf/Platform.h: #define USE_CORE_TEXT for Chrome/Mac.
2009-12-02 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add files missed in prior patch.
* runtime/JSZombie.cpp:
(JSC::):
(JSC::JSZombie::leakedZombieStructure):
* runtime/JSZombie.h: Added.
(JSC::JSZombie::JSZombie):
(JSC::JSZombie::isZombie):
(JSC::JSZombie::classInfo):
(JSC::JSZombie::isGetterSetter):
(JSC::JSZombie::isAPIValueWrapper):
(JSC::JSZombie::isPropertyNameIterator):
(JSC::JSZombie::getCallData):
(JSC::JSZombie::getConstructData):
(JSC::JSZombie::getUInt32):
(JSC::JSZombie::toPrimitive):
(JSC::JSZombie::getPrimitiveNumber):
(JSC::JSZombie::toBoolean):
(JSC::JSZombie::toNumber):
(JSC::JSZombie::toString):
(JSC::JSZombie::toObject):
(JSC::JSZombie::markChildren):
(JSC::JSZombie::put):
(JSC::JSZombie::deleteProperty):
(JSC::JSZombie::toThisObject):
(JSC::JSZombie::toThisString):
(JSC::JSZombie::toThisJSString):
(JSC::JSZombie::getJSNumber):
(JSC::JSZombie::getOwnPropertySlot):
2009-12-02 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Add zombies to JSC
https://bugs.webkit.org/show_bug.cgi?id=32103
Add a compile time flag to make the JSC collector replace "unreachable"
objects with zombie objects. The zombie object is a JSCell subclass that
ASSERTs on any attempt to use the JSCell methods. In addition there are
a number of additional assertions in bottleneck code to catch zombie usage
as quickly as possible.
Grrr. Argh. Brains.
* JavaScriptCore.xcodeproj/project.pbxproj:
* interpreter/Register.h:
(JSC::Register::Register):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::append):
(JSC::ArgList::ArgList):
* runtime/Collector.cpp:
(JSC::Heap::destroy):
(JSC::Heap::sweep):
* runtime/Collector.h:
* runtime/JSCell.h:
(JSC::JSCell::isZombie):
(JSC::JSValue::isZombie):
* runtime/JSValue.h:
(JSC::JSValue::decode):
(JSC::JSValue::JSValue):
* wtf/Platform.h:
2009-12-01 Jens Alfke <snej@chromium.org>
Reviewed by Darin Adler.
Added variants of find/contains/add that allow a foreign key type to be used.
This will allow AtomicString-keyed maps to be queried by C string without
having to create a temporary AtomicString (see HTTPHeaderMap.)
The code for this is adapted from the equivalent in HashSet.h.
* wtf/HashMap.h:
(WTF::HashMap::find):
(WTF::HashMap::contains):
(WTF::HashMap::add):
* wtf/HashSet.h: Changed "method" to "function member" in a comment.
2009-12-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Revert 51551 because it broke GTK+.
* wtf/Platform.h:
2009-11-30 Gavin Barraclough <barraclough@apple.com>
Windows Build fix. Reviewed by NOBODY.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2009-11-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.
WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.
Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.
* API/JSBase.cpp:
(JSEvaluateScript):
* API/JSObjectRef.cpp:
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalData.h:
2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove obsolete PLATFORM(KDE) code
https://bugs.webkit.org/show_bug.cgi?id=31958
KDE is now using unpatched QtWebKit.
* parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
* wtf/Platform.h: Remove PLATFORM(KDE) definition and code
section that is guarded with it.
2009-11-30 Jan-Arve Sæther <jan-arve.saether@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix compilation with win32-icc
The Intel compiler does not support the __has_trivial_constructor type
trait. The Intel Compiler can report itself as _MSC_VER >= 1400. The
reason for that is that the Intel Compiler depends on the Microsoft
Platform SDK, and in order to try to be "fully" MS compatible it will
"pretend" to be the same MS compiler as was shipped with the MS PSDK.
(Thus, compiling with win32-icc with VC8 SDK will make the source code
"think" the compiler at hand supports this type trait).
* wtf/TypeTraits.h:
2009-11-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] Mac build has JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=31828
* wtf/Platform.h: Enable JIT for Qt Mac builds
2009-11-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all ports running on Windows
https://bugs.webkit.org/show_bug.cgi?id=31943
* runtime/MarkStack.h:
(JSC::MarkStack::MarkStackArray::shrinkAllocation):
2009-11-28 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
https://bugs.webkit.org/show_bug.cgi?id=31930
Seems a typo. We don't need ~270k memory to determine the vptrs.
* runtime/JSGlobalData.cpp:
(JSC::VPtrSet::VPtrSet):
2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
Build fix for chromium after r51423.
Exclude gtk directory from chromium build.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2009-11-25 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Incorrect behaviour of jneq_null in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=31901
Correct the logic of jneq_null. This is already covered by existing tests.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Oliver Hunt.
Move GOwnPtr* from wtf to wtf/gtk
https://bugs.webkit.org/show_bug.cgi?id=31793
* GNUmakefile.am: Change the path for GOwnPtr.*.
* JavaScriptCore.gyp/JavaScriptCore.gyp: Remove
GOwnPtr.cpp from the exclude list.
* JavaScriptCore.gypi: Change the path for GOwnPtr.*.
* wscript: Remove GOwnPtr.cpp from the exclude list.
* wtf/GOwnPtr.cpp: Removed.
* wtf/GOwnPtr.h: Removed.
* wtf/Threading.h: Change the path for GOwnPtr.h.
* wtf/gtk/GOwnPtr.cpp: Copied from JavaScriptCore/wtf/GOwnPtr.cpp.
* wtf/gtk/GOwnPtr.h: Copied from JavaScriptCore/wtf/GOwnPtr.h.
* wtf/unicode/glib/UnicodeGLib.h: Change the path for GOwnPtr.h.
2009-11-24 Dmitry Titov <dimich@chromium.org>
Reviewed by Eric Seidel.
Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
https://bugs.webkit.org/show_bug.cgi?id=31444
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2009-11-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Add ability to enable ACCELERATED_COMPOSITING on Windows (currently disabled)
https://bugs.webkit.org/show_bug.cgi?id=27314
* wtf/Platform.h:
2009-11-24 Jason Smith <dark.panda@gmail.com>
Reviewed by Alexey Proskuryakov.
RegExp#exec's returned Array-like object behaves differently from
regular Arrays
https://bugs.webkit.org/show_bug.cgi?id=31689
* JavaScriptCore/runtime/RegExpConstructor.cpp: ensure that undefined
values are added to the returned RegExpMatchesArray
2009-11-24 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
JSON.stringify performance on undefined is very poor
https://bugs.webkit.org/show_bug.cgi?id=31839
Switch from a UString to a Vector<UChar> when building
the JSON string, allowing us to safely remove the substr-copy
we otherwise did when unwinding an undefined property.
Also turns out to be a ~5% speedup on stringification.
* runtime/JSONObject.cpp:
(JSC::Stringifier::StringBuilder::append):
(JSC::Stringifier::stringify):
(JSC::Stringifier::Holder::appendNextProperty):
2009-11-24 Mark Rowe <mrowe@apple.com>
Fix production builds where the source tree may be read-only.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792
* wtf/unicode/UTF8.cpp:
* wtf/unicode/glib/UnicodeGLib.cpp:
* wtf/unicode/wince/UnicodeWince.cpp:
2009-11-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Streamlined some Math functions where we expect or know the result not
to be representable as an int.
SunSpider says 0.6% faster.
* runtime/JSNumberCell.h:
(JSC::JSValue::JSValue):
* runtime/JSValue.h:
(JSC::JSValue::):
(JSC::jsDoubleNumber):
(JSC::JSValue::JSValue): Added a function for making a numeric JSValue
and skipping the "can I encode this as an int?" check, avoiding the
overhead of int <-> double roundtripping and double <-> double comparison
and branching.
* runtime/MathObject.cpp:
(JSC::mathProtoFuncACos):
(JSC::mathProtoFuncASin):
(JSC::mathProtoFuncATan):
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncExp):
(JSC::mathProtoFuncLog):
(JSC::mathProtoFuncRandom):
(JSC::mathProtoFuncSin):
(JSC::mathProtoFuncSqrt):
(JSC::mathProtoFuncTan): For these functions, which we expect or know
to produce results not representable as ints, call jsDoubleNumber instead
of jsNumber.
2009-11-23 Mark Rowe <mrowe@apple.com>
Unreviewed. Unbreak the regression tests after r51329.
* API/JSBase.cpp:
(JSEvaluateScript): Null-check clientData before dereferencing it.
* API/JSObjectRef.cpp:
(JSObjectCallAsFunction): Ditto.
2009-11-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Part 1/3 of <rdar://problem/7377477> REGRESSION: Many web pages fail to render after interesting script runs in isolated world
Some clients of the JavaScriptCore API expect to be able to make callbacks over the JSC API,
and for this to automagically cause execution to take place in the world associated with the
global object associated with the ExecState (JSContextRef) passed. However this is not how
things work - the world must be explicitly set within WebCore.
Making this work just for API calls to evaluate & call will be a far from perfect solution,
since direct (non-API) use of JSC still relies on WebCore setting the current world correctly.
A better solution would be to make this all work automagically all throughout WebCore, but this
will require more refactoring.
Since the API is in JSC but worlds only exist in WebCore, add callbacks on the JSGlobalData::ClientData
to allow it to update the current world on entry/exit via the JSC API. This is temporary duck
tape, and should be removed once the current world no longer needs to be explicitly tracked.
* API/JSBase.cpp:
(JSEvaluateScript):
* API/JSObjectRef.cpp:
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::ClientData::beginningExecution):
(JSC::JSGlobalData::ClientData::completedExecution):
* runtime/JSGlobalData.h:
2009-11-23 Steve Block <steveblock@google.com>
Reviewed by Dmitry Titov.
Adds MainThreadAndroid.cpp with Android-specific WTF threading functions.
https://bugs.webkit.org/show_bug.cgi?id=31807
* wtf/android: Added.
* wtf/android/MainThreadAndroid.cpp: Added.
(WTF::timeoutFired):
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
2009-11-23 Alexey Proskuryakov <ap@apple.com>
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=31748
Make WebSocketHandleCFNet respect proxy auto-configuration files via CFProxySupport
* JavaScriptCore.exp: Export callOnMainThreadAndWait.
2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Symbian] Fix lastIndexOf() for Symbian
https://bugs.webkit.org/show_bug.cgi?id=31773
Symbian soft floating point library has problems with operators
comparing NaN to numbers. Without a workaround lastIndexOf()
function does not work.
Patch developed by David Leong.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncLastIndexOf):Add an extra test
to check for NaN for Symbian.
2009-11-23 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Android port lacks implementation of atomicIncrement and atomicDecrement.
https://bugs.webkit.org/show_bug.cgi?id=31715
* wtf/Threading.h: Modified.
(WTF::atomicIncrement): Added Android implementation.
(WTF::atomicDecrement): Added Android implementation.
2009-11-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed.
[Qt] Sort source lists and remove obsolete comments
from the build system.
* JavaScriptCore.pri:
2009-11-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt][Mac] Turn on multiple JavaScript threads for QtWebkit on Mac
https://bugs.webkit.org/show_bug.cgi?id=31753
* wtf/Platform.h:
2009-11-19 Steve Block <steveblock@google.com>
Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671
* wtf/Platform.h: Modified. Added Android-specific configuration.
2009-11-19 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31690
Make SocketStreamHandleCFNet work on Windows
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/MainThread.cpp:
(WTF::FunctionWithContext::FunctionWithContext):
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThreadAndWait):
* wtf/MainThread.h:
Re-add callOnMainThreadAndWait(), which was removed in bug 23926.
2009-11-19 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
isMainThread() on Chromium (Mac and Linux) is so slow it timeouts LayoutTests..
https://bugs.webkit.org/show_bug.cgi?id=31693
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): grab and use the pthread_t of the main thread instead of ThreadIdentifier.
(WTF::isMainThread): Ditto.
2009-11-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Remove HAVE(STRING_H) guard from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31668
* config.h:
* runtime/UString.cpp:
2009-11-19 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dmitry Titov.
Fixing a bug in MessageQueue::removeIf() that leads to an
assertion failure.
https://bugs.webkit.org/show_bug.cgi?id=31657
* wtf/MessageQueue.h:
(WTF::MessageQueue::removeIf):
2009-11-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Remove HAVE(FLOAT_H) guard
https://bugs.webkit.org/show_bug.cgi?id=31661
JavaScriptCore has a dependency on float.h, there is
no need to guard float.h.
* runtime/DatePrototype.cpp: Remove include directive
for float.h as it is included in MathExtras.h already.
* runtime/Operations.cpp: Ditto.
* runtime/UString.cpp: Ditto.
* wtf/dtoa.cpp: Ditto.
* wtf/MathExtras.h: Remove HAVE(FLOAT_H) guard.
* wtf/Platform.h: Ditto.
2009-11-19 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Build fix for 32-bit Sparc machines: these machines are big-endian.
* wtf/Platform.h:
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove support for Qt v4.3 or older versions
https://bugs.webkit.org/show_bug.cgi?id=29469
* JavaScriptCore.pro:
* jsc.pro:
* wtf/unicode/qt4/UnicodeQt4.h:
2009-11-18 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Move UString::from(double) implementation to new
WTF::doubleToStringInJavaScriptFormat(), and expose it because WebCore
code will use it.
https://bugs.webkit.org/show_bug.cgi?id=31330
- Introduce new function createRep(const char*, unsigned) and
UString::UString(const char*, unsigned) to reduce 2 calls to strlen().
- Fix a bug that dtoa() doesn't update *rve if the input value is NaN
or Infinity.
No new tests because this doesn't change the behavior.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/UString.cpp:
(JSC::createRep):
(JSC::UString::UString):
(JSC::UString::from): Move the code to doubleToStringInJavaScriptFormat().
* runtime/UString.h:
* wtf/dtoa.cpp:
(WTF::dtoa): Fix a bug about rve.
(WTF::append): A helper for doubleToStringInJavaScriptFormat().
(WTF::doubleToStringInJavaScriptFormat): Move the code from UString::from(double).
* wtf/dtoa.h:
2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=31643
* JavaScriptCore.pro:
2009-11-18 Nate Chapin <japhet@chromium.org>
Reviewed by Darin Fisher.
Remove Chromium's unnecessary dependency on wtf's tcmalloc files.
https://bugs.webkit.org/show_bug.cgi?id=31648
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2009-11-18 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Gavin Barraclough.
[Qt] Implement symbol hiding for JSC's JIT functions.
These functions are implemented directly in assembly, so they need the
proper directives to enable/disable visibility. On ELF systems, it's
.hidden, whereas on Mach-O systems (Mac) it's .private_extern. On
Windows, it's not necessary since you have to explicitly export. I
also implemented the AIX idiom, though it's unlikely anyone will
implement AIX/POWER JIT.
https://bugs.webkit.org/show_bug.cgi?id=30864
* jit/JITStubs.cpp:
2009-11-18 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
Interpreter may do an out of range access when throwing an exception in the profiler.
https://bugs.webkit.org/show_bug.cgi?id=31635
Add bounds check.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
2009-11-18 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Darin Adler.
Fix the clobber list of cacheFlush for ARM and Thumb2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=31631
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
2009-11-18 Harald Fernengel <harald.fernengel@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix detection of linux-g++
Never use "linux-g++*" to check for linux-g++, since this will break embedded
builds which use linux-arm-g++ and friends. Use 'linux*-g++*' to check for any
g++ on linux mkspec.
* JavaScriptCore.pri:
2009-11-17 Jon Honeycutt <jhoneycutt@apple.com>
Add JSContextRefPrivate.h to list of copied files.
Reviewed by Mark Rowe.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
2009-11-17 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Adam Barth.
[GTK] Style cleanup for GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=31506
Remove forward declaration in GOwnPtr and do some style cleanup.
* wtf/GOwnPtr.cpp:
* wtf/GOwnPtr.h:
(WTF::GOwnPtr::GOwnPtr):
(WTF::GOwnPtr::~GOwnPtr):
(WTF::GOwnPtr::get):
(WTF::GOwnPtr::release):
(WTF::GOwnPtr::outPtr):
(WTF::GOwnPtr::set):
(WTF::GOwnPtr::clear):
(WTF::GOwnPtr::operator*):
(WTF::GOwnPtr::operator->):
(WTF::GOwnPtr::operator!):
(WTF::GOwnPtr::operator UnspecifiedBoolType):
(WTF::GOwnPtr::swap):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::getPtr):
(WTF::freeOwnedGPtr):
2009-11-17 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Incorrect use of JavaScriptCore API in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=31577
Add assertions to the 'toJS' functions to catch mistakes like
this early. Restructure existing code which blindly passed potentially
null values to toJS when forwarding exceptions so that a null check is
performed first.
* API/APICast.h:
(toJS):
(toJSForGC):
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::call):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::staticValueGetter):
(JSC::::callbackGetter):
* API/tests/testapi.c: Fix errors in the API tester.
(MyObject_getProperty):
(MyObject_convertToType):
(EvilExceptionObject_convertToType):
2009-11-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
https://bugs.webkit.org/show_bug.cgi?id=31050
Minor fixes for JSVALUE32_64: branchConvertDoubleToInt32
failed on a CortexA8 CPU, but not on a simulator; and
JITCall.cpp modifications was somehow not committed to mainline.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::fmrs_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
2009-11-16 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon Hausmann.
Fix Qt build on Windows CE 6.
* JavaScriptCore.pri: Add missing include path.
* wtf/Platform.h: Include ce_time.h for Windows CE 6.
2009-11-13 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
https://bugs.webkit.org/show_bug.cgi?id=31050
Adding optimization support for mode JSVALUE32_64
on ARM systems.
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
2009-11-14 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
https://bugs.webkit.org/show_bug.cgi?id=31050
Adding JSVALUE32_64 support for ARM (but not turning it
on by default). All optimizations must be disabled, since
this patch is only the first of a series of patches.
During the work, a lot of x86 specific code revealed and
made platform independent.
See revisions: 50531 50541 50593 50594 50595
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::fdivd_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::branchOr32):
(JSC::MacroAssemblerARM::set8):
(JSC::MacroAssemblerARM::setTest8):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::zeroDouble):
* jit/JIT.cpp:
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITStubs.cpp:
* wtf/StdLibExtras.h:
2009-11-13 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Eric Seidel.
Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468
Adding isAlphanumeric abstraction, required
by TextBoundaries.cpp.
* wtf/unicode/glib/UnicodeGLib.h:
(WTF::Unicode::isAlphanumeric):
* wtf/unicode/icu/UnicodeIcu.h:
(WTF::Unicode::isAlphanumeric):
2009-11-13 Norbert Leser <norbert.leser&nokia.com>
Reviewed by Eric Seidel.
Added macros for USERINCLUDE paths within symbian blocks
to guarantee inclusion of respective header files from local path
first (to avoid clashes with same names of header files in system include path).
* JavaScriptCore.pri:
2009-11-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
JSValueProtect and JSValueUnprotect don't protect API wrapper values
https://bugs.webkit.org/show_bug.cgi?id=31485
Make JSValueProtect/Unprotect use a new 'toJS' function, 'toJSForGC' that
does not attempt to to strip out API wrapper objects.
* API/APICast.h:
(toJSForGC):
* API/JSValueRef.cpp:
(JSValueProtect):
(JSValueUnprotect):
* API/tests/testapi.c:
(makeGlobalNumberValue):
(main):
2009-11-13 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Antti Koivisto.
Fix typo, ce_time.cpp should be ce_time.c
* JavaScriptCore.pri:
2009-11-12 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by Adam Barth.
Calculate the time offset only if we were able to parse
the date string. This saves an IPC in Chromium for
invalid date strings.
https://bugs.webkit.org/show_bug.cgi?id=31416
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::parseDateFromNullTerminatedCharacters):
2009-11-12 Oliver Hunt <oliver@apple.com>
Rollout r50896 until i can work out why it causes failures.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitReturn):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* parser/Nodes.cpp:
(JSC::EvalNode::emitBytecode):
2009-11-12 Steve Falkenburg <sfalken@apple.com>
Reviewed by Stephanie Lewis.
Remove LIBRARY directive from def file to fix Debug_All target.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2009-11-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Holger Freyther.
Revert r50204, since it makes DRT crash on 32 bits release builds
for GTK+.
* wtf/FastMalloc.h:
2009-11-12 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Start unifying entry logic for function and eval code.
Eval now uses a ret instruction to end execution, and sets up
a callframe more in line with what we do for function entry.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitReturn):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* parser/Nodes.cpp:
(JSC::EvalNode::emitBytecode):
2009-11-12 Richard Moe Gustavsen <richard.gustavsen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disable pthread_setname_np.
This allows Qt builds on Mac from 10.6 to run on earlier version
where this symbol is not present.
https://bugs.webkit.org/show_bug.cgi?id=31403
* wtf/Platform.h:
2009-11-12 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix linking on Linux 32-bit.
It was missing the ".text" directive at the top of the file,
indicating that code would follow. Without it, the assembler created
"NOTYPE" symbols, which would result in linker errors.
https://bugs.webkit.org/show_bug.cgi?id=30863
* jit/JITStubs.cpp:
2009-11-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Alexey Proskuryakov.
Refactor multiple JavaScriptCore threads
https://bugs.webkit.org/show_bug.cgi?id=31328
Remove the id field from the PlatformThread structure
as it is not used.
* runtime/Collector.cpp:
(JSC::getCurrentPlatformThread):
(JSC::suspendThread):
(JSC::resumeThread):
(JSC::getPlatformThreadRegisters):
2009-11-10 Geoffrey Garen <ggaren@apple.com>
Linux build fix: Added an #include for UINT_MAX.
* runtime/WeakRandom.h:
2009-11-10 Geoffrey Garen <ggaren@apple.com>
JavaScriptGlue build fix: Marked a file 'private' instead of 'project'.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-11-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin "avGni arBalroguch" Barraclough.
Faster Math.random, based on GameRand.
SunSpider says 1.4% faster.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Added the header to the project.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h: Use an object to track random number generation
state, initialized to the current time.
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
(JSC::mathProtoFuncRandom): Use the new hotness.
* runtime/WeakRandom.h: Added.
(JSC::WeakRandom::WeakRandom):
(JSC::WeakRandom::get):
(JSC::WeakRandom::advance): The new hotness.
2009-11-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Imported the v8 DST cache.
SunSpider says 1.5% faster.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::resetDateCache): Reset the DST cache when resetting
other date data.
* runtime/JSGlobalData.h:
(JSC::DSTOffsetCache::DSTOffsetCache):
(JSC::DSTOffsetCache::reset): Added a struct for the DST cache.
* wtf/DateMath.cpp:
(WTF::calculateDSTOffsetSimple):
(WTF::calculateDSTOffset):
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::getDSTOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h: The imported code for probing and updating the cache.
2009-11-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed an edge case that could cause the engine not to notice a timezone
change.
No test because this case would require manual intervention to change
the timezone during the test.
SunSpider reports no change.
* runtime/DateInstanceCache.h:
(JSC::DateInstanceCache::DateInstanceCache):
(JSC::DateInstanceCache::reset): Added a helper function for resetting
this cache. Also, shrank the cache, since we'll be resetting it often.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::resetDateCache): Include resetting the DateInstanceCache
in resetting Date data. (Otherwise, a cache hit could bypass a necessary
timezone update check.)
2009-11-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Some manual inlining and constant propogation in Date code.
SunSpider reports a 0.4% speedup on date-*, no overall speedup. Shark
says some previously evident stalls are now gone.
* runtime/DateConstructor.cpp:
(JSC::callDate):
* runtime/DateConversion.cpp:
(JSC::formatTime):
(JSC::formatTimeUTC): Split formatTime into UTC and non-UTC variants.
* runtime/DateConversion.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):
* runtime/DateInstance.h:
(JSC::DateInstance::gregorianDateTime):
(JSC::DateInstance::gregorianDateTimeUTC): Split gregorianDateTime into
a UTC and non-UTC variant, and split each variant into a fast inline
case and a slow out-of-line case.
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Updated for the gregorianDateTime change above.
2009-11-09 Geoffrey Garen <ggaren@apple.com>
Build fix: export a new symbol.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2009-11-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam "Home Wrecker" Weinig.
Added a tiny cache for Date parsing.
SunSpider says 1.2% faster.
* runtime/DateConversion.cpp:
(JSC::parseDate): Try to reuse the last parsed Date, if present.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::resetDateCache):
* runtime/JSGlobalData.h: Added storage for last parsed Date. Refactored
this code to make resetting the date cache easier.
* runtime/JSGlobalObject.h:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
refactoring.
* wtf/DateMath.cpp:
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h: Changed ExecState to be first parameter, as is the JSC custom.
2009-11-09 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Can cache prototype lookups on uncacheable dictionaries.
https://bugs.webkit.org/show_bug.cgi?id=31198
Replace fromDictionaryTransition with flattenDictionaryObject and
flattenDictionaryStructure. This change is necessary as we need to
guarantee that our attempt to convert away from a dictionary structure
will definitely succeed, and in some cases this requires mutating the
object storage itself.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCacheGetByID):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/BatchedTransitionOptimizer.h:
(JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
* runtime/JSObject.h:
(JSC::JSObject::flattenDictionaryObject):
* runtime/Operations.h:
(JSC::normalizePrototypeChain):
* runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure):
(JSC::comparePropertyMapEntryIndices):
* runtime/Structure.h:
2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Not reviewed, build fix.
Remove extra character from r50701.
* JavaScriptCore.pri:
2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Not reviewed, build fix.
Revert r50695 because it broke QtWebKit (clean builds).
* JavaScriptCore.pri:
2009-11-09 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Prepended $$PWD to GENERATED_SOURCES_DIR to avoid potential ambiguities when included from WebCore.pro.
Some preprocessors consider this GENERATED_SOURCES_DIR relative to current invoking dir (e.g., ./WebCore),
and not the working dir of JavaCriptCore.pri (i.e., ../JavaScriptCore/).
* JavaScriptCore.pri:
2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
https://bugs.webkit.org/show_bug.cgi?id=31040
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2009-11-08 David Levin <levin@chromium.org>
Reviewed by NOBODY (speculative snow leopard and windows build fixes).
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h:
(JSC::GregorianDateTime::GregorianDateTime):
2009-11-08 David Levin <levin@chromium.org>
Reviewed by NOBODY (chromium build fix).
Hopefully, the last build fix.
Create better separation in DateMath about the JSC
and non-JSC portions. Also, only expose the non-JSC
version in the exports.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::getUTCOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h:
(JSC::gmtoffset):
2009-11-08 David Levin <levin@chromium.org>
Reviewed by NOBODY (chromium build fix).
For the change in DateMath.
* config.h:
* wtf/DateMath.cpp:
2009-11-06 Geoffrey Garen <ggaren@apple.com>
Windows build fix: export some symbols.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2009-11-06 Geoffrey Garen <ggaren@apple.com>
Build fix: updated export file.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
2009-11-06 Geoffrey Garen <ggaren@apple.com>
Build fix: added some #includes.
* wtf/CurrentTime.h:
* wtf/DateMath.h:
2009-11-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=31197
Implemented a timezone cache not based on Mac OS X's notify_check API.
If the VM calculates the local timezone offset from UTC, it caches the
result until the end of the current VM invocation. (We don't want to cache
forever, because the user's timezone may change over time.)
This removes notify_* overhead on Mac, and, more significantly, removes
OS time and date call overhead on non-Mac platforms.
~8% speedup on Date microbenchmark on Mac. SunSpider reports maybe a tiny
speedup on Mac. (Speedup on non-Mac platforms should be even more noticeable.)
* JavaScriptCore.exp:
* interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/JSGlobalObject.h:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Made the
DynamicGlobalObjectScope constructor responsible for checking whether a
dynamicGlobalObject has already been set. This eliminated some duplicate
client code, and allowed me to avoid adding even more duplicate client
code. Made DynamicGlobalObjectScope responsible for resetting the
local timezone cache upon first entry to the VM.
* runtime/DateConstructor.cpp:
(JSC::constructDate):
(JSC::callDate):
(JSC::dateParse):
(JSC::dateUTC):
* runtime/DateConversion.cpp:
(JSC::parseDate):
* runtime/DateConversion.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::gregorianDateTime):
* runtime/DateInstance.h:
* runtime/DateInstanceCache.h:
* runtime/DatePrototype.cpp:
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* wtf/DateMath.cpp:
(WTF::getCurrentUTCTime):
(WTF::getCurrentUTCTimeWithMicroseconds):
(WTF::getLocalTime):
(JSC::getUTCOffset): Use the new cache. Also, see below.
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::initializeDates):
(JSC::parseDateFromNullTerminatedCharacters): Simplified the way this function
accounts for the local timezone offset, to accomodate our new caching API,
and a (possibly misguided) caller in WebCore. Also, see below.
* wtf/DateMath.h:
(JSC::GregorianDateTime::GregorianDateTime): Moved most of the code in
DateMath.* into the JSC namespace. The code needed to move so it could
naturally interact with ExecState and JSGlobalData to support caching.
Logically, it seemed right to move it, too, since this code is not really
as low-level as the WTF namespace might imply -- it implements a set of
date parsing and conversion quirks that are finely tuned to the JavaScript
language. Also removed the Mac OS X notify_* infrastructure.
* wtf/CurrentTime.h:
(WTF::currentTimeMS):
(WTF::getLocalTime): Moved the rest of the DateMath code here, and renamed
it to make it consistent with WTF's currentTime function.
2009-11-06 Gabor Loki <loki@inf.u-szeged.hu>
Unreviewed trivial buildfix after r50595.
Rename the remaining rshiftPtr calls to rshift32
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_rshift):
* jit/JITInlineMethods.h:
(JSC::JIT::emitFastArithImmToInt):
2009-11-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Tidy up the shift methods on the macro-assembler interface.
Currently behaviour of shifts of a magnitude > 0x1f is undefined.
Instead defined that all shifts are masked to this range. This makes a lot of
practical sense, both since having undefined behaviour is not particularly
desirable, and because this behaviour is commonly required (particularly since
it is required bt ECMA-262 for shifts).
Update the ARM assemblers to provide this behaviour. Remove (now) redundant
masks from JITArithmetic, and remove rshiftPtr (this was used in case that
could be rewritten in a simpler form using rshift32, only optimized JSVALUE32
on x86-64, which uses JSVALUE64!)
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::rshift32):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::lshift32):
(JSC::MacroAssemblerARMv7::rshift32):
* assembler/MacroAssemblerX86_64.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):
2009-11-05 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Oliver Hunt.
Remove a magic number (1) from the JIT, instead compute the value with OBJECT_OFFSET.
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutJITStubArg):
(JSC::JIT::emitPutJITStubArgConstant):
(JSC::JIT::emitGetJITStubArg):
(JSC::JIT::emitPutJITStubArgFromVirtualRegister):
* jit/JITStubCall.h:
(JSC::JITStubCall::JITStubCall):
(JSC::JITStubCall::getArgument):
* jit/JITStubs.h:
2009-11-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
https://bugs.webkit.org/show_bug.cgi?id=31159
Fix branchDouble behaviour on ARM THUMB2 JIT.
The x86 branchDouble behaviour is reworked, and all JIT
ports should follow the x86 port. See bug 31104 and 31151
This patch contains a fix for the traditional ARM port
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::fmrs_r):
(JSC::ARMAssembler::ftosid_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
2009-11-05 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Removed the "this is part of the KDE project" comments from
all *.h, *.cpp, *.idl, and *.pm files.
https://bugs.webkit.org/show_bug.cgi?id=31167
The maintenance and architecture page in the project wiki lists
this as a task.
This change includes no changes or additions to test cases
since the change affects only comments.
* wtf/wince/FastMallocWince.h:
2009-11-05 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Use ARMv7 specific encoding for immediate constants on ARMv7 target
https://bugs.webkit.org/show_bug.cgi?id=31060
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::getOp2): Use INVALID_IMM
(JSC::ARMAssembler::getImm): Use encodeComplexImm for complex immediate
(JSC::ARMAssembler::moveImm): Ditto.
(JSC::ARMAssembler::encodeComplexImm): Encode a constant by one or two
instructions or a PC relative load.
* assembler/ARMAssembler.h: Use INVALID_IMM if a constant cannot be
encoded as an immediate constant.
(JSC::ARMAssembler::):
(JSC::ARMAssembler::movw_r): 16-bit immediate load
(JSC::ARMAssembler::movt_r): High halfword 16-bit immediate load
(JSC::ARMAssembler::getImm16Op2): Encode immediate constant for
movw_r and mowt_r
2009-11-04 Mark Mentovai <mark@chromium.org>
Reviewed by Mark Rowe.
Provide TARGETING_TIGER and TARGETING_LEOPARD as analogues to
BUILDING_ON_TIGER and BUILDING_ON_LEOPARD. The TARGETING_ macros
consider the deployment target; the BUILDING_ON_ macros consider the
headers being built against.
* wtf/Platform.h:
2009-11-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=31151
Fix branchDouble behaviour on ARM THUMB2 JIT.
The ARMv7 JIT is currently using ARMv7Assembler::ConditionEQ to branch
for DoubleEqualOrUnordered, however this is incorrect - ConditionEQ won't
branch on unordered operands. Similarly, DoubleLessThanOrUnordered &
DoubleLessThanOrEqualOrUnordered use ARMv7Assembler::ConditionLO &
ARMv7Assembler::ConditionLS, whereas they should be using
ARMv7Assembler::ConditionLT & ARMv7Assembler::ConditionLE.
Fix these, and fill out the missing DoubleConditions.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::):
(JSC::MacroAssemblerARMv7::branchDouble):
2009-11-04 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Oliver Hunt.
Enable native call optimizations on ARMv7. (Existing ARM_TRADITIONAL
implementation was generic, worked perfectly, just needed turning on).
* jit/JITOpcodes.cpp:
* wtf/Platform.h:
2009-11-04 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Mark Rowe, Oliver Hunt, and Sam Weinig.
Add a missing assert to the ARMv7 JIT.
* assembler/ARMv7Assembler.h:
(JSC::ARMThumbImmediate::ARMThumbImmediate):
2009-11-04 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Oliver Hunt.
Remove bogus op_ prefix on dumped version of three opcodes.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
2009-11-04 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
Fix dumping of constants in bytecode so that they aren't printed as large positive register numbers.
We do this by having the registerName function return information about the constant if the register
number corresponds to a constant. This requires that registerName, and several functions that call it,
be converted to member functions of CodeBlock so that the constant value can be retrieved. The
ExecState also needs to be threaded down through these functions so that it can be passed on to
constantName when needed.
* bytecode/CodeBlock.cpp:
(JSC::constantName):
(JSC::CodeBlock::registerName):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::isConstantRegisterIndex):
2009-11-04 Pavel Heimlich <tropikhajma@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=30647
Solaris build failure due to strnstr.
* wtf/StringExtras.h: Enable strnstr on Solaris, too.
2009-11-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=31104
Refactor x86-specific behaviour out of the JIT.
- Add explicit double branch conditions for ordered and unordered comparisons (presently the brehaviour is a mix).
- Refactor double to int conversion out into the MacroAssembler.
- Remove broken double to int conversion for !JSVALUE32_64 builds - this code was broken and slowing us down, fixing it showed it not to be an improvement.
- Remove exclusion of double to int conversion from (1 % X) cases in JSVALUE32_64 builds - if this was of benefit this is no longer the case; simplify.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::):
(JSC::MacroAssemblerX86Common::convertInt32ToDouble):
(JSC::MacroAssemblerX86Common::branchDouble):
(JSC::MacroAssemblerX86Common::branchConvertDoubleToInt32):
* jit/JITArithmetic.cpp:
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jfalse):
2009-11-04 Mark Mentovai <mark@chromium.org>
Reviewed by Eric Seidel.
Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp. This is supposed
to be set as needed only in wtf/Platform.h.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2009-11-02 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionary at the head of the chain
https://bugs.webkit.org/show_bug.cgi?id=31045
Add guards to prevent caching of prototype chain lookups with dictionaries at the
head of the chain. Also add a few tighter assertions to cached prototype lookups
to catch this in future.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
2009-11-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671
* wtf/Platform.h: Turn on CF support if both QT and DARWIN
platforms are defined.
2009-11-02 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
https://bugs.webkit.org/show_bug.cgi?id=30612
* wtf/MessageQueue.h:
(WTF::MessageQueue::alwaysTruePredicate):
(WTF::MessageQueue::~MessageQueue):
(WTF::MessageQueue::append):
(WTF::MessageQueue::appendAndCheckEmpty):
(WTF::MessageQueue::prepend):
(WTF::MessageQueue::waitForMessage):
(WTF::MessageQueue::waitForMessageFilteredWithTimeout):
(WTF::MessageQueue::tryGetMessage):
(WTF::MessageQueue::removeIf):
The MessageQueue is changed to act as a queue of OwnPtr<DataType>. It takes ownership
of posted tasks and passes it to the new owner (in another thread) when the task is fetched.
All methods have arguments of type PassOwnPtr<DataType> and return the same type.
* wtf/Threading.cpp:
(WTF::createThread):
Superficial change to trigger rebuild of JSC project on Windows,
workaround for https://bugs.webkit.org/show_bug.cgi?id=30890
2009-10-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed failing layout test: restore a special case I accidentally deleted.
* runtime/DatePrototype.cpp:
(JSC::setNewValueFromDateArgs): In the case of applying a change to a date
that is NaN, reset the date to 0 *and* then apply the change; don't just
reset the date to 0.
2009-10-30 Geoffrey Garen <ggaren@apple.com>
Windows build fix: update for object-to-pointer change.
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
2009-10-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30942
Use pointers instead of copies to pass GregorianDateTime objects around.
SunSpider reports a shocking 4.5% speedup on date-format-xparb, and 1.3%
speedup on date-format-tofte.
* runtime/DateInstance.cpp:
(JSC::DateInstance::gregorianDateTime):
* runtime/DateInstance.h:
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Renamed getGregorianDateTime to gregorianDateTime,
since it no longer has an out parameter. Uses 0 to indicate invalid dates.
2009-10-30 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=30853
Inherits ListHashSet class from FastAllocBase because it is
instantiated by 'new' in WebCore/rendering/RenderBlock.cpp:1813.
* wtf/ListHashSet.h:
2009-10-30 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Regression: crash enumerating properties of an object with getters or setters
https://bugs.webkit.org/show_bug.cgi?id=30948
Add a guard to prevent us trying to cache property enumeration on
objects with getters or setters.
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
2009-10-30 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Eric Seidel.
Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
Bug 28420 - Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)
No new tests (no functional change).
* Configurations/FeatureDefines.xcconfig:
2009-10-29 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION (r50218-r50262): E*TRADE accounts page is missing content
https://bugs.webkit.org/show_bug.cgi?id=30947
<rdar://problem/7348833>
The logic for flagging that a structure has non-enumerable properties
was in addPropertyWithoutTransition, rather than in the core Structure::put
method. Despite this I was unable to produce a testcase that caused
the failure that etrade was experiencing, but the new assertion in
getEnumerablePropertyNames triggers on numerous layout tests without
the fix, so in effecti all for..in enumeration in any test ends up
doing the required consistency check.
* runtime/Structure.cpp:
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::put):
(JSC::Structure::getEnumerablePropertyNames):
(JSC::Structure::checkConsistency):
2009-10-29 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add cacheFlush support for Thumb-2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=30865
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
2009-10-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
JSC JIT on ARMv7 cannot link jumps >16Mb range
https://bugs.webkit.org/show_bug.cgi?id=30891
Start planing all relative jumps as move-32-bit-immediate-to-register-BX.
In the cases where the jump would fall within a relative jump range, use a relative jump.
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::~ARMv7Assembler):
(JSC::ARMv7Assembler::LinkRecord::LinkRecord):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::executableCopy):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::relinkJump):
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::isB):
(JSC::ARMv7Assembler::isBX):
(JSC::ARMv7Assembler::isMOV_imm_T3):
(JSC::ARMv7Assembler::isMOVT):
(JSC::ARMv7Assembler::isNOP_T1):
(JSC::ARMv7Assembler::isNOP_T2):
(JSC::ARMv7Assembler::linkJumpAbsolute):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmFirst):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmSecond):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp5i6Imm4Reg4EncodedImm):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::makeJump):
(JSC::MacroAssemblerARMv7::makeBranch):
* jit/JIT.h:
* wtf/Platform.h:
2009-10-28 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Improve for..in enumeration performance
https://bugs.webkit.org/show_bug.cgi?id=30887
Improve indexing of an object with a for..in iterator by
identifying cases where get_by_val is being used with a iterator
as the subscript and replace it with a new get_by_pname
bytecode. get_by_pname then optimizes lookups that directly access
the base object.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetByVal):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::pushOptimisedForIn):
(JSC::BytecodeGenerator::popOptimisedForIn):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::emitSlow_op_get_by_pname):
* parser/Nodes.cpp:
(JSC::ForInNode::emitBytecode):
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::getOffset):
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
* runtime/JSValue.h:
(JSC::JSValue::):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::addAnonymousSlotsTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::addPropertyWithoutTransition):
Track the existence (or not) of non-enumerable properties.
* runtime/Structure.h:
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::hasNonEnumerableProperties):
(JSC::Structure::hasAnonymousSlots):
2009-10-28 Dmitry Titov <dimich@chromium.org>
Not reviewed, attemp to fix Windows build.
Touch the cpp file to cause recompile.
* wtf/Threading.cpp:
(WTF::threadEntryPoint):
2009-10-28 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=30805
Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this since Database removes tasks when it is stopped.
* wtf/MessageQueue.h:
(WTF::::removeIf):
2009-10-28 Afonso R. Costa Jr. <afonso.costa@openbossa.org>
Reviewed by Oliver Hunt.
[Qt] Enable YARR when YARR_JIT is enabled
https://bugs.webkit.org/show_bug.cgi?id=30730
When enabling or disabling JIT using JAVASCRIPTCORE_JIT, the ENABLE_YARR should
be toggled also.
* JavaScriptCore.pri:
2009-10-24 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Oliver Hunt.
Fix strict aliasing warning by switching reinterpret_cast to bitwise_cast.
strict-aliasing warnings in JSFunction.h
https://bugs.webkit.org/show_bug.cgi?id=27869
* runtime/JSFunction.h:
(JSC::JSFunction::nativeFunction):
(JSC::JSFunction::scopeChain):
(JSC::JSFunction::setScopeChain):
(JSC::JSFunction::setNativeFunction):
2009-10-28 Jan-Arve Sæther <jan-arve.saether@nokia.com>
Reviewed by Tor Arne Vestbø.
Build-fix for 64-bit Windows
* wtf/Platform.h: Make sure to use WTF_USE_JSVALUE64
2009-10-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix!).
* jit/JIT.h:
2009-10-26 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber-stamped by Darin Adler.
Export fastMalloc, fastCalloc, fastRealloc and fastFree on GCC/Unix
https://bugs.webkit.org/show_bug.cgi?id=30769
When using -fvisibility=hidden to hide all internal symbols by default
the malloc symbols will be hidden as well. For memory instrumentation
it is needed to provide an instrumented version of these symbols and
override the normal routines and by changing the visibility back to
default this becomes possible.
The only other solution would be to use system malloc instead of the
TCmalloc implementation but this will not allow to analyze memory
behavior with the default allocator.
* wtf/FastMalloc.h: Define WTF_FAST_MALLOC_EXPORT for GCC and !darwin
2009-10-27 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Samuel Q. Weinig.
Make the asserts protecting the offsets in the JIT more descriptive.
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
2009-10-27 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little bit of refactoring in the date code.
* JavaScriptCore.exp: Don't export this unused symbol.
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h: Removed some unused functions. Changed the default
constructor to ensure that a DateInstance is always initialized.
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype): Pass an initializer to our constructor,
since it now requires one.
* wtf/DateMath.cpp:
(WTF::msToGregorianDateTime): Only compute our offset from UTC if our
output will require it. Otherwise, our offset is 0.
2009-10-27 Geoffrey Garen <ggaren@apple.com>
Build fix: Mark DateInstaceCache.h private, so other frameworks can see it.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-10-27 Geoffrey Garen <ggaren@apple.com>
Build fix: re-readded this file.
* runtime/DateInstanceCache.h: Added.
(JSC::DateInstanceData::create):
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::DateInstanceCache):
(JSC::DateInstanceCache::add):
(JSC::DateInstanceCache::lookup):
2009-10-27 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler and Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=30800
Cache recently computed date data.
SunSpider reports a ~0.5% speedup, mostly from date-format-tofte.js.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Added new file.
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
(JSC::DateInstance::getGregorianDateTime): Use the shared cache.
* runtime/DateInstance.h: Renamed m_cache to m_data, to avoid the confusion
of a "cache cache".
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Pass an ExecState to these functions, so they
can access the DateInstanceCache.
* runtime/JSGlobalData.h: Keep a DateInstanceCache.
2009-10-27 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Ensures that JavaScriptCore/wtf/CurrentTime.cpp is not built in PLATFORM(CHROMIUM) builds.
Chromium uses a different method to calculate the current time than is used in
JavaScriptCore/wtf/CurrentTime.cpp. This can lead to time skew when calls to currentTime() and Chromium's time
function are mixed. In particular, timers can get scheduled in the past which leads to 100% CPU use.
See http://code.google.com/p/chromium/issues/detail?id=25892 for an example.
https://bugs.webkit.org/show_bug.cgi?id=30833
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* wtf/CurrentTime.cpp:
2009-10-27 Peter Varga <pvarga@inf.u-szeged.hu>
Rubber-stamped by Tor Arne Vestbø.
Fix typo in RegexInterpreter.cpp and RegexJIT.cpp alterantive to
alternative.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::ByteCompiler::alternativeBodyDisjunction):
(JSC::Yarr::ByteCompiler::alternativeDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateDisjunction):
2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Make .rc files compile on Windows without depending on MFC headers
https://bugs.webkit.org/show_bug.cgi?id=30750
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc: Use
winresrc.h because it exists even when MFC is not installed, and is
all that's needed here.
2009-10-26 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
The thunkReturnAddress is on JITStackFrame on ARM JIT as well
https://bugs.webkit.org/show_bug.cgi?id=30782
Move the thunkReturnAddress from top of the stack into the JITStackFrame
structure. This is a requirement for JSValue32_64 support on ARM.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::ret): Return with link register
(JSC::MacroAssemblerARM::prepareCall): Store the return address in link register
* jit/JIT.h: Remove unused ctiReturnRegister
* jit/JITInlineMethods.h: Same as ARMv7
(JSC::JIT::restoreArgumentReference): Ditto.
(JSC::JIT::restoreArgumentReferenceForTrampoline): Ditto.
* jit/JITOpcodes.cpp: Remove ctiReturnRegister related instruction
* jit/JITStubs.cpp: Store thunkReturnAddress on JITStackFrame. Use
small trampoline functions which handle return addresses for each
CTI_STUB_FUNCTION.
* jit/JITStubs.h: Store thunkReturnAddress on JITStackFrame
(JSC::JITStackFrame::returnAddressSlot): Return with the address of thunkReturnAddress
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter): Remove the unnecessary instruction
2009-10-26 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Adds ability to disable ReadWriteLock on platforms (eg Android) that use pthreads but do not support pthread_rwlock.
https://bugs.webkit.org/show_bug.cgi?id=30713
* wtf/Platform.h: Modified. Defines HAVE_PTHREAD_RWLOCK for all platforms currently using pthreads.
* wtf/Threading.h: Modified. Use pthread_rwlock_t only when HAVE_PTHREAD_RWLOCK is defined.
* wtf/ThreadingPthreads.cpp: Modified. Build ReadWriteLock methods only when HAVE_PTHREAD_RWLOCK is defined.
2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Holger Freyther.
[Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
https://bugs.webkit.org/show_bug.cgi?id=30476
Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
to jsc.exe.
* jsc.pro:
2009-10-23 Steve Block <steveblock@google.com>
Reviewed by Dmitry Titov.
Fixes a leak in createThreadInternal on Android.
https://bugs.webkit.org/show_bug.cgi?id=30698
* wtf/ThreadingPthreads.cpp: Modified.
(WTF::createThreadInternal): Avoid leaking a ThreadData object on failure.
2009-10-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Alexey Proskuryakov.
Fixed ASSERT when opening Safari's Caches window while the Web Inspector
is open.
* runtime/Collector.cpp:
(JSC::typeName): Added two new types to the type name list in the Collector.
These types have been around for a while, but nobody remembered to consider them here.
* runtime/JSCell.h:
(JSC::JSCell::isPropertyNameIterator):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::isPropertyNameIterator): Give the Collector
a way to tell if a cell is a JSPropertyNameIterator.
2009-10-22 Steve Falkenburg <sfalken@apple.com>
Reviewed by Jon Honeycutt.
https://bugs.webkit.org/show_bug.cgi?id=30686
Remove debug-specific def file.
Only Debug_All target uses JavaScriptCore_debug.dll naming, and since
that target is only used internally, maintaining two files just to
suppress a single link warning isn't worthwhile.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Removed.
2009-10-21 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/7270320> Screenshots of off-screen plug-ins are blank
<rdar://problem/7270314> After halting a transparent PluginView on
Windows, the transparency is applied twice
Reviewed by Dan Bernstein.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Export WTF::deleteOwnedPtr(HDC).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Ditto.
2009-10-20 Geoffrey Garen <ggaren@apple.com>
Windows build fix: updated variable name.
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
2009-10-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_next_pname): Slightly tweaked this #ifdef to match the
size of a JSValue because m_jsStrings is an array of JSValues.
2009-10-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Fixed a 64-bit regression caused by the fix for
https://bugs.webkit.org/show_bug.cgi?id=30570.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_next_pname): Use TimesEight stepping on 64-bit, since
64-bit pointers are eight bytes long.
2009-10-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Refactored DateInstance::msToGregorianDateTime so that a DateInstance's
caller doesn't need to supply the DateInstance's own internal value to
the DateInstance.
* runtime/DateInstance.cpp:
(JSC::DateInstance::getGregorianDateTime): Renamed from "msToGregorianDateTime".
* runtime/DateInstance.h:
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Also renamed "utc" to "outputIsUTC", for clarity.
2009-10-20 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Geoffrey Garen.
The op_next_pname should use 4 bytes addressing mode in case of JSValue32
https://bugs.webkit.org/show_bug.cgi?id=30570
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_next_pname):
2009-10-20 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Move OverridesMarkChildren flag from DatePrototype to its parent class
https://bugs.webkit.org/show_bug.cgi?id=30372
* runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
* runtime/DatePrototype.h:
2009-10-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Tightened up some put_by_id_transition code generation.
https://bugs.webkit.org/show_bug.cgi?id=30539
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition): No need to do object type
checks or read Structures and prototypes from objects: they're all known
constants at compile time.
2009-10-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added a private API for getting a global context from a context, for
clients who want to preserve a context for a later callback.
* API/APICast.h:
(toGlobalRef): Added an ASSERT, since this function is used more often
than before.
* API/JSContextRef.cpp:
* API/JSContextRefPrivate.h: Added. The new API.
* API/tests/testapi.c:
(print_callAsFunction):
(main): Test the new API.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj: Build and export the new API.
2009-10-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Tightened up some instanceof code generation.
https://bugs.webkit.org/show_bug.cgi?id=30488
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof): No need to do object type checks -
cell type checks and ImplementsDefaultHasIntance checks implicitly
supersede object type checks.
2009-10-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
https://bugs.webkit.org/show_bug.cgi?id=30474
stricmp and strnicmp are deprecated beginning in Visual
C++ 2005. Use _stricmp and _strnicmp instead in StringExtras.h.
* wtf/StringExtras.h:
(strncasecmp):
(strcasecmp):
2009-10-16 Geoffrey Garen <ggaren@apple.com>
Build fix: apparently we shouldn't export those symbols?
* JavaScriptCore.exp:
2009-10-16 Geoffrey Garen <ggaren@apple.com>
Build fix: export some symbols.
* JavaScriptCore.exp:
2009-10-16 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
structure typeinfo flags should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=30468
Add StructureFlag constant to the various JSC classes and use
it for the TypeInfo construction. This allows us to simply
accumulate flags by basing each classes StructureInfo on its parents.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GlobalEvalFunction.h:
(JSC::GlobalEvalFunction::createStructure):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSByteArray.h:
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createStructure):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
2009-10-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fast for-in enumeration: Cache JSPropertyNameIterator; cache JSStrings
in JSPropertyNameIterator; inline more code.
1.024x as fast on SunSpider (fasta: 1.43x as fast).
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetPropertyNames):
(JSC::BytecodeGenerator::emitNextPropertyName):
* bytecompiler/BytecodeGenerator.h: Added a few extra operands to
op_get_pnames and op_next_pname so that we can track iteration state
in the register file instead of in the JSPropertyNameIterator. (To be
cacheable, the JSPropertyNameIterator must be stateless.)
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::Interpreter::privateExecute): Updated for in-RegisterFile
iteration state tracking.
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_pnames): Updated for in-RegisterFile
iteration state tracking.
(JSC::JIT::emit_op_next_pname): Inlined code generation for op_next_pname.
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::): Added has_property and to_object stubs. Removed op_next_pname
stub, since has_property is all we need anymore.
* parser/Nodes.cpp:
(JSC::ForInNode::emitBytecode): Updated for in-RegisterFile
iteration state tracking.
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames): Don't do caching at this layer
anymore, since we don't create a JSPropertyNameIterator at this layer.
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create): Do do caching at this layer.
(JSC::JSPropertyNameIterator::get): Updated for in-RegisterFile
iteration state tracking.
(JSC::JSPropertyNameIterator::markChildren): Mark our JSStrings.
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::size):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::JSPropertyNameIterator::cachedStructure):
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
(JSC::JSPropertyNameIterator::cachedPrototypeChain):
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::Structure::setEnumerationCache): Don't store iteration state in
a JSPropertyNameIterator. Do cache a JSPropertyNameIterator in a
Structure.
* runtime/JSValue.h:
(JSC::asCell):
* runtime/MarkStack.h: Make those mischievous #include gods happy.
* runtime/ObjectConstructor.cpp:
* runtime/Operations.h:
(JSC::normalizePrototypeChain): Renamed countPrototypeChainEntriesAndCheckForProxies
to normalizePrototypeChain, since it changes dictionary prototypes to
non-dictionary objects.
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/PropertyNameArray.h:
(JSC::PropertyNameArrayData::PropertyNameArrayData):
(JSC::PropertyNameArray::data):
(JSC::PropertyNameArray::size):
(JSC::PropertyNameArray::begin):
(JSC::PropertyNameArray::end): Simplified some code here to help with
current and future refactoring.
* runtime/Protect.h:
* runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition): No need to clear
the enumeration cache with adding / removing properties without
transition. It is an error to add / remove properties without transition
once an object has been observed, and we can ASSERT to catch that.
* runtime/Structure.h:
(JSC::Structure::enumerationCache): Changed the enumeration cache to
hold a JSPropertyNameIterator.
* runtime/StructureChain.cpp:
* runtime/StructureChain.h:
(JSC::StructureChain::head): Removed StructureChain::isCacheable because
it was wrong-headed in two ways: (1) It gave up when a prototype was a
dictionary, but instead we want un-dictionary heavily accessed
prototypes; (2) It folded a test for hasDefaultGetPropertyNames() into
a generic test for "cacheable-ness", but hasDefaultGetPropertyNames()
is only releavant to for-in caching.
2009-10-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Add a Debug_All configuration to build entire stack as debug.
Change Debug_Internal to:
- stop using _debug suffix for all WebKit/Safari binaries
- not use _debug as a DLL naming suffix
- use non-debug C runtime lib.
* JavaScriptCore.vcproj/JavaScriptCore.make: Debug build in makefile should build Debug_All.
* JavaScriptCore.vcproj/JavaScriptCore.sln: Add Debug_All configuration.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add Debug_All configuration.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add Debug_All configuration.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Add Debug_All configuration.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_All configuration.
* JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_All configuration.
2009-10-16 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Last part -- replace HasDefaultGetPropertyNames with OverridesGetPropertyNames
flag.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GlobalEvalFunction.h:
(JSC::GlobalEvalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createStructure):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::overridesGetPropertyNames):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
* runtime/StructureChain.cpp:
(JSC::StructureChain::isCacheable):
2009-10-16 Kevin Ollivier <kevino@theolliviers.com>
wxMSW build fix, we can't use the simple hash there because the PlatformModuleVersion
structure differs.
* wtf/Platform.h:
2009-10-16 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Implement ExecutableAllocator for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29946
Tested with YARR JIT enabled for Symbian;
This patch does not (yet) enable YARR JIT by default.
* JavaScriptCore.pri:
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorSymbian.cpp: Added.
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
2009-10-15 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Part 2 -- Reverse the TypeInfo HasDefaultMark flag to OverridesMarkChildren, etc
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GetterSetter.h:
(JSC::GetterSetter::createStructure):
* runtime/GlobalEvalFunction.h:
(JSC::GlobalEvalFunction::createStructure):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
(JSC::MarkStack::markChildren):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createStructure):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::createStructure):
* runtime/JSNumberCell.h:
(JSC::JSNumberCell::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSString.h:
(JSC::JSString::createStructure):
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::overridesMarkChildren):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
2009-10-14 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Part 1. Reverse the HasStandardGetOwnPropertySlot flag.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GlobalEvalFunction.h:
(JSC::GlobalEvalFunction::createStructure):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createStructure):
* runtime/JSNumberCell.h:
(JSC::JSNumberCell::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
(JSC::JSCell::fastGetOwnPropertySlot):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSString.h:
(JSC::JSString::createStructure):
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::overridesGetOwnPropertySlot):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
2009-10-14 Kevin Ollivier <kevino@theolliviers.com>
2009-10-14 Darin Adler <darin@apple.com>
Additions so fix for https://bugs.webkit.org/show_bug.cgi?id=18994
can build on Windows.
* wtf/MathExtras.h: Added llround and llroundf for Windows.
2009-10-14 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Set ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for plugins while we're still building stubs.
* wtf/Platform.h:
2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
Refactor ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
https://bugs.webkit.org/show_bug.cgi?id=30278
Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH
from the make system into common code.
* wtf/Platform.h:
2009-10-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
ARM compiler does not understand reinterpret_cast<void*>
https://bugs.webkit.org/show_bug.cgi?id=29034
Change reinterpret_cast<void*> to regular C style (void*) cast
for the ARM RVCT compiler.
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
* jit/JITOpcodes.cpp: Cast to FunctionPtr first
instead of directly casting to reinterpret_cast
* jit/JITStubCall.h: Ditto + change the type of m_stub
from void* to FunctionPtr.
(JSC::JITStubCall::JITStubCall):
(JSC::JITStubCall::call):
* jit/JITStubs.cpp: Ditto.
(JSC::DEFINE_STUB_FUNCTION(EncodedJSValue, op_throw)):
2009-10-11 Oliver Hunt <oliver@apple.com>
Re-enable the JIT.
* wtf/Platform.h:
2009-10-10 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Support for String.trim(), String.trimLeft() and String.trimRight() methods
https://bugs.webkit.org/show_bug.cgi?id=26590
Implement trim, trimLeft, and trimRight
* runtime/StringPrototype.cpp:
(JSC::isTrimWhitespace):
Our normal string whitespace function does not include U+200B which
is needed for compatibility with mozilla's implementation of trim.
U+200B does not appear to be expected according to spec, however I am
choosing to be lax, and match mozilla behavior so have added this
exception.
(JSC::trimString):
2009-10-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Eliminated some legacy bytecode weirdness.
Use vPC[x] subscripting instead of ++vPC to access instruction operands.
This is simpler, and often more efficient.
To support this, and to remove use of hard-coded offsets in bytecode and
JIT code generation and dumping, calculate jump offsets from the beginning
of an instruction, rather than the middle or end.
Also, use OPCODE_LENGTH instead of hard-coded constants for the sizes of
opcodes.
SunSpider reports no change in JIT mode, and a 1.01x speedup in Interpreter
mode.
* bytecode/CodeBlock.cpp:
(JSC::printConditionalJump):
(JSC::CodeBlock::dump):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC::BytecodeGenerator::emitJumpScopes):
(JSC::BytecodeGenerator::emitNextPropertyName):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitJumpSubroutine):
(JSC::prepareJumpTableForImmediateSwitch):
(JSC::prepareJumpTableForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::endSwitch):
* bytecompiler/Label.h:
(JSC::Label::setLocation):
(JSC::Label::bind):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveBase):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop):
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emitSlow_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
(JSC::JIT::emit_op_loop_if_true):
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_jmp_scopes):
2009-10-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Migrated some code that didn't belong out of Structure.
SunSpider says maybe 1.03x faster.
* runtime/JSCell.h: Nixed Structure::markAggregate, and made marking of
a Structure's prototype the direct responsility of the object using it.
(Giving Structure a mark function was misleading because it implied that
all live structures get marked during GC, when they don't.)
* runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren): Added code to mark prototypes stored
on the global object. Maybe this wasn't necessary, but now we don't have
to wonder.
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getEnumerableNamesFromClassInfoTable):
* runtime/JSObject.h:
(JSC::JSObject::markChildrenDirect):
* runtime/PropertyNameArray.h:
* runtime/Structure.cpp:
* runtime/Structure.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache): Moved property name gathering code
from Structure to JSObject because having a Structure iterate its JSObject
was a layering violation. A JSObject is implemented using a Structure; not
the other way around.
2009-10-09 Mark Rowe <mrowe@apple.com>
Attempt to fix the GTK release build.
* GNUmakefile.am: Include Grammar.cpp in release builds now that
AllInOneFile.cpp is gone.
2009-10-09 Gabor Loki <loki@inf.u-szeged.hu>
Rubber-stamped by Eric Seidel.
Add ARM JIT support for Gtk port (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=30228
* GNUmakefile.am:
2009-10-08 Geoffrey Garen <ggaren@apple.com>
Tiger build fix: added a few more variable initializations.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncSearch):
2009-10-08 Geoffrey Garen <ggaren@apple.com>
Qt build fix: added missing #include.
* jsc.cpp:
2009-10-08 Geoffrey Garen <ggaren@apple.com>
Tiger build fix: initialize variable whose initialization the compiler
can't otherwise figure out.
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
2009-10-08 Geoffrey Garen <ggaren@apple.com>
Windows build fix: updated exports.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-10-08 Geoffrey Garen <ggaren@apple.com>
Tiger build fix: fixed file name case.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-10-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
At long last, I pronounce the death of AllInOneFile.cpp.
SunSpider reports a 1.01x speedup.
* AllInOneFile.cpp: Removed.
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj: Added missing project files
to compilation stages.
* parser/Grammar.y:
* parser/Lexer.cpp:
* parser/Lexer.h:
(JSC::jscyylex):
* runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
* runtime/Collector.h:
* runtime/JSCell.cpp:
(JSC::JSCell::operator new):
* runtime/JSCell.h:
(JSC::JSCell::operator new):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::operator new):
* runtime/JSNumberCell.h:
(JSC::JSNumberCell::operator new):
* runtime/JSString.cpp:
* runtime/JSString.h:
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructorPrivate::RegExpConstructorPrivate):
(JSC::RegExpConstructorPrivate::lastOvector):
(JSC::RegExpConstructorPrivate::tempOvector):
(JSC::RegExpConstructorPrivate::changeLastOvector):
(JSC::RegExpConstructor::performMatch):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
* yarr/RegexJIT.cpp:
* yarr/RegexJIT.h:
(JSC::Yarr::executeRegex): Inlined a few things that Shark said
were hot, on the presumption that AllInOneFile.cpp used to inline them
automatically.
2009-10-08 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Fix for JIT'ed op_call instructions (evals, constructs, etc.)
when !ENABLE(JIT_OPTIMIZE_CALL) && USE(JSVALUE32_64)
https://bugs.webkit.org/show_bug.cgi?id=30201
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
2009-10-07 Geoffrey Garen <ggaren@apple.com>
Windows build fix: removed no longer exported symbol.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-10-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed <rdar://problem/5751979> Database code takes JSLock on secondary
thread, permanently slowing down JavaScript
Removed the optional lock from Heap::protect, Heap::unprotect, and friends,
since WebCore no longer uses it.
* JavaScriptCore.exp:
* runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):
* runtime/Collector.h:
2009-10-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's IdentifierArena
https://bugs.webkit.org/show_bug.cgi?id=30158
Inherits IdentifierArena class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/ParserArena.cpp:36.
* parser/ParserArena.h:
2009-10-07 Adam Roben <aroben@apple.com>
Export DateInstance::info in a way that works on Windows
Fixes <http://webkit.org/b/30171>
fast/dom/Window/window-postmessage-clone.html fails on Windows
Reviewed by Anders Carlsson.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Removed the export of DateInstance::info from here.
* runtime/DateInstance.h: Use JS_EXPORTDATA to export
DateInstance::info, which is the required way of exporting data on
Windows.
2009-10-07 Jørgen Lind <jorgen.lind@nokia.com>
Reviewed by Simon Hausmann.
When enabling or disabling the JIT through .qmake.cache, make sure
to also toggle ENABLE_YARR_JIT.
* JavaScriptCore.pri:
2009-10-06 Priit Laes <plaes@plaes.org>
Reviewed by Gavin Barraclough.
Linking fails with "relocation R_X86_64_PC32 against symbol
`cti_vm_throw'"
https://bugs.webkit.org/show_bug.cgi?id=28422
* jit/JITStubs.cpp:
Mark cti_vm_throw symbol as PLT-indirect symbol, so it doesn't end up
in text segment causing relocation errors on amd64 architecture.
Introduced new define SYMBOL_STRING_RELOCATION for such symbols.
2009-10-06 Oliver Hunt <oliver@apple.com>
Windows linking fix
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-10-06 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (build fix).
Windows build fix.
* runtime/DateInstance.cpp:
2009-10-05 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
It should be possible to post (clone) built-in JS objects to Workers
https://bugs.webkit.org/show_bug.cgi?id=22878
Expose helpers to throw correct exceptions during object graph walk
used for cloning and add a helper function to create Date instances
without going through the JS Date constructor function.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
* runtime/ExceptionHelpers.cpp:
(JSC::createTypeError):
* runtime/ExceptionHelpers.h:
2009-10-06 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
StringImpl needs a method to get an instance for another thread which doesn't copy the underlying buffer.
https://bugs.webkit.org/show_bug.cgi?id=30095
* wtf/CrossThreadRefCounted.h:
Removed an unused function and assert improvement.
(WTF::CrossThreadRefCounted::isOwnedByCurrentThread): Moved out common code from asserts.
(WTF::CrossThreadRefCounted::ref): Changed assert to use the common method.
(WTF::CrossThreadRefCounted::deref): Changed assert to use the common method.
(WTF::CrossThreadRefCounted::crossThreadCopy): Since this includes a potentially
non-threadsafe operation, add an assert that the class is owned by the current thread.
2009-10-05 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Add Symbian files to the list of excludes.
* wscript:
2009-10-05 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Remove precompiled header from JavaScriptCore compilation to
prevent qmake warning during autonomous compilation.
https://bugs.webkit.org/show_bug.cgi?id=30069
* JavaScriptCore.pro:
2009-10-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed the concept of a "fast access cutoff" in arrays, because it
punished some patterns of array access too much, and made things too
complex for inlining in some cases.
1.3% speedup on SunSpider.
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
* jit/JITStubs.cpp:
* jit/JITStubs.h:
(JSC::): Check m_vectorLength instead of m_fastAccessCutoff when
getting / putting from / to an array. Inline putting past the end of
the array.
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):
* runtime/JSArray.h:
(JSC::JSArray::canGetIndex):
(JSC::JSArray::canSetIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::markChildrenDirect): Removed m_fastAccessCutoff, and
replaced with checks for JSValue() to detect reads and writes from / to
uninitialized parts of the array.
2009-10-02 Jonni Rainisto <jonni.rainisto@nokia.com>
Reviewed by Darin Adler.
Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined
https://bugs.webkit.org/show_bug.cgi?id=29956
* wtf/RandomNumber.cpp:
(WTF::randomNumber): Added PLATFORM(WIN_OS) to handle 15bit rand()
2009-10-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Take one branch instead of two to test for JSValue().
1.1% SunSpider speedup.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.
* runtime/JSValue.cpp:
(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.
* runtime/JSValue.h:
(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.
(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.
(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.
2009-10-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Mark Rowe.
<https://bugs.webkit.org/show_bug.cgi?id=29989>
Safari version number shouldn't be exposed in WebKit code
For a WebKit version of 532.3.4:
Product version is: 5.32.3.4 (was 4.0.3.0)
File version is: 5.32.3.4 (was 4.532.3.4)
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:
2009-10-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Fix the Qt on Mac OS X build.
* wtf/FastMalloc.cpp:
2009-10-02 Jørgen Lind <jorgen.lind@nokia.com>
Reviewed by Simon Hausmann.
Allow enabling and disabling of the JIT through a qmake variable.
Qt's configure may set this variable through .qmake.cache if a
commandline option is given and/or the compile test for hwcap.h
failed/succeeded.
* JavaScriptCore.pri:
2009-10-01 Mark Rowe <mrowe@apple.com>
Fix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported on Tiger.
* Configurations/FeatureDefines.xcconfig:
2009-10-01 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=29187
Don't inline ~ListRefPtr() to work around winscw compiler forward declaration
bug regarding templated classes.
The compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812
The change will be reverted when the above bug is fixed in winscw compiler.
* wtf/ListRefPtr.h:
(WTF::::~ListRefPtr):
2009-10-01 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Allow custom memory allocation control for the whole JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=27029
Since in JavaScriptCore almost every class which has been instantiated by operator new is
inherited from FastAllocBase (bug #20422), we disable customizing global operator new for the Qt-port
when USE_SYSTEM_MALLOC=0.
Add #include <unistd.h> to FastMalloc.cpp because it's used by TCMalloc_PageHeap::scavengerThread().
(It's needed for the functionality of TCmalloc.)
Add TCSystemAlloc.cpp to JavaScriptCore.pri if USE_SYSTEM_MALLOC is disabled.
* JavaScriptCore.pri:
* wtf/FastMalloc.cpp:
(WTF::sleep):
* wtf/FastMalloc.h:
2009-09-30 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by George Staikos.
Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
https://bugs.webkit.org/show_bug.cgi?id=29122
Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
when Thumb-2 instruction set is the required target. The
PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
case where the code is common the PLATFORM(ARM) have to be used.
Modified by George Wright <gwright@rim.com> to correctly work
with the RVCT-defined __TARGET_ARCH_ARM and __TARGET_ARCH_THUMB
compiler macros, as well as adding readability changes.
* wtf/Platform.h:
2009-09-30 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Devirtualise array toString conversion
Tweak the implementation of Array.prototype.toString to have a fast path
when acting on a true JSArray.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Geoffrey Garen.
Buildfix for platforms using JSVALUE32.
https://bugs.webkit.org/show_bug.cgi?id=29915
After http://trac.webkit.org/changeset/48905 the build broke in JSVALUE32 case.
Also removed unreachable code.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
- Declaration of "OperandTypes types" moved before first use.
- Typos fixed: dst modified to result, regT2 added.
- Unreachable code removed.
(JSC::JIT::emitSlow_op_add):
- Missing declaration of "OperandTypes types" added.
2009-09-30 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
Reduce heap size on Symbian from 64MB to 8MB.
This is not a perfect fix, it requires more fine tuning.
But this makes it possible again to debug in the emulator,
which is more important in order to be able to fix other
run-time issues.
* runtime/Collector.h:
2009-09-30 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
Fix CRASH() macro for Symbian build.
* wtf/Assertions.h: Added missing }
2009-09-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Inlined a few math operations.
~1% SunSpider speedup.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub): Don't take a stub call when operating on
a constant int and a double.
2009-09-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Tidy up codeblock sampler
https://bugs.webkit.org/show_bug.cgi?id=29836
Some rather simple refactoring of codeblock sampler so that
it's easier for us to use it to find problems in non-jsc
environments
* JavaScriptCore.exp:
* bytecode/SamplingTool.h:
* debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::enableSampler):
(JSC::Interpreter::dumpSampleData):
(JSC::Interpreter::startSampling):
(JSC::Interpreter::stopSampling):
* interpreter/Interpreter.h:
(JSC::Interpreter::sampler):
* jit/JIT.h:
* jsc.cpp:
(runWithScripts):
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Executable.h:
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::create):
(JSC::ProgramExecutable::ProgramExecutable):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::startSampling):
(JSC::JSGlobalData::stopSampling):
(JSC::JSGlobalData::dumpSampleData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
2009-09-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29895
The following files are generated by JavaScriptCore's GYP file and should be ignored:
pcre.mk
wtf.scons
wtf.mk
SConstruct
wtf_config.scons
wtf_config.mk
pcre.scons
* JavaScriptCore.gyp: Changed property svn:ignore.
2009-09-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized an optimization for adding non-numbers.
SunSpider says maybe a tiny speedup.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
2009-09-29 Geoffrey Garen <ggaren@apple.com>
Windows build fix: export a new symbol.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed virtual destructor from JSGlobalObjectData to eliminate pointer
fix-ups when accessing JSGlobalObject::d.
Replaced with an explicit destructor function pointer.
6% speedup on bench-alloc-nonretained.js.
* JavaScriptCore.exp:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::destroyJSGlobalObjectData):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::JSGlobalObject):
2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by David Kilzer.
[Qt] Assert messages prints visible in Symbian
https://bugs.webkit.org/show_bug.cgi?id=29808
Asserts use vprintf to print the messages to stderr.
In Symbian Open C it is not possible to see stderr so
I routed the messages to stdout instead.
* wtf/Assertions.cpp:
2009-09-29 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Darin Adler.
[Qt] Symbian CRASH macro implementation
Added Symbian specific crash macro that
stops to crash line if JIT debugging is used.
Additional differentiation of access violation
(KERN-EXEC 3) and CRASH panic.
* wtf/Assertions.h:
2009-09-28 Mark Rowe <mrowe@apple.com>
Fix the PowerPC build.
* JavaScriptCore.exp:
2009-09-28 Mark Rowe <mrowe@apple.com>
Reviewed by Gavin Barraclough.
<rdar://problem/7195704> JavaScriptCore fails to mark registers when built for x86_64 using LLVM GCC.
* runtime/Collector.cpp:
(JSC::Heap::markCurrentThreadConservatively): Force jmp_buf to use the appropriate alignment for a pointer
to ensure that we correctly interpret the contents of registers during marking.
2009-09-28 Geoffrey Garen <ggaren@apple.com>
Windows build fix: added new exports.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-28 Geoffrey Garen <ggaren@apple.com>
Windows build fix: removed exports that no longer exist.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
NotNullPassRefPtr: smart pointer optimized for passing references that are not null
https://bugs.webkit.org/show_bug.cgi?id=29822
Added NotNullPassRefPtr, and deployed it in all places that initialize
JavaScript objects.
2.2% speedup on bench-allocate-nonretained.js.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::JSCallbackObject):
* JavaScriptCore.exp:
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::addFunctionExpr):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
* runtime/ArrayPrototype.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/BooleanObject.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
* runtime/ErrorConstructor.h:
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/ErrorInstance.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
* runtime/FunctionPrototype.h:
* runtime/GlobalEvalFunction.cpp:
(JSC::GlobalEvalFunction::GlobalEvalFunction):
* runtime/GlobalEvalFunction.h:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
(JSC::InternalFunction::InternalFunction):
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
* runtime/JSByteArray.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSONObject.h:
(JSC::JSONObject::JSONObject):
* runtime/JSObject.h:
(JSC::JSObject::JSObject):
(JSC::JSObject::setStructure):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
* runtime/MathObject.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
* runtime/NumberConstructor.h:
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
* runtime/NumberObject.h:
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
* runtime/PropertyNameArray.h:
(JSC::PropertyNameArrayData::setCachedPrototypeChain):
* runtime/PrototypeFunction.cpp:
(JSC::PrototypeFunction::PrototypeFunction):
* runtime/PrototypeFunction.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
* runtime/RegExpConstructor.h:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
* runtime/RegExpObject.h:
(JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
* runtime/StringObject.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
* wtf/PassRefPtr.h:
(WTF::NotNullPassRefPtr::NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::~NotNullPassRefPtr):
(WTF::NotNullPassRefPtr::get):
(WTF::NotNullPassRefPtr::clear):
(WTF::NotNullPassRefPtr::releaseRef):
(WTF::NotNullPassRefPtr::operator*):
(WTF::NotNullPassRefPtr::operator->):
(WTF::NotNullPassRefPtr::operator!):
(WTF::NotNullPassRefPtr::operator UnspecifiedBoolType):
* wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::operator==):
2009-09-28 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Hard dependency on SSE2 instruction set with JIT
https://bugs.webkit.org/show_bug.cgi?id=29779
Add floating point support checks to op_jfalse and op_jtrue, and
fix the logic for the slow case of op_add
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_add):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
2009-09-28 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium port - recognize we are being built independently
of chromium and look for dependencies under webkit/chromium rather
than chromium/src.
https://bugs.webkit.org/show_bug.cgi?id=29722
* JavaScriptCore.gyp/JavaScriptCore.gyp:
2009-09-28 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
[Qt] Implement XSLT support with QtXmlPatterns.
https://bugs.webkit.org/show_bug.cgi?id=28303
* wtf/Platform.h: Add a WTF_USE_QXMLQUERY #define.
2009-09-28 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Remove __clear_cache which is an internal function of GCC
https://bugs.webkit.org/show_bug.cgi?id=28886
Although __clear_cache is exported from GCC, this is an internal
function. GCC makes no promises about it.
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
2009-09-28 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix an absolute path to somewhere in Oliver's machine to a relative path
for derived JSONObject.lut.h.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-09-28 Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed by Simon Hausmann.
Add ARM version detection for Windows CE.
* wtf/Platform.h:
2009-09-26 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
Add MarkStackSymbian.cpp to build JavascriptCore for Symbian.
Re-use Windows shrinkAllocation implementation because Symbian doesn't
support releasing part of memory region.
Use fastMalloc and fastFree to implement allocateStack and releaseStack
for Symbian port.
* JavaScriptCore.pri:
* runtime/MarkStack.h:
(JSC::MarkStack::MarkStackArray::shrinkAllocation):
* runtime/MarkStackSymbian.cpp: Added.
(JSC::MarkStack::initializePagesize):
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
2009-09-25 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Fix unaligned data access in YARR_JIT on ARMv5 and below.
https://bugs.webkit.org/show_bug.cgi?id=29695
On ARMv5 and below all data access should be naturally aligned.
In the YARR_JIT there is a case when character pairs are
loaded from the input string, but this data access is not
naturally aligned. This fix introduces load32WithUnalignedHalfWords
and branch32WithUnalignedHalfWords functions which contain
naturally aligned memory loads - half word loads - on ARMv5 and below.
* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
(JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32WithUnalignedHalfWords):
(JSC::MacroAssemblerARMv7::branch32):
(JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load32WithUnalignedHalfWords):
(JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
* wtf/Platform.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generatePatternCharacterPair):
2009-09-25 Jeremy Orlow <jorlow@chromium.org>
This is breaking Chromium try bots, so I'm counting this as a build fix.
Add more svn:ignore exceptions. On different platforms, these files are
generated with different case for JavaScriptCore. Also there are some
wtf project files that get built apparently.
* JavaScriptCore.gyp: Changed property svn:ignore.
2009-09-25 Ada Chan <adachan@apple.com>
Build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Inlined some object creation code, including lexicalGlobalObject access
https://bugs.webkit.org/show_bug.cgi?id=29750
SunSpider says 0.5% faster.
0.8% speedup on bench-alloc-nonretained.js.
2.5% speedup on v8-splay.js.
* interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
* interpreter/CallFrame.h:
(JSC::ExecState::lexicalGlobalObject):
(JSC::ExecState::globalThisValue):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::~ScopeChainNode):
(JSC::ScopeChainNode::push):
(JSC::ScopeChain::ScopeChain):
(JSC::ScopeChain::globalObject): Added a globalObject data member to ScopeChainNode.
Replaced accessor function for globalObject() with data member. Replaced
globalThisObject() accessor with direct access to globalThis, to match.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/JSGlobalObject.h: Inlined array and object construction.
2009-09-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Gavin Barraclough.
Add ARM version detection rules for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29715
* wtf/Platform.h:
2009-09-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark "Do It!" Rowe.
Some GCC versions don't like C++-style comments in preprocessor
directives, change to C-style to shut them up.
* wtf/Platform.h:
2009-09-24 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Division is needlessly slow in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=29723
Add codegen for op_div on x86-64
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_div):
* jit/JITInlineMethods.h:
(JSC::JIT::isOperandConstantImmediateDouble):
(JSC::JIT::addressFor):
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitJumpSlowCaseIfNotImmediateNumber):
2009-09-24 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Add GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=29724
Adding the following files to the svn:ignore list (all in the
JavaScriptCore/JavaScriptCore.gyp directory)
JavaScriptCore.xcodeproj
JavaScriptCore.sln
JavaScriptCore.vcproj
JavaScriptCore_Debug.rules
JavaScriptCore_Release.rules
JavaScriptCore_Release - no tcmalloc.rules
JavaScriptCore_Purify.rules
JavaScriptCore.mk
JavaScriptCore_Debug_rules.mk
JavaScriptCore_Release_rules.mk
JavaScriptCore_Release - no tcmalloc_rules.mk
JavaScriptCore_Purify_rules.mk
JavaScriptCore.scons
JavaScriptCore_main.scons
* JavaScriptCore.gyp: Changed property svn:ignore.
2009-09-24 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Barth.
Replace platform-dependent code with WTF::currentTime()
https://bugs.webkit.org/show_bug.cgi?id=29148
* jsc.cpp:
(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):
* runtime/TimeoutChecker.cpp:
(JSC::getCPUTime):
2009-09-24 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/7215058> FastMalloc scavenging thread should be named
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavengerThread): Set the thread name.
* wtf/Platform.h: Move the knowledge of whether pthread_setname_np exists to here as HAVE(PTHREAD_SETNAME_NP).
* wtf/ThreadingPthreads.cpp:
(WTF::setThreadNameInternal): Use HAVE(PTHREAD_SETNAME_NP).
2009-09-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Renamed clear to removeAll, as suggested by Darin Adler.
* wtf/HashCountedSet.h:
(WTF::::removeAll):
2009-09-24 Mark Rowe <mrowe@apple.com>
Reviewed by Gavin Barraclough.
Fix FastMalloc to build with assertions enabled.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::ReleaseToSpans):
* wtf/TCSpinLock.h:
(TCMalloc_SpinLock::IsHeld):
2009-09-24 Geoffrey Garen <ggaren@apple.com>
Suggested by Darin Adler.
Removed some unnecessary parameter names.
* wtf/HashCountedSet.h:
2009-09-24 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
On Windows JSChar is typedef'ed to wchar_t.
When building with WINSCW for Symbian we need to do the
same typedef.
* API/JSStringRef.h:
2009-09-23 Geoffrey Garen <ggaren@apple.com>
A piece of my last patch that I forgot.
* wtf/HashCountedSet.h:
(WTF::::clear): Added HashCountedSet::clear.
2009-09-24 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Avoid __clear_cache built-in function if DISABLE_BUILTIN_CLEAR_CACHE define is set
https://bugs.webkit.org/show_bug.cgi?id=28886
There are some GCC packages (for example GCC-2006q3 from CodeSourcery)
which contain __clear_cache built-in function only for C while the C++
version of __clear_cache is missing on ARM architectures.
Fixed a small bug in the inline assembly of cacheFlush function on
ARM_TRADITIONAL.
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
2009-09-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added the ability to swap vectors with inline capacities, so you can
store a vector with inline capacity in a hash table.
* wtf/Vector.h:
(WTF::swap):
(WTF::VectorBuffer::swap):
2009-09-23 David Kilzer <ddkilzer@apple.com>
Move definition of USE(PLUGIN_HOST_PROCESS) from WebKitPrefix.h to Platform.h
Reviewed by Mark Rowe.
* wtf/Platform.h: Define WTF_USE_PLUGIN_HOST_PROCESS to 1 when
building on 64-bit SnowLeopard. Define to 0 elsewhere.
2009-09-22 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Code sampling builds are broken.
https://bugs.webkit.org/show_bug.cgi?id=29662
Fix build.
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* bytecode/SamplingTool.cpp:
(JSC::ScriptSampleRecord::sample):
(JSC::SamplingTool::doRun):
(JSC::SamplingTool::notifyOfScope):
(JSC::compareScriptSampleRecords):
(JSC::SamplingTool::dump):
* bytecode/SamplingTool.h:
(JSC::ScriptSampleRecord::ScriptSampleRecord):
(JSC::ScriptSampleRecord::~ScriptSampleRecord):
(JSC::SamplingTool::SamplingTool):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
* debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* parser/Nodes.cpp:
(JSC::ScopeNode::ScopeNode):
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
2009-09-22 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
* wtf/Forward.h: Added PassOwnPtr.
2009-09-22 Yaar Schnitman <yaar@chromium.org>
Reviewed by David Levin.
Ported chromium.org's javascriptcore.gyp for the webkit chromium port.
https://bugs.webkit.org/show_bug.cgi?id=29617
* JavaScriptCore.gyp/JavaScriptCore.gyp: Added.
2009-09-22 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Fix compilation with WINSCW: no varargs macros
Disable variadic arguments for WINSCW just like we do
for MSVC7.
* wtf/Assertions.h:
2009-09-22 Kent Hansen <khansen@trolltech.com>
Reviewed by Simon Hausmann.
Disable variadic macros on MSVC7.
This was originally added in r26589 but not extended
when LOG_DISABLED/ASSERT_DISABLED was introduced.
* wtf/Assertions.h:
2009-09-22 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed build fix for Windows CE < 5
Define WINCEBASIC to disable the IsDebuggerPresent() code in
wtf/Assertions.cpp.
* JavaScriptCore.pri:
2009-09-22 Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed by Simon Hausmann.
Fix major memory leak in JavaScriptCore RegisterFile on Windows CE
https://bugs.webkit.org/show_bug.cgi?id=29367
On Widows CE we must decommit all committed pages before we release
them. See VirtualFree documentation.
Desktop Windows behaves much smoother in this situation.
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::~RegisterFile):
2009-09-21 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Simon Fraser & Sam Weinig.
Add ENABLE(ORIENTATION_EVENTS)
https://bugs.webkit.org/show_bug.cgi?id=29508
* wtf/Platform.h: Also sort PLATFORM(IPHONE) #defines.
2009-09-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Eric Seidel.
[Fix] SourceCode's uninitialized member
Potential source of crashes and bugs was fixed. Default constructor
didn't initialized m_provider member.
https://bugs.webkit.org/show_bug.cgi?id=29364
* parser/SourceCode.h:
(JSC::SourceCode::SourceCode):
2009-09-21 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
REGRESSION (r48582): Crash in StructureStubInfo::initPutByIdTransition when reloading trac.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=29599
It is unsafe to attempt to cache new property transitions on
dictionaries of any type.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
2009-09-21 Oliver Hunt <oliver@apple.com>
RS=Maciej Stachowiak.
Re-land SNES fix with corrected assertion.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/BatchedTransitionOptimizer.h:
(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
* runtime/JSObject.cpp:
(JSC::JSObject::removeDirect):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::getEnumerablePropertyNames):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::toCacheableDictionaryTransition):
(JSC::Structure::toUncacheableDictionaryTransition):
(JSC::Structure::fromDictionaryTransition):
(JSC::Structure::removePropertyWithoutTransition):
* runtime/Structure.h:
(JSC::Structure::isDictionary):
(JSC::Structure::isUncacheableDictionary):
(JSC::Structure::):
* runtime/StructureChain.cpp:
(JSC::StructureChain::isCacheable):
2009-09-21 Adam Roben <aroben@apple.com>
Revert r48573, as it caused many assertion failures
* interpreter/Interpreter.cpp:
* jit/JITStubs.cpp:
* runtime/BatchedTransitionOptimizer.h:
* runtime/JSObject.cpp:
* runtime/Structure.cpp:
* runtime/Structure.h:
* runtime/StructureChain.cpp:
2009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed make dist build fix. Missing files.
* GNUmakefile.am:
2009-09-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam 'Cabin Boy' Weinig.
Fix stack alignment with ARM THUMB2 JIT.
https://bugs.webkit.org/show_bug.cgi?id=29526
Stack is currently being decremented by 0x3c, bump this to 0x40 to make this a
multiple of 16 bytes.
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
2009-09-20 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
SNES is too slow
https://bugs.webkit.org/show_bug.cgi?id=29534
The problem was that the emulator used multiple classes with
more properties than our dictionary cutoff allowed, this resulted
in more or less all critical logic inside the emulator requiring
uncached property access.
Rather than simply bumping the dictionary cutoff, this patch
recognises that there are two ways to create a "dictionary"
structure. Either by adding a large number of properties, or
by removing a property. In the case of adding properties we
know all the existing properties will maintain their existing
offsets, so we could cache access to those properties, if we
know they won't be removed.
To make this possible, this patch adds the logic required to
distinguish a dictionary created by addition from one created
by removal. With this logic in place we can now cache access
to objects with large numbers of properties.
SNES performance improved by more than 6x.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/BatchedTransitionOptimizer.h:
(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
* runtime/JSObject.cpp:
(JSC::JSObject::removeDirect):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::getEnumerablePropertyNames):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::toCacheableDictionaryTransition):
(JSC::Structure::toUncacheableDictionaryTransition):
(JSC::Structure::fromDictionaryTransition):
(JSC::Structure::removePropertyWithoutTransition):
* runtime/Structure.h:
(JSC::Structure::isDictionary):
(JSC::Structure::isUncacheableDictionary):
(JSC::Structure::):
* runtime/StructureChain.cpp:
(JSC::StructureChain::isCacheable):
2009-09-19 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Implement ES5 Object.create function
https://bugs.webkit.org/show_bug.cgi?id=29524
Implement Object.create. Very simple patch, effectively Object.defineProperties
only creating the target object itself.
* runtime/CommonIdentifiers.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::objectConstructorCreate):
2009-09-19 Dan Bernstein <mitz@apple.com>
Fix clean debug builds.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-19 Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed by George Staikos.
QtWebKit Windows CE compile fix
https://bugs.webkit.org/show_bug.cgi?id=29379
There is no _aligned_alloc or _aligned_free on Windows CE.
We just use the Windows code that was there before and use VirtualAlloc.
But that also means that the BLOCK_SIZE must be 64K as this function
allocates on 64K boundaries.
* runtime/Collector.cpp:
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
* runtime/Collector.h:
2009-09-19 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Implement ES5 Object.defineProperties function
https://bugs.webkit.org/show_bug.cgi?id=29522
Implement Object.defineProperties. Fairly simple patch, simply makes use of
existing functionality used for defineProperty.
* runtime/CommonIdentifiers.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::defineProperties):
(JSC::objectConstructorDefineProperties):
2009-09-19 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Windows build fix part2
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-19 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Buildfix).
Windows build fix part 1.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-18 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Implement ES5 Object.defineProperty function
https://bugs.webkit.org/show_bug.cgi?id=29503
Implement Object.defineProperty. This requires adding the API to
ObjectConstructor, along with a helper function that implements the
ES5 internal [[ToPropertyDescriptor]] function. It then adds
JSObject::defineOwnProperty that implements the appropriate ES5 semantics.
Currently defineOwnProperty uses a delete followed by a put to redefine
attributes of a property, clearly this is less efficient than it could be
but we can improve this if it needs to be possible in future.
* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineGetter):
(JSC::DebuggerActivation::defineSetter):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
Update defineGetter/Setter calls
* runtime/CommonIdentifiers.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlot):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineGetter):
(JSC::JSGlobalObject::defineSetter):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::writable):
(JSC::PropertyDescriptor::enumerable):
(JSC::PropertyDescriptor::configurable):
(JSC::PropertyDescriptor::isDataDescriptor):
(JSC::PropertyDescriptor::isGenericDescriptor):
(JSC::PropertyDescriptor::isAccessorDescriptor):
(JSC::PropertyDescriptor::getter):
(JSC::PropertyDescriptor::setter):
(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
(JSC::PropertyDescriptor::setWritable):
(JSC::PropertyDescriptor::setEnumerable):
(JSC::PropertyDescriptor::setConfigurable):
(JSC::PropertyDescriptor::setSetter):
(JSC::PropertyDescriptor::setGetter):
(JSC::PropertyDescriptor::equalTo):
(JSC::PropertyDescriptor::attributesEqual):
(JSC::PropertyDescriptor::attributesWithOverride):
* runtime/PropertyDescriptor.h:
(JSC::PropertyDescriptor::PropertyDescriptor):
(JSC::PropertyDescriptor::value):
(JSC::PropertyDescriptor::setValue):
(JSC::PropertyDescriptor::isEmpty):
(JSC::PropertyDescriptor::writablePresent):
(JSC::PropertyDescriptor::enumerablePresent):
(JSC::PropertyDescriptor::configurablePresent):
(JSC::PropertyDescriptor::setterPresent):
(JSC::PropertyDescriptor::getterPresent):
(JSC::PropertyDescriptor::operator==):
(JSC::PropertyDescriptor::):
2009-09-18 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Build fix to enable ARM_THUMB2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
* jit/JITStubs.cpp:
* wtf/Platform.h:
2009-09-18 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
https://bugs.webkit.org/show_bug.cgi?id=29122
Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
when Thumb-2 instruction set is the required target. The
PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
case where the code is common the PLATFORM(ARM) have to be used.
* assembler/ARMAssembler.cpp:
* assembler/ARMAssembler.h:
* assembler/ARMv7Assembler.h:
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.cpp:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
* jit/ExecutableAllocator.h:
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::preserveReturnAddressAfterCall):
(JSC::JIT::restoreReturnAddressBeforeReturn):
(JSC::JIT::restoreArgumentReference):
(JSC::JIT::restoreArgumentReferenceForTrampoline):
* jit/JITOpcodes.cpp:
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
* wtf/Platform.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter):
2009-09-18 Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed by Simon Hausmann.
Fix the Qt/Windows CE build.
* JavaScriptCore.pri: Build the ce_time.cpp functions from
within Qt externally.
* wtf/DateMath.cpp: Removed unnecessary Qt #ifdef, for the
Qt build these functions are no external, too.
2009-09-17 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
Symbian/WINSCW build fox.
Repeat Q_OS_WIN wchar_t hack for WINSCW, similar to
revision 24774.
WINSCW defines wchar_t, thus UChar has to be wchar_t
* wtf/unicode/qt4/UnicodeQt4.h:
2009-09-17 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
Symbian/WINSCW build fix.
https://bugs.webkit.org/show_bug.cgi?id=29186
WINSCW Template specialisation name in declaration must the be the same as in implementation.
* runtime/LiteralParser.h:
2009-09-15 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27060
Symbian compiler for emulator target (WINSCW) fails with
"illegal operand" for m_attributesInPrevious in structure.ccp
(when calling make_pair functions).
This error is apparently due to the compiler not properly
resolving the unsigned type of the declared bitfield.
Initial patch explicitly casted m_attributesInPrevious
to unsigned, but since bitfield optimization is not critical for
the emulator target, this conditional change in header file
appears to be least intrusive.
* runtime/Structure.h:
2009-09-16 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Darin Adler.
Fix GCC warnings on ARM_THUMB2 platform
* assembler/ARMv7Assembler.h:
(JSC::ARMThumbImmediate::countLeadingZerosPartial):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
2009-09-16 Greg Bolsinga <bolsinga@apple.com>
Add ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=29260
Reviewed by David Kilzer.
* wtf/Platform.h:
2009-09-16 Greg Bolsinga <bolsinga@apple.com>
Add ENABLE(CONTEXT_MENUS)
https://bugs.webkit.org/show_bug.cgi?id=29225
Reviewed by David Kilzer.
* wtf/Platform.h:
2009-09-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Eric Seidel.
The webkit stdint and stdbool headers exists because
the compiler MSVC doesn't include them. The check
should not check for PLATFORM(WIN_OS) but for MSVC.
* os-win32/stdbool.h:
* os-win32/stdint.h:
2009-09-16 Greg Bolsinga <bolsinga@apple.com>
Add ENABLE(DRAG_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=29233
Reviewed by David Kilzer.
* wtf/Platform.h:
2009-09-16 Kevin Ollivier <kevino@theolliviers.com>
waf build fix after flag was moved to correct place.
* wscript:
2009-09-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Build fix for 64-bit Qt on Mac OS X
* wtf/Platform.h: Use JSVALUE64 on DARWIN, not only on MAC
2009-09-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Fix wtf/ThreadSpecific.h under Qt to free thread local objects.
https://bugs.webkit.org/show_bug.cgi?id=29295
This is an important fix when JavaScript workers are in use, since
unfreed ThreadGlobalDatas leak a big amount of memory (50-100k each).
QThreadStorage calls the destructor of a given object, which is the
ThreadSpecific::Data. Unlike pthread, Qt is object oriented, and does
not support the calling of a static utility function when the thread
is about to close. In this patch we call the ThreadSpecific::destroy()
utility function from the destructor of ThreadSpecific::Data. Moreover,
since Qt resets all thread local values to 0 before the calling of the
appropriate destructors, we set back the pointer to its original value.
This is necessary because the get() method of the ThreadSpecific
object may be called during the exuction of the destructor.
* wtf/ThreadSpecific.h:
(WTF::ThreadSpecific::Data::~Data):
(WTF::::~ThreadSpecific):
(WTF::::set):
(WTF::::destroy):
2009-09-10 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Allow anonymous storage inside JSObject
https://bugs.webkit.org/show_bug.cgi?id=29168
Add the concept of anonymous slots to Structures so that it is
possible to store references to values that need marking in the
standard JSObject storage buffer. This allows us to reduce the
malloc overhead of some objects (by allowing them to store JS
values in the inline storage of the object) and reduce the
dependence of custom mark functions (if all an objects children
are in the standard object property storage there's no need to
mark them manually).
* JavaScriptCore.exp:
* runtime/JSObject.h:
(JSC::JSObject::putAnonymousValue):
(JSC::JSObject::getAnonymousValue):
(JSC::JSObject::addAnonymousSlots):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
(JSC::JSWrapperObject::JSWrapperObject):
(JSC::JSWrapperObject::setInternalValue):
* runtime/PropertyMapHashTable.h:
* runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addAnonymousSlotsTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::put):
(JSC::Structure::rehashPropertyMapHashTable):
* runtime/Structure.h:
(JSC::Structure::propertyStorageSize):
(JSC::StructureTransitionTable::reifySingleTransition):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::TransitionTable::addSlotTransition):
(JSC::StructureTransitionTable::TransitionTable::removeSlotTransition):
(JSC::StructureTransitionTable::TransitionTable::getSlotTransition):
(JSC::StructureTransitionTable::getAnonymousSlotTransition):
(JSC::StructureTransitionTable::addAnonymousSlotTransition):
(JSC::StructureTransitionTable::removeAnonymousSlotTransition):
2009-09-15 Alex Milowski <alex@milowski.com>
Reviewed by Tor Arne Vestbø.
Added the ENABLE_MATHML define to the features
* Configurations/FeatureDefines.xcconfig:
2009-09-15 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Build fix for windows.
After http://trac.webkit.org/changeset/47795 the MinGW build broke,
because MinGW has __mingw_aligned_malloc instead of _aligned_malloc.
* runtime/Collector.cpp:
(JSC::Heap::allocateBlock): MinGW case added.
(JSC::Heap::freeBlock): MinGW case added.
2009-09-15 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Build fix for Windows/MinGW
https://bugs.webkit.org/show_bug.cgi?id=29268
* wtf/Platform.h: JSVALUE32_64 temporarily disabled on PLATFORM(WIN_OS) with COMPILER(MINGW)
2009-09-14 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Detect VFP at runtime in generic ARM port on Linux platform.
https://bugs.webkit.org/show_bug.cgi?id=29076
* JavaScriptCore.pri:
* assembler/MacroAssemblerARM.cpp: Added.
(JSC::isVFPPresent):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPoint):
2009-09-14 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
[Qt] Build fix for windows build.
* JavaScriptCore.pri: Correct a logic error.
* pcre/dftables: Add missing paranthesis for tmpdir function.
2009-09-12 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Build fix for windows exports (again).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-12 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Build fix for windows exports.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-12 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Correct fix for non-allinonefile builds
* runtime/ObjectConstructor.cpp:
2009-09-12 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Fix non-allinonefile builds
* runtime/ObjectConstructor.cpp:
2009-09-12 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
[ES5] Implement Object.keys
https://bugs.webkit.org/show_bug.cgi?id=29170
This patch basically requires two separate steps, the first is to split getPropertyNames
into two functions -- getOwnPropertyNames and getPropertyNames, basically making them behave
in the same way as getOwnPropertySlot and getPropertySlot. In essence getOwnPropertyNames
produces the list of properties on an object excluding its prototype chain and getPropertyNames
just iterates the the object and its prototype chain calling getOwnPropertyNames at each level.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyNames):
* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyNames):
* debugger/DebuggerActivation.h:
* runtime/CommonIdentifiers.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertyNames):
* runtime/JSByteArray.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertyNames):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyNames):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::getOwnPropertyNames):
* runtime/JSVariableObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::objectConstructorKeys):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertyNames):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
* runtime/StringObject.h:
* runtime/Structure.cpp:
(JSC::Structure::getOwnEnumerablePropertyNames):
(JSC::Structure::getEnumerablePropertyNames):
* runtime/Structure.h:
2009-09-11 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
getPropertyNames caching is invalid when the prototype chain contains objects with custom getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=29214
Add a flag to TypeInfo to indicate whether a type overrides getPropertyNames.
This flag is used to make sure that caching of the property name data is safe.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::hasDefaultGetPropertyNames):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/StructureChain.cpp:
(JSC::StructureChain::isCacheable):
2009-09-11 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=29207
Add checks for using WebCore JS context on secondary threads
* runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
Added a new mainThreadOnly flag that WebCore would set.
* runtime/Collector.cpp: (JSC::Heap::registerThread): JSC API methods always call this,
so this is a good place to check that the API isn't used form a wrong thread.
2009-09-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
Compiling JavaScriptCore on sparc 64 with gcc fails.
ThreadSafeShared uses the atomic __gnu_cxx::__exchange_and_add with an int,
however on sparc 64 the _Atomic_word argument is typedefed to long (8 bytes).
The patch disables WTF_USE_LOCKFREE_THREADSAFESHARED in ThreadSafeShared to use
a mutex instead when compiling for sparc 64 with gcc.
https://bugs.webkit.org/show_bug.cgi?id=29175
* wtf/Platform.h:
__sparc64__ is not defined on all OS.
Uses instead: __sparc__ && __arch64__ || __sparcv9
* wtf/Threading.h:
2009-09-11 Prasanth Ullattil <prasanth.ullattil@nokia.com>
Reviewed by Simon Hausmann.
Fix compile error on Windows7(64Bit) with latest SDK.
Added the missing include file.
* runtime/UString.cpp:
2009-09-11 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon Hausmann.
Qt/Windows CE compile fix, include the executable allocator and
markstack implementation in the windows build.
* JavaScriptCore.pri:
2009-09-08 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Remove unneeded define for ActiveX.
https://bugs.webkit.org/show_bug.cgi?id=29054
* wtf/Platform.h:
2009-09-10 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Sam Weinig.
Update JavaScriptCore and WebKit's FeatureDefines.xcconfig so that they are in sync with WebCore as they need to be.
* Configurations/FeatureDefines.xcconfig:
2009-09-10 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Export WTF::tryFastMalloc used in WebSocketChannel.
https://bugs.webkit.org/show_bug.cgi?id=28038
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-10 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Make StructureTransitionTable use an enum for the PtrAndFlags member
used for the single transition slot optimisation.
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::StructureTransitionTable):
(JSC::StructureTransitionTable::usingSingleTransitionSlot):
(JSC::StructureTransitionTable::):
2009-09-10 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
Refactor StructureTransitionTable and Structure to unify handling of the single slot optimization
https://bugs.webkit.org/show_bug.cgi?id=29141
Make StructureTransitionTable encapsulate the single transition slot optimization.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::hasTransition):
* runtime/Structure.h:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::hasTransition):
(JSC::StructureTransitionTable::reifySingleTransition):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::StructureTransitionTable):
(JSC::StructureTransitionTable::~StructureTransitionTable):
(JSC::StructureTransitionTable::remove):
(JSC::StructureTransitionTable::add):
(JSC::StructureTransitionTable::table):
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::usingSingleTransitionSlot):
(JSC::StructureTransitionTable::setSingleTransition):
(JSC::StructureTransitionTable::setTransitionTable):
(JSC::StructureTransitionTable::):
* wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
2009-09-10 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Implement fastDeleteSkippingDestructor for FastAllocBase and fastDeleteAllValues for HashSet
https://bugs.webkit.org/show_bug.cgi?id=25930
FastAllocBase has been extended with fastDeleteSkippingDestructor function which
releases memory without destructor call. fastDeleteAllValues has been implemented
similar as deleteAllValues but it uses fastDelete function to release memory.
* wtf/FastAllocBase.h:
(WTF::fastDeleteSkippingDestructor):
* wtf/HashSet.h:
(WTF::fastDeleteAllValues):
2009-09-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
ARM compiler does not understand GCC visibility attribute
https://bugs.webkit.org/show_bug.cgi?id=29079
* API/JSBase.h: Make the test more specific to hit only
the GCC compiler
2009-09-10 Adam Barth <abarth@webkit.org>
Unreviewed revert of the previous change. It broke the tests.
* wtf/dtoa.cpp:
(WTF::dtoa):
2009-09-10 Ben Laurie <benl@google.com>
Reviewed by Adam Barth.
<https://bugs.webkit.org/show_bug.cgi?id=26836>
If dtoa was given a small buffer and the number was either infinite or
NaN, then the buffer would be overflowed.
* wtf/dtoa.cpp:
2009-09-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Change reinterpret_cast to static_cast in r48212.
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
2009-09-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Remove WTF_PLATFORM_FORCE_PACK as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=29066
* wtf/Platform.h:
2009-09-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Ariya Hidayat.
Implement flushing the instruction cache for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29075
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush): Call IMB_Range to flush
the instruction cache on Symbian
2009-09-09 Kent Hansen <khansen@trolltech.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=29024
Make JavaScriptCore compile on platforms with case-insensitive file systems and typeinfo.h in STL
These platforms include Microsoft Visual Studio 2003, and Symbian with Metrowerks compiler.
* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSTypeInfo.h: Copied from JavaScriptCore/runtime/TypeInfo.h.
* runtime/Structure.h:
* runtime/TypeInfo.h: Removed.
2009-09-08 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
JSON.stringify(Date) loses the milliseconds information
https://bugs.webkit.org/show_bug.cgi?id=29063
Make sure we include milliseconds in the output of toISOString.
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):
2009-09-08 Kevin Ollivier <kevino@theolliviers.com>
wx build fix, generate derived sources earlier in order to make sure
they're found by the build system when generating the list of sources to build.
* wscript:
2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
https://bugs.webkit.org/show_bug.cgi?id=29011
* wtf/Threading.h: Use LOCKFREE_THREADSAFESHARED guard for
atomicIncrement and atomicDecrement
2009-09-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control in Yarr's RegexInterpreter
https://bugs.webkit.org/show_bug.cgi?id=29025
Inherits RegexInterpreter classes from FastAllocBase (bug #20422), which has
been instantiated by 'new':
class ByteDisjunction
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1462
struct BytecodePattern
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1279
* yarr/RegexInterpreter.h:
2009-09-07 Drew Wilson <atwilson@google.com>
Reverting r48121 to fix Windows build errors.
* JavaScriptCore.exp:
2009-09-07 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959
* Configurations/FeatureDefines.xcconfig:
2009-09-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Export WTF::tryFastMalloc used in WebSocketChannel.
https://bugs.webkit.org/show_bug.cgi?id=28038
* JavaScriptCore.exp:
2009-09-04 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Fix windows export files
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-09-04 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[[ToString]] conversion should use the actual toString function for String objects.
Remove incorrect specialisations of toString conversions on StringObject.
* JavaScriptCore.exp:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
2009-09-04 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Add new export.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Add new export.
2009-09-04 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove unneeded export.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Remove unneeded export.
2009-09-04 Darin Adler <darin@apple.com>
Reviewed by Geoff Garen.
DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909
Part two.
Make some improvements to garbage collection code:
1) Create a runtime assertion that catches any classes that
override markChildren but have the HasDefaultMark bit set.
2) Remove checks of the mark bit outside the MarkStack::append
function; they are redundant.
3) Improve the efficiency of the asObject and asArray functions
when called on JSCell* to avoid a round trip to JSValue.
4) Make more callers use the checked asCell and asObject
casting functions rather than unchecked casts.
5) Removed the JSCell::marked function and other GC-related
functions because these operations are no longer things that
code other than the core GC code needs to do directly. Fixed
callers that were calling them.
* runtime/Collector.cpp:
(JSC::Heap::markConservatively): Removed unneeded call to MarkStack::drain.
(JSC::Heap::markProtectedObjects): Removed unneeded check of the mark
bit and call to MarkStack::drain.
(JSC::Heap::collect): Removed unneeded checks of the mark bit and also
changed call to SmallStrings::mark to call markChildren instead to match
the rest of the objects.
(JSC::typeName): Removed unneeded cast to JSObject*.
* runtime/JSArray.h:
(JSC::asArray): Added an overload for JSCell* and changed the JSValue
version to call it. Removed some unneeded casts.
(JSC::JSArray::markChildrenDirect): Marked this function inline. It's in
a header, and if not marked inline this could lead to linking problems.
(JSC::MarkStack::markChildren): Added. This helper function is used by
the drain function to avoid repating code. Also added the code here to
check fro default mark violations in debug code. If a markChildren
function adds something to the mark stack, but the type info claimed
hasDefaultMark was true, then we will get an assertion now. Also fixed
the assertion about the mark bit to use the Heap function directly
because we don't have a JSCell::marked function any more.
(JSC::MarkStack::drain): Changed a local variable from "v" to "value",
and from "currentCell" to "cell". Changed to call markChildren in two
places instead of repeating a chain of if statements twice. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions.
* runtime/JSCell.h: Removed JSCell's markCellDirect and marked member
functions. Added a comment explaining that asCell should be deprecated
in favor of the JSValue asCell member function.
(JSC::MarkStack::append): Added the assertion that catches callers
that have set the HasDefaultMark bit incorrectly. Changed
code that reads and writes the mark bit to use Heap::isCellMarked and
Heap::markCell so we can eliminate the JSCell::marked and
JSCell::markCellDirect functions. Moved the overload of
MarkStack::append for JSValue here so it can call through to the cell
version. The old version had a copy of all the code instead, but that
repeated the conversion from JSValue to JSCell* and the check for
whether a value is a cell multiple times.
(JSC::Structure::markAggregate): Moved this function here to avoid
dependencies for Structure.h, since this calls MarkStack::append.
* runtime/JSObject.cpp:
(JSC::JSObject::markChildren): Added code to clear
m_isCheckingForDefaultMarkViolation so the marking done by JSObject
doesn't trigger the assertion.
* runtime/JSValue.h: Moved some stray includes that were outside the
header guard inside it. Not sure how that happened! Removed the
GC-related member functions markChildren, hasChildren, marked, and
markDirect.
* runtime/JSWrapperObject.h: Made markChildren private.
(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.
* runtime/MarkStack.h: Added m_isCheckingForDefaultMarkViolation and
initialized it to false. Moved the append function body from here to
JSCell.h. Added a declaration of a private markChildren function used
inside the drain function.
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::markChildren): Changed the name and style of this
function to match other functions. This allows us to share the normal
mark stack code path.
* runtime/SmallStrings.h: Changed the name and interface of mark to
the more-normal markChildren style.
* runtime/Structure.h: Moved the body of markAggregate into the
JSCell.h to avoid a circular dependency with JSCell.h.
2009-09-04 Darin Adler <darin@apple.com>
Reviewed by Geoff Garen.
DateInstance object collected on ARM JIT (JSValue: WTF_USE_JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=28909
Part one.
Make some improvements to garbage collection code:
1) Fix the two classes that had the default mark bit set but
should not.
2) Remove checks of the mark bit outside the MarkStack::append
function; they are redundant.
3) Make more callers use the checked asCell and asObject
casting functions rather than unchecked casts.
4) Removed some GC-related functions because these operations are
no longer things that code other than the core GC code needs
to do directly. Fixed callers that were calling them.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::markAggregate): Removed unneeded check of the mark
bit before calling MarkStack::append.
* interpreter/Register.h: Removed unneeded marked and markChildren
functions.
* jit/JITStubs.cpp:
(op_eq): Removed unneeded assertions, instead using checked casting
functions such as asObject.
* runtime/ArgList.h: Added now-needed forward declaration of MarkStack.
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::markChildren): Remmoved unneeded check of the mark bit.
* runtime/GlobalEvalFunction.h:
(JSC::GlobalEvalFunction::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set.
* runtime/JSCell.cpp:
(JSC::JSCell::getObject): Use asObject to avoid a direct static_cast.
* runtime/JSObject.h:
(JSC::asObject): Added an overload for JSCell* and changed the JSValue
version to call it.
(JSC::JSValue::get): Use asObject to avoid a direct static_cast.
* runtime/JSWrapperObject.h: Made markChildren private.
(JSC::JSWrapperObject::createStructure): Added. Fixes a bug where the
HasDefaultMark bit was set. Later we may want to optimize this for
wrapper types that never have cells in their internal values, but there
is no measured performance regression in SunSpider or V8 doing this
all the time.
* runtime/MarkStack.cpp: Tweaked formatting.
2009-09-04 Kevin Ollivier <kevino@theolliviers.com>
wx build fix. Switch USE_ defines over to the compiler so that they can be
checked by files not including config.h (like WebCorePrefix.h).
* wtf/Platform.h:
2009-09-03 Yong Li <yong.li@torchmobile.com>
Reviewed by David Levin.
Remove unnecessary dependency on unistd.h
https://bugs.webkit.org/show_bug.cgi?id=28962
* runtime/Completion.cpp:
2009-09-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Add strnstr for Linux and Windows in StringExtras.h
https://bugs.webkit.org/show_bug.cgi?id=28901
* wtf/StringExtras.h:
(strnstr):
2009-09-03 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's HashEntry class
https://bugs.webkit.org/show_bug.cgi?id=27830
Inherits HashEntry class from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/runtime/Lookup.cpp:32.
* runtime/Lookup.h:
2009-09-02 Gavin Barraclough <barraclough@apple.com>
Should crash if JIT code buffer allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=28926
<rdar://problem/7031922>
* jit/ExecutableAllocatorPosix.cpp:
(JSC::ExecutablePool::systemAlloc):
* jit/ExecutableAllocatorWin.cpp:
(JSC::ExecutablePool::systemAlloc):
2009-09-02 Kevin Ollivier <kevino@theolliviers.com>
waf build fixes for Windows/MSVC.
* wscript:
2009-09-02 Kevin Ollivier <kevino@theolliviers.com>
Build fix for building on Windows.
* wtf/ThreadingPthreads.cpp:
2009-09-02 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Eric Seidel.
Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled
RegisterFile constructor currently throws #error when both
MMAP and VIRTUALALLOC conditions fail.
On any platform that does not provide these features
(for instance, Symbian),
the fallback should be regular malloc (or fastMalloc).
It is functionally equivalent in this case, even though it may
have certain drawbacks such as lack of dynamic pre-allocation.
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::~RegisterFile):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
2009-08-31 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>
Reviewed by Gavin Barraclough.
Fixed typo.
https://bugs.webkit.org/show_bug.cgi?id=28691
* parser/Parser.h:
(JSC::Parser::parse):
2009-08-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
JSON Stringifier does not follow ES5 spec for handling of Number, String and Boolean objects
https://bugs.webkit.org/show_bug.cgi?id=28797
Fixed unwrapBoxedPrimitive to do the right thing, which necessitated a couple of new exception
checks, and corrected the logic in gap to correctly convert Number and String objects.
* runtime/JSONObject.cpp:
(JSC::unwrapBoxedPrimitive):
(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):
2009-08-27 Oliver Hunt <oliver@apple.com>
Reviewed by Adam Roben.
JSON.stringify replacer array does not accept values that are not string primitives.
https://bugs.webkit.org/show_bug.cgi?id=28788
Update the JSON stringifier to initialise its replacer array according to the most
recent version of the spec.
* runtime/Identifier.h:
(JSC::Identifier::from):
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
2009-08-27 Alexey Proskuryakov <ap@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=28753
<rdar://problem/7173448> Excessive number of threads (and a crash)
* wtf/Threading.h: (WTF::atomicIncrement): Changed atomicIncrement to match decrement
and return the new value. Also added using directives for these functions, to match
te rest of WTF.
2009-08-27 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Link the testapi against CFLite when building the WinCairo port.
* JavaScriptCore.vcproj/testapi/testapi.vcproj: Add new Release_CFLite
target. Update all targets to inherit from either the
JavaScriptCF.vsprops (Apple target) or the JavaScriptCFLite.vsprops
file (WinCairo target).
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Remove
input file CoreFoundation.lib. This is provided by either the
JavaScriptCF.vsprops or JavaScriptCFLite.vsprops file.
2009-08-27 Steve Falkenburg <sfalken@apple.com>
Reviewed by Geoff Garen.
Fix Windows-specific crash due to missing memory clearing call.
* runtime/Collector.cpp:
(JSC::Heap::allocateBlock):
2009-08-27 Brent Fulgham <bfulgham@webkit.org>
Build fix: JavaScriptCore_debug.def missing some exports. Apple
Windows build does not use this file, so it was not noticed previously.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-27 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
https://bugs.webkit.org/show_bug.cgi?id=28317
Missed one, fix part II.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::move):
* assembler/X86Assembler.h:
(JSC::CAN_SIGN_EXTEND_8_32):
2009-08-27 Oliver Hunt <oliver@apple.com>
Reviewed by Adam Roben.
JSON.stringify replacer array does not accept values that are not string primitives.
https://bugs.webkit.org/show_bug.cgi?id=28788
Update the JSON stringifier to initialise its replacer array according to the most
recent version of the spec.
* runtime/Identifier.h:
(JSC::Identifier::from):
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
2009-08-27 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
JSON parser accepts trailing comma in array literals
https://bugs.webkit.org/show_bug.cgi?id=28779
Update parser to correctly fail if there's a trailing comma.
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::parse):
2009-08-26 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
'this' in JSON.parse reviver is the global object
https://bugs.webkit.org/show_bug.cgi?id=28752
This is a technically simple change, we merely update the code for calling
the reviver function to pass the correct this object. Doing so however
exposes the holder to arbitrary mutation by the reviver function so it is
necessary for us to now guard all property accesses against the possibility
of failure.
* runtime/JSArray.h:
JSON needs to delete a property from the array, so we friend its
Walker class so that we can make a non-virtual call to the arrays
delete and getOwnPropertySlot methods.
* runtime/JSONObject.cpp:
(JSC::Walker::callReviver):
We need to pass the correct this object
(JSC::Walker::walk):
Update calls to callReviver, and update property logic logic
to correctly handle the holder being mutated by the reviver
function.
2009-08-26 Alice Liu <alice.liu@apple.com>
Windows build fix: added some exported symbols
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-26 Geoffrey Garen <ggaren@apple.com>
Windows build fix: Removed some exported symbols that no longer exist.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Olliejver Hunt.
x86-64 GTK broken due to code offsets changing, pointers sometimes packed into immediates.
https://bugs.webkit.org/show_bug.cgi?id=28317
We rely on a slightly OS X specific behaviour, that x86-64 applications have a 4Gb zero page,
so pointers are never representable as a 32-bit integer, and always have to be represented by
a separate immediate load instruction, rather than within the immediate field of an arithmetic
or memory operation.
We explicitly check for a couple of cases where a value might be representable in 32-bit, but
these probably never kick in on Mac OS, and only kick in to hose GTK. Deleting these does not
show a performance degradation on SunSpider. Remove.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::storePtr):
(JSC::MacroAssemblerX86_64::branchPtr):
2009-08-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A bit of Collector refatoring.
SunSpider says no change. v8 says 1.003x faster (1.02x faster on splay).
* JavaScriptCore.exp:
* runtime/JSCell.cpp:
(JSC::JSCell::toPrimitive):
(JSC::JSCell::getPrimitiveNumber):
(JSC::JSCell::toBoolean):
(JSC::JSCell::toNumber):
(JSC::JSCell::toString):
(JSC::JSCell::toObject): Removed pure virtual functions from
JSCell, so the collector can construct one. This allowed
me to remove a bunch of ASSERT_NOT_REACHED throughout the
code, too.
* runtime/JSCell.h:
(JSC::JSCell::JSCell): ditto
(JSC::Heap::heap): Inlined this function because it's trivial.
* JavaScriptCore.exp:
* runtime/Collector.cpp:
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks): Renamed freeHeap to freeBlocks, since
it doesn't actually free the Heap object.
(JSC::Heap::heapAllocate):
(JSC::Heap::sweep):
* runtime/Collector.h: Refactored block allocation and destruction
into helper functions.
* runtime/GetterSetter.cpp:
* runtime/JSAPIValueWrapper.cpp:
* runtime/JSPropertyNameIterator.cpp: Removed dummy implementations
of pure virtual functions. (See above.)
=== End re-roll-in of r47738:47740 with Windows crash fixed ===
2009-08-26 Geoffrey Garen <ggaren@apple.com>
Build fix: start out with a 32-bit value to avoid a shortening warning.
* runtime/Collector.cpp:
(JSC::Heap::sweep):
2009-08-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Substantially reduced VM thrash in the GC heap.
1.08x faster on v8 (1.60x faster on v8-splay).
1.40x faster on bench-alloc-nonretained.
1.90x faster on bench-alloc-retained.
SunSpider says no change.
* runtime/Collector.cpp:
(JSC::Heap::heapAllocate): Fixed a long-standing bug: update a few local
variables unconditionally after calling collect(), since they may be used
even if we don't "goto scan". (In the bug I saw, usedBlocks got out of
sync with heap.usedBlocks).
(JSC::Heap::sweep): Keep enough free heap space to accomodate
the number of objects we'll allocate before the next GC, plus 25%, for
good measure.
* runtime/Collector.h: Bumped the block size to 256k. This seems to give
the best cache performance, and it prevents us from initiating lots of
VM traffic to recover very small chunks of memory.
=== Begin re-roll-in of r47738:47740 with Windows crash fixed ===
2009-08-25 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902
Added OwnPtr to VectorTraits so we can store OwnPtrs in Vectors.
* wtf/VectorTraits.h:
2009-08-26 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Remove duplicated files from file list.
* GNUmakefile.am:
2009-08-26 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
More export fixes.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-26 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fix).
Hopefully fix all the exports from JSC on windows
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-26 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Build fixes).
Forgot I added files to JavaScriptCore.
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCoreSources.bkl:
2009-08-25 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[ES5] Implement getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=28724
Implement the core runtime support for getOwnPropertyDescriptor.
This adds a virtual getOwnPropertyDescriptor method to every class
that implements getOwnPropertySlot that shadows the behaviour of
getOwnPropertySlot. The alternative would be to make getOwnPropertySlot
(or PropertySlots in general) provide property attribute information,
but quick testing showed this to be a regression.
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyDescriptor):
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/CommonIdentifiers.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertyDescriptor):
* runtime/DatePrototype.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyDescriptor):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertyDescriptor):
* runtime/JSByteArray.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyDescriptor):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
* runtime/JSObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getStringPropertyDescriptor):
(JSC::JSString::getOwnPropertyDescriptor):
* runtime/JSString.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::symbolTableGet):
* runtime/JSVariableObject.h:
* runtime/Lookup.h:
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueDescriptor):
Add property descriptor equivalents of the lookup
table access functions
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):
* runtime/MathObject.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::objectConstructorGetOwnPropertyDescriptor):
* runtime/PropertyDescriptor.cpp: Added.
(JSC::PropertyDescriptor::writable):
(JSC::PropertyDescriptor::enumerable):
(JSC::PropertyDescriptor::configurable):
(JSC::PropertyDescriptor::hasAccessors):
(JSC::PropertyDescriptor::setUndefined):
(JSC::PropertyDescriptor::getter):
(JSC::PropertyDescriptor::setter):
(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
* runtime/PropertyDescriptor.h: Added.
(JSC::PropertyDescriptor::PropertyDescriptor):
(JSC::PropertyDescriptor::attributes):
(JSC::PropertyDescriptor::isValid):
(JSC::PropertyDescriptor::value):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertyDescriptor):
* runtime/RegExpObject.h:
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyDescriptor):
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertyDescriptor):
* runtime/StringPrototype.h:
2009-08-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
How many copies of the parameters do you need?
https://bugs.webkit.org/show_bug.cgi?id=28701
The function parameters in JSC get copied a lot - and unnecessarily so.
Originally this happened due to duplicating FunctionBodyNodes on recompilation,
though the problem has been exacerbated by copying the parameters from the
original function body onto the executable, then back onto the real body that
will be generated (this happens on every function). And this is all made worse
since the data structures in question are a little ugly - C style arrays of C++
objects containing ref counts, so they need a full copy-construct (rather than
a simple memcpy).
This can all be greatly simplified by just punting the parameters off into
their own ref-counted object, and forgoing all the copying.
~no performance change, possible slight progression.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
* parser/Nodes.cpp:
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::finishParsing):
* parser/Nodes.h:
(JSC::FunctionBodyNode::parameters):
(JSC::FunctionBodyNode::parameterCount):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compile):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::paramString):
* runtime/Executable.h:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::parameterCount):
2009-08-25 Brent Fulgham <bfulgham@webkit.org>
Reviewed by NOBODY (Buildfix).
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_CFLite target
that inherits from the debug_wincairo property sheet and therefore
links to the proper debug library.
* JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_CFLite target
that inherits from the debug_wincairo property sheet and therefore
links to the proper debug library.
2009-08-25 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Export tryFastMalloc for Canvas3D work
https://bugs.webkit.org/show_bug.cgi?id=28018
* JavaScriptCore.exp:
2009-08-25 David Levin <levin@chromium.org>
Reviewed by Adam Roben.
PLATFORM(CFNETWORK) should be USE(CFNETWORK).
https://bugs.webkit.org/show_bug.cgi?id=28713
* wtf/Platform.h: Added a #define to catch this issue in the
future. The define would generate an error on gcc without the
space in the expansion, but Visual C++ needs the space to cause an error.
2009-08-24 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Steve Falkenburg.
Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modify
Cairo debug build to inherit from new debug_cairo property sheet.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops:
Modify to look for debug CFLite when in debug build.
2009-08-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Adler & Darin Hunt.
https://bugs.webkit.org/show_bug.cgi?id=28691
Do not retain ScopeNodes outside of parsing
There is now no need for these to exist outside of parsing - their use in the runtime is replaced by Executable types.
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* parser/Nodes.cpp:
(JSC::ScopeNodeData::ScopeNodeData):
(JSC::ProgramNode::create):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(JSC::ScopeNode::adoptData):
(JSC::FunctionBodyNode::parameterCount):
* parser/Parser.cpp:
* parser/Parser.h:
(JSC::Parser::arena):
(JSC::Parser::Parser):
(JSC::Parser::parse):
* runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
(JSC::arrayProtoFuncSort):
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compile):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::fromGlobalCode):
(JSC::FunctionExecutable::copyParameters):
(JSC::FunctionExecutable::paramString):
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::sourceID):
(JSC::ScriptExecutable::sourceURL):
(JSC::ScriptExecutable::lineNo):
(JSC::ScriptExecutable::lastLine):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::recordParse):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::make):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::jitCode):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::numericCompareFunction):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
2009-08-24 Darin Adler <darin@apple.com>
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put): Landed revised version I had tested but forgot
to land. Leave out the branch, since we don't need one.
2009-08-24 Darin Adler <darin@apple.com>
Reviewed by Geoff Garen.
Array index miss case creates a string every time
https://bugs.webkit.org/show_bug.cgi?id=28664
SunSpider test results I saw:
0.5% faster overall
1% faster on crypto-aes
20% faster on crypto-md5
13% faster on crypto-sha1
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype): Initialize m_hasNoPropertiesWithUInt32Names
to true.
(JSC::ObjectPrototype::put): Clearly m_hasNoPropertiesWithUInt32Names if the new
property has a name that is the string form of a UInt32.
(JSC::ObjectPrototype::getOwnPropertySlot): Don't call JSObject::getOwnPropertySlot
if m_hasNoPropertiesWithUInt32Names is true, and it is highly likely to be true.
* runtime/ObjectPrototype.h: Added declarations for the above.
2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Fix a typo in my distcheck build fix.
* GNUmakefile.am:
2009-08-23 Gustavo Noronha Silva <gns@gnome.org>
Unreviewed build fix for make distcheck.
* GNUmakefile.am: Added files required for the build.
2009-08-22 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC
https://bugs.webkit.org/show_bug.cgi?id=28655
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction): Initialize properly with a VPtrHackExecutable.
* wtf/Platform.h:
2009-08-22 Darin Adler <darin@apple.com>
Fix storage leak from syntax tree arena allocation patch.
* parser/Nodes.h: CommaNode needs to inherit from ParserArenaDeletable
because it has a vector.
2009-08-21 Darin Adler <darin@apple.com>
Fix Qt build.
* parser/Nodes.cpp:
(JSC::ScopeNodeData::ScopeNodeData): Made non-inline again.
This is used outside Nodes.cpp so can't be inline unless
it is in the header.
2009-08-21 Darin Adler <darin@apple.com>
Two loose ends from the last commit.
* JavaScriptCore.xcodeproj/project.pbxproj: Made ParserArena.h
and create_hash_table project-internal instead of "private".
* runtime/Executable.h: Removed accidentally-added constructor.
2009-08-21 Darin Adler <darin@apple.com>
Reviewed by Gavin Barraclough.
Syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674
Use an actual arena now. 0.6% speedup on SunSpider.
New and improved with 100% less leaking of the universe.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
Removed all exports involving the class FunctionBodyNode, which no
longer needs to be used outside JavaScriptCore.
* JavaScriptCore.xcodeproj/project.pbxproj: Made Nodes.h and
Executable.h project-internal instead of "private".
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack
contains const Identifier* now.
* parser/Grammar.y: Made identifiers from the lexer be const
Identifier* and updated since VarStack contains const Identifier* now.
* parser/Lexer.cpp:
(JSC::Lexer::setCode): Pass in ParserArena, used for identifiers.
(JSC::Lexer::makeIdentifier): Changed return type to const Identifier*
and changed to call ParserArena.
(JSC::Lexer::clear): Removed the code to manage m_identifiers and
added code to set m_arena to 0.
* parser/Lexer.h: Updated for changes above.
* parser/NodeConstructors.h:
(JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable
on the arena.
(JSC::ParserArenaDeletable::operator new): Changed to call the
allocateDeletable function on the arena instead of deleteWithArena.
(JSC::PropertyNode::PropertyNode): Added new constructor that makes
numeric identifiers. Some day we might want to optimize this for
integers so it doesn't create a string for each one.
(JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier
since it's now a const Identifier& so it can't be left uninitialized.
(JSC::BreakNode::BreakNode): Ditto.
(JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements*
to keep track of the statements rather than a separate statement vector.
(JSC::BlockNode::BlockNode): Ditto.
(JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.
* parser/Nodes.cpp: Moved the comment explaining emitBytecode in here.
It seemed strangely out of place in the header.
(JSC::ThrowableExpressionData::emitThrowError): Added an overload for
UString as well as Identifier.
(JSC::SourceElements::singleStatement): Added.
(JSC::SourceElements::lastStatement): Added.
(JSC::RegExpNode::emitBytecode): Changed the throwError code to use
the substitution mechanism instead of doing a string append.
(JSC::SourceElements::emitBytecode): Added. Replaces the old
statementListEmitCode function, since we now keep the SourceElements
objects around.
(JSC::BlockNode::lastStatement): Added.
(JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of
statementListEmitCode.
(JSC::CaseClauseNode::emitBytecode): Added.
(JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode
instead of statementListEmitCode.
(JSC::ScopeNodeData::ScopeNodeData): Changed to store the
SourceElements* instead of using releaseContentsIntoVector.
(JSC::ScopeNode::emitStatementsBytecode): Added.
(JSC::ScopeNode::singleStatement): Added.
(JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead
of statementListEmitCode.
(JSC::EvalNode::emitBytecode): Ditto.
(JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode
insetad of statementListEmitCode and check for the return node using
the new functions.
* parser/Nodes.h: Changed VarStack to store const Identifier* instead
of Identifier and rely on the arena to control lifetime. Added a new
ParserArenaFreeable class. Made ParserArenaDeletable inherit from
FastAllocBase instead of having its own operator new. Base the Node
class on ParserArenaFreeable. Changed the various Node classes
to use const Identifier& instead of Identifier to avoid the need to
call their destructors and allow them to function as "freeable" in the
arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions.
Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode,
CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable
as a base class since they do not descend from Node. Eliminated the
StatementVector type and instead have various classes use SourceElements*
instead of StatementVector. This prevents those classes from having to
use ParserArenaDeletable to make sure the vector destructor is called.
* parser/Parser.cpp:
(JSC::Parser::parse): Pass the arena to the lexer.
* parser/Parser.h: Added an include of ParserArena.h, which is no longer
included by Nodes.h.
(JSC::Parser::parseFunctionFromGlobalCode): Changed to use the
singleStatement function, since there is no longer any children function.
Removed some unneeded use of RefPtr.
* parser/ParserArena.cpp:
(JSC::ParserArena::ParserArena): Added. Initializes the new members,
m_freeableMemory, m_freeablePoolEnd, and m_identifiers.
(JSC::ParserArena::freeablePool): Added. Computes the pool pointer,
since we store only the current pointer and the end of pool pointer.
(JSC::ParserArena::deallocateObjects): Added. Contains the common
memory-deallocation logic used by both the destructor and the
reset function.
(JSC::ParserArena::~ParserArena): Changed to call deallocateObjects.
(JSC::ParserArena::reset): Ditto. Also added code to zero out the
new structures, and switched to use clear() instead of shrink(0) since
we don't really reuse arenas.
(JSC::ParserArena::makeNumericIdentifier): Added.
(JSC::ParserArena::allocateFreeablePool): Added. Used when the pool
is empty.
(JSC::ParserArena::isEmpty): Added. No longer inline, which is fine
since this is used only for assertions at the moment.
(JSC::ParserArena::derefWithArena): Make non-inline.
* parser/ParserArena.h: Added an actual arena of "freeable" objects,
ones that don't need destructors to be called. Also added a separate
IdentifierArena object, a segmented vector of identifiers that used
to be in the Lexer.
* runtime/Executable.h: Moved the definition of the
FunctionExecutable::make function here. It can't go in JSFunction.h
since that header has to be used outside JavaScriptCore and so can't
include this, which includes Nodes.h. The function could be moved
elswhere if we don't want to include JSFunction.h in this header, but
for now this seems to be the best place.
* runtime/JSFunction.h: Removed the include of Executable.h and
definition of the FunctionExecutable::make function.
* wtf/FastMalloc.cpp: Fixed an incorrect comment.
2009-08-21 Mark Rowe <mrowe@apple.com>
Fix the non-JIT build.
* runtime/Executable.cpp:
* runtime/Executable.h:
2009-08-21 Gavin Barraclough <barraclough@apple.com>
Speculative QuickTime build fix.
* runtime/JSArray.cpp:
2009-08-21 Gavin Barraclough <barraclough@apple.com>
Speculative QT build fix.
* runtime/StringPrototype.cpp:
2009-08-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Restructure Executable types so that host functions do not hold a FunctionExecutable.
https://bugs.webkit.org/show_bug.cgi?id=28621
All JSFunction objects have a pointer to an Executable*. This is currently always a
FunctionExecutable, however this has a couple of drawbacks. Host functions do not
store a range of information that the FunctionExecutable provides (source, name,
CodeBlock & information presently held on the FunctionBodyNode).
[ * nearly all... see below! ]
Instead, make JSFunctions hold a pointer to an ExecutableBase, move fields specific
to JS sourced executable types (source, node) into a new subclass (ScriptExecutable),
and create a new NativeExecutable type. We now provide a new method in JSFunction
to access & downcast to FunctionExecutable, but in doing so we can make an early
check (with an ASSERT) to ensure that the Executable read from a function will only
be treated as a FunctionExecutable (and thus the JS sepcific fields will only be
accessed) if the JSFunction is not a host function.
There is one JSFunction that currently does not have an Executable, which is the
object created to allow us to read out the vtable pointer. By making this change
we can also add a new Executable type fror this object (VPtrHackExecutable).
Since this means that really all JSFunctions have an Executable we no longer have
to null-check m_executable before us it - particularly in isHostFunction().
This patch removes CacheableEvalExecutable, since all subclasses of ExecutableBase
can now be ref-counted - since both JSFunction holds (and ref-counts) an ExecutableBase
that might be a FunctionExecutable or a NativeExecutable. This does now mean that all
ProgramExecutables and EvalExecutables (unnecessarily) provide an interface to be
ref-counted, however this seems less-bad than host functions unnecessarily providing
interface to access non-host specific information.
The class hierarcy has changed from this:
- ExecutableBase
- ProgramExecutable
- EvalExecutable
- CacheableEvalExecutable (also RefCounted by multiple-inheritance)
- FunctionExecutable (also RefCounted by multiple-inheritance, 'special' FunctionExecutable also used for host functions)
To this:
- RefCounted
- ExecutableBase
- NativeExecutable
- VPtrHackExecutable
- ScriptExecutable
- ProgramExecutable
- EvalExecutable
- FunctionExecutable
This patch speeds up sunspidey by a couple of ms (presumably due to the changes to isHostFunction()).
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::ownerExecutable):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* profiler/Profiler.cpp:
(JSC::createCallIdentifierFromFunctionImp):
* runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
(JSC::Arguments::Arguments):
* runtime/Executable.cpp:
(JSC::NativeExecutable::~NativeExecutable):
(JSC::VPtrHackExecutable::~VPtrHackExecutable):
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::~ExecutableBase):
(JSC::ExecutableBase::isHostFunction):
(JSC::NativeExecutable::NativeExecutable):
(JSC::VPtrHackExecutable::VPtrHackExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::source):
(JSC::ScriptExecutable::sourceID):
(JSC::ScriptExecutable::sourceURL):
(JSC::ScriptExecutable::lineNo):
(JSC::ScriptExecutable::lastLine):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):
* runtime/JSFunction.h:
(JSC::JSFunction::executable):
(JSC::JSFunction::jsExecutable):
(JSC::JSFunction::isHostFunction):
2009-08-20 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Browser hangs on opening Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=28438
Code generation needs to be able to walk the entire scopechain in some
cases, however the symbol table used by activations was a member of the
codeblock. Following recompilation this may no longer exist, leading
to a crash or hang on lookup.
We fix this by introducing a refcounted SymbolTable subclass, SharedSymbolTable,
for the CodeBlocks used by function code. This allows activations to
maintain ownership of a copy of the symbol table even after recompilation so
they can continue to work.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::symbolTable):
(JSC::CodeBlock::sharedSymbolTable):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::FunctionCodeBlock::~FunctionCodeBlock):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveArguments):
* runtime/Executable.cpp:
(JSC::EvalExecutable::generateBytecode):
(JSC::FunctionExecutable::generateBytecode):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
* runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
(JSC::JSActivation::JSActivationData::~JSActivationData):
* runtime/SymbolTable.h:
2009-08-20 Xan Lopez <xlopez@igalia.com>
Add new file to GTK+ build.
* GNUmakefile.am:
2009-08-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Added a number => string cache.
1.07x faster on v8 (1.7x faster on v8-splay).
1.004x faster on SunSpider.
* runtime/JSCell.h: Moved JSValue::toString to JSString.h.
* runtime/JSGlobalData.h: Holds the cache.
* runtime/JSNumberCell.cpp:
(JSC::JSNumberCell::toString):
(JSC::JSNumberCell::toThisString): Removed -0 special case.
UString handles this now, since too many clients were
special-casing it.
* runtime/JSString.h:
(JSC::JSValue::toString): Use the cache when converting
an int or double to string.
* runtime/Operations.h:
(JSC::concatenateStrings): Call toString to take advantage
of the cache.
* runtime/SmallStrings.h:
(JSC::NumericStrings::add):
(JSC::NumericStrings::lookup): The cache.
* runtime/UString.cpp:
(JSC::UString::from): Added -0 special case mentioned above.
Removed appendNumeric because it's mutually exclusive with the
cache.
2009-08-20 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION: fast/profiler/call.html is crashing occasionally
https://bugs.webkit.org/show_bug.cgi?id=28476
Using the codeblock for information about how many parameters and
locals a function has is unsafe in certain circumstances. The
basic scenario is all function code being cleared in response to
the debugger or profiler being enabled, and then an activation is
marked before its associated function is re-executed.
To deal with this scenario we store the variable count of a function
directly in the FunctionExecutable, and then use that information.
* runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::generateBytecode):
* runtime/Executable.h:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::variableCount):
* runtime/JSActivation.cpp:
(JSC::JSActivation::markChildren):
2009-08-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Numbering of arguments to emitGetJITStubArg/emitPutJITStubArg incorrect
<bug lost in the great bug disasteroony of 08/20/09!>
The argumentNumber argument to emitGetJITStubArg/emitPutJITStubArg should match
the argument number used within the stub functions in JITStubs.cpp, but it doesn't.
Firstly, all the numbers changed when we added a void* 'reserved' as the first slot
(rather than leaving argument 0 unused), and secondly in 32_64 builds the index to
peek/poke needs to be multiplies by 2 (since the argument to peek/poke is a number
of machine words, and on 32_64 build the argument slots to stub functions are two
words wide).
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::compileOpCallVarargsSetupArgs):
(JSC::JIT::compileOpCall):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutJITStubArg):
(JSC::JIT::emitPutJITStubArgConstant):
(JSC::JIT::emitGetJITStubArg):
(JSC::JIT::emitPutJITStubArgFromVirtualRegister):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
2009-08-20 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
REGRESSION: significant slowdown on Celtic Kane "AJAX declaration" subtest
https://bugs.webkit.org/show_bug.cgi?id=28332
Follow up style fixes that were missed in review.
* runtime/Structure.cpp:
(JSC::Structure::hasTransition):
* runtime/Structure.h:
(JSC::Structure::get):
(JSC::StructureTransitionTable::contains):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::add):
2009-08-20 Oliver Hunt <oliver@apple.com>
Add new exports to windows jsc build
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-20 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION: significant slowdown on Celtic Kane "AJAX declaration" subtest
https://bugs.webkit.org/show_bug.cgi?id=28332
The method check optimisation made transitions aware of the value being
assigned when a transition was assigning a function. This had the side
effect of making every assignment of a function expression result in a
new transition, and thus a new Structure. The net result of this is that
the common JS idiom of
function MyObject() {
this.myFunction = function(...){...};
}
new MyObject();
Will produce a unique structure on every iteration, meaning that all
caching is defeated and there is a significant amount of structure churn.
The fix is to return the transition to its original form where it is
keyed off a property name + attributes tuple, but have each transition
support an optional transition on a specific value.
* JavaScriptCore.exp:
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
* runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::hasTransition):
* runtime/Structure.h:
(JSC::Structure::transitionedFor):
(JSC::Structure::hasTransition):
(JSC::Structure::):
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTableHashTraits::emptyValue):
(JSC::StructureTransitionTable::hasTransition):
(JSC::StructureTransitionTable::remove):
(JSC::StructureTransitionTable::add):
2009-08-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Remove FunctionCodeBlock.
https://bugs.webkit.org/show_bug.cgi?id=28502
These only exist to allow JIT code to dereference properties off the
CodeBlock for any callee, regardless of whether it is a host function.
Instead just use the FunctionExecutable. Copy the m_parameters field
from the CodeBlock into the Executable, and use this to distinguish
between host functions, functions that have been bytecompiled, and
functions that have not.
m_parameters is moved to ExecutableBase rather than FunctionExecutable
so that (as a separate change) we can move make a separate class of
executable for host code, which is not devived from FunctionExecutable
(host code does not feature any of the properties that normal executable
do and will provide, such as source, attributes, and a parsed name).
1% win on v8 tests, 0.5% on sunspider.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::handlerForBytecodeOffset):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
(JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
(JSC::CodeBlock::functionRegisterForBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
* bytecode/CodeBlock.h:
(JSC::):
(JSC::CodeBlock::source):
(JSC::CodeBlock::sourceOffset):
(JSC::CodeBlock::evalCodeCache):
(JSC::CodeBlock::createRareDataIfNecessary):
remove NativeCodeBlocks and the NativeCode code type.
* jit/JIT.cpp:
(JSC::JIT::linkCall):
Revert to previous behaviour (as currently still commented!) that Hhost functions have a null codeblock.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpCallVarargsSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
Bring the 32_64 & non-32_64 JITs into line with each other, callee in regT0.
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
Rewrite call trampolines to not use the CodeBlock.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
Make call_JSFunction & call_arityCheck return the callee, don't expect to be passed the CodeBlock.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::generateBytecode):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::ExecutableBase::):
(JSC::ExecutableBase::ExecutableBase):
(JSC::FunctionExecutable::isHostFunction):
Add m_numParameters.
* runtime/JSFunction.cpp:
(JSC::JSFunction::~JSFunction):
Only call generatedBytecode() on JSFunctions non-host FunctionExecutables.
2009-08-20 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28054
Use a helper function to work around winscw compiler forward declaration bug
regarding templated classes.
Add parenthesis around (PassRefPtr::*UnspecifiedBoolType) to make winscw compiler
work with the default UnSpecifiedBoolType() operator, which removes the winscw
specific bool cast hack.
* wtf/PassRefPtr.h:
(WTF::derefIfNotNull):
(WTF::PassRefPtr::~PassRefPtr):
2009-08-19 Yong Li <yong.li@torchmobile.com>
Reviewed by Gavin Barraclough.
Change namespace ARM to ARMRegisters
X86 to X86Registers to avoid conflict with macros
https://bugs.webkit.org/show_bug.cgi?id=28428
* assembler/ARMAssembler.cpp:
* assembler/ARMAssembler.h:
* assembler/ARMv7Assembler.h:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerX86Common.h:
* assembler/MacroAssemblerX86_64.h:
* assembler/X86Assembler.h:
* jit/JIT.h:
* jit/JITArithmetic.cpp:
* jit/JITInlineMethods.h:
* jit/JITOpcodes.cpp:
* wrec/WRECGenerator.cpp:
* wrec/WRECGenerator.h:
* yarr/RegexJIT.cpp:
2009-08-19 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Devirtualise marking
https://bugs.webkit.org/show_bug.cgi?id=28294
We actually need to mark the value in a number object if we're using the
32bit number representation.
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
2009-08-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
We probably shouldn't be keeping the AST for eval nodes around forevar.
https://bugs.webkit.org/show_bug.cgi?id=28469
EvalNodes don't destroyData() (delete their parser data) since they need to hold onto
their varStack. Copy a list of variable onto EvalCodeBlock, and this can go away.
* bytecode/CodeBlock.h:
(JSC::EvalCodeBlock::variable):
(JSC::EvalCodeBlock::numVariables):
(JSC::EvalCodeBlock::adoptVariables):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* parser/Nodes.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::generateBytecode):
* runtime/Executable.h:
2009-08-19 Jungshik Shin <jshin@chromium.org>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=28441
Fix a build issue with ICU 4.2 or later on Windows with Visual C++.
Instead of defining all isXXX and toupper/tolower as
WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h,
#define them to be different by prepending 'WTF_...ASCIIType_h' with
the originial names like 'toupper_WTF_...ASCIIType_h'.
* wtf/DisallowCType.h:
2009-08-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Assigning a function to an object should always use the existing transition, even if the transition is not specialized
https://bugs.webkit.org/show_bug.cgi?id=28442
Check for an unspecialized transition as an alternative to always failing if specialisation does not match.
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransitionToExistingStructure):
2009-08-18 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
Added additional getter to ByteArray with an unsigned char as return.
ByteArray can take unsigned char directly now.
* wtf/ByteArray.h:
(WTF::ByteArray::set):
(WTF::ByteArray::get):
2009-08-18 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
2009-08-18 Xan Lopez <xlopez@igalia.com>
Try to fix the GTK+ build.
* GNUmakefile.am:
2009-08-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
No, silly runtime, AST nodes are not for you.
We still use AST nodes (ScopeNodes, particularly FunctionBodyNodes) within
the runtime, which means that these nodes must be persisted outside of the
arena, contain both parser & runtime data, etc. This is all a bit of a mess.
Move functionality into a new FunctionExecutable class.
* API/JSCallbackFunction.cpp:
* API/JSObjectRef.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::markAggregate):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::discardBytecode):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::CodeBlock::ownerExecutable):
(JSC::CodeBlock::extractExceptionInfo):
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::functionDecl):
(JSC::CodeBlock::numberOfFunctionDecls):
(JSC::CodeBlock::addFunctionExpr):
(JSC::CodeBlock::functionExpr):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):
* bytecode/EvalCodeCache.h:
* bytecode/SamplingTool.cpp:
(JSC::SamplingTool::doRun):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
* bytecompiler/BytecodeGenerator.h:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
* interpreter/CallFrameClosure.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::debug):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::):
* parser/Nodes.cpp:
(JSC::FunctionBodyNode::reparseDataIfNecessary):
* parser/Nodes.h:
(JSC::EvalNode::partialDestroyData):
* parser/Parser.h:
* profiler/ProfileGenerator.cpp:
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
* runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
(JSC::Arguments::Arguments):
(JSC::JSActivation::copyRegisters):
* runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
* runtime/CallData.h:
(JSC::):
* runtime/Collector.cpp:
(JSC::Heap::collect):
* runtime/ConstructData.h:
(JSC::):
* runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
* runtime/Executable.cpp: Added.
(JSC::EvalExecutable::generateBytecode):
(JSC::ProgramExecutable::generateBytecode):
(JSC::FunctionExecutable::generateBytecode):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::isHostFunction):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::ExecutableBase::~ExecutableBase):
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::source):
(JSC::ExecutableBase::sourceID):
(JSC::ExecutableBase::lastLine):
(JSC::ExecutableBase::usesEval):
(JSC::ExecutableBase::usesArguments):
(JSC::ExecutableBase::needsActivation):
(JSC::ExecutableBase::astNode):
(JSC::ExecutableBase::generatedJITCode):
(JSC::ExecutableBase::getExecutablePool):
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::varStack):
(JSC::EvalExecutable::evalNode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::programNode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::generatedBytecode):
(JSC::FunctionExecutable::usesEval):
(JSC::FunctionExecutable::usesArguments):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::paramString):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::body):
(JSC::FunctionExecutable::jitCode):
(JSC::FunctionExecutable::createNativeThunk):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::markChildren):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::isHostFunction):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):
* runtime/JSFunction.h:
(JSC::JSFunction::executable):
(JSC::FunctionExecutable::make):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::numericCompareFunction):
* runtime/JSGlobalData.h:
2009-08-17 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix 300,000+ leaks seen during the regression tests.
EvalCodeCache::get was heap-allocating an EvalExecutable instance without adopting the initial reference.
While fixing this we noticed that EvalExecutable was a RefCounted type that was sometimes stack allocated.
To make this cleaner and to prevent clients from attempting to ref a stack-allocated instance, we move the
refcounting down to a new CacheableEvalExecutable class that derives from EvalExecutable. EvalCodeCache::get
now uses CacheableEvalExecutable::create and avoids the leak.
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
* runtime/Executable.h:
(JSC::CacheableEvalExecutable::create):
(JSC::CacheableEvalExecutable::CacheableEvalExecutable):
2009-08-17 Oliver Hunt <oliver@apple.com>
RS=Mark Rowe.
REGRESSION (r47292): Prototype.js is broken by ES5 Arguments changes
https://bugs.webkit.org/show_bug.cgi?id=28341
<rdar://problem/7145615>
Reverting r47292. Alas Prototype.js breaks with Arguments inheriting
from Array as ES5 attempted. Prototype.js defines $A in terms of a
function it places on (among other global objects) the Array prototype,
thus breaking $A for arrays.
* runtime/Arguments.h:
(JSC::Arguments::Arguments):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::markChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
* tests/mozilla/ecma_3/Function/arguments-001.js:
2009-08-17 Peter Kasting <pkasting@google.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
2009-08-17 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
Fix build with FAST_MALLOC_MATCH_VALIDATION enabled.
* wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastRealloc):
2009-08-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Fix crash on ./ecma_2/RegExp/exec-002.js.
https://bugs.webkit.org/show_bug.cgi?id=28353
Change the order of freeParenthesesDisjunctionContext and
popParenthesesDisjunctionContext on all call sites as the pop
method is accessing backTrack->lastContext which is the context
that is about to be freed.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::parenthesesDoBacktrack):
(JSC::Yarr::Interpreter::backtrackParentheses):
2009-08-16 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=28352
Fix coding style violations. Use m_ for C++ class members. Remove
trailing whitespace on empty lines.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::tryConsumeCharacter):
(JSC::Yarr::Interpreter::tryConsumeBackReference):
(JSC::Yarr::Interpreter::parenthesesDoBacktrack):
(JSC::Yarr::Interpreter::backtrackParentheses):
(JSC::Yarr::ByteCompiler::ByteCompiler):
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::checkInput):
(JSC::Yarr::ByteCompiler::assertionBOL):
(JSC::Yarr::ByteCompiler::assertionEOL):
(JSC::Yarr::ByteCompiler::assertionWordBoundary):
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
(JSC::Yarr::ByteCompiler::popParenthesesStack):
(JSC::Yarr::ByteCompiler::closeAlternative):
(JSC::Yarr::ByteCompiler::closeBodyAlternative):
(JSC::Yarr::ByteCompiler::atomParenthesesEnd):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction):
(JSC::Yarr::ByteCompiler::alterantiveDisjunction):
(JSC::Yarr::ByteCompiler::emitDisjunction):
2009-08-15 Mark Rowe <mrowe@apple.com>
Fix the build with JIT disabled.
* runtime/Arguments.h: Only compile the jitCode method when the JIT is enabled.
* runtime/Executable.h: Include PrototypeFunction.h so the compiler knows what
NativeFunctionWrapper is when the JIT is disabled.
2009-08-15 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Sam Weinig.
Added ENABLE_EVENTSOURCE flag.
https://bugs.webkit.org/show_bug.cgi?id=14997
* Configurations/FeatureDefines.xcconfig:
2009-08-14 Gavin Barraclough <barraclough@apple.com>
* parser/Parser.h:
(JSC::EvalExecutable::parse):
(JSC::ProgramExecutable::parse):
* runtime/Executable.h:
2009-08-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Remove AST nodes from use within the Runtime (outside of parsing), stage 1
https://bugs.webkit.org/show_bug.cgi?id=28330
Remove the EvalNode and ProgramNode from use in the runtime. They still exist
after this patch, but are hidden behind EvalExecutable and FunctionExecutable,
and are also still reachable behind CodeBlock::m_ownerNode.
The next step will be to beat back FunctionBodyNode in the same fashion.
Then remove the usage via CodeBlock, then only construct these nodes only on
demand during bytecode generation.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::GlobalCodeBlock::~GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* interpreter/Interpreter.h:
* parser/Nodes.cpp:
(JSC::FunctionBodyNode::createNativeThunk):
(JSC::FunctionBodyNode::generateBytecode):
(JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
* parser/Parser.h:
(JSC::Parser::parse):
(JSC::Parser::reparse):
(JSC::Parser::parseFunctionFromGlobalCode):
(JSC::::parse):
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Error.cpp:
(JSC::throwError):
* runtime/Error.h:
* runtime/Executable.h: Added.
(JSC::TemplateExecutable::TemplateExecutable):
(JSC::TemplateExecutable::markAggregate):
(JSC::TemplateExecutable::sourceURL):
(JSC::TemplateExecutable::lineNo):
(JSC::TemplateExecutable::bytecode):
(JSC::TemplateExecutable::jitCode):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/FunctionConstructor.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::numericCompareFunction):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::markChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::codeBlocks):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
2009-08-14 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.
* runtime/ArrayConstructor.cpp:
(JSC::arrayConstructorIsArray): Removed unneeded isObject call
and updated remaining isObject call to new name, inherits.
* runtime/JSCell.h: Renamed isObject(<class>) to inherits(<class>)
but more importantly, made it non-virtual (it was already inline)
so it is now as fast as JSObject::inherits was.
* runtime/JSObject.h: Removed inherits function since the one
in the base class is fine as-is. Also made various JSCell functions
that should not be called on JSObject uncallable by making them
both private and not implemented.
(JSC::JSCell::inherits): Updated name.
(JSC::JSValue::inherits): Ditto.
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncConcat):
* runtime/BooleanPrototype.cpp:
(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSActivation.cpp:
(JSC::JSActivation::argumentsGetter):
* runtime/JSValue.h:
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):
* runtime/ScopeChain.cpp:
(JSC::ScopeChain::localDepth):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSplit):
Updated to new name, inherits, from old name, isObject.
2009-07-31 Harald Fernengel <harald.fernengel@nokia.com>
Reviewed by Simon Hausmann.
Adding QNX as a platform. Currently only tested with Qt.
https://bugs.webkit.org/show_bug.cgi?id=27885
* JavaScriptCore/runtime/Collector.cpp: Added retrieving of stack base
since QNX doesn't have the pthread _nt functions
* JavaScriptCore/wtf/Platform.h: Added WTF_PLATFORM_QNX and corresponding
defines
* WebCore/bridge/npapi.h: Build fix for missing typedefs on QNX
2009-08-14 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Currently generic ARM and ARMv7 platforms work only with JSVALUE32
https://bugs.webkit.org/show_bug.cgi?id=28300
* wtf/Platform.h:
2009-08-14 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Enable JIT on ARM for QT by default
https://bugs.webkit.org/show_bug.cgi?id=28259
* wtf/Platform.h:
2009-08-14 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Enable YARR_JIT on ARM for QT by default
https://bugs.webkit.org/show_bug.cgi?id=28259
* wtf/Platform.h:
2009-08-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
[ES5] Arguments object should inherit from Array
https://bugs.webkit.org/show_bug.cgi?id=28298
Make the Arguments object conform to the behaviour specified in ES5.
The simple portion of this is to make Arguments use Array.prototype
as its prototype rather than Object.prototype.
The spec then requires us to set instance.constructor to the pristine
Object constructor, and instance.toString and instance.toLocaleString
to the pristine versions from Object.prototype. To do this we now
make the ObjectPrototype constructor return its toString and
toLocaleString functions (similar to the call and apply functions
from FunctionPrototype).
Oddly enough this reports itself as a slight win, but given the code
isn't hit in the tests that claim to have improved I put this down to
code motion.
* runtime/Arguments.h:
(JSC::Arguments::Arguments):
(JSC::Arguments::initializeStandardProperties):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::markChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::objectConstructor):
(JSC::JSGlobalObject::objectToStringFunction):
(JSC::JSGlobalObject::objectToLocaleStringFunction):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
* tests/mozilla/ecma_3/Function/arguments-001.js:
Update test to new es5 behaviour
2009-08-14 Oliver Hunt <oliver@apple.com>
Remove MarkStack::drain from the JSC exports file
MarkStack::drain is now marked inline, the including it in the exports file
produces an ld warning
* JavaScriptCore.exp:
2009-08-13 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Remove accidentally left in debugging statement.
* runtime/JSArray.h:
(JSC::MarkStack::drain):
2009-08-13 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
[ES5] Implement Array.isArray
https://bugs.webkit.org/show_bug.cgi?id=28296
Add support for Array.isArray to the Array constructor
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::arrayConstructorIsArray):
* runtime/ArrayConstructor.h:
* runtime/CommonIdentifiers.h:
* runtime/JSArray.h:
(JSC::MarkStack::drain):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
2009-08-13 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (Buildfix).
Attempt to fix windows build
* runtime/Collector.cpp:
2009-08-13 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Devirtualise marking
https://bugs.webkit.org/show_bug.cgi?id=28294
Add a bit to TypeInfo to indicate that an object uses the standard
JSObject::markChildren method. This allows us to devirtualise marking
of most objects (though a branch is still needed). We also add a branch
to identify arrays thus devirtualising marking in that case as well.
In order to make the best use of this devirtualisation I've also reworked
the MarkStack::drain() logic to make the iteration more efficient.
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* JavaScriptCore.exp:
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
* runtime/JSArray.cpp:
(JSC::JSArray::markChildren):
* runtime/JSArray.h:
(JSC::JSArray::markChildrenDirect):
(JSC::MarkStack::drain):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::createStructure):
* runtime/JSCell.h:
(JSC::MarkStack::append):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSNumberCell.h:
(JSC::JSNumberCell::createStructure):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.cpp:
(JSC::JSObject::markChildren):
* runtime/JSObject.h:
(JSC::JSObject::markChildrenDirect):
(JSC::JSObject::createStructure):
* runtime/JSString.h:
(JSC::JSString::createStructure):
* runtime/JSType.h:
(JSC::):
* runtime/MarkStack.h:
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::MarkSet::MarkSet):
(JSC::MarkStack::MarkStackArray::last):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
* runtime/TypeInfo.h:
(JSC::TypeInfo::hasDefaultMark):
2009-08-13 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
Some small bits of housekeeping.
* JavaScriptCore.xcodeproj/project.pbxproj: Make Parser.h
project instead of private. Remove JSONObject.lut.h.
* assembler/ARMAssembler.h: Remove unneeded WTF prefix.
* assembler/AssemblerBufferWithConstantPool.h: Ditto.
* bytecompiler/BytecodeGenerator.h: Ditto.
* wtf/SegmentedVector.h: Add a "using" statement as we do
with the other WTF headers.
2009-08-13 Darin Adler <darin@apple.com>
Fix Tiger build.
* parser/Grammar.y: Use a template function so we can compile
setStatementLocation even if it comes before YYLTYPE is defined.
2009-08-13 Darin Adler <darin@apple.com>
Reviewed by George Staikos.
Too much use of void* in Grammar.y
https://bugs.webkit.org/show_bug.cgi?id=28287
* parser/Grammar.y: Changed all the helper functions to
take a JSGlobalData* instead of a void*. A couple formatting
tweaks that I missed when breaking this into pieces.
2009-08-13 Darin Adler <darin@apple.com>
Reviewed by George Staikos.
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287
* parser/Grammar.y: Reduced and sorted includes. Tweaked comment
format. Marked a few more functions inline.
2009-08-13 Darin Adler <darin@apple.com>
Reviewed by George Staikos.
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287
* parser/Grammar.y: Pass the number to the PropertyNode instead of
first turning it into an Identifier.
* parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode): Add an overload that takes a double
so the code to convert to a string can be here instead of Grammar.y.
* parser/Nodes.h: Ditto.
2009-08-13 Darin Adler <darin@apple.com>
Reviewed by George Staikos.
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287
* parser/Grammar.y: Eliminate the DBG macro.
2009-08-13 Darin Adler <darin@apple.com>
Reviewed by George Staikos.
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287
* parser/Grammar.y: Eliminate the SET_EXCEPTION_LOCATION macro.
2009-08-13 Darin Adler <darin@apple.com>
Reviewed by George Staikos.
George asked me to break the patch from
https://bugs.webkit.org/show_bug.cgi?id=28287
into smaller pieces and land it in stages.
* parser/Grammar.y: Eliminate the LEXER macro.
2009-08-13 Mark Rowe <mrowe@apple.com>
Try some more to fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.
2009-08-13 Mark Rowe <mrowe@apple.com>
Try and fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.
2009-08-13 Darin Adler <darin@apple.com>
Reviewed by David Levin.
JavaScriptCore tweaks to get ready for the parser arena
https://bugs.webkit.org/show_bug.cgi?id=28243
Eliminate dependencies on Nodes.h outside JavaScriptCore,
and cut down on them inside JavaScriptCore.
Change regular expression parsing to use identifiers as
with other strings we parse.
Fix a couple things that are needed to use const Identifier
more, which will be part of the parser arena work.
* JavaScriptCore.exp: Resorted and updated.
* JavaScriptCore.xcodeproj/project.pbxproj: Changed
CollectorHeapIterator.h to be project-internal.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPushNewScope): Added const.
* bytecompiler/BytecodeGenerator.h: Ditto.
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Moved this function
here from WebCore. Here is better since it uses so many internals.
Removed unimportant optimization for the no listener case.
* debugger/Debugger.h: Ditto. Also removed unneeded include
and tweaked formatting and comments.
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName): Call asFunction instead
of doing the unchecked static_cast.
(JSC::DebuggerCallFrame::calculatedFunctionName): Ditto.
* jit/JITStubs.cpp:
(JSC::op_call_JSFunction): Call isHostFunction on the body rather
than on the JSFunction.
(JSC::vm_lazyLinkCall): Ditto.
(JSC::op_construct_JSConstruct): Ditto.
* parser/Grammar.y: Changed callers to use new scanRegExp with
out arguments instead of relying on state in the Lexer. And
callers that just want to skip a regular expression to use
skipRegExp.
* parser/Lexer.cpp:
(JSC::Lexer::scanRegExp): Changed to use out arguments, and to
add a prefix argument so we can add in the "=" character as needed.
Also rewrote to streamline the logic a bit inspired by suggestions
by David Levin.
(JSC::Lexer::skipRegExp): Added. Version of the function above that
does not actually put the regular expression into a string.
(JSC::Lexer::clear): Removed code to clear m_pattern and m_flags.
* parser/Lexer.h: Changed scanRegExp to have out arguments. Added
skipRegExp. Eliminated pattern, flags, m_pattern, and m_flags.
* parser/NodeConstructors.h:
(JSC::RegExpNode::RegExpNode): Changed to take const Identifier&.
* parser/Nodes.cpp:
(JSC::RegExpNode::emitBytecode): Changed since m_pattern and
m_flags are now Identifier instead of UString.
(JSC::FunctionBodyNode::make): Moved this function here instead
of putting it in the JSFunction.h header.
* parser/Nodes.h: Changed RegExpNode to use Identifier.
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier): Changed to use isHostFunction
on the body instead of on the JSFunction object.
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString): Ditto.
* runtime/JSFunction.cpp:
(JSC::JSFunction::isHostFunction): Moved here from header.
(JSC::JSFunction::isHostFunctionNonInline): Added.
(JSC::JSFunction::JSFunction): Removed unneeded initialization of
m_body to 0.
(JSC::JSFunction::setBody): Moved here from header.
* runtime/JSFunction.h: Removed unneeded includes. Moved private
constructor down to the private section. Made virtual functions
private. Removed unneeded overload of setBody and moved the body
of the function into the .cpp file. Changed assertions to use
the non-inline version of isHostFunction.
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter): Use asFunction instead
of doing the unchecked static_cast.
* wtf/SegmentedVector.h:
(WTF::SegmentedVector::isEmpty): Added.
2009-08-13 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Darin Adler.
Use the version of operator new that takes a JSGlobalData when allocating FuncDeclNode and FuncExprNode
from within the grammar to prevent these nodes from being leaked.
* parser/Grammar.y:
2009-08-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Remove the special-case for Qt wrt JSVALUE_32 introduced in
r46709. It must've been a dependency issue on the bot, as
after a manual build all the tests pass on amd64 and ia32.
* wtf/Platform.h:
2009-08-12 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add optimize call and property access support for ARM JIT.
https://bugs.webkit.org/show_bug.cgi?id=24986
For tightly coupled sequences the BEGIN_UNINTERRUPTED_SEQUENCE and
END_UNINTERRUPTED_SEQUENCE macros have been introduced which ensure
space for instructions and constants of the named sequence. This
method is vital for those architecture which are using constant pool.
The 'latePatch' method - which was linked to JmpSrc - is replaced with
a port specific solution (each calls are marked to place their address
on the constant pool).
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::linkBranch):
(JSC::ARMAssembler::executableCopy): Add extra align for constant pool.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::JmpSrc::JmpSrc):
(JSC::ARMAssembler::sizeOfConstantPool):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkCall):
* assembler/ARMv7Assembler.h:
* assembler/AbstractMacroAssembler.h:
* assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::flushIfNoSpaceFor): Fix the
computation of the remaining space.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::ensureSpace):
(JSC::MacroAssemblerARM::sizeOfConstantPool):
(JSC::MacroAssemblerARM::prepareCall):
* assembler/X86Assembler.h:
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITInlineMethods.h:
(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
2009-08-12 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Dave Kilzer.
Disable WTF_USE_JSVALUE32_64 on iPhone for now (support not yet added for ARMv7).
* wtf/Platform.h:
2009-08-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Maciej Stachoviak.
Ooops - moved code that had been accidentally added to op_new_func instead of
op_new_func_exp, to where it shoulds be.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* wtf/Platform.h:
2009-08-12 Ada Chan <adachan@apple.com>
Added workaround for the limitation that VirtualFree with MEM_RELEASE
can only accept the base address returned by VirtualAlloc when the region
was reserved and it can only free the entire region, and not a part of it.
Reviewed by Oliver Hunt.
* runtime/MarkStack.h:
(JSC::MarkStack::MarkStackArray::shrinkAllocation):
* runtime/MarkStackWin.cpp:
(JSC::MarkStack::releaseStack):
2009-08-12 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
Build fix: use std::numeric_limits<long long>::min() instead of LLONG_MIN
since LLONG_MIN is not defined in standard c++.
* runtime/UString.cpp:
(JSC::UString::from):
2009-08-12 Benjamin Otte <otte@gnome.org>
Reviewed by Jan Alonzo.
Buildfix for Gtk platforms debug builds.
* GNUmakefile.am: Choose MarkStackPosix.cpp or MarkStackWin.cpp
depending on platform.
2009-08-12 Simon Hausmann <simon.hausmann@nokia.com>
Prospective build fix for Mac and 32-bit Windows.
* runtime/UString.cpp: Include wtf/StringExtras.h for snprintf.
(JSC::UString::from): Use %lld instead of %I64d for snprintf
on non-windows platforms.
2009-08-12 Prasanth Ullattil <prasanth.ullattil@nokia.com>
Reviewed by Simon Hausmann.
Fix compile error on 64Bit Windows, when UString::from
is called with an intptr_t.
Added new UString::From overload with long long parameter.
Thanks to Holger for the long long idea.
* runtime/UString.cpp:
(JSC::UString::from):
* runtime/UString.h:
2009-08-11 Oliver Hunt <oliver@apple.com>
Reviewed by Mark Rowe.
Minor style fixes.
* runtime/UString.h:
(JSC::UString::Rep::createEmptyBuffer):
* wtf/FastMalloc.h:
(WTF::TryMallocReturnValue::getValue):
2009-08-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469
Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
* runtime/UString.cpp:
(JSC::allocChars):
(JSC::reallocChars):
(JSC::expandCapacity):
(JSC::UString::Rep::reserveCapacity):
(JSC::UString::expandPreCapacity):
(JSC::createRep):
(JSC::concatenate):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::append):
(JSC::UString::operator=):
* runtime/UString.h:
(JSC::UString::Rep::createEmptyBuffer):
* wtf/FastMalloc.cpp:
(WTF::tryFastZeroedMalloc):
(WTF::tryFastMalloc):
(WTF::tryFastCalloc):
(WTF::tryFastRealloc):
(WTF::TCMallocStats::tryFastMalloc):
(WTF::TCMallocStats::tryFastCalloc):
(WTF::TCMallocStats::tryFastRealloc):
* wtf/FastMalloc.h:
(WTF::TryMallocReturnValue::TryMallocReturnValue):
(WTF::TryMallocReturnValue::~TryMallocReturnValue):
(WTF::TryMallocReturnValue::operator PossiblyNull<T>):
(WTF::TryMallocReturnValue::getValue):
* wtf/Platform.h:
* wtf/PossiblyNull.h: Added.
(WTF::PossiblyNull::PossiblyNull):
(WTF::PossiblyNull::~PossiblyNull):
(WTF::::getValue):
2009-08-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix part deux).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-11 Gavin Barraclough <barraclough@apple.com>
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Restrict use of FuncDeclNode & FuncExprNode to the parser.
https://bugs.webkit.org/show_bug.cgi?id=28209
These objects were also being referenced from the CodeBlock. By changing this
to just retain pointers to FunctionBodyNodes these classes can be restricted to
use during parsing.
No performance impact (or sub-percent progression).
* JavaScriptCore.exp:
Update symbols.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::mark):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addFunction):
(JSC::CodeBlock::function):
Unify m_functions & m_functionExpressions into a single Vector<RefPtr<FuncExprNode> >.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
* bytecompiler/BytecodeGenerator.h:
FunctionStacks now contain FunctionBodyNodes not FuncDeclNodes.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
Update to reflect chnages in CodeBlock.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func_exp):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::):
Update to reflect chnages in CodeBlock.
* parser/Grammar.y:
FunctionStacks now contain FunctionBodyNodes not FuncDeclNodes.
* parser/NodeConstructors.h:
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
* parser/Nodes.cpp:
(JSC::ScopeNodeData::mark):
(JSC::FunctionBodyNode::finishParsing):
* parser/Nodes.h:
(JSC::FunctionBodyNode::ident):
Move m_ident & make methods from FuncDeclNode & FuncExprNode to FunctionBodyNode.
* runtime/JSFunction.h:
(JSC::FunctionBodyNode::make):
Make this method inline (was FuncDeclNode::makeFunction).
2009-08-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Native JSON.stringify does not omit functions
https://bugs.webkit.org/show_bug.cgi?id=28117
Objects that are callable should be treated as undefined when
serialising to JSON.
* runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
2009-08-11 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page
https://bugs.webkit.org/show_bug.cgi?id=28169
Handle the case where someone has attempted to shadow a property
on the global object with a constant.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::constRegisterFor):
* parser/Nodes.cpp:
(JSC::ConstDeclNode::emitCodeSingle):
2009-08-11 John Gregg <johnnyg@google.com>
Reviewed by Maciej Stachowiak.
Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463
Adds ENABLE_NOTIFICATION flag.
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2009-08-11 Maxime Simon <simon.maxime@gmail.com>
Reviewed by Eric Seidel.
Modifications on JavaScriptCore to allow Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=28121
* runtime/Collector.cpp: Haiku doesn't have sys/mman.h, using OS.h instead.
(JSC::currentThreadStackBase): Haiku uses its own threading system.
* wtf/Platform.h: Defining all Haiku platform values.
* wtf/haiku/MainThreadHaiku.cpp: Adding a missing header (NotImplemented.h).
2009-08-11 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Fix windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Tor Arne Vestbø.
Buildfix for Qt-win platforms.
* JavaScriptCore.pri: Choose MarkStackPosix.cpp or MarkStackWin.cpp depend on platform.
2009-08-10 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (And another build fix).
Add new exports for MSVC
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-08-10 Oliver Hunt <oliver@apple.com>
Reviewed by NOBODY (yet another build fix).
Remove obsolete entries from MSVC exports file
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-10 Oliver Hunt <oliver@apple.com>
Add includes needed for non-allinonefile builds
* runtime/GetterSetter.h:
* runtime/ScopeChain.h:
2009-08-10 Oliver Hunt <oliver@apple.com>
Fix export file for last build fix
* JavaScriptCore.exp:
2009-08-10 Oliver Hunt <oliver@apple.com>
Hoist page size initialization into platform specific code.
* jit/ExecutableAllocatorPosix.cpp:
* jit/ExecutableAllocatorWin.cpp:
* runtime/MarkStack.h:
(JSC::MarkStack::pageSize):
* runtime/MarkStackPosix.cpp:
(JSC::MarkStack::initializePagesize):
* runtime/MarkStackWin.cpp:
(JSC::MarkStack::initializePagesize):
2009-08-07 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Stack overflow crash in JavaScript garbage collector mark pass
https://bugs.webkit.org/show_bug.cgi?id=12216
Make the GC mark phase iterative by using an explicit mark stack.
To do this marking any single object is performed in multiple stages
* The object is appended to the MarkStack, this sets the marked
bit for the object using the new markDirect() function, and then
returns
* When the MarkStack is drain()ed the object is popped off the stack
and markChildren(MarkStack&) is called on the object to collect
all of its children. drain() then repeats until the stack is empty.
Additionally I renamed a number of methods from 'mark' to 'markAggregate'
in order to make it more clear that marking of those object was not
going to result in an actual recursive mark.
* GNUmakefile.am
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::markAggregate):
* bytecode/CodeBlock.h:
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::markAggregate):
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::markChildren):
* debugger/DebuggerActivation.h:
* interpreter/Register.h:
* interpreter/RegisterFile.h:
(JSC::RegisterFile::markGlobals):
(JSC::RegisterFile::markCallFrames):
* parser/Nodes.cpp:
(JSC::ScopeNodeData::markAggregate):
(JSC::EvalNode::markAggregate):
(JSC::FunctionBodyNode::markAggregate):
* parser/Nodes.h:
(JSC::ScopeNode::markAggregate):
* runtime/ArgList.cpp:
(JSC::MarkedArgumentBuffer::markLists):
* runtime/ArgList.h:
* runtime/Arguments.cpp:
(JSC::Arguments::markChildren):
* runtime/Arguments.h:
* runtime/Collector.cpp:
(JSC::Heap::markConservatively):
(JSC::Heap::markCurrentThreadConservativelyInternal):
(JSC::Heap::markCurrentThreadConservatively):
(JSC::Heap::markOtherThreadConservatively):
(JSC::Heap::markStackObjectsConservatively):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::collect):
* runtime/Collector.h:
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::markChildren):
* runtime/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::createStructure):
* runtime/GlobalEvalFunction.cpp:
(JSC::GlobalEvalFunction::markChildren):
* runtime/GlobalEvalFunction.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::markChildren):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::markChildren):
* runtime/JSArray.h:
* runtime/JSCell.h:
(JSC::JSCell::markCellDirect):
(JSC::JSCell::markChildren):
(JSC::JSValue::markDirect):
(JSC::JSValue::markChildren):
(JSC::JSValue::hasChildren):
(JSC::MarkStack::append):
(JSC::MarkStack::drain):
* runtime/JSFunction.cpp:
(JSC::JSFunction::markChildren):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
(JSC::JSGlobalObject::markChildren):
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::markChildren):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::markAggregate):
(JSC::JSONObject::markStringifiers):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::markChildren):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::markChildren):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::markChildren):
* runtime/JSStaticScopeObject.h:
* runtime/JSType.h:
(JSC::):
* runtime/JSValue.h:
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::markChildren):
* runtime/JSWrapperObject.h:
* runtime/MarkStack.cpp: Added.
(JSC::MarkStack::compact):
* runtime/MarkStack.h: Added.
(JSC::):
(JSC::MarkStack::MarkStack):
(JSC::MarkStack::append):
(JSC::MarkStack::appendValues):
(JSC::MarkStack::~MarkStack):
(JSC::MarkStack::MarkSet::MarkSet):
(JSC::MarkStack::pageSize):
MarkStackArray is a non-shrinking, mmap-based vector type
used for storing objects to be marked.
(JSC::MarkStack::MarkStackArray::MarkStackArray):
(JSC::MarkStack::MarkStackArray::~MarkStackArray):
(JSC::MarkStack::MarkStackArray::expand):
(JSC::MarkStack::MarkStackArray::append):
(JSC::MarkStack::MarkStackArray::removeLast):
(JSC::MarkStack::MarkStackArray::isEmpty):
(JSC::MarkStack::MarkStackArray::size):
(JSC::MarkStack::MarkStackArray::shrinkAllocation):
* runtime/MarkStackPosix.cpp: Added.
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
* runtime/MarkStackWin.cpp: Added.
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack):
* runtime/ScopeChain.h:
* runtime/ScopeChainMark.h:
(JSC::ScopeChain::markAggregate):
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::mark):
* runtime/Structure.h:
(JSC::Structure::markAggregate):
2009-08-10 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix hundreds of "pointer being freed was not allocated" errors seen on the build bot.
* wtf/FastMalloc.h: Implement nothrow variants of the delete and delete[] operators since
we implement the nothrow variants of new and new[]. The nothrow variant of delete is called
explicitly in the implementation of std::sort which was resulting in FastMalloc-allocated
memory being passed to the system allocator to free.
2009-08-10 Jan Michael Alonzo <jmalonzo@webkit.org>
[Gtk] Unreviewed build fix. Move JSAPIValueWrapper.cpp/.h in the debug
section. This file is already part of AllInOneFile in Release builds.
* GNUmakefile.am:
2009-08-10 Darin Adler <darin@apple.com>
* wtf/FastMalloc.h: Fix build.
2009-08-10 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
FastMalloc.h has cross-platform code but marked as WinCE-only
https://bugs.webkit.org/show_bug.cgi?id=28160
1) The support for nothrow was inside #if PLATFORM(WINCE) even though it is
not platform-specific.
2) The code tried to override operator delete nothrow, which does not exist.
3) The code in the header checks the value of USE_SYSTEM_MALLOC, but the code
in FastMalloc.cpp checks only if the macro is defined.
* wtf/FastMalloc.h: See above.
* wtf/FastMalloc.cpp: Ditto.
2009-08-10 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix an annoying indentation issue.
* runtime/DateConstructor.cpp:
(JSC::constructDate):
2009-08-10 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Add new files to makefile.
* GNUmakefile.am:
2009-08-10 Simon Hausmann <simon.hausmann@nokia.com>
Fix compilation with the interpreter instead of the JIT by including
PrototypeFunction.h as forward-declared through NativeFunctionWrapper.h.
* runtime/ObjectConstructor.cpp:
2009-08-09 Oliver Hunt <oliver@apple.com>
Reviewed by George Staikos.
JSON.stringify replacer returning undefined does not omit object properties
https://bugs.webkit.org/show_bug.cgi?id=28118
Correct behaviour of stringify when using a replacer function that returns
undefined. This is a simple change to move the undefined value check to
after the replacer function is called. This means that the replacer function
is now called for properties with the value undefined, however i've confirmed
that this behaviour is correct.
In addition I've made the cyclic object exception have a more useful error
message.
* runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
2009-08-08 Oliver Hunt <oliver@apple.com>
Reviewed by Eric Seidel and Sam Weinig.
[ES5] Implement Object.getPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=28114
Implement getPrototypeOf
* runtime/CommonIdentifiers.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
(JSC::objectConsGetPrototypeOf):
* runtime/ObjectConstructor.h:
2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879
Several classes which are inherited from Noncopyable are instantiated by
operator new, so Noncopyable class has been inherited from FastAllocBase.
* wtf/Noncopyable.h:
2009-08-07 George Staikos <george.staikos@torchmobile.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=27305
Implement WinCE-specific unicode layer.
Written by George Staikos <george.staikos@torchmobile.com>
with bug fixes by Yong Li <yong.li@torchmobile.com>
refactored by Joe Mason <joe.mason@torchmobile.com>
* wtf/Platform.h:
* wtf/unicode/Unicode.h:
* wtf/unicode/wince/UnicodeWince.cpp: Added.
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
(WTF::Unicode::foldCase):
(WTF::Unicode::isPrintableChar):
(WTF::Unicode::isSpace):
(WTF::Unicode::isLetter):
(WTF::Unicode::isUpper):
(WTF::Unicode::isLower):
(WTF::Unicode::isDigit):
(WTF::Unicode::isPunct):
(WTF::Unicode::toTitleCase):
(WTF::Unicode::direction):
(WTF::Unicode::category):
(WTF::Unicode::decompositionType):
(WTF::Unicode::combiningClass):
(WTF::Unicode::mirroredChar):
(WTF::Unicode::digitValue):
* wtf/unicode/wince/UnicodeWince.h: Added.
(WTF::Unicode::):
(WTF::Unicode::isSeparatorSpace):
(WTF::Unicode::isHighSurrogate):
(WTF::Unicode::isLowSurrogate):
(WTF::Unicode::isArabicChar):
(WTF::Unicode::hasLineBreakingPropertyComplexContext):
(WTF::Unicode::umemcasecmp):
(WTF::Unicode::surrogateToUcs4):
2009-08-07 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28069
Add inline to help winscw compiler resolve specialized argument in
templated functions.
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lexString):
2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for RegExpObjectData struct
http://bugs.webkit.org/show_bug.cgi?id=26750
Inherits RegExpObjectData struct from FastAllocBase because
it has been instantiated by 'new' in JavaScriptCore/runtime/RegExpObject.cpp:62
* runtime/RegExpObject.h:
2009-08-06 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
Updated patch for bug #27059:
Symbian platform always uses little endian encoding,
regardless of compiler.
We need to make sure that we correctly detect EABI architecture
for armv5 targets on Symbian,
where __EABI__ is set but not __ARM_EABI__
* wtf/Platform.h:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed revert.
http://bugs.webkit.org/show_bug.cgi?id=27879
Revert 46877 because it broke GTK.
* wtf/Noncopyable.h:
2009-08-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( https://bugs.webkit.org/show_bug.cgi?id=27635 )
This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).
* bytecode/CodeBlock.cpp:
(JSC::printStructureStubInfo):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
* bytecode/CodeBlock.h:
(JSC::):
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
- Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::seenOnce):
(JSC::StructureStubInfo::setSeen):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::unlinkCall):
- Remove the "don't lazy link" stage of calls.
* jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
- Remove the "don't lazy link" stage of calls.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSlowCase):
- Remove the "don't lazy link" stage of calls.
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
(JSC::JITStubs::getPolymorphicAccessStructureListSlot):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
* jit/JITStubs.h:
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITStubs::):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
* wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
(WTF::PtrAndFlags::operator!):
(WTF::PtrAndFlags::operator->):
- Add ! and -> operators, add constuctor with pointer argument.
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Adam Barth.
Allow custom memory allocation control for Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879
Several classes which inherited from Noncopyable are instantiated by
operator new, so Noncopyable class has been inherited from FastAllocBase.
* wtf/Noncopyable.h:
2009-08-06 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Sam Weinig.
Add explicit dependencies for our build verification scripts to ensure that they always run after linking has completed.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-08-06 Mark Rowe <mrowe@apple.com>
Bring a little order to our otherwise out of control lives.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's PolymorphicAccessStructureList struct
https://bugs.webkit.org/show_bug.cgi?id=27877
Inherits PolymorphicAccessStructureList struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/jit/JITStubs.cpp:1229.
* bytecode/Instruction.h:
2009-08-05 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct
https://bugs.webkit.org/show_bug.cgi?id=27875
Inherits ScopeNodeData struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/parser/Nodes.cpp:1848.
* parser/Nodes.h:
2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add floating point support for generic ARM port.
https://bugs.webkit.org/show_bug.cgi?id=24986
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::doubleTransfer):
* assembler/ARMAssembler.h:
(JSC::ARM::):
(JSC::ARMAssembler::):
(JSC::ARMAssembler::faddd_r):
(JSC::ARMAssembler::fsubd_r):
(JSC::ARMAssembler::fmuld_r):
(JSC::ARMAssembler::fcmpd_r):
(JSC::ARMAssembler::fdtr_u):
(JSC::ARMAssembler::fdtr_d):
(JSC::ARMAssembler::fmsr_r):
(JSC::ARMAssembler::fsitod_r):
(JSC::ARMAssembler::fmstat):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::):
(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::storeDouble):
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::branchDouble):
* jit/JIT.h:
2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add JIT support for generic ARM port without optimizations.
https://bugs.webkit.org/show_bug.cgi?id=24986
All JIT optimizations are disabled.
Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::baseIndexTransfer32):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Imm32::Imm32):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::load32):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getBytecodeIndex):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::restoreArgumentReference):
* jit/JITOpcodes.cpp:
* jit/JITStubs.cpp:
* jit/JITStubs.h:
(JSC::JITStackFrame::returnAddressSlot):
* wtf/Platform.h:
2009-08-04 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Oiver Hunt.
Revert r46643 since this breaks the Yarr::Interpreter running the v8 tests.
https://bugs.webkit.org/show_bug.cgi?id=27874
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::freeDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
2009-08-04 Oliver Hunt <oliver@apple.com>
PPC64 Build fix
* wtf/Platform.h:
2009-08-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Adam Treat
Explicitly include limits.h header when using INT_MAX and INT_MIN
* interpreter/Interpreter.cpp
2009-08-03 Harald Fernengel <harald.fernengel@nokia.com>
Reviewed by Darin Adler.
Fix compile error for ambigous call to abs()
https://bugs.webkit.org/show_bug.cgi?id=27873
Fix ambiguity in abs(long int) call by calling labs() instead
* wtf/DateMath.cpp: replace call to abs() with labs()
2009-08-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934
* JavaScriptCore.pro:
2009-08-03 Ada Chan <adachan@apple.com>
Fixed the Tiger build.
* wtf/FastMalloc.cpp:
2009-08-03 Ada Chan <adachan@apple.com>
Reviewed by Darin Adler.
Don't use background thread to scavenge memory on Tiger until we figure out why it causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=27900
* wtf/FastMalloc.cpp:
2009-08-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Jan Alonzo.
Fix build break on Gtk/x86_64.
https://bugs.webkit.org/show_bug.cgi?id=27936
Use JSVALUE64 for X86_64 LINUX, except Qt.
* wtf/Platform.h:
2009-08-02 Xan Lopez <xlopez@igalia.com>
Fix the GTK+ build.
* wtf/Platform.h:
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled JSVALUE32_64 on Qt builds, since all layout tests mysteriously
crash with it enabled.
* wtf/Platform.h:
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Qt build fix.
Added JSAPIValueWrapper.cpp to the build.
* JavaScriptCore.pri:
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Windows build fix.
Exported symbols for JSAPIValueWrapper.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-08-02 Geoffrey Garen <ggaren@apple.com>
GTK build fix.
* jit/JITStubs.cpp: #include <stdarg.h>, for a definition of va_start.
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Qt build fix.
* runtime/Collector.cpp: #include <limits.h>, for a definition of ULONG_MAX.
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Windows build fix: Nixed JSImmediate::prototype, JSImmediate::toObject,
and JSImmediate::toThisObject, and removed their exported symbols.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
* runtime/JSImmediate.cpp:
* runtime/JSImmediate.h:
2009-08-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Enabled JSVALUE32_64 by default on all platforms other than x86_64 (which uses JSVALUE64).
* wtf/Platform.h:
2009-08-02 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Jan Alonzo.
Script for building the JavaScriptCore library for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619
* wscript: Added.
2009-08-02 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
DateMath depends on strftime and localtime, which need to be imported manually on WinCE
https://bugs.webkit.org/show_bug.cgi?id=26558
* wtf/DateMath.cpp:
2009-08-01 David Kilzer <ddkilzer@apple.com>
wtf/Threading.h: added include of Platform.h
Reviewed by Mark Rowe.
* wtf/Threading.h: Added #include "Platform.h" since this header
uses PLATFORM() and other macros.
2009-08-01 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Oliver Hunt.
Roll out r46668 as it was misinformed. ScopeChain is only used with placement new.
* runtime/ScopeChain.h:
2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Allow custom memory allocation control for JavaScriptCore's HashMap class
http://bugs.webkit.org/show_bug.cgi?id=27871
Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:148.
* wtf/RefPtrHashMap.h:
(WTF::):
2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Allow custom memory allocation control for JavaScriptCore's ScopeChain class
https://bugs.webkit.org/show_bug.cgi?id=27834
Inherits ScopeChain class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSFunction.h:109.
* runtime/ScopeChain.h:
2009-08-01 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's RegExpConstructorPrivate struct
https://bugs.webkit.org/show_bug.cgi?id=27833
Inherits RegExpConstructorPrivate class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/RegExpConstructor.cpp:152.
* runtime/RegExpConstructor.cpp:
2009-07-31 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
Resurrect the old GetTickCount implementation of currentTime, controlled by WTF_USE_QUERY_PERFORMANCE_COUNTER
currentSystemTime taken from older WebKit; currentTime written by Yong Li <yong.li@torchmobile.com>; cleanup by Joe Mason <joe.mason@torchmobile.com>
https://bugs.webkit.org/show_bug.cgi?id=27848
* wtf/CurrentTime.cpp:
(WTF::currentSystemTime): get current time with GetCurrentFT
(WTF::currentTime): track msec elapsed since first currentSystemTime call using GetTickCount
* wtf/Platform.h:
2009-07-31 Ada Chan <adachan@apple.com>
Fixes the Windows release-PGO build.
Reviewed by Jon Honeycutt.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Suppresses the warning about unreachable code that we get by adding "return 0" to WTF::TCMalloc_PageHeap::runScavengerThread().
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::runScavengerThread): Fixes the error about the method not returning a value in the release-PGO build.
2009-07-31 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp
https://bugs.webkit.org/show_bug.cgi?id=27874
Use fastMalloc and fastFree instead of malloc and free in RegexInterpreter.cpp's methods.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::freeDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
2009-07-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
Fix compiler warning.
GCC does not like C++-style comments in preprocessor directives.
* wtf/Platform.h:
2009-07-30 John McCall <rjmccall@apple.com>
Reviewed by Gavin Barraclough.
Optimize the X86_64 trampolines: avoid the need for filler arguments
and move the stub-args area closer to the stack pointer.
* jit/JIT.h: adjust patch offsets because of slight code-size change
* jit/JITCode.h:
(JSC::JITCode::execute): don't pass filler args
* jit/JITStubs.cpp:
(ctiTrampoline): (X86_64): push args onto stack, use args directly
(ctiVMThrowTrampoline): (X86_64): adjust %rsp by correct displacement
(ctiOpThrowNotCaught): (X86_64): adjust %rsp by correct displacement
* jit/JITStubs.h:
(JITStackFrame): (X86_64): move args area earlier
(ctiTrampoline): remove filler args from prototype
2009-07-30 Gavin Barraclough <barraclough@apple.com>
Temporarily revert r46618 since this is b0rking on Linux.
2009-07-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( https://bugs.webkit.org/show_bug.cgi?id=27635 )
This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).
* bytecode/CodeBlock.cpp:
(JSC::printStructureStubInfo):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
* bytecode/CodeBlock.h:
(JSC::):
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
- Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::seenOnce):
(JSC::StructureStubInfo::setSeen):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::unlinkCall):
- Remove the "don't lazy link" stage of calls.
* jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
- Remove the "don't lazy link" stage of calls.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSlowCase):
- Remove the "don't lazy link" stage of calls.
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
(JSC::JITStubs::getPolymorphicAccessStructureListSlot):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
* jit/JITStubs.h:
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITStubs::):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
* wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
(WTF::PtrAndFlags::operator!):
(WTF::PtrAndFlags::operator->):
- Add ! and -> operators, add constuctor with pointer argument.
2009-07-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Fixed failing tests seen on Windows buildbot.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::): Use "int" instead of "bool" to guarantee a 32-bit result,
regardless of compiler. gcc on mac uses 32-bit values for bool,
but gcc on linux and MSVC on Windows use 8-bit values.
2009-07-30 Geoffrey Garen <ggaren@apple.com>
Windows build fix: added missing symbols on Windows.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-07-30 Geoffrey Garen <ggaren@apple.com>
Windows build fix: removed stale symbols on Windows.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
=== End merge of nitro-extreme branch 2009-07-30 ===
2009-07-20 Geoffrey Garen <ggaren@apple.com>
Fixed a post-review typo in r46066 that caused tons of test failures.
SunSpider reports no change.
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray): Initialize the full vector capacity, to avoid
uninitialized members at the end.
2009-07-20 Geoffrey Garen <ggaren@apple.com>
Windows WebKit build fix: Added some missing exports.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Get the branch working on windows.
https://bugs.webkit.org/show_bug.cgi?id=27391
SunSpider says 0.3% faster.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Updated
MSVC export lists to fix linker errors.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added / removed
new / old project files.
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines): Used #pragma pack to tell
MSVC that these structures represent actual memory layout, and should not be
automatically aligned. Changed the return value load to load a 64bit quantity
into the canonical registers.
* jit/JIT.h: Moved OBJECT_OFFSETOF definition to StdLibExtras.h because
it's needed by more than just the JIT, and it supplements a standard library
macro (offsetof).
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame): Fixed an incorrectly signed
cast to resolve an MSVC warning.
* jit/JITStubs.h: Used #pragma pack to tell MSVC that these structures
represent actual memory layout, and should not be automatically aligned.
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray): Replaced memset_pattern8 with a for loop, since
memset_pattern8 is not portable. (I verified that this version of the loop
gives the best performance / generated code in GCC.)
* runtime/JSObject.h:
(JSC::JSObject::JSObject): Removed accidental usage of FIELD_OFFSET --
OBJECT_OFFSETOF is our new macro name. (FIELD_OFFSET conflicts with a
definition in winnt.h.)
* runtime/JSValue.cpp: Added some headers needed by non-all-in-one builds.
* runtime/JSValue.h:
(JSC::JSValue::): Made the tag signed, to match MSVC's signed enum values.
(GCC doesn't seem to care one way or the other.)
* wtf/MainThread.cpp: Moved the StdLibExtras.h #include -- I did this a
while ago to resolve a conflict with winnt.h. I can't remember if it's truly
still needed, but what the heck.
* wtf/StdLibExtras.h: Moved OBJECT_OFFSETOF definition here.
2009-07-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig (?).
Fixed an assertion seen during the stress test.
Don't assume that, if op1 is constant, op2 is not, and vice versa. Sadly,
not all constants get folded.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
2009-07-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Include op_convert_this in result caching.
No change on SunSpider or v8.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_convert_this):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::): Made the op_convert_this JIT stub return an EncodedJSValue, so
to maintain the result caching contract that { tag, payload } can be
found in { regT1, regT0 }.
2009-07-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented result chaining.
1% faster on SunSpider. 4%-5% faster on v8.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::move):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movl_rr): Added an optimization to eliminate
no-op mov instructions, to simplify chaining.
* jit/JIT.cpp:
(JSC::JIT::JIT):
* jit/JIT.h: Added data members and helper functions for recording
chained results. We record both a mapping from virtual to machine register
and the opcode for which the mapping is valid, to help ensure that the
mapping isn't used after the mapped register has been stomped by other
instructions.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_construct_verify):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase): Chain function call results.
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
(JSC::JIT::isLabeled):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag): Use helper functions when loading virtual
registers into machine registers, in case the loads can be eliminated
by chaining.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_catch): Chain results from these opcodes.
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call): Load the profiler into regT2 to
avoid stomping a chained result.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_by_id): Chain results from these opcodes.
* jit/JITStubCall.h:
(JSC::JITStubCall::addArgument): Always use { regT1, regT0 }, to facilitate
chaining.
(JSC::JITStubCall::call): Unmap all mapped registers, since our callee
stub might stomp them.
2009-07-01 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Don't reload values in emitBinaryDoubleOp.
SunSpider reports a 0.6% progression.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):
2009-07-01 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Convert op_div to load op1 and op2 up front.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_div):
2009-07-01 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Don't emit code in emitBinaryDoubleOp if code is unreachable, observable
via an empty (unlinked) jumplist passed in. This only effects op_jnless
and op_jnlesseq at present.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitBinaryDoubleOp):
2009-07-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Converted op_mod to put { tag, payload } in { regT1, regT0 }, and
tidied up its constant case.
SunSpider reports a 0.2% regression, but a micro-benchmark of op_mod
shows a 12% speedup, and the SunSpider test that uses op_mod most should
benefit a lot from result caching in the end, since it almost always
performs (expression) % constant.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
2009-06-30 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Converted some more arithmetic ops to put { tag, payload } in
{ regT1, regT0 }.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Converted some more arithmetic ops to put { tag, payload } in
{ regT1, regT0 }, and added a case for subtract constant.
SunSpider says no change. v8 says 0.3% slower.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSub32Constant):
(JSC::JIT::emitSlow_op_sub):
2009-06-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove more uses of addressFor(), load double constants directly from
the constantpool in the CodeBlock, rather than from the register file.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitBinaryDoubleOp):
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a bug in postfix ops, where we would treat x = x++ and x = x--
as a no-op, even if x were not an int, and the ++/-- could have side-effects.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emitSlow_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emitSlow_op_post_dec):
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Converted some arithmetic ops to put { tag, payload } in
{ regT1, regT0 }.
SunSpider says 0.7% faster. v8 says no change.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
* jit/JITInlineMethods.h:
(JSC::JIT::isOperandConstantImmediateInt):
(JSC::JIT::getOperandConstantImmediateInt):
2009-06-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Start removing cases of addressFor().
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_div):
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitStoreDouble):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Rolled back in my last patch with regression fixed.
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Rolled out my last patch because it was a 2% SunSpider regression.
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin "Sam Weinig" Barraclough.
Standardized the rest of our opcodes to put { tag, payload } in
{ regT1, regT0 } where possible.
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
2009-06-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Replace calls to store32(tagFor()) and store32(payloadFor())
with emitStoreInt32(), emitStoreBool(), and emitStoreCell().
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitBitAnd32Constant):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitBitOr32Constant):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitBitXor32Constant):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSub32ConstantLeft):
(JSC::JIT::emitSub32ConstantRight):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
(JSC::JIT::emit_op_mod):
* jit/JITCall.cpp:
(JSC::JIT::emit_op_load_varargs):
* jit/JITInlineMethods.h:
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitStore):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JITStubCall.h:
(JSC::JITStubCall::call):
2009-06-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized the rest of the property access instructions to put { tag,
payload } in { regT1, regT0 }.
Small v8 speedup, 0.2% SunSpider slowdown.
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchPutByIdReplace):
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Various cleanups.
- Use fpRegT* instead of X86::xmm*.
- Use a switch statement in emitBinaryDoubleOp instead of a bunch of
if/elses.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_div):
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add inline code dealing with doubles for op_jfalse and op_jtrue.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::):
(JSC::MacroAssemblerX86Common::zeroDouble):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
2009-06-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized op_get_by_id to put { tag, payload } in { regT1, regT0 }.
SunSpider and v8 report maybe 0.2%-0.4% regressions, but the optimization
this enables will win much more than that back.
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
2009-06-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Standardized op_call to put { tag, payload } in { regT1, regT0 }.
SunSpider and v8 report no change.
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::compileOpCallVarargsSetupArgs):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
2009-06-26 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Handle multiplying by zero a little better by
inlining the case that both operands are non-negative
into the slowpath.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchOr32):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Optimize x++ to ++x inside for loops.
Sadly, no measurable speedup, but this should help with result chaining.
* parser/Nodes.cpp:
(JSC::ForNode::emitBytecode):
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_bitnot):
(JSC::JIT::emit_op_post_inc):
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emitSlow_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emitSlow_op_pre_dec):
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
* jit/JITCall.cpp:
(JSC::JIT::emit_op_construct_verify):
(JSC::JIT::emitSlow_op_construct_verify):
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_true):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig (sort of, maybe).
Fixed some ASSERTs in http/tests/security.
These ASSERTs were introduced by http://trac.webkit.org/changeset/45057,
but the underlying problem was actually older. http://trac.webkit.org/changeset/45057
just exposed the problem by enabling optimization in more cases.
The ASSERTs fired because we tested PropertySlot::slotBase() for validity,
but slotBase() ASSERTs if it's invalid, so we would ASSERT before
the test could happen. Solution: Remove the ASSERT. Maybe it was valid
once, but it clearly goes against a pattern we've deployed of late.
The underlying problem was that WebCore would re-use a PropertySlot in
the case of a forwarding access, and the second use would not completely
overwrite the first use. Solution: Make sure to overwrite m_offset when
setting a value on a PropertySlot. (Other values already get implicitly
overwritten during reuse.)
* runtime/PropertySlot.h:
(JSC::PropertySlot::PropertySlot):
(JSC::PropertySlot::setValueSlot):
(JSC::PropertySlot::setValue):
(JSC::PropertySlot::setRegisterSlot):
(JSC::PropertySlot::setUndefined):
(JSC::PropertySlot::slotBase):
(JSC::PropertySlot::clearOffset):
2009-06-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Enable JIT_OPTIMIZE_METHOD_CALLS on the branch, implementation matches current implemenatation in ToT.
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::compileGetByIdSlowCase):
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Bit off a tiny bit more of standardizing opcode behavior to help with result
caching.
SunSpider reports no change, v8 maybe a tiny speedup.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emitSlow_op_to_jsnumber):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Bit off a tiny bit more of standardizing opcode behavior to help with result
caching -- including removing my old enemy, op_resolve_function, because
it was non-standard, and removing it felt better than helping it limp along.
SunSpider reports no change, v8 maybe a tiny speedup.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
* bytecompiler/BytecodeGenerator.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emitSlow_op_to_primitive):
* jit/JITStubs.cpp:
* jit/JITStubs.h:
* parser/Nodes.cpp:
(JSC::FunctionCallResolveNode::emitBytecode):
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Bit off a tiny bit of standardizing opcode behavior to help with result
caching.
0.6% SunSpider speedup. 0.3% v8 speedup.
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoad): Accomodate a base register that overlaps with payload
by loading tag before payload, to avoid stomping base/payload.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_mov): Abide by the standard "tag in regT1, payload in
regT0" semantics.
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var): Ditto. Also, removed some irrelevent
loads while I was at it. The global object's "d" pointer never changes
after construction.
2009-06-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove 'arguments' field from Register union (again).
This time do so without breaking tests (radical, I know).
* interpreter/CallFrame.h:
(JSC::ExecState::optionalCalleeArguments):
(JSC::ExecState::setArgumentCount):
(JSC::ExecState::init):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):
* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::):
(JSC::Register::Register):
(JSC::Register::i):
* jit/JITStubs.cpp:
(JSC::JITStubs::cti_op_tear_off_arguments):
* runtime/Arguments.h:
(JSC::JSActivation::copyRegisters):
(JSC::Register::arguments):
* runtime/JSActivation.cpp:
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some result register tracking cruft in preparation for a new
result tracking mechanism.
SunSpider reports no change.
* assembler/AbstractMacroAssembler.h:
* assembler/X86Assembler.h:
(JSC::X86Assembler::JmpDst::JmpDst): No need to track jump targets in
machine code; we already do this in bytecode.
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::emitTimeoutCheck): Make sure to save and restore the result
registers, so an opcode with a timeout check can still benefit from result
register caching.
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases): Removed calls to killLastResultRegister()
in preparation for something new.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
* jit/JITInlineMethods.h:
(JSC::JIT::emitGetFromCallFrameHeaderPtr):
(JSC::JIT::emitGetFromCallFrameHeader32):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_sret):
(JSC::JIT::emit_op_jmp_scopes): ditto
* jit/JITStubCall.h:
(JSC::JITStubCall::JITStubCall):
(JSC::JITStubCall::getArgument): added a mechanism for reloading an argument
you passed to a JIT stub, for use in emitTimeoutCheck.
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove now-useless inplace variants of binary ops.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emit_op_mul):
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Move off memory operands to aid in re-enabling result caching.
- No regression measured.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitBitAnd32Constant):
(JSC::JIT::emitBitAnd32InPlace):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitBitOr32Constant):
(JSC::JIT::emitBitOr32InPlace):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitBitXor32Constant):
(JSC::JIT::emitBitXor32InPlace):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emitSlow_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emitSlow_op_pre_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitAdd32InPlace):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlowAdd32Constant):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSub32ConstantLeft):
(JSC::JIT::emitSub32ConstantRight):
(JSC::JIT::emitSub32InPlaceLeft):
(JSC::JIT::emitSub32InPlaceRight):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitMul32InPlace):
(JSC::JIT::emit_op_div):
(JSC::JIT::emit_op_mod):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargs):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emit_op_to_jsnumber):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some missing and/or misplaced labels in bytecode generation, so
we don't have to work around them in JIT code generation.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpSubroutine):
* parser/Nodes.cpp:
(JSC::TryNode::emitBytecode):
2009-06-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
For member function calls, emit "this" directly into the "this" slot
for the function call, instead of moving it there later. This reduces
time spent in op_mov during certain calls, like "a.b.c()".
1%-2% speedup on v8, mostly richards and delta-blue.
* parser/Nodes.cpp:
(JSC::FunctionCallDotNode::emitBytecode):
2009-06-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove 'arguments' field from Register union. Having JSCell derived types in the union is
dangerous since it opens the possibility for the field to be written as a raw pointer but
then read as a JSValue. This will lead to statle data being read for the tag, which may
be dangerous. Having removed Arguments* types form Register, all arguments objects must
always explicitly be stored in the register file as JSValues.
* interpreter/CallFrame.h:
(JSC::ExecState::optionalCalleeArguments):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):
* interpreter/Register.h:
(JSC::Register::):
* jit/JITStubs.cpp:
(JSC::JITStubs::cti_op_tear_off_arguments):
* runtime/Arguments.h:
(JSC::JSActivation::copyRegisters):
* runtime/JSActivation.cpp:
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
2009-06-03 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add back known this value optimization by abstracting
slow case if not JSCell jumps.
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):
(JSC::JIT::linkSlowCaseIfNotJSCell):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
2009-06-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some of the regression in crypto-aes.js. (8.5% speedup in
crypto-aes.js.)
SunSpider reports no change overall.
Division was producing double results, which took the slow path through
array access code.
Strangely, all my attempts at versions of this patch that modified array
access code to accept ints encoded as doubles along the fast or slow paths
were regressions. So I did this instead.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_div): When dividing an int by an int, go ahead and try
to turn the result into an int. Don't just do int division, though, because
testing shows it to be slower than SSE double division, and the corner
cases are pretty complicated / lengthy on top of that. Also, don't try
to canonicalize division of known tiny numerators into ints, since that's a
waste of time.
2009-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed a regression caused by my recent fix for NaN.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitBinaryDoubleOp): Actually do the comparison in reverse
order, like the ChangeLog said we would, bokay?
2009-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig and Oliver Hunt.
Fixed two edge cases in %:
- Don't do -2147483648 % x as a fast case, since you might do -2147483648 % -1,
which will signal a hardware exception due to overflow.
- In the case of a zero remainder, be sure to store negative zero if the
dividend was zero.
SunSpider reports no change.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Fixed a regression when comparing to NaN.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitBinaryDoubleOp): For op_jnless and op_jnless_eq, do the
comparison in reverse order, and jump if the result is below or
below-or-equal. This ensures that we do jump in the case of NaN.
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
SunSpider says no change.
Fixed regressions in fast/js/var-declarations-shadowing.html and
fast/js/equality.html, caused by recent == and != optimizations.
* jit/JITStubs.cpp:
(JSC::JITStubs::cti_op_eq): Don't treat "compare to string" as always
numeric or string comparison. If the second operand is an object, you
need to ToPrimitive it, and start all over again. Also, I wrote out each
of the possible cases explicitly, to cut down on redundant branching.
2009-05-25 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix bug in fast/js/constant-folding.html where we were not negating
-0 properly.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
2009-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Refactored new slow case codegen for == and !=.
SunSpider reports no change, maybe a tiny speedup.
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq): Made a vptr comparison a *Ptr operation,
instead of *32, to make it portable to 64bit. Reorganized the string
and generic cases to make their control flow a little clearer.
2009-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Optimized == and != for our new value representation -- especially for strings.
14% speedup on date-format-tofte.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
* jit/JITStubCall.h:
(JSC::JITStubCall::JITStubCall):
* jit/JITStubs.cpp:
(JSC::JITStubs::cti_op_eq):
(JSC::JITStubs::cti_op_eq_strings):
(JSC::JITStubs::cti_op_call_eval):
* jit/JITStubs.h:
(JSC::):
* runtime/JSValue.h:
2009-05-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix non-SSE enabled builds.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_add): Don't early return here, we still need to call the JIT stub.
(JSC::JIT::emitSlow_op_sub): Ditto.
2009-05-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Here's a thought: let's not take a jit stub call just to multiply by 1,
bokay?
imul doesn't set the zero flag, so to test for a zero result, we need
an explicit instruction. (Luckily, it does set the overflow flag, so
we can still use that.)
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitMul32InPlace):
2009-05-22 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "Premature Commit" Garen.
Add back constant integer cases for op_add.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlowAdd32Constant):
* jit/JITInlineMethods.h:
(JSC::JIT::getConstantOperandImmediateDouble):
(JSC::JIT::isOperandConstantImmediateDouble):
2009-05-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added fast double cases for op_jnless and op_jnlesseq.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::JumpList::jumps): New accesor, used by
addSlowCase.
* assembler/X86Assembler.h:
(JSC::X86Assembler::ucomisd_rm): New method for comparing register to
memory.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div): Modified emitBinaryDoubleOp to accept comparison/jump
operations in addition to operations with explicit result registers.
* jit/JITInlineMethods.h:
(JSC::JIT::addSlowCase): Added an "addSlowCase" for JumpLists, so clients
can track multiple jumps to the same slow case condition together.
2009-05-21 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Implement op_negate inline fast cases.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::neg32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::):
(JSC::X86Assembler::negl_m):
(JSC::X86Assembler::xorpd_rr):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Update the patchOffsetGetByIdSlowCaseCall constant for the
case that OPCODE_SAMPLING is enabled.
* jit/JIT.h:
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for inline subtraction of doubles.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSlowSub32InPlaceLeft):
(JSC::JIT::emitBinaryDoubleOp):
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Added support for inline division.
* assembler/X86Assembler.h:
(JSC::X86Assembler::):
(JSC::X86Assembler::divsd_rr):
(JSC::X86Assembler::divsd_mr):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitBinaryOp):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_div):
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for inline addition of doubles.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlowAdd32InPlace):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Factored inline double operations into a helper function, so that we
can reuse this code for other math operations.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for inline multiplication of doubles.
* assembler/X86Assembler.h:
(JSC::X86Assembler::cvtsi2sd_mr): New function, useful for loading an
int32 into a double register.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul): Filled out these cases for double arithmetic.
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::addressFor): New function, useful for addressing a JSValue's
full 64bits as a double.
2009-05-19 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement and enable optimized calls.
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines): Add ENABLE(JIT_OPTIMIZE_CALL) guards
around the the optimize call only trampolines (virtualCallPreLink and virtualCallLink).
Update the trampolines to account for the new JSValue representation.
(JSC::JIT::unlinkCall): Use NULL instead of JSValue noValue.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall): Update to account for the new JSValue representation
(JSC::JIT::compileOpCallSlowCase): Ditto.
* jit/JITStubs.h: Remove incorrect !ENABLE(JIT_OPTIMIZE_CALL) guard.
* wtf/Platform.h: Enable ENABLE_JIT_OPTIMIZE_CALL.
2009-05-19 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement and enable optimized property access.
* assembler/AbstractMacroAssembler.h: Fix comment.
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines): Remove array length trampoline
and implement the string length trampoline.
* jit/JIT.h: Add new constants for patch offsets.
* jit/JITInlineMethods.h: Remove FIELD_OFFSET which is now in StdLibExtras.h.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubCall.h:
(JSC::JITStubCall::addArgument): Add version of addArgument that takes
two registers for the tag and payload.
* jit/JITStubs.cpp:
(JSC::JITStubs::JITStubs): Remove array length trampoline pointer.
(JSC::JITStubs::cti_op_get_by_id_self_fail):
* jit/JITStubs.h:
* runtime/JSObject.h:
(JSC::JSObject::JSObject): Move m_inheritorID below the property storage
to align it to a 16 byte boundary.
* wtf/Platform.h: Enable ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
* wtf/StdLibExtras.h: Move FIELD_OFFSET here.
2009-05-17 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove unneeded ExecState parameter from the number JSValue constructors.
* runtime/JSValue.h:
(JSC::jsNumber):
(JSC::jsNaN):
(JSC::JSValue::JSValue):
2009-05-15 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implemented fast path for op_put_by_val when putting to arrays.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
2009-05-15 Geoffrey Garen <ggaren@apple.com> (Mostly by Sam)
Reviewed by Sam Weinig.
Implemented fast path for op_get_by_val when accessing array.
* jit/JIT.cpp:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a failure in fast/js/math-transforms.html caused by failing to
preserve -0 in multiplication.
* assembler/X86Assembler.h:
(JSC::X86Assembler::jz):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitMul32Constant):
(JSC::JIT::emitMul32InPlace): Check both for overflow and for zero when
doing multiplication. Use a slow case to get these right.
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a bug in the varargs calling convention.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargs): Move the argument count into regT1,
since that's where ctiVirtualCall expects it to be.
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a small bug in instanceof's looping code.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof): NULL means the object has no prototype,
so only loop when *not* equal to NULL.
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a small bug in instanceof's result writing code.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof): Make sure to fill out the payload bits
in all cases.
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Removed an invalid assertion in cti_op_urshift which
depended on a fast path for op_urshift which has
never existed.
* jit/JITStubs.cpp:
(JSC::JITStubs::cti_op_urshift):
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed loop_if_true, which had the same reversed test that jtrue had.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_true):
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
In op_neq, we apparently want to check that one value
does *not* equal another. Go figure.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_neq):
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
The slow case of op_mod should call op_mod's jit stub,
not op_mul. That would be dumb.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed problems when using 'arguments' due to a half-initialized register.
* interpreter/CallFrame.h:
(JSC::ExecState::setCalleeArguments):
(JSC::ExecState::init): Require a full JSValue when setting up the
'arguments' virtual register, since this register is accessible from JIT
code and bytecode, and needs to be a true JSValue.
* interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::resetCallFrame): ditto
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): ditto
* interpreter/Register.h: Removed the constructor that allowed assignment
of a JSArguments* to a register. That is not safe. See above.
* jit/JITStubs.cpp:
(JSC::JITStubs::cti_op_create_arguments):
(JSC::JITStubs::cti_op_create_arguments_no_params): ditto
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
We really want to go to the slow case in op_jfalse and
op_jtrue if the value is *not* boolean.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Flipped the condition when emitting a an op_loop_if_less or op_loop_if_lesseq
if the first operand is a constant.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Added missing return in op_jnless and op_jnlesseq.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Load constants into the the register file as a temporary measure to
aid bring up. This allows us to use to treat constants like any
other virtual register.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_enter_with_activation):
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented op_strict_eq. Original patch by Snowy, by way of Sam and Gavin.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::set8): Added set8, since it's slightly
faster than set32, and the new value representation usually doesn't
need set32.
* jit/JIT.cpp:
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload): Added helper functions for dealing with
constants. Eventually, we should write special cases for all constants,
but these are helpful in the short term.
* jit/JITOpcodes.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq): teh opcodez.
* runtime/JSValue.h:
(JSC::JSValue::):
(JSC::JSValue::isDouble): Added a LowestTag for clarity.
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some bugs in host function calls.
testapi now passes!
* jit/JIT.cpp: Changed some registers around to avoid overwriting edx:eax,
which is how JSValues are now returned. Also changed the code that
passes thisValue to pass the full 64bits of the value. Also added
an #error compiler directive to other platform builds, since the JSValue
return signature probably won't return in edx:eax on those platforms,
and we'll have to investigate a solution.
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed parameters from functions that are intended never to use their
parameters.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Ported op_instance_of from TOT. It's basically the same, but some register
stuff changed to memory stuff.
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutJITStubArgFromVirtualRegister):
(JSC::JIT::emitStore): Changed to use helper functions.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof): Ported from TOT.
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Added a comment to explain an exception-handling subtelty that we found
hard to remember when reviewing my last patch.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented try/catch.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_throw): Updated to use JITStackFrame abstraction.
(JSC::JIT::emit_op_catch): Filled out.
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implemented op_loop_if_true, op_jfalse, op_jtrue, op_jeq_null and op_jneq_null
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_instanceof): Moved from below to be next to its
fast brother.
(JSC::JIT::emit_op_loop_if_true): Similar to the old version
in that it tries to do the integer case first and reduce the
number of jumps you might need to take.
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jfalse): Very similar to op_loop_if_true, only
the inverse and without a timeout check.
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emit_op_jtrue): Very similar to op_loop_if_true except
without the timeout check.
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emit_op_jeq_null): Very similar to the implementation
of op_eq, except it takes jumps instead of copying the condition
to a dst.
(JSC::JIT::emit_op_jneq_null): Ditto but for op_neq.
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented op_call_varargs.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargsSetupArgs):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::emit_op_call):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_load_varargs):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_construct):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jneq_ptr):
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented op_call_eval.
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallVarargsSetupArgs):
(JSC::JIT::compileOpCall):
* jit/JITStubCall.h:
(JSC::CallEvalJITStub::CallEvalJITStub):
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Implemented op_not. (Gavin did most of the work!)
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_not):
(JSC::JIT::emitSlow_op_not):
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented op_global_resolve.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq): Added back accidentally removed
early returns.
(JSC::JIT::emit_op_resolve_global):
* jit/JITStubs.cpp:
(JSC::JITStubs::cti_op_resolve_global): Pretty similar to the old code,
but we need two reads and a TimesEight step in order to account for the
64bit value size.
* jit/JITStubs.h:
(JSC::): Slightly tweaked this code to specialize for a JSGlobalObject*,
to avoid having to pass an irrelevant tag pointer to the stub.
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implemented op_to_jsnumber.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emitSlow_op_to_jsnumber):
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implemented op_convert_this.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):
2009-05-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Got basic JS function and constructor calls working.
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpCallVarargsSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_construct_verify):
(JSC::JIT::emitSlow_op_construct_verify):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::compileOpCall): Filled out these cases, with call_eval #if'd out.
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutJITStubArgFromVirtualRegister):
(JSC::JIT::emitLoad): Restored some legacy "*CTIArg*" functions,
since I wanted to avoid the complexity of revamping the API here while
trying to bring it up. Eventually, we should re-remove all of these functions.
(JSC::JIT::recordJumpTarget): Removed unnecessary macro cruft. You will
not silence me, Sam Weinig! The world will know that you are a crufty,
crufty, crufty programmer!!!
* jit/JITOpcodes.cpp:
* jit/JITStubs.cpp:
(JSC::):
* jit/JITStubs.h: Changed up some offsets in the JITStackFrame class, since
and off-by-one error was causing stack misalignment.
2009-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_eq_null and op_neq_null.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::set8):
(JSC::MacroAssemblerX86Common::setTest8):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_stricteq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emit_op_nstricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jsc.cpp:
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_new_error.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_error):
* jit/JITStubCall.h:
(JSC::JITStubCall::addArgument): Add a version of addArgument
that takes a constant JSValue.
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove now unused emitGetVariableObjectRegister and emitPutVariableObjectRegister.
* jit/JIT.cpp:
* jit/JIT.h:
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_to_primitive and op_next_pname.
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_construct_verify):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_loop_if_true):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_next_pname):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add op_get_global_var, op_put_global_var, emit_op_get_scoped_var, emit_op_put_scoped_var and
op_unexpected_load.
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::tagFor):
(JSC::JIT::payloadFor):
(JSC::JIT::emitLoad):
(JSC::JIT::emitStore):
(JSC::JIT::emitLoadReturnValue):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_unexpected_load):
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added overflow handling to op_sub.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSlowSub32InPlaceLeft):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove a function call by folding op_get_by_id and op_put_by_id into
their respective compile functions.
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Make JITStubCall work in 64bit by making the stack index
step dependent on the size of void*.
* jit/JITStubCall.h:
(JSC::JITStubCall::JITStubCall):
(JSC::JITStubCall::addArgument):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement simple version of property access opcodes
which just call a stub functions.
* jit/JITOpcodes.cpp:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter):
(JSC::JIT::emit_op_put_setter):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compilePutByIdHotPath):
* jit/JITStubCall.h:
(JSC::JITStubCall::addArgument):
* jsc.cpp:
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added work-around for XCode debugging echo problem.
* jsc.cpp:
(runInteractive):
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added overflow handling to op_add.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlowAdd32InPlace):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add slow cases for op_jnless or emit_op_jnlesseq.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add implementations for op_jnless, emit_op_jnlesseq, op_loop_if_less and op_loop_if_lesseq.
No slow cases for op_jnless or emit_op_jnlesseq yet.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emitSlow_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Turn the RECORD_JUMP_TARGET macro into an inline function.
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::recordJumpTarget):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_jmp_scopes):
2009-05-12 Sam Weinig <sam@webkit.org>
Add MacroAssemblerX86Common::set8 to fix the build.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::set8):
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added overflow recovery for pre_inc and pre_dec.
Turned some short-circuit code into early returns, as is the WebKit style.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emitSlow_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emitSlow_op_post_dec):
(JSC::JIT::emitSlow_op_pre_inc):
(JSC::JIT::emitSlow_op_pre_dec):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_jmp, op_loop, op_eq and op_neq.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_enter_with_activation):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement the slow cases for arithmetic opcodes.
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_bitnot):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emit_op_mod):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implement op_bitnot.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::not32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::notl_m):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_bitnot):
2009-05-12 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add arithmetic opcode implementations from the old nitro-extreme branch.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitBitAnd32Constant):
(JSC::JIT::emitBitAnd32InPlace):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitBitOr32Constant):
(JSC::JIT::emitBitOr32InPlace):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitBitXor32Constant):
(JSC::JIT::emitBitXor32InPlace):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emitSlow_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emitSlow_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emitSlow_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emitSlow_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emitSlow_op_pre_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitAdd32InPlace):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSub32ConstantLeft):
(JSC::JIT::emitSub32ConstantRight):
(JSC::JIT::emitSub32InPlaceLeft):
(JSC::JIT::emitSub32InPlaceRight):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitMul32Constant):
(JSC::JIT::emitMul32InPlace):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
* jit/JITOpcodes.cpp:
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Removed JIT_OPTIMIZE_ARITHMETIC setting, since it was all about 32bit
value representations.
Added JSAPIValueWrapper to the repository.
* jit/JIT.h:
* jit/JITArithmetic.cpp:
* runtime/JSAPIValueWrapper.cpp: Added.
(JSC::JSAPIValueWrapper::toPrimitive):
(JSC::JSAPIValueWrapper::getPrimitiveNumber):
(JSC::JSAPIValueWrapper::toBoolean):
(JSC::JSAPIValueWrapper::toNumber):
(JSC::JSAPIValueWrapper::toString):
(JSC::JSAPIValueWrapper::toObject):
* runtime/JSAPIValueWrapper.h: Added.
(JSC::JSAPIValueWrapper::value):
(JSC::JSAPIValueWrapper::isAPIValueWrapper):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
(JSC::jsAPIValueWrapper):
* wtf/Platform.h:
2009-05-12 Geoffrey Garen <ggaren@apple.com>
Turned on the JIT and got it building and running the most trivial of
programs.
All configurable optimizations are turned off, and a few opcodes are ad
hoc #if'd out.
So far, I've only merged op_mov and op_end, but some stub-reliant
opcodes work as-is from TOT.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
* bytecode/CodeBlock.h:
* jit/JIT.cpp:
(JSC::JIT::compileOpStrictEq):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emitSlow_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emitSlow_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emitSlow_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emitSlow_op_pre_dec):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emit_op_add):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_sub):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::getConstantOperandImmediateInt):
(JSC::JIT::isOperandConstantImmediateInt):
(JSC::JIT::emitInitRegister):
(JSC::JIT::addSlowCase):
(JSC::JIT::addJump):
(JSC::JIT::emitJumpSlowToHot):
(JSC::JIT::tagFor):
(JSC::JIT::payloadFor):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoadReturnValue):
(JSC::JIT::emitStore):
(JSC::JIT::emitStoreReturnValue):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_loop):
(JSC::JIT::emit_op_loop_if_less):
(JSC::JIT::emit_op_loop_if_lesseq):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_construct_verify):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_loop_if_true):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_unexpected_load):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_push_scope):
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_push_new_scope):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_new_error):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
(JSC::JIT::emitSlow_op_construct_verify):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_loop_if_less):
(JSC::JIT::emitSlow_op_loop_if_lesseq):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_instanceof):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter):
(JSC::JIT::emit_op_put_setter):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compilePutByIdHotPath):
* jit/JITStubCall.h:
(JSC::JITStubCall::JITStubCall):
(JSC::JITStubCall::addArgument):
(JSC::JITStubCall::call):
(JSC::JITStubCall::):
(JSC::CallEvalJITStub::CallEvalJITStub):
* jit/JITStubs.cpp:
(JSC::):
(JSC::JITStubs::cti_op_add):
(JSC::JITStubs::cti_op_pre_inc):
(JSC::JITStubs::cti_op_mul):
(JSC::JITStubs::cti_op_get_by_val):
(JSC::JITStubs::cti_op_get_by_val_string):
(JSC::JITStubs::cti_op_get_by_val_byte_array):
(JSC::JITStubs::cti_op_sub):
(JSC::JITStubs::cti_op_put_by_val):
(JSC::JITStubs::cti_op_put_by_val_array):
(JSC::JITStubs::cti_op_put_by_val_byte_array):
(JSC::JITStubs::cti_op_negate):
(JSC::JITStubs::cti_op_div):
(JSC::JITStubs::cti_op_pre_dec):
(JSC::JITStubs::cti_op_post_inc):
(JSC::JITStubs::cti_op_eq):
(JSC::JITStubs::cti_op_lshift):
(JSC::JITStubs::cti_op_bitand):
(JSC::JITStubs::cti_op_rshift):
(JSC::JITStubs::cti_op_bitnot):
(JSC::JITStubs::cti_op_mod):
(JSC::JITStubs::cti_op_neq):
(JSC::JITStubs::cti_op_post_dec):
(JSC::JITStubs::cti_op_urshift):
(JSC::JITStubs::cti_op_bitxor):
(JSC::JITStubs::cti_op_bitor):
(JSC::JITStubs::cti_op_switch_imm):
* jit/JITStubs.h:
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSFunction.cpp:
(JSC::JSFunction::~JSFunction):
* runtime/JSValue.h:
(JSC::JSValue::payload):
* wtf/Platform.h:
2009-05-07 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Add some new MacroAssembler and assembler functions that will be needed shortly.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::mul32):
(JSC::MacroAssemblerX86Common::neg32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::sub32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::):
(JSC::X86Assembler::addl_rm):
(JSC::X86Assembler::andl_mr):
(JSC::X86Assembler::andl_rm):
(JSC::X86Assembler::andl_im):
(JSC::X86Assembler::negl_r):
(JSC::X86Assembler::notl_r):
(JSC::X86Assembler::orl_rm):
(JSC::X86Assembler::orl_im):
(JSC::X86Assembler::subl_rm):
(JSC::X86Assembler::xorl_mr):
(JSC::X86Assembler::xorl_rm):
(JSC::X86Assembler::xorl_im):
(JSC::X86Assembler::imull_mr):
2009-05-11 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Remove the NumberHeap.
* JavaScriptCore.exp:
* runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::recordExtraCost):
(JSC::Heap::heapAllocate):
(JSC::Heap::markConservatively):
(JSC::Heap::sweep):
(JSC::Heap::collect):
(JSC::Heap::objectCount):
(JSC::Heap::statistics):
(JSC::typeName):
(JSC::Heap::isBusy):
* runtime/Collector.h:
(JSC::Heap::globalData):
* runtime/JSCell.h:
2009-05-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Land initial commit of new number representation for 32 bit platforms,
with JIT disabled.
* API/APICast.h:
(toJS):
(toRef):
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
(JSC::::toNumber):
(JSC::::toString):
* API/tests/testapi.c:
(EvilExceptionObject_convertToType):
* AllInOneFile.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::valueToSourceString):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::emitUnexpectedLoad):
(JSC::keyForImmediateSwitch):
* bytecompiler/BytecodeGenerator.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::privateExecute):
* parser/Nodes.cpp:
(JSC::ArrayNode::emitBytecode):
(JSC::processClauseList):
* runtime/ArgList.h:
* runtime/Collector.h:
(JSC::sizeof):
* runtime/DateMath.cpp:
* runtime/ExceptionHelpers.h:
* runtime/InitializeThreading.cpp:
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::isAPIValueWrapper):
(JSC::JSValue::isString):
(JSC::JSValue::isGetterSetter):
(JSC::JSValue::isObject):
(JSC::JSValue::getString):
(JSC::JSValue::getObject):
(JSC::JSValue::getCallData):
(JSC::JSValue::getConstructData):
(JSC::JSValue::getUInt32):
(JSC::JSValue::marked):
(JSC::JSValue::toPrimitive):
(JSC::JSValue::getPrimitiveNumber):
(JSC::JSValue::toBoolean):
(JSC::JSValue::toNumber):
(JSC::JSValue::toString):
(JSC::JSValue::needsThisConversion):
(JSC::JSValue::toThisString):
(JSC::JSValue::getJSNumber):
(JSC::JSValue::toObject):
(JSC::JSValue::toThisObject):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeForLookup):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
* runtime/JSImmediate.h:
* runtime/JSNumberCell.cpp: Removed.
* runtime/JSNumberCell.h: Removed.
* runtime/JSObject.h:
(JSC::JSValue::get):
(JSC::JSValue::put):
* runtime/JSString.h:
(JSC::JSValue::toThisJSString):
* runtime/JSValue.cpp:
(JSC::JSValue::toInteger):
(JSC::JSValue::toIntegerPreserveNaN):
(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::toThisObjectSlowCase):
(JSC::JSValue::synthesizeObject):
(JSC::JSValue::synthesizePrototype):
(JSC::JSValue::description):
(JSC::nonInlineNaN):
* runtime/JSValue.h:
(JSC::JSValue::):
(JSC::EncodedJSValueHashTraits::emptyValue):
(JSC::jsNaN):
(JSC::operator==):
(JSC::operator!=):
(JSC::toInt32):
(JSC::toUInt32):
(JSC::JSValue::encode):
(JSC::JSValue::decode):
(JSC::JSValue::JSValue):
(JSC::JSValue::operator bool):
(JSC::JSValue::operator==):
(JSC::JSValue::operator!=):
(JSC::JSValue::isUndefined):
(JSC::JSValue::isNull):
(JSC::JSValue::isUndefinedOrNull):
(JSC::JSValue::isCell):
(JSC::JSValue::isInt32):
(JSC::JSValue::isUInt32):
(JSC::JSValue::isDouble):
(JSC::JSValue::isTrue):
(JSC::JSValue::isFalse):
(JSC::JSValue::tag):
(JSC::JSValue::asInt32):
(JSC::JSValue::asUInt32):
(JSC::JSValue::asDouble):
(JSC::JSValue::asCell):
(JSC::JSValue::isNumber):
(JSC::JSValue::isBoolean):
(JSC::JSValue::getBoolean):
(JSC::JSValue::uncheckedGetNumber):
(JSC::JSValue::toJSNumber):
(JSC::JSValue::getNumber):
(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):
* runtime/Operations.h:
(JSC::JSValue::equal):
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqual):
(JSC::JSValue::strictEqualSlowCaseInline):
(JSC::jsLess):
(JSC::jsLessEq):
(JSC::jsAdd):
* runtime/PropertySlot.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
* wtf/Platform.h:
=== Start merge of nitro-extreme branch 2009-07-30 ===
2009-07-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by George Staikos.
Resolve class/struct mixup in forward declarations
https://bugs.webkit.org/show_bug.cgi?id=27708
* API/JSClassRef.h:
* bytecode/SamplingTool.h:
* interpreter/Interpreter.h:
* jit/JIT.h:
* profiler/ProfileGenerator.h:
* profiler/Profiler.h:
* runtime/ClassInfo.h:
* runtime/ExceptionHelpers.h:
* runtime/JSByteArray.h:
* runtime/JSCell.h:
* runtime/JSFunction.h:
* runtime/JSGlobalData.h:
* runtime/JSObject.h:
* runtime/JSString.h:
2009-07-28 Ada Chan <adachan@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27236
- Implement TCMalloc_SystemRelease and TCMalloc_SystemCommit for Windows.
- Use a background thread to periodically scavenge memory to release back to the system.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::runScavengerThread):
(WTF::TCMalloc_PageHeap::scavenge):
(WTF::TCMalloc_PageHeap::shouldContinueScavenging):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::GrowHeap):
(WTF::sleep):
(WTF::TCMalloc_PageHeap::scavengerThread):
* wtf/TCSystemAlloc.cpp:
(TCMalloc_SystemRelease):
(TCMalloc_SystemCommit):
* wtf/TCSystemAlloc.h:
2009-07-28 Xan Lopez <xlopez@igalia.com>
Add new files, fixes distcheck.
* GNUmakefile.am:
2009-07-28 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Determining whether to use JIT or interpreter
moved from JavaScriptCore.pri to Platform.h
* JavaScriptCore.pri:
* wtf/Platform.h:
2009-07-27 Brian Weinstein <bweinstein@apple.com>
Fix of misuse of sort command.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-07-27 Brian Weinstein <bweinstein@apple.com>
Build fix for Windows.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-07-27 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Oliver Hunt.
Fix tyop in JIT, renamed preverveReturnAddressAfterCall -> preserveReturnAddressAfterCall.
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::preserveReturnAddressAfterCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
2009-07-27 Alexey Proskuryakov <ap@webkit.org>
Gtk build fix.
* runtime/JSLock.cpp: (JSC::JSLock::JSLock): Fix "no threading" case.
2009-07-27 Alexey Proskuryakov <ap@webkit.org>
Release build fix.
* runtime/JSLock.h: (JSC::JSLock::~JSLock):
2009-07-27 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27735
Give a helpful name to JSLock constructor argument
* API/JSBase.cpp:
(JSGarbageCollect):
* API/JSContextRef.cpp:
* API/JSObjectRef.cpp:
(JSPropertyNameArrayRelease):
(JSPropertyNameAccumulatorAddName):
* JavaScriptCore.exp:
* jsc.cpp:
(functionGC):
(cleanupGlobalData):
(jscmain):
* runtime/Collector.cpp:
(JSC::Heap::destroy):
* runtime/JSLock.cpp:
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):
* runtime/JSLock.h:
(JSC::):
(JSC::JSLock::JSLock):
(JSC::JSLock::~JSLock):
2009-07-25 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for OpaqueJSPropertyNameArray struct
https://bugs.webkit.org/show_bug.cgi?id=27342
Inherits OpaqueJSPropertyNameArray struct from FastAllocBase because it has been
instantiated by 'new' JavaScriptCore/API/JSObjectRef.cpp:473.
* API/JSObjectRef.cpp:
2009-07-24 Ada Chan <adachan@apple.com>
In preparation for https://bugs.webkit.org/show_bug.cgi?id=27236:
Remove TCMALLOC_TRACK_DECOMMITED_SPANS. We'll always track decommitted spans.
We have tested this and show it has little impact on performance.
Reviewed by Mark Rowe.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::propagateDecommittedState):
(WTF::mergeDecommittedStates):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::IncrementalScavenge):
2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Darin Adler and Adam Barth.
Build fix for x86 platforms.
https://bugs.webkit.org/show_bug.cgi?id=27602
* jit/JIT.cpp:
2009-07-23 Kevin Ollivier <kevino@theolliviers.com>
wx build fix, adding missing header.
* jit/JIT.cpp:
2009-07-22 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
Add wince specific memory files into wtf/wince
https://bugs.webkit.org/show_bug.cgi?id=27550
* wtf/wince/FastMallocWince.h: Added.
* wtf/wince/MemoryManager.cpp: Added.
* wtf/wince/MemoryManager.h: Added.
2009-07-23 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Fix for missing mmap features in Symbian
https://bugs.webkit.org/show_bug.cgi?id=24540
Fix, conditionally for PLATFORM(SYMBIAN), as an alternative
to missing support for the MAP_ANON property flag in mmap.
It utilizes Symbian specific memory allocation features.
* runtime/Collector.cpp
2009-07-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once per repatch event.
( https://bugs.webkit.org/show_bug.cgi?id=27564 )
Currently we change permissions forwards and backwards for each instruction modified,
instead we should only change permissions once per complete repatching event.
2.5% progression running with ENABLE(ASSEMBLER_WX_EXCLUSIVE) enabled,
which recoups 1/3 of the penalty of running with this mode enabled.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::linkBranch):
- Replace usage of MakeWritable with cacheFlush.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::patchPointerInternal):
(JSC::ARMAssembler::repatchLoadPtrToLEA):
- Replace usage of MakeWritable with cacheFlush.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::relinkJump):
(JSC::ARMv7Assembler::relinkCall):
(JSC::ARMv7Assembler::repatchInt32):
(JSC::ARMv7Assembler::repatchPointer):
(JSC::ARMv7Assembler::repatchLoadPtrToLEA):
(JSC::ARMv7Assembler::setInt32):
- Replace usage of MakeWritable with cacheFlush.
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::performFinalization):
- Make explicit call to cacheFlush.
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
- Make size always available.
* assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::~RepatchBuffer):
- Add calls to MakeWritable & makeExecutable.
* assembler/X86Assembler.h:
(JSC::X86Assembler::relinkJump):
(JSC::X86Assembler::relinkCall):
(JSC::X86Assembler::repatchInt32):
(JSC::X86Assembler::repatchPointer):
(JSC::X86Assembler::repatchLoadPtrToLEA):
- Remove usage of MakeWritable.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getJITCode):
- Provide access to CodeBlock's JITCode.
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::makeExecutable):
(JSC::ExecutableAllocator::cacheFlush):
- Remove MakeWritable, make cacheFlush public.
* jit/JIT.cpp:
(JSC::ctiPatchNearCallByReturnAddress):
(JSC::ctiPatchCallByReturnAddress):
(JSC::JIT::privateCompile):
(JSC::JIT::unlinkCall):
(JSC::JIT::linkCall):
- Add CodeBlock argument to RepatchBuffer.
* jit/JIT.h:
- Pass CodeBlock argument for use by RepatchBuffer.
* jit/JITCode.h:
(JSC::JITCode::start):
(JSC::JITCode::size):
- Provide access to code start & size.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchMethodCallProto):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- Add CodeBlock argument to RepatchBuffer.
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
- Pass CodeBlock argument for use by RepatchBuffer.
2009-07-21 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Cache not only the structure of the method, but the
structure of its prototype as well.
https://bugs.webkit.org/show_bug.cgi?id=27077
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
* bytecode/CodeBlock.h:
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
2009-07-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Move call linking / repatching down from AbstractMacroAssembler into MacroAssemblerARCH classes.
( https://bugs.webkit.org/show_bug.cgi?id=27527 )
This allows the implementation to be defined per architecture. Specifically this addresses the
fact that x86-64 MacroAssembler implements far calls as a load to register, followed by a call
to register. Patching the call actually requires the pointer load to be patched, rather than
the call to be patched. This is implementation detail specific to MacroAssemblerX86_64, and as
such is best handled there.
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::linkCall):
(JSC::MacroAssemblerARM::repatchCall):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::linkCall):
(JSC::MacroAssemblerARMv7::repatchCall):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::linkCall):
(JSC::MacroAssemblerX86::repatchCall):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::linkCall):
(JSC::MacroAssemblerX86_64::repatchCall):
2009-07-21 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
Every wtf file includes other wtf files with <> style includes
except this one. Fix the exception.
* wtf/ByteArray.h:
2009-07-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
( https://bugs.webkit.org/show_bug.cgi?id=27485 )
This change is the first step in a process to move code that should be in
the architecture-specific MacroAssembler classes up out of Assmbler and
AbstractMacroAssembler.
* JavaScriptCore.xcodeproj/project.pbxproj:
- added new files
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::linkPointer):
- rename patchPointer to bring it in line with the current link/repatch naming scheme
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):
(JSC::ARMv7Assembler::relinkCall):
(JSC::ARMv7Assembler::repatchInt32):
(JSC::ARMv7Assembler::repatchPointer):
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::setPointer):
- rename patchPointer to bring it in line with the current link/repatch naming scheme
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::linkJump):
(JSC::AbstractMacroAssembler::linkCall):
(JSC::AbstractMacroAssembler::linkPointer):
(JSC::AbstractMacroAssembler::getLinkerAddress):
(JSC::AbstractMacroAssembler::getLinkerCallReturnOffset):
(JSC::AbstractMacroAssembler::repatchJump):
(JSC::AbstractMacroAssembler::repatchCall):
(JSC::AbstractMacroAssembler::repatchNearCall):
(JSC::AbstractMacroAssembler::repatchInt32):
(JSC::AbstractMacroAssembler::repatchPointer):
(JSC::AbstractMacroAssembler::repatchLoadPtrToLEA):
- remove the LinkBuffer/RepatchBuffer classes, but leave a set of (private, friended) methods to interface to the Assembler
* assembler/LinkBuffer.h: Added.
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::~LinkBuffer):
(JSC::LinkBuffer::link):
(JSC::LinkBuffer::patch):
(JSC::LinkBuffer::locationOf):
(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::returnAddressOffset):
(JSC::LinkBuffer::finalizeCode):
(JSC::LinkBuffer::finalizeCodeAddendum):
(JSC::LinkBuffer::code):
(JSC::LinkBuffer::performFinalization):
- new file containing the LinkBuffer class, previously a member of AbstractMacroAssembler
* assembler/RepatchBuffer.h: Added.
(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::relink):
(JSC::RepatchBuffer::repatch):
(JSC::RepatchBuffer::repatchLoadPtrToLEA):
(JSC::RepatchBuffer::relinkCallerToTrampoline):
(JSC::RepatchBuffer::relinkCallerToFunction):
(JSC::RepatchBuffer::relinkNearCallerToTrampoline):
- new file containing the RepatchBuffer class, previously a member of AbstractMacroAssembler
* assembler/X86Assembler.h:
(JSC::X86Assembler::linkJump):
(JSC::X86Assembler::linkCall):
(JSC::X86Assembler::linkPointerForCall):
(JSC::X86Assembler::linkPointer):
(JSC::X86Assembler::relinkJump):
(JSC::X86Assembler::relinkCall):
(JSC::X86Assembler::repatchInt32):
(JSC::X86Assembler::repatchPointer):
(JSC::X86Assembler::setPointer):
(JSC::X86Assembler::setInt32):
(JSC::X86Assembler::setRel32):
- rename patchPointer to bring it in line with the current link/repatch naming scheme
* jit/JIT.cpp:
(JSC::ctiPatchNearCallByReturnAddress):
(JSC::ctiPatchCallByReturnAddress):
- include new headers
- remove MacroAssembler:: specification from RepatchBuffer usage
* jit/JITPropertyAccess.cpp:
* yarr/RegexJIT.cpp:
- include new headers
2009-07-21 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>
Reviewed by David Levin.
Fixed #undef typo.
https://bugs.webkit.org/show_bug.cgi?id=27506
* bytecode/Opcode.h:
2009-07-21 Adam Roben <aroben@apple.com>
Roll out r46153, r46154, and r46155
These changes were causing build failures and assertion failures on
Windows.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSArray.cpp:
* runtime/StringPrototype.cpp:
* runtime/UString.cpp:
* runtime/UString.h:
* wtf/FastMalloc.cpp:
* wtf/FastMalloc.h:
* wtf/Platform.h:
* wtf/PossiblyNull.h: Removed.
2009-07-21 Roland Steiner <rolandsteiner@google.com>
Reviewed by David Levin.
Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324
* Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.
2009-07-20 Oliver Hunt <oliver@apple.com>
Build fix attempt #2
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-07-20 Oliver Hunt <oliver@apple.com>
Build fix attempt #1
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-07-20 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469
Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
* runtime/UString.cpp:
(JSC::allocChars):
(JSC::reallocChars):
(JSC::expandCapacity):
(JSC::UString::Rep::reserveCapacity):
(JSC::UString::expandPreCapacity):
(JSC::createRep):
(JSC::concatenate):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::append):
(JSC::UString::operator=):
* runtime/UString.h:
(JSC::UString::Rep::createEmptyBuffer):
* wtf/FastMalloc.cpp:
(WTF::tryFastZeroedMalloc):
(WTF::tryFastMalloc):
(WTF::tryFastCalloc):
(WTF::tryFastRealloc):
(WTF::TCMallocStats::tryFastMalloc):
(WTF::TCMallocStats::tryFastCalloc):
(WTF::TCMallocStats::tryFastRealloc):
* wtf/FastMalloc.h:
(WTF::TryMallocReturnValue::TryMallocReturnValue):
(WTF::TryMallocReturnValue::~TryMallocReturnValue):
(WTF::TryMallocReturnValue::operator Maybe<T>):
(WTF::TryMallocReturnValue::getValue):
* wtf/PossiblyNull.h:
(WTF::PossiblyNull::PossiblyNull):
(WTF::PossiblyNull::~PossiblyNull):
(WTF::PossiblyNull::getValue):
* wtf/Platform.h:
2009-07-20 Gavin Barraclough <barraclough@apple.com>
RS Oliver Hunt.
Add ARM assembler files to xcodeproj, for convenience editing.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-07-20 Jessie Berlin <jberlin@apple.com>
Reviewed by David Levin.
Fix an incorrect assertion in Vector::remove.
https://bugs.webkit.org/show_bug.cgi?id=27477
* wtf/Vector.h:
(WTF::::remove):
Assert that the position at which to start removing elements + the
length (the number of elements to remove) is less than or equal to the
size of the entire Vector.
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Allow custom memory allocation control in NewThreadContext
https://bugs.webkit.org/show_bug.cgi?id=27338
Inherits NewThreadContext struct from FastAllocBase because it
has been instantiated by 'new' JavaScriptCore/wtf/Threading.cpp:76.
* wtf/Threading.cpp:
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Allow custom memory allocation control in JavaScriptCore's JSClassRef.h
https://bugs.webkit.org/show_bug.cgi?id=27340
Inherit StaticValueEntry and StaticFunctionEntry struct from FastAllocBase because these
have been instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:153
and in JavaScriptCore/API/JSClassRef.cpp:166.
* API/JSClassRef.h:
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control in JavaScriptCore's RegexPattern.h
https://bugs.webkit.org/show_bug.cgi?id=27343
Inherits RegexPattern.h's structs (which have been instantiated by operator new) from FastAllocBase:
CharacterClass (new call: JavaScriptCore/yarr/RegexCompiler.cpp:144)
PatternAlternative (new call: JavaScriptCore/yarr/RegexPattern.h:221)
PatternDisjunction (new call: JavaScriptCore/yarr/RegexCompiler.cpp:446)
* yarr/RegexPattern.h:
2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's MatchFrame struct
https://bugs.webkit.org/show_bug.cgi?id=27344
Inherits MatchFrame struct from FastAllocBase because it has
been instantiated by 'new' JavaScriptCore/pcre/pcre_exec.cpp:359.
* pcre/pcre_exec.cpp:
2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Holger Freyther.
Remove some outdated S60 platform specific code
https://bugs.webkit.org/show_bug.cgi?id=27423
* wtf/Platform.h:
2009-07-20 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
Qt build fix with MSVC and MinGW.
* jsc.pro: Make sure jsc is a console application, and turn off
exceptions and stl support to fix the build.
2009-07-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not use C++-style comments in preprocessor directives.
GCC does not like this in some configurations, using C-style
comments is safer.
* wtf/Platform.h:
2009-07-17 Peter Kasting <pkasting@google.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add YARR support for generic ARM platforms (disabled by default).
https://bugs.webkit.org/show_bug.cgi?id=24986
Add generic ARM port for MacroAssembler. It supports the whole
MacroAssembler functionality except floating point.
The class JmpSrc is extended with a flag which enables to patch
the jump destination offset during execution. This feature is
required for generic ARM port.
Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>
* JavaScriptCore.pri:
* assembler/ARMAssembler.cpp: Added.
(JSC::ARMAssembler::getLdrImmAddress):
(JSC::ARMAssembler::linkBranch):
(JSC::ARMAssembler::patchConstantPoolLoad):
(JSC::ARMAssembler::getOp2):
(JSC::ARMAssembler::genInt):
(JSC::ARMAssembler::getImm):
(JSC::ARMAssembler::moveImm):
(JSC::ARMAssembler::dataTransfer32):
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h: Added.
(JSC::ARM::):
(JSC::ARMAssembler::ARMAssembler):
(JSC::ARMAssembler::):
(JSC::ARMAssembler::JmpSrc::JmpSrc):
(JSC::ARMAssembler::JmpSrc::enableLatePatch):
(JSC::ARMAssembler::JmpDst::JmpDst):
(JSC::ARMAssembler::JmpDst::isUsed):
(JSC::ARMAssembler::JmpDst::used):
(JSC::ARMAssembler::emitInst):
(JSC::ARMAssembler::and_r):
(JSC::ARMAssembler::ands_r):
(JSC::ARMAssembler::eor_r):
(JSC::ARMAssembler::eors_r):
(JSC::ARMAssembler::sub_r):
(JSC::ARMAssembler::subs_r):
(JSC::ARMAssembler::rsb_r):
(JSC::ARMAssembler::rsbs_r):
(JSC::ARMAssembler::add_r):
(JSC::ARMAssembler::adds_r):
(JSC::ARMAssembler::adc_r):
(JSC::ARMAssembler::adcs_r):
(JSC::ARMAssembler::sbc_r):
(JSC::ARMAssembler::sbcs_r):
(JSC::ARMAssembler::rsc_r):
(JSC::ARMAssembler::rscs_r):
(JSC::ARMAssembler::tst_r):
(JSC::ARMAssembler::teq_r):
(JSC::ARMAssembler::cmp_r):
(JSC::ARMAssembler::orr_r):
(JSC::ARMAssembler::orrs_r):
(JSC::ARMAssembler::mov_r):
(JSC::ARMAssembler::movs_r):
(JSC::ARMAssembler::bic_r):
(JSC::ARMAssembler::bics_r):
(JSC::ARMAssembler::mvn_r):
(JSC::ARMAssembler::mvns_r):
(JSC::ARMAssembler::mul_r):
(JSC::ARMAssembler::muls_r):
(JSC::ARMAssembler::mull_r):
(JSC::ARMAssembler::ldr_imm):
(JSC::ARMAssembler::ldr_un_imm):
(JSC::ARMAssembler::dtr_u):
(JSC::ARMAssembler::dtr_ur):
(JSC::ARMAssembler::dtr_d):
(JSC::ARMAssembler::dtr_dr):
(JSC::ARMAssembler::ldrh_r):
(JSC::ARMAssembler::ldrh_d):
(JSC::ARMAssembler::ldrh_u):
(JSC::ARMAssembler::strh_r):
(JSC::ARMAssembler::push_r):
(JSC::ARMAssembler::pop_r):
(JSC::ARMAssembler::poke_r):
(JSC::ARMAssembler::peek_r):
(JSC::ARMAssembler::clz_r):
(JSC::ARMAssembler::bkpt):
(JSC::ARMAssembler::lsl):
(JSC::ARMAssembler::lsr):
(JSC::ARMAssembler::asr):
(JSC::ARMAssembler::lsl_r):
(JSC::ARMAssembler::lsr_r):
(JSC::ARMAssembler::asr_r):
(JSC::ARMAssembler::size):
(JSC::ARMAssembler::ensureSpace):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::patchPointerInternal):
(JSC::ARMAssembler::patchConstantPoolLoad):
(JSC::ARMAssembler::patchPointer):
(JSC::ARMAssembler::repatchInt32):
(JSC::ARMAssembler::repatchPointer):
(JSC::ARMAssembler::repatchLoadPtrToLEA):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::relinkJump):
(JSC::ARMAssembler::linkCall):
(JSC::ARMAssembler::relinkCall):
(JSC::ARMAssembler::getRelocatedAddress):
(JSC::ARMAssembler::getDifferenceBetweenLabels):
(JSC::ARMAssembler::getCallReturnOffset):
(JSC::ARMAssembler::getOp2Byte):
(JSC::ARMAssembler::placeConstantPoolBarrier):
(JSC::ARMAssembler::RM):
(JSC::ARMAssembler::RS):
(JSC::ARMAssembler::RD):
(JSC::ARMAssembler::RN):
(JSC::ARMAssembler::getConditionalField):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::JmpSrc::enableLatePatch):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Call::enableLatePatch):
(JSC::AbstractMacroAssembler::Jump::enableLatePatch):
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h: Added.
(JSC::MacroAssemblerARM::):
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::mul32):
(JSC::MacroAssemblerARM::not32):
(JSC::MacroAssemblerARM::or32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::load32):
(JSC::MacroAssemblerARM::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::loadPtrWithPatchToLEA):
(JSC::MacroAssemblerARM::load16):
(JSC::MacroAssemblerARM::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::pop):
(JSC::MacroAssemblerARM::push):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::signExtend32ToPtr):
(JSC::MacroAssemblerARM::zeroExtend32ToPtr):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branch16):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::jump):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::mull32):
(JSC::MacroAssemblerARM::branchMul32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::breakpoint):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::ret):
(JSC::MacroAssemblerARM::set32):
(JSC::MacroAssemblerARM::setTest32):
(JSC::MacroAssemblerARM::tailRecursiveCall):
(JSC::MacroAssemblerARM::makeTailRecursiveCall):
(JSC::MacroAssemblerARM::moveWithPatch):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::storePtrWithPatch):
(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::storeDouble):
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARM::ARMCondition):
(JSC::MacroAssemblerARM::prepareCall):
(JSC::MacroAssemblerARM::call32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::JmpSrc::enableLatePatch):
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
* wtf/Platform.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):
2009-07-17 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Extend AssemblerBuffer with constant pool handling mechanism.
https://bugs.webkit.org/show_bug.cgi?id=24986
Add a platform independed constant pool framework.
This pool can store 32 or 64 bits values which is enough to hold
any integer, pointer or double constant.
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt64Unchecked):
(JSC::AssemblerBuffer::append):
(JSC::AssemblerBuffer::grow):
* assembler/AssemblerBufferWithConstantPool.h: Added.
(JSC::):
2009-07-17 Eric Roman <eroman@chromium.org>
Reviewed by Darin Adler.
Build fix for non-Darwin.
Add a guard for inclusion of RetainPtr.h which includes CoreFoundation.h
https://bugs.webkit.org/show_bug.cgi?id=27382
* wtf/unicode/icu/CollatorICU.cpp:
2009-07-17 Alexey Proskuryakov <ap@webkit.org>
Reviewed by John Sullivan.
Get user default collation order via a CFLocale API when available.
* wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):
2009-07-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358
* JavaScriptCore.pri:
2009-07-17 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by David Levin.
Build fix on platforms don't have MMAP.
https://bugs.webkit.org/show_bug.cgi?id=27365
* interpreter/RegisterFile.h: Including stdio.h irrespectively of HAVE(MMAP)
2009-07-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
https://bugs.webkit.org/show_bug.cgi?id=27206
Add ENABLE_WEB_SOCKETS
* Configurations/FeatureDefines.xcconfig: add ENABLE_WEB_SOCKETS
2009-07-16 Maxime Simon <simon.maxime@gmail.com>
Reviewed by Eric Seidel.
Added Haiku-specific files for JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=26620
* wtf/haiku/MainThreadHaiku.cpp: Added.
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
2009-07-16 Gavin Barraclough <barraclough@apple.com>
RS by Oliver Hunt.
Revert r45969, this fix does not appear to be valid.
https://bugs.webkit.org/show_bug.cgi?id=27077
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::unlinkCallers):
* jit/JIT.cpp:
* jit/JIT.h:
2009-07-16 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Allow custom memory allocation control in ExceptionInfo and RareData struct
https://bugs.webkit.org/show_bug.cgi?id=27336
Inherits ExceptionInfo and RareData struct from FastAllocBase because these
have been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.cpp:1289 and
in JavaScriptCore/bytecode/CodeBlock.h:453.
Remove unnecessary WTF:: namespace from CodeBlock inheritance.
* bytecode/CodeBlock.h:
2009-07-16 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Geoff Garen.
Fix FeatureDefines.xcconfig to not be out of sync with the rest of the world.
* Configurations/FeatureDefines.xcconfig:
2009-07-16 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27320
_countof is only included in CE6; for CE5 we need to define it ourself
* wtf/Platform.h:
2009-07-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Workers + garbage collector: weird crashes
https://bugs.webkit.org/show_bug.cgi?id=27077
We need to unlink cached method call sites when a function is destroyed.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::unlinkCallers):
* jit/JIT.cpp:
(JSC::JIT::unlinkMethodCall):
* jit/JIT.h:
2009-07-15 Steve Falkenburg <sfalken@apple.com>
Windows Build fix.
Visual Studio reset our intermediate directory on us.
This sets it back.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
2009-07-15 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26794
Make Yacc-generated parsers to use fastMalloc/fastFree.
Define YYMALLOC and YYFREE to fastMalloc and fastFree
respectively.
* parser/Grammar.y:
2009-07-15 Darin Adler <darin@apple.com>
Fix a build for a particular Apple configuration.
* wtf/FastAllocBase.h: Change include to use "" style for
including another wtf header. This is the style we use for
including other public headers in the same directory.
2009-07-15 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=27303
Implement createThreadInternal for WinCE.
Contains changes by George Staikos <george.staikos@torchmobile.com> and Joe Mason <joe.mason@torchmobile.com>
* wtf/ThreadingWin.cpp:
(WTF::createThreadInternal):
2009-07-15 Joe Mason <joe.mason@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27298
Platform defines for WINCE.
Contains changes by Yong Li <yong.li@torchmobile.com>,
George Staikos <george.staikos@torchmobile.com> and Joe Mason <joe.mason@torchmobile.com>
* wtf/Platform.h:
2009-07-15 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=27306
Use RegisterClass instead of RegisterClassEx on WinCE.
* wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform):
2009-07-15 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27301
Use OutputDebugStringW on WinCE since OutputDebugStringA is not supported
Originally written by Yong Li <yong.li@torchmobile.com> and refactored by
Joe Mason <joe.mason@torchmobile.com>
* wtf/Assertions.cpp: vprintf_stderr_common
2009-07-15 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27020
msToGregorianDateTime should set utcOffset to 0 when outputIsUTC is false
* wtf/DateMath.cpp:
(WTF::gregorianDateTimeToMS):
2009-07-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Cleanup - Remove obsolete code from the make system
https://bugs.webkit.org/show_bug.cgi?id=27299
* JavaScriptCore.pro:
* jsc.pro:
2009-07-07 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=27056
Alternate bool operator for codewarrior compiler (WINSCW).
Compiler (latest b482) reports error for UnspecifiedBoolType construct:
"illegal explicit conversion from 'WTF::OwnArrayPtr<JSC::Register>' to 'bool'"
Same fix as in r38391.
* JavaScriptCore/wtf/OwnArrayPtr.h:
2009-07-15 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
Qualify include path with wtf to fix compilation
on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=27055
* interpreter/Interpreter.h:
2009-07-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Dave Kilzer.
Turn off non-portable date manipulations for SYMBIAN
https://bugs.webkit.org/show_bug.cgi?id=27064
Introduce HAVE(TM_GMTOFF), HAVE(TM_ZONE) and HAVE(TIMEGM) guards
and place the rules for controlling the guards in Platform.h.
Turn off these newly introduced guards for SYMBIAN.
* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
* wtf/DateMath.h:
(WTF::GregorianDateTime::GregorianDateTime):
(WTF::GregorianDateTime::operator tm):
* wtf/Platform.h:
2009-07-15 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Undef ASSERT on Symbian, to avoid excessive warnings
https://bugs.webkit.org/show_bug.cgi?id=27052
* wtf/Assertions.h:
2009-07-15 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Hausmann.
REGRESSION: fast/js/postfix-syntax.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27294
When postfix operators operating on locals assign to the same local
the order of operations has to be to store the incremented value, then
store the unmodified number. Rather than implementing this subtle
semantic in the interpreter I've just made the logic explicit in the
bytecode generator, so x=x++ effectively becomes x=ToNumber(x) (for a
local var x).
* parser/Nodes.cpp:
(JSC::emitPostIncOrDec):
2009-07-15 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Hausmann.
REGRESSION(43559): fast/js/kde/arguments-scope.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27259
The interpreter was incorrectly basing its need to create the arguments object
based on the presence of the callframe's argument reference rather than the local
arguments reference. Based on this it then overrode the local variable reference.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change JSCell's superclass to NoncopyableCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27248
JSCell class customizes operator new, since Noncopyable will be
inherited from FastAllocBase, NoncopyableCustomAllocated has
to be used.
* runtime/JSCell.h:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
* bytecode/SamplingTool.h:
* bytecompiler/RegisterID.h:
* interpreter/CachedCall.h:
* interpreter/RegisterFile.h:
* parser/Lexer.h:
* parser/Parser.h:
* runtime/ArgList.h:
* runtime/BatchedTransitionOptimizer.h:
* runtime/Collector.h:
* runtime/CommonIdentifiers.h:
* runtime/JSCell.h:
* runtime/JSGlobalObject.h:
* runtime/JSLock.h:
* runtime/JSONObject.cpp:
* runtime/SmallStrings.cpp:
* runtime/SmallStrings.h:
* wtf/CrossThreadRefCounted.h:
* wtf/GOwnPtr.h:
* wtf/Locker.h:
* wtf/MessageQueue.h:
* wtf/OwnArrayPtr.h:
* wtf/OwnFastMallocPtr.h:
* wtf/OwnPtr.h:
* wtf/RefCounted.h:
* wtf/ThreadSpecific.h:
* wtf/Threading.h:
* wtf/Vector.h:
* wtf/unicode/Collator.h:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change ParserArenaRefCounted's superclass to RefCountedCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27249
ParserArenaDeletable customizes operator new, to avoid double inheritance
ParserArenaDeletable's superclass has been changed to RefCountedCustomAllocated.
* parser/Nodes.h:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Add RefCountedCustomAllocated to RefCounted.h
https://bugs.webkit.org/show_bug.cgi?id=27232
Some class which are inherited from RefCounted customize
operator new, but RefCounted is inherited from Noncopyable
which will be inherited from FastAllocBase. To avoid
conflicts Noncopyable inheriting was moved down to RefCounted
and to avoid double inheritance this class has been added.
* wtf/RefCounted.h:
(WTF::RefCountedCustomAllocated::deref):
(WTF::RefCountedCustomAllocated::~RefCountedCustomAllocated):
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Add NoncopyableCustomAllocated to Noncopyable.h.
https://bugs.webkit.org/show_bug.cgi?id=27228
Some classes which inherited from Noncopyable overrides operator new
since Noncopyable'll be inherited from FastAllocBase, Noncopyable.h
needs to be extended with this new class to support the overriding.
* wtf/Noncopyable.h:
(WTFNoncopyable::NoncopyableCustomAllocated::NoncopyableCustomAllocated):
(WTFNoncopyable::NoncopyableCustomAllocated::~NoncopyableCustomAllocated):
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's IdentifierTable class
https://bugs.webkit.org/show_bug.cgi?id=27260
Inherits IdentifierTable class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Identifier.cpp:70.
* runtime/Identifier.cpp:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's Profiler class
https://bugs.webkit.org/show_bug.cgi?id=27253
Inherits Profiler class from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/profiler/Profiler.cpp:56.
* profiler/Profiler.h:
2009-07-06 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
Authors: George Staikos <george.staikos@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>, Makoto Matsumoto <matumoto@math.keio.ac.jp>, Takuji Nishimura
https://bugs.webkit.org/show_bug.cgi?id=27030
Implement custom RNG for WinCE using Mersenne Twister
* wtf/RandomNumber.cpp:
(WTF::randomNumber):
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
* wtf/wince/mt19937ar.c: Added.
(init_genrand):
(init_by_array):
(genrand_int32):
(genrand_int31):
(genrand_real1):
(genrand_real2):
(genrand_real3):
(genrand_res53):
2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed make dist build fix.
* GNUmakefile.am:
2009-07-13 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932
Added ENABLE(SHARED_WORKERS) flag (off by default).
* Configurations/FeatureDefines.xcconfig:
2009-07-07 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Maciej Stachoviak.
https://bugs.webkit.org/show_bug.cgi?id=27058
Removed superfluous parenthesis around single expression.
Compilers on Symbian platform fail to properly parse and compile.
* JavaScriptCore/wtf/Platform.h:
2009-07-13 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Maciej Stachoviak.
https://bugs.webkit.org/show_bug.cgi?id=27054
Renamed Translator to HashTranslator
Codewarrior compiler (WINSCW) latest b482 cannot resolve typename
mismatch between template declaration and definition
(HashTranslator / Translator)
* wtf/HashSet.h:
2009-07-13 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=27053
Ambiguity in LabelScope initialization
Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve
type of "0" unambiguously. Set expression explicitly to
PassRefPtr<Label>::PassRefPtr()
* bytecompiler/BytecodeGenerator.cpp
2009-07-11 Simon Fraser <simon.fraser@apple.com>
Enable support for accelerated compositing and 3d transforms on Leopard.
<https://bugs.webkit.org/show_bug.cgi?id=20166>
<rdar://problem/6120614>
Reviewed by Oliver Hunt.
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
2009-07-10 Mark Rowe <mrowe@apple.com>
Second part of the "make Windows happier" dance.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-07-10 Mark Rowe <mrowe@apple.com>
Try and make the Windows build happy.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-07-10 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoffrey Garen.
* debugger/Debugger.h: Made this function virtual for use in WebCore's
WebInspector.
2009-07-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790
ParserArenaDeletable overrides new, but it does not override delete.
ParserArenaDeletable must be freed by fastFree
because it is allocated by fastMalloc.
* parser/NodeConstructors.h:
(JSC::ParserArenaDeletable::operator delete):
* parser/Nodes.h:
2009-07-10 Adam Roben <aroben@apple.com>
Sort all our Xcode projects
Accomplished using sort-Xcode-project-file.
Requested by Dave Kilzer.
* JavaScriptCore.xcodeproj/project.pbxproj:
2009-07-09 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
Windows build fix for the last change.
* wtf/dtoa.cpp: Forgot to include Vector.h
2009-07-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
REGRESSION: crash in edge cases of floating point parsing.
https://bugs.webkit.org/show_bug.cgi?id=27110
<rdar://problem/7044458>
Tests: fast/css/number-parsing-crash.html
fast/css/number-parsing-crash.html
fast/js/number-parsing-crash.html
* wtf/dtoa.cpp:
(WTF::BigInt::BigInt): Converted this to more a proper class, using a Vector
with inline capacity
(WTF::lshift): Rearranged logic somewhat nontrivially to deal with the new way of sizing BigInts.
Added an assertion to verify that invariants are maintained.
All other functions are adapted fairly mechanically to the above changes.
(WTF::BigInt::clear):
(WTF::BigInt::size):
(WTF::BigInt::resize):
(WTF::BigInt::words):
(WTF::BigInt::append):
(WTF::multadd):
(WTF::s2b):
(WTF::i2b):
(WTF::mult):
(WTF::cmp):
(WTF::diff):
(WTF::b2d):
(WTF::d2b):
(WTF::ratio):
(WTF::strtod):
(WTF::quorem):
(WTF::dtoa):
2009-07-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.
* Configurations/FeatureDefines.xcconfig:
2009-07-09 Oliver Hunt <oliver@apple.com>
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2009-07-09 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Bug 27016 - Interpreter crashes due to invalid array indexes
<https://bugs.webkit.org/show_bug.cgi?id=27016>
Unsigned vs signed conversions results in incorrect behaviour in
64bit interpreter builds.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
2009-07-09 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Upstream JavaScriptCore.gypi, the project file for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=27135
* JavaScriptCore.gypi: Added.
2009-07-09 Joe Mason <joe.mason@torchmobile.com>
Reviewed by George Staikos.
Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>
https://bugs.webkit.org/show_bug.cgi?id=27031
Add an override for deleteOwnedPtr(HDC) on Windows
* wtf/OwnPtrCommon.h:
* wtf/OwnPtrWin.cpp:
(WTF::deleteOwnedPtr):
2009-07-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Guard singal.h dependency with HAVE(SIGNAL_H) to enable building jsc
on SYMBIAN.
https://bugs.webkit.org/show_bug.cgi?id=27026
Based on Norbert Leser's work.
* jsc.cpp:
(printUsageStatement):
(parseArguments):
* wtf/Platform.h:
2009-07-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Stop loading constants into the register file.
Instead, use high register values (highest bit bar the sign bit set) to indicate
constants in the instruction stream, and when we encounter such a value load it
directly from the CodeBlock.
Since constants are no longer copied into the register file, this patch renders
the 'unexpected constant' mechanism redundant, and removes it.
2% improvement, thanks to Sam Weinig.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::mark):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::isTemporaryRegisterIndex):
(JSC::CodeBlock::constantRegister):
(JSC::CodeBlock::isConstantRegisterIndex):
(JSC::CodeBlock::getConstant):
(JSC::ExecState::r):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::preserveLastVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitEqualityOp):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitNewError):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
* interpreter/CallFrame.h:
(JSC::ExecState::noCaller):
(JSC::ExecState::hasHostCallFrameFlag):
(JSC::ExecState::addHostCallFrameFlag):
(JSC::ExecState::removeHostCallFrameFlag):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveBase):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::resolveBaseAndFunc):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::throwException):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_error):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_enter_with_activation):
* parser/Nodes.cpp:
(JSC::DeleteResolveNode::emitBytecode):
(JSC::DeleteValueNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* wtf/Platform.h:
2009-07-07 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix <https://bugs.webkit.org/show_bug.cgi?id=27025> / <rdar://problem/7033448>.
Bug 27025: Crashes and regression test failures related to regexps in 64-bit
For x86_64 RegexGenerator uses rbx, a callee-save register, as a scratch register but
neglects to save and restore it. The change in handling of the output vector in r45545
altered code generation so that the RegExp::match was now storing important data in rbx,
which caused crashes and bogus results when it was clobbered.
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter): Save rbx.
(JSC::Yarr::RegexGenerator::generateReturn): Restore rbx.
2009-07-06 Ada Chan <adachan@apple.com>
Reviewed by Darin Adler and Mark Rowe.
Decommitted spans are added to the list of normal spans rather than
the returned spans in TCMalloc_PageHeap::Delete().
https://bugs.webkit.org/show_bug.cgi?id=26998
In TCMalloc_PageHeap::Delete(), the deleted span can be decommitted in
the process of merging with neighboring spans that are also decommitted.
The merged span needs to be placed in the list of returned spans (spans
whose memory has been returned to the system). Right now it's always added
to the list of the normal spans which can theoretically cause thrashing.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::Delete):
2009-07-05 Lars Knoll <lars.knoll@nokia.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=26843
Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.
The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.
Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.
Based on idea by Norbert Leser.
* runtime/Lookup.h: Define JSC_CONST_HASHTABLE as const for !WINSCW.
* create_hash_table: Use JSC_CONST_HASHTABLE for hashtables.
* runtime/JSGlobalData.cpp: Import various global hashtables via the macro.
2009-07-04 Dan Bernstein <mitz@apple.com>
- debug build fix
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getLastParen):
2009-07-03 Yong Li <yong.li@torchmobile.com>
Reviewed by Maciej Stachowiak (and revised slightly)
RegExp::match to be optimized
https://bugs.webkit.org/show_bug.cgi?id=26957
Allow regexp matching to use Vectors with inline capacity instead of
allocating a new ovector buffer every time.
~5% speedup on SunSpider string-unpack-code test, 0.3% on SunSpider overall.
* runtime/RegExp.cpp:
(JSC::RegExp::match):
* runtime/RegExp.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructorPrivate::RegExpConstructorPrivate):
(JSC::RegExpConstructorPrivate::lastOvector):
(JSC::RegExpConstructorPrivate::tempOvector):
(JSC::RegExpConstructorPrivate::changeLastOvector):
(JSC::RegExpConstructor::performMatch):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
(JSC::RegExpMatchesArray::fillArrayInstance):
(JSC::RegExpConstructor::getBackref):
(JSC::RegExpConstructor::getLastParen):
(JSC::RegExpConstructor::getLeftContext):
(JSC::RegExpConstructor::getRightContext):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):
2009-06-30 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Override operator new/delete with const std::nothrow_t& as the second
argument.
https://bugs.webkit.org/show_bug.cgi?id=26792
On Windows CE, operator new/delete, new[]/delete[] with const
std::nothrow_t& must be overrided because some standard template
libraries use these operators.
The problem occurs when memory allocated by new(size_t s, const
std::nothrow_t&) is freed by delete(void* p). This causes the umatched
malloc/free problem.
The patch overrides all new, delete, new[] and delete[] to use
fastMaloc and fastFree consistently.
* wtf/FastMalloc.h:
(throw):
2009-06-30 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Sam Weinig.
<https://bugs.webkit.org/show_bug.cgi?id=24986>
Remove unnecessary references to AssemblerBuffer.
* interpreter/Interpreter.cpp:
* interpreter/Interpreter.h:
2009-06-29 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
Still seeing occasional leaks from UString::sharedBuffer code
https://bugs.webkit.org/show_bug.cgi?id=26420
The problem is that the pointer to the memory allocation isn't visible
by "leaks" due to the lower bits being used as flags. The fix is to
make the pointer visible in memory (in debug only). The downside of
this fix that the memory allocated by sharedBuffer will still look like
a leak in non-debug builds when any flags are set.
* wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::set):
2009-06-29 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove more unused scons support.
* SConstruct: Removed.
2009-06-29 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
<rdar://problem/7016214> JSON.parse fails to parse valid JSON with most Unicode characters
<https://bugs.webkit.org/show_bug.cgi?id=26802>
In the original JSON.parse patch unicode was handled correctly, however in some last
minute "clean up" I oversimplified isSafeStringCharacter. This patch corrects this bug.
* runtime/LiteralParser.cpp:
(JSC::isSafeStringCharacter):
(JSC::LiteralParser::Lexer::lexString):
2009-06-26 Oliver Hunt <oliver@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7009684> REGRESSION(r45039): Crashes inside JSEvent::put on PowerPC (26746)
<https://bugs.webkit.org/show_bug.cgi?id=26746>
Fix for r45039 incorrectly uncached a get_by_id by converting it to put_by_id. Clearly this
is less than correct. This patch corrects that error.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCacheGetByID):
2009-06-26 Eric Seidel <eric@webkit.org>
No review, only rolling out r45259.
Roll out r45259 after crash appeared on the bots:
plugins/undefined-property-crash.html
ASSERTION FAILED: s <= HeapConstants<heapType>::cellSize
(leopard-intel-debug-tests/build/JavaScriptCore/runtime/Collector.cpp:278
void* JSC::Heap::heapAllocate(size_t) [with JSC::HeapType heapType = PrimaryHeap])
* runtime/DateInstance.cpp:
* runtime/Identifier.cpp:
* runtime/Lookup.h:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpObject.h:
* runtime/ScopeChain.h:
* runtime/UString.h:
2009-06-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Add support for QDataStream operators to Vector.
* wtf/Vector.h:
(WTF::operator<<):
(WTF::operator>>):
2009-06-24 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Make the opcode sampler work once again.
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JSC::JIT::compileCTIMachineTrampolines):
(JSC::JIT::compilePatchGetArrayLength):
* jit/JITStubCall.h:
(JSC::JITStubCall::call):
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Extend FastAllocBase.h with 'using WTF::FastAllocBase' to avoid
unnecessary WTF:: usings.
Remove existing unnecessary WTF:: usings.
* interpreter/Interpreter.h:
* profiler/CallIdentifier.h:
* runtime/ScopeChain.h:
* wtf/FastAllocBase.h:
2009-06-24 David Levin <levin@chromium.org>
Fix all builds.
* bytecode/CodeBlock.h:
* bytecompiler/BytecodeGenerator.h:
* interpreter/Register.h:
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=26677
Inherits CodeBlock class from FastAllocBase because it
has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:217.
* bytecode/CodeBlock.h:
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=26676
Inherits BytecodeGenerator class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/Nodes.cpp:1892.
* bytecompiler/BytecodeGenerator.h:
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=26675
Inherits Register class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149.
* interpreter/Register.h:
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26674
Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:458.
* wtf/HashMap.h:
2009-06-24 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanner shows blank page instead of site details in "basic research'
The problem was caused by the page returned with a function using a
var declaration list containing around ~3000 variables. The solution
to this is to flatten the comma expression representation and make
codegen comma expressions and initializer lists iterative rather than
recursive.
* parser/Grammar.y:
* parser/NodeConstructors.h:
(JSC::CommaNode::CommaNode):
* parser/Nodes.cpp:
(JSC::CommaNode::emitBytecode):
* parser/Nodes.h:
(JSC::ExpressionNode::isCommaNode):
(JSC::CommaNode::isCommaNode):
(JSC::CommaNode::append):
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=26645
Inherits ScopeChainNode class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/ScopeChain.h:95.
* wtf/RefPtr.h:
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26648
Inherits Deque class from FastAllocBase because it has been
instantiated by 'new' with DEFINE_STATIC_LOCAL macro in
JavaScriptCore/wtf/MainThread.cpp:62.
* wtf/Deque.h:
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26644
Inherits RefPtr class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/StructureChain.cpp:41.
* wtf/RefPtr.h:
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits HashSet class from FastAllocBase, because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.h:116.
* wtf/HashSet.h:
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits Vector class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:633.
* wtf/Vector.h:
2009-06-24 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Maciej Stachoviak.
The BytecodeGenerator objects were instantiated on stack, which takes up ~38kB per instance
(each instance includes copy of JSC::CodeBlock with large SymbolTable, etc.).
Specifically, since there is nested invocation (e.g., GlobalCode --> FunctionCode),
the stack overflows immediately on Symbian hardware (max. 80 kB).
Proposed change allocates generator objects on heap.
Performance impact (if any) should be negligible and change is proposed as general fix,
rather than ifdef'd for SYMBIAN.
* parser/Nodes.cpp:
(JSC::ProgramNode::generateBytecode):
(JSC::EvalNode::generateBytecode):
(JSC::EvalNode::bytecodeForExceptionInfoReparse):
(JSC::FunctionBodyNode::generateBytecode):
(JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
2009-06-23 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
<rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in cases of prototypes that have more than 64 (26593)
<https://bugs.webkit.org/show_bug.cgi?id=26593>
Do not attempt to cache structure chains if they contain a dictionary at any level.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
* runtime/Structure.cpp:
(JSC::Structure::getEnumerablePropertyNames):
(JSC::Structure::addPropertyTransition):
* runtime/StructureChain.cpp:
(JSC::StructureChain::isCacheable):
* runtime/StructureChain.h:
2009-06-23 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26654
Add the proper export define for the JavaScriptCore API when building for WINCE.
* API/JSBase.h:
2009-06-23 Joe Mason <joe.mason@torchmobile.com>
Reviewed by Adam Treat.
Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>
https://bugs.webkit.org/show_bug.cgi?id=26611
Implement currentThreadStackBase on WINCE by adding a global,
g_stackBase, which must be set to the address of a local variable
by the caller before calling any WebKit function that invokes JSC.
* runtime/Collector.cpp:
(JSC::isPageWritable):
(JSC::getStackBase):
Starts at the top of the stack and returns the entire range of
consecutive writable pages as an estimate of the actual stack.
This will be much bigger than the actual stack range, so some
dead objects can't be collected, but it guarantees live objects
aren't collected prematurely.
(JSC::currentThreadStackBase):
On WinCE, returns g_stackBase if set or call getStackBase as a
fallback if not.
2009-06-23 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
Fix stupid performance problem in the LiteralParser
The LiteralParser was making a new UString in order to use
toDouble, however UString's toDouble allows a much wider range
of numberic strings than the LiteralParser accepts, and requires
an additional heap allocation or two for the construciton of the
UString. To rectify this we just call WTF::dtoa directly using
a stack allocated buffer to hold the validated numeric literal.
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
2009-06-22 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
Bug 26640: JSON.stringify needs to special case Boolean objects
<https://bugs.webkit.org/show_bug.cgi?id=26640>
Add special case handling of the Boolean object so we match current
ES5 errata.
* runtime/JSONObject.cpp:
(JSC::unwrapBoxedPrimitive): renamed from unwrapNumberOrString
(JSC::gap):
(JSC::Stringifier::appendStringifiedValue):
2009-06-22 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Bug 26591: Support revivers in JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26591>
Add reviver support to JSON.parse. This completes the JSON object.
* runtime/JSONObject.cpp:
(JSC::Walker::Walker):
(JSC::Walker::callReviver):
(JSC::Walker::walk):
(JSC::JSONProtoFuncParse):
2009-06-21 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Bug 26592: Support standard toJSON functions
<https://bugs.webkit.org/show_bug.cgi?id=26592>
Add support for the standard Date.toJSON function.
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToJSON):
2009-06-21 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Bug 26594: JSC needs to support Date.toISOString
<https://bugs.webkit.org/show_bug.cgi?id=26594>
Add support for Date.toISOString.
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):
2009-06-21 Oliver Hunt <oliver@apple.com>
Remove dead code.
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::parse):
2009-06-21 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler and Cameron Zwarich.
Bug 26587: Support JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26587>
Extend the LiteralParser to support the full strict JSON
grammar, fix a few places where the grammar was incorrectly
lenient. Doesn't yet support the JSON.parse reviver function
but that does not block the JSON.parse functionality itself.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lex):
(JSC::isSafeStringCharacter):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::tryJSONParse):
(JSC::LiteralParser::):
(JSC::LiteralParser::Lexer::Lexer):
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (speculative build fix for windows).
Simply removed some whitespace form this file to make windows build wtf and
hopefully copy the new MessageQueque.h so that WebCore picks it up.
* wtf/Assertions.cpp:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Added support for multi-threaded MessagePorts.
* wtf/MessageQueue.h:
(WTF::::appendAndCheckEmpty):
Added API to test whether the queue was empty before adding an element.
2009-06-20 David D. Kilzer <ddkilzer@webkit.org>
Fix namespace comment in SegmentedVector.h
* wtf/SegmentedVector.h: Updated namespace comment to reflect
new namespace after r44897.
2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
Reviewed by Oliver Hunt.
An Iterator added for SegmentedVector. Currently
only the pre ++ operator is supported.
* wtf/SegmentedVector.h:
(WTF::SegmentedVectorIterator::~SegmentedVectorIterator):
(WTF::SegmentedVectorIterator::operator*):
(WTF::SegmentedVectorIterator::operator->):
(WTF::SegmentedVectorIterator::operator++):
(WTF::SegmentedVectorIterator::operator==):
(WTF::SegmentedVectorIterator::operator!=):
(WTF::SegmentedVectorIterator::operator=):
(WTF::SegmentedVectorIterator::SegmentedVectorIterator):
(WTF::SegmentedVector::alloc):
(WTF::SegmentedVector::begin):
(WTF::SegmentedVector::end):
2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
Reviewed by Oliver Hunt.
Move SegmentedVector to /wtf subdirectory
and change "namespace JSC" to "namespace WTF"
Additional build file updates by David Kilzer.
* GNUmakefile.am: Updated path to SegmentedVector.h.
* JavaScriptCore.order: Updated SegmentedVector namespace from
JSC to WTF in mangled C++ method name.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
Removed reference to bytecompiler\SegmentedVector.h.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to
wtf\SegmentedVector.h.
* JavaScriptCore.xcodeproj/project.pbxproj: Moved
SegmentedVector.h definition from bytecompiler subdirectory to
wtf subdirectory.
* bytecompiler/BytecodeGenerator.h: Updated #include path to
SegmentedVector.h and prepended WTF:: namespace to its use.
* parser/Lexer.h: Ditto.
* wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h.
(WTF::SegmentedVector::SegmentedVector):
(WTF::SegmentedVector::~SegmentedVector):
(WTF::SegmentedVector::size):
(WTF::SegmentedVector::at):
(WTF::SegmentedVector::operator[]):
(WTF::SegmentedVector::last):
(WTF::SegmentedVector::append):
(WTF::SegmentedVector::removeLast):
(WTF::SegmentedVector::grow):
(WTF::SegmentedVector::clear):
(WTF::SegmentedVector::deleteAllSegments):
(WTF::SegmentedVector::segmentExistsFor):
(WTF::SegmentedVector::segmentFor):
(WTF::SegmentedVector::subscriptFor):
(WTF::SegmentedVector::ensureSegmentsFor):
(WTF::SegmentedVector::ensureSegment):
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emitGetVariableObjectRegister):
(JSC::JIT::emitPutVariableObjectRegister):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::compileBinaryArithOp):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):
* jit/JITInlineMethods.h:
(JSC::JIT::restoreArgumentReference):
(JSC::JIT::checkStructure):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_construct_verify):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
* jit/JIT.h:
* jit/JITInlineMethods.h:
2009-06-19 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Reorganize ARM architecture specific macros.
Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
* assembler/ARMv7Assembler.h:
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Imm32::Imm32):
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::restoreArgumentReferenceForTrampoline):
* jit/JITStubs.cpp:
* jit/JITStubs.h:
* wtf/Platform.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix armv7 JIT build issues.
Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.
* Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
* Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
* jit/JIT.cpp:
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::restoreArgumentReference):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
2009-06-19 Adam Treat <adam.treat@torchmobile.com>
Blind attempt at build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Inherits CallIdentifier struct from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.
* wtf/HashCountedSet.h:
2009-06-19 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=26540
Modify the test shell to add a new function 'checkSyntax' that will
only parse the source instead of executing it. In this way we can test
pure parsing performance against some of the larger scripts in the wild.
* jsc.cpp:
(GlobalObject::GlobalObject):
(functionCheckSyntax):
2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits HashCountedSet class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.
* wtf/HashCountedSet.h:
2009-06-19 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26558
Declare these symbols extern for WINCE as they are provided by libce.
* runtime/DateConstructor.cpp:
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
2009-06-19 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/6988973> ScopeChain leak in interpreter builds
Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.
* runtime/JSFunction.cpp:
(JSC::JSFunction::~JSFunction):
* wtf/Platform.h:
2009-06-19 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26543
Windows CE uses 'GetLastError' instead of 'errno.'
* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
2009-06-19 David Levin <levin@chromium.org>
Reviewed by NOBODY (Windows build fix).
Add export for Windows corresponding to OSX export done in r44844.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
2009-06-18 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin "Viceroy of Venezuela" Barraclough.
Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>
We need to make sure that each native function instance correctly unlinks any references to it
when it is collected. Allowing this to happen required a few changes:
* Every native function needs a codeblock to track the link information
* To have this codeblock, every function now also needs its own functionbodynode
so we no longer get to have a single shared instance.
* Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode
* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
Constructor for NativeCode CodeBlock
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::handlerForBytecodeOffset):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
(JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
(JSC::CodeBlock::functionRegisterForBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
(JSC::CodeBlock::setJITCode):
Add assertions to ensure we don't try and use NativeCode CodeBlocks as
a normal codeblock.
* bytecode/CodeBlock.h:
(JSC::):
(JSC::CodeBlock::source):
(JSC::CodeBlock::sourceOffset):
(JSC::CodeBlock::evalCodeCache):
(JSC::CodeBlock::createRareDataIfNecessary):
More assertions.
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::linkCall):
Update logic to allow native function caching
* jit/JITStubs.cpp:
* parser/Nodes.cpp:
(JSC::FunctionBodyNode::createNativeThunk):
(JSC::FunctionBodyNode::isHostFunction):
* parser/Nodes.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::mark):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
2009-06-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
2009-06-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Timezone calculation incorrect in Venezuela.
https://bugs.webkit.org/show_bug.cgi?id=26531
<rdar://problem/6646169> Time is incorrectly reported to JavaScript in both Safari 3 and Firefox 3
The problem is that we're calculating the timezone relative to 01/01/2000,
but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.
According to the spec, section 15.9.1.9 states "the time since the beginning
of the year", presumably meaning the *current* year. Change the calculation
to be based on whatever the current year is, rather than a canned date.
No performance impact.
* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
2009-06-18 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Mark Rowe (originally reviewed by Sam Weinig).
(Reintroducing patch added in r44492, and reverted in r44796.)
Change the implementation of op_throw so the stub function always modifies its
return address - if it doesn't find a 'catch' it will switch to a trampoline
to force a return from JIT execution. This saves memory, by avoiding the need
for a unique return for every op_throw.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_throw):
JITStubs::cti_op_throw now always changes its return address,
remove return code generated after the stub call (this is now
handled by ctiOpThrowNotCaught).
* jit/JITStubs.cpp:
(JSC::):
Add ctiOpThrowNotCaught definitions.
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
Change cti_op_throw to always change its return address.
* jit/JITStubs.h:
Add ctiOpThrowNotCaught declaration.
2009-06-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit
- Exposed functions now needed by WebCore.
* JavaScriptCore.exp:
2009-06-17 Darin Adler <darin@apple.com>
Reviewed by Oliver Hunt.
Bug 26429: Make JSON.stringify non-recursive so it can handle objects
of arbitrary complexity
https://bugs.webkit.org/show_bug.cgi?id=26429
For marking I decided not to use gcProtect, because this is inside the engine
so it's easy enough to just do marking. And that darned gcProtect does locking!
Oliver tried to convince me to used MarkedArgumentBuffer, but the constructor
for that class says "FIXME: Remove all clients of this API, then remove this API."
* runtime/Collector.cpp:
(JSC::Heap::collect): Add a call to JSONObject::markStringifiers.
* runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers): Added emptyIdentifier.
* runtime/CommonIdentifiers.h: Ditto.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData): Initialize firstStringifierToMark to 0.
* runtime/JSGlobalData.h: Added firstStringifierToMark.
* runtime/JSONObject.cpp: Cut down the includes to the needed ones only.
(JSC::unwrapNumberOrString): Added. Helper for unwrapping number and string
objects to get their number and string values.
(JSC::ReplacerPropertyName::ReplacerPropertyName): Added. The class is used
to wrap an identifier or integer so we don't have to do any work unless we
actually call a replacer.
(JSC::ReplacerPropertyName::value): Added.
(JSC::gap): Added. Helper function for the Stringifier constructor.
(JSC::PropertyNameForFunctionCall::PropertyNameForFunctionCall): Added.
The class is used to wrap an identifier or integer so we don't have to
allocate a number or string until we actually call toJSON or a replacer.
(JSC::PropertyNameForFunctionCall::asJSValue): Added.
(JSC::Stringifier::Stringifier): Updated and moved out of the class
definition. Added code to hook this into a singly linked list for marking.
(JSC::Stringifier::~Stringifier): Remove from the singly linked list.
(JSC::Stringifier::mark): Mark all the objects in the holder stacks.
(JSC::Stringifier::stringify): Updated.
(JSC::Stringifier::appendQuotedString): Tweaked and streamlined a bit.
(JSC::Stringifier::toJSON): Renamed from toJSONValue.
(JSC::Stringifier::appendStringifiedValue): Renamed from stringify.
Added code to use the m_holderStack to do non-recursive stringify of
objects and arrays. This code also uses the timeout checker since in
pathological cases it could be slow even without calling into the
JavaScript virtual machine.
(JSC::Stringifier::willIndent): Added.
(JSC::Stringifier::indent): Added.
(JSC::Stringifier::unindent): Added.
(JSC::Stringifier::startNewLine): Added.
(JSC::Stringifier::Holder::Holder): Added.
(JSC::Stringifier::Holder::appendNextProperty): Added. This is the
function that handles the format of arrays and objects.
(JSC::JSONObject::getOwnPropertySlot): Moved this down to the bottom
of the file so the JSONObject class is not interleaved with the
Stringifier class.
(JSC::JSONObject::markStringifiers): Added. Calls mark.
(JSC::JSONProtoFuncStringify): Streamlined the code here. The code
to compute the gap string is now a separate function.
* runtime/JSONObject.h: Made everything private. Added markStringifiers.
2009-06-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
<rdar://problem/6974140> REGRESSION(r43849): Crash in cti_op_call_NotJSFunction when getting directions on maps.google.com
Roll out r43849 as it appears that we cannot rely on the address of
an objects property storage being constant even if the structure is
unchanged.
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Mark Rowe.
Fully revert r44492 & r44748 while we fix a bug they cause on internal builds <rdar://problem/6955963>.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_throw):
* jit/JITStubs.cpp:
(JSC::):
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6947426> sunspider math-cordic.js exhibits different intermediate results running 32-bit vs. 64-bit
On 64-bit, NaN-encoded values must be detagged before they can be used in rshift.
No performance impact.
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_rshift):
2009-06-17 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
* jsc.cpp:
(main):
2009-06-17 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=23155
Move WIN_CE -> WINCE as previously discussed with Qt WINCE folks.
* config.h:
* jsc.cpp:
* wtf/Assertions.cpp:
* wtf/Assertions.h:
* wtf/CurrentTime.cpp:
(WTF::lowResUTCTime):
* wtf/DateMath.cpp:
(WTF::getLocalTime):
* wtf/MathExtras.h:
* wtf/Platform.h:
* wtf/StringExtras.h:
* wtf/Threading.h:
* wtf/win/MainThreadWin.cpp:
2009-06-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6974175> ASSERT in JITStubs.cpp at appsaccess.apple.com
Remove PropertySlot::putValue - PropertySlots should only be used for getting,
not putting. Rename JSGlobalObject::getOwnPropertySlot to hasOwnPropertyForWrite,
which is what it really was being used to ask, and remove some other getOwnPropertySlot
& getOwnPropertySlotForWrite methods, which were unused and likely to lead to confusion.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::hasOwnPropertyForWrite):
* runtime/JSObject.h:
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/PropertySlot.h:
2009-06-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver hunt.
Temporarily partially disable r44492, since this is causing some problems on internal builds.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_throw):
* jit/JITStubs.cpp:
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
2009-06-16 Sam Weinig <sam@webkit.org>
Fix windows build.
* jit/JIT.cpp:
(JSC::JIT::JIT):
2009-06-16 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Initialize m_bytecodeIndex to -1 in JIT, and correctly initialize
it for each type of stub using the return address to find the correct
offset.
* jit/JIT.cpp:
(JSC::JIT::JIT):
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JSC::JIT::compileCTIMachineTrampolines):
(JSC::JIT::compilePatchGetArrayLength):
* jit/JITStubCall.h:
(JSC::JITStubCall::call):
== Rolled over to ChangeLog-2009-06-16 ==
|