1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112 6113 6114 6115 6116 6117 6118 6119 6120 6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152 6153 6154 6155 6156 6157 6158 6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179 6180 6181 6182 6183 6184 6185 6186 6187 6188 6189 6190 6191 6192 6193 6194 6195 6196 6197 6198 6199 6200 6201 6202 6203 6204 6205 6206 6207 6208 6209 6210 6211 6212 6213 6214 6215 6216 6217 6218 6219 6220 6221 6222 6223 6224 6225 6226 6227 6228 6229 6230 6231 6232 6233 6234 6235 6236 6237 6238 6239 6240 6241 6242 6243 6244 6245 6246 6247 6248 6249 6250 6251 6252 6253 6254 6255 6256 6257 6258 6259 6260 6261 6262 6263 6264 6265 6266 6267 6268 6269 6270 6271 6272 6273 6274 6275 6276 6277 6278 6279 6280 6281 6282 6283 6284 6285 6286 6287 6288 6289 6290 6291 6292 6293 6294 6295 6296 6297 6298 6299 6300 6301 6302 6303 6304 6305 6306 6307 6308 6309 6310 6311 6312 6313 6314 6315 6316 6317 6318 6319 6320 6321 6322 6323 6324 6325 6326 6327 6328 6329 6330 6331 6332 6333 6334 6335 6336 6337 6338 6339 6340 6341 6342 6343 6344 6345 6346 6347 6348 6349 6350 6351 6352 6353 6354 6355 6356 6357 6358 6359 6360 6361 6362 6363 6364 6365 6366 6367 6368 6369 6370 6371 6372 6373 6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441 6442 6443 6444 6445 6446 6447 6448 6449 6450 6451 6452 6453 6454 6455 6456 6457 6458 6459 6460 6461 6462 6463 6464 6465 6466 6467 6468 6469 6470 6471 6472 6473 6474 6475 6476 6477 6478 6479 6480 6481 6482 6483 6484 6485 6486 6487 6488 6489 6490 6491 6492 6493 6494 6495 6496 6497 6498 6499 6500 6501 6502 6503 6504 6505 6506 6507 6508 6509 6510 6511 6512 6513 6514 6515 6516 6517 6518 6519 6520 6521 6522 6523 6524 6525 6526 6527 6528 6529 6530 6531 6532 6533 6534 6535 6536 6537 6538 6539 6540 6541 6542 6543 6544 6545 6546 6547 6548 6549 6550 6551 6552 6553 6554 6555 6556 6557 6558 6559 6560 6561 6562 6563 6564 6565 6566 6567 6568 6569 6570 6571 6572 6573 6574 6575 6576 6577 6578 6579 6580 6581 6582 6583 6584 6585 6586 6587 6588 6589 6590 6591 6592 6593 6594 6595 6596 6597 6598 6599 6600 6601 6602 6603 6604 6605 6606 6607 6608 6609 6610 6611 6612 6613 6614 6615 6616 6617 6618 6619 6620 6621 6622 6623 6624 6625 6626 6627 6628 6629 6630 6631 6632 6633 6634 6635 6636 6637 6638 6639 6640 6641 6642 6643 6644 6645 6646 6647 6648 6649 6650 6651 6652 6653 6654 6655 6656 6657 6658 6659 6660 6661 6662 6663 6664 6665 6666 6667 6668 6669 6670 6671 6672 6673 6674 6675 6676 6677 6678 6679 6680 6681 6682 6683 6684 6685 6686 6687 6688 6689 6690 6691 6692 6693 6694 6695 6696 6697 6698 6699 6700 6701 6702 6703 6704 6705 6706 6707 6708 6709 6710 6711 6712 6713 6714 6715 6716 6717 6718 6719 6720 6721 6722 6723 6724 6725 6726 6727 6728 6729 6730 6731 6732 6733 6734 6735 6736 6737 6738 6739 6740 6741 6742 6743 6744 6745 6746 6747 6748 6749 6750 6751 6752 6753 6754 6755 6756 6757 6758 6759 6760 6761 6762 6763 6764 6765 6766 6767 6768 6769 6770 6771 6772 6773 6774 6775 6776 6777 6778 6779 6780 6781 6782 6783 6784 6785 6786 6787 6788 6789 6790 6791 6792 6793 6794 6795 6796 6797 6798 6799 6800 6801 6802 6803 6804 6805 6806 6807 6808 6809 6810 6811 6812 6813 6814 6815 6816 6817 6818 6819 6820 6821 6822 6823 6824 6825 6826 6827 6828 6829 6830 6831 6832 6833 6834 6835 6836 6837 6838 6839 6840 6841 6842 6843 6844 6845 6846 6847 6848 6849 6850 6851 6852 6853 6854 6855 6856 6857 6858 6859 6860 6861 6862 6863 6864 6865 6866 6867 6868 6869 6870 6871 6872 6873 6874 6875 6876 6877 6878 6879 6880 6881 6882 6883 6884 6885 6886 6887 6888 6889 6890 6891 6892 6893 6894 6895 6896 6897 6898 6899 6900 6901 6902 6903 6904 6905 6906 6907 6908 6909 6910 6911 6912 6913 6914 6915 6916 6917 6918 6919 6920 6921 6922 6923 6924 6925 6926 6927 6928 6929 6930 6931 6932 6933 6934 6935 6936 6937 6938 6939 6940 6941 6942 6943 6944 6945 6946 6947 6948 6949 6950 6951 6952 6953 6954 6955 6956 6957 6958 6959 6960 6961 6962 6963 6964 6965 6966 6967 6968 6969 6970 6971 6972 6973 6974 6975 6976 6977 6978 6979 6980 6981 6982 6983 6984 6985 6986 6987 6988 6989 6990 6991 6992 6993 6994 6995 6996 6997 6998 6999 7000 7001 7002 7003 7004 7005 7006 7007 7008 7009 7010 7011 7012 7013 7014 7015 7016 7017 7018 7019 7020 7021 7022 7023 7024 7025 7026 7027 7028 7029 7030 7031 7032 7033 7034 7035 7036 7037 7038 7039 7040 7041 7042 7043 7044 7045 7046 7047 7048 7049 7050 7051 7052 7053 7054 7055 7056 7057 7058 7059 7060 7061 7062 7063 7064 7065 7066 7067 7068 7069 7070 7071 7072 7073 7074 7075 7076 7077 7078 7079 7080 7081 7082 7083 7084 7085 7086 7087 7088 7089 7090 7091 7092 7093 7094 7095 7096 7097 7098 7099 7100 7101 7102 7103 7104 7105 7106 7107 7108 7109 7110 7111 7112 7113 7114 7115 7116 7117 7118 7119 7120 7121 7122 7123 7124 7125 7126 7127 7128 7129 7130 7131 7132 7133 7134 7135 7136 7137 7138 7139 7140 7141 7142 7143 7144 7145 7146 7147 7148 7149 7150 7151 7152 7153 7154 7155 7156 7157 7158 7159 7160 7161 7162 7163 7164 7165 7166 7167 7168 7169 7170 7171 7172 7173 7174 7175 7176 7177 7178 7179 7180 7181 7182 7183 7184 7185 7186 7187 7188 7189 7190 7191 7192 7193 7194 7195 7196 7197 7198 7199 7200 7201 7202 7203 7204 7205 7206 7207 7208 7209 7210 7211 7212 7213 7214 7215 7216 7217 7218 7219 7220 7221 7222 7223 7224 7225 7226 7227 7228 7229 7230 7231 7232 7233 7234 7235 7236 7237 7238 7239 7240 7241 7242 7243 7244 7245 7246 7247 7248 7249 7250 7251 7252 7253 7254 7255 7256 7257 7258 7259 7260 7261 7262 7263 7264 7265 7266 7267 7268 7269 7270 7271 7272 7273 7274 7275 7276 7277 7278 7279 7280 7281 7282 7283 7284 7285 7286 7287 7288 7289 7290 7291 7292 7293 7294 7295 7296 7297 7298 7299 7300 7301 7302 7303 7304 7305 7306 7307 7308 7309 7310 7311 7312 7313 7314 7315 7316 7317 7318 7319 7320 7321 7322 7323 7324 7325 7326 7327 7328 7329 7330 7331 7332 7333 7334 7335 7336 7337 7338 7339 7340 7341 7342 7343 7344 7345 7346 7347 7348 7349 7350 7351 7352 7353 7354 7355 7356 7357 7358 7359 7360 7361 7362 7363 7364 7365 7366 7367 7368 7369 7370 7371 7372 7373 7374 7375 7376 7377 7378 7379 7380 7381 7382 7383 7384 7385 7386 7387 7388 7389 7390 7391 7392 7393 7394 7395 7396 7397 7398 7399 7400 7401 7402 7403 7404 7405 7406 7407 7408 7409 7410 7411 7412 7413 7414 7415 7416 7417 7418 7419 7420 7421 7422 7423 7424 7425 7426 7427 7428 7429 7430 7431 7432 7433 7434 7435 7436 7437 7438 7439 7440 7441 7442 7443 7444 7445 7446 7447 7448 7449 7450 7451 7452 7453 7454 7455 7456 7457 7458 7459 7460 7461 7462 7463 7464 7465 7466 7467 7468 7469 7470 7471 7472 7473 7474 7475 7476 7477 7478 7479 7480 7481 7482 7483 7484 7485 7486 7487 7488 7489 7490 7491 7492 7493 7494 7495 7496 7497 7498 7499 7500 7501 7502 7503 7504 7505 7506 7507 7508 7509 7510 7511 7512 7513 7514 7515 7516 7517 7518 7519 7520 7521 7522 7523 7524 7525 7526 7527 7528 7529 7530 7531 7532 7533 7534 7535 7536 7537 7538 7539 7540 7541 7542 7543 7544 7545 7546 7547 7548 7549 7550 7551 7552 7553 7554 7555 7556 7557 7558 7559 7560 7561 7562 7563 7564 7565 7566 7567 7568 7569 7570 7571 7572 7573 7574 7575 7576 7577 7578 7579 7580 7581 7582 7583 7584 7585 7586 7587 7588 7589 7590 7591 7592 7593 7594 7595 7596 7597 7598 7599 7600 7601 7602 7603 7604 7605 7606 7607 7608 7609 7610 7611 7612 7613 7614 7615 7616 7617 7618 7619 7620 7621 7622 7623 7624 7625 7626 7627 7628 7629 7630 7631 7632 7633 7634 7635 7636 7637 7638 7639 7640 7641 7642 7643 7644 7645 7646 7647 7648 7649 7650 7651 7652 7653 7654 7655 7656 7657 7658 7659 7660 7661 7662 7663 7664 7665 7666 7667 7668 7669 7670 7671 7672 7673 7674 7675 7676 7677 7678 7679 7680 7681 7682 7683 7684 7685 7686 7687 7688 7689 7690 7691 7692 7693 7694 7695 7696 7697 7698 7699 7700 7701 7702 7703 7704 7705 7706 7707 7708 7709 7710 7711 7712 7713 7714 7715 7716 7717 7718 7719 7720 7721 7722 7723 7724 7725 7726 7727 7728 7729 7730 7731 7732 7733 7734 7735 7736 7737 7738 7739 7740 7741 7742 7743 7744 7745 7746 7747 7748 7749 7750 7751 7752 7753 7754 7755 7756 7757 7758 7759 7760 7761 7762 7763 7764 7765 7766 7767 7768 7769 7770 7771 7772 7773 7774 7775 7776 7777 7778 7779 7780 7781 7782 7783 7784 7785 7786 7787 7788 7789 7790 7791 7792 7793 7794 7795 7796 7797 7798 7799 7800 7801 7802 7803 7804 7805 7806 7807 7808 7809 7810 7811 7812 7813 7814 7815 7816 7817 7818 7819 7820 7821 7822 7823 7824 7825 7826 7827 7828 7829 7830 7831 7832 7833 7834 7835 7836 7837 7838 7839 7840 7841 7842 7843 7844 7845 7846 7847 7848 7849 7850 7851 7852 7853 7854 7855 7856 7857 7858 7859 7860 7861 7862 7863 7864 7865 7866 7867 7868 7869 7870 7871 7872 7873 7874 7875 7876 7877 7878 7879 7880 7881 7882 7883 7884 7885 7886 7887 7888 7889 7890 7891 7892 7893 7894 7895 7896 7897 7898 7899 7900 7901 7902 7903 7904 7905 7906 7907 7908 7909 7910 7911 7912 7913 7914 7915 7916 7917 7918 7919 7920 7921 7922 7923 7924 7925 7926 7927 7928 7929 7930 7931 7932 7933 7934 7935 7936 7937 7938 7939 7940 7941 7942 7943 7944 7945 7946 7947 7948 7949 7950 7951 7952 7953 7954 7955 7956 7957 7958 7959 7960 7961 7962 7963 7964 7965 7966 7967 7968 7969 7970 7971 7972 7973 7974 7975 7976 7977 7978 7979 7980 7981 7982 7983 7984 7985 7986 7987 7988 7989 7990 7991 7992 7993 7994 7995 7996 7997 7998 7999 8000 8001 8002 8003 8004 8005 8006 8007 8008 8009 8010 8011 8012 8013 8014 8015 8016 8017 8018 8019 8020 8021 8022 8023 8024 8025 8026 8027 8028 8029 8030 8031 8032 8033 8034 8035 8036 8037 8038 8039 8040 8041 8042 8043 8044 8045 8046 8047 8048 8049 8050 8051 8052 8053 8054 8055 8056 8057 8058 8059 8060 8061 8062 8063 8064 8065 8066 8067 8068 8069 8070 8071 8072 8073 8074 8075 8076 8077 8078 8079 8080 8081 8082 8083 8084 8085 8086 8087 8088 8089 8090 8091 8092 8093 8094 8095 8096 8097 8098 8099 8100 8101 8102 8103 8104 8105 8106 8107 8108 8109 8110 8111 8112 8113 8114 8115 8116 8117 8118 8119 8120 8121 8122 8123 8124 8125 8126 8127 8128 8129 8130 8131 8132 8133 8134 8135 8136 8137 8138 8139 8140 8141 8142 8143 8144 8145 8146 8147 8148 8149 8150 8151 8152 8153 8154 8155 8156 8157 8158 8159 8160 8161 8162 8163 8164 8165 8166 8167 8168 8169 8170 8171 8172 8173 8174 8175 8176 8177 8178 8179 8180 8181 8182 8183 8184 8185 8186 8187 8188 8189 8190 8191 8192 8193 8194 8195 8196 8197 8198 8199 8200 8201 8202 8203 8204 8205 8206 8207 8208 8209 8210 8211 8212 8213 8214 8215 8216 8217 8218 8219 8220 8221 8222 8223 8224 8225 8226 8227 8228 8229 8230 8231 8232 8233 8234 8235 8236 8237 8238 8239 8240 8241 8242 8243 8244 8245 8246 8247 8248 8249 8250 8251 8252 8253 8254 8255 8256 8257 8258 8259 8260 8261 8262 8263 8264 8265 8266 8267 8268 8269 8270 8271 8272 8273 8274 8275 8276 8277 8278 8279 8280 8281 8282 8283 8284 8285 8286 8287 8288 8289 8290 8291 8292 8293 8294 8295 8296 8297 8298 8299 8300 8301 8302 8303 8304 8305 8306 8307 8308 8309 8310 8311 8312 8313 8314 8315 8316 8317 8318 8319 8320 8321 8322 8323 8324 8325 8326 8327 8328 8329 8330 8331 8332 8333 8334 8335 8336 8337 8338 8339 8340 8341 8342 8343 8344 8345 8346 8347 8348 8349 8350 8351 8352 8353 8354 8355 8356 8357 8358 8359 8360 8361 8362 8363 8364 8365 8366 8367 8368 8369 8370 8371 8372 8373 8374 8375 8376 8377 8378 8379 8380 8381 8382 8383 8384 8385 8386 8387 8388 8389 8390 8391 8392 8393 8394 8395 8396 8397 8398 8399 8400 8401 8402 8403 8404 8405 8406 8407 8408 8409 8410 8411 8412 8413 8414 8415 8416 8417 8418 8419 8420 8421 8422 8423 8424 8425 8426 8427 8428 8429 8430 8431 8432 8433 8434 8435 8436 8437 8438 8439 8440 8441 8442 8443 8444 8445 8446 8447 8448 8449 8450 8451 8452 8453 8454 8455 8456 8457 8458 8459 8460 8461 8462 8463 8464 8465 8466 8467 8468 8469 8470 8471 8472 8473 8474 8475 8476 8477 8478 8479 8480 8481 8482 8483 8484 8485 8486 8487 8488 8489 8490 8491 8492 8493 8494 8495 8496 8497 8498 8499 8500 8501 8502 8503 8504 8505 8506 8507 8508 8509 8510 8511 8512 8513 8514 8515 8516 8517 8518 8519 8520 8521 8522 8523 8524 8525 8526 8527 8528 8529 8530 8531 8532 8533 8534 8535 8536 8537 8538 8539 8540 8541 8542 8543 8544 8545 8546 8547 8548 8549 8550 8551 8552 8553 8554 8555 8556 8557 8558 8559 8560 8561 8562 8563 8564 8565 8566 8567 8568 8569 8570 8571 8572 8573 8574 8575 8576 8577 8578 8579 8580 8581 8582 8583 8584 8585 8586 8587 8588 8589 8590 8591 8592 8593 8594 8595 8596 8597 8598 8599 8600 8601 8602 8603 8604 8605 8606 8607 8608 8609 8610 8611 8612 8613 8614 8615 8616 8617 8618 8619 8620 8621 8622 8623 8624 8625 8626 8627 8628 8629 8630 8631 8632 8633 8634 8635 8636 8637 8638 8639 8640 8641 8642 8643 8644 8645 8646 8647 8648 8649 8650 8651 8652 8653 8654 8655 8656 8657 8658 8659 8660 8661 8662 8663 8664 8665 8666 8667 8668 8669 8670 8671 8672 8673 8674 8675 8676 8677 8678 8679 8680 8681 8682 8683 8684 8685 8686 8687 8688 8689 8690 8691 8692 8693 8694 8695 8696 8697 8698 8699 8700 8701 8702 8703 8704 8705 8706 8707 8708 8709 8710 8711 8712 8713 8714 8715 8716 8717 8718 8719 8720 8721 8722 8723 8724 8725 8726 8727 8728 8729 8730 8731 8732 8733 8734 8735 8736 8737 8738 8739 8740 8741 8742 8743 8744 8745 8746 8747 8748 8749 8750 8751 8752 8753 8754 8755 8756 8757 8758 8759 8760 8761 8762 8763 8764 8765 8766 8767 8768 8769 8770 8771 8772 8773 8774 8775 8776 8777 8778 8779 8780 8781 8782 8783 8784 8785 8786 8787 8788 8789 8790 8791 8792 8793 8794 8795 8796 8797 8798 8799 8800 8801 8802 8803 8804 8805 8806 8807 8808 8809 8810 8811 8812 8813 8814 8815 8816 8817 8818 8819 8820 8821 8822 8823 8824 8825 8826 8827 8828 8829 8830 8831 8832 8833 8834 8835 8836 8837 8838 8839 8840 8841 8842 8843 8844 8845 8846 8847 8848 8849 8850 8851 8852 8853 8854 8855 8856 8857 8858 8859 8860 8861 8862 8863 8864 8865 8866 8867 8868 8869 8870 8871 8872 8873 8874 8875 8876 8877 8878 8879 8880 8881 8882 8883 8884 8885 8886 8887 8888 8889 8890 8891 8892 8893 8894 8895 8896 8897 8898 8899 8900 8901 8902 8903 8904 8905 8906 8907 8908 8909 8910 8911 8912 8913 8914 8915 8916 8917 8918 8919 8920 8921 8922 8923 8924 8925 8926 8927 8928 8929 8930 8931 8932 8933 8934 8935 8936 8937 8938 8939 8940 8941 8942 8943 8944 8945 8946 8947 8948 8949 8950 8951 8952 8953 8954 8955 8956 8957 8958 8959 8960 8961 8962 8963 8964 8965 8966 8967 8968 8969 8970 8971 8972 8973 8974 8975 8976 8977 8978 8979 8980 8981 8982 8983 8984 8985 8986 8987 8988 8989 8990 8991 8992 8993 8994 8995 8996 8997 8998 8999 9000 9001 9002 9003 9004 9005 9006 9007 9008 9009 9010 9011 9012 9013 9014 9015 9016 9017 9018 9019 9020 9021 9022 9023 9024 9025 9026 9027 9028 9029 9030 9031 9032 9033 9034 9035 9036 9037 9038 9039 9040 9041 9042 9043 9044 9045 9046 9047 9048 9049 9050 9051 9052 9053 9054 9055 9056 9057 9058 9059 9060 9061 9062 9063 9064 9065 9066 9067 9068 9069 9070 9071 9072 9073 9074 9075 9076 9077 9078 9079 9080 9081 9082 9083 9084 9085 9086 9087 9088 9089 9090 9091 9092 9093 9094 9095 9096 9097 9098 9099 9100 9101 9102 9103 9104 9105 9106 9107 9108 9109 9110 9111 9112 9113 9114 9115 9116 9117 9118 9119 9120 9121 9122 9123 9124 9125 9126 9127 9128 9129 9130 9131 9132 9133 9134 9135 9136 9137 9138 9139 9140 9141 9142 9143 9144 9145 9146 9147 9148 9149 9150 9151 9152 9153 9154 9155 9156 9157 9158 9159 9160 9161 9162 9163 9164 9165 9166 9167 9168 9169 9170 9171 9172 9173 9174 9175 9176 9177 9178 9179 9180 9181 9182 9183 9184 9185 9186 9187 9188 9189 9190 9191 9192 9193 9194 9195 9196 9197 9198 9199 9200 9201 9202 9203 9204 9205 9206 9207 9208 9209 9210 9211 9212 9213 9214 9215 9216 9217 9218 9219 9220 9221 9222 9223 9224 9225 9226 9227 9228 9229 9230 9231 9232 9233 9234 9235 9236 9237 9238 9239 9240 9241 9242 9243 9244 9245 9246 9247 9248 9249 9250 9251 9252 9253 9254 9255 9256 9257 9258 9259 9260 9261 9262 9263 9264 9265 9266 9267 9268 9269 9270 9271 9272 9273 9274 9275 9276 9277 9278 9279 9280 9281 9282 9283 9284 9285 9286 9287 9288 9289 9290 9291 9292 9293 9294 9295 9296 9297 9298 9299 9300 9301 9302 9303 9304 9305 9306 9307 9308 9309 9310 9311 9312 9313 9314 9315 9316 9317 9318 9319 9320 9321 9322 9323 9324 9325 9326 9327 9328 9329 9330 9331 9332 9333 9334 9335 9336 9337 9338 9339 9340 9341 9342 9343 9344 9345 9346 9347 9348 9349 9350 9351 9352 9353 9354 9355 9356 9357 9358 9359 9360 9361 9362 9363 9364 9365 9366 9367 9368 9369 9370 9371 9372 9373 9374 9375 9376 9377 9378 9379 9380 9381 9382 9383 9384 9385 9386 9387 9388 9389 9390 9391 9392 9393 9394 9395 9396 9397 9398 9399 9400 9401 9402 9403 9404 9405 9406 9407 9408 9409 9410 9411 9412 9413 9414 9415 9416 9417 9418 9419 9420 9421 9422 9423 9424 9425 9426 9427 9428 9429 9430 9431 9432 9433 9434 9435 9436 9437 9438 9439 9440 9441 9442 9443 9444 9445 9446 9447 9448 9449 9450 9451 9452 9453 9454 9455 9456 9457 9458 9459 9460 9461 9462 9463 9464 9465 9466 9467 9468 9469 9470 9471 9472 9473 9474 9475 9476 9477 9478 9479 9480 9481 9482 9483 9484 9485 9486 9487 9488 9489 9490 9491 9492 9493 9494 9495 9496 9497 9498 9499 9500 9501 9502 9503 9504 9505 9506 9507 9508 9509 9510 9511 9512 9513 9514 9515 9516 9517 9518 9519 9520 9521 9522 9523 9524 9525 9526 9527 9528 9529 9530 9531 9532 9533 9534 9535 9536 9537 9538 9539 9540 9541 9542 9543 9544 9545 9546 9547 9548 9549 9550 9551 9552 9553 9554 9555 9556 9557 9558 9559 9560 9561 9562 9563 9564 9565 9566 9567 9568 9569 9570 9571 9572 9573 9574 9575 9576 9577 9578 9579 9580 9581 9582 9583 9584 9585 9586 9587 9588 9589 9590 9591 9592 9593 9594 9595 9596 9597 9598 9599 9600 9601 9602 9603 9604 9605 9606 9607 9608 9609 9610 9611 9612 9613 9614 9615 9616 9617 9618 9619 9620 9621 9622 9623 9624 9625 9626 9627 9628 9629 9630 9631 9632 9633 9634 9635 9636 9637 9638 9639 9640 9641 9642 9643 9644 9645 9646 9647 9648 9649 9650 9651 9652 9653 9654 9655 9656 9657 9658 9659 9660 9661 9662 9663 9664 9665 9666 9667 9668 9669 9670 9671 9672 9673 9674 9675 9676 9677 9678 9679 9680 9681 9682 9683 9684 9685 9686 9687 9688 9689 9690 9691 9692 9693 9694 9695 9696 9697 9698 9699 9700 9701 9702 9703 9704 9705 9706 9707 9708 9709 9710 9711 9712 9713 9714 9715 9716 9717 9718 9719 9720 9721 9722 9723 9724 9725 9726 9727 9728 9729 9730 9731 9732 9733 9734 9735 9736 9737 9738 9739 9740 9741 9742 9743 9744 9745 9746 9747 9748 9749 9750 9751 9752 9753 9754 9755 9756 9757 9758 9759 9760 9761 9762 9763 9764 9765 9766 9767 9768 9769 9770 9771 9772 9773 9774 9775 9776 9777 9778 9779 9780 9781 9782 9783 9784 9785 9786 9787 9788 9789 9790 9791 9792 9793 9794 9795 9796 9797 9798 9799 9800 9801 9802 9803 9804 9805 9806 9807 9808 9809 9810 9811 9812 9813 9814 9815 9816 9817 9818 9819 9820 9821 9822 9823 9824 9825 9826 9827 9828 9829 9830 9831 9832 9833 9834 9835 9836 9837 9838 9839 9840 9841 9842 9843 9844 9845 9846 9847 9848 9849 9850 9851 9852 9853 9854 9855 9856 9857 9858 9859 9860 9861 9862 9863 9864 9865 9866 9867 9868 9869 9870 9871 9872 9873 9874 9875 9876 9877 9878 9879 9880 9881 9882 9883 9884 9885 9886 9887 9888 9889 9890 9891 9892 9893 9894 9895 9896 9897 9898 9899 9900 9901 9902 9903 9904 9905 9906 9907 9908 9909 9910 9911 9912 9913 9914 9915 9916 9917 9918 9919 9920 9921 9922 9923 9924 9925 9926 9927 9928 9929 9930 9931 9932 9933 9934 9935 9936 9937 9938 9939 9940 9941 9942 9943 9944 9945 9946 9947 9948 9949 9950 9951 9952 9953 9954 9955 9956 9957 9958 9959 9960 9961 9962 9963 9964 9965 9966 9967 9968 9969 9970 9971 9972 9973 9974 9975 9976 9977 9978 9979 9980 9981 9982 9983 9984 9985 9986 9987 9988 9989 9990 9991 9992 9993 9994 9995 9996 9997 9998 9999 10000 10001 10002 10003 10004 10005 10006 10007 10008 10009 10010 10011 10012 10013 10014 10015 10016 10017 10018 10019 10020 10021 10022 10023 10024 10025 10026 10027 10028 10029 10030 10031 10032 10033 10034 10035 10036 10037 10038 10039 10040 10041 10042 10043 10044 10045 10046 10047 10048 10049 10050 10051 10052 10053 10054 10055 10056 10057 10058 10059 10060 10061 10062 10063 10064 10065 10066 10067 10068 10069 10070 10071 10072 10073 10074 10075 10076 10077 10078 10079 10080 10081 10082 10083 10084 10085 10086 10087 10088 10089 10090 10091 10092 10093 10094 10095 10096 10097 10098 10099 10100 10101 10102 10103 10104 10105 10106 10107 10108 10109 10110 10111 10112 10113 10114 10115 10116 10117 10118 10119 10120 10121 10122 10123 10124 10125 10126 10127 10128 10129 10130 10131 10132 10133 10134 10135 10136 10137 10138 10139 10140 10141 10142 10143 10144 10145 10146 10147 10148 10149 10150 10151 10152 10153 10154 10155 10156 10157 10158 10159 10160 10161 10162 10163 10164 10165 10166 10167 10168 10169 10170 10171 10172 10173 10174 10175 10176 10177 10178 10179 10180 10181 10182 10183 10184 10185 10186 10187 10188 10189 10190 10191 10192 10193 10194 10195 10196 10197 10198 10199 10200 10201 10202 10203 10204 10205 10206 10207 10208 10209 10210 10211 10212 10213 10214 10215 10216 10217 10218 10219 10220 10221 10222 10223 10224 10225 10226 10227 10228 10229 10230 10231 10232 10233 10234 10235 10236 10237 10238 10239 10240 10241 10242 10243 10244 10245 10246 10247 10248 10249 10250 10251 10252 10253 10254 10255 10256 10257 10258 10259 10260 10261 10262 10263 10264 10265 10266 10267 10268 10269 10270 10271 10272 10273 10274 10275 10276 10277 10278 10279 10280 10281 10282 10283 10284 10285 10286 10287 10288 10289 10290 10291 10292 10293 10294 10295 10296 10297 10298 10299 10300 10301 10302 10303 10304 10305 10306 10307 10308 10309 10310 10311 10312 10313 10314 10315 10316 10317 10318 10319 10320 10321 10322 10323 10324 10325 10326 10327 10328 10329 10330 10331 10332 10333 10334 10335 10336 10337 10338 10339 10340 10341 10342 10343 10344 10345 10346 10347 10348 10349 10350 10351 10352 10353 10354 10355 10356 10357 10358 10359 10360 10361 10362 10363 10364 10365 10366 10367 10368 10369 10370 10371 10372 10373 10374 10375 10376 10377 10378 10379 10380 10381 10382 10383 10384 10385 10386 10387 10388 10389 10390 10391 10392 10393 10394 10395 10396 10397 10398 10399 10400 10401 10402 10403 10404 10405 10406 10407 10408 10409 10410 10411 10412 10413 10414 10415 10416 10417 10418 10419 10420 10421 10422 10423 10424 10425 10426 10427 10428 10429 10430 10431 10432 10433 10434 10435 10436 10437 10438 10439 10440 10441 10442 10443 10444 10445 10446 10447 10448 10449 10450 10451 10452 10453 10454 10455 10456 10457 10458 10459 10460 10461 10462 10463 10464 10465 10466 10467 10468 10469 10470 10471 10472 10473 10474 10475 10476 10477 10478 10479 10480 10481 10482 10483 10484 10485 10486 10487 10488 10489 10490 10491 10492 10493 10494 10495 10496 10497 10498 10499 10500 10501 10502 10503 10504 10505 10506 10507 10508 10509 10510 10511 10512 10513 10514 10515 10516 10517 10518 10519 10520 10521 10522 10523 10524 10525 10526 10527 10528 10529 10530 10531 10532 10533 10534 10535 10536 10537 10538 10539 10540 10541 10542 10543 10544 10545 10546 10547 10548 10549 10550 10551 10552 10553 10554 10555 10556 10557 10558 10559 10560 10561 10562 10563 10564 10565 10566 10567 10568 10569 10570 10571 10572 10573 10574 10575 10576 10577 10578 10579 10580 10581 10582 10583 10584 10585 10586 10587 10588 10589 10590 10591 10592 10593 10594 10595 10596 10597 10598 10599 10600 10601 10602 10603 10604 10605 10606 10607 10608 10609 10610 10611 10612 10613 10614 10615 10616 10617 10618 10619 10620 10621 10622 10623 10624 10625 10626 10627 10628 10629 10630 10631 10632 10633 10634 10635 10636 10637 10638 10639 10640 10641 10642 10643 10644 10645 10646 10647 10648 10649 10650 10651 10652 10653 10654 10655 10656 10657 10658 10659 10660 10661 10662 10663 10664 10665 10666 10667 10668 10669 10670 10671 10672 10673 10674 10675 10676 10677 10678 10679 10680 10681 10682 10683 10684 10685 10686 10687 10688 10689 10690 10691 10692 10693 10694 10695 10696 10697 10698 10699 10700 10701 10702 10703 10704 10705 10706 10707 10708 10709 10710 10711 10712 10713 10714 10715 10716 10717 10718 10719 10720 10721 10722 10723 10724 10725 10726 10727 10728 10729 10730 10731 10732 10733 10734 10735 10736 10737 10738 10739 10740 10741 10742 10743 10744 10745 10746 10747 10748 10749 10750 10751 10752 10753 10754 10755 10756 10757 10758 10759 10760 10761 10762 10763 10764 10765 10766 10767 10768 10769 10770 10771 10772 10773 10774 10775 10776 10777 10778 10779 10780 10781 10782 10783 10784 10785 10786 10787 10788 10789 10790 10791 10792 10793 10794 10795 10796 10797 10798 10799 10800 10801 10802 10803 10804 10805 10806 10807 10808 10809 10810 10811 10812 10813 10814 10815 10816 10817 10818 10819 10820 10821 10822 10823 10824 10825 10826 10827 10828 10829 10830 10831 10832 10833 10834 10835 10836 10837 10838 10839 10840 10841 10842 10843 10844 10845 10846 10847 10848 10849 10850 10851 10852 10853 10854 10855 10856 10857 10858 10859 10860 10861 10862 10863 10864 10865 10866 10867 10868 10869 10870 10871 10872 10873 10874 10875 10876 10877 10878 10879 10880 10881 10882 10883 10884 10885 10886 10887 10888 10889 10890 10891 10892 10893 10894 10895 10896 10897 10898 10899 10900 10901 10902 10903 10904 10905 10906 10907 10908 10909 10910 10911 10912 10913 10914 10915 10916 10917 10918 10919 10920 10921 10922 10923 10924 10925 10926 10927 10928 10929 10930 10931 10932 10933 10934 10935 10936 10937 10938 10939 10940 10941 10942 10943 10944 10945 10946 10947 10948 10949 10950 10951 10952 10953 10954 10955 10956 10957 10958 10959 10960 10961 10962 10963 10964 10965 10966 10967 10968 10969 10970 10971 10972 10973 10974 10975 10976 10977 10978 10979 10980 10981 10982 10983 10984 10985 10986 10987 10988 10989 10990 10991 10992 10993 10994 10995 10996 10997 10998 10999 11000 11001 11002 11003 11004 11005 11006 11007 11008 11009 11010 11011 11012 11013 11014 11015 11016 11017 11018 11019 11020 11021 11022 11023 11024 11025 11026 11027 11028 11029 11030 11031 11032 11033 11034 11035 11036 11037 11038 11039 11040 11041 11042 11043 11044 11045 11046 11047 11048 11049 11050 11051 11052 11053 11054 11055 11056 11057 11058 11059 11060 11061 11062 11063 11064 11065 11066 11067 11068 11069 11070 11071 11072 11073 11074 11075 11076 11077 11078 11079 11080 11081 11082 11083 11084 11085 11086 11087 11088 11089 11090 11091 11092 11093 11094 11095 11096 11097 11098 11099 11100 11101 11102 11103 11104 11105 11106 11107 11108 11109 11110 11111 11112 11113 11114 11115 11116 11117 11118 11119 11120 11121 11122 11123 11124 11125 11126 11127 11128 11129 11130 11131 11132 11133 11134 11135 11136 11137 11138 11139 11140 11141 11142 11143 11144 11145 11146 11147 11148 11149 11150 11151 11152 11153 11154 11155 11156 11157 11158 11159 11160 11161 11162 11163 11164 11165 11166 11167 11168 11169 11170 11171 11172 11173 11174 11175 11176 11177 11178 11179 11180 11181 11182 11183 11184 11185 11186 11187 11188 11189 11190 11191 11192 11193 11194 11195 11196 11197 11198 11199 11200 11201 11202 11203 11204 11205 11206 11207 11208 11209 11210 11211 11212 11213 11214 11215 11216 11217 11218 11219 11220 11221 11222 11223 11224 11225 11226 11227 11228 11229 11230 11231 11232 11233 11234 11235 11236 11237 11238 11239 11240 11241 11242 11243 11244 11245 11246 11247 11248 11249 11250 11251 11252 11253 11254 11255 11256 11257 11258 11259 11260 11261 11262 11263 11264 11265 11266 11267 11268 11269 11270 11271 11272 11273 11274 11275 11276 11277 11278 11279 11280 11281 11282 11283 11284 11285 11286 11287 11288 11289 11290 11291 11292 11293 11294 11295 11296 11297 11298 11299 11300 11301 11302 11303 11304 11305 11306 11307 11308 11309 11310 11311 11312 11313 11314 11315 11316 11317 11318 11319 11320 11321 11322 11323 11324 11325 11326 11327 11328 11329 11330 11331 11332 11333 11334 11335 11336 11337 11338 11339 11340 11341 11342 11343 11344 11345 11346 11347 11348 11349 11350 11351 11352 11353 11354 11355 11356 11357 11358 11359 11360 11361 11362 11363 11364 11365 11366 11367 11368 11369 11370 11371 11372 11373 11374 11375 11376 11377 11378 11379 11380 11381 11382 11383 11384 11385 11386 11387 11388 11389 11390 11391 11392 11393 11394 11395 11396 11397 11398 11399 11400 11401 11402 11403 11404 11405 11406 11407 11408 11409 11410 11411 11412 11413 11414 11415 11416 11417 11418 11419 11420 11421 11422 11423 11424 11425 11426 11427 11428 11429 11430 11431 11432 11433 11434 11435 11436 11437 11438 11439 11440 11441 11442 11443 11444 11445 11446 11447 11448 11449 11450 11451 11452 11453 11454 11455 11456 11457 11458 11459 11460 11461 11462 11463 11464 11465 11466 11467 11468 11469 11470 11471 11472 11473 11474 11475 11476 11477 11478 11479 11480 11481 11482 11483 11484 11485 11486 11487 11488 11489 11490 11491 11492 11493 11494 11495 11496 11497 11498 11499 11500 11501 11502 11503 11504 11505 11506 11507 11508 11509 11510 11511 11512 11513 11514 11515 11516 11517 11518 11519 11520 11521 11522 11523 11524 11525 11526 11527 11528 11529 11530 11531 11532 11533 11534 11535 11536 11537 11538 11539 11540 11541 11542 11543 11544 11545 11546 11547 11548 11549 11550 11551 11552 11553 11554 11555 11556 11557 11558 11559 11560 11561 11562 11563 11564 11565 11566 11567 11568 11569 11570 11571 11572 11573 11574 11575 11576 11577 11578 11579 11580 11581 11582 11583 11584 11585 11586 11587 11588 11589 11590 11591 11592 11593 11594 11595 11596 11597 11598 11599 11600 11601 11602 11603 11604 11605 11606 11607 11608 11609 11610 11611 11612 11613 11614 11615 11616 11617 11618 11619 11620 11621 11622 11623 11624 11625 11626 11627 11628 11629 11630 11631 11632 11633 11634 11635 11636 11637 11638 11639 11640 11641 11642 11643 11644 11645 11646 11647 11648 11649 11650 11651 11652 11653 11654 11655 11656 11657 11658 11659 11660 11661 11662 11663 11664 11665 11666 11667 11668 11669 11670 11671 11672 11673 11674 11675 11676 11677 11678 11679 11680 11681 11682 11683 11684 11685 11686 11687 11688 11689 11690 11691 11692 11693 11694 11695 11696 11697 11698 11699 11700 11701 11702 11703 11704 11705 11706 11707 11708 11709 11710 11711 11712 11713 11714 11715 11716 11717 11718 11719 11720 11721 11722 11723 11724 11725 11726 11727 11728 11729 11730 11731 11732 11733 11734 11735 11736 11737 11738 11739 11740 11741 11742 11743 11744 11745 11746 11747 11748 11749 11750 11751 11752 11753 11754 11755 11756 11757 11758 11759 11760 11761 11762 11763 11764 11765 11766 11767 11768 11769 11770 11771 11772 11773 11774 11775 11776 11777 11778 11779 11780 11781 11782 11783 11784 11785 11786 11787 11788 11789 11790 11791 11792 11793 11794 11795 11796 11797 11798 11799 11800 11801 11802 11803 11804 11805 11806 11807 11808 11809 11810 11811 11812 11813 11814 11815 11816 11817 11818 11819 11820 11821 11822 11823 11824 11825 11826 11827 11828 11829 11830 11831 11832 11833 11834 11835 11836 11837 11838 11839 11840 11841 11842 11843 11844 11845 11846 11847 11848 11849 11850 11851 11852 11853 11854 11855 11856 11857 11858 11859 11860 11861 11862 11863 11864 11865 11866 11867 11868 11869 11870 11871 11872 11873 11874 11875 11876 11877 11878 11879 11880 11881 11882 11883 11884 11885 11886 11887 11888 11889 11890 11891 11892 11893 11894 11895 11896 11897 11898 11899 11900 11901 11902 11903 11904 11905 11906 11907 11908 11909 11910 11911 11912 11913 11914 11915 11916 11917 11918 11919 11920 11921 11922 11923 11924 11925 11926 11927 11928 11929 11930 11931 11932 11933 11934 11935 11936 11937 11938 11939 11940 11941 11942 11943 11944 11945 11946 11947 11948 11949 11950 11951 11952 11953 11954 11955 11956 11957 11958 11959 11960 11961 11962 11963 11964 11965 11966 11967 11968 11969 11970 11971 11972 11973 11974 11975 11976 11977 11978 11979 11980 11981 11982 11983 11984 11985 11986 11987 11988 11989 11990 11991 11992 11993 11994 11995 11996 11997 11998 11999 12000 12001 12002 12003 12004 12005 12006 12007 12008 12009 12010 12011 12012 12013 12014 12015 12016 12017 12018 12019 12020 12021 12022 12023 12024 12025 12026 12027 12028 12029 12030 12031 12032 12033 12034 12035 12036 12037 12038 12039 12040 12041 12042 12043 12044 12045 12046 12047 12048 12049 12050 12051 12052 12053 12054 12055 12056 12057 12058 12059 12060 12061 12062 12063 12064 12065 12066 12067 12068 12069 12070 12071 12072 12073 12074 12075 12076 12077 12078 12079 12080 12081 12082 12083 12084 12085 12086 12087 12088 12089 12090 12091 12092 12093 12094 12095 12096 12097 12098 12099 12100 12101 12102 12103 12104 12105 12106 12107 12108 12109 12110 12111 12112 12113 12114 12115 12116 12117 12118 12119 12120 12121 12122 12123 12124 12125 12126 12127 12128 12129 12130 12131 12132 12133 12134 12135 12136 12137 12138 12139 12140 12141 12142 12143 12144 12145 12146 12147 12148 12149 12150 12151 12152 12153 12154 12155 12156 12157 12158 12159 12160 12161 12162 12163 12164 12165 12166 12167 12168 12169 12170 12171 12172 12173 12174 12175 12176 12177 12178 12179 12180 12181 12182 12183 12184 12185 12186 12187 12188 12189 12190 12191 12192 12193 12194 12195 12196 12197 12198 12199 12200 12201 12202 12203 12204 12205 12206 12207 12208 12209 12210 12211 12212 12213 12214 12215 12216 12217 12218 12219 12220 12221 12222 12223 12224 12225 12226 12227 12228 12229 12230 12231 12232 12233 12234 12235 12236 12237 12238 12239 12240 12241 12242 12243 12244 12245 12246 12247 12248 12249 12250 12251 12252 12253 12254 12255 12256 12257 12258 12259 12260 12261 12262 12263 12264 12265 12266 12267 12268 12269 12270 12271 12272 12273 12274 12275 12276 12277 12278 12279 12280 12281 12282 12283 12284 12285 12286 12287 12288 12289 12290 12291 12292 12293 12294 12295 12296 12297 12298 12299 12300 12301 12302 12303 12304 12305 12306 12307 12308 12309 12310 12311 12312 12313 12314 12315 12316 12317 12318 12319 12320 12321 12322 12323 12324 12325 12326 12327 12328 12329 12330 12331 12332 12333 12334 12335 12336 12337 12338 12339 12340 12341 12342 12343 12344 12345 12346 12347 12348 12349 12350 12351 12352 12353 12354 12355 12356 12357 12358 12359 12360 12361 12362 12363 12364 12365 12366 12367 12368 12369 12370 12371 12372 12373 12374 12375 12376 12377 12378 12379 12380 12381 12382 12383 12384 12385 12386 12387 12388 12389 12390 12391 12392 12393 12394 12395 12396 12397 12398 12399 12400 12401 12402 12403 12404 12405 12406 12407 12408 12409 12410 12411 12412 12413 12414 12415 12416 12417 12418 12419 12420 12421 12422 12423 12424 12425 12426 12427 12428 12429 12430 12431 12432 12433 12434 12435 12436 12437 12438 12439 12440 12441 12442 12443 12444 12445 12446 12447 12448 12449 12450 12451 12452 12453 12454 12455 12456 12457 12458 12459 12460 12461 12462 12463 12464 12465 12466 12467 12468 12469 12470 12471 12472 12473 12474 12475 12476 12477 12478 12479 12480 12481 12482 12483 12484 12485 12486 12487 12488 12489 12490 12491 12492 12493 12494 12495 12496 12497 12498 12499 12500 12501 12502 12503 12504 12505 12506 12507 12508 12509 12510 12511 12512 12513 12514 12515 12516 12517 12518 12519 12520 12521 12522 12523 12524 12525 12526 12527 12528 12529 12530 12531 12532 12533 12534 12535 12536 12537 12538 12539 12540 12541 12542 12543 12544 12545 12546 12547 12548 12549 12550 12551 12552 12553 12554 12555 12556 12557 12558 12559 12560 12561 12562 12563 12564 12565 12566 12567 12568 12569 12570 12571 12572 12573 12574 12575 12576 12577 12578 12579 12580 12581 12582 12583 12584 12585 12586 12587 12588 12589 12590 12591 12592 12593 12594 12595 12596 12597 12598 12599 12600 12601 12602 12603 12604 12605 12606 12607 12608 12609 12610 12611 12612 12613 12614 12615 12616 12617 12618 12619 12620 12621 12622 12623 12624 12625 12626 12627 12628 12629 12630 12631 12632 12633 12634 12635 12636 12637 12638 12639 12640 12641 12642 12643 12644 12645 12646 12647 12648 12649 12650 12651 12652 12653 12654 12655 12656 12657 12658 12659 12660 12661 12662 12663 12664 12665 12666 12667 12668 12669 12670 12671 12672 12673 12674 12675 12676 12677 12678 12679 12680 12681 12682 12683 12684 12685 12686 12687 12688 12689 12690 12691 12692 12693 12694 12695 12696 12697 12698 12699 12700 12701 12702 12703 12704 12705 12706 12707 12708 12709 12710 12711 12712 12713 12714 12715 12716 12717 12718 12719 12720 12721 12722 12723 12724 12725 12726 12727 12728 12729 12730 12731 12732 12733 12734 12735 12736 12737 12738 12739 12740 12741 12742 12743 12744 12745 12746 12747 12748 12749 12750 12751 12752 12753 12754 12755 12756 12757 12758 12759 12760 12761 12762 12763 12764 12765 12766 12767 12768 12769 12770 12771 12772 12773 12774 12775 12776 12777 12778 12779 12780 12781 12782 12783 12784 12785 12786 12787 12788 12789 12790 12791 12792 12793 12794 12795 12796 12797 12798 12799 12800 12801 12802 12803 12804 12805 12806 12807 12808 12809 12810 12811 12812 12813 12814 12815 12816 12817 12818 12819 12820 12821 12822 12823 12824 12825 12826 12827 12828 12829 12830 12831 12832 12833 12834 12835 12836 12837 12838 12839 12840 12841 12842 12843 12844 12845 12846 12847 12848 12849 12850 12851 12852 12853 12854 12855 12856 12857 12858 12859 12860 12861 12862 12863 12864 12865 12866 12867 12868 12869 12870 12871 12872 12873 12874 12875 12876 12877 12878 12879 12880 12881 12882 12883 12884 12885 12886 12887 12888 12889 12890 12891 12892 12893 12894 12895 12896 12897 12898 12899 12900 12901 12902 12903 12904 12905 12906 12907 12908 12909 12910 12911 12912 12913 12914 12915 12916 12917 12918 12919 12920 12921 12922 12923 12924 12925 12926 12927 12928 12929 12930 12931 12932 12933 12934 12935 12936 12937 12938 12939 12940 12941 12942 12943 12944 12945 12946 12947 12948 12949 12950 12951 12952 12953 12954 12955 12956 12957 12958 12959 12960 12961 12962 12963 12964 12965 12966 12967 12968 12969 12970 12971 12972 12973 12974 12975 12976 12977 12978 12979 12980 12981 12982 12983 12984 12985 12986 12987 12988 12989 12990 12991 12992 12993 12994 12995 12996 12997 12998 12999 13000 13001 13002 13003 13004 13005 13006 13007 13008 13009 13010 13011 13012 13013 13014 13015 13016 13017 13018 13019 13020 13021 13022 13023 13024 13025 13026 13027 13028 13029 13030 13031 13032 13033 13034 13035 13036 13037 13038 13039 13040 13041 13042 13043 13044 13045 13046 13047 13048 13049 13050 13051 13052 13053 13054 13055 13056 13057 13058 13059 13060 13061 13062 13063 13064 13065 13066 13067 13068 13069 13070 13071 13072 13073 13074 13075 13076 13077 13078 13079 13080 13081 13082 13083 13084 13085 13086 13087 13088 13089 13090 13091 13092 13093 13094 13095 13096 13097 13098 13099 13100 13101 13102 13103 13104 13105 13106 13107 13108 13109 13110 13111 13112 13113 13114 13115 13116 13117 13118 13119 13120 13121 13122 13123 13124 13125 13126 13127 13128 13129 13130 13131 13132 13133 13134 13135 13136 13137 13138 13139 13140 13141 13142 13143 13144 13145 13146 13147 13148 13149 13150 13151 13152 13153 13154 13155 13156 13157 13158 13159 13160 13161 13162 13163 13164 13165 13166 13167 13168 13169 13170 13171 13172 13173 13174 13175 13176 13177 13178 13179 13180 13181 13182 13183 13184 13185 13186 13187 13188 13189 13190 13191 13192 13193 13194 13195 13196 13197 13198 13199 13200 13201 13202 13203 13204 13205 13206 13207 13208 13209 13210 13211 13212 13213 13214 13215 13216 13217 13218 13219 13220 13221 13222 13223 13224 13225 13226 13227 13228 13229 13230 13231 13232 13233 13234 13235 13236 13237 13238 13239 13240 13241 13242 13243 13244 13245 13246 13247 13248 13249 13250 13251 13252 13253 13254 13255 13256 13257 13258 13259 13260 13261 13262 13263 13264 13265 13266 13267 13268 13269 13270 13271 13272 13273 13274 13275 13276 13277 13278 13279 13280 13281 13282 13283 13284 13285 13286 13287 13288 13289 13290 13291 13292 13293 13294 13295 13296 13297 13298 13299 13300 13301 13302 13303 13304 13305 13306 13307 13308 13309 13310 13311 13312 13313 13314 13315 13316 13317 13318 13319 13320 13321 13322 13323 13324 13325 13326 13327 13328 13329 13330 13331 13332 13333 13334 13335 13336 13337 13338 13339 13340 13341 13342 13343 13344 13345 13346 13347 13348 13349 13350 13351 13352 13353 13354 13355 13356 13357 13358 13359 13360 13361 13362 13363 13364 13365 13366 13367 13368 13369 13370 13371 13372 13373 13374 13375 13376 13377 13378 13379 13380 13381 13382 13383 13384 13385 13386 13387 13388 13389 13390 13391 13392 13393 13394 13395 13396 13397 13398 13399 13400 13401 13402 13403 13404 13405 13406 13407 13408 13409 13410 13411 13412 13413 13414 13415 13416 13417 13418 13419 13420 13421 13422 13423 13424 13425 13426 13427 13428 13429 13430 13431 13432 13433 13434 13435 13436 13437 13438 13439 13440 13441 13442 13443 13444 13445 13446 13447 13448 13449 13450 13451 13452 13453 13454 13455 13456 13457 13458 13459 13460 13461 13462 13463 13464 13465 13466 13467 13468 13469 13470 13471 13472 13473 13474 13475 13476 13477 13478 13479 13480 13481 13482 13483 13484 13485 13486 13487 13488 13489 13490 13491 13492 13493 13494 13495 13496 13497 13498 13499 13500 13501 13502 13503 13504 13505 13506 13507 13508 13509 13510 13511 13512 13513 13514 13515 13516 13517 13518 13519 13520 13521 13522 13523 13524 13525 13526 13527 13528 13529 13530 13531 13532 13533 13534 13535 13536 13537 13538 13539 13540 13541 13542 13543 13544 13545 13546 13547 13548 13549 13550 13551 13552 13553 13554 13555 13556 13557 13558 13559 13560 13561 13562 13563 13564 13565 13566 13567 13568 13569 13570 13571 13572 13573 13574 13575 13576 13577 13578 13579 13580 13581 13582 13583 13584 13585 13586 13587 13588 13589 13590 13591 13592 13593 13594 13595 13596 13597 13598 13599 13600 13601 13602 13603 13604 13605 13606 13607 13608 13609 13610 13611 13612 13613 13614 13615 13616 13617 13618 13619 13620 13621 13622 13623 13624 13625 13626 13627 13628 13629 13630 13631 13632 13633 13634 13635 13636 13637 13638 13639 13640 13641 13642 13643 13644 13645 13646 13647 13648 13649 13650 13651 13652 13653 13654 13655 13656 13657 13658 13659 13660 13661 13662 13663 13664 13665 13666 13667 13668 13669 13670 13671 13672 13673 13674 13675 13676 13677 13678 13679 13680 13681 13682 13683 13684 13685 13686 13687 13688 13689 13690 13691 13692 13693 13694 13695 13696 13697 13698 13699 13700 13701 13702 13703 13704 13705 13706 13707 13708 13709 13710 13711 13712 13713 13714 13715 13716 13717 13718 13719 13720 13721 13722 13723 13724 13725 13726 13727 13728 13729 13730 13731 13732 13733 13734 13735 13736 13737 13738 13739 13740 13741 13742 13743 13744 13745 13746 13747 13748 13749 13750 13751 13752 13753 13754 13755 13756 13757 13758 13759 13760 13761 13762 13763 13764 13765 13766 13767 13768 13769 13770 13771 13772 13773 13774 13775 13776 13777 13778 13779 13780 13781 13782 13783 13784 13785 13786 13787 13788 13789 13790 13791 13792 13793 13794 13795 13796 13797 13798 13799 13800 13801 13802 13803 13804 13805 13806 13807 13808 13809 13810 13811 13812 13813 13814 13815 13816 13817 13818 13819 13820 13821 13822 13823 13824 13825 13826 13827 13828 13829 13830 13831 13832 13833 13834 13835 13836 13837 13838 13839 13840 13841 13842 13843 13844 13845 13846 13847 13848 13849 13850 13851 13852 13853 13854 13855 13856 13857 13858 13859 13860 13861 13862 13863 13864 13865 13866 13867 13868 13869 13870 13871 13872 13873 13874 13875 13876 13877 13878 13879 13880 13881 13882 13883 13884 13885 13886 13887 13888 13889 13890 13891 13892 13893 13894 13895 13896 13897 13898 13899 13900 13901 13902 13903 13904 13905 13906 13907 13908 13909 13910 13911 13912 13913 13914 13915 13916 13917 13918 13919 13920 13921 13922 13923 13924 13925 13926 13927 13928 13929 13930 13931 13932 13933 13934 13935 13936 13937 13938 13939 13940 13941 13942 13943 13944 13945 13946 13947 13948 13949 13950 13951 13952 13953 13954 13955 13956 13957 13958 13959 13960 13961 13962 13963 13964 13965 13966 13967 13968 13969 13970 13971 13972 13973 13974 13975 13976 13977 13978 13979 13980 13981 13982 13983 13984 13985 13986 13987 13988 13989 13990 13991 13992 13993 13994 13995 13996 13997 13998 13999 14000 14001 14002 14003 14004 14005 14006 14007 14008 14009 14010 14011 14012 14013 14014 14015 14016 14017 14018 14019 14020 14021 14022 14023 14024 14025 14026 14027 14028 14029 14030 14031 14032 14033 14034 14035 14036 14037 14038 14039 14040 14041 14042 14043 14044 14045 14046 14047 14048 14049 14050 14051 14052 14053 14054 14055 14056 14057 14058 14059 14060 14061 14062 14063 14064 14065 14066 14067 14068 14069 14070 14071 14072 14073 14074 14075 14076 14077 14078 14079 14080 14081 14082 14083 14084 14085 14086 14087 14088 14089 14090 14091 14092 14093 14094 14095 14096 14097 14098 14099 14100 14101 14102 14103 14104 14105 14106 14107 14108 14109 14110 14111 14112 14113 14114 14115 14116 14117 14118 14119 14120 14121 14122 14123 14124 14125 14126 14127 14128 14129 14130 14131 14132 14133 14134 14135 14136 14137 14138 14139 14140 14141 14142 14143 14144 14145 14146 14147 14148 14149 14150 14151 14152 14153 14154 14155 14156 14157 14158 14159 14160 14161 14162 14163 14164 14165 14166 14167 14168 14169 14170 14171 14172 14173 14174 14175 14176 14177 14178 14179 14180 14181 14182 14183 14184 14185 14186 14187 14188 14189 14190 14191 14192 14193 14194 14195 14196 14197 14198 14199 14200 14201 14202 14203 14204 14205 14206 14207 14208 14209 14210 14211 14212 14213 14214 14215 14216 14217 14218 14219 14220 14221 14222 14223 14224 14225 14226 14227 14228 14229 14230 14231 14232 14233 14234 14235 14236 14237 14238 14239 14240 14241 14242 14243 14244 14245 14246 14247 14248 14249 14250 14251 14252 14253 14254 14255 14256 14257 14258 14259 14260 14261 14262 14263 14264 14265 14266 14267 14268 14269 14270 14271 14272 14273 14274 14275 14276 14277 14278 14279 14280 14281 14282 14283 14284 14285 14286 14287 14288 14289 14290 14291 14292 14293 14294 14295 14296 14297 14298 14299 14300 14301 14302 14303 14304 14305 14306 14307 14308 14309 14310 14311 14312 14313 14314 14315 14316 14317 14318 14319 14320 14321 14322 14323 14324 14325 14326 14327 14328 14329 14330 14331 14332 14333 14334 14335 14336 14337 14338 14339 14340 14341 14342 14343 14344 14345 14346 14347 14348 14349 14350 14351 14352 14353 14354 14355 14356 14357 14358 14359 14360 14361 14362 14363 14364 14365 14366 14367 14368 14369 14370 14371 14372 14373 14374 14375 14376 14377 14378 14379 14380 14381 14382 14383 14384 14385 14386 14387 14388 14389 14390 14391 14392 14393 14394 14395 14396 14397 14398 14399 14400 14401 14402 14403 14404 14405 14406 14407 14408 14409 14410 14411 14412 14413 14414 14415 14416 14417 14418 14419 14420 14421 14422 14423 14424 14425 14426 14427 14428 14429 14430 14431 14432 14433 14434 14435 14436 14437 14438 14439 14440 14441 14442 14443 14444 14445 14446 14447 14448 14449 14450 14451 14452 14453 14454 14455 14456 14457 14458 14459 14460 14461 14462 14463 14464 14465 14466 14467 14468 14469 14470 14471 14472 14473 14474 14475 14476 14477 14478 14479 14480 14481 14482 14483 14484 14485 14486 14487 14488 14489 14490 14491 14492 14493 14494 14495 14496 14497 14498 14499 14500 14501 14502 14503 14504 14505 14506 14507 14508 14509 14510 14511 14512 14513 14514 14515 14516 14517 14518 14519 14520 14521 14522 14523 14524 14525 14526 14527 14528 14529 14530 14531 14532 14533 14534 14535 14536 14537 14538 14539 14540 14541 14542 14543 14544 14545 14546 14547 14548 14549 14550 14551 14552 14553 14554 14555 14556 14557 14558 14559 14560 14561 14562 14563 14564 14565 14566 14567 14568 14569 14570 14571 14572 14573 14574 14575 14576 14577 14578 14579 14580 14581 14582 14583 14584 14585 14586 14587 14588 14589 14590 14591 14592 14593 14594 14595 14596 14597 14598 14599 14600 14601 14602 14603 14604 14605 14606 14607 14608 14609 14610 14611 14612 14613 14614 14615 14616 14617 14618 14619 14620 14621 14622 14623 14624 14625 14626 14627 14628 14629 14630 14631 14632 14633 14634 14635 14636 14637 14638 14639 14640 14641 14642 14643 14644 14645 14646 14647 14648 14649 14650 14651 14652 14653 14654 14655 14656 14657 14658 14659 14660 14661 14662 14663 14664 14665 14666 14667 14668 14669 14670 14671 14672 14673 14674 14675 14676 14677 14678 14679 14680 14681 14682 14683 14684 14685 14686 14687 14688 14689 14690 14691 14692 14693 14694 14695 14696 14697 14698 14699 14700 14701 14702 14703 14704 14705 14706 14707 14708 14709 14710 14711 14712 14713 14714 14715 14716 14717 14718 14719 14720 14721 14722 14723 14724 14725 14726 14727 14728 14729 14730 14731 14732 14733 14734 14735 14736 14737 14738 14739 14740 14741 14742 14743 14744 14745 14746 14747 14748 14749 14750 14751 14752 14753 14754 14755 14756 14757 14758 14759 14760 14761 14762 14763 14764 14765 14766 14767 14768 14769 14770 14771 14772 14773 14774 14775 14776 14777 14778 14779 14780 14781 14782 14783 14784 14785 14786 14787 14788 14789 14790 14791 14792 14793 14794 14795 14796 14797 14798 14799 14800 14801 14802 14803 14804 14805 14806 14807 14808 14809 14810 14811 14812 14813 14814 14815 14816 14817 14818 14819 14820 14821 14822 14823 14824 14825 14826 14827 14828 14829 14830 14831 14832 14833 14834 14835 14836 14837 14838 14839 14840 14841 14842 14843 14844 14845 14846 14847 14848 14849 14850 14851 14852 14853 14854 14855 14856 14857 14858 14859 14860 14861 14862 14863 14864 14865 14866 14867 14868 14869 14870 14871 14872 14873 14874 14875 14876 14877 14878 14879 14880 14881 14882 14883 14884 14885 14886 14887 14888 14889 14890 14891 14892 14893 14894 14895 14896 14897 14898 14899 14900 14901 14902 14903 14904 14905 14906 14907 14908 14909 14910 14911 14912 14913 14914 14915 14916 14917 14918 14919 14920 14921 14922 14923 14924 14925 14926 14927 14928 14929 14930 14931 14932 14933 14934 14935 14936 14937 14938 14939 14940 14941 14942 14943 14944 14945 14946 14947 14948 14949 14950 14951 14952 14953 14954 14955 14956 14957 14958 14959 14960 14961 14962 14963 14964 14965 14966 14967 14968 14969 14970 14971 14972 14973 14974 14975 14976 14977 14978 14979 14980 14981 14982 14983 14984 14985 14986 14987 14988 14989 14990 14991 14992 14993 14994 14995 14996 14997 14998 14999 15000 15001 15002 15003 15004 15005 15006 15007 15008 15009 15010 15011 15012 15013 15014 15015 15016 15017 15018 15019 15020 15021 15022 15023 15024 15025 15026 15027 15028 15029 15030 15031 15032 15033 15034 15035 15036 15037 15038 15039 15040 15041 15042 15043 15044 15045 15046 15047 15048 15049 15050 15051 15052 15053 15054 15055 15056 15057 15058 15059 15060 15061 15062 15063 15064 15065 15066 15067 15068 15069 15070 15071 15072 15073 15074 15075 15076 15077 15078 15079 15080 15081 15082 15083 15084 15085 15086 15087 15088 15089 15090 15091 15092 15093 15094 15095 15096 15097 15098 15099 15100 15101 15102 15103 15104 15105 15106 15107 15108 15109 15110 15111 15112 15113 15114 15115 15116 15117 15118 15119 15120 15121 15122 15123 15124 15125 15126 15127 15128 15129 15130 15131 15132 15133 15134 15135 15136 15137 15138 15139 15140 15141 15142 15143 15144 15145 15146 15147 15148 15149 15150 15151 15152 15153 15154 15155 15156 15157 15158 15159 15160 15161 15162 15163 15164 15165 15166 15167 15168 15169 15170 15171 15172 15173 15174 15175 15176 15177 15178 15179 15180 15181 15182 15183 15184 15185 15186 15187 15188 15189 15190 15191 15192 15193 15194 15195 15196 15197 15198 15199 15200 15201 15202 15203 15204 15205 15206 15207 15208 15209 15210 15211 15212 15213 15214 15215 15216 15217 15218 15219 15220 15221 15222 15223 15224 15225 15226 15227 15228 15229 15230 15231 15232 15233 15234 15235 15236 15237 15238 15239 15240 15241 15242 15243 15244 15245 15246 15247 15248 15249 15250 15251 15252 15253 15254 15255 15256 15257 15258 15259 15260 15261 15262 15263 15264 15265 15266 15267 15268 15269 15270 15271 15272 15273 15274 15275 15276 15277 15278 15279 15280 15281 15282 15283 15284 15285 15286 15287 15288 15289 15290 15291 15292 15293 15294 15295 15296 15297 15298 15299 15300 15301 15302 15303 15304 15305 15306 15307 15308 15309 15310 15311 15312 15313 15314 15315 15316 15317 15318 15319 15320 15321 15322 15323 15324 15325 15326 15327 15328 15329 15330 15331 15332 15333 15334 15335 15336 15337 15338 15339 15340 15341 15342 15343 15344 15345 15346 15347 15348 15349 15350 15351 15352 15353 15354 15355 15356 15357 15358 15359 15360 15361 15362 15363 15364 15365 15366 15367 15368 15369 15370 15371 15372 15373 15374 15375 15376 15377 15378 15379 15380 15381 15382 15383 15384 15385 15386 15387 15388 15389 15390 15391 15392 15393 15394 15395 15396 15397 15398 15399 15400 15401 15402 15403 15404 15405 15406 15407 15408 15409 15410 15411 15412 15413 15414 15415 15416 15417 15418 15419 15420 15421 15422 15423 15424 15425 15426 15427 15428 15429 15430 15431 15432 15433 15434 15435 15436 15437 15438 15439 15440 15441 15442 15443 15444 15445 15446 15447 15448 15449 15450 15451 15452 15453 15454 15455 15456 15457 15458 15459 15460 15461 15462 15463 15464 15465 15466 15467 15468 15469 15470 15471 15472 15473 15474 15475 15476 15477 15478 15479 15480 15481 15482 15483 15484 15485 15486 15487 15488 15489 15490 15491 15492 15493 15494 15495 15496 15497 15498 15499 15500 15501 15502 15503 15504 15505 15506 15507 15508 15509 15510 15511 15512 15513 15514 15515 15516 15517 15518 15519 15520 15521 15522 15523 15524 15525 15526 15527 15528 15529 15530 15531 15532 15533 15534 15535 15536 15537 15538 15539 15540 15541 15542 15543 15544 15545 15546 15547 15548 15549 15550 15551 15552 15553 15554 15555 15556 15557 15558 15559 15560 15561 15562 15563 15564 15565 15566 15567 15568 15569 15570 15571 15572 15573 15574 15575 15576 15577 15578 15579 15580 15581 15582 15583 15584 15585 15586 15587 15588 15589 15590 15591 15592 15593 15594 15595 15596 15597 15598 15599 15600 15601 15602 15603 15604 15605 15606 15607 15608 15609 15610 15611 15612 15613 15614 15615 15616 15617 15618 15619 15620 15621 15622 15623 15624 15625 15626 15627 15628 15629 15630 15631 15632 15633 15634 15635 15636 15637 15638 15639 15640 15641 15642 15643 15644 15645 15646 15647 15648 15649 15650 15651 15652 15653 15654 15655 15656 15657 15658 15659 15660 15661 15662 15663 15664 15665 15666 15667 15668 15669 15670 15671 15672 15673 15674 15675 15676 15677 15678 15679 15680 15681 15682 15683 15684 15685 15686 15687 15688 15689 15690 15691 15692 15693 15694 15695 15696 15697 15698 15699 15700 15701 15702 15703 15704 15705 15706 15707 15708 15709 15710 15711 15712 15713 15714 15715 15716 15717 15718 15719 15720 15721 15722 15723 15724 15725 15726 15727 15728 15729 15730 15731 15732 15733 15734 15735 15736 15737 15738 15739 15740 15741 15742 15743 15744 15745 15746 15747 15748 15749 15750 15751 15752 15753 15754 15755 15756 15757 15758 15759 15760 15761 15762 15763 15764 15765 15766 15767 15768 15769 15770 15771 15772 15773 15774 15775 15776 15777 15778 15779 15780 15781 15782 15783 15784 15785 15786 15787 15788 15789 15790 15791 15792 15793 15794 15795 15796 15797 15798 15799 15800 15801 15802 15803 15804 15805 15806 15807 15808 15809 15810 15811 15812 15813 15814 15815 15816 15817 15818 15819 15820 15821 15822 15823 15824 15825 15826 15827 15828 15829 15830 15831 15832 15833 15834 15835 15836 15837 15838 15839 15840 15841 15842 15843 15844 15845 15846 15847 15848 15849 15850 15851 15852 15853 15854 15855 15856 15857 15858 15859 15860 15861 15862 15863 15864 15865 15866 15867 15868 15869 15870 15871 15872 15873 15874 15875 15876 15877 15878 15879 15880 15881 15882 15883 15884 15885 15886 15887 15888 15889 15890 15891 15892 15893 15894 15895 15896 15897 15898 15899 15900 15901 15902 15903 15904 15905 15906 15907 15908 15909 15910 15911 15912 15913 15914 15915 15916 15917 15918 15919 15920 15921 15922 15923 15924 15925 15926 15927 15928 15929 15930 15931 15932 15933 15934 15935 15936 15937 15938 15939 15940 15941 15942 15943 15944 15945 15946 15947 15948 15949 15950 15951 15952 15953 15954 15955 15956 15957 15958 15959 15960 15961 15962 15963 15964 15965 15966 15967 15968 15969 15970 15971 15972 15973 15974 15975 15976 15977 15978 15979 15980 15981 15982 15983 15984 15985 15986 15987 15988 15989 15990 15991 15992 15993 15994 15995 15996 15997 15998 15999 16000 16001 16002 16003 16004 16005 16006 16007 16008 16009 16010 16011 16012 16013 16014 16015 16016 16017 16018 16019 16020 16021 16022 16023 16024 16025 16026 16027 16028 16029 16030 16031 16032 16033 16034 16035 16036 16037 16038 16039 16040 16041 16042 16043 16044 16045 16046 16047 16048 16049 16050 16051 16052 16053 16054 16055 16056 16057 16058 16059 16060 16061 16062 16063 16064 16065 16066 16067 16068 16069 16070 16071 16072 16073 16074 16075 16076 16077 16078 16079 16080 16081 16082 16083 16084 16085 16086 16087 16088 16089 16090 16091 16092 16093 16094 16095 16096 16097 16098 16099 16100 16101 16102 16103 16104 16105 16106 16107 16108 16109 16110 16111 16112 16113 16114 16115 16116 16117 16118 16119 16120 16121 16122 16123 16124 16125 16126 16127 16128 16129 16130 16131 16132 16133 16134 16135 16136 16137 16138 16139 16140 16141 16142 16143 16144 16145 16146 16147 16148 16149 16150 16151 16152 16153 16154 16155 16156 16157 16158 16159 16160 16161 16162 16163 16164 16165 16166 16167 16168 16169 16170 16171 16172 16173 16174 16175 16176 16177 16178 16179 16180 16181 16182 16183 16184 16185 16186 16187 16188 16189 16190 16191 16192 16193 16194 16195 16196 16197 16198 16199 16200 16201 16202 16203 16204 16205 16206 16207 16208 16209 16210 16211 16212 16213 16214 16215 16216 16217 16218 16219 16220 16221 16222 16223 16224 16225 16226 16227 16228 16229 16230 16231 16232 16233 16234 16235 16236 16237 16238 16239 16240 16241 16242 16243 16244 16245 16246 16247 16248 16249 16250 16251 16252 16253 16254 16255 16256 16257 16258 16259 16260 16261 16262 16263 16264 16265 16266 16267 16268 16269 16270 16271 16272 16273 16274 16275 16276 16277 16278 16279 16280 16281 16282 16283 16284 16285 16286 16287 16288 16289 16290 16291 16292 16293 16294 16295 16296 16297 16298 16299 16300 16301 16302 16303 16304 16305 16306 16307 16308 16309 16310 16311 16312 16313 16314 16315 16316 16317 16318 16319 16320 16321 16322 16323 16324 16325 16326 16327 16328 16329 16330 16331 16332 16333 16334 16335 16336 16337 16338 16339 16340 16341 16342 16343 16344 16345 16346 16347 16348 16349 16350 16351 16352 16353 16354 16355 16356 16357 16358 16359 16360 16361 16362 16363 16364 16365 16366 16367 16368 16369 16370 16371 16372 16373 16374 16375 16376 16377 16378 16379 16380 16381 16382 16383 16384 16385 16386 16387 16388 16389 16390 16391 16392 16393 16394 16395 16396 16397 16398 16399 16400 16401 16402 16403 16404 16405 16406 16407 16408 16409 16410 16411 16412 16413 16414 16415 16416 16417 16418 16419 16420 16421 16422 16423 16424 16425 16426 16427 16428 16429 16430 16431 16432 16433 16434 16435 16436 16437 16438 16439 16440 16441 16442 16443 16444 16445 16446 16447 16448 16449 16450 16451 16452 16453 16454 16455 16456 16457 16458 16459 16460 16461 16462 16463 16464 16465 16466 16467 16468 16469 16470 16471 16472 16473 16474 16475 16476 16477 16478 16479 16480 16481 16482 16483 16484 16485 16486 16487 16488 16489 16490 16491 16492 16493 16494 16495 16496 16497 16498 16499 16500 16501 16502 16503 16504 16505 16506 16507 16508 16509 16510 16511 16512 16513 16514 16515 16516 16517 16518 16519 16520 16521 16522 16523 16524 16525 16526 16527 16528 16529 16530 16531 16532 16533 16534 16535 16536 16537 16538 16539 16540 16541 16542 16543 16544 16545 16546 16547 16548 16549 16550 16551 16552 16553 16554 16555 16556 16557 16558 16559 16560 16561 16562 16563 16564 16565 16566 16567 16568 16569 16570 16571 16572 16573 16574 16575 16576 16577 16578 16579 16580 16581 16582 16583 16584 16585 16586 16587 16588 16589 16590 16591 16592 16593 16594 16595 16596 16597 16598 16599 16600 16601 16602 16603 16604 16605 16606 16607 16608 16609 16610 16611 16612 16613 16614 16615 16616 16617 16618 16619 16620 16621 16622 16623 16624 16625 16626 16627 16628 16629 16630 16631 16632 16633 16634 16635 16636 16637 16638 16639 16640 16641 16642 16643 16644 16645 16646 16647 16648 16649 16650 16651 16652 16653 16654 16655 16656 16657 16658 16659 16660 16661 16662 16663 16664 16665 16666 16667 16668 16669 16670 16671 16672 16673 16674 16675 16676 16677 16678 16679 16680 16681 16682 16683 16684 16685 16686 16687 16688 16689 16690 16691 16692 16693 16694 16695 16696 16697 16698 16699 16700 16701 16702 16703 16704 16705 16706 16707 16708 16709 16710 16711 16712 16713 16714 16715 16716 16717 16718 16719 16720 16721 16722 16723 16724 16725 16726 16727 16728 16729 16730 16731 16732 16733 16734 16735 16736 16737 16738 16739 16740 16741 16742 16743 16744 16745 16746 16747 16748 16749 16750 16751 16752 16753 16754 16755 16756 16757 16758 16759 16760 16761 16762 16763 16764 16765 16766 16767 16768 16769 16770 16771 16772 16773 16774 16775 16776 16777 16778 16779 16780 16781 16782 16783 16784 16785 16786 16787 16788 16789 16790 16791 16792 16793 16794 16795 16796 16797 16798 16799 16800 16801 16802 16803 16804 16805 16806 16807 16808 16809 16810 16811 16812 16813 16814 16815 16816 16817 16818 16819 16820 16821 16822 16823 16824 16825 16826 16827 16828 16829 16830 16831 16832 16833 16834 16835 16836 16837 16838 16839 16840 16841 16842 16843 16844 16845 16846 16847 16848 16849 16850 16851 16852 16853 16854 16855 16856 16857 16858 16859 16860 16861 16862 16863 16864 16865 16866 16867 16868 16869 16870 16871 16872 16873 16874 16875 16876 16877 16878 16879 16880 16881 16882 16883 16884 16885 16886 16887 16888 16889 16890 16891 16892 16893 16894 16895 16896 16897 16898 16899 16900 16901 16902 16903 16904 16905 16906 16907 16908 16909 16910 16911 16912 16913 16914 16915 16916 16917 16918 16919 16920 16921 16922 16923 16924 16925 16926 16927 16928 16929 16930 16931 16932 16933 16934 16935 16936 16937 16938 16939 16940 16941 16942 16943 16944 16945 16946 16947 16948 16949 16950 16951 16952 16953 16954 16955 16956 16957 16958 16959 16960 16961 16962 16963 16964 16965 16966 16967 16968 16969 16970 16971 16972 16973 16974 16975 16976 16977 16978 16979 16980 16981 16982 16983 16984 16985 16986 16987 16988 16989 16990 16991 16992 16993 16994 16995 16996 16997 16998 16999 17000 17001 17002 17003 17004 17005 17006 17007 17008 17009 17010 17011 17012 17013 17014 17015 17016 17017 17018 17019 17020 17021 17022 17023 17024 17025 17026 17027 17028 17029 17030 17031 17032 17033 17034 17035 17036 17037 17038 17039 17040 17041 17042 17043 17044 17045 17046 17047 17048 17049 17050 17051 17052 17053 17054 17055 17056 17057 17058 17059 17060 17061 17062 17063 17064 17065 17066 17067 17068 17069 17070 17071 17072 17073 17074 17075 17076 17077 17078 17079 17080 17081 17082 17083 17084 17085 17086 17087 17088 17089 17090 17091 17092 17093 17094 17095 17096 17097 17098 17099 17100 17101 17102 17103 17104 17105 17106 17107 17108 17109 17110 17111 17112 17113 17114 17115 17116 17117 17118 17119 17120 17121 17122 17123 17124 17125 17126 17127 17128 17129 17130 17131 17132 17133 17134 17135 17136 17137 17138 17139 17140 17141 17142 17143 17144 17145 17146 17147 17148 17149 17150 17151 17152 17153 17154 17155 17156 17157 17158 17159 17160 17161 17162 17163 17164 17165 17166 17167 17168 17169 17170 17171 17172 17173 17174 17175 17176 17177 17178 17179 17180 17181 17182 17183 17184 17185 17186 17187 17188 17189 17190 17191 17192 17193 17194 17195 17196 17197 17198 17199 17200 17201 17202 17203 17204 17205 17206 17207 17208 17209 17210 17211 17212 17213 17214 17215 17216 17217 17218 17219 17220 17221 17222 17223 17224 17225 17226 17227 17228 17229 17230 17231 17232 17233 17234 17235 17236 17237 17238 17239 17240 17241 17242 17243 17244 17245 17246 17247 17248 17249 17250 17251 17252 17253 17254 17255 17256 17257 17258 17259 17260 17261 17262 17263 17264 17265 17266 17267 17268 17269 17270 17271 17272 17273 17274 17275 17276 17277 17278 17279 17280 17281 17282 17283 17284 17285 17286 17287 17288 17289 17290 17291 17292 17293 17294 17295 17296 17297 17298 17299 17300 17301 17302 17303 17304 17305 17306 17307 17308 17309 17310 17311 17312 17313 17314 17315 17316 17317 17318 17319 17320 17321 17322 17323 17324 17325 17326 17327 17328 17329 17330 17331 17332 17333 17334 17335 17336 17337 17338 17339 17340 17341 17342 17343 17344 17345 17346 17347 17348 17349 17350 17351 17352 17353 17354 17355 17356 17357 17358 17359 17360 17361 17362 17363 17364 17365 17366 17367 17368 17369 17370 17371 17372 17373 17374 17375 17376 17377 17378 17379 17380 17381 17382 17383 17384 17385 17386 17387 17388 17389 17390 17391 17392 17393 17394 17395 17396 17397 17398 17399 17400 17401 17402 17403 17404 17405 17406 17407 17408 17409 17410 17411 17412 17413 17414 17415 17416 17417 17418 17419 17420 17421 17422 17423 17424 17425 17426 17427 17428 17429 17430 17431 17432 17433 17434 17435 17436 17437 17438 17439 17440 17441 17442 17443 17444 17445 17446 17447 17448 17449 17450 17451 17452 17453 17454 17455 17456 17457 17458 17459 17460 17461 17462 17463 17464 17465 17466 17467 17468 17469 17470 17471 17472 17473 17474 17475 17476 17477 17478 17479 17480 17481 17482 17483 17484 17485 17486 17487 17488 17489 17490 17491 17492 17493 17494 17495 17496 17497 17498 17499 17500 17501 17502 17503 17504 17505 17506 17507 17508 17509 17510 17511 17512 17513 17514 17515 17516 17517 17518 17519 17520 17521 17522 17523 17524 17525 17526 17527 17528 17529 17530 17531 17532 17533 17534 17535 17536 17537 17538 17539 17540 17541 17542 17543 17544 17545 17546 17547 17548 17549 17550 17551 17552 17553 17554 17555 17556 17557 17558 17559 17560 17561 17562 17563 17564 17565 17566 17567 17568 17569 17570 17571 17572 17573 17574 17575 17576 17577 17578 17579 17580 17581 17582 17583 17584 17585 17586 17587 17588 17589 17590 17591 17592 17593 17594 17595 17596 17597 17598 17599 17600 17601 17602 17603 17604 17605 17606 17607 17608 17609 17610 17611 17612 17613 17614 17615 17616 17617 17618 17619 17620 17621 17622 17623 17624 17625 17626 17627 17628 17629 17630 17631 17632 17633 17634 17635 17636 17637 17638 17639 17640 17641 17642 17643 17644 17645 17646 17647 17648 17649 17650 17651 17652 17653 17654 17655 17656 17657 17658 17659 17660 17661 17662 17663 17664 17665 17666 17667 17668 17669 17670 17671 17672 17673 17674 17675 17676 17677 17678 17679 17680 17681 17682 17683 17684 17685 17686 17687 17688 17689 17690 17691 17692 17693 17694 17695 17696 17697 17698 17699 17700 17701 17702 17703 17704 17705 17706 17707 17708 17709 17710 17711 17712 17713 17714 17715 17716 17717 17718 17719 17720 17721 17722 17723 17724 17725 17726 17727 17728 17729 17730 17731 17732 17733 17734 17735 17736 17737 17738 17739 17740 17741 17742 17743 17744 17745 17746 17747 17748 17749 17750 17751 17752 17753 17754 17755 17756 17757 17758 17759 17760 17761 17762 17763 17764 17765 17766 17767 17768 17769 17770 17771 17772 17773 17774 17775 17776 17777 17778 17779 17780 17781 17782 17783 17784 17785 17786 17787 17788 17789 17790 17791 17792 17793 17794 17795 17796 17797 17798 17799 17800 17801 17802 17803 17804 17805 17806 17807 17808 17809 17810 17811 17812 17813 17814 17815 17816 17817 17818 17819 17820 17821 17822 17823 17824 17825 17826 17827 17828 17829 17830 17831 17832 17833 17834 17835 17836 17837 17838 17839 17840 17841 17842 17843 17844 17845 17846 17847 17848 17849 17850 17851 17852 17853 17854 17855 17856 17857 17858 17859 17860 17861 17862 17863 17864 17865 17866 17867 17868 17869 17870 17871 17872 17873 17874 17875 17876 17877 17878 17879 17880 17881 17882 17883 17884 17885 17886 17887 17888 17889 17890 17891 17892 17893 17894 17895 17896 17897 17898 17899 17900 17901 17902 17903 17904 17905 17906 17907 17908 17909 17910 17911 17912 17913 17914 17915 17916 17917 17918 17919 17920 17921 17922 17923 17924 17925 17926 17927 17928 17929 17930 17931 17932 17933 17934 17935 17936 17937 17938 17939 17940 17941 17942 17943 17944 17945 17946 17947 17948 17949 17950 17951 17952 17953 17954 17955 17956 17957 17958 17959 17960 17961 17962 17963 17964 17965 17966 17967 17968 17969 17970 17971 17972 17973 17974 17975 17976 17977 17978 17979 17980 17981 17982 17983 17984 17985 17986 17987 17988 17989 17990 17991 17992 17993 17994 17995 17996 17997 17998 17999 18000 18001 18002 18003 18004 18005 18006 18007 18008 18009 18010 18011 18012 18013 18014 18015 18016 18017 18018 18019 18020 18021 18022 18023 18024 18025 18026 18027 18028 18029 18030 18031 18032 18033 18034 18035 18036 18037 18038 18039 18040 18041 18042 18043 18044 18045 18046 18047 18048 18049 18050 18051 18052 18053 18054 18055 18056 18057 18058 18059 18060 18061 18062 18063 18064 18065 18066 18067 18068 18069 18070 18071 18072 18073 18074 18075 18076 18077 18078 18079 18080 18081 18082 18083 18084 18085 18086 18087 18088 18089 18090 18091 18092 18093 18094 18095 18096 18097 18098 18099 18100 18101 18102 18103 18104 18105 18106 18107 18108 18109 18110 18111 18112 18113 18114 18115 18116 18117 18118 18119 18120 18121 18122 18123 18124 18125 18126 18127 18128 18129 18130 18131 18132 18133 18134 18135 18136 18137 18138 18139 18140 18141 18142 18143 18144 18145 18146 18147 18148 18149 18150 18151 18152 18153 18154 18155 18156 18157 18158 18159 18160 18161 18162 18163 18164 18165 18166 18167 18168 18169 18170 18171 18172 18173 18174 18175 18176 18177 18178 18179 18180 18181 18182 18183 18184 18185 18186 18187 18188 18189 18190 18191 18192 18193 18194 18195 18196 18197 18198 18199 18200 18201 18202 18203 18204 18205 18206 18207 18208 18209 18210 18211 18212 18213 18214 18215 18216 18217 18218 18219 18220 18221 18222 18223 18224 18225 18226 18227 18228 18229 18230 18231 18232 18233 18234 18235 18236 18237 18238 18239 18240 18241 18242 18243 18244 18245 18246 18247 18248 18249 18250 18251 18252 18253 18254 18255 18256 18257 18258 18259 18260 18261 18262 18263 18264 18265 18266 18267 18268 18269 18270 18271 18272 18273 18274 18275 18276 18277 18278 18279 18280 18281 18282 18283 18284 18285 18286 18287 18288 18289 18290 18291 18292 18293 18294 18295 18296 18297 18298 18299 18300 18301 18302 18303 18304 18305 18306 18307 18308 18309 18310 18311 18312 18313 18314 18315 18316 18317 18318 18319 18320 18321 18322 18323 18324 18325 18326 18327 18328 18329 18330 18331 18332 18333 18334 18335 18336 18337 18338 18339 18340 18341 18342 18343 18344 18345 18346 18347 18348 18349 18350 18351 18352 18353 18354 18355 18356 18357 18358 18359 18360 18361 18362 18363 18364 18365 18366 18367 18368 18369 18370 18371 18372 18373 18374 18375 18376 18377 18378 18379 18380 18381 18382 18383 18384 18385 18386 18387 18388 18389 18390 18391 18392 18393 18394 18395 18396 18397 18398 18399 18400 18401 18402 18403 18404 18405 18406 18407 18408 18409 18410 18411 18412 18413 18414 18415 18416 18417 18418 18419 18420 18421 18422 18423 18424 18425 18426 18427 18428 18429 18430 18431 18432 18433 18434 18435 18436 18437 18438 18439 18440 18441 18442 18443 18444 18445 18446 18447 18448 18449 18450 18451 18452 18453 18454 18455 18456 18457 18458 18459 18460 18461 18462 18463 18464 18465 18466 18467 18468 18469 18470 18471 18472 18473 18474 18475 18476 18477 18478 18479 18480 18481 18482 18483 18484 18485 18486 18487 18488 18489 18490 18491 18492 18493 18494 18495 18496 18497 18498 18499 18500 18501 18502 18503 18504 18505 18506 18507 18508 18509 18510 18511 18512 18513 18514 18515 18516 18517 18518 18519 18520 18521 18522 18523 18524 18525 18526 18527 18528 18529 18530 18531 18532 18533 18534 18535 18536 18537 18538 18539 18540 18541 18542 18543 18544 18545 18546 18547 18548 18549 18550 18551 18552 18553 18554 18555 18556 18557 18558 18559 18560 18561 18562 18563 18564 18565 18566 18567 18568 18569 18570 18571 18572 18573 18574 18575 18576 18577 18578 18579 18580 18581 18582 18583 18584 18585 18586 18587 18588 18589 18590 18591 18592 18593 18594 18595 18596 18597 18598 18599 18600 18601 18602 18603 18604 18605 18606 18607 18608 18609 18610 18611 18612 18613 18614 18615 18616 18617 18618 18619 18620 18621 18622 18623 18624 18625 18626 18627 18628 18629 18630 18631 18632 18633 18634 18635 18636 18637 18638 18639 18640 18641 18642 18643 18644 18645 18646 18647 18648 18649 18650 18651 18652 18653 18654 18655 18656 18657 18658 18659 18660 18661 18662 18663 18664 18665 18666 18667 18668 18669 18670 18671 18672 18673 18674 18675 18676 18677 18678 18679 18680 18681 18682 18683 18684 18685 18686 18687 18688 18689 18690 18691 18692 18693 18694 18695 18696 18697 18698 18699 18700 18701 18702 18703 18704 18705 18706 18707 18708 18709 18710 18711 18712 18713 18714 18715 18716 18717 18718 18719 18720 18721 18722 18723 18724 18725 18726 18727 18728 18729 18730 18731 18732 18733 18734 18735 18736 18737 18738 18739 18740 18741 18742 18743 18744 18745 18746 18747 18748 18749 18750 18751 18752 18753 18754 18755 18756 18757 18758 18759 18760 18761 18762 18763 18764 18765 18766 18767 18768 18769 18770 18771 18772 18773 18774 18775 18776 18777 18778 18779 18780 18781 18782 18783 18784 18785 18786 18787 18788 18789 18790 18791 18792 18793 18794 18795 18796 18797 18798 18799 18800 18801 18802 18803 18804 18805 18806 18807 18808 18809 18810 18811 18812 18813 18814 18815 18816 18817 18818 18819 18820 18821 18822 18823 18824 18825 18826 18827 18828 18829 18830 18831 18832 18833 18834 18835 18836 18837 18838 18839 18840 18841 18842 18843 18844 18845 18846 18847 18848 18849 18850 18851 18852 18853 18854 18855 18856 18857 18858 18859 18860 18861 18862 18863 18864 18865 18866 18867 18868 18869 18870 18871 18872 18873 18874 18875 18876 18877 18878 18879 18880 18881 18882 18883 18884 18885 18886 18887 18888 18889 18890 18891 18892 18893 18894 18895 18896 18897 18898 18899 18900 18901 18902 18903 18904 18905 18906 18907 18908 18909 18910 18911 18912 18913 18914 18915 18916 18917 18918 18919 18920 18921 18922 18923 18924 18925 18926 18927 18928 18929 18930 18931 18932 18933 18934 18935 18936 18937 18938 18939 18940 18941 18942 18943 18944 18945 18946 18947 18948 18949 18950 18951 18952 18953 18954 18955 18956 18957 18958 18959 18960 18961 18962 18963 18964 18965 18966 18967 18968 18969 18970 18971 18972 18973 18974 18975 18976 18977 18978 18979 18980 18981 18982 18983 18984 18985 18986 18987 18988 18989 18990 18991 18992 18993 18994 18995 18996 18997 18998 18999 19000 19001 19002 19003 19004 19005 19006 19007 19008 19009 19010 19011 19012 19013 19014 19015 19016 19017 19018 19019 19020 19021 19022 19023 19024 19025 19026 19027 19028 19029 19030 19031 19032 19033 19034 19035 19036 19037 19038 19039 19040 19041 19042 19043 19044 19045 19046 19047 19048 19049 19050 19051 19052 19053 19054 19055 19056 19057 19058 19059 19060 19061 19062 19063 19064 19065 19066 19067 19068 19069 19070 19071 19072 19073 19074 19075 19076 19077 19078 19079 19080 19081 19082 19083 19084 19085 19086 19087 19088 19089 19090 19091 19092 19093 19094 19095 19096 19097 19098 19099 19100 19101 19102 19103 19104 19105 19106 19107 19108 19109 19110 19111 19112 19113 19114 19115 19116 19117 19118 19119 19120 19121 19122 19123 19124 19125 19126 19127 19128 19129 19130 19131 19132 19133 19134 19135 19136 19137 19138 19139 19140 19141 19142 19143 19144 19145 19146 19147 19148 19149 19150 19151 19152 19153 19154 19155 19156 19157 19158 19159 19160 19161 19162 19163 19164 19165 19166 19167 19168 19169 19170 19171 19172 19173 19174 19175 19176 19177 19178 19179 19180 19181 19182 19183 19184 19185 19186 19187 19188 19189 19190 19191 19192 19193 19194 19195 19196 19197 19198 19199 19200 19201 19202 19203 19204 19205 19206 19207 19208 19209 19210 19211 19212 19213 19214 19215 19216 19217 19218 19219 19220 19221 19222 19223 19224 19225 19226 19227 19228 19229 19230 19231 19232 19233 19234 19235 19236 19237 19238 19239 19240 19241 19242 19243 19244 19245 19246 19247 19248 19249 19250 19251 19252 19253 19254 19255 19256 19257 19258 19259 19260 19261 19262 19263 19264 19265 19266 19267 19268 19269 19270 19271 19272 19273 19274 19275 19276 19277 19278 19279 19280 19281 19282 19283 19284 19285 19286 19287 19288 19289 19290 19291 19292 19293 19294 19295 19296 19297 19298 19299 19300 19301 19302 19303 19304 19305 19306 19307 19308 19309 19310 19311 19312 19313 19314 19315 19316 19317 19318 19319 19320 19321 19322 19323 19324 19325 19326 19327 19328 19329 19330 19331 19332 19333 19334 19335 19336 19337 19338 19339 19340 19341 19342 19343 19344 19345 19346 19347 19348 19349 19350 19351 19352 19353 19354 19355 19356 19357 19358 19359 19360 19361 19362 19363 19364 19365 19366 19367 19368 19369 19370 19371 19372 19373 19374 19375 19376 19377 19378 19379 19380 19381 19382 19383 19384 19385 19386 19387 19388 19389 19390 19391 19392 19393 19394 19395 19396 19397 19398 19399 19400 19401 19402 19403 19404 19405 19406 19407 19408 19409 19410 19411 19412 19413 19414 19415 19416 19417 19418 19419 19420 19421 19422 19423 19424 19425 19426 19427 19428 19429 19430 19431 19432 19433 19434 19435 19436 19437 19438 19439 19440 19441 19442 19443 19444 19445 19446 19447 19448 19449 19450 19451 19452 19453 19454 19455 19456 19457 19458 19459 19460 19461 19462 19463 19464 19465 19466 19467 19468 19469 19470 19471 19472 19473 19474 19475 19476 19477 19478 19479 19480 19481 19482 19483 19484 19485 19486 19487 19488 19489 19490 19491 19492 19493 19494 19495 19496 19497 19498 19499 19500 19501 19502 19503 19504 19505 19506 19507 19508 19509 19510 19511 19512 19513 19514 19515 19516 19517 19518 19519 19520 19521 19522 19523 19524 19525 19526 19527 19528 19529 19530 19531 19532 19533 19534 19535 19536 19537 19538 19539 19540 19541 19542 19543 19544 19545 19546 19547 19548 19549 19550 19551 19552 19553 19554 19555 19556 19557 19558 19559 19560 19561 19562 19563 19564 19565 19566 19567 19568 19569 19570 19571 19572 19573 19574 19575 19576 19577 19578 19579 19580 19581 19582 19583 19584 19585 19586 19587 19588 19589 19590 19591 19592 19593 19594 19595 19596 19597 19598 19599 19600 19601 19602 19603 19604 19605 19606 19607 19608 19609 19610 19611 19612 19613 19614 19615 19616 19617 19618 19619 19620 19621 19622 19623 19624 19625 19626 19627 19628 19629 19630 19631 19632 19633 19634 19635 19636 19637 19638 19639 19640 19641 19642 19643 19644 19645 19646 19647 19648 19649 19650 19651 19652 19653 19654 19655 19656 19657 19658 19659 19660 19661 19662 19663 19664 19665 19666 19667 19668 19669 19670 19671 19672 19673 19674 19675 19676 19677 19678 19679 19680 19681 19682 19683 19684 19685 19686 19687 19688 19689 19690 19691 19692 19693 19694 19695 19696 19697 19698 19699 19700 19701 19702 19703 19704 19705 19706 19707 19708 19709 19710 19711 19712 19713 19714 19715 19716 19717 19718 19719 19720 19721 19722 19723 19724 19725 19726 19727 19728 19729 19730 19731 19732 19733 19734 19735 19736 19737 19738 19739 19740 19741 19742 19743 19744 19745 19746 19747 19748 19749 19750 19751 19752 19753 19754 19755 19756 19757 19758 19759 19760 19761 19762 19763 19764 19765 19766 19767 19768 19769 19770 19771 19772 19773 19774 19775 19776 19777 19778 19779 19780 19781 19782 19783 19784 19785 19786 19787 19788 19789 19790 19791 19792 19793 19794 19795 19796 19797 19798 19799 19800 19801 19802 19803 19804 19805 19806 19807 19808 19809 19810 19811 19812 19813 19814 19815 19816 19817 19818 19819 19820 19821 19822 19823 19824 19825 19826 19827 19828 19829 19830 19831 19832 19833 19834 19835 19836 19837 19838 19839 19840 19841 19842 19843 19844 19845 19846 19847 19848 19849 19850 19851 19852 19853 19854 19855 19856 19857 19858 19859 19860 19861 19862 19863 19864 19865 19866 19867 19868 19869 19870 19871 19872 19873 19874 19875 19876 19877 19878 19879 19880 19881 19882 19883 19884 19885 19886 19887 19888 19889 19890 19891 19892 19893 19894 19895 19896 19897 19898 19899 19900 19901 19902 19903 19904 19905 19906 19907 19908 19909 19910 19911 19912 19913 19914 19915 19916 19917 19918 19919 19920 19921 19922 19923 19924 19925 19926 19927 19928 19929 19930 19931 19932 19933 19934 19935 19936 19937 19938 19939 19940 19941 19942 19943 19944 19945 19946 19947 19948 19949 19950 19951 19952 19953 19954 19955 19956 19957 19958 19959 19960 19961 19962 19963 19964 19965 19966 19967 19968 19969 19970 19971 19972 19973 19974 19975 19976 19977 19978 19979 19980 19981 19982 19983 19984 19985 19986 19987 19988 19989 19990 19991 19992 19993 19994 19995 19996 19997 19998 19999 20000 20001 20002 20003 20004 20005 20006 20007 20008 20009 20010 20011 20012 20013 20014 20015 20016 20017 20018 20019 20020 20021 20022 20023 20024 20025 20026 20027 20028 20029 20030 20031 20032 20033 20034 20035 20036 20037 20038 20039 20040 20041 20042 20043 20044 20045 20046 20047 20048 20049 20050 20051 20052 20053 20054 20055 20056 20057 20058 20059 20060 20061 20062 20063 20064 20065 20066 20067 20068 20069 20070 20071 20072 20073 20074 20075 20076 20077 20078 20079 20080 20081 20082 20083 20084 20085 20086 20087 20088 20089 20090 20091 20092 20093 20094 20095 20096 20097 20098 20099 20100 20101 20102 20103 20104 20105 20106 20107 20108 20109 20110 20111 20112 20113 20114 20115 20116 20117 20118 20119 20120 20121 20122 20123 20124 20125 20126 20127 20128 20129 20130 20131 20132 20133 20134 20135 20136 20137 20138 20139 20140 20141 20142 20143 20144 20145 20146 20147 20148 20149 20150 20151 20152 20153 20154 20155 20156 20157 20158 20159 20160 20161 20162 20163 20164 20165 20166 20167 20168 20169 20170 20171 20172 20173 20174 20175 20176 20177 20178 20179 20180 20181 20182 20183 20184 20185 20186 20187 20188 20189 20190 20191 20192 20193 20194 20195 20196 20197 20198 20199 20200 20201 20202 20203 20204 20205 20206 20207 20208 20209 20210 20211 20212 20213 20214 20215 20216 20217 20218 20219 20220 20221 20222 20223 20224 20225 20226 20227 20228 20229 20230 20231 20232 20233 20234 20235 20236 20237 20238 20239 20240 20241 20242 20243 20244 20245 20246 20247 20248 20249 20250 20251 20252 20253 20254 20255 20256 20257 20258 20259 20260 20261 20262 20263 20264 20265 20266 20267 20268 20269 20270 20271 20272 20273 20274 20275 20276 20277 20278 20279 20280 20281 20282 20283 20284 20285 20286 20287 20288 20289 20290 20291 20292 20293 20294 20295 20296 20297 20298 20299 20300 20301 20302 20303 20304 20305 20306 20307 20308 20309 20310 20311 20312 20313 20314 20315 20316 20317 20318 20319 20320 20321 20322 20323 20324 20325 20326 20327 20328 20329 20330 20331 20332 20333 20334 20335 20336 20337 20338 20339 20340 20341 20342 20343 20344 20345 20346 20347 20348 20349 20350 20351 20352 20353 20354 20355 20356 20357 20358 20359 20360 20361 20362 20363 20364 20365 20366 20367 20368 20369 20370 20371 20372 20373 20374 20375 20376 20377 20378 20379 20380 20381 20382 20383 20384 20385 20386 20387 20388 20389 20390 20391 20392 20393 20394 20395 20396 20397 20398 20399 20400 20401 20402 20403 20404 20405 20406 20407 20408 20409 20410 20411 20412 20413 20414 20415 20416 20417 20418 20419 20420 20421 20422 20423 20424 20425 20426 20427 20428 20429 20430 20431 20432 20433 20434 20435 20436 20437 20438 20439 20440 20441 20442 20443 20444 20445 20446 20447 20448 20449 20450 20451 20452 20453 20454 20455 20456 20457 20458 20459 20460 20461 20462 20463 20464 20465 20466 20467 20468 20469 20470 20471 20472 20473 20474 20475 20476 20477 20478 20479 20480 20481 20482 20483 20484 20485 20486 20487 20488 20489 20490 20491 20492 20493 20494 20495 20496 20497 20498 20499 20500 20501 20502 20503 20504 20505 20506 20507 20508 20509 20510 20511 20512 20513 20514 20515 20516 20517 20518 20519 20520 20521 20522 20523 20524 20525 20526 20527 20528 20529 20530 20531 20532 20533 20534 20535 20536 20537 20538 20539 20540 20541 20542 20543 20544 20545 20546 20547 20548 20549 20550 20551 20552 20553 20554 20555 20556 20557 20558 20559 20560 20561 20562 20563 20564 20565 20566 20567 20568 20569 20570 20571 20572 20573 20574 20575 20576 20577 20578 20579 20580 20581 20582 20583 20584 20585 20586 20587 20588 20589 20590 20591 20592 20593 20594 20595 20596 20597 20598 20599 20600 20601 20602 20603 20604 20605 20606 20607 20608 20609 20610 20611 20612 20613 20614 20615 20616 20617 20618 20619 20620 20621 20622 20623 20624 20625 20626 20627 20628 20629 20630 20631 20632 20633 20634 20635 20636 20637 20638 20639 20640 20641 20642 20643 20644 20645 20646 20647 20648 20649 20650 20651 20652 20653 20654 20655 20656 20657 20658 20659 20660 20661 20662 20663 20664 20665 20666 20667 20668 20669 20670 20671 20672 20673 20674 20675 20676 20677 20678 20679 20680 20681 20682 20683 20684 20685 20686 20687 20688 20689 20690 20691 20692 20693 20694 20695 20696 20697 20698 20699 20700 20701 20702 20703 20704 20705 20706 20707 20708 20709 20710 20711 20712 20713 20714 20715 20716 20717 20718 20719 20720 20721 20722 20723 20724 20725 20726 20727 20728 20729 20730 20731 20732 20733 20734 20735 20736 20737 20738 20739 20740 20741 20742 20743 20744 20745 20746 20747 20748 20749 20750 20751 20752 20753 20754 20755 20756 20757 20758 20759 20760 20761 20762 20763 20764 20765 20766 20767 20768 20769 20770 20771 20772 20773 20774 20775 20776 20777 20778 20779 20780 20781 20782 20783 20784 20785 20786 20787 20788 20789 20790 20791 20792 20793 20794 20795 20796 20797 20798 20799 20800 20801 20802 20803 20804 20805 20806 20807 20808 20809 20810 20811 20812 20813 20814 20815 20816 20817 20818 20819 20820 20821 20822 20823 20824 20825 20826 20827 20828 20829 20830 20831 20832 20833 20834 20835 20836 20837 20838 20839 20840 20841 20842 20843 20844 20845 20846 20847 20848 20849 20850 20851 20852 20853 20854 20855 20856 20857 20858 20859 20860 20861 20862 20863 20864 20865 20866 20867 20868 20869 20870 20871 20872 20873 20874 20875 20876 20877 20878 20879 20880 20881 20882 20883 20884 20885 20886 20887 20888 20889 20890 20891 20892 20893 20894 20895 20896 20897 20898 20899 20900 20901 20902 20903 20904 20905 20906 20907 20908 20909 20910 20911 20912 20913 20914 20915 20916 20917 20918 20919 20920 20921 20922 20923 20924 20925 20926 20927 20928 20929 20930 20931 20932 20933 20934 20935 20936 20937 20938 20939 20940 20941 20942 20943 20944 20945 20946 20947 20948 20949 20950 20951 20952 20953 20954 20955 20956 20957 20958 20959 20960 20961 20962 20963 20964 20965 20966 20967 20968 20969 20970 20971 20972 20973 20974 20975 20976 20977 20978 20979 20980 20981 20982 20983 20984 20985 20986 20987 20988 20989 20990 20991 20992 20993 20994 20995 20996 20997 20998 20999 21000 21001 21002 21003 21004 21005 21006 21007 21008 21009 21010 21011 21012 21013 21014 21015 21016 21017 21018 21019 21020 21021 21022 21023 21024 21025 21026 21027 21028 21029 21030 21031 21032 21033 21034 21035 21036 21037 21038 21039 21040 21041 21042 21043 21044 21045 21046 21047 21048 21049 21050 21051 21052 21053 21054 21055 21056 21057 21058 21059 21060 21061 21062 21063 21064 21065 21066 21067 21068 21069 21070 21071 21072 21073 21074 21075 21076 21077 21078 21079 21080 21081 21082 21083 21084 21085 21086 21087 21088 21089 21090 21091 21092 21093 21094 21095 21096 21097 21098 21099 21100 21101 21102 21103 21104 21105 21106 21107 21108 21109 21110 21111 21112 21113 21114 21115 21116 21117 21118 21119 21120 21121 21122 21123 21124 21125 21126 21127 21128 21129 21130 21131 21132 21133 21134 21135 21136 21137 21138 21139 21140 21141 21142 21143 21144 21145 21146 21147 21148 21149 21150 21151 21152 21153 21154 21155 21156 21157 21158 21159 21160 21161 21162 21163 21164 21165 21166 21167 21168 21169 21170 21171 21172 21173 21174 21175 21176 21177 21178 21179 21180 21181 21182 21183 21184 21185 21186 21187 21188 21189 21190 21191 21192 21193 21194 21195 21196 21197 21198 21199 21200 21201 21202 21203 21204 21205 21206 21207 21208 21209 21210 21211 21212 21213 21214 21215 21216 21217 21218 21219 21220 21221 21222 21223 21224 21225 21226 21227 21228 21229 21230 21231 21232 21233 21234 21235 21236 21237 21238 21239 21240 21241 21242 21243 21244 21245 21246 21247 21248 21249 21250 21251 21252 21253 21254 21255 21256 21257 21258 21259 21260 21261 21262 21263 21264 21265 21266 21267 21268 21269 21270 21271 21272 21273 21274 21275 21276 21277 21278 21279 21280 21281 21282 21283 21284 21285 21286 21287 21288 21289 21290 21291 21292 21293 21294 21295 21296 21297 21298 21299 21300 21301 21302 21303 21304 21305 21306 21307 21308 21309 21310 21311 21312 21313 21314 21315 21316 21317 21318 21319 21320 21321 21322 21323 21324 21325 21326 21327 21328 21329 21330 21331 21332 21333 21334 21335 21336 21337 21338 21339 21340 21341 21342 21343 21344 21345 21346 21347 21348 21349 21350 21351 21352 21353 21354 21355 21356 21357 21358 21359 21360 21361 21362 21363 21364 21365 21366 21367 21368 21369 21370 21371 21372 21373 21374 21375 21376 21377 21378 21379 21380 21381 21382 21383 21384 21385 21386 21387 21388 21389 21390 21391 21392 21393 21394 21395 21396 21397 21398 21399 21400 21401 21402 21403 21404 21405 21406 21407 21408 21409 21410 21411 21412 21413 21414 21415 21416 21417 21418 21419 21420 21421 21422 21423 21424 21425 21426 21427 21428 21429 21430 21431 21432 21433 21434 21435 21436 21437 21438 21439 21440 21441 21442 21443 21444 21445 21446 21447 21448 21449 21450 21451 21452 21453 21454 21455 21456 21457 21458 21459 21460 21461 21462 21463 21464 21465 21466 21467 21468 21469 21470 21471 21472 21473 21474 21475 21476 21477 21478 21479 21480 21481 21482 21483 21484 21485 21486 21487 21488 21489 21490 21491 21492 21493 21494 21495 21496 21497 21498 21499 21500 21501 21502 21503 21504 21505 21506 21507 21508 21509 21510 21511 21512 21513 21514 21515 21516 21517 21518 21519 21520 21521 21522 21523 21524 21525 21526 21527 21528 21529 21530 21531 21532 21533 21534 21535 21536 21537 21538 21539 21540 21541 21542 21543 21544 21545 21546 21547 21548 21549 21550 21551 21552 21553 21554 21555 21556 21557 21558 21559 21560 21561 21562 21563 21564 21565 21566 21567 21568 21569 21570 21571 21572 21573 21574 21575 21576 21577 21578 21579 21580 21581 21582 21583 21584 21585 21586 21587 21588 21589 21590 21591 21592 21593 21594 21595 21596 21597 21598 21599 21600 21601 21602 21603 21604 21605 21606 21607 21608 21609 21610 21611 21612 21613 21614 21615 21616 21617 21618 21619 21620 21621 21622 21623 21624 21625 21626 21627 21628 21629 21630 21631 21632 21633 21634 21635 21636 21637 21638 21639 21640 21641 21642 21643 21644 21645 21646 21647 21648 21649 21650 21651 21652 21653 21654 21655 21656 21657 21658 21659 21660 21661 21662 21663 21664 21665 21666 21667 21668 21669 21670 21671 21672 21673 21674 21675 21676 21677 21678 21679 21680 21681 21682 21683 21684 21685 21686 21687 21688 21689 21690 21691 21692 21693 21694 21695 21696 21697 21698 21699 21700 21701 21702 21703 21704 21705 21706 21707 21708 21709 21710 21711 21712 21713 21714 21715 21716 21717 21718 21719 21720 21721 21722 21723 21724 21725 21726 21727 21728 21729 21730 21731 21732 21733 21734 21735 21736 21737 21738 21739 21740 21741 21742 21743 21744 21745 21746 21747 21748 21749 21750 21751 21752 21753 21754 21755 21756 21757 21758 21759 21760 21761 21762 21763 21764 21765 21766 21767 21768 21769 21770 21771 21772 21773 21774 21775 21776 21777 21778 21779 21780 21781 21782 21783 21784 21785 21786 21787 21788 21789 21790 21791 21792 21793 21794 21795 21796 21797 21798 21799 21800 21801 21802 21803 21804 21805 21806 21807 21808 21809 21810 21811 21812 21813 21814 21815 21816 21817 21818 21819 21820 21821 21822 21823 21824 21825 21826 21827 21828 21829 21830 21831 21832 21833 21834 21835 21836 21837 21838 21839 21840 21841 21842 21843 21844 21845 21846 21847 21848 21849 21850 21851 21852 21853 21854 21855 21856 21857 21858 21859 21860 21861 21862 21863 21864 21865 21866 21867 21868 21869 21870 21871 21872 21873 21874 21875 21876 21877 21878 21879 21880 21881 21882 21883 21884 21885 21886 21887 21888 21889 21890 21891 21892 21893 21894 21895 21896 21897 21898 21899 21900 21901 21902 21903 21904 21905 21906 21907 21908 21909 21910 21911 21912 21913 21914 21915 21916 21917 21918 21919 21920 21921 21922 21923 21924 21925 21926 21927 21928 21929 21930 21931 21932 21933 21934 21935 21936 21937 21938 21939 21940 21941 21942 21943 21944 21945 21946 21947 21948 21949 21950 21951 21952 21953 21954 21955 21956 21957 21958 21959 21960 21961 21962 21963 21964 21965 21966 21967 21968 21969 21970 21971 21972 21973 21974 21975 21976 21977 21978 21979 21980 21981 21982 21983 21984 21985 21986 21987 21988 21989 21990 21991 21992 21993 21994 21995 21996 21997 21998 21999 22000 22001 22002 22003 22004 22005 22006 22007 22008 22009 22010 22011 22012 22013 22014 22015 22016 22017 22018 22019 22020 22021 22022 22023 22024 22025 22026 22027 22028 22029 22030 22031 22032 22033 22034 22035 22036 22037 22038 22039 22040 22041 22042 22043 22044 22045 22046 22047 22048 22049 22050 22051 22052 22053 22054 22055 22056 22057 22058 22059 22060 22061 22062 22063 22064 22065 22066 22067 22068 22069 22070 22071 22072 22073 22074 22075 22076 22077 22078 22079 22080 22081 22082 22083 22084 22085 22086 22087 22088 22089 22090 22091 22092 22093 22094 22095 22096 22097 22098 22099 22100 22101 22102 22103 22104 22105 22106 22107 22108 22109 22110 22111 22112 22113 22114 22115 22116 22117 22118 22119 22120 22121 22122 22123 22124 22125 22126 22127 22128 22129 22130 22131 22132 22133 22134 22135 22136 22137 22138 22139 22140 22141 22142 22143 22144 22145 22146 22147 22148 22149 22150 22151 22152 22153 22154 22155 22156 22157 22158 22159 22160 22161 22162 22163 22164 22165 22166 22167 22168 22169 22170 22171 22172 22173 22174 22175 22176 22177 22178 22179 22180 22181 22182 22183 22184 22185 22186 22187 22188 22189 22190 22191 22192 22193 22194 22195 22196 22197 22198 22199 22200 22201 22202 22203 22204 22205 22206 22207 22208 22209 22210 22211 22212 22213 22214 22215 22216 22217 22218 22219 22220 22221 22222 22223 22224 22225 22226 22227 22228 22229 22230 22231 22232 22233 22234 22235 22236 22237 22238 22239 22240 22241 22242 22243 22244 22245 22246 22247 22248 22249 22250 22251 22252 22253 22254 22255 22256 22257 22258 22259 22260 22261 22262 22263 22264 22265 22266 22267 22268 22269 22270 22271 22272 22273 22274 22275 22276 22277 22278 22279 22280 22281 22282 22283 22284 22285 22286 22287 22288 22289 22290 22291 22292 22293 22294 22295 22296 22297 22298 22299 22300 22301 22302 22303 22304 22305 22306 22307 22308 22309 22310 22311 22312 22313 22314 22315 22316 22317 22318 22319 22320 22321 22322 22323 22324 22325 22326 22327 22328 22329 22330 22331 22332 22333 22334 22335 22336 22337 22338 22339 22340 22341 22342 22343 22344 22345 22346 22347 22348 22349 22350 22351 22352 22353 22354 22355 22356 22357 22358 22359 22360 22361 22362 22363 22364 22365 22366 22367 22368 22369 22370 22371 22372 22373 22374 22375 22376 22377 22378 22379 22380 22381 22382 22383 22384 22385 22386 22387 22388 22389 22390 22391 22392 22393 22394 22395 22396 22397 22398 22399 22400 22401 22402 22403 22404 22405 22406 22407 22408 22409 22410 22411 22412 22413 22414 22415 22416 22417 22418 22419 22420 22421 22422 22423 22424 22425 22426 22427 22428 22429 22430 22431 22432 22433 22434 22435 22436 22437 22438 22439 22440 22441 22442 22443 22444 22445 22446 22447 22448 22449 22450 22451 22452 22453 22454 22455 22456 22457 22458 22459 22460 22461 22462 22463 22464 22465 22466 22467 22468 22469 22470 22471 22472 22473 22474 22475 22476 22477 22478 22479 22480 22481 22482 22483 22484 22485 22486 22487 22488 22489 22490 22491 22492 22493 22494 22495 22496 22497 22498 22499 22500 22501 22502 22503 22504 22505 22506 22507 22508 22509 22510 22511 22512 22513 22514 22515 22516 22517 22518 22519 22520 22521 22522 22523 22524 22525 22526 22527 22528 22529 22530 22531 22532 22533 22534 22535 22536 22537 22538 22539 22540 22541 22542 22543 22544 22545 22546 22547 22548 22549 22550 22551 22552 22553 22554 22555 22556 22557 22558 22559 22560 22561 22562 22563 22564 22565 22566 22567 22568 22569 22570 22571 22572 22573 22574 22575 22576 22577 22578 22579 22580 22581 22582 22583 22584 22585 22586 22587 22588 22589 22590 22591 22592 22593 22594 22595 22596 22597 22598 22599 22600 22601 22602 22603 22604 22605 22606 22607 22608 22609 22610 22611 22612 22613 22614 22615 22616 22617 22618 22619 22620 22621 22622 22623 22624 22625 22626 22627 22628 22629 22630 22631 22632 22633 22634 22635 22636 22637 22638 22639 22640 22641 22642 22643 22644 22645 22646 22647 22648 22649 22650 22651 22652 22653 22654 22655 22656 22657 22658 22659 22660 22661 22662 22663 22664 22665 22666 22667 22668 22669 22670 22671 22672 22673 22674 22675 22676 22677 22678 22679 22680 22681 22682 22683 22684 22685 22686 22687 22688 22689 22690 22691 22692 22693 22694 22695 22696 22697 22698 22699 22700 22701 22702 22703 22704 22705 22706 22707 22708 22709 22710 22711 22712 22713 22714 22715 22716 22717 22718 22719 22720 22721 22722 22723 22724 22725 22726 22727 22728 22729 22730 22731 22732 22733 22734 22735 22736 22737 22738 22739 22740 22741 22742 22743 22744 22745 22746 22747 22748 22749 22750 22751 22752 22753 22754 22755 22756 22757 22758 22759 22760 22761 22762 22763 22764 22765 22766 22767 22768 22769 22770 22771 22772 22773 22774 22775 22776 22777 22778 22779 22780 22781 22782 22783 22784 22785 22786 22787 22788 22789 22790 22791 22792 22793 22794 22795 22796 22797 22798 22799 22800 22801 22802 22803 22804 22805 22806 22807 22808 22809 22810 22811 22812 22813 22814 22815 22816 22817 22818 22819 22820 22821 22822 22823 22824 22825 22826 22827 22828 22829 22830 22831 22832 22833 22834 22835 22836 22837 22838 22839 22840 22841 22842 22843 22844 22845 22846 22847 22848 22849 22850 22851 22852 22853 22854 22855 22856 22857 22858 22859 22860 22861 22862 22863 22864 22865 22866 22867 22868 22869 22870 22871 22872 22873 22874 22875 22876 22877 22878 22879 22880 22881 22882 22883 22884 22885 22886 22887 22888 22889 22890 22891 22892 22893 22894 22895 22896 22897 22898 22899 22900 22901 22902 22903 22904 22905 22906 22907 22908 22909 22910 22911 22912 22913 22914 22915 22916 22917 22918 22919 22920 22921 22922 22923 22924 22925 22926 22927 22928 22929 22930 22931 22932 22933 22934 22935 22936 22937 22938 22939 22940 22941 22942 22943 22944 22945 22946 22947 22948 22949 22950 22951 22952 22953 22954 22955 22956 22957 22958 22959 22960 22961 22962 22963 22964 22965 22966 22967 22968 22969 22970 22971 22972 22973 22974 22975 22976 22977 22978 22979 22980 22981 22982 22983 22984 22985 22986 22987 22988 22989 22990 22991 22992 22993 22994 22995 22996 22997 22998 22999 23000 23001 23002 23003 23004 23005 23006 23007 23008 23009 23010 23011 23012 23013 23014 23015 23016 23017 23018 23019 23020 23021 23022 23023 23024 23025 23026 23027 23028 23029 23030 23031 23032 23033 23034 23035 23036 23037 23038 23039 23040 23041 23042 23043 23044 23045 23046 23047 23048 23049 23050 23051 23052 23053 23054 23055 23056 23057 23058 23059 23060 23061 23062 23063 23064 23065 23066 23067 23068 23069 23070 23071 23072 23073 23074 23075 23076 23077 23078 23079 23080 23081 23082 23083 23084 23085 23086 23087 23088 23089 23090 23091 23092 23093 23094 23095 23096 23097 23098 23099 23100 23101 23102 23103 23104 23105 23106 23107 23108 23109 23110 23111 23112 23113 23114 23115 23116 23117 23118 23119 23120 23121 23122 23123 23124 23125 23126 23127 23128 23129 23130 23131 23132 23133 23134 23135 23136 23137 23138 23139 23140 23141 23142 23143 23144 23145 23146 23147 23148 23149 23150 23151 23152 23153 23154 23155 23156 23157 23158 23159 23160 23161 23162 23163 23164 23165 23166 23167 23168 23169 23170 23171 23172 23173 23174 23175 23176 23177 23178 23179 23180 23181 23182 23183 23184 23185 23186 23187 23188 23189 23190 23191 23192 23193 23194 23195 23196 23197 23198 23199 23200 23201 23202 23203 23204 23205 23206 23207 23208 23209 23210 23211 23212 23213 23214 23215 23216 23217 23218 23219 23220 23221 23222 23223 23224 23225 23226 23227 23228 23229 23230 23231 23232 23233 23234 23235 23236 23237 23238 23239 23240 23241 23242 23243 23244 23245 23246 23247 23248 23249 23250 23251 23252 23253 23254 23255 23256 23257 23258 23259 23260 23261 23262 23263 23264 23265 23266 23267 23268 23269 23270 23271 23272 23273 23274 23275 23276 23277 23278 23279 23280 23281 23282 23283 23284 23285 23286 23287 23288 23289 23290 23291 23292 23293 23294 23295 23296 23297 23298 23299 23300 23301 23302 23303 23304 23305 23306 23307 23308 23309 23310 23311 23312 23313 23314 23315 23316 23317 23318 23319 23320 23321 23322 23323 23324 23325 23326 23327 23328 23329 23330 23331 23332 23333 23334 23335 23336 23337 23338 23339 23340 23341 23342 23343 23344 23345 23346 23347 23348 23349 23350 23351 23352 23353 23354 23355 23356 23357 23358 23359 23360 23361 23362 23363 23364 23365 23366 23367 23368 23369 23370 23371 23372 23373 23374 23375 23376 23377 23378 23379 23380 23381 23382 23383 23384 23385 23386 23387 23388 23389 23390 23391 23392 23393 23394 23395 23396 23397 23398 23399 23400 23401 23402 23403 23404 23405 23406 23407 23408 23409 23410 23411 23412 23413 23414 23415 23416 23417 23418 23419 23420 23421 23422 23423 23424 23425 23426 23427 23428 23429 23430 23431 23432 23433 23434 23435 23436 23437 23438 23439 23440 23441 23442 23443 23444 23445 23446 23447 23448 23449 23450 23451 23452 23453 23454 23455 23456 23457 23458 23459 23460 23461 23462 23463 23464 23465 23466 23467 23468 23469 23470 23471 23472 23473 23474 23475 23476 23477 23478 23479 23480 23481 23482 23483 23484 23485 23486 23487 23488 23489 23490 23491 23492 23493 23494 23495 23496 23497 23498 23499 23500 23501 23502 23503 23504 23505 23506 23507 23508 23509 23510 23511 23512 23513 23514 23515 23516 23517 23518 23519 23520 23521 23522 23523 23524 23525 23526 23527 23528 23529 23530 23531 23532 23533 23534 23535 23536 23537 23538 23539 23540 23541 23542 23543 23544 23545 23546 23547 23548 23549 23550 23551 23552 23553 23554 23555 23556 23557 23558 23559 23560 23561 23562 23563 23564 23565 23566 23567 23568 23569 23570 23571 23572 23573 23574 23575 23576 23577 23578 23579 23580 23581 23582 23583 23584 23585 23586 23587 23588 23589 23590 23591 23592 23593 23594 23595 23596 23597 23598 23599 23600 23601 23602 23603 23604 23605 23606 23607 23608 23609 23610 23611 23612 23613 23614 23615 23616 23617 23618 23619 23620 23621 23622 23623 23624 23625 23626 23627 23628 23629 23630 23631 23632 23633 23634 23635 23636 23637 23638 23639 23640 23641 23642 23643 23644 23645 23646 23647 23648 23649 23650 23651 23652 23653 23654 23655 23656 23657 23658 23659 23660 23661 23662 23663 23664 23665 23666 23667 23668 23669 23670 23671 23672 23673 23674 23675 23676 23677 23678 23679 23680 23681 23682 23683 23684 23685 23686 23687 23688 23689 23690 23691 23692 23693 23694 23695 23696 23697 23698 23699 23700 23701 23702 23703 23704 23705 23706 23707 23708 23709 23710 23711 23712 23713 23714 23715 23716 23717 23718 23719 23720 23721 23722 23723 23724 23725 23726 23727 23728 23729 23730 23731 23732 23733 23734 23735 23736 23737 23738 23739 23740 23741 23742 23743 23744 23745 23746 23747 23748 23749 23750 23751 23752 23753 23754 23755 23756 23757 23758 23759 23760 23761 23762 23763 23764 23765 23766 23767 23768 23769 23770 23771 23772 23773 23774 23775 23776 23777 23778 23779 23780 23781 23782 23783 23784 23785 23786 23787 23788 23789 23790 23791 23792 23793 23794 23795 23796 23797 23798 23799 23800 23801 23802 23803 23804 23805 23806 23807 23808 23809 23810 23811 23812 23813 23814 23815 23816 23817 23818 23819 23820 23821 23822 23823 23824 23825 23826 23827 23828 23829 23830 23831 23832 23833 23834 23835 23836 23837 23838 23839 23840 23841 23842 23843 23844 23845 23846 23847 23848 23849 23850 23851 23852 23853 23854 23855 23856 23857 23858 23859 23860 23861 23862 23863 23864 23865 23866 23867 23868 23869 23870 23871 23872 23873 23874 23875 23876 23877 23878 23879 23880 23881 23882 23883 23884 23885 23886 23887 23888 23889 23890 23891 23892 23893 23894 23895 23896 23897 23898 23899 23900 23901 23902 23903 23904 23905 23906 23907 23908 23909 23910 23911 23912 23913 23914 23915 23916 23917 23918 23919 23920 23921 23922 23923 23924 23925 23926 23927 23928 23929 23930 23931 23932 23933 23934 23935 23936 23937 23938 23939 23940 23941 23942 23943 23944 23945 23946 23947 23948 23949 23950 23951 23952 23953 23954 23955 23956 23957 23958 23959 23960 23961 23962 23963 23964 23965 23966 23967 23968 23969 23970 23971 23972 23973 23974 23975 23976 23977 23978 23979 23980 23981 23982 23983 23984 23985 23986 23987 23988 23989 23990 23991 23992 23993 23994 23995 23996 23997 23998 23999 24000 24001 24002 24003 24004 24005 24006 24007 24008 24009 24010 24011 24012 24013 24014 24015 24016 24017 24018 24019 24020 24021 24022 24023 24024 24025 24026 24027 24028 24029 24030 24031 24032 24033 24034 24035 24036 24037 24038 24039 24040 24041 24042 24043 24044 24045 24046 24047 24048 24049 24050 24051 24052 24053 24054 24055 24056 24057 24058 24059 24060 24061 24062 24063 24064 24065 24066 24067 24068 24069 24070 24071 24072 24073 24074 24075 24076 24077 24078 24079 24080 24081 24082 24083 24084 24085 24086 24087 24088 24089 24090 24091 24092 24093 24094 24095 24096 24097 24098 24099 24100 24101 24102 24103 24104 24105 24106 24107 24108 24109 24110 24111 24112 24113 24114 24115 24116 24117 24118 24119 24120 24121 24122 24123 24124 24125 24126 24127 24128 24129 24130 24131 24132 24133 24134 24135 24136 24137 24138 24139 24140 24141 24142 24143 24144 24145 24146 24147 24148 24149 24150 24151 24152 24153 24154 24155 24156 24157 24158 24159 24160 24161 24162 24163 24164 24165 24166 24167 24168 24169 24170 24171 24172 24173 24174 24175 24176 24177 24178 24179 24180 24181 24182 24183 24184 24185 24186 24187 24188 24189 24190 24191 24192 24193 24194 24195 24196 24197 24198 24199 24200 24201 24202 24203 24204 24205 24206 24207 24208 24209 24210 24211 24212 24213 24214 24215 24216 24217 24218 24219 24220 24221 24222 24223 24224 24225 24226 24227 24228 24229 24230 24231 24232 24233 24234 24235 24236 24237 24238 24239 24240 24241 24242 24243 24244 24245 24246 24247 24248 24249 24250 24251 24252 24253 24254 24255 24256 24257 24258 24259 24260 24261 24262 24263 24264 24265 24266 24267 24268 24269 24270 24271 24272 24273 24274 24275 24276 24277 24278 24279 24280 24281 24282 24283 24284 24285 24286 24287 24288 24289 24290 24291 24292 24293 24294 24295 24296 24297 24298 24299 24300 24301 24302 24303 24304 24305 24306 24307 24308 24309 24310 24311 24312 24313 24314 24315 24316 24317 24318 24319 24320 24321 24322 24323 24324 24325 24326 24327 24328 24329 24330 24331 24332 24333 24334 24335 24336 24337 24338 24339 24340 24341 24342 24343 24344 24345 24346 24347 24348 24349 24350 24351 24352 24353 24354 24355 24356 24357 24358 24359 24360 24361 24362 24363 24364 24365 24366 24367 24368 24369 24370 24371 24372 24373 24374 24375 24376 24377 24378 24379 24380 24381 24382 24383 24384 24385 24386 24387 24388 24389 24390 24391 24392 24393 24394 24395 24396 24397 24398 24399 24400 24401 24402 24403 24404 24405 24406 24407 24408 24409 24410 24411 24412 24413 24414 24415 24416 24417 24418 24419 24420 24421 24422 24423 24424 24425 24426 24427 24428 24429 24430 24431 24432 24433 24434 24435 24436 24437 24438 24439 24440 24441 24442 24443 24444 24445 24446 24447 24448 24449 24450 24451 24452 24453 24454 24455 24456 24457 24458 24459 24460 24461 24462 24463 24464 24465 24466 24467 24468 24469 24470 24471 24472 24473 24474 24475 24476 24477 24478 24479 24480 24481 24482 24483 24484 24485 24486 24487 24488 24489 24490 24491 24492 24493 24494 24495 24496 24497 24498 24499 24500 24501 24502 24503 24504 24505 24506 24507 24508 24509 24510 24511 24512 24513 24514 24515 24516 24517 24518 24519 24520 24521 24522 24523 24524 24525 24526 24527 24528 24529 24530 24531 24532 24533 24534 24535 24536 24537 24538 24539 24540 24541 24542 24543 24544 24545 24546 24547 24548 24549 24550 24551 24552 24553 24554 24555 24556 24557 24558 24559 24560 24561 24562 24563 24564 24565 24566 24567 24568 24569 24570 24571 24572 24573 24574 24575 24576 24577 24578 24579 24580 24581 24582 24583 24584 24585 24586 24587 24588 24589 24590 24591 24592 24593 24594 24595 24596 24597 24598 24599 24600 24601 24602 24603 24604 24605 24606 24607 24608 24609 24610 24611 24612 24613 24614 24615 24616 24617 24618 24619 24620 24621 24622 24623 24624 24625 24626 24627 24628 24629 24630 24631 24632 24633 24634 24635 24636 24637 24638 24639 24640 24641 24642 24643 24644 24645 24646 24647 24648 24649 24650 24651 24652 24653 24654 24655 24656 24657 24658 24659 24660 24661 24662 24663 24664 24665 24666 24667 24668 24669 24670 24671 24672 24673 24674 24675 24676 24677 24678 24679 24680 24681 24682 24683 24684 24685 24686 24687 24688 24689 24690 24691 24692 24693 24694 24695 24696 24697 24698 24699 24700 24701 24702 24703 24704 24705 24706 24707 24708 24709 24710 24711 24712 24713 24714 24715 24716 24717 24718 24719 24720 24721 24722 24723 24724 24725 24726 24727 24728 24729 24730 24731 24732 24733 24734 24735 24736 24737 24738 24739 24740 24741 24742 24743 24744 24745 24746 24747 24748 24749 24750 24751 24752 24753 24754 24755 24756 24757 24758 24759 24760 24761 24762 24763 24764 24765 24766 24767 24768 24769 24770 24771 24772 24773 24774 24775 24776 24777 24778 24779 24780 24781 24782 24783 24784 24785 24786 24787 24788 24789 24790 24791 24792 24793 24794 24795 24796 24797 24798 24799 24800 24801 24802 24803 24804 24805 24806 24807 24808 24809 24810 24811 24812 24813 24814 24815 24816 24817 24818 24819 24820 24821 24822 24823 24824 24825 24826 24827 24828 24829 24830 24831 24832 24833 24834 24835 24836 24837 24838 24839 24840 24841 24842 24843 24844 24845 24846 24847 24848 24849 24850 24851 24852 24853 24854 24855 24856 24857 24858 24859 24860 24861 24862 24863 24864 24865 24866 24867 24868 24869 24870 24871 24872 24873 24874 24875 24876 24877 24878 24879 24880 24881 24882 24883 24884 24885 24886 24887 24888 24889 24890 24891 24892 24893 24894 24895 24896 24897 24898 24899 24900 24901 24902 24903 24904 24905 24906 24907 24908 24909 24910 24911 24912 24913 24914 24915 24916 24917 24918 24919 24920 24921 24922 24923 24924 24925 24926 24927 24928 24929 24930 24931 24932 24933 24934 24935 24936 24937 24938 24939 24940 24941 24942 24943 24944 24945 24946 24947 24948 24949 24950 24951 24952 24953 24954 24955 24956 24957 24958 24959 24960 24961 24962 24963 24964 24965 24966 24967 24968 24969 24970 24971 24972 24973 24974 24975 24976 24977 24978 24979 24980 24981 24982 24983 24984 24985 24986 24987 24988 24989 24990 24991 24992 24993 24994 24995 24996 24997 24998 24999 25000 25001 25002 25003 25004 25005 25006 25007 25008 25009 25010 25011 25012 25013 25014 25015 25016 25017 25018 25019 25020 25021 25022 25023 25024 25025 25026 25027 25028 25029 25030 25031 25032 25033 25034 25035 25036 25037 25038 25039 25040 25041 25042 25043 25044 25045 25046 25047 25048 25049 25050 25051 25052 25053 25054 25055 25056 25057 25058 25059 25060 25061 25062 25063 25064 25065 25066 25067 25068 25069 25070 25071 25072 25073 25074 25075 25076 25077 25078 25079 25080 25081 25082 25083 25084 25085 25086 25087 25088 25089 25090 25091 25092 25093 25094 25095 25096 25097 25098 25099 25100 25101 25102 25103 25104 25105 25106 25107 25108 25109 25110 25111 25112 25113 25114 25115 25116 25117 25118 25119 25120 25121 25122 25123 25124 25125 25126 25127 25128 25129 25130 25131 25132 25133 25134 25135 25136 25137 25138 25139 25140 25141 25142 25143 25144 25145 25146 25147 25148 25149 25150 25151 25152 25153 25154 25155 25156 25157 25158 25159 25160 25161 25162 25163 25164 25165 25166 25167 25168 25169 25170 25171 25172 25173 25174 25175 25176 25177 25178 25179 25180 25181 25182 25183 25184 25185 25186 25187 25188 25189 25190 25191 25192 25193 25194 25195 25196 25197 25198 25199 25200 25201 25202 25203 25204 25205 25206 25207 25208 25209 25210 25211 25212 25213 25214 25215 25216 25217 25218 25219 25220 25221 25222 25223 25224 25225 25226 25227 25228 25229 25230 25231 25232 25233 25234 25235 25236 25237 25238 25239 25240 25241 25242 25243 25244 25245 25246 25247 25248 25249 25250 25251 25252 25253 25254 25255 25256 25257 25258 25259 25260 25261 25262 25263 25264 25265 25266 25267 25268 25269 25270 25271 25272 25273 25274 25275 25276 25277 25278 25279 25280 25281 25282 25283 25284 25285 25286 25287 25288 25289 25290 25291 25292 25293 25294 25295 25296 25297 25298 25299 25300 25301 25302 25303 25304 25305 25306 25307 25308 25309 25310 25311 25312 25313 25314 25315 25316 25317 25318 25319 25320 25321 25322 25323 25324 25325 25326 25327 25328 25329 25330 25331 25332 25333 25334 25335 25336 25337 25338 25339 25340 25341 25342 25343 25344 25345 25346 25347 25348 25349 25350 25351 25352 25353 25354 25355 25356 25357 25358 25359 25360 25361 25362 25363 25364 25365 25366 25367 25368 25369 25370 25371 25372 25373 25374 25375 25376 25377 25378 25379 25380 25381 25382 25383 25384 25385 25386 25387 25388 25389 25390 25391 25392 25393 25394 25395 25396 25397 25398 25399 25400 25401 25402 25403 25404 25405 25406 25407 25408 25409 25410 25411 25412 25413 25414 25415 25416 25417 25418 25419 25420 25421 25422 25423 25424 25425 25426 25427 25428 25429 25430 25431 25432 25433 25434 25435 25436 25437 25438 25439 25440 25441 25442 25443 25444 25445 25446 25447 25448 25449 25450 25451 25452 25453 25454 25455 25456 25457 25458 25459 25460 25461 25462 25463 25464 25465 25466 25467 25468 25469 25470 25471 25472 25473 25474 25475 25476 25477 25478 25479 25480 25481 25482 25483 25484 25485 25486 25487 25488 25489 25490 25491 25492 25493 25494 25495 25496 25497 25498 25499 25500 25501 25502 25503 25504 25505 25506 25507 25508 25509 25510 25511 25512 25513 25514 25515 25516 25517 25518 25519 25520 25521 25522 25523 25524 25525 25526 25527 25528 25529 25530 25531 25532 25533 25534 25535 25536 25537 25538 25539 25540 25541 25542 25543 25544 25545 25546 25547 25548 25549 25550 25551 25552 25553 25554 25555 25556 25557 25558 25559 25560 25561 25562 25563 25564 25565 25566 25567 25568 25569 25570 25571 25572 25573 25574 25575 25576 25577 25578 25579 25580 25581 25582 25583 25584 25585 25586 25587 25588 25589 25590 25591 25592 25593 25594 25595 25596 25597 25598 25599 25600 25601 25602 25603 25604 25605 25606 25607 25608 25609 25610 25611 25612 25613 25614 25615 25616 25617 25618 25619 25620 25621 25622 25623 25624 25625 25626 25627 25628 25629 25630 25631 25632 25633 25634 25635 25636 25637 25638 25639 25640 25641 25642 25643 25644 25645 25646 25647 25648 25649 25650 25651 25652 25653 25654 25655 25656 25657 25658 25659 25660 25661 25662 25663 25664 25665 25666 25667 25668 25669 25670 25671 25672 25673 25674 25675 25676 25677 25678 25679 25680 25681 25682 25683 25684 25685 25686 25687 25688 25689 25690 25691 25692 25693 25694 25695 25696 25697 25698 25699 25700 25701 25702 25703 25704 25705 25706 25707 25708 25709 25710 25711 25712 25713 25714 25715 25716 25717 25718 25719 25720 25721 25722 25723 25724 25725 25726 25727 25728 25729 25730 25731 25732 25733 25734 25735 25736 25737 25738 25739 25740 25741 25742 25743 25744 25745 25746 25747 25748 25749 25750 25751 25752 25753 25754 25755 25756 25757 25758 25759 25760 25761 25762 25763 25764 25765 25766 25767 25768 25769 25770 25771 25772 25773 25774 25775 25776 25777 25778 25779 25780 25781 25782 25783 25784 25785 25786 25787 25788 25789 25790 25791 25792 25793 25794 25795 25796 25797 25798 25799 25800 25801 25802 25803 25804 25805 25806 25807 25808 25809 25810 25811 25812 25813 25814 25815 25816 25817 25818 25819 25820 25821 25822 25823 25824 25825 25826 25827 25828 25829 25830 25831 25832 25833 25834 25835 25836 25837 25838 25839 25840 25841 25842 25843 25844 25845 25846 25847 25848 25849 25850 25851 25852 25853 25854 25855 25856 25857 25858 25859 25860 25861 25862 25863 25864 25865 25866 25867 25868 25869 25870 25871 25872 25873 25874 25875 25876 25877 25878 25879 25880 25881 25882 25883 25884 25885 25886 25887 25888 25889 25890 25891 25892 25893 25894 25895 25896 25897 25898 25899 25900 25901 25902 25903 25904 25905 25906 25907 25908 25909 25910 25911 25912 25913 25914 25915 25916 25917 25918 25919 25920 25921 25922 25923 25924 25925 25926 25927 25928 25929 25930 25931 25932 25933 25934 25935 25936 25937 25938 25939 25940 25941 25942 25943 25944 25945 25946 25947 25948 25949 25950 25951 25952 25953 25954 25955 25956 25957 25958 25959 25960 25961 25962 25963 25964 25965 25966 25967 25968 25969 25970 25971 25972 25973 25974 25975 25976 25977 25978 25979 25980 25981 25982 25983 25984 25985 25986 25987 25988 25989 25990 25991 25992 25993 25994 25995 25996 25997 25998 25999 26000 26001 26002 26003 26004 26005 26006 26007 26008 26009 26010 26011 26012 26013 26014 26015 26016 26017 26018 26019 26020 26021 26022 26023 26024 26025 26026 26027 26028 26029 26030 26031 26032 26033 26034 26035 26036 26037 26038 26039 26040 26041 26042 26043 26044 26045 26046 26047 26048 26049 26050 26051 26052 26053 26054 26055 26056 26057 26058 26059 26060 26061 26062 26063 26064 26065 26066 26067 26068 26069 26070 26071 26072 26073 26074 26075 26076 26077 26078 26079 26080 26081 26082 26083 26084 26085 26086 26087 26088 26089 26090 26091 26092 26093 26094 26095 26096 26097 26098 26099 26100 26101 26102 26103 26104 26105 26106 26107 26108 26109 26110 26111 26112 26113 26114 26115 26116 26117 26118 26119 26120 26121 26122 26123 26124 26125 26126 26127 26128 26129 26130 26131 26132 26133 26134 26135 26136 26137 26138 26139 26140 26141 26142 26143 26144 26145 26146 26147 26148 26149 26150 26151 26152 26153 26154 26155 26156 26157 26158 26159 26160 26161 26162 26163 26164 26165 26166 26167 26168 26169 26170 26171 26172 26173 26174 26175 26176 26177 26178 26179 26180 26181 26182 26183 26184 26185 26186 26187 26188 26189 26190 26191 26192 26193 26194 26195 26196 26197 26198 26199 26200 26201 26202 26203 26204 26205 26206 26207 26208 26209 26210 26211 26212 26213 26214 26215 26216 26217 26218 26219 26220 26221 26222 26223 26224 26225 26226 26227 26228 26229 26230 26231 26232 26233 26234 26235 26236 26237 26238 26239 26240 26241 26242 26243 26244 26245 26246 26247 26248 26249 26250 26251 26252 26253 26254 26255 26256 26257 26258 26259 26260 26261 26262 26263 26264 26265 26266 26267 26268 26269 26270 26271 26272 26273 26274 26275 26276 26277 26278 26279 26280 26281 26282 26283 26284 26285 26286 26287 26288 26289 26290 26291 26292 26293 26294 26295 26296 26297 26298 26299 26300 26301 26302 26303 26304 26305 26306 26307 26308 26309 26310 26311 26312 26313 26314 26315 26316 26317 26318 26319 26320 26321 26322 26323 26324 26325 26326 26327 26328 26329 26330 26331 26332 26333 26334 26335 26336 26337 26338 26339 26340 26341 26342 26343 26344 26345 26346 26347 26348 26349 26350 26351 26352 26353 26354 26355 26356 26357 26358 26359 26360 26361 26362 26363 26364 26365 26366 26367 26368 26369 26370 26371 26372 26373 26374 26375 26376 26377 26378 26379 26380 26381 26382 26383 26384 26385 26386 26387 26388 26389 26390 26391 26392 26393 26394 26395 26396 26397 26398 26399 26400 26401 26402 26403 26404 26405 26406 26407 26408 26409 26410 26411 26412 26413 26414 26415 26416 26417 26418 26419 26420 26421 26422 26423 26424 26425 26426 26427 26428 26429 26430 26431 26432 26433 26434 26435 26436 26437 26438 26439 26440 26441 26442 26443 26444 26445 26446 26447 26448 26449 26450 26451 26452 26453 26454 26455 26456 26457 26458 26459 26460 26461 26462 26463 26464 26465 26466 26467 26468 26469 26470 26471 26472 26473 26474 26475 26476 26477 26478 26479 26480 26481 26482 26483 26484 26485 26486 26487 26488 26489 26490 26491 26492 26493 26494 26495 26496 26497 26498 26499 26500 26501 26502 26503 26504 26505 26506 26507 26508 26509 26510 26511 26512 26513 26514 26515 26516 26517 26518 26519 26520 26521 26522 26523 26524 26525 26526 26527 26528 26529 26530 26531 26532 26533 26534 26535 26536 26537 26538 26539 26540 26541 26542 26543 26544 26545 26546 26547 26548 26549 26550 26551 26552 26553 26554 26555 26556 26557 26558 26559 26560 26561 26562 26563 26564 26565 26566 26567 26568 26569 26570 26571 26572 26573 26574 26575 26576 26577 26578 26579 26580 26581 26582 26583 26584 26585 26586 26587 26588 26589 26590 26591 26592 26593 26594 26595 26596 26597 26598 26599 26600 26601 26602 26603 26604 26605 26606 26607 26608 26609 26610 26611 26612 26613 26614 26615 26616 26617 26618 26619 26620 26621 26622 26623 26624 26625 26626 26627 26628 26629 26630 26631 26632 26633 26634 26635 26636 26637 26638 26639 26640 26641 26642 26643 26644 26645 26646 26647 26648 26649 26650 26651 26652 26653 26654 26655 26656 26657 26658 26659 26660 26661 26662 26663 26664 26665 26666 26667 26668 26669 26670 26671 26672 26673 26674 26675 26676 26677 26678 26679 26680 26681 26682 26683 26684 26685 26686 26687 26688 26689 26690 26691 26692 26693 26694 26695 26696 26697 26698 26699 26700 26701 26702 26703 26704 26705 26706 26707 26708 26709 26710 26711 26712 26713 26714 26715 26716 26717 26718 26719 26720 26721 26722 26723 26724 26725 26726 26727 26728 26729 26730 26731 26732 26733 26734 26735 26736 26737 26738 26739 26740 26741 26742 26743 26744 26745 26746 26747 26748 26749 26750 26751 26752 26753 26754 26755 26756 26757 26758 26759 26760 26761 26762 26763 26764 26765 26766 26767 26768 26769 26770 26771 26772 26773 26774 26775 26776 26777 26778 26779 26780 26781 26782 26783 26784 26785 26786 26787 26788 26789 26790 26791 26792 26793 26794 26795 26796 26797 26798 26799 26800 26801 26802 26803 26804 26805 26806 26807 26808 26809 26810 26811 26812 26813 26814 26815 26816 26817 26818 26819 26820 26821 26822 26823 26824 26825 26826 26827 26828 26829 26830 26831 26832 26833 26834 26835 26836 26837 26838 26839 26840 26841 26842 26843 26844 26845 26846 26847 26848 26849 26850 26851 26852 26853 26854 26855 26856 26857 26858 26859 26860 26861 26862 26863 26864 26865 26866 26867 26868 26869 26870 26871 26872 26873 26874 26875 26876 26877 26878 26879 26880 26881 26882 26883 26884 26885 26886 26887 26888 26889 26890 26891 26892 26893 26894 26895 26896 26897 26898 26899 26900 26901 26902 26903 26904 26905 26906 26907 26908 26909 26910 26911 26912 26913 26914 26915 26916 26917 26918 26919 26920 26921 26922 26923 26924 26925 26926 26927 26928 26929 26930 26931 26932 26933 26934 26935 26936 26937 26938 26939 26940 26941 26942 26943 26944 26945 26946 26947 26948 26949 26950 26951 26952 26953 26954 26955 26956 26957 26958 26959 26960 26961 26962 26963 26964 26965 26966 26967 26968 26969 26970 26971 26972 26973 26974 26975 26976 26977 26978 26979 26980 26981 26982 26983 26984 26985 26986 26987 26988 26989 26990 26991 26992 26993 26994 26995 26996 26997 26998 26999 27000 27001 27002 27003 27004 27005 27006 27007 27008 27009 27010 27011 27012 27013 27014 27015 27016 27017 27018 27019 27020 27021 27022 27023 27024 27025 27026 27027 27028 27029 27030 27031 27032 27033 27034 27035 27036 27037 27038 27039 27040 27041 27042 27043 27044 27045 27046 27047 27048 27049 27050 27051 27052 27053 27054 27055 27056 27057 27058 27059 27060 27061 27062 27063 27064 27065 27066 27067 27068 27069 27070 27071 27072 27073 27074 27075 27076 27077 27078 27079 27080 27081 27082 27083 27084 27085 27086 27087 27088 27089 27090 27091 27092 27093 27094 27095 27096 27097 27098 27099 27100 27101 27102 27103 27104 27105 27106 27107 27108 27109 27110 27111 27112 27113 27114 27115 27116 27117 27118 27119 27120 27121 27122 27123 27124 27125 27126 27127 27128 27129 27130 27131 27132 27133 27134 27135 27136 27137 27138 27139 27140 27141 27142 27143 27144 27145 27146 27147 27148 27149 27150 27151 27152 27153 27154 27155 27156 27157 27158 27159 27160 27161 27162 27163 27164 27165 27166 27167 27168 27169 27170 27171 27172 27173 27174 27175 27176 27177 27178 27179 27180 27181 27182 27183 27184 27185 27186 27187 27188 27189 27190 27191 27192 27193 27194 27195 27196 27197 27198 27199 27200 27201 27202 27203 27204 27205 27206 27207 27208 27209 27210 27211 27212 27213 27214 27215 27216 27217 27218 27219 27220 27221 27222 27223 27224 27225 27226 27227 27228 27229 27230 27231 27232 27233 27234 27235 27236 27237 27238 27239 27240 27241 27242 27243 27244 27245 27246 27247 27248 27249 27250 27251 27252 27253 27254 27255 27256 27257 27258 27259 27260 27261 27262 27263 27264 27265 27266 27267 27268 27269 27270 27271 27272 27273 27274 27275 27276 27277 27278 27279 27280 27281 27282 27283 27284 27285 27286 27287 27288 27289 27290 27291 27292 27293 27294 27295 27296 27297 27298 27299 27300 27301 27302 27303 27304 27305 27306 27307 27308 27309 27310 27311 27312 27313 27314 27315 27316 27317 27318 27319 27320 27321 27322 27323 27324 27325 27326 27327 27328 27329 27330 27331 27332 27333 27334 27335 27336 27337 27338 27339 27340 27341 27342 27343 27344 27345 27346 27347 27348 27349 27350 27351 27352 27353 27354 27355 27356 27357 27358 27359 27360 27361 27362 27363 27364 27365 27366 27367 27368 27369 27370 27371 27372 27373 27374 27375 27376 27377 27378 27379 27380 27381 27382 27383 27384 27385 27386 27387 27388 27389 27390 27391 27392 27393 27394 27395 27396 27397 27398 27399 27400 27401 27402 27403 27404 27405 27406 27407 27408 27409 27410 27411 27412 27413 27414 27415 27416 27417 27418 27419 27420 27421 27422 27423 27424 27425 27426 27427 27428 27429 27430 27431 27432 27433 27434 27435 27436 27437 27438 27439 27440 27441 27442 27443 27444 27445 27446 27447 27448 27449 27450 27451 27452 27453 27454 27455 27456 27457 27458 27459 27460 27461 27462 27463 27464 27465 27466 27467 27468 27469 27470 27471 27472 27473 27474 27475 27476 27477 27478 27479 27480 27481 27482 27483 27484 27485 27486 27487 27488 27489 27490 27491 27492 27493 27494 27495 27496 27497 27498 27499 27500 27501 27502 27503 27504 27505 27506 27507 27508 27509 27510 27511 27512 27513 27514 27515 27516 27517 27518 27519 27520 27521 27522 27523 27524 27525 27526 27527 27528 27529 27530 27531 27532 27533 27534 27535 27536 27537 27538 27539 27540 27541 27542 27543 27544 27545 27546 27547 27548 27549 27550 27551 27552 27553 27554 27555 27556 27557 27558 27559 27560 27561 27562 27563 27564 27565 27566 27567 27568 27569 27570 27571 27572 27573 27574 27575 27576 27577 27578 27579 27580 27581 27582 27583 27584 27585 27586 27587 27588 27589 27590 27591 27592 27593 27594 27595 27596 27597 27598 27599 27600 27601 27602 27603 27604 27605 27606 27607 27608 27609 27610 27611 27612 27613 27614 27615 27616 27617 27618 27619 27620 27621 27622 27623 27624 27625 27626 27627 27628 27629 27630 27631 27632 27633 27634 27635 27636 27637 27638 27639 27640 27641 27642 27643 27644 27645 27646 27647 27648 27649 27650 27651 27652 27653 27654 27655 27656 27657 27658 27659 27660 27661 27662 27663 27664 27665 27666 27667 27668 27669 27670 27671 27672 27673 27674 27675 27676 27677 27678 27679 27680 27681 27682 27683 27684 27685 27686 27687 27688 27689 27690 27691 27692 27693 27694 27695 27696 27697 27698 27699 27700 27701 27702 27703 27704 27705 27706 27707 27708 27709 27710 27711 27712 27713 27714 27715 27716 27717 27718 27719 27720 27721 27722 27723 27724 27725 27726 27727 27728 27729 27730 27731 27732 27733 27734 27735 27736 27737 27738 27739 27740 27741 27742 27743 27744 27745 27746 27747 27748 27749 27750 27751 27752 27753 27754 27755 27756 27757 27758 27759 27760 27761 27762 27763 27764 27765 27766 27767 27768 27769 27770 27771 27772 27773 27774 27775 27776 27777 27778 27779 27780 27781 27782 27783 27784 27785 27786 27787 27788 27789 27790 27791 27792 27793 27794 27795 27796 27797 27798 27799 27800 27801 27802 27803 27804 27805 27806 27807 27808 27809 27810 27811 27812 27813 27814 27815 27816 27817 27818 27819 27820 27821 27822 27823 27824 27825 27826 27827 27828 27829 27830 27831 27832 27833 27834 27835 27836 27837 27838 27839 27840 27841 27842 27843 27844 27845 27846 27847 27848 27849 27850 27851 27852 27853 27854 27855 27856 27857 27858 27859 27860 27861 27862 27863 27864 27865 27866 27867 27868 27869 27870 27871 27872 27873 27874 27875 27876 27877 27878 27879 27880 27881 27882 27883 27884 27885 27886 27887 27888 27889 27890 27891 27892 27893 27894 27895 27896 27897 27898 27899 27900 27901 27902 27903 27904 27905 27906 27907 27908 27909 27910 27911 27912 27913 27914 27915 27916 27917 27918 27919 27920 27921 27922 27923 27924 27925 27926 27927 27928 27929 27930 27931 27932 27933 27934 27935 27936 27937 27938 27939 27940 27941 27942 27943 27944 27945 27946 27947 27948 27949 27950 27951 27952 27953 27954 27955 27956 27957 27958 27959 27960 27961 27962 27963 27964 27965 27966 27967 27968 27969 27970 27971 27972 27973 27974 27975 27976 27977 27978 27979 27980 27981 27982 27983 27984 27985 27986 27987 27988 27989 27990 27991 27992 27993 27994 27995 27996 27997 27998 27999 28000 28001 28002 28003 28004 28005 28006 28007 28008 28009 28010 28011 28012 28013 28014 28015 28016 28017 28018 28019 28020 28021 28022 28023 28024 28025 28026 28027 28028 28029 28030 28031 28032 28033 28034 28035 28036 28037 28038 28039 28040 28041 28042 28043 28044 28045 28046 28047 28048 28049 28050 28051 28052 28053 28054 28055 28056 28057 28058 28059 28060 28061 28062 28063 28064 28065 28066 28067 28068 28069 28070 28071 28072 28073 28074 28075 28076 28077 28078 28079 28080 28081 28082 28083 28084 28085 28086 28087 28088 28089 28090 28091 28092 28093 28094 28095 28096 28097 28098 28099 28100 28101 28102 28103 28104 28105 28106 28107 28108 28109 28110 28111 28112 28113 28114 28115 28116 28117 28118 28119 28120 28121 28122 28123 28124 28125 28126 28127 28128 28129 28130 28131 28132 28133 28134 28135 28136 28137 28138 28139 28140 28141 28142 28143 28144 28145 28146 28147 28148 28149 28150 28151 28152 28153 28154 28155 28156 28157 28158 28159 28160 28161 28162 28163 28164 28165 28166 28167 28168 28169 28170 28171 28172 28173 28174 28175 28176 28177 28178 28179 28180 28181 28182 28183 28184 28185 28186 28187 28188 28189 28190 28191 28192 28193 28194 28195 28196 28197 28198 28199 28200 28201 28202 28203 28204 28205 28206 28207 28208 28209 28210 28211 28212 28213 28214 28215 28216 28217 28218 28219 28220 28221 28222 28223 28224 28225 28226 28227 28228 28229 28230 28231 28232 28233 28234 28235 28236 28237 28238 28239 28240 28241 28242 28243 28244 28245 28246 28247 28248 28249 28250 28251 28252 28253 28254 28255 28256 28257 28258 28259 28260 28261 28262 28263 28264 28265 28266 28267 28268 28269 28270 28271 28272 28273 28274 28275 28276 28277 28278 28279 28280 28281 28282 28283 28284 28285 28286 28287 28288 28289 28290 28291 28292 28293 28294 28295 28296 28297 28298 28299 28300 28301 28302 28303 28304 28305 28306 28307 28308 28309 28310 28311 28312 28313 28314 28315 28316 28317 28318 28319 28320 28321 28322 28323 28324 28325 28326 28327 28328 28329 28330 28331 28332 28333 28334 28335 28336 28337 28338 28339 28340 28341 28342 28343 28344 28345 28346 28347 28348 28349 28350 28351 28352 28353 28354 28355 28356 28357 28358 28359 28360 28361 28362 28363 28364 28365 28366 28367 28368 28369 28370 28371 28372 28373 28374 28375 28376 28377 28378 28379 28380 28381 28382 28383 28384 28385 28386 28387 28388 28389 28390 28391 28392 28393 28394 28395 28396 28397 28398 28399 28400 28401 28402 28403 28404 28405 28406 28407 28408 28409 28410 28411 28412 28413 28414 28415 28416 28417 28418 28419 28420 28421 28422 28423 28424 28425 28426 28427 28428 28429 28430 28431 28432 28433 28434 28435 28436 28437 28438 28439 28440 28441 28442 28443 28444 28445 28446 28447 28448 28449 28450 28451 28452 28453 28454 28455 28456 28457 28458 28459 28460 28461 28462 28463 28464 28465 28466 28467 28468 28469 28470 28471 28472 28473 28474 28475 28476 28477 28478 28479 28480 28481 28482 28483 28484 28485 28486 28487 28488 28489 28490 28491 28492 28493 28494 28495 28496 28497 28498 28499 28500 28501 28502 28503 28504 28505 28506 28507 28508 28509 28510 28511 28512 28513 28514 28515 28516 28517 28518 28519 28520 28521 28522 28523 28524 28525 28526 28527 28528 28529 28530 28531 28532 28533 28534 28535 28536 28537 28538 28539 28540 28541 28542 28543 28544 28545 28546 28547 28548 28549 28550 28551 28552 28553 28554 28555 28556 28557 28558 28559 28560 28561 28562 28563 28564 28565 28566 28567 28568 28569 28570 28571 28572 28573 28574 28575 28576 28577 28578 28579 28580 28581 28582 28583 28584 28585 28586 28587 28588 28589 28590 28591 28592 28593 28594 28595 28596 28597 28598 28599 28600 28601 28602 28603 28604 28605 28606 28607 28608 28609 28610 28611 28612 28613 28614 28615 28616 28617 28618 28619 28620 28621 28622 28623 28624 28625 28626 28627 28628 28629 28630 28631 28632 28633 28634 28635 28636 28637 28638 28639 28640 28641 28642 28643 28644 28645 28646 28647 28648 28649 28650 28651 28652 28653 28654 28655 28656 28657 28658 28659 28660 28661 28662 28663 28664 28665 28666 28667 28668 28669 28670 28671 28672 28673 28674 28675 28676 28677 28678 28679 28680 28681 28682 28683 28684 28685 28686 28687 28688 28689 28690 28691 28692 28693 28694 28695 28696 28697 28698 28699 28700 28701 28702 28703 28704 28705 28706 28707 28708 28709 28710 28711 28712 28713 28714 28715 28716 28717 28718 28719 28720 28721 28722 28723 28724 28725 28726 28727 28728 28729 28730 28731 28732 28733 28734 28735 28736 28737 28738 28739 28740 28741 28742 28743 28744 28745 28746 28747 28748 28749 28750 28751 28752 28753 28754 28755 28756 28757 28758 28759 28760 28761 28762 28763 28764 28765 28766 28767 28768 28769 28770 28771 28772 28773 28774 28775 28776 28777 28778 28779 28780 28781 28782 28783 28784 28785 28786 28787 28788 28789 28790 28791 28792 28793 28794 28795 28796 28797 28798 28799 28800 28801 28802 28803 28804 28805 28806 28807 28808 28809 28810 28811 28812 28813 28814 28815 28816 28817 28818 28819 28820 28821 28822 28823 28824 28825 28826 28827 28828 28829 28830 28831 28832 28833 28834 28835 28836 28837 28838 28839 28840 28841 28842 28843 28844 28845 28846 28847 28848 28849 28850 28851 28852 28853 28854 28855 28856 28857 28858 28859 28860 28861 28862 28863 28864 28865 28866 28867 28868 28869 28870 28871 28872 28873 28874 28875 28876 28877 28878 28879 28880 28881 28882 28883 28884 28885 28886 28887 28888 28889 28890 28891 28892 28893 28894 28895 28896 28897 28898 28899 28900 28901 28902 28903 28904 28905 28906 28907 28908 28909 28910 28911 28912 28913 28914 28915 28916 28917 28918 28919 28920 28921 28922 28923 28924 28925 28926 28927 28928 28929 28930 28931 28932 28933 28934 28935 28936 28937 28938 28939 28940 28941 28942 28943 28944 28945 28946 28947 28948 28949 28950 28951 28952 28953 28954 28955 28956 28957 28958 28959 28960 28961 28962 28963 28964 28965 28966 28967 28968 28969 28970 28971 28972 28973 28974 28975 28976 28977 28978 28979 28980 28981 28982 28983 28984 28985 28986 28987 28988 28989 28990 28991 28992 28993 28994 28995 28996 28997 28998 28999 29000 29001 29002 29003 29004 29005 29006 29007 29008 29009 29010 29011 29012 29013 29014 29015 29016 29017 29018 29019 29020 29021 29022 29023 29024 29025 29026 29027 29028 29029 29030 29031 29032 29033 29034 29035 29036 29037 29038 29039 29040 29041 29042 29043 29044 29045 29046 29047 29048 29049 29050 29051 29052 29053 29054 29055 29056 29057 29058 29059 29060 29061 29062 29063 29064 29065 29066 29067 29068 29069 29070 29071 29072 29073 29074 29075 29076 29077 29078 29079 29080 29081 29082 29083 29084 29085 29086 29087 29088 29089 29090 29091 29092 29093 29094 29095 29096 29097 29098 29099 29100 29101 29102 29103 29104 29105 29106 29107 29108 29109 29110 29111 29112 29113 29114 29115 29116 29117 29118 29119 29120 29121 29122 29123 29124 29125 29126 29127 29128 29129 29130 29131 29132 29133 29134 29135 29136 29137 29138 29139 29140 29141 29142 29143 29144 29145 29146 29147 29148 29149 29150 29151 29152 29153 29154 29155 29156 29157 29158 29159 29160 29161 29162 29163 29164 29165 29166 29167 29168 29169 29170 29171 29172 29173 29174 29175 29176 29177 29178 29179 29180 29181 29182 29183 29184 29185 29186 29187 29188 29189 29190 29191 29192 29193 29194 29195 29196 29197 29198 29199 29200 29201 29202 29203 29204 29205 29206 29207 29208 29209 29210 29211 29212 29213 29214 29215 29216 29217 29218 29219 29220 29221 29222 29223 29224 29225 29226 29227 29228 29229 29230 29231 29232 29233 29234 29235 29236 29237 29238 29239 29240 29241 29242 29243 29244 29245 29246 29247 29248 29249 29250 29251 29252 29253 29254 29255 29256 29257 29258 29259 29260 29261 29262 29263 29264 29265 29266 29267 29268 29269 29270 29271 29272 29273 29274 29275 29276 29277 29278 29279 29280 29281 29282 29283 29284 29285 29286 29287 29288 29289 29290 29291 29292 29293 29294 29295 29296 29297 29298 29299 29300 29301 29302 29303 29304 29305 29306 29307 29308 29309 29310 29311 29312 29313 29314 29315 29316 29317 29318 29319 29320 29321 29322 29323 29324 29325 29326 29327 29328 29329 29330 29331 29332 29333 29334 29335 29336 29337 29338 29339 29340 29341 29342 29343 29344 29345 29346 29347 29348 29349 29350 29351 29352 29353 29354 29355 29356 29357 29358 29359 29360 29361 29362 29363 29364 29365 29366 29367 29368 29369 29370 29371 29372 29373 29374 29375 29376 29377 29378 29379 29380 29381 29382 29383 29384 29385 29386 29387 29388 29389 29390 29391 29392 29393 29394 29395 29396 29397 29398 29399 29400 29401 29402 29403 29404 29405 29406 29407 29408 29409 29410 29411 29412 29413 29414 29415 29416 29417 29418 29419 29420 29421 29422 29423 29424 29425 29426 29427 29428 29429 29430 29431 29432 29433 29434 29435 29436 29437 29438 29439 29440 29441 29442 29443 29444 29445 29446 29447 29448 29449 29450 29451 29452 29453 29454 29455 29456 29457 29458 29459 29460 29461 29462 29463 29464 29465 29466 29467 29468 29469 29470 29471 29472 29473 29474 29475 29476 29477 29478 29479 29480 29481 29482 29483 29484 29485 29486 29487 29488 29489 29490 29491 29492 29493 29494 29495 29496 29497 29498 29499 29500 29501 29502 29503 29504 29505 29506 29507 29508 29509 29510 29511 29512 29513 29514 29515 29516 29517 29518 29519 29520 29521 29522 29523 29524 29525 29526 29527 29528 29529 29530 29531 29532 29533 29534 29535 29536 29537 29538 29539 29540 29541 29542 29543 29544 29545 29546 29547 29548 29549 29550 29551 29552 29553 29554 29555 29556 29557 29558 29559 29560 29561 29562 29563 29564 29565 29566 29567 29568 29569 29570 29571 29572 29573 29574 29575 29576 29577 29578 29579 29580 29581 29582 29583 29584 29585 29586 29587 29588 29589 29590 29591 29592 29593 29594 29595 29596 29597 29598 29599 29600 29601 29602 29603 29604 29605 29606 29607 29608 29609 29610 29611 29612 29613 29614 29615 29616 29617 29618 29619 29620 29621 29622 29623 29624 29625 29626 29627 29628 29629 29630 29631 29632 29633 29634 29635 29636 29637 29638 29639 29640 29641 29642 29643 29644 29645 29646 29647 29648 29649 29650 29651 29652 29653 29654 29655 29656 29657 29658 29659 29660 29661 29662 29663 29664 29665 29666 29667 29668 29669 29670 29671 29672 29673 29674 29675 29676 29677 29678 29679 29680 29681 29682 29683 29684 29685 29686 29687 29688 29689 29690 29691 29692 29693 29694 29695 29696 29697 29698 29699 29700 29701 29702 29703 29704 29705 29706 29707 29708 29709 29710 29711 29712 29713 29714 29715 29716 29717 29718 29719 29720 29721 29722 29723 29724 29725 29726 29727 29728 29729 29730 29731 29732 29733 29734 29735 29736 29737 29738 29739 29740 29741 29742 29743 29744 29745 29746 29747 29748 29749 29750 29751 29752 29753 29754 29755 29756 29757 29758 29759 29760 29761 29762 29763 29764 29765 29766 29767 29768 29769 29770 29771 29772 29773 29774 29775 29776 29777 29778 29779 29780 29781 29782 29783 29784 29785 29786 29787 29788 29789 29790 29791 29792 29793 29794 29795 29796 29797 29798 29799 29800 29801 29802 29803 29804 29805 29806 29807 29808 29809 29810 29811 29812 29813 29814 29815 29816 29817 29818 29819 29820 29821 29822 29823 29824 29825 29826 29827 29828 29829 29830 29831 29832 29833 29834 29835 29836 29837 29838 29839 29840 29841 29842 29843 29844 29845 29846 29847 29848 29849 29850 29851 29852 29853 29854 29855 29856 29857 29858 29859 29860 29861 29862 29863 29864 29865 29866 29867 29868 29869 29870 29871 29872 29873 29874 29875 29876 29877 29878 29879 29880 29881 29882 29883 29884 29885 29886 29887 29888 29889 29890 29891 29892 29893 29894 29895 29896 29897 29898 29899 29900 29901 29902 29903 29904 29905 29906 29907 29908 29909 29910 29911 29912 29913 29914 29915 29916 29917 29918 29919 29920 29921 29922 29923 29924 29925 29926 29927 29928 29929 29930 29931 29932 29933 29934 29935 29936 29937 29938 29939 29940 29941 29942 29943 29944 29945 29946 29947 29948 29949 29950 29951 29952 29953 29954 29955 29956 29957 29958 29959 29960 29961 29962 29963 29964 29965 29966 29967 29968 29969 29970 29971 29972 29973 29974 29975 29976 29977 29978 29979 29980 29981 29982 29983 29984 29985 29986 29987 29988 29989 29990 29991 29992 29993 29994 29995 29996 29997 29998 29999 30000 30001 30002 30003 30004 30005 30006 30007 30008 30009 30010 30011 30012 30013 30014 30015 30016 30017 30018 30019 30020 30021 30022 30023 30024 30025 30026 30027 30028 30029 30030 30031 30032 30033 30034 30035 30036 30037 30038 30039 30040 30041 30042 30043 30044 30045 30046 30047 30048 30049 30050 30051 30052 30053 30054 30055 30056 30057 30058 30059 30060 30061 30062 30063 30064 30065 30066 30067 30068 30069 30070 30071 30072 30073 30074 30075 30076 30077 30078 30079 30080 30081 30082 30083 30084 30085 30086 30087 30088 30089 30090 30091 30092 30093 30094 30095 30096 30097 30098 30099 30100 30101 30102 30103 30104 30105 30106 30107 30108 30109 30110 30111 30112 30113 30114 30115 30116 30117 30118 30119 30120 30121 30122 30123 30124 30125 30126 30127 30128 30129 30130 30131 30132 30133 30134 30135 30136 30137 30138 30139 30140 30141 30142 30143 30144 30145 30146 30147 30148 30149 30150 30151 30152 30153 30154 30155 30156 30157 30158 30159 30160 30161 30162 30163 30164 30165 30166 30167 30168 30169 30170 30171 30172 30173 30174 30175 30176 30177 30178 30179 30180 30181 30182 30183 30184 30185 30186 30187 30188 30189 30190 30191 30192 30193 30194 30195 30196 30197 30198 30199 30200 30201 30202 30203 30204 30205 30206 30207 30208 30209 30210 30211 30212 30213 30214 30215 30216 30217 30218 30219 30220 30221 30222 30223 30224 30225 30226 30227 30228 30229 30230 30231 30232 30233 30234 30235 30236 30237 30238 30239 30240 30241 30242 30243 30244 30245 30246 30247 30248 30249 30250 30251 30252 30253 30254 30255 30256 30257 30258 30259 30260 30261 30262 30263 30264 30265 30266 30267 30268 30269 30270 30271 30272 30273 30274 30275 30276 30277 30278 30279 30280 30281 30282 30283 30284 30285 30286 30287 30288 30289 30290 30291 30292 30293 30294 30295 30296 30297 30298 30299 30300 30301 30302 30303 30304 30305 30306 30307 30308 30309 30310 30311 30312 30313 30314 30315 30316 30317 30318 30319 30320 30321 30322 30323 30324 30325 30326 30327 30328 30329 30330 30331 30332 30333 30334 30335 30336 30337 30338 30339 30340 30341 30342 30343 30344 30345 30346 30347 30348 30349 30350 30351 30352 30353 30354 30355 30356 30357 30358 30359 30360 30361 30362 30363 30364 30365 30366 30367 30368 30369 30370 30371 30372 30373 30374 30375 30376 30377 30378 30379 30380 30381 30382 30383 30384 30385 30386 30387 30388 30389 30390 30391 30392 30393 30394 30395 30396 30397 30398 30399 30400 30401 30402 30403 30404 30405 30406 30407 30408 30409 30410 30411 30412 30413 30414 30415 30416 30417 30418 30419 30420 30421 30422 30423 30424 30425 30426 30427 30428 30429 30430 30431 30432 30433 30434 30435 30436 30437 30438 30439 30440 30441 30442 30443 30444 30445 30446 30447 30448 30449 30450 30451 30452 30453 30454 30455 30456 30457 30458 30459 30460 30461 30462 30463 30464 30465 30466 30467 30468 30469 30470 30471 30472 30473 30474 30475 30476 30477 30478 30479 30480 30481 30482 30483 30484 30485 30486 30487 30488 30489 30490 30491 30492 30493 30494 30495 30496 30497 30498 30499 30500 30501 30502 30503 30504 30505 30506 30507 30508 30509 30510 30511 30512 30513 30514 30515 30516 30517 30518 30519 30520 30521 30522 30523 30524 30525 30526 30527 30528 30529 30530 30531 30532 30533 30534 30535 30536 30537 30538 30539 30540 30541 30542 30543 30544 30545 30546 30547 30548 30549 30550 30551 30552 30553 30554 30555 30556 30557 30558 30559 30560 30561 30562 30563 30564 30565 30566 30567 30568 30569 30570 30571 30572 30573 30574 30575 30576 30577 30578 30579 30580 30581 30582 30583 30584 30585 30586 30587 30588 30589 30590 30591 30592 30593 30594 30595 30596 30597 30598 30599 30600 30601 30602 30603 30604 30605 30606 30607 30608 30609 30610 30611 30612 30613 30614 30615 30616 30617 30618 30619 30620 30621 30622 30623 30624 30625 30626 30627 30628 30629 30630 30631 30632 30633 30634 30635 30636 30637 30638 30639 30640 30641 30642 30643 30644 30645 30646 30647 30648 30649 30650 30651 30652 30653 30654 30655 30656 30657 30658 30659 30660 30661 30662 30663 30664 30665 30666 30667 30668 30669 30670 30671 30672 30673 30674 30675 30676 30677 30678 30679 30680 30681 30682 30683 30684 30685 30686 30687 30688 30689 30690 30691 30692 30693 30694 30695 30696 30697 30698 30699 30700 30701 30702 30703 30704 30705 30706 30707 30708 30709 30710 30711 30712 30713 30714 30715 30716 30717 30718 30719 30720 30721 30722 30723 30724 30725 30726 30727 30728 30729 30730 30731 30732 30733 30734 30735 30736 30737 30738 30739 30740 30741 30742 30743 30744 30745 30746 30747 30748 30749 30750 30751 30752 30753 30754 30755 30756 30757 30758 30759 30760 30761 30762 30763 30764 30765 30766 30767 30768 30769 30770 30771 30772 30773 30774 30775 30776 30777 30778 30779 30780 30781 30782 30783 30784 30785 30786 30787 30788 30789 30790 30791 30792 30793 30794 30795 30796 30797 30798 30799 30800 30801 30802 30803 30804 30805 30806 30807 30808 30809 30810 30811 30812 30813 30814 30815 30816 30817 30818 30819 30820 30821 30822 30823 30824 30825 30826 30827 30828 30829 30830 30831 30832 30833 30834 30835 30836 30837 30838 30839 30840 30841 30842 30843 30844 30845 30846 30847 30848 30849 30850 30851 30852 30853 30854 30855 30856 30857 30858 30859 30860 30861 30862 30863 30864 30865 30866 30867 30868 30869 30870 30871 30872 30873 30874 30875 30876 30877 30878 30879 30880 30881 30882 30883 30884 30885 30886 30887 30888 30889 30890 30891 30892 30893 30894 30895 30896 30897 30898 30899 30900 30901 30902 30903 30904 30905 30906 30907 30908 30909 30910 30911 30912 30913 30914 30915 30916 30917 30918 30919 30920 30921 30922 30923 30924 30925 30926 30927 30928 30929 30930 30931 30932 30933 30934 30935 30936 30937 30938 30939 30940 30941 30942 30943 30944 30945 30946 30947 30948 30949 30950 30951 30952 30953 30954 30955 30956 30957 30958 30959 30960 30961 30962 30963 30964 30965 30966 30967 30968 30969 30970 30971 30972 30973 30974 30975 30976 30977 30978 30979 30980 30981 30982 30983 30984 30985 30986 30987 30988 30989 30990 30991 30992 30993 30994 30995 30996 30997 30998 30999 31000 31001 31002 31003 31004 31005 31006 31007 31008 31009 31010 31011 31012 31013 31014 31015 31016 31017 31018 31019 31020 31021 31022 31023 31024 31025 31026 31027 31028 31029 31030 31031 31032 31033 31034 31035 31036 31037 31038 31039 31040 31041 31042 31043 31044 31045 31046 31047 31048 31049 31050 31051 31052 31053 31054 31055 31056 31057 31058 31059 31060 31061 31062 31063 31064 31065 31066 31067 31068 31069 31070 31071 31072 31073 31074 31075 31076 31077 31078 31079 31080 31081 31082 31083 31084 31085 31086 31087 31088 31089 31090 31091 31092 31093 31094 31095 31096 31097 31098 31099 31100 31101 31102 31103 31104 31105 31106 31107 31108 31109 31110 31111 31112 31113 31114 31115 31116 31117 31118 31119 31120 31121 31122 31123 31124 31125 31126 31127 31128 31129 31130 31131 31132 31133 31134 31135 31136 31137 31138 31139 31140 31141 31142 31143 31144 31145 31146 31147 31148 31149 31150 31151 31152 31153 31154 31155 31156 31157 31158 31159 31160 31161 31162 31163 31164 31165 31166 31167 31168 31169 31170 31171 31172 31173 31174 31175 31176 31177 31178 31179 31180 31181 31182 31183 31184 31185 31186 31187 31188 31189 31190 31191 31192 31193 31194 31195 31196 31197 31198 31199 31200 31201 31202 31203 31204 31205 31206 31207 31208 31209 31210 31211 31212 31213 31214 31215 31216 31217 31218 31219 31220 31221 31222 31223 31224 31225 31226 31227 31228 31229 31230 31231 31232 31233 31234 31235 31236 31237 31238 31239 31240 31241 31242 31243 31244 31245 31246 31247 31248 31249 31250 31251 31252 31253 31254 31255 31256 31257 31258 31259 31260 31261 31262 31263 31264 31265 31266 31267 31268 31269 31270 31271 31272 31273 31274 31275 31276 31277 31278 31279 31280 31281 31282 31283 31284 31285 31286 31287 31288 31289 31290 31291 31292 31293 31294 31295 31296 31297 31298 31299 31300 31301 31302 31303 31304 31305 31306 31307 31308 31309 31310 31311 31312 31313 31314 31315 31316 31317 31318 31319 31320 31321 31322 31323 31324 31325 31326 31327 31328 31329 31330 31331 31332 31333 31334 31335 31336 31337 31338 31339 31340 31341 31342 31343 31344 31345 31346 31347 31348 31349 31350 31351 31352 31353 31354 31355 31356 31357 31358 31359 31360 31361 31362 31363 31364 31365 31366 31367 31368 31369 31370 31371 31372 31373 31374 31375 31376 31377 31378 31379 31380 31381 31382 31383 31384 31385 31386 31387 31388 31389 31390 31391 31392 31393 31394 31395 31396 31397 31398 31399 31400 31401 31402 31403 31404 31405 31406 31407 31408 31409 31410 31411 31412 31413 31414 31415 31416 31417 31418 31419 31420 31421 31422 31423 31424 31425 31426 31427 31428 31429 31430 31431 31432 31433 31434 31435 31436 31437 31438 31439 31440 31441 31442 31443 31444 31445 31446 31447 31448 31449 31450 31451 31452 31453 31454 31455 31456 31457 31458 31459 31460 31461 31462 31463 31464 31465 31466 31467 31468 31469 31470 31471 31472 31473 31474 31475 31476 31477 31478 31479 31480 31481 31482 31483 31484 31485 31486 31487 31488 31489 31490 31491 31492 31493 31494 31495 31496 31497 31498 31499 31500 31501 31502 31503 31504 31505 31506 31507 31508 31509 31510 31511 31512 31513 31514 31515 31516 31517 31518 31519 31520 31521 31522 31523 31524 31525 31526 31527 31528 31529 31530 31531 31532 31533 31534 31535 31536 31537 31538 31539 31540 31541 31542 31543 31544 31545 31546 31547 31548 31549 31550 31551 31552 31553 31554 31555 31556 31557 31558 31559 31560 31561 31562 31563 31564 31565 31566 31567 31568 31569 31570 31571 31572 31573 31574 31575 31576 31577 31578 31579 31580 31581 31582 31583 31584 31585 31586 31587 31588 31589 31590 31591 31592 31593 31594 31595 31596 31597 31598 31599 31600 31601 31602 31603 31604 31605 31606 31607 31608 31609 31610 31611 31612 31613 31614 31615 31616 31617 31618 31619 31620 31621 31622 31623 31624 31625 31626 31627 31628 31629 31630 31631 31632 31633 31634 31635 31636 31637 31638 31639 31640 31641 31642 31643 31644 31645 31646 31647 31648 31649 31650 31651 31652 31653 31654 31655 31656 31657 31658 31659 31660 31661 31662 31663 31664 31665 31666 31667 31668 31669 31670 31671 31672 31673 31674 31675 31676 31677 31678 31679 31680 31681 31682 31683 31684 31685 31686 31687 31688 31689 31690 31691 31692 31693 31694 31695 31696 31697 31698 31699 31700 31701 31702 31703 31704 31705 31706 31707 31708 31709 31710 31711 31712 31713 31714 31715 31716 31717 31718 31719 31720 31721 31722 31723 31724 31725 31726 31727 31728 31729 31730 31731 31732 31733 31734 31735 31736 31737 31738 31739 31740 31741 31742 31743 31744 31745 31746 31747 31748 31749 31750 31751 31752 31753 31754 31755 31756 31757 31758 31759 31760 31761 31762 31763 31764 31765 31766 31767 31768 31769 31770 31771 31772 31773 31774 31775 31776 31777 31778 31779 31780 31781 31782 31783 31784 31785 31786 31787 31788 31789 31790 31791 31792 31793 31794 31795 31796 31797 31798 31799 31800 31801 31802 31803 31804 31805 31806 31807 31808 31809 31810 31811 31812 31813 31814 31815 31816 31817 31818 31819 31820 31821 31822 31823 31824 31825 31826 31827 31828 31829 31830 31831 31832 31833 31834 31835 31836 31837 31838 31839 31840 31841 31842 31843 31844 31845 31846 31847 31848 31849 31850 31851 31852 31853 31854 31855 31856 31857 31858 31859 31860 31861 31862 31863 31864 31865 31866 31867 31868 31869 31870 31871 31872 31873 31874 31875 31876 31877 31878 31879 31880 31881 31882 31883 31884 31885 31886 31887 31888 31889 31890 31891 31892 31893 31894 31895 31896 31897 31898 31899 31900 31901 31902 31903 31904 31905 31906 31907 31908 31909 31910 31911 31912 31913 31914 31915 31916 31917 31918 31919 31920 31921 31922 31923 31924 31925 31926 31927 31928 31929 31930 31931 31932 31933 31934 31935 31936 31937 31938 31939 31940 31941 31942 31943 31944 31945 31946 31947 31948 31949 31950 31951 31952 31953 31954 31955 31956 31957 31958 31959 31960 31961 31962 31963 31964 31965 31966 31967 31968 31969 31970 31971 31972 31973 31974 31975 31976 31977 31978 31979 31980 31981 31982 31983 31984 31985 31986 31987 31988 31989 31990 31991 31992 31993 31994 31995 31996 31997 31998 31999 32000 32001 32002 32003 32004 32005 32006 32007 32008 32009 32010 32011 32012 32013 32014 32015 32016 32017 32018 32019 32020 32021 32022 32023 32024 32025 32026 32027 32028 32029 32030 32031 32032 32033 32034 32035 32036 32037 32038 32039 32040 32041 32042 32043 32044 32045 32046 32047 32048 32049 32050 32051 32052 32053 32054 32055 32056 32057 32058 32059 32060 32061 32062 32063 32064 32065 32066 32067 32068 32069 32070 32071 32072 32073 32074 32075 32076 32077 32078 32079 32080 32081 32082 32083 32084 32085 32086 32087 32088 32089 32090 32091 32092 32093 32094 32095 32096 32097 32098 32099 32100 32101 32102 32103 32104 32105 32106 32107 32108 32109 32110 32111 32112 32113 32114 32115 32116 32117 32118 32119 32120 32121 32122 32123 32124 32125 32126 32127 32128 32129 32130 32131 32132 32133 32134 32135 32136 32137 32138 32139 32140 32141 32142 32143 32144 32145 32146 32147 32148 32149 32150 32151 32152 32153 32154 32155 32156 32157 32158 32159 32160 32161 32162 32163 32164 32165 32166 32167 32168 32169 32170 32171 32172 32173 32174 32175 32176 32177 32178 32179 32180 32181 32182 32183 32184 32185 32186 32187 32188 32189 32190 32191 32192 32193 32194 32195 32196 32197 32198 32199 32200 32201 32202 32203 32204 32205 32206 32207 32208 32209 32210 32211 32212 32213 32214 32215 32216 32217 32218 32219 32220 32221 32222 32223 32224 32225 32226 32227 32228 32229 32230 32231 32232 32233 32234 32235 32236 32237 32238 32239 32240 32241 32242 32243 32244 32245 32246 32247 32248 32249 32250 32251 32252 32253 32254 32255 32256 32257 32258 32259 32260 32261 32262 32263 32264 32265 32266 32267 32268 32269 32270 32271 32272 32273 32274 32275 32276 32277 32278 32279 32280 32281 32282 32283 32284 32285 32286 32287 32288 32289 32290 32291 32292 32293 32294 32295 32296 32297 32298 32299 32300 32301 32302 32303 32304 32305 32306 32307 32308 32309 32310 32311 32312 32313 32314 32315 32316 32317 32318 32319 32320 32321 32322 32323 32324 32325 32326 32327 32328 32329 32330 32331 32332 32333 32334 32335 32336 32337 32338 32339 32340 32341 32342 32343 32344 32345 32346 32347 32348 32349 32350 32351 32352 32353 32354 32355 32356 32357 32358 32359 32360 32361 32362 32363 32364 32365 32366 32367 32368 32369 32370 32371 32372 32373 32374 32375 32376 32377 32378 32379 32380 32381 32382 32383 32384 32385 32386 32387 32388 32389 32390 32391 32392 32393 32394 32395 32396 32397 32398 32399 32400 32401 32402 32403 32404 32405 32406 32407 32408 32409 32410 32411 32412 32413 32414 32415 32416 32417 32418 32419 32420 32421 32422 32423 32424 32425 32426 32427 32428 32429 32430 32431 32432 32433 32434 32435 32436 32437 32438 32439 32440 32441 32442 32443 32444 32445 32446 32447 32448 32449 32450 32451 32452 32453 32454 32455 32456 32457 32458 32459 32460 32461 32462 32463 32464 32465 32466 32467 32468 32469 32470 32471 32472 32473 32474 32475 32476 32477 32478 32479 32480 32481 32482 32483 32484 32485 32486 32487 32488 32489 32490 32491 32492 32493 32494 32495 32496 32497 32498 32499 32500 32501 32502 32503 32504 32505 32506 32507 32508 32509 32510 32511 32512 32513 32514 32515 32516 32517 32518 32519 32520 32521 32522 32523 32524 32525 32526 32527 32528 32529 32530 32531 32532 32533 32534 32535 32536 32537 32538 32539 32540 32541 32542 32543 32544 32545 32546 32547 32548 32549 32550 32551 32552 32553 32554 32555 32556 32557 32558 32559 32560 32561 32562 32563 32564 32565 32566 32567 32568 32569 32570 32571 32572 32573 32574 32575 32576 32577 32578 32579 32580 32581 32582 32583 32584 32585 32586 32587 32588 32589 32590 32591 32592 32593 32594 32595 32596 32597 32598 32599 32600 32601 32602 32603 32604 32605 32606 32607 32608 32609 32610 32611 32612 32613 32614 32615 32616 32617 32618 32619 32620 32621 32622 32623 32624 32625 32626 32627 32628 32629 32630 32631 32632 32633 32634 32635 32636 32637 32638 32639 32640 32641 32642 32643 32644 32645 32646 32647 32648 32649 32650 32651 32652 32653 32654 32655 32656 32657 32658 32659 32660 32661 32662 32663 32664 32665 32666 32667 32668 32669 32670 32671 32672 32673 32674 32675 32676 32677 32678 32679 32680 32681 32682 32683 32684 32685 32686 32687 32688 32689 32690 32691 32692 32693 32694 32695 32696 32697 32698 32699 32700 32701 32702 32703 32704 32705 32706 32707 32708 32709 32710 32711 32712 32713 32714 32715 32716 32717 32718 32719 32720 32721 32722 32723 32724 32725 32726 32727 32728 32729 32730 32731 32732 32733 32734 32735 32736 32737 32738 32739 32740 32741 32742 32743 32744 32745 32746 32747 32748 32749 32750 32751 32752 32753 32754 32755 32756 32757 32758 32759 32760 32761 32762 32763 32764 32765 32766 32767 32768 32769 32770 32771 32772 32773 32774 32775 32776 32777 32778 32779 32780 32781 32782 32783 32784 32785 32786 32787 32788 32789 32790 32791 32792 32793 32794 32795 32796 32797 32798 32799 32800 32801 32802 32803 32804 32805 32806 32807 32808 32809 32810 32811 32812 32813 32814 32815 32816 32817 32818 32819 32820 32821 32822 32823 32824 32825 32826 32827 32828 32829 32830 32831 32832 32833 32834 32835 32836 32837 32838 32839 32840 32841 32842 32843 32844 32845 32846 32847 32848 32849 32850 32851 32852 32853 32854 32855 32856 32857 32858 32859 32860 32861 32862 32863 32864 32865 32866 32867 32868 32869 32870 32871 32872 32873 32874 32875 32876 32877 32878 32879 32880 32881 32882 32883 32884 32885 32886 32887 32888 32889 32890 32891 32892 32893 32894 32895 32896 32897 32898 32899 32900 32901 32902 32903 32904 32905 32906 32907 32908 32909 32910 32911 32912 32913 32914 32915 32916 32917 32918 32919 32920 32921 32922 32923 32924 32925 32926 32927 32928 32929 32930 32931 32932 32933 32934 32935 32936 32937 32938 32939 32940 32941 32942 32943 32944 32945 32946 32947 32948 32949 32950 32951 32952 32953 32954 32955 32956 32957 32958 32959 32960 32961 32962 32963 32964 32965 32966 32967 32968 32969 32970 32971 32972 32973 32974 32975 32976 32977 32978 32979 32980 32981 32982 32983 32984 32985 32986 32987 32988 32989 32990 32991 32992 32993 32994 32995 32996 32997 32998 32999 33000 33001 33002 33003 33004 33005 33006 33007 33008 33009 33010 33011 33012 33013 33014 33015 33016 33017 33018 33019 33020 33021 33022 33023 33024 33025 33026 33027 33028 33029 33030 33031 33032 33033 33034 33035 33036 33037 33038 33039 33040 33041 33042 33043 33044 33045 33046 33047 33048 33049 33050 33051 33052 33053 33054 33055 33056 33057 33058 33059 33060 33061 33062 33063 33064 33065 33066 33067 33068 33069 33070 33071 33072 33073 33074 33075 33076 33077 33078 33079 33080 33081 33082 33083 33084 33085 33086 33087 33088 33089 33090 33091 33092 33093 33094 33095 33096 33097 33098 33099 33100 33101 33102 33103 33104 33105 33106 33107 33108 33109 33110 33111 33112 33113 33114 33115 33116 33117 33118 33119 33120 33121 33122 33123 33124 33125 33126 33127 33128 33129 33130 33131 33132 33133 33134 33135 33136 33137 33138 33139 33140 33141 33142 33143 33144 33145 33146 33147 33148 33149 33150 33151 33152 33153 33154 33155 33156 33157 33158 33159 33160 33161 33162 33163 33164 33165 33166 33167 33168 33169 33170 33171 33172 33173 33174 33175 33176 33177 33178 33179 33180 33181 33182 33183 33184 33185 33186 33187 33188 33189 33190 33191 33192 33193 33194 33195 33196 33197 33198 33199 33200 33201 33202 33203 33204 33205 33206 33207 33208 33209 33210 33211 33212 33213 33214 33215 33216 33217 33218 33219 33220 33221 33222 33223 33224 33225 33226 33227 33228 33229 33230 33231 33232 33233 33234 33235 33236 33237 33238 33239 33240 33241 33242 33243 33244 33245 33246 33247 33248 33249 33250 33251 33252 33253 33254 33255 33256 33257 33258 33259 33260 33261 33262 33263 33264 33265 33266 33267 33268 33269 33270 33271 33272 33273 33274 33275 33276 33277 33278 33279 33280 33281 33282 33283 33284 33285 33286 33287 33288 33289 33290 33291 33292 33293 33294 33295 33296 33297 33298 33299 33300 33301 33302 33303 33304 33305 33306 33307 33308 33309 33310 33311 33312 33313 33314 33315 33316 33317 33318 33319 33320 33321 33322 33323 33324 33325 33326 33327 33328 33329 33330 33331 33332 33333 33334 33335 33336 33337 33338 33339 33340 33341 33342 33343 33344 33345 33346 33347 33348 33349 33350 33351 33352 33353 33354 33355 33356 33357 33358 33359 33360 33361 33362 33363 33364 33365 33366 33367 33368 33369 33370 33371 33372 33373 33374 33375 33376 33377 33378 33379 33380 33381 33382 33383 33384 33385 33386 33387 33388 33389 33390 33391 33392 33393 33394 33395 33396 33397 33398 33399 33400 33401 33402 33403 33404 33405 33406 33407 33408 33409 33410 33411 33412 33413 33414 33415 33416 33417 33418 33419 33420 33421 33422 33423 33424 33425 33426 33427 33428 33429 33430 33431 33432 33433 33434 33435 33436 33437 33438 33439 33440 33441 33442 33443 33444 33445 33446 33447 33448 33449 33450 33451 33452 33453 33454 33455 33456 33457 33458 33459 33460 33461 33462 33463 33464 33465 33466 33467 33468 33469 33470 33471 33472 33473 33474 33475 33476 33477 33478 33479 33480 33481 33482 33483 33484 33485 33486 33487 33488 33489 33490 33491 33492 33493 33494 33495 33496 33497 33498 33499 33500 33501 33502 33503 33504 33505 33506 33507 33508 33509 33510 33511 33512 33513 33514 33515 33516 33517 33518 33519 33520 33521 33522 33523 33524 33525 33526 33527 33528 33529 33530 33531 33532 33533 33534 33535 33536 33537 33538 33539 33540 33541 33542 33543 33544 33545 33546 33547 33548 33549 33550 33551 33552 33553 33554 33555 33556 33557 33558 33559 33560 33561 33562 33563 33564 33565 33566 33567 33568 33569 33570 33571 33572 33573 33574 33575 33576 33577 33578 33579 33580 33581 33582 33583 33584 33585 33586 33587 33588 33589 33590 33591 33592 33593 33594 33595 33596 33597 33598 33599 33600 33601 33602 33603 33604 33605 33606 33607 33608 33609 33610 33611 33612 33613 33614 33615 33616 33617 33618 33619 33620 33621 33622 33623 33624 33625 33626 33627 33628 33629 33630 33631 33632 33633 33634 33635 33636 33637 33638 33639 33640 33641 33642 33643 33644 33645 33646 33647 33648 33649 33650 33651 33652 33653 33654 33655 33656 33657 33658 33659 33660 33661 33662 33663 33664 33665 33666 33667 33668 33669 33670 33671 33672 33673 33674 33675 33676 33677 33678 33679 33680 33681 33682 33683 33684 33685 33686 33687 33688 33689 33690 33691 33692 33693 33694 33695 33696 33697 33698 33699 33700 33701 33702 33703 33704 33705 33706 33707 33708 33709 33710 33711 33712 33713 33714 33715 33716 33717 33718 33719 33720 33721 33722 33723 33724 33725 33726 33727 33728 33729 33730 33731 33732 33733 33734 33735 33736 33737 33738 33739 33740 33741 33742 33743 33744 33745 33746 33747 33748 33749 33750 33751 33752 33753 33754 33755 33756 33757 33758 33759 33760 33761 33762 33763 33764 33765 33766 33767 33768 33769 33770 33771 33772 33773 33774 33775 33776 33777 33778 33779 33780 33781 33782 33783 33784 33785 33786 33787 33788 33789 33790 33791 33792 33793 33794 33795 33796 33797 33798 33799 33800 33801 33802 33803 33804 33805 33806 33807 33808 33809 33810 33811 33812 33813 33814 33815 33816 33817 33818 33819 33820 33821 33822 33823 33824 33825 33826 33827 33828 33829 33830 33831 33832 33833 33834 33835 33836 33837 33838 33839 33840 33841 33842 33843 33844 33845 33846 33847 33848 33849 33850 33851 33852 33853 33854 33855 33856 33857 33858 33859 33860 33861 33862 33863 33864 33865 33866 33867 33868 33869 33870 33871 33872 33873 33874 33875 33876 33877 33878 33879 33880 33881 33882 33883 33884 33885 33886 33887 33888 33889 33890 33891 33892 33893 33894 33895 33896 33897 33898 33899 33900 33901 33902 33903 33904 33905 33906 33907 33908 33909 33910 33911 33912 33913 33914 33915 33916 33917 33918 33919 33920 33921 33922 33923 33924 33925 33926 33927 33928 33929 33930 33931 33932 33933 33934 33935 33936 33937 33938 33939 33940 33941 33942 33943 33944 33945 33946 33947 33948 33949 33950 33951 33952 33953 33954 33955 33956 33957 33958 33959 33960 33961 33962 33963 33964 33965 33966 33967 33968 33969 33970 33971 33972 33973 33974 33975 33976 33977 33978 33979 33980 33981 33982 33983 33984 33985 33986 33987 33988 33989 33990 33991 33992 33993 33994 33995 33996 33997 33998 33999 34000 34001 34002 34003 34004 34005 34006 34007 34008 34009 34010 34011 34012 34013 34014 34015 34016 34017 34018 34019 34020 34021 34022 34023 34024 34025 34026 34027 34028 34029 34030 34031 34032 34033 34034 34035 34036 34037 34038 34039 34040 34041 34042 34043 34044 34045 34046 34047 34048 34049 34050 34051 34052 34053 34054 34055 34056 34057 34058 34059 34060 34061 34062 34063 34064 34065 34066 34067 34068 34069 34070 34071 34072 34073 34074 34075 34076 34077 34078 34079 34080 34081 34082 34083 34084 34085 34086 34087 34088 34089 34090 34091 34092 34093 34094 34095 34096 34097 34098 34099 34100 34101 34102 34103 34104 34105 34106 34107 34108 34109 34110 34111 34112 34113 34114 34115 34116 34117 34118 34119 34120 34121 34122 34123 34124 34125 34126 34127 34128 34129 34130 34131 34132 34133 34134 34135 34136 34137 34138 34139 34140 34141 34142 34143 34144 34145 34146 34147 34148 34149 34150 34151 34152 34153 34154 34155 34156 34157 34158 34159 34160 34161 34162 34163 34164 34165 34166 34167 34168 34169 34170 34171 34172 34173 34174 34175 34176 34177 34178 34179 34180 34181 34182 34183 34184 34185 34186 34187 34188 34189 34190 34191 34192 34193 34194 34195 34196 34197 34198 34199 34200 34201 34202 34203 34204 34205 34206 34207 34208 34209 34210 34211 34212 34213 34214 34215 34216 34217 34218 34219 34220 34221 34222 34223 34224 34225 34226 34227 34228 34229 34230 34231 34232 34233 34234 34235 34236 34237 34238 34239 34240 34241 34242 34243 34244 34245 34246 34247 34248 34249 34250 34251 34252 34253 34254 34255 34256 34257 34258 34259 34260 34261 34262 34263 34264 34265 34266 34267 34268 34269 34270 34271 34272 34273 34274 34275 34276 34277 34278 34279 34280 34281 34282 34283 34284 34285 34286 34287 34288 34289 34290 34291 34292 34293 34294 34295 34296 34297 34298 34299 34300 34301 34302 34303 34304 34305 34306 34307 34308 34309 34310 34311 34312 34313 34314 34315 34316 34317 34318 34319 34320 34321 34322 34323 34324 34325 34326 34327 34328 34329 34330 34331 34332 34333 34334 34335 34336 34337 34338 34339 34340 34341 34342 34343 34344 34345 34346 34347 34348 34349 34350 34351 34352 34353 34354 34355 34356 34357 34358 34359 34360 34361 34362 34363 34364 34365 34366 34367 34368 34369 34370 34371 34372 34373 34374 34375 34376 34377 34378 34379 34380 34381 34382 34383 34384 34385 34386 34387 34388 34389 34390 34391 34392 34393 34394 34395 34396 34397 34398 34399 34400 34401 34402 34403 34404 34405 34406 34407 34408 34409 34410 34411 34412 34413 34414 34415 34416 34417 34418 34419 34420 34421 34422 34423 34424 34425 34426 34427 34428 34429 34430 34431 34432 34433 34434 34435 34436 34437 34438 34439 34440 34441 34442 34443 34444 34445 34446 34447 34448 34449 34450 34451 34452 34453 34454 34455 34456 34457 34458 34459 34460 34461 34462 34463 34464 34465 34466 34467 34468 34469 34470 34471 34472 34473 34474 34475 34476 34477 34478 34479 34480 34481 34482 34483 34484 34485 34486 34487 34488 34489 34490 34491 34492 34493 34494 34495 34496 34497 34498 34499 34500 34501 34502 34503 34504 34505 34506 34507 34508 34509 34510 34511 34512 34513 34514 34515 34516 34517 34518 34519 34520 34521 34522 34523 34524 34525 34526 34527 34528 34529 34530 34531 34532 34533 34534 34535 34536 34537 34538 34539 34540 34541 34542 34543 34544 34545 34546 34547 34548 34549 34550 34551 34552 34553 34554 34555 34556 34557 34558 34559 34560 34561 34562 34563 34564 34565 34566 34567 34568 34569 34570 34571 34572 34573 34574 34575 34576 34577 34578 34579 34580 34581 34582 34583 34584 34585 34586 34587 34588 34589 34590 34591 34592 34593 34594 34595 34596 34597 34598 34599 34600 34601 34602 34603 34604 34605 34606 34607 34608 34609 34610 34611 34612 34613 34614 34615 34616 34617 34618 34619 34620 34621 34622 34623 34624 34625 34626 34627 34628 34629 34630 34631 34632 34633 34634 34635 34636 34637 34638 34639 34640 34641 34642 34643 34644 34645 34646 34647 34648 34649 34650 34651 34652 34653 34654 34655 34656 34657 34658 34659 34660 34661 34662 34663 34664 34665 34666 34667 34668 34669 34670 34671 34672 34673 34674 34675 34676 34677 34678 34679 34680 34681 34682 34683 34684 34685 34686 34687 34688 34689 34690 34691 34692 34693 34694 34695 34696 34697 34698 34699 34700 34701 34702 34703 34704 34705 34706 34707 34708 34709 34710 34711 34712 34713 34714 34715 34716 34717 34718 34719 34720 34721 34722 34723 34724 34725 34726 34727 34728 34729 34730 34731 34732 34733 34734 34735 34736 34737 34738 34739 34740 34741 34742 34743 34744 34745 34746 34747 34748 34749 34750 34751 34752 34753 34754 34755 34756 34757 34758 34759 34760 34761 34762 34763 34764 34765 34766 34767 34768 34769 34770 34771 34772 34773 34774 34775 34776 34777 34778 34779 34780 34781 34782 34783 34784 34785 34786 34787 34788 34789 34790 34791 34792 34793 34794 34795 34796 34797 34798 34799 34800 34801 34802 34803 34804 34805 34806 34807 34808 34809 34810 34811 34812 34813 34814 34815 34816 34817 34818 34819 34820 34821 34822 34823 34824 34825 34826 34827 34828 34829 34830 34831 34832 34833 34834 34835 34836 34837 34838 34839 34840 34841 34842 34843 34844 34845 34846 34847 34848 34849 34850 34851 34852 34853 34854 34855 34856 34857 34858 34859 34860 34861 34862 34863 34864 34865 34866 34867 34868 34869 34870 34871 34872 34873 34874 34875 34876 34877 34878 34879 34880 34881 34882 34883 34884 34885 34886 34887 34888 34889 34890 34891 34892 34893 34894 34895 34896 34897 34898 34899 34900 34901 34902 34903 34904 34905 34906 34907 34908 34909 34910 34911 34912 34913 34914 34915 34916 34917 34918 34919 34920 34921 34922 34923 34924 34925 34926 34927 34928 34929 34930 34931 34932 34933 34934 34935 34936 34937 34938 34939 34940 34941 34942 34943 34944 34945 34946 34947 34948 34949 34950 34951 34952 34953 34954 34955 34956 34957 34958 34959 34960 34961 34962 34963 34964 34965 34966 34967 34968 34969 34970 34971 34972 34973 34974 34975 34976 34977 34978 34979 34980 34981 34982 34983 34984 34985 34986 34987 34988 34989 34990 34991 34992 34993 34994 34995 34996 34997 34998 34999 35000 35001 35002 35003 35004 35005 35006 35007 35008 35009 35010 35011 35012 35013 35014 35015 35016 35017 35018 35019 35020 35021 35022 35023 35024 35025 35026 35027 35028 35029 35030 35031 35032 35033 35034 35035 35036 35037 35038 35039 35040 35041 35042 35043 35044 35045 35046 35047 35048 35049 35050 35051 35052 35053 35054 35055 35056 35057 35058 35059 35060 35061 35062 35063 35064 35065 35066 35067 35068 35069 35070 35071 35072 35073 35074 35075 35076 35077 35078 35079 35080 35081 35082 35083 35084 35085 35086 35087 35088 35089 35090 35091 35092 35093 35094 35095 35096 35097 35098 35099 35100 35101 35102 35103 35104 35105 35106 35107 35108 35109 35110 35111 35112 35113 35114 35115 35116 35117 35118 35119 35120 35121 35122 35123 35124 35125 35126 35127 35128 35129 35130 35131 35132 35133 35134 35135 35136 35137 35138 35139 35140 35141 35142 35143 35144 35145 35146 35147 35148 35149 35150 35151 35152 35153 35154 35155 35156 35157 35158 35159 35160 35161 35162 35163 35164 35165 35166 35167 35168 35169 35170 35171 35172 35173 35174 35175 35176 35177 35178 35179 35180 35181 35182 35183 35184 35185 35186 35187 35188 35189 35190 35191 35192 35193 35194 35195 35196 35197 35198 35199 35200 35201 35202 35203 35204 35205 35206 35207 35208 35209 35210 35211 35212 35213 35214 35215 35216 35217 35218 35219 35220 35221 35222 35223 35224 35225 35226 35227 35228 35229 35230 35231 35232 35233 35234 35235 35236 35237 35238 35239 35240 35241 35242 35243 35244 35245 35246 35247 35248 35249 35250 35251 35252 35253 35254 35255 35256 35257 35258 35259 35260 35261 35262 35263 35264 35265 35266 35267 35268 35269 35270 35271 35272 35273 35274 35275 35276 35277 35278 35279 35280 35281 35282 35283 35284 35285 35286 35287 35288 35289 35290 35291 35292 35293 35294 35295 35296 35297 35298 35299 35300 35301 35302 35303 35304 35305 35306 35307 35308 35309 35310 35311 35312 35313 35314 35315 35316 35317 35318 35319 35320 35321 35322 35323 35324 35325 35326 35327 35328 35329 35330 35331 35332 35333 35334 35335 35336 35337 35338 35339 35340 35341 35342 35343 35344 35345 35346 35347 35348 35349 35350 35351 35352 35353 35354 35355 35356 35357 35358 35359 35360 35361 35362 35363 35364 35365 35366 35367 35368 35369 35370 35371 35372 35373 35374 35375 35376 35377 35378 35379 35380 35381 35382 35383 35384 35385 35386 35387 35388 35389 35390 35391 35392 35393 35394 35395 35396 35397 35398 35399 35400 35401 35402 35403 35404 35405 35406 35407 35408 35409 35410 35411 35412 35413 35414 35415 35416 35417 35418 35419 35420 35421 35422 35423 35424 35425 35426 35427 35428 35429 35430 35431 35432 35433 35434 35435 35436 35437 35438 35439 35440 35441 35442 35443 35444 35445 35446 35447 35448 35449 35450 35451 35452 35453 35454 35455 35456 35457 35458 35459 35460 35461 35462 35463 35464 35465 35466 35467 35468 35469 35470 35471 35472 35473 35474 35475 35476 35477 35478 35479 35480 35481 35482 35483 35484 35485 35486 35487 35488 35489 35490 35491 35492 35493 35494 35495 35496 35497 35498 35499 35500 35501 35502 35503 35504 35505 35506 35507 35508 35509 35510 35511 35512 35513 35514 35515 35516 35517 35518 35519 35520 35521 35522 35523 35524 35525 35526 35527 35528 35529 35530 35531 35532 35533 35534 35535 35536 35537 35538 35539 35540 35541 35542 35543 35544 35545 35546 35547 35548 35549 35550 35551 35552 35553 35554 35555 35556 35557 35558 35559 35560 35561 35562 35563 35564 35565 35566 35567 35568 35569 35570 35571 35572 35573 35574 35575 35576 35577 35578 35579 35580 35581 35582 35583 35584 35585 35586 35587 35588 35589 35590 35591 35592 35593 35594 35595 35596 35597 35598 35599 35600 35601 35602 35603 35604 35605 35606 35607 35608 35609 35610 35611 35612 35613 35614 35615 35616 35617 35618 35619 35620 35621 35622 35623 35624 35625 35626 35627 35628 35629 35630 35631 35632 35633 35634 35635 35636 35637 35638 35639 35640 35641 35642 35643 35644 35645 35646 35647 35648 35649 35650 35651 35652 35653 35654 35655 35656 35657 35658 35659 35660 35661 35662 35663 35664 35665 35666 35667 35668 35669 35670 35671 35672 35673 35674 35675 35676 35677 35678 35679 35680 35681 35682 35683 35684 35685 35686 35687 35688 35689 35690 35691 35692 35693 35694 35695 35696 35697 35698 35699 35700 35701 35702 35703 35704 35705 35706 35707 35708 35709 35710 35711 35712 35713 35714 35715 35716 35717 35718 35719 35720 35721 35722 35723 35724 35725 35726 35727 35728 35729 35730 35731 35732 35733 35734 35735 35736 35737 35738 35739 35740 35741 35742 35743 35744 35745 35746 35747 35748 35749 35750 35751 35752 35753 35754 35755 35756 35757 35758 35759 35760 35761 35762 35763 35764 35765 35766 35767 35768 35769 35770 35771 35772 35773 35774 35775 35776 35777 35778 35779 35780 35781 35782 35783 35784 35785 35786 35787 35788 35789 35790 35791 35792 35793 35794 35795 35796 35797 35798 35799 35800 35801 35802 35803 35804 35805 35806 35807 35808 35809 35810 35811 35812 35813 35814 35815 35816 35817 35818 35819 35820 35821 35822 35823 35824 35825 35826 35827 35828 35829 35830 35831 35832 35833 35834 35835 35836 35837 35838 35839 35840 35841 35842 35843 35844 35845 35846 35847 35848 35849 35850 35851 35852 35853 35854 35855 35856 35857 35858 35859 35860 35861 35862 35863 35864 35865 35866 35867 35868 35869 35870 35871 35872 35873 35874 35875 35876 35877 35878 35879 35880 35881 35882 35883 35884 35885 35886 35887 35888 35889 35890 35891 35892 35893 35894 35895 35896 35897 35898 35899 35900 35901 35902 35903 35904 35905 35906 35907 35908 35909 35910 35911 35912 35913 35914 35915 35916 35917 35918 35919 35920 35921 35922 35923 35924 35925 35926 35927 35928 35929 35930 35931 35932 35933 35934 35935 35936 35937 35938 35939 35940 35941 35942 35943 35944 35945 35946 35947 35948 35949 35950 35951 35952 35953 35954 35955 35956 35957 35958 35959 35960 35961 35962 35963 35964 35965 35966 35967 35968 35969 35970 35971 35972 35973 35974 35975 35976 35977 35978 35979 35980 35981 35982 35983 35984 35985 35986 35987 35988 35989 35990 35991 35992 35993 35994 35995 35996 35997 35998 35999 36000 36001 36002 36003 36004 36005 36006 36007 36008 36009 36010 36011 36012 36013 36014 36015 36016 36017 36018 36019 36020 36021 36022 36023 36024 36025 36026 36027 36028 36029 36030 36031 36032 36033 36034 36035 36036 36037 36038 36039 36040 36041 36042 36043 36044 36045 36046 36047 36048 36049 36050 36051 36052 36053 36054 36055 36056 36057 36058 36059 36060 36061 36062 36063 36064 36065 36066 36067 36068 36069 36070 36071 36072 36073 36074 36075 36076 36077 36078 36079 36080 36081 36082 36083 36084 36085 36086 36087 36088 36089 36090 36091 36092 36093 36094 36095 36096 36097 36098 36099 36100 36101 36102 36103 36104 36105 36106 36107 36108 36109 36110 36111 36112 36113 36114 36115 36116 36117 36118 36119 36120 36121 36122 36123 36124 36125 36126 36127 36128 36129 36130 36131 36132 36133 36134 36135 36136 36137 36138 36139 36140 36141 36142 36143 36144 36145 36146 36147 36148 36149 36150 36151 36152 36153 36154 36155 36156 36157 36158 36159 36160 36161 36162 36163 36164 36165 36166 36167 36168 36169 36170 36171 36172 36173 36174 36175 36176 36177 36178 36179 36180 36181 36182 36183 36184 36185 36186 36187 36188 36189 36190 36191 36192 36193 36194 36195 36196 36197 36198 36199 36200 36201 36202 36203 36204 36205 36206 36207 36208 36209 36210 36211 36212 36213 36214 36215 36216 36217 36218 36219 36220 36221 36222 36223 36224 36225 36226 36227 36228 36229 36230 36231 36232 36233 36234 36235 36236 36237 36238 36239 36240 36241 36242 36243 36244 36245 36246 36247 36248 36249 36250 36251 36252 36253 36254 36255 36256 36257 36258 36259 36260 36261 36262 36263 36264 36265 36266 36267 36268 36269 36270 36271 36272 36273 36274 36275 36276 36277 36278 36279 36280 36281 36282 36283 36284 36285 36286 36287 36288 36289 36290 36291 36292 36293 36294 36295 36296 36297 36298 36299 36300 36301 36302 36303 36304 36305 36306 36307 36308 36309 36310 36311 36312 36313 36314 36315 36316 36317 36318 36319 36320 36321 36322 36323 36324 36325 36326 36327 36328 36329 36330 36331 36332 36333 36334 36335 36336 36337 36338 36339 36340 36341 36342 36343 36344 36345 36346 36347 36348 36349 36350 36351 36352 36353 36354 36355 36356 36357 36358 36359 36360 36361 36362 36363 36364 36365 36366 36367 36368 36369 36370 36371 36372 36373 36374 36375 36376 36377 36378 36379 36380 36381 36382 36383 36384 36385 36386 36387 36388 36389 36390 36391 36392 36393 36394 36395 36396 36397 36398 36399 36400 36401 36402 36403 36404 36405 36406 36407 36408 36409 36410 36411 36412 36413 36414 36415 36416 36417 36418 36419 36420 36421 36422 36423 36424 36425 36426 36427 36428 36429 36430 36431 36432 36433 36434 36435 36436 36437 36438 36439 36440 36441 36442 36443 36444 36445 36446 36447 36448 36449 36450 36451 36452 36453 36454 36455 36456 36457 36458 36459 36460 36461 36462 36463 36464 36465 36466 36467 36468 36469 36470 36471 36472 36473 36474 36475 36476 36477 36478 36479 36480 36481 36482 36483 36484 36485 36486 36487 36488 36489 36490 36491 36492 36493 36494 36495 36496 36497 36498 36499 36500 36501 36502 36503 36504 36505 36506 36507 36508 36509 36510 36511 36512 36513 36514 36515 36516 36517 36518 36519 36520 36521 36522 36523 36524 36525 36526 36527 36528 36529 36530 36531 36532 36533 36534 36535 36536 36537 36538 36539 36540 36541 36542 36543 36544 36545 36546 36547 36548 36549 36550 36551 36552 36553 36554 36555 36556 36557 36558 36559 36560 36561 36562 36563 36564 36565 36566 36567 36568 36569 36570 36571 36572 36573 36574 36575 36576 36577 36578 36579 36580 36581 36582 36583 36584 36585 36586 36587 36588 36589 36590 36591 36592 36593 36594 36595 36596 36597 36598 36599 36600 36601 36602 36603 36604 36605 36606 36607 36608 36609 36610 36611 36612 36613 36614 36615 36616 36617 36618 36619 36620 36621 36622 36623 36624 36625 36626 36627 36628 36629 36630 36631 36632 36633 36634 36635 36636 36637 36638 36639 36640 36641 36642 36643 36644 36645 36646 36647 36648 36649 36650 36651 36652 36653 36654 36655 36656 36657 36658 36659 36660 36661 36662 36663 36664 36665 36666 36667 36668 36669 36670 36671 36672 36673 36674 36675 36676 36677 36678 36679 36680 36681 36682 36683 36684 36685 36686 36687 36688 36689 36690 36691 36692 36693 36694 36695 36696 36697 36698 36699 36700 36701 36702 36703 36704 36705 36706 36707 36708 36709 36710 36711 36712 36713 36714 36715 36716 36717 36718 36719 36720 36721 36722 36723 36724 36725 36726 36727 36728 36729 36730 36731 36732 36733 36734 36735 36736 36737 36738 36739 36740 36741 36742 36743 36744 36745 36746 36747 36748 36749 36750 36751 36752 36753 36754 36755 36756 36757 36758 36759 36760 36761 36762 36763 36764 36765 36766 36767 36768 36769 36770 36771 36772 36773 36774 36775 36776 36777 36778 36779 36780 36781 36782 36783 36784 36785 36786 36787 36788 36789 36790 36791 36792 36793 36794 36795 36796 36797 36798 36799 36800 36801 36802 36803 36804 36805 36806 36807 36808 36809 36810 36811 36812 36813 36814 36815 36816 36817 36818 36819 36820 36821 36822 36823 36824 36825 36826 36827 36828 36829 36830 36831 36832 36833 36834 36835 36836 36837 36838 36839 36840 36841 36842 36843 36844 36845 36846 36847 36848 36849 36850 36851 36852 36853 36854 36855 36856 36857 36858 36859 36860 36861 36862 36863 36864 36865 36866 36867 36868 36869 36870 36871 36872 36873 36874 36875 36876 36877 36878 36879 36880 36881 36882 36883 36884 36885 36886 36887 36888 36889 36890 36891 36892 36893 36894 36895 36896 36897 36898 36899 36900 36901 36902 36903 36904 36905 36906 36907 36908 36909 36910 36911 36912 36913 36914 36915 36916 36917 36918 36919 36920 36921 36922 36923 36924 36925 36926 36927 36928 36929 36930 36931 36932 36933 36934 36935 36936 36937 36938 36939 36940 36941 36942 36943 36944 36945 36946 36947 36948 36949 36950 36951 36952 36953 36954 36955 36956 36957 36958 36959 36960 36961 36962 36963 36964 36965 36966 36967 36968 36969 36970 36971 36972 36973 36974 36975 36976 36977 36978 36979 36980 36981 36982 36983 36984 36985 36986 36987 36988 36989 36990 36991 36992 36993 36994 36995 36996 36997 36998 36999 37000 37001 37002 37003 37004 37005 37006 37007 37008 37009 37010 37011 37012 37013 37014 37015 37016 37017 37018 37019 37020 37021 37022 37023 37024 37025 37026 37027 37028 37029 37030 37031 37032 37033 37034 37035 37036 37037 37038 37039 37040 37041 37042 37043 37044 37045 37046 37047 37048 37049 37050 37051 37052 37053 37054 37055 37056 37057 37058 37059 37060 37061 37062 37063 37064 37065 37066 37067 37068 37069 37070 37071 37072 37073 37074 37075 37076 37077 37078 37079 37080 37081 37082 37083 37084 37085 37086 37087 37088 37089 37090 37091 37092 37093 37094 37095 37096 37097 37098 37099 37100 37101 37102 37103 37104 37105 37106 37107 37108 37109 37110 37111 37112 37113 37114 37115 37116 37117 37118 37119 37120 37121 37122 37123 37124 37125 37126 37127 37128 37129 37130 37131 37132 37133 37134 37135 37136 37137 37138 37139 37140 37141 37142 37143 37144 37145 37146 37147 37148 37149 37150 37151 37152 37153 37154 37155 37156 37157 37158 37159 37160 37161 37162 37163 37164 37165 37166 37167 37168 37169 37170 37171 37172 37173 37174 37175 37176 37177 37178 37179 37180 37181 37182 37183 37184 37185 37186 37187 37188 37189 37190 37191 37192 37193 37194 37195 37196 37197 37198 37199 37200 37201 37202 37203 37204 37205 37206 37207 37208 37209 37210 37211 37212 37213 37214 37215 37216 37217 37218 37219 37220 37221 37222 37223 37224 37225 37226 37227 37228 37229 37230 37231 37232 37233 37234 37235 37236 37237 37238 37239 37240 37241 37242 37243 37244 37245 37246 37247 37248 37249 37250 37251 37252 37253 37254 37255 37256 37257 37258 37259 37260 37261 37262 37263 37264 37265 37266 37267 37268 37269 37270 37271 37272 37273 37274 37275 37276 37277 37278 37279 37280 37281 37282 37283 37284 37285 37286 37287 37288 37289 37290 37291 37292 37293 37294 37295 37296 37297 37298 37299 37300 37301 37302 37303 37304 37305 37306 37307 37308 37309 37310 37311 37312 37313 37314 37315 37316 37317 37318 37319 37320 37321 37322 37323 37324 37325 37326 37327 37328 37329 37330 37331 37332 37333 37334 37335 37336 37337 37338 37339 37340 37341 37342 37343 37344 37345 37346 37347 37348 37349 37350 37351 37352 37353 37354 37355 37356 37357 37358 37359 37360 37361 37362 37363 37364 37365 37366 37367 37368 37369 37370 37371 37372 37373 37374 37375 37376 37377 37378 37379 37380 37381 37382 37383 37384 37385 37386 37387 37388 37389 37390 37391 37392 37393 37394 37395 37396 37397 37398 37399 37400 37401 37402 37403 37404 37405 37406 37407 37408 37409 37410 37411 37412 37413 37414 37415 37416 37417 37418 37419 37420 37421 37422 37423 37424 37425 37426 37427 37428 37429 37430 37431 37432 37433 37434 37435 37436 37437 37438 37439 37440 37441 37442 37443 37444 37445 37446 37447 37448 37449 37450 37451 37452 37453 37454 37455 37456 37457 37458 37459 37460 37461 37462 37463 37464 37465 37466 37467 37468 37469 37470 37471 37472 37473 37474 37475 37476 37477 37478 37479 37480 37481 37482 37483 37484 37485 37486 37487 37488 37489 37490 37491 37492 37493 37494 37495 37496 37497 37498 37499 37500 37501 37502 37503 37504 37505 37506 37507 37508 37509 37510 37511 37512 37513 37514 37515 37516 37517 37518 37519 37520 37521 37522 37523 37524 37525 37526 37527 37528 37529 37530 37531 37532 37533 37534 37535 37536 37537 37538 37539 37540 37541 37542 37543 37544 37545 37546 37547 37548 37549 37550 37551 37552 37553 37554 37555 37556 37557 37558 37559 37560 37561 37562 37563 37564 37565 37566 37567 37568 37569 37570 37571 37572 37573 37574 37575 37576 37577 37578 37579 37580 37581 37582 37583 37584 37585 37586 37587 37588 37589 37590 37591 37592 37593 37594 37595 37596 37597 37598 37599 37600 37601 37602 37603 37604 37605 37606 37607 37608 37609 37610 37611 37612 37613 37614 37615 37616 37617 37618 37619 37620 37621 37622 37623 37624 37625 37626 37627 37628 37629 37630 37631 37632 37633 37634 37635 37636 37637 37638 37639 37640 37641 37642 37643 37644 37645 37646 37647 37648 37649 37650 37651 37652 37653 37654 37655 37656 37657 37658 37659 37660 37661 37662 37663 37664 37665 37666 37667 37668 37669 37670 37671 37672 37673 37674 37675 37676 37677 37678 37679 37680 37681 37682 37683 37684 37685 37686 37687 37688 37689 37690 37691 37692 37693 37694 37695 37696 37697 37698 37699 37700 37701 37702 37703 37704 37705 37706 37707 37708 37709 37710 37711 37712 37713 37714 37715 37716 37717 37718 37719 37720 37721 37722 37723 37724 37725 37726 37727 37728 37729 37730 37731 37732 37733 37734 37735 37736 37737 37738 37739 37740 37741 37742 37743 37744 37745 37746 37747 37748 37749 37750 37751 37752 37753 37754 37755 37756 37757 37758 37759 37760 37761 37762 37763 37764 37765 37766 37767 37768 37769 37770 37771 37772 37773 37774 37775 37776 37777 37778 37779 37780 37781 37782 37783 37784 37785 37786 37787 37788 37789 37790 37791 37792 37793 37794 37795 37796 37797 37798 37799 37800 37801 37802 37803 37804 37805 37806 37807 37808 37809 37810 37811 37812 37813 37814 37815 37816 37817 37818 37819 37820 37821 37822 37823 37824 37825 37826 37827 37828 37829 37830 37831 37832 37833 37834 37835 37836 37837 37838 37839 37840 37841 37842 37843 37844 37845 37846 37847 37848 37849 37850 37851 37852 37853 37854 37855 37856 37857 37858 37859 37860 37861 37862 37863 37864 37865 37866 37867 37868 37869 37870 37871 37872 37873 37874 37875 37876 37877 37878 37879 37880 37881 37882 37883 37884 37885 37886 37887 37888 37889 37890 37891 37892 37893 37894 37895 37896 37897 37898 37899 37900 37901 37902 37903 37904 37905 37906 37907 37908 37909 37910 37911 37912 37913 37914 37915 37916 37917 37918 37919 37920 37921 37922 37923 37924 37925 37926 37927 37928 37929 37930 37931 37932 37933 37934 37935 37936 37937 37938 37939 37940 37941 37942 37943 37944 37945 37946 37947 37948 37949 37950 37951 37952 37953 37954 37955 37956 37957 37958 37959 37960 37961 37962 37963 37964 37965 37966 37967 37968 37969 37970 37971 37972 37973 37974 37975 37976 37977 37978 37979 37980 37981 37982 37983 37984 37985 37986 37987 37988 37989 37990 37991 37992 37993 37994 37995 37996 37997 37998 37999 38000 38001 38002 38003 38004 38005 38006 38007 38008 38009 38010 38011 38012 38013 38014 38015 38016 38017 38018 38019 38020 38021 38022 38023 38024 38025 38026 38027 38028 38029 38030 38031 38032 38033 38034 38035 38036 38037 38038 38039 38040 38041 38042 38043 38044 38045 38046 38047 38048 38049 38050 38051 38052 38053 38054 38055 38056 38057 38058 38059 38060 38061 38062 38063 38064 38065 38066 38067 38068 38069 38070 38071 38072 38073 38074 38075 38076 38077 38078 38079 38080 38081 38082 38083 38084 38085 38086 38087 38088 38089 38090 38091 38092 38093 38094 38095 38096 38097 38098 38099 38100 38101 38102 38103 38104 38105 38106 38107 38108 38109 38110 38111 38112 38113 38114 38115 38116 38117 38118 38119 38120 38121 38122 38123 38124 38125 38126 38127 38128 38129 38130 38131 38132 38133 38134 38135 38136 38137 38138 38139 38140 38141 38142 38143 38144 38145 38146 38147 38148 38149 38150 38151 38152 38153 38154 38155 38156 38157 38158 38159 38160 38161 38162 38163 38164 38165 38166 38167 38168 38169 38170 38171 38172 38173 38174 38175 38176 38177 38178 38179 38180 38181 38182 38183 38184 38185 38186 38187 38188 38189 38190 38191 38192 38193 38194 38195 38196 38197 38198 38199 38200 38201 38202 38203 38204 38205 38206 38207 38208 38209 38210 38211 38212 38213 38214 38215 38216 38217 38218 38219 38220 38221 38222 38223 38224 38225 38226 38227 38228 38229 38230 38231 38232 38233 38234 38235 38236 38237 38238 38239 38240 38241 38242 38243 38244 38245 38246 38247 38248 38249 38250 38251 38252 38253 38254 38255 38256 38257 38258 38259 38260 38261 38262 38263 38264 38265 38266 38267 38268 38269 38270 38271 38272 38273 38274 38275 38276 38277 38278 38279 38280 38281 38282 38283 38284 38285 38286 38287 38288 38289 38290 38291 38292 38293 38294 38295 38296 38297 38298 38299 38300 38301 38302 38303 38304 38305 38306 38307 38308 38309 38310 38311 38312 38313 38314 38315 38316 38317 38318 38319 38320 38321 38322 38323 38324 38325 38326 38327 38328 38329 38330 38331 38332 38333 38334 38335 38336 38337 38338 38339 38340 38341 38342 38343 38344 38345 38346 38347 38348 38349 38350 38351 38352 38353 38354 38355 38356 38357 38358 38359 38360 38361 38362 38363 38364 38365 38366 38367 38368 38369 38370 38371 38372 38373 38374 38375 38376 38377 38378 38379 38380 38381 38382 38383 38384 38385 38386 38387 38388 38389 38390 38391 38392 38393 38394 38395 38396 38397 38398 38399 38400 38401 38402 38403 38404 38405 38406 38407 38408 38409 38410 38411 38412 38413 38414 38415 38416 38417 38418 38419 38420 38421 38422 38423 38424 38425 38426 38427 38428 38429 38430 38431 38432 38433 38434 38435 38436 38437 38438 38439 38440 38441 38442 38443 38444 38445 38446 38447 38448 38449 38450 38451 38452 38453 38454 38455 38456 38457 38458 38459 38460 38461 38462 38463 38464 38465 38466 38467 38468 38469 38470 38471 38472 38473 38474 38475 38476 38477 38478 38479 38480 38481 38482 38483 38484 38485 38486 38487 38488 38489 38490 38491 38492 38493 38494 38495 38496 38497 38498 38499 38500 38501 38502 38503 38504 38505 38506 38507 38508 38509 38510 38511 38512 38513 38514 38515 38516 38517 38518 38519 38520 38521 38522 38523 38524 38525 38526 38527 38528 38529 38530 38531 38532 38533 38534 38535 38536 38537 38538 38539 38540 38541 38542 38543 38544 38545 38546 38547 38548 38549 38550 38551 38552 38553 38554 38555 38556 38557 38558 38559 38560 38561 38562 38563 38564 38565 38566 38567 38568 38569 38570 38571 38572 38573 38574 38575 38576 38577 38578 38579 38580 38581 38582 38583 38584 38585 38586 38587 38588 38589 38590 38591 38592 38593 38594 38595 38596 38597 38598 38599 38600 38601 38602 38603 38604 38605 38606 38607 38608 38609 38610 38611 38612 38613 38614 38615 38616 38617 38618 38619 38620 38621 38622 38623 38624 38625 38626 38627 38628 38629 38630 38631 38632 38633 38634 38635 38636 38637 38638 38639 38640 38641 38642 38643 38644 38645 38646 38647 38648 38649 38650 38651 38652 38653 38654 38655 38656 38657 38658 38659 38660 38661 38662 38663 38664 38665 38666 38667 38668 38669 38670 38671 38672 38673 38674 38675 38676 38677 38678 38679 38680 38681 38682 38683 38684 38685 38686 38687 38688 38689 38690 38691 38692 38693 38694 38695 38696 38697 38698 38699 38700 38701 38702 38703 38704 38705 38706 38707 38708 38709 38710 38711 38712 38713 38714 38715 38716 38717 38718 38719 38720 38721 38722 38723 38724 38725 38726 38727 38728 38729 38730 38731 38732 38733 38734 38735 38736 38737 38738 38739 38740 38741 38742 38743 38744 38745 38746 38747 38748 38749 38750 38751 38752 38753 38754 38755 38756 38757 38758 38759 38760 38761 38762 38763 38764 38765 38766 38767 38768 38769 38770 38771 38772 38773 38774 38775 38776 38777 38778 38779 38780 38781 38782 38783 38784 38785 38786 38787 38788 38789 38790 38791 38792 38793 38794 38795 38796 38797 38798 38799 38800 38801 38802 38803 38804 38805 38806 38807 38808 38809 38810 38811 38812 38813 38814 38815 38816 38817 38818 38819 38820 38821 38822 38823 38824 38825 38826 38827 38828 38829 38830 38831 38832 38833 38834 38835 38836 38837 38838 38839 38840 38841 38842 38843 38844 38845 38846 38847 38848 38849 38850 38851 38852 38853 38854 38855 38856 38857 38858 38859 38860 38861 38862 38863 38864 38865 38866 38867 38868 38869 38870 38871 38872 38873 38874 38875 38876 38877 38878 38879 38880 38881 38882 38883 38884 38885 38886 38887 38888 38889 38890 38891 38892 38893 38894 38895 38896 38897 38898 38899 38900 38901 38902 38903 38904 38905 38906 38907 38908 38909 38910 38911 38912 38913 38914 38915 38916 38917 38918 38919 38920 38921 38922 38923 38924 38925 38926 38927 38928 38929 38930 38931 38932 38933 38934 38935 38936 38937 38938 38939 38940 38941 38942 38943 38944 38945 38946 38947 38948 38949 38950 38951 38952 38953 38954 38955 38956 38957 38958 38959 38960 38961 38962 38963 38964 38965 38966 38967 38968 38969 38970 38971 38972 38973 38974 38975 38976 38977 38978 38979 38980 38981 38982 38983 38984 38985 38986 38987 38988 38989 38990 38991 38992 38993 38994 38995 38996 38997 38998 38999 39000 39001 39002 39003 39004 39005 39006 39007 39008 39009 39010 39011 39012 39013 39014 39015 39016 39017 39018 39019 39020 39021 39022 39023 39024 39025 39026 39027 39028 39029 39030 39031 39032 39033 39034 39035 39036 39037 39038 39039 39040 39041 39042 39043 39044 39045 39046 39047 39048 39049 39050 39051 39052 39053 39054 39055 39056 39057 39058 39059 39060 39061 39062 39063 39064 39065 39066 39067 39068 39069 39070 39071 39072 39073 39074 39075 39076 39077 39078 39079 39080 39081 39082 39083 39084 39085 39086 39087 39088 39089 39090 39091 39092 39093 39094 39095 39096 39097 39098 39099 39100 39101 39102 39103 39104 39105 39106 39107 39108 39109 39110 39111 39112 39113 39114 39115 39116 39117 39118 39119 39120 39121 39122 39123 39124 39125 39126 39127 39128 39129 39130 39131 39132 39133 39134 39135 39136 39137 39138 39139 39140 39141 39142 39143 39144 39145 39146 39147 39148 39149 39150 39151 39152 39153 39154 39155 39156 39157 39158 39159 39160 39161 39162 39163 39164 39165 39166 39167 39168 39169 39170 39171 39172 39173 39174 39175 39176 39177 39178 39179 39180 39181 39182 39183 39184 39185 39186 39187 39188 39189 39190 39191 39192 39193 39194 39195 39196 39197 39198 39199 39200 39201 39202 39203 39204 39205 39206 39207 39208 39209 39210 39211 39212 39213 39214 39215 39216 39217 39218 39219 39220 39221 39222 39223 39224 39225 39226 39227 39228 39229 39230 39231 39232 39233 39234 39235 39236 39237 39238 39239 39240 39241 39242 39243 39244 39245 39246 39247 39248 39249 39250 39251 39252 39253 39254 39255 39256 39257 39258 39259 39260 39261 39262 39263 39264 39265 39266 39267 39268 39269 39270 39271 39272 39273 39274 39275 39276 39277 39278 39279 39280 39281 39282 39283 39284 39285 39286 39287 39288 39289 39290 39291 39292 39293 39294 39295 39296 39297 39298 39299 39300 39301 39302 39303 39304 39305 39306 39307 39308 39309 39310 39311 39312 39313 39314 39315 39316 39317 39318 39319 39320 39321 39322 39323 39324 39325 39326 39327 39328 39329 39330 39331 39332 39333 39334 39335 39336 39337 39338 39339 39340 39341 39342 39343 39344 39345 39346 39347 39348 39349 39350 39351 39352 39353 39354 39355 39356 39357 39358 39359 39360 39361 39362 39363 39364 39365 39366 39367 39368 39369 39370 39371 39372 39373 39374 39375 39376 39377 39378 39379 39380 39381 39382 39383 39384 39385 39386 39387 39388 39389 39390 39391 39392 39393 39394 39395 39396 39397 39398 39399 39400 39401 39402 39403 39404 39405 39406 39407 39408 39409 39410 39411 39412 39413 39414 39415 39416 39417 39418 39419 39420 39421 39422 39423 39424 39425 39426 39427 39428 39429 39430 39431 39432 39433 39434 39435 39436 39437 39438 39439 39440 39441 39442 39443 39444 39445 39446 39447 39448 39449 39450 39451 39452 39453 39454 39455 39456 39457 39458 39459 39460 39461 39462 39463 39464 39465 39466 39467 39468 39469 39470 39471 39472 39473 39474 39475 39476 39477 39478 39479 39480 39481 39482 39483 39484 39485 39486 39487 39488 39489 39490 39491 39492 39493 39494 39495 39496 39497 39498 39499 39500 39501 39502 39503 39504 39505 39506 39507 39508 39509 39510 39511 39512 39513 39514 39515 39516 39517 39518 39519 39520 39521 39522 39523 39524 39525 39526 39527 39528 39529 39530 39531 39532 39533 39534 39535 39536 39537 39538 39539 39540 39541 39542 39543 39544 39545 39546 39547 39548 39549 39550 39551 39552 39553 39554 39555 39556 39557 39558 39559 39560 39561 39562 39563 39564 39565 39566 39567 39568 39569 39570 39571 39572 39573 39574 39575 39576 39577 39578 39579 39580 39581 39582 39583 39584 39585 39586 39587 39588 39589 39590 39591 39592 39593 39594 39595 39596 39597 39598 39599 39600 39601 39602 39603 39604 39605 39606 39607 39608 39609 39610 39611 39612 39613 39614 39615 39616 39617 39618 39619 39620 39621 39622 39623 39624 39625 39626 39627 39628 39629 39630 39631 39632 39633 39634 39635 39636 39637 39638 39639 39640 39641 39642 39643 39644 39645 39646 39647 39648 39649 39650 39651 39652 39653 39654 39655 39656 39657 39658 39659 39660 39661 39662 39663 39664 39665 39666 39667 39668 39669 39670 39671 39672 39673 39674 39675 39676 39677 39678 39679 39680 39681 39682 39683 39684 39685 39686 39687 39688 39689 39690 39691 39692 39693 39694 39695 39696 39697 39698 39699 39700 39701 39702 39703 39704 39705 39706 39707 39708 39709 39710 39711 39712 39713 39714 39715 39716 39717 39718 39719 39720 39721 39722 39723 39724 39725 39726 39727 39728 39729 39730 39731 39732 39733 39734 39735 39736 39737 39738 39739 39740 39741 39742 39743 39744 39745 39746 39747 39748 39749 39750 39751 39752 39753 39754 39755 39756 39757 39758 39759 39760 39761 39762 39763 39764 39765 39766 39767 39768 39769 39770 39771 39772 39773 39774 39775 39776 39777 39778 39779 39780 39781 39782 39783 39784 39785 39786 39787 39788 39789 39790 39791 39792 39793 39794 39795 39796 39797 39798 39799 39800 39801 39802 39803 39804 39805 39806 39807 39808 39809 39810 39811 39812 39813 39814 39815 39816 39817 39818 39819 39820 39821 39822 39823 39824 39825 39826 39827 39828 39829 39830 39831 39832 39833 39834 39835 39836 39837 39838 39839 39840 39841 39842 39843 39844 39845 39846 39847 39848 39849 39850 39851 39852 39853 39854 39855 39856 39857 39858 39859 39860 39861 39862 39863 39864 39865 39866 39867 39868 39869 39870 39871 39872 39873 39874 39875 39876 39877 39878 39879 39880 39881 39882 39883 39884 39885 39886 39887 39888 39889 39890 39891 39892 39893 39894 39895 39896 39897 39898 39899 39900 39901 39902 39903 39904 39905 39906 39907 39908 39909 39910 39911 39912 39913 39914 39915 39916 39917 39918 39919 39920 39921 39922 39923 39924 39925 39926 39927 39928 39929 39930 39931 39932 39933 39934 39935 39936 39937 39938 39939 39940 39941 39942 39943 39944 39945 39946 39947 39948 39949 39950 39951 39952 39953 39954 39955 39956 39957 39958 39959 39960 39961 39962 39963 39964 39965 39966 39967 39968 39969 39970 39971 39972 39973 39974 39975 39976 39977 39978 39979 39980 39981 39982 39983 39984 39985 39986 39987 39988 39989 39990 39991 39992 39993 39994 39995 39996 39997 39998 39999 40000 40001 40002 40003 40004 40005 40006 40007 40008 40009 40010 40011 40012 40013 40014 40015 40016 40017 40018 40019 40020 40021 40022 40023 40024 40025 40026 40027 40028 40029 40030 40031 40032 40033 40034 40035 40036 40037 40038 40039 40040 40041 40042 40043 40044 40045 40046 40047 40048 40049 40050 40051 40052 40053 40054 40055 40056 40057 40058 40059 40060 40061 40062 40063 40064 40065 40066 40067 40068 40069 40070 40071 40072 40073 40074 40075 40076 40077 40078 40079 40080 40081 40082 40083 40084 40085 40086 40087 40088 40089 40090 40091 40092 40093 40094 40095 40096 40097 40098 40099 40100 40101 40102 40103 40104 40105 40106 40107 40108 40109 40110 40111 40112 40113 40114 40115 40116 40117 40118 40119 40120 40121 40122 40123 40124 40125 40126 40127 40128 40129 40130 40131 40132 40133 40134 40135 40136 40137 40138 40139 40140 40141 40142 40143 40144 40145 40146 40147 40148 40149 40150 40151 40152 40153 40154 40155 40156 40157 40158 40159 40160 40161 40162 40163 40164 40165 40166 40167 40168 40169 40170 40171 40172 40173 40174 40175 40176 40177 40178 40179 40180 40181 40182 40183 40184 40185 40186 40187 40188 40189 40190 40191 40192 40193 40194 40195 40196 40197 40198 40199 40200 40201 40202 40203 40204 40205 40206 40207 40208 40209 40210 40211 40212 40213 40214 40215 40216 40217 40218 40219 40220 40221 40222 40223 40224 40225 40226 40227 40228 40229 40230 40231 40232 40233 40234 40235 40236 40237 40238 40239 40240 40241 40242 40243 40244 40245 40246 40247 40248 40249 40250 40251 40252 40253 40254 40255 40256 40257 40258 40259 40260 40261 40262 40263 40264 40265 40266 40267 40268 40269 40270 40271 40272 40273 40274 40275 40276 40277 40278 40279 40280 40281 40282 40283 40284 40285 40286 40287 40288 40289 40290 40291 40292 40293 40294 40295 40296 40297 40298 40299 40300 40301 40302 40303 40304 40305 40306 40307 40308 40309 40310 40311 40312 40313 40314 40315 40316 40317 40318 40319 40320 40321 40322 40323 40324 40325 40326 40327 40328 40329 40330 40331 40332 40333 40334 40335 40336 40337 40338 40339 40340 40341 40342 40343 40344 40345 40346 40347 40348 40349 40350 40351 40352 40353 40354 40355 40356 40357 40358 40359 40360 40361 40362 40363 40364 40365 40366 40367 40368 40369 40370 40371 40372 40373 40374 40375 40376 40377 40378 40379 40380 40381 40382 40383 40384 40385 40386 40387 40388 40389 40390 40391 40392 40393 40394 40395 40396 40397 40398 40399 40400 40401 40402 40403 40404 40405 40406 40407 40408 40409 40410 40411 40412 40413 40414 40415 40416 40417 40418 40419 40420 40421 40422 40423 40424 40425 40426 40427 40428 40429 40430 40431 40432 40433 40434 40435 40436 40437 40438 40439 40440 40441 40442 40443 40444 40445 40446 40447 40448 40449 40450 40451 40452 40453 40454 40455 40456 40457 40458 40459 40460 40461 40462 40463 40464 40465 40466 40467 40468 40469 40470 40471 40472 40473 40474 40475 40476 40477 40478 40479 40480 40481 40482 40483 40484 40485 40486 40487 40488 40489 40490 40491 40492 40493 40494 40495 40496 40497 40498 40499 40500 40501 40502 40503 40504 40505 40506 40507 40508 40509 40510 40511 40512 40513 40514 40515 40516 40517 40518 40519 40520 40521 40522 40523 40524 40525 40526 40527 40528 40529 40530 40531 40532 40533 40534 40535 40536 40537 40538 40539 40540 40541 40542 40543 40544 40545 40546 40547 40548 40549 40550 40551 40552 40553 40554 40555 40556 40557 40558 40559 40560 40561 40562 40563 40564 40565 40566 40567 40568 40569 40570 40571 40572 40573 40574 40575 40576 40577 40578 40579 40580 40581 40582 40583 40584 40585 40586 40587 40588 40589 40590 40591 40592 40593 40594 40595 40596 40597 40598 40599 40600 40601 40602 40603 40604 40605 40606 40607 40608 40609 40610 40611 40612 40613 40614 40615 40616 40617 40618 40619 40620 40621 40622 40623 40624 40625 40626 40627 40628 40629 40630 40631 40632 40633 40634 40635 40636 40637 40638 40639 40640 40641 40642 40643 40644 40645 40646 40647 40648 40649 40650 40651 40652 40653 40654 40655 40656 40657 40658 40659 40660 40661 40662 40663 40664 40665 40666 40667 40668 40669 40670 40671 40672 40673 40674 40675 40676 40677 40678 40679 40680 40681 40682 40683 40684 40685 40686 40687 40688 40689 40690 40691 40692 40693 40694 40695 40696 40697 40698 40699 40700 40701 40702 40703 40704 40705 40706 40707 40708 40709 40710 40711 40712 40713 40714 40715 40716 40717 40718 40719 40720 40721 40722 40723 40724 40725 40726 40727 40728 40729 40730 40731 40732 40733 40734 40735 40736 40737 40738 40739 40740 40741 40742 40743 40744 40745 40746 40747 40748 40749 40750 40751 40752 40753 40754 40755 40756 40757 40758 40759 40760 40761 40762 40763 40764 40765 40766 40767 40768 40769 40770 40771 40772 40773 40774 40775 40776 40777 40778 40779 40780 40781 40782 40783 40784 40785 40786 40787 40788 40789 40790 40791 40792 40793 40794 40795 40796 40797 40798 40799 40800 40801 40802 40803 40804 40805 40806 40807 40808 40809 40810 40811 40812 40813 40814 40815 40816 40817 40818 40819 40820 40821 40822 40823 40824 40825 40826 40827 40828 40829 40830 40831 40832 40833 40834 40835 40836 40837 40838 40839 40840 40841 40842 40843 40844 40845 40846 40847 40848 40849 40850 40851 40852 40853 40854 40855 40856 40857 40858 40859 40860 40861 40862 40863 40864 40865 40866 40867 40868 40869 40870 40871 40872 40873 40874 40875 40876 40877 40878 40879 40880 40881 40882 40883 40884 40885 40886 40887 40888 40889 40890 40891 40892 40893 40894 40895 40896 40897 40898 40899 40900 40901 40902 40903 40904 40905 40906 40907 40908 40909 40910 40911 40912 40913 40914 40915 40916 40917 40918 40919 40920 40921 40922 40923 40924 40925 40926 40927 40928 40929 40930 40931 40932 40933 40934 40935 40936 40937 40938 40939 40940 40941 40942 40943 40944 40945 40946 40947 40948 40949 40950 40951 40952 40953 40954 40955 40956 40957 40958 40959 40960 40961 40962 40963 40964 40965 40966 40967 40968 40969 40970 40971 40972 40973 40974 40975 40976 40977 40978 40979 40980 40981 40982 40983 40984 40985 40986 40987 40988 40989 40990 40991 40992 40993 40994 40995 40996 40997 40998 40999 41000 41001 41002 41003 41004 41005 41006 41007 41008 41009 41010 41011 41012 41013 41014 41015 41016 41017 41018 41019 41020 41021 41022 41023 41024 41025 41026 41027 41028 41029 41030 41031 41032 41033 41034 41035 41036 41037 41038 41039 41040 41041 41042 41043 41044 41045 41046 41047 41048 41049 41050 41051 41052 41053 41054 41055 41056 41057 41058 41059 41060 41061 41062 41063 41064 41065 41066 41067 41068 41069 41070 41071 41072 41073 41074 41075 41076 41077 41078 41079 41080 41081 41082 41083 41084 41085 41086 41087 41088 41089 41090 41091 41092 41093 41094 41095 41096 41097 41098 41099 41100 41101 41102 41103 41104 41105 41106 41107 41108 41109 41110 41111 41112 41113 41114 41115 41116 41117 41118 41119 41120 41121 41122 41123 41124 41125 41126 41127 41128 41129 41130 41131 41132 41133 41134 41135 41136 41137 41138 41139 41140 41141 41142 41143 41144 41145 41146 41147 41148 41149 41150 41151 41152 41153 41154 41155 41156 41157 41158 41159 41160 41161 41162 41163 41164 41165 41166 41167 41168 41169 41170 41171 41172 41173 41174 41175 41176 41177 41178 41179 41180 41181 41182 41183 41184 41185 41186 41187 41188 41189 41190 41191 41192 41193 41194 41195 41196 41197 41198 41199 41200 41201 41202 41203 41204 41205 41206 41207 41208 41209 41210 41211 41212 41213 41214 41215 41216 41217 41218 41219 41220 41221 41222 41223 41224 41225 41226 41227 41228 41229 41230 41231 41232 41233 41234 41235 41236 41237 41238 41239 41240 41241 41242 41243 41244 41245 41246 41247 41248 41249 41250 41251 41252 41253 41254 41255 41256 41257 41258 41259 41260 41261 41262 41263 41264 41265 41266 41267 41268 41269 41270 41271 41272 41273 41274 41275 41276 41277 41278 41279 41280 41281 41282 41283 41284 41285 41286 41287 41288 41289 41290 41291 41292 41293 41294 41295 41296 41297 41298 41299 41300 41301 41302 41303 41304 41305 41306 41307 41308 41309 41310 41311 41312 41313 41314 41315 41316 41317 41318 41319 41320 41321 41322 41323 41324 41325 41326 41327 41328 41329 41330 41331 41332 41333 41334 41335 41336 41337 41338 41339 41340 41341 41342 41343 41344 41345 41346 41347 41348 41349 41350 41351 41352 41353 41354 41355 41356 41357 41358 41359 41360 41361 41362 41363 41364 41365 41366 41367 41368 41369 41370 41371 41372 41373 41374 41375 41376 41377 41378 41379 41380 41381 41382 41383 41384 41385 41386 41387 41388 41389 41390 41391 41392 41393 41394 41395 41396 41397 41398 41399 41400 41401 41402 41403 41404 41405 41406 41407 41408 41409 41410 41411 41412 41413 41414 41415 41416 41417 41418 41419 41420 41421 41422 41423 41424 41425 41426 41427 41428 41429 41430 41431 41432 41433 41434 41435 41436 41437 41438 41439 41440 41441 41442 41443 41444 41445 41446 41447 41448 41449 41450 41451 41452 41453 41454 41455 41456 41457 41458 41459 41460 41461 41462 41463 41464 41465 41466 41467 41468 41469 41470 41471 41472 41473 41474 41475 41476 41477 41478 41479 41480 41481 41482 41483 41484 41485 41486 41487 41488 41489 41490 41491 41492 41493 41494 41495 41496 41497 41498 41499 41500 41501 41502 41503 41504 41505 41506 41507 41508 41509 41510 41511 41512 41513 41514 41515 41516 41517 41518 41519 41520 41521 41522 41523 41524 41525 41526 41527 41528 41529 41530 41531 41532 41533 41534 41535 41536 41537 41538 41539 41540 41541 41542 41543 41544 41545 41546 41547 41548 41549 41550 41551 41552 41553 41554 41555 41556 41557 41558 41559 41560 41561 41562 41563 41564 41565 41566 41567 41568 41569 41570 41571 41572 41573 41574 41575 41576 41577 41578 41579 41580 41581 41582 41583 41584 41585 41586 41587 41588 41589 41590 41591 41592 41593 41594 41595 41596 41597 41598 41599 41600 41601 41602 41603 41604 41605 41606 41607 41608 41609 41610 41611 41612 41613 41614 41615 41616 41617 41618 41619 41620 41621 41622 41623 41624 41625 41626 41627 41628 41629 41630 41631 41632 41633 41634 41635 41636 41637 41638 41639 41640 41641 41642 41643 41644 41645 41646 41647 41648 41649 41650 41651 41652 41653 41654 41655 41656 41657 41658 41659 41660 41661 41662 41663 41664 41665 41666 41667 41668 41669 41670 41671 41672 41673 41674 41675 41676 41677 41678 41679 41680 41681 41682 41683 41684 41685 41686 41687 41688 41689 41690 41691 41692 41693 41694 41695 41696 41697 41698 41699 41700 41701 41702 41703 41704 41705 41706 41707 41708 41709 41710 41711 41712 41713 41714 41715 41716 41717 41718 41719 41720 41721 41722 41723 41724 41725 41726 41727 41728 41729 41730 41731 41732 41733 41734 41735 41736 41737 41738 41739 41740 41741 41742 41743 41744 41745 41746 41747 41748 41749 41750 41751 41752 41753 41754 41755 41756 41757 41758 41759 41760 41761 41762 41763 41764 41765 41766 41767 41768 41769 41770 41771 41772 41773 41774 41775 41776 41777 41778 41779 41780 41781 41782 41783 41784 41785 41786 41787 41788 41789 41790 41791 41792 41793 41794 41795 41796 41797 41798 41799 41800 41801 41802 41803 41804 41805 41806 41807 41808 41809 41810 41811 41812 41813 41814 41815 41816 41817 41818 41819 41820 41821 41822 41823 41824 41825 41826 41827 41828 41829 41830 41831 41832 41833 41834 41835 41836 41837 41838 41839 41840 41841 41842 41843 41844 41845 41846 41847 41848 41849 41850 41851 41852 41853 41854 41855 41856 41857 41858 41859 41860 41861 41862 41863 41864 41865 41866 41867 41868 41869 41870 41871 41872 41873 41874 41875 41876 41877 41878 41879 41880 41881 41882 41883 41884 41885 41886 41887 41888 41889 41890 41891 41892 41893 41894 41895 41896 41897 41898 41899 41900 41901 41902 41903 41904 41905 41906 41907 41908 41909 41910 41911 41912 41913 41914 41915 41916 41917 41918 41919 41920 41921 41922 41923 41924 41925 41926 41927 41928 41929 41930 41931 41932 41933 41934 41935 41936 41937 41938 41939 41940 41941 41942 41943 41944 41945 41946 41947 41948 41949 41950 41951 41952 41953 41954 41955 41956 41957 41958 41959 41960 41961 41962 41963 41964 41965 41966 41967 41968 41969 41970 41971 41972 41973 41974 41975 41976 41977 41978 41979 41980 41981 41982 41983 41984 41985 41986 41987 41988 41989 41990 41991 41992 41993 41994 41995 41996 41997 41998 41999 42000 42001 42002 42003 42004 42005 42006 42007 42008 42009 42010 42011 42012 42013 42014 42015 42016 42017 42018 42019 42020 42021 42022 42023 42024 42025 42026 42027 42028 42029 42030 42031 42032 42033 42034 42035 42036 42037 42038 42039 42040 42041 42042 42043 42044 42045 42046 42047 42048 42049 42050 42051 42052 42053 42054 42055 42056 42057 42058 42059 42060 42061 42062 42063 42064 42065 42066 42067 42068 42069 42070 42071 42072 42073 42074 42075 42076 42077 42078 42079 42080 42081 42082 42083 42084 42085 42086 42087 42088 42089 42090 42091 42092 42093 42094 42095 42096 42097 42098 42099 42100 42101 42102 42103 42104 42105 42106 42107 42108 42109 42110 42111 42112 42113 42114 42115 42116 42117 42118 42119 42120 42121 42122 42123 42124 42125 42126 42127 42128 42129 42130 42131 42132 42133 42134 42135 42136 42137 42138 42139 42140 42141 42142 42143 42144 42145 42146 42147 42148 42149 42150 42151 42152 42153 42154 42155 42156 42157 42158 42159 42160 42161 42162 42163 42164 42165 42166 42167 42168 42169 42170 42171 42172 42173 42174 42175 42176 42177 42178 42179 42180 42181 42182 42183 42184 42185 42186 42187 42188 42189 42190 42191 42192 42193 42194 42195 42196 42197 42198 42199 42200 42201 42202 42203 42204 42205 42206 42207 42208 42209 42210 42211 42212 42213 42214 42215 42216 42217 42218 42219 42220 42221 42222 42223 42224 42225 42226 42227 42228 42229 42230 42231 42232 42233 42234 42235 42236 42237 42238 42239 42240 42241 42242 42243 42244 42245 42246 42247 42248 42249 42250 42251 42252 42253 42254 42255 42256 42257 42258 42259 42260 42261 42262 42263 42264 42265 42266 42267 42268 42269 42270 42271 42272 42273 42274 42275 42276 42277 42278 42279 42280 42281 42282 42283 42284 42285 42286 42287 42288 42289 42290 42291 42292 42293 42294 42295 42296 42297 42298 42299 42300 42301 42302 42303 42304 42305 42306 42307 42308 42309 42310 42311 42312 42313 42314 42315 42316 42317 42318 42319 42320 42321 42322 42323 42324 42325 42326 42327 42328 42329 42330 42331 42332 42333 42334 42335 42336 42337 42338 42339 42340 42341 42342 42343 42344 42345 42346 42347 42348 42349 42350 42351 42352 42353 42354 42355 42356 42357 42358 42359 42360 42361 42362 42363 42364 42365 42366 42367 42368 42369 42370 42371 42372 42373 42374 42375 42376 42377 42378 42379 42380 42381 42382 42383 42384 42385 42386 42387 42388 42389 42390 42391 42392 42393 42394 42395 42396 42397 42398 42399 42400 42401 42402 42403 42404 42405 42406 42407 42408 42409 42410 42411 42412 42413 42414 42415 42416 42417 42418 42419 42420 42421 42422 42423 42424 42425 42426 42427 42428 42429 42430 42431 42432 42433 42434 42435 42436 42437 42438 42439 42440 42441 42442 42443 42444 42445 42446 42447 42448 42449 42450 42451 42452 42453 42454 42455 42456 42457 42458 42459 42460 42461 42462 42463 42464 42465 42466 42467 42468 42469 42470 42471 42472 42473 42474 42475 42476 42477 42478 42479 42480 42481 42482 42483 42484 42485 42486 42487 42488 42489 42490 42491 42492 42493 42494 42495 42496 42497 42498 42499 42500 42501 42502 42503 42504 42505 42506 42507 42508 42509 42510 42511 42512 42513 42514 42515 42516 42517 42518 42519 42520 42521 42522 42523 42524 42525 42526 42527 42528 42529 42530 42531 42532 42533 42534 42535 42536 42537 42538 42539 42540 42541 42542 42543 42544 42545 42546 42547 42548 42549 42550 42551 42552 42553 42554 42555 42556 42557 42558 42559 42560 42561 42562 42563 42564 42565 42566 42567 42568 42569 42570 42571 42572 42573 42574 42575 42576 42577 42578 42579 42580 42581 42582 42583 42584 42585 42586 42587 42588 42589 42590 42591 42592 42593 42594 42595 42596 42597 42598 42599 42600 42601 42602 42603 42604 42605 42606 42607 42608 42609 42610 42611 42612 42613 42614 42615 42616 42617 42618 42619 42620 42621 42622 42623 42624 42625 42626 42627 42628 42629 42630 42631 42632 42633 42634 42635 42636 42637 42638 42639 42640 42641 42642 42643 42644 42645 42646 42647 42648 42649 42650 42651 42652 42653 42654 42655 42656 42657 42658 42659 42660 42661 42662 42663 42664 42665 42666 42667 42668 42669 42670 42671 42672 42673 42674 42675 42676 42677 42678 42679 42680 42681 42682 42683 42684 42685 42686 42687 42688 42689 42690 42691 42692 42693 42694 42695 42696 42697 42698 42699 42700 42701 42702 42703 42704 42705 42706 42707 42708 42709 42710 42711 42712 42713 42714 42715 42716 42717 42718 42719 42720 42721 42722 42723 42724 42725 42726 42727 42728 42729 42730 42731 42732 42733 42734 42735 42736 42737 42738 42739 42740 42741 42742 42743 42744 42745 42746 42747 42748 42749 42750 42751 42752 42753 42754 42755 42756 42757 42758 42759 42760 42761 42762 42763 42764 42765 42766 42767 42768 42769 42770 42771 42772 42773 42774 42775 42776 42777 42778 42779 42780 42781 42782 42783 42784 42785 42786 42787 42788 42789 42790 42791 42792 42793 42794 42795 42796 42797 42798 42799 42800 42801 42802 42803 42804 42805 42806 42807 42808 42809 42810 42811 42812 42813 42814 42815 42816 42817 42818 42819 42820 42821 42822 42823 42824 42825 42826 42827 42828 42829 42830 42831 42832 42833 42834 42835 42836 42837 42838 42839 42840 42841 42842 42843 42844 42845 42846 42847 42848 42849 42850 42851 42852 42853 42854 42855 42856 42857 42858 42859 42860 42861 42862 42863 42864 42865 42866 42867 42868 42869 42870 42871 42872 42873 42874 42875 42876 42877 42878 42879 42880 42881 42882 42883 42884 42885 42886 42887 42888 42889 42890 42891 42892 42893 42894 42895 42896 42897 42898 42899 42900 42901 42902 42903 42904 42905 42906 42907 42908 42909 42910 42911 42912 42913 42914 42915 42916 42917 42918 42919 42920 42921 42922 42923 42924 42925 42926 42927 42928 42929 42930 42931 42932 42933 42934 42935 42936 42937 42938 42939 42940 42941 42942 42943 42944 42945 42946 42947 42948 42949 42950 42951 42952 42953 42954 42955 42956 42957 42958 42959 42960 42961 42962 42963 42964 42965 42966 42967 42968 42969 42970 42971 42972 42973 42974 42975 42976 42977 42978 42979 42980 42981 42982 42983 42984 42985 42986 42987 42988 42989 42990 42991 42992 42993 42994 42995 42996 42997 42998 42999 43000 43001 43002 43003 43004 43005 43006 43007 43008 43009 43010 43011 43012 43013 43014 43015 43016 43017 43018 43019 43020 43021 43022 43023 43024 43025 43026 43027 43028 43029 43030 43031 43032 43033 43034 43035 43036 43037 43038 43039 43040 43041 43042 43043 43044 43045 43046 43047 43048 43049 43050 43051 43052 43053 43054 43055 43056 43057 43058 43059 43060 43061 43062 43063 43064 43065 43066 43067 43068 43069 43070 43071 43072 43073 43074 43075 43076 43077 43078 43079 43080 43081 43082 43083 43084 43085 43086 43087 43088 43089 43090 43091 43092 43093 43094 43095 43096 43097 43098 43099 43100 43101 43102 43103 43104 43105 43106 43107 43108 43109 43110 43111 43112 43113 43114 43115 43116 43117 43118 43119 43120 43121 43122 43123 43124 43125 43126 43127 43128 43129 43130 43131 43132 43133 43134 43135 43136 43137 43138 43139 43140 43141 43142 43143 43144 43145 43146 43147 43148 43149 43150 43151 43152 43153 43154 43155 43156 43157 43158 43159 43160 43161 43162 43163 43164 43165 43166 43167 43168 43169 43170 43171 43172 43173 43174 43175 43176 43177 43178 43179 43180 43181 43182 43183 43184 43185 43186 43187 43188 43189 43190 43191 43192 43193 43194 43195 43196 43197 43198 43199 43200 43201 43202 43203 43204 43205 43206 43207 43208 43209 43210 43211 43212 43213 43214 43215 43216 43217 43218 43219 43220 43221 43222 43223 43224 43225 43226 43227 43228 43229 43230 43231 43232 43233 43234 43235 43236 43237 43238 43239 43240 43241 43242 43243 43244 43245 43246 43247 43248 43249 43250 43251 43252 43253 43254 43255 43256 43257 43258 43259 43260 43261 43262 43263 43264 43265 43266 43267 43268 43269 43270 43271 43272 43273 43274 43275 43276 43277 43278 43279 43280 43281 43282 43283 43284 43285 43286 43287 43288 43289 43290 43291 43292 43293 43294 43295 43296 43297 43298 43299 43300 43301 43302 43303 43304 43305 43306 43307 43308 43309 43310 43311 43312 43313 43314 43315 43316 43317 43318 43319 43320 43321 43322 43323 43324 43325 43326 43327 43328 43329 43330 43331 43332 43333 43334 43335 43336 43337 43338 43339 43340 43341 43342 43343 43344 43345 43346 43347 43348 43349 43350 43351 43352 43353 43354 43355 43356 43357 43358 43359 43360 43361 43362 43363 43364 43365 43366 43367 43368 43369 43370 43371 43372 43373 43374 43375 43376 43377 43378 43379 43380 43381 43382 43383 43384 43385 43386 43387 43388 43389 43390 43391 43392 43393 43394 43395 43396 43397 43398 43399 43400 43401 43402 43403 43404 43405 43406 43407 43408 43409 43410 43411 43412 43413 43414 43415 43416 43417 43418 43419 43420 43421 43422 43423 43424 43425 43426 43427 43428 43429 43430 43431 43432 43433 43434 43435 43436 43437 43438 43439 43440 43441 43442 43443 43444 43445 43446 43447 43448 43449 43450 43451 43452 43453 43454 43455 43456 43457 43458 43459 43460 43461 43462 43463 43464 43465 43466 43467 43468 43469 43470 43471 43472 43473 43474 43475 43476 43477 43478 43479 43480 43481 43482 43483 43484 43485 43486 43487 43488 43489 43490 43491 43492 43493 43494 43495 43496 43497 43498 43499 43500 43501 43502 43503 43504 43505 43506 43507 43508 43509 43510 43511 43512 43513 43514 43515 43516 43517 43518 43519 43520 43521 43522 43523 43524 43525 43526 43527 43528 43529 43530 43531 43532 43533 43534 43535 43536 43537 43538 43539 43540 43541 43542 43543 43544 43545 43546 43547 43548 43549 43550 43551 43552 43553 43554 43555 43556 43557 43558 43559 43560 43561 43562 43563 43564 43565 43566 43567 43568 43569 43570 43571 43572 43573 43574 43575 43576 43577 43578 43579 43580 43581 43582 43583 43584 43585 43586 43587 43588 43589 43590 43591 43592 43593 43594 43595 43596 43597 43598 43599 43600 43601 43602 43603 43604 43605 43606 43607 43608 43609 43610 43611 43612 43613 43614 43615 43616 43617 43618 43619 43620 43621 43622 43623 43624 43625 43626 43627 43628 43629 43630 43631 43632 43633 43634 43635 43636 43637 43638 43639 43640 43641 43642 43643 43644 43645 43646 43647 43648 43649 43650 43651 43652 43653 43654 43655 43656 43657 43658 43659 43660 43661 43662 43663 43664 43665 43666 43667 43668 43669 43670 43671 43672 43673 43674 43675 43676 43677 43678 43679 43680 43681 43682 43683 43684 43685 43686 43687 43688 43689 43690 43691 43692 43693 43694 43695 43696 43697 43698 43699 43700 43701 43702 43703 43704 43705 43706 43707 43708 43709 43710 43711 43712 43713 43714 43715 43716 43717 43718 43719 43720 43721 43722 43723 43724 43725 43726 43727 43728 43729 43730 43731 43732 43733 43734 43735 43736 43737 43738 43739 43740 43741 43742 43743 43744 43745 43746 43747 43748 43749 43750 43751 43752 43753 43754 43755 43756 43757 43758 43759 43760 43761 43762 43763 43764 43765 43766 43767 43768 43769 43770 43771 43772 43773 43774 43775 43776 43777 43778 43779 43780 43781 43782 43783 43784 43785 43786 43787 43788 43789 43790 43791 43792 43793 43794 43795 43796 43797 43798 43799 43800 43801 43802 43803 43804 43805 43806 43807 43808 43809 43810 43811 43812 43813 43814 43815 43816 43817 43818 43819 43820 43821 43822 43823 43824 43825 43826 43827 43828 43829 43830 43831 43832 43833 43834 43835 43836 43837 43838 43839 43840 43841 43842 43843 43844 43845 43846 43847 43848 43849 43850 43851 43852 43853 43854 43855 43856 43857 43858 43859 43860 43861 43862 43863 43864 43865 43866 43867 43868 43869 43870 43871 43872 43873 43874 43875 43876 43877 43878 43879 43880 43881 43882 43883 43884 43885 43886 43887 43888 43889 43890 43891 43892 43893 43894 43895 43896 43897 43898 43899 43900 43901 43902 43903 43904 43905 43906 43907 43908 43909 43910 43911 43912 43913 43914 43915 43916 43917 43918 43919 43920 43921 43922 43923 43924 43925 43926 43927 43928 43929 43930 43931 43932 43933 43934 43935 43936 43937 43938 43939 43940 43941 43942 43943 43944 43945 43946 43947 43948 43949 43950 43951 43952 43953 43954 43955 43956 43957 43958 43959 43960 43961 43962 43963 43964 43965 43966 43967 43968 43969 43970 43971 43972 43973 43974 43975 43976 43977 43978 43979 43980 43981 43982 43983 43984 43985 43986 43987 43988 43989 43990 43991 43992 43993 43994 43995 43996 43997 43998 43999 44000 44001 44002 44003 44004 44005 44006 44007 44008 44009 44010 44011 44012 44013 44014 44015 44016 44017 44018 44019 44020 44021 44022 44023 44024 44025 44026 44027 44028 44029 44030 44031 44032 44033 44034 44035 44036 44037 44038 44039 44040 44041 44042 44043 44044 44045 44046 44047 44048 44049 44050 44051 44052 44053 44054 44055 44056 44057 44058 44059 44060 44061 44062 44063 44064 44065 44066 44067 44068 44069 44070 44071 44072 44073 44074 44075 44076 44077 44078 44079 44080 44081 44082 44083 44084 44085 44086 44087 44088 44089 44090 44091 44092 44093 44094 44095 44096 44097 44098 44099 44100 44101 44102 44103 44104 44105 44106 44107 44108 44109 44110 44111 44112 44113 44114 44115 44116 44117 44118 44119 44120 44121 44122 44123 44124 44125 44126 44127 44128 44129 44130 44131 44132 44133 44134 44135 44136 44137 44138 44139 44140 44141 44142 44143 44144 44145 44146 44147 44148 44149 44150 44151 44152 44153 44154 44155 44156 44157 44158 44159 44160 44161 44162 44163 44164 44165 44166 44167 44168 44169 44170 44171 44172 44173 44174 44175 44176 44177 44178 44179 44180 44181 44182 44183 44184 44185 44186 44187 44188 44189 44190 44191 44192 44193 44194 44195 44196 44197 44198 44199 44200 44201 44202 44203 44204 44205 44206 44207 44208 44209 44210 44211 44212 44213 44214 44215 44216 44217 44218 44219 44220 44221 44222 44223 44224 44225 44226 44227 44228 44229 44230 44231 44232 44233 44234 44235 44236 44237 44238 44239 44240 44241 44242 44243 44244 44245 44246 44247 44248 44249 44250 44251 44252 44253 44254 44255 44256 44257 44258 44259 44260 44261 44262 44263 44264 44265 44266 44267 44268 44269 44270 44271 44272 44273 44274 44275 44276 44277 44278 44279 44280 44281 44282 44283 44284 44285 44286 44287 44288 44289 44290 44291 44292 44293 44294 44295 44296 44297 44298 44299 44300 44301 44302 44303 44304 44305 44306 44307 44308 44309 44310 44311 44312 44313 44314 44315 44316 44317 44318 44319 44320 44321 44322 44323 44324 44325 44326 44327 44328 44329 44330 44331 44332 44333 44334 44335 44336 44337 44338 44339 44340 44341 44342 44343 44344 44345 44346 44347 44348 44349 44350 44351 44352 44353 44354 44355 44356 44357 44358 44359 44360 44361 44362 44363 44364 44365 44366 44367 44368 44369 44370 44371 44372 44373 44374 44375 44376 44377 44378 44379 44380 44381 44382 44383 44384 44385 44386 44387 44388 44389 44390 44391 44392 44393 44394 44395 44396 44397 44398 44399 44400 44401 44402 44403 44404 44405 44406 44407 44408 44409 44410 44411 44412 44413 44414 44415 44416 44417 44418 44419 44420 44421 44422 44423 44424 44425 44426 44427 44428 44429 44430 44431 44432 44433 44434 44435 44436 44437 44438 44439 44440 44441 44442 44443 44444 44445 44446 44447 44448 44449 44450 44451 44452 44453 44454 44455 44456 44457 44458 44459 44460 44461 44462 44463 44464 44465 44466 44467 44468 44469 44470 44471 44472 44473 44474 44475 44476 44477 44478 44479 44480 44481 44482 44483 44484 44485 44486 44487 44488 44489 44490 44491 44492 44493 44494 44495 44496 44497 44498 44499 44500 44501 44502 44503 44504 44505 44506 44507 44508 44509 44510 44511 44512 44513 44514 44515 44516 44517 44518 44519 44520 44521 44522 44523 44524 44525 44526 44527 44528 44529 44530 44531 44532 44533 44534 44535 44536 44537 44538 44539 44540 44541 44542 44543 44544 44545 44546 44547 44548 44549 44550 44551 44552 44553 44554 44555 44556 44557 44558 44559 44560 44561 44562 44563 44564 44565 44566 44567 44568 44569 44570 44571 44572 44573 44574 44575 44576 44577 44578 44579 44580 44581 44582 44583 44584 44585 44586 44587 44588 44589 44590 44591 44592 44593 44594 44595 44596 44597 44598 44599 44600 44601 44602 44603 44604 44605 44606 44607 44608 44609 44610 44611 44612 44613 44614 44615 44616 44617 44618 44619 44620 44621 44622 44623 44624 44625 44626 44627 44628 44629 44630 44631 44632 44633 44634 44635 44636 44637 44638 44639 44640 44641 44642 44643 44644 44645 44646 44647 44648 44649 44650 44651 44652 44653 44654 44655 44656 44657 44658 44659 44660 44661 44662 44663 44664 44665 44666 44667 44668 44669 44670 44671 44672 44673 44674 44675 44676 44677 44678 44679 44680 44681 44682 44683 44684 44685 44686 44687 44688 44689 44690 44691 44692 44693 44694 44695 44696 44697 44698 44699 44700 44701 44702 44703 44704 44705 44706 44707 44708 44709 44710 44711 44712 44713 44714 44715 44716 44717 44718 44719 44720 44721 44722 44723 44724 44725 44726 44727 44728 44729 44730 44731 44732 44733 44734 44735 44736 44737 44738 44739 44740 44741 44742 44743 44744 44745 44746 44747 44748 44749 44750 44751 44752 44753 44754 44755 44756 44757 44758 44759 44760 44761 44762 44763 44764 44765 44766 44767 44768 44769 44770 44771 44772 44773 44774 44775 44776 44777 44778 44779 44780 44781 44782 44783 44784 44785 44786 44787 44788 44789 44790 44791 44792 44793 44794 44795 44796 44797 44798 44799 44800 44801 44802 44803 44804 44805 44806 44807 44808 44809 44810 44811 44812 44813 44814 44815 44816 44817 44818 44819 44820 44821 44822 44823 44824 44825 44826 44827 44828 44829 44830 44831 44832 44833 44834 44835 44836 44837 44838 44839 44840 44841 44842 44843 44844 44845 44846 44847 44848 44849 44850 44851 44852 44853 44854 44855 44856 44857 44858 44859 44860 44861 44862 44863 44864 44865 44866 44867 44868 44869 44870 44871 44872 44873 44874 44875 44876 44877 44878 44879 44880 44881 44882 44883 44884 44885 44886 44887 44888 44889 44890 44891 44892 44893 44894 44895 44896 44897 44898 44899 44900 44901 44902 44903 44904 44905 44906 44907 44908 44909 44910 44911 44912 44913 44914 44915 44916 44917 44918 44919 44920 44921 44922 44923 44924 44925 44926 44927 44928 44929 44930 44931 44932 44933 44934 44935 44936 44937 44938 44939 44940 44941 44942 44943 44944 44945 44946 44947 44948 44949 44950 44951 44952 44953 44954 44955 44956 44957 44958 44959 44960 44961 44962 44963 44964 44965 44966 44967 44968 44969 44970 44971 44972 44973 44974 44975 44976 44977 44978 44979 44980 44981 44982 44983 44984 44985 44986 44987 44988 44989 44990 44991 44992 44993 44994 44995 44996 44997 44998 44999 45000 45001 45002 45003 45004 45005 45006 45007 45008 45009 45010 45011 45012 45013 45014 45015 45016 45017 45018 45019 45020 45021 45022 45023 45024 45025 45026 45027 45028 45029 45030 45031 45032 45033 45034 45035 45036 45037 45038 45039 45040 45041 45042 45043 45044 45045 45046 45047 45048 45049 45050 45051 45052 45053 45054 45055 45056 45057 45058 45059 45060 45061 45062 45063 45064 45065 45066 45067 45068 45069 45070 45071 45072 45073 45074 45075 45076 45077 45078 45079 45080 45081 45082 45083 45084 45085 45086 45087 45088 45089 45090 45091 45092 45093 45094 45095 45096 45097 45098 45099 45100 45101 45102 45103 45104 45105 45106 45107 45108 45109 45110 45111 45112 45113 45114 45115 45116 45117 45118 45119 45120 45121 45122 45123 45124 45125 45126 45127 45128 45129 45130 45131 45132 45133 45134 45135 45136 45137 45138 45139 45140 45141 45142 45143 45144 45145 45146 45147 45148 45149 45150 45151 45152 45153 45154 45155 45156 45157 45158 45159 45160 45161 45162 45163 45164 45165 45166 45167 45168 45169 45170 45171 45172 45173 45174 45175 45176 45177 45178 45179 45180 45181 45182 45183 45184 45185 45186 45187 45188 45189 45190 45191 45192 45193 45194 45195 45196 45197 45198 45199 45200 45201 45202 45203 45204 45205 45206 45207 45208 45209 45210 45211 45212 45213 45214 45215 45216 45217 45218 45219 45220 45221 45222 45223 45224 45225 45226 45227 45228 45229 45230 45231 45232 45233 45234 45235 45236 45237 45238 45239 45240 45241 45242 45243 45244 45245 45246 45247 45248 45249 45250 45251 45252 45253 45254 45255 45256 45257 45258 45259 45260 45261 45262 45263 45264 45265 45266 45267 45268 45269 45270 45271 45272 45273 45274 45275 45276 45277 45278 45279 45280 45281 45282 45283 45284 45285 45286 45287 45288 45289 45290 45291 45292 45293 45294 45295 45296 45297 45298 45299 45300 45301 45302 45303 45304 45305 45306 45307 45308 45309 45310 45311 45312 45313 45314 45315 45316 45317 45318 45319 45320 45321 45322 45323 45324 45325 45326 45327 45328 45329 45330 45331 45332 45333 45334 45335 45336 45337 45338 45339 45340 45341 45342 45343 45344 45345 45346 45347 45348 45349 45350 45351 45352 45353 45354 45355 45356 45357 45358 45359 45360 45361 45362 45363 45364 45365 45366 45367 45368 45369 45370 45371 45372 45373 45374 45375 45376 45377 45378 45379 45380 45381 45382 45383 45384 45385 45386 45387 45388 45389 45390 45391 45392 45393 45394 45395 45396 45397 45398 45399 45400 45401 45402 45403 45404 45405 45406 45407 45408 45409 45410 45411 45412 45413 45414 45415 45416 45417 45418 45419 45420 45421 45422 45423 45424 45425 45426 45427 45428 45429 45430 45431 45432 45433 45434 45435 45436 45437 45438 45439 45440 45441 45442 45443 45444 45445 45446 45447 45448 45449 45450 45451 45452 45453 45454 45455 45456 45457 45458 45459 45460 45461 45462 45463 45464 45465 45466 45467 45468 45469 45470 45471 45472 45473 45474 45475 45476 45477 45478 45479 45480 45481 45482 45483 45484 45485 45486 45487 45488 45489 45490 45491 45492 45493 45494 45495 45496 45497 45498 45499 45500 45501 45502 45503 45504 45505 45506 45507 45508 45509 45510 45511 45512 45513 45514 45515 45516 45517 45518 45519 45520 45521 45522 45523 45524 45525 45526 45527 45528 45529 45530 45531 45532 45533 45534 45535 45536 45537 45538 45539 45540 45541 45542 45543 45544 45545 45546 45547 45548 45549 45550 45551 45552 45553 45554 45555 45556 45557 45558 45559 45560 45561 45562 45563 45564 45565 45566 45567 45568 45569 45570 45571 45572 45573 45574 45575 45576 45577 45578 45579 45580 45581 45582 45583 45584 45585 45586 45587 45588 45589 45590 45591 45592 45593 45594 45595 45596 45597 45598 45599 45600 45601 45602 45603 45604 45605 45606 45607 45608 45609 45610 45611 45612 45613 45614 45615 45616 45617 45618 45619 45620 45621 45622 45623 45624 45625 45626 45627 45628 45629 45630 45631 45632 45633 45634 45635 45636 45637 45638 45639 45640 45641 45642 45643 45644 45645 45646 45647 45648 45649 45650 45651 45652 45653 45654 45655 45656 45657 45658 45659 45660 45661 45662 45663 45664 45665 45666 45667 45668 45669 45670 45671 45672 45673 45674 45675 45676 45677 45678 45679 45680 45681 45682 45683 45684 45685 45686 45687 45688 45689 45690 45691 45692 45693 45694 45695 45696 45697 45698 45699 45700 45701 45702 45703 45704 45705 45706 45707 45708 45709 45710 45711 45712 45713 45714 45715 45716 45717 45718 45719 45720 45721 45722 45723 45724 45725 45726 45727 45728 45729 45730 45731 45732 45733 45734 45735 45736 45737 45738 45739 45740 45741 45742 45743 45744 45745 45746 45747 45748 45749 45750 45751 45752 45753 45754 45755 45756 45757 45758 45759 45760 45761 45762 45763 45764 45765 45766 45767 45768 45769 45770 45771 45772 45773 45774 45775 45776 45777 45778 45779 45780 45781 45782 45783 45784 45785 45786 45787 45788 45789 45790 45791 45792 45793 45794 45795 45796 45797 45798 45799 45800 45801 45802 45803 45804 45805 45806 45807 45808 45809 45810 45811 45812 45813 45814 45815 45816 45817 45818 45819 45820 45821 45822 45823 45824 45825 45826 45827 45828 45829 45830 45831 45832 45833 45834 45835 45836 45837 45838 45839 45840 45841 45842 45843 45844 45845 45846 45847 45848 45849 45850 45851 45852 45853 45854 45855 45856 45857 45858 45859 45860 45861 45862 45863 45864 45865 45866 45867 45868 45869 45870 45871 45872 45873 45874 45875 45876 45877 45878 45879 45880 45881 45882 45883 45884 45885 45886 45887 45888 45889 45890 45891 45892 45893 45894 45895 45896 45897 45898 45899 45900 45901 45902 45903 45904 45905 45906 45907 45908 45909 45910 45911 45912 45913 45914 45915 45916 45917 45918 45919 45920 45921 45922 45923 45924 45925 45926 45927 45928 45929 45930 45931 45932 45933 45934 45935 45936 45937 45938 45939 45940 45941 45942 45943 45944 45945 45946 45947 45948 45949 45950 45951 45952 45953 45954 45955 45956 45957 45958 45959 45960 45961 45962 45963 45964 45965 45966 45967 45968 45969 45970 45971 45972 45973 45974 45975 45976 45977 45978 45979 45980 45981 45982 45983 45984 45985 45986 45987 45988 45989 45990 45991 45992 45993 45994 45995 45996 45997 45998 45999 46000 46001 46002 46003 46004 46005 46006 46007 46008 46009 46010 46011 46012 46013 46014 46015 46016 46017 46018 46019 46020 46021 46022 46023 46024 46025 46026 46027 46028 46029 46030 46031 46032 46033 46034 46035 46036 46037 46038 46039 46040 46041 46042 46043 46044 46045 46046 46047 46048 46049 46050 46051 46052 46053 46054 46055 46056 46057 46058 46059 46060 46061 46062 46063 46064 46065 46066 46067 46068 46069 46070 46071 46072 46073 46074 46075 46076 46077 46078 46079 46080 46081 46082 46083 46084 46085 46086 46087 46088 46089 46090 46091 46092 46093 46094 46095 46096 46097 46098 46099 46100 46101 46102 46103 46104 46105 46106 46107 46108 46109 46110 46111 46112 46113 46114 46115 46116 46117 46118 46119 46120 46121 46122 46123 46124 46125 46126 46127 46128 46129 46130 46131 46132 46133 46134 46135 46136 46137 46138 46139 46140 46141 46142 46143 46144 46145 46146 46147 46148 46149 46150 46151 46152 46153 46154 46155 46156 46157 46158 46159 46160 46161 46162 46163 46164 46165 46166 46167 46168 46169 46170 46171 46172 46173 46174 46175 46176 46177 46178 46179 46180 46181 46182 46183 46184 46185 46186 46187 46188 46189 46190 46191 46192 46193 46194 46195 46196 46197 46198 46199 46200 46201 46202 46203 46204 46205 46206 46207 46208 46209 46210 46211 46212 46213 46214 46215 46216 46217 46218 46219 46220 46221 46222 46223 46224 46225 46226 46227 46228 46229 46230 46231 46232 46233 46234 46235 46236 46237 46238 46239 46240 46241 46242 46243 46244 46245 46246 46247 46248 46249 46250 46251 46252 46253 46254 46255 46256 46257 46258 46259 46260 46261 46262 46263 46264 46265 46266 46267 46268 46269 46270 46271 46272 46273 46274 46275 46276 46277 46278 46279 46280 46281 46282 46283 46284 46285 46286 46287 46288 46289 46290 46291 46292 46293 46294 46295 46296 46297 46298 46299 46300 46301 46302 46303 46304 46305 46306 46307 46308 46309 46310 46311 46312 46313 46314 46315 46316 46317 46318 46319 46320 46321 46322 46323 46324 46325 46326 46327 46328 46329 46330 46331 46332 46333 46334 46335 46336 46337 46338 46339 46340 46341 46342 46343 46344 46345 46346 46347 46348 46349 46350 46351 46352 46353 46354 46355 46356 46357 46358 46359 46360 46361 46362 46363 46364 46365 46366 46367 46368 46369 46370 46371 46372 46373 46374 46375 46376 46377 46378 46379 46380 46381 46382 46383 46384 46385 46386 46387 46388 46389 46390 46391 46392 46393 46394 46395 46396 46397 46398 46399 46400 46401 46402 46403 46404 46405 46406 46407 46408 46409 46410 46411 46412 46413 46414 46415 46416 46417 46418 46419 46420 46421 46422 46423 46424 46425 46426 46427 46428 46429 46430 46431 46432 46433 46434 46435 46436 46437 46438 46439 46440 46441 46442 46443 46444 46445 46446 46447 46448 46449 46450 46451 46452 46453 46454 46455 46456 46457 46458 46459 46460 46461 46462 46463 46464 46465 46466 46467 46468 46469 46470 46471 46472 46473 46474 46475 46476 46477 46478 46479 46480 46481 46482 46483 46484 46485 46486 46487 46488 46489 46490 46491 46492 46493 46494 46495 46496 46497 46498 46499 46500 46501 46502 46503 46504 46505 46506 46507 46508 46509 46510 46511 46512 46513 46514 46515 46516 46517 46518 46519 46520 46521 46522 46523 46524 46525 46526 46527 46528 46529 46530 46531 46532 46533 46534 46535 46536 46537 46538 46539 46540 46541 46542 46543 46544 46545 46546 46547 46548 46549 46550 46551 46552 46553 46554 46555 46556 46557 46558 46559 46560 46561 46562 46563 46564 46565 46566 46567 46568 46569 46570 46571 46572 46573 46574 46575 46576 46577 46578 46579 46580 46581 46582 46583 46584 46585 46586 46587 46588 46589 46590 46591 46592 46593 46594 46595 46596 46597 46598 46599 46600 46601 46602 46603 46604 46605 46606 46607 46608 46609 46610 46611 46612 46613 46614 46615 46616 46617 46618 46619 46620 46621 46622 46623 46624 46625 46626 46627 46628 46629 46630 46631 46632 46633 46634 46635 46636 46637 46638 46639 46640 46641 46642 46643 46644 46645 46646 46647 46648 46649 46650 46651 46652 46653 46654 46655 46656 46657 46658 46659 46660 46661 46662 46663 46664 46665 46666 46667 46668 46669 46670 46671 46672 46673 46674 46675 46676 46677 46678 46679 46680 46681 46682 46683 46684 46685 46686 46687 46688 46689 46690 46691 46692 46693 46694 46695 46696 46697 46698 46699 46700 46701 46702 46703 46704 46705 46706 46707 46708 46709 46710 46711 46712 46713 46714 46715 46716 46717 46718 46719 46720 46721 46722 46723 46724 46725 46726 46727 46728 46729 46730 46731 46732 46733 46734 46735 46736 46737 46738 46739 46740 46741 46742 46743 46744 46745 46746 46747 46748 46749 46750 46751 46752 46753 46754 46755 46756 46757 46758 46759 46760 46761 46762 46763 46764 46765 46766 46767 46768 46769 46770 46771 46772 46773 46774 46775 46776 46777 46778 46779 46780 46781 46782 46783 46784 46785 46786 46787 46788 46789 46790 46791 46792 46793 46794 46795 46796 46797 46798 46799 46800 46801 46802 46803 46804 46805 46806 46807 46808 46809 46810 46811 46812 46813 46814 46815 46816 46817 46818 46819 46820 46821 46822 46823 46824 46825 46826 46827 46828 46829 46830 46831 46832 46833 46834 46835 46836 46837 46838 46839 46840 46841 46842 46843 46844 46845 46846 46847 46848 46849 46850 46851 46852 46853 46854 46855 46856 46857 46858 46859 46860 46861 46862 46863 46864 46865 46866 46867 46868 46869 46870 46871 46872 46873 46874 46875 46876 46877 46878 46879 46880 46881 46882 46883 46884 46885 46886 46887 46888 46889 46890 46891 46892 46893 46894 46895 46896 46897 46898 46899 46900 46901 46902 46903 46904 46905 46906 46907 46908 46909 46910 46911 46912 46913 46914 46915 46916 46917 46918 46919 46920 46921 46922 46923 46924 46925 46926 46927 46928 46929 46930 46931 46932 46933 46934 46935 46936 46937 46938 46939 46940 46941 46942 46943 46944 46945 46946 46947 46948 46949 46950 46951 46952 46953 46954 46955 46956 46957 46958 46959 46960 46961 46962 46963 46964 46965 46966 46967 46968 46969 46970 46971 46972 46973 46974 46975 46976 46977 46978 46979 46980 46981 46982 46983 46984 46985 46986 46987 46988 46989 46990 46991 46992 46993 46994 46995 46996 46997 46998 46999 47000 47001 47002 47003 47004 47005 47006 47007 47008 47009 47010 47011 47012 47013 47014 47015 47016 47017 47018 47019 47020 47021 47022 47023 47024 47025 47026 47027 47028 47029 47030 47031 47032 47033 47034 47035 47036 47037 47038 47039 47040 47041 47042 47043 47044 47045 47046 47047 47048 47049 47050 47051 47052 47053 47054 47055 47056 47057 47058 47059 47060 47061 47062 47063 47064 47065 47066 47067 47068 47069 47070 47071 47072 47073 47074 47075 47076 47077 47078 47079 47080 47081 47082 47083 47084 47085 47086 47087 47088 47089 47090 47091 47092 47093 47094 47095 47096 47097 47098 47099 47100 47101 47102 47103 47104 47105 47106 47107 47108 47109 47110 47111 47112 47113 47114 47115 47116 47117 47118 47119 47120 47121 47122 47123 47124 47125 47126 47127 47128 47129 47130 47131 47132 47133 47134 47135 47136 47137 47138 47139 47140 47141 47142 47143 47144 47145 47146 47147 47148 47149 47150 47151 47152 47153 47154 47155 47156 47157 47158 47159 47160 47161 47162 47163 47164 47165 47166 47167 47168 47169 47170 47171 47172 47173 47174 47175 47176 47177 47178 47179 47180 47181 47182 47183 47184 47185 47186 47187 47188 47189 47190 47191 47192 47193 47194 47195 47196 47197 47198 47199 47200 47201 47202 47203 47204 47205 47206 47207 47208 47209 47210 47211 47212 47213 47214 47215 47216 47217 47218 47219 47220 47221 47222 47223 47224 47225 47226 47227 47228 47229 47230 47231 47232 47233 47234 47235 47236 47237 47238 47239 47240 47241 47242 47243 47244 47245 47246 47247 47248 47249 47250 47251 47252 47253 47254 47255 47256 47257 47258 47259 47260 47261 47262 47263 47264 47265 47266 47267 47268 47269 47270 47271 47272 47273 47274 47275 47276 47277 47278 47279 47280 47281 47282 47283 47284 47285 47286 47287 47288 47289 47290 47291 47292 47293 47294 47295 47296 47297 47298 47299 47300 47301 47302 47303 47304 47305 47306 47307 47308 47309 47310 47311 47312 47313 47314 47315 47316 47317 47318 47319 47320 47321 47322 47323 47324 47325 47326 47327 47328 47329 47330 47331 47332 47333 47334 47335 47336 47337 47338 47339 47340 47341 47342 47343 47344 47345 47346 47347 47348 47349 47350 47351 47352 47353 47354 47355 47356 47357 47358 47359 47360 47361 47362 47363 47364 47365 47366 47367 47368 47369 47370 47371 47372 47373 47374 47375 47376 47377 47378 47379 47380 47381 47382 47383 47384 47385 47386 47387 47388 47389 47390 47391 47392 47393 47394 47395 47396 47397 47398 47399 47400 47401 47402 47403 47404 47405 47406 47407 47408 47409 47410 47411 47412 47413 47414 47415 47416 47417 47418 47419 47420 47421 47422 47423 47424 47425 47426 47427 47428 47429 47430 47431 47432 47433 47434 47435 47436 47437 47438 47439 47440 47441 47442 47443 47444 47445 47446 47447 47448 47449 47450 47451 47452 47453 47454 47455 47456 47457 47458 47459 47460 47461 47462 47463 47464 47465 47466 47467 47468 47469 47470 47471 47472 47473 47474 47475 47476 47477 47478 47479 47480 47481 47482 47483 47484 47485 47486 47487 47488 47489 47490 47491 47492 47493 47494 47495 47496 47497 47498 47499 47500 47501 47502 47503 47504 47505 47506 47507 47508 47509 47510 47511 47512 47513 47514 47515 47516 47517 47518 47519 47520 47521 47522 47523 47524 47525 47526 47527 47528 47529 47530 47531 47532 47533 47534 47535 47536 47537 47538 47539 47540 47541 47542 47543 47544 47545 47546 47547 47548 47549 47550 47551 47552 47553 47554 47555 47556 47557 47558 47559 47560 47561 47562 47563 47564 47565 47566 47567 47568 47569 47570 47571 47572 47573 47574 47575 47576 47577 47578 47579 47580 47581 47582 47583 47584 47585 47586 47587 47588 47589 47590 47591 47592 47593 47594 47595 47596 47597 47598 47599 47600 47601 47602 47603 47604 47605 47606 47607 47608 47609 47610 47611 47612 47613 47614 47615 47616 47617 47618 47619 47620 47621 47622 47623 47624 47625 47626 47627 47628 47629 47630 47631 47632 47633 47634 47635 47636 47637 47638 47639 47640 47641 47642 47643 47644 47645 47646 47647 47648 47649 47650 47651 47652 47653 47654 47655 47656 47657 47658 47659 47660 47661 47662 47663 47664 47665 47666 47667 47668 47669 47670 47671 47672 47673 47674 47675 47676 47677 47678 47679 47680 47681 47682 47683 47684 47685 47686 47687 47688 47689 47690 47691 47692 47693 47694 47695 47696 47697 47698 47699 47700 47701 47702 47703 47704 47705 47706 47707 47708 47709 47710 47711 47712 47713 47714 47715 47716 47717 47718 47719 47720 47721 47722 47723 47724 47725 47726 47727 47728 47729 47730 47731 47732 47733 47734 47735 47736 47737 47738 47739 47740 47741 47742 47743 47744 47745 47746 47747 47748 47749 47750 47751 47752 47753 47754 47755 47756 47757 47758 47759 47760 47761 47762 47763 47764 47765 47766 47767 47768 47769 47770 47771 47772 47773 47774 47775 47776 47777 47778 47779 47780 47781 47782 47783 47784 47785 47786 47787 47788 47789 47790 47791 47792 47793 47794 47795 47796 47797 47798 47799 47800 47801 47802 47803 47804 47805 47806 47807 47808 47809 47810 47811 47812 47813 47814 47815 47816 47817 47818 47819 47820 47821 47822 47823 47824 47825 47826 47827 47828 47829 47830 47831 47832 47833 47834 47835 47836 47837 47838 47839 47840 47841 47842 47843 47844 47845 47846 47847 47848 47849 47850 47851 47852 47853 47854 47855 47856 47857 47858 47859 47860 47861 47862 47863 47864 47865 47866 47867 47868 47869 47870 47871 47872 47873 47874 47875 47876 47877 47878 47879 47880 47881 47882 47883 47884 47885 47886 47887 47888 47889 47890 47891 47892 47893 47894 47895 47896
|
2011-02-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 54524 - Allow JSObject to fully utilize cell's capacity for inline storage.
Currently JSObject is both directly instantiated for regular JS objects, and
derived to implement subtypes. A consequence of this is that we need to ensure
that sufficient space from the cell is left unused and available for any data
members that will be introduced by subclasses of JSObject. By restructuring
the internal storage array out of JSObject we can increase the size in the
internal storage for regular objects.
Add classes JSFinalObject and JSNonFinalObject. JSNonFinalObject retains as
much additional capacity as is currently available to allow for data members
in subclasses. JSFinalObject utilizes all available space for internal storage,
and only allows construction through JSFinalObject::create().
* bindings/js/JSDOMWindowShell.h:
Update JSObject -> JSNonFinalObject.
2011-02-16 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
REGRESSION: Use after free in WebCore::RenderCounter::destroyCounterNode
https://bugs.webkit.org/show_bug.cgi?id=54478
Test: fast/css/counters/render-tree-reorg-crash.html
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
Fixed typo. The code was still walking sometimes the renderer tree
instead of the element tree as intended.
2011-02-16 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Inject auto increment keys via key path on insertion
https://bugs.webkit.org/show_bug.cgi?id=54457
Inject auto increment keys via key path for object stores using key
path and auto increment.
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::LocalContext::getNthValueOnKeyPath):
(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore::injectIDBKeyIntoSerializedValue):
* bindings/v8/IDBBindingUtilities.h:
* platform/chromium/PlatformBridge.h:
* storage/IDBKeyPathBackendImpl.cpp:
(IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):
* storage/IDBKeyPathBackendImpl.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::injectKeyIntoKeyPath):
(WebCore::IDBObjectStoreBackendImpl::selectKeyForPut):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
* storage/IDBObjectStoreBackendImpl.h:
* storage/chromium/IDBKeyPathBackendImpl.cpp:
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):
2011-02-16 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] Add support for layoutTestController.setWillSendRequestClearHeader
https://bugs.webkit.org/show_bug.cgi?id=54537
Headers removed from the SoupMessage should be also removed from
the ResourceRequest when updating the latter from the former.
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessage):
2011-02-16 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: split all the functions of Inspector backend API by domain.
https://bugs.webkit.org/show_bug.cgi?id=54558
We have a number of functions from different domains in single instance of InspectorBackend.
It'd be better to split the functions by their domains.
As example 'evaluate' will be moved from InspectorBackend to RuntimeAgent container.
* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.evaluateInTargetWindow):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._reloadResources):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
(WebInspector.DOMBreakpoint.prototype._enable):
(WebInspector.DOMBreakpoint.prototype._disable):
(WebInspector.EventListenerBreakpoint.prototype._enable):
(WebInspector.EventListenerBreakpoint.prototype._disable):
(WebInspector.XHRBreakpoint.prototype._enable):
(WebInspector.XHRBreakpoint.prototype._disable):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.createForId):
(WebInspector.CSSStyleSheet.prototype.setText):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.requestClearMessages):
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._deleteCookie):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.getChildNodesAsync):
(WebInspector.DOMAgent.prototype.setAttributeAsync):
(WebInspector.DOMAgent.prototype.removeAttributeAsync):
(WebInspector.DOMAgent.prototype.setTextNodeValueAsync):
(WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
(WebInspector.Cookies.getCookiesAsync):
(WebInspector.EventListeners.getEventListenersForNodeAsync):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.prototype.getEntries):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
* inspector/front-end/Database.js:
(WebInspector.Database.prototype.getTableNames):
(WebInspector.Database.prototype.executeSql):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.enableDebugger):
(WebInspector.DebuggerModel.prototype.disableDebugger):
(WebInspector.DebuggerModel.prototype.continueToLocation):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype.removeBreakpoint):
(WebInspector.DebuggerModel.prototype.editScriptSource):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.setDocument):
(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.performSearch):
(WebInspector.ElementsPanel.prototype.handleCopyEvent):
(WebInspector.ElementsPanel.prototype.setSearchingForNode):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
():
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
(WebInspector.ExtensionServer.prototype._onReload):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.reset):
(WebInspector.NetworkManager.prototype.requestContent):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView):
(WebInspector.CPUProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._clearProfiles):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._toggleProfiling):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.resolveNode):
(WebInspector.RemoteObject.prototype.getProperties):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.pushNodeToFrontend):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.onselect):
(WebInspector.FrameTreeElement.prototype.set hovered):
(WebInspector.FrameResourceTreeElement.prototype.ondblclick):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.requestSource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
(WebInspector.ScriptsPanel.prototype._togglePause):
(WebInspector.ScriptsPanel.prototype._stepOverClicked):
(WebInspector.ScriptsPanel.prototype._stepIntoClicked):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):
(WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._hidePopup):
* inspector/front-end/TestController.js:
(WebInspector.TestController.prototype.notifyDone):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
* inspector/front-end/inspector.js:
(WebInspector.highlightDOMNode):
(WebInspector.doLoadedDone):
(WebInspector.openResource):
(WebInspector.documentKeyDown):
2011-02-16 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831
Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.
Test: platform/gtk/accessibility/document-reload-events.html
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_name): Returns the current document's title
as fallback mechanism for webArea objects.
(webkit_accessible_detach): Emit 'state-change::defunct' function
as soon as the wrapper is detached from the related core object.
2011-02-15 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Pixel tests differences on 10.6.6 32bit vs. 64bit
https://bugs.webkit.org/show_bug.cgi?id=54474
When generating a SVG pixel test baseline with a vanilla 10.6.6 installation on a 32bit machine (Core Duo MBP)
and comparing the run with a software-identical 64bit machine (Core 2 Duo MBP), there are about 250 differences.
These fall in two categories:
a) 1px differences in text AA, or when drawing circles (all _below_ a tolerance of 0.01). Only visible in the subtracted difference image.
The reason is probably CGFloat being typedefed to double on 64bit machines, and float on 32bit machines.
AffineTransform stores doubles, so on 32bit machines we loose precision from AffineTransform -> CGAffineTransform.
b) Failures >0.1% (text origin/scale is slightly different, user-visible).
Caused by several sources of numerical instabilities within the SVG rendering code.
-> SVGPreserveAspectRatio::getCTM() computes an AffineTransform using doubles as input parameters, but floats are passed (like everywhere else in SVG).
This method is used to compute the viewBox AffineTransform, that affects the rendering of every content in the document. RenderSVGRoot concats
this transformation matrix to the GraphicsContext CTM, resulting in a source of numerical imprecision.
-> SVGInlineTextBox::paintTextWithShadows() calculates a scaling factor for text, to scale up the specified font size, to the actual on-screen size.
SVGInlineTextBox uses the scaled Font object, to draw in an unscaled context, that gets scaled up again afterwards.
context->scale(1 / scalingFactor); scaledFont.drawText(); context->scale(scalingFactor);
To remove the scale from the current GraphicsContext CTM, "context->scale(FloatSize(1 / scalingFactor, ...)" is used. As AffineTransform stores
doubles internally, it's likely that "context->scale(FloatSize(1 / ctm.a(), .." doesn't give you a matrix with a=1, but something close to 1.
Using "context->concatCTM(AffineTransform().scale(1 / ctm.a(), ..." could be used as workaround, to preserve double precision.
Fixing that brings us down to just a few pixel tests that differ between 32 & 64bit. There is still numerical imprecision, as floating-point
number representations aren't always precise. Unfortunately CoreGraphics doesn't provide a public way to just set a CTM, it only allows to concat them.
Fortunately CGContextSetCTM() is available, as private method, that allows me to switch the context CTM to any arbitary CGAffineTransform.
-> Add GraphicsContext::setCTM(const AffineTransform&) and implement it for all platforms (each explicitely exposes a 'setCTM' concept, except CG)
Use CGContextSetCTM() for CG, which appears to be present since at least 10.4, Cairo is using it for the same purpose since some years!
-> Instead of scaling the GraphicsContext before drawing text, grab the current CTM using context->getCTM(), scale it by '1 / scalingFactor'
normalize the transform (look for values close to 0/1 using float precision, and round!), and assign it using context->setCTM(normalizedTransform).
After drawing, just switch back to the preserved original CTM, both operations need GraphicsContext::setCTM.
This fixes all pixel test differences between 32/64 bit machines that fall into category b).
The use of GraphicsContext::setCTM() allows to switch between arbitary context transformations _without_ inducing accumulated rounding imprecision.
These combined patches fix the pixel test baseline changes.
Updated existing Snow Leopard pixel test baseline with a 32bit machine, passes here with tolerance 0.
The 64bit machine passes the baseline with tolerance 0.01.
* platform/graphics/GraphicsContext.h: Add setCTM(const AffineTransform&) method.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setCTM): Implement setCTM.
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setCTM): Ditto.
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::setCTM): Ditto.
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::setCTM): Ditto.
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::setCTM): Ditto.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::setCTM): Ditto.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setCTM): Ditto.
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
(WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
(WebCore::GraphicsContext::setCTM):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::setCTM): Ditto.
* rendering/svg/SVGInlineTextBox.cpp: Use setCTM() to switch to a scale-free AffineTransform, and also to switch back to the original CTM after rendering text.
(WebCore::normalizeTransform):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
(WebCore::SVGInlineTextBox::paintTextWithShadows):
* svg/SVGPreserveAspectRatio.cpp: s/double/float/.
(WebCore::SVGPreserveAspectRatio::getCTM):
* svg/SVGPreserveAspectRatio.h:
* svg/SVGSVGElement.cpp: Simplify viewport() code, avoid using doubles.
(WebCore::SVGSVGElement::viewport):
2011-02-16 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
SVGAnimateElement incorrectly uses Color::nameForRenderTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=54547
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::applyResultsToTarget):
2011-02-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Landing detailed heap snapshots, part 3.
https://bugs.webkit.org/show_bug.cgi?id=54385
Provide node classes for data grid views:
- summary -- list of objects by constuctor;
- diff -- summaries btw two snapshots;
- explorer -- explore heap graph;
- dominators tree;
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/DetailedHeapshotGridNodes.js: Added.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotFilteredOrderedIterator):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.incInstancesCount):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get instancesCount):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.next):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.resetInstancesCount):
(WebInspector.HeapSnapshotEdgesProvider):
(WebInspector.HeapSnapshotNodesProvider):
* inspector/front-end/PleaseWaitMessage.js:
(WebInspector.PleaseWaitMessage.prototype.get instance):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-02-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78655.
http://trac.webkit.org/changeset/78655
https://bugs.webkit.org/show_bug.cgi?id=54543
Causes too many test failures in chromium (Requested by
mnaganov on #webkit).
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
* dom/EventTarget.cpp:
* dom/EventTarget.h:
* storage/IDBRequest.cpp:
* storage/IDBRequest.h:
2011-02-16 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move Database and DOMStorage related things from InspectorAgent to the corresponding agents.
https://bugs.webkit.org/show_bug.cgi?id=54455
Some set of instrumentation calls should work even if we have no InspectorFrontend instance and corresponding agents.
At the moment we are using InspectorAgent instance for such calls.
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::pushDataCollectedOffline):
(WebCore::InspectorAgent::didCommitLoad):
* inspector/InspectorAgent.h:
(WebCore::InspectorOfflineResourcesBase::~InspectorOfflineResourcesBase):
(WebCore::InspectorOfflineResourcesBase::InspectorOfflineResourcesBase):
(WebCore::InspectorAgent::databaseAgentResources):
(WebCore::InspectorAgent::domStorageAgentResources):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::Resources::clear):
(WebCore::InspectorDOMStorageAgent::Resources::pushDataCollectedOffline):
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::createOfflineStorage):
(WebCore::InspectorDOMStorageAgent::selectDOMStorage):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
* inspector/InspectorDOMStorageAgent.h:
(WebCore::InspectorDOMStorageAgent::create):
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::Resources::clear):
(WebCore::InspectorDatabaseAgent::Resources::pushDataCollectedOffline):
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::createOfflineStorage):
(WebCore::InspectorDatabaseAgent::databaseForId):
(WebCore::InspectorDatabaseAgent::selectDatabase):
* inspector/InspectorDatabaseAgent.h:
(WebCore::InspectorDatabaseAgent::create):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
2011-02-15 John Sullivan <sullivan@apple.com>
Reviewed by Antti Koivisto.
Dan Bernstein came up with this fix while we debugged it. I just typed.
https://bugs.webkit.org/show_bug.cgi?id=54532
On platforms without platformWidgets, going Back to a scrolled page
draws at the top-left before drawing at the restored scroll position
<rdar://problem/8998838>
* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
Don't send the didFirstLayout and didFirstVisuallyNonEmptyLayout callbacks
for nested layouts. Doing so was causing ScrollView::setScrollPosition()
to short-circuit.
2011-02-15 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed.
[Qt][V8] Buildfix. Add missing USE(JSC) guard.
* plugins/qt/PluginViewQt.cpp:
2011-02-15 Ami Fischman <fischman@chromium.org>
Reviewed by David Levin.
Remove the artificial -32px shift for media controls in mediaDocuments
so that they overlap the canvas as they do in non-mediaDocuments.
This also fixes test_shell failing to update the media slider (see
linked crbug below).
https://bugs.webkit.org/show_bug.cgi?id=27798
http://crbug.com/72623
Test: media/video-controls-in-media-document.html
Added a render test that asserts that the controls show up in the
expected spot (0,208) instead of below the canvas (0,240).
* css/mediaControlsChromium.css:
2011-02-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Extract a function to process ancestor and their sibling nodes from processContents
https://bugs.webkit.org/show_bug.cgi?id=54425
Extracted processAncestorsAndTheirSiblings.
* dom/Range.cpp:
(WebCore::Range::processContents): Calls processContents.
(WebCore::Range::processAncestorsAndTheirSiblings): Extracted from processContents.
* dom/Range.h:
2011-02-15 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Rendering error of spin buttons on layers
https://bugs.webkit.org/show_bug.cgi?id=54427
Test: fast/forms/input-appearance-spinbutton-layer.html
* rendering/RenderThemeChromiumWin.cpp:
Add checks for multiple ThemePainter instances.
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
Avoid to create multiple ThemePainter instances.
2011-02-15 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix race condition in JavaScriptAudioNode
https://bugs.webkit.org/show_bug.cgi?id=54518
No new tests since audio API is not yet implemented.
* webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::process):
2011-02-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Throwing in an IndexedDB error or success event should lead to the transaction aborting
https://bugs.webkit.org/show_bug.cgi?id=54249
When an exception is thrown but not handled within an IDBRequests success/error event,
we should abort the transaction.
Test: storage/indexeddb/exception-in-event-aborts.html
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
* dom/EventTarget.cpp:
(WebCore::EventTarget::uncaughtExceptionInEventHandler):
* dom/EventTarget.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
* storage/IDBRequest.h:
2011-02-15 Ian Henderson <ianh@apple.com>
Reviewed by Darin Adler.
To determine image properties, CG allocates memory which isn't included in CachedImage's decoded size
https://bugs.webkit.org/show_bug.cgi?id=53281
When determining properties of an image (such as its size), CG ends up
decoding part of the image. This patch adds accounting for this extra
decoded size so a cache prune can clean up the allocations.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::destroyMetadataAndNotify):
Clearing the source destroys the extra decoded data. Report this
change in decoded size to the image observer.
(WebCore::BitmapImage::cacheFrame):
The first decoded frame subsumes the data decoded when determining
image properties, so we subtract it out here.
(WebCore::BitmapImage::didDecodeProperties):
Reports the extra decoded size to the image's observer.
(WebCore::BitmapImage::size):
(WebCore::BitmapImage::currentFrameSize):
(WebCore::BitmapImage::getHotSpot):
(WebCore::BitmapImage::frameCount):
(WebCore::BitmapImage::isSizeAvailable):
(WebCore::BitmapImage::repetitionCount):
* platform/graphics/BitmapImage.h:
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::bytesDecodedToDetermineProperties):
The default value is 0 to match the current behavior on other
platforms.
* platform/graphics/ImageSource.h:
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::bytesDecodedToDetermineProperties):
Add a constant value for bytesDecodedToDetermineProperties(), measured
by tracing malloc/calloc calls while asking an image source for its
properties.
2011-02-15 James Robinson <jamesr@chromium.org>
Reviewed by Alexey Proskuryakov.
requestAnimationFrame callbacks should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53188
requestAnimationFrame callbacks shouldn't fire while a modal dialog is up (like a window.alert()).
This matches Firefox and other async APIs. This patch moves the callback servicing into its own
controller class which receives notifications on suspend/resume.
Test: fast/animation/request-animation-frame-during-modal.html
* WebCore.gypi:
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setJavaScriptPaused):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::suspendScriptedAnimationControllerCallbacks):
(WebCore::Document::resumeScriptedAnimationControllerCallbacks):
(WebCore::Document::webkitRequestAnimationFrame):
(WebCore::Document::webkitCancelRequestAnimationFrame):
(WebCore::Document::serviceScriptedAnimations):
* dom/Document.h:
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
* dom/ScriptedAnimationController.cpp: Added.
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::suspend):
(WebCore::ScriptedAnimationController::resume):
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
* dom/ScriptedAnimationController.h: Added.
(WebCore::ScriptedAnimationController::create):
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2011-02-14 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Add initial support for per-origin quotas to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54421
Add support for non-persistent per-origin quotas. If one is
specified, it overrides the default.
No tests as this is only exposed via the Chromium webkit API.
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::setQuota):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
2011-02-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
XSLT with output method HTML and images crashes in debug mode
https://bugs.webkit.org/show_bug.cgi?id=54462
http://trac.webkit.org/changeset/75577 created Document::setContent but
didn't notice that the code paths combined into Document::setContent
were subtly different. In particular, some of the code paths called
parser->finish() whereas other did not.
The difference is that an explicit call to parser->finish() is required
in the case where there is no frame because explicitClose doesn't call
endIfNotLoadingMainResource if there is no frame. This patch moves
that logic inside explicitClose, which is more natural.
This patch also removes removeAllChildren, which has not effect in this
situation and should never have been added in the first place.
Test: fast/parser/xslt-with-html.xml
* dom/Document.cpp:
(WebCore::Document::setContent):
(WebCore::Document::explicitClose):
2011-02-15 Oliver Hunt <oliver@apple.com>
Fix EFL build for
https://bugs.webkit.org/show_bug.cgi?id=54415
* CMakeLists.txt:
2011-02-15 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/54487> Minor header clean up in RenderLayerBacking.cpp
Reviewed by Darin Adler.
* rendering/RenderLayerBacking.cpp: Remove unused
WebGLRenderingContext.h header, and move GraphicsContext3D.h
into a #if ENABLE(WEBGL) || ENABLE(ACCELERATED_2D_CANVAS)/#endif
block.
2011-02-14 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough and Geoff Garen.
Refactor handles and weak pointers to become nicer and more automatic
https://bugs.webkit.org/show_bug.cgi?id=54415
Update WebCore to use the new Global<> type rather than ProtectedJSValue
and gc[Un]Protect. Also update to use new WeakGCPtr APIs, and remove now
unnecessary destructors.
* ForwardingHeaders/collector/handles/Global.h: Added.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
* bindings/js/JSCustomVoidCallback.h:
* bindings/js/JSDOMBinding.cpp:
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDataGridDataSource.h:
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::setWrapper):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::executeFunctionInContext):
* bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptCachedFrameData.h:
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptArguments):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createWindowShell):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::attachDebugger):
* bindings/js/ScriptController.h:
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptCallback::call):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptObject::ScriptObject):
* bindings/js/ScriptObject.h:
* bindings/js/ScriptState.cpp:
(WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr):
(WebCore::ScriptStateProtectedPtr::get):
* bindings/js/ScriptState.h:
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::deserialize):
* bindings/js/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::hasNoValue):
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::ScriptWrappable):
(WebCore::ScriptWrappable::setWrapper):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
(WebCore::WorkerScriptController::evaluate):
* bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerContextWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
* bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::Instance):
(JSC::Bindings::Instance::~Instance):
(JSC::Bindings::Instance::willDestroyRuntimeObject):
(JSC::Bindings::Instance::willInvalidateRuntimeObject):
* bridge/jsc/BridgeJSC.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::invalidate):
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::RootObject):
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::globalObject):
(JSC::Bindings::RootObject::updateGlobalObject):
* bridge/runtime_root.h:
* dom/EventListener.h:
* dom/EventTarget.h:
(WebCore::EventTarget::markJSEventListeners):
* xml/XMLHttpRequest.cpp:
Qt bindings courtesy of Csaba Osztrogonác
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
* bridge/qt/qt_runtime.h:
2011-02-15 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Autocorrection should respect undo.
https://bugs.webkit.org/show_bug.cgi?id=52221
<rdar://problem/8663399>
Manual test: manual-tests/autocorrection/undo-autocorrection.html
When user undoes an autocorrection, we need to do four things:
1. Revert the change in text that has been made by correction.
2. Revert the selection to pre-correction state so that user can immediately continue typing.
3. Add appropriate markers to reverted text so that it won't be corrected again and/or shown
as misspelled.
4. If applicable, notify spell checking service to record this reversion.
To achieve these, this patch introduces following changes:
1. Created SpellingCorrectionCommand so that correction can be undone in similar way as any
other editing command. SpellingCorrectionCommand is a composition of SetSelectionCommand,
SpellingCorrectionRecordUndoCommand and ReplaceSelectionCommand.
2. Created SetSelectionCommand so that undo command can restore selection state.
3. Added member function recordAutocorrectionResponse() to editor client.
To improve readability, this patch also consolidates various boolean arguments in SelectionController::setSelection()
and ReplaceSelectionCommand::ReplaceSelectionCommand(). These boolean arguments have been
replaced by enum variable.
* WebCore.exp.in: Updated for changes in Editor and ReplaceSelectionCommand.
* WebCore.xcodeproj/project.pbxproj: Updated for new source files.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs): Adopted new signature of ReplaceSelectionCommand::create().
* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment): Ditto.
(WebCore::Editor::unappliedEditing): Cleaned up trailing whitespace.
(WebCore::Editor::reappliedEditing): Ditto.
(WebCore::Editor::selectComposition): Adopted new signature of SelectionController::setSelection().
(WebCore::Editor::confirmComposition): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Rearranged code to reduce the
level of deeply nested if statement. Adopted SpellingCorrectionCommand.
(WebCore::Editor::applyCorrectionPanelInfo): Adopted SpellingCorrectionCommand.
(WebCore::Editor::unappliedSpellCorrection): Function for adding markers to reverted text and
for notifiying editor client about undone correction.
(WebCore::Editor::changeSelectionAfterCommand): Adopted new signature of SelectionController::setSelection().
(WebCore::Editor::respondToChangedSelection): Use SelectionController::SetSelectionOptions
instead of boolean variables.
* editing/Editor.h: Added Editor::unappliedSpellCorrection().
* editing/EditorCommand.cpp:
(WebCore::executeInsertFragment): Adopted new signature of ReplaceSelectionCommand::create().
* editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::doApply): Ditto.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Replaced all boolean arguments
with an enum value.
* editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::create): Ditto.
* editing/SelectionController.cpp: Adopted new signature of SelectionController::setSelection().
(WebCore::SelectionController::moveTo):
(WebCore::SelectionController::setSelection):
(WebCore::SelectionController::respondToNodeModification):
(WebCore::SelectionController::setBase):
(WebCore::SelectionController::setExtent):
(WebCore::SelectionController::setSelectedRange):
* editing/SelectionController.h:
(WebCore::SelectionController::setSelection): Replaced all boolean arguments with an enum value.
* editing/SetSelectionCommand.cpp: Added.
(WebCore::SetSelectionCommand::SetSelectionCommand):
(WebCore::SetSelectionCommand::doApply):
(WebCore::SetSelectionCommand::doUnapply):
* editing/SetSelectionCommand.h: Added.
(WebCore::SetSelectionCommand::create):
* editing/mac/SpellingCorrectionCommand.cpp: Added.
(WebCore::SpellingCorrectionRecordUndoCommand::create):
(WebCore::SpellingCorrectionRecordUndoCommand::SpellingCorrectionRecordUndoCommand):
(WebCore::SpellingCorrectionRecordUndoCommand::doApply):
(WebCore::SpellingCorrectionRecordUndoCommand::doUnapply):
(WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand):
(WebCore::SpellingCorrectionCommand::doApply):
* editing/mac/SpellingCorrectionCommand.h: Added.
(WebCore::SpellingCorrectionCommand::create):
* loader/EmptyClients.h: Updated for the new function declared in EditorClient.
(WebCore::EmptyEditorClient::recordAutocorrectionResponse):
* manual-tests/autocorrection/undo-autocorrection.html: Added.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Adopted new signature of ReplaceSelectionCommand::create().
* page/DragController.cpp:
(WebCore::DragController::concludeEditDrag): Ditto.
* page/EditorClient.h: Added EditorClient::recordAutocorrectionResponse().
2011-02-15 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Speculative fix for <rdar://problem/8998498> CrashTracer: [USER]
8 crashes in WebProcess calling setOverlayScrollerState:forceImmediately:
My best guess is that this is crashing because
willRemoveVerticalScrollbar()/Horizontal was not being called
properly from the RenderLayer destructor.
Call willRemoveVerticalScrollbar()/Horizontal from destroyScrollbar()
so that all current and future scrollbar-destroyers will properly
call this function. And only do it for native scrollers.
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderListBox::destroyScrollbar):
For consistency's sake, I also moved didAddVerticalScrollbar()
/Horizontal to createScrollbar(). Again, only call for native
scrollers.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderListBox::createScrollbar):
These functions no longer call didAdd/willRemove.
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::setHasVerticalScrollbar):
Remove unnecessary ScrollableArea::-prefix
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
2011-02-15 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by David Kilzer.
Cleanup Some Potential ENABLE(INSPECTOR) Related Building Issues
https://bugs.webkit.org/show_bug.cgi?id=54048
* WebCore.exp.in: moved inspector only export into ENABLE(INSPECTOR) block.
* bindings/js/ScriptHeapSnapshot.h: include no longer needed.
2011-02-15 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
[chromium] clearRect() is incorrect in accelerated 2D canvas.
https://bugs.webkit.org/show_bug.cgi?id=54497
When doing GPU-Canvas2D clearRect() using the fast path (glClear()),
we were not correctly converting from canvas to screen coordinates.
Fixed by inverting the rectangle in Y, and changing
SharedGraphicsContext3D::scissor to take glScissor-like parameters.
Covered by fast/canvas/canvas-strokeRect.html.
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::clearRect):
Flip the Y coord of the rectangle passed to scissor().
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::scissor):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
Give scissor() the same param types as GraphicsContext3D::scissor().
2011-02-15 Pratik Solanki <psolanki@apple.com>
Move WTF_USE_CFNETWORK to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=54168
Reviewed by Darin Adler.
* config.h: Remove WTF_USE_CFNETWORK.
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
Renamed DOMTimer::minTimerInterval and setMinTimerInterval to
defaultMinTimerInterval and setDefaultMinTimerInterval, made them
private and exposed them via Settings::defaultMinDOMTimerInterval
and setDefaultMinDOMTimerInterval. Added new
Settings::setMinDOMTimerInterval and minDOMTimerInterval.
The storage for the minimum timer interval currently lives in the
Page, though this could be moved to the Settings object if
desired. The accessor methods on the Page are private and exposed
to Settings by making Settings a friend, so the abstraction
barrier is clear at the API level.
Adjusting the interval both upward and downward may cause the fire
times of the active timers on the page to be adjusted, if they
would be affected by the clamping value. This is needed to reduce
latency when bringing a tab to the foreground, in particular if
the minimum timer interval was decreased from a very high value to
a very low value.
A new method, setMinimumTimerInterval, has been added to
LayoutTestController, implemented in all ports of DumpRenderTree,
and used in new layout tests.
Ideally changing the page's minimum timer interval would affect
dedicated workers, but this is too much to do in an initial patch,
so a FIXME has been added.
Tested with:
- The new layout tests on the WebKit Mac and Chromium (Mac,
Linux) DRT ports.
- Hooked up the new API in Chromium and ran some simple manual
tests.
Tests: fast/dom/timer-increase-min-interval-and-reset-part-1.html
fast/dom/timer-increase-min-interval-and-reset-part-2.html
fast/dom/timer-increase-min-interval.html
fast/dom/timer-increase-then-decrease-min-interval.html
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::minimumTimerInterval):
* dom/Document.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::adjustMinimumTimerInterval):
(WebCore::ScriptExecutionContext::minimumTimerInterval):
* dom/ScriptExecutionContext.h:
* page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::fired):
(WebCore::DOMTimer::adjustMinimumTimerInterval):
(WebCore::DOMTimer::intervalClampedToMinimum):
* page/DOMTimer.h:
(WebCore::DOMTimer::defaultMinTimerInterval):
(WebCore::DOMTimer::setDefaultMinTimerInterval):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setMinimumTimerInterval):
(WebCore::Page::minimumTimerInterval):
* page/Page.h:
* page/Settings.cpp:
(WebCore::Settings::setDefaultMinDOMTimerInterval):
(WebCore::Settings::defaultMinDOMTimerInterval):
(WebCore::Settings::setMinDOMTimerInterval):
(WebCore::Settings::minDOMTimerInterval):
* page/Settings.h:
* platform/Timer.h:
(WebCore::TimerBase::augmentFireInterval):
(WebCore::TimerBase::augmentRepeatInterval):
2011-02-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Beth Dakin.
Fix scrollbar rendering crash when rendered into a layer
https://bugs.webkit.org/show_bug.cgi?id=54494
Remove code added in r78394 which was intended to find out whether
a scrollbar was being rendered into a compositing layer. r78612
obviated the need for this code.
* page/FrameView.h:
* platform/ScrollableArea.h:
* rendering/RenderLayer.cpp:
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
* rendering/RenderListBox.h:
2011-02-15 Simon Fraser <simon.fraser@apple.com>
Let Xcode have its way with the project.
* WebCore.xcodeproj/project.pbxproj:
2011-02-15 Simon Fraser <simon.fraser@apple.com>
Fix Mac builds that don't use rubber-band scrolling
by moving m_drawingIntoLayer out of the #ifdef.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
2011-02-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Freetype] Better map CSS font weight to Fontconfig font weight
https://bugs.webkit.org/show_bug.cgi?id=54323
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::fontWeightToFontconfigWeight): Added this helper to map between CSS and
Fontconfig font weights.
(WebCore::FontCache::createFontPlatformData): Use the new helper instead of just
deciding between bold and regular.
2011-02-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Fix scrollbar rendering crash when rendered into a layer
https://bugs.webkit.org/show_bug.cgi?id=54494
The scroller delegate was failing to return a layer in a case
where the scroller was still rendering into a GraphicsLayer, because
even though WebCore had switched out of compositing mode, the
DrawingAreaImpl was still rendering into its nonCompositedContent
layer. This happens when the m_exitCompositingTimer timer hasn't fired
yet.
The fix is to track whether we're drawing into a layer via the
GraphicsContext, rather than asking about compositing layers.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setIsCALayerContext):
(WebCore::GraphicsContext::isCALayerContext):
Getter and setter for the bit that says if we're rendering into a CALayer.
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
Store a bool for whether this context targets a layer.
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents): Call setIsCALayerContext(true).
* platform/mac/ScrollAnimatorMac.h:
(WebCore::ScrollAnimatorMac::setIsDrawingIntoLayer):
(WebCore::ScrollAnimatorMac::isDrawingIntoLayer):
New methods to get and set a flag that says when we're
drawing into a layer, so that the delegate can get at this state.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate layer]): Use isDrawingIntoLayer()
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Init the flag.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar): Whitespace.
(WebCore::ScrollbarThemeMac::paint): Push the "isDrawingIntoLayer"
state down onto ScrollAnimatorMac, getting it from the GraphicsContext.
2011-02-15 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add NPP_GetSitesWithData and NPP_URLRedirectNotify to the NPAPI headers
https://bugs.webkit.org/show_bug.cgi?id=54481
We should really sync all headers with the NPAPI repository, but doing that
lead to build errors so I just added what was needed.
* bridge/npapi.h:
Add new functions.
* bridge/nptypes.h:
Sync with the official NPAPI repository, adding 64-bit integer types and
removing a duplicate license header.
* plugins/npfunctions.h:
Add new functions.
2011-02-15 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=54486
Crashes under CachedResourceLoader::revalidateResource
CachedResourceLoader might get deleted from under one of its methods.
Try to catch a more informative crash stack.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::requestPreload):
* loader/cache/CachedResourceLoader.h:
2011-02-15 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Optimize Color::serialized()
https://bugs.webkit.org/show_bug.cgi?id=54452
Apply the optimizations from CSSPrimitiveValue::cssText() [CSS_RGBCOLOR]
to Color::serialized() - build the serialized color strings manually
instead of using String::format().
* platform/graphics/Color.cpp:
(WebCore::appendHexNumber):
(WebCore::Color::serialized):
2011-02-15 Jarred Nicholls <jarred@sencha.com>
Reviewed by Alexey Proskuryakov.
XMLHttpRequest::abort() doesn't clear response data
https://bugs.webkit.org/show_bug.cgi?id=54118
Properly clear all buffer data on abort, so no memory hangs around unnecessarily.
No new tests because there is no observable effect except for less memory used.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::abort):
2011-02-15 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Rename Color::name() to Color::nameForRenderTreeAsText()
https://bugs.webkit.org/show_bug.cgi?id=54464
Color::name() returns the color as either #RRGGBB or #RRGGBBAA.
Since the latter is not a valid CSS color, it can't be re-parsed
by WebKit, and should only be used in DRT dumps.
* editing/ApplyStyleCommand.cpp:
(WebCore::StyleChange::extractTextStyles):
* page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
* platform/graphics/Color.cpp:
(WebCore::Color::nameForRenderTreeAsText):
* platform/graphics/Color.h:
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::externalRepresentation):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
(WebCore::writeRenderSVGTextBox):
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::applyResultsToTarget):
* svg/SVGColor.cpp:
(WebCore::SVGColor::cssText):
2011-02-15 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Andreas Kling.
[Qt] Typo fix.
No new tests needed.
* WebCore.pro: add missing ASCII to header name.
2011-02-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: test whether inspector gets populated with databases and storages upon opening.
https://bugs.webkit.org/show_bug.cgi?id=54469
Tests: http/tests/inspector-enabled/database-open.html
http/tests/inspector-enabled/dom-storage-open.html
* inspector/front-end/DOMStorage.js:
* inspector/front-end/Database.js:
(WebInspector.DatabaseDispatcher.prototype.addDatabase):
2011-02-15 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Share the helper functions used by Latin-1 and UTF-8 text codecs
https://bugs.webkit.org/show_bug.cgi?id=54446
Move MachineWord, UCharByteFiller and the other helper functions
into TextCodecASCIIFastPath.h where they can be used by both
TextCodecUTF8 and TextCodecLatin1.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/text/TextCodecASCIIFastPath.h: Added.
(WebCore::isAllASCII):
(WebCore::copyASCIIMachineWord):
(WebCore::isAlignedToMachineWord):
(WebCore::alignToMachineWord):
* platform/text/TextCodecLatin1.cpp:
(WebCore::TextCodecLatin1::decode):
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::decode):
2011-02-15 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Kent Tamura.
Code style issue in WebCore/dom/InputElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=54428
Remove 2 extra spaces in InputElement.cpp line 221.
Code style fix, No new tests.
* dom/InputElement.cpp:
(WebCore::InputElement::handleBeforeTextInsertedEvent):
2011-02-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] Video player sets system volume to 100%
https://bugs.webkit.org/show_bug.cgi?id=54140
Don't explicitely set volume at startup and use the
GstStreamVolume interface with cubic volume scale when
updating/retrieving the volume value. This gives a much better
user-experience.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
2011-02-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Sketch script-src for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54381
This patch provides a sketch of the script-src directive. We still do
not parse the value of the directive, and the wiring into the rest of
WebCore is incorrect, but those are things we can fix in future
patches. For the momemnt, this patch lets us test what we're doing.
Test: http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::allows):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc):
(WebCore::ContentSecurityPolicy::parse):
(WebCore::ContentSecurityPolicy::emitDirective):
* page/ContentSecurityPolicy.h:
2011-02-15 Antti Koivisto <antti@apple.com>
Reviewed by Andreas Kling.
svg/custom/use-css-no-effect-on-shadow-tree.svg produces empty image on Chromium Linux after r58556
https://bugs.webkit.org/show_bug.cgi?id=54460
Don't use fast path for SVG. There are some additional rules for shadow trees that are not
implemented on fast path.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkSelector):
2011-02-15 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339
Part 1.
Introduce CodeGenerators.pri and add common includepaths to WebCore.pri,
thus unnecessary duplications can be removed from project files.
No new tests needed.
* CodeGenerators.pri: Copied from Source/WebCore/WebCore.pri.
Don't add non-source generated files to SOURCES.
* DerivedSources.pro: Change WebCore.pri to CodeGenerators.pri.
* WebCore.pri: Move code generation rules to CodeGenerators.pri.
* WebCore.pro: Move common options to WebCore.pri.
2011-02-15 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=54219
Ensures we do not start a new navigation while we are in the process of
stopping a navigation. Also adds a manual test, since the crash can
only be reproduced using the back button and not history.back().
* loader/FrameLoader.cpp:
* manual-tests/navigation-during-onload-triggered-by-back.html: Added.
* manual-tests/resources/navigation-during-onload-container.html: Added.
2011-02-15 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
SubresourceLoader should expose finish time
https://bugs.webkit.org/show_bug.cgi?id=54287
No tests needed, exposes no new functionality
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didFinishLoading):
* loader/DocumentThreadableLoader.h:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
* loader/SubresourceLoaderClient.h:
(WebCore::SubresourceLoaderClient::didFinishLoading):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didFinishLoading):
* loader/cache/CachedResourceRequest.h:
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::didFinishLoading):
* loader/icon/IconLoader.h:
2011-02-15 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
Enable fast path selector checking for child and subselector combinators
https://bugs.webkit.org/show_bug.cgi?id=54360
* css/CSSStyleSelector.cpp:
(WebCore::isFastCheckableSelector):
(WebCore::fastCheckSingleSelector):
(WebCore::checkClassValue):
(WebCore::checkIdValue):
(WebCore::checkTagValue):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
2011-02-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console auto-scroll is broken when there are both scrollers.
https://bugs.webkit.org/show_bug.cgi?id=54273
* inspector/front-end/utilities.js:
(Element.prototype.isScrolledToBottom): use clientHeight instead of offsetHeight to determine
whether the element is scrolled to the bottom.
2011-02-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: highlighter works incorrect at build.chromium.org WebKit cells
https://bugs.webkit.org/show_bug.cgi?id=53910
Use enclosingBoundingBox for the absolute margin quad as the reference box for a tooltip.
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::drawNodeHighlight):
2011-02-15 Dirk Schulze <krit@webkit.org>
Rubber-stamped by Nikolas Zimmermann.
SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410
Accidently replaced start value RegularPropertyValue for m_fromPropertyValueType
and m_toPropertyValueType by CurrentColorValue before landing. Check for property
value type 'inherit' on color validation was missing.
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
2011-02-15 Adam Roben <aroben@apple.com>
Windows build fix after r78533
* WebCore.vcproj/WebCore.vcproj: Fix bad XML syntax.
2011-02-15 Gavin Peters <gavinp@chromium.org>
Reviewed by Antti Koivisto.
SharedBuffer::buffer() does not do what you think.
https://bugs.webkit.org/show_bug.cgi?id=54420
No new tests.
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::resourceContentBase64):
* platform/SharedBuffer.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):
2011-02-15 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG animation doesn't support attribute value 'inherit'
https://bugs.webkit.org/show_bug.cgi?id=54410
SVG animation does not support 'inherit' as value for CSS property animations. With the patch, SVG determines
if the attribute of the target element is an animatable CSS Property and computes the style during the
animation.
This fixes the following tests on the W3C test suite:
* animate-elem-84-t.svg
* animate-elem-85-t.svg
Tests: svg/animations/animate-currentColor.html
svg/animations/animate-inherit-css-property.html
* svg/SVGAnimateElement.cpp:
(WebCore::adjustForCurrentColor):
(WebCore::adjustForInheritance):
(WebCore::SVGAnimateElement::calculateAnimatedValue): When a property value is 'inherit' or 'currentColor'
during the animation, get the computed style of the property since the values could be animated themselves.
(WebCore::inheritsFromProperty):
(WebCore::attributeValueIsCurrentColor):
(WebCore::SVGAnimateElement::calculateFromAndToValues): Check if 'from', 'by' or 'to' value has the
string 'inherit' or 'currentColor' and if the attribute supports one of these values.
(WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
* svg/SVGAnimateElement.h:
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): Check if target element is stylable and
the attribute is an animatable CSS property by using the CSS property map in SVGStyledElement.
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): s/target/targetElement/ for consistency.
* svg/SVGAnimationElement.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::isAnimatableCSSProperty): Checks if the CSS property is animatable.
* svg/SVGStyledElement.h:
* svg/animation/SMILTimeContainer.cpp: Use the new function isTargetAttributeCSSProperty to determine
if the target element is stylable and the attribute is an animatable CSS property.
(WebCore::SMILTimeContainer::baseValueFor):
2011-02-15 Antti Koivisto <antti@apple.com>
Reviewed by Andreas Kling.
r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
https://bugs.webkit.org/show_bug.cgi?id=54418
Check for zero buffer length.
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::decode):
2011-02-15 MORITA Hajime <morrita@google.com>
Unreviewed build fix.
* page/EditorClient.h: Changed GrammarDetail forward declaration from class to struct.
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
Created new abstract class TextCheckerClient. The class has
spellcheck related API which is split.
This is the first step for sharing spell-checking codebase
between ports. A standalone TextCheckerClient implementation
should be done in future changes.
No new tests. No behavioral change.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling):
* editing/Editor.cpp: Replacing some client() call with textChecker().
(WebCore::Editor::textChecker): Added.
(WebCore::Editor::ignoreSpelling):
(WebCore::Editor::learnSpelling):
(WebCore::Editor::isSelectionMisspelled):
(WebCore::Editor::guessesForMisspelledSelection):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::correctionPanelTimerFired):
* editing/Editor.h:
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::SpellChecker):
* editing/TextCheckingHelper.cpp: Replacing some client() call with textChecker().
(WebCore::TextCheckingHelper::findFirstMisspelling):
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
* loader/EmptyClients.h: Added EmptyTextCheckerClient.
(WebCore::EmptyTextCheckerClient::ignoreWordInSpellDocument):
(WebCore::EmptyTextCheckerClient::learnWord):
(WebCore::EmptyTextCheckerClient::checkSpellingOfString):
(WebCore::EmptyTextCheckerClient::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::EmptyTextCheckerClient::checkGrammarOfString):
(WebCore::EmptyTextCheckerClient::checkTextOfParagraph):
(WebCore::EmptyTextCheckerClient::getGuessesForWord):
(WebCore::EmptyTextCheckerClient::requestCheckingOfString):
(WebCore::EmptyEditorClient::textChecker):
* page/EditorClient.h: Extracted TextCheckerClient.
* page/Page.h:
* platform/text/TextCheckerClient.h: Added.
(WebCore::TextCheckerClient::~TextCheckerClient):
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. These functions
returns true iff the current frame should be able to copy/cut and paste respectively.
They take the default value determined by isDOMPasteAllowed and javaScriptCanAccessClipboard.
These callbacks allows embedders to decide whether or not copy/cut/paste should be enabled
per frame and thus per origin rather than per page.
No new tests are added since this is a WebKit/WebCore interface change.
* editing/EditorCommand.cpp:
(WebCore::supportedCopyCut): Calls canCopyCut.
(WebCore::supportedPaste): Calls canPaste.
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::canCopyCut): Added.
(WebCore::EmptyEditorClient::canPaste): Added.
* page/EditorClient.h:
2011-02-14 Jeremy Orlow <jorlow@chromium.org>
efl build fix
* CMakeLists.txt:
2011-02-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Finish up implementing the new event model in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=54331
We shouldn't have our own event subclasses. Instead, we
should just fire Event's with the proper type and bubble
settings. All the attributes on the events before should
just be on the request. IDBRequest should throw if they're
accessed before the success event fires.
* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.h:
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* dom/Event.cpp:
* dom/Event.h:
* page/DOMWindow.idl:
* storage/IDBAbortEvent.h: Removed.
* storage/IDBCompleteEvent.cpp: Removed.
* storage/IDBCompleteEvent.h: Removed.
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::~IDBDatabase):
* storage/IDBDatabaseException.h:
* storage/IDBDatabaseException.idl:
* storage/IDBErrorEvent.cpp: Removed.
* storage/IDBErrorEvent.h: Removed.
* storage/IDBErrorEvent.idl: Removed.
* storage/IDBEvent.h: Removed.
* storage/IDBEvent.idl: Removed.
* storage/IDBEventDispatcher.cpp:
(WebCore::IDBEventDispatcher::dispatch):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::result):
(WebCore::IDBRequest::errorCode):
(WebCore::IDBRequest::webkitErrorMessage):
(WebCore::IDBRequest::source):
(WebCore::IDBRequest::transaction):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::onError):
(WebCore::createSuccessEvent):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBRequest.idl:
* storage/IDBSuccessEvent.cpp: Removed.
* storage/IDBSuccessEvent.h: Removed.
* storage/IDBSuccessEvent.idl: Removed.
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::dispatchEvent):
2011-02-14 Enrica Casucci <enrica@apple.com>
Copy/paste from a WebKit window to a TextEdit window loses fonts.
<rdar://problem/8623090>
https://bugs.webkit.org/show_bug.cgi?id=54416
Reviewed by Dan Bernstein.
We don't have the complete solution that fixes this problem for WebKit2 yet.
This patch fixes the regression in WebKit.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): For WebKit2 use only plain text,
for WebKit use the original API to create the NSAttributedString.
2011-02-14 Levi Weintraub <leviw@chromium.org>
Reviewed by Alexey Proskuryakov.
Strikethrough disappears when posting a message on odnoklassniki.ru
https://bugs.webkit.org/show_bug.cgi?id=53475
Changing the behavior of the strikethrough execCommand when styleWithCSS
is false. We formerly created <s> tags, which was different than both IE
and FF and caused problems with some rich text editors that would strip
out unexpected tags such as <s>.
Test: editing/execCommand/strikethrough-uses-strike-tag.html
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
2011-02-14 Pratik Solanki <psolanki@apple.com>
Remove dead code in FormDataStreamCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54401
Reviewed by Darin Adler.
The static functions in this file are no longer reachable. We added a conditional branch to
use new CFNetwork functions in r30329 and later made that code path permanent in r41517
which made these functions unreachable.
* platform/network/cf/FormDataStreamCFNet.cpp:
2011-02-14 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
GraphicsContext: Add clip(IntRect) overload for Qt
https://bugs.webkit.org/show_bug.cgi?id=54365
Qt has special code paths for clipping to integer rectangles.
Add a GraphicsContext::clip() overload to allow us to take
advantage of the optimized code.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::clip):
* platform/graphics/GraphicsContext.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clip):
2011-02-14 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898
Covered by existing tests; not adding new tests at this time.
This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The first version failed some tests because
of incorrect error handling. The second version was missing one line
of code that made it decode incomplete sequences at the end of the
buffer twice.
* platform/text/TextCodecICU.cpp:
(WebCore::create): Renamed from newTextCodecICU, made a static member
function, and added a call to adoptPtr.
(WebCore::TextCodecICU::registerEncodingNames): Renamed from
registerExtendedEncodingNames since this class is no longer used for
base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8.
(WebCore::TextCodecICU::registerCodecs): Renamed.
(WebCore::fallbackForGBK): Renamed to conform to our current style.
* platform/text/TextCodecICU.h: Updated for above changes. Changed
indentation. Made most functions private, including virtual function
overrides. Marked ICUConverterWrapper noncopyable.
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases
that were formerly added by TextCodecICU.
(WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for
bytes F5-FF instead of failing.
(WebCore::decodeNonASCIISequence): Tweaked coding style.
(WebCore::appendCharacter): Added. Makes it easier to share code between
the partial-character handling and main loop.
(WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case
where there is a partial sequence. Fixed partial sequence handling so that
goto is no longer needed, since compilers sometimes make poor code when
goto is involved. Added a loop for partial sequences since we consume only
one byte when a partial sequence is invalid. Fixed logic in main decoding
loop so goto is not needed. Used early-exit style in both loops so the main
flow is not nested inside if statements. Added correct error handling for
flush when a partial sequence remains, which involved wrapping the function
in yet another loop.
* platform/text/TextCodecUTF8.h: Made virtual function overrides private.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed
calls to TextCodecICU. Added FIXMEs for other codecs that no longer need
to be included here.
(WebCore::extendTextCodecMaps): Updated for the name change of the
TextCodecICU functions.
2011-02-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add basic parser for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=54379
The parser in this patch is very basic. It just segments the CSP
header into directives. The exactly syntax will likely change a bit as
we discuss the details in public-web-security, but this parser will
allow us to make progress.
Sadly, this patch does not contain any tests. That's because CSP
policies do not have any observable effects yet. Hopefully we'll get
enough sketched out in the next couple patches to begin writing tests.
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::name):
(WebCore::CSPDirective::value):
(WebCore::ContentSecurityPolicy::~ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::parse):
* page/ContentSecurityPolicy.h:
2011-02-14 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Kenneth Russell.
[Qt] WebKit fails to compile for Qt when WebGL enabled
https://bugs.webkit.org/show_bug.cgi?id=53431
No new tests.
* WebCore.pro:
Add source and header files and include directory to Qt project.
* html/canvas/WebGLRenderingContext.cpp:
File uses 'emit' which is a Qt keyword - #undef emit.
* platform/graphics/gpu/qt: Added.
* platform/graphics/gpu/qt/DrawingBufferQt.cpp: Added.
Partial implementation of DrawingBuffer for Qt.
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::didReset):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::platformColorBuffer):
* platform/graphics/qt/Extensions3DQt.cpp:
Noop implementation for pure virtual methods added to Extensions3D.h
(WebCore::Extensions3DQt::blitFramebuffer):
(WebCore::Extensions3DQt::renderbufferStorageMultisample):
* platform/graphics/qt/Extensions3DQt.h:
Declare new methods added to Extensions3D.h
* platform/graphics/qt/GraphicsContext3DQt.cpp:
Remove method implementations no longer in GraphicsContext3D.h.
Change m_syntheticErrors to use unsigned int to match new
GC3Denum type.
(WebCore::GraphicsContext3D::create):
Change return type to match GraphicsContext3D.h
(WebCore::GraphicsContext3D::lineWidth):
Change argument type to GC3Dfloat to match GraphicsContext3D.h
(WebCore::GraphicsContext3D::getUniformLocation):
Change return type to GC3Dfloat to match GraphicsContext3D.h
(WebCore::GraphicsContext3D::getExtensions):
Need to call get() on OwnPtr.
(WebCore::GraphicsContext3D::getImageData):
Rename enum values to match declarations in GraphicsContext3D.h
2011-02-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
<select> elements don't honor border:0px in chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=51152
No new tests, covered by existing pixel results (fast/forms/basic-selects.html
convers lots of cases).
* css/themeChromiumLinux.css:
(select):
* platform/chromium/PlatformBridge.h:
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
match border logic in RenderThemeChromiumWin.cpp:
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderThemeChromiumWin.cpp#L463
2011-02-14 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix rendering of ISO-8859-8 when dir="rtl".
https://bugs.webkit.org/show_bug.cgi?id=52128
Test: fast/text/international/iso-8859-8.html
* platform/text/BidiResolver.h: Add VisualDirectionOverride enum.
(WebCore::::createBidiRunsForLine): For lines with visual direction override,
create bidi runs without resolving bidi levels (one run per render object),
set bidi level as 0 or 1 depending on LTR or RTL override,
and reverse runs for RTL override.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::constructLine): Set inline box bidi level the same as
BidiRun's bidi level without special handling of VisualDirectionOverride.
(WebCore::RenderBlock::layoutInlineChildren): Pass in VisualDirectionOverride
to createBidiRunsForLine().
2011-02-14 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] Crash on application exit after constructing and destroying a QWebView twice
https://bugs.webkit.org/show_bug.cgi?id=54000
Check the value is valid before use it.
* platform/qt/SharedTimerQt.cpp:
(WebCore::SharedTimerQt::~SharedTimerQt):
2011-02-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: 304 Not Modified responses have a yellow icon in Web Inspector Resources panel
https://bugs.webkit.org/show_bug.cgi?id=33220
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
2011-02-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Modify LayerTilerChromium to use TilingData.
https://bugs.webkit.org/show_bug.cgi?id=54143
Most of the previous data in LayerTilerChromium is now calculated
from TilingData. TilingData was modified to allow for a dynamic
tile size and page size. LayerTilerChromium also gets its own
shader with a texture transform to handle drawing from a texture
that is larger than a tile.
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::updateAndDrawRootLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::tilerSharedValues):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::create):
(WebCore::LayerTilerChromium::LayerTilerChromium):
(WebCore::LayerTilerChromium::setTileSize):
(WebCore::LayerTilerChromium::reset):
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::tileIndex):
(WebCore::LayerTilerChromium::tileContentRect):
(WebCore::LayerTilerChromium::tileLayerRect):
(WebCore::LayerTilerChromium::layerSize):
(WebCore::LayerTilerChromium::layerTileSize):
(WebCore::LayerTilerChromium::invalidateEntireLayer):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::resizeLayer):
(WebCore::LayerTilerChromium::growLayerToContain):
(WebCore::LayerTilerChromium::drawTexturedQuad):
(WebCore::LayerTilerChromium::SharedValues::SharedValues):
(WebCore::LayerTilerChromium::SharedValues::~SharedValues):
* platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::SharedValues::tilerShaderProgram):
(WebCore::LayerTilerChromium::SharedValues::shaderSamplerLocation):
(WebCore::LayerTilerChromium::SharedValues::shaderMatrixLocation):
(WebCore::LayerTilerChromium::SharedValues::shaderAlphaLocation):
(WebCore::LayerTilerChromium::SharedValues::shaderTexTransformLocation):
(WebCore::LayerTilerChromium::SharedValues::initialized):
* platform/graphics/gpu/TilingData.cpp:
(WebCore::computeNumTiles):
(WebCore::TilingData::TilingData):
(WebCore::TilingData::setTotalSize):
(WebCore::TilingData::setMaxTextureSize):
(WebCore::TilingData::tileSizeX):
(WebCore::TilingData::tileSizeY):
(WebCore::TilingData::textureOffset):
(WebCore::TilingData::recomputeNumTiles):
* platform/graphics/gpu/TilingData.h:
2011-02-14 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] First implementation of the editable TextViewer without optimization
https://bugs.webkit.org/show_bug.cgi?id=54388
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.set readOnly):
(WebInspector.TextEditorChunkedPanel):
(WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorChunkedPanel.prototype.beginDomUpdates):
(WebInspector.TextEditorChunkedPanel.prototype.endDomUpdates):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorGutterChunk.prototype.set expanded):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.set readOnly):
(WebInspector.TextEditorMainPanel.prototype._buildChunks):
(WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype.textChanged):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates.return):
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
(WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.removeDecoration):
(WebInspector.TextEditorMainChunk.prototype.set expanded):
2011-02-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: use call frame column to determine execution line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=54001
- Make call frame line and column zero based
- Set execution line in source frame based on call frame line:column
- Determine currently hit breakpoint based on call frame line:column
* bindings/js/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
* bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::update):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
* bindings/v8/DebuggerScript.js:
():
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.continueToLocation):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._breakpointForCallFrame):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._setTextViewerDecorations):
(WebInspector.SourceFrame.prototype.setExecutionLocation):
(WebInspector.SourceFrame.prototype.clearExecutionLocation):
(WebInspector.SourceFrame.prototype._setExecutionLocation):
(WebInspector.SourceFrame.prototype._breakpointAdded):
(WebInspector.SourceFrame.prototype._continueToLine):
(WebInspector.SourceFrame.prototype._originalLocationToTextViewerLineNumber):
2011-02-14 Christian Dywan <christian@lanedo.com>
Reviewed by Gustavo Noronha Silva.
Regression: Back, Forward, Reload hidden in context menu
https://bugs.webkit.org/show_bug.cgi?id=54393
* page/ContextMenuController.cpp: Always show Back, Forward,
Reload and Stop context menu items for the GTK+ port.
2011-02-14 Johnny Ding <jnd@chromium.org>
Reviewed by Andreas Kling.
Move the finiteness check into common code.
Test covered by canvas/philip/tests/2d.path.isPointInPath.nonfinite.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::isPointInPath):
2011-02-14 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54377 - Clean up RenderTextControlSingleLine::createSubtreeIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=54377
Rearranged the condition blocks, removed superfluous conditions:
.) if-statements where it's already clear that a search field is being generated
.) testing for spin-buttons on field types that can never have them.
createInnerBlockStyle(): only search fields create an inner block, and
these can never have spin buttons.
No new tests. (Refactoring - covered by existing tests)
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
2011-02-10 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactoring, extract SourceMapping from SourceFrameContent.
https://bugs.webkit.org/show_bug.cgi?id=54195
Add SourceMapping interface with two implementations - IdenticalSourceMapping and SourceMappingForFormattedScript.
Rewrite SourceFrameContent based on SourceMapping. Make SourceFrame unaware of source mapping details.
* inspector/front-end/ResourceView.js:
(WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
(WebInspector.ScriptFormatter.prototype.formatContent):
(WebInspector.ScriptFormatter.prototype._splitContentIntoChunks):
(WebInspector.SourceMappingForFormattedScript):
(WebInspector.SourceMappingForFormattedScript.prototype.fromScriptLocation):
(WebInspector.SourceMappingForFormattedScript.prototype.toScriptLocation):
(WebInspector.SourceMappingForFormattedScript.prototype.originalPositionToFormattedLocation):
(WebInspector.SourceMappingForFormattedScript.prototype._convertPosition):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype._shouldDisplayBreakpoint):
(WebInspector.SourceFrame.prototype.setExecutionLine):
(WebInspector.SourceFrame.prototype.clearExecutionLine):
(WebInspector.SourceFrame.prototype._breakpointAdded):
(WebInspector.SourceFrame.prototype.formatSource.didFormat):
(WebInspector.SourceFrame.prototype.formatSource):
(WebInspector.SourceFrame.prototype._continueToLine):
(WebInspector.SourceFrame.prototype._setBreakpoint):
(WebInspector.SourceFrame.prototype._findBreakpoint):
(WebInspector.SourceFrameContentProvider.prototype.requestContent):
* inspector/front-end/SourceFrameContent.js:
(WebInspector.SourceFrameContent):
(WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToScriptLocation):
(WebInspector.SourceFrameContent.prototype.scriptLocationToSourceFrameLineNumber):
(WebInspector.SourceFrameContent.prototype._sourceIDForSourceFrameLineNumber):
(WebInspector.SourceMapping):
(WebInspector.SourceMapping.prototype.fromScriptLocation):
(WebInspector.SourceMapping.prototype.toScriptLocation):
(WebInspector.IdenticalSourceMapping):
(WebInspector.IdenticalSourceMapping.prototype.fromScriptLocation):
(WebInspector.IdenticalSourceMapping.prototype.toScriptLocation):
* inspector/front-end/utilities.js:
(String.prototype.lineEndings):
2011-02-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION introduced in r77950] Develop -> Start Debugging JavaScript does not open Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=54277
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::stopUserInitiatedProfiling):
(WebCore::InspectorAgent::showAndEnableDebugger):
(WebCore::InspectorAgent::showPanel):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::showAndEnableDebugger):
(WebCore::InspectorController::stopUserInitiatedProfiling):
2011-02-14 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Andreas Kling.
css style="max-width:none" works wrong
https://bugs.webkit.org/show_bug.cgi?id=53743
Fix a bug that "max-width:none" works wrong.
See also: http://trac.webkit.org/changeset/13462
Test: fast/css/max-width-none.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): For max-width of none,
set it to Length(undefinedLength, Fixed), which is the correct
value.
2011-02-14 Antti Koivisto <antti@apple.com>
Reviewed by Andreas Kling.
REGRESSION (r77834): Assertion failing in svg/custom/use-multiple-on-nested-disallowed-font.svg
https://bugs.webkit.org/show_bug.cgi?id=54344
Intead of recomputing, just mark style selector dirty if it is invalidated in the middle of a style recalc.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:
2011-02-14 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
[Chromium] Fix wrong popup position for RTL(again)
https://bugs.webkit.org/show_bug.cgi?id=54375
Fix right position bug introduce by https://bugs.webkit.org/show_bug.cgi?id=53567, because the previous fix was correct for the current behaviour, but not good for http://crbug.com/60427. To calculate the correct right offset value and apply to the position, change WebCore::PopupContainer::layout() to return right offset value and use the returned value to calculate position.
No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect): Change the input parameter to take popupInitialCoordinate again. And calculate correct right position with returned right offset from layoutAndGetRightOffset().
(WebCore::PopupContainer::showPopup): Change the passing parameter to layoutAndCalculateWidgetRect().
(WebCore::PopupContainer::layoutAndGetRightOffset): Change the name from layout() and to return rightOffset value.
(WebCore::PopupContainer::refresh): Change the passing parameter to layoutAndCalculateWidgetRect().
* platform/chromium/PopupMenuChromium.h: Change the function name and parameters.
2011-02-14 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rolling out r78451.
http://trac.webkit.org/changeset/78451
https://bugs.webkit.org/show_bug.cgi?id=53898
It is causing crashes in some bots
* platform/text/TextCodecICU.cpp:
(WebCore::newTextCodecICU):
(WebCore::TextCodecICU::registerBaseEncodingNames):
(WebCore::TextCodecICU::registerBaseCodecs):
(WebCore::TextCodecICU::registerExtendedEncodingNames):
(WebCore::TextCodecICU::registerExtendedCodecs):
(WebCore::ErrorCallbackSetter::~ErrorCallbackSetter):
(WebCore::getGbkEscape):
(WebCore::urlEscapedEntityCallback):
(WebCore::gbkCallbackEscape):
(WebCore::gbkUrlEscapedEntityCallack):
(WebCore::gbkCallbackSubstitute):
* platform/text/TextCodecICU.h:
(WebCore::ICUConverterWrapper::ICUConverterWrapper):
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::registerEncodingNames):
(WebCore::nonASCIISequenceLength):
(WebCore::decodeNonASCIISequence):
(WebCore::TextCodecUTF8::decode):
* platform/text/TextCodecUTF8.h:
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):
2011-02-13 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=54376
Make sorting of matched rules faster
- use std::sort
- cache specificity, it is slow to compute
- inline compare function
* css/CSSStyleSelector.cpp:
(WebCore::RuleData::specificity):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::compareRules):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::RuleData::RuleData):
(WebCore::CSSStyleSelector::matchPageRules):
* css/CSSStyleSelector.h:
2011-02-12 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898
Covered by existing tests; not adding new tests at this time.
This patch now handles errors in the same way the existing codecs do,
and so passes our tests. The previous version failed some tests because
of incorrect error handling.
* platform/text/TextCodecICU.cpp:
(WebCore::create): Renamed from newTextCodecICU, made a static member
function, and added a call to adoptPtr.
(WebCore::TextCodecICU::registerEncodingNames): Renamed from
registerExtendedEncodingNames since this class is no longer used for
base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8.
(WebCore::TextCodecICU::registerCodecs): Renamed.
(WebCore::fallbackForGBK): Renamed to conform to our current style.
* platform/text/TextCodecICU.h: Updated for above changes. Changed
indentation. Made most functions private, including virtual function
overrides. Marked ICUConverterWrapper noncopyable.
* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases
that were formerly added by TextCodecICU.
(WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for
bytes F5-FF instead of failing.
(WebCore::decodeNonASCIISequence): Tweaked coding style.
(WebCore::appendCharacter): Added. Makes it easier to share code between
the partial-character handling and main loop.
(WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case
where there is a partial sequence. Fixed partial sequence handling so that
goto is no longer needed, since compilers sometimes make poor code when
goto is involved. Added a loop for partial sequences since we consume only
one byte when a partial sequence is invalid. Fixed logic in main decoding
loop so goto is not needed. Used early-exit style in both loops so the main
flow is not nested inside if statements. Added correct error handling for
flush when a partial sequence remains, which involved wrapping the function
in yet another loop.
* platform/text/TextCodecUTF8.h: Made virtual function overrides private.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed
calls to TextCodecICU. Added FIXMEs for other codecs that no longer need
to be included here.
(WebCore::extendTextCodecMaps): Updated for the name change of the
TextCodecICU functions.
2011-02-13 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't implement some necessary methods.
* platform/network/mac/AuthenticationMac.mm:
(-[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
(-[WebCoreAuthenticationClientAsChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):
2011-02-13 Simon Fraser <simon.fraser@apple.com>
Reviewed by Andreas Kling.
Repeating gradients drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53502
The 'forward-fill' logic for repeating gradients used the wrong
starting stop index (0 rather than the original first index), which
resulted in incorrect gradients if backwards-fill had already been
applied.
Test: fast/gradients/css3-repeating-end-fill.html
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
2011-02-13 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
Unused variable result in RenderBlock::addOverflowFromFloats()
https://bugs.webkit.org/show_bug.cgi?id=54363
Remove the unused variable.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromFloats):
2011-02-13 Cameron Zwarich <zwarich@apple.com>
Reviewed by Anders Carlsson.
WebCore fails to build with Clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54367
* loader/PingLoader.h:
(WebCore::PingLoader::didReceiveData): Change the method signature to match the signature
in the base class.
2011-02-13 Nico Weber <thakis@chromium.org>
Reviewed by Anders Carlsson.
RenderBR::width() tries but fails to override RenderText::width()
https://bugs.webkit.org/show_bug.cgi?id=54301
The superclass method's signature changed, e.g. in
http://trac.webkit.org/changeset/57215, but the subclass was not
updated.
* rendering/RenderBR.h:
(WebCore::RenderBR::width):
2011-02-13 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Canvas: 2d.fillStyle.parse.system.html fails
https://bugs.webkit.org/show_bug.cgi?id=39168
Based on previous work by Julien Chaffraix <jchaffraix@codeaurora.org>
and Jan Erik Hanssen <jhanssen@sencha.com>
* css/CSSParser.cpp:
(WebCore::CSSParser::parseColor): Changed the function to better match our
early return policy. Also we now return false when we don't parse the color.
This is needed for createFromString to fallback to using parseSystemColor.
(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.
* css/CSSParser.h: Added the new parseSystemColor method.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString.
(WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
* html/canvas/CanvasStyle.cpp:
(WebCore::parseColor):
(WebCore::parseColorOrCurrentColor):
(WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor
and fall back to parseSystemColor if it did not work.
* html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.
2011-02-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Adam Barth.
Add a compile-time option to completely disable WebArchive support.
https://bugs.webkit.org/show_bug.cgi?id=52712
Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code.
ArchiveResource and ArchiveResourceCollection are notably still compiled in. They are used
in Safari for functionality such as "Save Image As" and Image copy & paste independent of
WebArchive support.
Ports Affected:
WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt.
This patch preserves this behavior except that it also disables support in the Chromium port.
No behavior changes so no new tests.
* WebCore.gyp/WebCore.gyp: Don't compile LegacyWebArchive.cpp and friends.
* WebCore.pro: Don't compile ArchiveFactory.cpp in Qt port.
* loader/DocumentLoader.cpp: Surround WebArchive code with #ifdef.
(WebCore::DocumentLoader::commitLoad):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::archiveResourceForURL):
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::finishedLoadingDocument):
* loader/FrameLoader.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
* loader/archive/ArchiveFactory.cpp: Remove #ifdef since feature is now enabled/disabled wholesale.
(WebCore::archiveMIMETypes):
* page/Settings.cpp:
* page/Settings.h:
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedNonImageMimeTypes):
2011-02-13 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] QtWebKit does not properly handle D&D of a percent-encoded URL.
https://bugs.webkit.org/show_bug.cgi?id=53320
The encoding that was done is corrected in the fix.
Replaced the KURL encoding function with QUrl API.
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asURL):
2011-02-13 Leo Yang <leo.yang.c@gmail.com>
Reviewed by Andreas Kling.
Unnecessary call of containingBlock() in RenderBoxModelObject::relativePositionOffsetX()
https://bugs.webkit.org/show_bug.cgi?id=54351
We were calling containingBlock() twice if the left is not auto. We only need to call it
once because we can use 'cb' variable in the following line.
No functionality change, no new tests.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
2011-02-13 Jarred Nicholls <jarred@sencha.com>
Reviewed by Simon Fraser.
getComputedStyle returns wrong value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=13343
Matching IE, Firefox, and Opera behavior by returning the computed margin
values as specified, rather than the used/auto values (calculated via RenderBox).
Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable.
Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE
returns the specified percentage.
Tests: fast/css/getComputedStyle/getComputedStyle-margin-auto.html
fast/css/getComputedStyle/getComputedStyle-margin-length.html
fast/css/getComputedStyle/getComputedStyle-margin-percentage.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2011-02-13 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
crypto.getRandomValues should throw TYPE_MISMATCH_ERR
https://bugs.webkit.org/show_bug.cgi?id=54346
As requested by Sam.
* page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):
2011-02-13 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=54349
Inline some accessors in PrintContext
No change in behavior, so no tests.
* WebCore.exp.in:
* page/PrintContext.cpp:
* page/PrintContext.h:
(WebCore::PrintContext::pageCount):
(WebCore::PrintContext::pageRect):
Inline pageCount() and pageRect() to match pageRects().
2011-02-13 Sam Weinig <sam@webkit.org>
Roll r78424 [Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)] back
in with fixes to make it work with render layers.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::contentsSize):
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):
* rendering/RenderListBox.h:
2011-02-13 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Some Scrollbar functions assume an attached ScrollableArea but can be called without one
https://bugs.webkit.org/show_bug.cgi?id=54262
Make sure that all calls to the scrollable area are null checked.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
2011-02-13 Sam Weinig <sam@webkit.org>
Roll out r78424. It broke a bunch of tests.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
* rendering/RenderLayer.cpp:
* rendering/RenderLayer.h:
(WebCore::RenderLayer::contentsSize):
* rendering/RenderListBox.cpp:
* rendering/RenderListBox.h:
2011-02-12 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
WK2: Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)
<rdar://problem/8984760>
When going down the smooth scroll path, constrained scrolls (such as those from a
Mighty Mouse) were being correctly constrained at the ScrollView level, but the
duplicate values being stored by the animator were not being constrained correctly.
In order to implement the constraint at this level, more of the ScrollableArea's API
needed to be filled in for RenderLayer and RenderListBox.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): Call immediateScrollToPoint to stay
consistent and get the desired behavior.
(WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary):
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
Ensure that the scroll animators view of the current scroll position is the
same as the scrollable areas by correctly clamping the value.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::contentsSize): Correct implementation
to use the scroll size, not the visible size.
(WebCore::RenderLayer::visibleHeight):
(WebCore::RenderLayer::visibleWidth):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::visibleHeight):
(WebCore::RenderListBox::visibleWidth):
* rendering/RenderListBox.h:
Add implementations for visibleHeight/visibleWidth.
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
crypto.getRandomValues should support all integer array types
https://bugs.webkit.org/show_bug.cgi?id=54342
As discussed on whatwg, we should support all the integer array types.
Test: security/crypto-random-values-types.html
* page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Mark Rowe.
Use /dev/urandom as the OSRandomSource on OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=54279
Update the ifdef. OS(UNIX) includes OS(DARWIN), so this change is
should be a NOP.
* config.h:
2011-02-11 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
[chromium] Allow turning off multisampling through web preference settings
https://bugs.webkit.org/show_bug.cgi?id=54321
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create): Disable multisampling in WebGL if web reference says so.
* page/Settings.cpp: Add a flag for multisampling preference.
(WebCore::Settings::Settings):
(WebCore::Settings::setOpenGLMultisamplingEnabled):
* page/Settings.h: Ditto.
(WebCore::Settings::openGLMultisamplingEnabled):
2011-02-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Deploy EditingStyle in applyBlockStyle and applyInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=53911
Deployed EditingStyle in ApplyStyleCommand::applyBlockStyle and ApplyStyleCommand::applyInlineStyle.
Extracted EditingStyle::extractAndRemoveTextDirection from applyInlineStyle.
Also added propertiesToInclude to the argument list of EditingStyle's constructor that takes Node*
so that splitAncestorsWithUnicodeBidi can call EditingStyle::textDirection to obtain the text direction.
No new tests are added since this is a refactoring.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::doApply): Passes EditingStyle* to applyBlockStyle and applyInlineStyle.
(WebCore::ApplyStyleCommand::applyBlockStyle): Takes EditingStyle*.
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Changed the type of allowedDirection
from int to WritingDirection. Uses EditingStyle's textDirection to obtain the writing direction.
(WebCore::ApplyStyleCommand::applyInlineStyle): Takes EditingStyle*.
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Asserts that style is not null.
(WebCore::ApplyStyleCommand::removeInlineStyle): Allows style to be null.
* editing/ApplyStyleCommand.h: Includes WritingDirection.h; prototype changes.
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::EditingStyle): Added PropertiesToInclude to the argument.
(WebCore::EditingStyle::init): Supports PropertiesToInclude.
(WebCore::EditingStyle::extractAndRemoveTextDirection): Extracted from applyInlineStyle.
* editing/EditingStyle.h:
(WebCore::EditingStyle::create): Supports PropertiesToInclude.
2011-02-12 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Implement IDBObjectStore::clear
https://bugs.webkit.org/show_bug.cgi?id=54193
Test: storage/indexeddb/objectstore-clear.html
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::clear):
* storage/IDBObjectStore.h:
* storage/IDBObjectStore.idl:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::doDelete):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
* storage/IDBObjectStoreBackendImpl.h:
* storage/IDBObjectStoreBackendInterface.h:
2011-02-12 Adam Barth <abarth@webkit.org>
Another attempt to fix the EFL build. Looks like we're missing one
more file.
* CMakeLists.txt:
2011-02-12 Adam Barth <abarth@webkit.org>
Attempt to fix the EFL build. Apparently the CMake build had no
concept of ArrayBuffers.
* CMakeLists.txt:
2011-02-12 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix.
* dom/Range.cpp:
(WebCore::lengthOfContentsInNode): Replaced static const unsigned LengthOfContentsInNode.
(WebCore::Range::processContents):
(WebCore::Range::processContentsBetweenOffsets):
2011-02-12 Adam Barth <abarth@webkit.org>
CPP files belong in SOURCES not in HEADERS. There are more errors like
this for other disabled features, but I'm not fixing them in this
patch.
* WebCore.pro:
2011-02-12 Adam Barth <abarth@webkit.org>
Apparently lines in .pro files need to be \-terminated.
* WebCore.pro:
2011-02-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Extract a function to process contents for one node from Range::processContents
https://bugs.webkit.org/show_bug.cgi?id=54282
Extracted Range::processContentsBetweenOffsets, which process contents of a node
between two offsets. This function is used for the simple case where the start
and the end containers are of the same node, and to process start and end containers
in the complex case.
When the function takes a non-null fragment (simple case), it appends the processed
contents to the fragment; character data and processing instruction's contents are copied
between the offsets, and descendants are copied for node of other types (not node itself).
When the fragment is null (complex case), the function copies contents of character data,
processing instruction, and node of other types (including node itself).
No new tests are added since this is a refactoring.
* dom/Range.cpp:
(WebCore::highestAncestorUnderCommonRoot): Added.
(WebCore::Range::processContents): Calls highestAncestorUnderCommonRoot and
processContentsBetweenOffsets.
(WebCore::Range::processContentsBetweenOffsets): Added.
* dom/Range.h:
2011-02-12 Adam Barth <abarth@webkit.org>
Attempt to fix the Qt Windows build.
* WebCore.pro:
2011-02-12 Adam Barth <abarth@webkit.org>
Reviewed by Kenneth Russell.
Enable ArrayBuffers by default
https://bugs.webkit.org/show_bug.cgi?id=54310
As discussed on webkit-dev, ArrayBuffers are used by a bunch of
different APIs, implemented by Firefox, and appear to be stable.
Keeping them conditional is a large mantainance burden than it's worth.
* DerivedSources.cpp:
* WebCore.vcproj/WebCore.vcproj:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebGLEnabled):
* bindings/js/JSArrayBufferCustom.cpp:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDataViewCustom.cpp:
* bindings/js/JSFloat32ArrayCustom.cpp:
* bindings/js/JSInt16ArrayCustom.cpp:
* bindings/js/JSInt32ArrayCustom.cpp:
* bindings/js/JSInt8ArrayCustom.cpp:
* bindings/js/JSUint16ArrayCustom.cpp:
* bindings/js/JSUint32ArrayCustom.cpp:
* bindings/js/JSUint8ArrayCustom.cpp:
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
* bindings/v8/custom/V8DataViewCustom.cpp:
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
* html/canvas/ArrayBuffer.cpp:
* html/canvas/ArrayBuffer.idl:
* html/canvas/ArrayBufferView.cpp:
* html/canvas/ArrayBufferView.idl:
* html/canvas/DataView.cpp:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.cpp:
* html/canvas/Float32Array.idl:
* html/canvas/Int16Array.cpp:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.cpp:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.cpp:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.cpp:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.cpp:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.cpp:
* html/canvas/Uint8Array.idl:
* page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):
* page/Crypto.h:
* page/Crypto.idl:
* page/DOMWindow.idl:
* workers/WorkerContext.idl:
2011-02-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Background image positioning on RTL text
https://bugs.webkit.org/show_bug.cgi?id=32862
When the style of InlineFlowBox is right-to-left, the strips should be rearranged in reverse order.
Tests: fast/inline/inline-box-background-long-image.html
fast/inline/inline-box-background-repeat-x.html
fast/inline/inline-box-background-repeat-y.html
fast/inline/inline-box-background.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintFillLayer):
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78044.
http://trac.webkit.org/changeset/78044
https://bugs.webkit.org/show_bug.cgi?id=54318
Broke Safari extensions (Requested by eseidel on #webkit).
* platform/KURL.cpp:
(WebCore::KURL::parse):
2011-02-11 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/8976456> Scrollbars for overflow
areas never appear for WKScrollbarPainter scrollers
Call ScrollableArea::didAddVerticalScrollbar() and
ScrollableArea::willRemoveVerticalScrollbar() when
appropriate for RenderLayers.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
2011-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
KURL should remove default port numbers when cannonicalizing urls (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54090
* platform/KURL.cpp:
(WebCore::isDefaultPortForScheme):
(WebCore::KURL::parse):
2011-02-11 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Need makeContextCurrent() called in prepareForSoftwareDraw(), in the case that skia's backend
is the gpu. This matches the pattern in GraphicsContext3DOpenGL.cpp
No new tests. All existing canvas layouttests exercise this code path
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Adler.
Check for empty scheme before accessing URLSchemeMaps in SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=54304
This avoids potential crashes in HashMap, as WTF's StringHash doesn't
accept empty Strings.
* platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure):
(WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
2011-02-11 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[fileapi] Add support for filesystem: URI handling
https://bugs.webkit.org/show_bug.cgi?id=53529
There are two major parts to this patch: one is to add an
implementation of Entry.toURI to the FileSystem API.
The other is to implement security origin checking for this
new scheme.
All changes are guarded by the FILE_SYSTEM feature. An accompanying
Chromium change, to support loading of filesystem: URIs, has recently
been submitted as Chromium r74082.
Spec:
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods-2
Proposed URI format, and discussion of security origin issues:
http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0218.html
Tests: fast/filesystem/directory-entry-to-uri.html
fast/filesystem/file-entry-to-uri.html
fast/filesystem/filesystem-uri-origin.html
http/tests/security/filesystem-iframe-from-remote.html
* fileapi/Entry.cpp:
(WebCore::Entry::toURI):
* fileapi/Entry.h:
* fileapi/Entry.idl:
- Added toURI method to the IDL, omitting the MIME type argument
specified in the spec as it will soon be removed.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
- crack the filesystem: URI to get at the origin of the site
(WebCore::SecurityOrigin::canDisplay):
- canDisplay for filesystem: URIs is equivalent to canRequest
* platform/AsyncFileSystem.cpp:
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
* platform/AsyncFileSystem.h:
(WebCore::AsyncFileSystem::type):
- Exposed filesystem type to allow toURI to use it as part of the
path.
(WebCore::AsyncFileSystem::AsyncFileSystem):
* platform/SchemeRegistry.cpp:
(WebCore::canDisplayOnlyIfCanRequestSchemes):
(WebCore::SchemeRegistry::canDisplayOnlyIfCanRequest):
(WebCore::SchemeRegistry::registerAsCanDisplayOnlyIfCanRequest):
- Generalized canDisplayOnlyIfCanRequest as it applies to both
filesystem: and blob: URIs.
* platform/SchemeRegistry.h:
2011-02-11 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/8961061> CrashTracer: [USER]
1 crash at com.apple.WebCore:
-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:] + 62
Must check for null _animator.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
2011-02-11 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Throw exception when AudioContext's createBuffer() fails to properly decode audio file data
https://bugs.webkit.org/show_bug.cgi?id=54158
No new tests since audio API is not yet implemented.
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
(WebCore::JSAudioContext::createBuffer):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::createBufferCallback):
* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::createBusFromInMemoryAudioFile):
* webaudio/AudioContext.idl:
2011-02-11 Mike Reed <reed@google.com>
Reviewed by James Robinson.
Fix toDataURL() to use device->readPixels() if need be, rather than always dereferencing
the address returned by getPixels() (as the device may not be backed by a CPU bitmap)
https://bugs.webkit.org/show_bug.cgi?id=54224
No new tests. Existing canvas tests exercise this...
fast/canvas/script-tests/canvas-createPattern-fillRect-shadow.html
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
2011-02-11 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by David Levin.
Files missing ENABLE_VIDEO #ifdef
https://bugs.webkit.org/show_bug.cgi?id=53390
No new tests.
* html/canvas/WebGLRenderingContext.cpp:
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLRenderingContext.idl:
Wrap methods and declarations that use HTMLVideoElement
with #if ENABLE(VIDEO).
2011-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78331.
http://trac.webkit.org/changeset/78331
https://bugs.webkit.org/show_bug.cgi?id=54295
This patch broke 11 tests in GTK bots (Requested by svillar on
#webkit).
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_name):
(webkit_accessible_detach):
2011-02-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GDOM] Video element needs proper wrapping
https://bugs.webkit.org/show_bug.cgi?id=54231
Use the same strategy as the one used for the audio tag to wrap
video as well. No layout tests because this only adds API.
* bindings/gobject/GNUmakefile.am:
* bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
(WebKit::createVideoWrapper):
(WebKit::createHTMLElementWrapper):
2011-02-11 Dirk Schulze <krit@webkit.org>
Reviewed by Andreas Kling.
SVGStyledElement::fillAttributeToPropertyTypeMap triggers a clang warning (-Woverloaded-virtual)
https://bugs.webkit.org/show_bug.cgi?id=54259
Renamed fillAttributeToPropertyTypeMap with passed map to fillPassedAttributeToPropertyTypeMap to
avoid overloading a virtual function.
No change of functionality. Just fixing a build warning, so no new tests.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
* svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::fillPassedAttributeToPropertyTypeMap):
* svg/SVGFilterPrimitiveStandardAttributes.h:
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::fillPassedAttributeToPropertyTypeMap):
* svg/SVGGradientElement.h:
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
* svg/SVGMissingGlyphElement.cpp:
(WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
* svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::fillPassedAttributeToPropertyTypeMap):
* svg/SVGStyledElement.h:
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::fillPassedAttributeToPropertyTypeMap):
* svg/SVGStyledTransformableElement.h:
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
* svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
* svg/SVGTSpanElement.cpp:
(WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::fillPassedAttributeToPropertyTypeMap):
* svg/SVGTextContentElement.h:
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
* svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap):
* svg/SVGTextPositioningElement.h:
* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
* svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
2011-02-11 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
https://bugs.webkit.org/show_bug.cgi?id=54089
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize):
(WebInspector.Drawer.prototype.immediatelyFinishAnimation):
(WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
(WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
(WebInspector.Drawer.prototype._animateDrawerHeight):
(WebInspector.Drawer.prototype._statusBarDragging):
* inspector/front-end/inspector.js:
(WebInspector.animateStyle):
(WebInspector.animateStyle.forceComplete):
(WebInspector.animateStyle.cancel):
(WebInspector.showSourceLine):
2011-02-10 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Make DocumentWriter a member of DocumentLoader
instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=50489
Refactor, no new tests.
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::explicitClose):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
* dom/Document.h:
(WebCore::Document::setDocumentLoader):
(WebCore::Document::loader):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::setFrame):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::writer):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/DocumentWriter.h:
(WebCore::DocumentWriter::setFrame):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::finishedLoadingDocument):
(WebCore::FrameLoader::addExtraFieldsToRequest):
* loader/FrameLoader.h:
(WebCore::FrameLoader::notifier):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2011-02-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make InspectorAgent own sub-agents, align agent creation/deletion routines.
https://bugs.webkit.org/show_bug.cgi?id=54227
* dom/Document.cpp:
(WebCore::Document::finishedParsing):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
(WebCore::InspectorAgent::loadEventFired):
(WebCore::InspectorAgent::startTimelineProfiler):
(WebCore::InspectorAgent::stopTimelineProfiler):
* inspector/InspectorAgent.h:
* inspector/InspectorCSSAgent.cpp:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::startListening):
(WebCore::InspectorDOMAgent::stopListening):
(WebCore::InspectorDOMAgent::mainDOMContentLoaded):
(WebCore::InspectorDOMAgent::loadEventFired):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
* inspector/InspectorDOMStorageAgent.h:
(WebCore::InspectorDOMStorageAgent::create):
* inspector/InspectorDOMStorageResource.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::executeSQL):
(WebCore::InspectorDatabaseAgent::selectDatabase):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
* inspector/InspectorDatabaseAgent.h:
(WebCore::InspectorDatabaseAgent::FrontendProvider::create):
(WebCore::InspectorDatabaseAgent::FrontendProvider::~FrontendProvider):
(WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
(WebCore::InspectorDatabaseAgent::FrontendProvider::clearFrontend):
(WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorDatabaseAgent::create):
* inspector/InspectorDatabaseResource.cpp:
(WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
(WebCore::InspectorDatabaseResource::bind):
* inspector/InspectorDatabaseResource.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::mute):
(WebCore::InspectorState::updateCookie):
* inspector/InspectorState.h:
(WebCore::InspectorState::~InspectorState):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::didCommitLoad):
(WebCore::InspectorTimelineAgent::setFrontend):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::create):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line API $0 regressed.
https://bugs.webkit.org/show_bug.cgi?id=54283
* inspector/InjectedScriptSource.js:
2011-02-11 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Andreas Kling.
[Qt][S60] Vertical borders of buttons and frames are misaligned
https://bugs.webkit.org/show_bug.cgi?id=51169
Force anti-aliasing for lines and rects when using OpenVG backend on Symbian.
OpenVG cannot guarantee rendering to be on pixel in floating point co-ordinates
without anti-aliasing. Patch idea by Laszlo Agocs.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
2011-02-11 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831
Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.
Test: platform/gtk/accessibility/document-reload-events.html
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_name): Returns the current document's title
as fallback mechanism for webArea objects.
(webkit_accessible_detach): Emit 'state-change::defunct' function
as soon as the wrapper is detached from the related core object.
2011-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: command line's API inspect() is broken.
https://bugs.webkit.org/show_bug.cgi?id=54275
Test: inspector/command-line-api.html
* inspector/InjectedScriptSource.js:
2011-02-11 Adam Barth <abarth@webkit.org>
Turns out window.crypto is supposed to be readonly.
* page/DOMWindow.idl:
2011-02-11 Adam Barth <abarth@webkit.org>
Actually add Crypto.cpp to the Windows build. I'm terrible.
* WebCore.vcproj/WebCore.vcproj:
2011-02-11 Adam Barth <abarth@webkit.org>
Attempt to fix the Windows build. Apparently we don't support
conditional attributes on functions. This patch makes the whole Crypto
interface conditional on ArrayBuffer support.
* page/DOMWindow.idl:
* page/Crypto.cpp:
* page/Crypto.h:
* page/Crypto.idl:
2011-02-10 Antti Koivisto <antti@apple.com>
Reviewed by Dave Hyatt.
Enable ancestor identifier filtering for tree building
https://bugs.webkit.org/show_bug.cgi?id=54241
Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent
element stack as needed.
This roughly halves the remaining time in style matching over a typical page load.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::pushParentStackFrame):
(WebCore::CSSStyleSelector::popParentStackFrame):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
* dom/Document.h:
(WebCore::Document::styleSelectorIfExists):
* dom/Element.cpp:
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
* dom/Element.h:
2011-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
WebKit should have a cryptographic RNG
https://bugs.webkit.org/show_bug.cgi?id=22049
Add crypto.getRandomValues. Yes, all these diffs are required to
expose a single function to the DOM.
Test: security/crypto-random-values.html
* Android.mk:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* ForwardingHeaders/wtf/CryptographicallyRandomNumber.h: Added.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* config.h:
* page/Crypto.cpp: Added.
(WebCore::Crypto::Crypto):
(WebCore::Crypto::getRandomValues):
* page/Crypto.h: Added.
(WebCore::Crypto::create):
* page/Crypto.idl: Added.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::crypto):
* page/DOMWindow.h:
(WebCore::DOMWindow::optionalCrypto):
* page/DOMWindow.idl:
2011-02-11 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[GTK] Build break with 2.18.3
https://bugs.webkit.org/show_bug.cgi?id=54057
* platform/gtk/ScrollbarThemeGtk2.cpp: Include GtkVersioning.h
2011-02-11 Cosmin Truta <ctruta@chromium.org>
Reviewed by Adam Barth.
Templatize KURLGooglePrivate::init
https://bugs.webkit.org/show_bug.cgi?id=53749
No new tests. Refactoring.
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::init):
* platform/KURLGooglePrivate.h:
2011-02-10 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
Convert ContainerNode::firstElementChild() to a free function.
https://bugs.webkit.org/show_bug.cgi?id=54269
No new tests. No change in behavior.
It seemed incorrect to have a method on ContainerNode that had the
concept of an Element but couldn't return an Element*, but a method on
Element could not be called by holders of ContainerNodes or other
non-Element ContainerNode subclasses. A free function can both return
an Element* and be called by anyone with a ContainerNode*.
* dom/ContainerNode.h:
(WebCore::ContainerNode::lastChild):
(WebCore::Node::lastChild):
* dom/Document.cpp:
(WebCore::Document::cacheDocumentElement):
* dom/Element.cpp:
(WebCore::Element::firstElementChild):
* dom/Element.h:
(WebCore::firstElementChild):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
2011-02-10 Mads Ager <ager@chromium.org>
Reviewed by Nate Chapin.
[V8] Don't crash on exception getting event handler function
https://bugs.webkit.org/show_bug.cgi?id=54216
Check for exceptions when attempting to get the handleEvent property
of an event-handler object.
Test: fast/dom/exception-getting-event-handler.html
* bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::getListenerFunction):
2011-02-10 Naoki Takano <takano.naoki@gmail.com>
Reviewed by James Robinson.
[Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53857
globalAlpha is not applied to fillPath() and fillRect().
Test: fast/canvas/2d.composite.globalAlpha.fillPath.html and canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::State::applyAlpha): Append a new function to apply global alpha when fillRect() and fillPath() are called.
(WebCore::GLES2Canvas::fillRect): Global alpha is applied to m_fillColor.
(WebCore::GLES2Canvas::fillPath): Global alpha is applied to m_fillColor.
2011-02-10 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Remove an unneeded argument from HTMLDocument::create().
https://bugs.webkit.org/show_bug.cgi?id=54268
Now that HTMLTreeBuilder no longer uses a dummy HTMLDocument for
fragment parsing, there isn't a need to explicitly specify a baseURL
when constructing an HTMLDocument. We can remove the unneeded argument.
Also fix some style issues in Document.h and HTMLDocument.h caught by
check-webkit-style.
No new tests. No change in behavior.
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::HTMLDocument):
* html/HTMLDocument.h:
(WebCore::HTMLDocument::create):
2011-02-10 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Cached JavaScript Parser Data Being Left in Memory Cache
https://bugs.webkit.org/show_bug.cgi?id=54245
Added logic in CachedScript to clear SourceProviderCache data in
destroyDecodedData(). Added and changed CachedScript timeout to
act similar to CachedImage. Changed didAddClient to call super
class method instead of duplicating the logic in the derived
classes.
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::didAddClient):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::didAddClient):
(WebCore::CachedScript::allClientsRemoved):
(WebCore::CachedScript::script):
(WebCore::CachedScript::destroyDecodedData):
* loader/cache/CachedScript.h:
2011-02-10 Cosmin Truta <ctruta@chromium.org>
Reviewed by David Levin.
Fix style in KURLGooglePrivate
https://bugs.webkit.org/show_bug.cgi?id=54228
Replace occurrences of NULL with 0, '\0' or null (as applicable),
to appease check-webkit-style.
No new tests. This is a style fix.
* platform/KURLGoogle.cpp:
* platform/KURLGooglePrivate.h:
2011-02-10 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719
The HTML5 fragment parsing algorithm specifies that a new Document
should be created to serve as the temporary parent of fragment nodes
during parsing. Document creation is expensive and accounts for ~38% of
the Peacekeeper DOM performance regression. Avoid the cost of creating
a dummy document by using the already-created DocumentFragment as the
root node during fragment parsing.
With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
is ~24%.
Test: fast/parser/fragment-parser-doctype.html
* dom/ContainerNode.h:
(WebCore::ContainerNode::firstElementChild): Add a method that returns
the first element-typed child from a ContainerNode.
* dom/Document.cpp:
(WebCore::Document::cacheDocumentElement): Call
ContainerNode::firstElementChild() to retrieve and cache the document
element.
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::HTMLConstructionSite): Initialize the
root ContainerNode.
(WebCore::HTMLConstructionSite::detach): Clear the reference to the
root ContainerNode.
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
Attach the new element to the root ContainerNode.
(WebCore::HTMLConstructionSite::insertDoctype): Ditto.
(WebCore::HTMLConstructionSite::insertCommentOnDocument): Ditto.
* html/parser/HTMLConstructionSite.h: Store a pointer to a
ContainerNode that will be used as the root node for document parsing.
This node might or might not be the same as m_document.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the
HTMLConstructionSite with the correct root ContainerNode based on
whether or not we're parsing a fragment.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
Remove m_dummyDocumentForFragmentParsing.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): If the
fragment has a context element, store only the children of the root
element (HTML5 Section 10.4, Step 7).
* html/parser/HTMLTreeBuilder.h:
2011-02-10 Beth Dakin <bdakin@apple.com>
Reviewed by Oliver Hunt.
Speculative fix for <rdar://problem/8971107> CrashTracer: 6 crashes
in WebProcess at com.apple.AppKit:
-[NSAnimation(NSInternal) _advanceTimeWithTimer:] + 154
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
2011-02-09 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB event targets need to ensure their wrappers aren't garbage collected
https://bugs.webkit.org/show_bug.cgi?id=54144
hasActivityPending should return true as long as it's possible that we'll
fire more event listeners on our event targets. It is still possible for
user generated events to run into problems, but I'm not sure how to address
that yet (or how big of a deal it is).
There's really no way to test this deterministically. Testing by hand makes
it seem like this patch works as expected though.
* storage/IDBCursorBackendImpl.cpp:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::hasPendingActivity):
(WebCore::IDBDatabase::stop):
* storage/IDBDatabase.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::hasPendingActivity):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
* storage/IDBRequest.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::finished):
(WebCore::IDBTransaction::hasPendingActivity):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::canSuspend):
(WebCore::IDBTransaction::contextDestroyed):
(WebCore::IDBTransaction::enqueueEvent):
* storage/IDBTransaction.h:
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] create pkg-config files for mingw
https://bugs.webkit.org/show_bug.cgi?id=54238
(mingw is mostly the same as unix)
This change was applied in the Qt repository (qt/src/3rdparty/webkit),
so we should do the same here in QtWebKit.
Patch by Mark Brand <mabrand@mabrand.nl>, reviewed (there) by
Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
45fe2dddc3a0677b9ec9fce09f07cd4129e37afa
* WebCore.pro:
2011-02-10 Andreas Kling <kling@webkit.org>
Reviewed by Antti Koivisto.
RenderStyle: Remove duplicate comparison of InheritedFlags::_text_transform
https://bugs.webkit.org/show_bug.cgi?id=54246
* rendering/style/RenderStyle.h:
2011-02-10 Dirk Schulze <krit@webkit.org>
Reviewed by Andreas Kling.
SVG animation avoid unnecessary adjust for currentColor
https://bugs.webkit.org/show_bug.cgi?id=54243
At the moment we try to adjust every animation value for currentColor - independent of the animation type.
Since the value is a string and the target element may needs to get called by getElementById, this could
be an expensive and unnecessary operation. Also after we adjust for currentColor, we save the result back
as a string and parse it to Color afterwards again.
With the patch we just adjust an animation value, if we use color animation. The color won't get saved and
parsed as a string again.
No change of functionality, no new tests.
* svg/SVGAnimateElement.cpp:
(WebCore::adjustForCurrentColor):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::startedActiveInterval):
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Remove the use of deprecated qFindChildren()
https://bugs.webkit.org/show_bug.cgi?id=54232
This was applied on the Qt repository and affects QtWebKit there.
(13833beb641289c45faed337848d37280195aadc)
The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if that's possible today anyway).
Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.
The changes are result of the following commands:
git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(this,* */f\\1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(&\([^\(),]*\),* */\\2.f\\1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*()\),* */\\2->f\\1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*\):\([^\(),]*\),* */(\\2:\\3)->f\\1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*\),* */\\2->f\\1(/'" qFindChild
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivatePhonon::MediaPlayerPrivatePhonon):
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Rename build target from "embedded" to "qpa"
https://bugs.webkit.org/show_bug.cgi?id=54233
This flag is used by Qt's configure script to enable a QPA build
("QPA is a window system agnostic implementation of Qt" --
previously known as lighthouse).
On the Qt repository, this was changed by two commits:
13a0b4935900093607f2b3b7688e1452d22770fd
(from embedded to embedded_lite)
9716e12e0f5590ebc23ad9fb7ba75c6a3c5aadab
(from embedded_lite to qpa)
* WebCore.pro:
2011-02-10 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Incorporate algorithm for processing paths into GPU-renderable triangle meshes
https://bugs.webkit.org/show_bug.cgi?id=45521
Adding an implementation of Loop and Blinn's GPU accelerated path
rendering algorithm from GPU Gems 3. This implementation pays
particular attention to the efficiency of the curve subdivision
phase needed for correct rendering. It utilizes the OpenGL utility
library tessellator for triangulation of the interior of the
shape. The regions handled by Loop and Blinn's algorithm are
handled by the local triangulator previously incorporated.
No tests yet; pixel tests will eventually be used to verify this
algorithm and prevent regressions.
* platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Added.
(WebCore::LoopBlinnPathProcessorImplementation::Segment::Segment):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::setup):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::kind):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::getPoint):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::next):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::prev):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::setNext):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::setPrev):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::contour):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::subdivide):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::boundingBox):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::numCrossingsForXRay):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfTriangles):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::getTriangle):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfInteriorVertices):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::getInteriorVertex):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::markedForSubdivision):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::setMarkedForSubdivision):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::toString):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::computeBoundingBox):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::Contour):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::add):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::subdivide):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::begin):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::end):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::isOrientedCounterClockwise):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::setIsOrientedCounterClockwise):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::boundingBox):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::fillSide):
(WebCore::LoopBlinnPathProcessorImplementation::Contour::setFillSide):
(WebCore::LoopBlinnPathProcessorImplementation::Segment::triangulate):
(WebCore::LoopBlinnPathProcessor::LoopBlinnPathProcessor):
(WebCore::LoopBlinnPathProcessor::~LoopBlinnPathProcessor):
(WebCore::LoopBlinnPathProcessor::process):
(WebCore::LoopBlinnPathProcessor::buildContours):
(WebCore::LoopBlinnPathProcessor::allSegmentsOverlappingY):
(WebCore::LoopBlinnPathProcessor::determineSidesToFill):
(WebCore::LoopBlinnPathProcessor::determineOrientation):
(WebCore::SweepData::SweepEvent::SweepEvent):
(WebCore::SweepData::SweepEvent::setup):
(WebCore::SweepData::SweepEvent::x):
(WebCore::SweepData::SweepEvent::entry):
(WebCore::SweepData::SweepEvent::interval):
(WebCore::SweepData::SweepEvent::operator<):
(WebCore::SweepData::trianglesOverlap):
(WebCore::LoopBlinnPathProcessor::subdivideCurves):
(WebCore::LoopBlinnPathProcessor::conditionallySubdivide):
(WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
(WebCore::TessellationState::vertexCallback):
(WebCore::TessellationState::combineCallback):
(WebCore::TessellationState::edgeFlagCallback):
(WebCore::LoopBlinnPathProcessor::tessellateInterior):
* platform/graphics/gpu/LoopBlinnPathProcessor.h: Added.
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Remove the use of deprecated qVariant*
https://bugs.webkit.org/show_bug.cgi?id=54229
This was applied on the Qt repository and affects QtWebKit there.
(633f3f45e5420663cf4ceadea79e62fea44cd2eb)
The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if it's possible today anyway).
Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.
The changes are result of the following commands:
git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
git grep -O"sed -i 's/qVariantSetValue(\([^&*\(),]*\), */\\1.setValue(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantSetValue *<\([^>]*\)> *(\([^&*\(),]*\), */\\2.setValue<\\1>(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*([^&*\(),]*)\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue\\1/'" qVariantFromValue
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::commitLoad):
2011-02-10 Nico Weber <thakis@chromium.org>
Reviewed by Darin Adler.
Fix clang warning "WebCore::HTMLAreaElement::getRect' hides overloaded virtual function [-Woverloaded-virtual]"
https://bugs.webkit.org/show_bug.cgi?id=54221
The method name conflicts with ContainerNode::getRect() so rename it to
computeRect(). Rename getPath() to computePath() for consistency as
well.
No intended functionality change, covered by existing tests.
* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::elementRect):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
* html/HTMLAreaElement.h:
* page/SpatialNavigation.cpp:
(WebCore::virtualRectForAreaElementAndDirection):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintFocusRing):
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] Default focus ring is too wide
https://bugs.webkit.org/show_bug.cgi?id=51854
We now respect the outline property and html.css defines the outline of the focus
ring to be 5px. This is propagated until GraphicsContext::drawFocusRing which uses
it as the pen size. We should ignore the size and keep a default one. I also
reverted the SolidLine to DotLine so that the selection looks nicer. Chromium Skia,
CG Win, Haiku, WinCE ports also ignore the width.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::drawFocusRingForPath):
(WebCore::GraphicsContext::drawFocusRing):
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Soup] ResourceHandleSoup does not ever call didSendData for file uploads
https://bugs.webkit.org/show_bug.cgi?id=52090
Call didSendData as body data is uploaded to the server. This is necessary
for XHR upload events to function properly.
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal): Add two new members.
One to track the total amount of body data and one to track the total amount of
body data sent so far.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::wroteBodyDataCallback): Added.
(WebCore::addFormElementsToSoupMessage): Split this out into a helper function.
Will now now sum the total amount of body data.
(WebCore::startHttp): Attach a wrote-body-data signal handler.
2011-02-10 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
Add fields to ResourceRequest and ResourceResponse in preparation for adding CORS support to AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=53925
* platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
* platform/network/chromium/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::downloadToFile):
(WebCore::ResourceRequest::setDownloadToFile):
* platform/network/chromium/ResourceResponse.cpp:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::downloadFilePath):
(WebCore::ResourceResponse::setDownloadFilePath):
2011-02-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimateElement needs information about the animated attribute type
https://bugs.webkit.org/show_bug.cgi?id=53442
For animations, we need to know the SVG property type for a XML attribute. A global static mapping between
attribute name and a type is not possible, since one attribute name can be bound to different property types:
x can be a SVGNumberList, a SVGNumber or a SVGLength. So we have to ask every target element, if it supports
the animated attribute and of which type it is. Just for CSS properties we can share an explicit mapping between
the name and the type. This is done in a static map in SVGStyledElement. All other mappings are stored in local static
HashMaps for all SVG elements with animated properties. These maps get filled once with the fillAttributeToPropertyTypeMap function
that needs to be included in every SVG element. The function is not virtual in base classes for performance reasons.
No change of functionality, so no new test cases.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::attributeToPropertyTypeMap):
(WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
* svg/SVGAElement.h:
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::attributeToPropertyTypeMap):
(WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
* svg/SVGAltGlyphElement.h:
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::determinePropertyType):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::attributeToPropertyTypeMap):
(WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
* svg/SVGCircleElement.h:
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::attributeToPropertyTypeMap):
(WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
* svg/SVGClipPathElement.h:
* svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::attributeToPropertyTypeMap):
(WebCore::SVGComponentTransferFunctionElement::fillAttributeToPropertyTypeMap):
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::attributeToPropertyTypeMap):
(WebCore::SVGCursorElement::fillAttributeToPropertyTypeMap):
* svg/SVGCursorElement.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::attributeToPropertyTypeMap):
(WebCore::SVGElement::animatedPropertyTypeForAttribute):
* svg/SVGElement.h:
(WebCore::SVGElement::fillAttributeToPropertyTypeMap):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::attributeToPropertyTypeMap):
(WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
* svg/SVGEllipseElement.h:
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::attributeToPropertyTypeMap):
(WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::attributeToPropertyTypeMap):
(WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::attributeToPropertyTypeMap):
(WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::attributeToPropertyTypeMap):
(WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
* svg/SVGFECompositeElement.h:
* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::attributeToPropertyTypeMap):
(WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEConvolveMatrixElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::attributeToPropertyTypeMap):
(WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::attributeToPropertyTypeMap):
(WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::attributeToPropertyTypeMap):
(WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEFloodElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::attributeToPropertyTypeMap):
(WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::attributeToPropertyTypeMap):
(WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEImageElement.h:
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::attributeToPropertyTypeMap):
(WebCore::SVGFELightElement::fillAttributeToPropertyTypeMap):
* svg/SVGFELightElement.h:
* svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::attributeToPropertyTypeMap):
(WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEMergeElement.h:
* svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::attributeToPropertyTypeMap):
(WebCore::SVGFEMergeNodeElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEMergeNodeElement.h:
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::attributeToPropertyTypeMap):
(WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::attributeToPropertyTypeMap):
(WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
* svg/SVGFEOffsetElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::attributeToPropertyTypeMap):
(WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::attributeToPropertyTypeMap):
(WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
* svg/SVGFETileElement.h:
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::attributeToPropertyTypeMap):
(WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
* svg/SVGFETurbulenceElement.h:
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::attributeToPropertyTypeMap):
(WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
* svg/SVGFilterElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::fillAttributeToPropertyTypeMap):
* svg/SVGFilterPrimitiveStandardAttributes.h:
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::attributeToPropertyTypeMap):
(WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
* svg/SVGFontElement.h:
(WebCore::SVGFontElement::rendererIsNeeded):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::attributeToPropertyTypeMap):
(WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
* svg/SVGForeignObjectElement.h:
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::attributeToPropertyTypeMap):
(WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
* svg/SVGGlyphElement.h:
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::fillAttributeToPropertyTypeMap):
* svg/SVGGradientElement.h:
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::attributeToPropertyTypeMap):
(WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
* svg/SVGImageElement.h:
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::attributeToPropertyTypeMap):
(WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
* svg/SVGLineElement.h:
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::attributeToPropertyTypeMap):
(WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
* svg/SVGLinearGradientElement.h:
* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::attributeToPropertyTypeMap):
(WebCore::SVGMPathElement::fillAttributeToPropertyTypeMap):
* svg/SVGMPathElement.h:
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::attributeToPropertyTypeMap):
(WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
* svg/SVGMarkerElement.h:
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::attributeToPropertyTypeMap):
(WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
* svg/SVGMaskElement.h:
* svg/SVGMissingGlyphElement.cpp:
(WebCore::SVGMissingGlyphElement::attributeToPropertyTypeMap):
(WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
* svg/SVGMissingGlyphElement.h:
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::attributeToPropertyTypeMap):
(WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
* svg/SVGPathElement.h:
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::attributeToPropertyTypeMap):
(WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
* svg/SVGPatternElement.h:
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::attributeToPropertyTypeMap):
(WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
* svg/SVGPolyElement.h:
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::attributeToPropertyTypeMap):
(WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
* svg/SVGRadialGradientElement.h:
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::attributeToPropertyTypeMap):
(WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
* svg/SVGRectElement.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::attributeToPropertyTypeMap):
(WebCore::SVGSVGElement::fillAttributeToPropertyTypeMap):
* svg/SVGSVGElement.h:
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::attributeToPropertyTypeMap):
(WebCore::SVGScriptElement::fillAttributeToPropertyTypeMap):
* svg/SVGScriptElement.h:
* svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::attributeToPropertyTypeMap):
(WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
* svg/SVGStopElement.h:
* svg/SVGStyledElement.cpp:
(WebCore::cssPropertyToTypeMap):
(WebCore::SVGStyledElement::animatedPropertyTypeForCSSProperty):
(WebCore::SVGStyledElement::fillAttributeToPropertyTypeMap):
* svg/SVGStyledElement.h:
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::fillAttributeToPropertyTypeMap):
* svg/SVGStyledTransformableElement.h:
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::attributeToPropertyTypeMap):
(WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
* svg/SVGSwitchElement.h:
* svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::attributeToPropertyTypeMap):
(WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
* svg/SVGSymbolElement.h:
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::attributeToPropertyTypeMap):
(WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
* svg/SVGTRefElement.h:
* svg/SVGTSpanElement.cpp:
(WebCore::SVGTSpanElement::attributeToPropertyTypeMap):
(WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
* svg/SVGTSpanElement.h:
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::fillAttributeToPropertyTypeMap):
* svg/SVGTextContentElement.h:
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::attributeToPropertyTypeMap):
(WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
* svg/SVGTextElement.h:
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::attributeToPropertyTypeMap):
(WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
* svg/SVGTextPathElement.h:
* svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::fillAttributeToPropertyTypeMap):
* svg/SVGTextPositioningElement.h:
* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::attributeToPropertyTypeMap):
(WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
* svg/SVGTitleElement.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::attributeToPropertyTypeMap):
(WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
* svg/SVGUseElement.h:
* svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::attributeToPropertyTypeMap):
(WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
* svg/SVGViewElement.h:
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
Fix a Warning after removing FileSystem support for the inspector.
* WebCore.pro:
2011-02-10 Chris Fleizach <cfleizach@apple.com>
Reviewed by Anders Carlsson.
AX: AX needs to stop using WebCoreViewFactory
https://bugs.webkit.org/show_bug.cgi?id=54153
WebKit2 no longer uses WebCoreViewFactory, which means that accessibility code needs
to get off of it and use WebCoreSystemInterface, like other clients.
* WebCore.exp.in:
* accessibility/AXObjectCache.h:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
* accessibility/mac/AccessibilityObjectWrapper.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(textMarkerForVisiblePosition):
(-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[AccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributeStringSetElement):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* editing/mac/SelectionControllerMac.mm:
(WebCore::accessibilityConvertScreenRect):
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] In trunk with Qt Multimedia the full screen mode doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=54201
Add files for the fullscreen video playback handling. It also fix
a missing header.
* WebCore.pro:
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Remove FileSystem support from the inspector.
https://bugs.webkit.org/show_bug.cgi?id=50695
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.idl:
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorFileSystemAgent.cpp: Removed.
* inspector/InspectorFileSystemAgent.h: Removed.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::scriptImportedImpl):
(WebCore::InspectorInstrumentation::networkStateChangedImpl):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
(WebCore::InspectorInstrumentation::retrieveResourceAgent):
* inspector/front-end/FileSystemView.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-02-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78219.
http://trac.webkit.org/changeset/78219
https://bugs.webkit.org/show_bug.cgi?id=54215
breaks editing/style/iframe-onload-crash.html on GTK 64-bit
Debug (Requested by philn-tp on #webkit).
* dom/Document.h:
* dom/DocumentFragment.h:
* dom/Element.h:
* dom/Node.h:
* dom/Text.h:
* editing/htmlediting.cpp:
(WebCore::editingIgnoresContent):
(WebCore::canHaveChildrenForEditing):
* editing/htmlediting.h:
* html/HTMLBRElement.h:
* html/HTMLButtonElement.h:
* html/HTMLDataGridElement.h:
* html/HTMLFormControlElement.h:
* html/HTMLFrameElementBase.h:
* html/HTMLHRElement.h:
* html/HTMLImageElement.h:
* html/HTMLMeterElement.h:
* html/HTMLOutputElement.h:
* html/HTMLPlugInElement.h:
* html/HTMLProgressElement.h:
* wml/WMLBRElement.h:
* wml/WMLDoElement.h:
* wml/WMLImageElement.h:
* wml/WMLInputElement.h:
* wml/WMLSelectElement.h:
2011-02-10 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt][V8] Fix the build.
No new tests needed.
* bindings/v8/WorkerContextExecutionProxy.cpp: add missing CString header.
* loader/cache/CachedScript.h: do not use extra qualification for base class enum.
2011-02-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [STYLES] Suggest CSS property values once Up/Down is pressed with an empty input
https://bugs.webkit.org/show_bug.cgi?id=54205
* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions):
(WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
* inspector/front-end/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
* inspector/front-end/StylesSidebarPane.js:
():
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
2011-02-10 Renata Hodovan <reni@webkit.org>
Reviewed by Dirk Schulze.
SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=54186
The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.
Tests: svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
* svg/SVGFESpecularLightingElement.h:
2011-02-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Error messages are not displayed for the last line in a script
https://bugs.webkit.org/show_bug.cgi?id=54204
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addMessage):
(WebInspector.SourceFrame.prototype._addMessageToSource):
(WebInspector.SourceFrame.prototype._createConditionElement):
2011-02-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Make canHaveChildrenForEditing more efficient
https://bugs.webkit.org/show_bug.cgi?id=53564
Improved the performance (1-2% in release and 20% in debug) by adding virtual member function
canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container
node for a position.
As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes
and any elements except:
HTML: applet, br, button, datagrid, embed, frame, frameset, hr, img, input,
meter, object, output, progress, and select.
WML: br, do, img, input, and select.
No new tests are added since this change cannot be tested directly.
* dom/Document.h:
(WebCore::Document::canContainRangeEndPoint): Added; returns false.
* dom/DocumentFragment.h:
(WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true.
* dom/Element.h:
(WebCore::Element::canContainRangeEndPoint): Ditto.
* dom/Node.h:
(WebCore::Node::canContainRangeEndPoint): Added; returns false.
* dom/Text.h:
(WebCore::Text::canContainRangeEndPoint): Added; returns true.
* editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing.
* editing/htmlediting.h:
(WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline.
(WebCore::canHaveChildrenForEditing): Ditto.
* html/HTMLBRElement.h:
(WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false.
* html/HTMLButtonElement.h:
(WebCore::HTMLButtonElement::canContainRangeEndPoint): Ditto.
* html/HTMLDataGridElement.h:
(WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto.
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto.
* html/HTMLFrameElementBase.h:
(WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto.
* html/HTMLHRElement.h:
(WebCore::HTMLHRElement::canContainRangeEndPoint): Ditto.
* html/HTMLImageElement.h:
(WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto.
* html/HTMLMeterElement.h:
(WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto.
* html/HTMLOutputElement.h:
(WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto.
* html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto.
* html/HTMLProgressElement.h:
(WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto.
* wml/WMLBRElement.h:
(WebCore::WMLBRElement::canContainRangeEndPoint): Ditto.
* wml/WMLDoElement.h:
(WebCore::WMLDoElement::canContainRangeEndPoint): Ditto.
* wml/WMLImageElement.h:
(WebCore::WMLImageElement::canContainRangeEndPoint): Ditto.
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::canContainRangeEndPoint): Ditto.
* wml/WMLSelectElement.h:
(WebCore::WMLSelectElement::canContainRangeEndPoint): Ditto.
2011-02-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: define interface per domain in Inspector.idl.
https://bugs.webkit.org/show_bug.cgi?id=54135
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
2011-02-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left
https://bugs.webkit.org/show_bug.cgi?id=54098
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype._updatePanelOffsets):
(WebInspector.TextViewer.prototype._syncScroll):
(WebInspector.TextViewer.prototype._syncDecorationsForLine):
(WebInspector.TextEditorChunkedPanel.prototype._totalHeight):
(WebInspector.TextEditorChunkedPanel.prototype.resize):
(WebInspector.TextEditorGutterPanel):
(WebInspector.TextEditorGutterChunk.prototype.set expanded):
(WebInspector.TextEditorGutterChunk.prototype.get height):
(WebInspector.TextEditorMainChunk.prototype.get height):
* inspector/front-end/textViewer.css:
(.webkit-line-content):
2011-02-10 takano takumi <takano@apple.com>
Reviewed by Dan Bernstein.
A full-width character rotated leftward 90 degrees in text-combine
https://bugs.webkit.org/show_bug.cgi?id=54169
* rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::combineText):
- Fixed by resetting font's orientation to horizontal when we decided to make combined text.
Otherwise the text will be unexpectedly rotated in showGlyphsWithAdvances() in FontMac.mm.
2011-02-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=50306
<rdar://problem/8976152> REGRESSION: WebChromeClient::shouldReplaceWithGeneratedFileForUpload()
uses an initialized result value (breaks form submission with clang-built WebKit)
No new test, because I can't reproduce the observable effect with my gcc build.
* platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Restore an
empty path check - an empty path was causing an exception in Foundation.
2011-02-09 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Network & Resource panels make multiple requests for images with no content
https://bugs.webkit.org/show_bug.cgi?id=54085
- Added success parameter to resourceContent
- NetworkManager.requestContent() now returns empty for zero-length resources, null for errors
* inspector/Inspector.idl:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::resourceData):
(WebCore::InspectorResourceAgent::resourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._contentURL):
2011-02-10 Renata Hodovan <reni@webkit.org>
Reviewed by Dirk Schulze.
Move the light source implementations into their own files.
https://bugs.webkit.org/show_bug.cgi?id=53996
Splitting LightSource.cpp into 3 files.
No new tests are added since this is a refactoring.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/DistantLightSource.cpp: Added.
(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::updatePaintingData):
(WebCore::DistantLightSource::setAzimuth):
(WebCore::DistantLightSource::setElevation):
(WebCore::DistantLightSource::externalRepresentation):
* platform/graphics/filters/LightSource.cpp:
* platform/graphics/filters/PointLightSource.cpp: Added.
(WebCore::PointLightSource::initPaintingData):
(WebCore::PointLightSource::updatePaintingData):
(WebCore::PointLightSource::setX):
(WebCore::PointLightSource::setY):
(WebCore::PointLightSource::setZ):
(WebCore::operator<<):
(WebCore::PointLightSource::externalRepresentation):
* platform/graphics/filters/SpotLightSource.cpp: Added.
(WebCore::SpotLightSource::initPaintingData):
(WebCore::SpotLightSource::updatePaintingData):
(WebCore::SpotLightSource::setX):
(WebCore::SpotLightSource::setY):
(WebCore::SpotLightSource::setZ):
(WebCore::SpotLightSource::setPointsAtX):
(WebCore::SpotLightSource::setPointsAtY):
(WebCore::SpotLightSource::setPointsAtZ):
(WebCore::SpotLightSource::setSpecularExponent):
(WebCore::SpotLightSource::setLimitingConeAngle):
(WebCore::operator<<):
(WebCore::SpotLightSource::externalRepresentation):
2011-02-10 Avi Drissman <avi@google.com>
Reviewed by Darin Fisher.
<option> should implement the dir attribute. Mac Chromium version, followup to r76983, r77654.
https://bugs.webkit.org/show_bug.cgi?id=50969
Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html added in r76983.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::updateFromElement):
* platform/chromium/PopupMenuChromium.h:
2011-02-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Update the semantics of put()
https://bugs.webkit.org/show_bug.cgi?id=54102
Update the semantics of put: For object stores with auto increment,
it should be allowed to provide an explicit key, or an in-line key,
overriding the key generator mechanism.
This reflects the spec changes suggested here:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11976
Extracting key-selection logic into its own function
to make it a bit easier on the eyes.
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::selectKeyForPut):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
* storage/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::resetAutoIncrementKeyCache):
2011-02-09 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=54103
Implement fast path for matching simple selectors
Implement a fast path for single and descendant selectors consisting
of id, class and tag selectors only.
Selectors like this are marked on style selector initialization. When
encountered during style matching they are resolved using a fast path.
Since selectors like this are very common this speeds up style matching
quite a bit (up to 50% on some sites according to Shark).
* css/CSSStyleSelector.cpp:
(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasTopSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::selectorTagMatches):
(WebCore::isFastCheckableSelector):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::RuleData):
* css/CSSStyleSelector.h:
2011-02-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r77101) box-shadow sometimes renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=54160
Fix an issue when ShadowBlur had a cached image buffer
that was larger than that of the current shadow being drawn,
and the current shadow was partially clipped out.
In that situation endShadowLayer() would clip to the image
buffer, using the size of the buffer (as it must), but failed
to take into account the fact that we'd only cleared and painted
into a smaller section of the buffer. So we need to additionally
constrain the clip to cover only the valid part of the buffer.
Test: fast/box-shadow/shadow-buffer-partial.html
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::endShadowLayer):
2011-02-09 Beth Dakin <bdakin@apple.com>
Reviewed by Maciej Stachowiak.
Fix for <rdar://problem/8977051> CrashTracer: 8 crashes
in WebProcess at com.apple.WebCore:
-[ScrollbarPartAnimation setCurrentProgress:] + 364
The ScrollbarPartAnimation must be sent by reference!
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053
The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
the position variable "s" is not null.
Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.
Test: fast/forms/file-input-hit-test.html
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::toNormalizedRange):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::positionForPoint):
* rendering/RenderFileUploadControl.h:
2011-02-09 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Overlay scrollbars crash used with a RenderListBox.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):
(WebCore::RenderListBox::setHasVerticalScrollbar):
* rendering/RenderListBox.h:
Implement enough of the ScrollableArea interface to get things generally
working.
2011-02-09 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
Fix for <rdar://problem/8966868> ScrollbarPainterDelegate
must return a layer if layer-backed to avoid crashing
New virtual function scrollbarWillRenderIntoCompositingLayer()
on ScrollableArea.
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollbarWillRenderIntoCompositingLayer):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::scrollbarWillRenderIntoCompositingLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollbarWillRenderIntoCompositingLayer):
* rendering/RenderListBox.h:
Clean up unnecessary method declarations and call
scrollbarWillRenderIntoCompositingLayer() to deterine if
we need to return a layer.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate layer]):
2011-02-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Replace static_cast<HTMLElement*> with toHTMLElement
https://bugs.webkit.org/show_bug.cgi?id=54117
No new tests since no new functionality was introduced.
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::addChildren):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::addChildren):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_name):
(webkit_accessible_get_description):
* bindings/gobject/WebKitDOMBinding.cpp:
(WebKit::createWrapper):
(WebKit::kit):
* bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::nameGetter):
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/v8/custom/V8ElementCustom.cpp:
(WebCore::toV8):
* dom/Document.cpp:
(WebCore::Document::body):
* dom/Element.cpp:
(WebCore::Element::deprecatedCreateContextualFragment):
* dom/Range.cpp:
(WebCore::Range::createContextualFragment):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
(WebCore::ApplyStyleCommand::removeInlineStyle):
(WebCore::ApplyStyleCommand::shouldSplitTextElement):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
* editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::show):
* editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::mergeWithNeighboringLists):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::copyStyleToChildren):
* editing/SelectionController.cpp:
(WebCore::scanForForm):
(WebCore::SelectionController::currentForm):
* editing/htmlediting.cpp:
(WebCore::enclosingList):
(WebCore::enclosingListChild):
(WebCore::embeddedSublist):
(WebCore::appendedSublist):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendElement):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setOuterHTML):
(WebCore::HTMLElement::shadowAncestorOwnerForm):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setOption):
(WebCore::HTMLSelectElement::setLength):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::createPart):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::createSubtreeIfNeeded):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
2011-02-09 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
Use Skia's device->readPixels() when its bitmap claims to have no pixels, as this
handles the case when the device is backed by the GPU.
Patch developed by bsalomon@google.com
No new tests. Existing canvas tests suffice
e.g. LayoutTests/canvas/philip/...
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.close shouldn't affect non-script-created parsers
https://bugs.webkit.org/show_bug.cgi?id=53689
Tests: fast/frames/document-write-in-iframe-onload-3.html
fast/parser/iframe-onload-document-close-with-external-script-2.html
fast/parser/iframe-onload-document-close-with-external-script-3.html
fast/parser/iframe-onload-document-close-with-external-script.html
fast/parser/setTimeout-open.html
Move our implementation of document.close closer to the spec by
introducing the notion of a script-created parser. This area of our
code is somewhat hairy. It might take a few more iterations before we
fully come up to spec.
* dom/Document.cpp:
(WebCore::Document::setContent):
(WebCore::Document::open):
(WebCore::Document::cancelParsing):
(WebCore::Document::close):
- Over time, this method should converge to the spec.
(WebCore::Document::explicitClose):
- I'm not in love with this name. Somehow we want to differentiate
between Document closing itself and the document.close DOM
method.
(WebCore::Document::removePendingSheet):
* dom/Document.h:
* dom/ScriptableDocumentParser.cpp:
(WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
* dom/ScriptableDocumentParser.h:
(WebCore::ScriptableDocumentParser::setWasCreatedByScript):
(WebCore::ScriptableDocumentParser::wasCreatedByScript):
- General nonsense to keep track of whether the parser was created
by script.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::hasInsertionPoint):
- I'm not sure whether this part of the change is 100% correct. I
think our notion of the EOF character might be subtly different
from the notion in the spec.
* html/parser/HTMLInputStream.h:
(WebCore::HTMLInputStream::hasInsertionPoint):
- Remove FIXME because we're fixing that!
2011-02-09 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
[Chromium] Issue 72387: Integer bounds crash in LayerTilerChromium::resizeLayer
https://bugs.webkit.org/show_bug.cgi?id=54132
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::resizeLayer):
2011-02-09 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Use #f7f7f7 for select popup background on chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=54115
No new tests since no behavior change.
* css/themeChromiumLinux.css:
(select[size="1"] option):
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(HTML 5): HTMLDocumentParser does not report html parse errors to the console
https://bugs.webkit.org/show_bug.cgi?id=41187
Wire up a basic HTML parse error message. There's a lot of room for
improvement in this area, but this is a start.
No tests! See https://bugs.webkit.org/show_bug.cgi?id=54134
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::parseError):
* html/parser/HTMLTreeBuilder.h:
2011-02-09 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kenneth Russell.
[Chromium] Issue 58536: Fix Layout Test canvas/philip/tests/2d.imageData.put.alpha.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53757
This fix is for 2d.imageData.put.alpha.html with --accelerated-2d-canvas. No new tests.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::putUnmultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software.
(WebCore::ImageBuffer::putPremultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software.
2011-02-09 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix scaling and thread safety of FFTFrameFFTW
https://bugs.webkit.org/show_bug.cgi?id=54045
No new tests since audio API is not yet implemented.
* platform/audio/FFTFrame.h:
* platform/audio/fftw/FFTFrameFFTW.cpp:
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::fftwPlanForSize):
* platform/audio/mac/FFTFrameMac.cpp:
(WebCore::FFTFrame::initialize):
* platform/audio/mkl/FFTFrameMKL.cpp:
(WebCore::FFTFrame::initialize):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
2011-02-09 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: accessibilityShouldUseUniqueId doesn't need to be in the core AX object
https://bugs.webkit.org/show_bug.cgi?id=54126
This is a Mac-only accessibility API concept and doesn't belong in the core AX object.
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::node):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
2011-02-09 Nebojsa Ciric <cira@chromium.org>
Reviewed by Darin Fisher.
Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414
Test: fast/js/i18n-bindings-locale.html
* WebCore.gyp/WebCore.gyp:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::experimentalI18NAPIEnabled):
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setExperimentalI18NAPIEnabled):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):
2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065
* dom/Node.cpp:
(WebCore::pullOutOfShadow): Added a helper to move a node to the outermost
boundary of shadow DOM.
(WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.
2011-02-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Add convenience method toHTMLElement(Node*)
https://bugs.webkit.org/show_bug.cgi?id=54105
No new tests since no new functionality introduced.
* html/HTMLElement.h:
(WebCore::toHTMLElement):
2011-02-09 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fixed positioned elements at very top or bottom of page remain fixed but clip during rubber-banding
<rdar://problem/7615997>
https://bugs.webkit.org/show_bug.cgi?id=54054
Take the overhang into account when calculating position for elements with position: fixed.
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollXForFixedPosition):
(WebCore::ScrollView::scrollYForFixedPosition):
(WebCore::ScrollView::scrollOffsetForFixedPosition):
* platform/ScrollView.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
(WebCore::RenderView::computeRectForRepaint):
2011-02-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dirk Schulze.
Enhance ShadowBlur to tile inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=51567
Add a tiling code path to ShadowBlur for rendering inset
box-shadows.
Test: fast/box-shadow/inset-box-shadows.html
* platform/graphics/ShadowBlur.cpp:
(WebCore::computeSliceSizesFromRadii): Compute the slice sizes
for the eight-piece shadow template.
(WebCore::ShadowBlur::templateSize): Compute the size of the template,
given the slice sizes.
(WebCore::ShadowBlur::drawRectShadow): Bail early if layerRect is empty
(which probably means we're clipped out). Call templateSize() and use
the result to decide whether to tile.
(WebCore::ShadowBlur::drawInsetShadow): New method for inset shadows.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling): Code moved.
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling): The non-tiling code
path for inset shadows.
(WebCore::ShadowBlur::drawInsetShadowWithTiling): Fill the shadow template
buffer, paint the non-blurred area of the destination, and then call drawLayerPieces()
to paint the eight-piece template image.
(WebCore::ShadowBlur::drawRectShadowWithTiling): Refactored code, now
shares the blurring code via blurAndColorShadowBuffer(), and the tiled template
drawing via drawLayerPieces().
(WebCore::ShadowBlur::drawLayerPieces): Draw an eight-piece image from the
shadow template to the destination.
(WebCore::ShadowBlur::blurAndColorShadowBuffer): Blur the pixels in the image
buffer, and colorize them using the CompositeSourceIn operation.
* platform/graphics/ShadowBlur.h:
2011-02-09 Jochen Eisinger <jochen@chromium.org>
Reviewed by Adam Barth.
Disable script elements when a CSP header is present
https://bugs.webkit.org/show_bug.cgi?id=53867
Tests: http/tests/security/contentSecurityPolicy/no-policy.html
http/tests/security/contentSecurityPolicy/script-src-in-iframe.html
http/tests/security/contentSecurityPolicy/script-src-none.html
http/tests/security/contentSecurityPolicy/script-src-redirect.html
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::requestPendingScript):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc):
* page/ContentSecurityPolicy.h:
2011-02-09 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r78047.
ContextMenu.cpp and ContextMenuItem.cpp have a USE(CROSS_PLATFORM_CONTEXT_MENUS),
so they shouldn't cause problems with correct preprocessor defines.
* CMakeLists.txt:
2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InspectorAgent should know nothing about InspectorController instance.
https://bugs.webkit.org/show_bug.cgi?id=54100
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::disconnectFrontend):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::restoreInspectorStateFromCookie):
2011-02-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: source frame scroll position is not restored.
https://bugs.webkit.org/show_bug.cgi?id=54101
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype.get scrollTop):
(WebInspector.SourceFrame.prototype.set scrollTop):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.get scrollTop):
(WebInspector.TextViewer.prototype.set scrollTop):
(WebInspector.TextViewer.prototype.get scrollLeft):
(WebInspector.TextViewer.prototype.set scrollLeft):
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
* WebCore.exp.in:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::stopUserInitiatedProfiling):
(WebCore::InspectorAgent::showAndEnableDebugger):
(WebCore::InspectorAgent::enabled):
(WebCore::InspectorAgent::showConsole):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::didClearWindowObjectInWorld):
(WebCore::InspectorController::showConsole):
(WebCore::InspectorController::enabled):
(WebCore::InspectorController::inspectedPage):
* inspector/InspectorController.h:
* inspector/InspectorFrontendClientLocal.cpp:
2011-02-07 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
LayoutTests/animations/play-state.html has wrong behavior with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53513
The PlatformCAAnimation::create() function which took a pointer to another
PlatformCAAnimation was supposed to make a copy of that passed object.
But it was doing completely the wrong thing on Mac and was leaking an object
to boot. And the notion of copying an object using a static creation function
is wrong in the first place. So I changed it to a member copy() function
which would create a new PlatformCAAnimation which was a copy of 'this' and
return it. I changed the implementation on both Mac and Win to match.
This problem was not caught by DRT, even there is a specific test for it.
That test just verifies that the higher level logic is working
properly, which it is. There's no practical way to find out if the
layer is currently animating. There is no logic which probes that
deeply into the layer mechanics.
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/graphics/ca/PlatformCAAnimation.h:
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
2011-02-09 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Remove double definition of ContextMenu.
https://bugs.webkit.org/show_bug.cgi?id=50762
When building with SHARED_CORE enabled, the symbols of ContextMenu
were both in webkit and webcore. This removes them from webcore and
shall be put back once the CROSS_PLATFORM_CONTEXT_MENUS is implemented
in EFL port.
No new tests because no new functionality.
* CMakeLists.txt:
2011-02-09 Adam Roben <aroben@apple.com>
Windows Production build fix
* WebCore.vcproj/QTMovieWinCommon.vsprops: Link against
WebKitSystemInterface$(WebKitConfigSuffix).lib, not just WebKitSystemInterface.lib, so we
pick up the _debug variant when appropriate.
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Hostnames should cannonicalize to lowercase (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54084
* platform/KURL.cpp:
(WebCore::KURL::parse):
2011-02-09 Peter Varga <pvarga@webkit.org>
Reviewed by Gavin Barraclough.
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
No new tests needed.
* Android.jscbindings.mk:
* CMakeLists.txt:
* ForwardingHeaders/pcre/pcre.h: Removed.
* ForwardingHeaders/yarr/Yarr.h: Added.
* ForwardingHeaders/yarr/YarrInterpreter.h: Added.
* ForwardingHeaders/yarr/YarrPattern.h: Added.
* WebCore.gyp/WebCore.gyp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::Private::create):
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::match):
2011-02-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add dummy functions for HTML5 Video's control UI
https://bugs.webkit.org/show_bug.cgi?id=53906
In WebKit EFL, there are no implementations for HTML5 control UI.
First, dummy functions are added.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::extraMediaControlsStyleSheet):
(WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):
(WebCore::RenderThemeEfl::paintMediaPlayButton):
(WebCore::RenderThemeEfl::paintMediaSeekBackButton):
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
(WebCore::RenderThemeEfl::paintMediaSliderThumb):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeEfl::paintMediaCurrentTime):
* platform/efl/RenderThemeEfl.h:
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make WebKit's fragment cannonicalization match other browsers
https://bugs.webkit.org/show_bug.cgi?id=53850
This doesn't make us match perfectly, but it brings us closer.
* platform/KURL.cpp:
(WebCore::appendEscapingBadChars):
(WebCore::escapeAndAppendFragment):
(WebCore::KURL::parse):
2011-02-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Cursors should skip deleted entries
https://bugs.webkit.org/show_bug.cgi?id=53690
Add test to check that the cursor skips deleted entries.
Test: storage/indexeddb/cursor-skip-deleted.html
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::currentRowExists):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
* storage/IDBCursorBackendImpl.h:
2011-02-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: script formatter should not create a worker for each script.
https://bugs.webkit.org/show_bug.cgi?id=54010
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter):
(WebInspector.ScriptFormatter.prototype._formatScript):
(WebInspector.ScriptFormatter.prototype._handleMessage):
(WebInspector.ScriptFormatter.prototype._handleError):
2011-02-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: sync uglifyjs parser files.
https://bugs.webkit.org/show_bug.cgi?id=54003
* inspector/front-end/UglifyJS/parse-js.js:
* inspector/front-end/UglifyJS/process.js:
2011-02-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
https://bugs.webkit.org/show_bug.cgi?id=53196
The bug was caused by Editor::selectionComputedStyle's modifying typing style without making a copy,
and its removing non-inheritable properties from the typing style. Fixed the bug by making a copy
before making the modification and not removing non-inheritable properties.
Also fixed a bug in selectionStartCSSPropertyValue that it doesn't handle xx-small to -webkit-xxx-large
by extracting a function from StyleChange::extractTextStyles and calling it in both extractTextStyles
and selectionStartCSSPropertyValue.
Test: editing/style/query-typing-style.html
* editing/ApplyStyleCommand.cpp:
(WebCore::legacyFontSizeFromCSSValue): Extracted from StyleChange::extractTextStyles.
(WebCore::StyleChange::extractTextStyles): Calls legacyFontSizeFromCSSValue; this fixes the bug that
CSS values from xx-small through -webkit-xxx-large are not accounted.
* editing/ApplyStyleCommand.h:
* editing/Editor.cpp:
(WebCore::Editor::selectionStartCSSPropertyValue): Calls legacyFontSizeFromCSSValue.
(WebCore::Editor::selectionComputedStyle): Makes a copy before modifying typing style.
No longer calls removeNonEditingProperties on the copied typing style so that background-color property
is included when merged into the style.
2011-02-08 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
REGRESSION (r76831): Subframes are printed blank
<rdar://problem/8945867>
* page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
Don't paint overhangs when printing.
2011-02-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975
The third change in the series of overhauling IndexedDB's event model to match
the spec (at least the version in our heads and bugs).
Test: storage/indexeddb/transaction-event-propagation.html
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
* dom/Event.cpp:
(WebCore::Event::isIDBAbortEvent):
(WebCore::Event::isIDBCompleteEvent):
* dom/Event.h:
* dom/EventTarget.cpp:
(WebCore::EventTarget::toIDBDatabase):
* dom/EventTarget.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::scriptExecutionContext):
(WebCore::IDBDatabase::eventTargetData):
(WebCore::IDBDatabase::ensureEventTargetData):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::toIDBDatabase):
(WebCore::IDBDatabase::refEventTarget):
(WebCore::IDBDatabase::derefEventTarget):
* storage/IDBDatabase.idl:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::backend):
(WebCore::IDBTransaction::db):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::scriptExecutionContext):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::enqueueEvent):
* storage/IDBTransaction.h:
(WebCore::IDBTransaction::dispatchEvent):
2011-02-08 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add cache for GPU-accelerated path processing results
https://bugs.webkit.org/show_bug.cgi?id=45519
Adding a cache which holds the results of processing a path into
interior and exterior triangle meshes, according to the path
rendering algorithm from GPU Gems 3. No tests yet; will be tested
in conjunction with later code.
* platform/graphics/gpu/LoopBlinnPathCache.cpp: Added.
(WebCore::LoopBlinnPathCache::LoopBlinnPathCache):
(WebCore::LoopBlinnPathCache::~LoopBlinnPathCache):
(WebCore::LoopBlinnPathCache::addVertex):
(WebCore::LoopBlinnPathCache::clear):
(WebCore::LoopBlinnPathCache::addInteriorVertex):
(WebCore::LoopBlinnPathCache::numberOfInteriorEdgeVertices):
(WebCore::LoopBlinnPathCache::interiorEdgeVertices):
(WebCore::LoopBlinnPathCache::addInteriorEdgeVertex):
* platform/graphics/gpu/LoopBlinnPathCache.h: Added.
(WebCore::LoopBlinnPathCache::numberOfVertices):
(WebCore::LoopBlinnPathCache::vertices):
(WebCore::LoopBlinnPathCache::texcoords):
(WebCore::LoopBlinnPathCache::numberOfInteriorVertices):
(WebCore::LoopBlinnPathCache::interiorVertices):
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Rename GraphicsContext3D::WebGLEnumType
https://bugs.webkit.org/show_bug.cgi?id=45708
* html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::getAttachedShader):
* html/canvas/WebGLProgram.h:
* platform/graphics/GraphicsContext3D.h:
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77980.
http://trac.webkit.org/changeset/77980
https://bugs.webkit.org/show_bug.cgi?id=54043
"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).
* WebCore.exp.in:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
* accessibility/AccessibilityObject.cpp:
(WebCore::startOfStyleRange):
(WebCore::endOfStyleRange):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(objectAndOffsetUnignored):
* dom/Position.cpp:
(WebCore::Position::upstream):
(WebCore::Position::downstream):
* dom/Range.cpp:
(WebCore::Range::editingStartPosition):
* editing/Editor.cpp:
(WebCore::Editor::canDeleteRange):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
* editing/SelectionController.cpp:
(WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
(WebCore::SelectionController::setSelectedRange):
* editing/TextIterator.cpp:
(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed):
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::VisiblePosition):
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
(WebCore::VisiblePosition::canonicalPosition):
(WebCore::VisiblePosition::characterAfter):
(WebCore::VisiblePosition::localCaretRect):
(WebCore::makeRange):
(WebCore::startVisiblePosition):
(WebCore::endVisiblePosition):
(WebCore::setStart):
(WebCore::setEnd):
(WebCore::isFirstVisiblePositionInNode):
(WebCore::isLastVisiblePositionInNode):
* editing/VisiblePosition.h:
* editing/htmlediting.cpp:
(WebCore::firstInSpecialElement):
(WebCore::lastInSpecialElement):
(WebCore::visiblePositionBeforeNode):
(WebCore::visiblePositionAfterNode):
* editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
(WebCore::endOfBlock):
(WebCore::startOfDocument):
(WebCore::endOfDocument):
(WebCore::logicalStartPositionForLine):
(WebCore::logicalEndPositionForLine):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::setBaseAndExtent):
(WebCore::DOMSelection::setPosition):
(WebCore::DOMSelection::extend):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::selectSubString):
2011-02-08 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943
Test: editing/undo/undo-paste-when-caret-is-not-in-range.html
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setWithoutValidation):
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove the last remnants of the Mozilla theme drawing code
https://bugs.webkit.org/show_bug.cgi?id=54035
Remove all Mozilla theme drawing code.
No new tests. This change only removes dead code.
* GNUmakefile.am: Remove Mozilla files from the source list.
* platform/gtk/RenderThemeGtk.h: Remove Mozilla-theme-drawing-related methods
and add m_colormap to hold the current colormap of the widgets.
* platform/gtk/RenderThemeGtk2.cpp: Remove Mozilla code.
(WebCore::RenderThemeGtk::platformInit): Ditto.
(WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto.
(WebCore::RenderThemeGtk::gtkContainer): Ditto.
* platform/gtk/ScrollbarThemeGtk2.cpp: Ditto.
* platform/gtk/WidgetRenderingContext.cpp: Ditto.
(WebCore::WidgetRenderingContext::WidgetRenderingContext): Ditto.
* platform/gtk/WidgetRenderingContext.h: Ditto.
* platform/gtk/gtk2drawing.c: Removed.
* platform/gtk/gtkdrawing.h: Removed.
2011-02-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
Crash when logging into gmail.com with frame flattening turned on.
https://bugs.webkit.org/show_bug.cgi?id=52449
Frame flattening algorithm requires that layout always starts from the main frame, since layout of
subframes impacts the layout of their parents.
There are places in the code that call view->layout() not on the main frame.
Instead of changing all the callsites, I changed FrameView::layout()
to force layout from the main frame if frame flattening is enabled.
In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(),
because calling the from layout() leads to a crash in pages that have a selection in an iframe.
Tests: fast/frames/flattening/iframe-flattening-crash.html
fast/frames/flattening/iframe-flattening-selection-crash.html
* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):
2011-02-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
<rdar://problem/8913952> REGRESSION (r76301): 'plaintext-only' must be
a supported contentEditable mode.
https://bugs.webkit.org/show_bug.cgi?id=54041
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setContentEditable): Setting the contentEditable
attribute to 'plaintext-only' should not throw an exception.
2011-02-08 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
RenderRubyRun::m_beingDestroyed is redundant
https://bugs.webkit.org/show_bug.cgi?id=54042
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun): Removed intialization of m_beingDestroyed.
(WebCore::RenderRubyRun::removeChild): Use the base class beingDestroyed().
* rendering/RenderRubyRun.h:
2011-02-08 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing VisiblePosition completely away from legacy positions.
No new tests since this is functionaly equivalent.
* WebCore.exp.in: Removing the legacy VisiblePosition constructor and
adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions
outside of WebCore, they should be parent anchored.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
* accessibility/AccessibilityObject.cpp:
(WebCore::startOfStyleRange):
(WebCore::endOfStyleRange):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(objectAndOffsetUnignored):
* dom/Position.cpp:
(WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor
(WebCore::Position::downstream): ditto
* dom/Range.cpp:
(WebCore::Range::editingStartPosition):
* editing/Editor.cpp:
(WebCore::Editor::canDeleteRange):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
* editing/SelectionController.cpp:
(WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
(WebCore::SelectionController::setSelectedRange):
* editing/TextIterator.cpp:
(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed):
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
(WebCore::VisiblePosition::canonicalPosition):
(WebCore::VisiblePosition::characterAfter):
(WebCore::VisiblePosition::localCaretRect):
(WebCore::makeRange):
(WebCore::startVisiblePosition):
(WebCore::endVisiblePosition):
(WebCore::setStart):
(WebCore::setEnd):
(WebCore::isFirstVisiblePositionInNode):
(WebCore::isLastVisiblePositionInNode):
* editing/VisiblePosition.h:
(WebCore::VisiblePosition::VisiblePosition):
* editing/htmlediting.cpp:
(WebCore::firstInSpecialElement):
(WebCore::lastInSpecialElement):
(WebCore::visiblePositionBeforeNode):
(WebCore::visiblePositionAfterNode):
* editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
(WebCore::endOfBlock):
(WebCore::startOfDocument):
(WebCore::endOfDocument):
(WebCore::logicalStartPositionForLine):
(WebCore::logicalEndPositionForLine):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::setBaseAndExtent):
(WebCore::DOMSelection::setPosition):
(WebCore::DOMSelection::extend):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::selectSubString):
2011-02-08 Michael Saboff <msaboff@apple.com>
JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716
Changed ASSERT to be an if for the case where the RuntimeObject was
GC'ed before RootObject::invalidate is called. In that case there is
no need to remove the RuntimeObject from the RootObject. The isValid()
call will be false in this case, but the RuntimeObject has already
been removed from the RootObject. Added similar defensive code
in RootObject::removeRuntimeObject().
* bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::willDestroyRuntimeObject):
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::removeRuntimeObject):
2011-02-08 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/8953365> CrashTracer: 14
crashes in WebProcess at com.apple.WebCore:
-[ScrollKnobAnimation setCurrentProgress:] + 258
This crash seems to happen when the animation is running
and a window is closed. If the ScrollAnimator is destroyed,
delegate calls for the animation can still run, so we have
to make sure we inform the delegates when the ScrollAnimator
is gone, and then we have to null-check it before we do
anything with it.
Remove scrollbarPainterDelegate() since it's not used anymore.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
Add null-checks for _animator
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
New function to inform the delegates that the ScrollAnimator
is being destroyed.
(-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
This code appears to be unused.
* html/HTMLParserErrorCodes.cpp:
* html/HTMLParserErrorCodes.h:
* html/HTMLParserQuirks.h:
* loader/EmptyClients.h:
* page/ChromeClient.h:
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Move scrollbar rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52836
Replace gtk2drawing.c scrollbar rendering with our own version. This
is the last use of the Mozilla theme drawing code.
No new tests. This should not change the rendering of the default
theme.
* platform/gtk/GtkVersioning.h: Add some more backported allocation setters.
* platform/gtk/RenderThemeGtk.h: Add a getter for the scrollbar widgets.
* platform/gtk/RenderThemeGtk2.cpp: Initialize and add getters for scrollbar widgets.
(WebCore::RenderThemeGtk::platformInit): Ditto.
(WebCore::RenderThemeGtk::gtkHScrollbar): Ditto.
(WebCore::RenderThemeGtk::gtkVScrollbar): Ditto.
* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::paint): We only repaint the scrolled
window background if we are repainting a button or the thumb. In that
case also repaint the track rect.
* platform/gtk/ScrollbarThemeGtk2.cpp: Port to WidgetRenderingContext.
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Ditto.
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto.
(WebCore::getWidgetForScrollbar): Ditto.
(WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto.
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
(WebCore::ScrollbarThemeGtk::paintThumb): Ditto.
(WebCore::ScrollbarThemeGtk::paintButton): Ditto.
* platform/gtk/WidgetRenderingContext.cpp: Ditto.
(WebCore::WidgetRenderingContext::gtkPaintBox): Added an option which
also adjusts a widget allocation according to the paint rect. This is
necessary to properly draw scrollbar buttons.
* platform/gtk/WidgetRenderingContext.h: Ditto.
2011-02-08 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Inset shadow with large offset renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53882
Fix an issue with inset shadows, when the shadow offset
was larger than the box size. In this case we'd fail to
fill the box with the shadow color.
Test: fast/box-shadow/inset-shadow-large-offset.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::areaCastingShadowInHole): Return a rect that covers the area
which contributes to the inset shadow.
(WebCore::RenderBoxModelObject::paintBoxShadow): Use areaCastingShadowInHole()
to compute the outerRect.
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
https://bugs.webkit.org/show_bug.cgi?id=54017
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::drawElements):
2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53190
This is the second part of refactoring the HTMLMediaElement to use new
shadow DOM. The changes are mainly mechanical, except for needing to
add a new method to RenderTheme, which indicates whether or not status
display is being used by it. Previously, we relied on existence of a cached
pseudo style.
Refactoring, covered by existing tests.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId): Removed now-unused enum values.
(WebCore::nameToPseudoTypeMap): Ditto.
(WebCore::CSSSelector::extractPseudoType): Ditto.
* css/CSSSelector.h: Ditto.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::createPanel): Changed to use the newly-added MediaControlPanelElement.
(WebCore::MediaControls::createCurrentTimeDisplay): Changed to use the newly-added
MediaControlCurrentTimeDisplayElement.
(WebCore::MediaControls::createTimeRemainingDisplay): Changed to use the newly-added
MediaControlTimeRemainingDisplayElement.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlShadowRootElement::updateStyle): Changed to use the
standard style resolution.
(WebCore::MediaControlShadowRootElement::shadowPseudoId): Added.
(WebCore::MediaControlElement::MediaControlElement): Removed the switch statement
that is no longer necessary.
(WebCore::MediaControlElement::styleForElement): Changed to use the standard
style resolution.
(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added.
(WebCore::MediaControlPanelElement::create): Added.
(WebCore::MediaControlPanelElement::displayType): Added.
(WebCore::MediaControlPanelElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):
Changed to use the newly-plumbed usesMediaControlStatusDisplay helper.
(WebCore::MediaControlTimelineContainerElement::displayType): Added.
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlVolumeSliderContainerElement::displayType): Added.
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Changed to
use the newly-plumbed usesMediaControlStatusDisplay helper.
(WebCore::MediaControlStatusDisplayElement::displayType): Added.
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlTimeRemainingDisplayElement::create): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::displayType): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::create): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::displayType): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Added.
* rendering/MediaControlElements.h: Added/changed defs accordingly.
* rendering/RenderTheme.h:
(WebCore::RenderTheme::usesMediaControlStatusDisplay): Added.
* rendering/RenderThemeMac.h: Added def.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::usesMediaControlStatusDisplay): Added.
* rendering/style/RenderStyleConstants.h: Removed now-unused enum values.
2011-02-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix pop-up button text not rendered correctly according to its direction
in <option>.
https://bugs.webkit.org/show_bug.cgi?id=53642
In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.
Test: fast/text/international/pop-up-button-text-alignment-and-direction.html
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle):
2011-02-08 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Qt-minimal.
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::hasFrontend):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=53169
All the Inspector API for WebCore has two parts.
The first one is InspectorInstrumentation for WebCore.
The second is InspectorController for WebKit.
InspectorAgent was produced by renaming original InspectorController.
This patch extracts WebKit related methods from InspectorAgent to InspectorController.
* WebCore.exp.in:
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createParser):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::~InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::inspect):
(WebCore::InspectorAgent::handleMousePress):
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::resourceAgent):
(WebCore::InspectorAgent::createFrontendLifetimeAgents):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::pushDataCollectedOffline):
(WebCore::InspectorAgent::restoreProfiler):
(WebCore::InspectorAgent::startTimelineProfiler):
(WebCore::PostWorkerNotificationToFrontendTask::performTask):
(WebCore::InspectorAgent::didOpenDatabase):
(WebCore::InspectorAgent::didUseDOMStorage):
(WebCore::InspectorAgent::showAndEnableDebugger):
(WebCore::InspectorAgent::enableDebugger):
(WebCore::InspectorAgent::enabled):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::frontend):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::didClearWindowObjectInWorld):
(WebCore::InspectorController::startTimelineProfiler):
(WebCore::InspectorController::stopTimelineProfiler):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::disconnectFrontendImpl):
(WebCore::InspectorController::show):
(WebCore::InspectorController::close):
(WebCore::InspectorController::restoreInspectorStateFromCookie):
(WebCore::InspectorController::evaluateForTestInFrontend):
(WebCore::InspectorController::drawNodeHighlight):
(WebCore::InspectorController::inspect):
(WebCore::InspectorController::enabled):
(WebCore::InspectorController::showPanel):
(WebCore::InspectorController::frontendLoaded):
(WebCore::InspectorController::timelineProfilerEnabled):
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
(WebCore::InspectorController::profilerEnabled):
(WebCore::InspectorController::debuggerEnabled):
(WebCore::InspectorController::showAndEnableDebugger):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
(WebCore::InspectorController::isRecordingUserInitiatedProfile):
(WebCore::InspectorController::setInspectorExtensionAPI):
(WebCore::InspectorController::resume):
(WebCore::InspectorController::hideHighlight):
(WebCore::InspectorController::dispatchMessageFromFrontend):
* inspector/InspectorController.h:
(WebCore::InspectorController::inspectorClient):
(WebCore::InspectorController::inspectedPage):
(WebCore::InspectorController::hasFrontend):
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::setExtensionAPI):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::profilerEnabledImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::hasFrontend):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2011-02-08 George Wright <gwright@rim.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=53949
Ensure that we pack the colour byte order correctly for Skia using
Skia's SkPackARGB32 function.
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::setRGBA):
2011-02-08 George Wright <gwright@rim.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=53951
Ensure we do not pass (-1, -1) sized rects to ImageBuffer but instead
pass the full image dimensions.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImageBuffer):
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Add missing includes and forward declarations for DownloadBundle
https://bugs.webkit.org/show_bug.cgi?id=53881
* platform/network/cf/DownloadBundle.h:
* platform/network/win/DownloadBundleWin.cpp:
(WebCore::DownloadBundle::appendResumeData):
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Add missing include in WKCAImageQueue
https://bugs.webkit.org/show_bug.cgi?id=53890
* platform/graphics/win/WKCAImageQueue.cpp:
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Add missing includes and forward declarations for CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=53883
* platform/network/cf/DNSCFNet.cpp:
* platform/network/cf/LoaderRunLoopCF.cpp:
* platform/network/cf/LoaderRunLoopCF.h:
* platform/network/cf/ProxyServerCFNet.cpp:
* platform/network/cf/SocketStreamHandle.h:
* platform/network/cf/SocketStreamHandleCFNet.cpp:
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r77870.
* platform/DragImage.cpp: Enable createDragImageForLink for WinCE.
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: open network resource url in new tab upon double click.
https://bugs.webkit.org/show_bug.cgi?id=53930
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
2011-02-08 Yonathan Randolph <yonathan@gmail.com>
Reviewed by Pavel Feldman.
Web Inspector: $x: any node should work in optional context parameter.
https://bugs.webkit.org/show_bug.cgi?id=50138
* inspector/InjectedScriptSource.js:
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r77870.
Remove the global namespace prefix from GlobalLock/GlobalUnlock.
* platform/win/ClipboardUtilitiesWin.cpp:
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: re-apply r77924.
Test: inspector/console-api-on-call-frame.html
* inspector/InjectedScriptSource.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
2011-02-08 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
REGRESSION(r77312): Unbreak TiledBackingStore.
Due to an off-by-one error, we were no longer rendering the
rightmost column and bottom row of tiles.
Covered by tst_QGraphicsWebView::widgetsRenderingThroughCache().
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::createTiles):
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77924.
http://trac.webkit.org/changeset/77924
https://bugs.webkit.org/show_bug.cgi?id=53997
Breaks inspector tests. (Requested by pfeldman on #webkit).
* inspector/InjectedScriptSource.js:
(.):
():
2011-02-08 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [refacotring] merge InspectorAgent::willSendRequest() into InspectorResourceAgent
https://bugs.webkit.org/show_bug.cgi?id=53789
- perform UserAgent override via InspectorInstrumentation
- move adding extra request headers to InspectorResourceAgent
- simplified things in InspectorState
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::applyUserAgentOverride):
* inspector/InspectorAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
(WebCore::InspectorInstrumentation::willSendRequestImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::applyUserAgentOverride):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setExtraHeaders):
(WebCore::InspectorResourceAgent::willSendRequest):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::restoreFromInspectorCookie):
(WebCore::InspectorState::updateCookie):
(WebCore::InspectorState::setValue):
(WebCore::InspectorState::getBoolean):
(WebCore::InspectorState::getString):
(WebCore::InspectorState::getLong):
(WebCore::InspectorState::getObject):
* inspector/InspectorState.h:
(WebCore::InspectorState::setObject):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::userAgent):
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not hide scope variables with command line api.
https://bugs.webkit.org/show_bug.cgi?id=53497
Test: inspector/console-api-on-call-frame.html
* inspector/InjectedScriptSource.js:
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
https://bugs.webkit.org/show_bug.cgi?id=53914
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::reloadPage):
* inspector/InspectorAgent.h:
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._reloadResources):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
2011-02-08 Antti Koivisto <antti@apple.com>
Reviewed by Cameron Zwarich.
Skip over sibling selectors when collecting descendant selector hashes
https://bugs.webkit.org/show_bug.cgi?id=53987
Skip instead of bailing out. This will allow optimizing some sibling selector cases.
* css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::collectIdentifierHashes):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
* css/CSSStyleSelector.h:
2011-02-07 Cris Neckar <cdn@chromium.org>
Reviewed by Jian Li.
Fix null deref in DOMURL
https://bugs.webkit.org/show_bug.cgi?id=53811
Test: fast/files/domurl-script-execution-context-crash.html
* html/DOMURL.cpp:
(WebCore::DOMURL::DOMURL):
2011-02-07 Mark Rowe <mrowe@apple.com>
Fix the 32-bit build.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters.
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto.
2011-02-07 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Select popup box does not align with select button when appearance is not "menulist".
https://bugs.webkit.org/show_bug.cgi?id=53942
Added manual test select_webkit_appearance_off_popup_alignment.html.
* manual-tests/select_webkit_appearance_off_popup_alignment.html: Added.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::layout):
2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983
Added copy option for Qt platform if selection is a link.
Added a test in tst_qwebpage.cpp.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
2011-02-07 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend
when drawing <canvas>. Disabled by default.
No new tests. existing canvas layouttests apply
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::publishToPlatformLayer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::GetGlobalGrContext):
(WebCore::PlatformContextSkia::isPrinting):
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
(WebCore::PlatformContextSkia::syncSoftwareCanvas):
2011-02-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
Removing unused code from PopupMenuChromium.
https://bugs.webkit.org/show_bug.cgi?id=53866
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::layout):
(WebCore::PopupMenuChromium::show):
* platform/chromium/PopupMenuChromium.h:
2011-02-07 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Andreas Kling.
HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791
Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged().
Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::childrenChanged): Calls super class's
childrenChanged().
2011-02-07 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289
Use the QtNAMThreadSafeProxy to make sure the cookie jar is created
in the same thread as the QNetworkAccessManager.
* platform/network/qt/QtNAMThreadSafeProxy.cpp:
(WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy):
(WebCore::QtNAMThreadSafeProxy::hasCookieJar):
* platform/network/qt/QtNAMThreadSafeProxy.h:
* platform/qt/CookieJarQt.cpp:
(WebCore::cookiesEnabled):
2011-02-07 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722
Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback):
(WebCore::WebGLRenderingContextLostCallback::onContextLost):
(WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback):
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::setContextLostCallback): stub
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::setContextLostCallback): stub
2011-02-07 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Add missing PaintInfo include in RenderThemeWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=53885
* rendering/RenderThemeWin.cpp:
2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974
Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
* platform/ContextMenuItem.h:
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagCopyImageUrlToClipboard):
* platform/LocalizedStrings.h:
2011-02-07 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Kent Tamura.
HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970
Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form()
return the right value.
Test: fast/dom/HTMLObjectElement/form/nested-form-element.html
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::virtualForm): Added.
* html/HTMLObjectElement.h: Added virtualForm().
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Leopard build fix.
* WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion.
* platform/mac/DragImageMac.mm:
(WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat.
2011-02-07 Enrica Casucci <enrica@apple.com>
Reviewed by Sam Weinig.
Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874
When moving code from WebKit to WebCore we needed to move some additional
functions previously in NSStringExtras.
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/DragImageMac.mm:
(WebCore::fontFromNSFont):
(WebCore::canUseFastRenderer):
(WebCore::widthWithFont):
(WebCore::webkit_CGCeiling):
(WebCore::drawAtPoint):
(WebCore::drawDoubledAtPoint):
(WebCore::createDragImageForLink):
2011-02-07 Lucas Forschler <lforschler@apple.com>
Reviewed by Geoff Garen.
Tr #2, Fix the Leopard 32bit debug build.
No new tests required.
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityAllInOne.cpp:
2011-02-07 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/8946961> Fix repaint problems
with WKScrollbarPainter scrollers while resizing the window
Remove setPainterForPainterController() and
removePainterFromPainterController() since they aren't
used anymore.
* platform/mac/ScrollAnimatorMac.h:
Return early if they alpha hasn't changed.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
If we're in a live resize, restore alpha to 1.
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
2011-02-07 Beth Dakin <bdakin@apple.com>
Reviewed by Eric Seidel.
Fix for https://bugs.webkit.org/show_bug.cgi?id=53950
USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in
Platform.h instead
Use hot new USE(WK_SCROLLBAR_PAINTER) from Platform.h rather
than the silly, old in-file #define.
* platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::paint):
2011-02-07 Enrica Casucci <enrica@apple.com>
Reviewed Adam Roben and Darin Adler.
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>
* loader/EmptyClients.h: Removed createDragImageFromLink.
* page/DragClient.h: Ditto.
* page/DragController.cpp:
(WebCore::DragController::startDrag): changed call to createDragImageFromLink.
* platform/DragImage.h:
* platform/mac/DragImageMac.mm:
(WebCore::createDragImageForLink): Moved from DragClient.
* platform/win/ClipboardUtilitiesWin.cpp: Added a series of functions
to de-serialize the drag data from the map into an IDataObject.
(WebCore::getWebLocData):
(WebCore::texthtmlFormat):
(WebCore::createGlobalData):
(WebCore::getFullCFHTML):
(WebCore::urlWFormat):
(WebCore::urlFormat):
(WebCore::filenameWFormat):
(WebCore::filenameFormat):
(WebCore::htmlFormat):
(WebCore::smartPasteFormat):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::ClipboardDataItem::ClipboardDataItem):
(WebCore::getStringData):
(WebCore::getUtf8Data):
(WebCore::getCFData):
(WebCore::setUCharData):
(WebCore::setCharData):
(WebCore::setCFData):
(WebCore::getClipboardMap):
(WebCore::getClipboardData):
(WebCore::setClipboardData):
* platform/win/ClipboardUtilitiesWin.h:
* platform/win/DragImageWin.cpp: Moved createDragImageForLink from DragClient
to a platform specific file in WebCore. It makes a lot more sense here, since
the drag image is always created in WebCore for all the other content types
except for links.
(WebCore::dragLabelFont):
(WebCore::createDragImageForLink):
* platform/win/WCDataObject.cpp: Added new way to
construct a WCDataObject from a DragDataMap.
(WebCore::WCDataObject::createInstance):
(WebCore::WCDataObject::clearData):
* platform/win/WCDataObject.h:
2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77848.
http://trac.webkit.org/changeset/77848
https://bugs.webkit.org/show_bug.cgi?id=53963
caused 6 test failures (Requested by othermaciej on #webkit).
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2011-02-04 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add shaders for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=45520
Refactored SolidFillShader and TexShader to call new
generateVertex() and generateFragment() methods on base Shader
class, and added support for the Loop/Blinn shaders. Refactored
Loop/Blinn shader classes to derive from Shader.
Tested these changes with several of the IE9 Testdrive demos with
accelerated 2D canvas enabled, as well as a full layout test run
with --platform chromium-gpu.
* platform/graphics/gpu/LoopBlinnShader.cpp: Added.
(WebCore::LoopBlinnShader::LoopBlinnShader):
(WebCore::LoopBlinnShader::use):
* platform/graphics/gpu/LoopBlinnShader.h: Added.
* platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Added.
(WebCore::LoopBlinnSolidFillShader::create):
(WebCore::LoopBlinnSolidFillShader::LoopBlinnSolidFillShader):
(WebCore::LoopBlinnSolidFillShader::use):
* platform/graphics/gpu/LoopBlinnSolidFillShader.h: Added.
* platform/graphics/gpu/Shader.cpp:
(WebCore::Shader::affineTo4x4):
(WebCore::Shader::loadShader):
(WebCore::Shader::loadProgram):
(WebCore::Shader::generateVertex):
(WebCore::Shader::generateFragment):
* platform/graphics/gpu/Shader.h:
* platform/graphics/gpu/SolidFillShader.cpp:
(WebCore::SolidFillShader::create):
* platform/graphics/gpu/TexShader.cpp:
(WebCore::TexShader::TexShader):
(WebCore::TexShader::create):
2011-02-07 Dan Bernstein <mitz@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro-05-t.svg)
https://bugs.webkit.org/show_bug.cgi?id=53480
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): m_indexEnd should be an
offset into m_characters, not into the run’s characters.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.
2011-02-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add bundle API to get the background color of a frame
<rdar://problem/8962670>
https://bugs.webkit.org/show_bug.cgi?id=53952
* WebCore.exp.in: Add export.
2011-02-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Assertion failure in ~JSGlobalObject when loading apple.com HTML5
transitions demo page
https://bugs.webkit.org/show_bug.cgi?id=53853
This was a long-standing bookkeeping bug uncovered by some heap refactoring.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::notifyFinished):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dropProtection): Take the JSLock before
reporting extra cost to the JavaScriptCore heap, since all use of
JavaScriptCore is supposed to be guarded by JSLock.
2011-02-07 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug
bots
https://bugs.webkit.org/show_bug.cgi?id=53104
Covered by the existing tests.
* fileapi/FileStreamProxy.cpp:
(WebCore::FileStreamProxy::startOnFileThread):
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::createResourceHandle):
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::cancel):
(WebCore::delayedStartBlobResourceHandle):
(WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive
till the delay function is called.
(WebCore::BlobResourceHandle::doStart):
(WebCore::doNotifyFinish):
(WebCore::BlobResourceHandle::notifyFinish): Notify the client via the
standalone function to prevent the handle from being disposed immediately
by the client which will make the calls in the stack that're still bound
to the handle suffer.
* platform/network/BlobResourceHandle.h:
* platform/network/ResourceHandle.h: Change cancel() to virtual so that
BlobResourceHandle::cancel will be called when we abort a FileReader.
2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77845.
http://trac.webkit.org/changeset/77845
https://bugs.webkit.org/show_bug.cgi?id=53946
build failure (Requested by lforschler_ on #webkit).
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityAllInOne.cpp:
2011-02-07 Darin Adler <darin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=53939
fast/css/text-overflow-ellipsis.html failure after r77818/77819
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerExtendedEncodingNames):
Add back the "utf8" synonym for "UTF-8".
2011-02-07 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Remove an unnecessary extra computeLogicalWidth() from line layout.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2011-02-07 Lucas Forschler <lforschler@apple.com>
Reviewed by Geoffrey Garen.
Fix Leopard Intel Debug Build.
<rdar://problem/8953606> REGRESSION: Can't link WebCore on 32-bit Leopard (53681)
This could potentially break windows, since I had to change #include <filename> to #include "filename"
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityAllInOne.cpp:
2011-02-07 Sam Weinig <sam@webkit.org>
Fix build.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
2011-02-07 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Add mechanism to inform the ScrollAnimator when Scrollbars are added
and removed.
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::didAddVerticalScrollbar):
(WebCore::ScrollAnimator::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimator::didAddHorizontalScrollbar):
(WebCore::ScrollAnimator::willRemoveHorizontalScrollbar):
Make virtual to allow platform specific overrides.
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Call new ScrollableArea functions.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::didAddVerticalScrollbar):
(WebCore::ScrollableArea::willRemoveVerticalScrollbar):
(WebCore::ScrollableArea::didAddHorizontalScrollbar):
(WebCore::ScrollableArea::willRemoveHorizontalScrollbar):
* platform/ScrollableArea.h:
Pipe to ScrollAnimator.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
Move painter delegate registration to the new didAdd/willRemove functions.
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Missing text match markers with accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53934
When doing the fake paint that recomputes the text match rects, we need to
flatten compositing layers, otherwise the rects won't be updated until the next paint call.
(This worked by accident in WebKit1 because Safari calls -[NSWindow displayIfNeeded] on the containing
window before asking for the text match rects).
* editing/Editor.cpp:
(WebCore::Editor::countMatchesForText):
2011-02-07 Antti Koivisto <antti@apple.com>
Reviewed by Andreas Kling.
REGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transform.svg
https://bugs.webkit.org/show_bug.cgi?id=53900
Ignore link elements in shadow trees.
* dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
Some asserts to catch cases like this.
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::insertedIntoDocument):
(WebCore::HTMLLinkElement::removedFromDocument):
* html/HTMLLinkElement.h:
2011-02-07 Darin Adler <darin@apple.com>
Turn UTF-8 decoder off for now so we can look into failing tests
without leaving the tree red.
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerBaseEncodingNames): Reverting
earlier change so this can handle UTF-8.
(WebCore::TextCodecICU::registerBaseCodecs): Ditto.
(WebCore::TextCodecICU::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecICU::registerExtendedCodecs): Ditto.
* platform/text/TextCodecICU.h: Ditto.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps): Ditto.
(WebCore::extendTextCodecMaps): Ditto.
* platform/text/brew/TextCodecBrew.cpp:
(WebCore::TextCodecBrew::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerBaseCodecs): Ditto.
(WebCore::TextCodecBrew::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerExtendedCodecs): Ditto.
* platform/text/brew/TextCodecBrew.h: Ditto.
* platform/text/gtk/TextCodecGtk.cpp:
(WebCore::TextCodecGtk::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
* platform/text/wince/TextCodecWinCE.cpp:
(WebCore::TextCodecWinCE::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerBaseCodecs): Ditto.
(WebCore::TextCodecWinCE::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerExtendedCodecs): Ditto.
* platform/text/wince/TextCodecWinCE.h: Ditto.
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924
Export ScrollbarTheme::nativeTheme.
* WebCore.exp.in:
2011-02-07 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831
* html/canvas/WebGLRenderingContext.cpp: Allocate large enough buffer for atttrib0 if it's enabled and not used.
(WebCore::WebGLRenderingContext::initVertexAttrib0):
(WebCore::WebGLRenderingContext::simulateVertexAttrib0):
* html/canvas/WebGLRenderingContext.h:
2011-02-07 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles.
https://bugs.webkit.org/show_bug.cgi?id=53842
Test: platform/mac/accessibility/aria-sort.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sortDirection):
* accessibility/AccessibilityObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
* html/HTMLAttributeNames.in:
2011-02-07 Darin Adler <darin@apple.com>
Reviewed by Antti Koivisto.
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898
Correct behavior is covered by existing tests.
* Android.mk: Added TextCodecUTF8.
* CMakeLists.txt: Ditto.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/text/TextCodecICU.cpp: Removed registration of UTF-8
since that's now handled by the built-in UTF-8 codec.
(WebCore::TextCodecICU::registerEncodingNames): Renamed to remove
the word "extended" since all codecs from ICU are now extended.
(WebCore::TextCodecICU::registerCodecs): Ditto.
* platform/text/TextCodecICU.h: Ditto.
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::decode): Added a FIXME about missing
error handling.
* platform/text/TextCodecUTF8.cpp: Added.
* platform/text/TextCodecUTF8.h: Added.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps): Added TextCodecUTF8, and
removed TextCodecICU, TextCodecBrew, and TextCodecWinCE.
(WebCore::extendTextCodecMaps): Updated names for
TextCodecICU and TextCodecWinCE.
* platform/text/brew/TextCodecBrew.cpp:
(WebCore::TextCodecBrew::registerEncodingNames): Renamed to remove
the word "extended" since all codecs from Brew are now extended.
(WebCore::TextCodecBrew::registerCodecs): Ditto.
* platform/text/brew/TextCodecBrew.h: Ditto.
* platform/text/gtk/TextCodecGtk.cpp:
(WebCore::TextCodecGtk::registerBaseEncodingNames): Removed
registration of UTF-8. It's questionable whether the other codecs
here are really basic. If we think they qualify, then we should
register them on other platforms, not just GTK.
(WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
* platform/text/wince/TextCodecWinCE.cpp:
(WebCore::getCodePage): Removed special case for UTF-8 since we
no longer use this codec for UTF-8.
(WebCore::TextCodecWinCE::registerEncodingNames): Renamed to remove
the word "extended" since all codecs from WinCE are now extended.
(WebCore::TextCodecWinCE::registerCodecs): Ditto.
* platform/text/wince/TextCodecWinCE.h: Ditto.
2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436
Consider list item markers when calculating the offset.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_caret_offset): Adjust the offset
with the item marker's length for list items.
(webkit_accessible_text_set_caret_offset): Replace usage of
g_utf8_strlen() by calling to markerText.length().
2011-02-07 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix LayoutTests/media/restore-from-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=53621
Changed the networkState to MediaPlayer::Loaded when
MediaPlayerPrivateQt has enough data.
Test: media/restore-from-page-cache.html
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::updateStates):
2011-01-31 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement beautification of scripts inlined in html documents.
https://bugs.webkit.org/show_bug.cgi?id=52706
To beautify scripts inlined in html, we need to cut individual scripts, beautify them using UglifyJS library, and
finally paste them back to html.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter): Implement formatting of scripts inlined in html.
(WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
(WebInspector.ScriptFormatter.prototype.formatContent):
(WebInspector.ScriptFormatter.prototype._splitContentIntoChunks):
(WebInspector.ScriptFormatter.prototype._formatChunks.didFormat):
(WebInspector.ScriptFormatter.prototype._formatChunks):
(WebInspector.ScriptFormatter.prototype._buildContentFromChunks):
(WebInspector.ScriptFormatter.prototype._formatScript.messageHandler):
(WebInspector.ScriptFormatter.prototype._formatScript):
* inspector/front-end/ScriptFormatterWorker.js:
(onmessage):
(buildMapping):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrameContent): Use SourceFrameContent and FormattedSourceFrameContent to perform operations with line numbers.
* inspector/front-end/SourceFrameContent.js: Added.
(WebInspector.SourceFrameContent): Helper class, holds resource text and scripts layout
(WebInspector.SourceFrameContent.prototype.get scriptRanges):
(WebInspector.SourceFrameContent.prototype.locationToPosition):
(WebInspector.SourceFrameContent.prototype.positionToLocation):
(WebInspector.SourceFrameContent.prototype.scriptLocationForLineNumber):
(WebInspector.SourceFrameContent.prototype.scriptLocationForRange):
(WebInspector.SourceFrameContent.prototype.lineNumberToRange):
(WebInspector.SourceFrameContent.prototype._intersectingScriptRange):
(WebInspector):
(WebInspector.FormattedSourceFrameContent): Helper class, holds original and formatted versions of resource and mapping between them.
(WebInspector.FormattedSourceFrameContent.prototype.get text):
(WebInspector.FormattedSourceFrameContent.prototype.originalLocationToFormattedLocation):
(WebInspector.FormattedSourceFrameContent.prototype.scriptLocationForFormattedLineNumber):
(WebInspector.FormattedSourceFrameContent.prototype._convertPosition):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: "Reveal in elements panel" does not always work.
https://bugs.webkit.org/show_bug.cgi?id=53775
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu.prototype.show):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.switchToAndFocus):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
* inspector/front-end/inspector.js:
(WebInspector.cancelSearch):
2011-02-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Relative .. in URL paths shouldn't skip adjacent / characters
https://bugs.webkit.org/show_bug.cgi?id=53907
Our new behavior matches Firefox, Chrome, and IE.
* platform/KURL.cpp:
(WebCore::copyPathRemovingDots):
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>
* Configurations/WebCore.xcconfig: Allow WebKitTestRunner to link
WebCore.
* WebCore.exp.in: Export a handful of KURL symbols.
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
* ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
* bindings/v8/NPV8Object.cpp:
(WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of
v8::Handle<v8::Value>*.
(_NPN_Invoke): Calls createValueListFromVariantArgs.
(_NPN_InvokeDefault): createValueListFromVariantArgs.
(_NPN_Construct): createValueListFromVariantArgs.
* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr.
(WebCore::ScriptFunctionCall::construct): Ditto.
(WebCore::ScriptCallback::call):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext): Ditto.
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl): Ditto
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode): Ditto,
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray.
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr.
(WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto.
(WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito.
* platform/Length.cpp:
(WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*.
(WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*.
* platform/Length.h: Prototype changes.
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::getDirtyRects): Ditto.
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::getNormalizedTextRun): Ditto.
* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::glyphsToAdvances): Ditto.
(WebCore::canRender): Ditto.
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::updateSubRect): Ditto.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto.
* platform/graphics/wince/SharedBitmap.cpp:
(WebCore::SharedBitmap::to16bit): Ditto.
* platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::getContextMenuItems): Ditto.
* platform/win/LoggingWin.cpp:
(WebCore::initializeWithUserDefault): Ditto.
* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::fetchInfo): Ditto.
2011-02-06 Kent Tamura <tkent@chromium.org>
Unreviewed.
* WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file.
2011-02-03 Dominic Cooney <dominicc@google.com>
Reviewed by Dimitri Glazkov.
Convert <keygen> option elements to a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=51379
Covered by existing tests e.g. fast/html/keygen.html,
html5lib/runner.html, etc.
* css/html.css:
(form): Cleanup.
(keygen, select): Border radii should match so focus ring looks good.
(keygen::-webkit-keygen-select): No margin on the shadow element.
(select): Hoisting border radius to keygen, select rule.
* dom/SelectElement.cpp:
(WebCore::toSelectElement): keygen is no longer a select element.
* html/HTMLKeygenElement.cpp: Implements keygen shadow.
(WebCore::KeygenSelectElement::create):
(WebCore::KeygenSelectElement::shadowPseudoId):
(WebCore::KeygenSelectElement::KeygenSelectElement):
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::parseMappedAttribute):
(WebCore::HTMLKeygenElement::appendFormData):
(WebCore::HTMLKeygenElement::formControlType):
(WebCore::HTMLKeygenElement::reset):
(WebCore::HTMLKeygenElement::selectShadow):
* html/HTMLKeygenElement.h: keygen is no longer a select on C++ side.
(WebCore::HTMLKeygenElement::canStartSelection):
(WebCore::HTMLKeygenElement::isEnumeratable):
(WebCore::HTMLKeygenElement::isResettable):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name.
2011-02-06 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix coding style errors in ClipboardQt.h
https://bugs.webkit.org/show_bug.cgi?id=43520
Fix coding style: order of header and indentation.
* platform/qt/ClipboardQt.h:
(WebCore::ClipboardQt::create):
(WebCore::ClipboardQt::clipboardData):
(WebCore::ClipboardQt::invalidateWritableData):
2011-02-06 Antti Koivisto <antti@apple.com>
Reviewed by Maciej Stachowiak.
Use bloom filter for descendant selector filtering
https://bugs.webkit.org/show_bug.cgi?id=53880
Bloom filter is faster than a hash set in this kind of use.
Shark thinks this speeds up style matching by ~30% on sites
with lots of descendant selectors.
* ForwardingHeaders/wtf/BloomFilter.h: Added.
* css/CSSStyleSelector.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
* css/CSSStyleSelector.h:
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
media/video-document-types.html sometimes crashes the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=53884
No new tests. Already covered by media/video-document-types.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer
when cancelling the load.
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=53863
We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.
* platform/graphics/win/IconWin.cpp:
(WebCore::Icon::createIconForFiles):
* platform/graphics/win/QTMovie.cpp:
* platform/graphics/win/QTMovieGWorld.cpp:
(QTMovieGWorld::fullscreenWndProc):
(QTMovieGWorld::enterFullscreen):
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataCairoWin.cpp:
* platform/graphics/win/SimpleFontDataWin.cpp:
* platform/graphics/wince/SimpleFontDataWinCE.cpp:
* platform/win/BString.cpp:
* platform/win/ClipboardWin.cpp:
(WebCore::filesystemPathFromUrlOrTitle):
(WebCore::createGlobalHDropContent):
(WebCore::createGlobalImageFileDescriptor):
* platform/win/ContextMenuWin.cpp:
* platform/win/CursorWin.cpp:
(WebCore::loadSharedCursor):
* platform/win/FileChooserWin.cpp:
(WebCore::FileChooser::basenameForWidth):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::popupClassName):
(WebCore::PopupMenuWin::show):
* platform/win/PopupMenuWin.h:
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Replace FLT_MAX with std::numeric_limits
https://bugs.webkit.org/show_bug.cgi?id=53861
Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl.
* html/NumberInputType.cpp:
* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType):
* platform/brew/SystemTimeBrew.cpp:
(WebCore::userIdleTime):
* platform/efl/SystemTimeEfl.cpp:
(WebCore::userIdleTime):
* platform/efl/TemporaryLinkStubs.cpp:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setupAnimation):
* platform/win/SystemTimeWin.cpp:
(WebCore::userIdleTime):
* platform/wx/SystemTimeWx.cpp:
(WebCore::userIdleTime):
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773
Add a JavaScriptCore dependecy to WebCore, so CMake can
generate the correct build order for the solution.
* CMakeLists.txt:
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Unify ENABLE_SVG sections
https://bugs.webkit.org/show_bug.cgi?id=53778
* CMakeLists.txt:
2011-02-06 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Refactor Font::normalizeSpaces() to avoid an extra String copy.
https://bugs.webkit.org/show_bug.cgi?id=53871
Have normalizeSpaces() take UChar*,length arguments instead of a
String, since all call sites were creating temporaries from these
components anyway.
Font::normalizeSpaces() now always makes 1 String copy,
instead of 1 in the best case and 2 in the worst case.
* platform/graphics/Font.cpp:
(WebCore::Font::normalizeSpaces):
* platform/graphics/Font.h:
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForSimpleText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::selectionRectForComplexText):
* svg/SVGFont.cpp:
(WebCore::SVGTextRunWalker::walk):
2011-02-06 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Fix potential buffer overrun in SVGTextRunWalker::walk()
https://bugs.webkit.org/show_bug.cgi?id=53870
A new String was created from a UChar* with a 'length' argument
that could be greater than the number of UChars available.
* svg/SVGFont.cpp:
(WebCore::SVGTextRunWalker::walk):
2011-02-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove unused parameter related to XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53862
* WebCore.exp.in:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript):
(WebCore::ScriptController::executeIfJavaScriptURL):
* bindings/ScriptControllerBase.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::executeScriptInWorld):
* bindings/js/ScriptController.h:
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluate):
* bindings/v8/ScriptController.h:
2011-02-05 Adam Barth <abarth@webkit.org>
Fix Qt build.
* WebCore.pro:
2011-02-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Delete XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53859
The job of the XSSAuditor is now done by the XSSFilter. In the future,
we might rename XSSFilter to XSSAuditor.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* bindings/ScriptControllerBase.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/ScriptController.h:
* bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::evaluate):
* bindings/v8/ScriptController.h:
* bindings/v8/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
* dom/Document.cpp:
(WebCore::Document::implicitOpen):
(WebCore::Document::processBaseElement):
* dom/ScriptableDocumentParser.cpp:
(WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
* dom/ScriptableDocumentParser.h:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
* page/XSSAuditor.cpp: Removed.
* page/XSSAuditor.h: Removed.
2011-02-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Need a way to resize and scroll the page at the same time
https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>
Export a function needed by WebKit2.
* WebCore.exp.in:
2011-02-05 Patrick Gansterer <paroga@webkit.org>
Reviewed by Alexey Proskuryakov.
Use Document::encoding() instead of DocumentWriter::encoding()
https://bugs.webkit.org/show_bug.cgi?id=53398
This change makes the code more readable, when a subresource
inherits the character encoding of the document.
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::scriptCharset):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestPreload):
* platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::encodingFromAcceptCharset):
2011-02-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Introduce URLString to represent a canonicalized URL represented by a string
https://bugs.webkit.org/show_bug.cgi?id=53847
Instead of using String all over the codebase to represent a URL,
instead we should have a type to represent a canonicalized URL in the
form of a string. This patch introduces that type.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* platform/KURL.cpp:
(WebCore::KURL::KURL):
* platform/KURL.h:
(WebCore::KURL::urlString):
2011-02-05 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Style widgets not rendering
https://bugs.webkit.org/show_bug.cgi?id=53849
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId): x-qt-styled-widget is a valid class id too
2011-02-05 Jochen Eisinger <jochen@chromium.org>
Reviewed by Adam Barth.
Add ContentSecurityPolicy object to Document and pass the X-WebKit-CSP header from the MainResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=53685
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.h:
(WebCore::Document::contentSecurityPolicy):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
* page/ContentSecurityPolicy.h:
2011-02-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848
We're clearly the odd man out here. See results from every browser at:
https://github.com/abarth/url-spec/blob/master/tests/gurl-results/by-browser.txt
* platform/KURL.cpp:
(WebCore::KURL::parse):
- Just lowercase the scheme when copying.
2011-02-05 Antti Koivisto <antti@apple.com>
Reviewed by Dave Hyatt.
Optimize matching of descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=49876
<rdar://problem/8772822>
During style recalculation, maintain a filter of tags, ids and classes seen in ancestor elements.
Use the filter to quickly reject descendant and child selectors when doing style matching.
This speeds up style recalculations 3-6x on many major web sites.
* css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::collectElementIdentifiers):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
* dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):
2011-02-05 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Refactor: NotificationCenter shouldn't hold its own copy of the ScriptExecutionContext*
when it inherits one from ActiveDOMObject.
https://bugs.webkit.org/show_bug.cgi?id=53815
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotificationCenter::requestPermission):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::requestPermissionCallback):
* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):
(WebCore::NotificationCenter::disconnectFrame):
* notifications/NotificationCenter.h:
(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Crash in WebCore::TextEncoding::decode below XSSFilter::init
https://bugs.webkit.org/show_bug.cgi?id=53837
Add missing null check.
Test: http/tests/security/xssAuditor/non-block-javascript-url-frame.html
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::init):
2011-02-04 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Crashes in ShadowBlur via WebKit2 FindController
https://bugs.webkit.org/show_bug.cgi?id=53830
Fix a crash cause by re-entering ShadowBlur, and add assertions to
detect when it happens.
The re-entrancy occurred when drawRectShadowWithTiling() filled
the interior of the shadow with fillRect() on the context
which still had the shadow state set. This would make another ShadowBlur
on the stack and call into the code again, potentially blowing away
the image buffer.
Fix by turning off shadows in the destination context while we're
drawing the tiled shadow. The non-tiled code path already did this.
Not testable because CSS shadows clip out the inside of the rect
being shadowed, and SVG uses fillPath, even for rects.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::getScratchBuffer):
(WebCore::ScratchBuffer::scheduleScratchBufferPurge):
(WebCore::ShadowBlur::ShadowBlur):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Don't use a fixed size for search field icons
https://bugs.webkit.org/show_bug.cgi?id=50624
Use the parent input content box to make sure the icon fits in the
search field, scaling it down when needed.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintGdkPixbuf):
(WebCore::getIconSizeForPixelSize):
(WebCore::adjustSearchFieldIconStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::centerRectVerticallyInParentInputElement):
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::paintCapsLockIndicator):
(WebCore::RenderThemeGtk::paintMediaButton):
2011-02-04 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250
Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.
Test: fast/images/cmyk-jpeg-with-color-profile.html
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
2011-02-04 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Option text in select popup does not align with menulist button text
https://bugs.webkit.org/show_bug.cgi?id=53632
This makes clientPaddingLeft and clientPaddingRight return
the additional m_innerBlock's padding so that the popup item text
aligns with the menulist button text.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::clientPaddingLeft):
(WebCore::RenderMenuList::clientPaddingRight):
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig and Beth Dakin.
REGRESSION: Horizontal scrollbar thumbs leave artifacts over page content when scrolling vertically
<rdar://problem/8962457>
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
Subtract scrollbars from the scroll view rect if overlay scrollers are enabled.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Make sure to invalidate both scrollbars if overlay scrollers are enabled.
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.
This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.
Test: plugins/plugin-document-back-forward.html
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::appendBytes):
* page/FrameView.cpp:
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
* page/FrameView.h:
2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.
* loader/HistoryController.cpp:
* loader/HistoryController.h:
2011-02-04 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Code Changes.
CSS 2.1 failure: content-*
https://bugs.webkit.org/show_bug.cgi?id=52126
Test: fast/css/counters/content-021.html
* rendering/CounterNode.cpp:
(showCounterTree):
Made parameter const because it is supposed to be so.
* rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::areRenderersElementsSiblings):
(WebCore::nextInPreOrder):
Added these local helper functions to help navigate the DOM tree
enriched with :before and :after pseudo elements.
(WebCore::planCounter):
Fixed bug that would create a repeat counter for second and
subsequent renderers associated with the same DOM element.
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
Changed to use the new tree navigation functions described above
instead of the Renderer Tree navigation functions.
(WebCore::RenderCounter::rendererSubtreeAttached):
(WebCore::RenderCounter::rendererStyleChanged):
Optimized to not bother about counters until the renderers are
finally attached.
(showRendererTree):
(showNodeTree):
Debug helper functions used to debug Counter bugs.
2011-02-04 Dan Bernstein <mitz@apple.com>
Typo fix.
* html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::containsJavaScriptURL):
2011-02-04 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
Make an infinite loop introduced in r77454 finite.
* html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::containsJavaScriptURL):
2011-02-04 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=52697
Test: media/video-frame-accurate-seek.html
Make seeking slightly more accurate by rounding instead of truncating
when converting from seconds-in-float to time/timeScale.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTTime):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue):
* platform/graphics/win/QTMovie.cpp:
(QTMovie::setCurrentTime):
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Second IndexedDB events overhaul patch
https://bugs.webkit.org/show_bug.cgi?id=53813
If an IDBRequest has a IDBTransaction, it should propogate
events through it. In order to do this, IDBRequest needs to
hold a transaction frontend object rather than a backend one.
Test: storage/indexeddb/request-event-propagation.html
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::IDBCursor):
* storage/IDBCursor.h:
(WebCore::IDBCursor::create):
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::setSetVersionTransaction):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
* storage/IDBDatabase.h:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::IDBIndex):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* storage/IDBIndex.h:
(WebCore::IDBIndex::create):
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::create):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::contextDestroyed):
(WebCore::IDBTransaction::enqueueEvent):
* storage/IDBTransaction.h:
* storage/IDBTransaction.idl:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
Test: storage/indexeddb/error-causes-abort-by-default.html
* storage/IDBAbortEvent.cpp:
(WebCore::IDBAbortEvent::create):
(WebCore::IDBAbortEvent::IDBAbortEvent):
* storage/IDBAbortEvent.h:
* storage/IDBCompleteEvent.cpp:
(WebCore::IDBCompleteEvent::create):
(WebCore::IDBCompleteEvent::IDBCompleteEvent):
* storage/IDBCompleteEvent.h:
* storage/IDBErrorEvent.cpp:
(WebCore::IDBErrorEvent::IDBErrorEvent):
* storage/IDBEvent.cpp:
(WebCore::IDBEvent::IDBEvent):
(WebCore::IDBEvent::dispatch):
* storage/IDBEvent.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBSuccessEvent.cpp:
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
(WebCore::IDBTransaction::backend):
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
2011-02-04 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727
For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.
No new tests because no new functionality.
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::createReadable):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::create):
* platform/chromium/PlatformBridge.h:
* platform/chromium/ReadableDataObject.cpp:
(WebCore::ReadableDataObject::create):
(WebCore::ReadableDataObject::ReadableDataObject):
(WebCore::ReadableDataObject::getData):
(WebCore::ReadableDataObject::urlTitle):
(WebCore::ReadableDataObject::htmlBaseUrl):
(WebCore::ReadableDataObject::filenames):
(WebCore::ReadableDataObject::ensureTypeCacheInitialized):
* platform/chromium/ReadableDataObject.h:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Revert https://bugs.webkit.org/show_bug.cgi?id=53795
* storage/IDBAbortEvent.cpp:
(WebCore::IDBAbortEvent::create):
(WebCore::IDBAbortEvent::IDBAbortEvent):
* storage/IDBAbortEvent.h:
* storage/IDBCompleteEvent.cpp:
(WebCore::IDBCompleteEvent::create):
(WebCore::IDBCompleteEvent::IDBCompleteEvent):
* storage/IDBCompleteEvent.h:
* storage/IDBErrorEvent.cpp:
(WebCore::IDBErrorEvent::IDBErrorEvent):
* storage/IDBEvent.cpp:
(WebCore::IDBEvent::IDBEvent):
* storage/IDBEvent.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBSuccessEvent.cpp:
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
2011-02-04 Martin Galpin <martin@66laps.com>
Reviewed by David Levin.
CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773
Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::preflightSuccess):
Explicitly set the request origin after a preflight request succeeds.
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
Test: storage/indexeddb/error-causes-abort-by-default.html
* storage/IDBAbortEvent.cpp:
(WebCore::IDBAbortEvent::create):
(WebCore::IDBAbortEvent::IDBAbortEvent):
* storage/IDBAbortEvent.h:
* storage/IDBCompleteEvent.cpp:
(WebCore::IDBCompleteEvent::create):
(WebCore::IDBCompleteEvent::IDBCompleteEvent):
* storage/IDBCompleteEvent.h:
* storage/IDBErrorEvent.cpp:
(WebCore::IDBErrorEvent::IDBErrorEvent):
* storage/IDBEvent.cpp:
(WebCore::IDBEvent::IDBEvent):
(WebCore::IDBEvent::dispatch):
* storage/IDBEvent.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBSuccessEvent.cpp:
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
(WebCore::IDBTransaction::backend):
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Csaba Osztrogonác.
[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674
* css/mediaControlsQt.css:
2011-02-04 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler and Dave Hyatt.
<rdar://problem/8902704> Make ruby text size 50% by default
https://bugs.webkit.org/show_bug.cgi?id=53723
* css/html.css:
(ruby > rt): Changed the font-size from 60% to 50%.
2011-02-04 Antti Koivisto <antti@apple.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=53610
Regression: adjacent sibling selector not working as expected
<rdar://problem/8960033>
https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/8948643>
Test for additional conditions in parent style that prevent sharing.
Tests: fast/selectors/style-sharing-adjacent-selector.html
fast/selectors/style-sharing-last-child.html
* css/CSSStyleSelector.cpp:
(WebCore::parentStylePreventsSharing):
(WebCore::CSSStyleSelector::locateSharedStyle):
2011-02-04 Mark Mentovai <mark@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium GYP build fix.
When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.
Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.
The build now includes a postbuild step to prevent
http://crbug.com/71537 from regressing again. The build will fail upon
regression.
https://bugs.webkit.org/show_bug.cgi?id=53630
* WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into
direct_dependent_settings as needed, add the check_objc_rename
postbuild step.
* WebCore.gyp/mac/check_objc_rename.sh: Added.
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594
Move Chromium code for identifying and cutting out
iframe shims from plugins to cross-platform utility file
IFrameShimSupport.cpp.
Amend PluginViewQt to use this code to handle shims correctly.
* WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp
* WebCore.pro: Add Qt support for IFrameShimSupport.cpp
* plugins/IFrameShimSupport.cpp: Added.
(WebCore::getObjectStack):
(WebCore::iframeIsAbovePlugin):
(WebCore::getPluginOcclusions):
* plugins/IFframeShimSupport.h: Added.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
2011-02-04 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969
Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html
added in r76983.
* platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from
<select> drop-down setting.
(WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint
items in drop-down and pass-in bidi override flag when creating text run.
* platform/chromium/PopupMenuChromium.h: Remove directionalityHint from
PopupContainerSettings.
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Build fix from merge mistake.
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::ensureEventTargetData):
2011-02-04 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Adler.
Remove unneeded function declarations in comments in EditorClient.h
https://bugs.webkit.org/show_bug.cgi?id=53745
Removing unused commented out function declarations. No tests since this is just cleanup.
* page/EditorClient.h:
2011-02-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Refactor IDBRequest and IDBTransaction a bit
https://bugs.webkit.org/show_bug.cgi?id=53565
There were a lot of subtle issues with the way IDBTransaction
and IDBRequest used to be written. This cleans a lot of them up
and largely simplifies the logic. Using EventQueue rather than
timers is one example of the simplification.
* bindings/scripts/CodeGeneratorV8.pm:
* dom/EventQueue.cpp:
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::dispatchEvent):
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::continueFunction):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
(WebCore::IDBRequest::eventTargetData):
(WebCore::IDBRequest::ensureEventTargetData):
* storage/IDBRequest.h:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::onTimeout):
(WebCore::IDBTransaction::canSuspend):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::enqueueEvent):
(WebCore::IDBTransaction::eventTargetData):
(WebCore::IDBTransaction::ensureEventTargetData):
* storage/IDBTransaction.h:
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
Remove timeout and ontimeout from IDBTransaction per the spec.
* WebCore.gypi:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.idl:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBDatabaseBackendInterface.h:
* storage/IDBTimeoutEvent.cpp: Removed.
* storage/IDBTimeoutEvent.h: Removed.
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
* storage/IDBTransaction.idl:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
* storage/IDBTransactionBackendImpl.h:
* storage/IDBTransactionCallbacks.h:
2011-02-04 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: Can't set accessibility overridden attributes on web objects
https://bugs.webkit.org/show_bug.cgi?id=53725
accessibilitySetOverriddenValue does not work on AX objects from WebCore because
the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
attribute only when an AX client asks for it through the AX frameworks.
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691
Test: fast/repaint/slider-thumb-drag-release.html
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure
that the thumb is repainted.
2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Add "show more" data grid node and waiting message UI components.
https://bugs.webkit.org/show_bug.cgi?id=53763
- "show more" data grid node is used for on-demand population of
data grid contents (similar to DOM tree capability for limiting
displayed nodes count);
- waiting message is used for informing user about long lasting
operations (with a possibility to cancel them).
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/PleaseWaitMessage.js: Added.
(WebInspector.PleaseWaitMessage):
* inspector/front-end/ShowMoreDataGridNode.js: Added.
(WebInspector.ShowMoreDataGridNode):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.data-grid button):
(.please-wait-msg):
* inspector/front-end/inspector.html:
2011-02-04 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=53740
<rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused
Tests:
fast/forms/textarea-placeholder-visibility-1.html
fast/forms/textarea-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-1.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-3.html
* html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Add a check for shouldShowPlaceholderWhenFocused.
* html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue):
Whenever the value is updated, we should also update placeholder visibility.
* rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused):
Make the default the same as the existing behavior.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
Show placeholder when appropriate.
2011-02-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: evaluate on hover does not work on a breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=53768
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._mouseHover):
2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77625 and r77626.
http://trac.webkit.org/changeset/77625
http://trac.webkit.org/changeset/77626
https://bugs.webkit.org/show_bug.cgi?id=53765
It broke Windows builds (Requested by Ossy_ on #webkit).
* Android.jscbindings.mk:
* CMakeLists.txt:
* ForwardingHeaders/pcre/pcre.h: Added.
* ForwardingHeaders/yarr/Yarr.h: Removed.
* ForwardingHeaders/yarr/YarrInterpreter.h: Removed.
* ForwardingHeaders/yarr/YarrPattern.h: Removed.
* WebCore.gyp/WebCore.gyp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::Private::regexp):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::create):
(WebCore::RegularExpression::Private::~Private):
(WebCore::RegularExpression::match):
2011-02-04 Peter Varga <pvarga@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
Speculative windows build fix.
No new tests needed.
* platform/text/RegularExpression.cpp:
2011-02-04 Peter Varga <pvarga@webkit.org>
Reviewed by Gavin Barraclough.
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
No new tests needed.
* Android.jscbindings.mk:
* CMakeLists.txt:
* ForwardingHeaders/pcre/pcre.h: Removed.
* ForwardingHeaders/yarr/Yarr.h: Added.
* ForwardingHeaders/yarr/YarrInterpreter.h: Added.
* ForwardingHeaders/yarr/YarrPattern.h: Added.
* WebCore.gyp/WebCore.gyp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::Private::create):
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::match):
2011-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Network panel filtering is broken.
https://bugs.webkit.org/show_bug.cgi?id=53764
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._sortItems):
(WebInspector.NetworkPanel.prototype._sortByTimeline):
(WebInspector.NetworkPanel.prototype._filter):
(WebInspector.NetworkPanel.prototype._updateOffscreenRows):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.get selectable):
(WebInspector.NetworkTotalGridNode.prototype.isFilteredOut):
(WebInspector.NetworkTotalGridNode.prototype.get selectable):
2011-02-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: support overriding user agent strings
https://bugs.webkit.org/show_bug.cgi?id=51485
Test: http/tests/inspector/extensions-useragent.html
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::setUserAgentOverride):
(WebCore::InspectorController::userAgentOverride):
* inspector/InspectorController.h:
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::userAgent):
(WebCore::FrameLoader::applyUserAgent):
2011-02-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: scripts panel displays wrong file name after reload.
https://bugs.webkit.org/show_bug.cgi?id=53761
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
* WebCore.exp.in:
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorClient.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
* inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can
provide platform-specific settings accessor.
(WebCore::InspectorFrontendClientLocal::Settings::Settings):
(WebCore::InspectorFrontendClientLocal::Settings::~Settings):
(WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight):
(WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight):
* loader/EmptyClients.h:
2011-02-03 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] frame several more JS code invocations into v8::TryCatch
https://bugs.webkit.org/show_bug.cgi?id=53594
This patch is preemptive and adjusts v8 bindings code to forthcoming small change
in v8::ThrowException---currently sometimes exceptions thrown by this method
do not reach surrounding v8::TryCatch handler (see
http://code.google.com/p/v8/issues/detail?id=1072 and
http://codereview.chromium.org/6397011/). Therefore the goal of this patch
is to make forthcoming v8 roll as smooth as possible (alas, we'll still need
one rebaseline as of now.)
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::runScript): Do not rely on empty handle as a signal of exception, wrap into v8::TryCatch instead
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction): Ditto
2011-02-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/8898294>
* WebCore.exp.in: Add export now needed by WebKit2
2011-02-03 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
Replaces float literals with uniform values in shader code
so that buggy drivers unable to parse float values in different
locales will not produce a pink video.
[chromium] Fix pink video bug with gpu-acceleration enabled
https://bugs.webkit.org/show_bug.cgi?id=53568
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::SharedValues::SharedValues):
(WebCore::VideoLayerChromium::drawYUV):
* platform/graphics/chromium/VideoLayerChromium.h:
(WebCore::VideoLayerChromium::SharedValues::signAdjLocation):
2011-02-03 James Kozianski <koz@chromium.org>
Reviewed by Dimitri Glazkov.
Add navigator.registerProtocolHandler behind a flag.
https://bugs.webkit.org/show_bug.cgi?id=52609
This method is described in the HTML5 specification here,
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
This change is largely cribbed from B. Green's 29651 patches. It is
behind a flag so as not to break JS feature detection.
New layout test fast/dom/registerProtocolHandler.html.
* Configurations/FeatureDefines.xcconfig:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::registerProtocolHandler):
* page/Chrome.cpp:
(WebCore::Chrome::registerProtocolHandler):
* page/Chrome.h:
* page/ChromeClient.h:
* page/Navigator.cpp:
(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):
* page/Navigator.h:
* page/Navigator.idl:
2011-02-03 Brian Ryner <bryner@chromium.org>
Reviewed by Darin Fisher.
Add a field to the ResourceResponse for tracking the socket address
of the host that the resource was fetched from. Patch was originally
by Paul Marks.
https://bugs.webkit.org/show_bug.cgi?id=53699
* platform/network/chromium/ResourceResponse.cpp:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::socketAddress):
(WebCore::ResourceResponse::setSocketAddress):
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkIfRunInsecureContent):
* loader/FrameLoaderClient.h:
2011-02-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
REGRESSION: Artifacts on box-shadow corners in some cases
https://bugs.webkit.org/show_bug.cgi?id=53731
Fix overdrawing artifacts in ShadowBlur's tiling code path,
which show up in shadows using a color with alpha.
Test: fast/box-shadow/shadow-tiling-artifact.html
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::drawRectShadowWithTiling): Ensure
that the inner rect that gets filled does not overlap with any
of the eight tiled areas by having the corner and side dimensions
be the same for contiguous areas.
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
XSS Auditor is spinning inside decodeURLEscapeSequences() if there are
percent signs in large posted data
https://bugs.webkit.org/show_bug.cgi?id=53405
If the input string contains many non-% characters followed by a %
character that is not a valid URL escape sequence, then the old
algorithm would only advance the initial search by one character
(instead of jumping to just after the % character). That would cause
the algorithm to take N^2 time (in the number of characters before the
first % character). This patch just advances the search past the first
% character so we can start looking for next % character sooner.
* platform/KURL.cpp:
(WebCore::decodeURLEscapeSequences):
2011-02-03 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: click on a breakpoint highlights wrong line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=53692
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement):
2011-02-03 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Bail out if to string conversion returned empty handle
https://bugs.webkit.org/show_bug.cgi?id=53687
This a temporary measure: actually one probably should never get empty handle
if there was no exception. The root cause is under investigation.
The bailout though allows Chromium not to crash---attempt to convert an empty
v8 hande into WebCore string crashes with invalid memory access.
See http://code.google.com/p/chromium/issues/detail?id=71544
There is no known reduction expressible as a layout test so far. The crash found with automated testing tools.
* bindings/v8/V8Binding.cpp:
(WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
* bindings/v8/V8Binding.h:
(WebCore::V8ParameterBase::prepareBase): Ditto
2011-02-03 Adam Barth <abarth@webkit.org>
Attempt to fix Chromium build.
* html/parser/XSSFilter.cpp:
2011-02-03 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rolling out r77562.
http://trac.webkit.org/changeset/77562
https://bugs.webkit.org/show_bug.cgi?id=53630
broke chromium mac build
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/mac/check_objc_rename.sh: Removed.
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
XSS Auditor severely affects loading performance after submitting a large form
https://bugs.webkit.org/show_bug.cgi?id=49845
Switch over from the XSSAuditor to the XSSFilter, improving performance
on this example.
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterToken):
* page/XSSAuditor.cpp:
(WebCore::XSSAuditor::isEnabled):
2011-02-03 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rolling out r77567.
http://trac.webkit.org/changeset/77567
https://bugs.webkit.org/show_bug.cgi?id=53468
broke chromium linux svg, canvas tests, possibly win also?
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
2011-02-02 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Refactoring: <progress> should not use ShadowElement
https://bugs.webkit.org/show_bug.cgi?id=53583
- Introduced RenderIndicatorPart and RenderProgressBarValuePart
to be responsible for bar-part layout,
which adopted layout logic from ShadowBlockElement.
- ProgressBarValueElement is no longer a subclass of ShadowBlockElement.
- Remove dependency from RenderProgress to HTMLProgressElement and
ShadowBlockElement.
- The shadow tree is no longer removed on detach(). It becomes persistent.
This is now possible because the ShadowBlockElement dependency is gone.
- ::-webkit-appearance for -webkit-progress-bar-value is no longer referred.
That didn't make sense.
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
* html/HTMLProgressElement.h:
* html/shadow/ProgressBarValueElement.h: Added.
(WebCore::ProgressBarValueElement::ProgressBarValueElement):
(WebCore::ProgressBarValueElement::shadowPseudoId):
(WebCore::ProgressBarValueElement::createRenderer):
(WebCore::ProgressBarValueElement::create):
* rendering/RenderIndicator.cpp:
(WebCore::RenderIndicatorPart::RenderIndicatorPart):
(WebCore::RenderIndicatorPart::~RenderIndicatorPart):
(WebCore::RenderIndicatorPart::layout):
(WebCore::RenderIndicatorPart::styleDidChange):
* rendering/RenderIndicator.h: Added RenderIndicatorPart class
(WebCore::RenderIndicatorPart::originalVisibility):
(WebCore::RenderIndicatorPart::requiresForcedStyleRecalcPropagation):
(WebCore::RenderIndicatorPart::canHaveChildren):
* rendering/RenderProgress.cpp:
(WebCore::RenderProgressBarValuePart::preferredFrameRect):
(WebCore::RenderProgressBarValuePart::shouldBeHidden):
(WebCore::RenderProgress::updateFromElement):
(WebCore::RenderProgress::layoutParts):
(WebCore::RenderProgress::shouldHaveParts):
* rendering/RenderProgress.h:
(WebCore::RenderProgressBarValuePart::RenderProgressBarValuePart):
2011-02-03 Jia Pu <jpu@apple.com>
Reversion should not be marked as misspelled.
https://bugs.webkit.org/show_bug.cgi?id=53255
This patch includes fix for reported bug, and also some housekeeping changes.
To implement desired behavior, we need:
1. Add a new marker type, SpellCheckingExemption, since now we distingusish between text
that shouldn't be spellchecked and text shouldn't be autocorrected.
2. Make sure that there is no pending correction panel when we enter markAllMisspellingsAndBadGrammarInRanges().
Otherwise the spell checking code in that function may interfere with autocorrection. This
is achieved by explicitly applying pending correction when user types space, line break or
paragraph break.
Housekeeping code changes include:
1. Change manual-tests that were broken by relocated WebCore directory.
2. Use TextIterator in various DocumentMarkerController functions instead of using
Node::traverseNextNode() directly.
3. Allow passing multiple marker types into DocumentMarkerController::removeMarkers() and
DocumentMarkerController::hasMarkers() to improve clarity and efficiency.
4. Fixes of minor bugs that were exposed previously.
* WebCore.exp.in: Change signature of DocumentMarkerController::removeMarkers().
* dom/DocumentMarker.h: Added new marker type SpellCheckingExemption.
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::removeMarkers): Use TextIterator to scan the range to be
consistent with addMarker() function. Allow passing in multiple marker types in one call.
Added a boolean argument to specify the behavior when removing markers that partially
overlap the specified range.
(WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Allow passing in
multiple marker types in one call.
(WebCore::DocumentMarkerController::hasMarkers): Use TextIterator to scan the range to be
consistent with addMarker() function. Allow passing in multiple marker types in one call.
* dom/DocumentMarkerController.h: Allow passing in multiple marker types to removeMarkers()
and hasMarkers(). Added a boolean argument to removeMarkers() to specify the behavior when
removing markers that partially overlap the specified range.
* editing/Editor.cpp:
(WebCore::markerTypesForAutocorrection): Add SpellCheckingExemption marker when apply correction.
(WebCore::markerTypesForReplacement): Ditto.
(WebCore::Editor::respondToChangedSelection): Reordered call to dismissCorrectionPanel() and
setSelection() to make sure there is no pending correction when entering
markAllMisspellingsAndBadGrammarInRanges().
(WebCore::Editor::appliedEditing): Only remove CorrectionIndicator markers when the command
is a top level command to improve efficiency.
(WebCore::Editor::insertTextWithoutSendingTextEvent): Added code to applying pending correction.
(WebCore::Editor::insertLineBreak): Ditto.
(WebCore::Editor::insertParagraphSeparator): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Don't mark mispelling if the
text carries SpellCheckingExemption marker.
(WebCore::Editor::correctionPanelTimerFired): Reset correction panel if the returned suggestion
from spellchecker is an empty string.
(WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
Use new DocumentMarkerController::removeMarkers() to replace custom implemenation to improve
efficiency and readability.
(WebCore::Editor::applyCorrectionPanelInfo): Remove the code that set caret position after
applying correction, since it's unnecessary. Also, store pre-correction string together with
the marker for reversion panel to use.
(WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate): Apply pending correction.
(WebCore::Editor::changeSelectionAfterCommand): Moved marker removal code to Editor::appliedEditing()
where we have access to EditCommand object.
* editing/Editor.h: Added new function applyAutocorrectionAfterTypingIfAppropriate().
* manual-tests/autocorrection/autocorrection-cancelled-by-ESC.html: Change manual-tests that
were broken by relocated WebCore directory.
* manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Ditto.
* manual-tests/autocorrection/autocorrection-contraction.html: Ditto.
* manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Ditto.
* manual-tests/autocorrection/delete-to-dismiss-reversion.html: Ditto.
* manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Ditto.
* manual-tests/autocorrection/dismiss-multiple-guesses.html: Ditto.
* manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Ditto.
* manual-tests/autocorrection/select-from-multiple-guesses.html: Ditto.
* manual-tests/autocorrection/spell-checking-after-reversion.html: Added.
* manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Change manual-tests that
were broken by relocated WebCore directory.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDocumentMarkers): Code clean-up to be more concise.
2011-02-03 Abhishek Arya <inferno@chromium.org>
Unreviewed, qt build fix.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject):
2011-02-03 Brian Salomon <bsalomon@google.com>
Reviewed by James Robinson.
Handle non-raster backed images in getUnmultipliedImageData()
https://bugs.webkit.org/show_bug.cgi?id=53468
No new tests. Existing canvas tests sufficient
LayoutTests/canvas/philip/...
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
2011-02-03 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
Enforce more limits on root inline boxes height calculations.
https://bugs.webkit.org/show_bug.cgi?id=53729
Test: fast/overflow/overflow-height-float-not-removed-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject): prevent logicalBottom to
become negative when logicalTop is INT_MAX.
(WebCore::RenderBlock::markLinesDirtyInBlockRange): when logicalBottom
is INT_MAX, we should dirty everything. So, we bail out to make
afterLowest equal to the lastRootBox() or lowestDirstLine.
2011-02-03 David Levin <levin@chromium.org>
Reviewed by Adam Barth and Oliver Hunt.
Worker.importScript() should clean errors for cross origin imports.
https://bugs.webkit.org/show_bug.cgi?id=52871
Test: http/tests/workers/worker-importScriptsOnError.html
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate): Use sanitizeScriptError
to determine when to create a clean exception.
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate): Ditto.
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::sanitizeScriptError): Figure out
if the error needs to be cleaned up.
(WebCore::ScriptExecutionContext::dispatchErrorEvent): Extracted
sanitizeScriptError for use by other places.
* dom/ScriptExecutionContext.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts): Use the reponse url when
telling the evaluate where the script came fro.
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::responseURL): Expose the url that
the script was loaded from (which may be different from url() due
to redirects).
(WebCore::WorkerScriptLoader::didReceiveResponse): Capture the reponse url.
* workers/WorkerScriptLoader.h:
2011-02-03 Mark Mentovai <mark@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium GYP build fix.
When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.
Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.
The build now includes a postbuild step to prevent
http://crbug.com/71537 from regressing again. The build will fail upon
regression.
https://bugs.webkit.org/show_bug.cgi?id=53630
* WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into
direct_dependent_settings as needed, add the check_objc_rename
postbuild step.
* WebCore.gyp/mac/check_objc_rename.sh: Added.
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make XSSFilter go fast by adding a SuffixTree
https://bugs.webkit.org/show_bug.cgi?id=53665
The SuffixTree lets us quickly reject snippets if the POST data is
large (because we can avoid a linear scan over the POST data).
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::init):
(WebCore::XSSFilter::isContainedInRequest):
* html/parser/XSSFilter.h:
2011-02-03 Mihai Parparita <mihaip@chromium.org>
Reviewed by Alexey Proskuryakov.
REGRESSION (r77355): Page cache layout tests crash
https://bugs.webkit.org/show_bug.cgi?id=53648
Test: fast/events/pagehide-timeout.html
Suspend active DOM objects after all pagehide event handlers have run,
otherwise it's possible for them to create more objects that weren't
getting suspended.
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
2011-02-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
SerializedScriptValue should not require v8 to create undefined and null values
https://bugs.webkit.org/show_bug.cgi?id=53730
Instead of creating a v8 type and passing that into the constructor, just use
the writer class directly. While I was at it, I cleaned up the code a bit too
by getting rid of the WireData/StringValue enum as I found that personally
confusing.
This is necessary because these methods are called by IndexedDB in the browser
process where v8 is not spun up.
No functionality changed and not possible to test.
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::release):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/v8/SerializedScriptValue.h:
2011-02-03 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/8944544> Ability to animate track
for WKPainter scrollers
Two new WebKitSystemInterface functions.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Use Scrollbar::convertFromContainingView() to return the right point.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
ScrollKnobAnimation is now ScrollbarPartAnimation. It can
now be used to animate the knob or the track.
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
Scrollbars need invalodating after the overlay state changes.
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
2011-02-03 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Scroll thumb jumps to top when resizing horizontally.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Add call to update
the scrollbar's offset in the case where we may have created
a new scrollbar but have not changed the current position.
2011-02-03 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
startAnimations should use a local, RefCounted Vector.
https://bugs.webkit.org/show_bug.cgi?id=53458
Test: svg/custom/use-animation-in-fill.html
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::startAnimations):
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
XSSFilter shouldn't bother to analyze pages without "injection"
characters in the request
https://bugs.webkit.org/show_bug.cgi?id=53664
If the request lacks these "injection" characters, then it's unlikely
that there's a reflective XSS attack happening. This hueristic lets us
avoid analyzing the vast majority of responses for XSS. Of course, the
hueristic isn't perfect. Because of this huerstic, we miss out on
injections into unquoted attributes. However, it's a trade-off that's
worked well in the XSSAuditor.
* html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::isRequiredForInjection):
(WebCore::XSSFilter::XSSFilter):
(WebCore::XSSFilter::init):
(WebCore::XSSFilter::filterToken):
(WebCore::XSSFilter::isContainedInRequest):
* html/parser/XSSFilter.h:
2011-02-03 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Fixing a compositor crash occurring on layers
without an associated RenderSurface.
https://bugs.webkit.org/show_bug.cgi?id=53679
Regression was introduced by in r77425
Test: http://webkit.org/blog/386/3d-transforms/ doesn't crash
anymore.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayer):
2011-02-03 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/8948788> Text emphasis marks have wrong orientation for vertical text
https://bugs.webkit.org/show_bug.cgi?id=53709
Covered by rendering of fast/text/emphasis-vertical.html
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::scaledFontData): Give the scaled font the same orientation this font
has.
2011-02-02 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Moving cursor down in table cycles at the end of a row
https://bugs.webkit.org/show_bug.cgi?id=50012
Avoids a caret cycling issue with certain content (e.g. tables) found at the very
end of a document due to a bug in nextLeafWithSameEditability.
Test: editing/selection/move-by-line-cycles-in-table.html
* editing/visible_units.cpp:
(WebCore::nextLeafWithSameEditability): Properly avoid descending back into the
original leaf node.
2011-02-03 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove dead code related to changes panel.
https://bugs.webkit.org/show_bug.cgi?id=53688
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ChangesView.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(#error-warning-count):
(#error-warning-count:hover):
(#error-count + #warning-count):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
2011-02-02 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add notification of the end of a rubber band.
<rdar://problem/8940648>
* WebCore.exp.in:
Add additional exprots.
* page/ChromeClient.h:
(WebCore::ChromeClient::didCompleteRubberBandForMainFrame):
* page/FrameView.cpp:
(WebCore::FrameView::didCompleteRubberBand):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::didCompleteRubberBand):
* platform/ScrollView.h:
Add hook.
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::inLiveResize):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleWidth):
(WebCore::ScrollableArea::overhangAmount):
(WebCore::ScrollableArea::didCompleteRubberBand):
Reorganize and de-virtualize live resize notifications.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Call the new hook when the rubberband ends.
2011-02-02 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] complex joining characters positioned in wrong place
https://bugs.webkit.org/show_bug.cgi?id=53637
Provide the correct font metrics to Harfbuzz related to the font design space.
There are used in some fonts for GPOS positioning.
Test: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::setupFontForScriptRun):
(WebCore::ComplexTextController::allocHarfbuzzFont):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::emSizeInFontUnits):
(WebCore::FontPlatformData::operator=):
* platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::FontPlatformData):
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
https://bugs.webkit.org/show_bug.cgi?id=53634
Test: fast/dom/HTMLInputElement/input-slider-update.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue): Added a call to InputType::valueChanged.
* html/InputType.cpp:
(WebCore::InputType::valueChanged): Added empty implementation.
* html/InputType.h: Added def.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::valueChanged): Added implementation that dirties layout
bit on the thumb.
* html/RangeInputType.h: Added def.
2011-02-02 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: do not share source frames between resources panel and scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=53584
Currently, we show error messages only for resources. This change will allow showing error
messages in source frame even when resource is not available (eval scripts, inlined scripts).
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.addMessage):
(WebInspector.ConsoleView.prototype.clearMessages):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.recreateResourceView):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._setBubbleText):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
(WebInspector.ScriptsPanel.prototype.addConsoleMessage):
(WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
(WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
(WebInspector.ScriptsPanel.prototype._sourceFrameForScript):
2011-02-03 Simon Fraser <simon.fraser@apple.com>
Fix 32-bit builds.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::blurLayerImage):
2011-02-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Add reporting of JS heap size limit to 'console.memory'.
https://bugs.webkit.org/show_bug.cgi?id=53592
In JSC there is no limit, thus 'undefined' value is returned.
For V8, the limit reported by the VM is returned.
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSMemoryInfoCustom.cpp: Added.
* bindings/js/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::getHeapSize):
* bindings/js/ScriptGCEvent.h:
* bindings/v8/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::getHeapSize):
* bindings/v8/ScriptGCEvent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
* page/MemoryInfo.cpp:
(WebCore::MemoryInfo::MemoryInfo):
* page/MemoryInfo.h:
(WebCore::MemoryInfo::jsHeapSizeLimit):
* page/MemoryInfo.idl:
2011-01-27 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.
2011-02-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
ShadowBlur radius for CSS shadows is slightly too big
https://bugs.webkit.org/show_bug.cgi?id=53660
If we follow SVG gaussian blur for CSS shadows, we can end up rendering
shadows that extend further than the CSS "blur radius", which results
in the shadows being truncated.
Fix with a small fudge factor to reduce the kernel diameter slightly
for CSS shadows.
Also more closely follow the algorithm described in the SVG spec
for computing the kernel size for different diameters, and clean up
some variable naming relating to the shadow bounds.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::blurLayerImage):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
2011-02-01 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce new api for managing JavaScript breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=53235
Single protocol breakpoint (e.g. set by url) is mapped on zero or more VM breakpoints (set by sourceID).
removeJavaScriptBreakpoint(breakpointId) removes breakpoint and all linked VM breakpoints.
Since UI uses VM breakpoint location rather then protocol breakpoint location, all resolved breakpoints locations are passed to frontend.
SourceFrame is now aware of whether breakpoint is resolved or not and may display it accordingly.
JavaScriptBreakpointsSidebarPane filters out breakpoints set on nonexistent scripts to avoid UI cluttering.
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp: clear breakpoints from inspector state when new frontend is created
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::restoreDebugger):
(WebCore::InspectorAgent::showAndEnableDebugger):
(WebCore::InspectorAgent::enableDebugger):
* inspector/InspectorAgent.h:
* inspector/InspectorDebuggerAgent.cpp: manage relations between protocol breakpoints and VM breakpoints
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
(WebCore::InspectorDebuggerAgent::setJavaScriptBreakpointBySourceId):
(WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
* inspector/InspectorDebuggerAgent.h:
(WebCore::InspectorDebuggerAgent::Script::Script):
* inspector/InspectorValues.cpp:
(WebCore::InspectorValue::asNumber):
(WebCore::InspectorBasicValue::asNumber):
(WebCore::InspectorObject::remove):
* inspector/InspectorValues.h:
(WebCore::InspectorObject::getNumber):
(WebCore::InspectorObject::find):
* inspector/ScriptBreakpoint.h:
(WebCore::ScriptBreakpoint::ScriptBreakpoint):
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.addLocation):
* inspector/front-end/BreakpointManager.js: remove all stuff related to JavaScript breakpoints from here
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
(WebInspector.BreakpointManager.prototype._validateBreakpoints):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane): filter breakpoints set on nonexistent scripts to avoid ui cluttering
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel): pull all JavaScript from localStorage and push them to fronted when debugger is enabled, save resolved breakpoints data
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.sourceLine):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SourceFrame.js: handle resolved and unresolved breakpoints differently
* inspector/front-end/inspector.js:
2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
SVG <text> with font-size smaller or equal to 1 does not paint correctly
https://bugs.webkit.org/show_bug.cgi?id=14242
misplaced text in SVG
https://bugs.webkit.org/show_bug.cgi?id=17053
Don't render very small (but zoomed) text inside SVG
https://bugs.webkit.org/show_bug.cgi?id=19393
Tiny fonts scaled up end up too large in Safari
https://bugs.webkit.org/show_bug.cgi?id=20192
Stretched SVG Text has awful glyph spacing
https://bugs.webkit.org/show_bug.cgi?id=21774
REGRESSION (r72141?): svg/batik/text/smallFonts.svg failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=49846
[Gtk] Text height in zoomed SVG is 1px too high
https://bugs.webkit.org/show_bug.cgi?id=50313
SVG text smaller than 0.5px not displayed properly
https://bugs.webkit.org/show_bug.cgi?id=50528
When rendering text, we're selecting a font with a size, as specified in the markup.
This can lead to problems, if the context, where the text is rendered upon, is scaled. If a parent
element of the <text> defines a transform=".." or the outermost <svg> containing a viewBox the
problem becomes apparent.
Consider following two snippets, which should render exactly the same:
<svg viewBox="0 0 100 100"><text x="25" y="50" font-size="25">test</text></svg>
<svg viewBox="0 0 1 1"><text x="0.25" y="0.5" font-size="0.25">test</text></svg>
When selecting a font size below 0.5, FontCacheMac would request a font with size 0,
which AppKit turns into 12. This lead to huge text rendering, instead of small text on Mac.
Other platforms have different problems (Qt simply scales the font, leading to pixelation etc.)
To fix this in a cross-platform fashion, we now always compute the final font size on screen,
remove any scaling from the context, draw the text using the scaled font size, then reapply
the context scale. This makes the example snippets above render exactly the same and fixes
numerous of bugs, present since years. As we're now heavily using floating-point font sizes
internally, depending on the scale of the document, it's very important to use the new
floating-point text metrics information (floatAscent/floatDescent/floatHeight) everywhere in SVG.
Fixes existing tests: css3/zoom-coords.xhtml (cross-platform inconsistencies should be gone, mac now reports floatHeight values for SVG text height)
svg/hixie/text/003.html (no more pixelation)
svg/batik/text/smallFonts.svg (small fonts aren't rendered huge anymore on mac)
svg/hixie/viewbox/preserveAspectRatio/001.xml (bug 21774, no more awful spacing)
svg/zoom/page/zoom-zoom-coords.xhtml (cross-platform inconsistencies should be gone, inspired by bug 50313)
Tests: svg/text/font-size-below-point-five-2.svg (reduction from bug 50528)
svg/text/font-size-below-point-five.svg (reduction from bug 50528)
svg/text/scaled-font.svg (reduction from bug 12448)
svg/text/small-fonts-2.svg (reduction from bug 14242)
svg/text/small-fonts-3.svg (reduction from bug 17053)
svg/text/small-fonts-in-html5.html (reduction from bug 19393)
svg/text/small-fonts.svg (reduction from bug 20192))
* rendering/svg/RenderSVGInlineText.cpp: Cache 'float scalingFactor' & 'Font scaledFont', whenever the on-screen representation changes.
* rendering/svg/RenderSVGInlineText.h:
* rendering/svg/RenderSVGText.cpp: Update scalingFactor/scaledFont, if necessary.
* rendering/svg/SVGInlineTextBox.cpp: Switch to new font rendering strategy. Always use scaledFont, and remove any context scale before drawing.
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGTextLayoutEngineBaseline.cpp: Use floating-point metrics everywhere.
* rendering/svg/SVGTextMetrics.cpp: Ditto.
* rendering/svg/SVGTextMetrics.h: Ditto.
* rendering/svg/SVGTextQuery.cpp: Ditto.
* svg/SVGFont.cpp: Adjust stroke thickness, when drawing SVGFonts into a normalized context (no more scale).
* svg/SVGTextContentElement.cpp: Make <text> elements always dependant on window size changes in combination with viewBox set.
* svg/SVGTextPositioningElement.cpp: Remove now unnecessary code to determine wheter relative lengths are used as text attributes.
* svg/SVGTextPositioningElement.h:
2011-02-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: resources panel doesn't show frames after reload.
https://bugs.webkit.org/show_bug.cgi?id=53430
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show):
(WebInspector.ResourcesPanel.prototype.loadEventFired):
(WebInspector.ResourcesPanel.prototype._initDefaultSelection):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.clear):
* inspector/front-end/inspector.js:
(WebInspector.loadEventFired):
2011-02-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Remove the *2 suffix from the CSS style-related protocol methods
https://bugs.webkit.org/show_bug.cgi?id=53492
* inspector/Inspector.idl:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStyleForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyles):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
* inspector/InspectorCSSAgent.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleModel.prototype._onRevert):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.createForId):
(WebInspector.CSSStyleSheet.prototype.setText):
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter about data URLs
https://bugs.webkit.org/show_bug.cgi?id=53662
The XSS filter doesn't really make sense for data URLs because
everything in a "response" from a data URL was part of the request.
Test: http/tests/security/xssAuditor/data-urls-work.html
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::init):
(WebCore::XSSFilter::filterToken):
2011-02-02 Chris Evans <cevans@chromium.org>
Reviewed by Darin Fisher.
window.find() can fail when switching case sensitivity
https://bugs.webkit.org/show_bug.cgi?id=53654
Reset the pattern to a safe one when done, to avoid usearch_reset()
indirectly touching the old, stale text pointer.
Test: fast/text/find-window.html
* editing/TextIterator.cpp:
(WebCore::SearchBuffer::~SearchBuffer): leave a safe pattern buffer when done.
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter that <param> elements can contain URLs
https://bugs.webkit.org/show_bug.cgi?id=53652
When loading plugins for the <object> tag, we're "smart" enough to
reach into the <param> elements and pull out the URL in some cases.
This patch teaches the XSSFilter how to block injections into those
sorts of param elements.
Fixes:
http/tests/security/xssAuditor/object-*
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::isURLParameter):
(WebCore::HTMLParamElement::isURLAttribute):
(WebCore::HTMLParamElement::addSubresourceAttributeURLs):
* html/HTMLParamElement.h:
- Add a helper function so that HTMLParamElement can share the
ground truth for these names with the XSSFilter.
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterTokenInitial):
(WebCore::XSSFilter::filterParamToken):
* html/parser/XSSFilter.h:
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Levin.
GCC compiler on ARM issues bogus warnings and fails to compile.
https://bugs.webkit.org/show_bug.cgi?id=53620
Despite warnings explicitly being disallowed (-Wno-uninitialized),
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 throws up the warnings like:
"error: 'colorTransparent.unstatic.4909' may be used uninitialized in this function"
The fix is to add an extra condition, which somehow pacifies the compiler.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::createColor): Added workaround conditions.
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter about X-XSS-Protection
https://bugs.webkit.org/show_bug.cgi?id=53640
This patch causes us to pass:
http/tests/security/xssAuditor/full-block-*
http/tests/security/xssAuditor/no-protection-script-tag.html
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::XSSFilter):
(WebCore::XSSFilter::init):
(WebCore::XSSFilter::filterToken):
* html/parser/XSSFilter.h:
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
When XSSFilter blocks JavaScript URLs, use a safe JavaScript URL
instead of the empty string
https://bugs.webkit.org/show_bug.cgi?id=53643
In a URL context, the empty string completes to the URL of the current
page, which causes these tests to go into an infinite loop. Instead,
we should use a "safe" JavaScript URL that does nothing.
Fixes:
http/tests/security/xssAuditor/javascript-link*
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
2011-02-02 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display in WebKit under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=44942
Test: fast/text/bidi-embedding-pop-and-push-same-2.html
* platform/text/BidiResolver.h:
(WebCore::::commitExplicitEmbedding): Changed to return a boolean indicating whether there was
a change to embedding levels.
(WebCore::::createBidiRunsForLine): If embedding levels did not change as a result of committing
the explicit embedding sequence, then runs were not added, and we should continue normally.
2011-02-02 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix miscalculation of the overhang area used for painting. We were
not correctly accounting for scrollbars resulting in an non-negative
overhang even when we weren't over the edge.
* platform/ScrollView.cpp:
(WebCore::ScrollView::calculateOverhangAreasForPainting):
2011-02-02 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IDBTransaction and IDBRequest can be deleted while ScriptExecutionContext is iterating....which is bad
https://bugs.webkit.org/show_bug.cgi?id=52722
The solution is to change ScriptExecutionContext's destructor to iterate over
the list in a way that handles the mutations. This new method is destructive,
but that's OK since the object is going away. I've also added a several asserts.
There should be no behavior change.
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::createdActiveDOMObject):
(WebCore::ScriptExecutionContext::destroyedActiveDOMObject):
* dom/ScriptExecutionContext.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::contextDestroyed):
* storage/IDBTransaction.h:
2011-02-02 Mark Rowe <mrowe@apple.com>
Build fix.
* WebCore.exp.in: Remove some bogus symbols from the .exp.in file.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar): Look the object
up in the HashMap rather than relying on a local variable that doesn't
exist.
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter about JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=53635
This patch teaches the XSSFilter to check for JavaScript URLs in
attribute values. If this approach has too many false positives, we
can restrict which attribute names we examine.
Fixes these tests:
http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html
http/tests/security/xssAuditor/dom-write-location-javascript-URL.html
http/tests/security/xssAuditor/iframe-javascript-url*
* html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::containsJavaScriptURL):
(WebCore::XSSFilter::filterTokenInitial):
(WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
* html/parser/XSSFilter.h:
2011-02-02 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig, even though this is just a...
...build fix.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
2011-02-02 Mark Rowe <mrowe@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/8952012> Crash on launch inside scrollbar code.
We need to ensure that we remove ourselves as the delegates of objects when we're going
away as failing to do this can lead to crashes if the lifetime of the other objects
is longer than ours.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
2011-02-02 Beth Dakin <bdakin@apple.com>
Build fix.
* WebCore.exp.in:
2011-02-02 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r77397.
* page/wince/FrameWinCE.cpp:
(WebCore::computePageRectsForFrame):
2011-02-02 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r77398.
* platform/graphics/wince/PlatformPathWinCE.cpp:
(WebCore::containsPoint):
(WebCore::inflateRectToContainPoint):
(WebCore::PlatformPath::addRect):
* platform/graphics/wince/SharedBitmap.cpp:
(WebCore::SharedBitmap::drawPattern):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintMenuListButton):
(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
(WebCore::RenderThemeWinCE::paintSliderTrack):
(WebCore::RenderThemeWinCE::paintMediaMuteButton):
(WebCore::RenderThemeWinCE::paintMediaPlayButton):
(WebCore::RenderThemeWinCE::paintMediaSeekBackButton):
(WebCore::RenderThemeWinCE::paintMediaSeekForwardButton):
2011-02-02 Jian Li <jianli@chromium.org>
Reviewed by Kenneth Russell.
[V8] Accessing DataView with index of -1 returns 0, doesn't throw
https://bugs.webkit.org/show_bug.cgi?id=53559
Added test cases to cover this in fast/canvas/webgl/data-view-test.html.
* html/canvas/DataView.h:
(WebCore::DataView::beyondRange):
2011-02-02 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Add ChromeClient function to paint custom overhang areas.
https://bugs.webkit.org/show_bug.cgi?id=53639
* page/Chrome.cpp:
(WebCore::ChromeClient::paintCustomOverhangArea):
* page/ChromeClient.h:
Add ChromeClient function.
* page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
* page/FrameView.h:
Call out the the ChromeClient, call ScrollView base implementation
if the ChromeClient returns false.
* platform/ScrollView.cpp:
(WebCore::ScrollView::paintOverhangAreas):
* platform/ScrollView.h:
Add dirty rect for use when painting overhang areas.
2011-02-02 Peter Kasting <pkasting@google.com>
Not reviewed, build fix.
Fix compile after r77427.
https://bugs.webkit.org/show_bug.cgi?id=53455
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::operator=):
* platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::decodeBMP):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::outputScanlines):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):
2011-02-02 Peter Kasting <pkasting@google.com>
Reviewed by David Levin.
Clean up ImageDecoder's comments (remove/trim/clarify).
https://bugs.webkit.org/show_bug.cgi?id=53455
This also renames or eliminates a couple of functions for clarity, and
switches a couple erroneous strncmp() calls to memcmp().
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::setSize):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::originalFrameRect):
(WebCore::ImageFrame::setOriginalFrameRect):
(WebCore::ImageDecoder::ImageDecoder):
(WebCore::ImageDecoder::~ImageDecoder):
(WebCore::ImageDecoder::isSizeAvailable):
(WebCore::ImageDecoder::size):
(WebCore::ImageDecoder::setIgnoreGammaAndColorProfile):
(WebCore::ImageDecoder::clearFrameBufferCache):
(WebCore::ImageDecoder::isOverSize):
* platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::processNonRLEData):
* platform/image-decoders/cg/ImageDecoderCG.cpp:
(WebCore::ImageFrame::setSize):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/qt/ImageFrameQt.cpp:
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::setSize):
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::setSize):
* platform/image-decoders/webp/WEBPImageDecoder.h:
2011-02-02 Vangelis Kokkevis <vangelis@chromium.org>
[chromium] Adding support for reflections to the accelerated
compositing path.
https://bugs.webkit.org/show_bug.cgi?id=53179
All layout tests in compositing/reflections generate correct
results with the exception of:
1. nested-reflection-anchor-point.html : There appears to be
some issue with the layer transform math that I haven't been
able to track down yet.
2. reflection-opacity.html : The current implementation applies
opacity before doing the reflection which makes this test
produce incorrect results. This will affect reflected layers
with opacity that overlap their original layer. FIXME comment
added in the code.
Tests: Covered by existing layout tests in compositing/reflections.
Please see above for exceptions.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setReplicaLayer):
(WebCore::LayerChromium::replicaLayer):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayersRecursive):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::drawableContentRect):
(WebCore::RenderSurfaceChromium::drawSurface):
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::drawTransform):
2011-02-02 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Select popup with padding has white strip on right
https://bugs.webkit.org/show_bug.cgi?id=53602
No new tests as this change restores old behavior.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::layout):
2011-02-02 Beth Dakin <bdakin@apple.com>
Reviewed by Mark Rowe.
Fix for <rdar://problem/8950343> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebCore:
WebCore::ScrollbarThemeMac::unregisterScrollbar + 22
It is possible for a Scrollbar's ScrollableArea to be null,
so we must null check.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
bufferData and bufferSubData should generate INVALID_VALUE with negative input
https://bugs.webkit.org/show_bug.cgi?id=53626
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
2011-02-02 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler and Steve Falkenburg.
Add DerivedSources.make to some Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53607
* WebCore.vcproj/WebCoreGenerated.vcproj: Add DerivedSources.make.
2011-02-02 Cris Neckar <cdn@chromium.org>
Reviewed by James Robinson.
Refcount domwindows when dispatching device orientation events.
https://bugs.webkit.org/show_bug.cgi?id=53623
Test: fast/events/device-orientation-crash.html
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::didChangeDeviceMotion):
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::timerFired):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
* dom/DeviceOrientationController.h:
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::checkObjectToBeBound): Helper function to bind* and useProgram.
(WebCore::WebGLRenderingContext::bindBuffer): Use checkObjectToBeBound.
(WebCore::WebGLRenderingContext::bindFramebuffer): Ditto.
(WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto.
(WebCore::WebGLRenderingContext::bindTexture): Ditto, also check the target matching.
(WebCore::WebGLRenderingContext::deleteObject): Helper funtion to delete*.
(WebCore::WebGLRenderingContext::deleteBuffer): Use deleteObject.
(WebCore::WebGLRenderingContext::deleteFramebuffer): Ditto.
(WebCore::WebGLRenderingContext::deleteProgram): Ditto.
(WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto.
(WebCore::WebGLRenderingContext::deleteShader): Ditto.
(WebCore::WebGLRenderingContext::deleteTexture): Ditto.
(WebCore::WebGLRenderingContext::useProgram): Use checkObjectToBeBound.
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLTexture.h:
(WebCore::WebGLTexture::getTarget): Accessor to cached target.
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Unreviewed Efl buildfix after r77399.
* CMakeListsEfl.txt:
2011-02-02 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Rename Typed Array subset to subarray
https://bugs.webkit.org/show_bug.cgi?id=53618
* html/canvas/Float32Array.cpp:
(WebCore::Float32Array::subarray):
* html/canvas/Float32Array.h:
* html/canvas/Float32Array.idl:
* html/canvas/Int16Array.cpp:
(WebCore::Int16Array::subarray):
* html/canvas/Int16Array.h:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.cpp:
(WebCore::Int32Array::subarray):
* html/canvas/Int32Array.h:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.cpp:
(WebCore::Int8Array::subarray):
* html/canvas/Int8Array.h:
* html/canvas/Int8Array.idl:
* html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::subarrayImpl):
* html/canvas/Uint16Array.cpp:
(WebCore::Uint16Array::subarray):
* html/canvas/Uint16Array.h:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.cpp:
(WebCore::Uint32Array::subarray):
* html/canvas/Uint32Array.h:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.cpp:
(WebCore::Uint8Array::subarray):
* html/canvas/Uint8Array.h:
* html/canvas/Uint8Array.idl:
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add an empty file for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=53573
Posting this as a separate patch because editing the build files is so
painful.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
2011-02-02 Dan Winship <danw@gnome.org>
Reviewed by Martin Robinson.
[GTK] remove old data: URI handler, fix the SoupRequest-based one
to pass tests
https://bugs.webkit.org/show_bug.cgi?id=50885
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback): Do content-type sniffing here for
non-HTTP requests.
(WebCore::startHTTPRequest): Rename to match WebKit style.
(WebCore::ResourceHandle::start): Pass everything except HTTP to
startNonHTTPRequest, letting the SoupRequester decide whether it's
supported or not.
(WebCore::startNonHTTPRequest): Remove some old pre-SoupRequester
code that was a no-op for file: URIs, but would break some data:
URIs.
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Update even more references to right() and bottom() in Chromium. Sheesh.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::getFramebufferPixels): Replaced bottom/right with maxY/maxX.
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Unreviewed Gtk3 buildfix after r77286.
https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintMenuList):
2011-02-02 Anders Carlsson <andersca@apple.com>
Fix build.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::pinnedInDirection):
2011-02-02 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=53619
Floats should not use physical terminology for their rects. Replace left/top with x/y and right/bottom
with maxX/maxY. This matches IntRect.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::x):
(WebCore::RenderBlock::FloatingObject::maxX):
(WebCore::RenderBlock::FloatingObject::y):
(WebCore::RenderBlock::FloatingObject::maxY):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Update more references to right() and bottom() in Chromium Win.
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::compositeOpaqueComposite): Replaced bottom/right with maxY/maxX.
(WebCore::TransparencyWin::compositeTextComposite): Ditto.
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::paintMenuList): Ditto.
2011-02-02 Adam Roben <aroben@apple.com>
Encode/decode FormData and FormDataElement objects consistently
Fixes <http://webkit.org/b/53615> <rdar://problem/8943346> WebKit2: Restoring session state
that contains form data fails (asserts in Debug build)
To prevent this from interfering with WebKit2 testing, it's useful to get this into a build
now, even though we don't have an automated test for it yet. Writing a test is covered by
<http://webkit.org/b/53616>.
Reviewed by Darin Adler.
* history/HistoryItem.cpp: Bump the encoding version, since this patch changes how we encode
FormData objects.
* platform/network/FormData.cpp:
(WebCore::decode): Decode the type from the Decoder, rather than getting it from the
default-constructed FormDataElement. Failing to do this meant that all future uses of the
Decoder would be reading from an unexpected part of the buffer (i.e., the next decode would
start by reading the uint32_t that we forgot to decode here, and so on). We already had code
to correctly set the FormDataElement's type based on this decoded type later in the
function.
(WebCore::FormData::encodeForBackForward): Encode m_identifier as an int64_t, since that
matches its type and how we decode it.
2011-02-02 Dan Winship <danw@gnome.org>
Reviewed by Martin Robinson.
[GTK] drop soup cache stuff, which has been moved to libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747
Use libsoup-based cache/requester API and remove the WebCore version
of this functionality. This has been pushed upstream fully.
No new tests because this should not change functionality.
* GNUmakefile.am: Update for removed files.
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal): Update
type names, drop m_requester.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ensureSessionIsInitialized): Add a SoupRequester to the
session.
(WebCore::parseDataUrl):
(WebCore::startHttp): Get the requester from the session rather
than using m_requester.
(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::readCallback):
(WebCore::startGio): Update type names.
* platform/network/soup/cache/soup-directory-input-stream.c: Removed.
* platform/network/soup/cache/soup-directory-input-stream.h: Removed.
* platform/network/soup/cache/soup-http-input-stream.c: Removed.
* platform/network/soup/cache/soup-http-input-stream.h: Removed.
* platform/network/soup/cache/soup-request-data.c: Removed.
* platform/network/soup/cache/soup-request-data.h: Removed.
* platform/network/soup/cache/soup-request-file.c: Removed.
* platform/network/soup/cache/soup-request-file.h: Removed.
* platform/network/soup/cache/soup-request-http.c: Removed.
* platform/network/soup/cache/soup-request-http.h: Removed.
* platform/network/soup/cache/soup-request.c: Removed.
* platform/network/soup/cache/soup-request.h: Removed.
* platform/network/soup/cache/soup-requester.c: Removed.
* platform/network/soup/cache/soup-requester.h: Removed.
* platform/network/soup/cache/webkit/soup-cache-private.h: Removed.
* platform/network/soup/cache/webkit/soup-cache.c: Removed.
* platform/network/soup/cache/webkit/soup-cache.h: Removed.
2011-02-02 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=53520
Remove physical accessors from IntRect and FloatRect.
* page/FrameView.cpp:
(WebCore::FrameView::adjustPageHeightDeprecated):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.h:
2011-02-02 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=53614
Remove physical terminology from overflow. Replace with minX/maxX/minY/maxY.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::minYLayoutOverflow):
(WebCore::InlineFlowBox::maxYLayoutOverflow):
(WebCore::InlineFlowBox::minXLayoutOverflow):
(WebCore::InlineFlowBox::maxXLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::minYVisualOverflow):
(WebCore::InlineFlowBox::maxYVisualOverflow):
(WebCore::InlineFlowBox::minXVisualOverflow):
(WebCore::InlineFlowBox::maxXVisualOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalminYVisualOverflow):
(WebCore::InlineFlowBox::logicalmaxYVisualOverflow):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::minYLayoutOverflow):
(WebCore::RenderBox::maxYLayoutOverflow):
(WebCore::RenderBox::minXLayoutOverflow):
(WebCore::RenderBox::maxXLayoutOverflow):
(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::maxYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(WebCore::RenderBox::maxXVisualOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
* rendering/RenderOverflow.h:
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::minYLayoutOverflow):
(WebCore::RenderOverflow::maxYLayoutOverflow):
(WebCore::RenderOverflow::minXLayoutOverflow):
(WebCore::RenderOverflow::maxXLayoutOverflow):
(WebCore::RenderOverflow::minYVisualOverflow):
(WebCore::RenderOverflow::maxYVisualOverflow):
(WebCore::RenderOverflow::minXVisualOverflow):
(WebCore::RenderOverflow::maxXVisualOverflow):
(WebCore::RenderOverflow::setminYVisualOverflow):
(WebCore::RenderOverflow::visualOverflowRect):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::docTop):
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* features.pri:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAudioBytesDecoded):
(WebCore::HTMLMediaElement::webkitVideoBytesDecoded):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitDecodedFrames):
(WebCore::HTMLVideoElement::webkitDroppedFrames):
* html/HTMLVideoElement.h:
* html/HTMLVideoElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::decodedFrames):
(WebCore::MediaPlayer::droppedFrames):
(WebCore::MediaPlayer::audioBytesDecoded):
(WebCore::MediaPlayer::videoBytesDecoded):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::decodedFrames):
(WebCore::MediaPlayerPrivateInterface::droppedFrames):
(WebCore::MediaPlayerPrivateInterface::audioBytesDecoded):
(WebCore::MediaPlayerPrivateInterface::videoBytesDecoded):
2011-02-02 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by David Hyatt.
More conversion from right()/bottom() to maxX()/maxY().
* page/qt/FrameQt.cpp:
(WebCore::Frame::dragImageForSelection):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
2011-02-02 Kevin Ollivier <kevino@theolliviers.com>
[wx] Build fixes for wxWebKit.
* bindings/cpp/WebDOMHTMLDocumentCustom.cpp:
(documentWrite):
* bindings/scripts/CodeGeneratorCPP.pm:
* page/wx/DragControllerWx.cpp:
(WebCore::DragController::dragOperation):
* platform/graphics/wx/FontCustomPlatformData.h:
* platform/graphics/wx/FontPlatformData.h:
(WebCore::FontPlatformData::widthVariant):
* platform/graphics/wx/FontPlatformDataWx.cpp:
(WebCore::FontPlatformData::computeHash):
* platform/graphics/wx/FontWx.cpp:
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/wx/RenderThemeWx.cpp:
2011-02-02 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
More right()/bottom() to maxX()/maxY() conversion.
* page/chromium/FrameChromium.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
2011-02-02 Sam Weinig <sam@webkit.org>
Fix windows clean build.
* DerivedSources.make:
2011-02-02 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Landing detailed heap snapshots, part 2.
https://bugs.webkit.org/show_bug.cgi?id=53606
Display progress while taking a snapshot, and hints while loading
and parsing. This is needed because taking detailed heap snapshots
takes time.
* English.lproj/localizedStrings.js:
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype.getProfiles):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
* inspector/front-end/SidebarTreeElement.js:
(WebInspector.SidebarTreeElement.prototype.refreshTitles):
2011-02-02 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
More conversion from right()/bottom() to maxX()/maxY().
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
2011-02-02 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Removal of right()/bottom(). Replace with maxX() and maxY(). Still converting. Haven't removed yet.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::layout):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::drawTexturedRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::growLayerToContain):
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::overlappedTileIndices):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/skia/FloatRectSkia.cpp:
(WebCore::FloatRect::operator SkRect):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/skia/IntRectSkia.cpp:
(WebCore::IntRect::operator SkIRect):
(WebCore::IntRect::operator SkRect):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::beginLayerClippedToImage):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::clip):
* platform/graphics/win/IntRectWin.cpp:
(WebCore::IntRect::operator RECT):
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::roundRect):
(WebCore::mapRect):
(WebCore::TransparentLayerDC::TransparentLayerDC):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::strokeRect):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::invalidateRect):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintMenuListButton):
(WebCore::RenderThemeSafari::paintSliderTrack):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintInnerSpinButton):
(WebCore::RenderThemeWin::paintMenuListButton):
2011-02-02 Antti Koivisto <antti@apple.com>
Reviewed by Maciej Stachowiak.
Use Vector instead of a linked list for rules in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=53581
- eliminate CSSRuleDataList, replace with Vector<RuleData>
- rename CSSRuleData -> RuleData and CSSRuleSet -> RuleSet
(these are selector internal classes, CSS prefix is better reserved for public ones).
- constify a bit
- shrink the vectors to fit after collecting the rules
* css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::getIDRules):
(WebCore::RuleSet::getClassRules):
(WebCore::RuleSet::getTagRules):
(WebCore::RuleSet::getPseudoRules):
(WebCore::RuleSet::getUniversalRules):
(WebCore::RuleSet::getPageRules):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::operator >):
(WebCore::operator <=):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::RuleSet::collectIdsAndSiblingRules):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::addMatchedRule):
2011-02-02 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Use DIVs instead of TABLE in TextViewer
https://bugs.webkit.org/show_bug.cgi?id=53299
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype._mouseDown):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype.set mimeType):
(WebInspector.TextViewer.prototype.revealLine):
(WebInspector.TextViewer.prototype.addDecoration):
(WebInspector.TextViewer.prototype.removeDecoration):
(WebInspector.TextViewer.prototype.markAndRevealRange):
(WebInspector.TextViewer.prototype.highlightLine):
(WebInspector.TextViewer.prototype.clearLineHighlight):
(WebInspector.TextViewer.prototype.freeCachedElements):
(WebInspector.TextViewer.prototype._handleKeyDown):
(WebInspector.TextViewer.prototype.editLine.finishEditing):
(WebInspector.TextViewer.prototype.editLine):
(WebInspector.TextViewer.prototype.beginUpdates):
(WebInspector.TextViewer.prototype.endUpdates):
(WebInspector.TextViewer.prototype.resize):
(WebInspector.TextViewer.prototype._textChanged):
(WebInspector.TextViewer.prototype._updatePanelOffsets):
(WebInspector.TextViewer.prototype._syncScroll):
(WebInspector.TextViewer.prototype._syncDecorationsForLine):
(WebInspector.TextEditorChunkedPanel):
(WebInspector.TextEditorChunkedPanel.prototype.set syncScrollListener):
(WebInspector.TextEditorChunkedPanel.prototype.get textModel):
(WebInspector.TextEditorChunkedPanel.prototype.addDecoration):
(WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
(WebInspector.TextEditorChunkedPanel.prototype.revealLine):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorChunkedPanel.prototype.textChanged):
(WebInspector.TextEditorChunkedPanel.prototype.beginUpdates):
(WebInspector.TextEditorChunkedPanel.prototype.endUpdates):
(WebInspector.TextEditorChunkedPanel.prototype.resize):
(WebInspector.TextEditorChunkedPanel.prototype._scroll):
(WebInspector.TextEditorChunkedPanel.prototype._scheduleRepaintAll):
(WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
(WebInspector.TextEditorChunkedPanel.prototype._chunkForLine):
(WebInspector.TextEditorGutterPanel):
(WebInspector.TextEditorGutterPanel.prototype.freeCachedElements):
(WebInspector.TextEditorGutterPanel.prototype._createNewChunk):
(WebInspector.TextEditorGutterPanel.prototype._expandChunks):
(WebInspector.TextEditorGutterChunk):
(WebInspector.TextEditorGutterChunk.prototype.get expanded):
(WebInspector.TextEditorGutterChunk.prototype.set expanded):
(WebInspector.TextEditorGutterChunk.prototype.get height):
(WebInspector.TextEditorGutterChunk.prototype._createRow):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.set syncDecorationsForLine):
(WebInspector.TextEditorMainPanel.prototype.set mimeType):
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype.highlightLine):
(WebInspector.TextEditorMainPanel.prototype.clearLineHighlight):
(WebInspector.TextEditorMainPanel.prototype.freeCachedElements):
(WebInspector.TextEditorMainPanel.prototype._buildChunks):
(WebInspector.TextEditorMainPanel.prototype._createNewChunk):
(WebInspector.TextEditorMainPanel.prototype._expandChunks):
(WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._releaseLinesHighlight):
(WebInspector.TextEditorMainPanel.prototype._getSelection):
(WebInspector.TextEditorMainPanel.prototype._restoreSelection):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._positionToSelection):
(WebInspector.TextEditorMainPanel.prototype._appendTextNode):
(WebInspector.TextEditorMainPanel.prototype._handleDomUpdates):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.set expanded):
(WebInspector.TextEditorMainChunk.prototype.get height):
(WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow):
(WebInspector.TextEditorMainChunk.prototype._createRow):
(WebInspector):
* inspector/front-end/textViewer.css:
(.text-editor-lines):
(.text-editor-contents):
(.text-editor-editable):
(.webkit-line-decorations):
(.webkit-line-number):
(.webkit-execution-line.webkit-line-content):
(.diff-container .webkit-added-line.webkit-line-content):
(.diff-container .webkit-removed-line.webkit-line-content):
(.diff-container .webkit-changed-line.webkit-line-content):
(.webkit-highlighted-line.webkit-line-content):
2011-02-02 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421
Implement support for cursor updates using the same pattern as cursor
deletes: forward the calls to the IDBObjectStoreBackend::put().
The put() function's signature needs to be changed to allow for a
"cursor update mode". This makes the signature more clear anyway,
since it replaces the boolean parameter.
Test: storage/indexeddb/cursor-update.html
* storage/IDBCursor.idl:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::key):
(WebCore::IDBCursorBackendImpl::update):
* storage/IDBCursorBackendImpl.h:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
* storage/IDBObjectStoreBackendImpl.h:
* storage/IDBObjectStoreBackendInterface.h:
2011-02-02 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
Fix popup menu RTL bug introduced by Changeset 75982.
https://bugs.webkit.org/show_bug.cgi?id=53567
PopupMenuChromium::layout() calculates X position according to RTL or not. So Change the X position calculation in layoutAndCalculateWidgetRect().
No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect): Fix calculation of x position, because layout() considers RTL. And change the parameter from both X and Y positions to only Y position.
(WebCore::PopupContainer::showPopup): Change the passing parameter.
(WebCore::PopupContainer::refresh): Change the passing parameter.
* platform/chromium/PopupMenuChromium.h: Change the parameter declaration.
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix dist compilation
https://bugs.webkit.org/show_bug.cgi?id=53579
* GNUmakefile.am: Added FontWidthVariant.h to the sources, it was
added in r77153.
2011-02-02 Dai Mikurube <dmikurube@google.com>
Reviewed by David Levin.
Make mime type lookup in File::create(path) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=47700
This patch introduces a new function MIMETypeRegistry::getMIMETypeForExtensionThreadSafe().
The function is to be called as a thread-safe version of getMIMETypeForExtension() when
both FILE_SYSTEM and WORKERS are enabled.
No tests for this patch. This patch itself doesn't change the behaviors.
For Chromium, it runs in the same way with getMIMETypeForExtensionThreadSafe().
For the other platforms, it causes compilation error in case of enabled FILE_SYSTEM and WORKERS.
The compilation error would be a signal to implement getMIMETypeForExtensionThreadSafe() in these
platforms. Currently it doesn't happen since FILE_SYSTEM is not available in the other platforms.
* platform/MIMETypeRegistry.cpp: Defined generic getMIMETypeForExtension() calling getMIMETypeForExtensionThreadSafe() for enabled FILE_SYSTEM and WORKERS.
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/MIMETypeRegistry.h: Declared getMIMETypeForExtensionThreadSafe() which should be implemented for each platform.
* platform/android/TemporaryLinkStubs.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/brew/MIMETypeRegistryBrew.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/chromium/MIMETypeRegistryChromium.cpp: Defined getMIMETypeForExtensionThreadSafe() for the case when FILE_SYSTEM and WORKERS are enabled.
(WebCore::MIMETypeRegistry::getMIMETypeForExtensionThreadSafe):
* platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/gtk/MIMETypeRegistryGtk.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/haiku/MIMETypeRegistryHaiku.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/mac/MIMETypeRegistryMac.mm:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/qt/MIMETypeRegistryQt.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/win/MIMETypeRegistryWin.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/wince/MIMETypeRegistryWinCE.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/wx/MimeTypeRegistryWx.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
2011-02-01 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Improve readability of updateWidget by converting bool parameter to an enum
https://bugs.webkit.org/show_bug.cgi?id=53576
As requested on webkit-dev.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
* html/HTMLEmbedElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateWidget):
* html/HTMLMediaElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
* html/HTMLObjectElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
* html/HTMLPlugInImageElement.h:
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
2011-02-01 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566
A recursion limit of 22 is necessary to pass fast/dom/Document/document-write-recursion.html.
Other than being large enough for this one test case, this limit is arbitrary.
* bindings/v8/V8Proxy.h:
2011-02-01 Adam Barth <abarth@webkit.org>
Reviewed by Andreas Kling.
Remove useless comment
https://bugs.webkit.org/show_bug.cgi?id=53549
The reason for this parameter is captured in
plugins/netscape-plugin-setwindow-size.html, which is a better place to
capture it than in this comment (which otherwise just re-iterates the
name of the parameter).
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
2011-02-01 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[WebTiming] Remove asserts that verify timestamp order
https://bugs.webkit.org/show_bug.cgi?id=53548
Covered by existing tests.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): Remove assert.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchTimedEvent): Ditto.
2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
Add the 'default_targets' enclosure to the flags.
* WebCore.gyp/WebCore.gyp: Did it.
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).
Test: fast/events/scroll-event-during-modal-dialog.html
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/EventQueue.cpp:
(WebCore::EventQueueTimer::EventQueueTimer):
(WebCore::EventQueueTimer::fired):
(WebCore::EventQueue::EventQueue):
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::pendingEventTimerFired):
* dom/EventQueue.h:
(WebCore::EventQueue::create):
* page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::SuspendableTimer):
(WebCore::SuspendableTimer::suspend):
(WebCore::SuspendableTimer::resume):
* page/SuspendableTimer.h:
2011-02-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Change wrong PLATFORM(WIN) to USE(WININET)
https://bugs.webkit.org/show_bug.cgi?id=53547
* platform/network/ResourceHandle.h:
2011-02-01 Beth Dakin <bdakin@apple.com>
32-bit build fix.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
2011-01-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057
Instead of creating synchronous ResourceHandles manually, use the ::create factory.
This ensures that ::start() is not called when there is a scheduled failure and also
reduces code duplication.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously): Use the ::create factory method.
2011-02-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] GObject DOM bindings do no support the CallWith attribute
https://bugs.webkit.org/show_bug.cgi?id=53331
Disable building GObject DOM bindings for IndexedDB because we do not support
the CallWith attribute at this time.
* bindings/gobject/GNUmakefile.am: Disable building bindings for the IndexedDB API.
2011-02-01 Darin Adler <darin@apple.com>
Reviewed by Brady Eidson.
Fix a couple loose ends from the back/forward tree encode/decode work
https://bugs.webkit.org/show_bug.cgi?id=53537
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode): Remove extra copy of
original URL string; no need to encode it twice.
(WebCore::HistoryItem::decodeBackForwardTree): Ditto.
* history/HistoryItem.h: Removed declaration for function that is no
longer defined nor used.
2011-02-01 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] disable arm uninitialized variable warnings
https://bugs.webkit.org/show_bug.cgi?id=53553
We just got another error:
third_party/WebKit/Source/WebCore/css/CSSPrimitiveValue.cpp:123:error:
'colorTransparent.unstatic.4879' may be used uninitialized in this
function
* WebCore.gyp/WebCore.gyp:
2011-02-01 chris reiss <christopher.reiss@nokia.com>
Reviewed by Adam Barth.
Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123
Here we are replicating the Firefox safeguard against
recursive document.write( ) 's.
See https://bug197052.bugzilla.mozilla.org/attachment.cgi?id=293907 in bug
https://bugzilla.mozilla.org/show_bug.cgi?id=197052 . Firefox does two things -
a) imposes a recursion limit of 20 on document.write( ) and
b) once that limit is passed, panics all the way the call stack (rather than just returning one level.)
To see why this is necessary, consider the script :
<script>
var t = document.body.innerHTML;
document.write(t);
</script>
This will create a tree both broad and deep as the script keeps appending itself to the text. If
we just return one level after the recursion limit is reached, we still allow millions of copies to
duplicate (and execute).
The recursion is fortunately depth-first, so as soon as we cross this limit, we panic up the callstack
to prevent this situation. (IE apparently does the same thing, with a lower recursion limit.)
Test: fast/dom/Document/document-write-recursion.html
Test: fast/dom/Document/document-close-iframe-load.html
Test: fast/dom/Document/document-close-nested-iframe-load.html
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::write):
* dom/Document.h:
2011-02-01 Johnny Ding <jnd@chromium.org>
Reviewed by Darin Adler.
Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424
Test: fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html
* html/HTMLAnchorElement.cpp:
(WebCore::handleLinkClick):
2011-02-01 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed Qt buildfix after r77286.
https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
2011-02-01 Sam Weinig <sam@webkit.org>
Fix Mac production builds.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollbarThemeMac.h:
2011-02-01 Darin Adler <darin@apple.com>
Reviewed by Chris Fleizach.
REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169
Test: fast/images/imagemap-scroll.html
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::setFocus): Added override. Calls the new
RenderImage::areaElementFocusChanged function.
(WebCore::HTMLAreaElement::updateFocusAppearance): Removed the code
here that calls setNeedsLayout on the image's renderer. This was an
attempt to cause repaint of the renderer, but this function does not
need to do that. Also changed this to use the imageElement function
to avoid repeating code.
* html/HTMLAreaElement.h: Updated for above changes.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paint): Updated for name change.
(WebCore::RenderImage::paintAreaElementFocusRing): Renamed this from
paintFocusRing, because it only paints area focus rings, and should
not be confused with paintFocusRing functions in other classes. Also
removed the unused style argument. Removed the code that used an
HTMLCollection to see if the focused area element is for this image
and instead just call imageElement on the area element.
(WebCore::RenderImage::areaElementFocusChanged): Added. Calls repaint.
* rendering/RenderImage.h: Added a public areaElementFocusChanged
function for HTMLAreaElement to call. Made the paintFocusRing function
private, renamed it to paintAreaElementFocusRing, and removed its
unused style argument.
2011-02-01 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r77286.
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::TransparentLayerDC::TransparentLayerDC):
2011-02-01 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: AXPosition of AXScrollArea is wrong
https://bugs.webkit.org/show_bug.cgi?id=53511
AccessibilityScrollView needed to return a valid documentFrameView() object.
At the same time, the code from document() should be consolidated in
AccessibilityObject, so all objects can use it.
Test: platform/mac/accessibility/webkit-scrollarea-position.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::document):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::documentFrameView):
* accessibility/AccessibilityScrollView.h:
2011-02-01 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
getUniform should support SAMPLER_2D or SAMPLER_CUBE
https://bugs.webkit.org/show_bug.cgi?id=52190
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniform):
2011-02-01 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Adler.
Fix the incorrect usage of RetainPtr cases in GraphicsContext3DCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53531
With this fix, running WebGL conformance tests should no longer crash randomly.
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
One more Chromium build fix after r77286.
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint): Changed to not use topLeft().
2011-02-01 Sam Weinig <sam@webkit.org>
Fix the build for Beth.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
2011-02-01 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Part 2 for <rdar://problem/8492788>
Adopt WKScrollbarPainterController
Use header detection to define scrollbar painting controller #define.
* WebCore.exp.in:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2011-02-01 David Hyatt <hyatt@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.
Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
we need to update our terminology to be more accurate.
I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
even for flipped rectangles.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
* dom/ClientRect.h:
(WebCore::ClientRect::right):
(WebCore::ClientRect::bottom):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::convertLogicalToDevice):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::normalizeRect):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::drawElementTitle):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
* page/DragController.cpp:
(WebCore::dragLocForSelectionDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
* page/PrintContext.cpp:
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::pageNumberForElement):
* page/SpatialNavigation.cpp:
(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::entryAndExitPointsForDirection):
(WebCore::virtualRectForDirection):
* page/WindowFeatures.cpp:
(WebCore::WindowFeatures::WindowFeatures):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::setFrameRect):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::splitTrack):
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
* platform/graphics/FloatQuad.h:
(WebCore::FloatQuad::FloatQuad):
* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::intersects):
(WebCore::FloatRect::contains):
(WebCore::FloatRect::intersect):
(WebCore::FloatRect::unite):
(WebCore::enclosingIntRect):
* platform/graphics/FloatRect.h:
(WebCore::FloatRect::maxX):
(WebCore::FloatRect::maxY):
(WebCore::FloatRect::contains):
* platform/graphics/IntRect.cpp:
(WebCore::IntRect::intersects):
(WebCore::IntRect::contains):
(WebCore::IntRect::intersect):
(WebCore::IntRect::unite):
* platform/graphics/IntRect.h:
(WebCore::IntRect::maxX):
(WebCore::IntRect::maxY):
(WebCore::IntRect::shiftXEdgeTo):
(WebCore::IntRect::shiftMaxXEdgeTo):
(WebCore::IntRect::shiftYEdgeTo):
(WebCore::IntRect::shiftMaxYEdgeTo):
(WebCore::IntRect::contains):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::copyImageBytes):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::mapRect):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::paint):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::centerRectVerticallyInParentInputElement):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::positionForOffset):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::bottom):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::addShadowOverflow):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::flipForWritingMode):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::getRectToExpose):
(WebCore::cornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::overflowBottom):
(WebCore::RenderLayer::overflowRight):
(WebCore::RenderLayer::paintResizer):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::paint):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderOverflow.h:
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
(WebCore::RenderOverflow::resetLayoutOverflow):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
* rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteQuads):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::paintSliderTrack):
* rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docRight):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
2011-02-01 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
Lots of new WebCoreSystemInterface functions to export.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Let the scrollAnimator know when the mouse has
moved anywhere inside the page, and when the mouse
has moved in or out of the window.
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):
Let the scrollAnimator know when the window has become
active or inactive.
* page/FocusController.cpp:
(WebCore::FocusController::setActive):
Let the scrollAnimator know when all of these things
are happening.
* page/FrameView.cpp:
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::contentsResized):
New functions called through WebKit2 that allow the
scrollAnimator to know when a live resize starts and ends.
(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):
* page/FrameView.h:
New functions on ScrollAnimator that pass information
to the WKPainterController when we're using one.
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::scrollableArea):
(WebCore::ScrollAnimator::contentAreaWillPaint):
(WebCore::ScrollAnimator::mouseEnteredContentArea):
(WebCore::ScrollAnimator::mouseExitedContentArea):
(WebCore::ScrollAnimator::mouseMovedInContentArea):
(WebCore::ScrollAnimator::willStartLiveResize):
(WebCore::ScrollAnimator::contentsResized):
(WebCore::ScrollAnimator::willEndLiveResize):
(WebCore::ScrollAnimator::contentAreaDidShow):
(WebCore::ScrollAnimator::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scrollbarPainterDelegate):
(WebCore::ScrollAnimatorMac::setPainterForPainterController):
(WebCore::ScrollAnimatorMac::removePainterFromPainterController):
(WebCore::ScrollAnimatorMac::notityPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
Let the scrollAnimator know when this is happening.
* platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
New function lets the scrollAnimator get the current
mouse position.
* platform/ScrollView.h:
(WebCore::ScrollView::currentMousePosition):
New function that returns the scrollAnimator when needed.
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollAnimator):
Keep track of if we're in a live resize using a new memeber
variable.
* platform/mac/ScrollAnimatorMac.h:
(WebCore::ScrollAnimatorMac::inLiveResize):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::view):
New delegates for the WKPainter and WKPainterController
(-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollKnobAnimation initWithScrollbarPainter:forScrollAnimator:WebCore::animateKnobAlphaTo:duration:]):
(-[ScrollKnobAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterDelegate convertRectToBacking:]):
(-[ScrollbarPainterDelegate convertRectFromBacking:]):
(-[ScrollbarPainterDelegate layer]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
Get the WKScrollbarPainterRefs to synch up with the
WKScrollbarPainterControllerRefs when appropriate
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
Implement ScrollableArea's virtual function contentsSize() for access
through the scrollAnimator.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::contentsSize):
2011-02-01 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
layoutTestController.counterValueForElementById does not return the correct value
https://bugs.webkit.org/show_bug.cgi?id=53037
Test: fast/css/counters/deep-before.html
* rendering/RenderTreeAsText.cpp:
(WebCore::counterValueForElement):
Modified to use the newly available RenderObject::beforePseudoElement()
and RenderObject::afterPseudoElement() instead of the old imperfect
algorithm to find the before and after pseudo elements.
2011-02-01 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Allow access for security origin same as this.
https://bugs.webkit.org/show_bug.cgi?id=53440
Hard to test as newly added path currently is never hit.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canAccess): allow access if this == other
2011-01-31 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Update JSObject storage for new marking API
https://bugs.webkit.org/show_bug.cgi?id=53467
Update WebCore to handle new anonymous slot behaviour.
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/scripts/CodeGeneratorJS.pm:
2011-02-01 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix a text rendering problem when enclosing block is RTL and text runs
are in different directionality.
https://bugs.webkit.org/show_bug.cgi?id=34176
The problem happens in the following example scenario (ABC represents
Hebrew characters):
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.
The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.
Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
the run's render object's ancestor (not only its parent) has already
been constructed or has something following it on the line, in which
case, create a new box for TextRun2 instead of sharing the same box with
TextRun3.
In other words, the following 2 div should render the same results
(ABC represents Hebrew characters).
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
<div dir=rtl>this is a <span>Test <span>ABC</span></span></div>
Test: fast/dom/34176.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::parentIsConstructedOrHaveNext):
(WebCore::RenderBlock::createLineBoxes):
2011-02-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Do not add a node in the document's stylesheet candidate node list if the
node is already removed from document.
https://bugs.webkit.org/show_bug.cgi?id=53441
Test: fast/css/stylesheet-candidate-nodes-crash.xhtml
* dom/Document.cpp:
(WebCore::Document::addStyleSheetCandidateNode):
2011-02-01 Dave Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
with vertical text.
Change printing functions to check writing-mode and properly swap width and height
as needed.
Fix the setScrollOrigin function so that the origin doesn't cause
scroll spasming during printing (this is only partially successful, but it's better
than it was).
Rewrite computePageRects to handle both RTL documents properly as well as vertical
text documents properly.
* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::forceLayoutForPagination):
* page/PrintContext.cpp:
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::computeAutomaticScaleFactor):
(WebCore::PrintContext::spoolPage):
(WebCore::PrintContext::spoolRect):
* page/PrintContext.h:
* page/mac/WebCoreFrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetScrollOrigin):
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
2011-02-01 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=53500
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
2011-02-01 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Landing detailed heap snapshots, part 1.
https://bugs.webkit.org/show_bug.cgi?id=53173
Adding code for accessing heap snapshot data and
performing graph calculations.
* English.lproj/localizedStrings.js:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotArraySlice): Helper class to avoid array contents copying.
(WebInspector.HeapSnapshotEdge): Wrapper for accessing graph edge properties.
(WebInspector.HeapSnapshotEdgeIterator):
(WebInspector.HeapSnapshotNode): Wrapper for accessing graph node properties.
(WebInspector.HeapSnapshotNodeIterator):
(WebInspector.HeapSnapshot): Wrapper for the heap snapshot.
(WebInspector.HeapSnapshotFilteredOrderedIterator):
(WebInspector.HeapSnapshotEdgesProvider):
(WebInspector.HeapSnapshotNodesProvider):
(WebInspector.HeapSnapshotPathFinder):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._convertSnapshot):
2011-02-01 Adam Roben <aroben@apple.com>
Fix linker warnings in Release_LTCG builds
* WebCore.vcproj/WebCore.vcproj: Exclude EventNames.cpp and EventTarget.cpp from all
configurations, since they get pulled in via DOMAllInOne.cpp.
2011-02-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
https://bugs.webkit.org/show_bug.cgi?id=53482
* English.lproj/localizedStrings.js:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
* inspector/front-end/inspector.js:
(WebInspector.resourceForURL):
(WebInspector.openLinkExternallyLabel):
2011-02-01 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Propagate parent document security origin to newly create Document XML response
https://bugs.webkit.org/show_bug.cgi?id=53444
Covered by the existing tests.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML):
2011-02-01 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rollout r77230 which caused many layout tests
crashes on Chromium Debug bots.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/EventQueue.cpp:
(WebCore::EventQueue::EventQueue):
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::pendingEventTimerFired):
* dom/EventQueue.h:
2011-02-01 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
LightElement changes does not require relayout.
https://bugs.webkit.org/show_bug.cgi?id=53232
When an attribute of a LightElement changes, it
send an update message to the lighting filters
to update its corresponding LightSource objects,
and repaint the filters.
Duplicated 'id' attributes removed from svg-filter-animation.svg.
Existing dynamic-update tests covers this feature.
5x speedup on manual-tests/svg-filter-animation.svg
* manual-tests/svg-filter-animation.svg:
* platform/graphics/filters/DistantLightSource.h:
* platform/graphics/filters/FEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::setLightingColor):
(WebCore::FEDiffuseLighting::setSurfaceScale):
(WebCore::FEDiffuseLighting::setDiffuseConstant):
(WebCore::FEDiffuseLighting::setKernelUnitLengthX):
(WebCore::FEDiffuseLighting::setKernelUnitLengthY):
* platform/graphics/filters/FEDiffuseLighting.h:
* platform/graphics/filters/LightSource.cpp:
(WebCore::PointLightSource::setX):
(WebCore::PointLightSource::setY):
(WebCore::PointLightSource::setZ):
(WebCore::SpotLightSource::setX):
(WebCore::SpotLightSource::setY):
(WebCore::SpotLightSource::setZ):
(WebCore::SpotLightSource::setPointsAtX):
(WebCore::SpotLightSource::setPointsAtY):
(WebCore::SpotLightSource::setPointsAtZ):
(WebCore::SpotLightSource::setSpecularExponent):
(WebCore::SpotLightSource::setLimitingConeAngle):
(WebCore::DistantLightSource::setAzimuth):
(WebCore::DistantLightSource::setElevation):
(WebCore::LightSource::setAzimuth):
(WebCore::LightSource::setElevation):
(WebCore::LightSource::setX):
(WebCore::LightSource::setY):
(WebCore::LightSource::setZ):
(WebCore::LightSource::setPointsAtX):
(WebCore::LightSource::setPointsAtY):
(WebCore::LightSource::setPointsAtZ):
(WebCore::LightSource::setSpecularExponent):
(WebCore::LightSource::setLimitingConeAngle):
* platform/graphics/filters/LightSource.h:
* platform/graphics/filters/PointLightSource.h:
* platform/graphics/filters/SpotLightSource.h:
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
(WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged):
(WebCore::SVGFEDiffuseLightingElement::build):
(WebCore::SVGFEDiffuseLightingElement::findLightElement):
(WebCore::SVGFEDiffuseLightingElement::findLight):
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged):
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):
* svg/SVGFilterPrimitiveStandardAttributes.h:
2011-02-01 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289
Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.
No new tests. (refactoring)
* Android.mk:
* CMakeLists.txt:
* GNUMakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::getElementById):
(WebCore::Document::getImageMap):
* dom/Document.h:
* dom/DocumentOrderedMap.cpp: Added.
(WebCore::keyMatchesId):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::DocumentOrderedMap::clear):
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
* dom/DocumentOrderedMap.h: Added.
(WebCore::DocumentOrderedMap::contains):
(WebCore::DocumentOrderedMap::containsMultiple):
* dom/DOMAllInOne.cpp:
2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] atk_text_set_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53388
Allow using text ranges across list items.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::allowsTextRanges): Add list items
to the list of accessibility objects supporting text ranges.
2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] character range extents is off when the end of a wrapped line is included
https://bugs.webkit.org/show_bug.cgi?id=53323
Fixed wrong calculation getting the range extents.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_get_range_extents): Removed '+1' since the
requested interval shouldn't include the last character.
2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Caret Offset is one off at the end of wrapped lines
https://bugs.webkit.org/show_bug.cgi?id=53300
Consider linebreaks as special cases.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(objectAndOffsetUnignored): In order to avoid getting wrong values
when around linebreaks, we need to workaround this by explicitly
avoiding those '\n' text nodes from affecting the result of
calling to TextIterator:rangeLength().
2011-02-01 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed, rolling out r77229.
http://trac.webkit.org/changeset/77229
https://bugs.webkit.org/show_bug.cgi?id=53289
revert mysterious build breakage
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/Document.cpp:
(WebCore::Document::DocumentOrderedMap::clear):
(WebCore::Document::DocumentOrderedMap::add):
(WebCore::Document::DocumentOrderedMap::remove):
(WebCore::Document::DocumentOrderedMap::get):
(WebCore::keyMatchesId):
(WebCore::Document::getElementById):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::Document::getImageMap):
* dom/Document.h:
(WebCore::Document::DocumentOrderedMap::contains):
(WebCore::Document::DocumentOrderedMap::containsMultiple):
* dom/DocumentOrderedMap.cpp: Removed.
* dom/DocumentOrderedMap.h: Removed.
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).
Test: fast/events/scroll-event-during-modal-dialog.html
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/EventQueue.cpp:
(WebCore::EventQueueTimer::EventQueueTimer):
(WebCore::EventQueueTimer::fired):
(WebCore::EventQueue::EventQueue):
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::pendingEventTimerFired):
* dom/EventQueue.h:
(WebCore::EventQueue::create):
2011-02-01 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289
Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.
No new tests. (refactoring)
* Android.mk:
* CMakeLists.txt:
* GNUMakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::getElementById):
(WebCore::Document::getImageMap):
* dom/Document.h:
* dom/DocumentOrderedMap.cpp: Added.
(WebCore::keyMatchesId):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::DocumentOrderedMap::clear):
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
* dom/DocumentOrderedMap.h: Added.
(WebCore::DocumentOrderedMap::contains):
(WebCore::DocumentOrderedMap::containsMultiple):
* dom/DOMAllInOne.cpp:
2011-02-01 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Darin Fisher.
[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
http://crbug.com/65654
No new tests, because this fix is for Chromium project and hard to test only in WebKit project.
* html/InputType.h: Insert comment for canSetSuggestedValue().
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::canSetSuggestedValue): Implemented to return always true for that all text filed inputs can be completed.
* html/TextFieldInputType.h: Declare canSetSuggestedValue().
* html/TextInputType.cpp: Delete canSetSuggestedValue() not to return true anymore.
* html/TextInputType.h: Delete canSetSuggestedValue() not to return true anymore.
2011-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dan Bernstein.
REGRESSION (r65062): Safari loops forever under WebCore::plainTextToMallocAllocatedBuffer()
https://bugs.webkit.org/show_bug.cgi?id=53272
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextBox): Pass the appropriate renderer to emitText().
2011-01-31 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=53466
Move WebKit2 to printing via API methods
* WebCore.exp.in: Export IntRect::scale().
2011-01-31 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Remove obsolete comment after r41871
https://bugs.webkit.org/show_bug.cgi?id=53406
* dom/Document.h:
2011-01-31 Simon Fraser <simon.fraser@apple.com>
Fix according to reviewer comments: can just use Color::black now.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::drawInsetShadow):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
2011-01-31 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Clean up ShadowBlur
https://bugs.webkit.org/show_bug.cgi?id=53472
Some minor ShadowBlur cleanup.
* platform/graphics/ShadowBlur.h:
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::ShadowBlur): Use m_blurRadius rather than the radius
paramter.
(WebCore::ShadowBlur::adjustBlurRadius): Renamed from adjustBlurDistance.
(WebCore::ShadowBlur::calculateLayerBoundingRect): Rename layerFloatRect to
layerRect. Make frameSize a float.
(WebCore::ShadowBlur::beginShadowLayer): This now takes a precomputed
layerRect rather than calling calculateLayerBoundingRect() to compute
it itself, since we were calling calculateLayerBoundingRect() twice.
(WebCore::ShadowBlur::drawRectShadow): Optimize to call calculateLayerBoundingRect()
only once. The shadowRect variable was unused, so two return paths could be
collapsed into one.
(WebCore::ShadowBlur::drawInsetShadow): Call calculateLayerBoundingRect() before
beginShadowLayer() now.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling): The layerRect gets passed in.
We always used alpha=1, so no need to pass that in.
(WebCore::ShadowBlur::drawRectShadowWithTiling): We always used alpha=1, so no need to
pass that in. Move shadowRect down to first use.
ShadowBlur::clipBounds() was unused.
2011-01-31 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
https://bugs.webkit.org/show_bug.cgi?id=46748
This problem disappears when we register QWebElement using qRegisterMetaType, which we now do in QtInstance.
Added a regression test to tst_QWebFrame.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::QtInstance):
2011-01-27 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Convert <progress> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50660
* Removed RenderProgress::m_valuePart, moved the shadow node
to the shadow root of HTMLProgressElement.
* Removed hard-coded pseudo ID for -webkit-progress-bar-value.
ProgressBarValueElement is defined only for overriding
shadowPseudoId().
No new tests. No behavioral change.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* html/HTMLProgressElement.cpp:
(WebCore::ProgressBarValueElement::ProgressBarValueElement):
(WebCore::ProgressBarValueElement::shadowPseudoId):
(WebCore::ProgressBarValueElement::create):
(WebCore::ProgressBarValueElement::detach):
(WebCore::HTMLProgressElement::parseMappedAttribute):
(WebCore::HTMLProgressElement::attach):
(WebCore::HTMLProgressElement::valuePart):
(WebCore::HTMLProgressElement::didElementStateChange):
(WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
* html/HTMLProgressElement.h:
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::~RenderProgress):
(WebCore::RenderProgress::updateFromElement):
(WebCore::RenderProgress::layoutParts):
(WebCore::RenderProgress::shouldHaveParts):
(WebCore::RenderProgress::valuePart):
* rendering/RenderProgress.h:
* rendering/style/RenderStyleConstants.h:
2011-01-31 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Add sanity check to help diagnose bug 52819
https://bugs.webkit.org/show_bug.cgi?id=53402
Crash early if the children of fromItem look invalid.
* loader/HistoryController.cpp:
2011-01-31 Kalle Vahlman <kalle.vahlman@movial.com>
Reviewed by Andreas Kling.
[Qt] canvas.drawImage(HTMLVideoElement) doesn't work with Qt Multimedia backend
https://bugs.webkit.org/show_bug.cgi?id=53325
Reimplement paintCurrentFrameInContext() rather than delegate the
rendering to paint() to make sure we really do get the video frame
content into the GraphicsContext, regardless of accelerated
compositing and the video scene state.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::paintCurrentFrameInContext):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
2011-01-31 Emil A Eklund <eae@chromium.org>
Reviewed by Darin Adler.
Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436
Change SelectElement::setSelectedIndex to select the first selectable
option when the select state of all options is set to false as required
by the HTML5 specification.
Test: fast/dom/HTMLSelectElement/selected-false.html
* dom/SelectElement.cpp:
(WebCore::SelectElement::setSelectedIndex):
2011-01-31 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Console source references need a left-margin
https://bugs.webkit.org/show_bug.cgi?id=53308
* inspector/front-end/inspector.css:
(.console-message-url): Added a 4px margin on the left.
2011-01-31 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Code Changes only.
It is needlessly expensive to find the generating node from an anonymous renderer of a pseudoelement.
https://bugs.webkit.org/show_bug.cgi?id=53024
No new tests. No change in functionality
* rendering/RenderObject.h:
(WebCore::RenderObject::before):
(WebCore::RenderObject::after):
(WebCore::RenderObject::generatingNode):
Added new accessors for the use of the CSS 2.1 counters code
(mainlyly)
* rendering/RenderObjectChildList.cpp:
(WebCore::beforeAfterContainer):
(WebCore::RenderObjectChildList::invalidateCounters):
(WebCore::RenderObjectChildList::before):
(WebCore::RenderObjectChildList::after):
Refactored the code to take advantage of the new accessors.
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
Changed to store the generating node in the :before and :after
renderers.
* rendering/RenderObjectChildList.h:
2011-01-31 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
Reviewed by David Hyatt.
Add background-clip to background shorthand
https://bugs.webkit.org/show_bug.cgi?id=52080
Added background-clip to background-shorthand. Also made changes to
include webkitMaskClip to the mask shorthand to keep both in sync.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
2011-01-31 Darin Adler <darin@apple.com>
Reviewed by Adele Peterson.
WKView should support scrollPageDown:, scrollPageUp:, scrollToBeg and other similar selectors
https://bugs.webkit.org/show_bug.cgi?id=53460
* editing/EditorCommand.cpp:
(WebCore::executeScrollPageBackward): Added.
(WebCore::executeScrollPageForward): Added.
(WebCore::executeScrollToBeginningOfDocument): Added.
(WebCore::executeScrollToEndOfDocument): Added.
(WebCore::createCommandMap): Added the four commands above to the map.
2011-01-31 Dan Bernstein <mitz@apple.com>
Reviewed by Adele Peterson.
Inter-ideograph justification should apply to hiragana and katakana as well
https://bugs.webkit.org/show_bug.cgi?id=53464
Changed the test for expansion opportunities from isCJKIdeograph() to isCJKIdeographOrSymbol().
* platform/graphics/Font.cpp:
(WebCore::Font::expansionOpportunityCount):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
2011-01-31 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by James Robinson.
REGRESSION(r76951): Appearance of media controls changed slightly on Qt/Chromium ports
https://bugs.webkit.org/show_bug.cgi?id=53314
Fixes media/controls-strict.html on Chromium.
* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
Added proper box-sizing to avoid differences between strict/quirks mode.
2011-01-31 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Validation message bubble shouldn't inherit text-security style
https://bugs.webkit.org/show_bug.cgi?id=53457
No new tests because the validation message feature depends on timers
and is enabled only in Chromium port.
* css/html.css:
(::-webkit-validation-bubble): Reset -webkit-text-security.
2011-01-31 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271
Reapplying this patch again.
The removal of this patch in <http://trac.webkit.org/changeset/77125>
as part of https://bugs.webkit.org/show_bug.cgi?id=53418,
removed the both the first (failing) patch (r76893) and this fixed
patch (r76969). This patch includes slight changes necessitated by
r77151.
Reapplying this patch with the change that the second ASSERT in
RootObject::removeRuntimeObject was changed to use
.uncheckedGet() instead of the failing .get(). The object in question
could be in the process of being GC'ed. The get() call will not return
such an object while the uncheckedGet() call will return the (unsafe)
object. This is the behavior we want.
Precautionary change.
Changed RootObject to use WeakGCMap instead of HashSet.
Found will looking for another issue, but can't produce a test case
that is problematic. THerefore there aren't any new tests.
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):
* bridge/runtime_root.h:
2011-01-31 Andreas Kling <kling@webkit.org>
Unbreak Qt build after r77151.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::removeCachedMethod):
(JSC::Bindings::QtInstance::markAggregate):
2011-01-31 takano takumi <takano@apple.com>
Reviewed by Dave Hyatt.
Implement text-combine rendering code
https://bugs.webkit.org/show_bug.cgi?id=50621
Test: fast/text/international/text-combine-image-test.html
* Android.mk: Added RenderCombineText.cpp/h
* CMakeLists.txt: Added RenderCombineText.cpp/h
* GNUmakefile.am: Added RenderCombineText.cpp/h
* WebCore.exp.in:
* WebCore.gypi: Added RenderCombineText.cpp/h
* WebCore.pro: Added RenderCombineText.cpp/h
* WebCore.vcproj/WebCore.vcproj: Added RenderCombineText.cpp/h
* WebCore.xcodeproj/project.pbxproj: Added RenderCombineText.cpp/h
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- Added fontDescription.widthVariant to SimpleFontData creation.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- Changed to set "Unique" flag to RenderStyle in case of TextCombine.
* dom/Text.cpp:
(WebCore::Text::createRenderer):
- Changed to create RenderCombineText in case of TextCombine.
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::platformDataFromCustomData):
- Added FontWidthVariant as an argument for FontPlatformData creation.
* loader/cache/CachedFont.h:
- Ditto.
* platform/graphics/Font.h:
(WebCore::Font::widthVariant):
- The accessor to FontWidthVariant member variable.
* platform/graphics/FontCache.cpp:
- Made cache to incorporate FontWidthVariant value.
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):
* platform/graphics/FontDescription.h:
- Add a member variable that holds a width variant - none, half-width, third-width, and quarter-width.
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::widthVariant):
(WebCore::FontDescription::setWidthVariant):
(WebCore::FontDescription::operator==):
* platform/graphics/FontWidthVariant.h: Added.
* platform/graphics/cairo/FontCustomPlatformData.h:
- Changed to carry FontWidthVariant value.
* platform/graphics/cocoa/FontPlatformData.h:
- Changed to carry FontWidthVariant value.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::widthVariant):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
- Changed to carry FontWidthVariant value.
(WebCore::FontPlatformData::operator=):
- Ditto.
(WebCore::mapFontWidthVariantToCTFeatureSelector):
- A function to map a FontWidthVariant value to a CoreText's text spacing feature selector.
(WebCore::FontPlatformData::ctFont):
- Changed to create CTFont with text spacing variant based on FontWidthVariant.
* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- Changed to carry FontWidthVariant value.
* platform/graphics/haiku/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- Changed to carry FontWidthVariant value.
* platform/graphics/haiku/FontCustomPlatformData.h:
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
- Changed to carry FontWidthVariant value.
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- Changed to carry FontWidthVariant value.
* platform/graphics/mac/FontCustomPlatformData.h:
- Ditto.
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
- Changed to skip CT path when width variant is specified.
* platform/graphics/pango/FontCustomPlatformDataPango.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- Ditto.
* platform/graphics/qt/FontCustomPlatformData.h:
- Ditto.
* platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- Ditto.
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- Ditto.
* platform/graphics/skia/FontCustomPlatformData.h:
- Ditto.
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- Ditto.
* platform/graphics/win/FontCustomPlatformData.h:
- Ditto.
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
- Ditto.
(WebCore::FontCustomPlatformData::fontPlatformData):
- Ditto.
* platform/graphics/win/FontCustomPlatformDataCairo.h:
- Ditto.
* platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- Ditto.
* platform/graphics/wince/FontCustomPlatformData.h:
- Ditto.
* platform/graphics/wx/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- Ditto.
* platform/graphics/wx/FontCustomPlatformData.h:
- Ditto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- In case of RenderCombineText, we don't rotate text even in vertical writing. Also, we render original text
instead of text returned from text().
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
- Made to call RenderCombinedText's prepareTextCombine() here.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::textWidth):
- Made to always use the render object's width() in case of TextCombine.
(WebCore::RenderBlock::findNextLineBreak):
- Made to call RenderCombinedText's prepareTextCombine() here.
* rendering/RenderCombineText.cpp: Added. A subclass of RenderText.
(WebCore::RenderCombineText::RenderCombineText):
(WebCore::RenderCombineText::styleDidChange):
- Clear the flag that indicated the font has been prepared for combining. The font will be reinitialized in
the next call of RenderBlock::findNextLineBreak().
(WebCore::RenderCombineText::setTextInternal):
- Ditto.
(WebCore::RenderCombineText::width):
- Returns 1-em width in case of font combine.
(WebCore::RenderCombineText::adjustTextOrigin):
- Adjust drawing origin point in case of font combine.
(WebCore::RenderCombineText::charactersToRender):
- Return original text instead of current text in case of font combine.
(WebCore::RenderCombineText::combineText):
- This function tries to pack passed text with; 1) the current font as is, 2) the font created
from the descriptor with half-width variant specified, 3) the font with third-width variant, 4) the font
with quarter-width variant.
- If a suitable font successfully found, replace the current font with the new font. If no appropriate font found,
we give up text-combine as the CSS spec describes.
- If a new font found, we replace the text with 0xFFFC. This is needed for a combined text block to be able to
behave like a single character against text decorations.
* rendering/RenderCombineText.h: Added.
(WebCore::RenderCombineText::isCombined):
(WebCore::RenderCombineText::combinedTextWidth):
- Returns 1-em width in case of font combine.
(WebCore::RenderCombineText::renderName):
(WebCore::toRenderCombineText):
* rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache):
- Made to call RenderCombineText's combinedTextWidth when the text is combined.
* rendering/RenderingAllInOne.cpp: Added RenderCombineText.cpp
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasTextCombine):
- Added for a quick test of TextCombine.
2011-01-31 Oliver Hunt <oliver@apple.com>
Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219
rolling r77098, r77099, r77100, r77109, and
r77111 back in, along with a few more Qt fix attempts.
* ForwardingHeaders/runtime/WriteBarrier.h: Added.
* WebCore.exp.in:
* bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::globalData):
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSDOMBinding.cpp:
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::markChildren):
(WebCore::JSDOMGlobalObject::setInjectedScript):
(WebCore::JSDOMGlobalObject::injectedScript):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
(WebCore::getDOMConstructor):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
(WebCore::DialogHandler::dialogCreated):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::markChildren):
(WebCore::JSDOMWindowShell::unwrappedObject):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::createAccelerationObject):
(WebCore::createRotationRateObject):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::markJSFunction):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::setAll):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::scopeChain):
(WebCore::JSJavaScriptCallFrame::scopeType):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::markAggregate):
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSNodeFilterCondition.h:
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::QtInstance):
(JSC::Bindings::QtInstance::removeCachedMethod):
(JSC::Bindings::QtInstance::markAggregate):
* bridge/qt/qt_instance.h:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::markChildren):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
* bridge/qt/qt_runtime.h:
* dom/Document.h:
2011-01-31 Dan Winship <danw@gnome.org>
Reviewed by Gustavo Noronha Silva.
wss (websockets ssl) support for gtk via new gio TLS support
https://bugs.webkit.org/show_bug.cgi?id=50344
Update to use GPollableOutputStream and GTlsConnection to
implement wss URLs
* platform/network/soup/SocketStreamHandle.h:
* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability):
(WebCore::writeReadyCallback):
2011-01-31 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Check the textarea node still exists in document before casting
it to HTMLTextAreaElement.
https://bugs.webkit.org/show_bug.cgi?id=53429
Test: fast/forms/textarea-node-removed-from-document-crash.html
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
2011-01-27 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
If beforeChild is wrapped in an anonymous table section, we need to
go the parent to find it and use it before adding childs to table.
https://bugs.webkit.org/show_bug.cgi?id=53276
We need to make sure that beforeChild's parent is "this" before calling
RenderBox::addChild. The previous condition in while is too restrictive
and fails to calculate the right beforeChild value when its display
style is table caption.
Test: fast/table/before-child-non-table-section-add-table-crash.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
2011-01-31 Shane Stephens <shanestephens@google.com>
Reviewed by Simon Fraser.
AffineTransform::translateRight incorrectly computes a translateLeft.
https://bugs.webkit.org/show_bug.cgi?id=52551
Removed translateRight and converted all uses to perform standard
matrix multiplication.
No new tests because patch doesn't modify functionality.
* platform/graphics/transforms/AffineTransform.cpp:
* platform/graphics/transforms/AffineTransform.h:
(WebCore::AffineTransform::translation):
* rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::localToParentTransform):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::localToRepaintContainerTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
* rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::localToParentTransform):
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
2011-01-31 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
https://bugs.webkit.org/show_bug.cgi?id=53389
Return FALSE when not able to set the caret at the specified offset.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_text_set_caret_offset): Return FALSE when the
range created is NULL and adjust offset to account for list markers.
2011-01-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: copy HAR to clipboard instead of saving blob on export.
https://bugs.webkit.org/show_bug.cgi?id=53328
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._exportAll):
(WebInspector.NetworkPanel.prototype._exportResource):
2011-01-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: speed up network panel rendering.
https://bugs.webkit.org/show_bug.cgi?id=53397
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.get scrollContainer):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.NetworkPanel.prototype._positionSummaryBar):
(WebInspector.NetworkPanel.prototype._createTable):
(WebInspector.NetworkPanel.prototype._exportResource):
(WebInspector.NetworkPanel.prototype._onScroll):
* inspector/front-end/networkPanel.css:
(.network-sidebar .data-grid.small tr.offscreen):
(.network-sidebar .data-grid tr.offscreen):
(.network-sidebar .data-grid tr.offscreen td):
2011-01-31 Peter Varga <pvarga@webkit.org>
Reviewed by Andreas Kling.
Remove wrec from WebCore
https://bugs.webkit.org/show_bug.cgi?id=53298
No new tests needed.
* Android.jscbindings.mk:
* ForwardingHeaders/wrec/WREC.h: Removed.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/copyForwardingHeaders.cmd:
2011-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76969.
http://trac.webkit.org/changeset/76969
https://bugs.webkit.org/show_bug.cgi?id=53418
"It is causing crashes in GTK+ and Leopard bots" (Requested by
alexg__ on #webkit).
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):
* bridge/runtime_root.h:
2011-01-31 Antti Koivisto <antti@apple.com>
Not reviewed.
Spelling.
* css/CSSSelectorList.h:
(WebCore::CSSSelectorList::next):
2011-01-31 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium compilation on Linux.
* platform/graphics/ShadowBlur.cpp: added PLATFORM(CHROMIUM) guard
* platform/graphics/ShadowBlur.h: added missing ColorSpace.h header include
2011-01-31 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium compilation on Mac broken by r77101.
* WebCore.gypi: add ShadowBlur.{h,cpp} to the gypi file.
2011-01-31 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Change button title from "Clear CPU profiles" to "Clear all profiles".
https://bugs.webkit.org/show_bug.cgi?id=53309
* English.lproj/localizedStrings.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
2011-01-31 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed, fix the build with current GTK+ 3.x.
* plugins/gtk/gtk2xtbin.c:
* plugins/gtk/gtk2xtbin.h:
2011-01-30 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223
Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.
Test: fast/forms/dangling-form-element-crash.html
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedIntoDocument): Added.
(WebCore::FormAssociatedElement::removedFromDocument): Ditto.
(WebCore::FormAssociatedElement::insertedIntoTree): Don't register
the element to a document.
(WebCore::FormAssociatedElement::removedFromTree): Don't unregister
the element from a document.
* html/FormAssociatedElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedIntoDocument): Added.
(WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
* html/HTMLFormControlElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedIntoDocument): Calls
FormAssociatedElement::insertedIntoDocument().
(WebCore::HTMLObjectElement::removedFromDocument): Calls
FormAssociatedElement::removedFromDocument().
2011-01-30 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219
Qt build is broken
* ForwardingHeaders/runtime/WriteBarrier.h: Removed.
* WebCore.exp.in:
* bindings/js/DOMWrapperWorld.h:
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSDOMBinding.cpp:
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::markChildren):
(WebCore::JSDOMGlobalObject::setInjectedScript):
(WebCore::JSDOMGlobalObject::injectedScript):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
(WebCore::getDOMConstructor):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
(WebCore::DialogHandler::dialogCreated):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::markChildren):
(WebCore::JSDOMWindowShell::unwrappedObject):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::createAccelerationObject):
(WebCore::createRotationRateObject):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::markJSFunction):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::setAll):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::scopeChain):
(WebCore::JSJavaScriptCallFrame::scopeType):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::markAggregate):
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSNodeFilterCondition.h:
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::QtInstance):
(JSC::Bindings::QtInstance::removeCachedMethod):
(JSC::Bindings::QtInstance::markAggregate):
* bridge/qt/qt_instance.h:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::markChildren):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
* bridge/qt/qt_runtime.h:
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
* bridge/runtime_root.h:
* dom/Document.h:
2011-01-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77107.
http://trac.webkit.org/changeset/77107
https://bugs.webkit.org/show_bug.cgi?id=53412
Caused 5 new form-related test crashes (Requested by smfr on
#webkit).
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::parseMappedAttribute):
(WebCore::HTMLProgressElement::attach):
* html/HTMLProgressElement.h:
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::~RenderProgress):
(WebCore::RenderProgress::updateFromElement):
(WebCore::RenderProgress::layoutParts):
(WebCore::RenderProgress::shouldHaveParts):
* rendering/RenderProgress.h:
* rendering/style/RenderStyleConstants.h:
2011-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Enhance ShadowBlur to render inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=51567
Use ShadowBlur for inset box-shadows with CG. It
currently lacks a tiled version, but is still much
faster than CG shadows.
Test: fast/box-shadow/inset-box-shadow-radius.html
* platform/graphics/ShadowBlur.cpp:
* platform/graphics/ShadowBlur.h: New method for inset
shadows.
(WebCore::ShadowBlur::drawInsetShadow):
* platform/graphics/GraphicsContext.cpp: #ifdef out
fillRectWithRoundedHole() for CG.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRectWithRoundedHole): If there's
a shadow with a radius > 0, use ShadowBlur.
2011-01-28 Kenneth Russell <kbr@google.com>
Reviewed by Chris Marrin.
WebGL shows PNG Textures with indexed colors too dark
https://bugs.webkit.org/show_bug.cgi?id=47477
Properly handle indexed PNG images by re-rendering them as RGBA
images before upload. Verified with this layout test and the test
cases from bugs 47477 and 53269.
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
2011-01-27 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Convert <progress> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50660
* Removed RenderProgress::m_valuePart, moved the shadow node
to the shadow root of HTMLProgressElement.
* Removed hard-coded pseudo ID for -webkit-progress-bar-value.
ProgressBarValueElement is defined only for overriding
shadowPseudoId().
No new tests. No behavioral change.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* html/HTMLProgressElement.cpp:
(WebCore::ProgressBarValueElement::ProgressBarValueElement):
(WebCore::ProgressBarValueElement::shadowPseudoId):
(WebCore::ProgressBarValueElement::create):
(WebCore::HTMLProgressElement::parseMappedAttribute):
(WebCore::HTMLProgressElement::attach):
(WebCore::HTMLProgressElement::valuePart):
(WebCore::HTMLProgressElement::didElementStateChange):
(WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
* html/HTMLProgressElement.h:
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::~RenderProgress):
(WebCore::RenderProgress::updateFromElement):
(WebCore::RenderProgress::layoutParts):
(WebCore::RenderProgress::shouldHaveParts):
(WebCore::RenderProgress::valuePart):
* rendering/RenderProgress.h:
* rendering/style/RenderStyleConstants.h:
2011-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Ariya Hidayat.
Enhance ShadowBlur to render inset box shadows; Part 1.
https://bugs.webkit.org/show_bug.cgi?id=51567
Add a new method to GraphicsContext to render a rect with a rounded hole,
for use by inset box-shadow code. Knowledge that we're rendering a rounded
hole will enable ShadowBlur to be used here in future.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRectWithRoundedHole):
* platform/graphics/GraphicsContext.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
2011-01-23 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
REGRESSION: Inset shadow with too large border radius misses rounded corner.
https://bugs.webkit.org/show_bug.cgi?id=52800
The refactoring on r76083 broke the invariant between border
IntRect and its radii because RoundedIntRect::setRect() is called
after getRoundedInnerBorderWithBorderWidths(), which enforces the
invariant. Th rounded-rect clipping code verifies the invariant,
and discard the invalid radii, that results broken paintings.
This change moved setRect() before
getRoundedInnerBorderWithBorderWidths() not to modify the valid
RoundedIntRect value.
Test: fast/box-shadow/inset-with-extraordinary-radii-and-border.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
2011-01-30 Simon Fraser <simon.fraser@apple.com>
Attempt to fix Windows build by adding ShadowBlur.cpp/h to the
vcproj.
* WebCore.vcproj/WebCore.vcproj:
2011-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
-webkit-box-shadow causes awful scroll/resize/redraw performance
https://bugs.webkit.org/show_bug.cgi?id=22102
Use ShadowBlur for CG, whe rendering shadows on rects and
rounded rects outside of canvas.
CG shadows with a radius of more than 8px do not render
correctly. We preserve this incorrect rendering by compensating
for it when rending -webkit-box-shadow. Calls that should use
this deprecated radius behavior now use setLegacyShadow().
Test: fast/box-shadow/box-shadow-transformed.html
* html/canvas/CanvasRenderingContext2D.cpp: Use setLegacyShadow()
for canvas, to indicate that it should use the deprecated radius
behavior.
(WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Ditto.
(WebCore::CanvasRenderingContext2D::setShadow): Ditto.
(WebCore::CanvasRenderingContext2D::applyShadow): Ditto.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setLegacyShadow): Set the m_state.shadowsUseLegacyRadius bit.
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState): Add a
shadowsUseLegacyRadius bit to the state.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::radiusToLegacyRadius): Map from the actual radius to one
that approximates CG behavior.
(WebCore::hasBlurredShadow): Helper that returns true if we have a shadow
with a non-zero blur radius.
(WebCore::GraphicsContext::fillRect): Use ShadowBlur if not canvas.
(WebCore::GraphicsContext::fillRoundedRect): Ditto.
(WebCore::GraphicsContext::setPlatformShadow): Comment.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow): Call setLegacyShadow()
for -webkit-box-shadow.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::calculateLayerBoundingRect): Fix some pixel crack issues
by rounding up the blur radius.
(WebCore::ShadowBlur::drawRectShadow): Ditto
(WebCore::ShadowBlur::drawRectShadowWithTiling): Ditto.
2011-01-30 Oliver Hunt <oliver@apple.com>
Try to fix Qt build (again).
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
2011-01-30 Oliver Hunt <oliver@apple.com>
Try to fix Qt build.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::QtInstance):
(JSC::Bindings::QtInstance::removeCachedMethod):
(JSC::Bindings::QtInstance::markAggregate):
* bridge/qt/qt_instance.h:
2011-01-30 Oliver Hunt <oliver@apple.com>
Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219
rolling r77006 and r77020 back in.
* ForwardingHeaders/runtime/WriteBarrier.h: Added.
* WebCore.exp.in:
* bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::globalData):
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSDOMBinding.cpp:
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::markChildren):
(WebCore::JSDOMGlobalObject::setInjectedScript):
(WebCore::JSDOMGlobalObject::injectedScript):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
(WebCore::getDOMConstructor):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
(WebCore::DialogHandler::dialogCreated):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::markChildren):
(WebCore::JSDOMWindowShell::unwrappedObject):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::createAccelerationObject):
(WebCore::createRotationRateObject):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::markJSFunction):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::setAll):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::scopeChain):
(WebCore::JSJavaScriptCallFrame::scopeType):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::markAggregate):
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSNodeFilterCondition.h:
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::markChildren):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
* bridge/qt/qt_runtime.h:
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
* bridge/runtime_root.h:
* dom/Document.h:
2011-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Make ContextShadow code cross-platform
https://bugs.webkit.org/show_bug.cgi?id=51312
Add a new class, ShadowBlur, that contains most of the
code from ContextShadow, but is fully cross-platform.
It depends on one new method, GraphicsContext::clipBounds(),
which platforms will have to implement.
Add ShadowBlur to the Mac Xcode project, but don't use it
anywhere yet.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::clipBounds):
* platform/graphics/GraphicsContext.h:
* platform/graphics/ShadowBlur.cpp: Added.
(WebCore::roundUpToMultipleOf32):
(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::getScratchBuffer):
(WebCore::ScratchBuffer::scheduleScratchBufferPurge):
(WebCore::ScratchBuffer::timerFired):
(WebCore::ScratchBuffer::clearScratchBuffer):
(WebCore::ScratchBuffer::shared):
(WebCore::ShadowBlur::ShadowBlur):
(WebCore::ShadowBlur::blurLayerImage):
(WebCore::ShadowBlur::adjustBlurDistance):
(WebCore::ShadowBlur::calculateLayerBoundingRect):
(WebCore::ShadowBlur::beginShadowLayer):
(WebCore::ShadowBlur::endShadowLayer):
(WebCore::ShadowBlur::drawRectShadow):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::clipBounds):
* platform/graphics/ShadowBlur.h: Added.
(WebCore::ShadowBlur::setShadowsIgnoreTransforms):
(WebCore::ShadowBlur::shadowsIgnoreTransforms):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipBounds):
2011-01-29 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
CSS3 gradients with em-based stops fail to repaint when font size changes
https://bugs.webkit.org/show_bug.cgi?id=51845
Mark as uncacheable gradidients whose color stops depend on font size,
and don't attempt to put these into CSSImageGeneratorValue's image cache.
This means we return a new gradient each time, which is fairly cheap, and
fixes repaint issues under changing font size.
Test: fast/repaint/gradients-em-stops-repaint.html
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::isCacheable):
* css/CSSGradientValue.h:
2011-01-29 Geoffrey Garen <ggaren@apple.com>
Undo try to fix the Qt build.
My guess didn't work.
* WebCore.pro:
2011-01-29 Geoffrey Garen <ggaren@apple.com>
Try to fix the Qt build.
* WebCore.pro: Added platform/text/CharacterNames.h.
2011-01-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357
Updated for JavaScriptCore changes.
* bindings/js/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::getHeapSize):
2011-01-29 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Fix XSSFilter crash when extracting the source for a token twice
https://bugs.webkit.org/show_bug.cgi?id=53368
Previously, it was unsafe to extract the source for the same token
twice because the HTMLSourceTracker would advance its internal
representation of the SegmentedString. This patch introduces a cache
to make calling HTMLSourceTracker::sourceForToken multiple times safe.
* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::end):
(WebCore::HTMLSourceTracker::sourceForToken):
* html/parser/HTMLSourceTracker.h:
2011-01-29 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Fix fat build for both 32-bit and 64-bit under llvm-gcc 4.2
https://bugs.webkit.org/show_bug.cgi?id=53386
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::elasticDeltaForReboundDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::roundTowardZero):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
2011-01-29 Daniel Bates <dbates@rim.com>
Reviewed by Maciej Stachowiak.
Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
https://bugs.webkit.org/show_bug.cgi?id=53382
Our file system hierarchy ensures that CMAKE_SOURCE_DIR is defined to be /Source.
So, ${CMAKE_SOURCE_DIR}/Source evaluates to the non-existent directory /Source/Source.
Therefore, we should remove such references.
* CMakeLists.txt:
2011-01-29 Sam Weinig <sam@webkit.org>
Reviewed by Jon Honeycutt.
Fix 32-bit build on the Mac.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
Use floats instead of doubles to avoid double-to-float conversion
issues.
2011-01-29 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Barth.
Use clampToInteger() functions in a few places
https://bugs.webkit.org/show_bug.cgi?id=53363
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Use clampToInteger() for z-index.
(WebCore::CSSStyleSelector::createTransformOperations): Use clampToPositiveInteger().
* platform/graphics/transforms/PerspectiveTransformOperation.cpp: Ditto.
(WebCore::PerspectiveTransformOperation::blend): Ditto.
2011-01-29 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618
* ForwardingHeaders/wtf/unicode/CharacterNames.h: Added.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityRenderObject.cpp:
* bindings/cpp/WebDOMHTMLDocumentCustom.cpp:
* bindings/js/JSHTMLDocumentCustom.cpp:
* dom/Position.cpp:
* dom/SelectElement.cpp:
* editing/CompositeEditCommand.cpp:
* editing/Editor.cpp:
* editing/HTMLInterchange.cpp:
* editing/InsertTextCommand.cpp:
* editing/MarkupAccumulator.cpp:
* editing/TextIterator.cpp:
* editing/VisibleSelection.cpp:
* editing/htmlediting.cpp:
* editing/htmlediting.h:
* editing/markup.cpp:
* html/FTPDirectoryDocument.cpp:
* html/HTMLFormControlElement.cpp:
* html/parser/HTMLTreeBuilder.cpp:
* loader/appcache/ManifestParser.cpp:
* platform/chromium/PopupMenuChromium.cpp:
* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:
* platform/graphics/GlyphPageTreeNode.cpp:
* platform/graphics/StringTruncator.cpp:
* platform/graphics/mac/ComplexTextController.cpp:
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
* platform/graphics/wince/GraphicsContextWinCE.cpp:
* platform/mac/PasteboardMac.mm:
* platform/text/TextCodecICU.cpp:
* platform/text/mac/TextCodecMac.cpp:
* platform/text/transcoder/FontTranscoder.cpp:
* rendering/RenderBlockLineLayout.cpp:
* rendering/RenderFlexibleBox.cpp:
* rendering/RenderListMarker.cpp:
* rendering/RenderText.cpp:
* rendering/RenderTextControl.cpp:
* rendering/RenderTreeAsText.cpp:
* rendering/break_lines.cpp:
* rendering/mathml/RenderMathMLOperator.h:
* websockets/WebSocketHandshake.cpp:
* wml/WMLTableElement.cpp:
2011-01-29 Dan Winship <danw@gnome.org>
Reviewed by Xan Lopez.
[GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::defaultCookieJar):
(WebCore::setCookies):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::prepareForURL):
(WebCore::restartedCallback):
(WebCore::startHttp):
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):
(WebCore::ResourceRequest::updateFromSoupMessage):
2011-01-29 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
XSSFilter should replace URLs with about:blank instead of the empty string
https://bugs.webkit.org/show_bug.cgi?id=53370
Using the empty string will make the URL complete to the current
document's URL, which isn't really what we want. Instead, we want to
use about:blank, which is safe.
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterObjectToken):
(WebCore::XSSFilter::filterEmbedToken):
2011-01-29 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
XSSFilter should pass xssAuditor/script-tag-addslashes*
https://bugs.webkit.org/show_bug.cgi?id=53365
We need to canonicalize strings to avoid being tricked by addslashes.
* html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::isNonCanonicalCharacter):
- This function is copied from the XSSAuditor (with some tweaks).
We'll eventually remove the XSSAuditor once we've got XSSFilter
working properly.
(WebCore::HTMLNames::canonicalize):
(WebCore::HTMLNames::decodeURL):
(WebCore::XSSFilter::isContainedInRequest):
2011-01-29 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
XSSFilter should pass xssAuditor/script-tag-with-source-same-host.html
and xssAuditor/script-tag-post-*
https://bugs.webkit.org/show_bug.cgi?id=53364
We're supposed to allow loading same-origin resources even if they
appear as part of the request.
Also, we're supposed to look at the POST data too. :)
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::eraseAttributeIfInjected):
(WebCore::XSSFilter::isSameOriginResource):
- Copy/paste from XSSAuditor::isSameOriginResource. We'll
eventually remove the XSSAuditor version when XSSFilter is done.
* html/parser/XSSFilter.h:
2011-01-29 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
XSSFilter should pass 16 of the xssAuditor/script-tag* tests
https://bugs.webkit.org/show_bug.cgi?id=53362
Turns out we need to replace the src attribute of script tags with
about:blank to avoid loading the main document URL as a script. Also,
move misplaced return statement that was triggering the console message
too often.
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::appendToAttributeValue):
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterScriptToken):
(WebCore::XSSFilter::eraseAttributeIfInjected):
* html/parser/XSSFilter.h:
2011-01-28 Jon Honeycutt <jhoneycutt@apple.com>
Downloads in WK2 on Windows should write resume data to bundle
https://bugs.webkit.org/show_bug.cgi?id=53282
<rdar://problem/8753077>
Reviewed by Alice Liu.
* WebCore.vcproj/WebCore.vcproj:
Added new files to project.
* platform/network/cf/DownloadBundle.h: Added.
* platform/network/win/DownloadBundleWin.cpp: Added.
(WebCore::DownloadBundle::magicNumber):
Moved from WebKit's WebDownload so that WebKit and WebKit2 can share
it.
(WebCore::DownloadBundle::fileExtension):
Ditto.
(WebCore::DownloadBundle::appendResumeData):
Ditto - but modified to return bool rather than HRESULT and to clean up
whitespace.
(WebCore::DownloadBundle::extractResumeData):
Ditto - modified to clean up whitespace.
2011-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77050.
http://trac.webkit.org/changeset/77050
https://bugs.webkit.org/show_bug.cgi?id=53371
Caused a crash in Chromium's test_shell_tests (Requested by
rniwa on #webkit).
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
* html/parser/HTMLTreeBuilder.h:
2011-01-28 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719
It's unclear exactly what the Peacekeeper benchmark is testing,
because I haven't found a way to run it myself.
However, I constructed a benchmark which shows at least one possible slow point.
The HTML5 spec talks about creating a new document for every time we use
the fragment parsing algorithm. Document() it turns out, it a huge bloated
mess, and the constructor and destructor do a huge amount of work.
To avoid constructing (or destructing) documents for each innerHTML call,
this patch adds a shared dummy document used by all innerHTML calls.
This patch brings us from 7x slower than Safari 5 on tiny-innerHTML
to only 1.5x slower than Safari 5. I'm sure there is more work to do here.
Saving a shared Document like this is error prone. Currently
DummyDocumentFactory::releaseDocument() calls removeAllChildren()
in an attempt to clear the Document's state. However it's possible
that that call is not sufficient and we'll have future bugs here.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::DummyDocumentFactory::createDummyDocument):
(WebCore::DummyDocumentFactory::releaseDocument):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
* html/parser/HTMLTreeBuilder.h:
2011-01-28 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Gesture API: Don't use current gesture status to set "forceUserGesture" parameter when calling ScriptController::executeScript.
The "forceUserGesture" parameter should be only set when you are definitely sure that the running script is from a hyper-link.
https://bugs.webkit.org/show_bug.cgi?id=53244
Test: fast/events/popup-blocked-from-iframe-src.html
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
2011-01-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Gavin Barraclough.
Add various clampToInt() methods to MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=52910
Use clampToInteger() from MathExtras.h
* css/CSSParser.cpp:
(WebCore::CSSParser::parseCounter):
2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77006 and r77020.
http://trac.webkit.org/changeset/77006
http://trac.webkit.org/changeset/77020
https://bugs.webkit.org/show_bug.cgi?id=53360
"Broke Windows tests" (Requested by rniwa on #webkit).
* ForwardingHeaders/runtime/WriteBarrier.h: Removed.
* WebCore.exp.in:
* bindings/js/DOMWrapperWorld.h:
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSDOMBinding.cpp:
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::markChildren):
(WebCore::JSDOMGlobalObject::setInjectedScript):
(WebCore::JSDOMGlobalObject::injectedScript):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
(WebCore::getDOMConstructor):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
(WebCore::DialogHandler::dialogCreated):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::markChildren):
(WebCore::JSDOMWindowShell::unwrappedObject):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::createAccelerationObject):
(WebCore::createRotationRateObject):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::markJSFunction):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::setAll):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::scopeChain):
(WebCore::JSJavaScriptCallFrame::scopeType):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::markAggregate):
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSNodeFilterCondition.h:
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::markChildren):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
* bridge/qt/qt_runtime.h:
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
* bridge/runtime_root.h:
* dom/Document.h:
2011-01-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
XSSFilter should log to the console when it blocks something
https://bugs.webkit.org/show_bug.cgi?id=53354
This patch refactors a bunch of methods in XSSFilter to return a bool
indicating whether they blocked anything. Using this bool, we decide
whether to log to the console. We're using the same log message as the
XSSAuditor, but it seems likely we can improve this message in the
future (especially by piping in the correct line number, which is now
accessible via the parser).
* html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::isNameOfInlineEventHandler):
(WebCore::XSSFilter::filterToken):
(WebCore::XSSFilter::filterTokenInitial):
(WebCore::XSSFilter::filterTokenAfterScriptStartTag):
(WebCore::XSSFilter::filterScriptToken):
(WebCore::XSSFilter::filterObjectToken):
(WebCore::XSSFilter::filterEmbedToken):
(WebCore::XSSFilter::filterAppletToken):
(WebCore::XSSFilter::filterMetaToken):
(WebCore::XSSFilter::filterBaseToken):
(WebCore::XSSFilter::eraseInlineEventHandlersIfInjected):
* html/parser/XSSFilter.h:
2011-01-28 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Wire up settings->xssAuditorEnabled to XSSFilter
https://bugs.webkit.org/show_bug.cgi?id=53345
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::XSSFilter):
(WebCore::XSSFilter::filterToken):
* html/parser/XSSFilter.h:
2011-01-28 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter about <meta> and <base> tags
https://bugs.webkit.org/show_bug.cgi?id=53339
I'm not 100% sure we need to block <meta http-equiv>, but it seems
prudent given how powerful that attribute is. We definitely need to
block injection of <base href> because that can redirect script tags
that use relative URLs.
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterToken):
(WebCore::XSSFilter::filterMetaToken):
(WebCore::XSSFilter::filterBaseToken):
* html/parser/XSSFilter.h:
2011-01-28 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter about <applet>
https://bugs.webkit.org/show_bug.cgi?id=53338
HTML5 is pretty light on information about how the <applet> tag works.
According to this site:
http://download.oracle.com/javase/1.4.2/docs/guide/misc/applet.html
The "code" and "object" attributes are the essential attributes for
determining which piece of Java to run. We might need to expand to the
codebase and archive attributes at some point, but hopefully code and
object will be sufficient.
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterToken):
(WebCore::XSSFilter::filterAppletToken):
* html/parser/XSSFilter.h:
2011-01-28 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach the XSSFilter about object and embed tags
https://bugs.webkit.org/show_bug.cgi?id=53336
For <object> and <embed>, we filter out attribute values that either
indicate which piece of media to load or which plugin to load. In a
perfect world, we'd only need to filter out the URLs of the media, but
some plug-ins (like Flash) have lots of fun places you can hide the
URL (e.g., the "movie" <param>).
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterToken):
(WebCore::XSSFilter::filterScriptToken):
(WebCore::XSSFilter::filterObjectToken):
(WebCore::XSSFilter::filterEmbedToken):
(WebCore::XSSFilter::eraseAttributeIfInjected):
* html/parser/XSSFilter.h:
2011-01-28 Oliver Hunt <oliver@apple.com>
Fix Qt build.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::markChildren):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
* bridge/qt/qt_runtime.h:
2011-01-28 Antti Koivisto <antti@apple.com>
Reviewed by Simon Fraser.
CSS styles are shared based on uninitialized property values
https://bugs.webkit.org/show_bug.cgi?id=53285
Null test.
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mappedMapsEquivalent):
2011-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219
Update WebCore to the new marking apis, correct bindings
codegen.
* ForwardingHeaders/runtime/WriteBarrier.h: Added.
* WebCore.exp.in:
* bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::globalData):
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSDOMBinding.cpp:
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::markChildren):
(WebCore::JSDOMGlobalObject::setInjectedScript):
(WebCore::JSDOMGlobalObject::injectedScript):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
(WebCore::getDOMConstructor):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
(WebCore::DialogHandler::dialogCreated):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::markChildren):
(WebCore::JSDOMWindowShell::unwrappedObject):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::markJSFunction):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::setAll):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::scopeChain):
(WebCore::JSJavaScriptCallFrame::scopeType):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::markAggregate):
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSNodeFilterCondition.h:
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Document.h:
2011-01-28 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Keyboard scrolling doesn’t work in WebKit2
<rdar://problem/8909672>
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
Add additional necessary delegate methods.
2011-01-29 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Re-land this patch with the missing null check that caused crashes in layout tests.
Changing cursor style has no effect until the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=14344
rdar://problem/7563712
No tests added because we don't have infrastructure for testing actual cursor
changes (as opposed to cursor style computation) at this time. We might add it later.
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon): Added.
* page/EventHandler.h: Ditto.
* rendering/RenderObject.cpp:
(WebCore::areNonIdenticalCursorListsEqual): Added.
(WebCore::areCursorsEqual): Added.
(WebCore::RenderObject::styleDidChange): Call dispatchFakeMouseMoveEventSoon if
cursor styles changed.
2011-01-28 Justin Schuh <jschuh@chromium.org>
Reviewed by Eric Seidel.
We should hold RefPtrs to SVG font faces
https://bugs.webkit.org/show_bug.cgi?id=53270
Test: svg/custom/use-multiple-on-nested-disallowed-font.html
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSFontFaceSource.h:
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::associatedFontElement):
* svg/SVGFontFaceElement.h:
2011-01-28 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
uniformN*v should generate INVALID_VALUE of the array size is not a multiple of N
https://bugs.webkit.org/show_bug.cgi?id=53306
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
2011-01-28 Tom Sepez <tsepez@chromium.org>
Reviewed by Eric Seidel.
NULL pointer crash in TextIterator::handleTextBox()
https://bugs.webkit.org/show_bug.cgi?id=53267
Test: fast/css/rtl-nth-child-first-letter-crash.html
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextBox):
2011-01-28 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Remove a spurious diagnostic CRASH check.
https://bugs.webkit.org/show_bug.cgi?id=52379
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::invalidateRect):
2011-01-28 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/4761512> <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785
Changed <select> pop-up menus on Mac OS X Snow Leopard and later to have their items aligned in the
direction corresponding to the writing direction of the <select> element, with the checkmarks
on the "start" side, and use the <option>'s writing direction rather than "natural". Made the
pop-up button match the menu by adding a Chrome boolean function, selectItemAlignmentFollowsMenuWritingDirection(),
which returns true for this pop-up behavior.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
* manual-tests/pop-up-alignment-and-direction.html: Added.
* page/Chrome.cpp:
(WebCore::Chrome::selectItemAlignmentFollowsMenuWritingDirection): Added. Calls through to the
client.
* page/Chrome.h:
* page/ChromeClient.h:
* platform/PopupMenuStyle.h:
(WebCore::PopupMenuStyle::PopupMenuStyle): Added hasTextDirectionOverride parameter and member
variable initialization.
(WebCore::PopupMenuStyle::hasTextDirectionOverride): Added this accessor.
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate): Set the pop-up's layout direction and items' text alignment
to match the menu's writing direction. Set items' writing direction and direction override
according to their styles.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList): Removed unncesaary initialization of a smart pointer.
(WebCore::RenderMenuList::adjustInnerStyle): If the alignment of items in the menu follows the
menu's writing direction, use that alignment for the button as well. Also in this mode, use the
item's writing direction and override setting.
(WebCore::RenderMenuList::setTextFromOption): Store the option element's style.
(WebCore::RenderMenuList::itemStyle): Pass the text direction override value.
(WebCore::RenderMenuList::menuStyle): Ditto. Also use the button's direction, not the inner text's.
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::menuStyle): Pass the text direction override value.
2011-01-28 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Teach XSSFilter how to filter <script> elements
https://bugs.webkit.org/show_bug.cgi?id=53279
This patch adds the ability for the XSSFilter to block injected
<script> elements. Handling script elements is slightly subtle because
these elements act very differently depending on whether they have a
src attribute.
In the "src case", which check whether the src attribute was present in
the request. In the "non-src case", we check whether the start tag and
the body of the script element was included in the request. Checking
for the whole start tag means we miss out on some attribute splitting
attacks inside of script tags, but that doesn't seem like that big a
deal.
This patch also introduces some amount of state into the XSSFilter
because inline script elements span multiple tokens. There's a lot of
tuning and optimization left in these cases, some of which I've noted
with FIXMEs.
To test this patch, I played around with some of the existing
XSSAuditor tests. Hopefully I'll be able to run the test suite more
systematically in the future.
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::eraseCharacters):
(WebCore::HTMLToken::eraseValueOfAttribute):
* html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::hasName):
(WebCore::HTMLNames::findAttributeWithName):
(WebCore::HTMLNames::isNameOfScriptCarryingAttribute):
(WebCore::XSSFilter::XSSFilter):
(WebCore::XSSFilter::filterToken):
(WebCore::XSSFilter::filterTokenAfterScriptStartTag):
(WebCore::XSSFilter::filterScriptToken):
(WebCore::XSSFilter::snippetForRange):
(WebCore::XSSFilter::snippetForAttribute):
* html/parser/XSSFilter.h:
2011-01-28 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Sketch out new XSS filter design (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=53205
This patch adds a basic sketch of the new XSS filter design. Rather
than watching scripts as they execute, in this design, we watch tokens
emitted by the tokenizer. We then map the tokens directly back into
input characters, which lets us skip all the complicated logic related
to HTML entities and double-decoding of JavaScript URLs.
This patch contains only the bare essentially machinery. I'll add more
in future patches and eventually remove the previous code once this
code is up and running correctly.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::sourceForToken):
* html/parser/HTMLDocumentParser.h:
* html/parser/XSSFilter.cpp: Added.
* html/parser/XSSFilter.h: Added.
2011-01-28 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271
Reapplying this patch with the change that the second ASSERT in
RootObject::removeRuntimeObject was changed to use
.uncheckedGet() instead of the failing .get(). The object in question
could be in the process of being GC'ed. The get() call will not return
such an object while the uncheckedGet() call will return the (unsafe)
object. This is the behavior we want.
Precautionary change.
Changed RootObject to use WeakGCMap instead of HashSet.
Found will looking for another issue, but can't produce a test case
that is problematic. THerefore there aren't any new tests.
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):
* bridge/runtime_root.h:
2011-01-28 Adam Roben <aroben@apple.com>
Notify CACFLayerTreeHost when the context is flushed
LegacyCACFLayerTreeHost was keeping this a secret, which meant that WebCore's animation
timers were never starting.
Fixes <http://webkit.org/b/53302> [Windows 7 Release Tests] changesets 76853, 76856, and
76858 broke ~36 animations, compositing, and transitions tests
Reviewed by Sam Weinig.
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
(WebCore::LegacyCACFLayerTreeHost::contextDidChange): Call up to the base class after we
start our render timer.
2011-01-28 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
Remove dead code that tried to map from CSS values to parser values
https://bugs.webkit.org/show_bug.cgi?id=53318
* css/CSSFunctionValue.cpp:
* css/CSSFunctionValue.h:
* css/CSSPrimitiveValue.cpp:
* css/CSSPrimitiveValue.h:
* css/CSSValue.h:
* css/CSSValueList.cpp:
* css/CSSValueList.h:
2011-01-28 Enrica Casucci <enrica@apple.com>
Reviewed by Adam Roben.
Some drag and drop tests fail since r76824
https://bugs.webkit.org/show_bug.cgi?id=53304
There were '||' instead of '&&' in the checks for valid
clipboard content.
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
2011-01-28 Martin Robinson <mrobinson@igalia.com>
[GTK] AudioProcessingEvent.h and JSJavaScriptAudioNode.h: No such file or directory
https://bugs.webkit.org/show_bug.cgi?id=52889
Build fix for WebAudio. Include WebAudio source files on the source
list when WebAudio is enabled.
* GNUmakefile.am: Include missing source files.
2011-01-28 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Add basic rubber banding support
<rdar://problem/8219429>
https://bugs.webkit.org/show_bug.cgi?id=53277
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
Pass gesture events to the FrameView.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleGestureEvent):
* platform/ScrollAnimator.h:
Add stubbed out implementation.
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::handleGestureEvent):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::constrainsScrollingToContentEdge):
(WebCore::ScrollableArea::setConstrainsScrollingToContentEdge):
Move constrains scrolling bit to ScrollableArea from ScrollView.
(WebCore::ScrollableArea::contentsSize):
(WebCore::ScrollableArea::overhangAmount):
Add additional virtual functions for information needed by the animator.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::elasticDeltaForTimeDelta):
(WebCore::elasticDeltaForReboundDelta):
(WebCore::reboundDeltaForElasticDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::handleGestureEvent):
(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Implement basic rubber banding.
2011-01-28 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
Changing unicode-bidi doesn’t force layout
https://bugs.webkit.org/show_bug.cgi?id=53311
Test: fast/dynamic/unicode-bidi.html
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Return a layout difference if unicode-bidi values differ.
2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
Change HTMLInputElement-derived parts of media element shadow DOM to use shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53122
This is the first step in converting HTMLMediaElement to the new shadow DOM.
Should not regress any existing tests. No observable change in behavior.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId): Removed now-unnecessary hard-coded pseudo-element selectors.
(WebCore::nameToPseudoTypeMap): Ditto.
(WebCore::CSSSelector::extractPseudoType): Ditto.
* css/CSSSelector.h: Ditto.
* css/mediaControls.css: Added proper initial values, now that elements use the proper selector pipeline.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::MediaControlInputElement): Removed the switch statement,
which is now replaced with virtual shadowPseudoId on each corresponding class.
(WebCore::MediaControlInputElement::styleForElement): Changed to use element pipeline.
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Changed to set
display type in constructor.
(WebCore::MediaControlMuteButtonElement::create): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Added
to disambiguate from the MediaControlMuteButtonElement.
(WebCore::MediaControlVolumeSliderMuteButtonElement::create): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Added.
(WebCore::MediaControlSeekForwardButtonElement::create): Added.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Added.
(WebCore::MediaControlSeekBackButtonElement::create): Added.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Added.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlTimelineElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Added.
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Added.
* rendering/MediaControlElements.h:
(WebCore::MediaControlSeekForwardButtonElement::isForwardButton): Added.
(WebCore::MediaControlSeekBackButtonElement::isForwardButton): Added.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::createMuteButton): Changed to use new constructor.
(WebCore::RenderMedia::createSeekBackButton): Ditto.
(WebCore::RenderMedia::createSeekForwardButton): Ditto.
(WebCore::RenderMedia::createVolumeSliderMuteButton): Ditto.
* rendering/style/RenderStyleConstants.h: Removed constants that are no longer used.
2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Split MediaControls out of RenderMedia.
https://bugs.webkit.org/show_bug.cgi?id=53252
Near-mechanical moving of stuff, no change in behavior, thus no new tests.
* Android.mk: Added MediaControls to build system.
* CMakeLists.txt: Ditto.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::defaultEventHandler): Changed to forward events to MediaControls.
* html/shadow/MediaControls.cpp: Copied all controls-related methods from
Source/WebCore/rendering/RenderMedia.cpp, pulled them into their own class called MediaControls.
* html/shadow/MediaControls.h: Ditto from Source/WebCore/rendering/RenderMedia.h.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::defaultEventHandler): Changed to use MediaControls.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::RenderMedia): Moved relevant constructor initializers out to MediaControls.
(WebCore::RenderMedia::destroy): Changed to use MediaControls.
(WebCore::RenderMedia::styleDidChange): Ditto.
(WebCore::RenderMedia::layout): Ditto.
(WebCore::RenderMedia::updateFromElement): Ditto.
* rendering/RenderMedia.h: Updated defs accordingly and removed player() accessor, which
is only used by sub-class RenderVideo.
(WebCore::RenderMedia::controls): Added.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::~RenderVideo): Changed to access MediaPlayer* directly from mediaElement().
(WebCore::RenderVideo::calculateIntrinsicSize): Ditto.
(WebCore::RenderVideo::paintReplaced): Ditto.
(WebCore::RenderVideo::updatePlayer): Ditto.
(WebCore::RenderVideo::supportsAcceleratedRendering): Ditto.
(WebCore::RenderVideo::acceleratedRenderingStateChanged): Ditto.
2011-01-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: allow remote debugging with front-end
served from the cloud.
https://bugs.webkit.org/show_bug.cgi?id=53303
* inspector/front-end/inspector.js:
2011-01-28 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
Setting value of m_PressedPos to make scrolling smooth
Page scroll popup menu "Scroll here" option not working when cliking above scroll slider/handler.
https://bugs.webkit.org/show_bug.cgi?id=51349
The value of m_PressedPos was getting set before moveThumb() call
in all other scenarios except when "Scroll Here" option is used.
Hence scrolling with this option was not as expected even in cases
where scrolling was happening. The thumb would move in unexpected
direction. m_PressedPos is now set to pressed position so delta is
calculated.
Unable to write a test case as the test needs to click on "Scroll
Here" option of context sensitive menu and QTest is unable to do it.
Besides no new functionality introduced.
* platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::contextMenu):
2011-01-28 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] add JSON schema for extensions API
https://bugs.webkit.org/show_bug.cgi?id=53236
* inspector/front-end/ExtensionAPISchema.json: Added.
2011-01-27 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Remove _LENGTH enumerants
https://bugs.webkit.org/show_bug.cgi?id=53259
* html/canvas/WebGLRenderingContext.cpp: Remove queries for *LENGTH.
(WebCore::WebGLRenderingContext::getProgramParameter):
(WebCore::WebGLRenderingContext::getShaderParameter):
* html/canvas/WebGLRenderingContext.idl: Remove *LENGTH.
2011-01-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: syntax highlight inline JS and CSS in HTML resources
https://bugs.webkit.org/show_bug.cgi?id=30831
* inspector/front-end/SourceHTMLTokenizer.js:
(WebInspector.SourceHTMLTokenizer):
(WebInspector.SourceHTMLTokenizer.prototype.set line):
(WebInspector.SourceHTMLTokenizer.prototype.nextToken):
* inspector/front-end/SourceHTMLTokenizer.re2js:
2011-01-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [STYLES] Up/Down-suggestion breaks an existing keyword
https://bugs.webkit.org/show_bug.cgi?id=53295
Select the current word suffix before switching to the next suggestion.
* inspector/front-end/StylesSidebarPane.js:
():
2011-01-28 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix dist compilation for the release
https://bugs.webkit.org/show_bug.cgi?id=53290
* GNUmakefile.am: Added inspector files to the extra dist.
2011-01-28 Ilya Sherman <isherman@chromium.org>
Reviewed by Andreas Kling.
Const-correct HTMLSelectElement and WebSelectElement
https://bugs.webkit.org/show_bug.cgi?id=53293
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::value): const.
* html/HTMLSelectElement.h:
2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76893.
http://trac.webkit.org/changeset/76893
https://bugs.webkit.org/show_bug.cgi?id=53287
It made some tests crash on GTK and Qt debug bots (Requested
by Ossy on #webkit).
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):
* bridge/runtime_root.h:
2011-01-27 Greg Coletta <greg.coletta@nokia.com>
Reviewed by Laszlo Gombos.
Get rid of prefix header dependency for WebKit2 build system
https://bugs.webkit.org/show_bug.cgi?id=50174
Guard EmptyProtocalDefinitions.h to make sure it's not included twice.
* platform/mac/EmptyProtocolDefinitions.h:
2011-01-27 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Recalc table sections if needed before calculating the first line
box baseline.
https://bugs.webkit.org/show_bug.cgi?id=53265
When we try to calculate the baseline position of a table cell,
we recurse through all the child sibling boxes (when children are
non inline) and add their first linebox baseline values. If one of
the children is a table with pending section recalc, we will access
wrong table section values. We recalc table sections if it is needed.
Test: fast/table/recalc-section-first-body-crash-main.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::firstLineBoxBaseline):
2011-01-27 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Add CRASH calls to further debug tiled compositor memcpy crash.
https://bugs.webkit.org/show_bug.cgi?id=52379
Test: LayoutTests/compositing (to verify these weren't triggered)
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::update):
2011-01-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact
https://bugs.webkit.org/show_bug.cgi?id=53242
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76891.
http://trac.webkit.org/changeset/76891
https://bugs.webkit.org/show_bug.cgi?id=53280
Makes every layout test crash (Requested by othermaciej on
#webkit).
* page/EventHandler.cpp:
* page/EventHandler.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange):
2011-01-27 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed, rolling out r76839.
http://trac.webkit.org/changeset/76839
https://bugs.webkit.org/show_bug.cgi?id=49744
broke pixel tests
* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
2011-01-27 Emil A Eklund <eae@chromium.org>
Reviewed by Darin Adler.
contentEditable formatBlock crashes on divs with contenteditable="false"
https://bugs.webkit.org/show_bug.cgi?id=53263
Check if editableRootForPosition returns null for position.
Test: editing/execCommand/format-block-contenteditable-false.html
* editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::formatRange):
2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Remove RenderMedia members that aren't used.
https://bugs.webkit.org/show_bug.cgi?id=53245
Refactoring, no change in behavior, so no new tests.
* rendering/RenderMedia.h: Removed unused member variables.
2011-01-27 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271
Precautionary change.
Changed RootObject to use WeakGCMap instead of HashSet.
Found will looking for another issue, but can't produce a test case
that is problematic. THerefore there aren't any new tests.
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):
* bridge/runtime_root.h:
2011-01-27 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Rename Typed Array slice() to subset()
https://bugs.webkit.org/show_bug.cgi?id=53273
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::constructArrayBufferView):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
* html/canvas/Float32Array.cpp:
(WebCore::Float32Array::subset):
* html/canvas/Float32Array.h:
* html/canvas/Float32Array.idl:
* html/canvas/Int16Array.cpp:
(WebCore::Int16Array::subset):
* html/canvas/Int16Array.h:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.cpp:
(WebCore::Int32Array::subset):
* html/canvas/Int32Array.h:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.cpp:
(WebCore::Int8Array::subset):
* html/canvas/Int8Array.h:
* html/canvas/Int8Array.idl:
* html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::subsetImpl):
* html/canvas/Uint16Array.cpp:
(WebCore::Uint16Array::subset):
* html/canvas/Uint16Array.h:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.cpp:
(WebCore::Uint32Array::subset):
* html/canvas/Uint32Array.h:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.cpp:
(WebCore::Uint8Array::subset):
* html/canvas/Uint8Array.h:
* html/canvas/Uint8Array.idl:
2011-01-27 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Changing cursor style has no effect until the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=14344
rdar://problem/7563712
No tests added because we don't have infrastructure for testing actual cursor
changes (as opposed to cursor style computation) at this time. We might add it later.
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon): Added.
* page/EventHandler.h: Ditto.
* rendering/RenderObject.cpp:
(WebCore::areNonIdenticalCursorListsEqual): Added.
(WebCore::areCursorsEqual): Added.
(WebCore::RenderObject::styleDidChange): Call dispatchFakeMouseMoveEventSoon if
cursor styles changed.
2011-01-27 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
SVG Use Cycle is not detected
https://bugs.webkit.org/show_bug.cgi?id=52544
We should check if SVGUseElement::buildInstanceTree finds problem
for every child node. If it finds problem for any children we must
return immediately because otherwise the foundProblem variable may
be rewritten to false.
Test: svg/custom/recursive-use2.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildInstanceTree):
2011-01-27 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
https://bugs.webkit.org/show_bug.cgi?id=53054
Test: fast/canvas/webgl/tex-sub-image-2d-bad-args.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::texSubImage2DBase): Check format/type match.
2011-01-27 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Andreas Kling.
[Qt] Add fullscreen media control button for html video
https://bugs.webkit.org/show_bug.cgi?id=51543
Implement media control fullscreen button for QtWebKit html5 video.
* css/mediaControlsQt.css:
(video::-webkit-media-controls-fullscreen-button):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
2011-01-27 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Remove FrameLoader::url() and update callers to use
Document::url().
https://bugs.webkit.org/show_bug.cgi?id=41165
Refactor, no new tests.
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
(WebCore::Document::removePendingSheet):
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::CachedFrameBase):
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::inspectedURL):
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForFrame):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::deprecatedFrameEncoding):
* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
(WebCore::HistoryController::updateForSameDocumentNavigation):
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::NavigationScheduler::scheduleLocationChange):
(WebCore::NavigationScheduler::scheduleRefresh):
* page/FrameView.cpp:
(WebCore::FrameView::updateControlTints):
* page/Location.cpp:
(WebCore::Location::url):
(WebCore::Location::setProtocol):
(WebCore::Location::setHost):
(WebCore::Location::setHostname):
(WebCore::Location::setPort):
(WebCore::Location::setPathname):
(WebCore::Location::setSearch):
(WebCore::Location::setHash):
(WebCore::Location::reload):
* page/Page.cpp:
(WebCore::Page::goToItem):
2011-01-27 Stephen White <senorblanco@chromium.org>
Reviewed by Darin Adler.
Fix performance regression in ImageQualityController::objectDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=52645
In r72282, I inadvertently introduced this regression by using a
linear search through the hash map on object destruction. This was
because the hash key consisted of both object pointer and layer id,
but on object destruction we only know the object pointer, requiring
a search to find all the layers.
By replacing the hash map with two nested hash maps, where the outer key
is the object and the inner key is the layer, we can find all the
relevant data for an object in one hash lookup.
* rendering/RenderBoxModelObject.cpp:
Replace the (object,layer)->size HashMap with object->layer and
layer->size HashMaps.
(WebCore::ImageQualityController::isEmpty):
Implement isEmpty() for the outer HashMap.
(WebCore::ImageQualityController::removeLayer):
When a layer is removed, remove it from the inner hash map.
(WebCore::ImageQualityController::set):
Implement set(): if the inner map exists, set the layer->size tuple
directly. If not, create a new inner map, set the tuple, and insert
it in the outer map.
(WebCore::ImageQualityController::objectDestroyed):
Look up the object in the outer map only.
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
Cosmetic changes for the renamed now-outer hash map.
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
Do both outer and inner hash map lookups. Call set() to add/update
entries to the hash maps. keyDestroyed() is now removeLayer().
(WebCore::imageQualityController):
Make the ImageQualityController a file-static global, so it can be
created and destroyed on the fly.
(WebCore::RenderBoxModelObject::~RenderBoxModelObject):
If there is no ImageQualityController, don't call objectDestroyed().
If it's empty, delete it.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
Also pass the Image* as the (void*) layer, since 0 is not a valid
HashMap key.
2011-01-27 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Tiled compositor crashes if compositing turned off mid-paint
https://bugs.webkit.org/show_bug.cgi?id=53198
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::draw):
2011-01-27 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
A corrupted counter tree is created when renderers are added to the
tree bypassing RenderObject::addChild
https://bugs.webkit.org/show_bug.cgi?id=51270
No new tests. This patch reimplements the fix for bugs 43812 and
51637 and hence all tests are already there as part of the original
fixes for those bugs.
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
Removed old workaround as this patch hopefully fixes the real
problem.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
Removed call to counter updater as it was moved to a lower level.
(WebCore::RenderObject::destroy):
Moved attached counter nodes destruction to after the node is
removed from the tree.
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Added notifications to the Counter system such that the
CounterForest reflects the changes to the RendererTree.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):
Applied the same changes as for RenderObject::destroy()
since RenderObject::destroy() is not called from here.
2011-01-27 Adam Roben <aroben@apple.com>
Add WKCACFViewLayerTreeHost
This is a class that derives from CACFLayerTreeHost and uses a WKCACFView to render.
Fixes <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost should use
WKCACFView for rendering
* WebCore.vcproj/WebCore.vcproj: Added WKCACFViewLayerTreeHost.{cpp,h}.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Make the test window have a
non-zero size. WKCACFView will always say it can't render if you pass it a 0-sized window,
so we need a non-empty window to perform a valid test.
(WebCore::CACFLayerTreeHost::create): First try to create a WKCACFViewLayerTreeHost, then
fall back to a LegacyCACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to react to the
context flush from here...
(WebCore::CACFLayerTreeHost::contextDidChange): ...to here. Derived classes are required to
call this function whenever changes are flushed to the context.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Added contextDidChange.
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
(WebCore::LegacyCACFLayerTreeHost::createRenderer):
(WebCore::LegacyCACFLayerTreeHost::resize):
Changed to use flushContext instead of flushing the context manually so that we will always
notify the base class when the context gets flushed.
(WebCore::LegacyCACFLayerTreeHost::flushContext): Added a call to contextDidChange so the
base class will know what happened. Moved code to schedule a render from here...
(WebCore::LegacyCACFLayerTreeHost::contextDidChange): ...to here.
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added contextDidChange.
* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Added.
(WebCore::WKCACFViewLayerTreeHost::create): If WebKitQuartzCoreAdditions, which provides
WKCACFView, isn't present, bail. Otherwise allocate and return a new host.
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Initialize members.
(WebCore::WKCACFViewLayerTreeHost::updateViewIfNeeded): Update the view if we previously
marked that we needed to do so, and flush the context if our layer's bounds have changed.
(WebCore::WKCACFViewLayerTreeHost::contextDidChangeCallback): Call through to
contextDidChange.
(WebCore::WKCACFViewLayerTreeHost::contextDidChange): Tell the WKCACFView to start rendering
(if we didn't already), then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::initializeContext): Set the context's user data, the
view's layer, and hook up our "context did change" callback.
(WebCore::WKCACFViewLayerTreeHost::resize): Mark that the view needs to be updated the next
time we paint.
(WebCore::WKCACFViewLayerTreeHost::createRenderer): Update our view and return whether it is
able to render or not.
(WebCore::WKCACFViewLayerTreeHost::destroyRenderer): Clear out all the info we passed down
to the view.
(WebCore::WKCACFViewLayerTreeHost::lastCommitTime): Call through to the view.
(WebCore::WKCACFViewLayerTreeHost::flushContext): Ditto.
(WebCore::WKCACFViewLayerTreeHost::paint): Update the view so it will draw at the right
size, then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::render): Invalidate the view using the passed-in dirty
rects, then ask it to draw.
* platform/graphics/ca/win/WKCACFViewLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/ca/win/LegacyCACFLayerTreeHost.h.
2011-01-27 Adam Roben <aroben@apple.com>
Move LegacyCACFLayerTreeHost into its own files
More preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost
should use WKCACFView for rendering
Reviewed by Simon Fraser.
* WebCore.vcproj/WebCore.vcproj: Added LegacyCACFLayerTreeHost.{cpp,h}.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Moved code from here to new files.
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Added.
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added.
2011-01-27 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r76824.
* platform/wince/DragDataWinCE.cpp:
(WebCore::DragData::dragDataMap):
2011-01-27 Adam Roben <aroben@apple.com>
Split CACFLayerTreeHost into base and derived classes
The derived class, LegacyCACFLayerTreeHost, contains all the D3D-related code. A later patch
will add a new derived class that replaces the D3D code with a different rendering API.
For now, LegacyCACFLayerTreeHost lives in CACFLayerTreeHost.cpp. This keeps the diff a
little smaller. A later patch will move it to its own source files.
Preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost
should use WKCACFView for rendering
Reviewed by Simon Fraser.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Clear the window before
destroying the host, as that is now the API contract that clients must fulfill.
(WebCore::LegacyCACFLayerTreeHost::create): Added. Simple creator.
(WebCore::CACFLayerTreeHost::create): Now instantiates a LegacyCACFLayerTreeHost. Calls the
new initialize function to perform initialization that has to happen after the vtable has
been set up.
(WebCore::LegacyCACFLayerTreeHost::LegacyCACFLayerTreeHost):
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost):
(WebCore::LegacyCACFLayerTreeHost::initializeContext):
(WebCore::CACFLayerTreeHost::initialize):
Moved some initialization code from the CACFLayerTreeHost constructor into these new
functions.
(WebCore::LegacyCACFLayerTreeHost::~LegacyCACFLayerTreeHost): Added. Moved code here from
~CACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::~CACFLayerTreeHost): Rather than clearing the window at this
point (which would be too late, since we won't be able to call into the derived class's
virtual functions), just assert that it has already been cleared (or was never set in the
first place).
(WebCore::LegacyCACFLayerTreeHost::createRenderer): Renamed from
CACFLayerTreeHost::createRenderer, and changed to use getters instead of accessing
CACFLayerTreeHost's data members directly.
(WebCore::LegacyCACFLayerTreeHost::destroyRenderer):
(WebCore::CACFLayerTreeHost::destroyRenderer):
Moved some code to the new LegacyCACFLayerTreeHost function.
(WebCore::LegacyCACFLayerTreeHost::resize):
(WebCore::LegacyCACFLayerTreeHost::renderTimerFired):
Moved these functions to LegacyCACFLayerTreeHost.
(WebCore::LegacyCACFLayerTreeHost::paint):
(WebCore::CACFLayerTreeHost::paint):
Moved some code to the new LegacyCACFLayerTreeHost function.
(WebCore::LegacyCACFLayerTreeHost::render):
(WebCore::LegacyCACFLayerTreeHost::renderSoon):
Moved these functions to LegacyCACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to flush the context
from here...
(WebCore::LegacyCACFLayerTreeHost::flushContext): ...to this new function.
(WebCore::LegacyCACFLayerTreeHost::lastCommitTime): Moved code to get the last commit time
to this new function...
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): ...from here.
(WebCore::LegacyCACFLayerTreeHost::initD3DGeometry):
(WebCore::LegacyCACFLayerTreeHost::resetDevice):
Moved these functions to LegacyCACFLayerTreeHost.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Made some functions virtual, removed some
members that have moved to LegacyCACFLayerTreeHost, grouped remaining members more
logically, and added some getters used by LegacyCACFLayerTreeHost.
2011-01-27 Adam Roben <aroben@apple.com>
Move CACFLayerTreeHostClient to its own header file
Rubber-stamped by Steve Falkenburg.
* WebCore.vcproj/WebCore.vcproj: Added CACFLayerTreeHostClient.h. Also let VS have its way
with the file.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Removed CACFLayerTreeHostClient.
* platform/graphics/ca/win/CACFLayerTreeHostClient.h: Added.
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: Moved some #includes here
from the header file.
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Replaced broader #includes
with more specific ones, plus a forward-declaration.
2011-01-27 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Chang.
[Chromium] Simplify small caps logic in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=53207
Test: fast/text/atsui-multiple-renderers.html
fast/text/atsui-small-caps-punctuation-size.html
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::nextScriptRun): Remove redundant logic. Case changes in a text run imply FontData changes.
(WebCore::ComplexTextController::setupFontForScriptRun): Update comment to reflect above.
2011-01-27 Adam Barth <abarth@webkit.org>
In which I attempt to fix the EFL build.
* CMakeLists.txt:
2011-01-25 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Adler.
Adding border and padding to the calculation of the local caret rect for RenderBoxes.
Corrected for mistake in r76625
Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744
Tests: editing/selection/caret-painting-after-paste-undo-rtl.html
editing/selection/caret-painting-after-paste-undo.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76825.
http://trac.webkit.org/changeset/76825
https://bugs.webkit.org/show_bug.cgi?id=53256
"caused crashes on GTK and chromium" (Requested by rniwa on
#webkit).
* rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::keyDestroyed):
(WebCore::ImageQualityController::objectDestroyed):
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
(WebCore::imageQualityController):
(WebCore::RenderBoxModelObject::~RenderBoxModelObject):
2011-01-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Generalize the mechanism view-source uses to remember the source for an HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=53200
Currently view-source tracks the source associated with each HTMLToken.
We want to re-use this mechanism for the new XSS auditor. This patch
moves this code into its own class so it can be shared between the
view-source parser and the general HTML parser. This patch also add
support for tracking the source of tokens that span document.write
boundaries.
No functional change. This code change is somewhat tested by our
view-source layout tests.
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
- Fun with updating build files.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
- Teach HTMLDocumentParser to track the source for HTMLTokens.
Currently, this information isn't used, but it will be shortly.
I ran the HTML parser benchmark and this change didn't have a
measurable effect.
* html/parser/HTMLDocumentParser.h:
- Composite in the HTMLSourceTracker.
* html/parser/HTMLSourceTracker.cpp: Added.
(WebCore::HTMLSourceTracker::HTMLSourceTracker):
(WebCore::HTMLSourceTracker::start):
(WebCore::HTMLSourceTracker::end):
- This function should eventualy be folded into HTMLTokenizer.
(WebCore::HTMLSourceTracker::sourceForToken):
* html/parser/HTMLSourceTracker.h: Added.
* html/parser/HTMLToken.h:
- Now HTMLTokens always have a start index of zero. To do the job
of the old start index, this patch introduces the notion of a
baseOffset. Unlike the start index (which was used as the base
offset for all the other indicies), the baseOffset can change
over the lifetime of the token. We need the flexibility to
change the offset for tokens that span document.write boundaries.
Values are now normalized to zero-offset when stored.
(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::setBaseOffset):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):
* html/parser/HTMLViewSourceParser.cpp:
- Updates the HTMLViewSourceParser to use the new
HTMLSourceTracker.
(WebCore::HTMLViewSourceParser::pumpTokenizer):
(WebCore::HTMLViewSourceParser::append):
(WebCore::HTMLViewSourceParser::sourceForToken):
- This function now just calls through to HTMLSourceTracker.
* html/parser/HTMLViewSourceParser.h:
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::currentColumn):
(WebCore::SegmentedString::setCurrentPosition):
* platform/text/SegmentedString.h:
(WebCore::SegmentedString::numberOfCharactersConsumed):
- We need to handle the general case now. The "slow" version
doesn't turn out to be any slower in practice anyway.
2011-01-27 Sam Weinig <sam@webkit.org>
Fix all the builds.
* platform/ScrollView.cpp:
(WebCore::ScrollView::paintOverhangAreas): Add parameters.
2011-01-27 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Add ability to do an unconstrained scroll on a ScrollView
https://bugs.webkit.org/show_bug.cgi?id=53249
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
Initialize m_constrainsScrollingToContentEdge to true.
(WebCore::ScrollView::setScrollOffset):
Only constrain the offset if the m_constrainsScrollingToContentEdge is set.
(WebCore::ScrollView::updateScrollbars):
Simplify expression converting an IntSize to an IntPoint.
(WebCore::ScrollView::paint):
Paint the overhang if there is any.
(WebCore::ScrollView::calculateOverhangAreasForPainting):
Calculate the overhang in viewport coordinates for painting.
* platform/ScrollView.h:
(WebCore::ScrollView::constrainsScrollingToContentEdge):
(WebCore::ScrollView::setConstrainsScrollingToContentEdge):
Add bit to control whether the scroll position should be constrained
to the content edge when set.
* platform/ScrollbarThemeComposite.cpp:
(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
Improve calculations of thumb size and position to take overhang into account.
2011-01-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG animation of Paths with segments of different coordinate modes on begin and end
https://bugs.webkit.org/show_bug.cgi?id=52984
At the moment we just support SVG path animations, if the number of segments on the given start path
is the same as the number of segments on the given end path. But a segment on a given position must be identical
on both paths as well. Not only the segment type, also the coordinate mode of the segments must be identical.
If MoveToRel is on the second position on the start path a MoveToRel must be on the second position
of the end path too. According to the SVG spec, at least the coordinate mode can differ. Means, if we have MoveToRel
in the start path, we can use MoveToAbs on the same position in the end path.
This patch fixes the blending code to follow the spec here. It was necessary to track the current position of
both paths, transform coordinates to the same coordinate mode and transform the resulting animation coordinate back
to the coordinate mode of either the start or the end path. Which mode is taken depends on the progress of the
animation.
Tests: svg/animations/animate-path-animation-Cc-Ss.html
svg/animations/animate-path-animation-Ll-Vv-Hh.html
svg/animations/animate-path-animation-Qq-Tt.html
svg/animations/animate-path-animation-cC-sS-inverse.html
svg/animations/animate-path-animation-lL-vV-hH-inverse.html
svg/animations/animate-path-animation-qQ-tT-inverse.html
* svg/SVGPathBlender.cpp:
(WebCore::blendFloatPoint):
(WebCore::blendAnimatedFloat):
(WebCore::SVGPathBlender::blendAnimatedDimensionalFloat):
(WebCore::SVGPathBlender::blendAnimatedFloatPoint):
(WebCore::SVGPathBlender::blendMoveToSegment):
(WebCore::SVGPathBlender::blendLineToSegment):
(WebCore::SVGPathBlender::blendLineToHorizontalSegment):
(WebCore::SVGPathBlender::blendLineToVerticalSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment):
(WebCore::SVGPathBlender::blendArcToSegment):
(WebCore::coordinateModeOfCommand):
(WebCore::isSegmentEqual):
(WebCore::SVGPathBlender::blendAnimatedPath):
(WebCore::SVGPathBlender::cleanup):
* svg/SVGPathBlender.h:
2011-01-27 Cris Neckar <cdn@chromium.org>
Reviewed by Dimitri Glazkov.
Clear the parent on a css keyframe's m_style when removing it from the stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=52320
Test: fast/css/css-keyframe-style-crash.html
* css/CSSRuleList.cpp:
(WebCore::CSSRuleList::deleteRule):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
2011-01-27 Rob Buis <rwlbuis@gmail.com>
Reviewed by Kent Tamura.
Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790
Redirect style changes on <option> element to the owner <select> element.
Test: fast/repaint/select-option-background-color.html
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setRenderStyle):
2011-01-19 Stephen White <senorblanco@chromium.org>
Reviewed by Darin Adler.
Fix performance regression in ImageQualityController::objectDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=52645
In r72282, I inadvertently introduced this regression by using a
linear search through the hash map on object destruction. This was
because the hash key consisted of both object pointer and layer id,
but on object destruction we only know the object pointer, requiring
a search to find all the layers.
By replacing the hash map with two nested hash maps, where the outer key
is the object and the inner key is the layer, we can find all the
relevant data for an object in one hash lookup.
* rendering/RenderBoxModelObject.cpp:
Replace the (object,layer)->size HashMap with object->layer and
layer->size HashMaps.
(WebCore::ImageQualityController::isEmpty):
Implement isEmpty() for the outer HashMap.
(WebCore::ImageQualityController::removeLayer):
When a layer is removed, remove it from the inner hash map.
(WebCore::ImageQualityController::set):
Implement set(): if the inner map exists, set the layer->size tuple
directly. If not, create a new inner map, set the tuple, and insert
it in the outer map.
(WebCore::ImageQualityController::objectDestroyed):
Look up the object in the outer map only.
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
Cosmetic changes for the renamed now-outer hash map.
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
Do both outer and inner hash map lookups. Call set() to add/update
entries to the hash maps. keyDestroyed() is now removeLayer().
(WebCore::imageQualityController):
Make the ImageQualityController a file-static global, so it can be
created and destroyed on the fly.
(WebCore::RenderBoxModelObject::~RenderBoxModelObject):
If there is no ImageQualityController, don't call objectDestroyed().
If it's empty, delete it.
2011-01-26 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler and Adam Roben.
WebKit2: add support for drag and drop on Windows
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>
On Windows the access to the content being dragged is
provided via the IDataObject interface that is made available
to the window that registers itself as drop target.
Since this interface cannot be accessed from the WebProcess,
in every call to one of the methods of the IDropTarget interface
we serialize the content of the drag clipboard and send it over to
the WebProcess.
The bulk of this patch consists in the refactoring needed in DragData
and ClipboardWin classes to extract the data from the serialized object.
* platform/DragData.cpp:
* platform/DragData.h:
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::getCFHTML):
(WebCore::fragmentFromFilenames):
(WebCore::containsFilenames):
(WebCore::fragmentFromHTML):
(WebCore::containsHTML):
(WebCore::getClipboardData):
* platform/win/ClipboardUtilitiesWin.h:
* platform/win/ClipboardWin.cpp:
(WebCore::Clipboard::create):
(WebCore::ClipboardWin::ClipboardWin):
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
(WebCore::ClipboardWin::hasData):
* platform/win/ClipboardWin.h:
(WebCore::ClipboardWin::create):
* platform/win/DragDataWin.cpp:
(WebCore::DragData::DragData):
(WebCore::DragData::containsURL):
(WebCore::DragData::dragDataMap):
(WebCore::DragData::asURL):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):
2011-01-27 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Space characters in source document interfere with reported caret offset
https://bugs.webkit.org/show_bug.cgi?id=53033
Calculate caret offset from rendered text instead of from node contents.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(objectAndOffsetUnignored): Calculate the caret offset based only
on positions and ranges, instead of using the computed offset in
the container node.
2011-01-26 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=53197
<rdar://problem/8895682> Make WebKit2 printing asynchronous
* WebCore.exp.in: Export more PrintContext methods that we didn't use on Mac before.
* page/PrintContext.cpp: (WebCore::PrintContext::spoolRect): Changed to make the same
transformation as spoolPages does for consistency.
2011-01-27 David Grogan <dgrogan@google.com>
Reviewed by Jeremy Orlow.
initial support for close() in indexeddb backend
https://bugs.webkit.org/show_bug.cgi?id=53150
Test: storage/indexeddb/transaction-after-close.html
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::close):
* storage/IDBDatabase.h:
* storage/IDBDatabase.idl:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::close):
2011-01-27 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG animation doesn't support calcMode discrete for number and color values.
https://bugs.webkit.org/show_bug.cgi?id=53189
Add support for calcMode discrete on number and color animation.
Tests: svg/animations/animate-color-calcMode-discrete.html
svg/animations/animate-number-calcMode-discrete.html
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
2011-01-26 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
shaderSource needs to preserve original source
https://bugs.webkit.org/show_bug.cgi?id=52833
Test: fast/canvas/webgl/gl-getshadersource.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getShaderParameter): Intercept SHADER_SOURCE_LENGTH.
(WebCore::WebGLRenderingContext::getShaderSource): Intercept the call.
(WebCore::WebGLRenderingContext::shaderSource): Cache the source.
* html/canvas/WebGLShader.cpp: Cache shader source.
(WebCore::WebGLShader::WebGLShader):
* html/canvas/WebGLShader.h: Ditto.
(WebCore::WebGLShader::getSource):
(WebCore::WebGLShader::setSource):
2011-01-27 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r76743.
* platform/graphics/wince/FontWinCE.cpp:
(WebCore::TextRunComponent::TextRunComponent):
2011-01-27 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane):
(WebInspector.ScopeChainSidebarPane.prototype.update):
2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76789.
http://trac.webkit.org/changeset/76789
https://bugs.webkit.org/show_bug.cgi?id=53238
Broke GTK layout tests (Requested by podivilov on #webkit).
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane):
(WebInspector.ScopeChainSidebarPane.prototype.update):
2011-01-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: store all settings related to the agents on the frontend side
https://bugs.webkit.org/show_bug.cgi?id=53174
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptDebugServer.cpp:
* bindings/js/ScriptDebugServer.h:
* bindings/js/ScriptProfiler.cpp:
* bindings/js/ScriptProfiler.h:
* bindings/v8/ScriptDebugServer.cpp:
* bindings/v8/ScriptDebugServer.h:
* bindings/v8/ScriptProfiler.cpp:
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored
on the front-end side and will be pushed to the backend when the frontend is loaded.
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::restoreDebugger):
(WebCore::InspectorAgent::restoreProfiler):
(WebCore::InspectorAgent::enableProfiler):
(WebCore::InspectorAgent::disableProfiler):
(WebCore::InspectorAgent::showAndEnableDebugger):
(WebCore::InspectorAgent::enableDebugger):
(WebCore::InspectorAgent::disableDebugger):
* inspector/InspectorAgent.h:
* inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only
if the front-end was opened during current browser session and XHR logging is turned on
there.
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
* inspector/InspectorSettings.cpp: Removed.
* inspector/InspectorSettings.h: Removed.
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._toggleProfiling):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.js:
2011-01-27 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane):
(WebInspector.ScopeChainSidebarPane.prototype.update):
2011-01-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Elements panel] Tooltip for relative links incorrectly identifies current URL
https://bugs.webkit.org/show_bug.cgi?id=53171
* inspector/front-end/inspector.js:
(WebInspector.completeURL): Taught to understand partial href's that start with "?" (contain GET parameters only)
2011-01-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[V8] Crash in WebCore::addMessageToConsole
https://bugs.webkit.org/show_bug.cgi?id=53227
* bindings/v8/V8Proxy.cpp: check that the Frame where the error
occured still has a page before getting a console object from it.
(WebCore::V8Proxy::reportUnsafeAccessTo):
2011-01-27 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Remove IDBCallbacks::onSuccess() used for null values.
https://bugs.webkit.org/show_bug.cgi?id=53178
Remove the IDBCallbacks::onSuccess() function that was used for
null values, and replace such calls with calls to
IDBCallBacks::onSuccess(SerializedScriptValue::nullValue())
instead.
No new functionality, so no new tests.
* storage/IDBCallbacks.h:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::updateInternal):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
* storage/IDBRequest.cpp:
* storage/IDBRequest.h:
2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76773.
http://trac.webkit.org/changeset/76773
https://bugs.webkit.org/show_bug.cgi?id=53230
breaks multiple GTK media tests (Requested by philn-tp on
#webkit).
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76770.
http://trac.webkit.org/changeset/76770
https://bugs.webkit.org/show_bug.cgi?id=53229
Some inspector tests fail (Requested by yurys on #webkit).
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
* bindings/js/ScriptDebugServer.h:
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
* bindings/js/ScriptProfiler.h:
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
* bindings/v8/ScriptDebugServer.h:
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::restoreDebugger):
(WebCore::InspectorAgent::restoreProfiler):
(WebCore::InspectorAgent::ensureSettingsLoaded):
(WebCore::InspectorAgent::enableProfiler):
(WebCore::InspectorAgent::disableProfiler):
(WebCore::InspectorAgent::showAndEnableDebugger):
(WebCore::InspectorAgent::enableDebugger):
(WebCore::InspectorAgent::disableDebugger):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::settings):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::isDebuggerAlwaysEnabled):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
* inspector/InspectorSettings.cpp: Added.
(WebCore::InspectorSettings::InspectorSettings):
(WebCore::InspectorSettings::getBoolean):
(WebCore::InspectorSettings::setBoolean):
(WebCore::InspectorSettings::getLong):
(WebCore::InspectorSettings::setLong):
(WebCore::InspectorSettings::registerBoolean):
(WebCore::InspectorSettings::registerLong):
* inspector/InspectorSettings.h: Copied from Source/WebCore/bindings/v8/ScriptProfiler.h.
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._toggleProfiling):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.js:
2011-01-26 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.
2011-01-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: store all settings related to the agents on the frontend side
https://bugs.webkit.org/show_bug.cgi?id=53174
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored
on the front-end side and will be pushed to the backend when the frontend is loaded.
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::restoreDebugger):
(WebCore::InspectorAgent::restoreProfiler):
(WebCore::InspectorAgent::enableProfiler):
(WebCore::InspectorAgent::disableProfiler):
(WebCore::InspectorAgent::showAndEnableDebugger):
(WebCore::InspectorAgent::enableDebugger):
(WebCore::InspectorAgent::disableDebugger):
* inspector/InspectorAgent.h:
* inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only
if the front-end was opened during current browser session and XHR logging is turned on
there.
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorSettings.cpp: Removed.
* inspector/InspectorSettings.h: Removed.
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._toggleProfiling):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.js:
2011-01-27 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r76743): Uneven spacing in right-to-left justified text
https://bugs.webkit.org/show_bug.cgi?id=53225
Fixes failure in fast/text/atsui-spacing-features.html
There was an inconsistency between rendering code and font code in the interpretation of
'after expansion' and 'trailing expansion'. Changed all code to interpret these in terms of
visual order rather than logical.
* platform/graphics/Font.cpp:
(WebCore::Font::expansionOpportunityCount): Added a text direction parameter and changed to
iterate in visual order accordingly.
* platform/graphics/Font.h:
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Pass the run direction to expansionOpportunityCount().
(WebCore::WidthIterator::advance): For right-to-left runs, evaluate the trailing expansion
condition with respect to the first character, which is the trailing character in visual order.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController): Pass the run direction to
expansionOpportunityCount().
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
2011-01-26 Adam Roben <aroben@apple.com>
Don't create the Direct3D device before it's first needed
We only need the device once we decide to render. There's no point in creating it before
then.
Reviewed by Sam Weinig.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::setWindow): Removed the call to createRenderer() from here.
We already have code to create it when we first try to draw.
(WebCore::CACFLayerTreeHost::createRenderer): Flush the context after we set our layer's
bounds so that the bounds will take effect the next time we render (which could be just
after this function returns).
2011-01-26 Adam Roben <aroben@apple.com>
Add assertions that CACFLayerTreeHost gains and loses an HWND only once
CACFLayerTreeHost doesn't support any other use pattern.
Reviewed by Sam Weinig.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::setWindow): Assert that we transition from not having a window,
to having a window, to not having a window just once over the lifetime of this object.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Added m_state.
2011-01-26 Adam Roben <aroben@apple.com>
Notify layers that their animations have started when we flush the context, not when we
render
r76372 separated context flushing from rendering, but this bit of code got left behind.
Reviewed by Sam Weinig.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::render): Moved code to notify the layers from here to
notifyAnimationsStarted.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added a call to
notifyAnimationsStarted after we flush the context.
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): Added. Code came from render. Changed
to call PlatformCALayer::animationStarted rather than calling through to the client
directly.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Added notifyAniamtionsStarted.
2011-01-26 Adam Roben <aroben@apple.com>
Small cleanup in MediaPlayerPrivateFullscreenWindow
Reviewed by Sam Weinig.
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::~MediaPlayerPrivateFullscreenWindow): Moved
code here from close(), since this was the only place that called it after the following
change to createWindow.
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Replaced code that handled the
case where we had already created the window with an assertion that we have not already done
so. Our single caller (FullscreenVideoController) did not require this behavior.
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Removed layerView.
2011-01-26 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Move ScrollView scroll wheel code to ScrollAnimator.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/ScrollAnimator.h:
Moved implementation of handleWheelEvent from ScrollView::wheelEvent.
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
Call down to the ScrollableArea.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::handleWheelEvent):
Call down to the ScrollAnimator.
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollPosition):
(WebCore::ScrollableArea::minimumScrollPosition):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleContentRect):
(WebCore::ScrollableArea::visibleHeight):
(WebCore::ScrollableArea::visibleWidth):
Add functions needed to implement wheel event in the animator.
2011-01-26 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
<rdar://problem/8821760>
Reviewed by Antti Koivisto.
This adds support for HTTP pipelining in CFNetwork, but does not
enable it. To enable it post-SnowLeopard, use this command:
defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
Once enabled, it is possible to force the same load priority
(high) to be sent to CFNetwork to allow WebCore to handle the
scheduling:
defaults write BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh -bool YES
* WebCore.exp.in: Export _wkGetHTTPPipeliningPriority and
_wkSetHTTPPipeliningPriority.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
Copy the priority to preflightRequest.
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad): Refactored code
at the end of the method to use an early return.
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::load): Set the priority on the
ResourceRequest object based on the priority of the
CachedResourceRequest before calling
ResourceLoadScheduler::scheduleSubresourceLoad().
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Create a ResourceRequest
object and set its priority to ResourceLoadPriorityLow before
passing it to ResourceLoadScheduler::scheduleSubresourceLoad().
* platform/mac/WebCoreSystemInterface.h:
(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.
* platform/mac/WebCoreSystemInterface.mm:
(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt): Set m_priority when
adopting a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::copyData): Set m_priority when
creating a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::priority): Added.
(WebCore::ResourceRequestBase::setPriority): Added.
(WebCore::equalIgnoringHeaderFields): Priorities must match when
comparing two ResourceRequest objects.
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase): Set default
priority of new objects to ResourceLoadPriorityLow.
(WebCore::ResourceRequestBase::priority): Added declaration.
(WebCore::ResourceRequestBase::setPriority): Added declaration.
(WebCore::isHTTPPipeliningEnabled): Added.
(WebCore::shouldUseHTTPPipeliningPriority): Added.
* platform/network/cf/ResourceRequestCFNet.cpp: Updated so that
Mac OS X and Windows share code.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Always
set the HTTP connection count per host, but return an
'unlimited' value when using HTTP pipelining. This method used
to be defined in ResourceRequestMac.mm for Mac OS X.
(WebCore::readBooleanPreference): Added. Helper method for
reading boolean user defaults.
(WebCore::isHTTPPipeliningEnabled): Returns value of user
default key WebKitEnableHTTPPipelining, or false if not set.
(WebCore::shouldUseHTTPPipeliningPriority): Returns value of
user default key WebKitForceHTTPPipeliningPriorityHigh, or false
if not set.
* platform/network/cf/ResourceRequestCFNet.h: Updated so that
Mac OS X and Windows share code. Fixed indentation.
(WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority): Added.
(WebCore::mapResourceLoadPriorityToHTTPPipeliningPriority): Added.
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest): Update
HTTP pipelining priority on NSMutableFURLRequest object.
(WebCore::ResourceRequest::doUpdateResourceRequest): Update
m_priority from the NSURLRequest object.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Removed.
Code is now shared with Windows in ResourceRequestCFNet.cpp.
2011-01-26 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
when using WKScrollbars.
New WebKitSystemInterface Functionality.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Some of the terrible static arrays are now only needed in the
old non-WK code, so they are if-def'd now.
* platform/mac/ScrollbarThemeMac.mm:
Just patching this function in a better way than I did
before.
(WebCore::updateArrowPlacement):
Call into WK for the right values.
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
Return false if there are no buttons.
(WebCore::ScrollbarThemeMac::hasButtons):
Return an empty IntRect if there are not buttons.
(WebCore::buttonRepaintRect):
2011-01-26 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Add events to represent the start/end of a gesture scroll
https://bugs.webkit.org/show_bug.cgi?id=53215
* WebCore.exp.in:
Add new file.
* WebCore.xcodeproj/project.pbxproj:
Add new file.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* page/EventHandler.h:
Add entry point for handling gesture events.
* platform/PlatformGestureEvent.h: Added.
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::type):
(WebCore::PlatformGestureEvent::position):
(WebCore::PlatformGestureEvent::globalPosition):
(WebCore::PlatformGestureEvent::timestamp):
Add platform agnostic representation of a gesture event.
2011-01-26 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
<rdar://problem/8446709> Allow inter-ideograph justification for CJK
https://bugs.webkit.org/show_bug.cgi?id=53184
Tests: fast/text/justify-ideograph-complex.html
fast/text/justify-ideograph-simple.html
fast/text/justify-ideograph-vertical.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal): Corrected the type of the third parameter
passed to the TextRun constructor and added the trailingExpansionBehavior parameter.
* platform/graphics/Font.cpp:
(WebCore::Font::expansionOpportunityCount): Added. Returns the number of expansion opportunities
for text justification. On entry, isAfterExpansion says whether an expansion opportunity exists
before the first character. On return, isAfterExpansion says whether an expansion opportunity
exists after the last character.
* platform/graphics/Font.h:
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::expandLastAdvance): Added.
* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun): Added a TrailingExpansionBehavior parameter to the constructors.
Renamed padding to expansion.
(WebCore::TextRun::expansion): Renamed padding() to this.
(WebCore::TextRun::allowsTrailingExpansion): Added this accessor.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion. Use Font::expansionOpportunityCount()
and adjust the count if it includes a trailing expansion opportunity but the run disallows trailing
expansion.
(WebCore::WidthIterator::advance): Apply expansion before and after CJK ideographs.
(WebCore::WidthIterator::advanceOneCharacter): Changed to not clear the GlyphBuffer so that advance()
can expand the last advance if it is followed by a CJK ideograph.
* platform/graphics/WidthIterator.h: Renamed m_padding to m_expansion and m_padPerSpace
to m_expansionPerOpportunity.
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* platform/graphics/efl/FontEfl.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* platform/graphics/haiku/FontHaiku.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController): Initialize m_isAfterExpansion. Use
Font::expansionOpportunityCount() and adjust the count if it includes a trailing expansion
opportunity but the run disallows trailing expansion.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Moved the definition and initialization
of hasExtraSpacing outside the loop. Apply expansion before and after CJK ideographs.
* platform/graphics/mac/ComplexTextController.h: Renamed m_padding to m_expansion and m_padPerSpace
to m_expansionPerOpportunity.
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* platform/graphics/win/FontWin.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::UniscribeController): Updated for rename.
* platform/graphics/wince/FontWinCE.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* platform/graphics/wx/FontWx.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint): Pass a TrailingExpansionBehavior to the TextRun constructor.
(WebCore::EllipsisBox::selectionRect): Ditto.
(WebCore::EllipsisBox::paintSelection): Ditto.
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox): Renamed m_toAdd to m_expansion.
(WebCore::InlineBox::expansion): Renamed toAdd() to this.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect): Pass a TrailingExpansionBehavior to the TextRun constructor.
(WebCore::InlineTextBox::paint): Ditto.
(WebCore::InlineTextBox::paintSelection): Ditto.
(WebCore::InlineTextBox::paintCompositionBackground): Ditto.
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
(WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
(WebCore::InlineTextBox::offsetForPosition): Ditto.
(WebCore::InlineTextBox::positionForOffset): Ditto.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::setExpansion): Renamed setSpaceAdd() to this.
(WebCore::InlineTextBox::trailingExpansionBehavior): Added. Trailing expansion is allowed if this
is not the last leaf box on the line.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Keep expansion opportunity counts
in a vector instead of computing them twice. Discard the trailing expansion opportunity in the
last text box.
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject): Pass a TrailingExpansionBehavior to the TextRun constructor.
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths): Ditto.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto. Also corrected the type of the second parameter.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::getAvgCharWidth): Ditto.
(WebCore::RenderTextControl::paintPlaceholder): Ditto.
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun): Ditto.
2011-01-26 Andy Estes <aestes@apple.com>
Rubber-stamped by Darin Adler.
Inline HTMLObjectElement::hasValidClassId().
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId):
2011-01-26 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] crash on getBoundingClientRect in complex text
https://bugs.webkit.org/show_bug.cgi?id=53199
Use the correct array bound; we want the number of characters processed by
the shaper, not the longest continuous script run length.
Test: platform/chromium-linux/fast/text/international/complex-text-rectangle.html
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::nextScriptRun):
* platform/graphics/chromium/ComplexTextControllerLinux.h:
(WebCore::ComplexTextController::numCodePoints):
2011-01-26 Emil A Eklund <eae@chromium.org>
Reviewed by Alexey Proskuryakov.
Remove cached document reference from CSSStyleSheet and XSLStyleSheet.
https://bugs.webkit.org/show_bug.cgi?id=52084
Test: fast/dom/css-delete-doc.html
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::document):
* css/CSSStyleSheet.h:
* xml/XSLStyleSheet.h:
(WebCore::XSLStyleSheet::parentStyleSheet):
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::cachedResourceLoader):
(WebCore::XSLStyleSheet::setParentStyleSheet):
(WebCore::XSLStyleSheet::ownerDocument):
* xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::cachedResourceLoader):
(WebCore::XSLStyleSheet::ownerDocument):
2011-01-25 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
Reduce ref-count churn in shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53136
Refactoring, so no new tests.
* dom/Element.h:
(WebCore::Element::shadowPseudoId): Changed signature to use const AtomicString&
* html/ValidationMessage.cpp:
(WebCore::ElementWithPseudoId::shadowPseudoId): Ditto.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shadowPseudoId): Ditto, plus moved from the header file.
* html/shadow/SliderThumbElement.h: Ditto.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlMuteButtonElement::shadowPseudoId): Ditto.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Ditto.
(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Ditto.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Ditto.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Ditto.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Ditto.
(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Ditto.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Ditto.
(WebCore::MediaControlTimelineElement::shadowPseudoId): Ditto.
(WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Ditto.
(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Ditto.
* rendering/MediaControlElements.h: Ditto.
2011-01-26 Dave Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=46421, make multi-column layout work with vertical text.
Added new tests in fast/multicol/vertical-lr and fast/multicol/vertical-rl.
* css/html.css:
Update p, blockquote and h1-h6 to respect directionality so that column layout tests that use those
elements work properly.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Fix a flipping bug with the computation of lineTopIncludingMargins where it could be incorrectly shrunk
in some cases (causing lines to all stack on top of one another).
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::calculateBoundaries):
Fix calculateBoundaries to be physical rather than logical.
* rendering/LayoutState.cpp:
(WebCore::LayoutState::addForcedColumnBreak):
* rendering/LayoutState.h:
Rename childY to childLogicalOffset.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::desiredColumnWidth):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::leftForFloatIncludingMargin):
(WebCore::RenderBlock::topForFloatIncludingMargin):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
Reworking of all the RenderBlock column functions to support flipping and vertical modes.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::flipForWritingModeIncludingColumns):
Patch offsetFromContainer to be aware of flipped block writing modes when dealing with column layouts.
* rendering/RenderBox.h:
(WebCore::RenderBox::clientLogicalBottom):
Fix a bug in clientLogicalBottom where it didn't add in the right border/padding.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
Better terminology for pagination.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::mapLocalToContainer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):
(WebCore::RenderLayer::localBoundingBox):
(WebCore::RenderLayer::boundingBox):
Patch painting in RenderLayers to be vertical-text-aware.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::mapLocalToContainer):
Add code to be flipped block-aware with columns.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
Fix pagination to use better terminology.
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):
Fix a bug where vertical text wasn't taken into account.
2011-01-26 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r76719.
http://trac.webkit.org/changeset/76719
https://bugs.webkit.org/show_bug.cgi?id=53122
Broke a bunch of media tests in Chromium/Qt/GTK.
2011-01-26 Tony Chang <tony@chromium.org>
Reviewed by Ryosuke Niwa.
[gtk] strip NUL characters when copying text/html on GTK+
https://bugs.webkit.org/show_bug.cgi?id=52508
Putting NUL characters in the text/html clipboard doesn't work in
WebKit GTK+ (the pasted value is truncated at the NUL). Since we're
already stripping this character for plain text (for Windows), strip
it in text/html too.
* editing/MarkupAccumulator.h: mark function as virtual
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendString):
(WebCore::StyledMarkupAccumulator::takeResults): strip nulls
2011-01-26 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Reliable crash with getTextAtOffset()
https://bugs.webkit.org/show_bug.cgi?id=53131
Properly calculate length in bytes for a UTF8 substring.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(utf8Substr): Use character instead of bytes as units to
calculate the length in bytes for the UTF8 string.
2011-01-25 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
Change HTMLInputElement-derived parts of media element shadow DOM to use shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53122
This is the first step in converting HTMLMediaElement to the new shadow DOM.
Should not regress any existing tests. No observable change in behavior.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId): Removed now-unnecessary hard-coded pseudo-element selectors.
(WebCore::nameToPseudoTypeMap): Ditto.
(WebCore::CSSSelector::extractPseudoType): Ditto.
* css/CSSSelector.h: Ditto.
* css/mediaControls.css: Added proper initial values, now that elements use the proper selector pipeline.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::MediaControlInputElement): Removed the switch statement,
which is now replaced with virtual shadowPseudoId on each corresponding class.
(WebCore::MediaControlInputElement::styleForElement): Changed to use element pipeline.
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Changed to set
display type in constructor.
(WebCore::MediaControlMuteButtonElement::create): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Added
to disambiguate from the MediaControlMuteButtonElement.
(WebCore::MediaControlVolumeSliderMuteButtonElement::create): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Added.
(WebCore::MediaControlSeekForwardButtonElement::create): Added.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Added.
(WebCore::MediaControlSeekBackButtonElement::create): Added.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Added.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlTimelineElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Added.
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Changed to not take PseudoId as
constructor argument.
(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Added.
* rendering/MediaControlElements.h:
(WebCore::MediaControlSeekForwardButtonElement::isForwardButton): Added.
(WebCore::MediaControlSeekBackButtonElement::isForwardButton): Added.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::createMuteButton): Changed to use new constructor.
(WebCore::RenderMedia::createSeekBackButton): Ditto.
(WebCore::RenderMedia::createSeekForwardButton): Ditto.
(WebCore::RenderMedia::createVolumeSliderMuteButton): Ditto.
* rendering/style/RenderStyleConstants.h: Removed constants that are no longer used.
2011-01-26 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Fix multisampling support in DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=53154
In DrawingBuffer's multisampling code path, fixed enum usage and a
bug where it would incorrectly redefine the depth and stencil
buffers. Hooked up multisampling code path in Chromium port.
Tested manually with some accelerated 2D canvas content.
Multisampling isn't being switched on for the accelerated 2D
canvas at the current time because it will increase fill rate
requirements and cause a large number of rebaselines.
* platform/graphics/Extensions3D.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::publishToPlatformLayer):
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supports):
2011-01-26 Tony Chang <tony@chromium.org>
Unreviewed.
[chromium] revert r68310 because of race conditions detected by tsans
https://bugs.webkit.org/show_bug.cgi?id=53185
Causes stability problems for Chromium, http://crbug.com/70589
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
2011-01-26 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Make fireEventsAndUpdateStyle use stack local vectors.
https://bugs.webkit.org/show_bug.cgi?id=46760
Test: animations/animation-add-events-in-handler.html
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
2011-01-26 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Remove m_URL from FrameLoader and depend on Document::url()
instead. FrameLoader::url() will be removed in a followup patch.
https://bugs.webkit.org/show_bug.cgi?id=41165
Refactor only, no new tests.
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateURLForPushOrReplaceState):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::iconURL):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::didExplicitOpen):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::url):
(WebCore::FrameLoader::setOutgoingReferrer):
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::commitIconURLToIconDatabase):
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::checkIfDisplayInsecureContent):
(WebCore::FrameLoader::checkIfRunInsecureContent):
(WebCore::FrameLoader::updateFirstPartyForCookies):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::shouldScrollToAnchor):
* loader/FrameLoader.h: Rename setURL() to setOutgoingReferrer().
2011-01-25 Brian Weinstein <bweinstein@apple.com>
Reviewed by Antti Koivisto.
Crashes loading pages when cancelling subresource loads through WebKit
https://bugs.webkit.org/show_bug.cgi?id=53123
<rdar://problem/8914361>
Fix a crash that happened when cancelling subresource loads through WebKit.
When a load is cancelled synchronously (via the WebKit client), CachedResourceLoader::requestResource
can be called recursively on the same function, either leading to infinite recursion, or deleting
an object when it is not done being used.
The fix for this was to call checkForPendingPreloads and servePendingRequests asynchronously when
CachedResourceLoader::loadDone was called synchronously (due to the load being cancelled synchronously).
Test: fast/loader/willSendRequest-null-for-preload.html
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setRequest): Only dispatch didReceiveServerRedirectForProvisionalLoadForFrame
if our new URL is non-null.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader): Initialize our timer.
(WebCore::CachedResourceLoader::loadDone): If the CachedResource we were passed in was 0, that means this
function was called synchronously
from CachedResourceRequest::load, and we don't want to call into checkForPendingPreloads synchronously,
so put it on a 0-delay timer to make the calls to checkForPendingPreloads and servePendingRequests asynchronous.
(WebCore::CachedResourceLoader::loadDonePendingActionTimerFired): Call checkForPendingPreloads and servePendingRequests.
(WebCore::CachedResourceLoader::checkForPendingPreloads): m_pendingPreloads is now a Deque instead of a Vector,
so use Deque methods.
* loader/cache/CachedResourceLoader.h: Add the timer, the timer callback function, and make m_pendingPreloads a Deque.
2011-01-25 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: evaluate in console may not work when window.console is substituted or deleted.
https://bugs.webkit.org/show_bug.cgi?id=53072
Test: inspector/console-substituted.html
* inspector/InjectedScriptSource.js:
(.):
2011-01-26 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[cairo] Use CAIRO_OPERATOR_DARKEN when available
https://bugs.webkit.org/show_bug.cgi?id=53084
Use CAIRO_OPERATOR_DARKEN for CompositePlusDarker instead of
CAIRO_OPERATOR_SATURATE when building with cairo version >= 1.10.
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::toCairoOperator):
2011-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: visualize \n in strings as unicode cr
symbol in stack variables sidebar.
https://bugs.webkit.org/show_bug.cgi?id=53162
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
2011-01-26 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: size is wrong for cached resources in Network panel
- Set the size for 304/not modified resources from cached resource.
- Add response headers size to resource transfer size.
https://bugs.webkit.org/show_bug.cgi?id=52886
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.get transferSize):
(WebInspector.Resource.prototype.set responseHeaders):
(WebInspector.Resource.prototype._headersSize):
(WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
2011-01-26 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Simon Hausmann.
Fixed TiledBacking store to take into account new dirty regions caused by
paint time layouts.
Flawed rendering design for QtWebKit resulting in artifacts being displayed
https://bugs.webkit.org/show_bug.cgi?id=49184
There are no new tests as this patch aims at fixing flicker that
happen randomly, mostly on slow hardware, thus are hard to reproduce
consistently in an automated test.
This patch does not fully address the said bug but it is a step in the
right direction. A full solution to the bug, as currently perceived,
requires either a Qt GUI API change, a performance hit for QtWebKit,
or a hack, until a full solution is provided this patch is progress.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::updateTileBuffers):
Changed to take into account newly dirtied areas created during
tile update initiated layouts during the same update.
2011-01-26 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[SKIA] Remove "current path" of GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=53124
* platform/graphics/GraphicsContext.h:
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::strokeBoundingRect):
* platform/graphics/skia/PlatformContextSkia.cpp:
* platform/graphics/skia/PlatformContextSkia.h:
2011-01-26 Zalan Bujtas <zbujtas@gmail.com>
Reviewed by Andreas Kling.
[Qt] Path::normalAngleAtLength() returns incorrect value on ACID3.
QPainterPath returns angle values with the origo being at the top left corner,
we need to account for this in normalAngleAtLength().
This Regressed with r66979.
No new tests as this is already covered by ACID3.
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::normalAngleAtLength):
2011-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: live edit does not update source snippet.
https://bugs.webkit.org/show_bug.cgi?id=53097
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
2011-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Incorrect on-hover evaluation of a variable named 'profile'.
https://bugs.webkit.org/show_bug.cgi?id=53018
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getCompletions):
(WebCore::InjectedScript::getCompletionsOnCallFrame):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::getCompletions):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._showPopup):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
2011-01-26 Hironori Bono <hbono@chromium.org>
Reviewed by Kent Tamura.
A speculative fix for Bug 52422 - [chromium] More crash in
FontFallbackList::determinePitch(const Font* font)
https://bugs.webkit.org/show_bug.cgi?id=52422
My previous change may not work on non-US Windows whose system fonts
have localized aliases matching to the system locale because of a
font-name mismatch in createFontIndirectAndGetWinName(). This change
tries all the fonts installed in a PC and returns the first font that we
can create without errors.
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
Added a struct used for getLastResortFallbackFontProc().
(WebCore::getLastResortFallbackFontProc): Added a callback for EnumFontFamilies().
(WebCore::FontCache::getLastResortFallbackFont): Use EnumFontFamilies() to find a last-resort font.
2011-01-26 James Robinson <jamesr@chromium.org>
Reviewed by Nate Chapin.
Add a DOMTimeStamp parameter to the requestAnimationFrame callback
https://bugs.webkit.org/show_bug.cgi?id=53142
This adds a DOMTimeStamp parameter to the requestAnimationFrame callback to more
closely match mozilla's proposal. This is useful if the page has multiple imperative animations
and wants to ensure that they all remain synchronized. If each callback used Date.now() to
update its animation state, they would potentially be out of sync with each other. If they use
the timestamp then all callbacks for the same "frame" will update to the same state.
Test: fast/animation/request-animation-frame-timestamps.html
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithClass2Param):
* dom/Document.cpp:
(WebCore::Document::serviceScriptedAnimations):
* dom/Document.h:
* dom/RequestAnimationFrameCallback.h:
* dom/RequestAnimationFrameCallback.idl:
* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
* page/FrameView.h:
2011-01-25 Yuzo Fujishima <yuzo@google.com>
Unreviewed attempt to fix compilation error for Chromium Clang.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::advance):
2011-01-25 Ned Holbrook <nholbrook@apple.com>
Reviewed by Dan Bernstein.
ComplexTextController incorrectly conflates string length and range of indexes
https://bugs.webkit.org/show_bug.cgi?id=52760
Test: fast/text/offsetForPosition-complex-fallback.html
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic):
(WebCore::ComplexTextController::advance):
* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::create):
(WebCore::ComplexTextController::ComplexTextRun::indexEnd):
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
2011-01-25 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Scrollbars don't work correctly for top-to-bottom text in an overflow: scroll area
https://bugs.webkit.org/show_bug.cgi?id=53048
Test: fast/overflow/overflow-rtl-vertical-origin.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Take the scroll origin into account when calculating scrollbars in more places.
2011-01-25 Steve Falkenburg <sfalken@apple.com>
Windows production build fix.
Use correct configuration-specific path in makefile.
* WebCore.vcproj/WebCore.make:
2011-01-25 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Radio button group state is not restored correctly
https://bugs.webkit.org/show_bug.cgi?id=50442
Fixes a bug that radio button states are not restored correctly in
a case that non-first radio button in a group is checked.
If "checked" attribute is present, the radio button is checked and
other radio buttons in the group are unchecked. This behavior
disturbs form state restoring. This patch changes this behavior so
that the "checked" attribute handling is delayed after form state
restoring.
Test: fast/forms/state-restore-radio-group.html
* html/HTMLFormControlElement.h:
Make finishParsingChildren() protected so that HTMLInpuElement can call it.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
- Add createdByParser parameter.
- Initialize m_stateRestored and m_parsingInProgress.
(WebCore::HTMLInputElement::create): Sync with the constructor.
(WebCore::HTMLInputElement::restoreFormControlState):
Set m_stateRestored in order to refer it in finishParsingChildren().
(WebCore::HTMLInputElement::parseMappedAttribute):
Don't call setChecked() during parsing. Move setNeedsValidityCheck()
to setChecked().
(WebCore::HTMLInputElement::finishParsingChildren):
Call setChecked() if form state is not restored.
(WebCore::HTMLInputElement::setChecked):
Move setNeedsValidityCheck() from parseMappedAttribute() because
finishParsingChildren() also needs to call setNeedsValidityCheck().
* html/HTMLInputElement.h:
- Remove the default value of HTMLFormElement* of the HTMLInputElement
constructor, and add createdByParser parameter.
- Introduce m_parsingInProgress and m_stateRestored.
* html/HTMLIsIndexElement.cpp:
(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
Sync with the HTMLInputElement constructor change.
* html/HTMLTagNames.in: Add constructorNeedsCreatedByParser flag.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::MediaControlInputElement):
Sync with the HTMLInputElement constructor change.
* rendering/ShadowElement.cpp:
(WebCore::ShadowInputElement::ShadowInputElement): ditto.
* rendering/ShadowElement.h:
(WebCore::ShadowElement::ShadowElement): ditto.
2011-01-25 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
HTMLFormElement::checkValidity() returns incorrect result if 'invalid' events are canceled.
https://bugs.webkit.org/show_bug.cgi?id=52565
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
Check checkInvalidControlsAndCollectUnhandled() result instead of
checking emptiness of unhandled invalid controls list.
(WebCore::HTMLFormElement::checkValidity): ditto.
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
Renamed from collectUnhandledInvalidControls().
Returns true if there is any invalid control regardless of event canceling.
* html/HTMLFormElement.h: Rename collectUnhandledInvalidControls() to
checkInvalidControlsAndCollectUnhandled().
2011-01-25 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Range and number inputs should reject increment and decrement by
keyboard or mouse wheel if they are disabled or read-only
https://bugs.webkit.org/show_bug.cgi?id=53151
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent): Check disabled() and readOnly().
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): ditto.
2011-01-25 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
API to support localized numbers for <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=45730
Introduce platform/text/LocalizedNumber.h, and
LocalizedNumberNone.cpp, which is an empty implementation of the
functions in LocalizedNumber.h. We use LocalizedNumberNone.cpp in
all platforms for now.
A string in a type=number field is parsed as a localized number
first. If the parsing fails, it is parsed as the HTML5 number.
We introduce HTMLInputElement::visibleValue(). It represents a value
which should be drawn by a renderer. HTMLInputElement::value() always
returns a number formatted for HTML5, and visibleValue() may return a
localized number.
No new tests because this doesn't change any behavior.
* Android.mk: Add LocalizedNumber.h and/or LocalizedNumberNone.cpp.
* CMakeLists.txt: ditto.
* GNUmakefile.am: ditto.
* WebCore.gypi: ditto.
* WebCore.pro: ditto.
* WebCore.vcproj/WebCore.vcproj: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.
* dom/InputElement.h: Add visibleValue().
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::visibleValue): Added. Just call InputType::visibleValue().
* html/HTMLInputElement.h: Declare visibleValue().
* html/InputType.cpp:
(WebCore::InputType::visibleValue): Add the default implementation of
visibleValue(), which returns HTMLInputElement::value().
* html/InputType.h: Add declarations.
* html/NumberInputType.cpp:
(WebCore::isHTMLNumberCharacter): Renamed from isNumberCharacter().
(WebCore::isNumberCharacter): Calls isLocalizedNumberCharacter() and isHTMLNumberCharacter().
(WebCore::NumberInputType::visibleValue):
Returns a localized number string produced by formatLocalizedNumber().
(WebCore::NumberInputType::isAcceptableValue): Calls parseLocalizedNumber().
(WebCore::NumberInputType::sanitizeValue): Calls parseLocalizedNumber().
* html/NumberInputType.h: Add declarations.
* platform/text/LocalizedNumber.h: Added.
* platform/text/LocalizedNumberNone.cpp: Added.
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
(WebCore::isLocalizedNumberCharacter):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::updateFromElement):
Calls InputElement::visibleValue() instead of value().
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::visibleValue): Added. It just calls value().
2011-01-25 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=53143
Add IntRectHash
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/IntRectHash.h: Added.
* platform/graphics/IntSizeHash.h: Don't do "using WebCore::IntSize"!
2011-01-25 Ilya Sherman <isherman@chromium.org>
Reviewed by Ryosuke Niwa.
Remove trailing whitespace in HTMLInputElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=53152
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::applyStep):
(WebCore::HTMLInputElement::updateFocusAppearance):
(WebCore::HTMLInputElement::mapToEntry):
(WebCore::HTMLInputElement::setAutofilled):
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
(WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
2011-01-25 Mike Reed <reed@google.com>
Reviewed by James Robinson.
DrawingBufer::reset() today checks if the new size is the same as its
m_size, and if so, returns immediately. This does not match the
semantics of <canvas>, which wants to clear its contents anytime the
size is specified.
https://bugs.webkit.org/show_bug.cgi?id=53149
Test: Covered by existing <canvas> tests using gpu.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset):
2011-01-25 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Add a hashset of DOMURLs to ScriptExecutionContext to track back references.
https://bugs.webkit.org/show_bug.cgi?id=53038
Test: fast/dom/window-domurl-crash.html
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::createdDomUrl):
(WebCore::ScriptExecutionContext::destroyedDomUrl):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::domUrls):
* html/DOMURL.cpp:
(WebCore::DOMURL::DOMURL):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
* html/DOMURL.h:
(WebCore::DOMURL::scriptExecutionContext):
2011-01-23 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=52983
Eliminate m_tagHistory pointer from CSSSelector
Keep the component selectors in the array in CSSSelectorList instead
of maintaining a linked list between them. This allows eliminating
m_tagHistory pointer, shrinking CSSSelector by 25% (selection performance
seems to improve some too due to better locality).
* WebCore.xcodeproj/project.pbxproj:
Make CSSSelector.h a private header.
* css/CSSGrammar.y:
Use CSSParserSelector during parsing to keep the tag history in
a linked list. This is flattened to an array after parsing.
Use accessors for setting selector values.
Use OwnPtr in selector vector.
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
* css/CSSPageRule.h:
(WebCore::CSSPageRule::create):
Simplify.
* css/CSSParser.cpp:
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::createFloatingSelector):
(WebCore::CSSParser::sinkFloatingSelector):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::updateSpecifiersWithElementName):
(WebCore::CSSParser::createPageRule):
* css/CSSParser.h:
(WebCore::CSSParser::reusableSelectorVector):
CSSSelector -> CSSParserSelector.
Use OwnPtr in selector vector.
* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::CSSParserSelector):
(WebCore::CSSParserSelector::~CSSParserSelector):
* css/CSSParserValues.h:
(WebCore::CSSParserSelector::releaseSelector):
(WebCore::CSSParserSelector::setTag):
(WebCore::CSSParserSelector::setValue):
(WebCore::CSSParserSelector::setAttribute):
(WebCore::CSSParserSelector::setArgument):
(WebCore::CSSParserSelector::setSimpleSelector):
(WebCore::CSSParserSelector::setMatch):
(WebCore::CSSParserSelector::setRelation):
(WebCore::CSSParserSelector::setForPage):
(WebCore::CSSParserSelector::pseudoType):
(WebCore::CSSParserSelector::isUnknownPseudoElement):
(WebCore::CSSParserSelector::isSimple):
(WebCore::CSSParserSelector::tagHistory):
(WebCore::CSSParserSelector::setTagHistory):
Linked list used during parsing.
Avoid recursive destruction.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::operator==):
(WebCore::CSSSelector::selectorText):
(WebCore::CSSSelector::setSimpleSelector):
* css/CSSSelector.h:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagHistory):
(WebCore::CSSSelector::tag):
(WebCore::CSSSelector::value):
(WebCore::CSSSelector::setTag):
(WebCore::CSSSelector::isLastInTagHistory):
(WebCore::CSSSelector::setNotLastInTagHistory):
(WebCore::CSSSelector::RareData::RareData):
(WebCore::CSSSelector::RareData::~RareData):
(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::setValue):
Remove m_tagHistory.
Keep m_value in the union with the rare data pointer instead.
Make m_value and m_tag private, implement accessors.
Add a new bit to indicate end of the tag history (multipart selector).
Eliminate complex destruction. Selectors are now deleted as an array or by a CSSParserSelector chain.
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::adoptSelectorVector):
Flatten everything to an array.
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
* css/CSSSelectorList.h:
(WebCore::CSSSelectorList::hasOneSelector):
(WebCore::CSSSelectorList::next):
Skip over the subparts of multipart selectors to find the next selector.
* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::adoptSelectorVector):
CSSSelector -> CSSParserSelector.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSRuleSet::addRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSStyleSelector::matchPageRulesForList):
* dom/Node.cpp:
(WebCore::Node::querySelector):
* dom/SelectorNodeList.cpp:
(WebCore::createSelectorNodeList):
Use accessors.
2011-01-25 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Chang.
[Chromium] Support small caps in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=53051
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::nextScriptRun): Break runs at small caps boundaries.
(WebCore::ComplexTextController::setupFontForScriptRun): Setup small caps font data if needed.
* platform/graphics/chromium/ComplexTextControllerLinux.h: Store small caps text in separate string.
2011-01-25 Steve Falkenburg <sfalken@apple.com>
Rubber-stamped by Adam Roben.
Windows production build fix.
Use correct environment variable escaping
* WebCore.vcproj/WebCore.make:
2011-01-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Empty URLs are never display isolated
https://bugs.webkit.org/show_bug.cgi?id=53053
This check mirrors the check in the local case. There isn't a good way
to test this with a LayoutTest, but it is tested in Chromium (where
this registry is used).
* platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
2011-01-25 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Pipe a timestamp down into the PlatformWheelEvent for the Mac.
https://bugs.webkit.org/show_bug.cgi?id=53111
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::timestamp):
Add timestamp member.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Initialize the timestamp from the event.
2011-01-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76625.
http://trac.webkit.org/changeset/76625
https://bugs.webkit.org/show_bug.cgi?id=53119
"incorrect pixel test results" (Requested by rniwa on
#webkit).
* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
2011-01-25 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r76614.
* platform/FileSystem.h:
2011-01-21 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Adler.
Adding border and padding to the calculation of the local caret rect for RenderBoxes.
Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744
Tests: editing/selection/caret-painting-after-paste-undo-rtl.html
editing/selection/caret-painting-after-paste-undo.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
2011-01-25 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
https://bugs.webkit.org/show_bug.cgi?id=53107
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::hasPreciseScrollingDeltas):
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
2011-01-20 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION (r72119): Audio never plays on Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52467
QuickTime's eat/m4a movie importer compontent doesn't list audio/m4a as a mime
type which it supports, though it handles .m4a files just fine. Change the way
we build the list of supported MIME Types through a new WebKitSystemInterface
function.
Caused by r72119, which adds system-specific extension->MIME entries to the cache
before global entries, and the system-specific entries include QuickTime's registry
entries which contain the audio/m4a MIME type, while its components do not.
Test: media/audio-mpeg4-supported.html
* WebCore.vcproj/QTMovieWinCommon.vsprops:
* platform/graphics/win/QTMovie.cpp:
(getMIMETypeCallBack):
(initializeSupportedTypes):
(QTMovie::countSupportedTypes): gSupportedTypes is now a CFArrayRef.
(QTMovie::getSupportedType): Ditto.
2011-01-25 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Remove PlatformBridge::idbShutdown()
https://bugs.webkit.org/show_bug.cgi?id=53077
Since Chromium r72157, this is not used anymore. The previous use was
to signal to the embedder that IndexedDB was shutting down, but we
agreed it is better if the embedder keeps track of that itself.
No new tests: this does not change any functionality.
* platform/chromium/PlatformBridge.h:
* storage/IDBFactoryBackendInterface.cpp:
* storage/IDBFactoryBackendInterface.h:
(WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
* storage/chromium/IDBFactoryBackendInterface.cpp:
2011-01-25 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
WebKit is using CSBackupSetItemExcluded incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53095
rdar://problem/8790540
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performOpenInitialization): Added code to
exclude the database from backup one time, and record inside the
database that this has been done.
(WebCore::IconDatabase::wasExcludedFromBackup): Added.
(WebCore::IconDatabase::setWasExcludedFromBackup): Added.
* loader/icon/IconDatabase.h: Added new functions above.
* platform/FileSystem.cpp:
(WebCore::canExcludeFromBackup): Added.
(WebCore::excludeFromBackup): Added.
* platform/FileSystem.h: Added canExcludeFromBackup, excludeFromBackup,
and pathAsURL functions. Cleaned up ifdefs and comments a bit and sorted
things alphabetically, particularly platform-specific sections.
* platform/cf/FileSystemCF.cpp:
(WebCore::pathAsURL): Added.
* platform/mac/FileSystemMac.mm:
(WebCore::canExcludeFromBackup): Added.
(WebCore::excludeFromBackup): Added.
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::advanceCurrentStream): Changed to call pathAsURL.
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Ditto.
2011-01-25 Helder Correia <helder@sencha.com>
Reviewed by Dirk Schulze.
REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531
CGContextConcatCTM should use the CGLayer context, not the
GraphicsContext. Also, the CTM needs to be adjusted (translated).
This fixes SVG text gradient fill.
Test: svg/css/composite-shadow-text.svg
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRect):
2011-01-25 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Cannot extend or modify forward by word over a non-contenteditable region
https://bugs.webkit.org/show_bug.cgi?id=53070
Test: editing/selection/extend-forward-by-word-over-non-editable.html
Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa in the
functions which determine the end/start of words/lines/sentences in visible_units.cpp.
This fixes the bug where moving forwards by a word over a non-contenteditable region would place the cursor
inside that region, and then get moved back to the start of the word due to honorEditableBoundaryAtOrBefore.
The cursor is now moved to the end of the region (which is effectively a noop in this case).
* editing/visible_units.cpp: Change all instances of honorEditableBoundaryAtOrAfter to
honorEditableBoundaryAtOrBefore and vice versa.
(WebCore::previousWordPosition):
(WebCore::nextWordPosition):
(WebCore::startOfLine):
(WebCore::endOfLine):
(WebCore::previousSentencePosition):
(WebCore::nextSentencePosition):
(WebCore::logicalStartOfLine):
(WebCore::logicalEndOfLine):
2011-01-25 Yael Aharon <yael.aharon@nokia.com>
Unreviewed build fix.
After r76466, efsrv.lib is used unconditionally.
Don't guard it with ENABLE_NETSCAPE_PLUGIN_API.
* WebCore.pro:
2011-01-24 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Style cleanup for WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=52352
* html/canvas/WebGLBuffer.cpp:
* html/canvas/WebGLBuffer.h:
* html/canvas/WebGLObject.cpp:
* html/canvas/WebGLProgram.cpp:
* html/canvas/WebGLRenderbuffer.cpp:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::blendFunc):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::deleteBuffer):
(WebCore::WebGLRenderingContext::deleteShader):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::disableVertexAttribArray):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateRenderingState):
(WebCore::WebGLRenderingContext::enableVertexAttribArray):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLShader.cpp:
* html/canvas/WebGLTexture.cpp:
* html/canvas/WebGLUniformLocation.cpp:
* html/canvas/WebGLUniformLocation.h:
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* GNUmakefile.am:
* WebCore.pro:
* bindings/generic/RuntimeEnabledFeatures.h:
* bindings/js/JSArrayBufferCustom.cpp:
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDataViewCustom.cpp:
* bindings/js/JSDocumentCustom.cpp:
* bindings/js/JSFloat32ArrayCustom.cpp:
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/js/JSInt16ArrayCustom.cpp:
* bindings/js/JSInt32ArrayCustom.cpp:
* bindings/js/JSInt8ArrayCustom.cpp:
* bindings/js/JSUint16ArrayCustom.cpp:
* bindings/js/JSUint32ArrayCustom.cpp:
* bindings/js/JSUint8ArrayCustom.cpp:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::response):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
* bindings/v8/custom/V8DataViewCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::getCSSCanvasContextCallback):
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
(WebCore::V8XMLHttpRequest::sendCallback):
* features.pri:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::reset):
* html/HTMLCanvasElement.h:
* html/canvas/ArrayBuffer.cpp:
* html/canvas/ArrayBuffer.idl:
* html/canvas/ArrayBufferView.cpp:
* html/canvas/ArrayBufferView.idl:
* html/canvas/DataView.cpp:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.cpp:
* html/canvas/Float32Array.idl:
* html/canvas/Int16Array.cpp:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.cpp:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.cpp:
* html/canvas/Int8Array.idl:
* html/canvas/OESStandardDerivatives.cpp:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESTextureFloat.cpp:
* html/canvas/OESTextureFloat.idl:
* html/canvas/Uint16Array.cpp:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.cpp:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.cpp:
* html/canvas/Uint8Array.idl:
* html/canvas/WebGLActiveInfo.idl:
* html/canvas/WebGLBuffer.cpp:
* html/canvas/WebGLBuffer.idl:
* html/canvas/WebGLContextAttributes.cpp:
* html/canvas/WebGLContextAttributes.idl:
* html/canvas/WebGLContextEvent.idl:
* html/canvas/WebGLExtension.cpp:
* html/canvas/WebGLFramebuffer.cpp:
* html/canvas/WebGLFramebuffer.idl:
* html/canvas/WebGLGetInfo.cpp:
* html/canvas/WebGLObject.cpp:
* html/canvas/WebGLProgram.cpp:
* html/canvas/WebGLProgram.idl:
* html/canvas/WebGLRenderbuffer.cpp:
* html/canvas/WebGLRenderbuffer.idl:
* html/canvas/WebGLRenderingContext.cpp:
* html/canvas/WebGLRenderingContext.idl:
* html/canvas/WebGLShader.cpp:
* html/canvas/WebGLShader.idl:
* html/canvas/WebGLTexture.cpp:
* html/canvas/WebGLTexture.idl:
* html/canvas/WebGLUniformLocation.cpp:
* html/canvas/WebGLUniformLocation.idl:
* html/canvas/WebKitLoseContext.cpp:
* html/canvas/WebKitLoseContext.idl:
* page/DOMWindow.idl:
* platform/graphics/ANGLEWebKitBridge.cpp:
* platform/graphics/GraphicsContext3D.cpp:
* platform/graphics/cg/GraphicsContext3DCG.cpp:
* platform/graphics/gpu/DrawingBuffer.cpp:
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
* platform/graphics/mac/GraphicsContext3DMac.mm:
* platform/graphics/mac/WebGLLayer.mm:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/qt/Extensions3DQt.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::flushChanges):
* platform/graphics/qt/GraphicsLayerQt.h:
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::isAcceleratedCanvas):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::contentChanged):
* webaudio/AudioBuffer.cpp:
* webaudio/AudioBuffer.idl:
* webaudio/RealtimeAnalyser.cpp:
* webaudio/RealtimeAnalyser.h:
* webaudio/RealtimeAnalyserNode.h:
* webaudio/RealtimeAnalyserNode.idl:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/XMLHttpRequest.h:
2011-01-25 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Prepare for landing of detailed heap snapshots.
- Introduce Preferences.detailedHeapProfiles flag for controlling
querying of detailed heap snapshots.
- Add boilerplate code for the new view.
- Factor out common code.
https://bugs.webkit.org/show_bug.cgi?id=52624
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/ScriptProfiler.h:
(WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
(WebCore::ScriptProfiler::takeHeapSnapshot):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::takeHeapSnapshot):
* bindings/v8/ScriptProfiler.h:
(WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
* inspector/Inspector.idl:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::takeHeapSnapshot):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotView.js: Added.
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
(WebInspector.DetailedHeapshotView.prototype.get profile):
(WebInspector.DetailedHeapshotView.prototype.set profile):
(WebInspector.DetailedHeapshotView.prototype.show):
(WebInspector.DetailedHeapshotView.prototype.hide):
(WebInspector.DetailedHeapshotProfileType):
(WebInspector.DetailedHeapshotProfileType.prototype.get buttonTooltip):
(WebInspector.DetailedHeapshotProfileType.prototype.get buttonStyle):
(WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
(WebInspector.DetailedHeapshotProfileType.prototype.get welcomeMessage):
(WebInspector.DetailedHeapshotProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.DetailedHeapshotProfileType.prototype.createView):
* inspector/front-end/HeapSnapshot.js: Added.
(WebInspector.HeapSnapshotEdgesIterator):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get done):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get name):
(WebInspector.HeapSnapshotEdgesIterator.prototype.next):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get node):
(WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex):
(WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex):
(WebInspector.HeapSnapshotEdgesIterator.prototype._getType):
(WebInspector.HeapSnapshotNodeWrapper):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get edges):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get name):
(WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize):
(WebInspector.HeapSnapshotNodeWrapper.prototype._getName):
(WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges):
(WebInspector.HeapSnapshotNodeWrapper.prototype._getType):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.get rootEdges):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._setRecordingProfile):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
(WebInspector.ProfilerDispatcher.prototype.reportHeapSnapshotProgress):
* inspector/front-end/Settings.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
2011-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086
* WebCore.exp.in:
* inspector/InspectorAgent.cpp:
* inspector/InspectorAgent.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
* inspector/InspectorSettings.cpp:
(WebCore::InspectorSettings::InspectorSettings):
* inspector/InspectorSettings.h:
2011-01-25 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h
https://bugs.webkit.org/show_bug.cgi?id=51873
Replace the using declaration, because it doesn't compile on RVCT, and WINSCW has the same issue.
No new functionality so no new tests.
* html/canvas/Int32Array.h:
(WebCore::Int32Array::set):
* html/canvas/Int8Array.h:
(WebCore::Int8Array::set):
* html/canvas/Uint16Array.h:
(WebCore::Uint16Array::set):
* html/canvas/Uint32Array.h:
(WebCore::Uint32Array::set):
* html/canvas/Uint8Array.h:
(WebCore::Uint8Array::set):
2011-01-25 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
Repaint SVG elements with filter instead of relayout where possible
https://bugs.webkit.org/show_bug.cgi?id=52200
This patch allows repainting of filters, when their
attribute changes does not require relayout.
Existing dynamic-update tests cover this feature.
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::clearResult): Clearing the currently stored image
before repainting.
* platform/graphics/filters/FilterEffect.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceFilter): Not only the filter primitives,
but filters should also be detected to allow safe testing and casting.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives): Passing the renderer.
(WebCore::RenderSVGResourceFilter::applyResource):
determineFilterPrimitiveSubregion does not require the filter anymore.
(WebCore::RenderSVGResourceFilter::postApplyResource): Repaint
if lastEffect->hasResult() is false.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
Searching for all FilterEffects, whose created by the current FilterElement,
and clearing all resulting images depending on those FilterEffects.
* rendering/svg/RenderSVGResourceFilter.h:
(WebCore::RenderSVGResourceFilter::isSVGResourceFilter):
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
The filter argument is unnecessary anymore. But is is still kept as a static
member, since the primitive renderer still does not know about the
FilterEffect objects.
* rendering/svg/RenderSVGResourceFilterPrimitive.h:
(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
(WebCore::RenderSVGResourceFilterPrimitive::primitiveAttributeChanged):
Calls RenderSVGResourceFilter::primitiveAttributeChanged.
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
Setting the new attribute value for each FilterEffect.
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
* svg/SVGFEDiffuseLightingElement.h:
Calling primitiveAttributeChanged.
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):
This function will be removed when all FilterElement implements
their setFilterEffectAttribute
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::primitiveAttributeChanged):
* svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences): The
renderers are assigned to the filter effects.
(WebCore::SVGFilterBuilder::clearEffects):
(WebCore::SVGFilterBuilder::clearResultsRecursive): Recursively
clearing the result images for those filters, whose depend on
the starting filter.
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::effectReferences): 'get' is unnecessary
(WebCore::SVGFilterBuilder::effectByRenderer): returns the
FilterEffect belongs to this RenderObject.
2011-01-25 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG is missing to-animation support for Path
https://bugs.webkit.org/show_bug.cgi?id=52982
SVG was missing 'to' animation support for SVG paths. Even the fallback to discrete
animation did not work and an assert was thrown, because of the missing m_fromPath.
This also influences a test of the W3C test suite. Subtest 2 of animate-elem-83-t.svg passes now.
Test: svg/animations/animate-path-to-animation.html
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue): Take the value of the last SVGAnimateElement for
m_fromPath, since 'to' animations are accumulative.
(WebCore::SVGAnimateElement::calculateFromAndToValues): Added support for 'to' animations.
(WebCore::SVGAnimateElement::resetToBaseValue): Set m_animatedPath on the first animation element to baseVal.
* svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::copySVGPathByteStream): Return copy of current byte stream.
2011-01-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: bind resources to URLs upon adding them into the tree.
https://bugs.webkit.org/show_bug.cgi?id=53013
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._processCachedResources):
(WebInspector.NetworkManager.prototype.inflightResourceForURL):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.willSendRequest):
(WebInspector.NetworkDispatcher.prototype.markResourceAsCached):
(WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
(WebInspector.NetworkDispatcher.prototype.didReceiveContentLength):
(WebInspector.NetworkDispatcher.prototype.didFinishLoading):
(WebInspector.NetworkDispatcher.prototype.didFailLoading):
(WebInspector.NetworkDispatcher.prototype.willSendWebSocketHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse):
(WebInspector.NetworkDispatcher.prototype.didCloseWebSocket):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
(WebInspector.ResourceTreeModel.prototype._bindResourceURL):
(WebInspector.ResourceTreeModel.prototype._clearResources):
(WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.canShowSourceLine):
(WebInspector.ResourcesPanel.prototype.showSourceLine):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._parsedScriptSource):
(WebInspector.ScriptsPanel.prototype._addScript):
2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
Use accurate floating-point metrics for SVG Font calculations instead of casting float -> integer.
This hopefully fixes differences between 32/64 bit bots.
Needs new layout test results for several platforms, which need to be taken from the bots landing afterwards.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::initCharWidths):
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: debugger and browser debugger agents should manage sticky breakpoints independently.
https://bugs.webkit.org/show_bug.cgi?id=52999
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::enableDebugger):
(WebCore::InspectorAgent::inspectedURLWithoutFragment):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::setAllJavaScriptBreakpoints):
(WebCore::InspectorDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorDebuggerAgent::restoreBreakpoints):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
(WebInspector.BreakpointManager.prototype._pushBreakpointsToBackend):
2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Crash in some pages containing flash
https://bugs.webkit.org/show_bug.cgi?id=53016
Flash plugin can produce X errors that are handled by the GDK X
error handler, which exits the process. Since we don't want to
crash due to flash bugs, we install a custom error handler to show
a warning when a X error happens without aborting.
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::webkitgtkXError):
(WebCore::PluginPackage::load):
2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement spin buttons in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=51454
Paint inner up/down buttons for spin button elements when building
with GTK+ 3.x.
Test results will land with the GTK+ 2.x version of this patch.
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::paintSpinArrowButton):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
2011-01-24 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Missed move of one m_deleted use to be outside NDEBUG block
in r76575.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
2011-01-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Add runtime checks for invariants in memory cache
https://bugs.webkit.org/show_bug.cgi?id=53059
To help track down bug 53045, add some CRASH calls in addition to
ASSERTs, so that we can track down failures in reliability bots.
Just some checks, no new tests necessary.
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* loader/cache/CachedResource.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
2011-01-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Leaking CSSRuleDataList objects
https://bugs.webkit.org/show_bug.cgi?id=53062
Fix leaked CSSRuleDataLists added to the m_pseudoRules hash.
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleSet::~CSSRuleSet):
2011-01-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel.
Refcount Images used in rendering code
https://bugs.webkit.org/show_bug.cgi?id=52701
Change StyleImage::image(RenderObject*, const IntSize&) and
CSSImageGeneratorValue::image(RenderObject*, const IntSize&) to
return PassRefPtr<Image>, and adjust other code accordingly.
This allows us to return one-time images, for example for CSS gradients
whose appearance may change depending on factors other than the renderer
and the destination size.
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::image):
* css/CSSCanvasValue.h:
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
* css/CSSGradientValue.h:
* css/CSSImageGeneratorValue.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
* rendering/RenderImageResource.h:
(WebCore::RenderImageResource::image):
* rendering/RenderImageResourceStyleImage.h:
(WebCore::RenderImageResourceStyleImage::image):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::image):
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::image):
* rendering/style/StyleGeneratedImage.h:
* rendering/style/StyleImage.h:
* rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::image):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
2011-01-24 Tony Chang <tony@chromium.org>
Unreviewed, round ascent and descent to match old code.
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
2011-01-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
perspective() transform function should take lengths
https://bugs.webkit.org/show_bug.cgi?id=52683
The argument to the perspective() transform function should
be a Length, rather than a bare number. Bare numbers are still
accepted (and treated as px), but this behavior is deprecated.
Test: animations/3d/transform-perspective.html
transforms/3d/general/3dtransform-values.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTransform): Check the units for the perspective()
function. Allow bare numbers for backwards compatibility.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createTransformOperations): Convert
value to Length.
* platform/graphics/transforms/PerspectiveTransformOperation.cpp:
(WebCore::clampToPostiveInteger): Helper.
(WebCore::PerspectiveTransformOperation::blend): Blend via Lengths.
* platform/graphics/transforms/PerspectiveTransformOperation.h:
(WebCore::PerspectiveTransformOperation::create): double -> Length.
(WebCore::PerspectiveTransformOperation::perspective): Ditto.
(WebCore::PerspectiveTransformOperation::isIdentity): Ditto.
(WebCore::PerspectiveTransformOperation::apply): Ditto.
(WebCore::PerspectiveTransformOperation::PerspectiveTransformOperation): Assert
that the Length is a fixed type.
2011-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Windows] Textfield <input>s have different widths.
https://bugs.webkit.org/show_bug.cgi?id=48405
- Apply the padding override for type=text to other textfield types too.
- Reset margin value of outer spin button, which is not used in Windows.
- Don't add inner spin button width to the preferred text field width.
Text fields should have the identical widths regardless of the
existence of spin buttons.
Test: fast/forms/input-widths.html
* css/themeWin.css:
(input[type="week"]):
(input[type="week"]:disabled):
(input[type="search"]::-webkit-search-cancel-button):
(input::-webkit-outer-spin-button):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
Don't add inner spin button width to the preferred width.
2011-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Some bugs of search cancel button and spin button about state change in
an event handler.
https://bugs.webkit.org/show_bug.cgi?id=46950
Fix the following problems:
* Type=search field didn't release event capturing
* Assertion failure when an input field with spin buttons was changed
to another type on focus event.
* A input field with spin button didn't release event capturing when it
was changed to another type on focus event.
Tests: fast/forms/input-number-change-type-on-focus.html
fast/forms/search-hide-cancel-on-cancel.html
* rendering/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
- Make the variable 'input' RefPtr. It makes the code simpler.
- Remove visibility check on mouseup event. We should release capturing
anyway because the cancel button may be invisible if JavaScript code
called by the focus event removes the input value.
(WebCore::SpinButtonElement::detach):
- Release capturing on detach because it is possible that a spin button
node is detached while it is capturing events.
(WebCore::SpinButtonElement::defaultEventHandler):
Take a reference to this and check renderer() after some functions which
may run JavaScript code.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
Make the variable 'input' RefPtr to align other functions in this file.
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.
* rendering/TextControlInnerElements.h: Declare SpinButtonElement::detach().
2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
https://bugs.webkit.org/show_bug.cgi?id=52781
The bug was caused by stringWithRebalancedWhitespace's replacing the space at the beginning of a paragraph
and the end of a paragraph by a non-breaking space after it replaced two consecutive spaces by a space and
non-breaking space pattern, thereby replacing more spaces by non-breaking spaces than needed.
Rewrote the function using Vector<UChar> to fix the bug. New function no longer calls String::replace
multiple times but instead it traverses through the string and replaces a space that immediately follows
another space or appears at the beginning of a paragraph or at the end of a paragraph by a non-break space.
* editing/CompositeEditCommand.cpp:
* editing/htmlediting.cpp:
(WebCore::stringWithRebalancedWhitespace): Written.
* editing/htmlediting.h:
(WebCore::isWhitespace): Removed from CompositeEditCommand.cpp
2011-01-24 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Web Audio API: port FFTFrame to FFTW
https://bugs.webkit.org/show_bug.cgi?id=52989
Ported FFTFrame class to the open-source FFTW library. Tested with
unit tests from Chris Rogers. Made preliminary changes to GYP
files for conditional compilation of these files; will need to be
adjusted once FFTW is integrated as third-party source.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/audio/FFTFrame.h:
* platform/audio/fftw: Added.
* platform/audio/fftw/FFTFrameFFTW.cpp: Added.
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::fftwPlanForSize):
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Reset the page scale factor on standard frame loads
https://bugs.webkit.org/show_bug.cgi?id=53058
<rdar://problem/8908844>
Add a symbol needed by WebKit2.
* WebCore.exp.in:
2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Stop instantiating legacy editing positions in InsertTextCommand, MoveSelectionCommand,
ReplaceSelectionCommand, SelectionController, SpellChecker, TypingCommand, and markup.cpp
https://bugs.webkit.org/show_bug.cgi?id=52676
Stop instantiating legacy editing positions in the following files.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::prepareForTextInsertion):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::input):
(WebCore::InsertTextCommand::insertTab):
* editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::doApply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::shouldRemoveEndBR):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelectionFromNone):
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheck):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::makeEditableRootEmpty):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::highestAncestorToWrapMarkup):
(WebCore::createMarkup):
2011-01-24 Peter Kasting <pkasting@google.com>
Reviewed by Darin Adler.
Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733
* html/HTMLAnchorElement.cpp:
(WebCore::isLinkClick):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::postDispatchEventHandler):
(WebCore::HTMLInputElement::defaultEventHandler):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
2011-01-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Many DOM XHTML tests time out
https://bugs.webkit.org/show_bug.cgi?id=52553
Properly handle the situation where a synchronous load fails before the inner
event loop has started. In this case, we simply do not run the inner event loop,
or else it will block indefinitely (since no GIO or libsoup callbacks will fire).
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous
load if it fails up front.
2011-01-24 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
Cleanup WebGLGetInfo and related get*Parameter helpers in WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=52338
Removed the long/unsigned long types and corresponding get functions
and use int/unsigned int instead.
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/WebGLGetInfo.cpp:
(WebCore::WebGLGetInfo::WebGLGetInfo):
(WebCore::WebGLGetInfo::getInt):
(WebCore::WebGLGetInfo::getUnsignedInt):
* html/canvas/WebGLGetInfo.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getBufferParameter):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getProgramParameter):
(WebCore::WebGLRenderingContext::getRenderbufferParameter):
(WebCore::WebGLRenderingContext::getShaderParameter):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getVertexAttrib):
(WebCore::WebGLRenderingContext::getIntParameter):
(WebCore::WebGLRenderingContext::getUnsignedIntParameter):
* html/canvas/WebGLRenderingContext.h:
2011-01-24 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Adler.
Remove sizeInBytes from GraphicsContext3D's various implementations
https://bugs.webkit.org/show_bug.cgi?id=52339
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::sizeInBytes):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
2011-01-24 Adam Roben <aroben@apple.com>
Windows Production build fix
* WebCore.vcproj/WebCore.make: Update for move of WebCore into Source.
2011-01-24 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate class and files.
https://bugs.webkit.org/show_bug.cgi?id=52911
Plain refactoring, covered by the existing tests.
* WebCore.gypi: IntrusiveDOMWrapperMap.h added.
* bindings/v8/DOMDataStore.cpp: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
* bindings/v8/DOMDataStore.h: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
* bindings/v8/IntrusiveDOMWrapperMap.h: Added.
(WebCore::ChunkedTable::ChunkedTable):
(WebCore::ChunkedTable::add):
(WebCore::ChunkedTable::remove):
(WebCore::ChunkedTable::clear):
(WebCore::ChunkedTable::visit):
(WebCore::ChunkedTable::Chunk::Chunk):
(WebCore::ChunkedTable::clearEntries):
(WebCore::ChunkedTable::visitEntries):
(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(WebCore::IntrusiveDOMWrapperMap::clear):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
* bindings/v8/StaticDOMDataStore.h: include added.
2011-01-24 Shane Stephens <shanestephens@google.com>
Reviewed by Chris Marrin.
TransformationMatrix multiply operations apply operands in wrong order.
https://bugs.webkit.org/show_bug.cgi?id=52780
Rename TranformationMatrix::multLeft into multiply (the method does a multRight,
not a multLeft).
Remove TransformationMatrix::multiply, which was actually doing a multLeft.
Fix TransformationMatrix::operator* and operator*= such that the operand is
applied to the right-hand side of the matrix that the method is called on.
i.e., previously "a * b" used to compute "b * a", and "a *= b" used to store
"b * a" in "a". This has now been fixed so "a * b" computes "a * b" and
"a *= b" stores "a * b" in "a".
Convert all call sites for these methods to provide operands in the correct order.
No new tests as patch adds no new functionality.
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::multiply):
* platform/graphics/transforms/Matrix3DTransformOperation.h:
(WebCore::Matrix3DTransformOperation::apply):
* platform/graphics/transforms/MatrixTransformOperation.h:
(WebCore::MatrixTransformOperation::apply):
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::scaleNonUniform):
(WebCore::TransformationMatrix::scale3d):
(WebCore::TransformationMatrix::rotate3d):
(WebCore::TransformationMatrix::skew):
(WebCore::TransformationMatrix::applyPerspective):
(WebCore::TransformationMatrix::multiply):
(WebCore::TransformationMatrix::recompose):
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::operator*=):
(WebCore::TransformationMatrix::operator*):
* rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTransformFromContainer):
* rendering/TransformState.cpp:
(WebCore::TransformState::applyTransform):
(WebCore::HitTestingTransformState::applyTransform):
2011-01-24 Andrei Popescu <andreip@google.com>
Reviewed by Nate Chapin.
IndexedDatabase methods should not take arguments of type OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=53012
This patch reverts all IDB methods, except IDBDatabase::createObjectStore and
IDBObjectStore::createIndex, to using a plain list of arguments instead of
grouping the various parameters inside a single OptionsObject argument.
This decision was made on public-webapps@w3.org mailing list.
We also add support (v8 only for now) for passing DOMStringList objects as arguments to native
methods. The code for obtaining a DOMStringList object from a JS array of strings existed already
in OptionsObject.cpp, I just copied it to V8Bindings.cpp and taught the v8 code generator how to
use it.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Binding.cpp:
(WebCore::v8ValueToWebCoreDOMStringList):
* bindings/v8/V8Binding.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.idl:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* storage/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* storage/IDBIndex.idl:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.idl:
2011-01-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract dispatch API from network manager.
https://bugs.webkit.org/show_bug.cgi?id=53009
* WebCore.xcodeproj/project.pbxproj:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.reset):
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkManager.prototype._processCachedResources):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.identifierForInitialRequest):
(WebInspector.NetworkDispatcher.prototype.willSendRequest):
(WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
(WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
(WebInspector.NetworkDispatcher.prototype.didCreateWebSocket):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._updateResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._addFramesRecursively):
(WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._innerRequestContent):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype.reset):
(WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
2011-01-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
https://bugs.webkit.org/show_bug.cgi?id=53007
It's impossible to create "provisional" inspector for pages which are
not yet created so there is no need to listen for page creation in ScriptDebugServer.
* bindings/js/ScriptDebugServer.cpp:
* bindings/js/ScriptDebugServer.h:
* page/Page.cpp:
(WebCore::Page::Page):
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._update):
* inspector/front-end/DOMAgent.js:
(WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
2011-01-24 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix warnings about unregistering an invalid timer
https://bugs.webkit.org/show_bug.cgi?id=53006
The ShadowBuffer's purge timer ID was initialized with 0 which lead
to us calling QObject::killTimer(0), causing some qWarnings.
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ShadowBuffer::ShadowBuffer):
(WebCore::ShadowBuffer::schedulePurge):
2011-01-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Fix heap snapshot table sorting.
Fix table sorting to avoid qsort instability artefacts.
https://bugs.webkit.org/show_bug.cgi?id=52914
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._sortData):
(WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator):
(WebInspector.HeapSnapshotDataGridList.propertyComparator):
2011-01-24 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Find duplicate strings in localizedStrings.js, update it.
https://bugs.webkit.org/show_bug.cgi?id=53005
* English.lproj/localizedStrings.js:
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r76509.
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpoint):
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r76509.
* bindings/js/ScriptDebugServer.h:
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: set breakpoints by line:column.
https://bugs.webkit.org/show_bug.cgi?id=52615
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::restoreBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptBreakpoint.cpp: Removed.
* inspector/ScriptBreakpoint.h:
(WebCore::ScriptBreakpoint::ScriptBreakpoint):
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get url):
* inspector/front-end/BreakpointManager.js:
(WebInspector.JavaScriptBreakpoint.prototype._serializeToJSON):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.continueToLine):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype._breakpointSetOnBackend):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
2011-01-24 Peter Beverloo <peter@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: recognize application/x-font-woff as a valid mime-type.
https://bugs.webkit.org/show_bug.cgi?id=52977
No new tests.
* inspector/front-end/inspector.js:
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix for r76497.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show):
2011-01-24 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Use rad2deg() from WTF instead of rolling our own.
https://bugs.webkit.org/show_bug.cgi?id=52993
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArc):
2011-01-24 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] ResourceHandleSoup: do not wait for streams to close to issue didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=52885
No new tests as it does not change functionality. We will not wait for
the the input stream to close to issue didFinishLoading to
WebCore. We expect a subtle performance improvement with this
patch when loading complex web pages, as we wouldn't have to wait
for the stream to close (which involves creating a thread among
other things).
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::closeCallback):
(WebCore::readCallback):
2011-01-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: eliminate SourceView and ScriptView classes.
https://bugs.webkit.org/show_bug.cgi?id=52896
SourceView and ScriptView delegate everything to SourceFrame and should be eliminated.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.createResourceView):
(WebInspector.ResourceView.resourceViewTypeMatchesResource):
(WebInspector.SourceFrameContentProviderForResource): Moved from SourceView.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show):
(WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
(WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
* inspector/front-end/ScriptView.js: Removed.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
(WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
(WebInspector.ScriptsPanel.prototype._formatScript):
(WebInspector.SourceFrameContentProviderForScript): Moved from ScriptView.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype.hasContent):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
* inspector/front-end/SourceView.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
No new tests needed.
* WebCore.pri:
* WebCore.pro:
2011-01-24 Kent Tamura <tkent@chromium.org>
Unreviewed, trivial fix.
Fix a Chromium-only assertion failure by r76491.
https://bugs.webkit.org/show_bug.cgi?id=38982
Separate icon loading from the FileChooser constructor in order to avoid
ref() before adoptRef().
* platform/FileChooser.cpp:
(WebCore::FileChooser::FileChooser):
(WebCore::FileChooser::initialize):
(WebCore::FileChooser::create):
* platform/FileChooser.h:
2011-01-24 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextControlInnerElement::m_shadowParent should be removed.
https://bugs.webkit.org/show_bug.cgi?id=52998
No new tests. No behavioral change.
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
* rendering/TextControlInnerElements.h:
2011-01-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION (r72895): console.trace crashes
https://bugs.webkit.org/show_bug.cgi?id=52981
- Use local RefPtr variable for accessing PassRefPtr arguments to make sure the PassRefPtr has
non-null value.
- Use PassRefPtr for objects whos ownership is passed to the inspector.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorConsoleInstrumentation.h: Added. Extract inline methods called from the console into their
own header to reduce compilation time of other classes that depend on the inspector instrumentation.
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::startConsoleTiming):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleMarkTimeline):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
(WebCore::InspectorInstrumentation::addProfile):
(WebCore::InspectorInstrumentation::profilerEnabled):
(WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
* inspector/InspectorDatabaseInstrumentation.h: Added. Extract inline methods called from the datanase code into their
own header to reduce compilation time of other classes that depend on the inspector instrumentation.
(WebCore::InspectorInstrumentation::didOpenDatabase):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::consoleCountImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
(WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
(WebCore::InspectorInstrumentation::addProfileImpl):
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
* inspector/InspectorInstrumentation.h:
* page/Console.cpp: use RefPtr local variable instead of accessing PassRefPtr argument directly.
(WebCore::Console::addMessage):
(WebCore::Console::trace):
(WebCore::Console::count):
(WebCore::Console::markTimeline):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
* storage/Database.cpp:
(WebCore::Database::openDatabase):
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982
An icon data in Chromium port is represented as WebCore::Image. We
don't need OS-specific code anymore.
* WebCore.gypi:
* platform/graphics/Icon.h:
(WebCore::Icon::create): Add Chromium-specific factory.
* platform/graphics/chromium/IconChromium.cpp: Added.
* platform/graphics/chromium/IconChromiumLinux.cpp: Removed.
* platform/graphics/chromium/IconChromiumMac.cpp: Removed.
* platform/graphics/chromium/IconChromiumWin.cpp: Removed.
* platform/graphics/chromium/PlatformIcon.h:
2011-01-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move search functions from SourceView to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=52895
This is the last step before eliminating SourceView and ScriptView since
this classes just delegate everything to SourceFrame.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.set visible):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype.searchCanceled):
(WebInspector.SourceFrame.prototype.jumpToFirstSearchResult):
(WebInspector.SourceFrame.prototype.jumpToLastSearchResult):
(WebInspector.SourceFrame.prototype.jumpToNextSearchResult):
(WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult):
(WebInspector.SourceFrame.prototype.showingFirstSearchResult):
(WebInspector.SourceFrame.prototype.showingLastSearchResult):
(WebInspector.SourceFrame.prototype._jumpToSearchResult):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.hide):
(WebInspector.SourceView.prototype.searchCanceled):
(WebInspector.SourceView.prototype.performSearch):
(WebInspector.SourceView.prototype.jumpToFirstSearchResult):
(WebInspector.SourceView.prototype.jumpToLastSearchResult):
(WebInspector.SourceView.prototype.jumpToNextSearchResult):
(WebInspector.SourceView.prototype.jumpToPreviousSearchResult):
(WebInspector.SourceView.prototype.showingFirstSearchResult):
(WebInspector.SourceView.prototype.showingLastSearchResult):
(WebInspector.SourceView.prototype.clearMessages):
2011-01-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76463.
http://trac.webkit.org/changeset/76463
https://bugs.webkit.org/show_bug.cgi?id=52993
It broke canvas/philip/tests/2d.path.stroke.skew.html
(Requested by Ossy on #webkit).
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArc):
2011-01-23 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: summary bar is not resized properly with the rest of network panel
https://bugs.webkit.org/show_bug.cgi?id=52881
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.updateSidebarWidth):
(WebInspector.NetworkPanel.prototype._positionSummaryBar):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
2011-01-19 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Space and tab characters "sent" by an input method give totally different results than typing them directly
https://bugs.webkit.org/show_bug.cgi?id=5241
* Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to
distinguish text input which is originated by composition.
* Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing
range of string on text node, instead of surrounding part of that.
Test: editing/inserting/insert-composition-whitespace.html
* dom/TextEvent.h:
(WebCore::TextEvent::isComposition):
* dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
* editing/CompositeEditCommand.cpp:
(WebCore::containsOnlyWhitespace):
(WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor):
(WebCore::CompositeEditCommand::canRebalance):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
* editing/CompositeEditCommand.h:
* editing/Editor.cpp:
(WebCore::Editor::insertTextForConfirmedComposition): Added.
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition().
(WebCore::Editor::setComposition):
* editing/Editor.h:
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
* editing/InsertTextCommand.h:
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertTextRunWithoutNewlines):
* editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType
(WebCore::TypingCommand::setCompositionType): Added.
(WebCore::TypingCommand::create):
2011-01-23 Mark Rowe <mrowe@apple.com>
Follow-up to r76477.
Fix the scripts that detect problematic code such as static initializers
and destructors, weak vtables, inappropriate files in the framework wrappers,
and public headers including private headers. These had all been broken
since the projects were moved in to the Source directory as the paths to the
scripts were not updated at that time.
Stop copying an IDL file in to the framework wrapper. Doing that doesn't even make sense.
* WebCore.xcodeproj/project.pbxproj:
2011-01-23 Mark Rowe <mrowe@apple.com>
Build fix after r76459.
Static member variables or globals of types that have constructors or destructors are bad as
they generate static initializers and destructors. This is code that is run either at link time
when the library is loaded in to memory or at application termination time. Both of these are
terrible for performance and are thus outlawed in WebKit code.
The typical solution is to replace the static member or global with a function that allocates
the necessary variable on the heap. The variable is leaked to prevent it from being destroyed
at application termination time. The DEFINE_STATIC_LOCAL macro wraps this in to a concise little
package, but sadly fails to work in this case due to the type containing multiple template
parameters.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::inspectorAgents):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::bindInspectorAgent):
(WebCore::InspectorInstrumentation::unbindInspectorAgent):
(WebCore::InspectorInstrumentation::inspectorAgentForPage):
2011-01-21 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add support for -webkit-mask properties to the
accelerated compositing path.
https://bugs.webkit.org/show_bug.cgi?id=49780
Tests: Existing tests in LayoutTests/compositing/masks
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::draw):
(WebCore::ContentLayerChromium::unreserveContentsTexture):
(WebCore::ContentLayerChromium::bindContentsTexture):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setMaskLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::maskLayer):
(WebCore::LayerChromium::unreserveContentsTexture):
(WebCore::LayerChromium::bindContentsTexture):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayersRecursive):
* platform/graphics/chromium/LayerTexture.cpp:
(WebCore::LayerTexture::bindTexture):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::SharedValues::SharedValues):
(WebCore::RenderSurfaceChromium::SharedValues::~SharedValues):
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderProgram):
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderSamplerLocation):
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderMaskSamplerLocation):
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderMatrixLocation):
(WebCore::RenderSurfaceChromium::SharedValues::maskShaderAlphaLocation):
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Use WTF::StringHasher in WebCore
https://bugs.webkit.org/show_bug.cgi?id=52934
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::urlHostHash):
* platform/LinkHash.cpp:
(WebCore::visitedLinkHashInline):
* platform/cf/BinaryPropertyList.cpp:
(WebCore::IntegerArrayHash::hash):
* platform/graphics/wx/FontPlatformDataWx.cpp:
(WebCore::FontPlatformData::computeHash):
* platform/network/ProtectionSpaceHash.h:
(WebCore::ProtectionSpaceHash::hash):
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Add an overload to base64Encode with String output
https://bugs.webkit.org/show_bug.cgi?id=50122
This change removes duplicated code.
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::resourceContentBase64):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::btoa):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
* platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createUniqueFontName):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::encodeBasicAuthorization):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::encodeBasicAuthorization):
* platform/text/Base64.cpp:
(WebCore::base64Encode):
* platform/text/Base64.h:
(WebCore::base64Encode):
* platform/wince/KeygenWinCE.cpp:
(WebCore::WebCore::signedPublicKeyAndChallengeString):
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Add String::containsOnlyLatin1()
https://bugs.webkit.org/show_bug.cgi?id=52979
Use String::containsOnlyLatin1() instead of isSafeToConvertCharList().
* page/DOMWindow.cpp:
(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):
2011-01-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Add missing CodeGenerator dependencies
https://bugs.webkit.org/show_bug.cgi?id=52976
* CMakeLists.txt:
2011-01-23 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][Symbian] Fix --minimal build
https://bugs.webkit.org/show_bug.cgi?id=52839
Some of the plugins' functionality is reimplemented in
Symbian specific files.
Some of this functionality should be compiled in even if
the guard NETSCAPE_PLUGIN_API is turned off.
This patch moves that functionality out of the
NETSCAPE_PLUGIN_API guard.
Build fix so no new tests.
* WebCore.pro:
* plugins/symbian/PluginPackageSymbian.cpp:
2011-01-23 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Use rad2deg() from WTF instead of rolling our own.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArc):
2011-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Viewport meta: Always adjust device dimensions to the device pixel ratio.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
2011-01-23 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Don't scale absolute geometry specified by viewport meta tag.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
2011-01-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
Web Inspector: looks like efl doesn't regenerate InspectorBackendDispatcher.
Touch Inspector.idl.
* inspector/Inspector.idl:
2011-01-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: next step in splitting InspectorController.
Splitting InspectorController is a bit tricky process.
As a first step I'll do the next things:
1) rename existing InspectorController to InspectorAgent;
2) s/nspectorController/nspectorAgent/g everywhere in WebCore/inspector but InspectorInstrumentation;
3) create a fake InspectorController derived from the InspectorAgent for the rest of WebCore and WebKit;
The second step is a migration of a small set of functions described in bug 52510 from InspectorAgent to InspectorController.
As far as the second step will have significant changes in the functions' implementation I'll do it as a separate patch.
https://bugs.webkit.org/show_bug.cgi?id=52955
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::nodeForId):
(WebCore::JSInjectedScriptHost::selectDOMStorage):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::nodeForIdCallback):
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::clearConsoleMessages):
(WebCore::InjectedScriptHost::databaseForId):
(WebCore::InjectedScriptHost::selectDatabase):
(WebCore::InjectedScriptHost::selectDOMStorage):
(WebCore::InjectedScriptHost::injectedScriptForMainFrame):
(WebCore::InjectedScriptHost::inspectorDOMAgent):
(WebCore::InjectedScriptHost::frontend):
(WebCore::InjectedScriptHost::didCreateWorker):
(WebCore::InjectedScriptHost::didDestroyWorker):
* inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::inspectorAgent):
(WebCore::InjectedScriptHost::disconnectController):
* inspector/InspectorAgent.cpp: Copied from Source/WebCore/inspector/InspectorController.cpp.
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::~InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::enabled):
(WebCore::InspectorAgent::inspectorStartsAttached):
(WebCore::InspectorAgent::setInspectorStartsAttached):
(WebCore::InspectorAgent::setInspectorAttachedHeight):
(WebCore::InspectorAgent::inspectorAttachedHeight):
(WebCore::InspectorAgent::searchingForNodeInPage):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::inspect):
(WebCore::InspectorAgent::focusNode):
(WebCore::InspectorAgent::highlight):
(WebCore::InspectorAgent::highlightDOMNode):
(WebCore::InspectorAgent::highlightFrame):
(WebCore::InspectorAgent::hideHighlight):
(WebCore::InspectorAgent::mouseDidMoveOverElement):
(WebCore::InspectorAgent::handleMousePress):
(WebCore::InspectorAgent::setInspectorFrontendClient):
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
(WebCore::InspectorAgent::setSearchingForNode):
(WebCore::InspectorAgent::connectFrontend):
(WebCore::InspectorAgent::show):
(WebCore::InspectorAgent::showPanel):
(WebCore::InspectorAgent::close):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::resourceAgent):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::pushDataCollectedOffline):
(WebCore::InspectorAgent::restoreDebugger):
(WebCore::InspectorAgent::restoreProfiler):
(WebCore::InspectorAgent::unbindAllResources):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::mainResourceFiredDOMContentEvent):
(WebCore::InspectorAgent::mainResourceFiredLoadEvent):
(WebCore::InspectorAgent::isMainResourceLoader):
(WebCore::InspectorAgent::willSendRequest):
(WebCore::InspectorAgent::ensureSettingsLoaded):
(WebCore::InspectorAgent::startTimelineProfiler):
(WebCore::InspectorAgent::stopTimelineProfiler):
(WebCore::PostWorkerNotificationToFrontendTask::create):
(WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask):
(WebCore::PostWorkerNotificationToFrontendTask::performTask):
(WebCore::InspectorAgent::postWorkerNotificationToFrontend):
(WebCore::InspectorAgent::didCreateWorker):
(WebCore::InspectorAgent::didDestroyWorker):
(WebCore::InspectorAgent::didOpenDatabase):
(WebCore::InspectorAgent::getCookies):
(WebCore::InspectorAgent::buildArrayForCookies):
(WebCore::InspectorAgent::buildObjectForCookie):
(WebCore::InspectorAgent::deleteCookie):
(WebCore::InspectorAgent::didUseDOMStorage):
(WebCore::InspectorAgent::didCreateWebSocket):
(WebCore::InspectorAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorAgent::didCloseWebSocket):
(WebCore::InspectorAgent::isRecordingUserInitiatedProfile):
(WebCore::InspectorAgent::startUserInitiatedProfiling):
(WebCore::InspectorAgent::stopUserInitiatedProfiling):
(WebCore::InspectorAgent::profilerEnabled):
(WebCore::InspectorAgent::enableProfiler):
(WebCore::InspectorAgent::disableProfiler):
(WebCore::InspectorAgent::showAndEnableDebugger):
(WebCore::InspectorAgent::enableDebugger):
(WebCore::InspectorAgent::disableDebugger):
(WebCore::InspectorAgent::resume):
(WebCore::InspectorAgent::setAllBrowserBreakpoints):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::didEvaluateForTestInFrontend):
(WebCore::quadToPath):
(WebCore::drawOutlinedQuad):
(WebCore::drawOutlinedQuadWithClip):
(WebCore::drawHighlightForBox):
(WebCore::drawHighlightForLineBoxesOrSVGRenderer):
(WebCore::convertFromFrameToMainFrame):
(WebCore::frameToMainFrameOffset):
(WebCore::InspectorAgent::drawNodeHighlight):
(WebCore::InspectorAgent::drawElementTitle):
(WebCore::InspectorAgent::openInInspectedWindow):
(WebCore::InspectorAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorAgent::removeAllScriptsToEvaluateOnLoad):
(WebCore::InspectorAgent::setInspectorExtensionAPI):
(WebCore::InspectorAgent::inspectedURL):
(WebCore::InspectorAgent::reloadPage):
(WebCore::InspectorAgent::setExtraHeaders):
* inspector/InspectorAgent.h: Copied from Source/WebCore/inspector/InspectorController.h.
(WebCore::InspectorAgent::inspectorBackendDispatcher):
(WebCore::InspectorAgent::inspectorClient):
(WebCore::InspectorAgent::injectedScriptHost):
(WebCore::InspectorAgent::inspectedPage):
(WebCore::InspectorAgent::hideDOMNodeHighlight):
(WebCore::InspectorAgent::hideFrameHighlight):
(WebCore::InspectorAgent::frontend):
(WebCore::InspectorAgent::inspectorController):
(WebCore::InspectorAgent::inspectorAgent):
(WebCore::InspectorAgent::consoleAgent):
(WebCore::InspectorAgent::cssAgent):
(WebCore::InspectorAgent::domAgent):
(WebCore::InspectorAgent::injectedScriptAgent):
(WebCore::InspectorAgent::runtimeAgent):
(WebCore::InspectorAgent::timelineAgent):
(WebCore::InspectorAgent::databaseAgent):
(WebCore::InspectorAgent::domStorageAgent):
(WebCore::InspectorAgent::fileSystemAgent):
(WebCore::InspectorAgent::browserDebuggerAgent):
(WebCore::InspectorAgent::debuggerAgent):
(WebCore::InspectorAgent::profilerAgent):
(WebCore::InspectorAgent::applicationCacheAgent):
(WebCore::InspectorAgent::hasInspectorFrontendClient):
(WebCore::InspectorAgent::hasFrontend):
(WebCore::InspectorAgent::startProfiling):
(WebCore::InspectorAgent::stopProfiling):
(WebCore::InspectorAgent::debuggerEnabled):
(WebCore::InspectorAgent::state):
(WebCore::InspectorAgent::settings):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorBrowserDebuggerAgent.h:
(WebCore::InspectorBrowserDebuggerAgent::create):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::create):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::stop):
(WebCore::InspectorFileSystemAgent::getFileSystemPathAsync):
(WebCore::InspectorFileSystemAgent::didGetFileSystemPath):
(WebCore::InspectorFileSystemAgent::didGetFileSystemError):
* inspector/InspectorFileSystemAgent.h:
(WebCore::InspectorFileSystemAgent::create):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::setExtensionAPI):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
(WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
* inspector/InspectorProfilerAgent.h:
2011-01-22 Chris Rogers <crogers@google.com>
Rubber-stamped by Anders Carlsson.
Fix FFTFrameStub to compile properly
https://bugs.webkit.org/show_bug.cgi?id=52969
No new tests since this is a build fix.
* platform/audio/FFTFrameStub.cpp:
(WebCore::FFTFrame::FFTFrame):
2011-01-22 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IndexedDB corrupts data on disk
https://bugs.webkit.org/show_bug.cgi?id=52890
We need to store the SerializedScriptValues on disk in a BLOB column rather than TEXT.
Test: storage/indexeddb/data-corruption.html
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindBlob):
(WebCore::SQLiteStatement::getColumnBlobAsString):
(WebCore::SQLiteStatement::getColumnBlobAsVector):
* platform/sql/SQLiteStatement.h:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::loadCurrentRow):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::runCommands):
(WebCore::createTables):
(WebCore::createMetaDataTable):
(WebCore::migrateDatabase):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::putObjectStoreData):
2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix WinCE build.
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawText):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960
SimpleFontDataMac.mm contains a hack to modifiy lineGap/descent for the 'Hiragino' font.
That didn't influence the lineSpacing so far, but does now, causing regressions.
Restore old line spacing behaviour to fix the regression.
Covered by existing fast/blockflow, fast/repaint and fast/text/international test cases.
* platform/graphics/FontMetrics.h:
(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::floatLineSpacing):
(WebCore::FontMetrics::setLineSpacing):
(WebCore::FontMetrics::lineSpacing):
(WebCore::FontMetrics::reset):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/haiku/SimpleFontDataHaiku.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/pango/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont):
* platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformInit):
2011-01-22 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] fast/backgrounds/svg-as-mask.html fails
https://bugs.webkit.org/show_bug.cgi?id=52906
Transparency layers should start out with in SourceOver mode with
alpha 1.0 (modeled after CGContextBeginTransparencyLayer.)
* platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):
2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
Fix Chromium/Win build.
* platform/graphics/chromium/UniscribeHelperTextRun.cpp: s/->/./
(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
Encapsulate ascent/descent/lineHeight/lineGap methods in a single FontMetrics class, instead of
having to define them in both Font & SimpleFontData. Changed to store floating point values
as default, in order to get accurate information for small sized fonts. All these methods
now have floating-point and integer versions. Whenever an integer variant of these functions
is called, lroundf() is used to round the value.
This makes it possible to support small font-sizes for SVG in a follow-up patch, as well
as fixing rounding issues when using SVG Fonts.
Shouldn't affect existing tests.
* GNUmakefile.am: Add FontMetrics.h to build.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
(baselinePositionForAccessibilityRenderObject):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
* html/canvas/CanvasRenderingContext2D.cpp: Ditto.
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* inspector/InspectorController.cpp: Ditto.
(WebCore::InspectorController::drawElementTitle):
* platform/chromium/PopupMenuChromium.cpp: Ditto.
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):
* platform/graphics/Font.h: Remove ascent/descent/height/lineGap/lineSpacing/xHeight/unitsPerEm accessor...
(WebCore::Font::fontMetrics): ... and only expose a single FontMetrics object here.
* platform/graphics/FontFastPath.cpp: Use fontMetrics() to query metrics information.
(WebCore::Font::emphasisMarkAscent):
(WebCore::Font::emphasisMarkDescent):
(WebCore::Font::emphasisMarkHeight):
(WebCore::Font::floatWidthForSimpleText):
* platform/graphics/FontMetrics.h: Added.
(WebCore::FontMetrics::FontMetrics): Creates a FontMetrics object, stored in SimpleFontData.
(WebCore::FontMetrics::unitsPerEm): Returns an unsigned describing the unitsPerEm.
(WebCore::FontMetrics::setUnitsPerEm): Sets the unitsPerEm value.
(WebCore::FontMetrics::floatAscent): Returns the stored m_ascent float.
(WebCore::FontMetrics::setAscent): Sets the stored m_ascent float.
(WebCore::FontMetrics::floatDescent): Returns the stored m_descent float.
(WebCore::FontMetrics::setDescent): Sets the stored m_descent float.
(WebCore::FontMetrics::floatHeight): Returns floatAscent() + floatDescent().
(WebCore::FontMetrics::floatLineGap): Returns the stored m_lineGap float.
(WebCore::FontMetrics::setLineGap): Sets the stored m_lineGap float.
(WebCore::FontMetrics::floatLineSpacing): Returns the stored m_lineSpacing float.
(WebCore::FontMetrics::setLineSpacing): Sets the stored m_lineSpacing float.
(WebCore::FontMetrics::xHeight): Returns the stored m_xHeight float (no integer version available, hence no 'float' prefix).
(WebCore::FontMetrics::setXHeight): Sets the stored m_xHeight float.
(WebCore::FontMetrics::ascent): Returns a rounded version of ascent().
(WebCore::FontMetrics::descent): Ditto (for descent).
(WebCore::FontMetrics::height): Returns ascent() + descent().
(WebCore::FontMetrics::lineGap): Returns a rounded version of lineGap().
(WebCore::FontMetrics::lineSpacing): Ditto (for lineSpacing).
(WebCore::FontMetrics::reset): Nulls all members, used only by the platform variants of SimpleFontData.
* platform/graphics/SimpleFontData.cpp: Adapt SVG Fonts code, to initialize the FontMetrics object, as the m_ascent/etc.. members are gone.
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::initCharWidths):
* platform/graphics/SimpleFontData.h: Remove ascent/descent/height/lineSpacing/lineGap/xHeight/unitsPerEm accessors, and members, just store a FontMetrics object and expose it.
(WebCore::SimpleFontData::fontMetrics):
(WebCore::SimpleFontData::avgCharWidth):
* platform/graphics/chromium/FontChromiumWin.cpp: Use fontMetrics() to query font metrics.
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/chromium/SimpleFontDataLinux.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/chromium/UniscribeHelperTextRun.cpp: Use fontMetrics() to query font metrics.
(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
(WebCore::UniscribeHelperTextRun::nextWinFontData):
* platform/graphics/freetype/SimpleFontDataFreeType.cpp: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/haiku/SimpleFontDataHaiku.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/mac/FontComplexTextMac.cpp: Use fontMetrics() to query font metrics.
(WebCore::Font::floatWidthForComplexText):
* platform/graphics/mac/FontMac.mm: Ditto.
(WebCore::showGlyphsWithAdvances):
* platform/graphics/mac/SimpleFontDataMac.mm: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
* platform/graphics/pango/SimpleFontDataPango.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/qt/SimpleFontDataQt.cpp: Ditto. (+ Switch to QFontMetricsF to get floating-point accurancy.)
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/FontCGWin.cpp: Use fontMetrics() to query font metrics.
(WebCore::drawGDIGlyphs):
* platform/graphics/win/FontWin.cpp: Ditto.
(WebCore::Font::floatWidthForComplexText):
* platform/graphics/win/SimpleFontDataCGWin.cpp: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
* platform/graphics/win/SimpleFontDataCairoWin.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataWin.cpp: Ditto.
(WebCore::SimpleFontData::initGDIFont):
* platform/graphics/wince/GraphicsContextWinCE.cpp: Use fontMetrics() to query font metrics.
(WebCore::GraphicsContext::drawText):
* platform/graphics/wince/SimpleFontDataWinCE.cpp: Adapt platform code, to initialize the FontMetrics object.
(WebCore::SimpleFontData::platformInit):
* platform/graphics/wx/SimpleFontDataWx.cpp: Ditto.
(WebCore::SimpleFontData::platformInit):
* platform/win/PopupMenuWin.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
* rendering/EllipsisBox.cpp: Ditto.
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/InlineBox.cpp: Ditto.
(WebCore::InlineBox::logicalHeight):
* rendering/InlineFlowBox.cpp: Ditto.
(WebCore::verticalPositionForBox):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
* rendering/InlineTextBox.cpp: Ditto.
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
* rendering/RenderBlock.cpp: Ditto.
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
* rendering/RenderBox.cpp: Ditto.
(WebCore::RenderBox::localCaretRect):
* rendering/RenderEmbeddedObject.cpp: Ditto.
(WebCore::RenderEmbeddedObject::paintReplaced):
* rendering/RenderImage.cpp: Ditto.
(WebCore::RenderImage::setImageSizeForAltText):
(WebCore::RenderImage::paintReplaced):
* rendering/RenderInline.cpp: Ditto.
(WebCore::RenderInline::baselinePosition):
* rendering/RenderListBox.cpp: Ditto.
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::itemHeight):
* rendering/RenderListMarker.cpp: Ditto.
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::getRelativeMarkerRect):
* rendering/RenderTextControl.cpp: Ditto.
(WebCore::RenderTextControl::paintPlaceholder):
* rendering/RenderTextControlSingleLine.cpp: Ditto.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
* rendering/RenderThemeWin.cpp: Ditto.
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
* rendering/mathml/RenderMathMLFraction.cpp: Ditto.
(WebCore::RenderMathMLFraction::baselinePosition):
* rendering/style/RenderStyle.h: Add "const FontMetrics& fontMetrics() const" accessor.
(WebCore::InheritedFlags::fontMetrics):
(WebCore::InheritedFlags::computedLineHeight):
* rendering/svg/RenderSVGInlineText.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
(WebCore::RenderSVGInlineText::positionForPoint):
* rendering/svg/SVGInlineTextBox.cpp: Ditto.
(WebCore::SVGInlineTextBox::selectionRectForTextFragment):
(WebCore::positionOffsetForDecoration):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
(WebCore::SVGInlineTextBox::paintTextWithShadows):
(WebCore::SVGInlineTextBox::calculateBoundaries):
* rendering/svg/SVGTextLayoutEngineBaseline.cpp: Ditto.
(WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
(WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift):
(WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
* rendering/svg/SVGTextLayoutEngineSpacing.cpp: Ditto.
(WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
* rendering/svg/SVGTextMetrics.cpp: Ditto.
(WebCore::SVGTextMetrics::SVGTextMetrics):
* rendering/svg/SVGTextQuery.cpp: Ditto.
(WebCore::calculateGlyphBoundaries):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::unitsPerEm): Rename defaultUnitsPerEm global to gDefaultUnitsPerEm.
* svg/SVGLength.cpp: Use style->fontMetrics() instead of style->font() to access the metrics.
(WebCore::SVGLength::convertValueFromUserUnitsToEXS):
(WebCore::SVGLength::convertValueFromEXSToUserUnits):
2011-01-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Stop instantiating legacy editing positions in VisibleSelection, visible_units.cpp, Frame, and RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=52759
Stopped instantiating legacy editing positions in the following files.
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
* editing/visible_units.cpp:
(WebCore::previousBoundary):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
(WebCore::startOfBlock):
* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
* rendering/RenderBlock.cpp: Removed RenderBlock::positionForRenderer because it was not called anywhere.
* rendering/RenderBlock.h: Ditto.
2011-01-22 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Fix compositor repaints for offscreen fixed elements
https://bugs.webkit.org/show_bug.cgi?id=52681
The fast path scrolling was clipping offscreen invalidations.
Additionally, the compositor was ignoring all invalidations that were
entirely out of the content rect.
Test: compositing/ to verify this caused no regressions.
Tested fix manually in browser as I could not generate a LayoutTest that reproduced the bug in run-webkit-tests.
* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
2011-01-22 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging
* page/PrintContext.cpp: (WebCore::PrintContext::spoolRect): Use a correct offset to actually
draw inside the requested rectangle.
2011-01-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903
In case of an exception in a script from different domain only generic message
will be passed to window.onerror hander.
Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html
http/tests/security/cross-origin-script-window-onerror.html
* bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all
cross origin checks agains real script URL, not the original URL which may have resulted in a sequence
of redirects to different domains.
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
* bindings/v8/ScriptSourceCode.h: same for v8.
(WebCore::ScriptSourceCode::url):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot
access provide concise "Script error." message without any information about the error source. This is
what Firefox does in this case.
2011-01-21 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Always set composition mode through GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=52940
GraphicsContext tracks the current composition mode so we should
never call through to the QPainter directly.
* platform/graphics/GraphicsContext.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::toQtCompositionMode): Changed this method to a static inline
since it's only used by GraphicsContextQt.cpp now.
* platform/graphics/qt/ImageQt.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
2011-01-21 Dan Bernstein <mitz@apple.com>
Reviewed by Adele Peterson.
Inconsistent handling of no-break space in justification logic
https://bugs.webkit.org/show_bug.cgi?id=52938
Test: fast/text/justify-nbsp.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Count no-break space as a
space when computing the distribution of space between text boxes on the line.
2011-01-21 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Adds sanity checks to help diagnose the crash.
* loader/HistoryController.cpp:
2011-01-21 Andreas Kling <kling@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] Let QPainter decide whether a composition mode is supported or not
Lacking Porter-Duff support in the paint engine shouldn't exclude the
Source and Source-Over modes (and has nothing to do with the blend
and raster-op modes.)
Delegate this decision to QPainter instead (this will cause warnings
if an unsupported mode is used, but that's a good thing.)
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
fix audio build: header file should be "Noncopyable.h" and not "NonCopyable.h"
https://bugs.webkit.org/show_bug.cgi?id=52933
No new tests since this just fixes the build
* webaudio/RealtimeAnalyser.h:
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix audio build: change ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52928
No new tests since audio API is not yet implemented.
* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::AudioBus::loadPlatformResource):
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add FFTFrameStub to avoid link errors during bringup on platforms without an FFT implementation
https://bugs.webkit.org/show_bug.cgi?id=52922
No new tests since audio API is not yet implemented.
* WebCore.gypi:
* platform/audio/FFTFrameStub.cpp: Added.
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
2011-01-21 Tony Chang <tony@chromium.org>
Reviewed by Sam Weinig.
reduce number of FrameLoaderClient::didChangeScrollOffset calls
https://bugs.webkit.org/show_bug.cgi?id=52915
Only notify of changes in scroll offset when there actually is a change.
This regressed in r76291.
Covered by Chromium browser_tests.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
2011-01-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ~InspectorResourceAgent crashes on closing inspected page.
https://bugs.webkit.org/show_bug.cgi?id=52900
* inspector/InspectorController.cpp:
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741
No new tests since audio API is not yet implemented.
* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebkitAudioContextEnabled):
(WebCore::RuntimeEnabledFeatures::webkitAudioContextEnabled):
* page/DOMWindow.idl:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setWebAudioEnabled):
* page/Settings.h:
(WebCore::Settings::webAudioEnabled):
2011-01-21 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155
Move menulist rendering to RenderThemeGtk and correct padding code
for separators in menulists.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::RenderThemeGtk): Initialize new widget members.
(WebCore::RenderThemeGtk::getComboBoxSeparatorWidth): Added.
(WebCore::RenderThemeGtk::comboBoxArrowSize): Added.
(WebCore::getButtonInnerBorder): Added.
(WebCore::RenderThemeGtk::getComboBoxPadding): Do this manually instead of using
Mozilla code.
(WebCore::RenderThemeGtk::paintMenuList): Ditto.
(WebCore::setupWidget): Abstracted this part of the setupWidgetAndAddToContainer
out to handle child widgets of comboboxes.
(WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Abstracted out setupWidget.
(WebCore::RenderThemeGtk::gtkContainer): Added.
(WebCore::getGtkComboBoxButton): Added.
(WebCore::getGtkComboBoxPieces): Added.
(WebCore::RenderThemeGtk::gtkComboBox): Call setupWidget here.
(WebCore::RenderThemeGtk::refreshComboBoxChildren): Added.
(WebCore::RenderThemeGtk::gtkComboBoxButton): Added.
(WebCore::RenderThemeGtk::gtkComboBoxArrow): Added.
(WebCore::RenderThemeGtk::gtkComboBoxSeparator): Added.
* platform/gtk/RenderThemeGtk.h: Added new members and methods.
* platform/gtk/WidgetRenderingContext.h: Added new members and methods.
* platform/gtk/WidgetRenderingContextGtk2.cpp:
(WebCore::WidgetRenderingContext::gtkPaintArrow):
(WebCore::WidgetRenderingContext::gtkPaintVLine):
* platform/gtk/WidgetRenderingContextGtk3.cpp:
(WebCore::WidgetRenderingContext::gtkPaintArrow):
(WebCore::WidgetRenderingContext::gtkPaintVLine):
* platform/gtk/gtk2drawing.c: Removed code for drawing menulists and buttons.
(moz_gtk_init):
(moz_gtk_get_widget_border):
(moz_gtk_widget_paint):
* platform/gtk/gtk3drawing.c:
(moz_gtk_init):
(moz_gtk_get_widget_border):
(moz_gtk_widget_paint):
* platform/gtk/gtkdrawing.h:
2011-01-21 Sam Weinig <sam@webkit.org>
Fix chromium mac build.
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
2011-01-21 Sam Weinig <sam@webkit.org>
Fix the windows build.
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add chromium bundled audio spatialization resources to WebAudio.grd
https://bugs.webkit.org/show_bug.cgi?id=52651
No new tests since audio API is not yet implemented.
* WebCore.gyp/WebCore.gyp:
* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::AudioBus::loadPlatformResource):
2011-01-21 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
https://bugs.webkit.org/show_bug.cgi?id=52826
* platform/chromium/ChromiumBridge.h:
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::getWebThemeState):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):
* rendering/RenderThemeChromiumLinux.h:
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::setCheckboxSize):
(WebCore::RenderThemeChromiumSkia::setSizeIfAuto):
(WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor):
* rendering/RenderThemeChromiumSkia.h:
2011-01-21 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
https://bugs.webkit.org/show_bug.cgi?id=52779
Rename ScrollbarClient -> ScrollableArea.
- Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea
since that was its only use case.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::setValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* page/FrameView.h:
* platform/PopupMenuClient.h:
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::notityPositionChanged):
* platform/ScrollAnimator.h:
* platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
(WebCore::ScrollAnimatorWin::scroll):
* platform/ScrollAnimatorWin.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp.
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::~ScrollableArea):
(WebCore::ScrollableArea::scroll):
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
* platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::createNativeScrollbar):
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::isWindowActive):
(WebCore::Scrollbar::invalidateRect):
(WebCore::Scrollbar::convertToContainingView):
(WebCore::Scrollbar::convertFromContainingView):
* platform/Scrollbar.h:
(WebCore::Scrollbar::disconnectFromScrollableArea):
(WebCore::Scrollbar::scrollableArea):
* platform/ScrollbarClient.cpp: Removed.
* platform/ScrollbarClient.h: Removed.
* platform/ScrollbarThemeComposite.cpp:
* platform/chromium/FramelessScrollView.h:
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
* platform/efl/ScrollbarEfl.cpp:
(Scrollbar::createNativeScrollbar):
(ScrollbarEfl::ScrollbarEfl):
(scrollbarEflEdjeMessage):
* platform/efl/ScrollbarEfl.h:
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::create):
(MainFrameScrollbarGtk::MainFrameScrollbarGtk):
(MainFrameScrollbarGtk::gtkValueChanged):
* platform/gtk/MainFrameScrollbarGtk.h:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::contextMenu):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::wndProc):
* platform/win/PopupMenuWin.h:
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):
* platform/wx/ScrollbarThemeWx.cpp:
(WebCore::ScrollbarThemeWx::paint):
* rendering/RenderDataGrid.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::scroll):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::destroyScrollbar):
* rendering/RenderListBox.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::createScrollbar):
* rendering/RenderMenuList.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):
* rendering/RenderScrollbar.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createScrollbar):
* rendering/RenderTextControlSingleLine.h:
2011-01-21 Darin Adler <darin@apple.com>
Fix Leopard build.
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::layout): Use ceilf instead of ceil.
2011-01-21 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
https://bugs.webkit.org/show_bug.cgi?id=52901
Test: fast/dom/htmlcollection-conversion-throws-exception.html
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getItem):
2011-01-21 Adam Roben <aroben@apple.com>
Separate flushing layer changes from rendering in CACFLayerTreeHost
Old model:
1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which schedules the
render timer.
3) The timer fires, which calls through to CACFLayerTreeHost::render, which performs the
flush and then renders.
New model:
1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which tells the new
LayerChangesFlusher singleton that this host has changes that need to be flushed.
3) LayerChangesFlusher sets up a Windows hook that will get called on the next iteration
of the message loop.
4) LayerChangesFlusher's hook is called, which calls through to
CACFLayerTreeHost::flushPendingLayerChangesNow.
5) CACFLayerTreeHost::flushPendingLayerChangesNow schedules the render timer so the changes
that were just flushed to the context will be rendered.
When a change is made to a PlatformCALayer that doesn't have a corresponding GraphicsLayer
(e.g., for rendering <video>), CACFLayerTreeHost::layerTreeDidChange takes care of
scheduling the flush.
This change has three advantages:
1) Whenever we flush layer changes, we first update layout. This can cause the page to
leave compositing mode, which in turn can cause all references to the CACFLayerTreeHost
to be dropped. By separating flushing (and thus updating layout) from rendering, we no
longer have to worry about this happen during rendering.
2) The new model is much more similar to how things work on the Mac, so will hopefully
reduce the number of platform-specific bugs.
3) CACFLayerTreeHost::shouldRender, which was used to make sure we didn't render while a
layout was pending, is no longer needed. It actually hasn't been needed since at least
r75987, but removing it before now would have resulted in a crash whenever a page came
out of compositing mode due to (1).
Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
CACFLayerTreeHost, but shouldn't be
Reviewed by Simon Fraser.
* WebCore.vcproj/WebCore.vcproj: Added LayerChangesFlusher.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include, sorted existing
#includes.
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::layerTreeDidChange): If we aren't already flushing changes,
schedule a flush. Removed the call to renderSoon(), which now happens when the flush is
finished.
(WebCore::CACFLayerTreeHost::destroyRenderer): Cancel any pending flush we had scheduled. Also
fixed a bug where we'd fail to clear the context's layer.
(WebCore::CACFLayerTreeHost::render): Removed code to ask the client if we should render, which
is no longer needed. Moved code to flush layer changes from here to
flushPendingLayerChangesNow, which is called via the above-described mechanism.
(WebCore::CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon): Schedule a flush. Removed
code to schedule a render, which now happens after we've flushed.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added. Some of this code came from
render(). First we flush GraphicsLayer changes from GraphicsLayers to their underlying
PlatformCALayers, then we flush changes from PlatformCALayers to the context, then we
schedule a render so that the changes will be rendered to the screen.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Removed
CACFLayerTreeHostClient::shouldRender. Added flushPendingLayerChangesNow and
m_isFlushingLayerChanges.
* platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
(WebCore::LayerChangesFlusher::shared):
(WebCore::LayerChangesFlusher::LayerChangesFlusher):
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookCallback):
(WebCore::LayerChangesFlusher::hookFired):
(WebCore::LayerChangesFlusher::setHook):
(WebCore::LayerChangesFlusher::removeHook):
* platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
(WebCore::LayerChangesFlusher::shared): Returns the singleton.
(WebCore::LayerChangesFlusher::LayerChangesFlusher): Initialize our members.
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): Add the host to the set of
hosts with changes that need to be flushed, and set up our hook if we haven't already.
(WebCore::LayerChangesFlusher::cancelPendingFlush): Remove the host from the set of hosts
with changes that need to be flushed. If we have no more such hosts, remove our hook, unless
we're currently in the process of calling out to our hosts, in which case we'll take care of
the hook once we're done calling out.
(WebCore::LayerChangesFlusher::hookCallback): This is the function that Windows calls when
our hook fires. Just calls through to hookFired on the singleton.
(WebCore::LayerChangesFlusher::hookFired): Tell all the hosts with changes that needed to be
flushed that it's time to flush. If no hosts re-added themselves to our set during this
process, remove our hook.
(WebCore::LayerChangesFlusher::setHook): Calls through to ::SetWindowsHookExW.
(WebCore::LayerChangesFlusher::removeHook): Calls through to ::UnhookWindowsHookEx.
* platform/graphics/ca/win/LayerChangesFlusher.h: Added.
2011-01-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
GraphicsLayer should be non-copyable
https://bugs.webkit.org/show_bug.cgi?id=52909
Use WTF_MAKE_NONCOPYABLE on GraphicsLayer, and WTF_MAKE_FAST_ALLOCATED
on that and KeyframeValueList.
* platform/graphics/GraphicsLayer.h:
2011-01-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Report the sized used by canvases and types arrays
https://bugs.webkit.org/show_bug.cgi?id=52856
Report the memory cost associated with canvas elements,
and typed arrays to JavaScript as extraCost, so that it
can figure this into its GC behavior.
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::toJSArrayBufferView): New templatized function, similar
to getDOMObjectWrapper() but calls reportExtraMemoryCost() with
the byteLength of the array.
* bindings/js/JSFloat32ArrayCustom.cpp:
(WebCore::toJS): Use toJSArrayBufferView.
* bindings/js/JSInt16ArrayCustom.cpp:
(WebCore::toJS): Use toJSArrayBufferView.
* bindings/js/JSInt32ArrayCustom.cpp:
(WebCore::toJS): Use toJSArrayBufferView.
* bindings/js/JSInt8ArrayCustom.cpp:
(WebCore::toJS): Use toJSArrayBufferView.
* bindings/js/JSUint16ArrayCustom.cpp:
(WebCore::toJS): Use toJSArrayBufferView.
* bindings/js/JSUint32ArrayCustom.cpp:
(WebCore::toJS): Use toJSArrayBufferView.
* bindings/js/JSUint8ArrayCustom.cpp:
(WebCore::toJS): Use toJSArrayBufferView.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer): Call heap.reportExtraMemoryCost()
with the size of the canvas backing store.
* html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::byteLength): byteLength needs to
be public.
* platform/graphics/ImageBuffer.h: Add dataSize() method.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::dataSize): Implement dataSize().
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::dataSize): Implement dataSize().
* platform/graphics/haiku/ImageBufferHaiku.cpp:
(WebCore::ImageBuffer::dataSize): Implement dataSize().
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::dataSize): Implement dataSize().
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::dataSize): Implement dataSize().
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::dataSize): Implement dataSize().
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::dataSize): Implement dataSize().
2011-01-21 Adam Roben <aroben@apple.com>
Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]
Also renamed a few functions and data members to match.
Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
Reviewed by Simon Fraser.
* WebCore.vcproj/WebCore.vcproj: Updated files' names and paths.
* WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include
path.
* WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h.
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
Updated for renames.
2011-01-21 Patrick Gansterer <paroga@paroga.com>
Original patch from François Sausset <sausset@gmail.com>
Reviewed by Darin Adler.
Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201
Replace unneeded doubles by floats and remove unneeded casts.
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint):
* rendering/mathml/RenderMathMLFraction.h:
2011-01-21 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r73618): Clicking on a search input causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=52905
The problem is caused by TextControlInnerElement being used both as
shadow root and an element in a shadow subtree. The code assumed it is
only used as a shadow root.
Since this code is all just workaround for in-progress conversion to
new shadow DOM, I am just adding a check. This code will disappear
completely once bug 52788 is fixed.
Test: fast/dom/search-shadow-host-crash.html
* dom/Node.cpp:
(WebCore::Node::setShadowHost): Added an ASSERT for early detection
of attempting to stomp on the parentNode.
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::detach): Added a check to only
clear shadow host if we have one.
2011-01-21 Adam Roben <aroben@apple.com>
Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"
This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
opposed to just "layer" because there are cases where we flush changes to CACFLayers that
don't have a corresponding GraphicsLayer.
Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
WKCACFLayerRenderer and friends is confusing
Reviewed by Simon Fraser.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::render):
Updated for renames.
(WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from
syncCompositingStateSoon, and updated for other renames.
* platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to
* m_shouldFlushPendingGraphicsLayerChanges.
(WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from
syncCompositingState.
2011-01-21 Adam Roben <aroben@apple.com>
Clean up PlatformCAAnimationWin
Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient
Reviewed by Simon Fraser.
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFFillModeType):
(fromCACFFillModeType):
(toCACFValueFunctionType):
(fromCACFValueFunctionType):
Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just
so we can later convert back to CFStringRef.
(toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the
results of CACFTimingFunctionCreate.
(PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through
WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED().
(PlatformCAAnimation::setFillMode):
(PlatformCAAnimation::setTimingFunction):
(PlatformCAAnimation::setValueFunction):
(PlatformCAAnimation::setTimingFunctions):
Updated for changes to the above conversion functions.
2011-01-21 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812
Most calls to stopAllLoaders now clear the history's provisional item(s).
We can now avoid resetting the back/forward state if a new navigation
is in progress.
Test: http/tests/navigation/back-twice-without-commit.html
Test: http/tests/navigation/forward-and-cancel.html
* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
* loader/FrameLoaderTypes.h:
* WebCore.exp.in: Update stopAllLoaders signature.
2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Show caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=52878
Test: manual-tests/password-caps-lock.html
* platform/gtk/KeyEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Implement
currentCapsLockState() using GDK API.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintCapsLockIndicator): Paint an icon
in the password field when the caps lock modifier is locked.
* platform/gtk/RenderThemeGtk.h:
2011-01-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent.
https://bugs.webkit.org/show_bug.cgi?id=52874
This is the first step of debugger api refactoring (see bug 52879).
JavaScript breakpoints are still in the same list as native breakpoints and are restored by InspectorBrowserDebuggerAgent.
The second step will be to move sticky JavaScript breakpoints to InspectorDebuggerAgent.
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::discardBindings):
(WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreInspectorStateFromCookie):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebugger):
(WebCore::InspectorController::resume):
(WebCore::InspectorController::inspectedURL):
* inspector/InspectorController.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
2011-01-21 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
Turn off uninitialized errors for ARM linux build.
https://bugs.webkit.org/show_bug.cgi?id=52893
Fix ARM compiler breakage.
* WebCore.gyp/WebCore.gyp:
2011-01-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] REGRESSION: Using the "Back" button
while profiling causes renderer crash.
https://bugs.webkit.org/show_bug.cgi?id=52808
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.
There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=52869
* inspector/InspectorController.cpp:
* inspector/InspectorController.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addProfileImpl):
(WebCore::InspectorInstrumentation::profilerEnabledImpl):
(WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::addProfile):
(WebCore::InspectorInstrumentation::profilerEnabled):
(WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
* page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
2011-01-12 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: breakpoints are restored incorrectly when reverting live edit.
https://bugs.webkit.org/show_bug.cgi?id=52300
Fix breakpoints restoring when reverting to old revision by using text diff.
Move live edit logic from ScriptsPanel to DebuggerModel.
Eliminate unnecessary editLine delegate in TextViewer.
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.reset):
(WebInspector.DebuggerModel.prototype.editScriptSource):
(WebInspector.DebuggerModel.prototype._updateScriptSource):
(WebInspector.DebuggerModel.prototype.get callFrames):
(WebInspector.DebuggerModel.prototype.pausedScript):
(WebInspector.DebuggerModel.prototype.resumedScript):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.get source):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
(WebInspector.SourceFrame.prototype._doubleClick.didEditLine):
(WebInspector.SourceFrame.prototype._doubleClick):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype._handleKeyDown):
(WebInspector.TextViewer.prototype.editLine.finishEditing):
(WebInspector.TextViewer.prototype.editLine):
(WebInspector.TextChunk.prototype._createRow):
2011-01-21 Adam Klein <adamk@chromium.org>
Reviewed by Eric Seidel.
[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471
No tests added as this is a rename; no change in behavior.
* WebCore.gypi:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportFatalErrorInV8):
* page/PageGroup.cpp:
(WebCore::PageGroup::isLinkVisited):
* platform/android/PlatformBridge.h:
* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::createBusFromInMemoryAudioFile):
* platform/chromium/ChromiumBridge.h: Removed.
* platform/chromium/ChromiumDataObjectLegacy.cpp:
(WebCore::ChromiumDataObjectLegacy::getData):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::revealFolderInOS):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::fileExists):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):
* platform/chromium/LanguageChromium.cpp:
(WebCore::platformDefaultLanguage):
* platform/chromium/LinkHashChromium.cpp:
(WebCore::visitedLinkHash):
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
* platform/chromium/PlatformBridge.h:
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/chromium/ReadableDataObject.cpp:
(WebCore::ReadableDataObject::getData):
(WebCore::ReadableDataObject::urlTitle):
(WebCore::ReadableDataObject::htmlBaseUrl):
(WebCore::ReadableDataObject::filenames):
(WebCore::ReadableDataObject::ensureTypeCacheInitialized):
* platform/chromium/SSLKeyGeneratorChromium.cpp:
(WebCore::signedPublicKeyAndChallengeString):
* platform/chromium/ScrollbarThemeChromium.cpp:
* platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
* platform/chromium/SharedTimerChromium.cpp:
(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireTime):
(WebCore::stopSharedTimer):
* platform/chromium/SuddenTerminationChromium.cpp:
(WebCore::disableSuddenTermination):
(WebCore::enableSuddenTermination):
* platform/chromium/SystemTimeChromium.cpp:
(WebCore::currentTime):
* platform/chromium/WritableDataObject.cpp:
(WebCore::WritableDataObject::setData):
* platform/graphics/chromium/CrossProcessFontLoading.mm:
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::scriptFontProperties):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::querySystemForRenderStyle):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* platform/graphics/chromium/ImageChromium.cpp:
(WebCore::Image::loadPlatformResource):
* platform/graphics/chromium/ImageChromiumMac.mm:
(WebCore::Image::loadPlatformResource):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
(WebCore::UniscribeHelperTextRun::tryToPreloadFont):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/network/chromium/CookieJarChromium.cpp:
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
* platform/network/chromium/DNSChromium.cpp:
(WebCore::prefetchDNS):
* platform/qt/PlatformBridge.h:
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(chromiumOpen):
(chromiumDelete):
(chromiumAccess):
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::PluginCache::plugins):
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):
* storage/chromium/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
(WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
* storage/chromium/IDBKeyPathBackendImpl.cpp:
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
2011-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76335.
http://trac.webkit.org/changeset/76335
https://bugs.webkit.org/show_bug.cgi?id=52875
profiler tests were broken (Requested by loislo on #webkit).
* inspector/InspectorController.cpp:
(WebCore::InspectorController::addProfile):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):
* inspector/InspectorController.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
(WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
* page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
2011-01-21 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.
There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=52869
* inspector/InspectorController.cpp:
* inspector/InspectorController.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addProfileImpl):
(WebCore::InspectorInstrumentation::profilerEnabledImpl):
(WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::addProfile):
(WebCore::InspectorInstrumentation::profilerEnabled):
(WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
* page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
2011-01-20 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix failing tests from r76291.
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::updateScrollbars):
Take the scroll origin into account in more places.
2011-01-20 Kent Tamura <tkent@chromium.org>
Unreviewed, sorting an Xcode project file.
* WebCore.xcodeproj/project.pbxproj:
2011-01-20 Ben Vanik <ben.vanik@gmail.com>
Reviewed by Kenneth Russell.
Implementation of the OES_standard_derivatives WebGL extension.
https://bugs.webkit.org/show_bug.cgi?id=51678
Changes are modeled off of the existing OESTextureFloat extension. New files,
extension retrieval, etc all match the existing code.
Changed ANGLEWebKitBridge to allow for multiple sets of the ANGLE shader compiler
options. This supports the enabling of the standard derivatives flag when the
extension is enabled. Refactored the cleanup code to make the destruction of the
compilers (if they had been created) cleaner.
Tested with the WebGL conformance test:
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-standard-derivatives.html
Passes on WebKit/OSX, Chromium/OSX, and Chromium/Windows.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/OESStandardDerivatives.cpp: Added.
(WebCore::OESStandardDerivatives::OESStandardDerivatives):
(WebCore::OESStandardDerivatives::~OESStandardDerivatives):
(WebCore::OESStandardDerivatives::getName):
(WebCore::OESStandardDerivatives::create):
* html/canvas/OESStandardDerivatives.h: Added.
* html/canvas/OESStandardDerivatives.idl: Added.
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension): Enable and return the new extension.
(WebCore::WebGLRenderingContext::getParameter): Support extension enum when enabled.
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::hint): Validate extension enum when enabled.
(WebCore::WebGLRenderingContext::getNumberOfExtensions):
(WebCore::WebGLRenderingContext::getExtensionNumber):
* html/canvas/WebGLRenderingContext.h:
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Cleaned up compiler cleanup.
(WebCore::ANGLEWebKitBridge::cleanupCompilers): Destruct compilers.
(WebCore::ANGLEWebKitBridge::setResources): Cleanup existing compilers when changing
ANGLE settings.
(WebCore::ANGLEWebKitBridge::validateShaderSource): Cleaned up compiler cleanup on error.
* platform/graphics/ANGLEWebKitBridge.h:
(WebCore::ANGLEWebKitBridge::getResources):
* platform/graphics/Extensions3D.h: Added enumeration for the extension.
* platform/graphics/GraphicsContext3D.h: lumbing for GraphicsContext3D.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Plumbed through a pointer to the
GraphicsContext3D to handle resetting the shader compilers.
(WebCore::Extensions3DOpenGL::supports): Desktop GL always supports this extension,
so always return true.
(WebCore::Extensions3DOpenGL::ensureEnabled): Reset shader compilers as required.
* platform/graphics/opengl/Extensions3DOpenGL.h: Plumbing for GraphicsContext3D.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::getExtensions): Plumbing for GraphicsContext3D to
Extensions3DOpenGL.
2011-01-20 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix regression(r71566): PDF in RTL block might messes up text directionality.
https://bugs.webkit.org/show_bug.cgi?id=52776
Test: fast/dom/52776.html
* platform/text/BidiResolver.h:
(WebCore::::checkDirectionInLowerRaiseEmbeddingLevel):
(WebCore::::lowerExplicitEmbeddingLevel):
(WebCore::::raiseExplicitEmbeddingLevel):
(WebCore::::createBidiRunsForLine):
2011-01-20 Beth Dakin <bdakin@apple.com>
Reviewed by Anders Carlsson.
Follow-on for <rdar://problem/8890255>
This fixes a painting error with ScrollbarPainter scrollers
and the new drawing area code path.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):
2011-01-20 Levi Weintraub <leviw@chromium.org>
Unreviewed.
Fixing build breakage.
* editing/SelectionController.cpp:
(WebCore::SelectionController::willBeModified):
2011-01-20 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
https://bugs.webkit.org/show_bug.cgi?id=49511
Test: editing/selection/rtl-move-selection-right-left.html
* editing/SelectionController.cpp:
(WebCore::SelectionController::willBeModified):
Respecting the direction of the containing block when switching selection base and extent in
RTL content.
(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingLeft):
Using directionOfEnclosingBlock when deciding to use the selection start or end to do the
correct thing for RTL.
2011-01-20 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Null-check m_frame in DOMWindow::setLocation(), since it's
possible to reach this point without it having been checked
already.
https://bugs.webkit.org/show_bug.cgi?id=52769
Test: fast/dom/Window/Location/set-location-after-close.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation):
2011-01-20 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
setContentEditable with invalid string should throw exception.
https://bugs.webkit.org/show_bug.cgi?id=52057
Implemented exception throwing for setContentEditable according to the following spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#attr-contenteditable
Related quotas: "On setting, if the new value is an ASCII case-insensitive match for the
string 'inherit' then the content attribute must be removed, if the new value is an ASCII
case-insensitive match for the string 'true' then the content attribute must be set to the
string 'true', if the new value is an ASCII case-insensitive match for the string 'false'
then the content attribute must be set to the string 'false', and otherwise the attribute
setter must raise a SYNTAX_ERR exception."
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setContentEditable): Throw exception on invalid input strings; Make setting values case-insensitive and also convert them to lower cases according to the spec.
* html/HTMLElement.h: Add additional parameter ExceptionCode& for function setContentEditable.
* html/HTMLElement.idl: Add exception throwing support for contentEditable setter.
2011-01-19 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Composited render surfaces should allow writes to alpha channel.
https://bugs.webkit.org/show_bug.cgi?id=52766
Test: LayoutTests/platform/chromium/compositing
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):
2011-01-14 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION (r71842): Compass video is not playing in Safari welcome page
https://bugs.webkit.org/show_bug.cgi?id=52506
New test: LayoutTests/media/video-currentTime-delay.html
Call invalidateCachedTime() every time one of the cached property dependencies changes,
i.e. m_paused and m_playbackRate.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
2011-01-20 Beth Dakin <bdakin@apple.com>
Reviewed by Geoffrey Garen.
Fix for <rdar://problem/8890255>
Allow WebKitSystemInterface to draw scrollbars
when appropriate.
* WebCore.exp.in:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::scrollbarMap):
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
2011-01-20 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Cleanup Scrollbar/ScrollbarClient relationship
https://bugs.webkit.org/show_bug.cgi?id=52779
Pipe all scrolling through the ScrollbarClient/ScrollAnimator
rather than through the Scrollbar. The Scrollbar now is just
a "view" on the scroll position of the scrollable area it is
attached to.
There are now two ways to scroll a scrollable area:
- ScrollbarClient::scroll()
- ScrollbarClient::scrollToOffsetWithoutAnimation()
Both of these go through the ScrollAnimator (updating its state
or starting an animation). The ScrollAnimator, in turn, now calls
ScrollbarClient::setScrollOffsetFromAnimation, which tells the
Scrollbars to pull a new offset (via Scrollbar::offsetDidChange)
and tells the class that derives from ScrollbarClient to scroll
its contents (via ScrollbarClient::setScrollOffset).
* WebCore.xcodeproj/project.pbxproj:
Move Scrollbar.cpp to the right place.
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::setValue):
Initiate the scroll through the scrollbar client, rather than the
scrollbar itself.
* page/FrameView.cpp:
(WebCore::FrameView::scrollTo):
* page/FrameView.h:
Condense the two valueChanged overrides to a single override of the
scrollTo function.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::currentPosition):
(WebCore::ScrollAnimator::notityPositionChanged):
* platform/ScrollAnimator.h:
* platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):
* platform/ScrollAnimatorWin.h:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Change setScrollPositionAndStopAnimation to scrollToOffsetWithoutAnimation
and bottleneck all client notification of changed position through a new
notityPositionChanged() function.
* platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollTo):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
* platform/Scrollbar.h:
(WebCore::Scrollbar::setPressedPos):
Change the scrollbar to only updates its offset in response to
an offsetDidChange call.
* platform/ScrollbarClient.cpp:
(WebCore::ScrollbarClient::scroll):
(WebCore::ScrollbarClient::scrollToOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollbarClient::setScrollOffsetFromAnimation):
* platform/ScrollbarClient.h:
(WebCore::ScrollbarClient::horizontalScrollbar):
(WebCore::ScrollbarClient::verticalScrollbar):
Make the increasingly misnamed ScrollbarClient responsible for
scrolling.
* platform/efl/ScrollbarEfl.cpp:
(scrollbarEflEdjeMessage):
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::gtkValueChanged):
* platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::contextMenu):
Update to move scrolling through the client.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::scrollPosition):
(WebCore::PopupMenuWin::setScrollOffset):
(WebCore::PopupMenuWin::scrollTo):
(WebCore::PopupMenuWin::wndProc):
* platform/win/PopupMenuWin.h:
(WebCore::PopupMenuWin::verticalScrollbar):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setScrollOffset):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::scroll):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::scrollTo):
(WebCore::RenderListBox::setScrollTop):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::start):
Simplify initial paint to just do an immediate scroll to the position.
2011-01-20 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r76170.
* platform/graphics/wince/FontWinCE.cpp: Added a missing include.
* platform/graphics/wince/ImageBufferData.h: Added a missing include and fixed style.
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218
This implements mozilla's proposed requestAnimationFrame API. The idea with this API is that
an author driving an animation from script could use window.requestAnimationFrame(callback)
instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
decide when to update the animations. This avoids doing unnecessary work when the page content
is offscreen or is being displayed at a different framerate than what the page author expects.
Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
following changes:
*) Only the callback syntax is supported, there is no before paint event
*) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate
what content they intend to animate. That way if the page is being displayed but the element
in question is offscreen, we can avoid invoking the callback.
*) No timestamp is provided to the caller and there is no window.animationStartTime property
(see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)
*) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback
using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().
The implementation depends on the embedder scheduling the callbacks since the callback invocation
depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
to WebCore. The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
embedder has to rate limit callbacks and may not be able to tie the callback directly to the
rendering loop.
Tests: fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html
* WebCore.gypi:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::webkitRequestAnimationFrame):
(WebCore::Document::webkitCancelRequestAnimationFrame):
(WebCore::Document::serviceScriptedAnimations):
* dom/Document.h:
* dom/RequestAnimationFrameCallback.h: Added.
(WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
* dom/RequestAnimationFrameCallback.idl: Added.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::scheduleAnimation):
* page/Chrome.cpp:
(WebCore::Chrome::scheduleAnimation):
* page/Chrome.h:
* page/ChromeClient.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitRequestAnimationFrame):
(WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/FrameView.cpp:
(WebCore::FrameView::scheduleAnimation):
(WebCore::FrameView::serviceScriptedAnimations):
* page/FrameView.h:
* platform/HostWindow.h:
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Nate Chapin.
[v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters
https://bugs.webkit.org/show_bug.cgi?id=52837
When generating code to invoke a callback with no parameters CodeGeneratorV8.pm was generating the following:
v8::Handle<v8::Value> argv[] = {}; which does not compile in visual studio. Instead, if the argument count
is 0, we can just pass a NULL pointer for the argv parameter.
Test added to bindings/scripts/test/TestCallback.idl and covered by run-bindings-tests. This
patch also includes some spurious changes to the bindings tests golden files (mostly GObject)
because the old golden files were out of date.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
(WebDOMTestCallback::callbackWithNoParam):
* bindings/scripts/test/CPP/WebDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(webkit_dom_test_callback_callback_with_no_param):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithNoParam):
* bindings/scripts/test/JS/JSTestCallback.h:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/ObjC/DOMTestCallback.h:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithNoParam]):
* bindings/scripts/test/TestCallback.idl:
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithNoParam):
* bindings/scripts/test/V8/V8TestCallback.h:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::reflectedUnsignedIntegralAttrAttrGetter):
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Eric "Baller" Seidel.
RenderTableSection's setNeedsCellRecalc needs to null check table()
https://bugs.webkit.org/show_bug.cgi?id=52770
Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
This can be null during detach(). Test constructed by Eric Seidel.
Test: fast/css-generated-content/table-with-scrollbar-corner.html
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setNeedsCellRecalc):
* rendering/RenderTableSection.h:
2011-01-20 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVG Pattern doesn't take preserveAspectRatio of references Pattern
https://bugs.webkit.org/show_bug.cgi?id=52802
SVGPattern didn't take preserveAspectRatio of a referenced SVGPattern into account. Store preserveAspectRatio
in PatternAttributes as well, if the attribute was set on the referenced SVGPattern element.
Test: svg/custom/pattern-referencing-preserve-aspect-ratio.svg
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildTileImageTransform):
* svg/PatternAttributes.h:
(WebCore::PatternAttributes::PatternAttributes):
(WebCore::PatternAttributes::preserveAspectRatio):
(WebCore::PatternAttributes::setPreserveAspectRatio):
(WebCore::PatternAttributes::hasPreserveAspectRatio):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
2011-01-20 Dan Bernstein <mitz@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/8765498> REGRESSION (r72141): Cannot order prints with Aperture 3.1
<rdar://problem/8884648> REGRESSION (r72141): Safari hangs when visiting a page on www.bfmtv.com
https://bugs.webkit.org/show_bug.cgi?id=52765
<rdar://problem/8890909> REGRESSION (r72141): Very Slow Rendering With Certain Markup
https://bugs.webkit.org/show_bug.cgi?id=52265
Test: fast/block/line-layout/negative-max-height.html
Integer overflow detection led to a block having a huge height. This manifested as broken layout
in the first bug and as extreme slowness in the latter bugs because of
https://bugs.webkit.org/show_bug.cgi?id=52832
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Clamp maxHeight to 0 so the next line
cannot start above this line. The negative maxHeight also caused the integer overflow detection
logic to give the block a huge height.
2011-01-20 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Carlson.
Clean up the Media Controls CSS for Qt
https://bugs.webkit.org/show_bug.cgi?id=52822
Split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules
in mediaControlsQt.css, and remove the duplicate audio::-webkit-media-xxx
rules from mediaControlsQtFullscreen.css.
* css/mediaControlsQt.css:
(audio::-webkit-media-controls-panel):
(video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button):
(video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button):
(video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container):
(video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display):
(video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display):
(video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline):
(video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider-container):
(video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider):
(video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button):
(video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button):
(video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button):
(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-rewind-button):
(video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button):
(video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button):
(video::-webkit-media-controls-toggle-closed-captions-button):
* css/mediaControlsQtFullscreen.css:
(video::-webkit-media-controls-time-remaining-display):
(video::-webkit-media-controls-seek-back-button):
(video::-webkit-media-controls-seek-forward-button):
(video::-webkit-media-controls-rewind-button):
(video::-webkit-media-controls-return-to-realtime-button):
(video::-webkit-media-controls-toggle-closed-captions-button):
2011-01-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Canceling of CSS numeric values increment/decrement is broken
https://bugs.webkit.org/show_bug.cgi?id=52816
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
2011-01-20 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
[Qt] Fix Layering violation in MediaPlayerPrivateQt.
https://bugs.webkit.org/show_bug.cgi?id=52733
No new tests. no behavioral change.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::commitLoad):
2011-01-20 Nate Chapin <japhet@chromium.org>
Reviewed by Darin Fisher.
[V8] Call malloc and memcpy directly instead of
of strdup in convertV8ObjectToNPVariant() when
converting strings. If there is a null character
in the string, our use of strdup causes us to allocate
too little memory, leading to out of bounds reads.
https://bugs.webkit.org/show_bug.cgi?id=52631
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
2011-01-20 Andreas Kling <kling@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] Fill shadow scratch buffer with proper transparent pixels
QImage::fill() has no Qt::GlobalColor overload in Qt 4.7 (coming in 4.8)
so doing QImage::fill(Qt::transparent) will actually fill all pixels with
the RGBA value 0x00000013.
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ShadowBuffer::scratchImage):
2011-01-19 Adam Roben <aroben@apple.com>
Remove WKCACFContextFlusher
It wasn't doing anything.
Fixes <http://webkit.org/b/52752> WKCACFContextFlusher is unused
Reviewed by Simon Fraser.
* WebCore.vcproj/WebCore.vcproj: Removed WKCACFContextFlusher. Also let VS have its way with
the file.
* platform/graphics/win/WKCACFContextFlusher.cpp: Removed.
* platform/graphics/win/WKCACFContextFlusher.h: Removed.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::layerTreeDidChange):
Stop telling WKCACFContextFlusher about our context, since it never did anything with it.
2011-01-19 Adam Roben <aroben@apple.com>
Only flush our own context when we get resized
Fixes <http://webkit.org/b/52751> All WKCACFContexts with uncommitted
changes get flushed whenever any composited page is resized
Reviewed by Simon Fraser.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::resize): Just flush our own context, not all contexts
WKCACFContextFlusher knows about. After all, ours is the only one that just got resized!
2011-01-19 Adam Roben <aroben@apple.com>
Make WKCACFLayerRenderer ref-counted
This will be needed to handle cases where the client might release its reference to us while
we're calling out to it.
WKCACFLayerRenderer now has a setClient function, which is used rather than passing the
client to create(). This allows clients to null out the client pointer when they're done
with the renderer.
Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
ref-counted
Reviewed by Simon Fraser.
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow):
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
Updated for WKCACFLayerRenderer changes.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): Updated for changes to
create().
(WebCore::WKCACFLayerRenderer::create): No longer takes a WKCACFLayerRendererClient. Now
returns a PassOwnPtr.
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): No longer takes a
WKCACFLayerRendererClient.
* platform/graphics/win/WKCACFLayerRenderer.h: Made WKCACFLayerRenderer inherit from
RefCounted.
(WebCore::WKCACFLayerRenderer::setClient): Added this simple setter.
2011-01-20 Csaba Osztrogonác <ossy@webkit.org>
[Qt][V8] Unreviewed buildfix after r76248.
* bindings/v8/ScriptCachedFrameData.h: Add missing include.
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: enable resource agent upon request.
https://bugs.webkit.org/show_bug.cgi?id=52815
We should not send network-related notifications unless front-end
is interested.
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreInspectorStateFromCookie):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::resourceAgent):
* inspector/InspectorController.h:
(WebCore::InspectorController::consoleAgent):
(WebCore::InspectorController::cssAgent):
(WebCore::InspectorController::domAgent):
(WebCore::InspectorController::injectedScriptAgent):
(WebCore::InspectorController::runtimeAgent):
(WebCore::InspectorController::databaseAgent):
(WebCore::InspectorController::domStorageAgent):
(WebCore::InspectorController::fileSystemAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::retrieveResourceAgent):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::restore):
(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
(WebCore::InspectorResourceAgent::create):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
2011-01-20 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Csaba Osztrogonác.
Refactoring of the custom allocation framework
https://bugs.webkit.org/show_bug.cgi?id=49897
Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.
2011-01-20 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] CPU Profiles are cleared when navigating back and forth.
Profiles are now not cleared unless renderer instance was changed.
https://bugs.webkit.org/show_bug.cgi?id=52807
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreProfiler):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetState):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
* inspector/InspectorProfilerAgent.h:
2011-01-20 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, add new JS file refs missing from r76116.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/WebKit.qrc:
2011-01-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Crash when adding a rule for an ImageDocument
https://bugs.webkit.org/show_bug.cgi?id=52811
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::addRule2):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: cleanup InspectorController's friends list.
We have a plan to extract InspectorAgent from InspectorController.
InspectorAgent will be accessible only from InspectorController.
As result we can simply made some methods public and remove long
friends list.
https://bugs.webkit.org/show_bug.cgi?id=52806
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::databaseForId):
(WebCore::InjectedScriptHost::selectDatabase):
(WebCore::InjectedScriptHost::selectDOMStorage):
(WebCore::InjectedScriptHost::inspectorDOMAgent):
(WebCore::InjectedScriptHost::frontend):
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorController.h:
(WebCore::InspectorController::frontend):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::characterDataModifiedImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
(WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
(WebCore::InspectorInstrumentation::retrieveTimelineAgent):
(WebCore::InspectorInstrumentation::retrieveResourceAgent):
2011-01-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement JavaScriptBreakpointsSidebarPane based on events from debugger model.
https://bugs.webkit.org/show_bug.cgi?id=52723
Extract all breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get data):
(WebInspector.Breakpoint.prototype.remove):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointRemoved):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointEnableChanged):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointItemCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenuEventFired):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerResumed):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addListElement):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeListElement):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._projectChanged):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compare):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement.didGetSourceLine):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointIdForDebuggerPausedEvent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setBreakpointEnabled):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.NativeBreakpointsSidebarPane):
(WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.removeBreakpoint):
(WebInspector.DebuggerModel.prototype.breakpointForId):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._resumedScript):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/inspector.js:
2011-01-20 Dirk Schulze <krit@webkit.org>
Reviewed by Andreas Kling.
SVG Pattern doesn't take the viewBox of a referenced Pattern
https://bugs.webkit.org/show_bug.cgi?id=52804
SVGPattern element didn't use the viewBox of another SVGPattern element, referenced
by xlink:href. Modified PatternAttributes, to take the value of the viewBox of the
SVGPattern element as well, if the attribute was set.
This gets checked by a W3C SVG test case.
Test: svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildTileImageTransform):
* svg/PatternAttributes.h:
(WebCore::PatternAttributes::PatternAttributes):
(WebCore::PatternAttributes::viewBox):
(WebCore::PatternAttributes::setViewBox):
(WebCore::PatternAttributes::hasViewBox):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
2011-01-19 Stephen White <senorblanco@chromium.org>
[Re-land of r76159 with a compile fix for the Chromium linux shlib
build.]
Reviewed by James Robinson.
Implement accelerated path drawing and clipping for the Canvas2D GPU
path.
https://bugs.webkit.org/show_bug.cgi?id=52627
This is done with a simple curve interpolator and the GLU tesselator,
which is good enough for a 3-5X speedup on
http://ie.microsoft.com/testdrive/Performance/Galactic/Default.html.
Covered by canvas/philip/2d.path.clip.basic.html, and many, many more.
All tests canvas/philip and fast/canvas paths pass with no
regressions, although two have minor pixel differences which require
rebaselining.
* WebCore.gyp/WebCore.gyp:
Add internal_glu include path to chromium build.
* WebCore.gypi:
Add internal_glu files to chromium build.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::platformLayer):
Make CanvasRenderingContext2D more robust against failure to create
a DrawingBuffer.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
As in DrawingBufferMac.cpp, call reset() from the constructor.
Also initialize size to (-1, -1), so reset() doesn't early-out.
Add initializers for depthBuffer and stencilBuffer, and remove
multisampleDepthStencilBuffer.
* platform/graphics/chromium/GLES2Canvas.cpp:
Remove some unused #includes.
(WebCore::GLES2Canvas::State::State):
Add clipping state, and implement save/restore via the copy constructor.
(WebCore::operator*):
(WebCore::Quadratic::Quadratic):
(WebCore::Quadratic::fromBezier):
(WebCore::Quadratic::evaluate):
Quadratic Bezier curve class.
(WebCore::Cubic::Cubic):
(WebCore::Cubic::fromBezier):
(WebCore::Cubic::evaluate):
Cubic Bezier curve class.
(WebCore::GLES2Canvas::clearRect):
Add clipping support to clearRect().
(WebCore::GLES2Canvas::fillPath):
Implement fillPath().
(WebCore::GLES2Canvas::fillRect):
Add clipping support to fillRect().
(WebCore::GLES2Canvas::clipPath):
Implement clipPath().
(WebCore::GLES2Canvas::clipOut):
Stub out clipOut() (not called by Canvas 2D).
(WebCore::GLES2Canvas::restore):
When restoring, draw any remaining clipping paths to the stencil buffer.
(WebCore::GLES2Canvas::drawTexturedRect):
Add clipping support.
(WebCore::interpolateQuadratic):
(WebCore::interpolateCubic):
Simple curve interpolation, using the Cubic and Quadratic classes.
(WebCore::PolygonData::PolygonData):
A struct to hold the tesselation data for callbacks.
(WebCore::beginData):
(WebCore::edgeFlagData):
(WebCore::vertexData):
(WebCore::endData):
(WebCore::combineData):
internal_glu tesselation callbacks.
(WebCore::GLES2Canvas::createVertexBufferFromPath):
Build an interpolated, tesselated vertex buffer and element array buffer from a given path, suitable for filling.
(WebCore::GLES2Canvas::beginStencilDraw):
Enable stencilling, and disable draws to the color buffer.
(WebCore::GLES2Canvas::applyClipping):
If clipping is enabled, set the appropriate GL state.
* platform/graphics/chromium/GLES2Canvas.h:
Document the flavours of drawTexturedRect() a bit, so I don't get confused.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::createSecondaryBuffers):
(WebCore::DrawingBuffer::resizeDepthStencil):
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
Unify m_multisampleDepthStencilBuffer with m_depthStencilBuffer.
Implement separate depth and stencil buffers for when
OES_packed_depth_stencil is not available. Refactor creation of
multisampled and non-multisampled depth and stencil buffers into
resizeDepthStencil().
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
Turn on stencil, turn off depth, turn off antialiasing (for now).
(WebCore::SharedGraphicsContext3D::enableStencil):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
Implement stencil enable/disable.
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
Remove m_multisampleDepthStencilBuffer. Set the size to (-1, -1)
on creation, so reset() doesn't early-out. Initialize m_depthBuffer
and m_stencilBuffer.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
Put in GPU hooks for path clipping, and path drawing.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::canAccelerate):
Don't check for clipping paths in canAccelerate() (since we can
now accelerate them).
(WebCore::PlatformContextSkia::uploadSoftwareToHardware):
Don't do clipping when uploading software draws to hardware.
* thirdparty/glu/README.webkit:
* thirdparty/glu/gluos.h:
#undef MIN and MAX, to fix warnings-as-errors in Chrome/Mac build.
* thirdparty/glu/libtess/geom.c:
* thirdparty/glu/libtess/priorityq.c:
* thirdparty/glu/libtess/render.c:
Use do{}while(0) instead of if(1)else construct in macro.
* thirdparty/glu/libtess/sweep.c:
(IsWindingInside):
(DoneEdgeDict):
Fix some warnings treated as errors for the Linux Release build.
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: move releaseObjectGroup to the new Runtime agent.
https://bugs.webkit.org/show_bug.cgi?id=52803
(accedentally landed as r76231)
* inspector/InspectorContorller.h:
* inspector/InspectorContorller.cpp:
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: build fix.
* inspector/InspectorState.h:
(WebCore::InspectorState::setBoolean):
(WebCore::InspectorState::setString):
(WebCore::InspectorState::setLong):
2011-01-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: further simplify InspectorState.
https://bugs.webkit.org/show_bug.cgi?id=52731
This change moves XHR logging flag into console agent,
removes InspectorState pushing to the front-end.
* inspector/Inspector.idl:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
(WebCore::InspectorController::state):
(WebCore::InspectorController::settings):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::registerBoolean):
(WebCore::InspectorState::registerString):
(WebCore::InspectorState::registerLong):
(WebCore::InspectorState::registerObject):
(WebCore::InspectorState::Property::create):
* inspector/InspectorState.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
* inspector/front-end/inspector.js:
2011-01-20 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix.
[Qt][V8] Remove unnecessary files after r76224.
* WebCore.pro:
2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: prepare for extracting InspectorAgent from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=52797
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorController.h:
(WebCore::InspectorController::inspectorAgent):
(WebCore::InspectorController::cssAgent):
(WebCore::InspectorController::injectedScriptAgent):
(WebCore::InspectorController::resourceAgent):
(WebCore::InspectorController::runtimeAgent):
(WebCore::InspectorController::timelineAgent):
(WebCore::InspectorController::databaseAgent):
(WebCore::InspectorController::domStorageAgent):
(WebCore::InspectorController::fileSystemAgent):
(WebCore::InspectorController::browserDebuggerAgent):
(WebCore::InspectorController::debuggerAgent):
(WebCore::InspectorController::profilerAgent):
(WebCore::InspectorController::applicationCacheAgent):
2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76215.
http://trac.webkit.org/changeset/76215
https://bugs.webkit.org/show_bug.cgi?id=52799
Caused regressions in Chromium; morrita is going to look at it
tomrorow (Requested by jorlow on #webkit).
* dom/TextEvent.h:
* dom/TextEventInputType.h:
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
* editing/CompositeEditCommand.h:
* editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::confirmComposition):
(WebCore::Editor::setComposition):
* editing/Editor.h:
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
* editing/InsertTextCommand.h:
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertTextRunWithoutNewlines):
* editing/TypingCommand.h:
(WebCore::TypingCommand::create):
2010-12-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
[V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
https://bugs.webkit.org/show_bug.cgi?id=51044
* WebCore.gypi:
* bindings/v8/V8ConsoleMessage.cpp: Removed.
* bindings/v8/V8ConsoleMessage.h: Removed.
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::v8UncaughtExceptionHandler):
(WebCore::reportUnsafeJavaScriptAccess):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8Proxy.cpp:
(WebCore::addMessageToConsole):
(WebCore::logInfo):
(WebCore::V8Proxy::reportUnsafeAccessTo):
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::newInstance):
* bindings/v8/V8Proxy.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/specialization/V8BindingState.cpp:
(WebCore::::immediatelyReportUnsafeAccessTo):
2011-01-19 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
ShadowElement::m_shadowParent should be removed
https://bugs.webkit.org/show_bug.cgi?id=52558
No new tests. No behavioral change.
* rendering/ShadowElement.h:
(WebCore::ShadowElement::ShadowElement):
2011-01-20 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror
https://bugs.webkit.org/show_bug.cgi?id=52725
Let IDBObjectStore.get() fire the onsuccess handler with the value
'undefined' for when an object does not exist in the store.
Update SerializedScriptValue to provide such an undefined value.
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
* bindings/v8/SerializedScriptValue.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getInternal):
2010-12-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519
Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.
It was decided to dispatch ErrorEvent to all listeners/handlers no matter if they
were created in the same isolated world where the exception occured or not.
Tests: fast/events/window-onerror1.html
fast/events/window-onerror10.html
fast/events/window-onerror11.html
fast/events/window-onerror12.html
fast/events/window-onerror2.html
fast/events/window-onerror3.html
fast/events/window-onerror4.html
fast/events/window-onerror5.html
fast/events/window-onerror6.html
fast/events/window-onerror7.html
fast/events/window-onerror8.html
fast/events/window-onerror9.html
http/tests/security/window-onerror-exception-in-iframe.html
userscripts/window-onerror-for-isolated-world-1.html
userscripts/window-onerror-for-isolated-world-2.html
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* bindings/js/JSErrorHandler.cpp: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.cpp.
(WebCore::JSErrorHandler::JSErrorHandler):
(WebCore::JSErrorHandler::~JSErrorHandler):
(WebCore::JSErrorHandler::handleEvent):
* bindings/js/JSErrorHandler.h: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
(WebCore::JSErrorHandler::create):
(WebCore::createJSErrorHandler):
* bindings/js/JSEventListener.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8ConsoleMessage.cpp:
(WebCore::V8ConsoleMessage::dispatchNow):
(WebCore::V8ConsoleMessage::handler): the method was changed to use generic WebCore exception
reporting mechanism which is also used by JSC bindings.
* bindings/v8/V8ConsoleMessage.h:
* bindings/v8/V8EventListener.h:
* bindings/v8/V8WindowErrorHandler.cpp: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
(WebCore::V8WindowErrorHandler::V8WindowErrorHandler):
(WebCore::V8WindowErrorHandler::callListenerFunction):
* bindings/v8/V8WindowErrorHandler.h: Copied from WebCore/dom/ErrorEvent.cpp.
(WebCore::V8WindowErrorHandler::create):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::v8MessageHandler):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* dom/Document.cpp:
(WebCore::Document::errorEventTarget):
(WebCore::Document::logExceptionToConsole):
(WebCore::Document::addMessage):
* dom/Document.h:
* dom/ErrorEvent.cpp:
* dom/ErrorEvent.h:
* dom/Event.cpp:
(WebCore::Event::isErrorEvent):
* dom/Event.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::PendingException::PendingException):
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::reportException): this method is not virtual anymore to
ensure that error event dispatching algorithm is the same in WorkerContext and in Document.
(WebCore::ScriptExecutionContext::dispatchErrorEvent):
* dom/ScriptExecutionContext.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didOpen):
(WebCore::WebSocketChannel::didFail):
(WebCore::WebSocketChannel::appendToBuffer):
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::readStatusLine):
(WebCore::WebSocketHandshake::readHTTPHeaders):
(WebCore::WebSocketHandshake::checkResponseHeaders):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::postExceptionTask):
(WebCore::postConsoleMessageTask):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
(WebCore::WorkerContext::errorEventTarget):
(WebCore::WorkerContext::logExceptionToConsole):
(WebCore::WorkerContext::addMessage):
* workers/WorkerContext.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerExceptionTask::performTask):
(WebCore::postConsoleMessageTask):
* xml/XMLHttpRequest.cpp:
(WebCore::reportUnsafeUsage):
2011-01-19 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Space and tab characters "sent" by an input method give totally different results than typing them directly
https://bugs.webkit.org/show_bug.cgi?id=5241
* Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to
distinguish text input which is originated by composition.
* Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing
range of string on text node, instead of surrounding part of that.
Test: editing/inserting/insert-composition-whitespace.html
* dom/TextEvent.h:
(WebCore::TextEvent::isComposition):
* dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
* editing/CompositeEditCommand.cpp:
(WebCore::containsOnlyWhitespace):
(WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor):
(WebCore::CompositeEditCommand::canRebalance):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
* editing/CompositeEditCommand.h:
* editing/Editor.cpp:
(WebCore::Editor::insertTextForConfirmedComposition): Added.
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition().
(WebCore::Editor::setComposition):
* editing/Editor.h:
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
* editing/InsertTextCommand.h:
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertTextRunWithoutNewlines):
* editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType
(WebCore::TypingCommand::setCompositionType): Added.
(WebCore::TypingCommand::create):
2011-01-19 Dominic Cooney <dominicc@google.com>
Reviewed by Kent Tamura.
Make <keygen> no longer appear to be a <select> element to script.
https://bugs.webkit.org/show_bug.cgi?id=52557
The intent is to put <keygen> options into shadow DOM. This change
takes the first step by hiding the <select> element from
JavaScript.
Test: fast/dom/HTMLKeygenElement/keygen.html
* CMakeLists.txt: Adds new IDL-derived wrapper.
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/GNUmakefile.am:
* bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
(WebKit::createKeygenWrapper):
(WebKit::createHTMLElementWrapper):
* bindings/objc/DOM.mm:
(WebCore::createElementClassMap): Keygen no longer DOMHTMLSelectElement
* html/HTMLKeygenElement.h:
(WebCore::HTMLKeygenElement::willValidate): Now public.
* html/HTMLKeygenElement.idl: Added.
* html/HTMLTagNames.in: Keygen's wrapper is HTMLKeygenElement.
* page/DOMWindow.idl: Add HTMLKeygenElement constructor.
2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76203.
http://trac.webkit.org/changeset/76203
https://bugs.webkit.org/show_bug.cgi?id=52784
Broke Win compile on Chromium bots (Requested by dimich on
#webkit).
* WebCore.gypi:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportFatalErrorInV8):
* page/PageGroup.cpp:
(WebCore::PageGroup::isLinkVisited):
* platform/android/PlatformBridge.h:
* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::createBusFromInMemoryAudioFile):
* platform/chromium/ChromiumBridge.h: Added.
* platform/chromium/ChromiumDataObjectLegacy.cpp:
(WebCore::ChromiumDataObjectLegacy::getData):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::revealFolderInOS):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::fileExists):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):
* platform/chromium/LanguageChromium.cpp:
(WebCore::platformDefaultLanguage):
* platform/chromium/LinkHashChromium.cpp:
(WebCore::visitedLinkHash):
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
* platform/chromium/PlatformBridge.h:
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/chromium/ReadableDataObject.cpp:
(WebCore::ReadableDataObject::getData):
(WebCore::ReadableDataObject::urlTitle):
(WebCore::ReadableDataObject::htmlBaseUrl):
(WebCore::ReadableDataObject::filenames):
(WebCore::ReadableDataObject::ensureTypeCacheInitialized):
* platform/chromium/SSLKeyGeneratorChromium.cpp:
(WebCore::signedPublicKeyAndChallengeString):
* platform/chromium/ScrollbarThemeChromium.cpp:
* platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
* platform/chromium/SharedTimerChromium.cpp:
(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireTime):
(WebCore::stopSharedTimer):
* platform/chromium/SuddenTerminationChromium.cpp:
(WebCore::disableSuddenTermination):
(WebCore::enableSuddenTermination):
* platform/chromium/SystemTimeChromium.cpp:
(WebCore::currentTime):
* platform/chromium/WritableDataObject.cpp:
(WebCore::WritableDataObject::setData):
* platform/graphics/chromium/CrossProcessFontLoading.mm:
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::scriptFontProperties):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::querySystemForRenderStyle):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* platform/graphics/chromium/ImageChromium.cpp:
(WebCore::Image::loadPlatformResource):
* platform/graphics/chromium/ImageChromiumMac.mm:
(WebCore::Image::loadPlatformResource):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
(WebCore::UniscribeHelperTextRun::tryToPreloadFont):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/network/chromium/CookieJarChromium.cpp:
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
* platform/network/chromium/DNSChromium.cpp:
(WebCore::prefetchDNS):
* platform/qt/PlatformBridge.h:
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(chromiumOpen):
(chromiumDelete):
(chromiumAccess):
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::PluginCache::plugins):
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):
* storage/chromium/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
(WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
* storage/chromium/IDBKeyPathBackendImpl.cpp:
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
2011-01-19 Helder Correia <helder@sencha.com>
Reviewed by Andreas Kling.
[Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha
https://bugs.webkit.org/show_bug.cgi?id=52705
This is related to bug 52611. The shadow color alpha must be multiplied
by the context pen alpha. Fixing this results in correct behavior for
Canvas path stroke() and strokeRect() [which relies on stroke()].
Tests: fast/canvas/canvas-strokePath-alpha-shadow.html
fast/canvas/canvas-strokeRect-alpha-shadow.html
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::strokePath):
2011-01-19 Darin Fisher <darin@chromium.org>
Reviewed by Mihai Parparita.
Re-initialize the HistoryItem fully when navigating to a HistoryItem,
or replacing a HistoryItem, results in a different URL.
https://bugs.webkit.org/show_bug.cgi?id=49654
This patch also forces all HistoryItems to record the post-redirect
URL. Previously, frames would remember the pre-redirect URL. This is
problematic since other members of the HistoryItem correspond to the
post-redirect URL.
Tests: fast/history/history-replace-updates-current-item.html
http/tests/navigation/redirect-on-back-updates-history-item.html
http/tests/navigation/redirect-on-reload-updates-history-item.html
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
* history/HistoryItem.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::updateForBackForwardNavigation):
(WebCore::HistoryController::updateForReload):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
(WebCore::HistoryController::initializeItem):
(WebCore::HistoryController::createItem):
(WebCore::HistoryController::createItemTree):
(WebCore::HistoryController::updateCurrentItem):
* loader/HistoryController.h:
2011-01-19 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471
No tests added as this is a rename; no change in behavior.
* WebCore.gypi:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportFatalErrorInV8):
* page/PageGroup.cpp:
(WebCore::PageGroup::isLinkVisited):
* platform/android/PlatformBridge.h:
* platform/audio/chromium/AudioBusChromium.cpp:
(WebCore::createBusFromInMemoryAudioFile):
* platform/chromium/ChromiumBridge.h: Removed.
* platform/chromium/ChromiumDataObjectLegacy.cpp:
(WebCore::ChromiumDataObjectLegacy::getData):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::revealFolderInOS):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::fileExists):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):
* platform/chromium/LanguageChromium.cpp:
(WebCore::platformDefaultLanguage):
* platform/chromium/LinkHashChromium.cpp:
(WebCore::visitedLinkHash):
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
* platform/chromium/PlatformBridge.h:
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/chromium/ReadableDataObject.cpp:
(WebCore::ReadableDataObject::getData):
(WebCore::ReadableDataObject::urlTitle):
(WebCore::ReadableDataObject::htmlBaseUrl):
(WebCore::ReadableDataObject::filenames):
(WebCore::ReadableDataObject::ensureTypeCacheInitialized):
* platform/chromium/SSLKeyGeneratorChromium.cpp:
(WebCore::signedPublicKeyAndChallengeString):
* platform/chromium/ScrollbarThemeChromium.cpp:
* platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
* platform/chromium/SharedTimerChromium.cpp:
(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireTime):
(WebCore::stopSharedTimer):
* platform/chromium/SuddenTerminationChromium.cpp:
(WebCore::disableSuddenTermination):
(WebCore::enableSuddenTermination):
* platform/chromium/SystemTimeChromium.cpp:
(WebCore::currentTime):
* platform/chromium/WritableDataObject.cpp:
(WebCore::WritableDataObject::setData):
* platform/graphics/chromium/CrossProcessFontLoading.mm:
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::scriptFontProperties):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::querySystemForRenderStyle):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* platform/graphics/chromium/ImageChromium.cpp:
(WebCore::Image::loadPlatformResource):
* platform/graphics/chromium/ImageChromiumMac.mm:
(WebCore::Image::loadPlatformResource):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
(WebCore::UniscribeHelperTextRun::tryToPreloadFont):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/network/chromium/CookieJarChromium.cpp:
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
* platform/network/chromium/DNSChromium.cpp:
(WebCore::prefetchDNS):
* platform/qt/PlatformBridge.h:
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(chromiumOpen):
(chromiumDelete):
(chromiumAccess):
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::PluginCache::plugins):
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):
* storage/chromium/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
(WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
* storage/chromium/IDBKeyPathBackendImpl.cpp:
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76187.
http://trac.webkit.org/changeset/76187
https://bugs.webkit.org/show_bug.cgi?id=52778
Broke caret-showing tests on SnowLeopard and Chromium
(Requested by dimich on #webkit).
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
2011-01-19 Yuzo Fujishima <yuzo@google.com>
Reviewed by Kent Tamura.
Fix for Bug 52279 - WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=52279
In constructing text fragments to handle first-letter rule, first add
the text for the non-first letters and then remove the original text,
rather than the other way around. Otherwise, the text can be added to
an anoymous block that is different from the original one. This breaks
the assumption that a first letter render object has a non-null sibling
for the non-first letters and causes a crash.
Test: fast/css/first-letter-anonymous-block-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
2011-01-19 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r76194.
http://trac.webkit.org/changeset/76194
https://bugs.webkit.org/show_bug.cgi?id=51218
Caused mysterious compile failure on the chromium win
build.webkit.org bots
* WebCore.gypi:
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
* dom/RequestAnimationFrameCallback.h: Removed.
* dom/RequestAnimationFrameCallback.idl: Removed.
* loader/EmptyClients.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* page/DOMWindow.cpp:
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/FrameView.cpp:
* page/FrameView.h:
* platform/HostWindow.h:
2011-01-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
GraphicsLayers in subframes can get sync'd multiple times
https://bugs.webkit.org/show_bug.cgi?id=52489
Some cleanup that will work towards fixing this bug.
Tested by existing iframe compositing tests.
* WebCore.exp.in: syncCompositingStateRecursive()
was renamed to syncCompositingStateIncludingSubframes().
* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame): Some
code cleanup: do all the word we need to do for this frame,
including the needsLayout() check.
(WebCore::FrameView::syncCompositingStateIncludingSubframes):
This is no longer recursive; instead, it iterates over descendant
frames via the frame tree, calling syncCompositingStateForThisFrame()
on each Frame's view.
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::isFlushingLayers): Getter for the flag.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges): Maintain
a flag to say if we're flushing, which allows us to assert on re-entrant flushes.
(WebCore::RenderLayerCompositor::enclosingCompositorFlushingLayers):
Add the ability to get the rootmost compositor that is in the middle
of a flush.
2011-01-19 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218
This implements mozilla's proposed requestAnimationFrame API. The idea with this API is that
an author driving an animation from script could use window.requestAnimationFrame(callback)
instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
decide when to update the animations. This avoids doing unnecessary work when the page content
is offscreen or is being displayed at a different framerate than what the page author expects.
Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
following changes:
*) Only the callback syntax is supported, there is no before paint event
*) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate
what content they intend to animate. That way if the page is being displayed but the element
in question is offscreen, we can avoid invoking the callback.
*) No timestamp is provided to the caller and there is no window.animationStartTime property
(see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)
*) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback
using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().
The implementation depends on the embedder scheduling the callbacks since the callback invocation
depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
to WebCore. The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
embedder has to rate limit callbacks and may not be able to tie the callback directly to the
rendering loop.
Tests: fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html
* WebCore.gypi:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::webkitRequestAnimationFrame):
(WebCore::Document::webkitCancelRequestAnimationFrame):
(WebCore::Document::serviceScriptedAnimations):
* dom/Document.h:
* dom/RequestAnimationFrameCallback.h: Added.
(WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
* dom/RequestAnimationFrameCallback.idl: Added.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::scheduleAnimation):
* page/Chrome.cpp:
(WebCore::Chrome::scheduleAnimation):
* page/Chrome.h:
* page/ChromeClient.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitRequestAnimationFrame):
(WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/FrameView.cpp:
(WebCore::FrameView::scheduleAnimation):
(WebCore::FrameView::serviceScriptedAnimations):
* page/FrameView.h:
* platform/HostWindow.h:
2011-01-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] Move progress bar painting out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52385
Move progress bar painting to RenderThemeGtk2 and share some animation
logic between the GTK+ 2.x and GTK+ 3.x port.
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): Moved from RenderThemeGtk3.
(WebCore::RenderThemeGtk::animationDurationForProgressBar): Ditto.
(WebCore::RenderThemeGtk::calculateProgressRect): Calculate the proper rectangle for the
progress indicator given the rect for the maximum size of the indicator.
* platform/gtk/RenderThemeGtk.h: Added calculateProgressRect declaration and
a new widget member for GTK+ 2.x
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::platformInit): Added initialization for the new widget member.
(WebCore::RenderThemeGtk::paintProgressBar): Paint the progress bar manually instead of
calling the old Mozilla code.
(WebCore::RenderThemeGtk::gtkProgressBar): Added.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintProgressBar): Call calculateProgressRect now to get
the area of the progress indicator.
* platform/gtk/gtk2drawing.c: Remove unused code.
(moz_gtk_get_widget_border):
(moz_gtk_widget_paint):
* platform/gtk/gtkdrawing.h: Ditto.
2011-01-19 Dmitry Titov <dimich@chromium.org>
[Chromium] Not reviewed, reverts the following changes:
http://trac.webkit.org/changeset/76164 (build fix)
http://trac.webkit.org/changeset/76159 (main change)
The change broke Chromium Linux-shlib build.
Original issue:
Accelerated canvas2D has bad clipping performance.
https://bugs.webkit.org/show_bug.cgi?id=52627
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::platformLayer):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::State::State):
(WebCore::GLES2Canvas::clearRect):
(WebCore::GLES2Canvas::fillRect):
(WebCore::GLES2Canvas::restore):
(WebCore::GLES2Canvas::drawTexturedRect):
* platform/graphics/chromium/GLES2Canvas.h:
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::createSecondaryBuffers):
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::canAccelerate):
(WebCore::PlatformContextSkia::uploadSoftwareToHardware):
* thirdparty/glu/README.webkit:
* thirdparty/glu/gluos.h:
* thirdparty/glu/libtess/geom.c:
* thirdparty/glu/libtess/priorityq.c:
* thirdparty/glu/libtess/render.c:
* thirdparty/glu/libtess/sweep.c:
(IsWindingInside):
(DoneEdgeDict):
2011-01-19 Levi Weintraub <leviw@google.com>
Reviewed by Darin Adler.
Re-committing this with the proper expected results.
Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.
Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132
Test: editing/selection/caret-painting-in-overflowing-autowrap-content.html
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
2011-01-18 MORITA Hajime <morrita@google.com>
Reviewed by David Levin.
ElementRareData::m_shadowRoot should not be RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=51914
Makes ElementRareData::m_shadowRoot a raw pointer because
ElementRareData::m_shadowRoot should be like a
ContaineNode::m_firstChild, which is also a raw pointer.
pointer. Which also means that both the shadow root and the shadow
host reference each other as a parent-and-child relationship, via
a raw pointer.
Note that it is safe not to manipulate the ref-count of
m_shadowRoot because Node::m_parent of the shadow root points its
shadow host, and the object isn't deleted even if the refcount is
zero, as long as the node has non-null m_parent. (See TreeShared.)
The shadow root node is finally destroyed inside
removeShadowRoot(), where we store the root node into a local
RefPtr, then make the node's m_parent null, which results the
destroy the node, at the end of the function, by RefPtr::~RefPtr.
No new tests. No behavioral change.
* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::shadowRoot):
(WebCore::Element::setShadowRoot):
(WebCore::Element::removeShadowRoot):
* dom/ElementRareData.h:
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::~ElementRareData):
2011-01-12 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Move text field painting out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52327
No new tests. This should not change behavior.
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::paintButton): Use the setWidgetHasFocus helper.
(WebCore::RenderThemeGtk::paintTextField): Do this manually now instead
of calling into the Mozilla code.
* platform/gtk/WidgetRenderingContext.cpp: Added a couple more wrappers
for GTK+ theme functions.
(WebCore::WidgetRenderingContext::gtkPaintFlatBox):
(WebCore::WidgetRenderingContext::gtkPaintShadow):
* platform/gtk/WidgetRenderingContext.h: Added new method declarations.
* platform/gtk/gtk2drawing.c: Remove unused code.
(moz_gtk_get_widget_border):
(moz_gtk_widget_paint):
* platform/gtk/gtkdrawing.h:
2011-01-19 Antti Koivisto <antti@apple.com>
Reviewed by Oliver Hunt.
Cache function offsets to speed up javascript parsing
https://bugs.webkit.org/show_bug.cgi?id=52622
Use cache to save function offsets and some other info.
This avoids quite a bit of work when reparsing the source.
* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::cache):
(WebCore::CachedScriptSourceProvider::cacheSizeChanged):
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
* bindings/js/ScriptSourceProvider.h:
(WebCore::ScriptSourceProvider::ScriptSourceProvider):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::destroyDecodedData):
(WebCore::CachedScript::sourceProviderCache):
(WebCore::CachedScript::sourceProviderCacheSizeChanged):
* loader/cache/CachedScript.h:
2011-01-11 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Move toggle button rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52258
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::platformInit): Initialize new button members.
(WebCore::adjustRectForFocus): Added this function which inflates a rect based
on a widget's exterior focus.
(WebCore::RenderThemeGtk::adjustRepaintRect): Account for exterior focus.
(WebCore::setToggleSize): Only listen to indicator-size to properly size
checkboxes and radio buttons.
(WebCore::RenderThemeGtk::setCheckboxSize): Call new setToggleSize properly.
(WebCore::paintToggle): Added.
(WebCore::RenderThemeGtk::paintCheckbox): Call paintToggle.
(WebCore::RenderThemeGtk::setRadioSize): Call new setToggleSize properly.
(WebCore::RenderThemeGtk::paintRadio): Call paintToggle.
(WebCore::RenderThemeGtk::gtkRadioButton): Added.
(WebCore::RenderThemeGtk::gtkCheckButton): Added.
* platform/gtk/WidgetRenderingContext.cpp:
(WebCore::WidgetRenderingContext::WidgetRenderingContext): Use a static extra space
variable. This is good enough for all themes that I've tested and prevents having to
pass information from RenderThemeGtk about every single type of widget.
(WebCore::WidgetRenderingContext::gtkPaintFocus): Use the paintRect
to draw instead of m_paintRect. This is important when we're painting
something that isn't the size of the total rect.
(WebCore::WidgetRenderingContext::gtkPaintCheck): Added.
(WebCore::WidgetRenderingContext::gtkPaintOption): Added.
* platform/gtk/WidgetRenderingContext.h: Updated to reflect new methods.
* platform/gtk/gtkdrawing.h: Remove newly unused code.
* platform/gtk/gtk2drawing.c: Ditto.
2011-01-19 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Build fix for r76170
https://bugs.webkit.org/show_bug.cgi?id=52758
* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
2011-01-19 David D. Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/52687> Clean up FrameLoader methods for PLUGIN_PROXY_FOR_VIDEO
Reviewed by Eric Carlson.
* loader/FrameLoader.cpp: Declare the methods here.
(WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
(WebCore::FrameLoader::showMediaPlayerProxyPlugin):
* loader/FrameLoader.cpp: Moved methods to here...
(WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
(WebCore::FrameLoader::showMediaPlayerProxyPlugin):
* loader/SubframeLoader.cpp: ...from here.
(WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
(WebCore::FrameLoader::showMediaPlayerProxyPlugin):
2011-01-19 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Mihai Parparita.
Perform some forward declaration
https://bugs.webkit.org/show_bug.cgi?id=52522
No new tests because no new functionality.
* accessibility/AccessibilityObject.h:
* css/WebKitCSSMatrix.cpp:
* html/HTMLAreaElement.cpp:
* html/canvas/CanvasRenderingContext2D.cpp:
* inspector/InspectorController.cpp:
* platform/graphics/FloatPoint.cpp:
* platform/graphics/Font.cpp:
* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/ImageBuffer.h:
* platform/graphics/StringTruncator.cpp:
* platform/graphics/WidthIterator.cpp:
* platform/graphics/mac/ComplexTextController.cpp:
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
* platform/graphics/mac/FontComplexTextMac.cpp:
* platform/graphics/transforms/TransformationMatrix.cpp:
* platform/graphics/transforms/TransformationMatrix.h:
* rendering/EllipsisBox.cpp:
* rendering/InlineTextBox.cpp:
* rendering/RenderBlock.cpp:
* rendering/RenderBlockLineLayout.cpp:
* rendering/RenderEmbeddedObject.cpp:
* rendering/RenderFileUploadControl.cpp:
* rendering/RenderFlexibleBox.cpp:
* rendering/RenderImage.cpp:
* rendering/RenderListBox.cpp:
* rendering/RenderListMarker.cpp:
* rendering/RenderMenuList.cpp:
* rendering/RenderObject.h:
* rendering/RenderText.cpp:
* rendering/RenderTextControl.cpp:
* rendering/svg/SVGInlineTextBox.cpp:
* rendering/svg/SVGMarkerLayoutInfo.h:
* rendering/svg/SVGTextMetrics.cpp:
* svg/SVGFont.cpp:
2011-01-19 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Tiled compositor should use texture manager
https://bugs.webkit.org/show_bug.cgi?id=52418
Test: compositing/
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::LayerTilerChromium):
(WebCore::LayerTilerChromium::reset):
(WebCore::LayerTilerChromium::createTile):
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::draw):
* platform/graphics/chromium/LayerTilerChromium.h:
(WebCore::LayerTilerChromium::Tile::Tile):
(WebCore::LayerTilerChromium::Tile::texture):
2011-01-19 Stephen White <senorblanco@chromium.org>
Unreviewed; build fix for chromium.
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::fillPath):
2011-01-18 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Implement accelerated path drawing and clipping for the Canvas2D GPU
path.
https://bugs.webkit.org/show_bug.cgi?id=52627
This is done with a simple curve interpolator and the GLU tesselator,
which is good enough for a 3-5X speedup on
http://ie.microsoft.com/testdrive/Performance/Galactic/Default.html.
Covered by canvas/philip/2d.path.clip.basic.html, and many, many more.
All tests canvas/philip and fast/canvas paths pass with no
regressions, although two have minor pixel differences which require
rebaselining.
* WebCore.gyp/WebCore.gyp:
Add internal_glu include path to chromium build.
* WebCore.gypi:
Add internal_glu files to chromium build.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::platformLayer):
Make CanvasRenderingContext2D more robust against failure to create
a DrawingBuffer.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
As in DrawingBufferMac.cpp, call reset() from the constructor.
Also initialize size to (-1, -1), so reset() doesn't early-out.
Add initializers for depthBuffer and stencilBuffer, and remove
multisampleDepthStencilBuffer.
* platform/graphics/chromium/GLES2Canvas.cpp:
Remove some unused #includes.
(WebCore::GLES2Canvas::State::State):
Add clipping state, and implement save/restore via the copy constructor.
(WebCore::operator*):
(WebCore::Quadratic::Quadratic):
(WebCore::Quadratic::fromBezier):
(WebCore::Quadratic::evaluate):
Quadratic Bezier curve class.
(WebCore::Cubic::Cubic):
(WebCore::Cubic::fromBezier):
(WebCore::Cubic::evaluate):
Cubic Bezier curve class.
(WebCore::GLES2Canvas::clearRect):
Add clipping support to clearRect().
(WebCore::GLES2Canvas::fillPath):
Implement fillPath().
(WebCore::GLES2Canvas::fillRect):
Add clipping support to fillRect().
(WebCore::GLES2Canvas::clipPath):
Implement clipPath().
(WebCore::GLES2Canvas::clipOut):
Stub out clipOut() (not called by Canvas 2D).
(WebCore::GLES2Canvas::restore):
When restoring, draw any remaining clipping paths to the stencil buffer.
(WebCore::GLES2Canvas::drawTexturedRect):
Add clipping support.
(WebCore::interpolateQuadratic):
(WebCore::interpolateCubic):
Simple curve interpolation, using the Cubic and Quadratic classes.
(WebCore::PolygonData::PolygonData):
A struct to hold the tesselation data for callbacks.
(WebCore::beginData):
(WebCore::edgeFlagData):
(WebCore::vertexData):
(WebCore::endData):
(WebCore::combineData):
internal_glu tesselation callbacks.
(WebCore::GLES2Canvas::createVertexBufferFromPath):
Build an interpolated, tesselated vertex buffer and element array buffer from a given path, suitable for filling.
(WebCore::GLES2Canvas::beginStencilDraw):
Enable stencilling, and disable draws to the color buffer.
(WebCore::GLES2Canvas::applyClipping):
If clipping is enabled, set the appropriate GL state.
* platform/graphics/chromium/GLES2Canvas.h:
Document the flavours of drawTexturedRect() a bit, so I don't get confused.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::createSecondaryBuffers):
(WebCore::DrawingBuffer::resizeDepthStencil):
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
Unify m_multisampleDepthStencilBuffer with m_depthStencilBuffer.
Implement separate depth and stencil buffers for when
OES_packed_depth_stencil is not available. Refactor creation of
multisampled and non-multisampled depth and stencil buffers into
resizeDepthStencil().
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):
Turn on stencil, turn off depth, turn off antialiasing (for now).
(WebCore::SharedGraphicsContext3D::enableStencil):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
Implement stencil enable/disable.
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
Remove m_multisampleDepthStencilBuffer. Set the size to (-1, -1)
on creation, so reset() doesn't early-out. Initialize m_depthBuffer
and m_stencilBuffer.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
Put in GPU hooks for path clipping, and path drawing.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::canAccelerate):
Don't check for clipping paths in canAccelerate() (since we can
now accelerate them).
(WebCore::PlatformContextSkia::uploadSoftwareToHardware):
Don't do clipping when uploading software draws to hardware.
* thirdparty/glu/README.webkit:
* thirdparty/glu/gluos.h:
#undef MIN and MAX, to fix warnings-as-errors in Chrome/Mac build.
* thirdparty/glu/libtess/geom.c:
* thirdparty/glu/libtess/priorityq.c:
* thirdparty/glu/libtess/render.c:
Use do{}while(0) instead of if(1)else construct in macro.
* thirdparty/glu/libtess/sweep.c:
(IsWindingInside):
(DoneEdgeDict):
Fix some warnings treated as errors for the Linux Release build.
2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76144.
http://trac.webkit.org/changeset/76144
https://bugs.webkit.org/show_bug.cgi?id=52737
Broke tests on multiple bots, mostly Chromium Canaries
(Requested by dimich on #webkit).
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
2011-01-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
[CSS Gradients] Crash due to out-of-memory with repeating-linear-gradient and latter stop positioned before former
https://bugs.webkit.org/show_bug.cgi?id=52732
When repeating gradient stops, make sure that the first and last stops are not at the same
place, otherwise we'll add stops indefinitely and run out of memory.
Test: fast/gradients/zero-range-repeating-gradient-hang.html
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
2011-01-14 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Remove event forwarding logic from input[type=range], simplify event flow and thumb positioning logic.
https://bugs.webkit.org/show_bug.cgi?id=52464
This change has two parts:
1) Utilize shadow DOM event retargeting to get rid of forwarding events
via render tree;
2) Move thumb positioning logic from RenderSlider to SliderThumbElement.
These two are highly co-dependent. It looked ugly when I tried to
separate them.
No change in behavior, covered by existing tests.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler): Added invocation of
InputType::handleMouseDownEvent.
* html/InputType.cpp:
(WebCore::InputType::handleMouseDownEvent): Added empty decl.
* html/InputType.h: Added def.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent): Added to handle the case
when the user clicks on the track of the slider. Also removed the
forwardEvent method.
* html/RangeInputType.h: Added/removed defs.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::dragFrom): Added a helper method to start
dragging from any position.
(WebCore::SliderThumbElement::dragTo): Added a helper method to drag to
specified position.
(WebCore::SliderThumbElement::setPosition): Collapsed most of the positioning
logic in RenderSlider into this method, which is now a simple calculation
and adjusting of thumb position based on supplied coordinates.
(WebCore::SliderThumbElement::startDragging): Added.
(WebCore::SliderThumbElement::stopDragging): Added.
(WebCore::SliderThumbElement::defaultEventHandler): Removed most of the
old position-sniffing logic and replaced with simple calls to start,
stop, and drag the thumb.
* html/shadow/SliderThumbElement.h: Added defs.
* rendering/RenderSlider.cpp: Removed a bunch of code that is no longer
necessary.
* rendering/RenderSlider.h: Removed defs, removed now-unnecessary friendliness.
2011-01-19 Shane Stephens <shanestephens@google.com>
Reviewed by Chris Marrin.
Make AffineTransform and TransformationMatrix do matrix multiplication in the correct order (Column Major)
https://bugs.webkit.org/show_bug.cgi?id=48031
Fixed reversal, renamed matrix methods to be clearer, found all examples of operator* and
operator*= usage and switched operand order.
No new tests as this refactor doesn't add functionality.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::baseTransform):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
* platform/graphics/cg/PatternCG.cpp:
(WebCore::Pattern::createPlatformPattern):
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::fillRect):
(WebCore::GLES2Canvas::concatCTM):
(WebCore::GLES2Canvas::drawQuad):
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
(WebCore::TransparencyWin::setupTransformForKeepTransform):
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::multiply):
(WebCore::AffineTransform::rotate):
* platform/graphics/transforms/AffineTransform.h:
(WebCore::AffineTransform::operator*=):
(WebCore::AffineTransform::operator*):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/graphics/wince/SharedBitmap.cpp:
(WebCore::SharedBitmap::drawPattern):
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::clipToTextMask):
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::localToBorderBoxTransform):
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::calculateTransformationToOutermostSVGCoordinateSystem):
(WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::computeCTM):
(WebCore::SVGLocatable::getTransformToElement):
* svg/SVGMatrix.h:
(WebCore::SVGMatrix::multiply):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
(WebCore::SVGSVGElement::viewBoxToViewTransform):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::animatedLocalTransform):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::animatedLocalTransform):
* svg/SVGTransformList.cpp:
(WebCore::SVGTransformList::concatenate):
2011-01-19 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
The return value of contentEditable() function should depend on the DOM attribute
instead of render style userModify. The code change fixed test cases in the bug
and partially fixed test cases in other contentEditable bugs;
https://bugs.webkit.org/show_bug.cgi?id=52056
* html/HTMLElement.cpp:
(WebCore::HTMLElement::contentEditable):
2011-01-19 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Adler.
Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.
Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132
Test: editing/selection/caret-painting-in-overflowing-autowrap-content.html
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
2011-01-19 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
https://bugs.webkit.org/show_bug.cgi?id=52695
Added ASSERTs to the places we assume a non-null superlayer.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
2011-01-18 Beth Dakin <bdakin@apple.com>
Reviewed by Maciej Stachowiak.
Fix for <rdar://problem/8882916> Overlay scrollers require
content to layout underneath the scrollbar area
The render tree should not include scrollbar size for
overlay scrollers. This patch will allow scrollers on
the WebView to behave like overflow:overlay.
Treat overlay scrollers the same way as the !includeScrollbars
case.
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
No corner rect for overlay scrollers.
(WebCore::ScrollView::scrollCornerRect):
usesOverlayScrollbars() currently always returns no.
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::usesOverlayScrollbars):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
includeVerticalScrollbarSize() and includeHorizontalScrollbarSize()
should return false for overlay scrollers. They already return
false for overflow:overlay.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
* rendering/RenderBox.h:
In the render tree, always treat overlay scrollers like
they have a width and height of 0.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::verticalScrollbarWidth):
2011-01-18 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] simplify complex text code, fixing a handful of layout tests
https://bugs.webkit.org/show_bug.cgi?id=52661
Change ComplexTextControllerLinux to lay out RTL text to the left from
the starting point. (Previously it always went to the right.) This allows
us to map pixel offsets more directly into offsets within the text runs,
simplifying a few of the text-fiddling functions (they no longer need to
track the current position, as ComplexTextController now does it).
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::reset):
(WebCore::ComplexTextController::setGlyphXPositions):
* platform/graphics/chromium/ComplexTextControllerLinux.h:
(WebCore::ComplexTextController::offsetX):
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::glyphIndexForXPositionInScriptRun):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
2011-01-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move methods from InjectedScript domain into DOM,
Runtime and Debugger domains. Introduce InspectorRuntimeAgent.
https://bugs.webkit.org/show_bug.cgi?id=52717
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getCompletions):
(WebCore::InjectedScript::getCompletionsOnCallFrame):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::injectedScriptForMainWorld):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptSource.js:
(.):
():
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::releaseFrontendLifetimeAgents):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getNodeProperties):
(WebCore::InspectorDOMAgent::getNodePrototypes):
(WebCore::InspectorDOMAgent::injectedScriptForNodeId):
* inspector/InspectorDOMAgent.h:
(WebCore::EventListenerInfo::EventListenerInfo):
(WebCore::InspectorDOMAgent::DOMListener::~DOMListener):
(WebCore::InspectorDOMAgent::create):
(WebCore::InspectorDOMAgent::cast):
(WebCore::InspectorDOMAgent::documents):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
(WebCore::InspectorDebuggerAgent::injectedScriptForCallFrameId):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp: Added.
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::getCompletions):
(WebCore::InspectorRuntimeAgent::getProperties):
(WebCore::InspectorRuntimeAgent::setPropertyValue):
(WebCore::InspectorRuntimeAgent::pushNodeToFrontend):
(WebCore::InspectorRuntimeAgent::injectedScriptForObjectId):
* inspector/InspectorRuntimeAgent.h: Copied from Source/WebCore/inspector/InjectedScript.h.
(WebCore::InspectorRuntimeAgent::create):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
2011-01-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add UglifyJS parser and formatter files
https://bugs.webkit.org/show_bug.cgi?id=51702
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.ScriptFormatter.prototype.format.messageHandler):
(WebInspector.ScriptFormatter.prototype.format):
(WebInspector.ScriptFormatter.prototype._buildMapping):
(WebInspector.ScriptFormatter.prototype._convertPosition):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.formatSource.didFormat):
(WebInspector.SourceFrame.prototype.formatSource):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/parse-js.js: Added. UglifyJS parser.
* inspector/front-end/process.js: Added. UglifyJS formatter.
* inspector/front-end/scriptFormatterWorker.js: Added. Worker script that wraps UglifyJS code.
(onmessage):
(beautify):
(loadModule):
(require):
* inspector/front-end/utilities.js:
():
2011-01-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [JSC] scripts have incorrect starting line (always 1).
https://bugs.webkit.org/show_bug.cgi?id=52721
Test: inspector/debugger-scripts.html
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
(WebCore::ScriptDebugServer::sourceParsed):
* bindings/js/ScriptDebugServer.h:
* bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::startPosition):
(WebCore::StringSourceProvider::StringSourceProvider):
2011-01-19 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Send origin/url as part of speech input requests to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=52718
* page/SpeechInput.cpp:
(WebCore::SpeechInput::startRecognition): Pass up additional origin parameter.
* page/SpeechInput.h:
* page/SpeechInputClient.h:
* platform/mock/SpeechInputClientMock.cpp:
(WebCore::SpeechInputClientMock::startRecognition): Updated prototype.
* platform/mock/SpeechInputClientMock.h:
* rendering/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Pass the frame origin to speech input request.
2011-01-19 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Support auto-increment keys
https://bugs.webkit.org/show_bug.cgi?id=52576
Add support for auto-increment keys.
Test: storage/indexeddb/objectstore-autoincrement.html
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::genAutoIncrementKey):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
2011-01-19 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Laszlo Gombos and Tor Arne Vestbø.
[Qt] Remove unnecessary "../Source" from paths
after moving source files into Source is finished.
* WebCore.pri:
* WebCore.pro:
2011-01-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Employ TextPrompt for CSS property name/value autocompletion
https://bugs.webkit.org/show_bug.cgi?id=52212
WebInspector.CSSKeywordCompletions contains a hand-written list of accepted CSS property value keywords
for each property. WebInspector.TextPrompt is used to suggest both the name and value keywords while
editing styles, in place of the old custom suggestion code.
* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions.prototype.startsWith): Fix array-out-of-bounds error.
* inspector/front-end/CSSKeywordCompletions.js: Added.
(WebInspector.CSSKeywordCompletions.forProperty):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle):
(WebInspector.StylePropertyTreeElement.prototype):
():
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.removeFromElement):
(WebInspector.TextPrompt.prototype._onKeyDown):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype._moveBackInHistory):
(WebInspector.TextPrompt.prototype._moveForwardInHistory):
* inspector/front-end/inspector.css:
(.auto-complete-text, .editing .auto-complete-text):
* inspector/front-end/inspector.html:
2011-01-19 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Implement onformchange and onforminput event handlers
https://bugs.webkit.org/show_bug.cgi?id=26141
Tests: fast/forms/formchange-event.html
fast/forms/forminput-event.html
* bindings/scripts/CodeGeneratorGObject.pm: Added event names.
* dom/Document.h: Added event definitions.
* dom/Document.idl: Added event definitions.
* dom/Element.h: Added event definitions.
* dom/Element.idl: Added event definitions.
* dom/Event.cpp:
(WebCore::Event::fromUserGesture): Added a condition for a formchange event in handling user gestures.
* dom/EventNames.h: Added event definitions.
* dom/InputElement.cpp:
(WebCore::InputElement::setValueFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents(), a virtual function which broadcasts forminput events for HTML elements.
* dom/Node.cpp:
(WebCore::Node::dispatchInputEvents): Defined basic dispatchInputEvents() described above.
(WebCore::Node::dispatchChangeEvents): Defined basic dispatchChangeEvents() described above.
(WebCore::Node::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().
* dom/Node.h:
* html/FormAssociatedElement.h: Added isResettable() to check the element is resettable or not.
* html/HTMLAttributeNames.in: Added event names.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute): Added event handling.
(WebCore::HTMLElement::shadowAncestorOwnerForm): Added to get an ancestor <form> element from a shadow element.
(WebCore::HTMLElement::dispatchChangeEvents): Defined dispatchChangeEvents() for HTML elements described above.
(WebCore::HTMLElement::dispatchInputEvents): Defined dispatchInputEvents() for HTML elements described above.
* html/HTMLElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Added calling dispatchFormChange() to broadcast formchange events.
(WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Defined newly to dispatch an input event with broadcasting forminput events.
* html/HTMLFormControlElement.h: Added isResettable().
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::broadcastFormEvent): Added to broadcast forminput or formchange events.
(WebCore::HTMLFormElement::dispatchFormInput): Defined newly to broadcast forminput events.
(WebCore::HTMLFormElement::dispatchFormChange): Defined newly to broadcast formchange events.
* html/HTMLFormElement.h:
* html/HTMLFormElement.idl: Added dispatchFormInput() and dispatchFormChange() DOM API definitions.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::stepUpFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents().
* html/HTMLInputElement.h: Added isResettable().
* html/HTMLKeygenElement.h: Added isResettable().
* html/HTMLObjectElement.h: Added isResettable().
* html/HTMLOutputElement.h: Added isResettable().
* html/HTMLSelectElement.h: Added isResettable().
* html/HTMLTextAreaElement.h: Added isResettable().
* page/DOMWindow.h: Added event definitions.
* page/DOMWindow.idl: Added event definitions.
* rendering/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().
2011-01-19 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] delete pending callback from callback map before invoking it
https://bugs.webkit.org/show_bug.cgi?id=52707
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback):
2011-01-19 Levi Weintraub <leviw@google.com>
Reviewed by Ryosuke Niwa.
Replaced rangeCompliantEquivalent with Position::parentAnchoredEquivalent
and simplified the logic a bit. Unfortunately, Tables and some legacy
editing positions still need to be handled specifically.
remove rangeCompliantEquivalent and replace it with Position methods
https://bugs.webkit.org/show_bug.cgi?id=25057
No new tests as this is a refactor that doesn't change behavior.
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::caretRangeFromPoint):
* dom/Position.cpp:
(WebCore::Position::parentAnchoredEquivalent):
* dom/Position.h:
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeAt):
(WebCore::CompositeEditCommand::moveParagraphs):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializePositionData):
(WebCore::DeleteSelectionCommand::mergeParagraphs):
* editing/Editor.cpp:
(WebCore::Editor::textDirectionForSelection):
(WebCore::Editor::advanceToNextMisspelling):
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::shouldUseBreakElement):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::handleStyleSpansBeforeInsertion):
* editing/VisiblePosition.cpp:
(WebCore::makeRange):
(WebCore::setStart):
(WebCore::setEnd):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::firstRange):
(WebCore::VisibleSelection::toNormalizedRange):
(WebCore::makeSearchRange):
* editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
* editing/htmlediting.h:
* editing/visible_units.cpp:
(WebCore::previousBoundary):
(WebCore::nextBoundary):
* page/DOMSelection.cpp:
(WebCore::anchorPosition):
(WebCore::focusPosition):
(WebCore::basePosition):
(WebCore::extentPosition):
2011-01-19 Peter Rybin <peter.rybin@gmail.com>
Reviewed by Yury Semikhatsky.
Web Inspector: script column offset is incorrect
https://bugs.webkit.org/show_bug.cgi?id=52580
Column is updated in 3 places, 2 less probable places contained error.
Fixed now.
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::advanceSlowCase):
* platform/text/SegmentedString.h:
(WebCore::SegmentedString::advancePastNewline):
2011-01-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=52652
Calls served by the InjectedScript should be first class protocol
citizens, not dispatched via single protocol message.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::evaluateInCallFrame):
(WebCore::InjectedScript::evaluateOnSelf):
(WebCore::InjectedScript::getCompletions):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::pushNodeToFrontend):
(WebCore::InjectedScript::resolveNode):
(WebCore::InjectedScript::getNodeProperties):
(WebCore::InjectedScript::getNodePrototypes):
(WebCore::InjectedScript::setPropertyValue):
(WebCore::InjectedScript::makeCall):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::evaluate):
(WebCore::InjectedScriptHost::evaluateInCallFrame):
(WebCore::InjectedScriptHost::evaluateOnSelf):
(WebCore::InjectedScriptHost::getCompletions):
(WebCore::InjectedScriptHost::getProperties):
(WebCore::InjectedScriptHost::pushNodeToFrontend):
(WebCore::InjectedScriptHost::resolveNode):
(WebCore::InjectedScriptHost::getNodeProperties):
(WebCore::InjectedScriptHost::getNodePrototypes):
(WebCore::InjectedScriptHost::setPropertyValue):
(WebCore::InjectedScriptHost::injectedScriptForObjectId):
(WebCore::InjectedScriptHost::injectedScriptForNodeId):
(WebCore::InjectedScriptHost::injectedScriptForMainWorld):
* inspector/InjectedScriptHost.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
* inspector/InspectorController.h:
* inspector/InspectorValues.cpp:
(WebCore::InspectorObject::getNumber):
* inspector/InspectorValues.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.evaluateInTargetWindow):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype.doEvalInWindow):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
* inspector/front-end/InjectedScriptAccess.js: Removed.
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.callback):
(WebInspector.PropertiesSidebarPane.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.resolveNode):
(WebInspector.RemoteObject.prototype.getProperties):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.pushNodeToFrontend):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-01-18 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only a value type stored in the DOM map
https://bugs.webkit.org/show_bug.cgi?id=51683
Covered by the existing tests.
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::weakNodeCallback):
(WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
* bindings/v8/DOMDataStore.h:
* bindings/v8/V8DOMMap.h:
(WebCore::WeakReferenceMap::removeIfPresent):
2011-01-18 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of bools.
https://bugs.webkit.org/show_bug.cgi?id=52608
No new tests. no behavioral change.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/TextEvent.cpp:
(WebCore::TextEvent::create):
(WebCore::TextEvent::createForDrop):
(WebCore::TextEvent::TextEvent):
* dom/TextEvent.h:
(WebCore::TextEvent::isLineBreak):
(WebCore::TextEvent::isBackTab):
(WebCore::TextEvent::isPaste):
(WebCore::TextEvent::isDrop):
* dom/TextEventInputType.h: Added. Extracted from TextEvent::TextInputType.
* editing/EditorCommand.cpp:
(WebCore::executeInsertBacktab):
(WebCore::executeInsertLineBreak):
(WebCore::executeInsertNewline):
(WebCore::executeInsertTab):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTextInputEvent):
* page/EventHandler.h:
2011-01-18 Ben Vanik <ben.vanik@gmail.com>
Reviewed by Kenneth Russell.
Updating ANGLE in WebKit to r533.
https://bugs.webkit.org/show_bug.cgi?id=47194
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::validateShaderSource):
Update to new ANGLE API for shader validation.
* platform/graphics/ANGLEWebKitBridge.h:
(WebCore::ANGLEWebKitBridge::setResources):
Renaming types to new names.
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
Initialize ANGLEResources with ANGLE init call to prevent uninitialized variables.
2011-01-18 MORITA Hajime <morrita@google.com>
Reviewed by Simon Fraser.
Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664
RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::fillRoundedRect):
* platform/graphics/GraphicsContext.h:
* platform/graphics/RoundedIntRect.cpp: Added.
(WebCore::RoundedIntRect::Radii::isZero):
(WebCore::RoundedIntRect::Radii::scale):
(WebCore::RoundedIntRect::Radii::expand):
(WebCore::RoundedIntRect::Radii::includeLogicalEdges):
(WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
(WebCore::RoundedIntRect::RoundedIntRect):
(WebCore::RoundedIntRect::includeLogicalEdges):
(WebCore::RoundedIntRect::excludeLogicalEdges):
* platform/graphics/RoundedIntRect.h: Added.
(WebCore::RoundedIntRect::Radii::Radii):
(WebCore::RoundedIntRect::Radii::setTopLeft):
(WebCore::RoundedIntRect::Radii::setTopRight):
(WebCore::RoundedIntRect::Radii::setBottomLeft):
(WebCore::RoundedIntRect::Radii::setBottomRight):
(WebCore::RoundedIntRect::Radii::topLeft):
(WebCore::RoundedIntRect::Radii::topRight):
(WebCore::RoundedIntRect::Radii::bottomLeft):
(WebCore::RoundedIntRect::Radii::bottomRight):
(WebCore::RoundedIntRect::Radii::expand):
(WebCore::RoundedIntRect::Radii::shrink):
(WebCore::RoundedIntRect::rect):
(WebCore::RoundedIntRect::radii):
(WebCore::RoundedIntRect::isRounded):
(WebCore::RoundedIntRect::isEmpty):
(WebCore::RoundedIntRect::setRect):
(WebCore::RoundedIntRect::setRadii):
(WebCore::RoundedIntRect::move):
(WebCore::RoundedIntRect::inflate):
(WebCore::RoundedIntRect::inflateWithRadii):
(WebCore::RoundedIntRect::expandRadii):
(WebCore::RoundedIntRect::shrinkRadii):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderBoxModelObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawBoxSideFromPath):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
* rendering/style/BorderData.h:
* rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor):
(WebCore::calcConstraintScaleFor):
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBorderRadius):
2011-01-18 MORITA Hajime <morrita@google.com>
Reviewed by Simon Fraser.
Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664
RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.
No new tests. No behavioral change.
* Android.mk:
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::fillRoundedRect):
* platform/graphics/GraphicsContext.h:
* platform/graphics/RoundedIntRect.cpp: Added.
(WebCore::RoundedIntRect::Radii::isZero):
(WebCore::RoundedIntRect::Radii::scale):
(WebCore::RoundedIntRect::Radii::expand):
(WebCore::RoundedIntRect::Radii::includeLogicalEdges):
(WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
(WebCore::RoundedIntRect::RoundedIntRect):
(WebCore::RoundedIntRect::includeLogicalEdges):
(WebCore::RoundedIntRect::excludeLogicalEdges):
* platform/graphics/RoundedIntRect.h: Added.
(WebCore::RoundedIntRect::Radii::Radii):
(WebCore::RoundedIntRect::Radii::setTopLeft):
(WebCore::RoundedIntRect::Radii::setTopRight):
(WebCore::RoundedIntRect::Radii::setBottomLeft):
(WebCore::RoundedIntRect::Radii::setBottomRight):
(WebCore::RoundedIntRect::Radii::topLeft):
(WebCore::RoundedIntRect::Radii::topRight):
(WebCore::RoundedIntRect::Radii::bottomLeft):
(WebCore::RoundedIntRect::Radii::bottomRight):
(WebCore::RoundedIntRect::Radii::expand):
(WebCore::RoundedIntRect::Radii::shrink):
(WebCore::RoundedIntRect::rect):
(WebCore::RoundedIntRect::radii):
(WebCore::RoundedIntRect::isRounded):
(WebCore::RoundedIntRect::isEmpty):
(WebCore::RoundedIntRect::setRect):
(WebCore::RoundedIntRect::setRadii):
(WebCore::RoundedIntRect::move):
(WebCore::RoundedIntRect::inflate):
(WebCore::RoundedIntRect::inflateWithRadii):
(WebCore::RoundedIntRect::expandRadii):
(WebCore::RoundedIntRect::shrinkRadii):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderBoxModelObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawBoxSideFromPath):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
* rendering/style/BorderData.h:
* rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor):
(WebCore::calcConstraintScaleFor):
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBorderRadius):
2011-01-18 Victoria Kirst <vrk@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Adding support for YV16 video frame formats.
https://bugs.webkit.org/show_bug.cgi?id=52345
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::determineTextureFormat):
(WebCore::VideoLayerChromium::draw):
2011-01-18 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com
Exclude floating objects from shrinking to avoid floats. They should never do this. Timing-related bugs could
occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they
got encountered on the correct line exposed this issue.
Added /fast/block/float/float-overflow-hidden-containing-block-width.html.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkToAvoidFloats):
2011-01-18 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Make CheckedInt<long> and CheckedInt<unsigned long> work
https://bugs.webkit.org/show_bug.cgi?id=52401
* html/canvas/CheckedInt.h:
(WebCore::CheckedInt::CheckedInt): Merge with the patch provided by Benoit Jacob.
* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl): Use CheckedInt<long> instead of CheckedInt<int>.
(WebCore::WebGLBuffer::associateBufferSubDataImpl): Ditto.
2011-01-18 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Must strip comments from WebGL shaders before enforcing character set
https://bugs.webkit.org/show_bug.cgi?id=52390
Strip comments from incoming shaders, preserving line numbers,
before validating that they conform to the ESSL character set.
Revert changes from http://trac.webkit.org/changeset/75735 which
allowed invalid characters to be passed to certain APIs.
Tested with WebGL layout tests, conformance test suite and several
WebGL demos in both Safari and Chromium.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::StripComments::StripComments::process):
(WebCore::WebGLRenderingContext::shaderSource):
2011-01-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Stop instantiating legacy editing positions in DeleteSelectionCommand, IndentOudentCommand,
InsertLineBreakCommand, InsertListCOmmand.cpp, InsertParagraphSeparatorCommand, and htmlediting.cpp
https://bugs.webkit.org/show_bug.cgi?id=52644
This is a cleanup to stop instantiating legacy editing positions in the following tests.
firstDeepEditingPositionForNode and lastDeepEditingPositionForNode in htmlediting.h are not updated
because doing so requires significant code changes. They are tracked on the bug 52642.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializeStartEnd):
(WebCore::updatePositionForNodeRemoval):
(WebCore::DeleteSelectionCommand::removeNode):
(WebCore::updatePositionForTextRemoval):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph):
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph):
(WebCore::InsertListCommand::unlistifyParagraph):
(WebCore::InsertListCommand::listifyParagraph):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
* editing/htmlediting.cpp:
(WebCore::enclosingBlock):
(WebCore::enclosingList):
(WebCore::enclosingListChild):
(WebCore::indexForVisiblePosition):
(WebCore::isNodeVisiblyContainedWithin):
(WebCore::avoidIntersectionWithNode):
2011-01-18 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch
https://bugs.webkit.org/show_bug.cgi?id=52610
This is a purely aesthetic change.
* editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::advance):
* editing/visible_units.cpp:
(WebCore::previousBoundary):
2011-01-18 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
https://bugs.webkit.org/show_bug.cgi?id=42236
* platform/chromium/ChromiumBridge.h:
* platform/chromium/WidgetChromium.cpp:
(WebCore::Widget::setCursor):
2011-01-18 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
REGRESSION: A problem with Voiceover and finding links
https://bugs.webkit.org/show_bug.cgi?id=52324
Fallout from recent change to make WebCore return its own scroll view.
1) There were two scroll views in the hierarchy, one which no needed to be ignored.
2) Hit tests for sub frames needed to be offset.
3) The check for whether an attachment is ignored must happen earlier than using
the helpText to determine if an element should be ignored.
Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper scrollViewParent]):
2011-01-18 Adam Roben <aroben@apple.com>
Call alternate CFHTTPCookie functions if available
Fixes <http://webkit.org/b/52637> <rdar://problem/8878984>.
Reviewed by Darin Adler.
* platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to
pull in the alternate CFHTTPCookie functions.
(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
Added these wrappers around the CFHTTPCookie functions. We call the
alternate functions if they exist, otherwise fall back to the current
functions.
(WebCore::filterCookies):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
Changed to use the wrapper functions.
2011-01-18 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Filenames are converted to URLs during edit drags
https://bugs.webkit.org/show_bug.cgi?id=52096
* platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the
conversion policy allows it.
(WebCore::DragData::containsURL): Ditto.
(WebCore::DragData::asURL): Ditto.
2011-01-18 Helder Correia <helder@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52611
This is related to bug 52559. The shadow color alpha must be multiplied
by the context brush alpha.
Test: fast/canvas/canvas-fillPath-alpha-shadow.html
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
2011-01-18 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: fail resource.requestContent() immediately for WebSocket resources
https://bugs.webkit.org/show_bug.cgi?id=52628
* English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
* inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete)
(WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
* inspector/front-end/Resource.js:
(WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used.
(WebInspector.Resource.Type.toString): ditto.
(WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
* inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
2011-01-18 Helder Correia <helder@sencha.com>
Reviewed by Dirk Schulze.
REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531
r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.
Test: svg/css/text-gradient-shadow.svg
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRect):
2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Nikolas Zimmermann.
Unable to indirectly animate visibility of SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=50240
SVGUseElement::recalcStyle should take care of its shadow
tree's style recalculation when it is called with change >= Inherit
or when childNeedsStyleRecalc() is true because in these two
cases needStyleRecalc() may not be true.
Test: svg/custom/use-inherit-style.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::recalcStyle):
2011-01-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: provide script length to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52620
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
* inspector/front-end/Script.js:
(WebInspector.Script):
2011-01-18 Zoltan Herczeg <zherczeg@webkit.org>
Rubber-stamped by Csaba Osztrogonác
Fixing ChangeLog
Removing a line introduced by
http://trac.webkit.org/changeset/75743/trunk/Source/WebCore/ChangeLog
Removing an unnecessary space before a time stamp.
2011-01-17 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [refactoring] use events to notify NetworkManager clients
https://bugs.webkit.org/show_bug.cgi?id=52588
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView): Do not expose public interface to resource count. Do not reset resource count upon reset().
(WebInspector.AuditLauncherView.prototype._resetResourceCount):
(WebInspector.AuditLauncherView.prototype._onResourceStarted):
(WebInspector.AuditLauncherView.prototype._onResourceFinished):
* inspector/front-end/AuditsPanel.js: Do not expose public interface to resource start/finish events.
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceFinished):
(WebInspector.ExtensionServer.prototype.initExtensions):
* inspector/front-end/NetworkManager.js: Dispatch events rather than directly call clients.
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.willSendRequest):
(WebInspector.NetworkManager.prototype.markResourceAsCached):
(WebInspector.NetworkManager.prototype.didReceiveResponse):
(WebInspector.NetworkManager.prototype.didReceiveContentLength):
(WebInspector.NetworkManager.prototype.setInitialContent):
(WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
(WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
(WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
(WebInspector.NetworkManager.prototype._startResource):
(WebInspector.NetworkManager.prototype._finishResource):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype._onResourceStarted):
(WebInspector.NetworkPanel.prototype._appendResource):
(WebInspector.NetworkPanel.prototype._onResourceUpdated):
(WebInspector.NetworkPanel.prototype._refreshResource):
(WebInspector.NetworkPanel.prototype._onMainResourceChanged):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._refreshResource):
2011-01-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: preserve pause on exception state in settings.
https://bugs.webkit.org/show_bug.cgi?id=52619
* inspector/InspectorController.cpp:
(WebCore::InspectorController::getInspectorState):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
(WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState):
(WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone.populateInspectorState):
2011-01-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
https://bugs.webkit.org/show_bug.cgi?id=52623
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage):
2011-01-18 Pavel Feldman <pfeldman@chromium.org>
Revert r76017. No need to guard InspectorInstrumentation:: in WebCore.
* page/Page.cpp:
(WebCore::networkStateChanged):
2011-01-18 Konstantin Tokarev <annulen@yandex.ru>
Reviewed by Kent Tamura.
Fixed compilation when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=52564
* page/Page.cpp:
(WebCore::networkStateChanged): Added ENABLE(INSPECTOR) guard
2011-01-18 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r76004, r76005, r76007, and r76011.
http://trac.webkit.org/changeset/76004
http://trac.webkit.org/changeset/76005
http://trac.webkit.org/changeset/76007
http://trac.webkit.org/changeset/76011
https://bugs.webkit.org/show_bug.cgi?id=51664
The r76004 broke pixel tests.
(The failure was missed due to the tolerance.)
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
* platform/graphics/GraphicsContext.h:
* platform/graphics/RoundedIntRect.cpp: Removed.
* platform/graphics/RoundedIntRect.h: Removed.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::uniformlyExpandBorderRadii):
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderBoxModelObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawBoxSideFromPath):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
* rendering/style/BorderData.h:
* rendering/style/RenderStyle.cpp:
(WebCore::constrainCornerRadiiForRect):
(WebCore::RenderStyle::getBorderRadiiForRect):
(WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
* rendering/style/RenderStyle.h:
2011-01-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add source column field to debugger call frames.
https://bugs.webkit.org/show_bug.cgi?id=52443
* bindings/js/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
* bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::update):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::column):
* bindings/v8/JavaScriptCallFrame.h:
* inspector/InjectedScriptSource.js:
():
* inspector/JavaScriptCallFrame.idl:
2011-01-18 Antti Koivisto <antti@apple.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites
The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.
This patch gets the style sharing back to 25-40% range on most web sites.
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::propertiesEqual):
Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.
* css/CSSSelector.h:
(WebCore::CSSSelector::isSiblingSelector):
Test for selectors that are affected by the sibling elements.
* css/CSSStyleSelector.cpp:
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::assertNoSiblingRulesInDefaultStyle):
Extract sibling rules from the MathML default stylesheet.
Assert that no other default stylesheet has them.
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):
Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
where style sharing can't be used.
* css/CSSStyleSelector.h:
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mappedMapsEquivalent):
Check also for CSSValue mutation from DOM.
* mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedIntoDocument):
* mathml/MathMLMathElement.h:
MathML default style sheet has sibling rules which don't get noticed by the normal document
stylesheet parsing.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setFirstChildState):
(WebCore::InheritedFlags::setLastChildState):
(WebCore::InheritedFlags::setChildIndex):
These all make style non-shareable (unique).
2011-01-18 MORITA Hajime <morrita@google.com>
Unreviewed crash fix on release builds.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
2011-01-18 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, update localizedStrings.js.
* English.lproj/localizedStrings.js:
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: implement script beautifier prototype.
https://bugs.webkit.org/show_bug.cgi?id=51588
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ScriptFormatter.js: Added.
(WebInspector.ScriptFormatter): Implements JavaScript source beautification and conversion between original and
formatted line numbers
(WebInspector.ScriptFormatter.findLineEndings):
(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.ScriptFormatter.upperBound):
(WebInspector.ScriptFormatter.prototype.format):
(WebInspector.ScriptFormatter.prototype.originalLineNumberToFormattedLineNumber):
(WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalLineNumber):
(WebInspector.ScriptFormatter.prototype.originalPositionToFormattedLineNumber):
(WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalPosition):
(WebInspector.ScriptFormatter.prototype._convertPosition):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._formatScript):
* inspector/front-end/SourceFrame.js: Convert original line numbers to UI line numbers and vice versa
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2011-01-18 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK build fix as follow-up of r76004.
* GNUmakefile.am: Include RoundedIntRect files in the build
2011-01-18 Philippe Normand <pnormand@igalia.com>
Unreviewed, rolling out r76002.
http://trac.webkit.org/changeset/76002
https://bugs.webkit.org/show_bug.cgi?id=49790
breaks a bunch of fast/forms tests on mac and GTK
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setRenderStyle):
2011-01-18 MORITA Hajime <morrita@google.com>
Unreviewed windows build fix.
* WebCore.vcproj/WebCore.vcproj:
2011-01-17 MORITA Hajime <morrita@google.com>
Reviewed by Simon Fraser.
Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664
RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.
No new tests. No behavioral change.
* Android.mk:
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::fillRoundedRect):
* platform/graphics/GraphicsContext.h:
* platform/graphics/RoundedIntRect.cpp: Added.
(WebCore::RoundedIntRect::Radii::isZero):
(WebCore::RoundedIntRect::Radii::scale):
(WebCore::RoundedIntRect::Radii::expand):
(WebCore::RoundedIntRect::Radii::includeLogicalEdges):
(WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
(WebCore::RoundedIntRect::RoundedIntRect):
(WebCore::RoundedIntRect::includeLogicalEdges):
(WebCore::RoundedIntRect::excludeLogicalEdges):
* platform/graphics/RoundedIntRect.h: Added.
(WebCore::RoundedIntRect::Radii::Radii):
(WebCore::RoundedIntRect::Radii::setTopLeft):
(WebCore::RoundedIntRect::Radii::setTopRight):
(WebCore::RoundedIntRect::Radii::setBottomLeft):
(WebCore::RoundedIntRect::Radii::setBottomRight):
(WebCore::RoundedIntRect::Radii::topLeft):
(WebCore::RoundedIntRect::Radii::topRight):
(WebCore::RoundedIntRect::Radii::bottomLeft):
(WebCore::RoundedIntRect::Radii::bottomRight):
(WebCore::RoundedIntRect::Radii::expand):
(WebCore::RoundedIntRect::Radii::shrink):
(WebCore::RoundedIntRect::location):
(WebCore::RoundedIntRect::size):
(WebCore::RoundedIntRect::x):
(WebCore::RoundedIntRect::y):
(WebCore::RoundedIntRect::width):
(WebCore::RoundedIntRect::height):
(WebCore::RoundedIntRect::right):
(WebCore::RoundedIntRect::bottom):
(WebCore::RoundedIntRect::rect):
(WebCore::RoundedIntRect::radii):
(WebCore::RoundedIntRect::isRounded):
(WebCore::RoundedIntRect::isEmpty):
(WebCore::RoundedIntRect::setRect):
(WebCore::RoundedIntRect::setRadii):
(WebCore::RoundedIntRect::move):
(WebCore::RoundedIntRect::inflate):
(WebCore::RoundedIntRect::inflateWithRadii):
(WebCore::RoundedIntRect::expandRadii):
(WebCore::RoundedIntRect::shrinkRadii):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/RenderBoxModelObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawBoxSideFromPath):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
* rendering/style/BorderData.h:
* rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor):
(WebCore::calcConstraintScaleFor):
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBorderRadius):
2011-01-17 Rob Buis <rwlbuis@gmail.com>
Reviewed by Kent Tamura.
Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790
Redirect style changes on <option> element to the owner <select> element.
Tests: fast/forms/select-option-background-color-change.html
fast/forms/select-option-color-change.html
fast/forms/select-option-visibility-change.html
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setRenderStyle):
2011-01-17 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r75995.
http://trac.webkit.org/changeset/75995
https://bugs.webkit.org/show_bug.cgi?id=51914
Causes assertion failures.
* dom/Element.cpp:
(WebCore::Element::shadowRoot):
(WebCore::Element::setShadowRoot):
(WebCore::Element::removeShadowRoot):
* dom/ElementRareData.h:
(WebCore::ElementRareData::ElementRareData):
2011-01-17 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r75999.
http://trac.webkit.org/changeset/75999
* dom/Element.cpp:
(WebCore::Element::removeShadowRoot):
2011-01-17 MORITA Hajime <morrita@google.com>
Unreviewed crash fix, which introduced at r75995
* dom/Element.cpp:
(WebCore::Element::removeShadowRoot):
2011-01-17 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
ElementRareData::m_shadowRoot should not be RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=51914
This change makes m_shadowRoot a raw pointer, as Node::m_parent is.
This change is safe because shadow host pointer is stored as TreeShared::m_parent
which prevents deletion unless set to null.
No test, no behavioral change.
* dom/Element.cpp:
(WebCore::Element::shadowRoot):
(WebCore::Element::setShadowRoot):
(WebCore::Element::removeShadowRoot):
* dom/ElementRareData.h:
(WebCore::ElementRareData::ElementRareData):
2011-01-17 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Some WebKit2 layout tests crash due to focus being on a frame in the page cache
https://bugs.webkit.org/show_bug.cgi?id=52607
No new tests. Existing tests crash in WebKit2 without this fix.
I suspect there are other consequences besides the WebKit2 crash, but I
was unable to identify any for certain.
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame): If a frame still has focus when its page
goes in the page cache, reset focus to the main frame.
2011-01-17 Adam Roben <aroben@apple.com>
Simplify WKCACFLayerRenderer's API
createRenderer/destroyRenderer are now hidden behind setHostWindow.
WKCACFLayerRendererClient::animationsStarted has been removed, as it
was never called. (The work it was supposed to do was already being
accomplished by WKCACFLayerRenderer::render telling each layer that
animations are starting.)
Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use
Reviewed by Chris Marrin.
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Moved the
call to setHostWindow here from the WM_CREATE handler. The WM_CREATE
handler was causing the Direct3D device to be created, but MSDN says
you shouldn't create a device while handling WM_CREATE. Removed
no-longer-needed call to createRenderer (setHostWindow does this now)
and the never-needed call to setNeedsDisplay (we never draw into the
root layer; this was just creating an unnecessary backing store the
size of the screen!).
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Moved WM_CREATE
code, as described above. Removed call to destroyRenderer when handling
WM_DESTROY; setHostWindow does this now. Fixed up our WM_PAINT handler
to do a synchronous paint and to clear our dirty region, while I was in
here.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Changed to call
setHostWindow instead of destroyRenderer; the former calls the latter
if needed.
(WebCore::WKCACFLayerRenderer::setHostWindow): Moved here from the
header file. Destroys our old renderer (i.e., IDirect3DDevice9) if
we're losing our window, or creates a renderer if we're gaining a
window.
(WebCore::WKCACFLayerRenderer::createRenderer): Updated for WKSI function rename.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Changed to clear the
D3D device from our context before releasing the device.
* platform/graphics/win/WKCACFLayerRenderer.h: Removed
WKCACFLayerRendererClient::animationsStarted. Removed setNeedsDisplay.
Make createRenderer, destroyRenderer, and renderSoon private.
2011-01-17 Adam Roben <aroben@apple.com>
Remove special-cased support for providing content for the root layer
Clients will just have to provide content through the normal
GraphicsLayer channels now!
Support for <http://webkit.org/b/52582> WebView should paint directly
into a GraphicsLayer when in accelerated compositing mode
Reviewed by Simon Fraser and Chris Marrin.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Removed
initialization of m_backingStoreDirty, which has itself been removed.
(WebCore::WKCACFLayerRenderer::setNeedsDisplay): Moved code to schedule
a sync from here to syncCompositingStateSoon. We only need to call
renderSoon if we don't call syncCompositingStateSoon; the latter
function calls the former.
(WebCore::WKCACFLayerRenderer::paint): Removed code to handle
m_backingStoreDirty. We don't want to know anything about clients'
backing stores.
(WebCore::WKCACFLayerRenderer::syncCompositingStateSoon): Added. Code
came from setNeedsDisplay.
* platform/graphics/win/WKCACFLayerRenderer.h:
Removed setRootContents[AndDisplay], setBackingStoreDirty, and
m_backingStoreDirty. Made paint() public so that clients can force a
synchronous render (e.g., when handling WM_PAINT).
2011-01-17 Adam Roben <aroben@apple.com>
Remove contexts from WKCACFContextFlusher before destroying them
We aren't really using WKCACFContextFlusher for anything useful at the
moment, but that will probably change in the near future.
I couldn't come up with a way to test this because it isn't possible to
resize a window in DumpRenderTree.
Fixes <http://webkit.org/b/52573> REGRESSION (r75262): Crash beneath
WKCACFContextFlusher::flushAllContexts when resizing window on page
that uses accelerated compositing
Reviewed by Simon Fraser.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Remove our
context from WKCACFContextFlusher. (This code was erroneously removed
from WKCACFLayerRenderer::destroyRenderer in r75262. This is a more
sensible place for it.)
2011-01-17 Adam Roben <aroben@apple.com>
Don't access the CACFLayerRef's sublayers directly from PlatformCALayer
There might be a secret extra sublayer (the tile parent layer) that
PlatformCALayer doesn't know about. When PlatformCALayer would
encounter this, it would try to use the tile parent layer's
PlatformCALayer wrapper, which was null, and then would crash. We now
ask PlatformCALayerWinInternal for the sublayer list, since that class
knows about the tile parent layer and can exclude it from the sublayer
list.
Covered by compositing/tiling/huge-layer-resize.html.
Fixes <http://webkit.org/b/52597> Crash beneath
PlatformCALayer::adoptSublayers when switching out of tiling mode
(null-dereference of a PlatformCALayer)
Reviewed by Darin Adler and Chris Marrin.
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::adoptSublayers):
(printLayer):
Changed to use PlatformCALayerWinInternal::getSublayers.
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
of PlatformCALayers that represent our sublayers. Significantly, this
code knows about the tile parent layer and can thus exclude it.
* platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added
getSublayers.
2011-01-17 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
[Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382
http://crbug.com/60427
Calculate correct location of popup window whenever the items in the window change.
No new tests, because this fix is for Chromium project and hard to test only in WebKit project
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect): New Function to layout and calculate popup widget rect.
(WebCore::PopupContainer::showPopup): Move widgetRect calculation logic to calculateWidgetRect().
(WebCore::PopupContainer::refresh): Add parameter focusRect to take the location and the size of focus text input field to calculate correct popup window location.
* platform/chromium/PopupMenuChromium.h: Append new input parameter for refresh().
2011-01-17 Mark Rowe <mrowe@apple.com>
Fix the 32-bit build.
* WebCore.exp.in:
2011-01-17 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font
https://bugs.webkit.org/show_bug.cgi?id=52598
Test: fast/css/font-face-zero-hash-key.html
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData): Ditto.
2011-01-17 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
Reviewed by Dan Bernstein.
This fixes two issues:
Add missing DOMDocumentFragmentPrivate.h and
DOMDocumentPrivate.h files to the project. These files were
never added to the the project although their *Internal.h
counterparts were added in r16548 and r17390.
Add missing DOMDocumentFragmentInternal.h to the Headers
section. It was moved from Headers to "Copy Generated Headers"
in r31045, but it should have an entry in both sections.
* WebCore.xcodeproj/project.pbxproj:
2011-01-17 Helder Correia <helder@sencha.com>
Reviewed by Andreas Kling.
[Qt] Incorrect shadow alpha with pattern fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52559
The shadow color opacity needs to be set on the shadow painter.
This is related to bug 52556.
Test: fast/canvas/canvas-fillPath-pattern-shadow.html
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
2011-01-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[GTK] Port a crash fix from libsoup upstream to the libsoup cache code
https://bugs.webkit.org/show_bug.cgi?id=52586
No new tests. This is just a merge from upstream.
* platform/network/soup/cache/soup-http-input-stream.c:
(webkit_soup_http_input_stream_got_chunk): Properly handle unsigned numbers.
2011-01-17 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545
No new tests because no new functionality.
* ForwardingHeaders/runtime/InitializeThreading.h:
* editing/SmartReplace.h:
* loader/CrossOriginAccessControl.h:
* loader/NetscapePlugInStreamLoader.h:
* platform/chromium/ClipboardUtilitiesChromium.h:
* platform/graphics/cairo/DrawErrorUnderline.h:
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
* platform/graphics/cg/PDFDocumentImage.h:
* platform/win/WebCoreTextRenderer.h:
2011-01-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow-up fix for r52574: do not reuse clear() for navigation.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.clear):
(WebInspector.NetworkPanel.prototype.mainResourceChanged):
2011-01-17 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] No need to content sniff 304 Not Modified responses
https://bugs.webkit.org/show_bug.cgi?id=52570
Makes no sense to wait for the outcome of content sniffing when WebCore
is validating resources. If we get a 304 Not Modified it means that we can
safely use the cached version of the resource we're asking for.
No new tests because it does not change functionality, it just
calls didReceiveResponse sooner for 304 Not Modified responses.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::gotHeadersCallback):
2011-01-17 Jessie Berlin <jberlin@apple.com>
Reviewed by Anders Carlsson.
REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
navigating back to an unreachable URL
https://bugs.webkit.org/show_bug.cgi?id=52388
Test: http/tests/navigation/go-back-to-error-page.html
* history/PageCache.cpp:
(WebCore::PageCache::canCachePageContainingThisFrame):
Do not cache any error pages (which we can recognize as having substitute data and/or an
unreachableURL).
2011-01-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fixing typo in r75952.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
2011-01-17 Enrica Casucci <enrica@apple.com>
Reviewed by Alexey Proskuryakov.
Drag and drop support: refactoring of image from link and image from selection
https://bugs.webkit.org/show_bug.cgi?id=52496
This work cleans up the Mac code and makes it more similar to the Windows implementation,
avoiding the use of an NSView when the FrameView can be used.
The refactoring is a necessary step towards the complete support of drag and drop
in WebKit2.
* page/mac/FrameMac.mm:
(WebCore::Frame::imageFromRect): Modified to use FrameView instead of NSView
to generate the image for drag.
2011-01-17 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Mark Rowe.
Update xcodeproj svn:ignore to include xcuserdata.
* WebCore.xcodeproj: Modified property svn:ignore.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.
2011-01-17 Alexey Proskuryakov <ap@apple.com>
Leopard build fix.
* page/PrintContext.cpp: GCC complained about shortening a double value to float.
2011-01-17 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=52495
No change in behavior, so no tests.
* WebCore.exp.in: Export additional methods, as I'm going to use more code from PrintContext.
* page/PrintContext.cpp:
(WebCore::PrintContext::~PrintContext): No need to clear m_pageRects, the object is being
destroyed already.
(WebCore::PrintContext::pageCount): Changed page count from int to size_t.
(WebCore::PrintContext::pageRect): Ditto.
(WebCore::PrintContext::computePageRects): Pass allowHorizontalTiling as an argument.
PrintContext already has code to calculate scale factor, so it makes sense to make methods
that contain it universal (allowHorizontalTiling is always true for Safari).
Round page height to an integer, because Mac code does that, and because page height is
treated as integer almost everywhere else in code.
(WebCore::PrintContext::begin): Allow calling this function multiple times. There is no need
to return to screen mode if e.g. "print backgounds" option changes.
(WebCore::PrintContext::computeAutomaticScaleFactor): Expose scale factor computation, so
that clients don't have to copy it.
(WebCore::PrintContext::spoolRect): Add a way to spool a precomputed rect - handy if a request
comes from code that doesn't have page number.
(WebCore::PrintContext::pageNumberForElement): Page number int -> size_t.
* page/PrintContext.h: Added comments and FIXMEs. PrintContext needs cleanup, but that
depends on deciding how it really needs to work (e.g. whether computePageRects() should
cause relayout).
2011-01-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: unify image data source assignment, add image url
to the image view properties list.
https://bugs.webkit.org/show_bug.cgi?id=52584
* English.lproj/localizedStrings.js:
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
(WebInspector.ImageView.prototype._createContentIfNeeded):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.populateImageSource):
(WebInspector.Resource.prototype._contentURL):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype.onattach):
2011-01-17 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
Make resource start/finish hanlding more consistent.
https://bugs.webkit.org/show_bug.cgi?id=52452
* inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator
(WebInspector.AuditLauncherView.prototype._resetResourceCount):
(WebInspector.AuditLauncherView.prototype.resourceStarted):
(WebInspector.AuditLauncherView.prototype.resourceFinished):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource()
(WebInspector.NetworkManager.prototype.identifierForInitialRequest):
(WebInspector.NetworkManager.prototype.willSendRequest):
(WebInspector.NetworkManager.prototype.markResourceAsCached):
(WebInspector.NetworkManager.prototype.didReceiveResponse):
(WebInspector.NetworkManager.prototype.didReceiveContentLength):
(WebInspector.NetworkManager.prototype.didFinishLoading):
(WebInspector.NetworkManager.prototype.didFailLoading):
(WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
(WebInspector.NetworkManager.prototype.didCreateWebSocket):
(WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
(WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
(WebInspector.NetworkManager.prototype.didCloseWebSocket):
(WebInspector.NetworkManager.prototype._appendRedirect):
(WebInspector.NetworkManager.prototype._startResource):
(WebInspector.NetworkManager.prototype._finishResource):
2011-01-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: restore dom and network state upon frontend reuse.
https://bugs.webkit.org/show_bug.cgi?id=52574
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreInspectorStateFromCookie):
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::pushDataCollectedOffline):
(WebCore::InspectorController::didCommitLoad):
* inspector/InspectorController.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.reset):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.clear):
(WebInspector.NetworkPanel.prototype.mainResourceChanged):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype.reloadCachedResources):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.clear):
* inspector/front-end/inspector.js:
(WebInspector.frontendReused):
2011-01-17 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix after r75944.
* WebCore.pro:
2011-01-17 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249
Make MediaPlayerPrivateQt support a fullscreen player.
No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
So, still skip it for Qt.
* WebCore.pro:
* features.pri:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::removeVideoItem):
(WebCore::MediaPlayerPrivateQt::restoreVideoItem):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(WebCore::MediaPlayerPrivateQt::supportsFullscreen):
(WebCore::MediaPlayerPrivateQt::mediaPlayer):
2011-01-17 Anthony Ricaud <rik@webkit.org>
Reviewed by Kent Tamura.
[HTML5] Revert display:none on datalist
https://bugs.webkit.org/show_bug.cgi?id=52214
* css/html.css:
2011-01-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreDebugger):
(WebCore::InspectorController::showAndEnableDebugger):
(WebCore::InspectorController::enableDebugger):
* inspector/InspectorController.h:
* inspector/front-end/DebuggerModel.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.show):
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
2011-01-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51738
Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
(WebInspector.SourceFrameContentProviderForScript):
(WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource):
(WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
(WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addScript):
(WebInspector.ScriptsPanel.prototype.sourceFrameForScript):
(WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.set visible):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype._breakpointAdded):
(WebInspector.SourceFrame.prototype._breakpoints):
(WebInspector.SourceFrame.prototype._sourceIDForLine):
(WebInspector.SourceFrame.prototype._sourceIDSet):
(WebInspector.SourceFrameContentProvider):
(WebInspector.SourceFrameContentProvider.prototype.requestContent):
(WebInspector.SourceFrameContentProvider.prototype.scripts):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
(WebInspector.SourceView.prototype.show):
(WebInspector.SourceView.prototype.resize):
(WebInspector.SourceView.prototype.performSearch.didFindSearchMatches):
(WebInspector.SourceView.prototype.performSearch):
(WebInspector.SourceView.prototype.revealLine):
(WebInspector.SourceView.prototype.highlightLine):
(WebInspector.SourceView.prototype._jumpToSearchResult):
(WebInspector.SourceFrameContentProviderForResource):
(WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
(WebInspector.SourceFrameContentProviderForResource.prototype.scripts):
2011-01-17 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
GeolocationController should call stopUpdating on destruction
https://bugs.webkit.org/show_bug.cgi?id=52216
Test: fast/dom/Geolocation/window-close-crash.html
* page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController):
2011-01-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Qt build fix.
* inspector/InspectorInstrumentation.h:
2011-01-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make WebCore use InspectorInstrumentation
for instrumentation calls.
https://bugs.webkit.org/show_bug.cgi?id=52532
This change makes WebCore classes issue instrumentation signals
by means of InspectorInstrumentation interface. It covered migration
for Document, FrameLoader, Database, DOMStorage, etc. It fixed
instrumentation handling for Console as well. This all is a part
of story described in the bug 52510.
* dom/Document.cpp:
(WebCore::Document::finishedParsing):
* dom/Document.h:
* dom/ScriptExecutionContext.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorBrowserDebuggerAgent.h:
(WebCore::InspectorBrowserDebuggerAgent::create):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::handleMousePress):
(WebCore::InspectorController::didClearWindowObjectInWorld):
(WebCore::PostWorkerNotificationToFrontendTask::performTask):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl):
(WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
(WebCore::InspectorInstrumentation::handleMousePressImpl):
(WebCore::InspectorInstrumentation::mainResourceFiredLoadEventImpl):
(WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEventImpl):
(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::consoleCountImpl):
(WebCore::InspectorInstrumentation::startConsoleTimingImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
(WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
(WebCore::InspectorInstrumentation::didCreateWorkerImpl):
(WebCore::InspectorInstrumentation::didDestroyWorkerImpl):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
(WebCore::InspectorInstrumentation::networkStateChangedImpl):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::inspectorControllerCreated):
(WebCore::InspectorInstrumentation::inspectorControllerDeleted):
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
(WebCore::InspectorInstrumentation::inspectedPageDestroyed):
(WebCore::InspectorInstrumentation::willInsertDOMNode):
(WebCore::InspectorInstrumentation::didInsertDOMNode):
(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
(WebCore::InspectorInstrumentation::handleMousePress):
(WebCore::InspectorInstrumentation::characterDataModified):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
(WebCore::InspectorInstrumentation::didScheduleResourceRequest):
(WebCore::InspectorInstrumentation::didInstallTimer):
(WebCore::InspectorInstrumentation::didRemoveTimer):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::willChangeXHRReadyState):
(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::willEvaluateScript):
(WebCore::InspectorInstrumentation::willFireTimer):
(WebCore::InspectorInstrumentation::willLayout):
(WebCore::InspectorInstrumentation::willLoadXHR):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::willRecalculateStyle):
(WebCore::InspectorInstrumentation::identifierForInitialRequest):
(WebCore::InspectorInstrumentation::willSendRequest):
(WebCore::InspectorInstrumentation::markResourceAsCached):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
(WebCore::InspectorInstrumentation::willReceiveResourceData):
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didReceiveContentLength):
(WebCore::InspectorInstrumentation::didFinishLoading):
(WebCore::InspectorInstrumentation::didFailLoading):
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorInstrumentation::scriptImported):
(WebCore::InspectorInstrumentation::mainResourceFiredLoadEvent):
(WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEvent):
(WebCore::InspectorInstrumentation::frameDetachedFromParent):
(WebCore::InspectorInstrumentation::didCommitLoad):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didOpenDatabase):
(WebCore::InspectorInstrumentation::didUseDOMStorage):
(WebCore::InspectorInstrumentation::didCreateWorker):
(WebCore::InspectorInstrumentation::didDestroyWorker):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
(WebCore::InspectorInstrumentation::networkStateChanged):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::startConsoleTiming):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleMarkTimeline):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
(WebCore::InspectorInstrumentation::inspectorControllerForContext):
(WebCore::InspectorInstrumentation::inspectorControllerForFrame):
(WebCore::InspectorInstrumentation::inspectorControllerForPage):
(WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForContext):
(WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForDocument):
(WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForFrame):
(WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
* inspector/InspectorState.cpp:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoader::dispatchDidCommitLoad):
* page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
* page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::count):
(WebCore::Console::markTimeline):
(WebCore::Console::profile):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
(WebCore::Console::groupEnd):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
(WebCore::DOMWindow::dispatchLoadEvent):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
* page/Page.cpp:
(WebCore::Page::~Page):
* storage/Database.cpp:
(WebCore::Database::openDatabase):
* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::onDestroyWorker):
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
* workers/Worker.cpp:
(WebCore::Worker::create):
* workers/WorkerMessagingProxy.cpp:
2011-01-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed, rolling out r75923.
GTK guy rolls out the r75914.
* platform/efl/ScrollViewEfl.cpp:
(WebCore::ScrollView::platformInit):
2011-01-17 Helder Correia <helder@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=52556
The shadow color opacity needs to be set on the shadow painter.
Additionally, the gradient brush should be transformed.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
2011-01-17 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Background image rendering is slow
https://bugs.webkit.org/show_bug.cgi?id=50527
When tiling a scaled pixmap in Image::drawPattern, scale the tile
first and only then draw it to the target. Do so only when drawing
more than one tile.
Tests in fast/backgrounds/size cover this.
* platform/graphics/qt/ImageQt.cpp:
(WebCore::Image::drawPattern):
2011-01-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] [Symbian] Fix building NPAPI support
https://bugs.webkit.org/show_bug.cgi?id=51981
Make sure that npapi.h is always included outside of the extern "C"
linkage declaration block.
No new tests as there is no new functionality.
* bridge/npruntime.h:
2011-01-17 Philippe Normand <pnormand@igalia.com>
Unreviewed, rolling out r75914.
http://trac.webkit.org/changeset/75914
https://bugs.webkit.org/show_bug.cgi?id=49177
multiple crashes on GTK
* platform/ScrollView.cpp:
(WebCore::ScrollView::removeChild):
(WebCore::ScrollView::wheelEvent):
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::attachAdjustment):
(MainFrameScrollbarGtk::gtkValueChanged):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::platformInit):
(WebCore::ScrollView::platformAddChild):
(WebCore::ScrollView::platformRemoveChild):
2011-01-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build fix.
Bug 49177's patch enabled platformInit() in super class(ScrollView).
But, it didn't removed the function in ScrollViewEfl.cpp.
* platform/efl/ScrollViewEfl.cpp:
2011-01-16 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8871903> REGRESSION (r75897): Crash with 0-by-0 iframe in scaled WebView
Avoid use of FloatRect::enclosingBoundingBox(), which can stretch an empty
quad to a non-empty rect.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
2011-01-16 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=49177
* platform/ScrollView.cpp: Move the platform guards around a little. GTK+
now shares the implementation of platformAddChild and platformRemoveChild,
but has its own implementation of removeChild, which knows how to inform
main frame scrollbars that they no longer control the WebCore scrollbar.
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::attachAdjustment): If we are attaching the same adjustment
that we already have, bail out early. Apply the value changed signal handler
after configuring the adjustment. We don't want our reset of the adjustment to
stomp on WebCore values.
(MainFrameScrollbarGtk::gtkValueChanged): Do not adjust the value if the WebCore
state already matches ours. This prevents some unnecessary recursion
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::removeChild): Added, special cases main frame scrollbars
which need their adjustments detached.
2011-01-13 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Fix for Bug 52427 - Inconsistent use of m_cache in CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=52427
In constructor/destructor of CachedResourceLoader, m_cache has been
used to call MemoryCache::addCachedResourceLoader/removeCachedResourceLoader
while cache() is used everywhere else.
Actually addCachedResourceLoader/removeCachedResourceLoader need not be called at all.
Remove the call sites and make MemoryCache non-friend of CachedResourceLoader.
No new tests because the behavior remains the same.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
* loader/cache/CachedResourceLoader.h:
* loader/cache/MemoryCache.cpp:
* loader/cache/MemoryCache.h:
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* WebCore.gyp/WebCore.gyp:
* WebCore.pri:
* WebCore.pro:
2011-01-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
frame-removed-during-resize.html test crashes (shows up as image-map-2.html crash)
https://bugs.webkit.org/show_bug.cgi?id=52549
Fix regression from r75900; m_widget->setFrameRect() can run script that
clears m_widget, so null-check it before calling setBoundsSize().
Tested by fast/replaced/frame-removed-during-resize.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
2011-01-16 Simon Fraser <simon.fraser@apple.com>
Keep Leopard build happy.
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setBoundsSize):
2011-01-16 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] plugins/keyboard-events.html fails after r72717
https://bugs.webkit.org/show_bug.cgi?id=50050
* plugins/qt/PluginViewQt.cpp:
(WebCore::setXKeyEventSpecificFields): map event text to keycode
2011-01-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Issues with iframes and plugins when the WebView is scaled.
<rdar://problem/6213380>
When _scaleWebView has been called on a WebView, iframes
in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
This is caused by AppKit NSViews not playing nicely with the scale
applied through style.
Work around most of these issues by adjusting the bounds size
of widgets to allow iframe contents to paint with the correct scale,
and fix various places in the code where we relied on coordinate
transforms via NSViews (which ignore CSS transforms).
* WebCore.exp.in:
* platform/Widget.cpp:
(WebCore::Widget::setBoundsSize):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setBoundsSize):
(WebCore::Widget::paint):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
* rendering/RenderWidget.h:
2011-01-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
RenderView needs to take transforms on its layer into account
https://bugs.webkit.org/show_bug.cgi?id=52536
The RenderView's coordinate mapping methods failed to
take into account a transform on the RenderView's layer.
No tests because it's not possible to get a transform
on the RenderView's layer through content.
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
2011-01-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75708.
http://trac.webkit.org/changeset/75708
https://bugs.webkit.org/show_bug.cgi?id=52521
Breaks Qt build if mobility is not installed. (Requested by
benjaminp on #webkit).
* WebCore.pro:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(WebCore::MediaPlayerPrivateQt::supportsFullscreen):
2011-01-15 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/52512> REGRESSION(r73818): range.cloneContents() ignores end offset
Reviewed by Adele Peterson.
The fix for Bug 50710 in r73799 introduced an off-by-one error
when copying nodes to a local NodeVector for processing. A fix
was attempted for Bug 50854 in r73818, but instead of stopping
at the end offset, it iterates through all the sibling nodes
because the loop variable (i) is never incremented. To clean
this up, revert back to the code in r73799 and fix the
off-by-one error.
Test: fast/dom/Range/range-clone-contents.html
* dom/Range.cpp:
(WebCore::Range::processContents): Fix the loop that copies
nodes to a local NodeVector by restoring the code from r73799
and fixing the off-by-one error.
2011-01-15 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit2 into Source
https://bugs.webkit.org/show_bug.cgi?id=52438
* WebCore.pro:
2011-01-15 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Linux build with FileSystem API enabled fails
https://bugs.webkit.org/show_bug.cgi?id=43878
This patch allows WebKitGtk+ to build with FileSystem API option.
No new tests because no new functionality.
* GNUmakefile.am: Included AsyncFileSystem.h,cpp and Excluded duplicated JSFileException.h,cpp.
* bindings/js/JSDirectoryEntryCustom.cpp: Included ExceptionCode.h.
2011-01-14 Sam Magnuson <smagnuso@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750
* platform/graphics/qt/GraphicsLayerQt.cpp:
* platform/graphics/qt/GraphicsLayerQt.h:
* platform/qt/PlatformMouseEventQt.cpp:
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Alexey Proskuryakov.
Strip NUL character when copying text on Windows
https://bugs.webkit.org/show_bug.cgi?id=52236
Test: editing/pasteboard/copy-null-characters.html
* editing/Editor.cpp:
(WebCore::Editor::selectedText):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
No new tests because the behavior remains the same.
* WebCore.exp.in:
* WebCore.order:
* history/PageCache.cpp:
(WebCore::PageCache::releaseAutoreleasedPagesNow):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::cachedResource):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::data):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::setDecodedSize):
(WebCore::CachedResource::setEncodedSize):
(WebCore::CachedResource::didAccessDecodedData):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::clearPreloads):
(WebCore::CachedResourceLoader::printPreloadStats):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::load):
(WebCore::CachedResourceRequest::didFail):
(WebCore::CachedResourceRequest::didReceiveResponse):
* loader/cache/MemoryCache.cpp:
(WebCore::memoryCache):
* loader/cache/MemoryCache.h:
2011-01-14 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
* WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and
RenderWidget::resumeWidgetHierarchyUpdates().
* manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
are disabled. When this assertion was added, this condition was a subset of the “calling out to
plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
change now suspends widget hierarchy updates even at times where plug-in code is expected to be
called, which invalidates the assertion.
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* rendering/style/StyleRareInheritedData.cpp:
* rendering/style/StyleRareNonInheritedData.cpp:
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* rendering/style/RenderStyle.cpp:
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* editing/EditorCommand.cpp:
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* editing/ApplyStyleCommand.cpp:
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* css/CSSStyleSelector.cpp:
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494
* rendering/InlineFlowBox.h:
* rendering/RenderBoxModelObject.h:
2011-01-14 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Do some forward declaration in RenderStyle.h
https://bugs.webkit.org/show_bug.cgi?id=52453
No new tests because no new functionality.
* css/CSSComputedStyleDeclaration.cpp:
* css/CSSStyleSelector.cpp:
* editing/Editor.cpp:
* page/EventHandler.cpp:
* rendering/EllipsisBox.cpp:
* rendering/InlineBox.cpp:
* rendering/InlineTextBox.cpp:
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
* rendering/RenderEmbeddedObject.cpp:
* rendering/RenderFieldset.cpp:
* rendering/RenderFileUploadControl.cpp:
* rendering/RenderFrameSet.cpp:
* rendering/RenderHTMLCanvas.cpp:
* rendering/RenderImageResource.cpp:
* rendering/RenderInputSpeech.cpp:
* rendering/RenderLayer.h:
* rendering/RenderLineBoxList.cpp:
* rendering/RenderListBox.cpp:
* rendering/RenderMediaControlsChromium.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* rendering/RenderObjectChildList.cpp:
* rendering/RenderProgress.cpp:
* rendering/RenderScrollbarPart.cpp:
* rendering/RenderTable.cpp:
* rendering/RenderTable.h:
* rendering/RenderTableCell.cpp:
* rendering/RenderTableRow.cpp:
* rendering/RenderTableSection.cpp:
* rendering/RenderTheme.cpp:
* rendering/RenderThemeChromiumSkia.cpp:
* rendering/RenderThemeChromiumWin.cpp:
* rendering/RootInlineBox.cpp:
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
2011-01-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
https://bugs.webkit.org/show_bug.cgi?id=52481
Removed instantiation of legacy editing positions.
Calls to Position::Position are replaced by calls to Position's convenience functions.
Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
they instantiate right positions for text nodes.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setSelectedTextRange):
* dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::inputText):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
(WebCore::CompositeEditCommand::splitTreeToNode):
* editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
* editing/htmlediting.h:
(WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of
positionBeforeNode for a text node.
(WebCore::lastPositionInOrAfterNode): Ditto.
2011-01-14 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982
This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.
Test: fast/canvas/canvas-fillPath-gradient-shadow.html
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Layer syncing should go through the compositor
https://bugs.webkit.org/show_bug.cgi?id=52486
Rather than have FrameView go directly to GraphicsLayer to
sync pending changes, route the call through RenderLayerCompositor.
Add a FIXME about an existing issue with flushing and subframes.
No behavior change, so no tests.
* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::notifySyncRequired):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scheduleLayerFlush):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::notifySyncRequired):
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Fix parent block calculation when trying to find top most node
containing "this" float.
https://bugs.webkit.org/show_bug.cgi?id=51711
Replace use of containingBlock and traverse the parents directly
to check for float existence. containingBlock can skip parents and
jump to the RenderView directly which will cause floats to not get
cleared from intermediate parents.
Test: fast/block/float/floats-not-cleared-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
2011-01-14 Adam Klein <adamk@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42237
Remove Chromium-specific implementation from WebCore.
No tests added; this refactor should be covered by existing history-exercising tests.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* history/BackForwardListChromium.cpp: Removed.
* history/BackForwardListImpl.h:
2011-01-12 Satish Sampath <satish@chromium.org>
Reviewed by Dimitri Glazkov.
Fix a crash when accessing speech input from script.
https://bugs.webkit.org/show_bug.cgi?id=52325
Test: fast/speech/speech-input-scripting.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute): Recreate renderer when speech input is enabled/disabled.
* rendering/RenderTextControlSingleLine.cpp: Remove unused code.
* rendering/RenderTextControlSingleLine.h:
* rendering/TextControlInnerElements.cpp: Take self references before firing events and check for renderer validity after.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
(WebCore::InputFieldSpeechButtonElement::detach):
2011-01-14 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Prevent merging of anonymous blocks if one of them is already getting
destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52402
Test: fast/block/merge-anonymous-block-remove-child-crash2.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock): initialize m_beingDestroyed to false.
(WebCore::RenderBlock::destroy): set m_beingDestroyed to true.
(WebCore::canMergeContiguousAnonymousBlocks): do not merge if any or prev or next is being destroyed.
(WebCore::RenderBlock::removeChild): remove the hack previously done for preventing oldChild merging with nextBlock's next sibling.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::beingDestroyed): public function for m_beingDestroyed.
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Follow up to r75791: fix missing dispatch.
https://bugs.webkit.org/show_bug.cgi?id=52442
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Issues with contentsScale in GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=52463
Fix various issues with the recent contentsScale changes:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1.
(WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay()
if the layer draws content, otherwise we'll create backing store for empty layers.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale
on the new (tiled or untiled) layer.
(WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Let Xcode have it's way with the project file.
* WebCore.xcodeproj/project.pbxproj:
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Refactor some FrameView::syncCompositingState code
https://bugs.webkit.org/show_bug.cgi?id=52459
Refactor some code in FrameView related to synchronizing
compositing layer state.
* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::syncCompositingStateRecursive):
(WebCore::FrameView::paintContents):
* page/FrameView.h:
2011-01-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Eric Seidel.
[Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
https://bugs.webkit.org/show_bug.cgi?id=30179
* plugins/symbian/PluginViewSymbian.cpp:
2011-01-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532
* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
2011-01-14 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by David Levin.
[GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=52434
No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.
* platform/gtk/FileSystemGtk.cpp:
(WebCore::filenameToString): Use GOwnPtr instead of gchar pointer.
(WebCore::fileSystemRepresentation): Ditto.
(WebCore::filenameForDisplay): Ditto.
(WebCore::pathGetFileName): Ditto.
2011-01-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload.
https://bugs.webkit.org/show_bug.cgi?id=52215
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.populateLabelElement):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.get linesCount):
(WebInspector.Script.prototype.sourceLine):
(WebInspector.Script.prototype.sourceLine.didRequestSource):
(WebInspector.Script.prototype.set source):
(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded.didRequestSource):
(WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._addBreakpoint):
* inspector/front-end/utilities.js:
(String.prototype.findAll):
2011-01-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: provide script column offset to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52377
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptDebugListener.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.parsedScriptSource):
* inspector/front-end/Script.js:
(WebInspector.Script):
2011-01-14 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed one line fix for console-xhr-logging test.
The problem was introduced at r75788.
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
2011-01-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract console related functionality into InspectorConsoleAgent
https://bugs.webkit.org/show_bug.cgi?id=52282
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* inspector/CodeGeneratorInspector.pm:
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::~ConsoleMessage):
* inspector/ConsoleMessage.h:
* inspector/Inspector.idl:
* inspector/InspectorConsoleAgent.cpp: Added.
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::reset):
(WebCore::InspectorConsoleAgent::setFrontend):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::startTiming):
(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h: Added.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::clearConsoleMessages):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::didCommitLoad):
* inspector/InspectorController.h:
(WebCore::InspectorController::consoleAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::count):
(WebCore::InspectorInstrumentation::startTiming):
(WebCore::InspectorInstrumentation::stopTiming):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.addConsoleMessage):
(WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount):
(WebInspector.ConsoleView.prototype.consoleMessagesCleared):
* inspector/front-end/inspector.js:
* page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::count):
(WebCore::Console::profile):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
(WebCore::Console::groupEnd):
* page/Console.h:
* page/Console.idl:
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not use this as protocol message
dispatcher in models / agents.
https://bugs.webkit.org/show_bug.cgi?id=52442
Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
There should be a clear way to tell whether method is being called
from within front-end or by the backend.
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype.nodeForId):
(WebInspector.DOMAgent.prototype._bindNodes):
(WebInspector.DOMAgent.prototype._removeBreakpoints):
(WebInspector.DOMDispatcher):
(WebInspector.DOMDispatcher.prototype.setDocument):
(WebInspector.DOMDispatcher.prototype.attributesUpdated):
(WebInspector.DOMDispatcher.prototype.characterDataModified):
(WebInspector.DOMDispatcher.prototype.setChildNodes):
(WebInspector.DOMDispatcher.prototype.setDetachedRoot):
(WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
(WebInspector.DOMDispatcher.prototype.childNodeInserted):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
(WebInspector.DOMDispatcher.prototype.didCommitLoad):
(WebInspector.ApplicationCacheDispatcher):
(WebInspector.ApplicationCacheDispatcher.prototype.getApplicationCachesAsync):
(WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
(WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageDispatcher):
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
(WebInspector.DOMStorageDispatcher.prototype.selectDOMStorage):
(WebInspector.DOMStorageDispatcher.prototype.updateDOMStorage):
* inspector/front-end/Database.js:
(WebInspector.Database.prototype.executeSql):
(WebInspector.DatabaseDispatcher):
(WebInspector.DatabaseDispatcher.prototype.addDatabase):
(WebInspector.DatabaseDispatcher.prototype.selectDatabase):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._resumedScript):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerDispatcher):
(WebInspector.DebuggerDispatcher.prototype.pausedScript):
(WebInspector.DebuggerDispatcher.prototype.resumedScript):
(WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.failedToParseScriptSource):
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemDispatcher):
(WebInspector.FileSystemDispatcher.prototype.getFileSystemPathsAsync):
(WebInspector.FileSystemDispatcher.prototype.didGetFileSystemPath):
(WebInspector.FileSystemDispatcher.prototype.didGetFileSystemError):
(WebInspector.FileSystemDispatcher.prototype.didGetFileSystemDisabled):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._setRecordingProfile):
(WebInspector.ProfilerDispatcher):
(WebInspector.ProfilerDispatcher.prototype.profilerWasEnabled):
(WebInspector.ProfilerDispatcher.prototype.profilerWasDisabled):
(WebInspector.ProfilerDispatcher.prototype.resetProfiles):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
(WebInspector.ProfilerDispatcher.prototype.addHeapSnapshotChunk):
(WebInspector.ProfilerDispatcher.prototype.finishHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
(WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._timelineProfilerWasStarted):
(WebInspector.TimelinePanel.prototype._timelineProfilerWasStopped):
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelineDispatcher):
(WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStarted):
(WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStopped):
(WebInspector.TimelineDispatcher.prototype.addRecordToTimeline):
2011-01-14 Csaba Osztrogonác <ossy@webkit.org>
[Qt][V8] Unreviewed buildfix after r75788.
* inspector/InspectorBrowserDebuggerAgent.cpp:
2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.
http://bugs.webkit.org/show_bug.cgi?id=52294
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Added.
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::discardBindings):
(WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
* inspector/InspectorBrowserDebuggerAgent.h: Added.
(WebCore::InspectorBrowserDebuggerAgent::create):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2011-01-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: redirected resources not handled properly in Network panel
https://bugs.webkit.org/show_bug.cgi?id=52292
* inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
* inspector/InspectorInstrumentation.cpp: Ditto.
(WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
* inspector/InspectorResourceAgent.cpp: Ditto.
(WebCore::InspectorResourceAgent::identifierForInitialRequest):
* inspector/InspectorResourceAgent.h: Ditto.
* inspector/InspectorInstrumentation.cpp: Ditto.
(WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
* inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
* inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource
(WebInspector.ConsoleMessage.prototype._formatMessage):
* inspector/front-end/ExtensionServer.js: Ditto.
(WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
* inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._convertResource):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource.
(WebInspector.NetworkManager.prototype.identifierForInitialRequest):
(WebInspector.NetworkManager.prototype.willSendRequest):
(WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
(WebInspector.NetworkManager.prototype.setInitialContent):
(WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
(WebInspector.NetworkManager.prototype.didCreateWebSocket):
(WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel
(WebInspector.NetworkManager.prototype._appendRedirect):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype.get resources):
(WebInspector.NetworkPanel.prototype.resourceById):
(WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added.
(WebInspector.NetworkPanel.prototype.refreshResource): ditto.
(WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
* inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation.
(WebInspector.ResourceTreeModel.prototype._clearResources):
(WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype.createResource):
* inspector/front-end/inspector.js:
(WebInspector.resourceById):
2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75783.
http://trac.webkit.org/changeset/75783
https://bugs.webkit.org/show_bug.cgi?id=52439
a bit strange but the same patch have broken mac builds at
linking stage. (Requested by loislo2 on #webkit).
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
* inspector/InspectorBrowserDebuggerAgent.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
(WebCore::InspectorController::setEventListenerBreakpoint):
(WebCore::InspectorController::removeEventListenerBreakpoint):
(WebCore::InspectorController::hasEventListenerBreakpoint):
(WebCore::InspectorController::setXHRBreakpoint):
(WebCore::InspectorController::removeXHRBreakpoint):
(WebCore::InspectorController::hasXHRBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::setDOMBreakpoint):
(WebCore::InspectorDOMAgent::removeDOMBreakpoint):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
(WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
(WebCore::InspectorDOMAgent::descriptionForDOMEvent):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::hasBreakpoint):
(WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.
http://bugs.webkit.org/show_bug.cgi?id=52294
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Added.
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::discardBindings):
(WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
* inspector/InspectorBrowserDebuggerAgent.h: Added.
(WebCore::InspectorBrowserDebuggerAgent::create):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: build fix.
* WebCore.vcproj/WebCore.vcproj:
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract InspectorSettings from InspectorState,
simplify it.
https://bugs.webkit.org/show_bug.cgi?id=52429
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorClient.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectorStartsAttached):
(WebCore::InspectorController::setInspectorStartsAttached):
(WebCore::InspectorController::setInspectorAttachedHeight):
(WebCore::InspectorController::inspectorAttachedHeight):
(WebCore::InspectorController::setMonitoringXHREnabled):
(WebCore::InspectorController::restoreDebugger):
(WebCore::InspectorController::restoreProfiler):
(WebCore::InspectorController::ensureSettingsLoaded):
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
* inspector/InspectorController.h:
* inspector/InspectorSettings.cpp: Added.
(WebCore::InspectorSettings::InspectorSettings):
(WebCore::InspectorSettings::getBoolean):
(WebCore::InspectorSettings::setBoolean):
(WebCore::InspectorSettings::getLong):
(WebCore::InspectorSettings::setLong):
(WebCore::InspectorSettings::registerBoolean):
(WebCore::InspectorSettings::registerLong):
* inspector/InspectorSettings.h: Added.
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::setValue):
(WebCore::InspectorState::setObject):
(WebCore::InspectorState::registerBoolean):
(WebCore::InspectorState::registerString):
(WebCore::InspectorState::registerLong):
(WebCore::InspectorState::registerObject):
(WebCore::InspectorState::Property::create):
* inspector/InspectorState.h:
(WebCore::InspectorState::setBoolean):
(WebCore::InspectorState::setString):
(WebCore::InspectorState::setLong):
2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75774.
http://trac.webkit.org/changeset/75774
https://bugs.webkit.org/show_bug.cgi?id=52431
gtk builds were broken (Requested by loislo2 on #webkit).
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
* inspector/InspectorBrowserDebuggerAgent.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
(WebCore::InspectorController::setEventListenerBreakpoint):
(WebCore::InspectorController::removeEventListenerBreakpoint):
(WebCore::InspectorController::hasEventListenerBreakpoint):
(WebCore::InspectorController::setXHRBreakpoint):
(WebCore::InspectorController::removeXHRBreakpoint):
(WebCore::InspectorController::hasXHRBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::setDOMBreakpoint):
(WebCore::InspectorDOMAgent::removeDOMBreakpoint):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
(WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
(WebCore::InspectorDOMAgent::descriptionForDOMEvent):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::hasBreakpoint):
(WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.
http://bugs.webkit.org/show_bug.cgi?id=52294
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Added.
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::discardBindings):
(WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
* inspector/InspectorBrowserDebuggerAgent.h: Added.
(WebCore::InspectorBrowserDebuggerAgent::create):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2011-01-13 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Implement form validation message UI
https://bugs.webkit.org/show_bug.cgi?id=48980
* Add four internal pseudo selectors:
- -webkit-validation-bubble
- -webkit-validation-bubble-message
- -webkit-validation-bubble-top-outer-arrow
- -webkit-validation-bubble-top-inner-arrow
* Implement ValidationMessage functions
Show the message for <the number of characters> / 20.0 seconds.
No new tests because the feature is disabled by default for now and the
new behavior is strongly timing-dependent.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
Do not share a style with elements with different shadowPseudoId().
* css/html.css: Define appearance for the internal selectors.
(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-top-outer-arrow):
(::-webkit-validation-bubble-top-inner-arrow):
* dom/Node.cpp:
(WebCore::Node::createRendererIfNeeded):
Allow to add shadow renderers even if canHaveChildren() returns false.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::detach):
Remove m_validationMessage immediately because we can't use
hideVisibleValidationMessage(), which calls a ValidationMessage function later.
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
- Don't create ValidationMessage if the message is empty.
- Remove the check for message equality.
(WebCore::HTMLFormControlElement::hideVisibleValidationMessage):
Don't remove m_validationMessage immediately. We shouldn't make the
element needsLayout() state in this context.
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::~ValidationMessage):
hideMessage() -> deleteBubbleTree() renaming.
(WebCore::ValidationMessage::setMessage): Implemented.
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
Added. This updates the validation message and starts the timer to hide it.
(WebCore::ElementWithPseudoId):
Added to help implementations of styled shadow nodes.
(WebCore::ValidationMessage::buildBubbleTree): Added.
(WebCore::ValidationMessage::requestToHideMessage): Added.
(WebCore::ValidationMessage::deleteBubbleTree):
Renamed from hideMessage(), and implemented.
* html/ValidationMessage.h: Add declarations.
2011-01-13 Dan Bernstein <mitz@apple.com>
Reviewed by Alexey Proskuryakov.
<rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
https://bugs.webkit.org/show_bug.cgi?id=52419
Test: http/tests/loading/cross-origin-XHR-willLoadRequest.html
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init): Complete r74453 by ensuring that m_request is only set after
willSendRequest(). Otherwise, willSendRequest() ends up calling into
ThreadableDocumentRequest::willSendRequest(), which cancels the request.
2011-01-13 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
Don’t try to compile InjectedScriptSource.js into WebCore.
* WebCore.xcodeproj/project.pbxproj:
2011-01-13 Mike Thole <mthole@apple.com>
Reviewed by Darin Adler and Brady Eidson.
The pageScaleFactor() should be saved/restored along with the scroll position
https://bugs.webkit.org/show_bug.cgi?id=52406
<rdar://problem/8714412>
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem): Initialize m_pageScaleFactor.
(WebCore::HistoryItem::pageScaleFactor): Added getter.
(WebCore::HistoryItem::setPageScaleFactor): Added setter.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Encode m_pageScaleFactor.
(WebCore::HistoryItem::decodeBackForwardTree): Decode m_pageScaleFactor.
* history/HistoryItem.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem): Save the page scale factor...
(WebCore::HistoryController::restoreScrollPositionAndViewState): ...and restore it here.
2011-01-13 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] drop backwards iteration in Linux complex text code
https://bugs.webkit.org/show_bug.cgi?id=52403
ComplexTextController previously supported iterating through the text in
both directions, but this resulted in duplicate code for each path.
Instead, by being more careful about flipping signs where appropriate,
we can refactor the code into one code path.
No tests, just a refactoring; should be covered by existing tests.
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::reset):
(WebCore::ComplexTextController::nextScriptRun):
* platform/graphics/chromium/ComplexTextControllerLinux.h:
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::glyphIndexForXPositionInScriptRun):
(WebCore::Font::selectionRectForComplexText):
2011-01-13 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Flip input[type=range] to use the new shadow DOM model.
https://bugs.webkit.org/show_bug.cgi?id=52317
This is a straight-up flip, minimal change to the logic, which will be
refactored in a follow-up patch.
Covered by existing tests.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
host or parent node to find parent.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
shadow DOM subtree.
* html/InputType.cpp:
(WebCore::InputType::createShadowSubtree): Added empty decl.
(WebCore::InputType::destroyShadowSubtree): Added a method to destroy
shadow subtree.
* html/InputType.h: Added defs.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
slider thumb.
* html/RangeInputType.h: Adde def.
* html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
to handle cascading appearance.
(WebCore::RenderSliderThumb::RenderSliderThumb): Added.
(WebCore::RenderSliderThumb::layout): Moved here the logic from
RenderSlider::createThumbStyle.
(WebCore::SliderThumbElement::createRenderer): Added virtual method to
create RenderSliderThumb instance.
(WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
as base class.
(WebCore::SliderThumbElement::detach): Ditto.
* html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::SliderThumbElement): Ditto.
(WebCore::SliderThumbElement::create): Ditto.
(WebCore::toSliderThumbElement): Added a casting helper.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
since the whole method is hand-rolled.
(WebCore::MediaControlInputElement::updateStyle): Ditto.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
(WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::layout): Ditto.
(WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
SliderThumbElement.
(WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
(WebCore::RenderSlider::setValueForPosition): Ditto.
(WebCore::RenderSlider::positionForOffset): Ditto.
(WebCore::RenderSlider::currentPosition): Ditto.
(WebCore::RenderSlider::trackSize): Ditto.
(WebCore::RenderSlider::forwardEvent): Ditto.
(WebCore::RenderSlider::inDragMode): Ditto.
* rendering/RenderSlider.h: Added def.
2011-01-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename RGBA32Buffer to ImageFrame
https://bugs.webkit.org/show_bug.cgi?id=52363
RGBA32Buffer is a terrible misnomer. ImageFrame is vastly
more accurate. More cleanup to come.
* WebCore.pro:
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
* platform/graphics/qt/ImageDecoderQt.h:
* platform/graphics/wince/ImageWinCE.cpp:
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clear):
(WebCore::ImageFrame::zeroFill):
(WebCore::ImageFrame::copyReferenceToBitmapData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::ImageFrame):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::decode):
* platform/image-decoders/bmp/BMPImageDecoder.h:
* platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::decodeBMP):
* platform/image-decoders/bmp/BMPImageReader.h:
(WebCore::BMPImageReader::setBuffer):
* platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/cg/ImageDecoderCG.cpp:
(WebCore::getPtrAsPixelData):
(WebCore::ImageFrame::copyReferenceToBitmapData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
* platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameReader::GIFFrameReader):
* platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::decode):
* platform/image-decoders/ico/ICOImageDecoder.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::jpegComplete):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
* platform/image-decoders/png/PNGImageDecoder.h:
(WebCore::PNGImageDecoder::isComplete):
* platform/image-decoders/qt/ImageFrameQt.cpp: Copied from Source/WebCore/platform/image-decoders/qt/RGBA32BufferQt.cpp.
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clear):
(WebCore::ImageFrame::zeroFill):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::setPixmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
* platform/image-decoders/qt/RGBA32BufferQt.cpp: Removed.
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clear):
(WebCore::ImageFrame::zeroFill):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::frameBufferAtIndex):
(WebCore::WEBPImageDecoder::decode):
* platform/image-decoders/webp/WEBPImageDecoder.h:
* platform/image-decoders/wx/ImageDecoderWx.cpp:
(WebCore::ImageFrame::asNewNativeImage):
2011-01-13 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Transferring nodes between documents should be aware of the shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=52399
No visible change in behavior at the moment.
Once https://bugs.webkit.org/show_bug.cgi?id=52317 lands, the following
tests should no longer crash:
* fast/css/pseudo-in-range-invalid-value.html
* fast/css/pseudo-in-range.html
* fast/forms/form-collection-elements.html
* fast/forms/range-keyoperation.html
* dom/Document.cpp:
(WebCore::Document::adoptNode): Changed to use Node::setDocumentRecursively.
* dom/Node.cpp:
(WebCore::Node::setDocumentRecursively): Added new method, taking existing
logic and adding shadow DOM traversal.
(WebCore::Node::traverseNextNode): Style fix.
(WebCore::Node::traverseNextSibling): Ditto.
(WebCore::Node::traversePreviousNode): Ditto.
(WebCore::Node::traversePreviousNodePostOrder): Ditto.
(WebCore::Node::checkReplaceChild): Changed to use setDocumentRecursively.
(WebCore::Node::checkAddChild): Ditto.
* dom/Node.h: Added def.
2011-01-12 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>
This patch contains the changes required to support dropping content
in WebKit on the Mac. The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
The support for WebKit as drag source will be added with a separate patch.
* WebCore.exp.in:
* page/DragController.cpp:
(WebCore::DragController::dragIsMove): Added DragData parameter.
(WebCore::DragController::tryDocumentDrag): Modified call to dragIsMove.
(WebCore::DragController::concludeEditDrag): Same as above.
* page/DragController.h: Added parameter to isCopyKeyDown.
* page/mac/DragControllerMac.mm:
The following methods have been modified to use the information stored
in the DragData class.
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
* platform/DragData.h:
(WebCore::DragData::flags):
* platform/DragData.cpp: Added default flags parameter to the constructor.
* platform/mac/DragDataMac.mm:
(WebCore::DragData::DragData): Added constructor that receives the name of the pasteboard to use.
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
All the following files have been modified to add the DragData
parameter to isCopyKeyDown. I plan to improve this in the future
and make isCopyKeyDown not platform specific.
* page/android/DragControllerAndroid.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/brew/DragControllerBrew.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/chromium/DragControllerChromium.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/efl/DragControllerEfl.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/haiku/DragControllerHaiku.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/mac/DragControllerMac.mm:
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
* page/qt/DragControllerQt.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/win/DragControllerWin.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/wx/DragControllerWx.cpp:
(WebCore::DragController::isCopyKeyDown):
2011-01-13 David Kilzer <ddkilzer@apple.com>
Add missing MathMLElementFactory.h and MathMLNames.h to Xcode project
Not reviewed.
* WebCore.xcodeproj/project.pbxproj: Add missing headers. Note
that the corresponding source files were originally added to the
project in r48559.
2011-01-12 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Use GC3D types in WebGLRenderingContext and related WebGL classes
https://bugs.webkit.org/show_bug.cgi?id=51908
* html/canvas/WebGLActiveInfo.h:
(WebCore::WebGLActiveInfo::create):
(WebCore::WebGLActiveInfo::type):
(WebCore::WebGLActiveInfo::size):
(WebCore::WebGLActiveInfo::WebGLActiveInfo):
* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl):
(WebCore::WebGLBuffer::associateBufferData):
(WebCore::WebGLBuffer::associateBufferSubDataImpl):
(WebCore::WebGLBuffer::associateBufferSubData):
(WebCore::WebGLBuffer::byteLength):
(WebCore::WebGLBuffer::getCachedMaxIndex):
(WebCore::WebGLBuffer::setCachedMaxIndex):
(WebCore::WebGLBuffer::setTarget):
* html/canvas/WebGLBuffer.h:
(WebCore::WebGLBuffer::getTarget):
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::setAttachment):
(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::getWidth):
(WebCore::WebGLFramebuffer::getHeight):
(WebCore::WebGLFramebuffer::getColorBufferFormat):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):
* html/canvas/WebGLFramebuffer.h:
* html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::cacheActiveAttribLocations):
(WebCore::WebGLProgram::numActiveAttribLocations):
(WebCore::WebGLProgram::getActiveAttribLocation):
(WebCore::WebGLProgram::isUsingVertexAttrib0):
* html/canvas/WebGLProgram.h:
(WebCore::WebGLProgram::getLinkCount):
* html/canvas/WebGLRenderbuffer.h:
(WebCore::WebGLRenderbuffer::setInternalFormat):
(WebCore::WebGLRenderbuffer::getInternalFormat):
(WebCore::WebGLRenderbuffer::setSize):
(WebCore::WebGLRenderbuffer::getWidth):
(WebCore::WebGLRenderbuffer::getHeight):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::sizeInBytes):
(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::bindBuffer):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::bindRenderbuffer):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::blendColor):
(WebCore::WebGLRenderingContext::blendEquation):
(WebCore::WebGLRenderingContext::blendEquationSeparate):
(WebCore::WebGLRenderingContext::blendFunc):
(WebCore::WebGLRenderingContext::blendFuncSeparate):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::clearColor):
(WebCore::WebGLRenderingContext::clearDepth):
(WebCore::WebGLRenderingContext::clearStencil):
(WebCore::WebGLRenderingContext::colorMask):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::cullFace):
(WebCore::WebGLRenderingContext::deleteBuffer):
(WebCore::WebGLRenderingContext::depthFunc):
(WebCore::WebGLRenderingContext::depthMask):
(WebCore::WebGLRenderingContext::depthRange):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::disableVertexAttribArray):
(WebCore::WebGLRenderingContext::validateElementArraySize):
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateRenderingState):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::enableVertexAttribArray):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::frontFace):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getActiveAttrib):
(WebCore::WebGLRenderingContext::getActiveUniform):
(WebCore::WebGLRenderingContext::getAttachedShaders):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getBufferParameter):
(WebCore::WebGLRenderingContext::getError):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getProgramParameter):
(WebCore::WebGLRenderingContext::getRenderbufferParameter):
(WebCore::WebGLRenderingContext::getShaderParameter):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::getVertexAttrib):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::hint):
(WebCore::WebGLRenderingContext::isBuffer):
(WebCore::WebGLRenderingContext::isEnabled):
(WebCore::WebGLRenderingContext::isFramebuffer):
(WebCore::WebGLRenderingContext::isProgram):
(WebCore::WebGLRenderingContext::isRenderbuffer):
(WebCore::WebGLRenderingContext::isShader):
(WebCore::WebGLRenderingContext::isTexture):
(WebCore::WebGLRenderingContext::lineWidth):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::pixelStorei):
(WebCore::WebGLRenderingContext::polygonOffset):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::renderbufferStorage):
(WebCore::WebGLRenderingContext::sampleCoverage):
(WebCore::WebGLRenderingContext::scissor):
(WebCore::WebGLRenderingContext::stencilFunc):
(WebCore::WebGLRenderingContext::stencilFuncSeparate):
(WebCore::WebGLRenderingContext::stencilMask):
(WebCore::WebGLRenderingContext::stencilMaskSeparate):
(WebCore::WebGLRenderingContext::stencilOp):
(WebCore::WebGLRenderingContext::stencilOpSeparate):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texParameter):
(WebCore::WebGLRenderingContext::texParameterf):
(WebCore::WebGLRenderingContext::texParameteri):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::uniform1f):
(WebCore::WebGLRenderingContext::uniform1fv):
(WebCore::WebGLRenderingContext::uniform1i):
(WebCore::WebGLRenderingContext::uniform1iv):
(WebCore::WebGLRenderingContext::uniform2f):
(WebCore::WebGLRenderingContext::uniform2fv):
(WebCore::WebGLRenderingContext::uniform2i):
(WebCore::WebGLRenderingContext::uniform2iv):
(WebCore::WebGLRenderingContext::uniform3f):
(WebCore::WebGLRenderingContext::uniform3fv):
(WebCore::WebGLRenderingContext::uniform3i):
(WebCore::WebGLRenderingContext::uniform3iv):
(WebCore::WebGLRenderingContext::uniform4f):
(WebCore::WebGLRenderingContext::uniform4fv):
(WebCore::WebGLRenderingContext::uniform4i):
(WebCore::WebGLRenderingContext::uniform4iv):
(WebCore::WebGLRenderingContext::uniformMatrix2fv):
(WebCore::WebGLRenderingContext::uniformMatrix3fv):
(WebCore::WebGLRenderingContext::uniformMatrix4fv):
(WebCore::WebGLRenderingContext::vertexAttrib1f):
(WebCore::WebGLRenderingContext::vertexAttrib1fv):
(WebCore::WebGLRenderingContext::vertexAttrib2f):
(WebCore::WebGLRenderingContext::vertexAttrib2fv):
(WebCore::WebGLRenderingContext::vertexAttrib3f):
(WebCore::WebGLRenderingContext::vertexAttrib3fv):
(WebCore::WebGLRenderingContext::vertexAttrib4f):
(WebCore::WebGLRenderingContext::vertexAttrib4fv):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
(WebCore::WebGLRenderingContext::viewport):
(WebCore::WebGLRenderingContext::getBooleanParameter):
(WebCore::WebGLRenderingContext::getBooleanArrayParameter):
(WebCore::WebGLRenderingContext::getFloatParameter):
(WebCore::WebGLRenderingContext::getIntParameter):
(WebCore::WebGLRenderingContext::getLongParameter):
(WebCore::WebGLRenderingContext::getUnsignedLongParameter):
(WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
(WebCore::WebGLRenderingContext::getWebGLIntArrayParameter):
(WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
(WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::validateSize):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncLevel):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
(WebCore::WebGLRenderingContext::validateTexFuncData):
(WebCore::WebGLRenderingContext::validateDrawMode):
(WebCore::WebGLRenderingContext::validateStencilFunc):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::validateBlendEquation):
(WebCore::WebGLRenderingContext::validateBlendFuncFactors):
(WebCore::WebGLRenderingContext::validateCapability):
(WebCore::WebGLRenderingContext::validateUniformParameters):
(WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
(WebCore::WebGLRenderingContext::validateBufferDataParameters):
(WebCore::WebGLRenderingContext::vertexAttribfImpl):
(WebCore::WebGLRenderingContext::vertexAttribfvImpl):
(WebCore::WebGLRenderingContext::simulateVertexAttrib0):
* html/canvas/WebGLRenderingContext.h:
(WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
* html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::create):
(WebCore::WebGLShader::WebGLShader):
* html/canvas/WebGLShader.h:
(WebCore::WebGLShader::getType):
* html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::setTarget):
(WebCore::WebGLTexture::setParameteri):
(WebCore::WebGLTexture::setParameterf):
(WebCore::WebGLTexture::setLevelInfo):
(WebCore::WebGLTexture::generateMipmapLevelInfo):
(WebCore::WebGLTexture::getInternalFormat):
(WebCore::WebGLTexture::getType):
(WebCore::WebGLTexture::getWidth):
(WebCore::WebGLTexture::getHeight):
(WebCore::WebGLTexture::isNPOT):
(WebCore::WebGLTexture::mapTargetToIndex):
(WebCore::WebGLTexture::computeLevelCount):
(WebCore::WebGLTexture::update):
(WebCore::WebGLTexture::getLevelInfo):
* html/canvas/WebGLTexture.h:
(WebCore::WebGLTexture::LevelInfo::setInfo):
* html/canvas/WebGLUniformLocation.cpp:
(WebCore::WebGLUniformLocation::create):
(WebCore::WebGLUniformLocation::WebGLUniformLocation):
(WebCore::WebGLUniformLocation::location):
* html/canvas/WebGLUniformLocation.h:
* platform/graphics/GraphicsContext3D.h: Map GC3Dboolean to bool instead of unsigned char.
2011-01-13 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
Change createObjectURL and revokeObjectURL to put under webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=52257
Note that we add "webkit" vendor prefix to URL that is introduced in
the latest File API spec.
For the time being, we implement webkitURL as a readonly attribute
instead of a constructor so that we will not expose prototype property,
as required by the spec.
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.mk:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/DOMURL.cpp: Added.
* html/DOMURL.h: Added.
* html/DOMURL.idl: Added.
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/utilities.js:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitURL):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::webkitURL):
* workers/WorkerContext.h:
* workers/WorkerContext.idl:
2011-01-13 Emil Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
Setting outerText should convert CR/LF to <br>
https://bugs.webkit.org/show_bug.cgi?id=52268
Make set outerText support line breaks (sharing the text to fragment code
with setInnerText) and handle empty text nodes the same way IE does.
Test: fast/dom/set-outer-text.html
* html/HTMLElement.cpp:
(WebCore::HTMLElement::textToFragment): Shared between setInnerText and setOuterText
(WebCore::HTMLElement::setInnerText): Split out text parsing code.
(WebCore::mergeWithNextTextNode): Split out text node merging code.
(WebCore::HTMLElement::setOuterText): Added support for line breaks.
* html/HTMLElement.h:
2011-01-13 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Relax the ESSL valid charset a little bit to include " ' `
https://bugs.webkit.org/show_bug.cgi?id=52396
* html/canvas/WebGLRenderingContext.cpp:
2011-01-13 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Attempt to fix crash in tiled compositor memcpy
https://bugs.webkit.org/show_bug.cgi?id=52379
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::update):
2011-01-13 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r75725.
http://trac.webkit.org/changeset/75725
https://bugs.webkit.org/show_bug.cgi?id=52317
Caused crashes in layout tests.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
* html/InputType.cpp:
* html/InputType.h:
* html/RangeInputType.cpp:
* html/RangeInputType.h:
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::detach):
* html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::SliderThumbElement):
(WebCore::SliderThumbElement::create):
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::attach):
(WebCore::MediaControlInputElement::updateStyle):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::~RenderSlider):
(WebCore::RenderSlider::styleDidChange):
(WebCore::RenderSlider::createThumbStyle):
(WebCore::RenderSlider::thumbRect):
(WebCore::RenderSlider::layout):
(WebCore::RenderSlider::updateFromElement):
(WebCore::RenderSlider::mouseEventIsInThumb):
(WebCore::RenderSlider::mouseEventOffsetToThumb):
(WebCore::RenderSlider::setValueForPosition):
(WebCore::RenderSlider::positionForOffset):
(WebCore::RenderSlider::currentPosition):
(WebCore::RenderSlider::trackSize):
(WebCore::RenderSlider::forwardEvent):
(WebCore::RenderSlider::inDragMode):
* rendering/RenderSlider.h:
2011-01-12 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Flip input[type=range] to use the new shadow DOM model.
https://bugs.webkit.org/show_bug.cgi?id=52317
This is a straight-up flip, minimal change to the logic, which will be
refactored in a follow-up patch.
Covered by existing tests.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
host or parent node to find parent.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
shadow DOM subtree.
* html/InputType.cpp:
(WebCore::InputType::createShadowSubtree): Added empty decl.
(WebCore::InputType::destroyShadowSubtree): Added a method to destroy
shadow subtree.
* html/InputType.h: Added defs.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
slider thumb.
* html/RangeInputType.h: Adde def.
* html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
to handle cascading appearance.
(WebCore::RenderSliderThumb::RenderSliderThumb): Added.
(WebCore::RenderSliderThumb::layout): Moved here the logic from
RenderSlider::createThumbStyle.
(WebCore::SliderThumbElement::createRenderer): Added virtual method to
create RenderSliderThumb instance.
(WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
as base class.
(WebCore::SliderThumbElement::detach): Ditto.
* html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::SliderThumbElement): Ditto.
(WebCore::SliderThumbElement::create): Ditto.
(WebCore::toSliderThumbElement): Added a casting helper.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
since the whole method is hand-rolled.
(WebCore::MediaControlInputElement::updateStyle): Ditto.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
(WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::layout): Ditto.
(WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
SliderThumbElement.
(WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
(WebCore::RenderSlider::setValueForPosition): Ditto.
(WebCore::RenderSlider::positionForOffset): Ditto.
(WebCore::RenderSlider::currentPosition): Ditto.
(WebCore::RenderSlider::trackSize): Ditto.
(WebCore::RenderSlider::forwardEvent): Ditto.
(WebCore::RenderSlider::inDragMode): Ditto.
* rendering/RenderSlider.h: Added def.
2011-01-13 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/8098442> Crash in Widget::setFrameRect()
https://bugs.webkit.org/show_bug.cgi?id=52375
Test: plugins/destroy-on-setwindow.html
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the view.
(WebCore::Widget::getOuterView): Coding style fix.
(WebCore::Widget::paint): Protect the Widget from being deleted as a result of calling out to
the views. This is precautionary, since this function does not applear to access member variables
after such calls.
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the platform widget.
2011-01-13 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix after r75715.
* WebCore.pri:
* WebCore.pro:
2011-01-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Qt build fix.
* WebCore.pri:
2011-01-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: embed injected script into the backend.
https://bugs.webkit.org/show_bug.cgi?id=52312
InjectedScript belongs to the backend of the system and
should be exposed by means of protocol, not InjectedScriptAccess.
This patch makes injected script a part of the backend.
It introduces single manual generation step (xxd -i) that should be
automated by the build scripts for all the platforms.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::injectedScriptSource):
* inspector/InjectedScriptHost.h:
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreInspectorStateFromCookie):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/InjectedScript.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone.propertyNamesCallback):
(WebInspector.doLoadedDone):
* inspector/xxd.pl: Added.
2011-01-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Cleanup after r75613 -- make all UI-facing strings
to be passed directly to WebInspector.UIString
https://bugs.webkit.org/show_bug.cgi?id=52365
* English.lproj/localizedStrings.js:
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._updateWithCookies):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
(WebInspector.ImageView.prototype._createContentIfNeeded):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkTimeCalculator.prototype.formatValue):
(WebInspector.NetworkTransferTimeCalculator.prototype.formatValue):
(WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
(WebInspector.ProfileDataGridNode.prototype.get data):
* inspector/front-end/Resource.js:
(WebInspector.Resource.Type.toUIString):
(WebInspector.Resource.Type.toString):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewCalculator.prototype.formatValue):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelineCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
* inspector/front-end/utilities.js:
():
2011-01-13 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Need a way to inform the application when a Netscape plugin is created.
https://bugs.webkit.org/show_bug.cgi?id=30179
Added "c" style static method for the application to hook up for
receiving notifications when a plugin is created.
* plugins/symbian/PluginViewSymbian.cpp:
(qtwebkit_setPluginCreatedCallback):
(WebCore::PluginView::platformStart):
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Seidel.
[Qt] Use a black background color for the video element on Qt Mobile
https://bugs.webkit.org/show_bug.cgi?id=52252
Use black as the background color for the video element on Qt Mobile.
* css/themeQtMobile.css:
(video):
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Seidel.
[Qt] Use a big central media play control button for video element
https://bugs.webkit.org/show_bug.cgi?id=52315
When ChromeClient::requiresFullscreenForVideoPlayback() returns true,
all other control buttons for the video element are hidden, except
a big centralized play button.
No new tests because no client implements requiresFullscreenForVideoPlayback yet.
* WebCore.pri:
* css/mediaControlsQtFullscreen.css: Added.
(audio):
(audio::-webkit-media-controls-panel):
(video::-webkit-media-controls-panel):
(video:-webkit-full-page-media::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button):
(video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button):
(video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container):
(video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display):
(video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline):
(video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider-container):
(video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider):
(video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button):
(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
2011-01-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Paint toggle buttons inconsistent when the object state is indeterminate
https://bugs.webkit.org/show_bug.cgi?id=52361
Check whether the object state is indeterminate to set the flag
GTK_STATE_FLAG_INCONSISTENT before rendering check and radio
buttons.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::paintToggle):
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249
Make MediaPlayerPrivateQt support a fullscreen player.
No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
So, still skip it for Qt.
* WebCore.pro:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::removeVideoItem):
(WebCore::MediaPlayerPrivateQt::restoreVideoItem):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(WebCore::MediaPlayerPrivateQt::supportsFullscreen):
(WebCore::MediaPlayerPrivateQt::mediaPlayer):
2011-01-13 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
<rdar://problem/8858548> Disable inheritance of text emphasis marks to ruby text
https://bugs.webkit.org/show_bug.cgi?id=52359
Test: fast/ruby/text-emphasis.html
* css/html.css:
(rt):
2011-01-13 Csaba Osztrogonác <ossy@webkit.org>
Rubber-stamped by David Levin.
Trivial fix after r75682.
* loader/FrameLoader.cpp: Remove accidentally committed debug code.
(WebCore::FrameLoader::shouldClose):
2011-01-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
https://bugs.webkit.org/show_bug.cgi?id=52241
The bug was caused by RenderTextControl::selection's creating a Range with m_insertText
which is a shadow DOM div as both start and end containers. Fixed the bug by traversing
through the descendents of m_innerText and using the right start and end containers to
create a Range.
Test: fast/forms/focus-change-on-keypress.html
* rendering/RenderTextControl.cpp:
(WebCore::setContainerAndOffsetForRange): Added; a helper function.
(WebCore::RenderTextControl::selection): See above.
2011-01-12 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
https://bugs.webkit.org/show_bug.cgi?id=51905
Calls unregisterFormElementWithFormAttribute() when 'form' attribute
is removed.
Tests: fast/forms/form-associated-element-crash.html
fast/forms/form-associated-element-crash2.html
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::formAttributeChanged):
2011-01-12 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
M_formElementsWithFormAttribute not cleared when Node is moved to another document.
https://bugs.webkit.org/show_bug.cgi?id=51418
Calls unregisterFormElementWithFormAttribute() when form associated elements
are moved to another document.
Test: fast/forms/change-form-element-document-crash.html
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::willMoveToNewOwnerDocument): Added.
* html/FormAssociatedElement.h: Added willMoveToNewOwnerDocument().
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::willMoveToNewOwnerDocument): Added.
* html/HTMLFormControlElement.h: Added willMoveToNewOwnerDocument().
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::willMoveToNewOwnerDocument): Added.
* html/HTMLObjectElement.h: Added willMoveToNewOwnerDocument().
* html/HTMLPlugInImageElement.h: Moves willMoveToNewOwnerDocument() to protected.
2011-01-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Stop instantiating legacy editing positions in ApplyBlockElementCommand and ApplyStyleCommand
https://bugs.webkit.org/show_bug.cgi?id=52250
Removed instantiation of legacy editing positions.
Calls to Position::Position are replaced by calls to Position's convenience functions.
Also added firstPositionInOrBeforeNode and lastPositionInOrAfterNode,
which are functions that return firstPositionInNode and lastPositionInNode respectively
when the specified node can have children for editing purpose and return positionBeforeNode
and positionAfterNode respectively otherwise. They can be used to guarantee that we never
create a bogus position like [img, 0] or [br, 0].
No tests are added since this is a cleanup.
* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::formatSelection):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
(WebCore::ApplyStyleCommand::removeInlineStyle):
(WebCore::ApplyStyleCommand::nodeFullySelected):
(WebCore::ApplyStyleCommand::nodeFullyUnselected):
(WebCore::ApplyStyleCommand::splitTextAtStart):
(WebCore::ApplyStyleCommand::splitTextAtEnd):
(WebCore::ApplyStyleCommand::splitTextElementAtStart):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode):
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
(WebCore::ApplyStyleCommand::computedFontSize):
(WebCore::ApplyStyleCommand::joinChildTextNodes):
* editing/ApplyStyleCommand.h:
* editing/htmlediting.h:
(WebCore::firstPositionInOrBeforeNode): Added.
(WebCore::lastPositionInOrAfterNode): Added.
2011-01-12 Sam Weinig <sam@webkit.org>
Another build fix.
* platform/mac/WheelEventMac.mm:
(WebCore::phaseForEvent):
2011-01-12 Sam Weinig <sam@webkit.org>
Fix build.
* platform/mac/WheelEventMac.mm:
(WebCore::phaseForEvent):
2011-01-12 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove premature optimization from SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=52283
As far as I can tell, this optimization isn't necessary. I'm slightly
unsure which benchmarks to run to demonstrate this numerically, but
none of the benchmarks Chromium tracks were affected by adding a
similar check for "display-isolated" schemes.
* platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
2011-01-12 Beth Dakin <bdakin@apple.com>
Reviewed by Anders Carlsson.
Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
Expose fixed layout through WebKit SPI
-and corresponding-
<rdar://problem/8844464>
And now with getters!
* WebCore.exp.in:
2011-01-12 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=52337
PlatformWheelEvent should know about the scroll phase on the Mac
Add a phase parameter on Mac PlatformWheelEvents.
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::phase):
* platform/mac/WheelEventMac.mm:
(WebCore::phaseForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
2011-01-12 Chris Marrin <cmarrin@apple.com>
Unreviewed.
A couple of lines of the patch for https://bugs.webkit.org/show_bug.cgi?id=52321
were omitted.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
2011-01-12 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Getting rid of an assert that was causing build failures that turns out not to be needed.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintsWithTransform):
2011-01-12 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Another fix for Gtk
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintsWithTransform):
2011-01-12 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Fix for Gtk and Windows builds
* page/Frame.cpp:
(WebCore::Frame::scalePage):
* page/Frame.h:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::contentsScale):
(PlatformCALayer::setContentsScale):
2011-01-12 Chris Marrin <cmarrin@apple.com>
UNreviewed.
Fix for the Windows build
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(contentsScale):
(setContentsScale):
2011-01-12 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Another build fix
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setContentsScale):
2011-01-11 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=52172
Tests: fast/canvas/canvas-large-dimensions.html
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
2011-01-12 Daniel Bates <dbates@rim.com>
And Benjamin C Meyer <bmeyer@rim.com>
Build fix when building with Inspector disabled
https://bugs.webkit.org/show_bug.cgi?id=52313
After changeset 75604 <http://trac.webkit.org/changeset/75604> it's not
possible to build when the Inspector is disabled.
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus): Fix build breakage when building
with Inspector disabled and Offline Web Applications enabled by moving macro guard condition
ENABLE(INSPECTOR) && ENABLE(OFFLINE_WEB_APPLICATIONS) into function body. This makes us also
consistent with the form we use for InspectorInstrumentation::networkStateChanged() and other
InspectorInstrumentation functions.
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveData): Fix build breakage when building with Inspector
disabled by adding ENABLE(INSPECTOR) guard around code that references the instance variable
ApplicationCacheGroup::m_currentResourceIdentifier as this variable only exists when building
with the Inspector.
(WebCore::ApplicationCacheGroup::didFinishLoading): Ditto.
(WebCore::ApplicationCacheGroup::didFail): Ditto.
2011-01-12 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Fix a build issue from http://trac.webkit.org/changeset/75639.
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::contentsScale):
(WebCore::GraphicsLayer::setContentsScale):
2011-01-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Kevin Decker.
Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
rdar://problem/8824974
This prevents the rootLayer (with the WebKit rendered content) from going becoming
a tiled layer when zoomed, and when there is other layered content on the page.
This speeds up zooming a lot and avoids some buggy behavior in CA with a very large
number of layers.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintsWithTransform):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintingGoesToWindow):
2011-01-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
rdar://problem/8824974
When scaled, WebKit renders the page content at the scaled up size, so there are no
scaling artifacts. But content drawn into a layer's backing store does not scale up.
This is made worse by the fact that the root page contents become layered when there
are other accelerated compositing layers present (video, plugins, etc.).
Plumb scaling factor from Frame::scalePage() down into all layers with content. It
eventually calls CALayer::setContentsScale which renders to a backing store whose dimensions
are scaled, causing them to render larger and appear pixel perfect at the scaled
page size.
* page/Frame.cpp:
(WebCore::Frame::updateContentsScale):
(WebCore::Frame::scalePage):
* page/Frame.h:
* platform/graphics/GraphicsLayer.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setContentsScale):
(WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
* platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::contentsScale):
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::contentsScale):
(PlatformCALayer::setContentsScale):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateContentsScale):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateForegroundLayer):
(WebCore::RenderLayerBacking::updateMaskLayer):
(WebCore::RenderLayerBacking::updateContentsScale):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateContentsScale):
* rendering/RenderLayerCompositor.h:
2011-01-12 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Fix DrawingBuffer issues for depth/stencil, extensions, etc.
https://bugs.webkit.org/show_bug.cgi?id=52310
1) GL_TEXTURE is not a valid argument to glFramebufferTexture2D()
(should be GL_TEXTURE_2D).
2) Support for the multisampling extension was being checked after
the DrawingBuffer constructor was called, which calls multisample()
to check for the extension.
3) If depth or stencil is set, the corresponding framebuffers must
be created in the DrawingBuffer constructor.
4) GL_DEPTH_STENCIL is not a valid framebuffer internal type in
GLES2. Must use GL_OES_DEPTH24_STENCIL8, and check for the
OES_packed_depth_stencil extension.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
Record the extension support in the constructor. Create all the
secondary drawing buffers (for multisampling, depth/stencil).
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::create):
Check for the extensions before calling the DrawingBuffer constructor.
(WebCore::DrawingBuffer::createSecondaryBuffers):
Refactor creation of the secondary buffers from DrawingBufferMac.mm to
here.
(WebCore::DrawingBuffer::reset):
Use DEPTH24_STENCIL8 format, not DEPTH_STENCIL. Use
DEPTH_COMPONENT16, not DEPTH_COMPONENT.
Use GL_TEXTURE_2D, not GL_TEXTURE (for glFramebufferTexture2D).
* platform/graphics/gpu/DrawingBuffer.h:
Refactor createSecondaryBuffers(). Add extension support arguments to
constructor. Add support for packed_depth_stencil extension.
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
Record extension support in constructor. Refactor out creation of
secondary buffers.
2011-01-12 Beth Dakin <bdakin@apple.com>
Reviewed by Anders Carlsson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
fixed layout through WebKit SPI
-and corresponding-
<rdar://problem/8844464>
Export symbols for ScrollView::setUseFixedLayout() and
ScrollView::setFixedLayoutSize()
* WebCore.exp.in:
2011-01-12 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Search input field doesn't have cancel button
Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.
Unskip a bunch of search field related tests that pass now:
fast/forms/search-cancel-button-mouseup.html
fast/forms/search-rtl.html
fast/forms/search-abs-pos-cancel-button.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-zoomed.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-display-none-cancel-button.html
fast/forms/search-placeholder-value-changed.html
fast/repaint/search-field-cancel.html
fast/forms/search-cancel-button-events.html
https://bugs.webkit.org/show_bug.cgi?id=42887
* platform/graphics/qt/ImageQt.cpp:
(loadResourcePixmap):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::paintSearchField):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::convertToPaintingRect):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
* platform/qt/RenderThemeQt.h:
2011-01-12 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: cookie table is multiplied after repeated switching to cookies tab in network item view
Only create cookiesTable is it hasn't been done yet.
https://bugs.webkit.org/show_bug.cgi?id=52303
* inspector/front-end/ResourceCookiesView.js:
(WebInspector.ResourceCookiesView.prototype.show):
2011-01-12 Koan-Sin Tan <koansin.tan@gmail.com>
Reviewed by Martin Robinson.
[Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50867
* config.h: Don't disallow ctype for (OS(DARWIN) && PLATFORM(GTK))
Many GTK+ related files include <libintl.h> or <glib/gi18n-lib.h>.
On Mac, <libintl.h> includes <xlocale.h>. <xclocale.h> includes
<xlocale/_ctype.h>, which uses isacii().
* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString): For OS(DARWIN) && !PLATFORM(CF)
use the Chromium Linux UUID generation.
2011-01-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel.
[CSS Gradients] One color stop should not paint anything for linear-gradient
https://bugs.webkit.org/show_bug.cgi?id=52259
Share color stop parsing code between linear and radial gradients.
Consider the gradient invalid if it has less than two color stops.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseGradientColorStops):
* css/CSSParser.h:
2011-01-12 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Fix inconsistencies in Inspector strings found by the new check-inspector-strings script.
https://bugs.webkit.org/show_bug.cgi?id=52295
* English.lproj/localizedStrings.js:
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
* inspector/front-end/Resource.js:
(WebInspector.Resource.Type.toString):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceRevisionTreeElement):
* inspector/front-end/utilities.js:
():
2011-01-12 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix WML compilation on Mac.
* wml/WMLInputElement.cpp:
(WebCore::WMLInputElement::setValue):
(WebCore::WMLInputElement::setValueForUser):
(WebCore::WMLInputElement::initialize):
(WebCore::WMLInputElement::validateInputMask):
* wml/WMLSelectElement.cpp:
(WebCore::WMLSelectElement::listBoxSelectItem):
2011-01-12 Justin Schuh <jschuh@chromium.org>
Unreviewed build fix for debug strict compiles.
Use fprintf for debug statements instead of fwrite, which caused compile failures
in debug strict mode because of failure to check the fwrite return value.
No behavior changed.
* rendering/CounterNode.cpp:
(WebCore::showTreeAndMark):
2010-12-29 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
inspector/timeline-network-resource.html fails when run twice
https://bugs.webkit.org/show_bug.cgi?id=37394
Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
instead of ResourceLoader::didReceiveResponse to cover the cases when resources
are loaded from memory cache.
Network notifications are now sent to InspectorInstrumentation which dispatches
them to interested agents and InspectorController.
* inspector/Inspector.idl:
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::willSendRequest):
(WebCore::InspectorController::didReceiveResponse):
(WebCore::InspectorController::didFailLoading):
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
* inspector/InspectorController.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::scriptImportedImpl):
(WebCore::InspectorInstrumentation::retrieveResourceAgent):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::identifierForInitialRequest):
(WebCore::InspectorInstrumentation::willSendRequest):
(WebCore::InspectorInstrumentation::markResourceAsCached):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didReceiveContentLength):
(WebCore::InspectorInstrumentation::didFinishLoading):
(WebCore::InspectorInstrumentation::didFailLoading):
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorInstrumentation::scriptImported):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::identifierForInitialRequest):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createResourceSendRequestData):
* inspector/TimelineRecordFactory.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.identifierForInitialRequest):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.addRecordToTimeline):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::didReceiveResponse):
(WebCore::ResourceLoadNotifier::didFailToLoad):
(WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
(WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
(WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
(WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponse):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didReceiveData):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
* loader/appcache/ApplicationCacheGroup.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):
* workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):
2011-01-12 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: do not replace all tabs with spaces when editing script source
https://bugs.webkit.org/show_bug.cgi?id=52291
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype._editLine):
2011-01-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Enforce READ_ONLY transactions in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=52229
Add READ_ONLY_ERR and return it whenever delete or put
are called. Note that IDBCursor's delete and update
are simply aliases for delete/put, which is why no
extra code is required to handle those cases.
Test: storage/indexeddb/transaction-read-only.html
* dom/ExceptionCode.cpp:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::deleteFunction):
* storage/IDBDatabase.idl:
* storage/IDBDatabaseException.h:
* storage/IDBDatabaseException.idl:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
2011-01-11 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GTK] minimal build breaks in RenderThemeGtk3
https://bugs.webkit.org/show_bug.cgi?id=52202
* platform/gtk/RenderThemeGtk3.cpp: Added VIDEO guards around
initMediaColors().
2011-01-11 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] PlatformVideoWindowMac implementation
https://bugs.webkit.org/show_bug.cgi?id=50770
This new implementation will be used on Mac OS to display the
fullscreen video window with the GStreamer-based media player.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::gstGWorldSyncMessageCallback):
* platform/graphics/gstreamer/PlatformVideoWindow.h:
(WebCore::PlatformVideoWindow::window):
* platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
(PlatformVideoWindow::PlatformVideoWindow):
(PlatformVideoWindow::~PlatformVideoWindow):
(PlatformVideoWindow::prepareForOverlay):
2011-01-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Webkit crashes when a gradient is applied using the first-line pseudo element
https://bugs.webkit.org/show_bug.cgi?id=52225
When a pseudostyle references images, we fail to register/unregister
the relevant RenderObjects as clients of the image in the style.
For gradients, this caused a crash.
This patch fixes the crash by returning a null gradient image in this
situation.
Test: fast/gradients/gradient-on-pseudoelement-crash.html
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
2011-01-11 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r71562): servePendingRequests() no longer called when
resources are done loading.
https://bugs.webkit.org/show_bug.cgi?id=52264
<rdar://problem/8767429>
In r71562, servePendingRequests() is no longer called in Loader's
didFinishLoading(), didFail() and didReceiveResponse() methods. Since
r71562 was intended only as a refactoring, these calls should be
restored. At least one WebKit-based Mac OS X application relies on this
for correct behavior.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadDone): Call
resourceLoadScheduler()->servePendingRequests().
2011-01-11 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Add Document::setContent()
https://bugs.webkit.org/show_bug.cgi?id=52085
Add a method to Document to set the whole content at once.
This removes the hack of the insert method in the xml parser
and is a predecessor to feed the xml parser with raw data.
* dom/Document.cpp:
(WebCore::Document::setContent):
* dom/Document.h:
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::insert): Added ASSERT_NOT_REACHED().
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureSVGFontData): Use setContent.
* xml/DOMParser.cpp:
(WebCore::DOMParser::parseFromString): Ditto.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML): Ditto.
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource): Ditto.
2011-01-11 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build fix.
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addArc): Switch to MathExtra's piFloat define,
rather than M_PI which is not always available.
2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Adam Barth.
Use plug-in DB for extensions to MIME type convertion
Plugins extension to MIME type conversion was not used in the
frameLoader. This was causing some fallback to be use which as the side
effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
This patch ensure that we try to convert the extension to MIME type
using the plugin database beofre using this fallback.
Attribute lost with Flash plugin without mime type set
https://bugs.webkit.org/show_bug.cgi?id=50657
Test: plugins/no-mime-with-valid-extension.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType): Use PluginDatabase for MIME
2011-01-11 James Simonsen <simonjam@chromium.org>
Reviewed by Eric Seidel.
[Web Timing] Rename sslHandshakeStart to secureConnectionStart
https://bugs.webkit.org/show_bug.cgi?id=52239
* page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::secureConnectionStart):
* page/PerformanceTiming.h:
* page/PerformanceTiming.idl:
2011-01-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
This patch actually makes the display-isolated schemes display
isolated. The behavior should be the same as the previous iteration of
this patch, but re-organized a bit because reading the access white
list is expensive.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::isAccessToURLWhiteListed):
(WebCore::SecurityOrigin::canDisplay):
* page/SecurityOrigin.h:
* platform/SchemeRegistry.cpp:
* platform/SchemeRegistry.h:
2011-01-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
Scroll event should be fired asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45631
Tests: fast/events/fire-scroll-event.html
fast/events/fire-scroll-event-element.html
fast/events/scroll-event-phase.html
Makes scroll events fire asynchronously to be in compliance with the
CSSOM View Module and consistent with Gecko, Opera and (to some degree)
IE.
Implemented via the EventQueue class added by r74062 (EventQueue now
has a convenience enqueueScrollEvent method).
* dom/EventQueue.cpp:
(WebCore::EventQueue::enqueueScrollEvent):
(WebCore::EventQueue::pendingEventTimerFired):
* dom/EventQueue.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::sendScrollEvent):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::valueChanged):
2011-01-11 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r75523.
* platform/wince/DragDataWinCE.cpp: Added missing include.
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
RefPtr the FrameView to prevent scrollbar from getting deleted inside
its scroll event.
https://bugs.webkit.org/show_bug.cgi?id=52238
Test: scrollbars/scrollable-iframe-remove-crash.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollTo):
2011-01-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Hyatt.
Make pseudo-style resolution less hard-coded when used to select a shadow node
https://bugs.webkit.org/show_bug.cgi?id=46595
Essentially implements the plumbing for the XBL2 pseudo attribute:
http://dev.w3.org/2006/xbl2/#the-pseudo-attribute
Test: fast/css/unknown-pseudo-element-matching.html
* css/CSSGrammar.y: Changed to handle specifier_list structure with the
CSSParser::updateSpecifierWithElementName helper, added logic to
keep unknown pseudo-element selectors at the top of the selector chain,
so that we can easily check for them and grab them, and also because
they would either not match anything or act as a descendant selector
(descendant into a shadow DOM subtree that is), not a specifier.
* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName): Generalized/combined
the logic adding element name to selectors and added the special case
to handle unknown pseudo-element selectors.
* css/CSSParser.h: Added def.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId): Removed any mention of PseudoSliderThumb/SLIDER_THUMB.
(WebCore::nameToPseudoTypeMap): Ditto.
(WebCore::CSSSelector::extractPseudoType): Ditto.
* css/CSSSelector.h: Added a new ShadowDescendant relation type,
removed PseudoSliderThumb def.
(WebCore::CSSSelector::isUnknownPseudoElement): Added a helper method.
* css/CSSSelectorList.cpp:
(WebCore::SelectorHasUnknownPseudoElementFunctor::operator()): Added a functor
to check for an unknown pseudo-element in the list.
(WebCore::CSSSelectorList::hasUnknownPseudoElements): Added.
* css/CSSSelectorList.h: Added a def.
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleSet::getPseudoRules): Added accessor to pseudo-element hash.
(WebCore::CSSStyleSelector::matchRules): Added matching pseudo elements.
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Added handling
of ShadowDescendant relation.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Enabled handling
of unknown pseudo-element selectors.
(WebCore::CSSRuleSet::addRule): Added populating unknown pseudo-element hash.
* css/html.css:
(input[type="range"]::-webkit-slider-thumb): Added previously-hard-coded
display:block.
* dom/Element.h:
(WebCore::Element::shadowPseudoId): Added new virtual method to allow
elements to provide the value of pseudo-element selector they would match.
* dom/Node.cpp:
(WebCore::Node::querySelector): Added checking for unknown pseudo-element selectors,
so that we can throw a SYNTAX_ERR if found.
(WebCore::Node::querySelectorAll): Ditto.
* html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::shadowPseudoId): Added to return "-webkit-slider-thumb";
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::createThumbStyle): Changed to use the new styleForElement logic.
* rendering/style/RenderStyleConstants.h: Removed SLIDER_THUMB.
2011-01-11 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=52233
WebKitCSSMatrix constructor should accept 'none'
as a valid string parameter.
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
2011-01-11 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Set all RenderBlocks as replaced when an inline display type is specified
https://bugs.webkit.org/show_bug.cgi?id=50858
When a RenderBlock is created for an element with a specified display:inline style,
it should always be treated as inline-block. This situations often comes up for form
controls. Previously, RenderBlock::styleWillChange set the replaced flag for display
values of inline-block, inline-table, and inline-table and a number of subclasses of
RenderBlock set the replaced flag in styleDidChange for a display:inline. However
sometimes new subclasses would miss this step leading to bugs (such as with RenderDetails).
This patch sets the replaced flag for all inline display types in RenderBlock::styleWillChange.
Code cleanup only, no change in behavior so no new tests.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::styleDidChange):
* rendering/RenderFieldset.cpp:
* rendering/RenderFieldset.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::styleDidChange):
* rendering/RenderListBox.cpp:
* rendering/RenderListBox.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::styleDidChange):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::styleDidChange):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
2011-01-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
REGRESSION(r71934) Can't type in search edit field on skin-one.com
https://bugs.webkit.org/show_bug.cgi?id=52195
Restored the original behavior, where the selectstart event is not
dispatched when selection changes inside of the shadow DOM.
* dom/Node.cpp:
(WebCore::determineDispatchBehavior): Moved EventDispatchBehavior-determining
logic into a helper function, also added a check to keep selectstart
events inside of the shadow DOM.
(WebCore::Node::dispatchGenericEvent): Changed to use the helper function.
2011-01-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Eric Seidel.
[Qt] Provide plugin coordinates to windowless plugins on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=52213
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
2011-01-10 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Need to consider UNPACK_ALIGNMENT in GraphicsContext3D::texImage2DResourceSafe
https://bugs.webkit.org/show_bug.cgi?id=52068
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D): Use computeImageSizeInBytes.
(WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::readPixels): Ditto, and fix a bug on generating the wrong error.
(WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
(WebCore::WebGLRenderingContext::validateTexFuncData): Use computeImageSizeInBytes.
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe): Add a new parameter alignment.
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters): Add more supported format/type.
(WebCore::GraphicsContext3D::computeImageSizeInBytes): Added.
* platform/graphics/GraphicsContext3D.h:
2011-01-10 Enrica Casucci <enrica@apple.com>
Reviewed by Alexey Proskuryakov.
Paste and drag and drop use different code paths to interact with the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=52093
The change consists in a refactoring of the code to have only one class that
deals with the pasteboard on Mac.
No new tests. A test is already available for this
(editing/pasteboard/drag-image-to-contenteditable-in-iframe.html) but had incorrect results.
* WebCore.exp.in:
* loader/EmptyClients.h: Added two Mac only methods to call into WebKit to use functionality
that is in NSURLExtras.
(WebCore::EmptyEditorClient::canonicalizeURL):
(WebCore::EmptyEditorClient::canonicalizeURLString):
* page/DragController.cpp:
The following methods have been changed to pass a pointer to the Frame object
to the DragData class.
(WebCore::documentFragmentFromDragData):
(WebCore::DragController::performDrag):
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):
* page/EditorClient.h: Added two Mac only methods to call into WebKit to use functionality
that is in NSURLExtras.
The following files have been modified to pass the Frame object to the DragData method calls.
* page/chromium/DragControllerChromium.cpp:
(WebCore::DragController::dragOperation):
* page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::dragOperation):
* page/mac/DragControllerMac.mm:
(WebCore::DragController::dragOperation):
* page/qt/DragControllerQt.cpp:
(WebCore::DragController::dragOperation):
* page/win/DragControllerWin.cpp:
(WebCore::DragController::dragOperation):
* platform/DragData.h: Removed Mac specific constructor and reference to PasteboardHelper class.
* platform/Pasteboard.h: Added public constructor to create a Pasteboard object from an NSPasteboard.
The following files were all modified to match the new parameters of the methods listed.
* platform/android/DragDataAndroid.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):
* platform/gtk/DragDataGtk.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/haiku/DragDataHaiku.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/mac/DragDataMac.mm:
(WebCore::DragData::DragData):
(WebCore::DragData::asPlainText):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getBestURL):
(WebCore::Pasteboard::asURL):
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/win/DragDataWin.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):
* platform/wince/DragDataWinCE.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asFragment):
* platform/wx/DragDataWx.cpp:
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
2011-01-11 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
RefPtr text node in setOuterText since calling appendData
on a text node can fire away dom event listener which might
remove the text node from underneath.
https://bugs.webkit.org/show_bug.cgi?id=52163
Test: fast/dom/text-node-append-data-remove-crash.html
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setOuterText):
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add support for <meter> element
https://bugs.webkit.org/show_bug.cgi?id=48713
* GNUmakefile.am: Enable meter element.
2011-01-11 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed buildfix.
[Qt][V8] Add missing include for debug build.
* loader/cache/CachedResourceLoader.cpp:
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: redirects are lost from the network panel upon navigation.
https://bugs.webkit.org/show_bug.cgi?id=52210
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
2011-01-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove uses of QFuture since it isn't supported on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=51204
* platform/network/qt/QtNAMThreadSafeProxy.cpp:
(WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy):
(WebCore::QtNAMThreadSafeProxy::localCookiesForUrl):
(WebCore::QtNAMThreadSafeProxy::localWillLoadFromCache):
* platform/network/qt/QtNAMThreadSafeProxy.h:
(WebCore::QtNAMThreadSafeProxy::cookiesForUrl):
(WebCore::QtNAMThreadSafeProxy::willLoadFromCache):
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: recreate script view after live edit.
https://bugs.webkit.org/show_bug.cgi?id=51751
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.set source):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback):
(WebInspector.ScriptsPanel.prototype.editScriptSource):
(WebInspector.ScriptsPanel.prototype.viewRecreated):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._doEditLine):
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: frameDetachedFromParent notification handler is missing in NetworkManager.
https://bugs.webkit.org/show_bug.cgi?id=52205
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.frameDetachedFromParent):
2011-01-11 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Audit present state" always disabled
https://bugs.webkit.org/show_bug.cgi?id=52199
Removed all traces of resource tracking checks, as we have it no more.
* English.lproj/localizedStrings.js:
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
* inspector/front-end/AuditsPanel.js:
2011-01-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move delayed search implementation to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51753
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
(WebInspector.SourceFrame.prototype.findSearchMatches):
(WebInspector.SourceFrame.prototype.cancelFindSearchMatches):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.hide):
(WebInspector.SourceView.prototype.searchCanceled):
(WebInspector.SourceView.prototype.performSearch.didFindSearchMatches):
(WebInspector.SourceView.prototype.performSearch):
2011-01-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: innerFirstChild has a side effect which should be called explicitly.
If a node is a frame's owner then innerFirstChild method
subscribes DOMAgent instance to the frame's doc's events.
I think this should be done explicitly when we meet with
the node for the first time. As I understand it happens
in buildArrayForContainerChildren method.
https://bugs.webkit.org/show_bug.cgi?id=52204
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::startListeningFrameDoc):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::innerFirstChild):
* inspector/InspectorDOMAgent.h:
2011-01-11 Adam Roben <aroben@apple.com>
Delete WKCACFLayer.{cpp,h}
These have been unused since r75262
* platform/graphics/win/WKCACFLayer.cpp: Removed.
* platform/graphics/win/WKCACFLayer.h: Removed.
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [regression] Cookies view does not allow columns resize.
https://bugs.webkit.org/show_bug.cgi?id=51877
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._updateWithCookies):
2011-01-11 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[chromium] canvas.toDataURL("image/jpeg") should composite onto black.
https://bugs.webkit.org/show_bug.cgi?id=51237
The Canvas specification requires that the canvas image is composited using
the Porter-Duff operator source-over onto a black background; the resultant
image should be JPEG encoded and returned as a dataURL. To composite image
A and background B, for any Porter-Duff operator, produce pixels I with
I = c(A)F(A) + c(B)F(B)
where, F(X) is the fraction [0.0-1.0] contributed to the composite by image
X, and c(X) are the premultiplied RGB color components of image X. Note by
definition, c(B) = 0 since the background is black, so I = c(A)F(A). Since
F(A) = 1 in Porter-Duff operator source-over, the composited pixels satisfy
I = c(A). Hence, to conform to the Canvas spec, pass the premultiplied RGB
color components of the canvas image to the JPEG encoder.
Covered by canvas/philip/tests/toDataURL.jpeg.alpha.html
* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::preMultipliedBGRAtoRGB): Use Porter-Duff source-over black.
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: get rid of APU-related code in WebKit/chromium.
https://bugs.webkit.org/show_bug.cgi?id=52152
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreInspectorStateFromCookie):
(WebCore::InspectorController::setInjectedScriptSource):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/inspector.js:
2011-01-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] Load timing is requested
for all resources (not only for the main one).
https://bugs.webkit.org/show_bug.cgi?id=51749
* inspector/InspectorController.cpp:
(WebCore::InspectorController::willSendRequest):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
2011-01-11 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] GRefPtr should not be used with Gtk widgets
https://bugs.webkit.org/show_bug.cgi?id=51241
GRefPtr breaks the widget life-cycle, the main problem is
that GRefPtr calls g_object_unref() when it's destroyed,
which is undesirable for widgets. In gtk+ widgets are created with
a floating reference and when added to a container, the container
takes the ownership of the widget consuming the floating
reference. So you don't usually need to call g_object_ref/unref on
widgets (only for some operations like reparent a widget) and
toplevel widgets are destroyed with gtk_widget_destroy().
* platform/ContextMenuItem.h:
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::~ContextMenu):
(WebCore::ContextMenu::setPlatformDescription):
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::releasePlatformDescription):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::title):
(WebCore::ContextMenuItem::setTitle):
(WebCore::ContextMenuItem::platformSubMenu):
(WebCore::ContextMenuItem::setSubMenu):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::setEnabled):
2010-10-10 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=51119, transformed
elements not responding properly to :hover after r73385.
Just use the entire document area as the hit test area,
since there appears to be a rounding bug/issues with relying
on float math when mapping the hit test area into
transformed coordinates.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
2011-01-10 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Fix canvas->canvas draws on the GPU path.
https://bugs.webkit.org/show_bug.cgi?id=52141
Two problems: according to the canvas spec, both source and
destination rects can have negative width or height, but this shouldn't
cause the image to be flipped. So we need to normalize the rects (in
the software path, this is done by BitmapImage*::draw). Secondly, in
the FBO->FBO path, the image needs to be flipped vertically, since it
is drawn upside down. We were doing this by flipping the destination
rect, but this doesn't work if the source rect is not the entire image,
since we extract the wrong part of the image. Fixed by flipping the
source rect instead (and flipping it within the image buffer's height,
not the source rect's height).
Covered by fast/canvas/drawImage-with-negative-source-destination.html.
* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
Put normalizeRect() in global scope.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):
Fix as above: normalize both source and dest rects, and flip the
source rect instead of the dest rect.
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::normalizeRect):
Put normalizeRect() in global scope.
2011-01-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Baseline qt_minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51313
No new tests as there is no new functionality.
* platform/graphics/qt/GraphicsLayerQt.cpp: Fix the location of the
QT_NO_ANIMATION guard.
* platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::applyDelta): Fix the location of the
QT_NO_WHEELEVENT guard.
2011-01-10 Joe Mason <jmason@rim.com>
Reviewed by Alexey Proskuryakov.
WebSockets: unbounded buffer growth when server sends bad data
https://bugs.webkit.org/show_bug.cgi?id=51253
Fail a websocket handshake after 1024 bytes without a newline, or if it
contains a null byte before the first newline.
Tests: http/tests/websocket/tests/handshake-fail-by-maxlength.html
http/tests/websocket/tests/handshake-fail-by-prepended-null.html
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readStatusLine):
2011-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by
Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
This patch adds the basic plumbing for display-isolated URL schemes.
Originally, this patch also had the functional change, but I've split
that off into a separate patch because the original patch caused a
performance regression.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canDisplay):
* platform/SchemeRegistry.cpp:
(WebCore::displayIsolatedURLSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsLocal):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
(WebCore::SchemeRegistry::localSchemes):
(WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
(WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
* platform/SchemeRegistry.h:
2011-01-10 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=52095
REGRESSION (r75277): 2 test cases (<1%) had incorrect layout
Fixes tests:
fullscreen/full-screen-remove-ancestor.html
fullscreen/full-screen-remove.html
Previously, the above tests were failing because DRT dumped the contents of their
<script> tags, though all the explicit tests were passing. This was caused by
the document's render tree being left in an inconsistent state when a full screen
element's ancestor was removed from the DOM.
In nodeWillBeRemoved(), match the code in webkitDidExitFullScreen().
Don't detach the documentElement, but rather simply call recalcStyle(Force).
* dom/Document.cpp:
(WebCore::Document::nodeWillBeRemoved):
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::setAnimating): #if ENABLED -> # if USE
* rendering/RenderFullScreen.h:
(WebCore::RenderFullScreen::RenderFullScreen): RenderFullScreen should be an anonymous renderer.
2011-01-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release
https://bugs.webkit.org/show_bug.cgi?id=52173
No new tests. This is only a build fix.
* platform/gtk/GRefPtrGtk.cpp: Guard the GdkCursor specialization against GTK+ 3.x.
In GTK+ 3.x, GdkCursor is just a GObject.
* platform/gtk/GRefPtrGtk.h: Ditto.
2011-01-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved Collector.* => Heap.*, since the file contains a class named "Heap".
* ForwardingHeaders/runtime/Collector.h: Removed.
* ForwardingHeaders/runtime/Heap.h: Copied from WebCore/ForwardingHeaders/runtime/Collector.h.
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/GCController.cpp:
* bindings/js/ScriptGCEvent.cpp:
2011-01-10 Leonid Ebril <leonid.ebril@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
https://bugs.webkit.org/show_bug.cgi?id=51879
Set the PluginQuirkDontSetNullWindowHandleOnDestroy for Adobe Lite
plugin if Flash 10 or newer (for Symbian platform), setting a nulled
window handler on destroy crashes WebKit.
* plugins/symbian/PluginPackageSymbian.cpp:
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::determineQuirks):
2011-01-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove unecessary RenderThemeGtk and WidgetRenderingContext code
https://bugs.webkit.org/show_bug.cgi?id=52170
Remove unnecessary code from RenderThemeGtk3 and RenderThemeGtk now that the
GtkStyleContext port is complete. Also remove WidgetRenderingContextGtk3 and
move WidgetRenderingRenderingContextGtk2 to WidgetRenderingContext and make it
GTK+ 2.x only. Some methods have been moved to RenderThemeGtk2 since they are
GTK+ 2.x only now.
No new tests. This should not change functionality.
* GNUmakefile.am: Remove WidgetRenderingContextGtk3 and gtk3drawing.c
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::RenderThemeGtk):
(WebCore::gtkIconState): Made this method static. It isn't used outside RenderThemeGtk.
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): Updated to refelct gtkIconState change.
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton): Ditto.
(WebCore::RenderThemeGtk::paintMediaButton): Ditto
* platform/gtk/RenderThemeGtk.h: Move a few methods which are now GTK+ 2.x only.
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::platformInit): Added this platform initialization method
that is only used for GTK+ 2.x at the moment.
(WebCore::RenderThemeGtk::~RenderThemeGtk): Added.
(WebCore::getGtkStateType): Made this method static.
(WebCore::RenderThemeGtk::getIndicatorMetrics): Moved this here from RenderThemeGtk.
(WebCore::setToggleSize): Updated to reflect changes to getGtkStateType.
(WebCore::RenderThemeGtk::paintButton): Ditto.
(WebCore::RenderThemeGtk::paintSliderTrack): Ditto.
(WebCore::RenderThemeGtk::paintSliderThumb): Ditto.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::gtkScrollbarStyle): Moved to the top of the file.
(WebCore::RenderThemeGtk::platformInit): Added.
(WebCore::RenderThemeGtk::~RenderThemeGtk): Added.
(WebCore::RenderThemeGtk::initMediaColors): Changed to use the GtkStyleContext API to
fetch these colors. This was the last dependency on the old API.
* platform/gtk/WidgetRenderingContext.cpp: Renamed from Source/WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp.
* platform/gtk/WidgetRenderingContext.h: Made GTK+ 2.x only.
* platform/gtk/WidgetRenderingContextGtk3.cpp: Removed.
* platform/gtk/gtk3drawing.c: Removed.
* platform/gtk/gtkdrawing.h: Made GTK+ 2.x only.
2011-01-10 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081
Test for the availability of cookie jar to return if cookies are enabled or not.
* platform/qt/CookieJarQt.cpp:
(WebCore::cookiesEnabled):
2011-01-10 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Enable reuse of RenderSurface for drawing.
https://bugs.webkit.org/show_bug.cgi?id=51928
Modifies RenderSurfaceChromium::prepareContentsTexture to avoid trying to 'reserve' a texture
that is already reserved, should an attempt be made to re-select a previously drawn render surface
in order to continue drawing to it. This use case appears when compositing into an offscreen texture.
Covered by existing test (compositing/geometry/fixed-position.html) when offscreen compositing enabled.
* platform/graphics/chromium/LayerTexture.h:
(WebCore::LayerTexture::isReserved):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::prepareContentsTexture):
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::isProtected):
* platform/graphics/chromium/TextureManager.h:
2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Port combo box painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51828
Use GtkStyleContext API to paint combo boxes when building with
GTK+ 3.x. Method paintButton() has been factored out and the new
static method renderButton() is used by both paintButton() and
paintMenuList().
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::adjustRepaintRect):
(WebCore::renderButton):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::popupInternalPaddingLeft):
(WebCore::RenderThemeGtk::popupInternalPaddingRight):
(WebCore::RenderThemeGtk::popupInternalPaddingTop):
(WebCore::RenderThemeGtk::popupInternalPaddingBottom):
(WebCore::RenderThemeGtk::paintMenuList):
2011-01-10 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] simplify complex glyph positioning code
https://bugs.webkit.org/show_bug.cgi?id=52159
Before, we had roughly same code duplicated for RTL and LTR.
Now, use the same code for both directions by being careful about
flipping signs where appropriate.
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::shapeGlyphs):
(WebCore::ComplexTextController::setGlyphXPositions):
2011-01-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fix gtk2 compilation for master
https://bugs.webkit.org/show_bug.cgi?id=51885
* platform/gtk/GtkVersioning.h: Replaced the 2.24.0 check with
2.23.0 to avoid using the old symbols in the 2.23 releases. Added
support for gdk_pixmap_get_size before the 2.23.4.
* platform/gtk/WidgetRenderingContextGtk2.cpp:
(WebCore::WidgetRenderingContext::WidgetRenderingContext):
Replaced the old gdk_drawable_get_size with gdk_pixmap_get_size.
2011-01-10 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; build fix for r75385.
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint):
2011-01-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75341.
http://trac.webkit.org/changeset/75341
https://bugs.webkit.org/show_bug.cgi?id=52157
Regressions on several pixel tests (Requested by jorlow on
#webkit).
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Port check and radio button painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51815
Use GtkStyleContext API to paint check and radio buttons when
building with GTK+ 3.x.
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::adjustRepaintRect):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::setCheckboxSize):
(WebCore::RenderThemeGtk::paintCheckbox):
(WebCore::RenderThemeGtk::setRadioSize):
(WebCore::RenderThemeGtk::paintRadio):
2011-01-10 François Sausset <sausset@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
MathML: vertical alignment & bar thickness adjustments of fractions.
https://bugs.webkit.org/show_bug.cgi?id=50018
The fraction bar thickness default value should follow the w3c MathML 3 recommendation:
http://www.w3.org/TR/MathML3/chapter3.html#presm.mfrac
The vertical alignment of the fraction bar should be more accurate, specially with operators (+,=,...).
Test: mathml/presentation/fractions.xhtml
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::RenderMathMLFraction):
(WebCore::RenderMathMLFraction::updateFromElement):
(WebCore::RenderMathMLFraction::layout):
(WebCore::RenderMathMLFraction::paint):
(WebCore::RenderMathMLFraction::baselinePosition):
* rendering/mathml/RenderMathMLFraction.h:
2011-01-10 Antti Koivisto <antti@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=52044
REGRESSION(r74807): No-store is ignored within a document
Don't use cached resources with Cache-control: no-store (unless cache policy is CachePolicyHistoryBuffer).
This matches a behavior that got lost in r74807.
Test: http/tests/misc/script-no-store.html
(by Alexey Proskuryakov)
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
2011-01-10 Patrick Gansterer <paroga@webkit.org>
Reviewed by Laszlo Gombos.
[WIN] Add ProxyServerWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=52031
Add stub implementation to fix ENABLE_NETSCAPE_PLUGIN_API on WinCE.
* CMakeLists.txt:
* CMakeListsWinCE.txt:
* platform/network/win/ProxyServerWin.cpp: Added.
(WebCore::proxyServersForURL):
2011-01-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869
We avoid the situation where we have to render the same arc
multiple times over itself. Now it renders just one oval and
moves to the end angle.
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addArc):
2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Port text input control painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51870
Use GtkStyleContext API to paint text input controls when building
with GTK+ 3.x.
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::adjustRepaintRect):
(WebCore::RenderThemeGtk::paintTextField):
2011-01-09 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Alexey Proskuryakov.
Forward declare some headers where possible
https://bugs.webkit.org/show_bug.cgi?id=52133
No new tests because no new functionality.
* css/CSSValue.h:
* dom/BeforeLoadEvent.h:
* dom/Event.cpp:
* dom/Event.h:
* dom/StyledElement.cpp:
* dom/StyledElement.h:
* loader/DocumentLoader.h:
* loader/FrameLoader.h:
* page/Frame.h:
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
* platform/graphics/filters/FEBlend.cpp:
* platform/graphics/filters/FEColorMatrix.cpp:
* platform/graphics/filters/FEComponentTransfer.cpp:
* platform/graphics/filters/FEComposite.cpp:
* platform/graphics/filters/FEConvolveMatrix.cpp:
* platform/graphics/filters/FEDiffuseLighting.cpp:
* platform/graphics/filters/FEDisplacementMap.cpp:
* platform/graphics/filters/FEFlood.cpp:
* platform/graphics/filters/FEGaussianBlur.cpp:
* platform/graphics/filters/FEMerge.cpp:
* platform/graphics/filters/FEMorphology.cpp:
* platform/graphics/filters/FEOffset.cpp:
* platform/graphics/filters/FESpecularLighting.cpp:
* platform/graphics/filters/FETile.cpp:
* platform/graphics/filters/FETurbulence.cpp:
* platform/graphics/filters/FilterEffect.cpp:
* platform/graphics/filters/FilterEffect.h:
* platform/graphics/filters/SourceAlpha.cpp:
* platform/graphics/filters/SourceGraphic.cpp:
* svg/SVGElement.cpp:
* svg/SVGElement.h:
* svg/SVGFEBlendElement.cpp:
* svg/SVGFEColorMatrixElement.cpp:
* svg/SVGFEComponentTransferElement.cpp:
* svg/SVGFECompositeElement.cpp:
* svg/SVGFEConvolveMatrixElement.cpp:
* svg/SVGFEConvolveMatrixElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
* svg/SVGFEDisplacementMapElement.cpp:
* svg/SVGFEGaussianBlurElement.cpp:
* svg/SVGFEImageElement.h:
* svg/SVGFEMergeElement.cpp:
* svg/SVGFEMorphologyElement.cpp:
* svg/SVGFEOffsetElement.cpp:
* svg/SVGFESpecularLightingElement.cpp:
* svg/SVGFETileElement.cpp:
* svg/SVGFETurbulenceElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
* svg/SVGFilterPrimitiveStandardAttributes.h:
* svg/SVGTextContentElement.cpp:
* svg/graphics/filters/SVGFEImage.cpp:
* svg/graphics/filters/SVGFEImage.h:
2011-01-10 Adam Roben <aroben@apple.com>
Windows build fix after r75313
* WebCore.vcproj/build-generated-files.sh: Updated for the change in
this script's path.
2011-01-10 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: make properties on Array's prototype non-enumerable.
https://bugs.webkit.org/show_bug.cgi?id=51776
* inspector/front-end/utilities.js:
():
2011-01-10 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Fraser.
Specificity of negated selectors apparently miscalculated
https://bugs.webkit.org/show_bug.cgi?id=41206
Give negated selectors the specificity of the selector they are negating.
This is the same as the behavior of other browsers.
Test: fast/css/pseudo-not.html
* css/CSSSelector.cpp:
(WebCore::CSSSelector::specificityForOneSelector):
2011-01-10 Adam Roben <aroben@apple.com>
Windows build fix after r75353
* WebCore.vcproj/WebCoreCommon.vsprops: Added rendering/mathml to the
include path.
2011-01-10 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Remove non-client-based Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=50921
Code clean up, covered by existing tests.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/ChromiumBridge.h:
* platform/chromium/GeolocationServiceChromium.cpp: Removed.
* platform/chromium/GeolocationServiceChromium.h: Removed.
2011-01-10 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: protocol related change. Rename stepIntoStatement, stepOutOfFunction, stepOverStatement.
stepIntoStatement => stepInto
stepOutOfFunction => stepOut
stepOverStatement => stepOver
https://bugs.webkit.org/show_bug.cgi?id=52142
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._stepOverClicked):
(WebInspector.ScriptsPanel.prototype._stepIntoClicked):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):
2011-01-10 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Port progressbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52054
Use GtkStyleContext API to paint progressbars when building with
GTK+ 3.x. Also add support for indeterminate progressbars.
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk.cpp:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeGtk::animationDurationForProgressBar):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeGtk::animationDurationForProgressBar):
(WebCore::RenderThemeGtk::paintProgressBar):
2011-01-10 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Remove unused class "Pen" in WebCore/platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=49955
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/Pen.cpp: Removed.
* platform/graphics/Pen.h: Removed.
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
* platform/graphics/wx/GraphicsContextWx.cpp:
* platform/graphics/wx/PenWx.cpp: Removed.
2011-01-10 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Create intermediate libWebCore library
https://bugs.webkit.org/show_bug.cgi?id=52116
Create intermediate libWebCore.la to avoid overflowing the linker
in the final link stage.
* GNUmakefile.am: define the new library.
2011-01-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75337.
http://trac.webkit.org/changeset/75337
https://bugs.webkit.org/show_bug.cgi?id=52137
It made fast/dom/navigator-detached-no-crash.html crash
(Requested by Ossy on #webkit).
* platform/qt/CookieJarQt.cpp:
(WebCore::cookiesEnabled):
2011-01-09 Mark Rowe <mrowe@apple.com>
Fix the build.
* WebCore.xcodeproj/project.pbxproj: Copy SVGResourcesCache.h in to PrivateHeaders
once more.
2011-01-09 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8765555> WebKit2: Search field focus ring is missing
Provide a focus ring visible rect to AppKit.
* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):
(-[WebCoreFlippedView _focusRingClipAncestor]):
2011-01-09 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
Move MathML renderer to rendering/mathml
https://bugs.webkit.org/show_bug.cgi?id=52131
Move all renderer of MathML to WebCore/rendering/mathml
No change of functionality, no new tests added.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* mathml/RenderMathMLBlock.cpp: Removed.
* mathml/RenderMathMLBlock.h: Removed.
* mathml/RenderMathMLFenced.cpp: Removed.
* mathml/RenderMathMLFenced.h: Removed.
* mathml/RenderMathMLFraction.cpp: Removed.
* mathml/RenderMathMLFraction.h: Removed.
* mathml/RenderMathMLMath.cpp: Removed.
* mathml/RenderMathMLMath.h: Removed.
* mathml/RenderMathMLOperator.cpp: Removed.
* mathml/RenderMathMLOperator.h: Removed.
* mathml/RenderMathMLRoot.cpp: Removed.
* mathml/RenderMathMLRoot.h: Removed.
* mathml/RenderMathMLRow.cpp: Removed.
* mathml/RenderMathMLRow.h: Removed.
* mathml/RenderMathMLSquareRoot.cpp: Removed.
* mathml/RenderMathMLSquareRoot.h: Removed.
* mathml/RenderMathMLSubSup.cpp: Removed.
* mathml/RenderMathMLSubSup.h: Removed.
* mathml/RenderMathMLUnderOver.cpp: Removed.
* mathml/RenderMathMLUnderOver.h: Removed.
* rendering/mathml: Added.
* rendering/mathml/RenderMathMLBlock.cpp: Copied from Source/WebCore/mathml/RenderMathMLBlock.cpp.
* rendering/mathml/RenderMathMLBlock.h: Copied from Source/WebCore/mathml/RenderMathMLBlock.h.
* rendering/mathml/RenderMathMLFenced.cpp: Copied from Source/WebCore/mathml/RenderMathMLFenced.cpp.
* rendering/mathml/RenderMathMLFenced.h: Copied from Source/WebCore/mathml/RenderMathMLFenced.h.
* rendering/mathml/RenderMathMLFraction.cpp: Copied from Source/WebCore/mathml/RenderMathMLFraction.cpp.
* rendering/mathml/RenderMathMLFraction.h: Copied from Source/WebCore/mathml/RenderMathMLFraction.h.
* rendering/mathml/RenderMathMLMath.cpp: Copied from Source/WebCore/mathml/RenderMathMLMath.cpp.
* rendering/mathml/RenderMathMLMath.h: Copied from Source/WebCore/mathml/RenderMathMLMath.h.
* rendering/mathml/RenderMathMLOperator.cpp: Copied from Source/WebCore/mathml/RenderMathMLOperator.cpp.
* rendering/mathml/RenderMathMLOperator.h: Copied from Source/WebCore/mathml/RenderMathMLOperator.h.
* rendering/mathml/RenderMathMLRoot.cpp: Copied from Source/WebCore/mathml/RenderMathMLRoot.cpp.
* rendering/mathml/RenderMathMLRoot.h: Copied from Source/WebCore/mathml/RenderMathMLRoot.h.
* rendering/mathml/RenderMathMLRow.cpp: Copied from Source/WebCore/mathml/RenderMathMLRow.cpp.
* rendering/mathml/RenderMathMLRow.h: Copied from Source/WebCore/mathml/RenderMathMLRow.h.
* rendering/mathml/RenderMathMLSquareRoot.cpp: Copied from Source/WebCore/mathml/RenderMathMLSquareRoot.cpp.
* rendering/mathml/RenderMathMLSquareRoot.h: Copied from Source/WebCore/mathml/RenderMathMLSquareRoot.h.
* rendering/mathml/RenderMathMLSubSup.cpp: Copied from Source/WebCore/mathml/RenderMathMLSubSup.cpp.
* rendering/mathml/RenderMathMLSubSup.h: Copied from Source/WebCore/mathml/RenderMathMLSubSup.h.
* rendering/mathml/RenderMathMLUnderOver.cpp: Copied from Source/WebCore/mathml/RenderMathMLUnderOver.cpp.
* rendering/mathml/RenderMathMLUnderOver.h: Copied from Source/WebCore/mathml/RenderMathMLUnderOver.h.
2011-01-08 Simon Fraser <simon.fraser@apple.com>
Reviewed by Alexey Proskuryakov.
HTMLStyleElement.disabled doesn't work (affects jQuery)
https://bugs.webkit.org/show_bug.cgi?id=25287
Fix the disabled property of a HTMLStyleElement to reflect,
and set the disabled state of its style sheet, as required
by DOM1 etc.
Based on initial patch by Tarun Nainani.
Test: fast/html/disable-style-element.html
* dom/StyleElement.h:
(WebCore::StyleElement::sheet): Make const.
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::disabled):
(WebCore::HTMLStyleElement::setDisabled): Getter and setter for disabled
call through to the sheet (if any).
2011-01-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Rename RenderForeignObject to RenderSVGForeignObject
https://bugs.webkit.org/show_bug.cgi?id=52129
Rename RenderForeignObject to RenderSVGForeignObject to match the naming schema in render/svg.
No change of functionality, no new tests.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderingAllInOne.cpp:
* rendering/svg/RenderForeignObject.cpp: Removed.
* rendering/svg/RenderForeignObject.h: Removed.
* rendering/svg/RenderSVGAllInOne.cpp:
* rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::updateBoxModelInfoFromStyle):
* rendering/svg/RenderSVGForeignObject.cpp: Copied from Source/WebCore/rendering/svg/RenderForeignObject.cpp.
(WebCore::RenderSVGForeignObject::RenderSVGForeignObject):
(WebCore::RenderSVGForeignObject::~RenderSVGForeignObject):
(WebCore::RenderSVGForeignObject::paint):
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):
(WebCore::RenderSVGForeignObject::localToParentTransform):
(WebCore::RenderSVGForeignObject::computeLogicalWidth):
(WebCore::RenderSVGForeignObject::computeLogicalHeight):
(WebCore::RenderSVGForeignObject::layout):
(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
(WebCore::RenderSVGForeignObject::nodeAtPoint):
(WebCore::RenderSVGForeignObject::mapLocalToContainer):
* rendering/svg/RenderSVGForeignObject.h: Copied from Source/WebCore/rendering/svg/RenderForeignObject.h.
(WebCore::RenderSVGForeignObject::renderName):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::createRenderer):
2011-01-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move all SVG renderer to WebCore/rendering/svg
https://bugs.webkit.org/show_bug.cgi?id=52087
No change of functionality. Just moved all SVG renderer to WebCore/rendering/svg.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vjproj/project.vjproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderForeignObject.cpp: Removed.
* rendering/RenderForeignObject.h: Removed.
* rendering/RenderSVGAllInOne.cpp: Removed.
* rendering/RenderSVGBlock.cpp: Removed.
* rendering/RenderSVGBlock.h: Removed.
* rendering/RenderSVGContainer.cpp: Removed.
* rendering/RenderSVGContainer.h: Removed.
* rendering/RenderSVGGradientStop.cpp: Removed.
* rendering/RenderSVGGradientStop.h: Removed.
* rendering/RenderSVGHiddenContainer.cpp: Removed.
* rendering/RenderSVGHiddenContainer.h: Removed.
* rendering/RenderSVGImage.cpp: Removed.
* rendering/RenderSVGImage.h: Removed.
* rendering/RenderSVGModelObject.cpp: Removed.
* rendering/RenderSVGModelObject.h: Removed.
* rendering/RenderSVGResource.cpp: Removed.
* rendering/RenderSVGResource.h: Removed.
* rendering/RenderSVGResourceClipper.cpp: Removed.
* rendering/RenderSVGResourceClipper.h: Removed.
* rendering/RenderSVGResourceContainer.cpp: Removed.
* rendering/RenderSVGResourceContainer.h: Removed.
* rendering/RenderSVGResourceFilter.cpp: Removed.
* rendering/RenderSVGResourceFilter.h: Removed.
* rendering/RenderSVGResourceFilterPrimitive.cpp: Removed.
* rendering/RenderSVGResourceFilterPrimitive.h: Removed.
* rendering/RenderSVGResourceGradient.cpp: Removed.
* rendering/RenderSVGResourceGradient.h: Removed.
* rendering/RenderSVGResourceLinearGradient.cpp: Removed.
* rendering/RenderSVGResourceLinearGradient.h: Removed.
* rendering/RenderSVGResourceMarker.cpp: Removed.
* rendering/RenderSVGResourceMarker.h: Removed.
* rendering/RenderSVGResourceMasker.cpp: Removed.
* rendering/RenderSVGResourceMasker.h: Removed.
* rendering/RenderSVGResourcePattern.cpp: Removed.
* rendering/RenderSVGResourcePattern.h: Removed.
* rendering/RenderSVGResourceRadialGradient.cpp: Removed.
* rendering/RenderSVGResourceRadialGradient.h: Removed.
* rendering/RenderSVGResourceSolidColor.cpp: Removed.
* rendering/RenderSVGResourceSolidColor.h: Removed.
* rendering/RenderSVGRoot.cpp: Removed.
* rendering/RenderSVGRoot.h: Removed.
* rendering/RenderSVGShadowTreeRootContainer.cpp: Removed.
* rendering/RenderSVGShadowTreeRootContainer.h: Removed.
* rendering/RenderSVGTransformableContainer.cpp: Removed.
* rendering/RenderSVGTransformableContainer.h: Removed.
* rendering/RenderSVGViewportContainer.cpp: Removed.
* rendering/RenderSVGViewportContainer.h: Removed.
* rendering/SVGImageBufferTools.cpp: Removed.
* rendering/SVGImageBufferTools.h: Removed.
* rendering/SVGMarkerData.h: Removed.
* rendering/SVGMarkerLayoutInfo.cpp: Removed.
* rendering/SVGMarkerLayoutInfo.h: Removed.
* rendering/SVGRenderSupport.cpp: Removed.
* rendering/SVGRenderSupport.h: Removed.
* rendering/SVGRenderTreeAsText.cpp: Removed.
* rendering/SVGRenderTreeAsText.h: Removed.
* rendering/SVGResources.cpp: Removed.
* rendering/SVGResources.h: Removed.
* rendering/SVGResourcesCache.cpp: Removed.
* rendering/SVGResourcesCache.h: Removed.
* rendering/SVGResourcesCycleSolver.cpp: Removed.
* rendering/SVGResourcesCycleSolver.h: Removed.
* rendering/SVGShadowTreeElements.cpp: Removed.
* rendering/SVGShadowTreeElements.h: Removed.
* rendering/svg/RenderForeignObject.cpp: Copied from Source/WebCore/rendering/RenderForeignObject.cpp.
* rendering/svg/RenderForeignObject.h: Copied from Source/WebCore/rendering/RenderForeignObject.h.
* rendering/svg/RenderSVGAllInOne.cpp: Copied from Source/WebCore/rendering/RenderSVGAllInOne.cpp.
* rendering/svg/RenderSVGBlock.cpp: Copied from Source/WebCore/rendering/RenderSVGBlock.cpp.
* rendering/svg/RenderSVGBlock.h: Copied from Source/WebCore/rendering/RenderSVGBlock.h.
* rendering/svg/RenderSVGContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGContainer.cpp.
* rendering/svg/RenderSVGContainer.h: Copied from Source/WebCore/rendering/RenderSVGContainer.h.
* rendering/svg/RenderSVGGradientStop.cpp: Copied from Source/WebCore/rendering/RenderSVGGradientStop.cpp.
* rendering/svg/RenderSVGGradientStop.h: Copied from Source/WebCore/rendering/RenderSVGGradientStop.h.
* rendering/svg/RenderSVGHiddenContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGHiddenContainer.cpp.
* rendering/svg/RenderSVGHiddenContainer.h: Copied from Source/WebCore/rendering/RenderSVGHiddenContainer.h.
* rendering/svg/RenderSVGImage.cpp: Copied from Source/WebCore/rendering/RenderSVGImage.cpp.
* rendering/svg/RenderSVGImage.h: Copied from Source/WebCore/rendering/RenderSVGImage.h.
* rendering/svg/RenderSVGModelObject.cpp: Copied from Source/WebCore/rendering/RenderSVGModelObject.cpp.
* rendering/svg/RenderSVGModelObject.h: Copied from Source/WebCore/rendering/RenderSVGModelObject.h.
* rendering/svg/RenderSVGResource.cpp: Copied from Source/WebCore/rendering/RenderSVGResource.cpp.
* rendering/svg/RenderSVGResource.h: Copied from Source/WebCore/rendering/RenderSVGResource.h.
* rendering/svg/RenderSVGResourceClipper.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceClipper.cpp.
* rendering/svg/RenderSVGResourceClipper.h: Copied from Source/WebCore/rendering/RenderSVGResourceClipper.h.
* rendering/svg/RenderSVGResourceContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceContainer.cpp.
* rendering/svg/RenderSVGResourceContainer.h: Copied from Source/WebCore/rendering/RenderSVGResourceContainer.h.
* rendering/svg/RenderSVGResourceFilter.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceFilter.cpp.
* rendering/svg/RenderSVGResourceFilter.h: Copied from Source/WebCore/rendering/RenderSVGResourceFilter.h.
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceFilterPrimitive.cpp.
* rendering/svg/RenderSVGResourceFilterPrimitive.h: Copied from Source/WebCore/rendering/RenderSVGResourceFilterPrimitive.h.
* rendering/svg/RenderSVGResourceGradient.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceGradient.cpp.
* rendering/svg/RenderSVGResourceGradient.h: Copied from Source/WebCore/rendering/RenderSVGResourceGradient.h.
* rendering/svg/RenderSVGResourceLinearGradient.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceLinearGradient.cpp.
* rendering/svg/RenderSVGResourceLinearGradient.h: Copied from Source/WebCore/rendering/RenderSVGResourceLinearGradient.h.
* rendering/svg/RenderSVGResourceMarker.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceMarker.cpp.
* rendering/svg/RenderSVGResourceMarker.h: Copied from Source/WebCore/rendering/RenderSVGResourceMarker.h.
* rendering/svg/RenderSVGResourceMasker.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceMasker.cpp.
* rendering/svg/RenderSVGResourceMasker.h: Copied from Source/WebCore/rendering/RenderSVGResourceMasker.h.
* rendering/svg/RenderSVGResourcePattern.cpp: Copied from Source/WebCore/rendering/RenderSVGResourcePattern.cpp.
* rendering/svg/RenderSVGResourcePattern.h: Copied from Source/WebCore/rendering/RenderSVGResourcePattern.h.
* rendering/svg/RenderSVGResourceRadialGradient.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceRadialGradient.cpp.
* rendering/svg/RenderSVGResourceRadialGradient.h: Copied from Source/WebCore/rendering/RenderSVGResourceRadialGradient.h.
* rendering/svg/RenderSVGResourceSolidColor.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceSolidColor.cpp.
* rendering/svg/RenderSVGResourceSolidColor.h: Copied from Source/WebCore/rendering/RenderSVGResourceSolidColor.h.
* rendering/svg/RenderSVGRoot.cpp: Copied from Source/WebCore/rendering/RenderSVGRoot.cpp.
* rendering/svg/RenderSVGRoot.h: Copied from Source/WebCore/rendering/RenderSVGRoot.h.
* rendering/svg/RenderSVGShadowTreeRootContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGShadowTreeRootContainer.cpp.
* rendering/svg/RenderSVGShadowTreeRootContainer.h: Copied from Source/WebCore/rendering/RenderSVGShadowTreeRootContainer.h.
* rendering/svg/RenderSVGTransformableContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGTransformableContainer.cpp.
* rendering/svg/RenderSVGTransformableContainer.h: Copied from Source/WebCore/rendering/RenderSVGTransformableContainer.h.
* rendering/svg/RenderSVGViewportContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGViewportContainer.cpp.
* rendering/svg/RenderSVGViewportContainer.h: Copied from Source/WebCore/rendering/RenderSVGViewportContainer.h.
* rendering/svg/SVGImageBufferTools.cpp: Copied from Source/WebCore/rendering/SVGImageBufferTools.cpp.
* rendering/svg/SVGImageBufferTools.h: Copied from Source/WebCore/rendering/SVGImageBufferTools.h.
* rendering/svg/SVGMarkerData.h: Copied from Source/WebCore/rendering/SVGMarkerData.h.
* rendering/svg/SVGMarkerLayoutInfo.cpp: Copied from Source/WebCore/rendering/SVGMarkerLayoutInfo.cpp.
* rendering/svg/SVGMarkerLayoutInfo.h: Copied from Source/WebCore/rendering/SVGMarkerLayoutInfo.h.
* rendering/svg/SVGRenderSupport.cpp: Copied from Source/WebCore/rendering/SVGRenderSupport.cpp.
* rendering/svg/SVGRenderSupport.h: Copied from Source/WebCore/rendering/SVGRenderSupport.h.
* rendering/svg/SVGRenderTreeAsText.cpp: Copied from Source/WebCore/rendering/SVGRenderTreeAsText.cpp.
* rendering/svg/SVGRenderTreeAsText.h: Copied from Source/WebCore/rendering/SVGRenderTreeAsText.h.
* rendering/svg/SVGResources.cpp: Copied from Source/WebCore/rendering/SVGResources.cpp.
* rendering/svg/SVGResources.h: Copied from Source/WebCore/rendering/SVGResources.h.
* rendering/svg/SVGResourcesCache.cpp: Copied from Source/WebCore/rendering/SVGResourcesCache.cpp.
* rendering/svg/SVGResourcesCache.h: Copied from Source/WebCore/rendering/SVGResourcesCache.h.
* rendering/svg/SVGResourcesCycleSolver.cpp: Copied from Source/WebCore/rendering/SVGResourcesCycleSolver.cpp.
* rendering/svg/SVGResourcesCycleSolver.h: Copied from Source/WebCore/rendering/SVGResourcesCycleSolver.h.
* rendering/svg/SVGShadowTreeElements.cpp: Copied from Source/WebCore/rendering/SVGShadowTreeElements.cpp.
* rendering/svg/SVGShadowTreeElements.h: Copied from Source/WebCore/rendering/SVGShadowTreeElements.h.
2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation.
Let client APIs know which URL a new window will start with
* loader/FrameLoader.cpp:
(WebCore::createWindow):
* page/ContextMenuController.cpp:
(WebCore::openNewWindow):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
2011-01-09 Dirk Schulze <krit@webkit.org>
Unreviewed sort of Xcode project file.
* WebCore.xcodeproj/project.pbxproj:
2011-01-09 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
Changes to add Process Launcher and Thread Launcher implementation to the WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=48511
* platform/FileSystem.h:
* platform/gtk/FileSystemGtk.cpp: Implement function to get a binary's path
(WebCore::applicationDirectoryPath):
2011-01-08 Martin Robinson <mrobinson@igalia.com>
GTK+ Build fix. Add missing headers to the source list, fixing make dist.
No new tests. This is only a build change.
* GNUmakefile.am: Add missing headers to the source list.
2011-01-08 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
[GTK] WebKit2 GNUmakefile is out of date from trunk
https://bugs.webkit.org/show_bug.cgi?id=51883
Added stubs for WebKit2 compilation.
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::contextMenuItemVector):
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::checked):
(WebCore::ContextMenuItem::enabled):
* platform/network/soup/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::authenticationClient):
2011-01-08 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982
This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.
Test: fast/canvas/canvas-fillPath-gradient-shadow.html
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
2011-01-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] PasteboardQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39771
Update the code to follow the coding style.
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
2011-01-08 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
HTML5 Conformance Test failure: approved/xhtml5/html_style_in_comment.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48593
XHTML <style> blocks, unlike HTML <style> blocks, should respect HTML
comments.
Test: fast/parser/xhtml-html-comment-in-style-block.xhtml
* dom/StyleElement.cpp:
(WebCore::isValidStyleChild): Remove the COMMENT_NODE check as the HTML parser doesn't add COMMENT_NODEs as children of style blocks.
(WebCore::StyleElement::process): Factored out a condition that must remain in sync.
2011-01-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Navigator.cookiesEnabled return true for Qt even if there is no cookie jar
https://bugs.webkit.org/show_bug.cgi?id=52081
Test for the availability of cookie jar to return if cookies are enabled or not. The network access
manager always exist, not the cookie jar.
* platform/qt/CookieJarQt.cpp:
(WebCore::cookiesEnabled):
2011-01-08 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Canceled frame loads can corrupt back forward list
https://bugs.webkit.org/show_bug.cgi?id=50254
Avoids changing m_currentItem until the navigation commits.
Also resets top-level history items if a subframe navigation is canceled.
* WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
* WebCore/loader/HistoryController.cpp:
* WebCore/loader/HistoryController.h:
2011-01-08 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Support createTouchList with Touch list for test automation.
Implemented JS/V8 custom functions for createTouchList.
https://bugs.webkit.org/show_bug.cgi?id=51196
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::createTouchList):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::createTouchListCallback):
* dom/Document.idl:
* dom/TouchEvent.cpp:
(WebCore::TouchEvent::initTouchEvent):
2011-01-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] CookieJarQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39778
Improve the coding style of CookieJarQt.cpp.
* platform/qt/CookieJarQt.cpp:
(WebCore::networkAccessManager):
(WebCore::cookiesEnabled):
2011-01-08 Jeff Miller <jeffm@apple.com>
Rubber-stamped by Dan Bernstein.
Fix QTMovieWin.vcproj to account for moving WebCore to Source\WebCore
https://bugs.webkit.org/show_bug.cgi?id=52114
* WebCore.vcproj/QTMovieWin.vcproj:
Add an extra .. to some InheritedPropertySheets entries since WebCore is now one level deeper.
2011-01-08 Dirk Schulze <krit@webkit.org>
Reviewed by Mihai Parparita.
SVG rendering clean up according to the webkit style rules 2
https://bugs.webkit.org/show_bug.cgi?id=52112
Modified the style of the license of all files in WebCore/rendering/svg to match the style
in WebCore/svg. Cleaned up the code according to the webkit style rules.
No change of functionality. No test added.
* rendering/svg/RenderSVGInline.cpp:
* rendering/svg/RenderSVGInline.h:
* rendering/svg/RenderSVGInlineText.cpp:
* rendering/svg/RenderSVGInlineText.h:
* rendering/svg/RenderSVGPath.cpp:
* rendering/svg/RenderSVGPath.h:
* rendering/svg/RenderSVGTSpan.cpp:
* rendering/svg/RenderSVGTSpan.h:
* rendering/svg/RenderSVGText.cpp:
* rendering/svg/RenderSVGText.h:
* rendering/svg/RenderSVGTextPath.cpp:
* rendering/svg/RenderSVGTextPath.h:
* rendering/svg/SVGInlineFlowBox.cpp:
* rendering/svg/SVGInlineFlowBox.h:
* rendering/svg/SVGInlineTextBox.cpp:
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGRootInlineBox.cpp:
* rendering/svg/SVGRootInlineBox.h:
* rendering/svg/SVGTextLayoutEngineBaseline.cpp: Brace was misplaced accoring to check-webkit-style.
(WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle):
* rendering/svg/SVGTextQuery.cpp:
* rendering/svg/SVGTextQuery.h:
2011-01-08 Dirk Schulze <krit@webkit.org>
Reviewed by Mihai Parparita.
SVG rendering clean up according to the webkit style rules
https://bugs.webkit.org/show_bug.cgi?id=52107
Cleanup of the SVG rendering code according to the webbkit style rules.
Changed style of licensing texts to match the style in WebCore/svg, no change
of the licensing text itself.
* rendering/RenderForeignObject.cpp:
* rendering/RenderForeignObject.h:
* rendering/RenderSVGBlock.cpp:
* rendering/RenderSVGBlock.h:
* rendering/RenderSVGContainer.cpp:
* rendering/RenderSVGContainer.h:
* rendering/RenderSVGGradientStop.cpp:
* rendering/RenderSVGGradientStop.h:
* rendering/RenderSVGHiddenContainer.cpp:
* rendering/RenderSVGHiddenContainer.h:
(WebCore::RenderSVGHiddenContainer::renderName):
(WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer):
(WebCore::RenderSVGHiddenContainer::requiresLayer):
(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
* rendering/RenderSVGImage.cpp:
* rendering/RenderSVGImage.h:
* rendering/RenderSVGModelObject.h:
* rendering/RenderSVGResource.cpp:
* rendering/RenderSVGResource.h:
* rendering/RenderSVGResourceClipper.cpp:
* rendering/RenderSVGResourceClipper.h:
* rendering/RenderSVGResourceContainer.cpp:
* rendering/RenderSVGResourceContainer.h:
* rendering/RenderSVGResourceFilter.cpp:
* rendering/RenderSVGResourceFilter.h:
* rendering/RenderSVGResourceFilterPrimitive.cpp:
* rendering/RenderSVGResourceFilterPrimitive.h:
* rendering/RenderSVGResourceGradient.cpp:
* rendering/RenderSVGResourceGradient.h:
* rendering/RenderSVGResourceLinearGradient.cpp:
* rendering/RenderSVGResourceLinearGradient.h:
* rendering/RenderSVGResourceMarker.cpp:
* rendering/RenderSVGResourceMarker.h:
* rendering/RenderSVGResourceMasker.cpp:
* rendering/RenderSVGResourceMasker.h:
* rendering/RenderSVGResourcePattern.cpp:
* rendering/RenderSVGResourcePattern.h:
* rendering/RenderSVGResourceRadialGradient.cpp:
* rendering/RenderSVGResourceRadialGradient.h:
* rendering/RenderSVGResourceSolidColor.cpp:
* rendering/RenderSVGResourceSolidColor.h:
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
* rendering/RenderSVGRoot.h:
* rendering/RenderSVGShadowTreeRootContainer.cpp:
* rendering/RenderSVGShadowTreeRootContainer.h:
* rendering/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
* rendering/RenderSVGTransformableContainer.h:
(WebCore::RenderSVGTransformableContainer::localToParentTransform):
(WebCore::RenderSVGTransformableContainer::setNeedsTransformUpdate):
(WebCore::RenderSVGTransformableContainer::localTransform):
* rendering/RenderSVGViewportContainer.cpp:
* rendering/RenderSVGViewportContainer.h:
* rendering/SVGImageBufferTools.cpp:
* rendering/SVGImageBufferTools.h:
* rendering/SVGMarkerData.h:
* rendering/SVGMarkerLayoutInfo.cpp:
* rendering/SVGMarkerLayoutInfo.h:
* rendering/SVGRenderSupport.cpp:
* rendering/SVGRenderSupport.h:
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/SVGRenderTreeAsText.h:
* rendering/SVGResources.cpp:
* rendering/SVGResources.h:
* rendering/SVGResourcesCache.cpp:
* rendering/SVGResourcesCache.h:
* rendering/SVGResourcesCycleSolver.cpp:
* rendering/SVGResourcesCycleSolver.h:
* rendering/SVGShadowTreeElements.cpp:
* rendering/SVGShadowTreeElements.h:
2011-01-07 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050
Update project files to understand WebCore's new location. I suspect
there will be some follow-up patches after we land this patch.
* Android.derived.jscbindings.mk:
* Android.jscbindings.mk:
* Android.v8bindings.mk:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
* WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
2011-01-07 Justin Garcia <justin.garcia@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=51851
Implement RenderSVGInlineText::localCaretRect()
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect): Implemented.
2011-01-07 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Added the missing null pointer check for r75293.
* dom/Document.cpp:
(WebCore::Document::adoptNode):
2011-01-07 Stephanie Lewis <slewis@apple.com>
Reviewed by Geoff Garen.
<rdar://problem/8649617> Migrate memory tracking from Safari to WebKit
https://bugs.webkit.org/show_bug.cgi?id=50799 Add Memory Sampler to WebKit
Add a sampler for printing off process memory statistics.
Export file mode.
* WebCore.exp.in:
2011-01-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
onbeforeunload is broken for framesets
https://bugs.webkit.org/show_bug.cgi?id=19418
Added beforeunload event support for sub frames. WebKit's implementation tries to match
that of Internet Explorer as much as possible. beforeunload event is fired for each and
every descendent of a frame that is about to navigate.
When a value other than null is returned by a beforeunload handler, a confirmation dialog
is shown for each handler (calls chrome's runBeforeUnloadConfirmPanel) just like it is done
for main frames.
In addition, navigation is forbidden while beforeunload handlers are being called.
Setting values to location.href, location.reload, and other means of navigations are thus
ignored while beforeunload event handler is being ran, matching Internet Explorer's behavior.
Because navigation needs to prevented globally, NavigationDisablerForBeforeUnload is added to
NavigationScheduler.h, which is instantiated as a RAII object in FrameLoader::shouldClose.
Tests: fast/events/before-unload-adopt-subframe-to-outside.html
fast/events/before-unload-adopt-within-subframes.html
fast/events/before-unload-forbidden-navigation.html
fast/events/before-unload-in-multiple-subframes.html
fast/events/before-unload-in-subframe.html
fast/events/before-unload-javascript-navigation.html
fast/events/before-unload-remove-and-add-subframe.html
fact/events/before-unload-remove-itself.html
fast/events/before-unload-with-subframes.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldClose): Calls fireBeforeUnloadEvent on m_frame and m_frame's
descendents. Returns true only if every call to fireBeforeUnloadEvent returned true.
(WebCore::FrameLoader::fireBeforeUnloadEvent): Fires a beforeunload event and calls
chrome's runBeforeUnloadConfirmPanel as needed.
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Calls shouldClose for all frames.
* loader/FrameLoader.h:
* loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::shouldScheduleNavigation): Checks the nullity of Page and calls
NavigationDisablerForBeforeUnload::isNavigationAllowed when url is not javascript scheme.
(WebCore::NavigationScheduler::scheduleRedirect): Calls shouldScheduleNavigation.
(WebCore::NavigationScheduler::scheduleLocationChange): Ditto.
(WebCore::NavigationScheduler::scheduleRefresh): Ditto.
(WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.
* loader/NavigationScheduler.h:
(WebCore::NavigationDisablerForBeforeUnload::NavigationDisablerForBeforeUnload): Disables navigation.
(WebCore::NavigationDisablerForBeforeUnload::~NavigationDisablerForBeforeUnload): Enables navigation
when called on the last instance of NavigationDisablerForBeforeUnload.
(WebCore::NavigationDisablerForBeforeUnload::isNavigationAllowed): Returns true if there are no instance
of NavigationDisablerForBeforeUnload left on the stack.
2011-01-07 Martin Robinson <mrobinson@igalia.com>
Build fix for GTK+.
* GNUmakefile.am: Add RenderFullScreen.cpp to the sources list.
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::setAnimating): Guard the call to contentChanged
with ENABLED(ACCELERATED_COMPOSITING).
2011-01-07 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; speculative fix for Windows debug build.
* bindings/js/JSBindingsAllInOne.cpp:
2011-01-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Adopting an iframe to a child frame results in stack overflow
https://bugs.webkit.org/show_bug.cgi?id=52018
Throws an exception when a document adopts an iframe that is an ancestor
of the document in the frame hierarchy. New behavior matches that of Firefox.
Test: fast/html/adopt-parent-frame.html
* dom/Document.cpp:
(WebCore::Document::adoptNode):
2011-01-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Scrollbar code cleanup
https://bugs.webkit.org/show_bug.cgi?id=52073
Scrollbar code cleanup:
- Remove ScrollbarThemeMac.{mm|h} from the mac sources list, we use
ScrollbarThemeChromiumMac.{mm|h}
- Remove USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define now that switch to
WebThemeEngine is permanent
- Fix typo in Linux scrollbar enum name
No new tests (compiles).
* WebCore.gypi:
* platform/chromium/ChromiumBridge.h:
* platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
2011-01-07 Jer Noble <jer.noble@apple.com>
GTK Linux build fix: isDocumentRunningFullScreenAnimation should
be protected both by ENABLE(FULLSCREEN_API) && USE(ACCELERATED_COMPOSITING)
* page/FrameView.cpp:
2011-01-07 Rafael Weinstein <rafaelw@chromium.org>
Reviewed by Eric Seidel.
Cleanup: Fold shadowParentNode into shadowHost
https://bugs.webkit.org/show_bug.cgi?id=51059
Replaces all uses of shadowParentNode.
No new tests because no behavior has changed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
* dom/Node.cpp:
(WebCore::Node::shadowHost):
(WebCore::Node::shadowAncestorNode):
(WebCore::eventTargetRespectingSVGTargetRules):
(WebCore::Node::getEventAncestors):
* dom/Node.h:
* editing/Editor.cpp:
(WebCore::Editor::findString):
* page/DragController.cpp:
(WebCore::asFileInput):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::instanceAssociatedWithShadowTreeElement):
(WebCore::EventHandler::dispatchMouseEvent):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasLineIfEmpty):
* rendering/RenderSVGShadowTreeRootContainer.cpp:
(WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title):
2011-01-07 Chris Marrin <cmarrin@apple.com>
Unreviewed.
I mistakenly included a Windows only file in a
cross platform file.
* platform/graphics/ca/GraphicsLayerCA.cpp:
2011-01-07 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Get rid of include of <QuartzCore/QuartzCore.h>
* platform/graphics/ca/GraphicsLayerCA.cpp:
2011-01-07 Jer Noble <jer.noble@apple.com>
Further build fixes. Add a ENABLE(FULLSCREEN_API) guard around
the implementation of requiresCompositingfForFullScreen.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):
2011-01-07 Jer Noble <jer.noble@apple.com>
No review, build fix only. Removed parameter who was causing
a warning in Release builds.
* dom/Document.cpp:
(WebCore::Document::webkitDidExitFullScreenForElement):
2011-01-07 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Use new wkCACFLayerGetContextUserData function
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
2011-01-07 James Robinson <jamesr@chromium.org>
Fix compile bustage due to bad merge in 75276.
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
2010-12-17 Jer Noble <jer@kokode.apple.com>
Reviewed by Simon Fraser.
Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444
Mark for export all those WebCore functions needed by WebFullscreenController.
* WebCore.exp.in:
2010-12-17 Jer Noble <jer@kokode.apple.com>
Reviewed by Simon Fraser.
Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444
screenRect is useful for more than just HTMLMediaElements. Promote it into
Element.
* dom/Element.cpp: Moved into Element from HTMLMediaElement.
* dom/Element.h: Ditto.
* dom/Node.cpp:
* html/HTMLMediaElement.cpp: Moved screenRect into Element.
* html/HTMLMediaElement.h: Ditto.
* WebCore.exp.in: Modify the exports list to reflect the new symbol name.
2010-12-17 Jer Noble <jer@kokode.apple.com>
Reviewed by Simon Fraser.
Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444
The RenderFullScreen is intended to be used by clients of that API to allow a DOM subtree to
be rendered outside its original Frame. Because of this, there are a few areas of the
rendering code which need to be special cased: RenderFullScreen layers should not be clipped
to the viewport, as they will almost always be rendering outside the viewport area;
RenderFullScreen graphics layers should not be reparented by the RenderLayerCompositor, as
the client will likely want to reparent the platformLayer into their own fullscreen platform
window; the FrameView must update the RenderFullScreen graphics layer tree separately from
the root layer, as the two trees are disconnected.
* page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayers): Special treatment for fullscreen renderer.
(WebCore::FrameView::syncCompositingStateRecursive): Ditto.
(WebCore::FrameView::paintContents): Ditto.
* rendering/RenderLayer.h: Add a new ContentChangeType enum entry for FullScreen.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::contentChanged): Add support for above.
* rendering/RenderLayerBacking.cpp:
(WebCore::layerOrAncestorIsFullScreen): New function.
(WebCore::RenderLayerBacking::updateCompositedBounds): Do not clip if the layerOrAncestorIsFullScreen.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Special treatment for fullscreen renderer.
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Ditto.
(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.
* rendering/RenderLayerCompositor.h:
2010-12-17 Jer Noble <jer@kokode.apple.com>
Reviewed by Simon Fraser.
Implemented non-accelerated fullscreen support. The Document will now vend a RenderFullScreen object for clients to
use to relocate the fullscreen element subtree.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444
* css/CSSStyleSelector.cpp:
(WebCore::loadFullScreenRulesIfNeeded): Change webkitFullScreen -> webkitIsFullScreen.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
* dom/Document.cpp:
(WebCore::Document::Document): Initialize m_fullScreenRenderer.
(WebCore::Document::detach): Call setFullScreenRenderer(0).
(WebCore::Document::nodeWillBeRemoved): Replicate the logic in webkitWillEnterFullScreenForElement.
(WebCore::Document::webkitWillEnterFullScreenForElement): Detach the fullscreen element to cause
a new RenderFullScreen renderer to be created with the new fullscreen element.
(WebCore::Document::webkitDidEnterFullScreenForElement): Notify clients of a fullscreen change
here, rather in "willEnter", to avoid reentrancy problems when clients remove nodes in response
to webkitfullscreenchange events.
(WebCore::Document::webkitWillExitFullScreenForElement): Recalculate the fullscreen element's style.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRenderer): Accessor for m_fullScreenRenderer.
(WebCore::Document::setFullScreenRendererSize): Set the style on the m_fullScreenRenderer with a new
size; this keeps clients from having to access the renderer's style directly.
(WebCore::Document::setFullScreenRendererBackgroundColor): Ditto.
* dom/Document.h:
(WebCore::Document::webkitIsFullScreen): Change webkitFullScreen -> webkitIsFullScreen.
(WebCore::Document::fullScreenRenderer): Accessor.
* dom/Document.idl:
* dom/Node.cpp:
(WebCore::Node::createRendererIfNeeded): If the document is in fullscreen mode, create a RenderFullScreen
object to insert between the fullscreen element and its parent.
* page/ChromeClient.h:
(WebCore::ChromeClient::fullScreenRendererChanged): Added.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Change webkitFullScreen -> webkitIsFullScreen.
2010-12-17 Jer Noble <jer@kokode.apple.com>
Reviewed by Simon Fraser.
Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444
This patch introduces a new RenderObject type: RenderFullScreen. The RenderFullScreen renderer
will be used to implement new FullScreen APIs. Because the RenderFullScreen object will be the
parent of the current fullscreen element, the style rules for fullscreen objects must change to
match.
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderFullScreen.cpp: Added.
(RenderFullScreen::setAnimating): Sets the m_isAnimating flag.
(RenderFullScreen::createFullScreenStyle): Returns a new RenderStyle containing the default stye
for RenderFullScreen objects.
* rendering/RenderFullScreen.h: Added.
(WebCore::RenderFullScreen::isRenderFullScreen): Added. Overrides the RenderObject version.
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderFullScreen): Added. Used for type-checking RenderFullScreen objects.
* css/fullscreen.css: Modified the contained fullscreen styles.
2011-01-07 James Robinson <jamesr@chromium.org>
Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952
This approach isn't quite right.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/DOMWindow.cpp:
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/Frame.cpp:
* page/Frame.h:
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
* page/animation/AnimationTimeController.cpp: Removed.
* page/animation/AnimationTimeController.h: Removed.
2011-01-07 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] Black text on black buttons using a dark theme
https://bugs.webkit.org/show_bug.cgi?id=35024
Implement RenderThemeQt::systemColor to apply the correct colors from the current Qt style.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::systemColor):
* platform/qt/RenderThemeQt.h:
2011-01-05 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Add WEBKIT_lose_context WebGL extension.
https://bugs.webkit.org/show_bug.cgi?id=51492
Tests: fast/canvas/webgl/context-lost-restored.html
fast/canvas/webgl/context-lost.html
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
(WebCore::JSWebGLRenderingContext::getSupportedExtensions):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::forceLostContext):
(WebCore::WebGLRenderingContext::onLostContext):
(WebCore::WebGLRenderingContext::getNumberOfExtensions):
(WebCore::WebGLRenderingContext::getExtensionNumber):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebKitLoseContext.cpp: Copied from WebCore/html/canvas/WebGLExtension.h.
(WebCore::WebKitLoseContext::WebKitLoseContext):
(WebCore::WebKitLoseContext::~WebKitLoseContext):
(WebCore::WebKitLoseContext::getName):
(WebCore::WebKitLoseContext::create):
(WebCore::WebKitLoseContext::loseContext):
* html/canvas/WebKitLoseContext.h: Copied from WebCore/html/canvas/WebGLExtension.h.
* html/canvas/WebKitLoseContext.idl: Copied from WebCore/html/canvas/WebGLExtension.h.
2011-01-07 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Build fix for Chromium. Missing include.
* page/animation/AnimationBase.cpp:
2011-01-07 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Build fix.
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
2011-01-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:
(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
called forgetWorld() none exists.
(6) Attempt to add a wrapper to a NULL map.
Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
* WebCore.exp.in:
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers):
* bindings/js/DOMWrapperWorld.h:
2011-01-07 Chris Marrin <cmarrin@apple.com>
Rubber-stamped by Simon Fraser.
Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Final step in unifying GraphicsLayer logic across Win and Mac. This
implements the Windows side classes for PlatformCALayer and supporting
classes. Also changed MediaPlayer to use new PlatformCALayerClient
so it can use PlatformCALayer directly rather than a dummy GraphicsLayer.
WKCACFLayerRenderer now does the task of notifying animations of their
start time. Also commented out an assert in AnimationBase because
AnimationController's frame time is not in sync with the new
AnimationTimeController. I've opened a new bug for that issue:
https://bugs.webkit.org/show_bug.cgi?id=52037
This also includes the Mac side changes backed out in
http://trac.webkit.org/changeset/75227.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* WebCore.xcodeproj/project.pbxproj:
* config.h:
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::freezeAtTime):
(WebCore::AnimationBase::getElapsedTime):
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::layerDidDisplay):
(WebCore::GraphicsLayer::showDebugBorders):
(WebCore::GraphicsLayer::showRepaintCounter):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
(WebCore::GraphicsLayerCA::setContentsToImage):
(WebCore::GraphicsLayerCA::setContentsToMedia):
(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::updateSublayerList):
* platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::platformCALayer):
(WebCore::GraphicsLayerCA::platformCALayerLayoutSublayersOfLayer):
(WebCore::GraphicsLayerCA::platformCALayerRespondsToLayoutChanges):
(WebCore::GraphicsLayerCA::platformCALayerContentsOrientation):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders):
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
(WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount):
(WebCore::GraphicsLayerCA::platformCALayerContentsOpaque):
(WebCore::GraphicsLayerCA::platformCALayerDrawsContent):
(WebCore::GraphicsLayerCA::platformCALayerLayerDidDisplay):
* platform/graphics/ca/PlatformCAAnimation.h:
* platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::owner):
(WebCore::PlatformCALayer::animationStarted):
* platform/graphics/ca/PlatformCALayerClient.h: Copied from WebCore/platform/graphics/ca/PlatformCALayerClient.h.
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setOwner):
(PlatformCALayer::create):
(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::contents):
(PlatformCALayer::setContents):
* platform/graphics/ca/win: Added.
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp: Added.
* platform/graphics/ca/win/PlatformCALayerWin.cpp: Added.
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp: Added.
* platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added.
(WebCore::PlatformCALayerWinInternal::owner):
* platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer display]):
* platform/graphics/mac/WebLayer.h:
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
(setLayerNeedsDisplayInRect):
(-[WebLayer setNeedsDisplay]):
(-[WebLayer display]):
* platform/graphics/mac/WebTiledLayer.mm:
(-[WebTiledLayer setNeedsDisplay]):
(-[WebTiledLayer display]):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::CGContextWithHDC):
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc):
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
(WebCore::MediaPlayerPrivateFullscreenWindow::rootChildLayer):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::~LayerClient):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerRespondsToLayoutChanges):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerAnimationStarted):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerContentsOrientation):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerPaintContents):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerShowDebugBorders):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerShowRepaintCounter):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerIncrementRepaintCount):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerContentsOpaque):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDrawsContent):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerLayerDidDisplay):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerLayoutSublayersOfLayer):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::platformMedia):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::createLayerForMovie):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::movieNewImageAvailable):
(WebCore::MediaPlayerPrivate::createLayerForMovie):
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::rootLayer):
(WebCore::WKCACFLayerRenderer::addPendingAnimatedLayer):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::setNeedsDisplay):
(WebCore::WKCACFLayerRenderer::destroyRenderer):
(WebCore::WKCACFLayerRenderer::render):
* platform/graphics/win/WKCACFLayerRenderer.h:
(WebCore::WKCACFLayerRendererClient::animationsStarted):
(WebCore::WKCACFLayerRendererClient::syncCompositingState):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::showDebugBorders):
(WebCore::RenderLayerBacking::showRepaintCounter):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::compositorShowDebugBorders):
(WebCore::RenderLayerCompositor::compositorShowRepaintCounter):
(WebCore::RenderLayerCompositor::notifyAnimationStarted):
(WebCore::RenderLayerCompositor::notifySyncRequired):
(WebCore::RenderLayerCompositor::paintContents):
(WebCore::RenderLayerCompositor::showDebugBorders):
(WebCore::RenderLayerCompositor::showRepaintCounter):
2011-01-07 Nate Chapin <japhet@chromium.org>
Reviewed by Darin Fisher.
Let PingLoader send cookies if FrameLoaderClient permits it.
https://bugs.webkit.org/show_bug.cgi?id=51898
Test: http/tests/navigation/ping-cookie.html
* loader/PingLoader.cpp:
(WebCore::PingLoader::PingLoader): Set m_shouldUseCredentialStorage
at load start time, since we won't be able to call
FrameLoaderClient::shouldUseCredentialStorage() later.
* loader/PingLoader.h:
(WebCore::PingLoader::shouldUseCredentialStorage):
2011-01-07 Xan Lopez <xlopez@igalia.com>
Unreviewed, rolling out r75256.
http://trac.webkit.org/changeset/75256
https://bugs.webkit.org/show_bug.cgi?id=50869
Broke GTK+ canvas tests
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addArc):
2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Port scrollbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52051
Use GtkStyleContext API to paint scrollbars when building with
GTK+ 3.x.
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::gtkScrollbarStyle):
* platform/gtk/ScrollbarThemeGtk.cpp:
* platform/gtk/ScrollbarThemeGtk.h:
* platform/gtk/ScrollbarThemeGtk2.cpp:
(WebCore::gtkStyleSetCallback):
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
* platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::gtkStyleChangedCallback):
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
(WebCore::ScrollbarThemeGtk::updateThemeProperties):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
2011-01-07 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/8783318> Text emphasis marks should not appear over characters that have ruby annotations
https://bugs.webkit.org/show_bug.cgi?id=51267
Test: fast/text/emphasis-avoid-ruby.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Use getEmphasisMarkPosition() to check if
there are text emphasis marks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Ditto.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Ditto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::getEmphasisMarkPosition): Added. Returns true and sets the emphasis mark
position if the text is style with emphasis marks and there isn’t a ruby annotation that should
suppress them. Otherwise returns false.
(WebCore::InlineTextBox::paint): Use getEmphasisMarkPosition() to check if emphasis marks should
be painted.
* rendering/InlineTextBox.h:
2011-01-07 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869
We avoid the situation where we have to render the same arc
multiple times over itself. Now it renders just one oval and
moves to the end angle.
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addArc):
2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Port buttons painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51812
Use GtkStyleContext API to paint buttons when building with GTK+
3.x.
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::adjustRectForFocus):
(WebCore::RenderThemeGtk::adjustRepaintRect):
(WebCore::RenderThemeGtk::paintButton):
2011-01-07 Zhenyao Mo <zmo@google.com>
Unreviewed, build fix.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
2011-01-06 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
copyTexSubImage2D shouldn't have undefined pixels
https://bugs.webkit.org/show_bug.cgi?id=51559
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D): Refactor to share some code with copyTexSubImage2D through helper function clip2D.
(WebCore::WebGLRenderingContext::copyTexSubImage2D): Initialize undefined pixels to 0.
(WebCore::WebGLRenderingContext::validateTexFuncLevel): Seperate the validation of level from validateTexFuncParameters.
(WebCore::WebGLRenderingContext::validateTexFuncParameters): Ditto.
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::getType): Expose the type of a texture.
* html/canvas/WebGLTexture.h:
2011-01-07 Takashi Toyoshima <toyoshim@google.com>
Reviewed by Kenneth Russell.
cleanupAfterGraphicsCall() is never called in
WebGLRenderingContext::checkFramebufferStatus()
https://bugs.webkit.org/show_bug.cgi?id=51668
No new tests. This is a trivial bug.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
2011-01-07 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
GTK: AX: atk tests need to be updated after recent changes
https://bugs.webkit.org/show_bug.cgi?id=51932
Make sure we can always get the right accesssible parent for an
AtkObject when traversing the hierarchy bottom up.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(isRootObject): New function to check whether an
AccessibilityObject is the root one or not, according to the
latest changes in the hierarchy.
(atkParentOfRootObject): Gets the appropriate AtkObject from GTK's
GAIL as the parent of the root AtkObject from WebCore.
(webkit_accessible_get_parent): Use atkParentOfRootObject.
(webkit_accessible_get_index_in_parent): Ditto.
(atkRole): Expose AccessibilityObjects with ScrollAreaRole as
AtkObject's of role ATK_ROLE_SCROLLED_PANE.
2011-01-07 Zhenyao Mo <zmo@google.com>
Unreviewed, Mac 32-bit build fix.
Use float instead of double in GL function arguments to avoid implicit type down casting.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::blendColor):
(WebCore::WebGLRenderingContext::clearColor):
(WebCore::WebGLRenderingContext::clearDepth):
(WebCore::WebGLRenderingContext::depthRange):
(WebCore::WebGLRenderingContext::lineWidth):
(WebCore::WebGLRenderingContext::polygonOffset):
(WebCore::WebGLRenderingContext::sampleCoverage):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLRenderingContext.idl:
2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Port slider painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51874
Use GtkStyleContext API to paint sliders when building with GTK+
3.x. Also move the code to adjust media slider to its own method
in RenderThemeGtk.cpp since it's common to both gtk 2 and 3.
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
2011-01-07 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] [WK2] QtWebKit does not build in debug, FileReader.cpp does not compile
https://bugs.webkit.org/show_bug.cgi?id=51992
Add the missing header. CString is used in debug by the calls to LOG().
* fileapi/FileReader.cpp:
2011-01-07 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Cairo's ContextShadow may mis-render some box shadows
https://bugs.webkit.org/show_bug.cgi?id=51374
The space required for the internal shadow of the corners was not
correctly considered.
* platform/graphics/cairo/ContextShadowCairo.cpp:
(WebCore::ContextShadow::drawRectShadow):
2011-01-06 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
REGRESSION (r74663): ASSERTION FAILED: m_tokenizer->lineNumber() == line.zeroBasedInt()
https://bugs.webkit.org/show_bug.cgi?id=52013
When excluding line numbers for composite strings, we forgot to exclude
the line number for the current string!
Test: fast/parser/line-number-composite-segmented-string.html
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::setExcludeLineNumbers):
2011-01-06 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Back out changes in http://trac.webkit.org/changeset/75199
This breaks the Windows build. Fixing it on that side. Until
then I'll back this out.
2011-01-06 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
When a live frame is moved between pages, some plug-in DOM methods cease to function
https://bugs.webkit.org/show_bug.cgi?id=45770
Test: fast/frames/iframe-reparenting-plugins.html
* page/Frame.cpp:
(WebCore::Frame::~Frame):
(WebCore::Frame::addObserver):
(WebCore::Frame::removeObserver):
* page/Frame.h:
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
Added observer to be notified when frame is destroyed.
* page/Page.cpp:
(WebCore::Page::~Page):
(WebCore::Page::refreshPlugins):
PluginData no longer stores page pointer.
* plugins/DOMMimeType.cpp:
(WebCore::DOMMimeType::DOMMimeType):
(WebCore::DOMMimeType::~DOMMimeType):
(WebCore::DOMMimeType::enabledPlugin):
* plugins/DOMMimeType.h:
(WebCore::DOMMimeType::create):
(WebCore::DOMMimeType::frameDestroyed):
Store frame instead of page pointer in DOMMimeType.
* plugins/DOMMimeTypeArray.cpp:
(WebCore::DOMMimeTypeArray::item):
(WebCore::DOMMimeTypeArray::namedItem):
Provide frame to create DOMMimeType.
* plugins/DOMPlugin.cpp:
(WebCore::DOMPlugin::DOMPlugin):
(WebCore::DOMPlugin::~DOMPlugin):
(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::namedItem):
* plugins/DOMPlugin.h:
(WebCore::DOMPlugin::create):
(WebCore::DOMPlugin::frameDestroyed):
Store frame instead of page pointer in DOMPlugin.
* plugins/DOMPluginArray.cpp:
(WebCore::DOMPluginArray::item):
(WebCore::DOMPluginArray::namedItem):
Provide frame to create DOMPlugin.
* plugins/PluginData.cpp:
(WebCore::PluginData::PluginData):
(WebCore::PluginData::initPlugins):
* plugins/PluginData.h:
No longer stores a pointer to the page.
Added page parameter to initPlugins.
* plugins/PluginDataNone.cpp:
(WebCore::PluginData::initPlugins):
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::PluginData::initPlugins):
* plugins/gtk/PluginDataGtk.cpp:
(WebCore::PluginData::initPlugins):
* plugins/wx/PluginDataWx.cpp:
(WebCore::PluginData::initPlugins):
Updated platforms to add (unused) page parameter to initPlugins.
2011-01-05 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Define GC3D types to match GL types and use them in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=45557
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::validateTexFuncData):
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe):
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
(WebCore::GraphicsContext3D::extractImageData):
(WebCore::GraphicsContext3D::extractTextureData):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::enable):
(WebCore::SharedGraphicsContext3D::disable):
(WebCore::SharedGraphicsContext3D::clear):
(WebCore::SharedGraphicsContext3D::drawArrays):
(WebCore::SharedGraphicsContext3D::getError):
(WebCore::SharedGraphicsContext3D::getIntegerv):
(WebCore::SharedGraphicsContext3D::createFramebuffer):
(WebCore::SharedGraphicsContext3D::createTexture):
(WebCore::SharedGraphicsContext3D::deleteFramebuffer):
(WebCore::SharedGraphicsContext3D::deleteTexture):
(WebCore::SharedGraphicsContext3D::framebufferTexture2D):
(WebCore::SharedGraphicsContext3D::texParameteri):
(WebCore::SharedGraphicsContext3D::texImage2D):
(WebCore::SharedGraphicsContext3D::texSubImage2D):
(WebCore::SharedGraphicsContext3D::readPixels):
(WebCore::SharedGraphicsContext3D::setActiveTexture):
(WebCore::SharedGraphicsContext3D::bindTexture):
(WebCore::SharedGraphicsContext3D::bindFramebuffer):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::sizeInBytes):
(WebCore::GraphicsContext3D::synthesizeGLError):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::sizeInBytes):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Initial build support for WebGL
https://bugs.webkit.org/show_bug.cgi?id=51716
Add initial build support for WebGL and insert bits of implementation
necessary for clean compilation into GraphicsContext3D.
No new tests. This is just a build change.
* GNUmakefile.am: Add missing files to the source lists.
* platform/graphics/GraphicsContext3D.h: Include IntSize.h as it's used below.
Include typedefs necessary for WebGL on GTK+ and consolidate typdefs which are the
same across different platforms. X11 headers define the VERSION symbol, so it's
necessary to undefine it, since it's used as an enum value.
2011-01-06 Helder Correia <helder@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext::drawConvexPolygon() has unnecessary code for shadow
https://bugs.webkit.org/show_bug.cgi?id=52014
The function is only used by RenderObject to draw box sides.
The shadow branch is never used and thus can be removed.
No new tests are necessary.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
2011-01-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make sure touch is disabled in the minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51316
No new tests as there is no new functionality.
* features.pri:
2011-01-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Freetype backend does not support WOFF
https://bugs.webkit.org/show_bug.cgi?id=51904
* CMakeListsEfl.txt: Add WOFF support to the sources list.
* GNUmakefile.am: Add WOFF support to the sources list.
* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::createFontCustomPlatformData): Call the WOFF decoder when appropriate.
(WebCore::FontCustomPlatformData::supportsFormat): Advertise support for WOFF.
2011-01-06 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Remove vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=48922
* page/DOMWindow.cpp:
(WebCore::DOMWindow::performance): Rename to performance.
* page/DOMWindow.h:
* page/DOMWindow.idl: Rename to performance and make replaceable.
2011-01-06 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Changed PlatformCALayer API. Added PlatformCALayerClient abstract class which is
used to communicate from PlatformCALayer to the owner. This replaces passing
GraphicsLayerCA pointer when creating PlatformCALayer. It also includes the
API that used to be in PlatformCALayerLayout. GraphicsLayerCA now implements
the PlatformCALayerClient API.
This change has little impact on the Mac side but makes the Windows
interface simpler, especially when handling video layers on Windows.
* WebCore.xcodeproj/project.pbxproj:
* config.h:
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::layerDidDisplay):
(WebCore::GraphicsLayer::showDebugBorders):
(WebCore::GraphicsLayer::showRepaintCounter):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
(WebCore::GraphicsLayerCA::setContentsToImage):
(WebCore::GraphicsLayerCA::setContentsToMedia):
(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::updateSublayerList):
* platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::platformCALayerLayoutSublayersOfLayer):
(WebCore::GraphicsLayerCA::platformCALayerRespondsToLayoutChanges):
(WebCore::GraphicsLayerCA::platformCALayerContentsOrientation):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders):
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
(WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount):
(WebCore::GraphicsLayerCA::platformCALayerContentsOpaque):
(WebCore::GraphicsLayerCA::platformCALayerDrawsContent):
(WebCore::GraphicsLayerCA::platformCALayerLayerDidDisplay):
(WebCore::GraphicsLayerCA::platformCALayer):
* platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::owner):
(WebCore::PlatformCALayer::animationStarted):
* platform/graphics/ca/PlatformCALayerClient.h: Added.
(WebCore::PlatformCALayerClient::~PlatformCALayerClient):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setOwner):
(PlatformCALayer::create):
(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::contents):
(PlatformCALayer::setContents):
* platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer display]):
* platform/graphics/mac/WebLayer.h:
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
(setLayerNeedsDisplayInRect):
(-[WebLayer setNeedsDisplay]):
(-[WebLayer display]):
* platform/graphics/mac/WebTiledLayer.mm:
(-[WebTiledLayer setNeedsDisplay]):
(-[WebTiledLayer display]):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::showDebugBorders):
(WebCore::RenderLayerBacking::showRepaintCounter):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::compositorShowDebugBorders):
(WebCore::RenderLayerCompositor::compositorShowRepaintCounter):
(WebCore::RenderLayerCompositor::notifyAnimationStarted):
(WebCore::RenderLayerCompositor::notifySyncRequired):
(WebCore::RenderLayerCompositor::paintContents):
(WebCore::RenderLayerCompositor::showDebugBorders):
(WebCore::RenderLayerCompositor::showRepaintCounter):
2011-01-06 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Allow framesets after hidden inputs
https://bugs.webkit.org/show_bug.cgi?id=51998
This implements the HTML5 spec update in response to:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11156
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
2010-12-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
vertexAttribPointer should raise INVALID_OPERATION if stride/offset is not multiple of the type size
https://bugs.webkit.org/show_bug.cgi?id=51725
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::vertexAttribPointer):
2011-01-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
[WINCE] Remove JSC::g_stackBase
https://bugs.webkit.org/show_bug.cgi?id=51779
* platform/wince/SharedTimerWinCE.cpp:
(WebCore::TimerWindowWndProc):
2011-01-06 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge
This allows LayoutTestController to pass WebCore::Node back to
layout tests.
Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.
Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html
https://bugs.webkit.org/show_bug.cgi?id=48957
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtDRTNodeRuntime::create):
(JSC::Bindings::QtDRTNodeRuntime::get):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
2011-01-06 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Eric Seidel.
WML Parser should treat line/column number in a consistent way
https://bugs.webkit.org/show_bug.cgi?id=51601
XML Parser treats line/column number as 1-based values, but WML ErrorHandler treat them as 0-based.
Therefore, this patch allows WML ErrorHandler to use 1-based values.
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::handleError): Treat line/column number as 1 based values.
* dom/XMLDocumentParser.h: Make textPositionOneBased public and Add TextPosition1(m_lastErrorPosition) to keep error line/column number.
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser): Initialize m_lastErrorPosition.
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser): Initialize m_lastErrorPosition.
* wml/WMLErrorHandling.cpp:
(WebCore::reportWMLError): Use 1 based value instead of 0 based value to report error line/column number.
2011-01-05 Adam Roben <aroben@apple.com>
Remove some dead code from WKCACFLayerRenderer
Fixes <http://webkit.org/b/51954> WKCACFLayerRenderer has dead and
redundant code for reacting to changes to the layer tree
Reviewed by Sam Weinig.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
* platform/graphics/win/WKCACFLayerRenderer.h:
Removed didFlushContext and the HashMap it depended on. We react to
changes to the layer tree in layerTreeDidChange instead.
2011-01-06 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: "AXExpanded" not exposed on most ARIA roles that use aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=51995
Test: platform/mac/accessibility/aria-expanded-standard-items.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIAExpanded):
(WebCore::AccessibilityObject::isExpanded):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isVisited):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
2010-12-28 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Must generate INVALID_VALUE errors for strings containing out-of-range characters
https://bugs.webkit.org/show_bug.cgi?id=50929
* html/canvas/WebGLRenderingContext.cpp: Validate characters according to GLSL ES 1.0 spec section 3.1.
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::shaderSource):
(WebCore::WebGLRenderingContext::validateString): Helper function to perform the character validation.
* html/canvas/WebGLRenderingContext.h: Declare validateString().
2011-01-06 Yong Li <yoli@rim.com>
Reviewed by Adam Barth.
Add the test case that is missed in r75066.
https://bugs.webkit.org/show_bug.cgi?id=48077
Test case: WebCore/manual-tests/bugzilla-48077.html.
2011-01-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952
Implements mozilla's animationTime property as described here:
https://developer.mozilla.org/en/DOM/window.mozAnimationStartTime
and http://hacks.mozilla.org/2010/08/more-efficient-javascript-animations-with-mozrequestanimationframe/
The property is called webkitAnimationTime as calling it the 'Start' time is not very informative.
This property exposes a notion of a 'current' time to use for declarative animations and allows
scripts to synchronize imperative animations with declarative ones if they choose to. Once queried
this time is saved and used for all declarative animation updates until the embedder paints/composites
the next frame and clears it, or 15ms elapse (in case the embedder isn't producing frames, for example
if the page is in a background tab).
This patch also ensures that all declarative animations started in the same script execution block
are synchronized even if some time elapses while script is running.
Test: fast/animation/animation-time.html
* WebCore.gypi:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitAnimationTime):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/Frame.cpp:
(WebCore::Frame::currentAnimationTime):
* page/Frame.h:
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
(WebCore::Page::animationTime):
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
* page/animation/AnimationTimeController.cpp: Added.
(WebCore::AnimationTimeController::AnimationTimeController):
(WebCore::AnimationTimeController::~AnimationTimeController):
(WebCore::AnimationTimeController::currentAnimationTime):
(WebCore::AnimationTimeController::clearCurrentAnimationTime):
(WebCore::AnimationTimeController::clearCurrentAnimationTimeTimerFired):
* page/animation/AnimationTimeController.h: Added.
(WebCore::AnimationTimeController::create):
2011-01-06 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Null out the parent stylesheet pointer when a css rule is removed.
https://bugs.webkit.org/show_bug.cgi?id=51993
Tests: fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html
fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html
* css/CSSRuleList.cpp:
(WebCore::CSSRuleList::deleteRule):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::deleteRule):
2011-01-04 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
NaN in a TypedArray should be converted to zero only for Float32Array.
https://bugs.webkit.org/show_bug.cgi?id=46990
Test: LayoutTests/fast/canvas/webgl/array-unit-tests.html
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::convertArrayValue):
(WebCore::constructArrayBufferView):
* html/canvas/Float32Array.h:
(WebCore::Float32Array::set):
(WebCore::Float32Array::item):
2011-01-06 Patrick Gansterer <paroga@webkit.org>
Unreviewed Windows build fix for r75161.
* platform/graphics/cg/GraphicsContextCG.cpp: Missing include added.
2011-01-06 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r75139.
Try to remove include after adding forward-declaration in r75145.
* platform/graphics/Gradient.h:
2011-01-06 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
https://bugs.webkit.org/show_bug.cgi?id=51811
Merge m_height and m_width members of ImageData into the new m_size member.
Image (BitmapImage, ImageSource) types in WebKit use IntSize to store their
width and height argument, except ImageData. This patch refactors ImageData
to follow the style of other Image types in WebKit.
Using of PassRefPtrs other than argument passing is not allowed in WebKit anymore.
This patch also refactors the PassRefPtr usages of ImageData.
It's just a refactoring, so we don't need any new tests.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readTerminal):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Reader::readImageData):
* html/ImageData.cpp:
(WebCore::ImageData::create):
(WebCore::ImageData::ImageData):
* html/ImageData.h:
(WebCore::ImageData::size):
(WebCore::ImageData::width):
(WebCore::ImageData::height):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::createEmptyImageData):
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/haiku/ImageBufferHaiku.cpp:
(WebCore::getImageData):
2011-01-06 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
document.querySelector(':nth-child(foo)') should throw a syntax error
https://bugs.webkit.org/show_bug.cgi?id=51231
Also fixes
CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
https://bugs.webkit.org/show_bug.cgi?id=21815
Add a check in the parser that other than an+b, only "odd" or "even" would be allowed
as parameters to nth selector.
Tests: fast/css/css3-nth-tokens-script.html
fast/css/css3-nth-tokens-style.html
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::isValidNthToken):
* css/CSSParser.h:
2011-01-06 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=51453
Check if m_reply is NULL before accessing.
* manual-tests/load-deferrer-resume-crash.html: Added.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::setLoadMode):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2011-01-06 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][V8] Fix the build when DEVICE_ORIENTATION is enabled.
No new tests needed.
* WebCore.pro: remove duplications and globally add RuntimeEnabledFeatures.
2011-01-06 Helder Correia <helder@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][GTK] Use GraphicsContext::hasShadow() in port-specific code
https://bugs.webkit.org/show_bug.cgi?id=51985
r75139 introduced GraphicsContext::hasShadow(). This can now simplify
and unify some code in the Qt and GTK ports.
No new tests necessary for this refactoring.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
2011-01-05 Darin Adler <darin@apple.com>
Fix Chromium Mac build.
* platform/graphics/Gradient.h: Forward-declare CGContextRef.
This might even make it possible to remove the include of
<CoreGraphics/CoreGraphics.h> for PLATFORM(WIN), but I did not
do that at this time because I don't want to break the Windows
build when fixing the Chromium build.
2011-01-05 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by David Levin.
Implement RemoteFontStream's skip behavior (in FontCustomPlatformData.cpp)
https://bugs.webkit.org/show_bug.cgi?id=51736
No new tests. This change has potential effect on @font-face CSS feature
on ports using Skia. Tested on Chromium that this change won't break
fast/css/font-face-remote.html. This change can make the test pass on
other ports using Skia.
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::RemoteFontStream::read):
2011-01-05 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=51869
GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
The shadow is being drawn, but getting clipped to the rect being filled.
The solution is to draw the gradient into a CGLayer (when a shadow is
required), then render the layer to the GraphicsContext.
This patch also fixes:
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html
Test: fast/canvas/canvas-fillRect-gradient-shadow.html
* platform/graphics/Gradient.h:
* platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::paint):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillRect):
2011-01-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185
Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.
Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.
Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
* WebCore.vcproj/QTMovieWinCommon.vsprops:
* WebCore.vcproj/QTMovieWinPostBuild.cmd:
* WebCore.vcproj/QTMovieWinPreBuild.cmd:
* WebCore.vcproj/WebCore.make:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
* WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
* WebCore.vcproj/WebCoreMediaQT.vsprops:
* WebCore.vcproj/WebCorePostBuild.cmd:
* WebCore.vcproj/WebCorePreBuild.cmd:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* WebCore.vcproj/copyInspectorFiles.cmd:
2011-01-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Ariya Hidayat.
Directly composited SVG images fail to render
https://bugs.webkit.org/show_bug.cgi?id=51975
There was already code, added in r67900, to detect whether an image
may be directly composited, by checking to see if it's a bitmap image.
However, CachedImage::image() returns the nullImage() if m_image is null,
which is a BitmapImage, confusing this test.
Test: compositing/images/direct-svg-image.html
* loader/cache/CachedImage.cpp: Remove nullImage(), since Image has
exactly the same method.
(WebCore::CachedImage::image): Use Image::nullImage().
* loader/cache/CachedImage.h:
(WebCore::CachedImage::hasImage): New method to ask whether the m_image is
non-null.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use hasImage()
so that we don't test the nullImage.
2011-01-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Fix percentage values in radius of radial gradients
https://bugs.webkit.org/show_bug.cgi?id=51979
Handle percentage values for the ending size of radial gradients.
Test: fast/gradients/css3-radial-gradients3.html
* css/CSSGradientValue.cpp:
(WebCore::CSSRadialGradientValue::resolveRadius): Add parameter for height or width, which is
non-null if percentage values are allowed, and compute percentage values when we see them.
(WebCore::CSSRadialGradientValue::createGradient): Pass height or width down to say that
percentages are OK when resolving end radii.
* css/CSSGradientValue.h: New parameter for resolveRadius.
2011-01-05 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
[Web Timing] Zero out some values on cross-origin redirects
https://bugs.webkit.org/show_bug.cgi?id=49294
Tests: http/tests/misc/webtiming-cross-origin-redirect.php
http/tests/misc/webtiming-origins.html
* loader/DocumentLoadTiming.h:
(WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::~FrameLoader):
(WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times.
(WebCore::FrameLoader::completed):
(WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin.
(WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
* loader/FrameLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
* page/PerformanceNavigation.cpp:
(WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
* page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::redirectStart): Ditto.
(WebCore::PerformanceTiming::redirectEnd): Ditto.
(WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set.
(WebCore::PerformanceTiming::unloadEventEnd): Ditto.
2011-01-05 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Default focus ring is too wide
https://bugs.webkit.org/show_bug.cgi?id=51854
This is an intermediate step to solve this bug. Use QPalette::Highlight
instead of default half-transparent black as the focus ring color.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::drawFocusRingForPath):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::platformFocusRingColor):
* platform/qt/RenderThemeQt.h:
2011-01-05 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] requestStart and responseStart should be available even if the document is still loading
https://bugs.webkit.org/show_bug.cgi?id=51368
Test: http/tests/misc/webtiming-slow-load.php
* page/PerformanceTiming.cpp:
(WebCore::getPossiblySkewedTimeInKnownRange): Handle case where response is not yet complete.
(WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Use full upper bound.
2011-01-05 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Add WebKitClient::createAudioDevice() for Chromium port of web audio API
https://bugs.webkit.org/show_bug.cgi?id=51424
No new tests since audio API is not yet implemented.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
2011-01-05 Anders Carlsson <andersca@apple.com>
Try again.
* WebCore.exp.in:
2011-01-05 Anders Carlsson <andersca@apple.com>
Attempt to fix Leopard build.
* WebCore.exp.in:
2011-01-05 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] refactor complex text on Linux
https://bugs.webkit.org/show_bug.cgi?id=51956
Pull out TextRunWalker from FontLinux.cpp. Put it in its own file.
Rename it to ComplexTextController, to match platform/graphics/mac
more closely.
No tests because the change is just renaming a class.
* WebCore.gyp/WebCore.gyp:
* platform/graphics/chromium/ComplexTextControllerLinux.cpp: Added.
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::~ComplexTextController):
(WebCore::ComplexTextController::isWordBreak):
(WebCore::ComplexTextController::determineWordBreakSpacing):
(WebCore::ComplexTextController::setPadding):
(WebCore::ComplexTextController::reset):
(WebCore::ComplexTextController::setBackwardsIteration):
(WebCore::ComplexTextController::nextScriptRun):
(WebCore::ComplexTextController::widthOfFullRun):
(WebCore::ComplexTextController::setupFontForScriptRun):
(WebCore::ComplexTextController::allocHarfbuzzFont):
(WebCore::ComplexTextController::deleteGlyphArrays):
(WebCore::ComplexTextController::createGlyphArrays):
(WebCore::ComplexTextController::resetGlyphArrays):
(WebCore::ComplexTextController::shapeGlyphs):
(WebCore::ComplexTextController::setGlyphXPositions):
(WebCore::ComplexTextController::normalizeSpacesAndMirrorChars):
(WebCore::ComplexTextController::getNormalizedTextRun):
* platform/graphics/chromium/ComplexTextControllerLinux.h: Added.
(WebCore::ComplexTextController::setWordSpacingAdjustment):
(WebCore::ComplexTextController::setLetterSpacingAdjustment):
(WebCore::ComplexTextController::letterSpacing):
(WebCore::ComplexTextController::setXOffsetToZero):
(WebCore::ComplexTextController::rtl):
(WebCore::ComplexTextController::glyphs):
(WebCore::ComplexTextController::length):
(WebCore::ComplexTextController::xPositions):
(WebCore::ComplexTextController::advances):
(WebCore::ComplexTextController::width):
(WebCore::ComplexTextController::logClusters):
(WebCore::ComplexTextController::numCodePoints):
(WebCore::ComplexTextController::fontPlatformDataForScriptRun):
(WebCore::ComplexTextController::isCodepointSpace):
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::glyphIndexForXPositionInScriptRun):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
2011-01-05 Pratik Solanki <psolanki@apple.com>
Reviewed by Darin Adler.
Merge cf and mac header files with same name
https://bugs.webkit.org/show_bug.cgi?id=51916
Since most of the code in the header files is identical, we can merge them and have #if
USE(CFNETWORK) to separate out the network specific parts.
* WebCore.xcodeproj/project.pbxproj:
* platform/network/cf/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::sender):
(WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
* platform/network/cf/ResourceError.h:
(WebCore::ResourceError::ResourceError):
* platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/mac/AuthenticationChallenge.h: Removed.
* platform/network/mac/ResourceError.h: Removed.
* platform/network/mac/ResourceRequest.h: Removed.
* platform/network/mac/ResourceResponse.h: Removed.
2011-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Adele Peterson.
Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943
Export Editor functions needed by WebKit2.
* WebCore.exp.in:
2011-01-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt.
Implement repeating CSS3 gradients
https://bugs.webkit.org/show_bug.cgi?id=51843
Add support for repeating gradients, via the new gradient functions
-webkit-repeating-linear-gradient and -webkit-repeating-radial-gradient.
Tests: fast/gradients/css3-repeating-linear-gradients.html
fast/gradients/css3-repeating-radial-gradients.html
* css/CSSGradientValue.h:
(WebCore::CSSGradientValue::isRepeating): Accessor for whethe the gradient repeats.
(WebCore::CSSGradientValue::CSSGradientValue): Pass CSSGradientRepeat in.
(WebCore::CSSLinearGradientValue::create): Pass CSSGradientRepeat.
(WebCore::CSSLinearGradientValue::CSSLinearGradientValue): Ditto
(WebCore::CSSRadialGradientValue::create): Ditto.
(WebCore::CSSRadialGradientValue::CSSRadialGradientValue): Ditto.
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops): Pass maxLengthForRepeat, which
is used for repeating radial gradients. Add code to repeat the stops,
adding stops before the start, and after the end until the 0-N range is
covered, where N is large enough to ensure the box is covered. Fix an issue
with repeating gradients where if both stops were < 0, it would fail to clamp
them to 0.
(WebCore::CSSLinearGradientValue::cssText): Output strings for repeating gradients.
(WebCore::CSSLinearGradientValue::createGradient): maxExtent for linear gradients is 1,
because they are guaranteed to fill the box already.
(WebCore::CSSRadialGradientValue::cssText): Output strings for repeating gradients.
(WebCore::CSSRadialGradientValue::createGradient): Compute the distance to the furthest
corner in order to inform addStops() how much additional extent is required.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseDeprecatedGradient): Old gradients never repeat.
(WebCore::CSSParser::parseLinearGradient): Pass down CSSGradientRepeat.
(WebCore::CSSParser::parseRadialGradient): Ditto.
(WebCore::CSSParser::isGeneratedImageValue): Add repeating gradient functions.
(WebCore::CSSParser::parseGeneratedImage): Ditto.
* css/CSSParser.h: Pass CSSGradientRepeat to gradient functions.
* platform/graphics/cg/GradientCG.cpp: Remove unused #include.
2011-01-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ariya Hidayat.
ContextShadow::blurLayerImage() not endian-safe
https://bugs.webkit.org/show_bug.cgi?id=51822
Correct the channel map in ContextShadow to reflect the different
ordering of pixels on processors with different endianness.
No new tests. This is covered by the existing shadow tests. It was
not discovered, because all of the bots using ContextShadow are
little-endian.
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::blurLayerImage): Initialize the channel mapping
based on machine endianness.
2011-01-05 Mihai Parparita <mihaip@chromium.org>
Reviewed by Nate Chapin.
[Chromium] Crash when drawing PDF plug-in scrollbars
https://bugs.webkit.org/show_bug.cgi?id=51942
Pepper plug-in scrollbars don't have a parent, guard against that before
seeing if the parent is a FrameView.
Not testable via layout tests, verified fix by hand.
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
2011-01-05 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Update FIXME comment to sound better. Also initialize the block to fix compile.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
2011-01-05 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Do not merge anonymous blocks when one of them is the one getting removed.
https://bugs.webkit.org/show_bug.cgi?id=51919
Test: fast/block/merge-anonymous-block-remove-child-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
2011-01-05 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
ApplyStyleCommand::applyRelativeFontStyleChange should take EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=50641
Modified applyRelativeFontStyleChange to take EditingStyle instead of CSSMutableStyleDeclaration.
Also extracted the logic to obtain the font size delta from ApplyStyleCommand to EditingStyle.
The font size delta is now stored as a member variable of EditingStyle as supposed to a property
in CSSMutableStyleDeclration as soon as EditingStyle is instantiated.
No new tests are added since this is a refactoring.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::doApply): Calls applyRelativeFontStyleChange.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Takes EditingStyle.
* editing/ApplyStyleCommand.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::EditingStyle): Initializes m_fontSizeDelta.
(WebCore::EditingStyle::init): Ditto.
(WebCore::EditingStyle::extractFontSizeDelta): Extracted from applyRelativeFontStyleChange.
(WebCore::EditingStyle::isEmpty): Takes care of m_fontSizeDelta.
(WebCore::EditingStyle::setStyle): Calls extractFontSizeDelta.
(WebCore::EditingStyle::overrideWithStyle): Ditto.
(WebCore::EditingStyle::clear): Initializes m_fontSizeDelta.
(WebCore::EditingStyle::copy): Calls extractFontSizeDelta.
* editing/EditingStyle.h:
(WebCore::EditingStyle::fontSizeDelta): Added.
(WebCore::EditingStyle::hasFontSizeDelta): Added.
* editing/Editor.h:
2011-01-05 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus if the primary font lacks a hyphen glyph
https://bugs.webkit.org/show_bug.cgi?id=51915
This changes the results of existing tests in fast/text.
* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added.
* rendering/style/RenderStyle.cpp:
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added a stub.
(WebCore::RenderStyle::hyphenString): For hyphenate-character: auto, return a
hyphen only if the primary font has a hyphen glyph, and otherwise return a
hyphen-minus.
2011-01-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] [Symbian] Make CONFIG-=def_files the default configuration for trunk builds
https://bugs.webkit.org/show_bug.cgi?id=51888
Overrule Qt's default from qconfig.pri for non-production builds so
that CONFIG(def_files) evaluates to false and QtWebKit trunk builds succeed.
No new tests as there is no new functionality.
* WebCore.pro:
2011-01-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74778.
http://trac.webkit.org/changeset/74778
https://bugs.webkit.org/show_bug.cgi?id=51930
Android and QtWebKit-V8 uses V8DOMWindowShell::setContext.
(Requested by bbandix on #webkit).
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setContext):
* bindings/v8/V8DOMWindowShell.h:
2011-01-05 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Animated GIF images does not animate 10x as expected by default.
https://bugs.webkit.org/show_bug.cgi?id=36818
Add a test animated GIF which should be displayed 2 times and stop.
* manual-tests/animated-gif-looping.html:
* manual-tests/resources/animated-2x.gif: Added.
2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fork code of ScrollbarThemeGtk that will differ for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=51923
Split out pieces of ScrollbarThemeGtk into ScrollbarThemeGtk2 and
ScrollbarThemeGtk3 that will differ between GTK+ 2 and GTK+ 3.
No new tests. This should not change functionality.
* GNUmakefile.am: Add ScrollbarThemeGtk2.cpp and ScrollbarThemeGtk3.cpp
* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
* platform/gtk/ScrollbarThemeGtk.h:
* platform/gtk/ScrollbarThemeGtk2.cpp: Added.
(WebCore::ScrollbarThemeGtk::updateThemeProperties):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
* platform/gtk/ScrollbarThemeGtk3.cpp: Added.
(WebCore::ScrollbarThemeGtk::updateThemeProperties):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
2011-01-05 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Fix the usage of SOURCE_GROUP
https://bugs.webkit.org/show_bug.cgi?id=51739
* CMakeLists.txt:
2011-01-05 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][V8] Fix the build after recent changes.
No new tests needed.
* WebCore.pro: Add missing files, and remove obsolete ones.
2011-01-05 Yong Li <yoli@rim.com>
Reviewed by Adam Barth.
Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.
https://bugs.webkit.org/show_bug.cgi?id=48077
Test case: WebCore/manual-tests/bugzilla-48077.html.
* dom/DocumentParser.cpp:
(WebCore::DocumentParser::suspendScheduledTasks):
(WebCore::DocumentParser::resumeScheduledTasks):
* dom/DocumentParser.h:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::suspendScheduledTasks):
(WebCore::HTMLDocumentParser::resumeScheduledTasks):
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::suspend):
(WebCore::HTMLParserScheduler::resume):
* html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::isScheduledForResume):
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2011-01-05 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen, Gustavo Noronha Silva
[GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
https://bugs.webkit.org/show_bug.cgi?id=51926
Work around potential upstream bug: Querying a GstBin for the duration,
will forward the query to all sink children. Our WebKitWebSrc however
is a bin with only source children, therefore the query fails. Until
this is changed upstream, this patch works around it as follows,
based on suggestion by Philippe Normand and Sebastian Dröge:
When the initial query fails, attempt the same query on all source
pads and take the maximum length reported.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
2011-01-05 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Eric Seidel.
[GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=51810
Based on a patch by Mart Raudsepp.
No new tests, build fix only.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
introduced in same version as the xoverlay API change.
2011-01-05 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610
We should check recursive <use> at the begining of
WebCore::SVGUseElement::buildInstanceTree instead
of at the end of it because the target element's
children may cause infinite recursive <use>.
Test: svg/custom/recursive-use.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
* svg/SVGUseElement.h:
2011-01-04 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=51907
Style selector should only be recalculated when the pending sheet count goes to zero
Shark says this is a significant performance improvement on some sites with lots of stylesheets.
* dom/Document.cpp:
(WebCore::Document::removePendingSheet):
2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use GtkStyleContext to get platform colors
https://bugs.webkit.org/show_bug.cgi?id=51830
Use GtkStyleContext API to get platform colors when building with
GTK+ 3.x.
No new tests. This should not change functionality.
* platform/graphics/Color.h: Add specialized constructor for GdkRGBA.
* platform/graphics/gtk/ColorGtk.cpp:
(WebCore::Color::Color):
(WebCore::Color::operator GdkRGBA):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::systemColor):
2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Build fix for GTK when using gtk+-3 after r75009.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::getStockIcon): Use adoptGRef instead of
adoptGRefPtr which doesn't exist.
2011-01-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=51903
Tell UI process which subframe is largest
* WebCore.exp.in: Exported FrameView::contentsSize().
2011-01-04 Chris Fleizach <cfleizach@apple.com>
Unreviewed. GTK build fix.
WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859
* page/FrameView.cpp:
(WebCore::FrameView::axObjectCache):
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74992.
http://trac.webkit.org/changeset/74992
https://bugs.webkit.org/show_bug.cgi?id=51917
Crash in HTMLDocumentParser::suspendScheduledTasks()
(Requested by tkent on #webkit).
* dom/DocumentParser.cpp:
* dom/DocumentParser.h:
* html/parser/HTMLDocumentParser.cpp:
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::HTMLParserScheduler):
* html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::isScheduledForResume):
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] Add support for non-trivial context menu action
https://bugs.webkit.org/show_bug.cgi?id=51902
Fix the preprocessor guard for ContextMenuItemTagSelectAll in
the implementation of ContextMenuController::contextMenuItemSelected(). The guard was
inconsistent with what is defined in ContextMenuItem.h.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
2011-01-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Ryosuke Niwa.
Avoid manual ref/deref in AsyncScriptRunner by using PendingScript
https://bugs.webkit.org/show_bug.cgi?id=51723
ScriptElement should also be able to keep its Element+CachedScript in
a PendingScript, and then executeScriptSoon can accept a PendingScript.
Once HTMLScriptRunner, ScriptElement, and AsyncScriptRunner all use
PendingScripts, then generic request and execute which operate on
PendingScripts can be factored out to avoid code duplicate that we have.
No new tests because no new functionality.
* dom/AsyncScriptRunner.cpp:
(WebCore::AsyncScriptRunner::~AsyncScriptRunner):
(WebCore::AsyncScriptRunner::executeScriptSoon):
(WebCore::AsyncScriptRunner::timerFired):
* dom/AsyncScriptRunner.h:
* dom/PendingScript.h: Add ctor which sets element and cachedScript. Rename adoptElement->setElement.
* dom/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::requestPendingScript):
2011-01-04 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Member variable and method naming cleanup to be consistent with WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=51228
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::eventActivatedView):
Rename activatedWebView() to didActivateWebView().
* platform/PlatformMouseEvent.h:
Rename m_activatedWebView to m_didActivateWebView.
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
Initialize platform-specific member variables in PlatformMouseEvent constructors.
(WebCore::PlatformMouseEvent::didActivateWebView):
Rename activatedWebView() to didActivateWebView().
* platform/win/PlatformMouseEventWin.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
Rename m_activatedWebView to m_didActivateWebView.
2011-01-04 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
CSS3 :nth-child selector and valid whitespace test fails
https://bugs.webkit.org/show_bug.cgi?id=36279
Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs.
Test: fast/css/css3-nth-space.html
* css/tokenizer.flex:
2011-01-04 Chris Fleizach <cfleizach@apple.com>
Unreviewed. Build fix.
WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(fallbackObject):
2011-01-04 Cosmin Truta <ctruta@chromium.org>
Reviewed by Eric Seidel.
[chromium] PNG compression settings optimized for speed
https://bugs.webkit.org/show_bug.cgi?id=51719
Although Z_HUFFMAN_ONLY is the fastest on hard-to-compress images,
it is also the slowest, by a wide margin, on easy-to-compress images.
Use a more balanced configuration, based on the libpng compression defaults,
but with a faster compression level (3 instead of 6), and a faster filter
("sub" instead of "all").
No change in behaviour, so no new tests.
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::PNGImageEncoder::encode):
2011-01-04 Chris Fleizach <cfleizach@apple.com>
Reviewed by Sam Weinig.
WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859
WK2 doesn't use platform scroll views anymore. Accessibility code
needs to have its own scroll views.
Test: platform/mac/accessibility/webkit-scrollarea.html
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleScrollbarUpdate):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::handleScrollbarUpdate):
* accessibility/AccessibilityARIAGrid.h:
* accessibility/AccessibilityAllInOne.cpp:
* accessibility/AccessibilityImageMapLink.cpp:
* accessibility/AccessibilityImageMapLink.h:
* accessibility/AccessibilityListBoxOption.cpp:
* accessibility/AccessibilityListBoxOption.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateChildrenIfNecessary):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::focusedUIElement):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilityScrollView):
(WebCore::AccessibilityObject::isScrollView):
(WebCore::AccessibilityObject::canSetNumericValue):
(WebCore::AccessibilityObject::scrollBar):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::setValue):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp: Added.
(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::create):
(WebCore::AccessibilityScrollView::scrollBar):
(WebCore::AccessibilityScrollView::children):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::removeChildScrollbar):
(WebCore::AccessibilityScrollView::addChildScrollbar):
(WebCore::AccessibilityScrollView::addChildren):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::document):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::parentObject):
* accessibility/AccessibilityScrollView.h: Added.
(WebCore::AccessibilityScrollView::roleValue):
(WebCore::AccessibilityScrollView::scrollView):
(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::isAccessibilityScrollView):
(WebCore::toAccessibilityScrollView):
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::create):
(WebCore::AccessibilityScrollbar::elementRect):
(WebCore::AccessibilityScrollbar::document):
(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):
(WebCore::AccessibilityScrollbar::valueForRange):
(WebCore::AccessibilityScrollbar::setValue):
* accessibility/AccessibilityScrollbar.h:
(WebCore::AccessibilityScrollbar::setParent):
(WebCore::AccessibilityScrollbar::canSetValueAttribute):
(WebCore::AccessibilityScrollbar::canSetNumericValue):
(WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::parentObject):
(WebCore::AccessibilityScrollbar::roleValue):
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper scrollViewParent]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
* dom/Document.cpp:
(WebCore::Document::axObjectCache):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):
* loader/FrameLoaderClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::axObjectCache):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar):
(WebCore::Scrollbar::scroll):
(WebCore::Scrollbar::axObjectCache):
* platform/Scrollbar.h:
* platform/Widget.h:
(WebCore::Widget::axObjectCache):
2011-01-04 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add support to compositor to composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=50833
A patch to extend compositor to be able to composite into an offscreen texture instead
of just directly to the display buffer. Builds on RenderSurfaceChromium support.
Explicitly resets alpha channel before rendering to display.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::updateAndDrawRootLayer):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setCompositeOffscreen):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::isCompositingOffscreen):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
2011-01-04 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] depend on harfbuzz explicitly
https://bugs.webkit.org/show_bug.cgi?id=51895
platform/graphics/chromium uses Harfbuzz directly. Rather than
expecting Skia to adjust the include paths, be explicit about
the dependency.
* WebCore.gyp/WebCore.gyp:
2011-01-04 Darin Adler <darin@apple.com>
Reviewed by Brady Eidson.
Add back/forward encoding and decoding to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51901
* WebCore.exp.in: Export functions used in WebKit2.
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTree): Use references instead of pointers.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Ditto.
(WebCore::HistoryItem::decodeBackForwardTree): Ditto.
* history/HistoryItem.h: Ditto.
* platform/network/FormData.cpp:
(WebCore::encode): Ditto.
(WebCore::decode): Ditto.
(WebCore::FormData::encodeForBackForward): Ditto.
(WebCore::FormData::decodeForBackForward): Ditto.
* platform/network/FormData.h: Ditto.
2011-01-04 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Implement sel.modify('move', 'left'/'right', 'lineBoundary').
https://bugs.webkit.org/show_bug.cgi?id=33435
* editing/SelectionController.cpp:
(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingLeft):
* editing/visible_units.cpp:
(WebCore::logicalStartOfLine):
(WebCore::logicalEndOfLine):
(WebCore::leftBoundaryOfLine):
(WebCore::rightBoundaryOfLine):
* editing/visible_units.h:
2011-01-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use the default CSS text input control border width of relying on the GTK+ theme
https://bugs.webkit.org/show_bug.cgi?id=51887
Do not rely on the GTK+ theme to determine text control borders. This simplifies
the RenderTheme code, prevents metrics differences between GTK+ 2.x and 3.x and
doesn't break the rendering of any theme that I've encountered.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustSearchFieldStyle): No longer call setTextInputBorders, but
still disable any border radius.
* platform/gtk/RenderThemeGtk.h: Remove setTextInputBorders and no longer override the
default style of text areas and text input controls.
* platform/gtk/RenderThemeGtk2.cpp: Ditto.
* platform/gtk/RenderThemeGtk3.cpp: Ditto.
2011-01-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Darin Adler.
Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=51846
No new tests. This should not introduce any functional changes.
Changed all references to PlatformRefPtr in GTK+ code to GRefPtr. Changed
all references to PlatformRefPtr in Brew code to RefPtr.
2011-01-04 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/51890> Move ResourceLoadPriority.h into WebCore/platform/network
Reviewed by Antti Koivisto.
This is needed to prevent a WebCore/platform policy violation in
my next patch.
* WebCore.gypi: Updated for moved header.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/network/ResourceLoadPriority.h: Renamed from WebCore/loader/ResourceLoadPriority.h.
2011-01-04 Brady Eidson <beidson@apple.com>
Reviewed by a spell checker.
* storage/StorageMap.h: mesured? Really?
2011-01-04 Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Port stock icon painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51764
Port stock icon painting for media and search input elements to
GtkStyleContext. Also create the initial machinery for accessing
style contexts for all GTK+ 3.x based widgets.
No new tests. This should not change functionality.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintGdkPixbuf):
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::paintMediaButton):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::getStockIcon):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::gtkStyleChangedCallback):
(WebCore::styleContextMap):
(WebCore::getStyleContext):
(WebCore::RenderThemeGtk::paintMenuList):
2010-12-31 Antti Koivisto <antti@apple.com>
Reviewed by Dave Hyatt.
Scripts should not be executed before preceding stylesheets are loaded
https://bugs.webkit.org/show_bug.cgi?id=8852
Block inline script execution on pending stylesheet loads. This matches
other browsers and HTML5.
Tests: fast/tokenizer/inline-script-stylesheet-write.html
fast/tokenizer/inline-script-stylesheet.html
* dom/PendingScript.cpp:
(WebCore::PendingScript::releaseElementAndClear):
* dom/PendingScript.h:
(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::operator=):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
This fixes an unrelated bug with beforeload events that was exposed by the other
changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::sourceFromPendingScript):
(WebCore::HTMLScriptRunner::runScript):
2011-01-04 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by Darin Adler.
Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
on ARM.
https://bugs.webkit.org/show_bug.cgi?id=51861
By the way, changed other getIntXX() and setIntXX() methods to use
more precise integer types.
* bindings/js/JSDataViewCustom.cpp:
(WebCore::setDataViewMember):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::setInt8Callback):
* html/canvas/DataView.cpp:
(WebCore::DataView::getInt8):
(WebCore::DataView::setInt8):
* html/canvas/DataView.h:
* html/canvas/DataView.idl:
2011-01-04 Yong Li <yoli@rim.com>
Reviewed by Adam Barth.
Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.
https://bugs.webkit.org/show_bug.cgi?id=48077
Test case: WebCore/manual-tests/bugzilla-48077.html.
* dom/DocumentParser.cpp:
(WebCore::DocumentParser::suspendScheduledTasks):
(WebCore::DocumentParser::resumeScheduledTasks):
* dom/DocumentParser.h:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::suspendScheduledTasks):
(WebCore::HTMLDocumentParser::resumeScheduledTasks):
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::suspend):
(WebCore::HTMLParserScheduler::resume):
* html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::isScheduledForResume):
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2011-01-04 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Include glib-object.h for GObject
https://bugs.webkit.org/show_bug.cgi?id=51876
* bindings/gobject/DOMObjectCache.cpp:
2011-01-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
https://bugs.webkit.org/show_bug.cgi?id=50992
Fixed the bug by interchanging the offset when the direction of inline text box and the containing block
does not match. Reused the code added by http://trac.webkit.org/changeset/73553.
Test: editing/selection/caret-bidi-first-and-last-letters.html
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::offsetForPosition):
2010-12-29 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Adler.
Remove 2 unnecessary includes from Document.h
https://bugs.webkit.org/show_bug.cgi?id=51727
No new tests because no changed functionality.
* dom/Document.cpp:
* dom/Document.h:
* editing/Editor.cpp:
* editing/SpellChecker.h:
* editing/SplitTextNodeCommand.cpp:
* editing/TextCheckingHelper.cpp:
* page/FrameView.cpp:
* page/Page.cpp:
* rendering/HitTestResult.cpp:
* rendering/InlineTextBox.cpp:
* rendering/InlineTextBox.h:
* rendering/svg/SVGInlineFlowBox.cpp:
2011-01-04 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix.
* CMakeListsWinCE.txt: Added missing include directories, files and libraries.
2011-01-04 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
Provide an interface to require using fullscreen mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=51133
Only video should be displayed in fullscreen when
requiresFullscreenForVideoPlayback is specified.
No new tests because no client implements requiresFullscreenForVideoPlayback yet.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState):
2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=51825
Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the
platform independent menu informations.
* platform/qt/ContextMenuQt.cpp:
(WebCore::contextMenuItemVector):
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74960.
http://trac.webkit.org/changeset/74960
https://bugs.webkit.org/show_bug.cgi?id=51868
Rollout since we hit an assert after this patch. (Requested by
krit on #webkit).
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildInstanceTree):
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74961.
http://trac.webkit.org/changeset/74961
https://bugs.webkit.org/show_bug.cgi?id=51867
breaks 32/64-bits debug bots build (Requested by philn-tp on
#webkit).
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::setWindowOverlay):
2011-01-03 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Eric Seidel.
[GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=51810
Based on a patch by Mart Raudsepp.
No new tests, build fix only.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
introduced in same version as the xoverlay API change.
2011-01-04 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610
We should check recursive <use> at the begining of
WebCore::SVGUseElement::buildInstanceTree instead
of at the end of it because the target element's
children may cause infinite recursive <use>.
Test: svg/custom/recursive-use.svg
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildInstanceTree):
2011-01-04 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
Try to fix Clang build.
* css/CSSParser.cpp:
(WebCore::valueFromSideKeyword):
(WebCore::CSSParser::parseLinearGradient):
2011-01-03 Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com>
Reviewed by Darin Adler.
HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596
border attribute was not parsed in HTMLObjectElement.
I added code for it as HTMLImageElement handled.
new test:fast/html/object-border.html
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
2011-01-03 Darin Adler <darin@apple.com>
Try to fix Chromium build.
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
Not sure this ever will be used with V8.
(WebCore::HistoryItem::decodeBackForwardTree): Ditto.
2011-01-03 Darin Adler <darin@apple.com>
Try to fix Leopard build.
* history/HistoryItem.cpp: Use a consistent type, uint64_t, for the
size variable.
2011-01-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Fixes before child calculation when adding anonymous childs to table parts.
https://bugs.webkit.org/show_bug.cgi?id=50932
Fix in r74364 was incomplete. When before child is equal to the table part(to
which the new child is getting added), it confuses the table part to add it
incorrectly as an after child. The patch fixes by passing the before child as
the table part's first child.
Tests: fast/css-generated-content/table-before-after-child-add.html
fast/css-generated-content/table-cell-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
2011-01-03 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
Shrink HTMLTableCellElement
https://bugs.webkit.org/show_bug.cgi?id=51858
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
m_col.
* html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
2011-01-03 Darin Adler <darin@apple.com>
Fix build.
* platform/network/FormData.cpp:
(WebCore::FormData::create): Roll back uint8_t change.
(WebCore::FormData::flatten): Ditto.
(WebCore::FormData::flattenToString): Ditto.
(WebCore::encode): Ditto.
(WebCore::decode): Ditto.
(WebCore::FormData::encodeForBackForward):
* platform/network/FormData.h: Ditto.
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Ditto.
2011-01-03 Darin Adler <darin@apple.com>
Reviewed by Brady Eidson.
Add code to encode/decode the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=51853
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTree): Added.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Added.
(WebCore::HistoryItem::decodeBackForwardTree): Added.
* history/HistoryItem.h: Added functions above.
* platform/network/FormData.cpp:
(WebCore::FormData::create): Changed type to Vector<uint8_t> instead of
Vector<char>. This type is used in our newer code for vectors of bytes.
(WebCore::FormData::flatten): Ditto.
(WebCore::FormData::flattenToString): Ditto. Had to add a cast here.
(WebCore::FormData::encodeForBackForward): Added.
(WebCore::FormData::decodeForBackForward): Added.
* platform/network/FormData.h: Changed type to Vector<uint8_t> instead of
Vector<char>. Also made some single-argument constructors explicit.
Also added the new functions.
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
2011-01-03 Simon Fraser <simon.fraser@apple.com>
Attempt to fix GTK build.
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::drawGlyphsShadow):
2011-01-03 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
ContextShadow can avoid code duplication for getting the CTM
https://bugs.webkit.org/show_bug.cgi?id=51799
ContextShadow defines its own getTransformationMatrixFromContext()
which does exactly the same as GraphicsContext::getCTM().
Existing tests: fast/canvas/canvas*shadow*html
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::mustUseContextShadow):
(WebCore::ContextShadow::adjustBlurDistance):
(WebCore::ContextShadow::calculateLayerBoundingRect):
* platform/graphics/ContextShadow.h:
* platform/graphics/cairo/ContextShadowCairo.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
(WebCore::ContextShadow::drawRectShadowWithoutTiling):
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::drawGlyphsShadow):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::drawGlyphsShadow):
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::draw):
2011-01-03 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
InsertTextCommand::m_charactersAdded is unused
https://bugs.webkit.org/show_bug.cgi?id=51849
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded.
(WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
* editing/InsertTextCommand.h: Removed charactersAdded function and
m_charactersAdded data member.
2011-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=51832
Method paintMenuListButton() contains code common to both gtk 2
and 3, so it can be moved to RenderThemeGtk.cpp instead of
duplicating it.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMenuListButton):
* platform/gtk/RenderThemeGtk2.cpp:
* platform/gtk/RenderThemeGtk3.cpp:
2011-01-03 Pratik Solanki <psolanki@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=51850
Put CFNetwork loader code inside USE(CFNETWORK)
Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
files to the WebCore Xcode project.
* WebCore.xcodeproj/project.pbxproj:
* loader/cf/ResourceLoaderCFNet.cpp:
* loader/mac/ResourceLoaderMac.mm:
* platform/network/cf/AuthenticationCF.cpp:
* platform/network/cf/AuthenticationCF.h:
* platform/network/cf/CookieJarCFNet.cpp:
* platform/network/cf/CookieStorageCFNet.cpp:
* platform/network/cf/CookieStorageCFNet.h:
* platform/network/cf/CredentialStorageCFNet.cpp:
* platform/network/cf/FormDataStreamCFNet.cpp:
* platform/network/cf/FormDataStreamCFNet.h:
* platform/network/cf/LoaderRunLoopCF.cpp:
* platform/network/cf/LoaderRunLoopCF.h:
* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceRequestCFNet.cpp:
* platform/network/cf/ResourceRequestCFNet.h:
* platform/network/cf/ResourceResponse.h:
* platform/network/cf/ResourceResponseCFNet.cpp:
* platform/network/mac/AuthenticationMac.h:
* platform/network/mac/AuthenticationMac.mm:
* platform/network/mac/FormDataStreamMac.h:
* platform/network/mac/FormDataStreamMac.mm:
* platform/network/mac/ResourceError.h:
* platform/network/mac/ResourceHandleMac.mm:
* platform/network/mac/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
* platform/network/mac/ResourceResponse.h:
* platform/network/mac/ResourceResponseMac.mm:
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Enable SelectAll for the Qt context menu.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
* platform/ContextMenuItem.h:
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagSelectAll):
* platform/LocalizedStrings.h:
2011-01-03 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Shrink RootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=51847
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
accessor.
* rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to
unsigned because otherwise MSVC treats it as signed.
(WebCore::RootInlineBox::baselineType): Added a cast.
2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698
Fix DOM bindings generation to no longer include the now-gone
webkitprivate.h header, including the appropriate replacements
instead.
* bindings/scripts/CodeGeneratorGObject.pm:
2011-01-03 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.
* ForwardingHeaders/wtf/Decoder.h: Added.
* ForwardingHeaders/wtf/Encoder.h: Added.
2011-01-03 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
https://bugs.webkit.org/show_bug.cgi?id=51833
Make sure the web area returns the contentsSize, not the same size as what is displayed.
Test: platform/mac/accessibility/webarea-size-equals-content-size.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):
2011-01-03 Simon Fraser <simon.fraser@apple.com>
Fix warning in 32-bit builds.
* css/CSSGradientValue.cpp:
(WebCore::CSSLinearGradientValue::createGradient):
2011-01-03 Benjamin C Meyer <bmeyer@rim.com>
Reviewed by Daniel Bates.
In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
https://bugs.webkit.org/show_bug.cgi?id=51827
* CMakeLists.txt:
2011-01-03 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
Remove the unused RenderTableCell::m_percentageHeight
https://bugs.webkit.org/show_bug.cgi?id=51837
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
* rendering/RenderTableCell.h: Removed m_percentageHeight.
2011-01-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by David Hyatt.
Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152
Add support for -webkit-radial-gradients.
Tests: fast/gradients/css3-radial-gradients.html
fast/gradients/css3-radial-gradients2.html
* css/CSSGradientValue.cpp:
(WebCore::blend): Used to blend colors, which is necessary when truncating
the start of radial gradients.
(WebCore::GradientStop): Small struct to aid gradient stop processing.
(WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store
the color so that we can blend it when truncating radial gradients. Changed
to handle both linear and radial gradients.
(WebCore::CSSRadialGradientValue::cssText): Update to follow the spec.
(WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change.
(WebCore::distanceToClosestCorner): New utility method.
(WebCore::distanceToFarthestCorner): Ditto.
(WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and
fill rules.
* css/CSSGradientValue.h:
(WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what
kind of gradient it's dealing with, so add new isFooGradient methods.
(WebCore::CSSGradientValue::isRadialGradient): Ditto.
(WebCore::CSSLinearGradientValue::isLinearGradient):
(WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc.
(WebCore::CSSRadialGradientValue::setSizingBehavior):
(WebCore::CSSRadialGradientValue::setEndHorizontalSize):
(WebCore::CSSRadialGradientValue::setEndVerticalSize):
(WebCore::CSSRadialGradientValue::isRadialGradient):
* css/CSSParser.h:
* css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition()
so we can use parseFillPosition() when parsing a gradient function.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList*
(WebCore::CSSParser::parseFillPosition): Ditto
(WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition.
(WebCore::CSSParser::parseTransformOriginShorthand): Ditto
(WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing.
(WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition.
(WebCore::CSSParser::parsePerspectiveOrigin): Ditto
* css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.
* platform/graphics/Gradient.cpp:
(WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
* platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients.
(WebCore::Gradient::create):
(WebCore::Gradient::startRadius): Expose radii.
(WebCore::Gradient::endRadius):
(WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops.
(WebCore::Gradient::setEndRadius):
(WebCore::Gradient::aspectRatio):
* platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().
2011-01-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by David Hyatt.
Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152
Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.
Tests: fast/gradients/css3-color-stop-units.html
fast/gradients/css3-color-stops.html
fast/gradients/css3-gradient-parsing.html
fast/gradients/css3-linear-angle-gradients.html
* css/CSSGradientValue.h:
Add subclasses of CSSGradientValue for linear and radial gradients.
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache
the gradient sometimes.
(WebCore::compareStops): positions are CSSValues now.
(WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called
for old-style gradients.
(WebCore::CSSGradientValue::addStops): New method that handles the spec rules about
missing positions, ensuring that stop position is ordered, and spacing out stops
without positions. Also normalize gradients which use stops outside the 0-1 range
so that platforms can render them correctly.
(WebCore::positionFromValue): Determin the position on the gradient line for percentage,
number and length values.
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::cssText):
(WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle
given an angle.
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::cssText):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Style fix.
(WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage()
(WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage()
(WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage()
(WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient.
(WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient,
and fixed to store CSSValues for the stop position.
(WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient,
and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate.
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword): Color parsing utility.
(WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients.
(WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients.
(WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas.
(WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients
and CSS canvas.
* css/CSSParser.h:
* platform/graphics/Gradient.h:
(WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients.
(WebCore::Gradient::setP1): Ditto.
2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464
Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom member (qtObject) to WebCore::Widget.
Added a test to tst_qwebpage to make sure plugins created
as QGraphicsWidget are accessible through JavaScript.
* bindings/js/ScriptControllerQt.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
* platform/Widget.h:
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::setBindingObject):
(WebCore::Widget::bindingObject):
2011-01-03 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=51328
Printing on a page with body { height: 100% } clips out the overflow contents. This happened
because the computePageRects function was never correct. It was using the layer's width and height
for the document's width and height, and the layer no longer includes overflow in its width and
height. It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
assumption in RTL or vertical text environments.
Added printing/page-count-percentage-height.html
* page/PrintContext.cpp:
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
2011-01-03 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed buildfix for --minimal build after r74895.
* html/InputType.cpp: Missing include added.
* html/NumberInputType.cpp: Missing include added.
2011-01-02 Darin Adler <darin@apple.com>
Reviewed by Kent Tamura.
Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791
* dom/InputElement.h: Make sanitizeValueForTextField public so it can
be called by InputType.
* html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::accessKeyAction): Added.
(WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
* html/BaseButtonInputType.h: Ditto.
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::canSetStringValue): Added.
(WebCore::BaseCheckableInputType::accessKeyAction): Added.
(WebCore::BaseCheckableInputType::fallbackValue): Added.
(WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added.
(WebCore::BaseCheckableInputType::isCheckable): Added.
* html/BaseCheckableInputType.h: Ditto.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
* html/BaseDateAndTimeInputType.h: Ditto.
* html/BaseTextInputType.h: Made more functions private.
* html/ButtonInputType.cpp:
(WebCore::ButtonInputType::isTextButton): Added.
* html/ButtonInputType.h: Ditto.
* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::willDispatchClick): Added.
(WebCore::CheckboxInputType::didDispatchClick): Added.
(WebCore::CheckboxInputType::isCheckbox): Added.
* html/CheckboxInputType.h: Ditto.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed
typo in name of this function.
* html/DateTimeInputType.h: Ditto.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
* html/DateTimeLocalInputType.h: Ditto.
* html/EmailInputType.cpp:
(WebCore::EmailInputType::isEmailField): Added.
* html/EmailInputType.h: Ditto.
* html/FileInputType.cpp:
(WebCore::FileInputType::FileInputType): Added.
(WebCore::FileInputType::canSetStringValue): Added.
(WebCore::FileInputType::canChangeFromAnotherType): Added.
(WebCore::FileInputType::files): Added.
(WebCore::FileInputType::canSetValue): Added.
(WebCore::FileInputType::getTypeSpecificValue): Added.
(WebCore::FileInputType::storesValueSeparateFromAttribute): Added.
(WebCore::FileInputType::setFileList): Added.
(WebCore::FileInputType::isFileUpload): Added.
* html/FileInputType.h: Ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement): Updated for data member
renaming and removal.
(WebCore::HTMLInputElement::isValidValue): Call canSetStringValue
instead of checking specific type numbers.
(WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
Use fastGetAttribute and fixed typo in the name of the
scaledStepValueShouldBeInteger function.
(WebCore::HTMLInputElement::isKeyboardFocusable): Call
InputType::isKeyboardFocusable; moved most of the type-specific
logic there.
(WebCore::HTMLInputElement::shouldUseInputMethod): Call
InputType::shouldUseInputMethod; moved the type-specific logic there.
(WebCore::HTMLInputElement::handleBlurEvent): Call
InputType::handleBlurEvent; moved the type-specific logic there.
(WebCore::HTMLInputElement::setType): Tweak the names and types
in this function.
(WebCore::HTMLInputElement::updateType): Removed the code that
set m_deprecatedTypeNumber. Compare types by comparing the value
from formControlType. Removed file-specific logic and instead call
InputType::canChangeFromAnotherType. Streamlined the logic for
activation callbacks.
(WebCore::HTMLInputElement::accessKeyAction): Call
InputType::accessKeyAction; moved the type-specific logic there.
(WebCore::HTMLInputElement::mapToEntry): Call
InputType::shouldRespectHeightAndWidthAttributes and
InputType::shouldRespectAlignAttribute.
(WebCore::HTMLInputElement::parseMappedAttribute): Updated
for name changes and the removal of m_defaultChecked. Changed the
alt attribute logic to be based on the class of the renderer.
Call InputType::srcAttributeChanged and moved the type-specific
logic there. Call shouldRespectAlignAttribute and
shouldRespectHeightAndWidthAttributes rather than having
type-specific logic here. Call minOrMaxAttributeChanged.
(WebCore::HTMLInputElement::rendererIsNeeded): Call
InputType::rendererIsNeeded; moved the type-specific logic there.
(WebCore::HTMLInputElement::attach): Removed the unneeded m_inited
flag, which was redundant with the m_haveType flag. Call
InputType::attach; moved the type-specific logic there.
(WebCore::HTMLInputElement::altText): Use fastGetAttribute.
(WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call
InputType::canBeSuccessfulSubmitButton; moved the type-specific
logic there.
(WebCore::HTMLInputElement::isActivatedSubmit): Updated for
name changes.
(WebCore::HTMLInputElement::setActivatedSubmit): Ditto.
(WebCore::HTMLInputElement::reset): Updated to use
InputType::storesValueSeparateFromAttribute. Also use
hasAttribute(checkedAttr) rather than m_defaultChecked,
since both are the same. Also updated for name change.
(WebCore::HTMLInputElement::setChecked): Updated for name
changes. Also added call to
InputType::shouldSendChangeEventAfterCheckedChanged and
moved the type-specific logic there.
(WebCore::HTMLInputElement::setIndeterminate): Call
isCheckable to see if indeterminate is allowed.
Also updated for name changes.
(WebCore::HTMLInputElement::copyNonAttributeProperties):
Updated for name changes and removed data members.
(WebCore::HTMLInputElement::value): Call
InputType::getTypeSpecificValue and InputType::fallbackValue.
Moved the type-specific logic there.
(WebCore::HTMLInputElement::valueWithDefault): Call
InputType::defaultValue. Moved the type-specific logic there.
(WebCore::HTMLInputElement::setSuggestedValue): Call
InputType::canSetSuggestedValue. Moved the type-specific logic
there.
(WebCore::HTMLInputElement::setValue): Call
InputType::canSetValue. Moved the type-specific logic there.
Clear the file list if it exists rather than checking the
type explicitly. We could probably do that a more elegant way.
(WebCore::HTMLInputElement::placeholder): Use fastGetAttribute.
(WebCore::HTMLInputElement::setValueFromRenderer): Use the
isFileUpload function in the assertion.
(WebCore::HTMLInputElement::setFileListFromRenderer): Put most
of the code from this function into FileInputType::setFileList.
(WebCore::HTMLInputElement::preDispatchEventHandler): Changed
to call InputType::willDispatchClick, which does the type-specific
work. Still need to use a single struct for all types, because
the type of the element could change during the event handling.
(WebCore::HTMLInputElement::postDispatchEventHandler): Changed
to call InputType::didDispatchClick.
(WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute.
(WebCore::HTMLInputElement::accept): Use fastGetAttribute.
(WebCore::HTMLInputElement::alt): Use fastGetAttribute.
(WebCore::HTMLInputElement::src): Use fastGetAttribute.
(WebCore::HTMLInputElement::setAutofilled): Updated for name
changes.
(WebCore::HTMLInputElement::files): Use InputType::files.
(WebCore::HTMLInputElement::isAcceptableValue): Use
InputType::isAcceptableValue.
(WebCore::HTMLInputElement::sanitizeValue): Use
InputType::sanitizeValue.
(WebCore::HTMLInputElement::hasUnacceptableValue): Use
InputType::hasUnacceptableValue.
(WebCore::HTMLInputElement::needsActivationCallback): Use
InputType::shouldResetOnDocumentActivation.
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use
InputType::willMoveToNewOwnerDocument.
(WebCore::HTMLInputElement::dataList): Use
InputType::shouldRespectListAttribute.
(WebCore::HTMLInputElement::selectedOption): Tweaked logic
and naming a bit.
(WebCore::HTMLInputElement::stepUpFromRenderer): Use
fastGetAttribute.
(WebCore::HTMLInputElement::isSpeechEnabled): Use
InputType::shouldRespectSpeechAttribute.
(WebCore::HTMLInputElement::isTextButton): No longer inline.
Calls through to InputType.
(WebCore::HTMLInputElement::isRadioButton): Ditto.
(WebCore::HTMLInputElement::isSearchField): Ditto.
(WebCore::HTMLInputElement::isInputTypeHidden): Ditto.
(WebCore::HTMLInputElement::isPasswordField): Ditto.
(WebCore::HTMLInputElement::isCheckbox): Ditto.
(WebCore::HTMLInputElement::isText): Ditto.
(WebCore::HTMLInputElement::isEmailField): Ditto.
(WebCore::HTMLInputElement::isFileUpload): Ditto.
(WebCore::HTMLInputElement::isImageButton): Ditto.
(WebCore::HTMLInputElement::isNumberField): Ditto.
(WebCore::HTMLInputElement::isSubmitButton): Ditto.
(WebCore::HTMLInputElement::isTelephoneField): Ditto.
(WebCore::HTMLInputElement::isURLField): Ditto.
(WebCore::HTMLInputElement::isEnumeratable): Ditto.
(WebCore::HTMLInputElement::isChecked): No longer inline.
Calls InputType::isCheckable.
(WebCore::HTMLInputElement::hasSpinButton): No longer inline.
Calls through to InputType.
(WebCore::HTMLInputElement::supportsPlaceholder): No longer
inline. Calls isTextType as before, but with no special case
for ISINDEX. That special case was unneeded since it returns
true from isTextType.
(WebCore::HTMLInputElement::checkedRadioButtons): No longer
inline.
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
No longer inline.
* html/HTMLInputElement.h: Removed multiple unneeded includes.
The big one is probably InputType.h, but also HTMLFormElement.h.
Removed unneeded forward declarations. Made many functions
no longer inline since they now need to make virtual function
dispatches. Removed the unneeded defaultChecked and
webkitdirectory functions. Both are handled by HTML attribute
reflection for DOM bindings, and the callers instead can get
at the attribute. Made updateCheckedRadioButtons public so it
can be called by an InputType class. Removed
DeprecatedInputType, InputTypeMap, createTypeMap,
deprecatedInputType, allowsIndeterminate,
respectHeightAndWidthAttrs, storesValueSeparateFromAttribute,
m_imageLoader, m_fileList, m_deprecatedTypeNumber,
m_defaultChecked, and m_inited. Renamed m_checked to
m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute,
m_indeterminate tom_isIndeterminate, m_haveType to m_hasType,
m_activeSubmit to m_isActivatedSubmit, and m_autofilled to
m_isAutofilled.
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::accessKeyAction): Added.
(WebCore::HiddenInputType::rendererIsNeeded) Added.:
(WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added.
(WebCore::HiddenInputType::isHiddenType): Added.
(WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
* html/HiddenInputType.h: Ditto.
* html/ImageInputType.cpp:
(WebCore::ImageInputType::ImageInputType): Moved out of the header file.
(WebCore::ImageInputType::srcAttributeChanged): Added.
(WebCore::ImageInputType::attach): Added.
(WebCore::ImageInputType::willMoveToNewOwnerDocument): Added.
(WebCore::ImageInputType::shouldRespectAlignAttribute): Added.
(WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added.
(WebCore::ImageInputType::isImageButton): Added.
(WebCore::ImageInputType::isEnumeratable): Added.
(WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
* html/ImageInputType.h: Ditto.
* html/InputType.cpp:
(WebCore::InputType::create): Changed argument type to String. There
is no value in taking an AtomicString here.
(WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in
this function name.
(WebCore::InputType::canSetStringValue): Added.
(WebCore::InputType::isKeyboardFocusable): Added.
(WebCore::InputType::shouldUseInputMethod): Added.
(WebCore::InputType::handleBlurEvent): Added.
(WebCore::InputType::accessKeyAction): Added.
(WebCore::InputType::attach): Added.
(WebCore::InputType::srcAttributeChanged): Added.
(WebCore::InputType::willMoveToNewOwnerDocument): Added.
(WebCore::InputType::shouldRespectAlignAttribute): Added.
(WebCore::InputType::canChangeFromAnotherType): Added.
(WebCore::InputType::minOrMaxAttributeChanged): Added.
(WebCore::InputType::canBeSuccessfulSubmitButton): Added.
(WebCore::InputType::rendererIsNeeded): Added.
(WebCore::InputType::files): Added.
(WebCore::InputType::getTypeSpecificValue): Added.
(WebCore::InputType::fallbackValue): Added.
(WebCore::InputType::defaultValue): Added.
(WebCore::InputType::canSetSuggestedValue): Added.
(WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added.
(WebCore::InputType::storesValueSeparateFromAttribute): Added.
(WebCore::InputType::canSetValue): Added.
(WebCore::InputType::willDispatchClick): Added.
(WebCore::InputType::didDispatchClick): Added.
(WebCore::InputType::isAcceptableValue): Added.
(WebCore::InputType::sanitizeValue): Added.
(WebCore::InputType::hasUnacceptableValue): Added.
(WebCore::InputType::setFileList): Added.
(WebCore::InputType::shouldResetOnDocumentActivation): Added.
(WebCore::InputType::shouldRespectListAttribute): Added.
(WebCore::InputType::shouldRespectSpeechAttribute): Added.
(WebCore::InputType::isTextButton): Added.
(WebCore::InputType::isRadioButton): Added.
(WebCore::InputType::isSearchField): Added.
(WebCore::InputType::isHiddenType): Added.
(WebCore::InputType::isPasswordField): Added.
(WebCore::InputType::isCheckbox): Added.
(WebCore::InputType::isEmailField): Added.
(WebCore::InputType::isFileUpload): Added.
(WebCore::InputType::isImageButton): Added.
(WebCore::InputType::isNumberField): Added.
(WebCore::InputType::isSubmitButton): Added.
(WebCore::InputType::isTelephoneField): Added.
(WebCore::InputType::isURLField): Added.
(WebCore::InputType::isEnumeratable): Added.
(WebCore::InputType::isCheckable): Added.
(WebCore::InputType::hasSpinButton): Added.
(WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
* html/InputType.h: Removed unneeded ExceptionCode.h include and
used a typedef instead as we do when we want for forward declare it.
Added includes and forward declarations needed for new functions.
Added ClickHandlingState structure. Changed the argument to create
to a String rather than AtomicString. Added many virtual functions.
* html/IsIndexInputType.cpp:
(WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
* html/IsIndexInputType.h: Ditto.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::handleBlurEvent): Added.
(WebCore::NumberInputType::isAcceptableValue): Added.
(WebCore::NumberInputType::sanitizeValue): Added.
(WebCore::NumberInputType::hasUnacceptableValue): Added.
(WebCore::NumberInputType::shouldRespectSpeechAttribute): Added.
(WebCore::NumberInputType::isNumberField): Added.
(WebCore::NumberInputType::hasSpinButton): Added.
* html/NumberInputType.h: Ditto.
* html/PasswordInputType.cpp:
(WebCore::PasswordInputType::shouldUseInputMethod): Added.
(WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added.
(WebCore::PasswordInputType::shouldRespectListAttribute): Added.
(WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added.
(WebCore::PasswordInputType::isPasswordField): Added.
* html/PasswordInputType.h: Ditto.
* html/RadioInputType.cpp:
(WebCore::RadioInputType::isKeyboardFocusable): Added.
(WebCore::RadioInputType::attach): Added.
(WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added.
(WebCore::RadioInputType::willDispatchClick): Added.
(WebCore::RadioInputType::didDispatchClick): Added.
(WebCore::RadioInputType::isRadioButton): Added.
* html/RadioInputType.h: Ditto.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::accessKeyAction): Added.
(WebCore::RangeInputType::minOrMaxAttributeChanged): Added.
(WebCore::RangeInputType::fallbackValue): Added.
(WebCore::RangeInputType::sanitizeValue): Added.
(WebCore::RangeInputType::shouldRespectListAttribute): Added.
* html/RangeInputType.h: Ditto.
* html/ResetInputType.cpp:
(WebCore::ResetInputType::defaultValue): Added.
(WebCore::ResetInputType::isTextButton): Added.
* html/ResetInputType.h: Ditto.
* html/SearchInputType.cpp:
(WebCore::SearchInputType::shouldRespectSpeechAttribute): Added.
(WebCore::SearchInputType::isSearchField): Added.
* html/SearchInputType.h: Ditto.
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added.
(WebCore::SubmitInputType::defaultValue): Added.
(WebCore::SubmitInputType::isSubmitButton): Added.
(WebCore::SubmitInputType::isTextButton): Added.
* html/SubmitInputType.h: Ditto.
* html/TelephoneInputType.cpp:
(WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added.
(WebCore::TelephoneInputType::isTelephoneField): Added.
* html/TelephoneInputType.h: Ditto.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::shouldUseInputMethod): Added.
(WebCore::TextFieldInputType::sanitizeValue): Added.
(WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
* html/TextFieldInputType.h: Ditto.
* html/TextInputType.cpp:
(WebCore::TextInputType::canSetSuggestedValue): Added.
(WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
* html/TextInputType.h: Ditto.
* html/TimeInputType.cpp:
(WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed
typo in the name of this function.
* html/TimeInputType.h: Ditto.
* html/URLInputType.cpp:
(WebCore::URLInputType::isURLField): Added.
* html/URLInputType.h: Ditto.
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed.
NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
https://bugs.webkit.org/show_bug.cgi?id=51151
Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
so that it can match Safari's (and thus use the same baselines).
No new tests, should be covered by layout tests (which will need
expectation changes)
* platform/chromium/ScrollbarThemeChromiumMac.mm:
2011-01-03 Antonio Gomes <agomes@rim.com>
Unreviewed build fix for WebKit/Gtk+.
RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
guarded by ENABLE(VIDEO), as it is in its header.
No new tests.
* platform/gtk/RenderThemeGtk2.cpp:
2011-01-02 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Simon Fraser.
<rdar://problem/8812159> Update copyright strings
* Info.plist:
2011-01-02 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
https://bugs.webkit.org/show_bug.cgi?id=51623
* editing/Editor.cpp:
(WebCore::Editor::countMatchesForText): Actually remember the original search range end
container and offset and restore them when needed, instead of using two references to the
same Range.
* manual-tests/find-count-matches-after-text-control.html: Added.
2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Csaba Osztrogonác.
WebKit 2 does not build on 64bits with a recent GCC
https://bugs.webkit.org/show_bug.cgi?id=51754
Use explicitely 64 bits types for the attributes of DatabaseDetails.
* storage/DatabaseDetails.h:
(WebCore::DatabaseDetails::expectedUsage):
(WebCore::DatabaseDetails::currentUsage):
2011-01-02 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r74868.
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::getImageData):
2011-01-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74847.
http://trac.webkit.org/changeset/74847
https://bugs.webkit.org/show_bug.cgi?id=51803
"Preprocessor guards should be in header files" (Requested by
ap on #webkit).
* bindings/js/JSDOMWindowBase.cpp:
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* html/HTMLDocument.cpp:
* loader/FrameLoader.cpp:
* loader/ResourceLoadNotifier.cpp:
* page/Chrome.cpp:
* page/Console.cpp:
* page/ContextMenuController.cpp:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchEvent):
* page/EventHandler.cpp:
* page/Page.cpp:
* storage/Database.cpp:
* workers/AbstractWorker.cpp:
* workers/DefaultSharedWorkerRepository.cpp:
* workers/SharedWorker.cpp:
* workers/Worker.cpp:
* workers/WorkerContext.cpp:
* workers/WorkerMessagingProxy.cpp:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener):
2011-01-02 Patrick Gansterer <paroga@webkit.org>
[CMake] Unreviewed build fix.
* CMakeLists.txt:
2011-01-02 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
Clarify ImageBuffer and ImageData relationship
https://bugs.webkit.org/show_bug.cgi?id=51297
Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
since this was a layering violation, and replaced it by ByteArray.
No change of functionality, so no new test added.
* html/ImageData.cpp:
(WebCore::ImageData::create):
(WebCore::ImageData::ImageData):
* html/ImageData.h: Added new constructor with ByteArray input.
(WebCore::ImageData::width):
(WebCore::ImageData::height):
(WebCore::ImageData::data):
* html/canvas/CanvasPixelArray.cpp:
(WebCore::CanvasPixelArray::create):
(WebCore::CanvasPixelArray::CanvasPixelArray):
* html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas.
(WebCore::CanvasPixelArray::data):
(WebCore::CanvasPixelArray::length):
(WebCore::CanvasPixelArray::set):
(WebCore::CanvasPixelArray::get):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
(WebCore::CanvasRenderingContext2D::putImageData):
* platform/graphics/ImageBuffer.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::apply):
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::apply):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::setDestinationPixels):
(WebCore::FEConvolveMatrix::apply):
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::apply):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::apply):
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::apply):
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::apply):
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::apply):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
(WebCore::FilterEffect::copyImageBytes):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
* platform/graphics/filters/FilterEffect.h:
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
* rendering/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
Update references to JavaScriptCore.
* Android.derived.jscbindings.mk:
* Android.v8bindings.mk:
* CMakeLists.txt:
* WebCore.gyp/WebCore.gyp:
* WebCore.pro:
- These changes are subtle and might not be 100% correct.
* move-js-headers.sh:
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340
We now pass the ScriptExecutionContext to window.close so it can find
the Frame and check whether navigation is allowed. This check will
almost always pass because you can only close top-level frames, but the
check will fail when the calling script is sandboxed.
Tests: fast/frames/sandboxed-iframe-close-top-noclose.html
fast/frames/sandboxed-iframe-close-top.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::close):
* page/DOMWindow.h:
* page/DOMWindow.idl:
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152
To enforce the sandbox restrictions on History, we need to pass the
ScriptExecutionContext to WebCore. This patch leaves the original
History methods in place because they are used directly by folks who
don't care about security checks.
Test: fast/frames/sandboxed-iframe-history-denied.html
* page/History.cpp:
(WebCore::History::back):
(WebCore::History::forward):
(WebCore::History::go):
* page/History.h:
* page/History.idl:
2011-01-01 Adam Barth <abarth@webkit.org>
Remove empty file.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/Entity.cpp: Removed.
2011-01-01 Adam Barth <abarth@webkit.org>
Remove empty file.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSPopStateEventCustom.cpp: Removed.
2011-01-01 Adam Barth <abarth@webkit.org>
Remove empty files.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/BindingFrame.h: Removed.
* bindings/generic/BindingLocation.h: Removed.
2011-01-01 Konstantin Tokarev <annulen@yandex.ru>
Reviewed by Darin Adler.
Don't include Inspector headers when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=51789
* bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when
Inspector is enabled
* dom/Document.cpp: Include Inspector headers when
Inspector is enabled
(WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie
handling
* html/HTMLDocument.cpp: Include Inspector headers when
Inspector is enabled
* loader/FrameLoader.cpp: Include Inspector headers when
Inspector is enabled
* loader/ResourceLoadNotifier.cpp: Include Inspector headers when
Inspector is enabled
* page/Chrome.cpp: Include Inspector headers when
Inspector is enabled
* page/Console.cpp: Include Inspector headers when
Inspector is enabled
* page/ContextMenuController.cpp: Include Inspector headers when
Inspector is enabled
* page/DOMWindow.cpp: Include Inspector headers when
Inspector is enabled
(WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie
handling
* page/EventHandler.cpp: Include Inspector headers when
Inspector is enabled
* page/Page.cpp: Include Inspector headers when
Inspector is enabled
* storage/Database.cpp: Include Inspector headers when
Inspector is enabled
* workers/AbstractWorker.cpp: Include Inspector headers when
Inspector is enabled
* workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when
Inspector is enabled
* workers/SharedWorker.cpp: Include Inspector headers when
Inspector is enabled
* workers/Worker.cpp: Include Inspector headers when
Inspector is enabled
* workers/WorkerContext.cpp: Include Inspector headers when
Inspector is enabled
* workers/WorkerMessagingProxy.cpp: Include Inspector headers when
Inspector is enabled
* xml/XMLHttpRequest.cpp: Include Inspector headers when
Inspector is enabled
(WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled
InspectorInstrumentationCookie handling
2010-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
fast/loader/about-blank-hash-change.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=51788
I'm unable to reproduce the failure locally, so this patch is slightly
speculative. We need to be slighly more careful how we compare the
fragment identifiers for Chromium because Chromium uses a URL parser
that is more agressive about canonicalization.
* page/Location.cpp:
(WebCore::Location::setHash):
2010-12-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use GLib/GIO API for FileSystemGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=51617
Complete implementation of FileSystem platform code for GLib. This
converts remaining API points using POSIX calls to platform-independent
GLib calls and fixes other compilation errors.
No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.
(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):
* platform/FileSystem.h: Added forward declarations for GLib types to
avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
* platform/gtk/FileSystemGtk.cpp:
(WebCore::openTemporaryFile): Reimplement using only GLib calls.
(WebCore::openFile): Ditto.
(WebCore::closeFile): Ditto.
(WebCore::seekFile): Added implementation.
(WebCore::writeToFile): Reimplement using only GLib calls.
(WebCore::readFromFile): Ditto.
2010-12-31 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Some renaming and refactoring of form element code
https://bugs.webkit.org/show_bug.cgi?id=51784
* bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::remove): Call new overload of remove
for option elements instead of putting the logic in the binding.
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes.
(WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to
"event" instead of "evt". Also updated for name changes.
(WebCore::HTMLButtonElement::isActivatedSubmit): Ditto.
(WebCore::HTMLButtonElement::setActivatedSubmit): Ditto.
(WebCore::HTMLButtonElement::appendFormData): Ditto.
* html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit
to match the getter function name. The name still doesn't seem great.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes.
(WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function
instead of m_autocomplete data member.
(WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member
instead of otherwise-unused isDemoted function.
(WebCore::HTMLFormElement::submitImplicitly): Updated for name changes.
(WebCore::HTMLFormElement::validateInteractively): Removed code to clear
m_insubmit. This is now handled by the caller, prepareForSubmission.
(WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for
name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission
here from validateInteractively. Removed unneeded check of m_doingsubmit
boolean before setting it.
(WebCore::HTMLFormElement::submit): Factored this function into two.
One for JavaScript and one for non-JavaScript. Neither function needs a frame
argument, because the question being asked, anyPageIsProcessingUserGesture,
is a question asked of an entire page group, not a specific frame or page,
so it's not important which is the active frame.
(WebCore::HTMLFormElement::submitFromJavaScript): Ditto.
(WebCore::HTMLFormElement::reset): Updated for name changes.
(WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse
acceptAttr and got rid of code to set m_autocomplete.
(WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw
pointer.
(WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer
and the vector find function. Added a FIXME about the comment.
(WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete
function instead of m_autocomplete data member.
(WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto.
(WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
(WebCore::HTMLFormElement::autoComplete): Ditto.
* html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete
function. Renamed prepareSubmit to prepareForSubmission. Got rid of the
frame argument from the submit function and added a new submitFromJavaScript
variant. Removed the unneeded isDemoted function. Changed the return type
of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed
m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to
m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed,
m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
* html/HTMLFormElement.idl: Use the function named submitFromJavaScript
instead of using CallWith=DynamicFrame because we don't need to know
what frame is calling. If we did, it's not clear that the "dynamic"
frame would be the right one anyway.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::remove): Added an overload that takes an option
element, since the JavaScript binding supports this.
* html/HTMLSelectElement.h: Ditto.
* html/ImageInputType.cpp:
(WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
* html/ImageInputType.h: Ditto.
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
2010-12-31 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Pass style for <area> instead of associated <img> when querying whether
the theme draws the focus ring for an <area>
https://bugs.webkit.org/show_bug.cgi?id=51632
Fixes an issue where the style for the associated <img> of an <area>
was passed when considering whether the theme should draw a focus ring
for the <area>. Instead, we should pass the theme the style for the <area>.
It's not possible to test this at this time since there are no themes
that override focus ring drawing for <area>s.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing()
such that it's called with respect to the focused <area>.
2010-12-31 Darin Adler <darin@apple.com>
* WebCore.xcodeproj/project.pbxproj: Added back the language.
Developers should be using Xcode 3.2.5 or newer.
2010-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move V8 to WebCore Location implementation
https://bugs.webkit.org/show_bug.cgi?id=51768
* bindings/generic/BindingFrame.h:
* bindings/generic/BindingLocation.h:
* bindings/v8/V8Binding.h:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setLocation):
* bindings/v8/V8Utilities.cpp:
* bindings/v8/V8Utilities.h:
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::hashAccessorSetter):
(WebCore::V8Location::hostAccessorSetter):
(WebCore::V8Location::hostnameAccessorSetter):
(WebCore::V8Location::hrefAccessorSetter):
(WebCore::V8Location::pathnameAccessorSetter):
(WebCore::V8Location::portAccessorSetter):
(WebCore::V8Location::protocolAccessorSetter):
(WebCore::V8Location::searchAccessorSetter):
(WebCore::V8Location::reloadCallback):
(WebCore::V8Location::replaceCallback):
(WebCore::V8Location::assignCallback):
2010-12-31 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Seidel.
Make retrieving extraMediaControlsStyleSheet be page dependent.
https://bugs.webkit.org/show_bug.cgi?id=51752
Use themeForPage to retrieve extraMediaControlsStyleSheet for media
controls.
No new tests because no platform-specific theme implementation uses
the passed page pointer yet.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.
https://bugs.webkit.org/show_bug.cgi?id=51709
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.canShowSourceLine):
2010-12-31 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix after r74800.
* bindings/js/JSDOMWindowCustom.cpp: Add missing header.
* bindings/js/JSLocationCustom.cpp: Ditto.
2010-12-31 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move HTML and XML parser benchmarks into PerformanceTests/Parser
https://bugs.webkit.org/show_bug.cgi?id=51772
Remove the benchmarks folder now that it's empty. Future benchmarks
should go in the PerformanceTests directory.
* benchmarks: Removed.
* benchmarks/parser: Removed.
* benchmarks/parser/html-parser.html: Removed.
* benchmarks/parser/resources: Removed.
* benchmarks/parser/resources/html5.html: Removed.
* benchmarks/parser/resources/runner.js: Removed.
* benchmarks/parser/xml-parser.html: Removed.
2010-12-31 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Add XML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51612
Move the JavaScript code of html parser into a separate file to share it with xml parser.
* benchmarks/parser/html-parser.html:
* benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html.
(runFunction):
(run):
(start):
* benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
2010-12-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings.
(WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings.
(WebCore::WebGLRenderingContext::drawElements): Ditto.
(WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error.
(WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto.
(WebCore::WebGLRenderingContext::stencilMask): Ditto.
(WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto.
(WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
* html/canvas/WebGLRenderingContext.h: Declare stencil setting members.
2010-12-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=51755
Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
step to landing support for the new GTK+ 3.x theming API.
No new tests. This should not change functionality.
* GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method.
(WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
(WebCore::RenderThemeGtk::paintMediaButton): Ditto.
(WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
* platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that
it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
* platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk
that will eventually be platform-dependent.
* platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
2010-12-30 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Reverting r74292 because it introduced a crash with ruby text.
https://bugs.webkit.org/show_bug.cgi?id=51637
Test: fast/css/counters/counter-ruby-text-cleared.html
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
2010-12-30 Darin Adler <darin@apple.com>
Reviewed by David Kilzer.
Remove unused JSBinding source files
https://bugs.webkit.org/show_bug.cgi?id=51762
* bindings/js/JSBinding.h: Removed.
* bindings/js/specialization: Removed.
* bindings/js/specialization/JSBindingState.cpp: Removed.
* bindings/js/specialization/JSBindingState.h: Removed.
* CMakeLists.txt: Removed references to files.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.
2010-12-30 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Adler.
Remove Document.h include from some headers where it isn't necessary
https://bugs.webkit.org/show_bug.cgi?id=51730
No new tests because no new functionality.
* editing/EditingStyle.cpp:
* editing/EditingStyle.h:
* editing/SelectionController.h:
* editing/visible_units.h:
* html/HTMLAudioElement.h:
* html/HTMLBodyElement.h:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.h:
* xml/DOMParser.cpp:
* xml/DOMParser.h:
(WebCore::DOMParser::create):
(WebCore::DOMParser::DOMParser):
2010-12-30 Benjamin C Meyer <bmeyer@rim.com>
Reviewed by Darin Adler.
bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
which is required when NOTIFICATIONS is enabled.
https://bugs.webkit.org/show_bug.cgi?id=51761
* CMakeLists.txt:
2010-12-30 Antti Koivisto <antti@apple.com>
Not reviewed.
Revert accidental project file change.
* WebCore.xcodeproj/project.pbxproj:
2010-12-30 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=51134
Move loading related code from MemoryCache to CachedResourceLoader
- Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
- Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
- Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
- Add MemoryCache::add
- Refactor the decision on whether to reload, revalidate or use the existing resource to
a single function, CachedResourceLoader::determineRevalidationPolicy
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
if ever taken (since it passes null CachedResourceLoader pointer).
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* loader/cache/CachedImage.cpp:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.
(WebCore::CachedResource::setLoadPriority):
Check for Unresolved value before setting.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::setOwningCachedResourceLoader):
Rename to be bit less mysterious.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
This was moved from MemoryCache.
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
This was moved/merged from MemoryCache.
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
This combines MemoryCache::requestResource and the existing method.
(WebCore::CachedResourceLoader::revalidateResource):
This was moved from MemoryCache.
(WebCore::CachedResourceLoader::loadResource):
New method for initiating loading.
(WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):
Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus
* loader/cache/CachedResourceLoader.h:
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::add):
* loader/cache/MemoryCache.h:
(WebCore::MemoryCache::remove):
2010-12-30 Steve Block <steveblock@google.com>
Reviewed by Gavin Barraclough.
Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
https://bugs.webkit.org/show_bug.cgi?id=51740
This is a policy decision for Android.
No new tests, simply enabling existing, tested code on Android.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
2010-12-30 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Adam Barth.
REGRESSION: fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342
Do not reload the page when submitting a form, using "GET" method, and the
form action url matches the location url, except for the fragment.
Test: fast/forms/submit-change-fragment.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldScrollToAnchor):
* loader/FrameLoader.h:
2010-12-30 Darin Adler <darin@apple.com>
Reviewed by Adam Barth.
Move security logic out of the JavaScript binding for location into the DOM class
https://bugs.webkit.org/show_bug.cgi?id=51714
* WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h,
and JSBinding.h. Later, we'll remove them from other project files and delete
the source files.
* bindings/js/JSBinding.h: Emptied out, marked for later deletion.
* bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull
function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL
function, unused toLexicalFrame function, unused completeURL function, unused
getCachedDOMStructure and cacheDOMStructure overloads, and unused
getCachedDOMConstructor and cacheDOMConstruction functions.
(WebCore::activeDOMWindow): Added.
(WebCore::firstDOMWindow): Added.
(WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through
JSBindingState, since the latter is an unneeded abstraction.
(WebCore::processingUserGesture): Changed to call ScriptController's function
rather than calling through JSBindingState, which is an unneeded abstraction
* bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added
activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly
named allowsAccessFromFrame functions, which answer the question of whether
script is allowed access *to* a frame.
* bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes.
(WebCore::JSDOMWindow::setLocation): Streamlined by using the new
activeDOMWindow and firstDOMWindow functions.
(WebCore::JSDOMWindow::open): Ditto.
(WebCore::JSDOMWindow::showModalDialog): Ditto.
(WebCore::JSDOMWindow::postMessage): Ditto.
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::setHref): Changed to pass the active and first windows through
to the Location::setHref function, with it doing the rest of the work. This moves
work out of the DOM binding that belongs in the DOM itself. Eventually such functions
could even be automatically generated by the bindings script.
(WebCore::JSLocation::setProtocol): Ditto.
(WebCore::JSLocation::setHost): Ditto.
(WebCore::JSLocation::setHostname): Ditto.
(WebCore::JSLocation::setPort): Ditto.
(WebCore::JSLocation::setPathname): Ditto.
(WebCore::JSLocation::setSearch): Ditto.
(WebCore::JSLocation::setHash): Ditto.
(WebCore::JSLocation::replace): Ditto.
(WebCore::JSLocation::reload): Ditto.
(WebCore::JSLocation::assign): Ditto.
* bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
* bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us
to use this function for Location::replace, which is the same as setLocation except that
it locks both history and the back/forward list.
* page/DOMWindow.h: Ditto.
* page/Location.cpp:
(WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security
logic there does not have to be repeated or even refactored.
(WebCore::Location::setProtocol): Ditto.
(WebCore::Location::setHost): Ditto.
(WebCore::Location::setHostname): Ditto.
(WebCore::Location::setPort): Ditto.
(WebCore::Location::setPathname): Ditto.
(WebCore::Location::setSearch): Ditto.
(WebCore::Location::setHash): Ditto.
(WebCore::Location::assign): Ditto.
(WebCore::Location::replace): Ditto.
(WebCore::Location::reload): Added. Security logic was refactored from the code in
JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems
possibly unneeded.
* page/Location.h: Fixed indentation on the whole file. Added the new functions above.
(WebCore::Location::create):
(WebCore::Location::frame):
2010-12-30 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Pasting a style property with value should automatically split it into prop/value
https://bugs.webkit.org/show_bug.cgi?id=51581
The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
and the edit focus is transferred to the value field.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/inspector.js:
(WebInspector.completeURL): Drive-by: return full URLs as-is.
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing):
(WebInspector.startEditing.pasteEventListener):
(WebInspector.startEditing.keyDownEventListener):
2010-12-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
https://bugs.webkit.org/show_bug.cgi?id=51745
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint.prototype.set enabled):
2010-12-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
https://bugs.webkit.org/show_bug.cgi?id=51748
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
(WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
(WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
2010-12-30 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).
https://bugs.webkit.org/show_bug.cgi?id=51713
* WebCore.gypi:
* WebCore.pro:
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::memoryAccessorGetter):
* bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp.
(WebCore::V8Performance::memoryAccessorGetter):
* page/Console.idl:
* page/Performance.idl:
2010-12-30 Steve Block <steveblock@google.com>
Reviewed by Sam Weinig.
Visiting macnn.com often causes SQL spew via geolocation database
https://bugs.webkit.org/show_bug.cgi?id=51557
If the Geolocation position cache database path has not been set, early-out
rather than using an empty path and thus failing to open the database.
This avoids SQL log spew.
Also, avoid starting the database thread until the path has been set, and
shorten the thread name to avoid warnings due to exceeding 30 characters.
No new tests, implementation clean-up only.
* page/GeolocationPositionCache.cpp:
(WebCore::GeolocationPositionCache::addUser):
(WebCore::GeolocationPositionCache::removeUser):
(WebCore::GeolocationPositionCache::setDatabasePath):
(WebCore::GeolocationPositionCache::startBackgroundThread):
2010-12-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] minimal build fails at link time due to missing sqlite3 symbols
https://bugs.webkit.org/show_bug.cgi?id=51327
Guard the code calling sqlite3 with the ENABLE(DATABASE) check.
No new tests, build fix only.
* platform/sql/SQLiteAuthorizer.cpp:
* platform/sql/SQLiteDatabase.cpp:
* platform/sql/SQLiteFileSystem.cpp:
* platform/sql/SQLiteStatement.cpp:
* platform/sql/SQLiteTransaction.cpp:
2010-12-30 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
https://bugs.webkit.org/show_bug.cgi?id=51692
* svg/SVGLength.cpp:
(WebCore::stringToLengthType):
(WebCore::SVGLength::setValueAsString):
2010-12-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Seidel.
Create a helper function for finding descendent video elements for a node.
https://bugs.webkit.org/show_bug.cgi?id=51696
Test: media/video-element-other-namespace-crash.html
* html/MediaDocument.cpp:
(WebCore::descendentVideoElement): helper function.
(WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions.
(WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.
2010-12-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
https://bugs.webkit.org/show_bug.cgi?id=51707
This change brushes up storage agents + removes redundant InspectorBackend class.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::databaseForId):
(WebCore::InjectedScriptHost::selectDatabase):
(WebCore::InjectedScriptHost::selectDOMStorage):
(WebCore::InjectedScriptHost::inspectorDOMAgent):
* inspector/Inspector.idl:
* inspector/InspectorBackend.cpp: Removed.
* inspector/InspectorBackend.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::releaseFrontendLifetimeAgents):
(WebCore::InspectorController::didUseDOMStorage):
(WebCore::InspectorController::setInjectedScriptSource):
(WebCore::InspectorController::dispatchOnInjectedScript):
(WebCore::InspectorController::releaseWrapperObjectGroup):
* inspector/InspectorController.h:
* inspector/InspectorDOMStorageAgent.cpp: Added.
(WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::selectDOMStorage):
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
* inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
(WebCore::InspectorDOMStorageAgent::create):
(WebCore::InspectorDOMStorageAgent::frontend):
* inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
(WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
(WebCore::InspectorDatabaseAgent::databaseForId):
(WebCore::InspectorDatabaseAgent::selectDatabase):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
* inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
(WebCore::InspectorDatabaseAgent::create):
(WebCore::InspectorDatabaseAgent::frontend):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.show):
(WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
2010-12-29 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
Cleanup SVG code according to the webkit style rules 3
https://bugs.webkit.org/show_bug.cgi?id=51490
Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
Just one file can't be fixed for check-webkit-style.
* SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
No changes of functionality, so no new tests.
* svg/SVGAllInOne.cpp:
* svg/SVGImage.cpp:
* svg/SVGLength.cpp:
(WebCore::SVGLength::setValue):
* svg/SVGPolygonElement.h:
* svg/SVGPolylineElement.h:
* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
(WebCore::SVGPreserveAspectRatio::transformRect):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::viewport):
* svg/SVGSetElement.h:
* svg/SVGStylable.h:
(WebCore::SVGStylable::~SVGStylable):
* svg/SVGStyledLocatableElement.h:
(WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
(WebCore::SVGStyledLocatableElement::isStyledLocatable):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::isKnownAttribute):
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
* svg/SVGTests.cpp:
(WebCore::SVGTests::parseMappedAttribute):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isKnownAttribute):
* svg/SVGTextPathElement.cpp:
* svg/SVGTextPathElement.h:
* svg/SVGTitleElement.h:
(WebCore::SVGTitleElement::rendererIsNeeded):
* svg/SVGTransformDistance.cpp:
(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance):
(WebCore::SVGTransformDistance::addSVGTransforms):
(WebCore::SVGTransformDistance::addSVGTransform):
(WebCore::SVGTransformDistance::addToSVGTransform):
(WebCore::SVGTransformDistance::isZero):
* svg/SVGTransformList.cpp:
* svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::getTarget):
* svg/SVGVKernElement.h:
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::parseViewSpec):
* svg/SVGZoomAndPan.h:
(WebCore::SVGZoomAndPan::SVGZoomAndPan):
(WebCore::SVGZoomAndPan::~SVGZoomAndPan):
(WebCore::SVGZoomAndPan::zoomAndPan):
* svg/SVGZoomEvent.h:
(WebCore::SVGZoomEvent::create):
* svg/animation/SMILTime.cpp:
(WebCore::operator*):
* svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
(WebCore::SMILTime::unresolved):
(WebCore::SMILTime::indefinite):
(WebCore::SMILTime::operator=):
(WebCore::SMILTime::value):
(WebCore::SMILTime::isFinite):
(WebCore::SMILTime::isIndefinite):
(WebCore::SMILTime::isUnresolved):
(WebCore::operator==):
(WebCore::operator!): new operator checks for 0 or infinite values.
(WebCore::operator!=):
(WebCore::operator>):
(WebCore::operator<):
(WebCore::operator>=):
(WebCore::operator<=):
* svg/animation/SMILTimeContainer.h:
(WebCore::SMILTimeContainer::create):
(WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
* svg/animation/SVGSMILElement.cpp:
(WebCore::ConditionEventListener::operator==):
(WebCore::SVGSMILElement::repeatingDuration):
(WebCore::SVGSMILElement::resolveInterval):
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
* svg/animation/SVGSMILElement.h:
(WebCore::SVGSMILElement::timeContainer):
(WebCore::SVGSMILElement::intervalBegin):
(WebCore::SVGSMILElement::intervalEnd):
(WebCore::SVGSMILElement::previousIntervalBegin):
(WebCore::SVGSMILElement::documentOrderIndex):
(WebCore::SVGSMILElement::setDocumentOrderIndex):
* svg/graphics/SVGImage.h:
(WebCore::SVGImage::create):
(WebCore::SVGImage::destroyDecodedData):
(WebCore::SVGImage::decodedSize):
(WebCore::SVGImage::frameAtIndex):
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::create):
(WebCore::SVGFilterBuilder::lastEffect):
(WebCore::SVGFilterBuilder::getEffectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):
2010-12-29 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
ASSERT(oldchild->parent() == owner) fails.
https://bugs.webkit.org/show_bug.cgi?id=50480
In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
assertion failure when removeChildNode executes on the child(equal to prev or next).
Fix a typo in canMergeContiguousAnonymousBlocks.
Test: fast/multicol/span/double-merge-anonymous-block-crash.html
* rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next.
(WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.
2010-12-29 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718
Test: svg/custom/scroll-to-anchor-in-symbol.svg
* page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
2010-12-29 Anton Muhin <antonm@chromium.org>
Reviewed by Eric Seidel.
[v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
https://bugs.webkit.org/show_bug.cgi?id=51704
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWindowShell.h:
2010-12-29 Kenichi Ishibashi <bashi@google.com>
Reviewed by Darin Adler.
Use a HashMap for m_continuation to save memory
https://bugs.webkit.org/show_bug.cgi?id=43716
Saving memory consumption by applying a HashMap convention to
continuation pointers of RenderInline and RenderBlock classes.
* rendering/RenderBlock.cpp: Removed m_continuation.
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::inlineElementContinuation):
(WebCore::RenderBlock::blockElementContinuation):
* rendering/RenderBlock.h: Removed m_continuation.
* rendering/RenderBoxModelObject.cpp: Added a hash map for continuations.
(WebCore::RenderBoxModelObject::destroy): Added an assertion.
(WebCore::RenderBoxModelObject::continuation): Added.
(WebCore::RenderBoxModelObject::setContinuation): Added.
* rendering/RenderBoxModelObject.h:
* rendering/RenderInline.cpp: Removed m_continuation.
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::inlineElementContinuation):
* rendering/RenderInline.h: Removed m_continuation.
2010-12-27 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
[GTK] Enable building whatever already exists of WebKit2
https://bugs.webkit.org/show_bug.cgi?id=37369
No new functionality added or deleted. Only makefile change. Hence, no tests added.
* GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and
added them to WebKit/gtk/GNUmakefile.am
* platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h>
and declare WEBKIT_API directly
2010-12-29 Eric Seidel <eric@webkit.org>
Unreviewed.
Simplify make-hash-tools.pl
https://bugs.webkit.org/show_bug.cgi?id=49922
Added HashTools.h to the project file now that its not autogenerated.
I also sorted the project file using sort-xcode-project-file
* WebCore.xcodeproj/project.pbxproj:
2010-12-29 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: revert r74755 and 74757.
2010-12-29 Martin Robinson <mrobinson@igalia.com>
Reviewed by Sam Weinig.
JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
https://bugs.webkit.org/show_bug.cgi?id=51722
Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
methods the fastcall calling convention, which leads to runtime errors when they are
called from C++. Also remove a bit of unnecessary code duplication.
No new tests. This is covered by fast/canvas/webgl/data-view-test.html.
* bindings/js/JSDataViewCustom.cpp:
(WebCore::getDataViewMember): Remove duplicated code.
(WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL.
(WebCore::JSDataView::getUint8): Ditto.
(WebCore::JSDataView::getFloat32): Ditto.
(WebCore::JSDataView::getFloat64): Ditto.
(WebCore::setDataViewMember): Remove duplicated code.
(WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL.
(WebCore::JSDataView::setUint8): Ditto.
2010-12-29 Dan Bernstein <mitz@apple.com>
Reviewed by Kenneth Russel.
A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
attach-type style recalc.
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
(WebCore::CanvasRenderingContext2D::accessFont): Added a call to
Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
and update the font if it is invalid.
* platform/graphics/Font.h:
(WebCore::Font::loadingCustomFonts): Made this private.
2010-12-29 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Qt build fix.
* inspector/InspectorController.cpp:
2010-12-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract Database & DOM Storage
agents; remove InspectorBackend.
https://bugs.webkit.org/show_bug.cgi?id=51707
This change brushes up storage agents + removes redundant
InspectorBackend class.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::databaseForId):
(WebCore::InjectedScriptHost::selectDatabase):
(WebCore::InjectedScriptHost::selectDOMStorage):
(WebCore::InjectedScriptHost::inspectorDOMAgent):
* inspector/Inspector.idl:
* inspector/InspectorBackend.cpp: Removed.
* inspector/InspectorBackend.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::releaseFrontendLifetimeAgents):
(WebCore::InspectorController::didUseDOMStorage):
(WebCore::InspectorController::setInjectedScriptSource):
(WebCore::InspectorController::dispatchOnInjectedScript):
(WebCore::InspectorController::releaseWrapperObjectGroup):
* inspector/InspectorController.h:
* inspector/InspectorDOMStorageAgent.cpp: Added.
(WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::selectDOMStorage):
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
* inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
(WebCore::InspectorDOMStorageAgent::create):
(WebCore::InspectorDOMStorageAgent::frontend):
* inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
(WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
(WebCore::InspectorDatabaseAgent::databaseForId):
(WebCore::InspectorDatabaseAgent::selectDatabase):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
* inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
(WebCore::InspectorDatabaseAgent::create):
(WebCore::InspectorDatabaseAgent::frontend):
* inspector/InspectorFrontendClientLocal.cpp:
* inspector/InspectorFrontendClientLocal.h:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.show):
2010-12-29 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
https://bugs.webkit.org/show_bug.cgi?id=51067
Typically when a script element is removed from the document, the cached script
client is removed. However, during the before load event, the cached script client
hasn't been created yet so it can't be removed.
This patch handles that case by explicitly checking if the script element was
removed during the beforeload event. Also, it avoids caching the Document references
over the arbitrary script execution in the before load event.
Test: fast/dom/HTMLScriptElement/move-in-beforeload.html
fast/dom/HTMLScriptElement/remove-in-beforeload.html
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
2010-12-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=51703
* inspector/InspectorController.cpp:
(WebCore::InspectorController::drawElementTitle):
2010-12-29 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kent Tamura.
[HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=29071
Use InputType::rangeUnderflow() and InputType::rangeOverflow()
to determine if a control is in-range or out-of-range.
Tests: fast/css/pseudo-in-range-invalid-value.html
fast/css/pseudo-in-range.html
fast/css/pseudo-out-of-range.html
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* dom/Element.h:
(WebCore::Element::isInRange):
(WebCore::Element::isOutOfRange):
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):
* html/BaseDateAndTimeInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isInRange):
(WebCore::HTMLInputElement::isOutOfRange):
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::supportsRangeLimitation):
* html/InputType.h:
* html/NumberInputType.cpp:
(WebCore::NumberInputType::supportsRangeLimitation):
* html/NumberInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::supportsRangeLimitation):
* html/RangeInputType.h:
2010-12-29 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Seidel.
When cloning an anonymous block, make sure to set the childrenInline flag based
on the state of the block to be cloned.
https://bugs.webkit.org/show_bug.cgi?id=51489
Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks.
(WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().
2010-12-29 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for WinCE after r73802.
Reapply parts from r72585:
Port ContextMenuWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48408
* CMakeLists.txt:
* platform/ContextMenu.h:
* platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createNativeMenuFromItems):
2010-12-29 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix compilation with Qt in namespace
https://bugs.webkit.org/show_bug.cgi?id=51701
* platform/graphics/ContextShadow.h:
* platform/graphics/GraphicsContext3D.h:
* platform/network/NetworkingContext.h:
* platform/network/qt/QtNAMThreadSafeProxy.h:
* plugins/PluginView.h:
2010-12-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: A disabled style property should get enabled when edited
https://bugs.webkit.org/show_bug.cgi?id=51679
Test: inspector/styles-disable-then-change.html
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):
2010-12-29 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Remove WebKitGenerators
https://bugs.webkit.org/show_bug.cgi?id=50445
* CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
2010-12-28 Pratik Solanki <psolanki@apple.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=51522
Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()
* page/win/FrameCGWin.cpp:
(WebCore::imageFromRect):
* platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::platformGradient):
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::checkForSolidColor):
* platform/graphics/gstreamer/ImageGStreamerCG.mm:
(ImageGStreamer::ImageGStreamer):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::CGContextWithHDC):
(WebCore::GraphicsContext::releaseWindowsContext):
(WebCore::GraphicsContext::drawWindowsBitmap):
* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::create):
(WebCore::BitmapImage::getHBITMAPOfSize):
* platform/image-decoders/cg/ImageDecoderCG.cpp:
(WebCore::createColorSpace):
* platform/win/DragImageCGWin.cpp:
(WebCore::allocImage):
(WebCore::createCgContextFromBitmap):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
2010-12-28 Daniel Bates <dbates@rim.com>
Reviewed by Sam Weinig.
Substitute // MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657
Fix compilation warnings about "#pragma mark" on GTK+ bots by
substituting "// MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.
* platform/graphics/cg/PathCG.cpp:
* platform/graphics/mac/WebLayer.mm:
2010-12-28 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Eric Seidel.
[Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
https://bugs.webkit.org/show_bug.cgi?id=51687
Use a const reference instead of a copy of QPainter::combinedTransform()
in GraphicsContext::getCTM()
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::getCTM):
2010-12-28 Takashi Toyoshima <toyoshim@google.com>
Reviewed by Eric Seidel.
gcc detected 'control reaches end of non-void function' with
-finstrument-functions option.
https://bugs.webkit.org/show_bug.cgi?id=51669
No new tests. These fixes are trivial.
* dom/Element.cpp:
(WebCore::Element::childTypeAllowed):
* inspector/InspectorResourceAgent.cpp:
(WebCore::cachedResourceTypeString):
2010-12-28 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Remove unused member of PendingScript
https://bugs.webkit.org/show_bug.cgi?id=51684
This was used when HTMLScriptRunner::runScript created a PendingScript
for inline scripts. But now it just calls executeScript() directly.
External scripts always have the minimum starting line number.
No new tests because no changed functionality.
* dom/PendingScript.cpp:
(WebCore::PendingScript::releaseElementAndClear):
* dom/PendingScript.h:
(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::operator=):
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::sourceFromPendingScript):
2010-12-20 Antonio Gomes <agomes@rim.com>
Reviewed by Daniel Bates.
Spatial Navigation: code clean up (Part VI)
https://bugs.webkit.org/show_bug.cgi?id=50666
No new tests needed.
* page/FocusController.cpp:
(WebCore::updatFocusCandidateIfNeeded): Assert renderer() and
isElementNode() now that we are bailing out earlier in both the
FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
* page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection
and virtualRectForAreaElementAndDirection functions.
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted callsites
of canScrollInDirection(), and added an early return if !isElementNode().
(WebCore::FocusController::advanceFocusDirectionally): Adjusted callsite of
virtualRectForAreaElementAndDirection();
* page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate): Assert if node is not a element node;
(WebCore::isScrollableNode): Renamed from isScrollableContainerNode;
(WebCore::scrollInDirection): Adjusted callsite after function name change;
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is
a documentNode.
(WebCore::canScrollInDirection): Signature changed.
(WebCore::canBeScrolledIntoView): Ditto.
(WebCore::virtualRectForAreaElementAndDirection): Ditto.
2010-12-28 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Fix tiled compositor assertion after GPU process recovery.
https://bugs.webkit.org/show_bug.cgi?id=51682
After the GPU process recovers, the layer size is set to IntSize(),
but IntRect::unite() has a special case for empty rects. This
behavior was causing the layer size to be too small, causing an
out-of-bounds array access elsewhere.
No new tests.
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::growLayerToContain):
2010-12-23 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421
* html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer.
(WebCore::WebGLFramebuffer::WebGLFramebuffer):
(WebCore::WebGLFramebuffer::setAttachment):
(WebCore::WebGLFramebuffer::getWidth):
(WebCore::WebGLFramebuffer::getHeight):
(WebCore::WebGLFramebuffer::getColorBufferFormat):
* html/canvas/WebGLFramebuffer.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0.
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::renderbufferStorage):
(WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
(WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level.
(WebCore::WebGLTexture::getInternalFormat):
(WebCore::WebGLTexture::getWidth):
(WebCore::WebGLTexture::getHeight):
(WebCore::WebGLTexture::mapTargetToIndex):
(WebCore::WebGLTexture::getLevelInfo):
* html/canvas/WebGLTexture.h:
(WebCore::WebGLTexture::isTexture):
* platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
2010-12-23 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long.
(WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
(WebCore::WebGLRenderingContext::scissor): Ditto.
(WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
(WebCore::WebGLRenderingContext::texImage2D): Ditto.
(WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto.
(WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
(WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::viewport): Ditto.
(WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLRenderingContext.idl:
2010-12-28 Abhishek Arya <inferno@chromium.org>
Reviewed by Kenneth Russell.
Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
process of loading.
https://bugs.webkit.org/show_bug.cgi?id=51681
Test: canvas/philip/tests/2d.text-custom-font-load-crash.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
* platform/graphics/Font.cpp:
(WebCore::Font::operator==): Replace condition with new function loadingCustomFonts()
(WebCore::Font::drawText): Replace condition with new function loadingCustomFonts()
(WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
* platform/graphics/Font.h:
(WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.
2010-12-28 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Combine setShadowRoot and clearShadowRoot into a simpler API
https://bugs.webkit.org/show_bug.cgi?id=50971
No change in behavior, and API is not used yet.
* dom/Element.cpp:
(WebCore::Element::setShadowRoot): Combined clearing and setting of
the shadowRoot, also hooked up with setting and clearing of the
corresponding shadowHost values.
* dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it
private.
* dom/Node.h: Made shadow host-related functions public so that
Element::setShadowRoot can access setShadowHost. It seems logical
to make shadowHost public as well to keep the defs together.
2010-12-28 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
https://bugs.webkit.org/show_bug.cgi?id=49727
Test: http/tests/inspector/extensions-resources-redirect.html
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._appendRedirect):
2010-12-28 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Qt.
ResourceTreeModel.js was added.
* inspector/front-end/WebKit.qrc:
2010-12-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.
https://bugs.webkit.org/show_bug.cgi?id=51680
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
2010-12-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663
The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
optional quotes/apostrophes and spaces are now allowed inside uri(...).
Test: inspector/styles-url-linkify.html
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle):
2010-12-21 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.
Domain was changed for Resources, FileSystem etc. related methods.
ResourcesManager was renamed to NetworkManager.
ResourceTreeModel was extracted as separate file.
FileSystem, Database, DOMStorage and ApplicationCache methods were
removed from NetworkManager and added to corresponding classes.
https://bugs.webkit.org/show_bug.cgi?id=51334
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.addMessage):
(WebInspector.ConsoleView.prototype.clearMessages):
* inspector/front-end/DOMAgent.js:
(WebInspector.ApplicationCache.updateApplicationCacheStatus):
(WebInspector.ApplicationCache.updateNetworkState):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.addDOMStorage):
(WebInspector.DOMStorage.selectDOMStorage):
(WebInspector.DOMStorage.updateDOMStorage):
* inspector/front-end/Database.js:
(WebInspector.Database.prototype.executeSql):
(WebInspector.Database.addDatabase):
(WebInspector.Database.selectDatabase):
(WebInspector.Database.sqlTransactionSucceeded):
(WebInspector.Database.sqlTransactionFailed):
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystem.didGetFileSystemPath):
(WebInspector.FileSystem.didGetFileSystemError):
(WebInspector.FileSystem.didGetFileSystemDisabled):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
* inspector/front-end/NetworkManager.js: Added.
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype._createResource):
(WebInspector.NetworkManager.prototype.identifierForInitialRequest):
(WebInspector.NetworkManager.prototype.willSendRequest):
(WebInspector.NetworkManager.prototype._updateResourceWithRequest):
(WebInspector.NetworkManager.prototype._appendRedirect):
(WebInspector.NetworkManager.prototype.markResourceAsCached):
(WebInspector.NetworkManager.prototype.didReceiveResponse):
(WebInspector.NetworkManager.prototype._updateResourceWithResponse):
(WebInspector.NetworkManager.prototype.didReceiveContentLength):
(WebInspector.NetworkManager.prototype.didFinishLoading):
(WebInspector.NetworkManager.prototype.didFailLoading):
(WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
(WebInspector.NetworkManager.prototype._updateResourceWithCachedResource):
(WebInspector.NetworkManager.prototype.setInitialContent):
(WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
(WebInspector.NetworkManager.prototype.frameDetachedFromParent):
(WebInspector.NetworkManager.prototype.didCreateWebSocket):
(WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
(WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
(WebInspector.NetworkManager.prototype.didCloseWebSocket):
(WebInspector.NetworkManager.prototype._processCachedResources):
(WebInspector.NetworkManager.prototype._addFramesRecursively):
(WebInspector.NetworkManager.requestContent):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.refreshResource):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._innerRequestContent):
* inspector/front-end/ResourceManager.js: Removed.
* inspector/front-end/ResourceTreeModel.js: Added.
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
(WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
(WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent):
(WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
(WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
(WebInspector.ResourceTreeModel.prototype._clearResources):
(WebInspector.ResourceTreeModel.prototype.forAllResources):
(WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
(WebInspector.ResourceTreeModel.prototype.clearConsoleMessages):
(WebInspector.ResourceTreeModel.prototype._callForFrameResources):
(WebInspector.ResourceTreeModel.prototype.resourceForURL):
(WebInspector.ResourceTreeModel.prototype.bindResourceURL):
(WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
(WebInspector.ResourceTreeModel.createResource):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.createResourceView):
(WebInspector.ResourceView.resourceViewTypeMatchesResource):
(WebInspector.ResourceView.resourceViewForResource):
(WebInspector.ResourceView.recreateResourceView):
(WebInspector.ResourceView.existingResourceViewForResource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.canShowSourceLine):
(WebInspector.ResourcesPanel.prototype.showSourceLine):
(WebInspector.ResourcesPanel.prototype.showResource):
(WebInspector.ResourcesPanel.prototype.get searchableViews.callback):
(WebInspector.ResourcesPanel.prototype.get searchableViews):
(WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
(WebInspector.FrameResourceTreeElement.prototype._contentChanged):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addScript):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.forAllResources):
(WebInspector.resourceForURL):
2010-12-27 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
ContextShadow should use AffineTransform instead of TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=51661
ContextShadow needs the CTM to make sure shadows are not affected by
transformations when drawing on a canvas. AffineTransform is sufficient
in this case.
Existing tests: fast/canvas/canvas*shadow*html
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::mustUseContextShadow):
(WebCore::ContextShadow::adjustBlurDistance):
(WebCore::ContextShadow::calculateLayerBoundingRect):
* platform/graphics/ContextShadow.h:
* platform/graphics/cairo/ContextShadowCairo.cpp:
(WebCore::ContextShadow::getTransformationMatrixFromContext):
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ContextShadow::getTransformationMatrixFromContext):
2010-12-27 Daniel Bates <dbates@rim.com>
Reviewed by Antonio Gomes.
Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
https://bugs.webkit.org/show_bug.cgi?id=51634
Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
to HTMLFrameElementBase::marginWidth() and HTMLFrameElementBase::marginHeight(), respectively.
This will make the names of these getters consistent with the naming convention we use for
getters.
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedIntoDocument):
* html/HTMLFrameElementBase.h:
(WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth().
(WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadSubframe):
* page/FrameView.cpp:
(WebCore::FrameView::init):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh
to marginWidth and marginHeight, respectively. This makes the names of these variables
consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
* rendering/RenderFrame.cpp:
(WebCore::RenderFrame::viewCleared): Ditto.
2010-12-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
https://bugs.webkit.org/show_bug.cgi?id=51654
Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
on some debug configurations.
No new tests. This is already covered by current slider tests. It isn't crashing on
the bots, but it does crash locally.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
2010-12-27 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
[v8] Remove unused methods to protect/unprotect wrappers during garbage collection
https://bugs.webkit.org/show_bug.cgi?id=51648
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::gcEpilogue):
* bindings/v8/V8GCController.h:
2010-12-27 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Removed trailing spaces from a localized
string to make it the same as the one used in the code.
* English.lproj/localizedStrings.js:
2010-12-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968
Throw an exception if there is no argument to querySelector or
querySelectorAll. This replaces the current behavior of passing the string
"undefined" as the argument.
No new tests, just updating the existing results for
fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/Element.idl:
2010-12-26 MORITA Hajime <morrita@google.com>
Reviewed by Dan Bernstein.
For box-shadow, non-primary shadows should have specified radii.
https://bugs.webkit.org/show_bug.cgi?id=51386
On paintBoxShadow(), the spread value accidentally accumulated accidentally
during the loop, which should be applied individually for radius of each shadow.
This change makes the radii for rects computed for each shadow.
Test: fast/box-shadow/spread-multiple-normal.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
2010-12-26 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Improve output of HTML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51611
Calculate and show median, min and max values.
* benchmarks/parser/html-parser.html:
2010-12-26 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer.
https://bugs.webkit.org/show_bug.cgi?id=48772
Test: fast/multicol/renderer-positioned-assert-crash.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintPaginatedChildLayer):
(WebCore::RenderLayer::hitTestPaginatedChildLayer):
2010-12-25 Peter Rybin <peter.rybin@gmail.com>
Reviewed by Adam Barth.
Adds currentColumn (and currentLine) to SegmentedString. Switches
HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
needs position for a <script> tag.
SegmentedString should provide column position
https://bugs.webkit.org/show_bug.cgi?id=51311
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::textPosition):
* html/parser/HTMLInputStream.h:
(WebCore::HTMLInputStream::current):
(WebCore::InsertionPointRecord::InsertionPointRecord):
(WebCore::InsertionPointRecord::~InsertionPointRecord):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
* html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::create):
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::numberOfCharactersConsumedSlow):
(WebCore::SegmentedString::advanceSlowCase):
(WebCore::SegmentedString::currentLine):
(WebCore::SegmentedString::currentColumn):
(WebCore::SegmentedString::setCurrentPosition):
* platform/text/SegmentedString.h:
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::advancePastNewline):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::numberOfCharactersConsumed):
2010-12-25 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
GraphicsContext: Don't pass StrokeStyle (enum) as const reference
https://bugs.webkit.org/show_bug.cgi?id=51608
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setStrokeStyle):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::adjustLineToPixelBoundaries):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformStrokeStyle):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::setPlatformStrokeStyle):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::setPlatformStrokeStyle):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::setStrokeStyle):
* platform/graphics/openvg/PainterOpenVG.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::setPlatformStrokeStyle):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformStrokeStyle):
2010-12-24 Dan Bernstein <mitz@apple.com>
Reviewed by Alexey Proskuryakov.
REGRESSION (r74648): XHR layout test failures
https://bugs.webkit.org/show_bug.cgi?id=51603
Reverted r74648.
* WebCore.exp.in:
2010-12-24 Dan Bernstein <mitz@apple.com>
Try to fix the Qt build after r74648.
* WebCore.gypi:
* WebCore.pro:
* platform/network/qt/CredentialStorageQt.cpp: Added.
(WebCore::CredentialStorage::getFromPersistentStorage):
2010-12-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
CSSStyleSelector cleanup
https://bugs.webkit.org/show_bug.cgi?id=51597
Make some methods const. Add assertion to checkOneSelector, with the
intention of later removing the if (!e) check (this is hot code).
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::mmLength):
(WebCore::CSSStyleSelector::inchLength):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
(WebCore::CSSStyleSelector::hasSelectorForAttribute):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::fontSelector):
2010-12-24 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/8758386> The web process uses its own credential storage
https://bugs.webkit.org/show_bug.cgi?id=51599
* WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),
and Credential::isEmpty().
2010-12-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Darin Adler.
[V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=51595
* WebCore.gypi:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp.
(WebCore::V8EventListener::V8EventListener):
(WebCore::V8EventListener::getListenerFunction):
(WebCore::V8EventListener::callListenerFunction):
* bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h.
(WebCore::V8EventListener::create):
* bindings/v8/V8EventListenerList.h:
* bindings/v8/V8WorkerContextEventListener.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8LocationCustom.cpp:
* bindings/v8/custom/V8NodeCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
2010-12-24 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Show current time / total in media player
https://bugs.webkit.org/show_bug.cgi?id=51535
* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::formatMediaControlsCurrentTime):
(WebCore::RenderThemeGtk::paintMediaCurrentTime):
* platform/gtk/RenderThemeGtk.h:
2010-12-24 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Eric Seidel.
Clean up CSSRuleData in CSSStyleSelector.h
https://bugs.webkit.org/show_bug.cgi?id=27753
Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleData::CSSRuleData):
(WebCore::CSSRuleData::~CSSRuleData):
(WebCore::CSSRuleData::position):
(WebCore::CSSRuleData::rule):
(WebCore::CSSRuleData::selector):
(WebCore::CSSRuleData::next):
(WebCore::CSSRuleDataList::CSSRuleDataList):
(WebCore::CSSRuleDataList::~CSSRuleDataList):
(WebCore::CSSRuleDataList::first):
(WebCore::CSSRuleDataList::last):
(WebCore::CSSRuleDataList::append):
* css/CSSStyleSelector.h:
2010-12-24 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix compilation on Windows.
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
* inspector/InspectorStyleSheet.h:
2010-12-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Darin Adler.
inspector/debugger-step-out.html crashing intermittently in the bots
https://bugs.webkit.org/show_bug.cgi?id=50868
Use RefPtr rather instead of raw pointers when keeping references
to refcounted objects.
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStylesForNode2):
(WebCore::InspectorCSSAgent::getComputedStyleForNode2):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::create):
(WebCore::InspectorStyle::InspectorStyle):
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyle::populateAllProperties):
(WebCore::InspectorStyle::replacePropertyInStyleText):
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
* inspector/InspectorStyleSheet.h:
(WebCore::InspectorStyle::cssStyle):
(WebCore::InspectorStyleSheet::pageStyleSheet):
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486
Test: svg/custom/use-instanceRoot-with-use-removed.svg
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::clearUseElement):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::removedFromDocument):
(WebCore::ShadowTreeUpdateBlocker::if):
(WebCore::SVGUseElement::detachInstance):
(WebCore::SVGUseElement::detach):
* svg/SVGUseElement.h:
2010-12-23 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Missing Localized Strings
https://bugs.webkit.org/show_bug.cgi?id=51542
Added missing strings: "WebSocket", "Frames", "Text", "Transfer",
"Preserve Log upon Navigation", and "Go to Line".
* English.lproj/localizedStrings.js:
2010-12-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
https://bugs.webkit.org/show_bug.cgi?id=51478
Now the element attribute modifications (including "style") are tracked, which results in the
source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
on the "style" attribute modification through the Elements tree. Also, it appears that
a complete "style" attribute removal destroys the inline style declaration
(StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).
Test: inspector/elements-delete-inline-style.html
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didModifyDOMAttr):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
(WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
(WebCore::InspectorStyleSheetForInlineStyle::text):
(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
* inspector/InspectorStyleSheet.h:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
2010-12-24 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Andreas Kling.
[chromium] Fix a style nit in the JPEG encoder
https://bugs.webkit.org/show_bug.cgi?id=51574
* platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.
2010-12-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Maciej Stachowiak.
Web Inspector: CSS shorthand properties expand unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=36304
"border-radius" is a shorthand property that has a "non-standard" format and longhands, see
http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
appropriately when adding implicit longhands, thus they were added as normal properties
found in the CSS (neither implicit, nor longhands). This is now fixed.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseBorderRadius):
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=51576
Disallowed elements may be pruned from the shadow tree, leaving a null
shadowTreeElement. We should check for that before setting attributes.
Test: svg/custom/animate-disallowed-use-element.svg
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
2010-12-24 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
TextMetrics::width is an integer, but the member is a float
https://bugs.webkit.org/show_bug.cgi?id=51566
Change the return type to a float.
No tests, fixing a compiler warning.
(I was unable to produce a difference in the values exposed to pages
with a float versus the previous conversion to an integer.)
* html/TextMetrics.h:
(WebCore::TextMetrics::width):
2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125
Add files for EFL to support TOUCH_EVENTS.
* CMakeLists.txt:
* CMakeListsEfl.txt:
* platform/PlatformTouchEvent.h: Add EFL related constructor.
* platform/PlatformTouchPoint.h: ditto.
* platform/efl/PlatformTouchEventEfl.cpp: Added.
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
* platform/efl/PlatformTouchPointEfl.cpp: Added.
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
2010-12-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
https://bugs.webkit.org/show_bug.cgi?id=51457
WebKit EFL can't play html5 audio because of wrong mime type checking.
So, 'application/octet-stream' is changed with an empty string.
* platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
Returns an empty string instead of application/octet-stream when it can't find proper mime type.
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
SVGFontFaceElement::rebuildFontFace() should exit when not in document
https://bugs.webkit.org/show_bug.cgi?id=51571
We were hitting a NULL deref crash. Since most of the callers checked
inDocument() anyway, I moved it into the start of rebuildFontFace.
Test: svg/custom/use-invalid-font-face.svg
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::parseMappedAttribute):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::childrenChanged):
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Remove unnecessary check in CSSCanvasValue::canvasDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=51564
This check was duplicating an ASSERT for a case fixed in r73927.
Now that the bug is fixed the check is no longer necessary.
Removing dead code, so no new tests needed.
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::canvasDestroyed):
2010-12-23 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
ViewportArguments.h uses an enum to intialize a bool
https://bugs.webkit.org/show_bug.cgi?id=50982
Initialize userScalable to true, rather than -1.
No tests; fixes a compiler warning.
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Adam Barth.
[Qt] User name/password stripped from URLs
https://bugs.webkit.org/show_bug.cgi?id=36232
If a username but no password or no username but a password is present
in a URL, QtWebKit won't send any authentication information down to Qt
as it should.
Tests: http/tests/xmlhttprequest/basic-auth-nopassword.html
http/tests/xmlhttprequest/basic-auth-nouser.html
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue("FormatBlock") does not respect editing boundaries
https://bugs.webkit.org/show_bug.cgi?id=51219
Fixed the bug by checking the element we found in elementForFormatBlockCommand
does not contain the editable root.
* editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::elementForFormatBlockCommand):
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
FormatBlock doesn't preserve typing style but it should
https://bugs.webkit.org/show_bug.cgi?id=51140
Fixed the bug by making preserveTypingStyle return true.
Test: editing/execCommand/format-block-typing-style.html
* editing/FormatBlockCommand.h:
(WebCore::FormatBlockCommand::preservesTypingStyle):
2010-12-23 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
Need WebKit2 API to create a SecurityOrigin from protocol, host, and port
https://bugs.webkit.org/show_bug.cgi?id=51563
Add SecurityOrigin::create(const String& protocol, const String& host, int port).
* WebCore.exp.in:
Export the symbols for WebCore::SecurityOrigin::create(String, String, int).
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
Use the constant MaxAllowedPort.
(WebCore::SecurityOrigin::create):
Sanitizing based off of that done in createFromDatabaseIdentifier.
* page/SecurityOrigin.h:
2010-12-23 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix for WinCE after r73802.
Reapply r70812:
Port ContextMenuItemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48407
* platform/win/ContextMenuItemWin.cpp:
2010-12-23 Adam Barth <abarth@webkit.org>
Remove include of non-existant file.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Selection becomes stale when CharacterData is manipulated directly
https://bugs.webkit.org/show_bug.cgi?id=51389
The bug was caused by SelectionController's not adjusting selection when CharacterData's
m_data is modified by its API.
Fixed the bug by adding textWillBeReplaced to SelectionController and calling it in
CharacterData::textWillBeReplaced. Added newLength to setDataAndUpdate, which is passed to
textWillBeReplaced because inserting, replacing, or removing data may require moving
the offset of the selection end points (done by shouldRemovePositionAfterAdoptingTextReplacement).
Also fixed the condition for determining whether or not a node intersects the selection
in respondToNodeModification, which is extracted from nodeWillBeRemoved. The old condition
failed to recognize certain cases when selection started and ended with non-zero offsets.
Tests: editing/selection/character-data-mutation-crash.html
editing/selection/character-data-mutation.html
* dom/CharacterData.cpp:
(WebCore::CharacterData::setData): Passes newLegnth to setDataAndUpdate.
(WebCore::CharacterData::appendData): Ditto.
(WebCore::CharacterData::insertData): Ditto.
(WebCore::CharacterData::deleteData): Ditto.
(WebCore::CharacterData::replaceData): Ditto.
(WebCore::CharacterData::setDataAndUpdate): Added newLegnth to the argument list,
and renamed lengthOfReplacedData to oldLength; calls textWillBeReplaced.
* dom/CharacterData.h:
* editing/SelectionController.cpp:
(WebCore::removingNodeRemovesPosition): Removed indentations from blank lines.
(WebCore::SelectionController::nodeWillBeRemoved): Calls nodeWillBeRemoved.
(WebCore::SelectionController::respondToNodeModification): Extracted from nodeWillBeRemoved;
fixed the logic to figure out whether a node is inside the range or not.
(WebCore::shouldRemovePositionAfterAdoptingTextReplacement): Added.
(WebCore::SelectionController::textWillBeReplaced): Added.
* editing/SelectionController.h:
2010-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove unneeded V8 bindings files
https://bugs.webkit.org/show_bug.cgi?id=51570
* WebCore.gypi:
* bindings/generic/BindingDOMWindow.h: Removed.
* bindings/v8/specialization/V8BindingDOMWindow.h: Removed.
2010-12-23 Dan Bernstein <mitz@apple.com>
Build fix.
* editing/EditorCommand.cpp:
(WebCore::enabledDismissCorrectionPanel):
2010-12-23 Darin Adler <darin@apple.com>
Try to fix crash seen on GTK bot.
* editing/EditorCommand.cpp:
(WebCore::internalCommand): Add back empty string check I accidentally deleted in r74580.
* WebCore.xcodeproj/project.pbxproj: Let Xcode edit the file.
2010-12-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74561.
http://trac.webkit.org/changeset/74561
https://bugs.webkit.org/show_bug.cgi?id=51565
"Broke Chromium UI tests on Vista" (Requested by kbr_google on
#webkit).
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
2010-12-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
https://bugs.webkit.org/show_bug.cgi?id=51507
Adds WebThemeEngine for the Mac (it already has parallel definitions for
Windows and Linux) so that scrollbar thumb rendering can be overridden
for the DRT (to be consistent with the NSScroller-based rendering
used by the Mac port).
No new tests since the functionality is not exposed yet. Eventually will
result in the Chromium/Mac port being able to use the same pixel
baselines for layout tests as the Mac port.
* platform/chromium/ChromiumBridge.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
2010-12-23 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WKView should not try to do asynchronous validation for selectors that are not editor commands
https://bugs.webkit.org/show_bug.cgi?id=51555
* WebCore.exp.in: Added commandIsSupportedFromMenuOrKeyBinding.
* editing/Editor.h: Reordered arguments in the Editor::Command constructor
and the data members too so the frame is last. Added
commandIsSupportedFromMenuOrKeyBinding.
* editing/EditorCommand.cpp:
(WebCore::supported): Removed the EditorCommandSource argument. These
functions are now only used when called from DOM.
(WebCore::supportedFromMenuOrKeyBinding): Ditto.
(WebCore::supportedCopyCut): Ditto.
(WebCore::supportedPaste): Ditto.
(WebCore::enabledDismissCorrectionPanel): Changed the supported function to
an enabled function. It was incorrect to say that this is "supported" only
when the correction panel is up. Correct to say that it is "enabled" only
then. And also probably OK to enable it even when the selection is not in
editable text, as long as the panel is up.
(WebCore::createCommandMap): Moved conditional commands out of the main
array into a separate section at the end.
(WebCore::internalCommand): Added.
(WebCore::Editor::command): Changed to use the new internalCommand function
and simplified by relying on the null check in the Command constructor.
(WebCore::Editor::commandIsSupportedFromMenuOrKeyBinding): Added.
(WebCore::Editor::Command::Command): Removed unneeded initialization of
m_source, which is never looked at if m_command is 0. Added feature of
passing a null command pointer to the non-default constructor.
(WebCore::Editor::Command::isSupported): Changed to only call the
per-command isSupported function when the command source is DOM.
Accordingly that function is now called isSupportedFromDOM.
2010-12-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Incorrect layer property used noted as changed in GraphicsLayerCA::setAcceleratesDrawing
https://bugs.webkit.org/show_bug.cgi?id=51560
No new tests.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setAcceleratesDrawing):
2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Andreas Kling.
[Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
https://bugs.webkit.org/show_bug.cgi?id=35635
Explicitly set text/html data on QClipboard as UTF-8 and also include a <meta>
tag informing the OS that the data is in UTF-8 format.
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection):
2010-12-23 Justin Schuh <jschuh@chromium.org>
Reviewed by Eric Seidel.
CSSCursorImageValue destructor should clear referenced element.
https://bugs.webkit.org/show_bug.cgi?id=51417
Calls correct method to clear image and renames method to avoid future confusion.
Test: svg/css/cursor-image-replace.svg
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
* svg/SVGElement.cpp:
(WebCore::SVGElement::cursorImageValueRemoved):
* svg/SVGElement.h:
2010-12-22 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
WebKit2 needs to mirror the frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=51546
- Add client functions to notify that a frame has been added or
removed from the page cache.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):
* history/CachedFrame.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didSaveToPageCache):
(WebCore::EmptyFrameLoaderClient::didRestoreFromPageCache):
* loader/FrameLoaderClient.h:
2010-12-22 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
This patch also changes USE_IOSURFACE to instead follow USE(IOSURFACE)
https://bugs.webkit.org/show_bug.cgi?id=51279
* html/HTMLCanvasElement.cpp: For IOSurface, use setNeedsStyleRecalc
* html/canvas/CanvasRenderingContext2D.cpp: Use new flag
* platform/graphics/ImageBuffer.h: Use new flag
* platform/graphics/cg/ImageBufferCG.cpp: Use new flag
2010-12-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Tile root layer of the compositor.
https://bugs.webkit.org/show_bug.cgi?id=49947
Refactor root layer update and drawing from LayerRendererChromium into
LayerTilerChromium. The root layer is now drawn as multiple tiles
rather than as one single large texture. Scrollbars are now drawn
separately rather than as part of the root layer.
Test: LayoutTests/compositing/
* WebCore.gypi:
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::setClipsRepaints):
* platform/ScrollView.h:
(WebCore::ScrollView::clipsRepaints):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::useShader):
(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::updateAndDrawRootLayer):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTilerChromium.cpp: Added.
(WebCore::LayerTilerChromium::create):
(WebCore::LayerTilerChromium::LayerTilerChromium):
(WebCore::LayerTilerChromium::~LayerTilerChromium):
(WebCore::LayerTilerChromium::layerRendererContext):
(WebCore::LayerTilerChromium::setTileSize):
(WebCore::LayerTilerChromium::reset):
(WebCore::LayerTilerChromium::createTile):
(WebCore::LayerTilerChromium::invalidateTiles):
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::contentRectToLayerRect):
(WebCore::LayerTilerChromium::layerRectToContentRect):
(WebCore::LayerTilerChromium::tileIndex):
(WebCore::LayerTilerChromium::tileContentRect):
(WebCore::LayerTilerChromium::tileLayerRect):
(WebCore::LayerTilerChromium::invalidateRect):
(WebCore::LayerTilerChromium::invalidateEntireLayer):
(WebCore::LayerTilerChromium::update):
(WebCore::LayerTilerChromium::setLayerPosition):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::resizeLayer):
(WebCore::LayerTilerChromium::growLayerToContain):
(WebCore::LayerTilerChromium::Tile::~Tile):
(WebCore::LayerTilerChromium::Tile::releaseTextureId):
* platform/graphics/chromium/LayerTilerChromium.h: Added.
(WebCore::LayerTilerChromium::Tile::Tile):
(WebCore::LayerTilerChromium::Tile::textureId):
(WebCore::LayerTilerChromium::Tile::dirty):
(WebCore::LayerTilerChromium::Tile::clearDirty):
(WebCore::LayerTilerChromium::layerRenderer):
2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441
Removed #include <Selection.h> from Editor.h.
Also extracted WritingDirection.h from EditingStyle.h and renamed SelectionController::EDirection
to SelectionDirection and moved its declaration from SelectionController.h to VisibleSelection.h
* WebCore.exp.in: Signature changes.
* WebCore.xcodeproj/project.pbxproj: Added WritingDirection.h
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): Change due to SelectionDirection.
* editing/EditingStyle.h: Removed WritingDirection and included WritingDirection.h
* editing/Editor.cpp:
(WebCore::Editor::deleteWithDirection): Change due to SelectionDirection.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
(WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
* editing/Editor.h: Removed SelectionController.h; added DocumentMarker.h, Timer.h, VisibleSelection.h
and WritingDirection.h; forward declared CSSMutableStyleDeclaration.
* editing/EditorCommand.cpp:
(WebCore::executeDeleteBackward): Change due to SelectionDirection.
(WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto.
(WebCore::executeDeleteForward): Ditto.
(WebCore::executeDeleteToBeginningOfLine): Ditto.
(WebCore::executeDeleteToBeginningOfParagraph): Ditto.
(WebCore::executeDeleteToEndOfLine): Ditto.
(WebCore::executeDeleteToEndOfParagraph): Ditto.
(WebCore::executeDeleteWordBackward): Ditto.
(WebCore::executeDeleteWordForward): Ditto.
(WebCore::executeForwardDelete): Ditto.
(WebCore::executeMoveBackward): Ditto.
(WebCore::executeMoveBackwardAndModifySelection): Ditto.
(WebCore::executeMoveDown): Ditto.
(WebCore::executeMoveDownAndModifySelection): Ditto.
(WebCore::executeMoveForward): Ditto.
(WebCore::executeMoveForwardAndModifySelection): Ditto.
(WebCore::executeMoveLeft): Ditto.
(WebCore::executeMoveLeftAndModifySelection): Ditto.
(WebCore::executeMoveRight): Ditto.
(WebCore::executeMoveRightAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfDocument): Ditto.
(WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfLine): Ditto.
(WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfParagraph): Ditto.
(WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto.
(WebCore::executeMoveToBeginningOfSentence): Ditto.
(WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfDocument): Ditto.
(WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfSentence): Ditto.
(WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfLine): Ditto.
(WebCore::executeMoveToEndOfLineAndModifySelection): Ditto.
(WebCore::executeMoveToEndOfParagraph): Ditto.
(WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto.
(WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto.
(WebCore::executeMoveParagraphForwardAndModifySelection): Ditto.
(WebCore::executeMoveUp): Ditto.
(WebCore::executeMoveUpAndModifySelection): Ditto.
(WebCore::executeMoveWordBackward): Ditto.
(WebCore::executeMoveWordBackwardAndModifySelection): Ditto.
(WebCore::executeMoveWordForward): Ditto.
(WebCore::executeMoveWordForwardAndModifySelection): Ditto.
(WebCore::executeMoveWordLeft): Ditto.
(WebCore::executeMoveWordLeftAndModifySelection): Ditto.
(WebCore::executeMoveWordRight): Ditto.
(WebCore::executeMoveWordRightAndModifySelection): Ditto.
(WebCore::executeMoveToLeftEndOfLine): Ditto.
(WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto.
(WebCore::executeMoveToRightEndOfLine): Ditto.
(WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto.
* editing/SelectionController.cpp:
(WebCore::SelectionController::willBeModified): Takes SelectionDirection instead of EDirection.
(WebCore::SelectionController::modify): Ditto.
* editing/SelectionController.h: Change due to SelectionDirection.
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Ditto.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
* editing/VisibleSelection.h: Added SelectionDirection, renamed and moved from EDirection
in SelectionController.h
* editing/WritingDirection.h: Added.
* page/DOMSelection.cpp:
(WebCore::DOMSelection::modify): Change due to SelectionDirection.
(WebCore::DOMSelection::deleteFromDocument): Ditto.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleKeyboardSelectionMovement): Ditto.
* page/Frame.h: Includes SelectionController.h.
2010-12-23 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move V8 to WebCore's implementation of showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=51527
This code is basically verbatim translation from the JavaScriptCore
bindings. The only intentional difference is in the world selection
for the dialog's frame. I suspect JavaScriptCore's bindings have a
subtle bug there.
In this patch, I also remove a bunch of now-unneeded code in the
generic bindings.
* bindings/generic/BindingDOMWindow.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::DialogHandler::dialogCreated):
(WebCore::setUpDialog):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::DialogHandler::DialogHandler):
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):
(WebCore::setUpDialog):
(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):
* bindings/v8/specialization/V8BindingDOMWindow.h:
2010-12-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Can't backspace from CSS value to CSS key field
https://bugs.webkit.org/show_bug.cgi?id=51476
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.):
(WebInspector.StylePropertyTreeElement.prototype):
2010-12-23 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=51186
No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Fix check by undefined macro
https://bugs.webkit.org/show_bug.cgi?id=51531
Fix check by undefined macro
When building EFL port with libsoup, BUILDING_GTK__ is not defined,
leading to warnings during compile. We actually have to use an #ifdef
instead of an #if.
No change in functionality so no new tests.
* platform/network/soup/cache/webkit/soup-cache.h:
2010-12-23 Jonathan Dixon <joth@chromium.org>
Reviewed by Steve Block.
TouchEvents does not support multi-touch on a page with multiple touch targets
https://bugs.webkit.org/show_bug.cgi?id=51258
Test: fast/events/touch/multi-touch-grouped-targets.html
* page/EventHandler.cpp:
(WebCore::eventNameForTouchPointState):
(WebCore::EventHandler::handleTouchEvent):
Redesigned event handler to ensure all event targets involved in a given
multitouch event get the appropriate event(s) fired.
* platform/PlatformTouchPoint.h: Added end-stop marker for State enum.
2010-12-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] media/audio-data-url.html fails since r75504
https://bugs.webkit.org/show_bug.cgi?id=51525
Make the GStreamer media-player advertize 3gpp mime-types as
supported if the 3gp caps are in the typefind factories.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
2010-12-23 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=51093
Move BeforeTextInserted and Wheel event handling, event forwarding to
renderers, and the isindex form submission quirk code to InputTypes.
Also, change the return types of InputType event handlers from 'bool'
to 'void'. We use Event::defaultHandled() to decide whether event
handling should be stopped.
No new tests because this is just a refactoring.
* html/BaseButtonInputType.cpp: bool->void changes
(WebCore::BaseButtonInputType::handleKeydownEvent):
(WebCore::BaseButtonInputType::handleKeypressEvent):
(WebCore::BaseButtonInputType::handleKeyupEvent):
* html/BaseButtonInputType.h: ditto.
* html/BaseCheckableInputType.cpp: ditto.
(WebCore::BaseCheckableInputType::handleKeydownEvent):
(WebCore::BaseCheckableInputType::handleKeypressEvent):
* html/BaseCheckableInputType.h: ditto.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::handleKeydownEvent): ditto.
(WebCore::BaseDateAndTimeInputType::handleWheelEvent): Just calls handleWheelEventForSpinButton().
* html/BaseDateAndTimeInputType.h: bool->void change and handleWhellEvent() addition.
* html/CheckboxInputType.cpp: bool->void change
(WebCore::CheckboxInputType::handleKeyupEvent):
* html/CheckboxInputType.h: ditto.
* html/FileInputType.cpp: ditto.
(WebCore::FileInputType::handleDOMActivateEvent):
* html/FileInputType.h: ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
- Change return-value handling of InputType event handlers
- Move out beforeTextInserted/wheel event handling and isindex form quirk.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
Added so that InputType can call InputElement::handleBeforeTextInsertedEvent().
* html/ImageInputType.cpp: bool->void change
(WebCore::ImageInputType::handleDOMActivateEvent):
* html/ImageInputType.h: ditto.
* html/InputType.cpp: ditto.
(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):
(WebCore::InputType::handleKeypressEvent):
(WebCore::InputType::handleKeyupEvent):
(WebCore::InputType::handleBeforeTextInsertedEvent):
(WebCore::InputType::handleWheelEvent): Added default implementation.
(WebCore::InputType::forwardEvent): ditto.
(WebCore::InputType::formForSubmission): ditto.
* html/InputType.h:
* html/IsIndexInputType.cpp:
(WebCore::IsIndexInputType::formForSubmission): Moved from HTMLInputElement.cpp.
* html/IsIndexInputType.h:
* html/NumberInputType.cpp:
(WebCore::isNumberCharacter): Moved from HTMLInputElement.cpp.
(WebCore::NumberInputType::handleKeydownEvent): bool->void change.
(WebCore::NumberInputType::handleBeforeTextInsertedEvent): Moved from HTMInputElement.cpp.
(WebCore::NumberInputType::handleWheelEvent): Added. Just calls handleWheelEventForSpinButton().
* html/NumberInputType.h:
* html/RadioInputType.cpp: bool->void changes.
(WebCore::RadioInputType::handleClickEvent):
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):
* html/RadioInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::forwardEvent): Moved from HTMLInputElement.cpp.
* html/RangeInputType.h:
* html/ResetInputType.cpp: bool->void change.
(WebCore::ResetInputType::handleDOMActivateEvent):
* html/ResetInputType.h: ditto.
* html/SubmitInputType.cpp: ditto.
(WebCore::SubmitInputType::handleDOMActivateEvent):
* html/SubmitInputType.h: ditto.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEvent): bool->void change.
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Moved from HTMLInputElement.cpp.
(WebCore::TextFieldInputType::forwardEvent): ditto.
* html/TextFieldInputType.h:
2010-12-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: After scrolling new property value and cancelling, removed property remains active in page style
https://bugs.webkit.org/show_bug.cgi?id=51390
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
2010-12-23 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Adam Barth.
[chromium] Reduce canvas.toDataURL("image/png") run-time costs 300%
https://bugs.webkit.org/show_bug.cgi?id=51455
Chromium uses the libpng compression defaults. Good compression results,
but at much larger run-time cost compared to other browsers. Chrome is 2
times slower than Mozilla 3.6.12 and 3-4 times slower than Safari 5.0.3.
libpng has supported alternative compression methods for some time, they
better meet the dual goals of good compression and run-time cost for the
on-line case, and are well-documented. Here use Huffman encoding. It's
2-20% faster than other encodings (Z_RLE, Z_FILTERED) and the compressed
size is within 1% of the Safari 5.0.3 result independent of image size.
No change in behaviour, so no new tests.
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::PNGImageEncoder::encode): Apply Huffman image encoding.
2010-12-22 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Darin Fisher.
[chromium] Optimize canvas.toDataURL("image/png") unpremultiplication loop
https://bugs.webkit.org/show_bug.cgi?id=51321
Follow on from r73890, unroll the SkUnPreMultiply::PMColorToColor() call for
the "image/png" encoder case viz., compute the unpremultiplication in-place.
See https://bugs.webkit.org/show_bug.cgi?id=50804 for reference.
No new tests: canvas.toDataURL() is covered by existing tests.
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::preMultipliedBGRAtoRGBA):
2010-12-22 Ariya Hidayat <ariya@sencha.com>
Reviewed by Simon Fraser.
Implement skewX() and skewY() for CSSMatrix.
https://bugs.webkit.org/show_bug.cgi?id=38335
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::skew): Implemented skewX() and skewY().
* css/WebKitCSSMatrix.h: Added skewX() and skewY().
* css/WebKitCSSMatrix.idl: Added skewX() and skewY().
2010-12-22 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Support unprefixed box-shadow property
https://bugs.webkit.org/show_bug.cgi?id=51448
Add support for the box-shadow CSS property. We'll currently render this
similarly to -webkit-box-shadow, but a later fix will adjust the blur radius
handling to match the spec.
Test: fast/css/box-shadow.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implement getComputedStyle
for box-shadow
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitValue):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitColor): Support CSSPropertyBoxShadow
* css/CSSPropertyNames.in: add box-shadow
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Add CSSPropertyBoxShadow, and
store in the ShadowData if this is -webkit-box-shadow or not. We'll use this
to adjust radii later.
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty): Add CSSPropertyBoxShadow.
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
(WebCore::PropertyWrapperShadow::blend):
(WebCore::AnimationBase::ensurePropertyMap): Support animations of box-shadow.
* rendering/style/ShadowData.cpp: Store a flag to say if this is a -webkit-box-shadow.
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
* rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::isWebkitBoxShadow):
2010-12-22 Michael Saboff <msaboff@apple.com>
Reviewed by Sam Weinig.
REGRESSION: Can't shadow/overwrite window.constructor
(causes TypeError exception)
https://bugs.webkit.org/show_bug.cgi?id=48953
Added code in the javascript code generator to create a setter for
a constructor if the new extended attribute ReplaceableConstructor
is present for the interface.
* bindings/scripts/CodeGeneratorJS.pm:
* page/DOMWindow.idl:
2010-12-22 Steve Lacey <sjl@chromium.org>
Reviewed by David Levin.
Change css for chromium media controls to deal with the timeline
not expanding when the current time disappears. This happens when
the width of the control drops below 240px.
This change results in a minor pixel difference - the timebar now
aligns better with the time and when the time is not displayed is
now perfectly centered. Disabling the affected tests for now
and will rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=51500
* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
2010-12-22 Mihai Parparita <mihaip@chromium.org>
Reviewed by Simon Fraser.
the shadow direction is negated in canvas context shadowOffsetY.
https://bugs.webkit.org/show_bug.cgi?id=25619
Invert shadow offset Y direction in 0-blur path in FontMac::drawGlyps
if we're not transforming shadows (i.e. are rendering in a canvas). Also
use CG shadows if there's a non-translate/flip transform applied
(shadow offsets are supposed to ignore transforms, but the naive/simple
implementation was taking them into account).
Also does the equivalent changes to FontCGWin.
Test: fast/canvas/fillText-shadow.html
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::shadowsIgnoreTransforms):
* platform/graphics/GraphicsContext.h:
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):
2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74503.
http://trac.webkit.org/changeset/74503
https://bugs.webkit.org/show_bug.cgi?id=51513
breaks chromium mac debug compile (Requested by tonyg-cr on
#webkit).
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
2010-12-22 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Replace runtime checks for hyphenation API availability with compile-time checks.
* platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForNullKey): Changed to use CFLocaleCopyCurrent() instead of using the
search locale, which is empty on Windows. On Mac, this is equivalent to using the search locale.
(WebCore::canHyphenate): Added this implementation for when the hyphenation API is not available.
It is identical to the implementation in Hyphenation.cpp.
(WebCore::lastHyphenLocation): Ditto.
2010-12-22 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Cache snapshots of plug-ins before painting, to avoid script running during painting
https://bugs.webkit.org/show_bug.cgi?id=51493
When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
or when printing), plug-ins which otherwise use the CA rendering model
are sent a paint event. Some plug-ins may run script while handling this event,
or out of process plug-ins may process queued requests at this time. Running
script while inside layout or painting can have bad consequences, because it
can result in arbitrary changes to the render tree.
This patch avoids sending plug-ins paint events inside of painting. Instead,
we ask the plug-ins to cache a snapshot before we paint, and then the software
paint simply draws that snapshot.
Requires manual test, because the bug happens when Safari does
a page snapshot. It's not possible to tell the Test Netscape Plug-in
to paint without laying out, making an automated test impossible.
* manual-tests/plugins/plugin-paint-causes-layout.html: Added.
* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::paintContents): Notify all enclosed widgets
that a flattening paint is going to happen.
(WebCore::FrameView::notifyWidgetsInAllFrames): Utility method
that tells the RenderView in all subframes to notify their widgets.
* platform/Widget.h:
(WebCore::Widget::notifyWidget): Generic method that can be used
to send messages to widgets. Current messages are just 'before flattening paint'
and 'after flattening paint'. Message has no payload.
* rendering/RenderView.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::getRetainedWidgets):
(WebCore::RenderView::releaseWidgets): Factor code out of updateWidgetPositions(),
since we use it in two places now.
(WebCore::RenderView::updateWidgetPositions): Use getRetainedWidgets() etc.
(WebCore::RenderView::notifyWidgets): Retain all the widgets, then send
them all the message.
* rendering/RenderWidget.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::notifyWidget): Pass the message to the widget.
2010-12-22 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Fix null pointer deref when restoring a lost WebGL context.
https://bugs.webkit.org/show_bug.cgi?id=51494
No new tests, as context restored events are not currently testable.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::restoreContext):
2010-12-22 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Martin Robinson.
[GTK] Building with Blob support fails again
https://bugs.webkit.org/show_bug.cgi?id=51392
Build fix.
* GNUmakefile.am:
2010-12-22 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
canHyphenate() always returns true for the default locale
https://bugs.webkit.org/show_bug.cgi?id=51506
No test, since this change only affects performance.
* platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForNullKey): Return 0 if hyphenation is not supported for the default locale.
(WebCore::::createValueForKey): Removed whitespace.
2010-12-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: script name gets parsed as HTML in Call stack panel
https://bugs.webkit.org/show_bug.cgi?id=51468
* inspector/front-end/Placard.js:
(WebInspector.Placard.prototype.set subtitle):
2010-12-22 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
MediaPlayer should look for MIME type in data: URL
https://bugs.webkit.org/show_bug.cgi?id=51195
If no MIME type is passed from the media element for a data: URL, try to get it from
the URL itself.
No new tests are possible because the MIME type is just passed to the media engine.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
2010-12-22 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=51186
No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
2010-12-22 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
WAI-ARIA menubar role mapped to AXGroup, should be AXMenuBar
https://bugs.webkit.org/show_bug.cgi?id=51488
Test: platform/mac/accessibility/aria-menubar.html
* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
2010-12-22 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
https://bugs.webkit.org/show_bug.cgi?id=51423
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D): Remove the isGLES2Compliant flag around format compatibility checking.
(WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat): Helper function to get bound framebuffer's color format; deal with the case of webgl's internal fbo.
* html/canvas/WebGLRenderingContext.h:
2010-12-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Compilation fixes with GTK+ 2.91.7
https://bugs.webkit.org/show_bug.cgi?id=51487
* platform/gtk/GtkVersioning.h: do not define GDK_DISPLAY for
backwards compatibility, it's now defined again in GTK+ 3.x.
* platform/gtk/PasteboardHelper.cpp: do not call GDK functions to
initialize global static variables (!). These are called when the
.so is loaded, and they now require GType to be initialized and
will crash. Initialize them once from the ctor, which is a more
common pattern anyway.
(WebCore::initGdkAtoms): new method to initialize static variables.
(WebCore::PasteboardHelper::PasteboardHelper): call it.
* plugins/gtk/PluginViewGtk.cpp: do not include gdkconfig.h when
using GTK+ 3.x, since it's no longer installed.
2010-12-22 Dirk Schulze <krit@wbekit.org>
Reviewed by Nikolas Zimmermann.
Cleanup SVG code according to the webkit style rules 2
https://bugs.webkit.org/show_bug.cgi?id=51461
Second patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
No changes of functionality, so no new tests.
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::stringToChannel):
* svg/SVGFEDistantLightElement.h:
* svg/SVGFEFuncAElement.h:
* svg/SVGFEFuncBElement.h:
* svg/SVGFEFuncGElement.h:
* svg/SVGFEFuncRElement.h:
* svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::build):
* svg/SVGFEMorphologyElement.cpp:
* svg/SVGFEPointLightElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::findLights):
* svg/SVGFESpotLightElement.h:
* svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseViewBox):
(WebCore::SVGFitToViewBox::isKnownAttribute):
* svg/SVGFontFaceElement.cpp:
(WebCore::cssPropertyIdForSVGAttributeName):
* svg/SVGFontFaceElement.h:
(WebCore::SVGFontFaceElement::associatedFontElement):
* svg/SVGFontFaceNameElement.h:
* svg/SVGFontFaceSrcElement.cpp:
* svg/SVGFontFaceSrcElement.h:
* svg/SVGFontFaceUriElement.h:
* svg/SVGForeignObjectElement.h:
* svg/SVGGlyphElement.cpp:
(WebCore::parseArabicForm):
(WebCore::parseOrientation):
* svg/SVGGlyphElement.h:
(WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
(WebCore::SVGGlyphIdentifier::inheritedValue):
(WebCore::SVGGlyphIdentifier::operator==):
(WebCore::SVGGlyphElement::rendererIsNeeded):
* svg/SVGGlyphMap.h:
(WebCore::GlyphMapNode::GlyphMapNode):
(WebCore::GlyphMapNode::create):
(WebCore::SVGGlyphMap::SVGGlyphMap):
(WebCore::SVGGlyphMap::add):
(WebCore::SVGGlyphMap::compareGlyphPriority):
(WebCore::SVGGlyphMap::get):
(WebCore::SVGGlyphMap::clear):
* svg/SVGGradientElement.cpp:
* svg/SVGHKernElement.cpp:
* svg/SVGHKernElement.h:
(WebCore::SVGHKernElement::rendererIsNeeded):
* svg/SVGImageElement.h:
* svg/SVGImageLoader.cpp:
* svg/SVGImageLoader.h:
* svg/SVGLangSpace.cpp:
(WebCore::SVGLangSpace::parseMappedAttribute):
(WebCore::SVGLangSpace::isKnownAttribute):
* svg/SVGLangSpace.h:
(WebCore::SVGLangSpace::xmllang):
* svg/SVGMetadataElement.h:
* svg/SVGMissingGlyphElement.h:
(WebCore::SVGMissingGlyphElement::rendererIsNeeded):
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::cssText):
* svg/SVGPaint.h:
(WebCore::SVGPaint::create):
(WebCore::SVGPaint::paintType):
(WebCore::SVGPaint::isSVGPaint):
* svg/SVGParserUtilities.cpp:
* svg/SVGParserUtilities.h:
(WebCore::isWhitespace):
(WebCore::skipOptionalSpaces):
(WebCore::skipOptionalSpacesOrDelimiter):
* svg/SVGPathElement.cpp:
* svg/SVGPathParserFactory.h:
* svg/SVGPathSegList.h:
2010-12-22 Chris Fleizach <cfleizach@apple.com>
Reviewed by Sam Weinig.
AX: WAI-ARIA textbox role needs different AXRole, depending on value of aria-multiline property
https://bugs.webkit.org/show_bug.cgi?id=51481
Support aria-multiline and use it to change the role of an ARIA "textbox"
from AXTextArea to AXTextField.
Test: platform/mac/accessibility/aria-multiline.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaIsMultiline):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
* accessibility/AccessibilityRenderObject.h:
* html/HTMLAttributeNames.in:
2010-12-22 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
CSS 2.1 failure: counter-increment-013 fails
https://bugs.webkit.org/show_bug.cgi?id=51483
Clamp the counter-increment property to the valid range of signed
integers.
Test: fast/css/counters/counter-increment-overflow.html
* css/CSSParser.cpp:
(WebCore::clampToSignedInteger):
(WebCore::CSSParser::parseCounter):
2010-12-22 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Mark Rowe.
Changed WebKitTools to Tools in script build phases.
* WebCore.xcodeproj/project.pbxproj:
2010-12-21 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Fixing crash with empty render surfaces.
https://bugs.webkit.org/show_bug.cgi?id=51432
Test: platform/chromium/compositing/empty-render-surface-crasher.html
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::draw):
2010-12-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: persist JavaScript breakpoints in frontend settings.
https://bugs.webkit.org/show_bug.cgi?id=48434
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.idl:
* inspector/InspectorBackend.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::setStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::restoreBreakpoint):
(WebCore::InspectorDebuggerAgent::clearForPageNavigation):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.remove):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.DOMBreakpoint.prototype._serializeToJSON):
(WebInspector.JavaScriptBreakpoint):
(WebInspector.XHRBreakpoint.prototype._serializeToJSON):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
* inspector/front-end/SourceFrame.js:
2010-12-20 Antti Koivisto <antti@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=51354
Don't block rendering and script execution on deferred stylesheets
- Don't add low priority stylesheets to the document pending sheet count.
- Resolve media attribute fully for the link element stylesheet load.
Test: http/tests/local/stylesheet-and-script-load-order-media-print.html
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::sheetLoaded):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
* html/HTMLLinkElement.h:
2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74473.
http://trac.webkit.org/changeset/74473
https://bugs.webkit.org/show_bug.cgi?id=51463
broke compilation on leopard intel release (Requested by
podivilov on #webkit).
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.idl:
* inspector/InspectorBackend.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::setStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
(WebCore::InspectorController::breakpointsSettingKey):
(WebCore::InspectorController::loadBreakpoints):
(WebCore::InspectorController::saveBreakpoints):
* inspector/InspectorController.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::formatBreakpointId):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::clearForPageNavigation):
(WebCore::InspectorDebuggerAgent::md5Base16):
(WebCore::InspectorDebuggerAgent::loadBreakpoints):
(WebCore::InspectorDebuggerAgent::saveBreakpoints):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.jsBreakpointId):
(WebInspector.Breakpoint.prototype.set enabled):
(WebInspector.Breakpoint.prototype.get id):
(WebInspector.Breakpoint.prototype.set condition):
(WebInspector.Breakpoint.prototype.remove):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._createDOMBreakpoint):
(WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint):
(WebInspector.BreakpointManager.prototype._createXHRBreakpoint):
(WebInspector.BreakpointManager.prototype._setNativeBreakpoint):
(WebInspector.BreakpointManager.prototype._setNativeBreakpointEnabled):
(WebInspector.BreakpointManager.prototype._removeNativeBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
(WebInspector.BreakpointManager.prototype._validateBreakpoints):
(WebInspector.DOMBreakpoint.prototype._serializeToJSON):
(WebInspector.EventListenerBreakpoint.prototype._serializeToJSON):
(WebInspector.XHRBreakpoint.prototype._serializeToJSON):
(WebInspector.NativeBreakpointView.prototype.set enabled):
(WebInspector.NativeBreakpointView.prototype.remove):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.setOneTimeBreakpoint):
(WebInspector.DebuggerModel.prototype.removeOneTimeBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.findBreakpoint):
(WebInspector.DebuggerModel.prototype.reset):
(WebInspector.DebuggerModel.prototype._setBreakpoint):
(WebInspector.DebuggerModel.prototype._breakpointRemoved):
(WebInspector.DebuggerModel.prototype._setBreakpointOnBackend):
(WebInspector.DebuggerModel.prototype.breakpointRestored):
(WebInspector.DebuggerModel.prototype.pausedScript):
(WebInspector.DebuggerModel.prototype.resumedScript):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.continueToLine):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrame.prototype._continueToLine):
(WebInspector.SourceFrame.prototype._setBreakpoint):
2010-12-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: persist JavaScript breakpoints in frontend settings.
https://bugs.webkit.org/show_bug.cgi?id=48434
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.idl:
* inspector/InspectorBackend.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::setStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::restoreBreakpoint):
(WebCore::InspectorDebuggerAgent::clearForPageNavigation):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.remove):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.DOMBreakpoint.prototype._serializeToJSON):
(WebInspector.JavaScriptBreakpoint):
(WebInspector.XHRBreakpoint.prototype._serializeToJSON):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
* inspector/front-end/SourceFrame.js:
2010-12-22 Dirk Schulze <krit@wbekit.org>
Reviewed by Nikolas Zimmermann.
Cleanup SVG code according to the webkit style rules 1
https://bugs.webkit.org/show_bug.cgi?id=51411
First patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
No change of functionality.
* svg/ColorDistance.cpp:
(WebCore::ColorDistance::isZero):
* svg/ColorDistance.h:
* svg/ElementTimeControl.h:
(WebCore::ElementTimeControl::~ElementTimeControl):
* svg/LinearGradientAttributes.h:
(WebCore::LinearGradientAttributes::LinearGradientAttributes):
(WebCore::LinearGradientAttributes::x1):
(WebCore::LinearGradientAttributes::y1):
(WebCore::LinearGradientAttributes::x2):
(WebCore::LinearGradientAttributes::y2):
(WebCore::LinearGradientAttributes::setX1):
(WebCore::LinearGradientAttributes::setY1):
(WebCore::LinearGradientAttributes::setX2):
(WebCore::LinearGradientAttributes::setY2):
(WebCore::LinearGradientAttributes::hasX1):
(WebCore::LinearGradientAttributes::hasY1):
(WebCore::LinearGradientAttributes::hasX2):
(WebCore::LinearGradientAttributes::hasY2):
* svg/RadialGradientAttributes.h:
(WebCore::RadialGradientAttributes::RadialGradientAttributes):
(WebCore::RadialGradientAttributes::cx):
(WebCore::RadialGradientAttributes::cy):
(WebCore::RadialGradientAttributes::r):
(WebCore::RadialGradientAttributes::fx):
(WebCore::RadialGradientAttributes::fy):
(WebCore::RadialGradientAttributes::setCx):
(WebCore::RadialGradientAttributes::setCy):
(WebCore::RadialGradientAttributes::setR):
(WebCore::RadialGradientAttributes::setFx):
(WebCore::RadialGradientAttributes::setFy):
(WebCore::RadialGradientAttributes::hasCx):
(WebCore::RadialGradientAttributes::hasCy):
(WebCore::RadialGradientAttributes::hasR):
(WebCore::RadialGradientAttributes::hasFx):
(WebCore::RadialGradientAttributes::hasFy):
* svg/SVGAngle.cpp:
* svg/SVGAnimateColorElement.h:
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateDistance):
* svg/SVGAnimateElement.h:
* svg/SVGAnimateMotionElement.cpp:
* svg/SVGAnimateMotionElement.h:
* svg/SVGAnimatedNumber.h:
* svg/SVGAnimationElement.cpp:
(WebCore::parseKeyTimes):
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::updateAnimation):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::svgAttributeChanged):
* svg/SVGColor.h:
(WebCore::SVGColor::create):
(WebCore::SVGColor::createCurrentColor):
(WebCore::SVGColor::colorType):
(WebCore::SVGColor::setRGBColor):
(WebCore::SVGColor::color):
(WebCore::SVGColor::isSVGColor):
* svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::svgAttributeChanged):
* svg/SVGCursorElement.h:
* svg/SVGDescElement.h:
(WebCore::SVGDescElement::rendererIsNeeded):
* svg/SVGDocument.cpp:
* svg/SVGDocument.h:
(WebCore::SVGDocument::create):
(WebCore::SVGDocument::isSVGDocument):
* svg/SVGElement.h:
(WebCore::SVGElement::isStyled):
(WebCore::SVGElement::isStyledTransformable):
(WebCore::SVGElement::isStyledLocatable):
(WebCore::SVGElement::isSVG):
(WebCore::SVGElement::isFilterEffect):
(WebCore::SVGElement::isGradientStop):
(WebCore::SVGElement::isTextContent):
(WebCore::SVGElement::isValid):
(WebCore::SVGElement::svgAttributeChanged):
(WebCore::SVGElement::synchronizeProperty):
(WebCore::SVGElement::supplementalTransform):
(WebCore::SVGElement::invalidateSVGAttributes):
(WebCore::SVGElement::rendererIsNeeded):
(WebCore::SVGElement::needsPendingResourceHandling):
(WebCore::SVGElement::buildPendingResource):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::create):
(WebCore::SVGElementInstance::correspondingElement):
(WebCore::SVGElementInstance::correspondingUseElement):
(WebCore::SVGElementInstance::shadowTreeElement):
(WebCore::SVGElementInstance::parentNode):
(WebCore::SVGElementInstance::previousSibling):
(WebCore::SVGElementInstance::nextSibling):
(WebCore::SVGElementInstance::firstChild):
(WebCore::SVGElementInstance::lastChild):
(WebCore::SVGElementInstance::ownerDocument):
(WebCore::SVGElementInstance::toNode):
(WebCore::SVGElementInstance::toSVGElementInstance):
(WebCore::SVGElementInstance::hasChildNodes):
(WebCore::SVGElementInstance::setFirstChild):
(WebCore::SVGElementInstance::setLastChild):
(WebCore::SVGElementInstance::setNextSibling):
(WebCore::SVGElementInstance::setPreviousSibling):
(WebCore::SVGElementInstance::refEventTarget):
(WebCore::SVGElementInstance::derefEventTarget):
* svg/SVGElementInstanceList.h:
(WebCore::SVGElementInstanceList::create):
* svg/SVGException.h:
(WebCore::SVGException::create):
(WebCore::SVGException::SVGException):
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::findLights):
* svg/SVGFont.cpp:
(WebCore::convertEmUnitToPixel):
* svg/SVGUseElement.cpp:
(WebCore::isDirectReference):
2010-12-22 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=51289
Initial state of checkValidity() and :invalid are incorrect with <select required>
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged): setNeedsValidityCheck() after <select>'s children change.
2010-12-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Styles pane fails to display properties from a broken CSS rule correctly
https://bugs.webkit.org/show_bug.cgi?id=51405
Invoke markPropertyStart() after the parser has restored after an error.
* css/CSSGrammar.y:
2010-12-22 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Assertion failure with <select multiple required>
https://bugs.webkit.org/show_bug.cgi?id=51260
Test: fast/css/pseudo-valid-select-click.html
* dom/SelectElement.cpp: updateValidity() after selecting some options of ListBox-typed <select> elements to update valid() cache.
(WebCore::SelectElement::updateListBoxSelection):
2010-12-21 Darin Adler <darin@apple.com>
Unreviewed correction to unreviewed build fix for r74447.
Inappropriate code was left behind in sourceURI function for non-Dashboard platforms.
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::sourceURI): Change the logic so all the bug-workaround
logic is inside the #ifdef.
2010-12-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Include the shadow color space as part of the GraphicsContext state
https://bugs.webkit.org/show_bug.cgi?id=51420
Include the ColorSpace for the shadow color as part of the graphics
state. This will be used later for a shadow implementation that
does not rely on platform shadow code.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setShadow):
(WebCore::GraphicsContext::clearShadow):
(WebCore::GraphicsContext::getShadow):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::Font::drawComplexText):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleDrawTextShadow):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
(WebCore::Font::drawGlyphs):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::drawText):
2010-12-21 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8668230> REGRESSION (r71884): Returning alternate requests from willSendRequest can prevent other requests from ever being sent
https://bugs.webkit.org/show_bug.cgi?id=51413
71884 was wrong in moving willSendRequest to ResourceLoader::start(). It’s wrong to do all the
scheduling, which is host-dependent, before calling willSendRequest, because the latter can
change the host.
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::create): Check the return value from ResourceLoader::init()
and return 0 if it is false.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init): Made this function return a boolean. Moved the call to willSendRequest()
from start() into here. Return false if willSendRequest() canceled the request.
(WebCore::ResourceLoader::start): Moved the call to willSendRequest() from here to init().
* loader/ResourceLoader.h:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create): Check the return value from ResourceLoader::init()
and return 0 if it is false.
2010-12-21 Benjamin Kalman <kalman@chromium.org>
Reviewed by Darin Adler.
Shift-End does not select to the end of the line
https://bugs.webkit.org/show_bug.cgi?id=50610
Let the VisiblePosition affinity for end of line selection to be set by
visibleEnd/visibleStart rather than using end/start and always using UPSTREAM.
Test: editing/selection/extend-to-line-boundary.html
* editing/SelectionController.cpp:
(WebCore::SelectionController::positionForPlatform): Use visibleStart/visibleEnd rather than
start/end.
(WebCore::SelectionController::modifyExtendingForward): Don't explicitly use UPSTREAM affinity.
2010-12-21 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Simon Fraser.
matrix3d() must take the zoom factor into account
https://bugs.webkit.org/show_bug.cgi?id=51408
Test: transforms/3d/general/matrix-with-zoom-3d.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createTransformOperations):
2010-12-21 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Move V8 to common implementation of window.open
https://bugs.webkit.org/show_bug.cgi?id=51385
I also changed some function names to match WebKit style. There's a
bunch of code we can remove in the generic bindings now. I'll do that
in the next patch.
* bindings/generic/BindingDOMWindow.h:
(WebCore::::open):
* bindings/generic/BindingFrame.h:
(WebCore::::navigateIfAllowed):
* bindings/generic/BindingSecurity.h:
(WebCore::::canAccessWindow):
(WebCore::::allowPopUp):
(WebCore::::shouldAllowNavigation):
* bindings/generic/GenericBinding.h:
(WebCore::completeURL):
* bindings/js/JSDOMBinding.cpp:
(WebCore::toLexicalFrame):
(WebCore::toDynamicFrame):
* bindings/js/specialization/JSBindingState.cpp:
(WebCore::::activeFrame):
(WebCore::::firstFrame):
* bindings/js/specialization/JSBindingState.h:
* bindings/v8/V8Utilities.cpp:
(WebCore::callingOrEnteredFrame):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::locationAccessorSetter):
(WebCore::V8DOMWindow::openCallback):
* bindings/v8/specialization/V8BindingState.cpp:
(WebCore::::activeWindow):
(WebCore::::firstWindow):
(WebCore::::activeFrame):
(WebCore::::firstFrame):
* bindings/v8/specialization/V8BindingState.h:
2010-12-21 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix for r74447.
Call usesDashboardBackwardCompatibilityMode() only if DASHBOARD_SUPPORT is enabled.
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::sourceURI):
2010-12-21 Dan Bernstein <mitz@apple.com>
Reviewed by John Sullivan.
<rdar://problem/8725702> REGRESSION (r68854): Broken image icon seen in the Address Book Dashboard widget
Test: platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html
The Address Book widget sets the src attribute of an img element to a string that looks like a CSS
URL value. This used to work prior to r68854, because some DOM attribute parsing functions were using
the wrong function to parse URL attributes (last named deprecatedParseURL).
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::sourceURI): In Dashboard, check if the src attribute begins with 'url("'
and ends with '")', and if so, strip those away.
2010-12-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
CharacterData needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=51426
Extracted CharacterData::setDataAndNotify and CharacterData::updateRenderer.
* dom/CharacterData.cpp:
(WebCore::CharacterData::setData): Calls setDataAndUpdate.
(WebCore::CharacterData::parserAppendData): Ditto.
(WebCore::CharacterData::appendData): Ditto.
(WebCore::CharacterData::insertData): Ditto.
(WebCore::CharacterData::deleteData): Ditto.
(WebCore::CharacterData::replaceData): Ditto.
(WebCore::CharacterData::setDataAndUpdate): Added.
(WebCore::CharacterData::updateRenderer): Added.
(WebCore::CharacterData::dispatchModifiedEvent): Renamed prevValue to oldData.
* dom/CharacterData.h:
2010-12-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74420.
http://trac.webkit.org/changeset/74420
https://bugs.webkit.org/show_bug.cgi?id=51436
causes editing/pasteboard/paste-noscript-xhtml.xhtml to crash
(Requested by tonyg-cr on #webkit).
* dom/DocumentParser.cpp:
* dom/DocumentParser.h:
* html/parser/HTMLDocumentParser.cpp:
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::HTMLParserScheduler):
* html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::isScheduledForResume):
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2010-12-21 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Enable extensions used in accelerated 2D canvas implementation
https://bugs.webkit.org/show_bug.cgi?id=51433
Call Extensions3D::ensureEnabled() for all supported extensions
the accelerated 2D Canvas implementation uses. Tested with a few
layout tests previously failing when run in Chromium due to OpenGL
INVALID_ENUM and other errors.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::create):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
(WebCore::SharedGraphicsContext3D::supportsBGRA):
* platform/graphics/gpu/SharedGraphicsContext3D.h:
2010-12-21 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355
Test: fast/canvas/webgl/uninitialized-test.html
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::onAccess): Use a parameter to decide if renderbuffer initialization is needed.
(WebCore::WebGLFramebuffer::initializeRenderbuffers): Don't return false if color buffer doesn't exist.
* html/canvas/WebGLFramebuffer.h: Modify onAccess with an added parameter.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::clear): Call onAccess with an added parameter.
(WebCore::WebGLRenderingContext::copyTexImage2D): Ditto.
(WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::drawArrays): Ditto.
(WebCore::WebGLRenderingContext::drawElements): Ditto.
(WebCore::WebGLRenderingContext::readPixels): Ditto.
(WebCore::WebGLRenderingContext::texImage2DBase): Create buffer data of 0s if input is null to initialize textures.
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe): Helper function that initialize all pixels to 0.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateContentsIfDirty): Use texImage2DResourceSafe.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::generateColorTexture): Ditto.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::prepareToDrawLayers): Ditto.
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::requestTexture): Ditto.
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::allocateTexture): Ditto.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset): Use texImage2DResourceSafe; also, only initialize depth/stencil buffer.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::texImage2D): Use texImage2DResourceSafe.
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::create): Ditto.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D): Generate an INVALID_VALUE if pixels==null is passed in.
2010-12-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioBusChromium for decoding audio file data
https://bugs.webkit.org/show_bug.cgi?id=51430
No new tests since audio API is not yet implemented.
* platform/audio/chromium: Added.
* platform/audio/chromium/AudioBusChromium.cpp: Added.
(WebCore::createBusFromInMemoryAudioFile):
2010-12-21 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add web audio spatialization resource files
https://bugs.webkit.org/show_bug.cgi?id=50998
No new tests since audio API is not yet implemented.
* platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
* platform/audio/mac/AudioBusMac.mm:
(WebCore::AudioBus::loadPlatformResource):
* platform/audio/resources: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T000_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T015_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T030_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T045_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T060_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T075_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T090_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T105_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T120_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T135_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T150_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T165_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T180_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T195_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T210_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T225_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T240_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T255_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T270_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T285_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T300_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T315_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T330_P345.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P000.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P015.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P030.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P045.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P060.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P075.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P090.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P315.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P330.wav: Added.
* platform/audio/resources/IRC_Composite_C_R0195_T345_P345.wav: Added.
2010-12-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough & Oliver Hunt.
Added PageAllocationAligned, a cross-platform abstraction for memory allocations with arbitrary alignment requirements
https://bugs.webkit.org/show_bug.cgi?id=51359
* ForwardingHeaders/wtf/PageAllocationAligned.h: Added.
2010-12-21 Ariya Hidayat <ariya@sencha.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=49774
Need to scale translation values in matrix() by the zoom factor.
Test: fast/transforms/matrix-with-zoom.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createTransformOperations):
2010-12-21 Jian Li <jianli@chromium.org>
Reviewed by Darin Adler.
Fix bug 51366: REGRESSION (r66452): Form data no longer contains
'Content-Type' header for files with unrecognized extensions
https://bugs.webkit.org/show_bug.cgi?id=51366
Test: http/tests/local/formdata/form-data-with-unknown-file-extension.html
* platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems):
2010-12-21 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Mac WebKit delivers an extra didCommit when loading web archives
https://bugs.webkit.org/show_bug.cgi?id=51419
Could not find a simple way to test this in WebKit1, but in WebKit2
it leads to an immediate failure when loading a web archive. Tested
that making the Mac share the same code path with other platforms
works fine in WebKit1.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedLoadingDocument): Removed special case for
the Mac platform. Also removed the call to isArchiveMimeType since we
get a 0 from ArchiveFactory::create in that case.
* loader/archive/ArchiveFactory.cpp:
(WebCore::ArchiveFactory::isArchiveMimeType): Hardened slightly by
adding a special case for null and empty strings, since hash tables can't
handle null strings.
(WebCore::ArchiveFactory::create): Ditto.
2010-12-21 Yong Li <yoli@rim.com>
Reviewed by Adam Barth.
Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.
https://bugs.webkit.org/show_bug.cgi?id=48077
Test case: WebCore/manual-tests/bugzilla-48077.html.
* dom/DocumentParser.cpp:
(WebCore::DocumentParser::suspendParsing):
(WebCore::DocumentParser::resumeParsing):
* dom/DocumentParser.h:
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::suspendParsing):
(WebCore::HTMLDocumentParser::resumeParsing):
* html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::suspend):
(WebCore::HTMLParserScheduler::resume):
* html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::isScheduledForResume):
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2010-12-21 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
Clicking missing plug-in text does not show a sheet
https://bugs.webkit.org/show_bug.cgi?id=51403
* WebCore.exp.in:
Export symbols needed by WebKit2.
* WebCore.xcodeproj/project.pbxproj:
Make HTMLPlugInImageElement.h a private header.
* html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::serviceType):
(WebCore::HTMLPlugInImageElement::url):
Make these member functions public.
2010-12-21 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Fix the build with USE_GSTREAMER=1
No new tests needed.
* WebCore.pro: remove nonexisting DataSourceGStreamer sources.
2010-12-21 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Andreas Kling.
[Qt] QtWebKit doesn't build in debug on Windows
https://bugs.webkit.org/show_bug.cgi?id=41930
Disable incremental linking in windows 32bit debug version as webkit is so
big it fails to link incremental.
Build fix. No new test cases added.
* WebCore.pro:
2010-12-21 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
Rename Node::isShadowNode to isShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=51060
The method gets whether the node is the root of a shadow tree;
renamed to reflect intent.
A simple rename--no new tests needed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
* dom/Node.cpp:
(WebCore::Node::shadowTreeRootNode):
(WebCore::Node::isInShadowTree):
(WebCore::eventTargetRespectingSVGTargetRules):
(WebCore::Node::getEventAncestors):
* dom/Node.h:
(WebCore::Node::isShadowRoot):
* dom/Range.cpp:
(WebCore::Range::checkNodeBA):
* page/DragController.cpp:
(WebCore::asFileInput):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::dispatchMouseEvent):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasLineIfEmpty):
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::attachInnerElement):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title):
* svg/SVGUseElement.cpp:
(WebCore::ShadowTreeUpdateBlocker::while):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedIntoDocument):
2010-12-20 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Andreas Kling.
Qt port of geolocation, geoposition objects timestamp was in seconds
instead of miliseconds as per HTML5 Geolocation standards.
Ref: http://dev.w3.org/geo/api/spec-source.html#position_interface
http://www.w3.org/TR/DOM-Level-3-Core/core.html#Core-DOMTimeStamp
Implemented by Asheesh Srivastava.
[QT] QtWebkit geolocation's position.timestamp is not in miliseconds
https://bugs.webkit.org/show_bug.cgi?id=51100
Porting code not covered in layout testing. No new tests added.
* platform/qt/GeolocationServiceQt.cpp:
(WebCore::GeolocationServiceQt::positionUpdated):
2010-12-20 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
Fix for Bug 26183 - [@font-face] font-family descriptor with multiple names should be discarded
https://bugs.webkit.org/show_bug.cgi?id=26183
Test: fast/css/font-face-font-family-descriptor.html
* css/CSSParser.cpp:
(WebCore::CSSParser::createFontFaceRule): Consider @font-face rule
invalid if its font-family descriptor has multiple (or zero) families.
2010-12-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: fall back to object formatting in case dom is not yet loaded.
https://bugs.webkit.org/show_bug.cgi?id=44273
Sometimes DOM is loaded after the inline message is being formatted, so we get
no nodeId for it. Let us fall back to object formatting in such cases.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._formatnode):
(WebInspector.ConsoleMessage):
2010-12-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: cycle through tag name / attributes / new attribute on Tab.
https://bugs.webkit.org/show_bug.cgi?id=38429
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):
2010-12-20 Yuta Kitamura <yutak@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket errors should be logged to console
https://bugs.webkit.org/show_bug.cgi?id=40945
Test: http/tests/inspector/console-websocket-error.html
* platform/network/SocketStreamErrorBase.cpp:
(WebCore::SocketStreamErrorBase::compare):
* platform/network/SocketStreamErrorBase.h:
(WebCore::SocketStreamErrorBase::failingURL):
(WebCore::SocketStreamErrorBase::localizedDescription):
(WebCore::SocketStreamErrorBase::SocketStreamErrorBase):
* platform/network/cf/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
* platform/network/cf/SocketStreamHandle.h:
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didFail):
2010-12-17 MORITA Hajime <morrita@google.com>
Reviewed by James Robinson.
https://bugs.webkit.org/show_bug.cgi?id=51240
[Chromium][Skia] Border with a color with alpha != 1 breaks webkit gradient on skia.
Even after a shader was set, old color value had been remaining and passed to Skia.
Then Skia refered an alpha component of that color to make pixels transparent.
This change invalidates existing color value when a shader is given,
which means the renderer will paint shapes with gradients or patterns.
Test: fast/gradients/gradient-after-transparent-border.html
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setStrokeShader):
(WebCore::PlatformContextSkia::setFillShader):
2010-12-20 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix move left/right by character hang.
https://bugs.webkit.org/show_bug.cgi?id=51344
Test: editing/selection/51344.html
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
2010-12-20 Steve Lacey <sjl@chromium.org>
Reviewed by David Levin.
Add missing default styles in mediaControlsChromium.css to prevent
user overrides.
https://bugs.webkit.org/show_bug.cgi?id=51360
No new tests needed as functionality is covered by existing layout
tests.
* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
2010-12-20 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Add lastModifiedDate attribute to File interface per File API spec
https://bugs.webkit.org/show_bug.cgi?id=49895
lastModifiedDate is not supported for GObject bindings because Date is
not support in code generation.
Test: http/tests/local/fileapi/file-last-modified.html
* fileapi/File.cpp:
(WebCore::File::lastModifiedDate):
* fileapi/File.h:
* fileapi/File.idl:
2010-12-20 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/8757601> Don't install header files in to the Resources directory.
* WebCore.xcodeproj/project.pbxproj:
2010-12-20 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
https://bugs.webkit.org/show_bug.cgi?id=51338
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Reader::readUint32):
2010-12-20 Beth Dakin <bdakin@apple.com>
Reviewed by Ada Chan.
Fix for https://bugs.webkit.org/show_bug.cgi?id=51355 Crash in
RenderMathMLSubSup::layout() because of null base
-and corresponding-
<rdar://problem/8712200>
Only use base inside if(base) block.
* mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):
2010-12-20 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
Crash at WebCore::SplitElementCommand::SplitElementCommand
https://bugs.webkit.org/show_bug.cgi?id=51278
<rdar://problem/7347139>
Executing outdent command on an inline blockquote that is
not the first element in a block causes a crash.
The fix consists in chaging the was the start of block is
calculated in case of the inline blockquote.
Test: editing/execCommand/outdent-inline-blockquote.html
editing/execCommand/outdent-inline-list.html
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph):
2010-12-20 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Need to support serialisation of cyclic graphs in the internal structured cloning algorithm
https://bugs.webkit.org/show_bug.cgi?id=51353
The Internal Structured Clone algorithm has been changed to allow (and
correctly clone) cyclic graphs. This patch updates our implementation
to provide that functionality.
I've bumped the serialization version number, and added ObjectReferenceTag
to represent references to objects that have already been seen.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::startObjectInternal):
Now that we have something a bit more complex than cycle checking
I've replaced the duplicate code in startObject and startArray with
a shared function that implements that logic to plant an object
reference
(WebCore::CloneSerializer::startObject):
(WebCore::CloneSerializer::startArray):
Lift out duplicate code
(WebCore::CloneSerializer::endObject):
Can't remove objects from the gcbuffer now as they need to remain live
so we can identify graphs
(WebCore::CloneSerializer::writeStringIndex):
(WebCore::CloneSerializer::writeObjectIndex):
(WebCore::CloneSerializer::writeConstantPoolIndex):
(WebCore::CloneSerializer::write):
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::readStringIndex):
(WebCore::CloneDeserializer::readConstantPoolIndex):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::CloneDeserializer::deserialize):
2010-12-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
* GNUmakefile.am: add missing files.
2010-12-20 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
Pass the correct beforeChild value when adding a child to an anonymous table part.
https://bugs.webkit.org/show_bug.cgi?id=50932
When a "before" content child was added to an anonymous table part, it was added
after the last child. This patch fixes the behavior by adding it properly before
the first child.
Test: fast/css-generated-content/table-before-child-add.html
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
2010-12-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Bug 26276 - Need a mechanism to determine stack extent
Add forwarding header for StackBounds.h.
* ForwardingHeaders/wtf/StackBounds.h: Added.
2010-12-20 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r74278.
http://trac.webkit.org/changeset/74278
https://bugs.webkit.org/show_bug.cgi?id=50833
[chromium] Causes many layout tests to crash
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::prepareToDrawLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/LayerRendererChromium.h:
2010-12-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Factored common page set management into a new PageBlock base class
https://bugs.webkit.org/show_bug.cgi?id=51285
* ForwardingHeaders/wtf/PageBlock.h: Added.
2010-12-20 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
GeolocationPositionCache should do database access on background thread
https://bugs.webkit.org/show_bug.cgi?id=50825
Covered by existing Geolocation tests.
* page/Coordinates.h:
(WebCore::Coordinates::threadSafeCopy):
* page/GeolocationPositionCache.cpp:
(WebCore::GeolocationPositionCache::GeolocationPositionCache):
(WebCore::GeolocationPositionCache::addUser):
(WebCore::GeolocationPositionCache::removeUser):
(WebCore::GeolocationPositionCache::setDatabasePath):
(WebCore::GeolocationPositionCache::setCachedPosition):
(WebCore::GeolocationPositionCache::cachedPosition):
(WebCore::GeolocationPositionCache::startBackgroundThread):
(WebCore::GeolocationPositionCache::threadEntryPoint):
(WebCore::GeolocationPositionCache::threadEntryPointImpl):
(WebCore::GeolocationPositionCache::triggerReadFromDatabase):
(WebCore::GeolocationPositionCache::readFromDatabase):
(WebCore::GeolocationPositionCache::readFromDatabaseImpl):
(WebCore::GeolocationPositionCache::triggerWriteToDatabase):
(WebCore::GeolocationPositionCache::writeToDatabase):
(WebCore::GeolocationPositionCache::writeToDatabaseImpl):
* page/GeolocationPositionCache.h:
* page/Geoposition.h:
(WebCore::Geoposition::threadSafeCopy):
(WebCore::Geoposition::Geoposition):
2010-12-20 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt][V8] Add missing sources to the pro file and remove duplications to fix linking.
No new tests needed.
* WebCore.pro:
2010-12-20 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Make CSSCompletions a real class rather than singleton
https://bugs.webkit.org/show_bug.cgi?id=51332
Drive-by: make use of keywords from re2js in the CSS tokenizer
(apparently, various authors have presumed that re2js is processed at build time).
No new tests, as this is a refactoring.
* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions):
(WebInspector.CSSCompletions.prototype.startsWith):
(WebInspector.CSSCompletions.prototype.firstStartsWith):
(WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
(WebInspector.CSSCompletions.prototype.keySet):
(WebInspector.CSSCompletions.prototype.next):
(WebInspector.CSSCompletions.prototype.previous):
(WebInspector.CSSCompletions.prototype._closest):
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer):
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone.propertyNamesCallback):
(WebInspector.doLoadedDone):
2010-12-10 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: "Add conditional breakpoint" - create breakpoint only after condition is provided.
https://bugs.webkit.org/show_bug.cgi?id=50813
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._addBreakpoint):
(WebInspector.SourceFrame.prototype._breakpointRemoved):
(WebInspector.SourceFrame.prototype._breakpointChanged):
(WebInspector.SourceFrame.prototype._setBreakpointDecoration):
(WebInspector.SourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype._continueToLine):
(WebInspector.SourceFrame.prototype._setBreakpoint):
2010-12-20 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBTransactionBackedImpl instances can be accidentally deleted during calls to abort/commit.
https://bugs.webkit.org/show_bug.cgi?id=51112
Makes IDBTransactionBackendImpl objects take a self reference while executing commit and abort.
Test: storage/indexeddb/transaction-crash-on-abort.html
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
2010-12-20 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBCursor::delete is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=51110
Implement IDBCursor::delete.
See http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-delete
Tests: storage/indexeddb/cursor-delete.html
storage/indexeddb/cursor-index-delete.html
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::deleteFunction):
* storage/IDBCursor.h:
* storage/IDBCursor.idl:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::deleteFunction):
(WebCore::IDBCursorBackendImpl::loadCurrentRow):
* storage/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
* storage/IDBCursorBackendInterface.h:
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
* storage/IDBKey.cpp:
(WebCore::IDBKey::fromQuery):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
2010-12-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: After a multiline command execution Console does not show the command prompt
https://bugs.webkit.org/show_bug.cgi?id=51257
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._moveBackInHistory):
(WebInspector.TextPrompt.prototype._moveForwardInHistory):
2010-12-19 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Blur distance should not be affected by transformations
https://bugs.webkit.org/show_bug.cgi?id=51161
From the spec at http://dev.w3.org/html5/2dcontext/#dom-context-2d-shadowblur:
"The shadowBlur attribute specifies the level of the blurring effect.
(The units do not map to coordinate space units, and are not affected
by the current transformation matrix.)"
Test: fast/canvas/canvas-scale-shadowBlur.html
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::adjustBlurDistance):
* platform/graphics/ContextShadow.h:
* platform/graphics/cairo/ContextShadowCairo.cpp:
(WebCore::ContextShadow::beginShadowLayer):
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ContextShadow::beginShadowLayer):
2010-12-19 Dan Bernstein <mitz@apple.com>
Reviewed by Cameron Zwarich.
Text emphasis marks are not repainted correctly in flipped writing modes
https://bugs.webkit.org/show_bug.cgi?id=51307
Tests: fast/repaint/text-emphasis-h.html
fast/repaint/text-emphasis-v.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added flippedness check.
2010-12-19 Rob Buis <rwlbuis@gmail.com>
Reviewed by Andreas Kling.
Remove m_drawsContents from RenderSVGContainer.h
https://bugs.webkit.org/show_bug.cgi?id=51305
Remove m_drawsContents, its getter and setter and the call
sites, since it has no effect anymore.
* WebCore.order:
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::RenderSVGContainer):
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGContainer.h:
* rendering/RenderSVGResourceContainer.h:
* rendering/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
2010-12-19 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
WebKit does not build with worker but without the javascript debugger
https://bugs.webkit.org/show_bug.cgi?id=51293
Add missing guard for calls depending on the debugger.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::postWorkerNotificationToFrontend):
2010-12-18 Tom Sepez <tsepez@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=51055
Fix a null de-reference when an XML file contains a malformed entity
of the form "&:;".
Test: fast/parser/xml-colon-entity.html
* html/parser/HTMLEntitySearch.cpp:
(WebCore::HTMLEntitySearch::advance):
2010-12-18 Noel Gordon <noel.gordon@gmail.com>
Reviewed by David Levin.
[chromium] Simplify the PNG encoder.
https://bugs.webkit.org/show_bug.cgi?id=50905
Remove PNGEncoderState class - it was a proxy for the encoder output, and
that is a Vector<>, so just write into it directly using append() to make
use of Vector<>'s resize() smarts. Simplify the preMultipliedBGRAtoRGBA()
and encode() routines, replace the OwnArrayPtr<> with a Vector<>.
canvas.toDataURL("image/png") is covered by existing tests.
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::writeOutput): Use a Vector<>, append() the encoded data to it.
(WebCore::preMultipliedBGRAtoRGBA): simplified.
(WebCore::PNGImageEncoder::encode): ditto.
2010-12-18 Dan Bernstein <mitz@apple.com>
Reviewed by Cameron Zwarich.
Text emphasis marks are not always included in the selection highlight
https://bugs.webkit.org/show_bug.cgi?id=51299
Affects pixel results of fast/text/emphasis.html
Account for annotations in selectionTop() and selectionBottom().
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):
2010-12-18 Dan Bernstein <mitz@apple.com>
Reviewed by Cameron Zwarich.
In flipped writing modes, opposite text emphasis marks from adjacent lines overlap
https://bugs.webkit.org/show_bug.cgi?id=51298
Test: fast/text/emphasis-overlap.html
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::beforeAnnotationsAdjustment): Changed + to -.
2010-12-18 Helder Correia <helder@sencha.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Ariya Hidayat.
[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422
On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows
"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."
NOTE: this applies only to canvas, not to box shadows.
Test: fast/canvas/canvas-transforms-fillRect-shadow.html
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::ContextShadow):
(WebCore::ContextShadow::calculateLayerBoundingRect):
* platform/graphics/ContextShadow.h:
(WebCore::ContextShadow::setShadowsIgnoreTransforms):
(WebCore::ContextShadow::shadowsIgnoreTransforms):
(WebCore::ContextShadow::offset):
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::mustUseContextShadow):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformShadow):
2010-12-18 Ariya Hidayat <ariya@sencha.com>
Reviewed by Andreas Kling.
[Qt] TransparencyLayer should inherit its container render hints
https://bugs.webkit.org/show_bug.cgi?id=51283
* platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer):
2010-12-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Laszlo Gombos.
[Web Timing] Rename domContentLoaded{Start,End}->domContentLoadedEvent{Start,End}
https://bugs.webkit.org/show_bug.cgi?id=50943
See: http://test.w3.org/webperf/specs/NavigationTiming/#nt-dom-content-event-start
* dom/Document.cpp:
(WebCore::Document::finishedParsing):
* dom/DocumentTiming.h:
(WebCore::DocumentTiming::DocumentTiming):
* page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::domContentLoadedEventStart):
(WebCore::PerformanceTiming::domContentLoadedEventEnd):
* page/PerformanceTiming.h:
* page/PerformanceTiming.idl:
2010-12-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Andreas Kling.
Style fix for r73927
https://bugs.webkit.org/show_bug.cgi?id=51194
No functionality change. No new tests needed.
* html/HTMLCanvasElement.h:
2010-12-17 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Buttons rendering was broken in r74129
https://bugs.webkit.org/show_bug.cgi?id=51173
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintRenderObject):
2010-12-17 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
Improve 'arithmetic' operator on feComposite
https://bugs.webkit.org/show_bug.cgi?id=51105
Fixing style errors and bug description for r74177.
* platform/graphics/filters/FEComposite.cpp:
(WebCore::arithmetic):
2010-12-17 Dan Bernstein <mitz@apple.com>
Rubber-stamped by Mark Rowe.
Updated for the renaming of WebKitTools to Tools
* WebCore.vcproj/build-generated-files.sh:
* WebCore.vcproj/migrate-scripts.sh:
2010-12-17 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
A corrupted counter tree is created when renderers are added to the
tree bypassing RenderObject::addChild
https://bugs.webkit.org/show_bug.cgi?id=51270
This patch replaces the hack introduced for fixing bug 43812
with code that addresses the underlying problem for that bug.
No new layout tests provided as there is no identified scenario when
visible behavior would be different, the internal datastructures
are maintained properly through this fix so the previous hack
introduced for bug 43812 is now removed. The fact that the
layout test introduced for 43812 continues to pass is proof that the
code works.
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
Removed hack.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
Moved call to counter nodes updater to lower level
functions to avoid bypass.
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Changed to update the values of the counters that
may be inserted in the tree.
2010-12-17 Shimeng (Simon) Wang <swang@google.com>
Reviewed by Steve Block.
Fix V8 JNI binding.
https://bugs.webkit.org/show_bug.cgi?id=51156
There're LayoutTests in:
http://trac.webkit.org/browser/trunk/LayoutTests/java/lc3/JSNumber
to exercise these code paths.
Though Chromium don't run them.
Tested on Android fast/events/touch tests.
* bridge/jni/v8/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertNPVariantToJValue):
2010-12-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Interrupted accelerated animation can break later transitions
<rdar://problem/8767714>
https://bugs.webkit.org/show_bug.cgi?id=51264
If we're still waiting for the 'animationDidStart' callback when renderers
get destroyed, then the m_waitingForStartTimeResponse flag could be left
set to 'true', which causes later transitions to never start.
Fix by clearing the m_waitingForStartTimeResponse flag when the m_startTimeResponseWaiters
becomes empty.
Test: transitions/interrupted-accelerated-transition.html
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
2010-12-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Interrupted accelerated animation can break later transitions
https://bugs.webkit.org/show_bug.cgi?id=51264
Step 1: code cleanup.
Rename "responseWait" variables to "startTimeResponseWait", to make it clear
the kind of response that is being waited for.
Make a couple of methods private.
No behavioral changes, so no tests.
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::endAnimationUpdate):
(WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
(WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
(WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList):
(WebCore::AnimationControllerPrivate::startTimeResponse):
* page/animation/AnimationControllerPrivate.h:
2010-12-17 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
Layout and rendering of CSS text-emphasis
Final part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539
Tests: fast/text/emphasis-vertical.html
fast/text/emphasis.html
Emphasis marks behave like they are stuck just above the ascender (or just below the
descender). They occupy space in the leading and in padding, and only grow the line space
if they cannot fit.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Renamed the containsRuby parameter to
hasAnnotationsBefore, and added hasAnnotationsAfter. Line annotations include ruby and text emphasis
marks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Added overflow from emphasis marks.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Remaned computeBlockDirectionRubyAdjustment()
to this and added adjustment for text emphasis marks.
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment): Added. Similar to the previous function,
but for annotations under the glyphs. These can only be text emphasis marks.
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::paintTextWithShadows): Paint emphasis marks.
(WebCore::InlineTextBox::paint): Ditto.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Generalized the code that adjusts the last line for
ruby in flipped writing mode to also adjust the last line for emphasis marks under the line in non-
flipped writing mode.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionColor): Added this helper method which generalizes selectionForegroundColor().
(WebCore::RenderObject::selectionForegroundColor): Moved most of the code to selectionColor().
(WebCore::RenderObject::selectionEmphasisMarkColor): Added.
* rendering/RenderObject.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox): Updated initialization for new members.
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Update new members.
(WebCore::RootInlineBox::beforeAnnotationsAdjustment): Renamed blockDirectionRubyAdjustment() to this
and extended to deal with annotations over and under the line and the previous line. If both lines have
annotations into the space between the lines, maintain separation so that the annotations do not overlap.
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::hasAnnotationsBefore): Added this accessor.
(WebCore::RootInlineBox::hasAnnotationsAfter): Ditto.
2010-12-17 W. James MacLean <wjmaclean@chromium.org>
Reviewed by James Robinson.
[chromium] Add support to compositor to composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=50833
A patch to extend compositor to be able to composite into an offscreen texture instead
of just directly to the display buffer. Builds on RenderSurfaceChromium support.
External behaviour not changed, so no tests.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::prepareToDrawLayers):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::setCompositeOffscreen):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::isCompositingOffscreen):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
2010-12-17 Ariya Hidayat <ariya@sencha.com>
Reviewed by Andreas Kling.
[Qt] Default image interpolation should reset the render hint
https://bugs.webkit.org/show_bug.cgi?id=51233
Save initial SmoothPixmapTransform render hint so that it can be used
with default image interpolation quality to reset back the render hints.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::setImageInterpolationQuality):
2010-12-17 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Support Date objects as keys.
https://bugs.webkit.org/show_bug.cgi?id=51193
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
Use the new IDBKey factory functions, and support Date objects.
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
Create Date objects from DateType keys.
* storage/IDBKey.cpp:
(WebCore::IDBKey::fromQuery):
(WebCore::IDBKey::isEqual):
(WebCore::IDBKey::whereSyntax):
(WebCore::IDBKey::lowerCursorWhereFragment):
(WebCore::IDBKey::upperCursorWhereFragment):
(WebCore::IDBKey::bind):
(WebCore::IDBKey::bindWithNulls):
Update all SQL related functions to handle Date keys.
* storage/IDBKey.h:
(WebCore::IDBKey::createNull):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
Rename the create factories; since both number and date is just a
double, function overloading can't be used to discriminate between
the factories.
(WebCore::IDBKey::date):
Add getter for the date value.
2010-12-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add scripts parsed after resource load to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51243
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addScript):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addScript):
2010-12-17 Anton Muhin <antonm@chromium.org>
Reviewed by Yury Semikhatsky.
[v8] The last portion of CSS GC work: fixing fast/dom/StyleSheet/gc-stylesheet-wrapper.html
https://bugs.webkit.org/show_bug.cgi?id=51121
Properly group style elements of HTML links, style elements and processing instructions.
* bindings/v8/V8GCController.cpp:
(WebCore::NodeGrouperVisitor::visitDOMWrapper):
(WebCore::NodeGrouperVisitor::addDOMObjectToGroup):
2010-12-17 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] scripts in scripts panel are not updated on reload.
https://bugs.webkit.org/show_bug.cgi?id=51101
* inspector/front-end/ResourceManager.js:
(WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
2010-12-17 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Laszlo Gombos.
The inspector does not compile without JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=51246
Fix the build, m_extraHeaders does not depend on JAVASCRIPT_DEBUGGER.
* inspector/InspectorController.h:
2010-12-17 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: clear extra/override headers when front-end is closed
https://bugs.webkit.org/show_bug.cgi?id=51244
* inspector/InspectorController.cpp:
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::willSendRequest):
2010-12-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=50893
Now Mac shortcuts are:
- Cmd F/G = find / next
- Cmd L = go to line
Win/Linux:
- Ctrl+G = go to line
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._registerShortcuts):
* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):
2010-12-16 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
Wrong check in ResourceHandleSoup in error cases
https://bugs.webkit.org/show_bug.cgi?id=51171
Calling didReceiveData with no data causes a crash in debug
builds. Checking for soupMsg->response_body->data is not correct as libsoup
always creates a buffer for that. Instead we should check for
soupMsg->response_body->length
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
2010-12-17 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Avoid unnecessary calls to GraphicsContextPlatformPrivate::p()
https://bugs.webkit.org/show_bug.cgi?id=49954
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::pushTransparencyLayerInternal):
(WebCore::GraphicsContext::beginTransparencyLayer):
2010-12-17 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Compile warning introduced in r74129
https://bugs.webkit.org/show_bug.cgi?id=51181
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::gtkContainer):
2010-12-17 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Add sslHandshakeStart to interface
https://bugs.webkit.org/show_bug.cgi?id=50400
Test: http/tests/misc/webtiming-ssl.php
* page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::connectStart): Update comment.
(WebCore::PerformanceTiming::connectEnd): Remove SSL time.
(WebCore::PerformanceTiming::sslHandshakeStart): Added.
* page/PerformanceTiming.h: Added sslHandshakeStart.
* page/PerformanceTiming.idl: Ditto.
2010-12-17 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Fisher.
[Web Timing] Navigation type enums should begin with TYPE_
https://bugs.webkit.org/show_bug.cgi?id=51200
* page/PerformanceNavigation.cpp:
(WebCore::PerformanceNavigation::type): Added TYPE_ to navigation types.
* page/PerformanceNavigation.h: Ditto and added TYPE_RESERVED.
* page/PerformanceNavigation.idl: Ditto.
2010-12-17 Steve Block <steveblock@google.com>
Unreviewed build fix.
Fix build when Geolocation is disabled.
No new tests, build fix only.
* page/Geolocation.h:
2010-12-17 Patrick Gansterer <paroga@webkit.org>
Unreviewed. WinCE build fix.
* platform/graphics/GraphicsContext.h:
2010-12-17 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove unnecessary dependencies from InspectorBackendStub.
InspectorBackendStub is a transport-only thing but it has dependencies with
Callback.js and WebInspector namespace. Callback can be integrated into
InspectorBackendStub because it is the only client.
Without these dependencies InspectorBackendStub can be used as an API
wrapper for Inspector Protocol.
https://bugs.webkit.org/show_bug.cgi?id=51184
* WebCore.gypi:
* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/Callback.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
2010-12-15 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Extension API] add support for adding/overriding HTTP request headers
https://bugs.webkit.org/show_bug.cgi?id=50493
Test: http/tests/inspector/extensions-headers.html
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::willSendRequest): Apply extra headers.
(WebCore::InspectorController::setExtraHeaders):
* inspector/InspectorController.h:
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):
(WebInspector.injectedExtensionAPI.Resources.prototype.addRequestHeaders):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
2010-12-16 Koan-Sin Tan <koansin.tan@gmail.com>
Reviewed by Kent Tamura.
Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=50365
No new tests. But this makes Chromimium Linux show
fast/blockflow/japanese-*-text.html and other vertical
writing text correctly as on WebKit and Chromimum for Mac.
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::hash):
* platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::orientation):
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::substituteWithVerticalGlyphs):
(WebCore::GlyphPage::fill):
2010-12-16 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbo <tor.arne.vestbo@nokia.com>
Reviewed by Eric Carlson.
Provide an interface to require using fullscreen mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=51133
Add ChromeClient::requiresFullscreenForVideoPlayback to require webkit
to launch fullscreen video player for playing the html5 video. The
idea is that a browser vendor can specify this behavior through the
platform plugin or something else by using this interface.
No new tests because no client implements requiresFullscreenForVideoPlayback yet.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::exitFullscreen):
* page/Chrome.cpp:
(WebCore::Chrome::requiresFullscreenForVideoPlayback):
* page/Chrome.h:
* page/ChromeClient.h:
(WebCore::ChromeClient::requiresFullscreenForVideoPlayback):
2010-12-16 Steve Block <steveblock@google.com>
Reviewed by Steve Block.
GeolocationPositionCache needs refactoring
https://bugs.webkit.org/show_bug.cgi?id=50826
No new tests, refactoring only.
* page/Geolocation.cpp:
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::makeCachedPositionCallbacks):
(WebCore::Geolocation::haveSuitableCachedPosition):
(WebCore::Geolocation::positionChangedInternal):
* page/Geolocation.h:
* page/GeolocationPositionCache.cpp:
(WebCore::GeolocationPositionCache::instance):
(WebCore::GeolocationPositionCache::GeolocationPositionCache):
(WebCore::GeolocationPositionCache::addUser):
(WebCore::GeolocationPositionCache::removeUser):
(WebCore::GeolocationPositionCache::setDatabasePath):
(WebCore::GeolocationPositionCache::setCachedPosition):
(WebCore::GeolocationPositionCache::cachedPosition):
(WebCore::GeolocationPositionCache::readFromDatabase):
(WebCore::GeolocationPositionCache::writeToDatabase):
* page/GeolocationPositionCache.h:
(WebCore::GeolocationPositionCacheWrapper::GeolocationPositionCacheWrapper):
(WebCore::GeolocationPositionCacheWrapper::~GeolocationPositionCacheWrapper):
(WebCore::GeolocationPositionCacheWrapper::setCachedPosition):
(WebCore::GeolocationPositionCacheWrapper::cachedPosition):
2010-12-16 Ariya Hidayat <ariya@sencha.com>
Reviewed by Andreas Kling.
[Qt] GraphicsContext should respect QWebView render hints
https://bugs.webkit.org/show_bug.cgi?id=51208
GraphicsContext does not override SmoothPixmapTransform (see also
r62762). To keep the same behavior, canvas default image interpolation
quality is set to medium and QWebView's render hints by default also
include SmoothPixmapTransform.
* html/HTMLCanvasElement.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
2010-12-16 Daniel Bates <dbates@rim.com>
Formatting fix; un-indent one level all lines in [2793, 2808] (with respect to r74217)
so as to be consistent with the formatting of the rest of this file.
Also, add an empty line between the win32* and wince* conditional include blocks.
* WebCore.pro:
2010-12-16 Daniel Bates <dbates@rim.com>
Reviewed by Antonio Gomes.
[Qt] Only include ScrollAnimatorWin.h and compile ScrollAnimatorWin.cpp
on Windows if ENABLE_SMOOTH_SCROLLING=1
https://bugs.webkit.org/show_bug.cgi?id=51215
Conditionally include the files ScrollAnimatorWin.h and ScrollAnimatorWin.cpp when building
the Qt Windows with smooth scrolling enabled.
No change in functionality since these files are guarded by ENABLE(SMOOTH_SCROLLING).
* WebCore.pro:
2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
execCommand('JustifyCenter') adds extra BR
https://bugs.webkit.org/show_bug.cgi?id=51082
The bug was caused by moveParagraphContentsToNewBlockIfNecessary's adding a placeholder br
to new block and not removing it later. Fixed the bug by removing it when the paragraph
moved into the block didn't have a br at the end.
Test: editing/execCommand/justify.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
2010-12-16 Jian Li <jianli@chromium.org>
Unreviewed. Fixed chromium build break caused by r74207.
* platform/ContextMenuItem.h:
2010-12-16 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build fix.
Disable ContextMenu support for now while support for
CROSS_PLATFORM_MENUS is written.
* CMakeListsEfl.txt:
* platform/ContextMenu.h:
* platform/ContextMenuItem.h:
* platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createNativeMenuFromItems):
(WebCore::ContextMenu::nativeMenu):
* platform/efl/ContextMenuItemEfl.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::nativeMenuItem):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::checked):
(WebCore::ContextMenuItem::setEnabled):
(WebCore::ContextMenuItem::enabled):
(WebCore::ContextMenuItem::setSubMenu):
2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
https://bugs.webkit.org/show_bug.cgi?id=51164
Fixed the bug by always enabling the StyleWithCSS command.
Test: editing/style/stylewithcss-without-selection.html
* editing/EditorCommand.cpp:
(WebCore::createCommandMap): StyleWithCSS is enabled rather than enabledInRichlyEditableText.
2010-12-16 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Save the manual plug-in stream data and redeliver it when the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=51201
Export SharedBuffer related symbols.
* WebCore.exp.in:
2010-12-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: timeline records should only operate WebCore time.
https://bugs.webkit.org/show_bug.cgi?id=51127
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createResourceFinishData):
* inspector/TimelineRecordFactory.h:
2010-12-15 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=50996
<rdar://problem/8098862> Consider disabling DNS prefetch when proxy is used
No new tests, cannot test DNS.
* platform/network/cf/DNSCFNet.cpp:
(WebCore::proxyIsEnabledInSystemPreferences): Check if accessing example.com is going to use
a proxy. This is only an estimate - even with a proxy is configured in system preferences, an
actual request can go directly to the host if a PAC script says so.
(WebCore::DNSResolveQueue::add): Check if proxy is enabled when sending immediate requests.
(WebCore::DNSResolveQueue::fired): Ditto when sending queued ones.
2010-12-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Console always scroll to the bottom on new events
https://bugs.webkit.org/show_bug.cgi?id=51189
When new messages are added to the console it will auto scroll
only if it was already scrolled down to the last record.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
(WebInspector.ConsoleView.prototype._isScrolledToLastMessage):
(WebInspector.ConsoleView.prototype.addMessage):
2010-12-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: update CallStackSidebarPane placards and status message in the same event handler.
https://bugs.webkit.org/show_bug.cgi?id=51174
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
(WebInspector.BreakpointManager.prototype._debuggerPaused):
(WebInspector.BreakpointManager.prototype._debuggerResumed):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.pausedScript):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
2010-12-16 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Fix IDBDatabaseError code offset bug
https://bugs.webkit.org/show_bug.cgi?id=51177
IDBDatabaseError::code() needs to return the error code without
offset. But when the IDBDatabaseError is created, the code comes with
an offset (it gets passed a IDBDatabaseException::IDBDatabaseExceptionCode).
However, in Chromium, IDBDatabaseErrors are sometimes also created via
WebIDBDatabaseError when they are sent across IPC, and then the error
code comes *without* offset. Provide a second create() function for
this case.
* storage/IDBDatabaseError.h:
(WebCore::IDBDatabaseError::create):
(WebCore::IDBDatabaseError::createWithoutOffset):
(WebCore::IDBDatabaseError::code):
2010-12-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74162.
http://trac.webkit.org/changeset/74162
https://bugs.webkit.org/show_bug.cgi?id=51185
More breakage in GTK+ (Requested by xan_ on #webkit).
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::registerEncodingNames):
2010-12-16 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Up/Down/PageUp/PageDown on a CSS property numeric value commit the value editor
https://bugs.webkit.org/show_bug.cgi?id=51114
The r74038 regressed the behaviour. This patch additionally ensures that both Metrics and Styles panes
are updated once a stylesheet is reverted.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._stylesPaneEdited):
(WebInspector.ElementsPanel.prototype._metricsPaneEdited):
(WebInspector.ElementsPanel.prototype._styleSheetChanged):
2010-12-16 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium Mac Debug Clang compilation.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
2010-12-16 Alejandro G. Castro <alex@igalia.com>
Unreviewed. Fix GTK3 compilation after 74129.
* platform/gtk/WidgetRenderingContextGtk3.cpp:
2010-12-16 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium Debug compilation after r74177
* platform/graphics/filters/FEComposite.cpp:
(WebCore::arithmetic):
2010-12-16 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
Fix a warning on 32-bit Mac.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::emphasisMarkFontData): 0.5 -> 0.5f
2010-12-16 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
Improve feArithmeticFilter
https://bugs.webkit.org/show_bug.cgi?id=51105
In case of the arithmetic operator on feComposite filter, we could use
different result passing modes depend on its type. Furthermore, the
number of executed multiplications is reduced if k1 or k4 argument is zero.
2% speedup on WebCore/manual-tests/svg-filter-animation.svg
* platform/graphics/filters/FEComposite.cpp:
(WebCore::computeArithmeticPixels):
(WebCore::arithmetic):
(WebCore::FEComposite::apply):
2010-12-15 Brian Weinstein <bweinstein@apple.com>
Reviewed by Jon Honeycutt.
WebKit2 should exit auto scrolling mode when losing focus
https://bugs.webkit.org/show_bug.cgi?id=49209
When a page loses focus, make sure that we stop the autoscroll timer, which exits pan scrolling mode. We
don't want to automatically scroll when a page doesn't have focus.
Updated manual-tests/autoscroll.html with instructions to test this bug.
* manual-tests/autoscroll.html:
* page/FocusController.cpp:
(WebCore::FocusController::setFocused):
2010-12-15 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Font support for the text-emphasis CSS property
Part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539
* platform/graphics/Font.cpp:
(WebCore::Font::drawEmphasisMarks): Added. Calls through to drawEmphasisMarksFor{Simple,Complex}Text.
(WebCore::Font::canReceiveTextEmphasis): Added. For simple text, checks if the character should
have an emphasis mark.
* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter): Replaced the forceSmallCaps boolean with a FontDataVariant
parameter and made this function work with other variants.
(WebCore::Font::getEmphasisMarkGlyphData): Added. Returns glyph data for the first character of
the emphasis mark. This function may not work if the emphasis mark uses a complex script, but none
of the standard emphasis marks do so.
(WebCore::Font::emphasisMarkAscent): Added.
(WebCore::Font::emphasisMarkDescent): Added.
(WebCore::Font::emphasisMarkHeight): Added.
(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Moved much of the logic from drawSimpleText()
into this new function, which also has a ForTextEmphasis parameter, which is passed along to the
WidthIterator.
(WebCore::Font::drawSimpleText): Left the drawing part here.
(WebCore::Font::drawEmphasisMarksForSimpleText): Added.
(WebCore::Font::drawGlyphBuffer): Removed the unused TextRun parameter.
(WebCore::offsetToMiddleOfGlyph): Added this helper.
(WebCore::offsetToMiddleOfGlyphAtIndex): Added this other helper.
(WebCore::Font::drawEmphasisMarks): Added. Draws emphasis marks for a given glyph buffer by placing
one mark centered above each glyph. Zero glyphs in the buffer indicate that no mark should be drawn.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawEmphasisMarks): Added. Calls through to Font::drawEmphasisMarks().
* platform/graphics/GraphicsContext.h:
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData): Removed initialization of deleted members.
(WebCore::SimpleFontData::~SimpleFontData): Removed derived font data cleanup, which now happens
in ~DerivedFontData.
(WebCore::SimpleFontData::brokenIdeographFontData): Changed to use m_derivedFontData.
(WebCore::SimpleFontData::DerivedFontData::DerivedFontData): Added. This lazily-allocated struct
contains the SimpleFontData for small caps, broken ideograph and emphasis mark.
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData): Added.
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::variantFontData): Added. This is used by Font::glyphDataForCharacter().
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Added forTextEmphasis parameter.
(WebCore::WidthIterator::advance): When used for text emphasis, replace glyphs with the zero glyph
if they should not receive an emphasis mark.
* platform/graphics/WidthIterator.h:
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::TextRunWalker::nextScriptRun): Updated for change to Font::glyphDataForCharacter().
(WebCore::TextRunWalker::setupFontForScriptRun): Ditto.
(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.
* platform/graphics/efl/FontEfl.cpp:
(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.
* platform/graphics/haiku/FontHaiku.cpp:
(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.
* platform/graphics/haiku/SimpleFontDataHaiku.cpp:
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController): Added forTextEmphasis parameter.
(WebCore::ComplexTextController::collectComplexTextRuns): Updated for change to Font::glyphDataForCharacter().
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): When used for text emphasis, replace glyphs with the zero glyph
if they should not receive an emphasis mark.
* platform/graphics/mac/ComplexTextController.h:
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::getGlyphsAndAdvancesForComplexText): Moved much of the logic from drawComplexText()
into this new function, which also has a ForTextEmphasis parameter, which is passed along to the
ComplexTextController.
(WebCore::Font::drawComplexText): Left the drawing part here.
(WebCore::Font::drawEmphasisMarksForComplexText): Added.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformDestroy): Adopted m_derivedFontData.
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.
* platform/graphics/pango/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformDestroy): Removed redundant clearing of derived font.
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::emphasisMarkAscent): Added stub.
(WebCore::Font::emphasisMarkDescent): Ditto.
(WebCore::Font::emphasisMarkHeight): Ditto.
(WebCore::Font::drawEmphasisMarksForSimpleText): Ditto.
(WebCore::Font::drawEmphasisMarksForComplexText): Ditto.
* platform/graphics/win/FontWin.cpp:
(WebCore::Font::getGlyphsAndAdvancesForComplexText): Moved much of the logic from drawComplexText()
into this new function, which also has a ForTextEmphasis parameter. Currently returns an empty
glyph buffer for text emphasis.
(WebCore::Font::drawComplexText): Left the drawing part here.
(WebCore::Font::drawEmphasisMarksForComplexText): Added.
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance): Updated for change to Font::glyphDataForCharacter().
* platform/graphics/wince/FontWinCE.cpp:
(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.
* platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::platformDestroy): Removed redundant clearing of derived font.
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.
* platform/graphics/wx/FontWx.cpp:
(WebCore::Font::getGlyphsAndAdvancesForComplexText): Added stub.
(WebCore::Font::drawComplexText): Updated for removal of unused TextRun parameter to drawGlyphBuffer().
(WebCore::Font::drawEmphasisMarksForComplexText): Added.
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.
* platform/text/CharacterNames.h: Added characters used in Font::canReceiveTextEmphasis().
2010-12-15 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=51150 WebView's
_scaleWebView SPI doesn't work on pages with compositing layers
-and corresponding-
<rdar://problem/8604713>
paintingGoesToWindow() should return false if the owning layer has
a transform.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintingGoesToWindow):
Use docWidth() and docHeight() instead of rightLayoutOverflow() and
bottomLayoutOverflow() since docWidth/Height are now the preferred
way to query physical dimensions of the document.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
2010-12-15 Alex Bredariol Grilo <abgrilo@profusion.mobi>
Reviewed by Eric Seidel.
[EFL] Fix timer calling time in SharedTimerEfl
No new features, so no tests added.
The usage of ecore_timer_loop_add instead of ecore_timer_add corrects
the problem that the timer is not called at the correct time. Since this
code runs in a single thread, all multiple thread operations were
removed.
* platform/efl/SharedTimerEfl.cpp:
(WebCore::stopSharedTimer):
(WebCore::addNewTimer):
2010-12-15 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] StillImage::draw() shouldn't call setCompositionMode() unless the QPaintEngine has Porter-Duff composition
https://bugs.webkit.org/show_bug.cgi?id=49918
Go through GraphicsContext::setCompositeOperation() which does the check for us.
* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::draw):
2010-12-15 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
UTF-16 and its variants should be treated as Big Endian when BOM
is absent.
https://bugs.webkit.org/show_bug.cgi?id=51035
Test: fast/encoding/char-decoding.html (changed)
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::registerEncodingNames):
2010-12-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Percentage Z values in 3d transform functions and transform-origin should cause the property to be invalid
https://bugs.webkit.org/show_bug.cgi?id=51070
Treat as inavlid -webkit-transform values that include a percentage value in translateZ()
or in the third parameter to translate3d().
Test: transforms/3d/general/3dtransform-values.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseTransformOrigin): Whitespace change.
2010-12-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Reflection does not render properly when -webkit-transform is toggled, untoggled, and retoggled
https://bugs.webkit.org/show_bug.cgi?id=50967
If a reflection on a compositied, transformed element is toggled on, off and on,
then we pick up a cached layer clone that has the wrong transform set on it.
The fix is to reset those properties on the layer clones that get changed
when the GraphicsLayer gains a structural layer (for reflection flattening).
Test: compositing/reflections/remove-add-reflection.html
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
2010-12-15 Timothy Hatcher <timothy@apple.com>
Fix a regression where the Web Inspector console would be empty
if the Inspector is localized.
https://bugs.webkit.org/show_bug.cgi?id=51145
Reviewed by Joseph Pecoraro.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.createFilterElement): Add a label argument so the UI string
is separate from the classname. Code clean up.
(WebInspector.ConsoleView.prototype.filter): Remove toLowerCase and use string compare.
(WebInspector.ConsoleView): Pass separate classnames and labels to createFilterElement.
2010-12-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adele Peterson.
WebKit2 in compositing mode no longer has font smoothing
https://bugs.webkit.org/show_bug.cgi?id=50733
Only turn off font smoothing for layers whose contents are
not opaque. This allows the root GraphicsLayer in WebKit2 to
set the opaque flag, and get smoothed text.
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
2010-12-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Allow disabling of font smoothing in compositing layers to be overridden by style
https://bugs.webkit.org/show_bug.cgi?id=50732
Add methods to GraphicsContext to get and set font smoothing,
and have them be part of the graphics state.
Fix Font::drawGlyphs() to allow the font's smoothing mode (from style)
to override the current smoothing mode of the context. The global
shouldUseSmoothing() still has final say.
Turn off smoothing in compositing layers with this, rather than
the non-stateful 'allow' method.
* manual-tests/compositing/font-smoothing.html: Added.
Manual test because DRT disables font smoothing.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setShouldSmoothFonts):
(WebCore::GraphicsContext::shouldSmoothFonts):
(WebCore::GraphicsContext::setPlatformShouldSmoothFonts):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformShouldSmoothFonts):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
2010-12-15 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
IOSurface bounds checks on bytesPerRow and allocSize are incorrect
https://bugs.webkit.org/show_bug.cgi?id=51137
No new tests added. For those using this new functionality, many current canvas layout tests will now pass.
* platform/graphics/cg/ImageBufferCG.cpp:
2010-12-15 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Web Audio API: port FFTFrame to MKL
https://bugs.webkit.org/show_bug.cgi?id=50986
Ported FFTFrame to Intel's MKL. This patch contains the port and
initial, though not complete, build system changes. Tested so far
with a unit test by Chris Rogers (which requires code changes to
AudioContext.cpp and is not being checked in). Further testing to
follow once layout tests are available for the Web Audio API.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/audio/FFTFrame.h:
* platform/audio/mkl: Added.
* platform/audio/mkl/FFTFrameMKL.cpp: Added.
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::getUpToDateComplexData):
(WebCore::FFTFrame::descriptorHandleForSize):
2010-12-15 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Fix stack overflow when there are too many sibling inline boxes by using
a loop to traverse children instead of calling each sibling from the first child.
https://bugs.webkit.org/show_bug.cgi?id=48255
Test: fast/overflow/lots-of-sibling-inline-boxes.html
* rendering/InlineBox.h:
(WebCore::InlineBox::setConstructed):
(WebCore::InlineBox::next):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::setConstructed):
2010-12-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2: Can't add files to an <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=51087
Add exported function.
* WebCore.exp.in:
2010-12-15 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] screenIsMonochrome() is broken
https://bugs.webkit.org/show_bug.cgi?id=49957
* platform/qt/PlatformScreenQt.cpp:
(WebCore::screenIsMonochrome):
2010-12-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Move button rendering from gtk{2,3}drawing.cpp to RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=48486
Implement button rendering in RenderThemeGtk. The implementation
from gtk{2,3}drawing.cpp will be removed once menu list button rendering
is implemented in RenderThemeGtk as well.
No new tests, as this should not change functionality.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintButton): Add an implementation of button
rendering that uses WidgetRenderingContext.
2010-10-18 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Move input type=range rendering to RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=47836
Begin moving widget rendering out of the old Mozilla theme drawing code,
which should remove many lines of code when completed. WidgetRenderingContext
now hides the GTK+ 2 vs. 3 API differences, so that RenderThemeGtk can stay
version agnostic.
No new tests as this patch does not change functionality.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::RenderThemeGtk): gtkContainer() now returns a
GtkWidget, so update the cast here.
(WebCore::RenderThemeGtk::getGtkStateType): Added this helper which
converts a RenderObject state into a GtkStateType.
(WebCore::RenderThemeGtk::paintRenderObject): Removed work-arounds for
scale painting, as it's not handled by this method any longer.
(WebCore::RenderThemeGtk::paintSliderTrack): Updated to use
WidgetRenderingContext.
(WebCore::RenderThemeGtk::paintSliderThumb): Ditto.
(WebCore::RenderThemeGtk::adjustSliderThumbSize): Get the size
properties directly from the widget now instead of asking the Mozilla code.
(WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Added this
helper which reduces the amount of code quite a bit.
(WebCore::RenderThemeGtk::gtkContainer): Updated to use helper.
(WebCore::RenderThemeGtk::gtkButton): Ditto.
(WebCore::RenderThemeGtk::gtkEntry): Ditto.
(WebCore::RenderThemeGtk::gtkTreeView): Ditto.
(WebCore::RenderThemeGtk::gtkVScale): Added.
(WebCore::RenderThemeGtk::gtkHScale): Added.
(WebCore::RenderThemeGtk::platformColorsDidChange): Removed
GTK_CONTAINER cast.
* platform/gtk/RenderThemeGtk.h: Updated to add new GtkHScale and
GtkVScale members.
* platform/gtk/WidgetRenderingContext.h: Aded new methods to proxy
gtk_paint_box, gtk_paint_focus and gtk_paint_slider.
* platform/gtk/WidgetRenderingContextGtk2.cpp:
(WebCore::WidgetRenderingContext::gtkPaintBox): Added.
(WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
* platform/gtk/WidgetRenderingContextGtk3.cpp:
(WebCore::WidgetRenderingContext::gtkPaintBox): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
(WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
* platform/gtk/gtk2drawing.c: Removed defunct code!
(moz_gtk_get_widget_border):
(moz_gtk_widget_paint):
* platform/gtk/gtk3drawing.c: Ditto.
(moz_gtk_get_widget_border):
(moz_gtk_widget_paint):
* platform/gtk/gtkdrawing.h:
2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113
This broke the GTK1 build. (Requested by mrobinson on
#webkit).
* GNUmakefile.am:
* platform/network/soup/cache/webkit/soup-cache.h:
2010-12-15 Jian Li <jianli@chromium.org>
Unreviewed. Fixed a clang compiling error by making the forward
declaration of MediaPlayerFactory be consistent with the definition.
* platform/graphics/MediaPlayer.h:
2010-12-15 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Rename pageY to pageLogicalOffset, since for vertical writing modes it is an x-position rather than a
y-position.
* rendering/LayoutState.cpp:
(WebCore::LayoutState::pageLogicalOffset):
(WebCore::LayoutState::addForcedColumnBreak):
* rendering/LayoutState.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::setPageLogicalOffset):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::pageLogicalOffset):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
2010-12-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move scripts storage from ScriptsPanel to DebuggerModel.
https://bugs.webkit.org/show_bug.cgi?id=50908
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._debuggerPaused):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.update):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype._setBreakpoint):
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
(WebInspector.DebuggerModel.prototype.scriptsForURL):
(WebInspector.DebuggerModel.prototype.queryScripts):
(WebInspector.DebuggerModel.prototype.parsedScriptSource):
(WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
(WebInspector.DebuggerModel.prototype.breakpointRestored):
(WebInspector.DebuggerModel.prototype.debuggerPaused):
(WebInspector.DebuggerModel.prototype.debuggerResumed):
* inspector/front-end/Resource.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel): eliminate sourceIDMap
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
(WebInspector.SourceFrame.prototype._setBreakpoint):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
* inspector/front-end/inspector.js:
(WebInspector.createJSBreakpointsSidebarPane):
(WebInspector.parsedScriptSource):
(WebInspector.failedToParseScriptSource):
2010-12-15 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
MediaPlayer should try all installed media engines
https://bugs.webkit.org/show_bug.cgi?id=50209
* platform/graphics/MediaPlayer.cpp:
(WebCore::bestMediaEngineForTypeAndCodecs): Rename from chooseBestEngineForTypeAndCodecs. Take optional
parameter for current engine.
(WebCore::nextMediaEngine): New, return the next media engine in the list.
(WebCore::MediaPlayer::MediaPlayer): Initialize reload timer.
(WebCore::MediaPlayer::load): Store url, mime type, and codecs parameter in member variables.
(WebCore::MediaPlayer::loadWithNextMediaEngine): New, initiate loading with the next media engine.
(WebCore::MediaPlayer::supportsType): Make contentType parameter const.
(WebCore::MediaPlayer::reloadTimerFired): New, call loadWithNextMediaEngine.
(WebCore::MediaPlayer::networkStateChanged): If network state signals a failure and the file's
metadata has not loaded, give the next installed engine a try.
* platform/graphics/MediaPlayer.h:
2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
Changes to enable building WebKit2 for Gtk port
(https://bugs.webkit.org/show_bug.cgi?id=37369)
No new functionality added or deleted. Only makefile change. Hence, no tests added.
* GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and added them to WebKit/gtk/GNUmakefile.am
* platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h> and declare WEBKIT_API directly
2010-12-15 Jarred Nicholls <jarred@sencha.com>
Reviewed by Andreas Kling.
[Qt] Implement the File API spec
https://bugs.webkit.org/show_bug.cgi?id=49839
No new tests. fast/files tests work when manually operated.
They do not automatically work due to Qt's inability to handle multi-file
inputs (https://bugs.webkit.org/show_bug.cgi?id=22048) as well as Qt's DRT
is missing an eventSender.beginDragWithFiles implementation.
* WebCore.pri:
* WebCore.pro:
* features.pri:
* platform/qt/FileSystemQt.cpp:
(WebCore::directoryName):
(WebCore::readFromFile):
(WebCore::seekFile):
2010-12-14 Antti Koivisto <antti@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=49548
WebCore cache stores duplicate copies of subresources with URL fragments
- Strip fragment identifiers from HTTP and file URLs for the memory cache.
- Changed some CachedResourceLoader and MemoryCache interfaces to use KURLs
instead of strings to reduce repeated URL parsing.
Test: http/tests/cache/subresource-fragment-identifier.html
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::cachedResource):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::cachedResource):
(WebCore::CachedResourceLoader::checkForReload):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
* loader/cache/CachedResourceLoader.h:
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::requestResource):
(WebCore::MemoryCache::requestUserCSSStyleSheet):
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
(WebCore::MemoryCache::resourceForURL):
* loader/cache/MemoryCache.h:
2010-12-15 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
[v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations
https://bugs.webkit.org/show_bug.cgi?id=50965
* bindings/v8/V8GCController.cpp:
(WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
(WebCore::DOMObjectGrouperVisitor::addAllItems):
2010-12-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: push persistent breakpoints into backend state cookie so they hit on navigation.
https://bugs.webkit.org/show_bug.cgi?id=48858
BreakpointManager pushes all persistent breakpoints to backend when loaded.
InspectorController restores sticky breakpoints from cookie on navigation.
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::setStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::getObject):
(WebCore::InspectorState::setObject):
(WebCore::InspectorState::registerObject):
* inspector/InspectorState.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane):
(WebInspector.BreakpointsSidebarPane.prototype._removeListElement):
(WebInspector.BreakpointsSidebarPane.prototype._projectChanged):
(WebInspector.EventListenerBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointAdded):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._projectChanged):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/Settings.js:
(WebInspector.Settings.prototype.inspectedURLChanged):
(WebInspector.Settings.prototype.get projectId):
(WebInspector.Settings.prototype.findSettingForAllProjects):
(WebInspector.Settings.prototype._formatProjectKey):
* inspector/front-end/inspector.js:
(WebInspector.createDOMBreakpointsSidebarPane):
(WebInspector.createXHRBreakpointsSidebarPane):
(WebInspector.reset):
(WebInspector.inspectedURLChanged):
2010-12-15 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, fix compilation warnings after r74066.
* rendering/RenderBox.cpp:
(WebCore::layersUseImage): Place this static function between the
same if-def region used in the only place where it's called from.
2010-12-15 Emil Eklund <eae@chromium.org>
Reviewed by Adam Barth.
Change ContainerNode::willRemoveChildren to not fire mutation events for children
added as a result of a mutation event, thereby avoiding an infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=51079
Test: fast/dom/containerNode.html
* dom/ContainerNode.cpp:
(WebCore::willRemoveChildren): Don't fire mutation events for children added during a mutation event.
2010-12-14 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/8767193> REGRESSION (r60822): caps-lock-indicator is accepted as a -webkit-appearance value
https://bugs.webkit.org/show_bug.cgi?id=51096
Test: fast/css/appearance-caps-lock-indicator.html
* css/CSSValueKeywords.in: Moved caps-lock-indicator outside the range of values that should be
accepted by the parser, and added comments about maintaining the list of appearance values.
* platform/ThemeTypes.h: Moved CapsLockIndicatorPart to the end of the ControlPart enum.
2010-12-14 takano takumi <takano@apple.com>
Reviewed by Dan Bernstein.
text-combine value names have been changed in the css3 proposal.
https://bugs.webkit.org/show_bug.cgi?id=51089
Changed text-combine's value names from "none|cluster|upright" to "none|horizontal".
* css/CSSParser.cpp: Changed value name.
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h: Changed value name.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextCombine):
* css/CSSValueKeywords.in: No more text-combine specific values needed since
"horizontal" is already there.
* rendering/style/RenderStyleConstants.h: Changed value name.
* rendering/style/StyleRareNonInheritedData.h: Changed textCombine field size.
2010-12-14 Koan-Sin Tan <koansin.tan@gmail.com>
Reviewed by Alexey Proskuryakov.
Kana should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
https://bugs.webkit.org/show_bug.cgi?id=51012
Kana should be displayed correctly in vertical text with broken font.
Test: fast/blockflow/japanese-rl-text-with-broken-font.html
* platform/graphics/Font.cpp:
(WebCore::Font::isCJKIdeographOrSymbol): add katakana, hiraganna, and Halfwidth and Fullwidth Forms
2010-12-14 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
Additional RenderStyle support for the text-emphasis CSS property
Part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539
No test possible, since this is just adding a function to be used by upcoming patches.
* platform/text/CharacterNames.h: Added characters used as emphasis marks.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::textEmphasisMarkString): Added. Returns a string containing the
emphasis mark, or the null AtomicString if there is none.
* rendering/style/RenderStyle.h:
2010-12-14 Anton D'Auria <adauria@apple.com>
Reviewed by Darin Adler.
Do not allow access to existing HTML5 databases in private browsing
mode https://bugs.webkit.org/show_bug.cgi?id=49332
Test: storage/private-browsing-noread-nowrite.html
Previously, read-only transactions and private browsing mode were
represented by the same SQLStatement and DatabaseAuthorizer states.
This patch removes the m_readOnly member variable from SQLStatement and
DatabaseAuthorizer, and replaces it with m_permissions whose bit fields
are initialized by a DatabaseAuthorizer enum Permissions (ReadWrite,
ReadOnly, NoAccess). A read-only transaction sets permissions to
ReadOnly, and if !m_database->scriptExecutionContext()->allowDatabaseAccess(),
then permissions also set to NoAccess.
* dom/Document.cpp:
(WebCore::Document::allowDatabaseAccess): this method was previously
called isDatabaseReadOnly. It checks if private browsing preference is
set. This method is renamed because it is used to check if private
browsing restricts access to databases.
* dom/Document.h:
* dom/ScriptExecutionContext.h:
* storage/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::setAuthorizerPermissions):
* storage/AbstractDatabase.h:
* storage/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::reset):
(WebCore::DatabaseAuthorizer::createTable):
(WebCore::DatabaseAuthorizer::createTempTable):
(WebCore::DatabaseAuthorizer::dropTable):
(WebCore::DatabaseAuthorizer::dropTempTable):
(WebCore::DatabaseAuthorizer::allowAlterTable):
(WebCore::DatabaseAuthorizer::createIndex):
(WebCore::DatabaseAuthorizer::createTempIndex):
(WebCore::DatabaseAuthorizer::dropIndex):
(WebCore::DatabaseAuthorizer::dropTempIndex):
(WebCore::DatabaseAuthorizer::createTrigger):
(WebCore::DatabaseAuthorizer::createTempTrigger):
(WebCore::DatabaseAuthorizer::dropTrigger):
(WebCore::DatabaseAuthorizer::dropTempTrigger):
(WebCore::DatabaseAuthorizer::createView):
(WebCore::DatabaseAuthorizer::createTempView):
(WebCore::DatabaseAuthorizer::dropView):
(WebCore::DatabaseAuthorizer::dropTempView):
(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):
(WebCore::DatabaseAuthorizer::allowDelete):
(WebCore::DatabaseAuthorizer::allowInsert):
(WebCore::DatabaseAuthorizer::allowUpdate):
(WebCore::DatabaseAuthorizer::allowRead):
(WebCore::DatabaseAuthorizer::allowReindex):
(WebCore::DatabaseAuthorizer::allowWrite): a new private method that
checks if DatabaseAuthorizer is enabled and if it is in ReadOnly or
NoAccess mode.
(WebCore::DatabaseAuthorizer::setReadOnly):
(WebCore::DatabaseAuthorizer::setPermissions):
* storage/DatabaseAuthorizer.h:
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::create):
(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::execute):
* storage/SQLStatement.h:
* storage/SQLStatementSync.cpp:
(WebCore::SQLStatementSync::SQLStatementSync):
(WebCore::SQLStatementSync::execute):
* storage/SQLStatementSync.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::executeSQL):
* workers/WorkerContext.h:
(WebCore::WorkerContext::allowDatabaseAccess):
2010-12-02 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Fix drawing of inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=41576
When clearing outside clipped path, the context contains unexpected transform.
Fixed to restore original state before the clear.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):
2010-12-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Mouse Events Not Received in Run Applet in their Own Process Mode
https://bugs.webkit.org/show_bug.cgi?id=51078
<rdar://problem/8333491>
Make sure that Widget::handleEvent is called for applets as well.
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::defaultEventHandler):
* html/HTMLAppletElement.h:
2010-12-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Parts of page disappear
https://bugs.webkit.org/show_bug.cgi?id=41701
The page has text-indent: -1000000px on an element that becomes
compositing, causing a huge tiled layer to get created.
r63452 aimed to fix this by clamping layer bounds to the viewport,
but did not do so for pages running accelerated animations (since
we don't want to clamp for transform animations). However, this
page only has an opacity animation.
So refine the logic added for r63452 to only call setCompositingConsultsOverlap(false)
for transform animations.
Test: compositing/geometry/limit-layer-bounds-opacity-transition.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation): call didStartAcceleratedAnimation()
with the appropriate properties, and clean up confusing logic that was used to
compute the return value. We want to return true if either property is accelerated.
(WebCore::RenderLayerBacking::startTransition): Call didStartAcceleratedAnimation()
with the appropriate property.
* rendering/RenderLayerCompositor.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::didStartAcceleratedAnimation): Pass the property in,
and only turn off overlap testing if we see a transform animation.
2010-12-14 Brady Eidson <beidson@apple.com>
Reviewed by Alexey Proskuryakov.
<rdar://problem/8225016> and https://bugs.webkit.org/show_bug.cgi?id=40138
Authorization header is sent from an HTTP Auth protected site on redirect
Test: http/tests/misc/authentication-sent-to-redirect.html
Add helper to clear the Auth headers from a resource request:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
* platform/network/ResourceRequestBase.h:
Only Mac and Windows CFNetwork ports seem to have this problem, so plug it for them:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::willSendRequest):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest):
2010-12-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Crash in WebCore::GraphicsLayer::paintGraphicsLayerContents() loading this URL
https://bugs.webkit.org/show_bug.cgi?id=51072
Fix a crash when painting a layer whose PlatformCALayer has been deleted,
by clearing the PlatformCALayer value on the CALayer when the PlatformCALayer
is destroyed.
I was not able to reduce the page to a simple testcase.
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::~PlatformCALayer):
2010-12-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, build fix.
[Qt] Fix the list of header files in WebCore.pro after r74049.
No new tests as there is no new functionality.
* WebCore.pro:
2010-12-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Focus rings are ugly, rects should be united instead of drawn individually
https://bugs.webkit.org/show_bug.cgi?id=49953
Create a QPainterPath and add to it the focus rects, one at a time.
Combine the 2 drawFocusRing functions into one function drawFocusRingForPath.
Tests: fast/css/focus-ring-detached.html
fast/css/focus-ring-multiline.html
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::drawFocusRingForPath):
(WebCore::GraphicsContext::drawFocusRing):
2010-12-14 Mark Rowe <mrowe@apple.com>
Fix the Qt build.
* xml/XSLTProcessorQt.cpp:
(WebCore::XSLTProcessor::transformToString): Make the conversion to QString explicit
since QVariant can be constructed from either a QString or a bool.
2010-12-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
compositing/masks/simple-composited-mask.html failure
https://bugs.webkit.org/show_bug.cgi?id=49746
Geometry of composited layers with a mask depends on the loading
of the mask image, since maskClipRect() is used for the layer bounds.
So when RenderBox::imageChanged() is called for an image used by
a mask on a layer with a composited mask, call the newly-renamed
layer->contentsChanged() method. This percolates down into RenderLayerBacking,
ending in a layer geometry update.
Renamed RenderLayer::rendereContentsChanged() to contentsChanged() and added
an enum to say what changed, for somewhat more efficient updating.
Also, when the mask layer gets resized, make sure we mark it as needing
display.
Tested by pixel result of compositing/masks/simple-composited-mask.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::didDraw):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::reshape):
* rendering/RenderBox.cpp:
(WebCore::layersUseImage):
(WebCore::RenderBox::imageChanged):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::notifyFinished):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::contentChanged):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::contentChanged):
* rendering/RenderLayerBacking.h:
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updatePlayer):
2010-12-14 Mark Rowe <mrowe@apple.com>
Reviewed by Sam Weinig.
<http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
We were crashing inside MediaPlayerPrivateQTKit::createQTMovie as we were passing a null URL in
to CFNetworkCopyProxiesForURL. This happened because we were null-checking the URL incorrectly.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::resumeLoad): Explicitly test for a null string.
2010-12-14 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=50970
It's arguably a bug, but we don't let inline flow layers paint floating
descendants. The containing block of the inline flow paints them instead.
However our shouldPaint logic has always been flawed and has turned off propagation
of painting when an inline flow layer is enclosing the float.
Change enclosingSelfPaintingLayer to enclosingFloatPaintingLayer to be more precise
and for now limit it to RenderBoxes.
Added fast/block/float/floatstack.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverhangingFloats):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::enclosingFloatPaintingLayer):
* rendering/RenderBox.h:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
2010-12-14 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Move asynchronous event dispatching out of Document
https://bugs.webkit.org/show_bug.cgi?id=49785
Move asynchonous event code out of Document and into a standalone
EventQueue class (which supports async events for both regular nodes
and the window object).
No new tests necessary, since no new functionality is exposed (existing
layout tests pass).
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::enqueueWindowEvent):
(WebCore::Document::enqueueHashchangeEvent):
* dom/DOMAllInOne.cpp:
(WebCore::Document::eventQueue):
* dom/Document.h:
* dom/EventQueue.cpp: Added.
(WebCore::EventQueue::EventQueue):
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::pendingEventTimerFired):
(WebCore::EventQueue::dispatchEvent):
* dom/EventQueue.h: Added.
* storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatch):
2010-12-14 Kyounga Ra <kyounga.ra@gmail.com>
Reviewed by Adam Barth.
<noscript> is rendered with enabled XHTMLMP.
https://bugs.webkit.org/show_bug.cgi?id=48493
* html/HTMLElement.cpp:
(WebCore::HTMLElement::rendererIsNeeded):
2010-12-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
https://bugs.webkit.org/show_bug.cgi?id=50231
No new tests as there is no new functionality.
Guard CONFIG+=link_pkgconfig with !symbian.
* WebCore.pro:
2010-12-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74040.
http://trac.webkit.org/changeset/74040
https://bugs.webkit.org/show_bug.cgi?id=51050
Breaks 2d.shadow.canvas.transparent.2 and
2d.shadow.image.transparent.2 (Requested by helder on
#webkit).
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::ContextShadow):
(WebCore::ContextShadow::calculateLayerBoundingRect):
* platform/graphics/ContextShadow.h:
(WebCore::ContextShadow::offset):
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformShadow):
2010-12-14 Nate Chapin <japhet@chromium.org>
Unreviewed, fixing qt (hopefully for real this time).
Remove a couple more references to loader.h.
* xml/XSLStyleSheetQt.cpp:
* xml/XSLTProcessorQt.cpp:
2010-12-14 Nate Chapin <japhet@chromium.org>
Unreviewed, fix mac and qt builds.
Missed a couple of references to loader.h and
improperly added CachedResourceRequest.h to
WebCore.xcodeproj.
* WebCore.xcodeproj/project.pbxproj:
* platform/android/TemporaryLinkStubs.cpp:
* platform/qt/TemporaryLinkStubsQt.cpp:
2010-12-14 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Rename Loader to CachedResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=50848
No new tests, rename only.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
* loader/cache/CachedCSSStyleSheet.cpp:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::setRequest):
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::cancelRequests):
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp: Copied from WebCore/loader/loader.cpp.
* loader/cache/CachedResourceRequest.h: Copied from WebCore/loader/loader.h.
* loader/loader.cpp: Removed.
* loader/loader.h: Removed.
* xml/XSLStyleSheetLibxslt.cpp:
* xml/XSLTProcessor.cpp:
* xml/XSLTProcessorLibxslt.cpp:
2010-12-14 David Hyatt <hyatt@apple.com>
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=46422
Rename pageHeight variables and members in WebCore to pageLogicalHeight in preparation for
making printing and pagination work with vertical writing modes.
* page/FrameView.cpp:
(WebCore::FrameView::forceLayoutForPagination):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):
* rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::isPaginated):
(WebCore::LayoutState::pageLogicalHeight):
(WebCore::LayoutState::pageLogicalHeightChanged):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::nextPageTop):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
* rendering/RenderView.h:
(WebCore::RenderView::pageLogicalHeight):
(WebCore::RenderView::setPageLogicalHeight):
2010-12-14 Dimitri Glazkov <dglazkov@chromium.org>
Fix GTK build by adding source files that were accidentally skipped in
r74044. Sorry!
* GNUmakefile.am: Added SliderThumbElement.
2010-12-14 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=50974
getComputedStyle() returns wrong values for zoomed elements when
display is none
-and corresponding-
<rdar://problem/8522731>
If there is no renderer but the RenderStyle's value is a fixed
length, send it through zoomAdjustedPixelValue(). There's not much
we can do for other length types without a renderer.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2010-12-13 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by David Levin.
Move SliderThumbElement into its own file.
https://bugs.webkit.org/show_bug.cgi?id=50973
No change in behavior, so no tests.
* Android.mk: Added SliderThumbElement.
* CMakeLists.txt: Ditto.
* WebCore.gyp/WebCore.gyp: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto,
* html/shadow/SliderThumbElement.cpp: Added.
* html/shadow/SliderThumbElement.h: Added.
* rendering/RenderSlider.cpp: Removed code that was moved into
SliderThumbElement.
2010-12-13 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=50953
DNS Prefetch should be an opt-in feature
No new tests, can't test DNS.
* dom/Document.h: Made initDNSPrefetch public, since Page now calls it.
* page/Page.cpp: (WebCore::Page::dnsPrefetchingStateChanged):
* page/Page.h:
Documents cache the value of this setting, so they need to be notified of changes. In particular,
the first document in a page is created before settings are applied.
* page/Settings.cpp:
(WebCore::Settings::Settings): Changed default to false.
(WebCore::Settings::setDNSPrefetchingEnabled): Notify the page about the change.
2010-12-14 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422
On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows
"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."
NOTE: this applies only to canvas, not to box shadows.
Test: fast/canvas/canvas-transforms-fillRect-shadow.html
* platform/graphics/ContextShadow.cpp:
(WebCore::ContextShadow::ContextShadow):
(WebCore::ContextShadow::calculateLayerBoundingRect):
* platform/graphics/ContextShadow.h:
(WebCore::ContextShadow::setShadowsIgnoreTransforms):
(WebCore::ContextShadow::shadowsIgnoreTransforms):
(WebCore::ContextShadow::offset):
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::mustUseContextShadow):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformShadow):
2010-12-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Rule data not updated in Styles pane after stylesheet gets reverted
https://bugs.webkit.org/show_bug.cgi?id=51034
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._onRevert):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._metricsPaneEdited):
(WebInspector.ElementsPanel.prototype._stylesPaneEdited):
(WebInspector.ElementsPanel.prototype._styleSheetChanged):
2010-12-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Avoid GraphicsContext save/restore in Image::drawPattern()
https://bugs.webkit.org/show_bug.cgi?id=51037
It's enough to restore the CompositeOperator after drawing.
* platform/graphics/qt/ImageQt.cpp:
(WebCore::Image::drawPattern):
2010-12-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/8763862>
r72017 used incorrect compiler conditional.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
2010-12-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Simplify context-menu handling code
https://bugs.webkit.org/show_bug.cgi?id=49658
* platform/ContextMenuItem.h:
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::appendItem):
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::releasePlatformDescription):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::setType):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::title):
(WebCore::ContextMenuItem::setTitle):
(WebCore::ContextMenuItem::platformSubMenu):
(WebCore::ContextMenuItem::setSubMenu):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::setEnabled):
2010-12-14 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
https://bugs.webkit.org/show_bug.cgi?id=27048
Handle focus change for text objects based in caret changes.
As text objects (such as paragraphs) seem not to accept focus in
WebCore in the same way other objects (text controls) do, a
Gtk-specific workaround is needed to expose this states and the
related events to ATK-based assistive technologies.
Test: platform/gtk/accessibility/caret-browsing-text-focus.html
Ensure that text objects are exposed with the ATK_STATE_FOCUSABLE
state, and that the ATK_STATE_FOCUSED state is added to those
text objects containing the currently active caret selection.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(selectionBelongsToObject): Moved upwards to use it from
the new isTextWithCaret() function.
(isTextWithCaret): New, checks whether an accessibility object
represents a text object with the current caret selection on it.
(setAtkStateSetFromCoreObject): Add the ATK_STATE_FOCUSED state
when also when isTextWithCaret(coreObject) returns true.
(webkit_accessible_ref_state_set): Add the ATK_STATE_FOCUSABLE
state to text objects and those with the ATK_ROLE_PARAGRAPH role.
(webkit_accessible_text_get_n_selections): Optimize return expression.
Make sure the proper events associated to a change of focus are
emitted, based on caret changes across different accessibility
objects. Also, refactored the code in more manageable and
understandable helper functions.
* editing/gtk/SelectionControllerGtk.cpp:
(WebCore::emitTextSelectionChange): New, includes the specific
code formerly placed in notifyAccessibilityForSelectionChange() to
emit the 'text-caret-moved' and 'text-selection-change' signals.
(WebCore::maybeEmitTextFocusChange): New, takes care of emitting
the 'focus-event' and 'state-changed::focused' signals when
needed, that is, when a change in the selection happens across
different accessible objects.
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
Refactored some code here, by using the new helper functions.
2010-12-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: regroup Inspector.idl entries.
Just for better visibility.
https://bugs.webkit.org/show_bug.cgi?id=51025
* inspector/Inspector.idl:
2010-12-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Reverted stylesheet breaks style data
https://bugs.webkit.org/show_bug.cgi?id=51030
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::reparseStyleSheet):
2010-12-14 Mads Ager <ager@chromium.org>
Reviewed by Pavel Feldman.
[V8] Reflected unsigned attributes should be in the range [0, 2^31)
https://bugs.webkit.org/show_bug.cgi?id=51023
Follow the changes made to CodeGeneratorJS.pm to return 0 for
reflected unsigned attributes that are outside the allowed range.
See https://bugs.webkit.org/show_bug.cgi?id=50472
* bindings/scripts/CodeGeneratorV8.pm:
2010-12-14 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
Remove stale include of Document.h in V8DOMWrapper.h
https://bugs.webkit.org/show_bug.cgi?id=50607
We no longer need to include Document.h or V8DOMMap.h in
V8DOMWrapper. Removing them to avoid dependencies.
* bindings/v8/V8DOMWrapper.h:
2010-12-14 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Darin Adler.
Test for: EventSource fails to connect if Content-Type header has a charset attribute
https://bugs.webkit.org/show_bug.cgi?id=45372
Tests: http/tests/eventsource/eventsource-content-type-charset.html
http/tests/eventsource/eventsource-content-type-text-event-stream-foobar.html
* page/EventSource.cpp:
(WebCore::EventSource::didReceiveResponse): Use the mimeType instead of the Content-Type
header directly. This makes the detection of the "text/stream" mimeType more accurate.
2010-12-14 Pieter Senster <psenster@google.com>
Reviewed by Dirk Schulze.
Incorporate the channel offsets from the ColorMatrix filter in the filter calculation
https://bugs.webkit.org/show_bug.cgi?id=50682
Test: svg/filters/feColorMatrix-offset.svg
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::matrix):
2010-12-14 Jarred Nicholls <jarred@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
Qt's Clipboard::files() implementation for HTML5 Drag/Drop (DataTransfer)
No new tests. Run tests manually until DRT is updated w/ beginDragWithFiles.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::files):
2010-12-13 Antonio Gomes <agomes@rim.com>
Rubber stamped by Daniel Bates.
Spatial Navigation: code clean up (part V)
https://bugs.webkit.org/show_bug.cgi?id=50666
No new tests needed.
* page/SpatialNavigation.cpp:
(WebCore::distanceDataForNode): Made 'FocusCandidate current' const since it is not
supposed to change within this function.
* page/SpatialNavigation.h: Ditto.
2010-12-13 takano takumi <takano@apple.com>
Reviewed by Dan Bernstein.
GlyphPage::fill() is slow on vertical writing (Mac)
https://bugs.webkit.org/show_bug.cgi?id=50865
No test. Just a performance improvement.
* platform/graphics/Font.cpp:
(WebCore::Font::isCJKIdeograph): Now this only checks pure ideographs (Hanji).
(WebCore::Font::isCJKIdeographOrSymbol): Added this for Hanji and Hanji related symbols.
* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter): Changed to call isCJKIdeographOrSymbol() instead of isCJKIdeograph().
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText): This tests if GlyphPage::fill() should use CoreText or not.
For vertical writing, if the current page contains only ideographs, we go CG path.
(WebCore::GlyphPage::fill): Made to call shouldUseCoreText() and switch code path.
2010-12-13 Antonio Gomes <agomes@rim.com>
Reviewed by Daniel Bates.
Spatial Navigation: code clean up (part IV)
https://bugs.webkit.org/show_bug.cgi?id=50666
Avoid calling canScrollInDirection more than necessary.
No new tests needed.
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionallyInContainer): Moved the call to canScrollInDirection()
to within the scrollInDirection().
* page/SpatialNavigation.cpp: Removed the assertion to canScrollingDirection function.
(WebCore::scrollInDirection):
2010-12-13 Antonio Gomes <agomes@rim.com>
Reviewed by Daniel Bates.
Spatial Navigation: code clean up (part III)
https://bugs.webkit.org/show_bug.cgi?id=50666
No new tests needed.
* page/SpatialNavigation.h: Added FocusCandidate::isFrameOwnerElement and
WebCore::frameOwnerElement helper functions.
(WebCore::FocusCandidate::isFrameOwnerElement): Returns true if the Node pointer
wrapped by FocusCandidate is an instance of HTMLFrameOwnerElement. Returns false
otherwise.
* page/SpatialNavigation.cpp:
(WebCore::frameOwnerElement): Returns the HTMLFrameOwnerElement associated with
the FocusCandidate if appropriate.
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded): Make use of newly added frameOwnerElement() helper.
(WebCore::FocusController::advanceFocusDirectionallyInContainer): Ditto.
2010-12-13 Mike Lawther <mikelawther@chromium.org>
Reviewed by Daniel Bates.
[skia] ignore transform for canvas shadows
https://bugs.webkit.org/show_bug.cgi?id=50437
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
2010-12-13 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
ValidityState's exposed functions should check if willValidate() is true before all
https://bugs.webkit.org/show_bug.cgi?id=50617
Added checking willValidate() to exposed functions. And modified willValidate() behavior
for <button type="submit"> and <input type="submit"> to return true if not disabled and
not readonly.
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseMappedAttribute): Added calling setNeedsWillValidateCheck() to refresh willValidate() after changing its type.
(WebCore::HTMLButtonElement::recalcWillValidate): Added to return true if not disabled and not readonly when type="submit". It's to be compliant to the spec.
* html/HTMLButtonElement.h:
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::supportsValidation): Removed it to enable willValidate() for <input> when type="submit". It's to be compliant to the spec.
(WebCore::SubmitInputType::supportsRequired): Added it to reject required attributes though validation is available.
* html/SubmitInputType.h:
* html/ValidityState.cpp: Added checking willValidate().
(WebCore::ValidityState::typeMismatch):
(WebCore::ValidityState::patternMismatch):
(WebCore::ValidityState::tooLong):
(WebCore::ValidityState::rangeUnderflow):
(WebCore::ValidityState::rangeOverflow):
(WebCore::ValidityState::stepMismatch):
(WebCore::ValidityState::customError):
* html/ValidityState.h:
2010-12-13 Noel Gordon <noel.gordon@gmail.com>
Reviewed by David Levin.
[chromium] Upstream skia/ImageBuffer.cpp routine mulDiv255Ceil()
https://bugs.webkit.org/show_bug.cgi?id=50545
Skia has rolled, replace uses of mulDiv255Ceil with SkMulDiv255Ceiling.
No new tests, no change in behaviour.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::putImageData):
2010-12-13 Gavin Peters <gavinp@chromium.org>
Reviewed by Adam Barth.
Re land Purpose after bad merge
https://bugs.webkit.org/show_bug.cgi?id=51000
* loader/loader.cpp:
(WebCore::Loader::load):
2010-12-13 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/8763696> REGRESSION (r72173): Fallback fonts’ vertical metrics aren’t accounted for even when line-height is unspecified
https://bugs.webkit.org/show_bug.cgi?id=50979
Many test results updated.
* rendering/InlineFlowBox.cpp: Reinstated the code that updates affectsAscent and
affectsDescent in the used-fonts code path. Renamed variables for clarity. Added
a check whether usedFonts is empty (which it might be if there is glyph overflow
but no fallback) as an optimization.
2010-12-13 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Jon Honeycutt.
Remove unnecessary include of Switch module.
There are no switch statements in this file.
* dom/make_names.pl:
2010-12-13 Emil Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
Change SelectionController::setFocusedNodeIfNeeded to traverse the DOM
tree instead of the render tree.
https://bugs.webkit.org/show_bug.cgi?id=50989
* editing/SelectionController.cpp:
(WebCore::SelectionController::setFocusedNodeIfNeeded):
Walk up DOM/hosted tree rather than render tree and remove FIXME comment
that does't apply (SelectionController and EventHandler needs different
checks).
2010-12-13 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: aria-invalid should be supported.
https://bugs.webkit.org/show_bug.cgi?id=50573
Test: platform/mac/accessibility/aria-invalid.html
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::invalidStatus):
* accessibility/AccessibilityObject.h:
* accessibility/chromium/AXObjectCacheChromium.cpp
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
* html/HTMLAttributeNames.in:
2010-12-13 Joone Hur <joone@kldp.org>
Reviewed by Eric Seidel.
WebKit fails to compile when building with WML support enabled
https://bugs.webkit.org/show_bug.cgi?id=42943
Use TextPosition instead of lineNumber() and columNumber().
No new tests are added, because this is just a build fix.
* dom/XMLDocumentParser.h: Make lineNumber() private.
* wml/WMLErrorHandling.cpp:
(WebCore::reportWMLError): Use TextPosition instead of lineNumber() and columnNumber().
2010-12-13 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
AX: lists and list boxes need different attributes
https://bugs.webkit.org/show_bug.cgi?id=50978
Separate out the attributes being returned for lists (<ul>) and listboxes (<select multiple>).
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2010-12-13 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=50963
REGRESSION: Scrolling nested iframes is messed up on platforms that use the cross-platform ScrollView.
The selfClipRect and childrenClipRect methods of RenderLayer were incorrectly relying on the bounding box
of the root layer. This bounding box was only coincidentally incorporating overflow as part of the
RenderLayer's bounds. Since I fixed the RenderLayer bounds to not include layout overflow any longer,
this check is now exposed as incorrect. Use the entire document size when computing layer clip
rects.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::childrenClipRect):
(WebCore::RenderLayer::selfClipRect):
* rendering/RenderView.h:
(WebCore::RenderView::documentRect):
2010-12-13 Simon Fraser <simon.fraser@apple.com>
GraphicsContextPrivate.h was removed. Nuke it from the project.
* WebCore.xcodeproj/project.pbxproj:
2010-12-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
HTMLMediaElement::endedPlayback should not return true if duration is zero
https://bugs.webkit.org/show_bug.cgi?id=50962
(WebCore::HTMLMediaElement::endedPlayback): Don't return true when duration is zero because a
media file can't play if it has no duration, therefore it can't have ended playback.
2010-12-13 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build fix after r73840.
* WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Update property file
to pass three arguments to build-generated-files.sh, just like
the official Apple port.
2010-12-13 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Make sure the defaultSpaceEventHandler does logical scrolling.
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultSpaceEventHandler):
2010-12-13 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=50591 Adopt new CG API for canvas
No new tests necessary.
* Configurations/WebCore.xcconfig: Added IOSurface framework link.
* html/canvas/CanvasRenderingContext2D.cpp: Used IOSurface def. instead.
* platform/graphics/ImageBuffer.h: Pushed renderingMode down into ctor.
* platform/graphics/cairo/ImageBufferCairo.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/haiku/ImageBufferHaiku.cpp:
* platform/graphics/qt/ImageBufferQt.cpp:
* platform/graphics/skia/ImageBufferSkia.cpp:
* platform/graphics/wince/ImageBufferWinCE.cpp:
* platform/graphics/wx/ImageBufferWx.cpp:
2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73923.
http://trac.webkit.org/changeset/73923
https://bugs.webkit.org/show_bug.cgi?id=50944
Broke editing/selection/extend-selection-home-end.html on non-
mac platforms. Looks like a real bug. (Requested by ojan on
#webkit).
* editing/SelectionController.cpp:
(WebCore::SelectionController::positionForPlatform):
(WebCore::SelectionController::modifyExtendingForward):
2010-12-13 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PageUp/PageDwn should respect writing-mode.
Add logical scrolling to WebCore. It basically mirrors physical scrolling but works in abstract logical
directions and only converts to physical when it's time to attempt the scroll.
Also fixed bugs in scrollRecursively and logicalScrollRecursively where overflow sections in containing
frames got skipped over.
Made the resetting of the inline axis scroll position on Home/End Mac-specific for overflow sections.
* WebCore.exp.in:
* page/EventHandler.cpp:
(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::scrollRecursively):
(WebCore::EventHandler::logicalScrollRecursively):
* page/EventHandler.h:
* page/FrameView.cpp:
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):
* page/FrameView.h:
* platform/ScrollTypes.h:
(WebCore::logicalToPhysical):
* platform/ScrollView.cpp:
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::logicalScroll):
* platform/ScrollView.h:
(WebCore::ScrollView::isVerticalDocument):
(WebCore::ScrollView::isFlippedDocument):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::logicalScroll):
* rendering/RenderBox.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scroll):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::logicalScroll):
* rendering/RenderListBox.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::logicalScroll):
* rendering/RenderTextControlSingleLine.h:
2010-12-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rollout 73914, 73915, 73917, 73920 and 73921.
REGRESSION(r73914): "Chromium page_cycler_morejs fails" (Requested by yurys on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=50950
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* bindings/js/JSWorkerContextErrorHandler.cpp: Renamed from WebCore/bindings/js/JSErrorHandler.cpp.
(WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler):
(WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler):
(WebCore::JSWorkerContextErrorHandler::handleEvent):
* bindings/js/JSWorkerContextErrorHandler.h: Renamed from WebCore/bindings/js/JSErrorHandler.h.
(WebCore::JSWorkerContextErrorHandler::create):
(WebCore::createJSWorkerContextErrorHandler):
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8ConsoleMessage.cpp:
(WebCore::V8ConsoleMessage::dispatchNow):
(WebCore::V8ConsoleMessage::handler):
* bindings/v8/V8ConsoleMessage.h:
* bindings/v8/V8WindowErrorHandler.cpp: Removed.
* bindings/v8/V8WindowErrorHandler.h: Removed.
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::v8MessageHandler):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* dom/Document.cpp:
(WebCore::Document::reportException):
(WebCore::Document::addMessage):
* dom/Document.h:
* dom/ErrorEvent.cpp:
* dom/ErrorEvent.h:
* dom/Event.cpp:
* dom/Event.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didOpen):
(WebCore::WebSocketChannel::appendToBuffer):
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::readStatusLine):
(WebCore::WebSocketHandshake::readHTTPHeaders):
(WebCore::WebSocketHandshake::checkResponseHeaders):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::postExceptionTask):
(WebCore::postConsoleMessageTask):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
(WebCore::WorkerContext::reportException):
(WebCore::WorkerContext::addMessage):
* workers/WorkerContext.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerExceptionTask::performTask):
(WebCore::postConsoleMessageTask):
* xml/XMLHttpRequest.cpp:
(WebCore::reportUnsafeUsage):
2010-12-13 Antti Koivisto <antti@apple.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=50758
<rdar://problem/8722094>
Defer loading print stylesheets
- Make preload scanner skip stylesheets with non-screen media types.
- Make it possible to specify non-default load priority from the client.
- Use this mechanism to load print stylesheets using very low priority so they get loaded after everything else.
- Move default priority code from Loader to CachedResource.
- Move ResourceLoadScheduler::Priority enum to a separate file (as ResourceLoadPriority).
- Add a way to make ResourceLoadScheduler load resources one at the time so the above functionality can be tested reliably.
Tests: http/tests/local/link-stylesheet-load-order-preload.html
http/tests/local/link-stylesheet-load-order.html
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLNames::PreloadTask::PreloadTask):
(WebCore::HTMLNames::PreloadTask::processAttributes):
(WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
(WebCore::HTMLNames::PreloadTask::linkMediaAttributeIsScreen):
(WebCore::HTMLNames::PreloadTask::preload):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
* loader/ResourceLoadPriority.h: Added.
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
(WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
(WebCore::ResourceLoadScheduler::schedulePluginStreamLoad):
(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
(WebCore::ResourceLoadScheduler::HostInformation::schedule):
(WebCore::ResourceLoadScheduler::HostInformation::remove):
(WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
(WebCore::ResourceLoadScheduler::HostInformation::limitRequests):
* loader/ResourceLoadScheduler.h:
(WebCore::ResourceLoadScheduler::isSerialLoadingEnabled):
(WebCore::ResourceLoadScheduler::setSerialLoadingEnabled):
(WebCore::ResourceLoadScheduler::HostInformation::requestsPending):
* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
(WebCore::CachedResource::CachedResource):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::loadPriority):
(WebCore::CachedResource::setLoadPriority):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::requestPreload):
* loader/cache/CachedResourceLoader.h:
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::requestResource):
* loader/cache/MemoryCache.h:
* loader/loader.cpp:
(WebCore::Loader::load):
2010-12-13 Justin Schuh <jschuh@chromium.org>
Reviewed by Dimitri Glazkov.
Build fix for r73927
https://bugs.webkit.org/show_bug.cgi?id=50946
Reverting CSSCanvasValue::canvasDestroyed to its code before r73927
because it's breaking the build and I changed it only because it
appeared redunudant after r73927.
No behavior changed so no new tests needed.
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::canvasDestroyed):
2010-12-13 Matthew Delaney <mdelaney@apple.com>
Reviewed by nobody, build fix.
Unlinking IOSurface framework from xcodeproj.
* WebCore.xcodeproj/project.pbxproj:
2010-12-13 Justin Schuh <jschuh@chromium.org>
Reviewed by Dimitri Glazkov.
HTMLCanvasElement should handle multiple observers.
https://bugs.webkit.org/show_bug.cgi?id=50899
Test: fast/canvas/canvas-bg-multiple-removal.html
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::~CSSCanvasValue):
(WebCore::CSSCanvasValue::canvasDestroyed):
(WebCore::CSSCanvasValue::element):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::~HTMLCanvasElement):
(WebCore::HTMLCanvasElement::addObserver):
(WebCore::HTMLCanvasElement::removeObserver):
(WebCore::HTMLCanvasElement::didDraw):
(WebCore::HTMLCanvasElement::reset):
* html/HTMLCanvasElement.h:
2010-12-13 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
[Chromium] canvas/philip/tests/2d.missingargs.html hangs on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=50841
Test: fast/canvas/strokeText-missing-args.html
We didn't have isfinite checks for the x and y coordinates that are
passed to strokeText/drawTextInternal (unlike all the other methods,
which got checks in r50910 and r59447).
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
2010-12-09 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Adopt new CG API for canvas
https://bugs.webkit.org/show_bug.cgi?id=50591
No new tests. All current layout tests are sufficient.
* html/HTMLCanvasElement.cpp: Add in accelerateRendering flag for imagebuffer creation.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::isAccelerated): Always return true if using CA on new platforms.
(WebCore::CanvasRenderingContext2D::drawTextInternal): Use accelerateRendering for imagebuffer.
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create): Plumb through new flag.
* platform/graphics/cairo/ImageBufferCairo.cpp: Update method sig.
* platform/graphics/cg/ImageBufferCG.cpp: Switch off of accelerateRendering flag for new accelerated paths.
* platform/graphics/cg/ImageBufferData.h: Add in surface ref
* platform/graphics/haiku/ImageBufferHaiku.cpp: Update method sig.
* platform/graphics/qt/ImageBufferQt.cpp: ^^
* platform/graphics/skia/ImageBufferSkia.cpp: ^^
* platform/graphics/wince/ImageBufferWinCE.cpp: ^^
* platform/graphics/wx/ImageBufferWx.cpp: ^^
* platform/mac/WebCoreSystemInterface.h: Add new method sigs
* platform/mac/WebCoreSystemInterface.mm: ^^
* rendering/RenderLayerBacking.cpp:
* rendering/RenderLayerCompositor.cpp: Set acceleratesDrawing for canvas backings.
2010-12-13 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ojan Vafai.
Shift-End does not select to the end of the line
https://bugs.webkit.org/show_bug.cgi?id=50610
Test: editing/selection/extend-to-line-boundary.html
* editing/SelectionController.cpp:
(WebCore::SelectionController::positionForPlatform): Use visibleStart/visibleEnd rather than
start/end.
(WebCore::SelectionController::modifyExtendingForward):
2010-12-13 Adam Roben <aroben@apple.com>
Windows build fix after r73914
* WebCore.vcproj/WebCore.vcproj: Fix malformed XML.
2010-12-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Qt build fix.
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
2010-12-13 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526
Enable "MoveTo{Beginninng|End}OfDocument" commands when caret
browsing is enabled.
This change impacts the GTK-port only as caret browsing is a
feature only used in that platform so far.
Test: platform/gtk/editing/selection/caret-mode-document-begin-end.html
* editing/EditorCommand.cpp:
(WebCore::createCommandMap): Enable the commads when in caret browsing.
2010-12-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Qt build fix.
* dom/Event.cpp:
(WebCore::Event::isErrorEvent):
* dom/Event.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not
only in workers.
2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.
https://bugs.webkit.org/show_bug.cgi?id=50906
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetState):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.didCommitLoad):
* inspector/front-end/Database.js:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.pausedScript):
(WebInspector.DebuggerModel.prototype.resumedScript):
(WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown):
(WebInspector.DebuggerModel.prototype.debuggerWasEnabled):
(WebInspector.DebuggerModel.prototype.debuggerWasDisabled):
(WebInspector.DebuggerModel.prototype.parsedScriptSource):
(WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
(WebInspector.DebuggerModel.prototype.didCreateWorker):
(WebInspector.DebuggerModel.prototype.didDestroyWorker):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
* inspector/front-end/ResourceManager.js:
(WebInspector.ResourceManager):
(WebInspector.ResourceManager.prototype._unbindResourceURL):
(WebInspector.ResourceManager.prototype.updateDOMStorage):
(WebInspector.ResourceManager.prototype.updateApplicationCacheStatus):
(WebInspector.ResourceManager.prototype.didGetFileSystemPath):
(WebInspector.ResourceManager.prototype.didGetFileSystemError):
(WebInspector.ResourceManager.prototype.didGetFileSystemDisabled):
(WebInspector.ResourceManager.prototype.updateNetworkState):
(WebInspector.ResourceManager.prototype.addDOMStorage):
(WebInspector.ResourceManager.prototype.selectDOMStorage):
(WebInspector.ResourceManager.prototype.addDatabase):
(WebInspector.ResourceManager.prototype.selectDatabase):
(WebInspector.ResourceManager.prototype.sqlTransactionSucceeded):
(WebInspector.ResourceManager.prototype.sqlTransactionFailed):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.Worker):
* inspector/front-end/inspector.js:
2010-12-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Qt build fix.
* dom/ErrorEvent.cpp:
* dom/ErrorEvent.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not
only in workers.
2010-12-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519
Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.
It was decided to dispatch ErrorEvent to all listeners/handlers no matter if they
were created in the same isolated world where the exception occured or not.
Tests: fast/events/window-onerror1.html
fast/events/window-onerror10.html
fast/events/window-onerror11.html
fast/events/window-onerror2.html
fast/events/window-onerror3.html
fast/events/window-onerror4.html
fast/events/window-onerror5.html
fast/events/window-onerror6.html
fast/events/window-onerror7.html
fast/events/window-onerror8.html
fast/events/window-onerror9.html
http/tests/security/window-onerror-exception-in-iframe.html
userscripts/window-onerror-for-isolated-world-1.html
userscripts/window-onerror-for-isolated-world-2.html
* Android.jscbindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* bindings/js/JSErrorHandler.cpp: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.cpp.
(WebCore::JSErrorHandler::JSErrorHandler):
(WebCore::JSErrorHandler::~JSErrorHandler):
(WebCore::JSErrorHandler::handleEvent):
* bindings/js/JSErrorHandler.h: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
(WebCore::JSErrorHandler::create):
(WebCore::createJSErrorHandler):
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8ConsoleMessage.cpp:
(WebCore::V8ConsoleMessage::dispatchNow):
(WebCore::V8ConsoleMessage::handler): the method was changed to use generic WebCore exception
reporting mechanism which is also used by JSC bindings.
* bindings/v8/V8ConsoleMessage.h:
* bindings/v8/V8WindowErrorHandler.cpp: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
(WebCore::V8WindowErrorHandler::V8WindowErrorHandler):
(WebCore::V8WindowErrorHandler::callListenerFunction):
* bindings/v8/V8WindowErrorHandler.h: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
(WebCore::V8WindowErrorHandler::create):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::v8MessageHandler):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* dom/Document.cpp:
(WebCore::Document::errorEventTarget):
(WebCore::Document::logExceptionToConsole):
* dom/Document.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::PendingException::PendingException):
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::reportException): this method is not virtual anymore to
ensure that error event dispatching algorithm is the same in WorkerContext and in Document.
(WebCore::ScriptExecutionContext::dispatchErrorEvent):
* dom/ScriptExecutionContext.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::postExceptionTask):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
(WebCore::WorkerContext::errorEventTarget):
(WebCore::WorkerContext::logExceptionToConsole):
* workers/WorkerContext.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerExceptionTask::performTask):
2010-12-08 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Enable CSS property editing name/value-wise (like Firebug does)
https://bugs.webkit.org/show_bug.cgi?id=50565
For CSS property editing, the property name and value have become two fields separated
by a colon (rather than one field containing the full property text.) A user can tab
between the name and value fields forward and backward. A colon typed in the name field
and a semicolon in the value field (unless found inside a string) act as a Tab and focus
the next editable field (while applying the entire property value.)
Now a user can tab through all editable styles for an element, even across rule boundaries.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
(WebInspector.DataGrid.prototype._startEditing):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
(WebInspector.ElementsTreeElement.prototype._startEditingTagName):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype.startEditing):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
* inspector/front-end/Section.js:
(WebInspector.Section):
(WebInspector.Section.prototype.get subtitleAsTextForTest):
(WebInspector.Section.prototype.get nextSibling):
(WebInspector.Section.prototype.get previousSibling):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.nextEditableSibling):
(WebInspector.StylePropertiesSection.prototype.previousEditableSibling):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.StylePropertiesSection.prototype.startEditingSelector):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype.):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._handleDoubleClick):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionTreeElement.prototype.startEditing):
* inspector/front-end/inspector.css:
(.child-editing):
* inspector/front-end/inspector.js:
(WebInspector.startEditing.defaultFinishHandler):
(WebInspector.startEditing):
* inspector/front-end/treeoutline.js:
(TreeElement.prototype.select):
2010-12-13 Yael Aharon <yael.aharon@nokia.com>
Unreviewed.
Added svn propery eol-style. Patches to this file fail to apply on Windows EWS bot.
* accessibility/AccessibilityAllInOne.cpp: Added property svn:eol-style.
2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73898.
http://trac.webkit.org/changeset/73898
https://bugs.webkit.org/show_bug.cgi?id=50919
FileSystem and Database API's were broken (Requested by loislo
on #webkit).
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetState):
* inspector/front-end/DOMAgent.js:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.debuggerPaused):
(WebInspector.DebuggerModel.prototype.debuggerResumed):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
* inspector/front-end/ResourceManager.js:
(WebInspector.ResourceManager):
(WebInspector.ResourceManager.prototype._registerNotifyHandlers):
(WebInspector.ResourceManager.prototype._unbindResourceURL):
* inspector/front-end/inspector.js:
(WebInspector.addDatabase):
(WebInspector.addDOMStorage):
(WebInspector.updateDOMStorage):
(WebInspector.updateApplicationCacheStatus):
(WebInspector.didGetFileSystemPath):
(WebInspector.didGetFileSystemError):
(WebInspector.didGetFileSystemDisabled):
(WebInspector.updateNetworkState):
(WebInspector.attachDebuggerWhenShown):
(WebInspector.debuggerWasEnabled):
(WebInspector.debuggerWasDisabled):
(WebInspector.profilerWasEnabled):
(WebInspector.profilerWasDisabled):
(WebInspector.parsedScriptSource):
(WebInspector.restoredBreakpoint):
(WebInspector.failedToParseScriptSource):
(WebInspector.pausedScript):
(WebInspector.resumedScript):
(WebInspector.resetProfilesPanel):
(WebInspector.didCommitLoad):
(WebInspector.addProfileHeader):
(WebInspector.setRecordingProfile):
(WebInspector.addHeapSnapshotChunk):
(WebInspector.finishHeapSnapshot):
2010-12-13 Anton Muhin <antonm@chromium.org>
Reviewed by Pavel Feldman.
[v8] More CSS wrappers GC work: keep document's style sheets, style sheet and css rule lists' items in proper object groups
https://bugs.webkit.org/show_bug.cgi?id=50828
* bindings/v8/DOMData.h:
(WebCore::DOMData::WrapperMapObjectRemover::visitDOMWrapper):
(WebCore::DOMData::removeObjectsFromWrapperMap):
* bindings/v8/DOMDataStore.h:
(WebCore::ChunkedTable::visit):
(WebCore::ChunkedTable::visitEntries):
(WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit):
(WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
* bindings/v8/V8DOMMap.cpp:
(WebCore::removeAllDOMObjectsInCurrentThread):
(WebCore::visitDOMNodesInCurrentThread):
(WebCore::visitDOMObjectsInCurrentThread):
(WebCore::visitActiveDOMObjectsInCurrentThread):
(WebCore::visitDOMSVGElementInstancesInCurrentThread):
* bindings/v8/V8DOMMap.h:
(WebCore::WeakReferenceMap::visit):
* bindings/v8/V8GCController.cpp:
(WebCore::DOMObjectVisitor::visitDOMWrapper):
(WebCore::EnsureWeakDOMNodeVisitor::visitDOMWrapper):
(WebCore::GCPrologueVisitor::visitDOMWrapper):
(WebCore::NodeGrouperVisitor::visitDOMWrapper):
(WebCore::NodeGrouperVisitor::applyGrouping):
(WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
(WebCore::GCEpilogueVisitor::visitDOMWrapper):
2010-12-13 Zoltan Herczeg <zherczeg@webkit.org>
Unreviewed build fix for r73894.
SVGFEImage should also check its hasResult() in its apply().
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::apply):
2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
Debugger and Resources related notification functions of Inspector.idl were
marked as such with help of "domain" attribute. The other changes in js files
are reflecting this change. Some wrappers in WebInspector namespace were dropped,
the others were moved to DebuggerModel class.
https://bugs.webkit.org/show_bug.cgi?id=50906
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::resetState):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.didCommitLoad):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype.pausedScript):
(WebInspector.DebuggerModel.prototype.resumedScript):
(WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown):
(WebInspector.DebuggerModel.prototype.debuggerWasEnabled):
(WebInspector.DebuggerModel.prototype.debuggerWasDisabled):
(WebInspector.DebuggerModel.prototype.parsedScriptSource):
(WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype.addHeapSnapshots):
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
* inspector/front-end/ResourceManager.js:
(WebInspector.ResourceManager):
(WebInspector.ResourceManager.prototype._unbindResourceURL):
(WebInspector.ResourceManager.prototype.updateDOMStorage):
(WebInspector.ResourceManager.prototype.updateApplicationCacheStatus):
(WebInspector.ResourceManager.prototype.didGetFileSystemPath):
(WebInspector.ResourceManager.prototype.didGetFileSystemError):
(WebInspector.ResourceManager.prototype.didGetFileSystemDisabled):
(WebInspector.ResourceManager.prototype.updateNetworkState):
(WebInspector.ResourceManager.prototype.addDatabase):
(WebInspector.ResourceManager.prototype.addDOMStorage):
* inspector/front-end/inspector.js:
2010-12-13 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
Better result passing in filter primitives
https://bugs.webkit.org/show_bug.cgi?id=49907
SVG filter primitives can use the output of other filters. The
input and output format of a filter can be a premultiplied or
unmultiplied RGBA array, or an image buffer. All filter
primitive results were converted to image buffers before, which
could be an unecessary (and really costly) operation, if
a filter expects its input in the same format as the output
of the input filter primitive. This overhead is removed by
this patch. All apply() methods are updated according to this
new filter primitive interface.
Filters do not generate their results twice (or more) anymore,
when their apply() called multiple times.
The existing tests cover this feature.
* manual-tests/svg-filter-animation.svg: Added.
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::apply):
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::apply):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::apply):
* platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::apply):
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::apply):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::apply):
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::apply):
* platform/graphics/filters/FEMerge.cpp:
(WebCore::FEMerge::apply):
* platform/graphics/filters/FEMerge.h:
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::apply):
* platform/graphics/filters/FEOffset.cpp:
(WebCore::FEOffset::apply):
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::apply):
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::apply):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::requestedRegionOfInputImageData):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
(WebCore::FilterEffect::copyImageBytes):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::hasResult):
* platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::apply):
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::apply):
* platform/graphics/filters/SourceGraphic.h:
* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::apply):
2010-12-13 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed.
* WebCore.pro: Remove non-existant loader/Request.h from build system.
2010-12-13 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Eric Seidel.
[chromium] Reduce canvas.toDataURL("image/jpeg") run-time cost by 10%
https://bugs.webkit.org/show_bug.cgi?id=50804
Follow on from r73173, unroll the SkUnPreMultiply::PMColorToColor() call
viz., compute the unpremultiplatcion in-place. This reduces the run-time
cost of jpeg encoding by 10-15% for my image test set.
No new tests: canvas.toDataURL() is covered by existing tests.
* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::preMultipliedBGRAtoRGB):
2010-12-13 Helder Correia <helder@sencha.com>
Reviewed by Eric Seidel.
[Qt] StillImage::draw() should use ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=50849
The branch that checks for a shadow requirement in StillImage::draw()
is executed when drawing a canvas onto a canvas with
ctx1.drawImage(canvas2, x, y). The current implementation supports
solid shadows only. And if transformations are present, the offset gets
transformed as well. Thus, ContextShadow must be used instead in order
to support blur and correct offset transformations.
Test: fast/canvas/canvas-draw-canvas-on-canvas-shadow.html
* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::draw):
2010-12-12 Jon Honeycutt <jhoneycutt@apple.com>
Unreviewed build fix.
* editing/EditingAllInOne.cpp:
Add new file to the all-in-one.
2010-12-12 Jon Honeycutt <jhoneycutt@apple.com>
Unreviewed build fix.
* WebCore.vcproj/WebCore.vcproj:
Remove accidentally-committed conflict marker.
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
- Introduced SpellChecker class to encapsulate asynchronous spell
checker state: sequence id, requesting text and target node.
This is also the first step to decompose spell-check related
code to a separate class.
- Added EditorClient::isAsynchronousSpellCheckingEnabled()
to use async spellcheck API on the platform.
These APIs are touched by SpellChecker.
- Used SpellChecker to check a pasted test. Text to check is
collected from the subtree under the editingRoot.
- Added Setting::m_asynchronousSpellCheckingEnabled to control
async spell checking.
Test: editing/spelling/spellcheck-paste.html
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::showMarkers):
(showDocumentMarkers):
* dom/DocumentMarkerController.h:
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::setOffsetInLeafNode):
* dom/PositionIterator.h:
* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::Editor):
(WebCore::findFirstMarkable):
(WebCore::Editor::selectionStartHasSpellingMarkerFor):
* editing/Editor.h:
(WebCore::Editor::spellChecker):
* editing/SpellChecker.cpp: Added.
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::~SpellChecker):
(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::isAsynchronousEnabled):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::isCheckable):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::forwardIterator):
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h: Added.
(WebCore::SpellCheckingResult::SpellCheckingResult):
(WebCore::SpellCheckingResult::type):
(WebCore::SpellCheckingResult::location):
(WebCore::SpellCheckingResult::length):
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::requestCheckingOfString):
* page/EditorClient.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setAsynchronousSpellCheckingEnabled):
(WebCore::Settings::asynchronousSpellCheckingEnabled):
2010-12-09 Antonio Gomes <agomes@rim.com>
Reviewed by Daniel Bates.
Spatial Navigation: code clean up (part II)
https://bugs.webkit.org/show_bug.cgi?id=50666
No new tests needed.
* page/FocusController.cpp: Removed static declaration of updateFocusCandidateIfNeeded() from
the top of FocusController.cpp, and added the 'static' keyword where the function is implemented;
* page/SpatialNavigation.cpp: In FocusCandidate constructor, renamed 'n' to 'node', and added an assert to it;
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::virtualRectForAreaElementAndDirection): Added an assert to 'node';
* page/SpatialNavigation.h:I reordered the declaration of some methods in order to group related ones;
Removed isScrollableContainerNode() function declaration since it is not used outside SpatialNavigation.cpp;
And removed the declaration of isNodeDeepDescendantOfDocument() since it does not exist anymore.
2010-12-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
build-webkit --gtk --minimal fails
https://bugs.webkit.org/show_bug.cgi?id=46267
No new tests, build fix only.
* GNUmakefile.am: Include some JS bindings generated headers in
the build even if their corresponding feature is disabled. They
are needed to make the DOM bindings build.
2010-12-12 Sam Magnuson <smagnuso@gmail.com>
Reviewed by Eric Seidel.
[Qt] Compile with QT_NO_QUUID_STRING.
https://bugs.webkit.org/show_bug.cgi?id=49745
* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
2010-12-12 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Eric Seidel.
[Qt] Missing style for date pickers on Qt Mobile theme
https://bugs.webkit.org/show_bug.cgi?id=50628
* css/themeQtMobile.css:
2010-12-11 Alice Liu <alice.liu@apple.com>
Mac build fix.
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
Resolve string[0] ambiguity by passing 0U.
2010-12-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
[V8] Move to DOMWindow::setLocation
https://bugs.webkit.org/show_bug.cgi?id=50876
Recently, JavaScriptCore moved to implementing setLocation in WebCore.
This patch change V8 to use that common code path. I haven't removed
the old code path because it's still used for other things (like
assigning window.location.href), but I'll move the rest over in a
future patch.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::locationAccessorSetter):
* bindings/v8/specialization/V8BindingState.cpp:
(WebCore::::getFirstWindow):
* bindings/v8/specialization/V8BindingState.h:
2010-10-11 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Mock DeviceOrientation client for DRT
https://bugs.webkit.org/show_bug.cgi?id=47490
* WebCore.pro:
2010-12-11 Joone Hur <joone@kldp.org>
Reviewed by Alexey Proskuryakov.
enumeration value ‘ResponseTypeArrayBuffer’ not handled in switch
https://bugs.webkit.org/show_bug.cgi?id=50871
Fix the warning which occurs when enumeration value is not handled in switch.
No new tests, no change in behavior.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::response):
2010-12-11 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Add an overload to makeString for Vector<char>
https://bugs.webkit.org/show_bug.cgi?id=50123
This also contains a segfault fix for ImageBuffer::toDataURL of the Haiku port.
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/haiku/ImageBufferHaiku.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
2010-12-10 Alexey Proskuryakov <ap@apple.com>
Mac build fix.
* platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
Resolve string[0] ambiguity by passing 0U.
2010-12-10 Steve Falkenburg <sfalken@apple.com>
Windows production build fix.
Only the vsprops are indirected through WebKitVSPropsRedirectionDir, not the scripts in WebKitLibraries/win/tools/scripts.
* WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
* WebCore.vcproj/build-generated-files.sh:
2010-12-10 John Knottenbelt <jknotten@chromium.org>
Reviewed by Eric Seidel.
Remove WebCore/platform/mac/GeolocationService.{h,mm}
https://bugs.webkit.org/show_bug.cgi?id=50074
Remove unused non-client-based geolocation code.
* platform/mac/GeolocationServiceMac.h: Removed.
* platform/mac/GeolocationServiceMac.mm: Removed.
2010-12-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46573
<rdar://problem/8479389> REGRESSION: charset="utf-8" (with quotes) doesn't work
Test: http/tests/mime/quoted-charset.php
* platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
Work around a CFNetwork issue, strip quotes if they are present.
2010-12-10 Vincent Scheib <scheib@chromium.org>
Reviewed by James Robinson.
Shader::loadShader() must initialize variable passed to getShaderiv
https://bugs.webkit.org/show_bug.cgi?id=50842
Test: fast/canvas/canvas-largedraws.html
* platform/graphics/gpu/Shader.cpp:
(WebCore::Shader::loadShader):
2010-12-10 Vincent Scheib <scheib@chromium.org>
Reviewed by James Robinson.
Texture::updateSubRect should pass IntRect by reference
https://bugs.webkit.org/show_bug.cgi?id=50845
No test, changing to pass by ref.
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::updateSubRect):
* platform/graphics/gpu/Texture.h:
2010-12-10 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Move open and showModalDialog implementations from bindings into DOM class DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=50836
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::open): Removed most of the code and changed to call
DOMWindow::open.
(WebCore::DialogHandler::DialogHandler): Added. Object is used to handle the
arguments and return value in showModalDialog.
(WebCore::DialogHandler::dialogCreated): Ditto.
(WebCore::DialogHandler::returnValue): Ditto.
(WebCore::setUpDialog): Added. Function passed to showModalDialog that just
casts pointer to DialogHandler can calls dialogCreated.
(WebCore::JSDOMWindow::showModalDialog): Removed most of the code and changed
to call DOMWindow::showModalDialog.
(WebCore::JSDOMWindow::postMessage): Made style match the rest of the file by
renaming local variables and getting rid of a needless ones.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parseModalDialogFeatures): Moved body of this function
to the WindowFeatures class.
(WebCore::DOMWindow::allowPopUp): Renamed argument from activeFrame to firstFrame,
because that's the frame we pass in here. Also added an overload so this can be
called on a window rather than a frame.
(WebCore::DOMWindow::setLocation): Renamed a couple variables so the names are
the same as in open and showModalDialog. Factored the JavaScript security check
into a new function named isInsecureScriptAccess.
(WebCore::DOMWindow::isInsecureScriptAccess): Here is the new function.
(WebCore::DOMWindow::createWindow): Added. Contains logic shared by open and
showModalDialog just as the function named createWindow in JSDOMWindowCustom.cpp
used to.
(WebCore::DOMWindow::open): Added. Code from JSDOMWindowCustom without the
JavaScript language binding part, and with a bit of refactoring to share code
with the rest of the DOMWindow class.
(WebCore::DOMWindow::showModalDialog): Ditto.
* page/DOMWindow.h: Moved conditional parts of the file into separate paragraphs
in alphabetical order so they are not scattered thorugh the file. Removed redundant
includes. Added some blank lines for clarity. Added an open function and a
showModalDialog function. Added private createWindow and isInsecureScriptAccess
functions.
* page/WindowFeatures.cpp:
(WebCore::isWindowFeaturesSeparator): Renamed from isSeparator for clarity.
(WebCore::WindowFeatures::WindowFeatures): Updated for name change. Used isEmpty
instead of checking length. Added a new constructor for use when making dialogs,
with code from the showModalDialog function.
(WebCore::WindowFeatures::boolFeature): Use DialogFeaturesMap typedef.
(WebCore::WindowFeatures::floatFeature): Use DialogFeaturesMap typedef.
Renamed a local variable and tweaked the comments a bit.
(WebCore::WindowFeatures::parseDialogFeatures): Added. Code moved here from
DOMWindow::parseDialogFeatures and refactored a bit.
* page/WindowFeatures.h: Added new constructor, new parseDialogFeatures
function, DialogFeaturesMap typedef, and made setWindowFeature function private.
2010-12-10 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
https://bugs.webkit.org/show_bug.cgi?id=50574
Refactors accessibility hit testing to allow for a more flexible model when handling elements
with fake sub-elements (like sliders or list boxes).
Renamed doAccessibilityHitTest -> accessibilityHitTest, which is called on the root
accessibility render object. Then subclassers are able to override
elementAccessibilityHitTest to return their own specific elements.
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::elementAccessibilityHitTest):
* accessibility/AccessibilityListBox.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessibilityHitTest):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::elementAccessibilityHitTest):
* accessibility/AccessibilitySlider.h:
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_component_ref_accessible_at_point):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
2010-12-10 Kenneth Russell <kbr@google.com>
Reviewed by Darin Adler.
Clean up assertion in Extensions3DOpenGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=50852
Built Release mode to test. No functionality change.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::ensureEnabled):
2010-12-10 Cosmin Truta <ctruta@chromium.org>
Reviewed by Eric Seidel.
Crash while processing ill-formed <textPath> ouside of <text>
https://bugs.webkit.org/show_bug.cgi?id=47759
Renderers within a <text> subtree are created only when their corresponding elements
satisfy the content model.
Test: svg/custom/invalid-text-content.svg
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::childShouldCreateRenderer): Fixed to comply with the content model.
(WebCore::SVGTRefElement::rendererIsNeeded): Added.
* svg/SVGTRefElement.h:
* svg/SVGTSpanElement.cpp:
(WebCore::SVGTSpanElement::childShouldCreateRenderer): Fixed to comply with the content model.
(WebCore::SVGTSpanElement::rendererIsNeeded): Added.
* svg/SVGTSpanElement.h: Changed indentation.
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::childShouldCreateRenderer): Reformatted.
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::childShouldCreateRenderer): Fixed to comply with the content model.
(WebCore::SVGTextPathElement::rendererIsNeeded): Added.
* svg/SVGTextPathElement.h:
2010-12-10 Zhenyao Mo <zmo@google.com>
Reviewed by Adam Barth.
Use enums instead of booleans in ImageSource/ImageDecoder constructors
https://bugs.webkit.org/show_bug.cgi?id=50818
This patch basically defines two enum type in ImageSource: AlphaOption
and GammaAndColorProfileOption and use them as ImageSource and ImageDecoder
constructor parameters instead of boolean typs.
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::ImageSource):
(WebCore::ImageSource::setData):
* platform/graphics/ImageSource.h: Define the two enum types.
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::ImageSource):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoder::create):
(WebCore::ImageDecoderQt::ImageDecoderQt):
* platform/graphics/qt/ImageDecoderQt.h:
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::ImageDecoder):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::BMPImageDecoder):
* platform/image-decoders/bmp/BMPImageDecoder.h:
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::ICOImageDecoder):
(WebCore::ICOImageDecoder::decodeAtIndex):
* platform/image-decoders/ico/ICOImageDecoder.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::JPEGImageDecoder):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::PNGImageDecoder):
* platform/image-decoders/png/PNGImageDecoder.h:
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::WEBPImageDecoder):
* platform/image-decoders/webp/WEBPImageDecoder.h:
2010-12-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r73799): editing/execCommand/4920488.html fails
https://bugs.webkit.org/show_bug.cgi?id=50854
The regression was caused by Range::processContents's not extracting
m_end.container()->firstChild(). Fixed the bug by always adding the first child.
* dom/Range.cpp:
(WebCore::Range::processContents):
2010-12-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION: Infinite redirect on developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=45627
Tests: fast/loader/form-submit-aborts-parsing.html
fast/loader/location-change-aborts-parsing.html
This patch is not pretty, but it fixes the bug. I stole this approach
from the old HTML parser (as suggested by Eric Seidel). The other
approaches that folks tried for this bug are better, but it's inclear
how to get them to work correctly. I've added a large FIXME comment.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::isParsingFragment):
2010-12-10 Brian Weinstein <bweinstein@apple.com>
Reviewed by Ada Chan.
When we are creating a ContextMenuItem, only call setSubMenu if we have
a subMenu to set.
* platform/ContextMenuItem.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
2010-12-10 Kenneth Russell <kbr@google.com>
Unreviewed, another build fix. #include <wtf/UnusedParam.h> needed
for Release builds.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
2010-12-10 Kenneth Russell <kbr@google.com>
Unreviewed, build fix. Change #ifndef NDEBUG to #ifdef NDEBUG.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::ensureEnabled):
2010-12-10 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Implement extension entry points and remove EXTENSIONS enum
https://bugs.webkit.org/show_bug.cgi?id=40316
Implemented WebGLRenderingContext's getSupportedExtensions and
getExtensions entry points, and, to verify them, added support for
the first specified WebGL extension, OES_texture_float. This
extension is now advertised in the Chromium and WebKit ports when
the underlying hardware supports it.
The new OES_texture_float test in the WebGL conformance suite
verifies the allocation and population of floating point textures,
and their use as render targets. However, because this extension
is optional, it is not easily testable with a layout test; there
is only one set of expectations for a given test, and two would be
needed, one when the extension is available and one when it is not.
Tested with the oes-texture-float.html WebGL conformance test in
Chromium and WebKit on Mac OS X on hardware that supports the
extension. Also verified with a configuration that does not
advertise the extension that this same test passes.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
(WebCore::JSWebGLRenderingContext::markChildren):
(WebCore::JSWebGLRenderingContext::getExtension):
(WebCore::JSWebGLRenderingContext::getSupportedExtensions):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
* html/canvas/OESTextureFloat.cpp: Added.
(WebCore::OESTextureFloat::OESTextureFloat):
(WebCore::OESTextureFloat::~OESTextureFloat):
(WebCore::OESTextureFloat::getName):
(WebCore::OESTextureFloat::create):
* html/canvas/OESTextureFloat.h: Added.
* html/canvas/OESTextureFloat.idl: Added.
* html/canvas/WebGLExtension.cpp: Added.
(WebCore::WebGLExtension::WebGLExtension):
(WebCore::WebGLExtension::~WebGLExtension):
* html/canvas/WebGLExtension.h: Added.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncData):
(WebCore::WebGLRenderingContext::getNumberOfExtensions):
(WebCore::WebGLRenderingContext::getExtensionNumber):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLRenderingContext.idl:
* platform/graphics/Extensions3D.h:
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
(WebCore::GraphicsContext3D::extractTextureData):
(WebCore::doUnpackingAndPacking):
(WebCore::doPacking):
(WebCore::doFloatingPointPacking):
(WebCore::GraphicsContext3D::packPixels):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supports):
(WebCore::Extensions3DOpenGL::ensureEnabled):
* platform/graphics/opengl/Extensions3DOpenGL.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D):
* platform/graphics/qt/Extensions3DQt.cpp:
(WebCore::Extensions3DQt::ensureEnabled):
* platform/graphics/qt/Extensions3DQt.h:
2010-12-10 Darin Adler <darin@apple.com>
Try to fix Windows build.
* dom/Range.cpp:
(WebCore::Range::processContents): Put typedef of NodeVector inside the function
instead of at the top of the file, since the use is restricted to this function.
There's another NodeVector in ContainerNode.cpp.
2010-12-09 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Prep for WebKit2: Context menu support on Windows
https://bugs.webkit.org/show_bug.cgi?id=50514
Before this patch ContextMenu on Windows were backed by HMENUs, and ContextMenuItems
were backed by MENUITEMINFOs. This meant they couldn't be copied, and they needed to
be to work in WebKit2.
This patch adds a new USE flag - CROSS_PLATFORM_CONTEXT_MENUS that are for a cross-platform
representation of context menus. This patch also has Windows adopt them.
Cross-platform context menus change the API of context menus and the ContextMenuClient. There
is no more idea of a PlatformMenuDescription or a PlatformMenuItemDescription. Menus are backed
by a Vector of ContextMenuItems, and menu items are backed by the variables they need (enabled, checked
title, action, type, and submenu).
This patch also refactors the ContextMenuClient interface to use a variation on the getCustomMenuFromDefaultItems
function to allow for customization of the context menu.
For other ports to use CROSS_PLATFORM_CONTEXT_MENUS, all they need to do is write conversion functions from
a ContextMenu <-> native menu type, and ContextMenuItem <-> native menu item type. For Windows, this is done
in ContextMenuWin.cpp and ContextMenuItemWin.cpp.
No new tests, no change in behavior.
* WebCore.vcproj/WebCore.vcproj: Add new files (only needed on Windows for now).
* loader/EmptyClients.h:
(WebCore::EmptyContextMenuClient::customizeMenu): Define this function if CROSS_PLATFORM_CONTEXT_MENUS
is on.
* page/ContextMenuClient.h: Ditto.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu): Call customizeMenu instead of
getCustomMenuFromDefaultItems if CROSS_PLATFORM_CONTEXT_MENUS is on.
* platform/ContextMenu.cpp: Added.
(WebCore::ContextMenu::ContextMenu): Empty constructor.
(WebCore::ContextMenu::setItems): Sets the items in the menu.
(WebCore::ContextMenu::items): Returns the items in the menu.
(WebCore::ContextMenu::itemAtIndex):
(WebCore::itemWithActionInMenu): Returns the item with the correct action, recursively descending
into submenus.
(WebCore::ContextMenu::itemWithAction): Calls through to itemWithActionInMenu.
* platform/ContextMenu.h: Added a new set of functions and member variables that are defined for
CROSS_PLATFORM_CONTEXT_MENUS.
(WebCore::ContextMenu::appendItem): Appends an item to the menu.
* platform/ContextMenuItem.cpp: Added.
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::setSubMenu):
* platform/ContextMenuItem.h:
(WebCore::ContextMenuItem::type): Returns the type.
(WebCore::ContextMenuItem::setType): Sets the type.
(WebCore::ContextMenuItem::action): Returns the action.
(WebCore::ContextMenuItem::setAction): Sets the action.
(WebCore::ContextMenuItem::title): Returns the title.
(WebCore::ContextMenuItem::setTitle): Sets the title.
(WebCore::ContextMenuItem::checked): Returns whether or not the menu item is checked.
(WebCore::ContextMenuItem::setChecked): Sets whether ot not the menu item is checked.
(WebCore::ContextMenuItem::enabled): Returns whether or not the menu item is enabled.
(WebCore::ContextMenuItem::setEnabled): Sets whether or not the menu item is enabled.
(WebCore::ContextMenuItem::submenu): Returns the submenu.
* platform/PlatformMenuDescription.h: Remove the idea if a PlatformMenuDescription if
CROSS_PLATFORM_CONTEXT_MENUS is on.
* platform/win/ContextMenuItemWin.cpp:
(WebCore::ContextMenuItem::ContextMenuItem): Creates a ContextMenuItem from a MENUITEMINFO.
(WebCore::ContextMenuItem::nativeMenuItem): Creates and returns a MENUITEMINFO.
* platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::ContextMenu): Creates a ContextMenu from an HMENU.
(WebCore::ContextMenu::nativeMenu): Creates and returns an HMENU.
2010-12-10 Emil Eklund <eae@chromium.org>
Reviewed by Adam Barth.
Fix crash in ReplaceSelectionCommand::doApply when selection is modified
during execution.
https://bugs.webkit.org/show_bug.cgi?id=50840
Test: editing/execCommand/insertHTML-mutation-crash.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::copyStyleToChildren):
Replaced raw node pointer with RefPtr.
(WebCore::ReplaceSelectionCommand::doApply):
Replaced raw node pointer with RefPtr and added null check.
2010-12-10 Emil Eklund <eae@chromium.org>
Reviewed by Adam Barth.
Fix crash in Range::processContents when modified during mutation event.
https://bugs.webkit.org/show_bug.cgi?id=50710
Test: fast/dom/Range/range-extractContents.html
* dom/Range.cpp:
(WebCore::Range::processContents):
Replace raw pointers with RefPtrs and add checks.
2010-12-09 Enrica Casucci <enrica@apple.com>
Reviewed by Alexey Proskuryakov.
Implement IME support for Mac.
<rdar://problem/7660589> WebKit2: Implement IME support for Mac.
https://bugs.webkit.org/show_bug.cgi?id=50788
* dom/KeyboardEvent.h:
(WebCore::KeypressCommand::KeypressCommand): Removed ASSERT in constructor,
since it is now used for more than one command.
2010-12-10 Jessie Berlin <jberlin@apple.com>
Windows build fix. Unreviewed.
* WebCore.vcproj/WebCore.vcproj:
Remove duplicate </File> tag.
2010-12-09 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Barth.
TextResourceDecoder::checkForHeadCharset can look way past the limit.
https://bugs.webkit.org/show_bug.cgi?id=47397
Replaced charset detection algorithm with real parser.
Added tests for parser bugs mentioned in the thread for this bug report.
Converted hixie's encoding parsing tests to a layout test.
Tests: fast/encoding/bracket-in-script.html
fast/encoding/bracket-in-tag.html
fast/encoding/escaped-bracket.html
fast/encoding/meta-in-body.html
fast/encoding/meta-in-script.html
fast/encoding/meta-in-title.html
fast/encoding/mismatched-end-tag.html
fast/encoding/namespace-meta.html
fast/encoding/not-http-equiv-content.html
fast/encoding/parser-tests.html
fast/encoding/quotes-in-title.html
fast/encoding/tag-name-digit.html
http/tests/misc/charset-sniffer-end-sniffing.html
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/parser/HTMLMetaCharsetParser.cpp: Added.
(WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser):
(WebCore::HTMLMetaCharsetParser::~HTMLMetaCharsetParser):
(WebCore::HTMLMetaCharsetParser::extractCharset):
(WebCore::HTMLMetaCharsetParser::processMeta):
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):
* html/parser/HTMLMetaCharsetParser.h: Added.
(WebCore::HTMLMetaCharsetParser::create):
(WebCore::HTMLMetaCharsetParser::encoding):
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset):
(WebCore::TextResourceDecoder::checkForMetaCharset):
* loader/TextResourceDecoder.h:
2010-12-10 Nate Chapin <japhet@chromium.org>
Reviewed by Antti Koivisto.
Merge Loader and Request. Currently, Loader is a singleton attached
to MemoryCache. Our goal is to remove knowledge of the loading process
from MemoryCache, so we should attach Loader to CachedResourceLoader instead.
Once Loader is moved off of MemoryCache, there's no reason it needs to be a singleton,
which removes the main reason for Request existing as a separate class (to store per-request
state that Loader couldn't).
Loader will be given a more descriptive name in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=49837
Refactor only, no new tests.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* loader/FrameLoader.cpp:
* loader/Request.cpp:
* loader/Request.h:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone): Was setLoadInProgress(false),
plus other CachedResourceLoader cleanup that had been handled in Loader.
(WebCore::CachedResourceLoader::cancelRequests): Moved from Loader.
(WebCore::CachedResourceLoader::requestCount):
* loader/cache/CachedResourceLoader.h:
(WebCore::CachedResourceLoader::loadFinishing): Was setLoadInProgress(true)
* loader/cache/MemoryCache.h:
* loader/loader.cpp:
(WebCore::Loader::Loader):
(WebCore::Loader::~Loader):
(WebCore::Loader::load):
(WebCore::Loader::willSendRequest):
(WebCore::Loader::didFinishLoading):
(WebCore::Loader::didFail):
(WebCore::Loader::didReceiveResponse):
(WebCore::Loader::didReceiveData):
(WebCore::Loader::didReceiveCachedMetadata):
* loader/loader.h:
(WebCore::Loader::cachedResourceLoader):
2010-12-10 Martin Robinson <mrobinson@igalia.com>
Unreviewed, rolling out r73703.
http://trac.webkit.org/changeset/73703
https://bugs.webkit.org/show_bug.cgi?id=49658
This patch is causing crashes on the GTK+ bots.
* platform/ContextMenuItem.h:
(WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::appendItem):
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::createNativeMenuItem):
(WebCore::ContextMenuItem::releasePlatformDescription):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::setType):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::title):
(WebCore::ContextMenuItem::setTitle):
(WebCore::ContextMenuItem::platformSubMenu):
(WebCore::ContextMenuItem::setSubMenu):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::setEnabled):
2010-12-08 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
fast/canvas/canvas-getImageData-negative-source.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=47901
Test: fast/canvas/canvas-getImageData-rounding.html
static_cast<unsigned> is generally not what we want in
convertLogicalToDevice. It produces inconsistent results when compiling
for 32-bit vs. 64-bit, and in any case we weren't getting correct
rounding behavior for source rectangles (e.g. we should get a source rect
of width 2 if the source X is 0.9 and the source width is 0.2, but we
were getting only one of width 1).
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::convertLogicalToDevice):
(WebCore::HTMLCanvasElement::convertToValidDeviceSize):
* html/HTMLCanvasElement.h:
2010-12-10 Hironori Bono <hbono@chromium.org>
Reviewed by Ojan Vafai.
[Chromium] Use libjpeg-turbo instead of libjpeg
https://bugs.webkit.org/show_bug.cgi?id=50054
This change replaces the hard-coded path to the GYP files of the JPEG
library with a 'libjpeg_gyp_path' variable, which is added by Chromium
r68453. (When building WebKit Chromium, this change sets its value to
'<(chromium_src_dir)/third_party/libjpeg/libjpeg.gyp' to avoid changing
the current behavior.)
No new tests since this does not change the code at all.
* WebCore.gyp/WebCore.gyp:
2010-12-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Got rid of the NonZeroBeginTimeFlag. Functionality is now hidden inside
the implementation.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
* platform/graphics/ca/PlatformCAAnimation.h:
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(hasNonZeroBeginTimeFlag):
(setNonZeroBeginTimeFlag):
(PlatformCAAnimation::PlatformCAAnimation):
(PlatformCAAnimation::setBeginTime):
2010-12-10 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: eliminate SourceFrameDelegate by passing scripts to SourceFrame constructor.
https://bugs.webkit.org/show_bug.cgi?id=50679
* inspector/front-end/Script.js:
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
(WebInspector.SourceFrame.prototype._breakpointAdded):
(WebInspector.SourceFrame.prototype._doEditLine):
(WebInspector.SourceFrame.prototype._commitEditLine):
(WebInspector.SourceFrame.prototype._breakpoints):
(WebInspector.SourceFrame.prototype._sourceIDForLine):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
2010-12-10 Andreas Kling <kling@webkit.org>
Reviewed by Eric Seidel.
Don't do GraphicsContext save/restore just to preserve the CompositeOperator
https://bugs.webkit.org/show_bug.cgi?id=50070
Add GraphicsContext::compositeOperation() so we don't have to do a full
save/restore if the only context-tainting call is setCompositeOperation().
GraphicsContext::setCompositeOperation() now stores the op in its state
and calls a port-specific setPlatformCompositeOperation().
No new tests, this is an optimization.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setCompositeOperation):
(WebCore::GraphicsContext::compositeOperation):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContextPrivate.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/Image.cpp:
(WebCore::Image::fillWithSolidColor):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/skia/SkiaUtils.cpp:
(WebCore::WebCoreCompositeToSkiaComposite):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
2010-12-10 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
GraphicsContext: Merge m_common and m_data
https://bugs.webkit.org/show_bug.cgi?id=49914
Move data members from GraphicsContextPrivate into GraphicsContext. So GraphicsContextPlatform.h
and m_common became unnecessary. They are removed.
Add two methods to GraphicsContext: platformInit() and platformDestroy(), which
make the constructor of GraphicsContext clearer.
Besides add a getter to the private GraphicsContext::m_state member, because some inline
functions in cairo need it.
No new test is needed, because this is a refactoring.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(WebCore::GraphicsContext::setStrokeThickness):
(WebCore::GraphicsContext::setStrokeStyle):
(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setShadow):
(WebCore::GraphicsContext::clearShadow):
(WebCore::GraphicsContext::getShadow):
(WebCore::GraphicsContext::strokeThickness):
(WebCore::GraphicsContext::strokeStyle):
(WebCore::GraphicsContext::strokeColor):
(WebCore::GraphicsContext::strokeColorSpace):
(WebCore::GraphicsContext::fillRule):
(WebCore::GraphicsContext::setFillRule):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::fillColor):
(WebCore::GraphicsContext::fillColorSpace):
(WebCore::GraphicsContext::setShouldAntialias):
(WebCore::GraphicsContext::shouldAntialias):
(WebCore::GraphicsContext::state):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
(WebCore::GraphicsContext::fillGradient):
(WebCore::GraphicsContext::strokeGradient):
(WebCore::GraphicsContext::fillPattern):
(WebCore::GraphicsContext::strokePattern):
(WebCore::GraphicsContext::setShadowsIgnoreTransforms):
(WebCore::GraphicsContext::updatingControlTints):
(WebCore::GraphicsContext::setUpdatingControlTints):
(WebCore::GraphicsContext::setPaintingDisabled):
(WebCore::GraphicsContext::paintingDisabled):
(WebCore::GraphicsContext::textDrawingMode):
(WebCore::GraphicsContext::setTextDrawingMode):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/GraphicsContextPrivate.h: Removed.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::drawPathShadow):
(WebCore::fillCurrentCairoPath):
(WebCore::strokeCurrentCairoPath):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::getAlpha):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeRect):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformInit):
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformInit):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
2010-12-10 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce a pair of set/remove methods for each breakpoint type.
https://bugs.webkit.org/show_bug.cgi?id=50809
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setEventListenerBreakpoint):
(WebCore::InspectorController::removeEventListenerBreakpoint):
(WebCore::InspectorController::hasEventListenerBreakpoint):
(WebCore::InspectorController::setXHRBreakpoint):
(WebCore::InspectorController::removeXHRBreakpoint):
(WebCore::InspectorController::hasXHRBreakpoint):
(WebCore::InspectorController::clearNativeBreakpoints):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setDOMBreakpoint):
(WebCore::InspectorDOMAgent::removeDOMBreakpoint):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
(WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
(WebCore::InspectorDOMAgent::descriptionForDOMEvent):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.NativeBreakpoint):
(WebInspector.DOMBreakpoint):
(WebInspector.EventListenerBreakpoint):
(WebInspector.XHRBreakpoint):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.debuggerPaused):
2010-12-10 Adam Roben <aroben@apple.com>
Windows production build fix after r72555
* WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Use
"$(WebKitVSPropsRedirectionDir)..\..\WebKitLibraries\win" to find the
.vsprops files, rather than $(WebKitLibrariesDir).
2010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by nobody, build fix.
[Qt] Second attempt to fix the build with Qt 4.6 broken in 73710.
* platform/network/qt/QtNAMThreadSafeProxy.cpp:
(WebCore::QtNetworkReplyThreadSafeProxy::QtNetworkReplyThreadSafeProxy):
(WebCore::QtNetworkReplyThreadSafeProxy::localCustomRequest):
* platform/network/qt/QtNAMThreadSafeProxy.h:
2010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by nobody, build fix.
[Qt] Fix the build with Qt 4.6 broken in 73710.
* platform/network/qt/QtNAMThreadSafeProxy.cpp:
(WebCore::QtNetworkReplyThreadSafeProxy::QtNetworkReplyThreadSafeProxy):
* platform/network/qt/QtNAMThreadSafeProxy.h:
2010-12-10 Emil Eklund <eae@chromium.org>
Reviewed by Eric Seidel.
Change EventHandler::dispatchMouseEvent code to use DOM traversal instead of render tree traversal
https://bugs.webkit.org/show_bug.cgi?id=49982
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
Walk up DOM/hosted tree rather than render tree.
2010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support a QNetworkAccessManager affined to a different thread.
https://bugs.webkit.org/show_bug.cgi?id=50080
This patch introduce thread safe proxy classes for QNetworkAccessManager
and QNetworkReply.
If run in the same thread, these objects will forward the calls with
Qt::DirectConnection bindings, while in the other case they will use
Qt::QueuedConnection to carry requests accross threads.
This patch basically:
- Makes sure that all access goes through these objects
- Reorders signal connections to make sure we are connected when the
signal comes
- Makes sure that no QObject in the WebCore thread is a child of the
reply which might be in a different thread.
- Forward the data directly in QByteArrays in signals instead of collecting
the data when the signal is handled.
New test: tst_QWebPage::networkAccessManagerOnDifferentThread
* WebCore.pro:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::commitLoad):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::~QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::setLoadMode):
(WebCore::QNetworkReplyHandler::abort):
(WebCore::QNetworkReplyHandler::release):
(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::sendQueuedItems):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/QtNAMThreadSafeProxy.cpp: Added.
* platform/network/qt/QtNAMThreadSafeProxy.h: Added.
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::willLoadFromCache):
* platform/qt/CookieJarQt.cpp:
(WebCore::networkAccessManager):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
2010-12-09 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Refactor QNetworkReplyHandler::finish() to prevent crashes.
https://bugs.webkit.org/show_bug.cgi?id=50761
This patch change the order to check if m_reply is null instead,
explicitly deleting the reply before calling start() for a redirect,
or after calling didFinishLoading()/didFail() in other cases.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
2010-12-09 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make sure we send the response before any data.
https://bugs.webkit.org/show_bug.cgi?id=50760
This patch make sure the data available flag is set before
we call sendResponseIfNeeded.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::resetState):
* platform/network/qt/QNetworkReplyHandler.h:
2010-12-10 Koan-Sin Tan <koansin.tan@gmail.com>
Reviewed by Dan Bernstein.
Bopomofo should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp
https://bugs.webkit.org/show_bug.cgi?id=50668
No new tests. Note that, as said in the bug report discussion,
I did have a test case for the bug. However, to show the test
case you need some "broken" Microsoft copyrighted fonts, such
as DFKai-SB.
* platform/graphics/Font.cpp:
(WebCore::Font::isCJKIdeograph):
2010-12-10 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Simplify context-menu handling code
https://bugs.webkit.org/show_bug.cgi?id=49658
* platform/ContextMenuItem.h:
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::appendItem):
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::releasePlatformDescription):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::setType):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::title):
(WebCore::ContextMenuItem::setTitle):
(WebCore::ContextMenuItem::platformSubMenu):
(WebCore::ContextMenuItem::setSubMenu):
(WebCore::ContextMenuItem::setChecked):
(WebCore::ContextMenuItem::setEnabled):
2010-12-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] un-needed methods
https://bugs.webkit.org/show_bug.cgi?id=50805
No new tests, code cleanup only.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
2010-12-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] data: source could also support non-base64 encoded URIs
https://bugs.webkit.org/show_bug.cgi?id=30007
Removed our ancient implementation of dataurisrc. We should now
use the one in gst-plugins-bad which is more mature.
* GNUmakefile.am:
* platform/graphics/gstreamer/DataSourceGStreamer.cpp: Removed.
* platform/graphics/gstreamer/DataSourceGStreamer.h: Removed.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::doGstInit):
2010-12-10 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Eric Seidel.
[Qt] Fix crashes in debug mode
https://bugs.webkit.org/show_bug.cgi?id=49976
The m_methods hashmap of QtInstance contains InternalFunctions
whose depend on the current RuntimeObject. When we recreate the
RuntimeObject, we should also reset this hashmap.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::newRuntimeObject):
2010-12-10 François Sausset <sausset@gmail.com>
Reviewed by Eric Seidel.
MathML: update baselinePosition() call in RenderMathMLBlock.cpp
https://bugs.webkit.org/show_bug.cgi?id=50540
The call of baselinePosition() is outdated: new arguments added.
* mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paint):
2010-12-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674
Use floating point to represent numeric keys,
add version meta data to the SQLite db,
and migrate object stores that use integers.
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::createTables):
(WebCore::migrateDatabase):
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBKey.cpp:
(WebCore::IDBKey::IDBKey):
(WebCore::IDBKey::fromQuery):
(WebCore::IDBKey::bind):
(WebCore::IDBKey::bindWithNulls):
* storage/IDBKey.h:
(WebCore::IDBKey::create):
(WebCore::IDBKey::number):
2010-12-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Gtk] style="font-family: courier" makes text disappear
https://bugs.webkit.org/show_bug.cgi?id=47452
Don't ever use fonts that do not have any of the three charmaps that
Fontconfig supports (Unicode, Apple Roman and Symbol). If we select
a font that doesn't have one of these charmaps, use the next font in
the list.
Test: platform/gtk/fonts/font-with-no-valid-encoding.html
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::createFontPlatformData): Check whether the
font we selected has a valid Fontconfig charmap.
* platform/graphics/freetype/FontPlatformData.h: Added new method definition.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::hasCompatibleCharmap): Added this method which
verifies that a font has a valid Fontconfig charmap.
2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Make DOM Mutation Events Asynchronous
https://bugs.webkit.org/show_bug.cgi?id=46936
Implemented DOM mutations events as scoped events. A scoped event is an event whose
dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
on its constructor and destructor respectively.
When the scoping level is 0 (initial level), scoped events are dispatched as soon as
they are enqueued and act like synchronous events. When the scoping level is greater than 0,
however, events are queued in ScopedEventQueue and their dispatches are delayed until
the scoping level goes back to 0 (by the destruction of EventQueueScope).
DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
of the events until the completion of each call of EditCommand::doApply.
Test: fast/events/mutation/execCommands.html
* Android.mk: Added ScopedEventQueue.cpp.
* CMakeLists.txt: Ditto.
* WebCore.pro: Ditto.
* GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
* WebCore.gypi: Ditto.
* WebCore.vcproj/project.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent.
(WebCore::dispatchChildRemovalEvents): Ditto.
* dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
* dom/Element.cpp:
(WebCore::Element::dispatchAttrRemovalEvent): Ditto.
(WebCore::Element::dispatchAttrAdditionEvent): Ditto.
* dom/Node.cpp:
(WebCore::Node::dispatchScopedEvent): Added.
(WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
* dom/Node.h:
* dom/ScopedEventQueue.cpp: Added.
(WebCore::ScopedEventQueue::initialize): Added.
(WebCore::ScopedEventQueue::enqueueEvent): Added.
(WebCore::ScopedEventQueue::dispatchAllEvents): Added.
(WebCore::ScopedEventQueue::dispatchEvent): Added.
(WebCore::ScopedEventQueue::instance): Added.
(WebCore::ScopedEventQueue::incrementScopingLevel): Added.
(WebCore::ScopedEventQueue::decrementScopingLevel): Added.
* dom/ScopedEventQueue.h: Added.
(WebCore::ScopedEventQueue::~ScopedEventQueue): Added.
(WebCore::ScopedEventQueue::ScopedEventQueue): Added.
(WebCore::EventQueueScope::EventQueueScope): Added.
(WebCore::EventQueueScope::~EventQueueScope): Added.
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply): Instantiates EventQueueScope.
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73684.
http://trac.webkit.org/changeset/73684
https://bugs.webkit.org/show_bug.cgi?id=50801
"missing bug number" (Requested by rniwa on #webkit).
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* dom/DOMAllInOne.cpp:
* dom/Element.cpp:
(WebCore::Element::dispatchAttrRemovalEvent):
(WebCore::Element::dispatchAttrAdditionEvent):
* dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchUIEvent):
* dom/Node.h:
* dom/ScopedEventQueue.cpp: Removed.
* dom/ScopedEventQueue.h: Removed.
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
2010-12-09 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] enable orientation flag when QtMobility available
https://bugs.webkit.org/show_bug.cgi?id=50781
When QtMobility available, enable orientation flag by default.
* features.pri:
2010-12-09 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Improve validation API support of <object> and <keygen>
https://bugs.webkit.org/show_bug.cgi?id=50663
Adds validation API to HTMLObjectElement class.
Makes HTMLKeygenElement::willValidate() return false.
Test: fast/forms/setCustomValidity-existence.html
* html/HTMLKeygenElement.h:
(WebCore::HTMLKeygenElement::willValidate): Added.
* html/HTMLObjectElement.h:
(WebCore::HTMLObjectElement::validationMessage): Added.
(WebCore::HTMLObjectElement::checkValidity): Added.
(WebCore::HTMLObjectElement::setCustomValidity): Added.
* html/HTMLObjectElement.idl: Added validation API properties.
2010-12-09 Sadrul Habib Chowdhury <sadrul@chromium.org>
Reviewed by Kent Tamura.
Make sure a non-zero value is used for tile-width to avoid a crash
https://bugs.webkit.org/show_bug.cgi?id=50341
The scaled tile width can be very small at times (e.g. with 'style: font 1
required'). So use a minimum width of 1 instead of using 0 (which leads to a
crash).
Tests: fast/dom/HTMLProgressElement/progress-element-with-style-crash.html
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintProgressBar):
2010-12-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Implemented DOM mutations events as scoped events. A scoped event is an event whose
dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by
EventQueueScope objects (RAII idiom), which increments and decrements the scoping level
on its constructor and destructor respectively.
When the scoping level is 0 (initial level), scoped events are dispatched as soon as
they are enqueued and act like synchronous events. When the scoping level is greater than 0,
however, events are queued in ScopedEventQueue and their dispatches are delayed until
the scoping level goes back to 0 (by the destruction of EventQueueScope).
DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument,
DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as
scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches
of the events until the completion of each call of EditCommand::doApply.
Test: fast/events/mutation/execCommands.html
* Android.mk: Added ScopedEventQueue.cpp.
* CMakeLists.txt: Ditto.
* WebCore.pro: Ditto.
* GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h.
* WebCore.gypi: Ditto.
* WebCore.vcproj/project.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent.
(WebCore::dispatchChildRemovalEvents): Ditto.
* dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp.
* dom/Element.cpp:
(WebCore::Element::dispatchAttrRemovalEvent): Ditto.
(WebCore::Element::dispatchAttrAdditionEvent): Ditto.
* dom/Node.cpp:
(WebCore::Node::dispatchScopedEvent): Added.
(WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent.
* dom/Node.h:
* dom/ScopedEventQueue.cpp: Added.
(WebCore::ScopedEventQueue::initialize): Added.
(WebCore::ScopedEventQueue::enqueueEvent): Added.
(WebCore::ScopedEventQueue::dispatchAllEvents): Added.
(WebCore::ScopedEventQueue::dispatchEvent): Added.
(WebCore::ScopedEventQueue::instance): Added.
(WebCore::ScopedEventQueue::incrementScopingLevel): Added.
(WebCore::ScopedEventQueue::decrementScopingLevel): Added.
* dom/ScopedEventQueue.h: Added.
(WebCore::ScopedEventQueue::~ScopedEventQueue): Added.
(WebCore::ScopedEventQueue::ScopedEventQueue): Added.
(WebCore::EventQueueScope::EventQueueScope): Added.
(WebCore::EventQueueScope::~EventQueueScope): Added.
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply): Instantiates EventQueueScope.
2010-12-09 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix scrolling with mouse wheel in WebKit2 views. Once
we coalesce wheel events, we can re-enable this.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scroll):
2010-12-09 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
For details element, ensure that if we ended up being inline that we set out replaced
flag so that we are treated like an inline block.
https://bugs.webkit.org/show_bug.cgi?id=50671
Test: fast/html/details-element-render-inline-crash.html
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::styleDidChange): setReplaced to true if we are set as inline.
* rendering/RenderDetails.h: function definition.
2010-12-09 Jasmin Lapalme <jlapalme@druide.com>
Reviewed by Alexey Proskuryakov.
Fix a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation.
https://bugs.webkit.org/show_bug.cgi?id=50708
Test: fast/xsl/utf8-chunks.xml
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::writeToVector): now converts and returns the correct byte count when the end of the chunk is in the middle of a multibyte UTF-8 character.
2010-12-09 Vincent Scheib <scheib@chromium.org>
Reviewed by James Robinson.
Clip update rectangle for Texture::updateSubRect to texture size
https://bugs.webkit.org/show_bug.cgi?id=49929
Test: fast/canvas/canvas-largedraws.html
* platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::updateSubRect):
2010-12-09 Kenneth Russell <kbr@google.com>
Unreviewed. Another speculative Gtk build fix after r73669. Add
needed derived sources to GNUmakefile.am.
* GNUmakefile.am:
2010-12-09 Kenneth Russell <kbr@google.com>
Unreviewed. Speculative Gtk build fix after
https://bugs.webkit.org/show_bug.cgi?id=36512 / r73669. Process
all of the WebGL classes' IDL files.
* CMakeLists.txt:
2010-12-09 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Expose constructor functions for instanceof checks of WebGL objects
https://bugs.webkit.org/show_bug.cgi?id=36512
Test: fast/canvas/webgl/instanceof-test.html
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webGLActiveInfoEnabled):
(WebCore::RuntimeEnabledFeatures::webGLBufferEnabled):
(WebCore::RuntimeEnabledFeatures::webGLFramebufferEnabled):
(WebCore::RuntimeEnabledFeatures::webGLProgramEnabled):
(WebCore::RuntimeEnabledFeatures::webGLRenderbufferEnabled):
(WebCore::RuntimeEnabledFeatures::webGLShaderEnabled):
(WebCore::RuntimeEnabledFeatures::webGLTextureEnabled):
(WebCore::RuntimeEnabledFeatures::webGLUniformLocationEnabled):
* html/canvas/WebGLActiveInfo.idl: Remove OmitConstructor.
* html/canvas/WebGLBuffer.idl: Ditto.
* html/canvas/WebGLFramebuffer.idl: Ditto.
* html/canvas/WebGLProgram.idl: Ditto.
* html/canvas/WebGLRenderbuffer.idl: Ditto.
* html/canvas/WebGLShader.idl: Ditto.
* html/canvas/WebGLTexture.idl: Ditto.
* html/canvas/WebGLUniformLocation.idl: Ditto.
* page/DOMWindow.idl: Expose constructors for WebGL objects in DOMWindow.
2010-12-09 Timothy Hatcher <timothy@apple.com>
Export Color::white and Color::transparent.
Reviewed by Anders Carlsson.
* WebCore.exp.in:
2010-12-09 Sam Weinig <sam@webkit.org>
Fix failing Mac tests.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scroll): Don't smooth scroll if the default
AppleScrollAnimationEnabled is false.
2010-12-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Compositor needs to manage its VRAM use
https://bugs.webkit.org/show_bug.cgi?id=49629
This adds a basic texture manager to the Chromium compositor to limit the amount of VRAM
used by compositor textures and switches ContentLayerChromium, ImageLayerChromium, and
RenderSurfaceChromium to use managed LayerTexture. The other *LayerChromium classes (Canvas,
Video, and WebGL) and the root layer are still unmanaged.
The TextureManager works by providing tokens to callers that want to use a managed texture.
The token can be used to request a texture, see if the previously requested texture is still
available, and to protect/unprotect textures when they cannot be collected. Whenever a
texture is created the manager attempts to free up the least recently used textures until the
total memory use is below the provided threshhold. If the manager cannot satisfy the memory
limit it will not return any new textures until some old textures are released.
A LayerTexture wraps a TextureManager token, size, and format. A LayerChromium can check if a
previously requested texture is still available for use and reserve the LayerTexture's underlying
storage between the updateContentsIfDirty() and the draw() call.
Also changes LayerChromium from having separate contentsDirty()/updateContents() calls to a single
updateContentsIfDirty().
Tests: platform/chromium/compositing/lots-of-img-layers-with-opacity.html
platform/chromium/compositing/lots-of-img-layers.html
* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateContentsIfDirty):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::cleanupResources):
(WebCore::ContentLayerChromium::updateContentsIfDirty):
(WebCore::ContentLayerChromium::updateTextureRect):
(WebCore::ContentLayerChromium::draw):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateContentsIfDirty):
(WebCore::LayerChromium::draw):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::useShader):
(WebCore::LayerRendererChromium::prepareToDrawLayers):
(WebCore::LayerRendererChromium::updateRootLayerTextureRect):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::createLayerTexture):
(WebCore::LayerRendererChromium::deleteLayerTexture):
(WebCore::LayerRendererChromium::updateLayersRecursive):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::renderSurfaceSharedValues):
(WebCore::LayerRendererChromium::textureManager):
* platform/graphics/chromium/LayerTexture.cpp: Added.
(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::~LayerTexture):
(WebCore::LayerTexture::isValid):
(WebCore::LayerTexture::reserve):
(WebCore::LayerTexture::unreserve):
(WebCore::LayerTexture::bindTexture):
(WebCore::LayerTexture::framebufferTexture2D):
* platform/graphics/chromium/LayerTexture.h: Added.
(WebCore::LayerTexture::create):
* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::updateContentsIfDirty):
* platform/graphics/chromium/PluginLayerChromium.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::SharedValues::SharedValues):
(WebCore::RenderSurfaceChromium::SharedValues::~SharedValues):
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::cleanupResources):
(WebCore::RenderSurfaceChromium::prepareContentsTexture):
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::SharedValues::shaderProgram):
(WebCore::RenderSurfaceChromium::SharedValues::shaderSamplerLocation):
(WebCore::RenderSurfaceChromium::SharedValues::shaderMatrixLocation):
(WebCore::RenderSurfaceChromium::SharedValues::shaderAlphaLocation):
(WebCore::RenderSurfaceChromium::SharedValues::initialized):
* platform/graphics/chromium/TextureManager.cpp: Added.
(WebCore::memoryUseBytes):
(WebCore::TextureManager::TextureManager):
(WebCore::TextureManager::getToken):
(WebCore::TextureManager::releaseToken):
(WebCore::TextureManager::hasTexture):
(WebCore::TextureManager::protectTexture):
(WebCore::TextureManager::unprotectTexture):
(WebCore::TextureManager::reduceMemoryToLimit):
(WebCore::TextureManager::addTexture):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h: Added.
(WebCore::TextureManager::create):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateContentsIfDirty):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateContentsIfDirty):
* platform/graphics/chromium/WebGLLayerChromium.h:
2010-12-09 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Rework my recent setLocation refactoring to use DOMWindow instead of Frame.
It's difficult to make correct security decisions based on Frame since a
Frame can navigate to a new document.
Fixes some test failures that I somehow missed before the last check-in.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Call to the
shell DOMWindow; not sure this one matters, but it's closer to the old
code before my last patch. Also pass the DOMWindow rather than the
frame to crossDomainAccessErrorMessage.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation): Pass DOMWindow rather than Frame
to the DOMWindow::setLocation function.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation): Take DOMWindow rather than Frame.
(WebCore::DOMWindow::crossDomainAccessErrorMessage): Ditto.
* page/DOMWindow.h: Update new functions to take DOMWindow rather
than Frame.
2010-12-09 Sam Weinig <sam@webkit.org>
Try and fix the mac build.
* WebCore.exp.in:
2010-12-09 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
Removed an unused variable.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights): Removed parentLineHeight.
2010-12-09 Darin Adler <darin@apple.com>
Reviewed by Geoffrey Garen.
Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
https://bugs.webkit.org/show_bug.cgi?id=50640
* bindings/js/JSDOMBinding.cpp:
(WebCore::printErrorMessageForFrame): Removed body; just call through to
DOMWindow::printErrorMessage.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body;
just call through to DOMWindow::crossDomainAccessErrorMessage.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and
firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most
of the body and moved it into DOMWindow::setLocation.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation): Added. Does all the same work that
JSDOMWindow::setLocation used to do, but in a way that's not specific
to JavaScript.
(WebCore::DOMWindow::printErrorMessage): Added.
(WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
* page/DOMWindow.h: Added setLocation, printErrorMessage, and
crossDomainAccessErrorMessage.
2010-12-09 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
WebKit2 needs smooth scrolling support on the mac
<rdar://problem/8219402>
* WebCore.xcodeproj/project.pbxproj: Change ScrollAnimatorMac.cpp to ScrollAnimatorMac.mm.
* platform/mac/ScrollAnimatorMac.cpp: Removed.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm: Copied from platform/mac/ScrollAnimatorMac.cpp.
(-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollAnimationHelperDelegate bounds]):
(-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
(-[ScrollAnimationHelperDelegate convertSizeToBase:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
(-[ScrollAnimationHelperDelegate superview]):
(-[ScrollAnimationHelperDelegate documentView]):
(-[ScrollAnimationHelperDelegate window]):
(-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
(WebCore::ScrollAnimatorMac::currentPosition):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Add implementation of ScrollAnimator for the Mac.
2010-12-09 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/8613779> and https://bugs.webkit.org/show_bug.cgi?id=50777
WebKit2 ContextMenuClient support
Export some symbols and headers needed by WebKit2 Mac:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73635.
http://trac.webkit.org/changeset/73635
https://bugs.webkit.org/show_bug.cgi?id=50778
'Side-effects on 3 css tests needs closer review' (Requested
by mwenge on #webkit).
* platform/graphics/qt/ImageQt.cpp:
(loadResourcePixmap):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::paintSearchField):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
* platform/qt/RenderThemeQt.h:
2010-12-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Search input field doesn't have cancel button
Add a cancel button to the search field and make it customizable
by the client. For now, use the close dialog button associated
with the application's style as the default.
https://bugs.webkit.org/show_bug.cgi?id=42887
* platform/graphics/qt/ImageQt.cpp:
(loadResourcePixmap):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::paintSearchField):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::convertToPaintingRect):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
* platform/qt/RenderThemeQt.h:
2010-12-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
Spatial Navigation: Crash when handling iframe of size 0.
https://bugs.webkit.org/show_bug.cgi?id=50730
if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is
that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
navigation algorithm.
Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73616.
http://trac.webkit.org/changeset/73616
https://bugs.webkit.org/show_bug.cgi?id=50772
Breaks chromium win build (Requested by hwennborg on #webkit).
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::createTables):
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBKey.cpp:
(WebCore::IDBKey::IDBKey):
(WebCore::IDBKey::fromQuery):
(WebCore::IDBKey::bind):
(WebCore::IDBKey::bindWithNulls):
* storage/IDBKey.h:
(WebCore::IDBKey::create):
(WebCore::IDBKey::number):
2010-12-09 Antonio Gomes <agomes@rim.com>
Rubber stamped by by Gustavo Noronha Silva.
Buildfix for GTK+ with building with -no-video.
paintStockIcon static function was implemented under the ENABLE(VIDEO) guard
but used from outside the guard. See RenderThemeGtk::paintSearchFieldResultsDecoration()
and RenderThemeGtk::paintSearchFieldCancelButton() methods.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
2010-12-07 Antonio Gomes <agomes@rim.com>
Reviewed by Daniel Bates.
Spatial Navigation: code clean up
https://bugs.webkit.org/show_bug.cgi?id=50666
Patch unifies two FocusCandidate constructors, making caller sites
simpler. Now the special handling HTMLAreaElement gets is done within
the non default constructor (i.e. FocusCanditate(Node*, FocusDirection)).
No new tests needed.
* page/FocusController.cpp:
(WebCore::FocusController::findFocusCandidateInContainer):
* page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
2010-12-09 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GStreamer] disable fullscreen on MacOS Tiger and Leopard
https://bugs.webkit.org/show_bug.cgi?id=50748
Don't support fullscreen video on Tiger and Leopard, just like the
QTKit player.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen):
2010-12-06 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] Support the Mozilla-style Fullscreen Javascript API
https://bugs.webkit.org/show_bug.cgi?id=50572
* GNUmakefile.am: enable the Javascript Fullscreen API feature if
it's been requested at configure time.
2010-12-09 Yong Li <yoli@rim.com>
Reviewed by Darin Adler.
Check the return value of ImageBuffer::create()
to avoid crash when ImageBuffer::create() fails.
https://bugs.webkit.org/show_bug.cgi?id=50631
No new test because it relies on the platform implementation
of ImageBuffer. It is hard to make ImageBuffer::create() fail
in most ports.
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::drawPattern):
2010-12-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement "Use Selection for Find" in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50737
<rdar://problem/8564881>
Implement a TakeFindStringFromSelection editor command. This is
used solely to implement the "Use Selection for Find" menu command
on Mac, and is not made available to script. On WebKit2, it is
very convenient to reuse the editing machinery since this command
is very similar to Copy.
* editing/Editor.h:
* editing/EditorCommand.cpp:
(WebCore::executeTakeFindStringFromSelection): Call to a mac-only Editor function.
(WebCore::enabledTakeFindStringFromSelection): Check using Editor::canCopyExcludingStandaloneImage
(WebCore::createCommandMap): Add "TakeFindStringFromSelection" command.
* editing/mac/EditorMac.mm:
(WebCore::Editor::canCopyExcludingStandaloneImages): Helper function; we can't use Editor::canCopy
since it would make no sense to enable "Use Selection for Find" when viewing a standalone image
document.
(WebCore::Editor::takeFindStringFromSelection): Implement by copying the selected text
to the special Find pasteboard.
2010-12-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
As part of r73559, I added the referenceNode check to validate whether the root
node of the iterator matches the node which is getting moved to other document.
referenceNode is initialized to root, however can get moved using previousNode
and nextNode methods, so it is required to use root directly.
https://bugs.webkit.org/show_bug.cgi?id=50764
Test: fast/dom/node-iterator-reference-node-moved-crash.html
* dom/Document.cpp:
(WebCore::Document::moveNodeIteratorsToNewDocument): change referenceNode to root.
2010-12-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Provide a generic way to store shadowParent on a Node.
https://bugs.webkit.org/show_bug.cgi?id=50184
This patch makes TreeShared::m_parent act as either parentNode() or
shadowHost() for Node. The distinction is controlled by IsShadowRootFlag.
Refactoring, so no new tests. See performance result testing in bug.
* dom/Element.cpp:
(WebCore::Element::recalcStyle): Changed to use parentOrHostNode().
* dom/Node.cpp:
(WebCore::Node::shadowHost): Added.
(WebCore::Node::setShadowHost): Added.
(WebCore::Node::isContentEditable): Changed to use parentOrHostNode().
(WebCore::Node::isContentRichlyEditable): Ditto.
(WebCore::Node::nextRenderer): Ditto.
(WebCore::Node::virtualComputedStyle): Ditto.
(WebCore::Node::canStartSelection): Ditto.
(WebCore::Node::shadowTreeRootNode): Changed to use parentNodeGuaranteedHostFree().
(WebCore::Node::getEventAncestors): Ditto.
(WebCore::Node::defaultEventHandler): Changed to use parentOrHostNode().
* dom/Node.h: Added an extra flag and adjusted bit counts.
(WebCore::Node::isShadowNode): Made non-virtual, switched to use flag.
(WebCore::Node::parentNode): Made to recognize flag.
(WebCore::Node::parentOrHostNode): Changed to use straight parent() and made const.
(WebCore::Node::parentNodeGuaranteedHostFree): Added.
(WebCore::Node::shadowParentNode): Made non-virtual and const.
* editing/TextIterator.cpp:
(WebCore::depthCrossingShadowBoundaries): Changed to use parentOrHostNode();
(WebCore::nextInPreOrderCrossingShadowBoundaries): Ditto.
(WebCore::previousInPostOrderCrossingShadowBoundaries): Ditto.
(WebCore::setUpFullyClippedStack): Ditto.
(WebCore::TextIterator::advance): Ditto.
(WebCore::SimplifiedBackwardsTextIterator::advance): Ditto.
* page/DOMSelection.cpp:
(WebCore::DOMSelection::anchorNode): Changed to use parentNodeGuaranteedHostFree().
(WebCore::DOMSelection::focusNode): Ditto.
(WebCore::DOMSelection::baseNode): Ditto.
(WebCore::DOMSelection::extentNode): Ditto.
(WebCore::DOMSelection::getRangeAt): Ditto.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
Changed to setShadowHost().
(WebCore::MediaControlShadowRootElement::updateStyle): Changed to use shadowHost().
(WebCore::MediaControlShadowRootElement::detach): Added an override to
explicitly set shadowHost to 0. Otherwise, the element will leak.
* rendering/MediaControlElements.h: Added detach def, removed members that are
no longer needed.
* rendering/RenderSVGShadowTreeRootContainer.cpp:
(WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
Added explicit clearing of shadowHost to avoid leaking and crashes,
because SVG shadow DOM can be dynamically attached/detached, producing
stale nodes in over/out event handling.
* rendering/RenderSlider.cpp:
(WebCore::SliderThumbElement::defaultEventHandler): Changed to use shadowHost().
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
Added explicit clearing of shadowHost and explicit destruction to
avoid out-of-order removal of children.
* rendering/RenderTreeAsText.cpp:
(WebCore::nodePosition): Simplified code.
* rendering/SVGShadowTreeElements.cpp:
(WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Added
setting of shadowHost.
(WebCore::SVGShadowTreeRootElement::attachElement): Changed to use shadowHost().
(WebCore::SVGShadowTreeRootElement::clearShadowHost): Added.
* rendering/SVGShadowTreeElements.h: Added def, removed members that are
no longer needed.
* rendering/ShadowElement.cpp:
(WebCore::ShadowBlockElement::initAsPart): Changed to use shadowHost().
* rendering/ShadowElement.h: Removed members that are no longer needed.
(WebCore::ShadowElement::ShadowElement): Added setting of shadowHost.
(WebCore::ShadowElement::detach): Added.
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement): Added setting
of shadowHost.
(WebCore::TextControlInnerElement::attachInnerElement): Changed to use
isShadowNode().
(WebCore::TextControlInnerElement::detach): Added.
* rendering/TextControlInnerElements.h: Removed members that are no
longer needed.
* svg/SVGElement.cpp:
(WebCore::SVGElement::ownerSVGElement): Simplified code.
(WebCore::SVGElement::viewportElement): Ditto.
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::computeCTM): Ditto.
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title): Ditto.
* svg/SVGUseElement.cpp:
(WebCore::ShadowTreeUpdateBlocker::while): Ditto.
2010-12-09 Brady Eidson <beidson@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
WebKit2 Authentication Support
* WebCore.exp.in:
2010-12-09 Peter Beverloo <peter@lvp-media.com>
Reviewed by Maciej Stachowiak.
Default CSS definitions for the figure and figcaption elements.
Tests: fast/html/figcaption-element.html
fast/html/figure-element.html
* css/html.css:
(figure): The default figure-style equals a blockquote
(figcaption): A non-sectioning block-level element
2010-12-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Console records for failed XHRs should contain call stack and request method
https://bugs.webkit.org/show_bug.cgi?id=50390
When inspector front-end is open we capture call stack at the place where request is sent and
pass the stack along with other request data. There is a new type of console messages which
is NetworkErrorMessageType, all messages of that type will have requestId field initialized
with the corresponding network request identifier so that later on when we need to display
that message in the front-end we could pull request data from the Network panel using
this identifier. If there are no data for given requestId message formatting falls back to
the old implementation which lacks such things as call stack, request method and exact
source location.
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::isEqual):
* inspector/ConsoleMessage.h:
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didReceiveResponse):
(WebCore::InspectorController::didFailLoading):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::identifierForInitialRequest):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype.toMessageElement):
(WebInspector.ConsoleMessage.prototype.toString):
(WebInspector.ConsoleMessage.prototype.isEqual):
* inspector/front-end/ResourceManager.js:
(WebInspector.ResourceManager.prototype.identifierForInitialRequest):
* inspector/front-end/inspector.js:
(WebInspector.addConsoleMessage):
* page/Console.h:
2010-12-09 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380
Test: fast/forms/select-live-pseudo-selectors.html
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html
* dom/SelectElement.cpp:
(WebCore::SelectElement::updateValidity): Added. It's a pure virtual function which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSelectElement::setNeedsValidityCheck().
(WebCore::SelectElement::parseMultipleAttribute): Added calling updateValidity().
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface.
(WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified.
(WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
(WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated..
(WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not.
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
(WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsValidityCheck().
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
* html/HTMLSelectElement.idl: Added a required attribute to select elements..
* html/ValidityState.cpp:
(WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
* wml/WMLSelectElement.h:
(WebCore::WMLSelectElement::updateValidity): Added. It does nothing.
2010-12-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
IndexedDB returns the wrong exceptions
https://bugs.webkit.org/show_bug.cgi?id=50632
IndexedDB exceptions need to have an offset so they can
be distinguished from DOM exceptions. We also need to
add strings for the various exceptions. Lastly, make
IDBDatabaseException use the common exception base class.
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* dom/ExceptionCode.cpp:
(WebCore::getExceptionCodeDescription):
* dom/ExceptionCode.h:
* storage/IDBDatabaseError.h:
(WebCore::IDBDatabaseError::code):
* storage/IDBDatabaseException.h:
(WebCore::IDBDatabaseException::create):
(WebCore::IDBDatabaseException::ErrorCodeToExceptionCode):
(WebCore::IDBDatabaseException::IDBDatabaseException):
* storage/IDBDatabaseException.idl:
2010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
GDK window size.
* plugins/gtk/gtk2xtbin.c:
(gtk_xtbin_realize):
2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
Use BUILDING_WEBKIT like other ports
https://bugs.webkit.org/show_bug.cgi?id=50713
* WebCore.pro: Change BUILD_WEBKIT to BUILDING_WEBKIT
2010-12-08 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
Replace getAttribute().isNull() with fastHasAttribute()
https://bugs.webkit.org/show_bug.cgi?id=50719
Covered by existing tests.
* dom/SelectElement.cpp:
(WebCore::SelectElement::reset):
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::rendererIsNeeded):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::itemAfter):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formNoValidate):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::noValidate):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultChecked):
(WebCore::HTMLInputElement::multiple):
(WebCore::HTMLInputElement::webkitdirectory):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::defaultSelected):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::asyncAttributeValue):
(WebCore::HTMLScriptElement::deferAttributeValue):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::allowsMultipleFiles):
(WebCore::RenderFileUploadControl::allowsDirectoryUpload):
2010-12-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
Full page size flash plugins do not show in all situations
https://bugs.webkit.org/show_bug.cgi?id=47742
This patch moves the plugin widget size allocation after the
NPP_SetWindow is called with the effect that the resize of Flash
content no longer result in grey flash. This seems logical since the
widget tree cannot be fully constructed before the plugin receives
the new container window.
Test: manual-tests/plugins/gtk-windowed-grey-glitch.html
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
2010-12-08 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Fix regression from xji's wheel scroll patch. The vertical case is looking at the horizontal
maximum position and not the vertical position.
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
2010-12-08 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726
* WebCore.xcodeproj/project.pbxproj: Expose HTMLIFrameElement.h.
2010-12-08 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Add getter and setters for acceleratesRendering flag on layers
https://bugs.webkit.org/show_bug.cgi?id=50717
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
Plumbed through acceleratedRendering flag.
2010-12-07 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
WebGLUniformLocation objects must be invalidated during linkProgram
https://bugs.webkit.org/show_bug.cgi?id=37118
* html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::WebGLProgram): Initialize link count to 0.
(WebCore::WebGLProgram::cacheActiveAttribLocations): Don't check link status through gl call; use the cached status instead.
* html/canvas/WebGLProgram.h:
(WebCore::WebGLProgram::getLinkCount): Get link count.
(WebCore::WebGLProgram::increaseLinkCount): Increase link count by 1.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniform): Fix a bug where wrong error is generated.
(WebCore::WebGLRenderingContext::linkProgram): call increaseLinkCount after linkProgram.
* html/canvas/WebGLUniformLocation.cpp:
(WebCore::WebGLUniformLocation::WebGLUniformLocation): Set program's link count upon creation.
(WebCore::WebGLUniformLocation::program): Return null if count doesn't match the program's.
(WebCore::WebGLUniformLocation::location): Return -1 if count doesn't match the program's.
* html/canvas/WebGLUniformLocation.h:
2010-12-08 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high
Test: fast/forms/placeholder-position.html
Since we center the inner text element for single line text controls,
we should ask the subclass to give us the y offset instead of trying to calculate it in the RenderTextControl class.
* rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::textBlockInsetTop):
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
* rendering/RenderTextControlSingleLine.h:
2010-12-08 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add web audio files to mac port Xcode projects
https://bugs.webkit.org/show_bug.cgi?id=50721
No new tests since audio API is not yet implemented.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::webkitAudioContext):
2010-12-08 Kent Tamura <tkent@chromium.org>
Reviewed by Alexey Proskuryakov.
Yensign hack should work with Shift_JIS and ISO-2022-JP encodings.
https://bugs.webkit.org/show_bug.cgi?id=49714
IE chooses a font which shows a yensign for 0x5c code point for a page
encoded in x-mac-japanese, ISO-2022-JP, EUC-JP, Shift_JIS, Shift_JIS_X0213-2000,
x-sjis, and Windows-31J.
We have emulated this behavior by replacing 0x5c with 0xa5 for EUC-JP and
Shift_JIS_X0213-2000. This change adds other encodings above.
Also, we move the HashSet initialization for isJapanese() and
backslashAsCurrencySymbol() to TextEncodingRegistry.cpp because of
ease of making them multi-thread safe.
* platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::isJapanese): Just calls isJapaneseEncoding().
(WebCore::TextEncoding::backslashAsCurrencySymbol): Uses shouldShowBackslashAsCurrencySymbolIn().
* platform/text/TextEncodingRegistry.cpp:
(WebCore::addEncodingName): Moved from TextEncoding.cpp, and stop using atomicCanonicalTextEncodingName().
(WebCore::buildQuirksSets): Added. Initializes HashSets for isJapaneseEncoding() and shouldShowBackslashAsCurrencySymbolIn().
(WebCore::isJapaneseEncoding):
(WebCore::shouldShowBackslashAsCurrencySymbolIn):
(WebCore::extendTextCodecMaps): Add a call to buildQuirksSets().
* platform/text/TextEncodingRegistry.h:
2010-12-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Reflected unsigned attributes should be in the range [0, 2^31).
https://bugs.webkit.org/show_bug.cgi?id=50472
HTML5 says that unsigned reflected attributes should be in the range
[0, 2^31). When a value isn't in this range, a default value (or 0)
should be returned instead. Update the JS bindings code generator to
ensure 0 is returned when a content attribute value falls outside of
this range.
Tests: bindings/scripts/test/TestObj.idl
fast/html/marquee-element.html
* bindings/scripts/CodeGeneratorJS.pm: Return the maximum of 0 and the
content attribute as a 32-bit signed int when converting a native value
to an unsigned JS value.
* bindings/scripts/test/TestObj.idl: Add a reflected unsigned attribute
to test code generation.
* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Update test results.
* bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
2010-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use gtk_icon_set_render_icon() to render icons in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=50623
We don't need to cache the icons since the will be cached by GTK+,
and they will be rendered using the state and text direction.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintStockIcon):
(WebCore::getMediaButtonIconSize):
(WebCore::RenderThemeGtk::initMediaColors):
(WebCore::RenderThemeGtk::initMediaButtons):
(WebCore::RenderThemeGtk::RenderThemeGtk):
(WebCore::RenderThemeGtk::~RenderThemeGtk):
(WebCore::RenderThemeGtk::gtkIconState):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::centerRectVerticallyInParentInputElement):
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::platformColorsDidChange):
(WebCore::RenderThemeGtk::paintMediaButton):
(WebCore::RenderThemeGtk::paintMediaFullscreenButton):
(WebCore::RenderThemeGtk::paintMediaMuteButton):
(WebCore::RenderThemeGtk::paintMediaPlayButton):
(WebCore::RenderThemeGtk::paintMediaSeekBackButton):
(WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
* platform/gtk/RenderThemeGtk.h:
2010-12-08 Abhishek Arya <inferno@chromium.org>
Reviewed by Dimitri Glazkov.
Detach node iterator and move to new document when node gets moved.
https://bugs.webkit.org/show_bug.cgi?id=50697
Test: fast/dom/node-iterator-document-moved-crash.html
* dom/Document.cpp: Method that takes a node and new document as argument.
It detaches the node iterators belonging to the current document and attaches
them to the new document.
(WebCore::Document::moveNodeIteratorsToNewDocument):
* dom/Document.h: Function definition.
* dom/Node.cpp: When node is moved to another document, call the function to move
the iterators appropriately.
(WebCore::Node::setDocument):
2010-12-08 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Text is blurry on a large composited layer with an odd center x/y coordinate
https://bugs.webkit.org/show_bug.cgi?id=50702
Compute the center of a large layer using floats instead of ints to avoid roundoff errors.
Test: compositing/text-on-large-layer.html
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::draw):
2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
REGRESSION: LayoutTests/editing/selection/caret-rtl-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=33503
The bug was caused by Font::offsetForPosition's not taking into account the containing block's text direction.
When RTL text appears in a LTR block, the offset at the beginning of RTL text is on the left of RTL text,
and the offset at the end of RTL text is on the right of RTL text. For example, if we had RTL text CBA,
then the correspondance between letters and offsets in logical order are: A -> 0, B -> 1, and C -> 2.
Case 1. CBA appears in a RTL block:
In this case, clicking on the visual left of CBA puts the caret naturally at Position("CBA", 2).
Clicking on the visual right of CBA puts the caret at Position("CBA", 0) as expected.
Case 2. CBA appears in a LTR block:
Because the containing block flows from left to right, by convention, Position("CBA", 2") corresponds
to the visual right of CBA, and Position("CBA", 0) corresponds to the visual left of CBA.
Therefore, clicking on the visual left of CBA should put the caret at Position("CBA", 0),
and clicking on the visual right should put it at Position("CBA", 2).
The bug was caused by WebKit's not considering case 2. The same bug also exist for LTR text in a RTL block.
Fixed the bug by taking care of the case 2 in InlineTextBox::offsetForPosition.
Tests: editing/selection/caret-ltr-2-left.html
editing/selection/caret-ltr-2.html
editing/selection/caret-ltr-right.html
editing/selection/caret-ltr.html
editing/selection/caret-rtl-2-left.html
editing/selection/caret-rtl-right.html
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::offsetForPosition):
2010-12-08 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Fix some clang++ warnings (one of which was an actual bug)
https://bugs.webkit.org/show_bug.cgi?id=50700
* page/mac/DragControllerMac.mm:
(WebCore::DragController::dragOperation):
Add parentheses to silent a clang warning.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
Fix || vs && precedence bug uncovered by clang.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshape):
Use an early return to avoid a warning.
2010-12-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Added copy constructors and casting operators to go between
TransformationMatrix and CATransform3D. Also added a copy
constructor to go from CGAffineTransform to TransformationMatrix.
Used these new methods to clean up platform CA code. This will
make it easier to port to Windows.
I also fixed a couple of build issues found when trying out a
Windows build.
This is a resubmission of changesets r73477 and r73483 with a
fix for the SL build. The failure was because TransformationMatrix
included QuartzCore/CATransform3D.h which brought in some system
libraries, including Quickdraw, which has a definition for
'Cursor' which clashed with WebCore's 'Cursor' class. So I had
to qualify its use in WebChromeClient.cpp in WebKit2.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateContentsTransform):
(WebCore::GraphicsLayerCA::ensureCloneLayers):
(WebCore::GraphicsLayerCA::fetchCloneLayers):
* platform/graphics/ca/TransformationMatrixCA.cpp: Copied from WebCore/platform/graphics/ca/TransformationMatrixCA.cpp.
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::transform):
(PlatformCALayer::setTransform):
(PlatformCALayer::sublayerTransform):
(PlatformCALayer::setSublayerTransform):
(PlatformCALayer::contentsTransform):
(PlatformCALayer::setContentsTransform):
* platform/graphics/cg/TransformationMatrixCG.cpp:
(WebCore::TransformationMatrix::TransformationMatrix):
* platform/graphics/transforms/TransformationMatrix.h:
2010-12-07 Brian Weinstein <bweinstein@apple.com>
Reviewed by John Sullivan.
Layering Violation in ContextMenu - member variable of type HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=50586
ContextMenu had a layering violation by having a member variable of type HitTestResult, because
classes in WebCore/platform can't know about classes in WebCore.
This patch moves the HitTestResult and all functions that use it out of ContextMenu into ContextMenuController.
All of the functions that dealt with populating the ContextMenu are now in ContextMenuController, and this
allowed us to delete the ContextMenu file, putting all of the cross-platform code that used to be it
in ContextMenuController, and the rest of the code is in the platform-specific files.
No change in behavior, no new tests.
* Android.mk: Removed ContextMenu.cpp.
* CMakeLists.txt: Ditto.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController): Initialized m_hitTestResult to an empty HitTestResult.
(WebCore::ContextMenuController::handleContextMenuEvent): Call populate on the ContextMenuController instead
of the ContextMenu.
(WebCore::ContextMenuController::createContextMenu): Fix some indination, and store the HitTestResult in a member
variable.
(WebCore::ContextMenuController::showContextMenu): Call addInspectElementItem on the ContextMenuController.
(WebCore::ContextMenuController::contextMenuItemSelected): Use m_hitTestResult whenever we need a HitTestResult.
(WebCore::ContextMenuController::appendItem): Validates the item for its state, and then appends it to the parent menu.
This allowed us to move checkOrEnableIfNeeded from ContextMenu.
These functions were all moved from ContextMenu, and changed slightly to fit in ContextMenuController.
All calls to ContextMenu::appendItem were changed to ContextMenuController::appendItem, which takes care
of validating the menu.
(WebCore::separatorItem): Moved from ContextMenu.
(WebCore::ContextMenuController::createAndAppendFontSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpeechSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTransformationsSubMenu): Ditto.
(WebCore::selectionContainsPossibleWord): Ditto.
(WebCore::ContextMenuController::populate): Ditto.
(WebCore::ContextMenuController::addInspectElementItem): Ditto.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
* page/ContextMenuController.h:
(WebCore::ContextMenuController::hitTestResult): Returns the HitTestResult of the current ContextMenu.
* platform/ContextMenu.cpp: Removed.
* platform/ContextMenu.h:
* platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
* platform/haiku/ContextMenuHaiku.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
(WebCore::ContextMenu::insertItem): Ditto.
* platform/mac/ContextMenuMac.mm:
(-[WebCoreMenuTarget validateMenuItem:]): Calls checkOrEnableIfNeeded on the controller instead of
the context menu.
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
(WebCore::ContextMenu::insertItem): Ditto.
* platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::insertItem): Removed the call to checkOrEnableIfNeeded.
* platform/wx/ContextMenuWx.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(ContextMenu::appendItem): Ditto.
2010-12-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by John Sullivan.
[GTK] Layering violation in ContextMenuGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=50676
ContextMenuGtk accesses the page's ContextMenuController, which is a layering
violation. This was fixed for Mac with change r73469. We make a similar fix here
by moving the "activated" signal connection to the WebKit layer.
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::appendItem): Remove access of ContextMenuController. This
is a layering violation.
2010-12-08 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebKit2: Implement WebChromeClient::exceededDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=50656
* WebCore.exp.in:
Export the symbol for SecurityOrigin::databaseIdentifier.
2010-12-08 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed, rolling out r73521.
http://trac.webkit.org/changeset/73521
https://bugs.webkit.org/show_bug.cgi?id=50640
It broke 90 layout tests
* bindings/js/JSDOMBinding.cpp:
(WebCore::printErrorMessageForFrame):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation):
* page/DOMWindow.cpp:
* page/DOMWindow.h:
2010-12-08 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=50576
REGRESSION in position of autocomplete popup on RTL page.
RTL static position computation did not subtract out the width of the enclosing box if the
immediate parent was a RenderInline. This bug was exposed by properly changing the RenderView
to be RTL when the document was RTL.
Added three new tests in fast/block/positioning.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):
2010-12-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix backward mouse wheeling not working when scroll position is below 0.
https://bugs.webkit.org/show_bug.cgi?id=50370
Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
2010-12-08 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Fix pauseAnimation API to work with shorthand properties
https://bugs.webkit.org/show_bug.cgi?id=50639
The pause API is always called with a long-hand property, but that
property may be animating via a shorthand. Detect this, and pause
such shorthand animations.
* page/animation/AnimationBase.cpp:
(WebCore::ShorthandPropertyWrapper::propertyWrappers): Expose the vector
of wrappers used by a shorthand wrapper.
(WebCore::gatherEnclosingShorthandProperties): Utility function that walks
through the shorthand wrappers, keeping track of which can affect the given
property.
(WebCore::AnimationBase::animatableShorthandsAffectingProperty): Return a set
of shorthand properties that can affect the given property.
* page/animation/AnimationBase.h: New method.
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::pauseTransitionAtTime): If we don't find the
property itself, check whether it's being animated via shorthands.
2010-12-08 David Hyatt <hyatt@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/8740920> Gestures: Frame::scalePage() broken by r73885
Make sure the transform applied to the RenderView for page scaling is incorporated into the
docTop/Bottom/Left/Right accessors.
* rendering/RenderView.cpp:
(WebCore::RenderView::docTop):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docRight):
2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Protocol cleanup task. Remove WebInspector wrappers
for TimelineAgent functions.
https://bugs.webkit.org/show_bug.cgi?id=50690
* inspector/Inspector.idl:
* inspector/front-end/TimelineAgent.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.timelineProfilerWasStarted):
(WebInspector.TimelinePanel.prototype.timelineProfilerWasStopped):
2010-12-08 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] media/fullscreen* failing on 64-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50394
Avoid emiting durationchanged in the case where the previous
duration was 0 because that case is already handled by the
HTMLMediaElement.
Test: media/media-fullscreen*.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::durationChanged):
2010-12-07 Darin Adler <darin@apple.com>
Reviewed by Geoffrey Garen.
Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
https://bugs.webkit.org/show_bug.cgi?id=50640
* bindings/js/JSDOMBinding.cpp:
(WebCore::printErrorMessageForFrame): Removed body; just call through to
DOMWindow::printErrorMessage.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body;
just call through to DOMWindow::crossDomainAccessErrorMessage.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and
firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most
of the body and moved it into DOMWindow::setLocation.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation): Added. Does all the same work that
JSDOMWindow::setLocation used to do, but in a way that's not specific
to JavaScript.
(WebCore::DOMWindow::printErrorMessage): Added.
(WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.
* page/DOMWindow.h: Added setLocation, printErrorMessage, and
crossDomainAccessErrorMessage.
2010-12-08 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rolling out r73494.
http://trac.webkit.org/changeset/73494
https://bugs.webkit.org/show_bug.cgi?id=50380
The tests added are crashing in the debug bots (macn and gtk)
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::deselectItems):
(WebCore::HTMLSelectElement::setSelectedIndex):
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
(WebCore::HTMLSelectElement::listBoxSelectItem):
(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::remove):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::parseMappedAttribute):
(WebCore::HTMLSelectElement::selectAll):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::setLength):
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::isOptionalFormControl):
* html/HTMLSelectElement.idl:
* html/ValidityState.cpp:
(WebCore::ValidityState::valueMissing):
2010-12-07 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector protocol cleanup task. Remove
WebInspector wrappers for DOMAgent functions.
There were a lot of wrappers in WebInspector namespace
for different WebInspector agents functions. As far as we have a
generic mechanic for such functions we can remove these
wrappers and register domAgent instance as a handler for
DOM domain notifications.
https://bugs.webkit.org/show_bug.cgi?id=50626
* inspector/Inspector.idl:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype.attributesUpdated):
(WebInspector.DOMAgent.prototype.characterDataModified):
(WebInspector.DOMAgent.prototype.setDocument):
(WebInspector.DOMAgent.prototype.setDetachedRoot):
(WebInspector.DOMAgent.prototype.setChildNodes):
(WebInspector.DOMAgent.prototype.childNodeCountUpdated):
(WebInspector.DOMAgent.prototype.childNodeInserted):
(WebInspector.DOMAgent.prototype.childNodeRemoved):
(WebInspector.EventListeners.getEventListenersForNodeAsync):
* inspector/front-end/inspector.js:
(WebInspector.didCommitLoad):
2010-12-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupLevel counter from console messages
https://bugs.webkit.org/show_bug.cgi?id=50672
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::isEqual):
* inspector/ConsoleMessage.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::addMessageToConsole):
(WebCore::InspectorController::clearConsoleMessages):
(WebCore::InspectorController::startGroup):
(WebCore::InspectorController::endGroup):
* inspector/InspectorController.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.createFilterElement):
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.filter):
(WebInspector.ConsoleView.prototype.afterShow):
(WebInspector.ConsoleView.prototype.addMessage):
(WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
(WebInspector.ConsoleView.prototype.clearMessages):
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessage.prototype.toMessageElement):
(WebInspector.ConsoleMessage.prototype._addMessageHeader):
(WebInspector.ConsoleMessage.prototype._updateRepeatCount):
(WebInspector.ConsoleMessage.prototype.toString):
(WebInspector.ConsoleMessage.prototype.isEqual):
(WebInspector.ConsoleGroup):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._checkWarning):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._addMessageToSource):
* inspector/front-end/inspector.js:
(WebInspector.addConsoleMessage):
(WebInspector.log.logMessage):
(WebInspector.log):
2010-12-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce DebuggerModel class representing InspectorDebuggerAgent state.
https://bugs.webkit.org/show_bug.cgi?id=50567
Moved debugging-related code from BreakpointManager to DebuggerModel. Moved Breakpoint class to a separate file.
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/Breakpoint.js: Added.
(WebInspector.Breakpoint): Moved from BreakpointManager.js.
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager): Remove debugger-related methods.
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
(WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
* inspector/front-end/DebuggerModel.js: Added.
(WebInspector.DebuggerModel): Moved debugger-related methods from BreakpointManager.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.continueToLine):
(WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback):
(WebInspector.ScriptsPanel.prototype.editScriptSource):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._debuggerResumed):
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createViewerIfNeeded):
(WebInspector.SourceFrameDelegate.prototype.addBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.breakpoints):
(WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.createJSBreakpointsSidebarPane):
(WebInspector.restoredBreakpoint):
(WebInspector.pausedScript):
(WebInspector.resumedScript):
(WebInspector.reset):
2010-12-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: SourceFrame refactoring.
https://bugs.webkit.org/show_bug.cgi?id=50223
SourceFrame should ask BreakpointManager about existing breakpoints instead of maintaining
it's own storages. Move common code from ScriptView and SourceView to SourceFrame.
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.findBreakpoints):
(WebInspector.BreakpointManager.prototype.findBreakpoint):
* inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.get linesCount):
(WebInspector.Script.prototype.get source):
(WebInspector.Script.prototype.set source):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView):
(WebInspector.ScriptView.prototype._scriptSourceChanged):
(WebInspector.ScriptFrameDelegateImpl):
(WebInspector.ScriptFrameDelegateImpl.prototype.canEditScripts):
(WebInspector.ScriptFrameDelegateImpl.prototype.editLineComplete):
(WebInspector.ScriptFrameDelegateImpl.prototype.scripts):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame): Add common methods of ScriptView and SourceView.
(WebInspector.SourceFrameDelegate):
(WebInspector.SourceFrameDelegate.prototype.canEditScripts):
(WebInspector.SourceFrameDelegate.prototype.editLineComplete):
(WebInspector.SourceFrameDelegate.prototype.scripts):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
(WebInspector.SourceView.prototype._contentLoaded):
(WebInspector.ResourceFrameDelegateImpl):
(WebInspector.ResourceFrameDelegateImpl.prototype.canEditScripts):
(WebInspector.ResourceFrameDelegateImpl.prototype.editLineComplete):
(WebInspector.ResourceFrameDelegateImpl.prototype.scripts):
2010-12-08 Yuta Kitamura <yutak@chromium.org>
Unreviewed, rolling out r73492.
http://trac.webkit.org/changeset/73492
https://bugs.webkit.org/show_bug.cgi?id=49914
Caused a lot of pixel test failures and broke Windows build.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createGraphicsContextPrivate):
(WebCore::GraphicsContext::destroyGraphicsContextPrivate):
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(WebCore::GraphicsContext::setStrokeThickness):
(WebCore::GraphicsContext::setStrokeStyle):
(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setShadow):
(WebCore::GraphicsContext::clearShadow):
(WebCore::GraphicsContext::getShadow):
(WebCore::GraphicsContext::strokeThickness):
(WebCore::GraphicsContext::strokeStyle):
(WebCore::GraphicsContext::strokeColor):
(WebCore::GraphicsContext::strokeColorSpace):
(WebCore::GraphicsContext::fillRule):
(WebCore::GraphicsContext::setFillRule):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::fillColor):
(WebCore::GraphicsContext::fillColorSpace):
(WebCore::GraphicsContext::setShouldAntialias):
(WebCore::GraphicsContext::shouldAntialias):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
(WebCore::GraphicsContext::fillGradient):
(WebCore::GraphicsContext::strokeGradient):
(WebCore::GraphicsContext::fillPattern):
(WebCore::GraphicsContext::strokePattern):
(WebCore::GraphicsContext::setShadowsIgnoreTransforms):
(WebCore::GraphicsContext::updatingControlTints):
(WebCore::GraphicsContext::setUpdatingControlTints):
(WebCore::GraphicsContext::setPaintingDisabled):
(WebCore::GraphicsContext::paintingDisabled):
(WebCore::GraphicsContext::textDrawingMode):
(WebCore::GraphicsContext::setTextDrawingMode):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContextPrivate.h: Added.
(WebCore::GraphicsContextState::GraphicsContextState):
(WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::drawPathShadow):
(WebCore::fillCurrentCairoPath):
(WebCore::strokeCurrentCairoPath):
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::getAlpha):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeRect):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::GraphicsContext):
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::GraphicsContext):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
2010-12-08 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Implement "required" attribute for select tags
https://bugs.webkit.org/show_bug.cgi?id=50380
Test: fast/forms/select-live-pseudo-selectors.html
platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface.
(WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified.
(WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
(WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated..
(WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck().
(WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not.
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
* html/HTMLSelectElement.idl: Added a required attribute to select elements..
* html/ValidityState.cpp:
(WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
2010-12-08 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
GraphicsContext: Merge m_common and m_data
https://bugs.webkit.org/show_bug.cgi?id=49914
Move data members from GraphicsContextPrivate into GraphicsContext. So GraphicsContextPlatform.h
and m_common became unnecessary. They are removed.
Add two methods to GraphicsContext: platformInit() and platformDestroy(), which
make the constructor of GraphicsContext clearer.
Besides add a getter to the private GraphicsContext::m_state member, because some inline
functions in cairo need it.
No new test is needed, because this is a refactoring.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(WebCore::GraphicsContext::setStrokeThickness):
(WebCore::GraphicsContext::setStrokeStyle):
(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setShadow):
(WebCore::GraphicsContext::clearShadow):
(WebCore::GraphicsContext::getShadow):
(WebCore::GraphicsContext::strokeThickness):
(WebCore::GraphicsContext::strokeStyle):
(WebCore::GraphicsContext::strokeColor):
(WebCore::GraphicsContext::strokeColorSpace):
(WebCore::GraphicsContext::fillRule):
(WebCore::GraphicsContext::setFillRule):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::fillColor):
(WebCore::GraphicsContext::fillColorSpace):
(WebCore::GraphicsContext::setShouldAntialias):
(WebCore::GraphicsContext::shouldAntialias):
(WebCore::GraphicsContext::state):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
(WebCore::GraphicsContext::fillGradient):
(WebCore::GraphicsContext::strokeGradient):
(WebCore::GraphicsContext::fillPattern):
(WebCore::GraphicsContext::strokePattern):
(WebCore::GraphicsContext::setShadowsIgnoreTransforms):
(WebCore::GraphicsContext::updatingControlTints):
(WebCore::GraphicsContext::setUpdatingControlTints):
(WebCore::GraphicsContext::setPaintingDisabled):
(WebCore::GraphicsContext::paintingDisabled):
(WebCore::GraphicsContext::textDrawingMode):
(WebCore::GraphicsContext::setTextDrawingMode):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState):
* platform/graphics/GraphicsContextPrivate.h: Removed.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::drawPathShadow):
(WebCore::fillCurrentCairoPath):
(WebCore::strokeCurrentCairoPath):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::getAlpha):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeRect):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::platformInit):
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::platformInit):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
2010-12-07 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
Port http://trac.webkit.org/changeset/72819/ to v8-backed ports.
https://bugs.webkit.org/show_bug.cgi?id=50246
* bindings/v8/V8DOMMap.h:
(WebCore::AbstractWeakReferenceMap::Visitor::startMap):
(WebCore::AbstractWeakReferenceMap::Visitor::endMap):
(WebCore::WeakReferenceMap::visit):
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperItem::GrouperItem):
(WebCore::GrouperItem::groupId):
(WebCore::makeV8ObjectGroups):
(WebCore::NodeGrouperVisitor::NodeGrouperVisitor):
(WebCore::NodeGrouperVisitor::visitDOMWrapper):
(WebCore::NodeGrouperVisitor::applyGrouping):
(WebCore::DOMObjectGrouperVisitor::ObjectGrouperVisitor):
(WebCore::DOMObjectGrouperVisitor::startMap):
(WebCore::DOMObjectGrouperVisitor::endMap):
(WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
(WebCore::V8GCController::gcPrologue):
2010-12-07 Daniel Bates <dbates@rim.com>
Reviewed by Martin Robinson.
Implement focus ring support for image maps
https://bugs.webkit.org/show_bug.cgi?id=50371
Implement GraphicsContext::drawFocusRing(const Path&, ...) so as to support
drawing a focus ring for image maps.
Tests: fast/images/imagemap-circle-focus-ring.html
fast/images/imagemap-polygon-focus-ring.html
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::adjustFocusRingColor): Added.
(WebCore::adjustFocusRingLineWidth): Added.
(WebCore::focusRingStrokeStyle): Added.
(WebCore::GraphicsContext::drawFocusRing): Moved code for determining focus ring- color,
line width and stroke style into functions adjustFocusRingColor(), adjustFocusRingLineWidth(),
and focusRingStrokeStyle(), respectively. Implemented GraphicsContext::drawFocusRing(const Path&, ...).
2010-12-07 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKitSoupCache fails to load resources when cache contents are externally removed
https://bugs.webkit.org/show_bug.cgi?id=50577
Try to download cached resources again if they are no longer
accesible by the cache.
* platform/network/soup/cache/soup-request-http.c:
(send_async_cb):
(webkit_soup_request_http_send_async):
2010-12-06 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
RenderIndicator subclasses should not change the render tree during layout.
https://bugs.webkit.org/show_bug.cgi?id=50026
The old code created shadow elements during a layout computation,
that makes the layout state inconsisntent and cause an assertion failure.
This change created shadow elements before the layout to avoid
state inconsistencies.
Instead of creating shadows on demand, RenderMeter and
RenderProgress now create all necessary shadows before layouts,
and change its visibilities during the layout: Changing
visibilities doesn't trigger relayout and keep the state
consistent.
RenderMeter uses new HidablePartElement for shadow elements,
which can toggle visibiliby between hidden and original value.
Test: fast/dom/HTMLMeterElement/meter-element-crash.html
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::attach): Calling updateFromElement()
* html/HTMLMeterElement.h:
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::attach): Calling updateFromElement()
* html/HTMLProgressElement.h:
* rendering/RenderIndicator.cpp:
* rendering/RenderIndicator.h:
* rendering/RenderMeter.cpp:
(WebCore::MeterPartElement::MeterPartElement): Added to hold a restorable visibility.
(WebCore::MeterPartElement::createForPart):
(WebCore::MeterPartElement::hide):
(WebCore::MeterPartElement::restoreVisibility):
(WebCore::MeterPartElement::updateStyleForPart):
(WebCore::MeterPartElement::saveVisibility):
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::createPart): Extracted
(WebCore::RenderMeter::updateFromElement): Had a shadow generation.
(WebCore::RenderMeter::layoutParts): Removed shadow generation code.
(WebCore::RenderMeter::shouldHaveParts):
(WebCore::RenderMeter::valuePartRect): Adopted orientation.
(WebCore::RenderMeter::orientation): Morphed from isHorizontal()
(WebCore::RenderMeter::valuePseudoId): Adoptedn orientation
(WebCore::RenderMeter::barPseudoId): Adopted orientation.
* rendering/RenderMeter.h:
(WebCore::RenderMeter::shadowAttached):
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::updateFromElement): Had a shadow generation.
(WebCore::RenderProgress::layoutParts):
* rendering/RenderProgress.h:
* rendering/ShadowElement.cpp:
(WebCore::ShadowBlockElement::createForPart): Extracted initAsPart().
(WebCore::ShadowBlockElement::initAsPart): Extracted from createForPart().
* rendering/ShadowElement.h:
2010-11-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
returning to a POST result within a frame does a GET instead of a POST
https://bugs.webkit.org/show_bug.cgi?id=10199
FrameLoader::loadURLIntoChildFrame had a check for whether a frame
had a HistoryItem, and if so used that item's URL. However, that did
not handle the case where the HistoryItem had FormData and thus was the
result of a POST request. FrameLoader::navigateToDifferentDocument (now
renamed to loadDifferentDocumentItem) does all that, so just switch to
using it instead.
Besides the bug fix, the only difference in behavior is that we use the
HistoryItem's URL instead of original URL when restoring it in a child
frame. This seems desirable too (for consistency with other browsers, and
so that we can avoid form double-submits for forms that that do
POST-then-redirect), and is tested by
fast/history/history-back-initial-vs-final-url.html.
Tests: fast/history/history-back-initial-vs-final-url.html
http/tests/navigation/post-frames-goback1.html
http/tests/navigation/postredirect-frames-goback1.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURLIntoChildFrame): Switch to using
loadDifferentDocumentItem. Also cleaned up ordering slightly (if
on the archive path, there's no need to do any of the other checks).
(WebCore::FrameLoader::loadDifferentDocumentItem): Renamed from
navigateToDifferentDocument so that calling it from loadItem and
loadURLIntoChildFrame flows more easily.
(WebCore::FrameLoader::loadSameDocumentItem): Similarly, renamed from
navigateWithinDocument.
(WebCore::FrameLoader::loadItem): Update callsites to the above methods.
* loader/FrameLoader.h:
2010-12-07 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Made tables repaint correctly in all writing modes
Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417
Tests: fast/repaint/table-writing-modes-h.html
fast/repaint/table-writing-modes-v.html
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject): Compute the ranges of rows and
columns to repaint based on the logical extent of the repaint rect.
2010-12-07 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by James Robinson.
[chromium] compositor lost context recovery fix
https://bugs.webkit.org/show_bug.cgi?id=50614
To test, load a page that triggers the compositor, kill the GPU
process and hover over a link to redraw and thus restart the GPU
process. Without this patch it will assert in
ContentLayerChromium::updateTextureRect; with this patch it will not.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setNeedsDisplay):
2010-12-07 Anders Carlsson <andersca@apple.com>
Fix the last clang++ build error.
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::animationForKey):
Cast the returned animation to the correct type.
2010-12-07 Anders Carlsson <andersca@apple.com>
Fix some clang++ build errors.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Remove unused variable.
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
Fix constness of pointers.
2010-12-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Fix the Color -> CGColorRef conversions for the debug colors
used for compositing layers.
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):
2010-12-07 Brian Weinstein <bweinstein@apple.com>
Reviewed by John Sullivan.
Part of Layering Violation in ContextMenu
https://bugs.webkit.org/show_bug.cgi?id=50586
ContextMenuMac.mm had a WebCoreMenuTarget class, which was responsible for wrapping
a ContextMenuItem, and calling through to the ContextMenuController to validate it
and call a function when it was selected.
It was a layering violation to have this class here, because ContextMenu can't know
about ContextMenuController.
This patch moves the class that wraps the ContextMenuItems to WebKit/mac/WebHTMLView.mm,
and sets up the menu targets there.
No change in behavior, no new tests.
* WebCore.exp.in: Added function that needs to be exported.
* platform/mac/ContextMenuMac.mm:
(WebCore::ContextMenu::ContextMenu): Don't set the sharedMenuTarget anymore.
(WebCore::ContextMenu::appendItem): Don't call setMenuItemTarget (this is done in WebKit now).
(WebCore::ContextMenu::insertItem): Ditto.
2010-12-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
-webkit-transition Fails on Multiple text-shadow Shadows
https://bugs.webkit.org/show_bug.cgi?id=42281
When transitioning multiple shadows, the blend function for
ShadowData dropped all but the first and last shadow because
of a failure to append to the end of the list. Fixed.
Test: transitions/multiple-text-shadow-transition.html
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperShadow::blend):
2010-12-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Beth Dakin.
CSS animation doesn't work for border-radius
https://bugs.webkit.org/show_bug.cgi?id=48340
Include CSSPropertyBorderRadius in the list of shorthand
properties, so that the individual border-radius properties
get animated.
Test: transitions/border-radius-transition.html
* page/animation/AnimationBase.cpp:
(WebCore::addShorthandProperties):
2010-12-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Kent Tamura.
Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511
Test: fast/html/hidden-attr.html
* html/HTMLElement.cpp:
(WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute.
(WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.
2010-12-07 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix compilation of core web audio files on Windows
https://bugs.webkit.org/show_bug.cgi?id=50603
Changed a few constructs using C99 features of math.h to use
wtf/MathExtras.h instead. Changed inline definitions of a couple of
const static doubles in classes to out-of-line. Built Chrome with
web audio enabled on Windows and Mac OS X to test these changes.
No new tests since audio API is not yet implemented.
* WebCore.gypi:
* platform/audio/AudioResampler.cpp:
* platform/audio/Biquad.cpp:
(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setLowShelfParams):
* platform/audio/Cone.cpp:
(WebCore::ConeEffect::gain):
* platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::pan):
* platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::interpolateFrequencyComponents):
(WebCore::FFTFrame::extractAverageGroupDelay):
(WebCore::FFTFrame::addConstantGroupDelay):
* platform/audio/HRTFKernel.cpp:
* platform/audio/HRTFPanner.cpp:
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::readFromBufferWithGrainEnvelope):
* webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::getAzimuthElevation):
* webaudio/AudioParam.cpp: Added.
(AudioParam::setValue):
(AudioParam::smooth):
* webaudio/AudioParam.h:
* webaudio/RealtimeAnalyser.cpp:
2010-11-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] faster elements linking
https://bugs.webkit.org/show_bug.cgi?id=50067
Perform less checks during GStreamer elements linking if building
against GStreamer >= 0.10.30.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
2010-12-07 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] ::buffered() should return multiple ranges in some cases
https://bugs.webkit.org/show_bug.cgi?id=45101
Improved the ::buffered() method thanks to the new buffering query
support that landed in GStreamer 0.10.31. The method now
queries the media buffered-ranges on the pipeline and queue2
handles it if it's buffering the media to disk.
The webkitwebsrc element also gained BYTES duration query
support. This is needed in the rare cases where uridecodebin
configures its queue before the HTTP server returns the media
Content-Length.
Test: http/tests/media/video-buffered.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::buffered):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(webKitWebSrcQuery): Make webkitwebsrc handle the duration queries
if it's aware of the media content-length.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaSliderTrack): Fix position of
the second and next buffered ranges.
2010-12-07 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
Spatial navigation not Working for Map and Area Tags
https://bugs.webkit.org/show_bug.cgi?id=47142
Give area elements special treatment in spatial navigation algorithm by getting the
rect of the area from the associated image. Since area elements are likely to overlap
if they are not rects, or if authors are not careful, we flatten the rect of area elements.
Tests: fast/spatial-navigation/snav-imagemap-area-not-focusable.html
fast/spatial-navigation/snav-imagemap-area-without-image.html
fast/spatial-navigation/snav-imagemap-overlapped-areas.html
fast/spatial-navigation/snav-imagemap-simple.html
* page/FocusController.cpp:
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):
* page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::virtualRectForDirection):
(WebCore::virtualRectForAreaElementAndDirection):
* page/SpatialNavigation.h:
(WebCore::FocusCandidate::FocusCandidate):
2010-12-07 Darin Adler <darin@apple.com>
Try to fix V8 build.
* bindings/generic/BindingDOMWindow.h:
(WebCore::BindingDOMWindow::createWindow): Pass security origin.
2010-12-07 Darin Adler <darin@apple.com>
Another build fix.
* loader/CrossOriginAccessControl.cpp: Added a missing include.
2010-12-07 Darin Adler <darin@apple.com>
Try to fix build.
* plugins/PluginView.cpp:
(WebCore::PluginView::start): Pass security origin.
(WebCore::PluginView::getURLNotify): Ditto.
(WebCore::PluginView::getURL): Ditto.
(WebCore::PluginView::handlePost): Ditto.
2010-12-06 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603
* bindings/generic/BindingDOMWindow.h:
(WebCore::BindingDOMWindow::createWindow): Pass security origin.
(WebCore::BindingDOMWindow::open): Ditto.
* bindings/generic/BindingFrame.h:
(WebCore::BindingFrame::navigateIfAllowed): Ditto.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation): Pass security origin.
(WebCore::createWindow): Ditto.
(WebCore::JSDOMWindow::open): Ditto.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation): Pass security origin.
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Pass security origin.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::openInInspectedWindow):
Pass security origin.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation): Added a security origin
argument, passed through to urlSelected.
(WebCore::FrameLoader::urlSelected): Replaced the resource request
and frame name arguments with a frame load request arguments in one
overload, and changed the other overload to pass in the current
frame's document for the security origin.
(WebCore::FrameLoader::loadFrameRequest): Moved the canDisplay
check before the referrer computation because it no longer needs
to look at the referrer. Replaced the call to canDisplay that
used the target frame's security origin and the call to
deprecatedCanDisplay with a single call to canDisplay that uses
the requester security origin.
* loader/FrameLoader.h: Updated for argument changes above.
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation): Added
a security origin.
(WebCore::ScheduledURLNavigation::fire): Pass the security origin
in to FrameLoader::changeLocation.
(WebCore::ScheduledURLNavigation::securityOrigin): Added.
(WebCore::ScheduledRedirect::ScheduledRedirect): Added a security
origin argument.
(WebCore::ScheduledLocationChange::ScheduledLocationChange): Ditto.
(WebCore::ScheduledRefresh::ScheduledRefresh): Ditto.
(WebCore::ScheduledRefresh::fire): Pass the security origin in to
FrameLoader::changeLocation.
(WebCore::ScheduledFormSubmission::fire): Include the security
origin when constructing form submission.
(WebCore::NavigationScheduler::scheduleRedirect): Include the security
origin when creating the scheduled navigation object.
(WebCore::NavigationScheduler::scheduleLocationChange): Ditto.
(WebCore::NavigationScheduler::scheduleRefresh): Ditto.
* loader/NavigationScheduler.h: Added the security origin argument
to scheduleLocationChange.
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadOrRedirectSubframe): Pass in the security
origin when calling scheduleLocationChange.
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache): Ditto.
* page/ContextMenuController.cpp:
(WebCore::openNewWindow): Pass in the security origin.
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
* page/FrameLoadRequest.h: Added a security origin called the requester
to all FrameLoadRequest objects.
* page/XSSAuditor.cpp:
(WebCore::XSSAuditor::findInRequest): Added the security origin.
2010-12-07 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: avoid initializing Context on when creating attaching listener to ScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=50627
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::addListener): don't try to collect already parsed scripts if context has
not been initialized yet.
2010-12-07 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed. Rolling out r73421, because it made transitions/color-transition-all.html flakey.
* page/animation/AnimationBase.cpp:
(WebCore::addShorthandProperties):
2010-12-07 Martin Robinson <mrobinson@igalia.com>
Unreviewed, rolling out r73392.
http://trac.webkit.org/changeset/73392
https://bugs.webkit.org/show_bug.cgi?id=50489
This commit caused crashes on the GTK+ bots
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::close):
(WebCore::Document::lastModified):
(WebCore::Document::finishedParsing):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
* dom/Document.h:
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::scriptCharset):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::setFrame):
* loader/DocumentLoader.h:
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/DocumentWriter.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::finishedLoadingDocument):
(WebCore::FrameLoader::addExtraFieldsToRequest):
* loader/FrameLoader.h:
(WebCore::FrameLoader::writer):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestPreload):
* platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::encodingFromAcceptCharset):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2010-12-07 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Remove WebKitGenerators
https://bugs.webkit.org/show_bug.cgi?id=50445
Move remaining logic into main CMakeLists.txt.
* CMakeLists.txt:
2010-12-07 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
Clear old SVG cursor entry before adding a new one
https://bugs.webkit.org/show_bug.cgi?id=50549
Test: svg/css/cursor-replace.svg
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
* svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::~SVGCursorElement):
(WebCore::SVGCursorElement::removeClient):
(WebCore::SVGCursorElement::removeReferencedElement):
* svg/SVGCursorElement.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::setCursorElement):
(WebCore::SVGElement::cursorElementRemoved):
(WebCore::SVGElement::setCursorImageValue):
(WebCore::SVGElement::cursorImageElementRemoved):
* svg/SVGElement.h:
2010-12-07 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821
Introduces FormAssociatedElement class which would be a super class
of form assocated elements. Some of member functions and variables of
HTMLFormControlElement are migrated into this class.
Following the HTML5 spec, HTMLFormControlElement class and
HTMLObjectElement class are subclasses of it for now.
Test: fast/forms/form-collection-elements-order.html
* Android.mk: Added FormAssociatedElement.cpp
* CMakeLists.txt: Ditto.
* GNUmakefile.am: Added FormAssociatedElement.{cpp,h}
* WebCore.exp.in: Added the symbol for toHTMLElement(FormAssociatedElement*)
* WebCore.gypi: Added FormAssociatedElement.{cpp,h}
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/CheckedRadioButtons.h: Fixed class forward declaration order.
* dom/Document.cpp:
(WebCore::Document::registerFormElementWithFormAttribute): Modified to
use FormAssociatedElement instead of HTMLFormControlElement
(WebCore::Document::unregisterFormElementWithFormAttribute): Ditto.
(WebCore::Document::resetFormElementsOwner):
* dom/Document.h: Ditto.
* html/DOMFormData.cpp: Ditto.
(WebCore::DOMFormData::DOMFormData):
* html/FormAssociatedElement.cpp: Copied and renamed from WebCore/html/HTMLFormControlElement.cpp.
(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::~FormAssociatedElement):
(WebCore::FormAssociatedElement::validity):
(WebCore::FormAssociatedElement::insertedIntoTree):
(WebCore::FormAssociatedElement::removedFromTree):
(WebCore::FormAssociatedElement::removeFromForm):
(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore::toHTMLElement):
* html/FormAssociatedElement.h: Ditto.
(WebCore::FormAssociatedElement::ref):
(WebCore::FormAssociatedElement::deref):
(WebCore::FormAssociatedElement::formDestroyed):
(WebCore::FormAssociatedElement::setForm):
* html/HTMLElement.h: Changed the access level of findFormAncestor().
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::item): Modified to use FormAssociatedElement
instead of HTMLFormControlElement.
(WebCore::HTMLFormCollection::getNamedFormItem): Ditto.
(WebCore::HTMLFormCollection::updateNameCache): Ditto.
* html/HTMLFormControlElement.cpp: Modified regarding with the change of class
hierarchy.
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::~HTMLFormControlElement):
(WebCore::HTMLFormControlElement::insertedIntoTree):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::supportsFocus):
(WebCore::HTMLFormControlElement::checkValidity):
(WebCore::HTMLFormControlElement::virtualForm):
(WebCore::HTMLFormControlElement::isDefaultButtonForForm):
(WebCore::HTMLFormControlElement::attributeChanged):
* html/HTMLFormControlElement.h: Ditto.
(WebCore::HTMLFormControlElement::form):
(WebCore::HTMLFormControlElement::disabled):
(WebCore::HTMLFormControlElement::type):
(WebCore::HTMLFormControlElement::refFormAssociatedElement):
(WebCore::HTMLFormControlElement::derefFormAssociatedElement):
* html/HTMLFormElement.cpp: Modified to use FormAssociatedElement
instead of HTMLFormControlElement.
(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::registerFormElement):
(WebCore::HTMLFormElement::removeFormElement):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::checkValidity):
(WebCore::HTMLFormElement::collectUnhandledInvalidControls):
(WebCore::HTMLFormElement::documentDidBecomeActive):
* html/HTMLFormElement.h: Ditto.
(WebCore::HTMLFormElement::associatedElements):
* html/HTMLInputElement.cpp: Ditto.
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
* html/HTMLObjectElement.cpp: Modified regarding with the change of class
hierarchy.
(WebCore::HTMLObjectElement::HTMLObjectElement):
(WebCore::HTMLObjectElement::~HTMLObjectElement):
(WebCore::HTMLObjectElement::create):
(WebCore::HTMLObjectElement::attributeChanged):
(WebCore::HTMLObjectElement::insertedIntoTree):
(WebCore::HTMLObjectElement::removedFromTree):
(WebCore::HTMLObjectElement::appendFormData):
(WebCore::HTMLObjectElement::formControlName):
* html/HTMLObjectElement.h: Ditto.
(WebCore::HTMLObjectElement::form):
(WebCore::HTMLObjectElement::isFormControlElement):
(WebCore::HTMLObjectElement::isEnumeratable):
(WebCore::HTMLObjectElement::refFormAssociatedElement):
(WebCore::HTMLObjectElement::derefFormAssociatedElement):
* html/HTMLTagNames.in: Added constructorNeedsFormElement to object tag.
* html/ValidationMessage.cpp: Modified to use FormAssociatedElement
instead of HTMLFormControlElement.
(WebCore::ValidationMessage::ValidationMessage):
(WebCore::ValidationMessage::create):
* html/ValidationMessage.h: Ditto.
* html/ValidityState.cpp: Ditto.
(WebCore::ValidityState::validationMessage):
(WebCore::ValidityState::setCustomErrorMessage):
(WebCore::ValidityState::valueMissing):
(WebCore::ValidityState::typeMismatch):
(WebCore::ValidityState::patternMismatch):
(WebCore::ValidityState::tooLong):
(WebCore::ValidityState::rangeUnderflow):
(WebCore::ValidityState::rangeOverflow):
(WebCore::ValidityState::stepMismatch):
* html/ValidityState.h: Ditto.
(WebCore::ValidityState::create):
(WebCore::ValidityState::ValidityState):
* loader/FormSubmission.cpp: Ditto.
(WebCore::FormSubmission::create):
2010-12-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out r72988 for breaking iframes.
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
2010-12-06 Hironori Bono <hbono@chromium.org>
Reviewed by David Levin.
[Chromium] Refactor FontCacheChromiumWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=50611
This change just moved the helper functions for the WebCore::FontCache class to the beginning of ths file.
No new tests are added since this is a refactoring.
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontDataFromDescriptionAndLogFont): Moved to the beginning of the file.
(WebCore::toGDIFontWeight): Moved to the beginning of the file.
(WebCore::FillLogFont): Moved to the beginning of the file.
(WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): Moved to the beginning of the file.
(WebCore::traitsInFamilyEnumProc): Moved to the beginning of the file.
(WebCore::FontCache::platformInit): Moved after the static functions.
2010-12-06 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Throw webglcontextlost and webglcontextrestored events when a WebGL context is lost and restored.
https://bugs.webkit.org/show_bug.cgi?id=50364
No new tests since there is currently no way to force a context lost event.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::isContextLost):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::restoreContext):
* html/canvas/WebGLRenderingContext.h:
(WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::WebGLRenderingContextRestoreTimer):
2010-12-06 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=50593
Fix background canvas painting for documents with left/top overflow. The math from the original RTL patch was incorrect.
Just use the RenderView's document dimensions always.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxDecorations):
2010-12-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Beth Dakin.
CSS animation doesn't work for border-radius
https://bugs.webkit.org/show_bug.cgi?id=48340
Include CSSPropertyBorderRadius in the list of shorthand
properties, so that the individual border-radius properties
get animated.
Test: transitions/border-radius-transition.html
* page/animation/AnimationBase.cpp:
(WebCore::addShorthandProperties):
2010-12-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
ApplyStyleCommand should take EditingStyle instead of CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=49938
Modified ApplyStyleCommand::ApplyStyleCommand and ApplyStyleCommand::create to take EditingStyle*
instead of CSSStyleDeclaration*. Also replaced much of code in Editor::computeAndSetTypingStyle
by calls to EditingStyle's member functions and extracted EditingStyle::overrideWith and
EditingStyle::extractAndRemoveBlockProperties.
No new tests are added since this is a refactoring.
* WebCore.exp.in: Added SelectionController::copyTypingStyle and EditingStyle::~EditingStyle.
* css/CSSMutableStyleDeclaration.cpp: Made CSSMutableStyleDeclaration* in the argument list const.
(WebCore::CSSMutableStyleDeclaration::merge):
* css/CSSMutableStyleDeclaration.h:
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::ApplyStyleCommand): Takes EditingStyle* instead of CSSStyleDeclaration*.
(WebCore::ApplyStyleCommand::doApply): Uses EditingStyle.
* editing/ApplyStyleCommand.h: m_style is now a ref-pointer to EditingStyle instead of CSSMutableStyleDeclaration.
(WebCore::ApplyStyleCommand::create): Takes EditingStyle* instead of CSSStyleDeclaration*.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::applyStyle): Ditto.
(WebCore::CompositeEditCommand::moveParagraphs): Calls applyStyle.
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
* editing/CompositeEditCommand.h:
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
* editing/EditCommand.cpp:
* editing/EditCommand.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::~EditingStyle): Added.
(WebCore::EditingStyle::overrideWithStyle): Extracted from Editor::calculateTypingStyleAfterDelete.
(WebCore::EditingStyle::copy): Added.
(WebCore::EditingStyle::extractAndRemoveBlockProperties): Extracted from Editor::calculateTypingStyleAfterDelete.
* editing/EditingStyle.h:
* editing/Editor.cpp:
(WebCore::Editor::applyStyle): Calls ApplyStyleCommand::create.
(WebCore::Editor::applyParagraphStyle): Ditto.
(WebCore::Editor::computeAndSetTypingStyle): Ditto.
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply): Calls applyStyle.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input): Ditto.
* editing/RemoveFormatCommand.cpp:
(WebCore::RemoveFormatCommand::doApply): Calls ApplyStyleCommand::create.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Calls applyStyle.
* editing/SelectionController.cpp:
(WebCore::SelectionController::copyTypingStyle): Moved from SelectionController.h
* editing/SelectionController.h:
2010-12-05 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Executing FormatBlock on multiple paragraphs inside pre does not remove the outer pre
https://bugs.webkit.org/show_bug.cgi?id=47300
The bug was caused by FormatBlockCommand::formatRange's not removing refNode when the refNode
contains more than one paragraphs even when the refNode is fully selected.
Fixed the bug by modifying FormatBlockCommand::formatRange to correctly remove the node in
such a situation.
Also fixed a bug in ApplyBlockElementCommand::formatSelection that the end of selection
is not properly updated when the end of selection resides in the node split by
rangeForParagraphSplittingTextNodesIfNeeded or endOfNextParagrahSplittingTextNodesIfNeeded.
Test: editing/execCommand/format-block-multiple-paragraphs-in-pre.html
* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::formatSelection): Calls formatRange with m_endOfLastParagraph.
(WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Updates
m_endOfLastParagraph when the position points to the node split by this function.
(WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Ditto.
* editing/ApplyBlockElementCommand.h: Added m_endOfLastParagraph as a member variable.
* editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::formatRange): See above.
* editing/FormatBlockCommand.h:
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::formatRange): Ignores the end of selection.
* editing/IndentOutdentCommand.h:
2010-12-03 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Postpone gl delete* calls until shaders/programs are no longer attached
https://bugs.webkit.org/show_bug.cgi?id=50501
* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::deleteObjectImpl): Simply delete GL resource.
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::deleteObjectImpl): Ditto.
* html/canvas/WebGLObject.cpp:
(WebCore::WebGLObject::deleteObject): Tracking whether deleteObjectImpl should be called or not.
* html/canvas/WebGLObject.h:
(WebCore::WebGLObject::detachContext): Set attachmentCount to 0 to ensure OpenGL resource deletion.
(WebCore::WebGLObject::onDetached): No need to track attachmentCount here as we track it in deleteObject.
(WebCore::WebGLObject::isDeleted): Make this public.
* html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::deleteObjectImpl): Simply delete GL resource.
* html/canvas/WebGLRenderbuffer.cpp:
(WebCore::WebGLRenderbuffer::deleteObjectImpl): Ditto.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getProgramParameter): intercept DELETE_STATUS.
(WebCore::WebGLRenderingContext::getShaderParameter): Ditto.
* html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::deleteObjectImpl): Simply delete GL resource.
* html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::deleteObjectImpl): Simply delete GL resource.
2010-12-06 Ryosuke Niwa <rniwa@webkit.org>
Yet unreviewed another Leopard build fix for r73380.
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(PlatformCAAnimation::setKeyTimes):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::platformCALayer):
2010-12-06 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Marquee elements do not stop animating when scrollAmount is set to 0.
https://bugs.webkit.org/show_bug.cgi?id=50434
Test: fast/html/marquee-scrollamount.html
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::timerFired): Allow increment to be 0.
2010-12-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Leopard buildfix for r73380.
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(PlatformCAAnimation::setTimingFunctions):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::PlatformCALayer):
2010-12-06 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] use ResourceHandle::setDefersLoading in WebKitWebSourceGStreamer
https://bugs.webkit.org/show_bug.cgi?id=44157
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcEnoughDataMainCb): Replaced platform-specific code
with cross-platform ResourceHandle::setDefersLoading calls.
2010-12-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Leopard build fix for r73388.
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
2010-12-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix for Leopard after r73379.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setAllowsFontSmoothing):
2010-12-06 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Make DocumentWriter a member of DocumentLoader
instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=50489
Refactor, no new tests.
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::close):
(WebCore::Document::lastModified):
(WebCore::Document::finishedParsing):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
* dom/Document.h:
(WebCore::Document::setDocumentLoader):
(WebCore::Document::loader):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::scriptCharset):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::setFrame):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::writer):
* loader/DocumentWriter.h:
(WebCore::DocumentWriter::setFrame):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::finishedLoadingDocument):
(WebCore::FrameLoader::addExtraFieldsToRequest):
* loader/FrameLoader.h:
(WebCore::FrameLoader::notifier):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestPreload):
* platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::encodingFromAcceptCharset):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
2010-12-06 Mark Rowe <mrowe@apple.com>
Build fix.
* WebCore.xcodeproj/project.pbxproj: Don't force WebCore to build against the 10.5 SDK.
That's just plain wrong.
2010-12-06 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
HTML5 Slider does not work correctly with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=50505
Address a few problems with the Mac implementation for the accessibility slider.
1) The value indicator is not hit testable.
2) The value indicator does not return an AXValue.
3) In the slider, the min/max values are not correct when min/max attributes are not present.
4) When you change the value with the keyboard, it doesn't send out the right notification.
5) Sliders were returning AXValue and AXTopLevelUIElement attributes twice in their list of attributes.
Test: platform/mac/accessibility/html-slider-indicator.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::getAttribute):
Use fastGetAttribute on Element, instead of getAttribute.
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isInputSlider):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::doAccessibilityHitTest):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
* accessibility/AccessibilitySlider.h:
(WebCore::AccessibilitySlider::isInputSlider):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::applyStep):
2010-12-06 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Fix for https://bugs.webkit.org/show_bug.cgi?id=49220 <<rdar://problem/8644849>, REGRESSION: transforms now
O(n^3) from pathological behavior in lowestPosition, rightmostPosition, leftmostPosition and topmostPosition.
This patch throws out the lowest/rightmost/leftmost/topmostPosition functions and re-architects layout overflow
in the engine to cache all the information required to properly handle scrolling.
In the old code, there were two types of overflow: layout overflow and visual overflow. The former could
affect scrolling and the latter could not. The distinction was largely meaningless, since layout overflow
wasn't actually used to determine scroll width or scroll height. It didn't propagate across self-painting layer
boundaries either. In the old code, the term visible overflow meant the union of the layout overflow and
visual overflow rects.
In the new code, the two types of overflow remain, but the distinction between the two is now clear. Visual overflow
is used purely for painting and hit testing checks and layout overflow is used specifically for scrolling. It has
been expanded to propagate across self-painting layers, to factor in relative positioning and transforms, and to
work with writing modes.
In order to minimize layout test changes, layers no longer incorporate right/bottom overflow into their width/height members.
Doing so uncovered two bugs where left/top overflow was ignored (proof that even having layer dimensions is harmful).
A render tree dump hack has been put into the code to keep this overflow dumping for the RenderView's layer, since otherwise
a huge number of tests would change.
Added fast/overflow/overflow-rtl-vertical.html to test vertical writing-mode overflow. Existing tests cover the rest.
* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::forceLayoutForPagination):
Changed to use RenderView's docTop/Left/Width/Height accessors, which simply grab the overflow and properly flip it
to account for writing modes.
* platform/graphics/IntRect.h:
(WebCore::IntRect::shiftLeftEdgeTo):
(WebCore::IntRect::shiftRightEdgeTo):
(WebCore::IntRect::shiftTopEdgeTo):
(WebCore::IntRect::shiftBottomEdgeTo):
New helper functions for sliding the edge of a rectangle without moving any of the other three edges.
* rendering/InlineBox.h:
(WebCore::InlineBox::frameRect):
frameRect is a helper for obtaining the x, y, width, height of an InlineBox as an IntRect.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
All of the overflow setting in the inline direction has been removed from this function. All line overflow is computed
at once now in a single function: computeOverflow.
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
Helper for propagating overflow from specific types of children that occur on a line into the InlineFlowBox's overflow.
(WebCore::InlineFlowBox::computeOverflow):
The new function that computes both horizontal and vertical overflow for a line box.
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
(WebCore::InlineFlowBox::setOverflowFromLogicalRects):
New functions that set the overflow computed by computeOverflow. These replace setBlockDirectionOverflowPositions
and setInlineDirectionOverflowPositions. They essentially do the same thing, but they operate on rectangles.
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
Changed to use visual overflow instead of visible overflow. (Visible overflow as a union of layout and visual
overflow is no longer necessary, since visual overflow is now equivalent to the old visible overflow concept.)
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::logicalLayoutOverflowRect):
(WebCore::InlineFlowBox::logicalVisualOverflowRect):
Helpers for obtaining logical overflow rectangles, since lines compute their overflow in logical terms before
converting to block coordinates at the end.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
Blocks now have a computeOverflow function called at the end of layout that adds in all the types of overflow. The addOverflowFromChildren
method is virtual so that RenderListItem and RenderTable can subclass it. RenderListItem has to position its list marker and
propagate marker overflow up, and RenderTable adds in overflow from its sections.
(WebCore::RenderBlock::layoutOnlyPositionedObjects):
(WebCore::RenderBlock::layoutPositionedObjects):
When only positioned objects lay out, overflow must still be recomputed. The refactoring of overflow computation into a single
callable method: computeOverflow, makes it possible for this to be done easily.
(WebCore::RenderBlock::paint):
visible -> visual.
(WebCore::RenderBlock::addOverhangingFloats):
The propagation of float overflow has changed substantially. The basic rules are:
(1) The float must be in our floating objects list to contribute to overflow.
(2) The float must be a descendant to contribute to overflow.
(3) The block must have the outermost list that contains the float, or it has a self-painting layer and
so the float needs to be included in its overflow.
(WebCore::RenderBlock::nodeAtPoint):
visible -> visual.
(WebCore::RenderBlock::layoutColumns):
Remove column overflow computation from layoutColumns and move it to computeOverflow.
(WebCore::RenderBlock::adjustLinePositionForPagination):
visible -> visual.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::scrollbarsChanged):
Added a new virtual method used by table cells when scrollbars in an overflow:auto/scroll table cell come and go.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
visible -> visual.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
Patched to use layoutOverflow functions instead of the old rightmost/leftmostPosition functions.
(WebCore::RenderBox::paintRootBoxDecorations):
Use docLeft and docTop here, so that writing modes are handled.
(WebCore::RenderBox::clippedOverflowRectForRepaint):
visible -> visual.
(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
* rendering/RenderBox.h:
The new overflow system for boxes. Layout overflow now crosses self-painting layer boundaries and adjusts child boxes
for transforms, relative positioning and writing mode differences.
(WebCore::RenderBox::layoutOverflowRect):
(WebCore::RenderBox::topLayoutOverflow):
(WebCore::RenderBox::bottomLayoutOverflow):
(WebCore::RenderBox::leftLayoutOverflow):
(WebCore::RenderBox::rightLayoutOverflow):
Changed the default rectangle for layout overflow to be the client box to match the scrollable areas of overflow regions.
(WebCore::RenderBox::clientLogicalBottom):
New helper for obtaining the logical bottom of the client box.
(WebCore::RenderBox::clientBoxRect):
New helper for obtaining the clientLeft/Top/Width/Height box.
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::relativePositionLogicalOffset):
Helper for obtaining the relative position offset transposed for vertical writing modes. Used by line overflow.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
Changed flexible boxes to just call the base class computeOverflow method.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
visible -> visual.
* rendering/RenderInline.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
Changed layers to no longer incorporate right/bottom overflow into width/height. This is the reason many layout
tests change. (Not doing this makes the layout test changes far worse, since overflow propagates across self-painting
layers now.)
(WebCore::RenderLayer::overflowTop):
(WebCore::RenderLayer::overflowBottom):
(WebCore::RenderLayer::overflowLeft):
(WebCore::RenderLayer::overflowRight):
overflowTop/Bottom/Left/Right return overflow that accounts for writing modes, i.e., purely physical overflow that can be used
to set up the scroll area.
(WebCore::RenderLayer::computeScrollDimensions):
Drastically simplified this method now that overflowTop/Bottom/Left/Right just do the right thing regarding unreachable overflow.
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Make sure to explicitly set the vertical scrollbar's position just as we did with horizontal scrollbars, so that clamping to the
bottom works.
(WebCore::performOverlapTests):
(WebCore::RenderLayer::paintLayer):
Fix a bug in performOverlapTests. It incorrectly used the layer's bounds, and so it didn't account for left/top overflow out
of the layer (see why I hate layers even having dimensions?). Changed it to use the bounding box of the layer instead.
(WebCore::RenderLayer::hitTest):
Fix a bug in hit testing. It incorrectly used the root layer's bounds as the limit of the hit test, and so it didn't account
for left/top overflow in a ScrollView (hate hate hate layers having dimensions). I changed it to use the hit test rect instead,
so that the damage rect never stops the point from being tested (unless the hit test request says not to ignore clipping).
(WebCore::RenderLayer::localBoundingBox):
visible -> visual.
* rendering/RenderLayer.h:
Added the new overflowTop/Left/Right/Bottom accessors.
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
visible -> visual.
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::addOverflowFromChildren):
(WebCore::RenderListItem::positionListMarker):
* rendering/RenderListItem.h:
RenderListItem now positions the list marker when computing its overflow, since the marker propagates overflow back up to the list item.
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
visible -> visual.
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
Changed to use overflow functions instead of rightmost/lowestPosition.
* rendering/RenderMedia.cpp:
* rendering/RenderMedia.h:
Removed the lowest/topmost/rightmost/leftmostPosition functions, since control overflow is handled properly already.
* rendering/RenderOverflow.h:
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
Add new setters for layout and visual overflow as rects.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
visible -> visual.
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layout):
Call computeOverflow to recompute our overflow information after we adjust the ruby.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::paint):
* rendering/RenderTable.h:
Move section overflow propagation into addOverflowFromChildren, and change RenderTable to just call computeOverflow.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
visible -> visual.
(WebCore::RenderTableCell::scrollbarsChanged):
Adding unreachable overflow support (something that in the old code only existed for positioned objects in the root view) exposed
a bug in table layout. If scrollbars are added during the layout that occurs after intrinsic padding was incorporated into the
cell, then the cell won't lay out properly the second time (after the scrollbars have been added). We have to adjust the intrinsic
padding accounting for the presence of the new scrollbar so the second layout will get the right dimensions.
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::hasVisualOverflow):
visible -> visual.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderTableSection.h:
visible -> visual. Removed the leftmost/rightmost/topmost/bottommostPosition functions.
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
Added a hack to render tree dumping to include right/bottom overflow for the root layer only. This keeps a zillion layout tests
from failing.
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
(WebCore::RenderView::docTop):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docRight):
* rendering/RenderView.h:
(WebCore::RenderView::docHeight):
(WebCore::RenderView::docWidth):
RenderView now uses docLeft/Top/Height/Width functions, which are just overflow queries that account for writing modes. These methods
are now the preferred way to query for the physical dimensions of a document.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::addHighlightOverflow):
Changed to call setOverflowFromLogicalRects instead of the block/inline position functions.
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Remove the computation of block direction overflow, since it now all happens at once after the line is built.
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
* rendering/RootInlineBox.h:
Added a new helper function for incorporating the end padding into a line. This end padding also includes the single pixel for a caret
in LTR if needed.
2010-12-06 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Replaced GraphicsLayerMac with GraphicsLayerCA. GraphicsLayerCA is essentially
identical to GraphicsLayerMac, but replaces all the CoreAnimation specific calls
with calls to PlatformCALayer and PlatformCAAnimation. This makes GraphicsLayerCA
platform neutral as long as implementations of those two classes are available.
Added implementations in PlatformCALayerMac and PlatformCAAnimationMac. Also got
rid of GraphicsLayer::nativeLayer() and replaced it with GraphicsLayer::platformLayer()
to avoid confusion since both names were used to refer to the same thing.
This patch is only for Mac. Windows implementation has not changed.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GraphicsLayer.h:
* platform/graphics/ca/GraphicsLayerCA.cpp: Copied from WebCore/platform/graphics/ca/GraphicsLayerCA.cpp.
* platform/graphics/ca/GraphicsLayerCA.h: Copied from WebCore/platform/graphics/ca/GraphicsLayerCA.h.
* platform/graphics/ca/PlatformCAAnimation.h: Copied from WebCore/platform/graphics/ca/PlatformCAAnimation.h.
* platform/graphics/ca/PlatformCALayer.h: Copied from WebCore/platform/graphics/ca/PlatformCALayer.h.
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm: Copied from WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm.
(toCAMediaTimingFunction):
* platform/graphics/ca/mac/PlatformCALayerMac.mm: Copied from WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm.
(PlatformCALayer::PlatformCALayer):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/mac/GraphicsLayerMac.h: Removed.
* platform/graphics/mac/GraphicsLayerMac.mm: Removed.
* platform/graphics/mac/WebLayer.h:
* platform/graphics/mac/WebLayer.mm:
(-[WebLayer setNeedsDisplay]):
(-[WebLayer setNeedsDisplayInRect:]):
(-[WebLayer display]):
(-[WebLayer drawInContext:]):
* platform/graphics/mac/WebTiledLayer.h:
* platform/graphics/mac/WebTiledLayer.mm:
(-[WebTiledLayer setNeedsDisplay]):
(-[WebTiledLayer setNeedsDisplayInRect:]):
(-[WebTiledLayer display]):
(-[WebTiledLayer drawInContext:]):
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::flushChanges):
* platform/graphics/qt/GraphicsLayerQt.h:
* platform/graphics/win/GraphicsLayerCACF.cpp:
* platform/graphics/win/GraphicsLayerCACF.h:
2010-12-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Font antialiasing (smoothing) changes when elements are rendered into compositing layers
https://bugs.webkit.org/show_bug.cgi?id=23364
Text rendered by Core Graphics over a transparent background looks bad because of
font smoothing, so turn off smoothing when rendering text into compositing layers.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setAllowsFontSmoothing):
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
2010-12-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[WINCE] Add build system
https://bugs.webkit.org/show_bug.cgi?id=50522
* CMakeListsWinCE.txt: Added.
2010-12-06 Chris Fleizach <cfleizach@apple.com>
Reviewed by Oliver Hunt.
AX does not support HTML5 "required"
https://bugs.webkit.org/show_bug.cgi?id=50507
Test: platform/mac/accessibility/html5-required-attribute.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isRequired):
2010-12-06 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] using shadows leaks memory
https://bugs.webkit.org/show_bug.cgi?id=50541
Fixed leaks in the shadow code.
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::drawPatternToCairoContext): adoptRef instead of just
getting a new reference.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow): handle cairo_path_t with smart
pointers.
2010-12-06 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: remove duplicate code for capturing stack trace
https://bugs.webkit.org/show_bug.cgi?id=50461
No new tests. Covered with existing inspector tests.
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* bindings/js/ScriptCallStackFactory.h:
* bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::toScriptCallFrame):
(WebCore::toScriptCallFramesVector):
(WebCore::createScriptCallStack):
* bindings/v8/ScriptCallStackFactory.h:
* bindings/v8/V8ConsoleMessage.cpp:
(WebCore::V8ConsoleMessage::handler):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
(WebCore::ScriptCallFrame::isEqual):
(WebCore::ScriptCallFrame::buildInspectorObject):
* inspector/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::sourceURL):
* inspector/ScriptCallStack.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
== Rolled over to ChangeLog-2010-12-06 ==
|