1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112
|
2012-11-29 Tommy Widenflycht <tommyw@google.com>
Speech Recognition API: Update SpeechRecognitionEvent to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407
Reviewed by Adam Barth.
Adding the new didReceiveResults method.
* public/WebSpeechRecognizerClient.h:
* src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::didReceiveResults):
(WebKit):
* src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):
2012-11-30 Keishi Hattori <keishi@webkit.org>
[Chromium] Page popup doesn't change mouse cursor
https://bugs.webkit.org/show_bug.cgi?id=97454
Reviewed by Kent Tamura.
The mouse cursor should change based on the page popup content and not the main window content.
On Mac the mousemove event propagates to both the page popup and main window causing the cursor to flicker.
The change to ChromeClientImpl stops that.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::setCursor): On Mac, don't update the mouse cursor if a popup is open.
* src/WebPagePopupImpl.cpp: Implement setCursor so the mouse cursor gets set based on the page popup content.
2012-11-30 Mihai Maerean <mmaerean@adobe.com>
[CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=101192
Reviewed by Hajime Morita.
Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
Tests: No new tests because there is no functional change.
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* public/WebSettings.h: moved setExperimentalCSSRegionsEnabled to the bottom of the interface and made it a
no-op. After this patch lands and Chromium's webkit_rev is increased, we'll remove any callers in Chromium. Once
the Chromium callers are gone and WebKit's chromium_rev is increased, we'll remove the deprecated API.
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCSSRegions):
(WebKit):
(WebKit::WebRuntimeFeatures::isCSSRegionsEnabled):
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:
(WebSettingsImpl):
2012-11-29 Rafael Weinstein <rafaelw@chromium.org>
[HTMLTemplateElement] Add feature flag
https://bugs.webkit.org/show_bug.cgi?id=103694
Reviewed by Adam Barth.
This flag will guard the implementation of the HTMLTemplateElement.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
* features.gypi:
2012-11-29 David Grogan <dgrogan@chromium.org>
IndexedDB: Propagate more leveldb errors to script
https://bugs.webkit.org/show_bug.cgi?id=103580
Reviewed by Tony Chang.
* tests/IDBFakeBackingStore.h:
Update method signatures.
2012-11-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r136171.
http://trac.webkit.org/changeset/136171
https://bugs.webkit.org/show_bug.cgi?id=103695
Likely caused ReOpenedWithID and ReOpenedWithURL to fail in
linux/chromeos (Requested by zhenyao on #webkit).
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::startMainThreadMonitoring):
(WebKit):
(WebKit::InspectorClientImpl::stopMainThreadMonitoring):
(WebKit::InspectorClientImpl::willProcessTask):
(WebKit::InspectorClientImpl::didProcessTask):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::detach):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
2012-11-29 Sadrul Habib Chowdhury <sadrul@chromium.org>
[chromium] Remove deprecated API since it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=103570
Reviewed by Adam Barth.
Remove WebPluginContainer::setIsAcceptingTouchEvents, since this is not used anymore,
in favour of WebPluginContainer::requestTouchEventType.
* public/WebPluginContainer.h:
(WebPluginContainer):
* src/WebPluginContainerImpl.cpp:
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
2012-11-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-29 Eugene Klyuchnikov <eustas@chromium.org>
Web Inspector: Make main-thread monitoring go through InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=103550
Reviewed by Pavel Feldman.
InspectorInstrumentation was a wrong path
* src/InspectorClientImpl.cpp: Remove TaskObserver implementation, and
listen/unlisten methods.
* src/InspectorClientImpl.h: Ditto.
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::attach):
Subscribe for main thread activity events.
(WebKit::WebDevToolsAgentImpl::detach):
Unsubscribe for main thread activity events.
(WebKit::WebDevToolsAgentImpl::willProcessTask): Implement TaskObserver
interface. Froward to InspectorController.
(WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto.
* src/WebDevToolsAgentImpl.h: Implement TaskObserver interface.
2012-11-29 Stephen Chenney <schenney@chromium.org>
[Chromium] Add code supppression flags for skia
Unreviewed addition of Skia build flags to allow for their removal from Chromium's skia.gyp.
* skia_webkit.gyp: Added defines for SK_DISABLE_DITHER_32BIT_GRADIENT and SK_DISABLE_DASHING_OPTIMIZATION
2012-11-29 Florin Malita <fmalita@chromium.org>
[Skia] Add missing OpaqueRegionSkia notifier calls
https://bugs.webkit.org/show_bug.cgi?id=102824
Reviewed by Stephen White.
Add opaque region tracking unit tests for the new PlatformContextSkia draw methods.
* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):
2012-11-29 Miguel Garcia <miguelg@chromium.org>
Fix typo in description of openDateTimeChooser documentation
https://bugs.webkit.org/show_bug.cgi?id=103622
Reviewed by Kent Tamura.
* public/WebViewClient.h:
(WebViewClient):
2012-11-28 Robert Kroeger <rjkroege@chromium.org>
remove unused PlatformGestureCurve code
https://bugs.webkit.org/show_bug.cgi?id=103296
Reviewed by Adam Barth.
Previous CLs have made the Chromium embedder provide gesture fling
curve implementation to WebKit. Consequently no platform uses the
gestural fling code currently found in WebKit. This CL removes this code.
Code removal only: covered by existing tests.
* WebKit.gypi:
* tests/PlatformGestureCurveTest.cpp: Removed.
2012-11-28 Mark Pilgrim <pilgrim@chromium.org>
[Chromium] Remove pluginsScriptableObject from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=103542
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
* src/PlatformSupport.cpp:
(WebCore):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
2012-11-28 Mark Pilgrim <pilgrim@chromium.org>
[Chromium][Win] Remove ensureFontLoaded from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97696
Reviewed by Adam Barth.
Move ensureFontLoaded() from PlatformSupport to
FontPlatformDataChromiumWin. Part of a refactoring series; see
tracking bug 82948.
* src/PlatformSupport.cpp:
(WebCore):
2012-11-28 Eric Uhrhane <ericu@chromium.org>
[chromium] Add unit tests for ChromeClientImpl::getNavigationPolicy
https://bugs.webkit.org/show_bug.cgi?id=102424
Reviewed by Adam Barth.
This tests a bunch of basic scenarios regarding what will produce a
popup, a new foreground/background tab, or a new window.
* WebKit.gypi: Added test file.
* src/WebViewImpl.h:
(WebViewImpl): Added friend declaration for setCurrentInputEventForTest.
* tests/ChromeClientImplTest.cpp: Added.
2012-11-28 Alexandre Elias <aelias@chromium.org>
[chromium] Handle pinch correctly in slow-scrolling area
https://bugs.webkit.org/show_bug.cgi?id=102740
Reviewed by James Robinson.
With the nonmodal gesture event model, pinch zoom gestures involve
interleaved pinch and scroll events. This caused a bug on slow-scroll
areas: the scroll events were sent to the main thread and
the pinch events were handled in the impl thread.
This patch makes it so that scroll events are always handled in the impl
thread if a pinch is active.
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
* src/WebCompositorInputHandlerImpl.h:
* tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):
(WebKit):
2012-11-28 Sadrul Habib Chowdhury <sadrul@chromium.org>
[chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
https://bugs.webkit.org/show_bug.cgi?id=103092
Reviewed by Tony Chang.
A plugin can now request to receive raw touch events, or to receive mouse events synthesized
from the touch events, or to not receive any touch events at all.
* public/WebPluginContainer.h:
(WebPluginContainer):
* src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit):
* src/WebInputEventConversion.h:
(WebMouseEventBuilder):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents):
(WebKit):
(WebKit::WebPluginContainerImpl::requestTouchEventType):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
(WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
2012-11-28 David Grogan <dgrogan@chromium.org>
IndexedDB: Remove setVersion from WK API
https://bugs.webkit.org/show_bug.cgi?id=103456
Reviewed by Darin Fisher.
These are the last vestiges of this ancient API. The bulk of the
removal was done in bug 94972.
* public/WebIDBCallbacks.h:
* public/WebIDBDatabase.h:
2012-11-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-27 James Simonsen <simonjam@chromium.org>
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151
Reviewed by Adam Barth.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::initializeLoader):
2012-11-27 Eberhard Graether <egraether@google.com>
[chromium] Add WebLayerTreeViewClient API to request font atlas
https://bugs.webkit.org/show_bug.cgi?id=102958
Reviewed by James Robinson.
This change makes the font atlas creation accessible to the WebLayerTreeView.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createFontAtlas):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
2012-11-27 Joshua Bell <jsbell@chromium.org>
IndexedDB: Simplify transaction timers and event tracking
https://bugs.webkit.org/show_bug.cgi?id=102984
Reviewed by Tony Chang.
Remove now-unused didCompleteTaskEvents() method.
* src/IDBTransactionBackendProxy.cpp:
* src/IDBTransactionBackendProxy.h:
(IDBTransactionBackendProxy):
* src/WebIDBTransactionImpl.cpp:
* src/WebIDBTransactionImpl.h:
2012-11-27 Alpha Lam <hclam@chromium.org>
[chromium] Implement full-featured image cache
https://bugs.webkit.org/show_bug.cgi?id=99784
Reviewed by Stephen White.
Added ImageFrameGeneratorTest to test cache logic and generation
of new cache entries.
ImageFrameGeneratorTest.cacheHit
Test that a complete cached entry is reused.
ImageFrameGeneratorTest.cacheMissWithScale
Cache miss for a scaled image but cache hit on a full size image.
Scaled image is created from cached full size image.
ImageFrameGeneratorTest.cacheMissWithDecodeAndScale
Cache miss for both scaled image and full size image.
ImageFrameGeneratorTest.cacheMissWithIncompleteDecode
Test the logic for handling incomplete cache objects.
* WebKit.gypi:
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):
* tests/DeferredImageDecoderTest.cpp:
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::decoderBeingDestroyed):
(WebCore::DeferredImageDecoderTest::frameBufferRequested):
(DeferredImageDecoderTest):
(WebCore::DeferredImageDecoderTest::frameStatus):
* tests/ImageFrameGeneratorTest.cpp: Added.
(WebCore):
(WebCore::fullSize):
(WebCore::scaledSize):
(MockImageDecoderFactory):
(WebCore::MockImageDecoderFactory::create):
(WebCore::MockImageDecoderFactory::MockImageDecoderFactory):
(ImageFrameGeneratorTest):
(WebCore::ImageFrameGeneratorTest::SetUp):
(WebCore::ImageFrameGeneratorTest::TearDown):
(WebCore::ImageFrameGeneratorTest::decoderBeingDestroyed):
(WebCore::ImageFrameGeneratorTest::frameBufferRequested):
(WebCore::ImageFrameGeneratorTest::frameStatus):
(WebCore::ImageFrameGeneratorTest::createCompleteImage):
(WebCore::ImageFrameGeneratorTest::setFrameStatus):
(WebCore::TEST_F):
* tests/MockImageDecoder.h:
(MockImageDecoderClient):
(WebCore::MockImageDecoder::frameBufferAtIndex):
2012-11-27 David Grogan <dgrogan@chromium.org>
IndexedDB: Remove IDBDatabase.setVersion API
https://bugs.webkit.org/show_bug.cgi?id=94972
Reviewed by Tony Chang.
* src/IDBCallbacksProxy.cpp:
* src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/WebIDBCallbacksImpl.cpp:
* src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
2012-11-27 Eberhard Graether <egraether@google.com>
Plumbing showPaintRects out of InspectorPageAgent to use a different drawing implementation if available.
https://bugs.webkit.org/show_bug.cgi?id=102452
Reviewed by Pavel Feldman.
This change makes the showPaintRects setting in the Web Inspector's settings notify InspectorClient
when changed. And the default paint rects drawing is not used if an alternative is available.
This allows Chromium to draw the paint rects in the compositor's HUDLayer.
* public/WebView.h:
(WebView):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::overridesShowPaintRects):
(WebKit):
(WebKit::InspectorClientImpl::setShowPaintRects):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setShowPaintRects):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
2012-11-27 Tony Chang <tony@chromium.org>
[chromium] Unreviewed build fix on Linux clang.
../../third_party/WebKit/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1055:63: error:
C++98 requires an accessible copy constructor for class 'WebKit::WebCachedURLRequest' when binding
a reference to a temporary; was private [-Werror,-Wbind-to-temporary-copy]
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchWillRequestResource):
2012-11-27 Marja Hölttä <marja@chromium.org>
Add callbacks to the FrameLoaderClient when a resource is requested
https://bugs.webkit.org/show_bug.cgi?id=92761
Reviewed by Adam Barth.
In Chromium, when an extension script cancels a network
request (which happens out of process), we'd like to
notify content scripts running on the current page about
which elements failed to load because the requests were
cancelled (as opposed to e.g. the network request just
didn't work). Since the resource request itself does not
carry any information what DOM element is was made for,
currently a content script has to search the DOM tree and
guess which requests will be cancelled by its counter
part. By adding these callbacks, the embedder can make
this connection explictly.
* WebKit.gyp:
* public/WebCachedURLRequest.h: Added.
(WebKit):
(WebCachedURLRequest):
(WebKit::WebCachedURLRequest::~WebCachedURLRequest):
* public/WebFrameClient.h:
(WebKit):
(WebFrameClient):
(WebKit::WebFrameClient::willRequestResource):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchWillRequestResource):
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
* src/WebCachedURLRequest.cpp: Added.
(WebKit):
(WebKit::WebCachedURLRequest::reset):
(WebKit::WebCachedURLRequest::urlRequest):
(WebKit::WebCachedURLRequest::charset):
(WebKit::WebCachedURLRequest::forPreload):
(WebKit::WebCachedURLRequest::initiatorName):
(WebKit::WebCachedURLRequest::initiatorElement):
(WebKit::WebCachedURLRequest::WebCachedURLRequest):
2012-11-27 Keishi Hattori <keishi@webkit.org>
Add WebLocalizedString for validation type badinput
https://bugs.webkit.org/show_bug.cgi?id=103381
Reviewed by Kent Tamura.
* src/LocalizedStrings.cpp:
(WebCore::validationMessageBadInputForNumberText): Using the newly added WebLocalizedString enum.
(WebCore::validationMessageBadInputForDateTimeText): Ditto.
2012-11-27 Alec Flett <alecflett@chromium.org>
IndexedDB: stub out IDBDatabaseBackendInterface::createTransaction
https://bugs.webkit.org/show_bug.cgi?id=102730
Reviewed by Darin Fisher.
Add support for new createTransaction() method in both sides
of the WebKit API.
* public/WebIDBDatabase.h:
(WebIDBDatabase):
(WebKit::WebIDBDatabase::createTransaction):
* src/IDBDatabaseBackendProxy.cpp:
(WebKit):
(WebKit::IDBDatabaseBackendProxy::createTransaction):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::createTransaction):
(WebKit):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
2012-11-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135786.
http://trac.webkit.org/changeset/135786
https://bugs.webkit.org/show_bug.cgi?id=103379
It made 3 plugin tests timeout on several platforms (Requested
by Ossy on #webkit).
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::initializeLoader):
2012-11-25 Kent Tamura <tkent@chromium.org>
Implement ValidityState::badInput
https://bugs.webkit.org/show_bug.cgi?id=102861
Reviewed by Hajime Morita.
* src/LocalizedStrings.cpp:
Add placeholder implementations for new localized string functions.
We'll update them in another patch.
(WebCore::validationMessageBadInputForNumberText):
(WebCore::validationMessageBadInputForDateTimeText):
2012-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135798.
http://trac.webkit.org/changeset/135798
https://bugs.webkit.org/show_bug.cgi?id=103354
Broke the chrome mac build (Requested by noel_ on #webkit).
* WebKit.gypi:
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):
* tests/DeferredImageDecoderTest.cpp:
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::decoderBeingDestroyed):
* tests/ImageFrameGeneratorTest.cpp: Removed.
* tests/MockImageDecoder.h:
(MockImageDecoderClient):
(WebCore::MockImageDecoder::frameBufferAtIndex):
2012-11-26 Alexandre Elias <aelias@chromium.org>
[chromium] Touchscreen fling handling
https://bugs.webkit.org/show_bug.cgi?id=103278
Reviewed by James Robinson.
The fling logic for touchpad can fall through to bad
performance in several ways. This patch introduces an alternate
path for touchscreen fling that simplifies it as follows:
- Stop generating wheel events, to prevent unnecessary scrollBegin hit
tests and to avoid falling back to slow path if a wheel handler is
registered.
- Drop the event on ScrollStatusIgnored. There's no real reason to
send the event to the WebKit thread here.
- Don't call transferActiveWheelFlingAnimation. This type of
transition shouldn't be needed with touchscreen flings.
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):
* src/WebCompositorInputHandlerImpl.h:
2012-11-26 Kentaro Hara <haraken@chromium.org>
[V8] Remove WorkerContextExecutionProxy.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=103325
Reviewed by Adam Barth.
Now WorkerContextExecutionProxy.{h,cpp} are empty.
No tests. No change in behavior.
* src/WebKit.cpp:
* src/WebWorkerClientImpl.cpp:
2012-11-26 James Robinson <jamesr@chromium.org>
[chromium] Remove deprecated and unused WebGraphicsContext3D compositor binding calls
https://bugs.webkit.org/show_bug.cgi?id=103322
Reviewed by Adam Barth.
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):
2012-11-26 Alpha Lam <hclam@chromium.org>
[chromium] Implement full-featured image cache
https://bugs.webkit.org/show_bug.cgi?id=99784
Reviewed by James Robinson.
Added ImageFrameGeneratorTest to test cache logic and generation
of new cache entries.
ImageFrameGeneratorTest.cacheHit
Test that a complete cached entry is reused.
ImageFrameGeneratorTest.cacheMissWithScale
Cache miss for a scaled image but cache hit on a full size image.
Scaled image is created from cached full size image.
ImageFrameGeneratorTest.cacheMissWithDecodeAndScale
Cache miss for both scaled image and full size image.
ImageFrameGeneratorTest.cacheMissWithIncompleteDecode
Test the logic for handling incomplete cache objects.
* WebKit.gypi:
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):
* tests/DeferredImageDecoderTest.cpp:
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::decoderBeingDestroyed):
(WebCore::DeferredImageDecoderTest::frameBufferRequested):
(DeferredImageDecoderTest):
(WebCore::DeferredImageDecoderTest::frameStatus):
* tests/ImageFrameGeneratorTest.cpp: Added.
(WebCore):
(WebCore::fullSize):
(WebCore::scaledSize):
(MockImageDecoderFactory):
(WebCore::MockImageDecoderFactory::create):
(WebCore::MockImageDecoderFactory::MockImageDecoderFactory):
(ImageFrameGeneratorTest):
(WebCore::ImageFrameGeneratorTest::SetUp):
(WebCore::ImageFrameGeneratorTest::TearDown):
(WebCore::ImageFrameGeneratorTest::decoderBeingDestroyed):
(WebCore::ImageFrameGeneratorTest::frameBufferRequested):
(WebCore::ImageFrameGeneratorTest::frameStatus):
(WebCore::ImageFrameGeneratorTest::createCompleteImage):
(WebCore::ImageFrameGeneratorTest::setFrameStatus):
(WebCore::TEST_F):
* tests/MockImageDecoder.h:
(MockImageDecoderClient):
(WebCore::MockImageDecoder::frameBufferAtIndex):
2012-11-26 Varun Jain <varunjain@chromium.org>
LongPress and LongTap gestures should start drag/drop and open context menu respectively.
https://bugs.webkit.org/show_bug.cgi?id=101545
Reviewed by Antonio Gomes.
For LongPress, we simulate drag by sending a mouse down and mouse drag
events. If a drag is not started (because maybe there is no draggable
element), then we show context menu instead (which is the current
behavior for LongPress). For LongTap, we use the existing functions that
LongPress uses to summon the context menu. LongPress initiated drag and
drop can be enabled/disabled by the platform using the Setting
touchDragDropEnabled which is disabled by default.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setTouchDragDropEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
2012-11-26 Yusuf Ozuysal <yusufo@google.com>
Add hasTouchEventhandlersAt to WebView API
https://bugs.webkit.org/show_bug.cgi?id=102541
Reviewed by James Robinson.
Adds hasTouchEventHandlersAt to WebWidget API to check for touch event handlers at a
given point. This will be used to distinguish between events not processed by
touch event handlers and event not hitting any touch event handlers. Both are
returning the same ACK message currently. Default implementation returns true to
continue the same behavior as we currently have.
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::hasTouchEventHandlersAt):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hasTouchEventHandlersAt):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
2012-11-26 James Simonsen <simonjam@chromium.org>
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151
Reviewed by Adam Barth.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::initializeLoader):
2012-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135743.
http://trac.webkit.org/changeset/135743
https://bugs.webkit.org/show_bug.cgi?id=103280
Caused compile failure 'SK_DISABLE_DITHER_32BIT_GRADIENT'
macro redefined (Requested by rjkroege on #webkit).
* skia_webkit.gyp:
2012-11-26 Mike Reed <reed@google.com>
add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining
https://bugs.webkit.org/show_bug.cgi?id=103272
Reviewed by NOBODY. Unreviewed.
No behavior change, as this define already exists on the chrome side in SkUserConfig.h
* skia_webkit.gyp:
2012-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135735.
http://trac.webkit.org/changeset/135735
https://bugs.webkit.org/show_bug.cgi?id=103270
Caused breakage across the Chromium tree. (Requested by
rjkroege_ on #webkit).
* skia_webkit.gyp:
2012-11-26 Mike Reed <reed@google.com>
add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining
https://bugs.webkit.org/show_bug.cgi?id=103269
Reviewed by NOBODY. Unreviewed.
No behavior change, as this define already exists on the chrome side in SkUserConfig.h
* skia_webkit.gyp:
2012-11-26 Scott Violet <sky@chromium.org>
[chromium] Make use_default_render_theme compile the right set of files
https://bugs.webkit.org/show_bug.cgi?id=102952
Reviewed by Kent Tamura.
* WebKit.gyp: Adds WebRenderTheme.* and updates rules as to when to compile them.
* features.gypi: Removes use_default_render_theme default values as common.gypi sets them.
* public/default: Added.
* public/default/WebRenderTheme.h: Copy of linux/WebRenderTheme.h
* src/default: Added.
* src/default/WebRenderTheme.cpp: Copy of linux/WebRenderTheme.cpp
2012-11-24 Silvia Pfeiffer <silviapf@chromium.org>
[chromium] Remove traces of MediaControlRootElement
https://bugs.webkit.org/show_bug.cgi?id=103174
Reviewed by Adam Barth.
Now that nothing is using MediaControlRootElement any more,
we can remove the FIXME and MediaControlRootElement enum left
over from bug 88871.
* public/WebContextMenuData.h:
2012-11-23 Robert Kroeger <rjkroege@chromium.org>
Remove unused ScrollByPixelVelocity
https://bugs.webkit.org/show_bug.cgi?id=102840
Reviewed by Sam Weinig.
Removed test for deleted code.
* tests/ScrollAnimatorNoneTest.cpp:
2012-11-23 Alexis Menard <alexis@webkit.org>
[CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
https://bugs.webkit.org/show_bug.cgi?id=102104
Reviewed by Julien Chaffraix.
Protect the new feature behind a feature flag.
* features.gypi:
2012-11-23 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium Win compilation after r135580.
https://bugs.webkit.org/show_bug.cgi?id=101772
* tests/WebFrameTest.cpp:
2012-11-23 Sami Kyostila <skyostil@chromium.org>
[chromium] Remove WebScreenInfo.{horizontal,vertical}DPI
https://bugs.webkit.org/show_bug.cgi?id=101772
Reviewed by Adam Barth.
Now that nothing is using WebScreenInfo.{horizontal,vertical}DPI we can simply
remove them.
* src/mac/WebScreenInfoFactory.mm:
(WebKit::WebScreenInfoFactory::screenInfo):
* src/win/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
* src/x11/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
2012-11-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-22 Dana Jansens <danakj@chromium.org>
[chromium] Add OS!="ios" to guard for gcc_version in WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=103007
Reviewed by Adam Barth.
This matches the guards used in chromium's chrome/chrome_browser.gypi.
* WebKit.gyp:
2012-11-22 Stephen Chenney <schenney@chromium.org>
[Chromium]: Removing gyp flags controlling Skia features.
Unreviewed, pre-tested rendering changes that have been waiting for a chance to rebaseline tests.
Enabled fixes for test rendering, and fast patsh for anti-aliased primitives.
* skia_webkit.gyp:
2012-11-22 Dan Carney <dcarney@google.com>
IDBRequestTest needs a v8 context
https://bugs.webkit.org/show_bug.cgi?id=102941
Reviewed by Jochen Eisinger.
Added v8 context to IDBRequestTest tests.
* tests/IDBRequestTest.cpp:
(IDBRequestTest):
(WebKit::IDBRequestTest::IDBRequestTest):
(WebKit::IDBRequestTest::context):
(WebKit::IDBRequestTest::scriptExecutionContext):
(WebKit):
(WebKit::TEST_F):
2012-11-21 Tien-Ren Chen <trchen@chromium.org>
[chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
https://bugs.webkit.org/show_bug.cgi?id=100061
Reviewed by Adam Barth.
On Android we're using a different pixel scaling implementation
(WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
platforms. In this mode, we don't make use of device-independent pixels. Device
scale factor is provided to WebKit and get merged into page scale factor. Other
than that device scale factor should have no effects on rendering.
* src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::paint):
* src/PageWidgetDelegate.h:
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::paint):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::shouldApplyDeviceScaleFactorInCompositor):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
2012-11-21 Tien-Ren Chen <trchen@chromium.org>
Use m_webView->size() for viewport update
https://bugs.webkit.org/show_bug.cgi?id=102764
Reviewed by Adam Barth.
m_webView->client()->windowRect() returns the outer rect of the browser
window, which includes the decorations such as the title bar.
We should use the size of the WebView for layout and rendering purpose.
Existing tests are updated to work without windowRect().
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* tests/WebFrameTest.cpp:
2012-11-21 Peter Beverloo <peter@chromium.org>
[Chromium] webkit_unit_tests should depend on forwarder2 for Android
https://bugs.webkit.org/show_bug.cgi?id=102934
Reviewed by Tony Chang.
Running webkit_unit_tests and TestWebKitAPI in the WebKit tree will defer
to the test runner used by Chromium, which in turn relies on forwarder2.
forwarder2 will eventually be required by layout tests as well.
* WebKitUnitTests.gyp:
2012-11-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135409.
http://trac.webkit.org/changeset/135409
https://bugs.webkit.org/show_bug.cgi?id=102959
This patch causes compiling error to Chromium build (Requested
by jianli_ on #webkit).
* tests/IDBRequestTest.cpp:
(WebCore::TEST):
2012-11-21 Kevin Ellis <kevers@chromium.org>
[chromium] Add flag to enable/disable touch adjustment at runtime.
https://bugs.webkit.org/show_bug.cgi?id=102534
Reviewed by Antonio Gomes.
Add setting for enabling or disabling touch adjustment.
For touch adjustemnt to apply, the compile option must
also be enabled.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setEnableTouchAdjustment):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
2012-11-21 Dan Carney <dcarney@google.com>
IDBRequestTest needs a v8 context
https://bugs.webkit.org/show_bug.cgi?id=102941
Reviewed by Jochen Eisinger.
Added v8 context to IDBRequestTest tests.
* tests/IDBRequestTest.cpp:
(IDBRequestTest):
(WebKit::IDBRequestTest::IDBRequestTest):
(WebKit::IDBRequestTest::context):
(WebKit::IDBRequestTest::scriptExecutionContext):
(WebKit):
(WebKit::TEST_F):
2012-11-21 Peter Beverloo <peter@chromium.org>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-21 Allan Sandfeld Jensen <allan.jensen@digia.com>
Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139
Reviewed by Julien Chaffraix.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::mouseDidMoveOverElement):
* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::characterIndexForPoint):
2012-11-21 W. James MacLean <wjmaclean@chromium.org>
[chromium] Link highlight should display for at least 100ms, and fadeout on GestureTap/Longpress.
https://bugs.webkit.org/show_bug.cgi?id=102823
Reviewed by Adrienne Walker.
Link highlights sometimes disappear so quickly they barely display. Modify
so that the highlight is displayed for minimum 100ms before fading out, and
also fadeout (as opposed to abrupt clear) on GestureTap and GestureLongPress.
* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimationIfNeeded): Check if min duration achieved, if not add time to fadeout animation.
* src/LinkHighlight.h:
(LinkHighlight):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent): Fadeout instead of clear on GestureTap and GestureLongPress.
2012-11-21 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Now that offending patch has been rolled out reenable IDBRequestTest.EventsAfterStopping
https://bugs.webkit.org/show_bug.cgi?id=102929
* tests/IDBRequestTest.cpp:
(WebCore::TEST):
2012-11-21 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Disable failing test.
https://bugs.webkit.org/show_bug.cgi?id=102929
* tests/IDBRequestTest.cpp:
(WebCore::TEST):
2012-11-21 Florin Malita <fmalita@chromium.org>
[Skia] Encapsulate access to PlatformContextSkia's SkCanvas
https://bugs.webkit.org/show_bug.cgi?id=102694
Reviewed by Stephen White.
Use PlatformContextSkia's wrapper methods instead of accessing the canvas directly.
* tests/TransparencyWinTest.cpp:
(WebCore::getPixelAt):
(WebCore::clearTopLayerAlphaChannel):
(WebCore::clearTopLayerAlphaPixel):
(WebCore::TEST):
2012-11-20 Rachel Blum <groby@chromium.org>
[Chromium] Need spellcheck suggestions even if continuous check is off.
https://bugs.webkit.org/show_bug.cgi?id=102535
Reviewed by Hajime Morita.
Make sure the context menu always has suggestions for misspelled words.
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2012-11-20 Robert Kroeger <rjkroege@chromium.org>
[chromium] Use embedder-supported gesture curves
https://bugs.webkit.org/show_bug.cgi?id=100884
Reviewed by James Robinson.
Use embedder-provided gesture animation curves via WebKit api interfaces.
Tested by existing tests.
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollBy):
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
* src/WebViewImpl.h:
(WebCore):
(WebKit):
(WebViewImpl):
2012-11-20 Tony Chang <tony@chromium.org>
When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
https://bugs.webkit.org/show_bug.cgi?id=102835
Reviewed by Ojan Vafai.
After r135082, Chromium browser_tests were triggering the ASSERT in
StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
trigger earlier and make it clear in the Chromium code that we're always
inserting user level styles.
* src/WebDocument.cpp:
(WebKit::WebDocument::insertUserStyleSheet):
2012-11-20 Istiaque Ahmed <lazyboy@chromium.org>
Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.
https://bugs.webkit.org/show_bug.cgi?id=102339
Reviewed by Adam Barth.
This change will allow converting a page's window coordinates to plugins's local coordinates,
taking CSS transformations into account. Embedder page of the plugin can use this information
for targetting elements inside the plugin (e.g. devtools can inspect a specific element at the
local coordinate position inside plugin).
* WebKit.gyp:
* WebKit.gypi:
* public/WebNode.h:
(WebKit):
* public/WebPluginContainer.h:
(WebKit):
(WebPluginContainer):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):
* src/WebNode.cpp:
(WebKit::WebNode::pluginContainer):
(WebKit):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::windowToLocalPoint):
(WebKit):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* tests/FakeWebPlugin.cpp: Added.
(WebKit):
(WebKit::FakeWebPlugin::FakeWebPlugin):
(WebKit::FakeWebPlugin::~FakeWebPlugin):
(WebKit::FakeWebPlugin::initialize):
(WebKit::FakeWebPlugin::destroy):
* tests/FakeWebPlugin.h: Added.
(WebKit):
(FakeWebPlugin):
* tests/WebPluginContainerTest.cpp: Added.
(WebKit):
(WebPluginContainerTest):
(WebKit::WebPluginContainerTest::WebPluginContainerTest):
(WebKit::WebPluginContainerTest::TearDown):
(WebKit::getWebPluginContainer):
(WebKit::TEST_F):
* tests/data/plugin_container.html: Added.
2012-11-20 Alpha Lam <hclam@chromium.org>
[chromium] Make lazy image decoding thread-safe
https://bugs.webkit.org/show_bug.cgi?id=102721
Reviewed by Stephen White.
Added a new unit test to verify that lazy image decoding operates
correctly on non-main threads.
* tests/DeferredImageDecoderTest.cpp:
(Rasterizer):
(WebCore):
(WebCore::rasterizeMain):
(WebCore::TEST_F):
2012-11-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135295.
http://trac.webkit.org/changeset/135295
https://bugs.webkit.org/show_bug.cgi?id=102834
This patch causes assertion to some layout tests on chromium
(Requested by jianli on #webkit).
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::initializeLoader):
2012-11-20 Eberhard Graether <egraether@google.com>
[Chromium] fix FPS counter disappearing when changing page
https://bugs.webkit.org/show_bug.cgi?id=102532
Reviewed by Pavel Feldman.
When changing the page with opened WebInspector and active FPS counter the WebInspector is
reloaded before the WebView switches to accelerated compositing, so the showFPSCounter call
to WebLayerTreeView is not yet possible. This fix saves the showFPSCounter value in the
WebSettings so it can be read when accelerated compositing is activated.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setShowFPSCounter):
2012-11-20 James Simonsen <simonjam@chromium.org>
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151
Reviewed by Adam Barth.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::initializeLoader):
2012-11-19 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium Win compilation after r135196.
https://bugs.webkit.org/show_bug.cgi?id=102021
* tests/DeferredImageDecoderTest.cpp: changed char to unsigned char in the array
declaration to avoid 'warning C4309' on MSVS when initializing from hex literals.
(WebCore):
2012-11-19 Miguel Garcia <miguelg@chromium.org>
[Chromium] Remove the dependency of INPUT_TYPE_COLOR on PAGE_POPUP
https://bugs.webkit.org/show_bug.cgi?id=102525
Reviewed by Kent Tamura.
INPUT_TYPE_COLOR should not depend on PAGE_POPUP, with this change we allow platforms like android to implement the former without depending on the latter.
Tested by compiling chromium with and without ENABLE_PAGE_POPUP and made sure that forms with input type color would load in both cases.
* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser):
* src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::ColorChooserUIController):
(WebKit::ColorChooserUIController::openUI):
(WebKit):
(WebKit::ColorChooserUIController::endChooser):
* src/ColorChooserUIController.h:
(ColorChooserUIController):
2012-11-19 Alpha Lam <hclam@chromium.org>
[chromium] Lazy image decoding without cache
https://bugs.webkit.org/show_bug.cgi?id=102021
Reviewed by Stephen White.
Updated two test cases using real image data.
The tests demonstrates that original image decoder is not used and
image is decoded lazily with correct pixel results.
* tests/DeferredImageDecoderTest.cpp:
(WebCore):
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::decoderBeingDestroyed):
(DeferredImageDecoderTest):
(WebCore::TEST_F):
* tests/MockImageDecoder.h:
(MockImageDecoderClient):
(WebCore):
(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::~MockImageDecoder):
(MockImageDecoder):
2012-11-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135180.
http://trac.webkit.org/changeset/135180
https://bugs.webkit.org/show_bug.cgi?id=102700
breaks ui/compositor build (Requested by danakj on #webkit).
* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2012-11-19 Yusuke Sato <yusukes@chromium.org>
[Chromium] Flash cannot receive scroll events when threaded compositing is in use
https://bugs.webkit.org/show_bug.cgi?id=101423
Reviewed by James Robinson.
Add setWantsWheelEvents() to Chromium's WebPluginContainer interface so that a plugin can tell the
container that the plugin always wants to handle wheel events even when a scroll bar is not shown.
* public/WebPluginContainer.h:
(WebPluginContainer):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setWantsWheelEvents):
(WebKit):
(WebKit::WebPluginContainerImpl::wantsWheelEvents):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
2012-11-19 Alec Flett <alecflett@chromium.org>
IndexedDB: simplify RecordIdentifier
https://bugs.webkit.org/show_bug.cgi?id=102018
Reviewed by Tony Chang.
Update IDBFakeBackingStore to match its parent class.
* tests/IDBFakeBackingStore.h:
2012-11-19 Vincent Scheib <scheib@chromium.org>
[Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock.
https://bugs.webkit.org/show_bug.cgi?id=96946
Reviewed by Adam Barth.
The runtime flag functionality has already been removed.
Now that Chromium no longer has a compile dependency on this
API, it can be removed as well.
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
2012-11-19 Kihong Kwon <kihong.kwon@samsung.com>
Add PROXIMITY_EVENTS feature
https://bugs.webkit.org/show_bug.cgi?id=102658
Reviewed by Kentaro Hara.
Add PROXIMITY_EVENTS feature to chromium port.
* features.gypi:
2012-11-19 Sami Kyostila <skyostil@chromium.org>
[chromium] Use devicePixelRatio instead of screen DPI for computing viewport attributes
https://bugs.webkit.org/show_bug.cgi?id=101767
Reviewed by Adam Barth.
Use the newly introduced device scale factor to calculate viewport properties
instead of using the screen DPI. No functional changes, because Chromium
platforms that have VIEWPORT enabled now also initialize the device scale
factor accordingly.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* tests/WebFrameTest.cpp:
2012-11-18 Kentaro Hara <haraken@chromium.org>
Unreviewed, rolling out r135047.
http://trac.webkit.org/changeset/135047
https://bugs.webkit.org/show_bug.cgi?id=102339
it broke Chromium Windows/Mac build
* WebKit.gyp:
* WebKit.gypi:
* public/WebNode.h:
(WebKit):
* public/WebPluginContainer.h:
(WebKit):
(WebPluginContainer):
* src/WebFrameImpl.cpp:
(WebKit::pluginContainerFromNode):
(WebKit):
(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):
* src/WebNode.cpp:
* src/WebPluginContainerImpl.cpp:
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* tests/FakeWebPlugin.cpp: Removed.
* tests/FakeWebPlugin.h: Removed.
* tests/WebPluginContainerTest.cpp: Removed.
* tests/data/plugin_container.html: Removed.
2012-11-18 Rick Byers <rbyers@chromium.org>
[chromium] add WebCursorInfo::imageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=102612
Reviewed by Adam Barth.
Add cursor image scale factor (currently always 1) to chromium API, in preparation for
high-dpi cursor support in bug 99493.
* public/WebCursorInfo.h:
(WebKit::WebCursorInfo::WebCursorInfo):
* src/WebCursorInfo.cpp:
(WebKit::WebCursorInfo::WebCursorInfo):
2012-11-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-17 Istiaque Ahmed <lazyboy@chromium.org>
Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.
https://bugs.webkit.org/show_bug.cgi?id=102339
Reviewed by Adam Barth.
This change will allow converting a page's window coordinates to plugins's local coordinates,
taking CSS transformations into account. Embedder page of the plugin can use this information
for targetting elements inside the plugin (e.g. devtools can inspect a specific element at the
local coordinate position inside plugin).
Attempting to re-land after Windows build fix.
* WebKit.gyp:
* WebKit.gypi:
* public/WebNode.h:
(WebKit):
* public/WebPluginContainer.h:
(WebKit):
(WebPluginContainer):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):
* src/WebNode.cpp:
(WebKit::WebNode::pluginContainer):
(WebKit):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::windowToLocalPoint):
(WebKit):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* tests/FakeWebPlugin.cpp: Added.
(WebKit):
(WebKit::FakeWebPlugin::FakeWebPlugin):
(WebKit::FakeWebPlugin::~FakeWebPlugin):
(WebKit::FakeWebPlugin::initialize):
(WebKit::FakeWebPlugin::destroy):
* tests/FakeWebPlugin.h: Added.
(WebKit):
(FakeWebPlugin):
* tests/WebPluginContainerTest.cpp: Added.
(WebKit):
(WebPluginContainerTest):
(WebKit::WebPluginContainerTest::WebPluginContainerTest):
(WebKit::WebPluginContainerTest::TearDown):
(WebKit::getWebPluginContainer):
(WebKit::TEST_F):
* tests/data/plugin_container.html: Added.
2012-11-16 Raman Kumar <ramankk@chromium.org>
Add setChecked API in WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=102422
Reviewed by Adam Barth.
* public/WebInputElement.h:
(WebInputElement): Add setChecked(bool, bool) API
* src/WebInputElement.cpp:
(WebKit::WebInputElement::setChecked): Implement setChecked by calling
underlying HTMLInputElement's setChecked.
(WebKit):
2012-11-16 Tony Chang <tony@chromium.org>
Remove ENABLE_CSS_HIERARCHIES since it's no longer in use
https://bugs.webkit.org/show_bug.cgi?id=102554
Reviewed by Andreas Kling.
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=79939#c41 ,
we're going to revist this feature once additional vendor support is
achieved.
* features.gypi:
2012-11-16 Mark Pilgrim <pilgrim@chromium.org>
[Chromium] Remove cookie-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=99340
Reviewed by Adam Barth.
Move cookie-related functions out of PlatformSupport and implement
new PlatformCookieJar interface via NetworkContext.
* WebKit.gyp:
* src/FrameNetworkingContextImpl.cpp: Added.
(WebKit):
(WebKit::FrameNetworkingContextImpl::cookieJar):
* src/FrameNetworkingContextImpl.h:
(FrameNetworkingContextImpl):
* src/PlatformSupport.cpp:
2012-11-16 Tien-Ren Chen <trchen@chromium.org>
Rename applyDefaultDeviceScaleFactorInCompositor to setApplyDeviceScaleFactorInCompositor
https://bugs.webkit.org/show_bug.cgi?id=102462
Reviewed by James Robinson.
As we no longer have this "default" device scale factor.
* public/WebSettings.h:
(WebKit::WebSettings::setApplyDefaultDeviceScaleFactorInCompositor):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setApplyDeviceScaleFactorInCompositor):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::applyDeviceScaleFactorInCompositor):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2012-11-16 Jon Lee <jonlee@apple.com>
Fix build error on Chromium due to r134995.
* src/WebNode.cpp:
(WebKit::WebNode::simulateClick): Pass in NULL pointer instead.
2012-11-16 Michael Pruett <michael@68k.org>
IndexedDB: Propagate DOMRequestState to IndexedDB binding utility functions
https://bugs.webkit.org/show_bug.cgi?id=102430
Reviewed by Adam Barth.
DOMRequestState is currently propagated to some but not all of
the IndexedDB binding utility functions. In order to implement
these functions for JSC, this state must be propagated to all
of the utility functions.
* tests/IDBBindingUtilitiesTest.cpp:
(WebKit::checkKeyFromValueAndKeyPathInternal):
(WebKit::injectKey):
2012-11-16 Tommy Widenflycht <tommyw@google.com>
MediaStream API: Update RTCPeerConnection states to match the latest editors draft
https://bugs.webkit.org/show_bug.cgi?id=102382
Reviewed by Adam Barth.
Updating readyState & iceState, and adding iceGatheringState.
* src/AssertMatchingEnums.cpp:
2012-11-16 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r134973.
http://trac.webkit.org/changeset/134973
https://bugs.webkit.org/show_bug.cgi?id=99340
Broke compile on at least Mac and Linux.
* WebKit.gyp:
* src/FrameNetworkingContextImpl.h:
* src/PlatformSupport.cpp:
(WebCore::getCookieJar):
(WebCore):
(WebCore::PlatformSupport::setCookies):
(WebCore::PlatformSupport::cookies):
(WebCore::PlatformSupport::cookieRequestHeaderFieldValue):
(WebCore::PlatformSupport::rawCookies):
(WebCore::PlatformSupport::deleteCookie):
(WebCore::PlatformSupport::cookiesEnabled):
2012-11-16 Mark Pilgrim <pilgrim@chromium.org>
[Chromium] Remove cookie-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=99340
Reviewed by Adam Barth.
Move cookie-related functions out of PlatformSupport and implement
new PlatformCookieJar interface via NetworkContext.
* WebKit.gyp:
* src/FrameNetworkingContextImpl.cpp: Added.
(WebKit):
(WebKit::FrameNetworkingContextImpl::cookieJar):
* src/FrameNetworkingContextImpl.h:
(FrameNetworkingContextImpl):
* src/PlatformSupport.cpp:
2012-11-16 Scott Violet <sky@chromium.org>
[chromium] Copy linux theme related files to default
https://bugs.webkit.org/show_bug.cgi?id=102403
Reviewed by Tony Chang
Transitional patch that copies linux WebThemeEngine to default directory.
No new tests, refactoring only.
* features.gypi:
* public/platform/default: Added.
* public/platform/default/WebThemeEngine.h: Copied from Source/WebKit/chromium/public/platform/linux/WebThemeEngine.h.
* src/PlatformSupport.cpp: Includes correct theme files when DEFAULT_RENDER_THEME is set.
(WebCore):
* src/WebViewImpl.cpp: Includes correct theme files when DEFAULT_RENDER_THEME is set.
(WebKit::WebViewImpl::setScrollbarColors): Calls to default theme as necessary.
(WebKit::WebViewImpl::setSelectionColors): Calls to default theme as necessary.
2012-11-16 Robert Flack <flackr@chromium.org>
Handle gesture events on scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=101516
Reviewed by Antonio Gomes.
Adds a gesture event handler to scrollbars and sends gestures beginning
over a scrollbar to this handler to allow touch scrolling scrollbars.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
2012-11-16 Peter Beverloo <peter@chromium.org>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-15 Kentaro Hara <haraken@chromium.org>
Unreviewed, rolling out r134880.
http://trac.webkit.org/changeset/134880
https://bugs.webkit.org/show_bug.cgi?id=102339
it broke Chromium Windows build
* WebKit.gyp:
* WebKit.gypi:
* public/WebNode.h:
(WebKit):
* public/WebPluginContainer.h:
(WebKit):
(WebPluginContainer):
* src/WebFrameImpl.cpp:
(WebKit::pluginContainerFromNode):
(WebKit):
(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):
* src/WebNode.cpp:
* src/WebPluginContainerImpl.cpp:
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* tests/FakeWebPlugin.cpp: Removed.
* tests/FakeWebPlugin.h: Removed.
* tests/WebPluginContainerTest.cpp: Removed.
* tests/data/plugin_container.html: Removed.
2012-11-15 Istiaque Ahmed <lazyboy@chromium.org>
Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.
https://bugs.webkit.org/show_bug.cgi?id=102339
Reviewed by Adam Barth.
This change will allow converting a page's window coordinates to plugins's local coordinates,
taking CSS transformations into account. Embedder page of the plugin can use this information
for targetting elements inside the plugin (e.g. devtools can inspect a specific element at the
local coordinate position inside plugin).
* WebKit.gyp:
* WebKit.gypi:
* public/WebNode.h:
(WebKit):
* public/WebPluginContainer.h:
(WebKit):
(WebPluginContainer):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):
* src/WebNode.cpp:
(WebKit::WebNode::pluginContainer):
(WebKit):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::windowToLocalPoint):
(WebKit):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* tests/FakeWebPlugin.cpp: Added.
(WebKit):
(WebKit::FakeWebPlugin::FakeWebPlugin):
(WebKit::FakeWebPlugin::~FakeWebPlugin):
(WebKit::FakeWebPlugin::initialize):
(WebKit::FakeWebPlugin::destroy):
* tests/FakeWebPlugin.h: Added.
(WebKit):
(FakeWebPlugin):
* tests/WebPluginContainerTest.cpp: Added.
(WebKit):
(WebPluginContainerTest):
(WebKit::WebPluginContainerTest::WebPluginContainerTest):
(WebKit::WebPluginContainerTest::TearDown):
(WebKit::getWebPluginContainer):
(WebKit::TEST_F):
* tests/data/plugin_container.html: Added.
2012-11-15 Tien-Ren Chen <trchen@chromium.org>
Add Settings to disable custom scrollbars on main frame
https://bugs.webkit.org/show_bug.cgi?id=102323
Reviewed by Adam Barth.
Custom scrollbars on main frame don't really work well on touch devices.
Add a setting to inhibit their creation.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAllowCustomScrollbarInMainFrame):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
2012-11-15 Yue Zhang <zysxqn@google.com>
Ignore autocomplete=off for chrome generated passwords.
https://bugs.webkit.org/show_bug.cgi?id=102426
Reviewed by Adam Barth.
Record the autocomplete attribute in the web password form data,
so that we can handle autocomplete in chromium code. The
motivation/background is: we should ignore autocomplete=off field
for password forms with chrome generated passwords (has passed
security review). By handling autocomplete in chromium code we can
distinguish password forms with chrome generated passwords and
those normal password forms. Note that we haven't turned off
checking autocomplete=off in the Webkit code for now so there is
no behavior change after this CL, and we will turn off after we
make the chromium side change to be safe.
* public/WebPasswordFormData.h:
(WebPasswordFormData):
* src/WebPasswordFormData.cpp:
2012-11-15 Scott Violet <sky@chromium.org>
[chromium] Create default directory so that cq can apply patch
https://bugs.webkit.org/show_bug.cgi?id=102421
Reviewed by Tony Chang.
Done in hopes of patch that copies files to this directory working.
* public/platform/default: Added.
2012-11-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r134800 and r134805.
http://trac.webkit.org/changeset/134800
http://trac.webkit.org/changeset/134805
https://bugs.webkit.org/show_bug.cgi?id=102417
This patch broke chromium port (Requested by jianli on
#webkit).
* src/AssertMatchingEnums.cpp:
2012-11-15 Sadrul Habib Chowdhury <sadrul@chromium.org>
[chromium] Do not mark an event (mouse wheel, scroll update) as handled if nothing was scrolled.
https://bugs.webkit.org/show_bug.cgi?id=102246
Reviewed by James Robinson.
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
* tests/WebCompositorInputHandlerImplTest.cpp:
(MockWebInputHandlerClient):
(WebKit::TEST_F):
2012-11-15 Tommy Widenflycht <tommyw@google.com>
MediaStream API: Update RTCPeerConnection states to match the latest editors draft
https://bugs.webkit.org/show_bug.cgi?id=102382
Reviewed by Adam Barth.
Updating readyState & iceState, and adding iceGatheringState.
* src/AssertMatchingEnums.cpp:
2012-11-15 Tien-Ren Chen <trchen@chromium.org>
Use correct unscaled document size when calculating scale limits
https://bugs.webkit.org/show_bug.cgi?id=102028
Reviewed by Adam Barth.
Fixes bug http://crbug.com/160581
Using contentsSize / pageScaleFactor as unscaled contents size results
in rounding errors. This can cause scale factor to oscillate indefinitely.
* src/WebViewImpl.cpp:
(WebKit::unscaledContentsSize):
(WebKit):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
* tests/WebFrameTest.cpp:
* tests/data/scale_oscillate.html: Added.
2012-11-15 Kenneth Russell <kbr@google.com>
[chromium] Move allowWebGL query to WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=102319
Reviewed by Adam Barth.
Moved allowWebGL query to WebFrameClient to avoid polluting
content/ API.
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::allowWebGL):
* public/WebPermissionClient.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowWebGL):
2012-11-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-15 Stephen Chenney <schenney@chromium.org>
[Chromium] Move SK_DISABLE_FAST_AA_STROKE_RECT to skia_webkit.gyp
Unreviewed non-funtional, behavior-neutral change
* skia_webkit.gyp: Add SK_DISABLE_FAST_AA_STROKE_RECT=1 so that it can be removed from Chromium's skia.gyp
2012-11-15 Stephen Chenney <schenney@chromium.org>
[Chromium] Disable SK_IGNORE_FAST_BLURRECT
Unreviewed test update.
This flag is enabled purely to simplify rebaselining. I am now
removing it and doing the rebaslining.
* skia_webkit.gyp: Remove the line for SK_IGNORE_FAST_BLURRECT
2012-11-15 Kent Tamura <tkent@chromium.org>
Support stand-alone month names in calendar picker
https://bugs.webkit.org/show_bug.cgi?id=102196
Reviewed by Kentaro Hara.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
We don't need to pass monthLabels any more.
2012-11-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-14 Joshua Bell <jsbell@chromium.org>
IndexedDB: Remove magic numbers in record comparator, handle missing case
https://bugs.webkit.org/show_bug.cgi?id=102255
Reviewed by Tony Chang.
Add test keys for various metadata types.
* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):
2012-11-14 Eric Uhrhane <ericu@chromium.org>
[chromium] Don't let shift-click turn popup into tab.
https://bugs.webkit.org/show_bug.cgi?id=102254
Reviewed by Adam Barth.
Change http://trac.webkit.org/changeset/132399 broke shift-click on
compose in GMail. We didn't want to change behavior that people were
depending on, and this quick fix seems a good compromise between user
intent and developer intent.
* src/ChromeClientImpl.cpp:
(WebKit::updatePolicyForEvent):
2012-11-14 Mike Reed <reed@google.com>
Dynamically create canvas in Setup() to avoid calling DEPRECATED function setDevice().
https://bugs.webkit.org/show_bug.cgi?id=102242
Reviewed by Stephen White.
This change should not change any test results, it is an equivalent implementation that avoids
using a (now) DEPRECATED function.
* tests/DeferredImageDecoderTest.cpp:
(WebCore::createRasterCanvas):
(WebCore):
(WebCore::DeferredImageDecoderTest::SetUp):
(DeferredImageDecoderTest):
(WebCore::TEST_F):
2012-11-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r134523.
http://trac.webkit.org/changeset/134523
https://bugs.webkit.org/show_bug.cgi?id=102218
brake chrome windows build, as it references a non existing
header js/DOMRequestState.h (Requested by jochen__ on
#webkit).
* src/WebIDBKey.cpp:
2012-11-14 Kent Tamura <tkent@chromium.org>
Support for localization tests of calendar picker
https://bugs.webkit.org/show_bug.cgi?id=102181
Reviewed by Kentaro Hara.
* src/DateTimeChooserImpl.cpp:
Use DateTimeChooserParameters::locale.
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::writeDocument):
2012-11-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r134566.
http://trac.webkit.org/changeset/134566
https://bugs.webkit.org/show_bug.cgi?id=102197
"it broke Chromium Android Release build" (Requested by
haraken on #webkit).
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::writeDocument):
2012-11-14 Kent Tamura <tkent@chromium.org>
Support for localization tests of calendar picker
https://bugs.webkit.org/show_bug.cgi?id=102181
Reviewed by Kentaro Hara.
* src/DateTimeChooserImpl.cpp:
Use DateTimeChooserParameters::locale.
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::writeDocument):
2012-11-14 Yury Semikhatsky <yurys@chromium.org>
Remove MemoryInstrumentationTest.ImageObserver
https://bugs.webkit.org/show_bug.cgi?id=102185
Reviewed by Pavel Feldman.
Removed obsolete memory instrumenation unit test.
* WebKit.gypi:
* tests/MemoryInstrumentationTest.cpp: Removed.
2012-11-14 Kent Tamura <tkent@chromium.org>
[Chromium] Add API to expose WebCore::DateTimeChooser
https://bugs.webkit.org/show_bug.cgi?id=101196
Reviewed by Hajime Morita.
Add ability to open date/time choosers to WebViewClient.
- ExternalDateTimeChooser forwards DateTimeChooser requests from WebCore
to WebViewClient, and waits for WebDateTimeChooerCompletion notifications.
- WebDateTimeChooserParams contains various information to create
chooser UI.
- WebDateTimeChooserCompletion informs value selection by users to
ExternalDateTimeChooser.
The design is very similar to existing WebFileChooserParams and
WebFileChooserCompletion.
These interfaces are used only if ENABLE_INPUT_MULTIPLE_FIELDS_UI is not
enabled, that is to say, in Chromium-Android port. Non-Android Chromium
ports use DateTimeChooserImpl and WebKit-internal choosers.
* WebKit.gyp: Add WebDateTimeChooserCompletion.h,
WebDateTimeChooserParams.h, ExternalDateTimeChooser.cpp, and
ExternalDateTimeChooser.h.
* public/WebDateTimeChooserCompletion.h: Added.
(WebDateTimeChooserCompletion):
(WebKit::WebDateTimeChooserCompletion::~WebDateTimeChooserCompletion):
* public/WebDateTimeChooserParams.h: Added.
(WebDateTimeChooserParams):
(WebKit::WebDateTimeChooserParams::WebDateTimeChooserParams):
* public/WebViewClient.h:
(WebKit): Add some forward declarations.
(WebKit::WebViewClient::openDateTimeChooser): Added.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::openDateTimeChooser):
Creates ExternalDateTimeChooser if !ENABLE(INPUT_MULTIPLE_FIELDS_UI).
* src/ExternalDateTimeChooser.cpp: Added.
(WebDateTimeChooserCompletionImpl): An implementation of
WebDateTimeChooserCompletion. When didChooseValue or didCancelChooser is
called, it notifies to an ExternalDateTimeChooser and kill itself.
(WebKit::ExternalDateTimeChooser::~ExternalDateTimeChooser): Added.
(WebKit::ExternalDateTimeChooser::ExternalDateTimeChooser): Added.
(WebKit::ExternalDateTimeChooser::create):
Cretes an object, then asks the WebViewClient to open date/time chooser.
If an open request fails, an empty PassRefPtr<> is returned.
We don't ask to open in the constructor because open requests might fail
and it's hard for the constructor to tell the failure.
(WebKit::ExternalDateTimeChooser::openDateTimeChooser): Prepares a
WebDateTimeChooserParams and a WebDateTimeChooserCompletion, calls
WebViewClient::openDateTimeChooser, and kill the
WebDateTimeChooserCompletion if openDateTimeChooser fails.
(WebKit::ExternalDateTimeChooser::didChooseValue):
Called by WebDateTimeChooserCompletion.
We need to check m_client because the requester is already dead.
(WebKit::ExternalDateTimeChooser::didCancelChooser): Ditto.
(WebKit::ExternalDateTimeChooser::endChooser):
Called by the requester when it wants to close the chooser.
We don't close the chooser here, and just disconnect the association of
the client and this object.
* src/ExternalDateTimeChooser.h: Added.
2012-11-13 Vincent Scheib <scheib@chromium.org>
Remove RuntimeEnabledFeatures::isPointerLockEnabled.
https://bugs.webkit.org/show_bug.cgi?id=102107
Reviewed by Adam Barth.
The runtime flag is always true now that the feature is enabled by default in Chromium.
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit):
(WebKit::WebRuntimeFeatures::enablePointerLock):
2012-11-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-13 Dana Jansens <danakj@chromium.org>
[chromium] Pass showDebugBorders directly to WebLayerTreeSettings, don't use the GraphicsLayer border width setting.
https://bugs.webkit.org/show_bug.cgi?id=102130
Reviewed by James Robinson.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
2012-11-13 Keishi Hattori <keishi@webkit.org>
Enable datalist UI for input types week and month
https://bugs.webkit.org/show_bug.cgi?id=102041
Reviewed by Kent Tamura.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): If the type supports calendar picker show the "Other..." option.
2012-11-13 Eberhard Graether <egraether@google.com>
checkbox to toggle FPS counter in the inspector's settings
https://bugs.webkit.org/show_bug.cgi?id=99660
Reviewed by Pavel Feldman.
Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true.
* public/WebView.h:
(WebView):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit):
(WebKit::InspectorClientImpl::setShowFPSCounter):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::loadFontAtlasIfNecessary):
* src/WebViewImpl.h:
(WebViewImpl):
2012-11-13 Dana Jansens <danakj@chromium.org>
[chromium] Plumb WebCompositorSupport settings through WebLayerTreeSettings as well, in preparation for removing the settings from WebCompositorSupport
https://bugs.webkit.org/show_bug.cgi?id=102146
Reviewed by James Robinson.
Add accelerated animation and per-tile painting to the WebSettings structure.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedAnimationEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
(WebKit::WebSettingsImpl::perTilePaintingEnabled):
(WebKit::WebSettingsImpl::acceleratedAnimationEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
2012-11-13 Kenneth Russell <kbr@google.com>
Notify embedder of lost contexts and allow overriding of WebGL support
https://bugs.webkit.org/show_bug.cgi?id=101826
Reviewed by Adam Barth.
Expose new FrameLoaderClient hooks through Chromium's
WebPermissionClient and WebFrameClient. Downstream browser tests
will exercise this new functionality.
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didLoseWebGLContext):
* public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowWebGL):
* src/FrameLoaderClientImpl.cpp:
(WebKit):
(WebKit::FrameLoaderClientImpl::allowWebGL):
(WebKit::FrameLoaderClientImpl::didLoseWebGLContext):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
2012-11-13 Chris Fleizach <cfleizach@apple.com>
AX: MathML types need to be semantically identified in AX tree
https://bugs.webkit.org/show_bug.cgi?id=101263
Reviewed by Beth Dakin.
* public/WebAccessibilityRole.h:
* src/AssertMatchingEnums.cpp:
Add new accessibility role.
2012-11-13 Silvia Pfeiffer <silviapf@chromium.org>
Clean up the inheritance tree under the MediaControls Class.
https://bugs.webkit.org/show_bug.cgi?id=88871
Reviewed by Eric Carlson.
This patch removes code duplication between the Chromium and Safari
media controls shadow DOMs.
The derived classes are renamed based on their platform:
- MediaControlRootElement to MediaControlsApple.
- MediaControlRootElementChromium to MediaControlsChromium.
- MediaControlRootElementChromiumAndroid to MediaControlsChromiumAndroid.
* public/WebContextMenuData.h:
Move MediaControlRootElement to MediaControls.
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
Move MediaControlRootElement to MediaControls.
2012-11-13 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r134446.
http://trac.webkit.org/changeset/134446
https://bugs.webkit.org/show_bug.cgi?id=101968
Need to try a different strategy for landing a two-sided patch
(3/3).
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
2012-11-13 Dan Carney <dcarney@google.com>
[V8] More efficient wrapper dispatch
https://bugs.webkit.org/show_bug.cgi?id=102082
Reviewed by Adam Barth.
* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::toV8Value):
* src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):
2012-11-12 Dana Jansens <danakj@chromium.org>
[chromium] Remove the WebCompositorSupport methods for changing settings, plumb everything through WebLayerTreeSettings
https://bugs.webkit.org/show_bug.cgi?id=101968
Reviewed by James Robinson.
This adds perTilePainting and acceleratedAniamtions to the WebSettings
classes, so that DRT can turn these on via WebLayerTreeSettings.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedAnimationEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
(WebKit::WebSettingsImpl::perTilePaintingEnabled):
(WebKit::WebSettingsImpl::acceleratedAnimationEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
2012-11-13 Alec Flett <alecflett@chromium.org>
IndexedDB: remove legacy string-based backend methods
https://bugs.webkit.org/show_bug.cgi?id=102004
Reviewed by Adam Barth.
This is the final stage in a refactor, preceded by
https://bugs.webkit.org/show_bug.cgi?id=100426
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::createIndex):
(WebKit::WebIDBObjectStore::index):
* public/WebIDBTransaction.h:
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBTransactionBackendProxy.cpp:
* src/IDBTransactionBackendProxy.h:
(IDBTransactionBackendProxy):
2012-11-13 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r134391.
http://trac.webkit.org/changeset/134391
https://bugs.webkit.org/show_bug.cgi?id=99660
Speculative rollout, trying to fix browser_tests failure.
* public/WebView.h:
(WebView):
* src/InspectorClientImpl.cpp:
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
2012-11-13 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed: temporary disable failing test.
* tests/MemoryInstrumentationTest.cpp:
2012-11-13 Eberhard Graether <egraether@google.com>
checkbox to toggle FPS counter in the inspector's settings
https://bugs.webkit.org/show_bug.cgi?id=99660
Reviewed by Pavel Feldman.
Added a checkbox to the inspector's settings to toggle a FPS counter. The checkbox appears when InspectorClient::canShowFPSCounter() returns true.
* public/WebView.h:
(WebView):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit):
(WebKit::InspectorClientImpl::setShowFPSCounter):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::loadFontAtlasIfNecessary):
* src/WebViewImpl.h:
(WebViewImpl):
2012-11-12 Kent Tamura <tkent@chromium.org>
Unable to set valid time value to input[type=time] with user interaction in some cases
https://bugs.webkit.org/show_bug.cgi?id=102048
Reviewed by Kentaro Hara.
* tests/DecimalTest.cpp:
(TEST_F): Update and add tests.
2.1 % 3 should be 2.1
10 % -3 should be 1
-10 % -3 should be -1
3.6 % 1.3 should be 1
500 % 1000 should be 500
-500 % 1000 should be -500
2012-11-12 Min Qin <qinmin@chromium.org>
Fix windowRect calculation for webplugin due to page scale factors
https://bugs.webkit.org/show_bug.cgi?id=100182
Reviewed by Adam Barth.
The current calculaton of windowRect in WebPluginContainerImpl is wrong. Even after some of our latest changes.
The problem is caused by page scale factor.
For example, windowToContents(IntPoint) will return an unscaled offset for an iframe, but will return a scaled offset for the main frame. So in order to obtain the correct window coordinate, we need to use contentsToWindow().
Since webview_plugin.cc is expecting window coordinates, we need to use contentsToWindow(IntRect) to calculate the windowRect so that the rect size can get correctly scaled.
It is difficult to write a test for this because it's pixel-based, and plugin placeholder is managed on the Chromium side (webview_plugin.cc).
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::paint):
2012-11-12 Adam Barth <abarth@webkit.org>
Unreviewed. Roll Chromium DEPS.
2012-11-12 Stephen Chenney <schenney@chromium.org>
[chromium] Supressing a Skia change to prevent layout test breakage.
Unreviewed expectations management.
* skia_webkit.gyp: Added supression 'SK_IGNORE_FAST_BLURRECT=1'
2012-11-12 Alexandre Elias <aelias@chromium.org>
[chromium] Delete WebCompositor.h
https://bugs.webkit.org/show_bug.cgi?id=101137
Reviewed by James Robinson.
The implementation of this class is getting deleted and all
WebKit-side users are already going via WebCompositorSupport instead.
* tests/WebCompositorInputHandlerImplTest.cpp:
2012-11-12 Dirk Pranke <dpranke@chromium.org>
Fix Chromium DEPS version after accidentally checking in HEAD a couple days ago.
Unreviewed, build fix.
* DEPS:
2012-11-12 Keishi Hattori <keishi@webkit.org>
Add support for week/month to Locale::formatDateTime()
https://bugs.webkit.org/show_bug.cgi?id=101878
Reviewed by Kent Tamura.
* tests/LocaleMacTest.cpp:
(LocaleMacTest::formatWeek): Takes ISO string and returns localized string.
(LocaleMacTest):
(LocaleMacTest::formatMonth): Ditto.
(TEST_F):
2012-11-11 Sadrul Habib Chowdhury <sadrul@chromium.org>
[chromium] Expose CustomEvent through WebDOMCustomEvent.
https://bugs.webkit.org/show_bug.cgi?id=101293
Reviewed by Adam Barth.
* WebKit.gyp:
* public/WebDOMCustomEvent.h: Added.
(WebKit):
(WebDOMCustomEvent):
(WebKit::WebDOMCustomEvent::WebDOMCustomEvent):
* src/WebDOMCustomEvent.cpp: Added.
(WebKit):
(WebKit::WebDOMCustomEvent::initCustomEvent):
2012-11-09 Rick Byers <rbyers@chromium.org>
Move chromium to USE(LAZY_NATIVE_CURSOR)
https://bugs.webkit.org/show_bug.cgi?id=101501
Reviewed by Adam Barth.
Update conversion from Cursor to WebCursorInfo to remove the
intermediate (and useless) step of PlatformCursor.
* src/AssertMatchingEnums.cpp:
* src/WebCursorInfo.cpp:
(WebKit::WebCursorInfo::WebCursorInfo):
2012-11-09 Alec Flett <alecflett@chromium.org>
IndexedDB: Combine IDBBackingStore and IDBLevelDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=101415
Reviewed by Tony Chang.
Remove method that is no longer in the base class.
* tests/IDBFakeBackingStore.h:
2012-11-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r134101.
http://trac.webkit.org/changeset/134101
https://bugs.webkit.org/show_bug.cgi?id=101790
IDBDatabaseBackendTest.BackingStoreRetention failing
(Requested by jsbell|gardener on #webkit).
* tests/IDBFakeBackingStore.h:
2012-11-09 Alec Flett <alecflett@chromium.org>
IndexedDB: Combine IDBBackingStore and IDBLevelDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=101415
Reviewed by Tony Chang.
Remove method that is no longer in the base class.
* tests/IDBFakeBackingStore.h:
2012-11-09 Alec Flett <alecflett@chromium.org>
IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426
Reviewed by Tony Chang.
Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425
* src/IDBObjectStoreBackendProxy.cpp:
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
2012-11-09 Tommy Widenflycht <tommyw@google.com>
MediaStream API: Deleting all files relating to the deprecated PeerConnection00
https://bugs.webkit.org/show_bug.cgi?id=101730
Reviewed by Adam Barth.
Since RTCPeerConenction has superseeded PeerConnection00 this patch removes all
files relating to the old API.
* WebKit.gyp:
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* public/platform/WebICECandidateDescriptor.h: Removed.
* public/platform/WebICEOptions.h: Removed.
* public/platform/WebMediaHints.h: Removed.
* public/platform/WebPeerConnection00Handler.h: Removed.
* public/platform/WebPeerConnection00HandlerClient.h: Removed.
* public/platform/WebPeerConnectionHandler.h: Removed.
* public/platform/WebPeerConnectionHandlerClient.h: Removed.
* public/platform/WebSessionDescriptionDescriptor.h: Removed.
* src/AssertMatchingEnums.cpp:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::isPeerConnectionEnabled):
* src/WebSessionDescriptionDescriptor.cpp: Removed.
2012-11-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r134010.
http://trac.webkit.org/changeset/134010
https://bugs.webkit.org/show_bug.cgi?id=101716
Broke the chromium windows build. (Requested by noel_ on
#webkit).
* src/IDBCallbacksProxy.cpp:
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::transaction):
(WebKit):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::deleteObjectStore):
(WebKit):
(WebKit::WebIDBDatabaseImpl::transaction):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::deleteIndex):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
* src/WebIDBTransactionImpl.cpp:
(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):
* src/WebIDBTransactionImpl.h:
* tests/IDBRequestTest.cpp:
2012-11-08 Alec Flett <alecflett@chromium.org>
IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426
Reviewed by Tony Chang.
Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425
* src/IDBObjectStoreBackendProxy.cpp:
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
2012-11-08 Keishi Hattori <keishi@webkit.org>
WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
https://bugs.webkit.org/show_bug.cgi?id=93800
Reviewed by Kent Tamura.
We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::close): Set m_closing to true.
2012-11-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r133984.
http://trac.webkit.org/changeset/133984
https://bugs.webkit.org/show_bug.cgi?id=101684
windows build error. (Requested by hayato on #webkit).
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::deleteObjectStore):
(WebKit):
(WebKit::WebIDBDatabaseImpl::transaction):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::deleteIndex):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
* src/WebIDBTransactionImpl.cpp:
(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):
* src/WebIDBTransactionImpl.h:
2012-11-08 Alec Flett <alecflett@chromium.org>
IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426
Reviewed by Tony Chang.
Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425
* src/IDBObjectStoreBackendProxy.cpp:
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
2012-11-07 Kent Tamura <tkent@chromium.org>
[Chromium] WebElement::hasHTMLTagName returns true for non-HTML elements
https://bugs.webkit.org/show_bug.cgi?id=101537
Reviewed by Abhishek Arya.
We should not do ignore-case comparison for tagName, which is always
upper-case and createElementNS(xhtmlNS, "INPUT") doesn't create an
HTMLInputElement object. We need to check if localName is equal to
"input" in this case.
* src/WebElement.cpp:
(WebKit::WebElement::hasHTMLTagName):
2012-11-08 Joshua Bell <jsbell@chromium.org>
Expose snapshots in platform/leveldb wrapper API
https://bugs.webkit.org/show_bug.cgi?id=100786
Reviewed by Tony Chang.
Add unit tests for transactions/snapshots.
* tests/LevelDBTest.cpp:
(WebCore::encodeString): Don't append to pre-sized vector.
(WebCore::TEST):
(WebCore):
2012-11-08 Adam Barth <abarth@webkit.org>
Unreviewed.
Roll Chromium DEPS: 166678 => 166755
* DEPS:
2012-11-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-08 Sami Kyostila <skyostil@chromium.org>
Introduce WebScreenInfo.deviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=101613
Reviewed by Adam Barth.
Introduce the WebScreenInfo.deviceScaleFactor property, which specifies the
ratio between physical and logical pixels. This is the first step in replacing
horizontalDPI/verticalDPI in favor of the deviceScaleFactor.
For now, this value is only initialized on Mac, because the other ports that
use it initialize the value in Chromium, whereas Windows and X11 default to a
factor of 1. The value on Mac is truncated to an integer to match the
expectation in Chromium's RenderWidget.
* src/mac/WebScreenInfoFactory.mm:
(WebKit::WebScreenInfoFactory::screenInfo):
2012-11-08 Dan Carney <dcarney@google.com>
Cleanup IDBBindingUtilitiesTest
https://bugs.webkit.org/show_bug.cgi?id=100860
Reviewed by Adam Barth.
Small cleanup of IDBBindingUtilitiesTest as per
https://bugs.webkit.org/show_bug.cgi?id=99975#c38
* tests/IDBBindingUtilitiesTest.cpp:
(IDBKeyFromValueAndKeyPathTest):
(WebKit::IDBKeyFromValueAndKeyPathTest::IDBKeyFromValueAndKeyPathTest):
(WebKit::IDBKeyFromValueAndKeyPathTest::context):
(WebKit):
(WebKit::TEST_F):
2012-11-08 Keishi Hattori <keishi@webkit.org>
Add properties for week/month picker in DateTimeChooserImpl::writeDocument
https://bugs.webkit.org/show_bug.cgi?id=101552
Reviewed by Kent Tamura.
Changing the arguments for calendar picker to support week/month picker.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
2012-11-08 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r133429.
http://trac.webkit.org/changeset/133429
https://bugs.webkit.org/show_bug.cgi?id=101173
Speculative roll out, investigating perf regression.
* src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
2012-11-08 Yury Semikhatsky <yurys@chromium.org>
Web Inspector: move front-end methods called from native part to InspectorFrontendAPI
https://bugs.webkit.org/show_bug.cgi?id=101463
Reviewed by Vsevolod Vlasov.
Moved Web Inspector methods called from native code to InspectorFrontendAPI. Updated
WebDevToolsFrontendImpl appropriately.
* src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
2012-11-08 Alec Flett <alecflett@chromium.org>
IndexedDB: Rename methods and remove dead code from IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=101488
Reviewed by Ojan Vafai.
Update IDBFakeBackingStore to reflect method changes in IDBBackingStore.
* tests/IDBFakeBackingStore.h:
2012-08-20 Taiju Tsuiki <tzik@chromium.org>
Web Inspector: Drop dimmed crumb handling
https://bugs.webkit.org/show_bug.cgi?id=94457
Reviewed by Vsevolod Vlasov.
* src/js/devTools.css:
2012-11-07 Adam Barth <abarth@webkit.org>
[V8] We should hide the DOMWrapperMaps inside DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101430
Reviewed by Kentaro Hara.
Remove unneeded header includes.
* src/WebScriptController.cpp:
2012-11-07 Varun Jain <varunjain@chromium.org>
Add new gesture type, LongTap, which is basically the completion of a GestureLongPress
https://bugs.webkit.org/show_bug.cgi?id=101385
Reviewed by Adam Barth.
Test: Only creating the new enum. No functionality change, hence no tests required.
* public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
* src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::handleInputEvent):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
2012-11-05 Emil A Eklund <eae@chromium.org>
Remove LayoutTypes abstraction
https://bugs.webkit.org/show_bug.cgi?id=93050
Reviewed by Levi Weintraub.
Remove LayoutTypes abstraction and rename FractionalLayout* to
Layout* now that all platforms use the FractionalLayout version
(albeit with different fractions).
No new tests, no change in functionality.
* src/LinkHighlight.cpp:
2012-11-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-07 Kenneth Rohde Christiansen <kenneth@webkit.org>
Remove support for "desktop-width" in the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=101217
Reviewed by Gyuyoung Kim.
Remove some code trying to use the set desktop width (say 980) for
sites not using a viewport meta element.
Removing this code should have no effect as it ends up being set
to desktop width in that case anyway, by the ViewportArguments
algorithm.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
2012-11-06 Dan Beam <dbeam@chromium.org>
Enable REQUEST_AUTOCOMPLETE for chromium port
https://bugs.webkit.org/show_bug.cgi?id=101376
Reviewed by Adam Barth.
This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.
* features.gypi:
Turned on the *compile* time flag for REQUEST_AUTOCOMPLETE in chromium's webkit port but also added a *run* time flag
that functionally enables the behavior. This means the chromium port will compile in support but will require a run
time flag to enable.
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
Added a method to the public chromium run time features interface to allow chrome to enable/disable this feature.
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableRequestAutocomplete):
(WebKit):
A setter than can be called from chrome code to change the enable/disable requestAutocomplete and associated events at
runtime.
(WebKit::WebRuntimeFeatures::isRequestAutocompleteEnabled):
A getter that returns whether the requestAutocomplete run time feature is enabled.
2012-11-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r133526.
http://trac.webkit.org/changeset/133526
https://bugs.webkit.org/show_bug.cgi?id=101388
May have caused 15% memory regression in Chromium (Requested
by jsbell|gardener on #webkit).
* src/WebScriptController.cpp:
2012-11-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-06 Peter Beverloo <peter@chromium.org>
[Chromium] Enable the JavaScript i18n API for Android
https://bugs.webkit.org/show_bug.cgi?id=101357
Reviewed by Adam Barth.
Enable the JavaScript i18n API for Chromium on Android. This adds a
grand total of 18.7 KiB of data to the content shell apk.
* features.gypi:
2012-11-06 Stephen White <senorblanco@chromium.org>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-05 Adam Barth <abarth@webkit.org>
[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110
Reviewed by Kentaro Hara.
* src/WebScriptController.cpp:
- Remove unneeded include of deleted file.
2012-11-05 Simon Fraser <simon.fraser@apple.com>
Fix layer borders to cleaning appear and disappear on switching
https://bugs.webkit.org/show_bug.cgi?id=101136
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
* src/NonCompositedContentHost.cpp:
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* src/PageOverlay.cpp:
* tests/GraphicsLayerChromiumTest.cpp:
* tests/ImageLayerChromiumTest.cpp:
2012-11-05 Bo Liu <boliu@chromium.org>
Expose hit test related methods in public chromium port
https://bugs.webkit.org/show_bug.cgi?id=101204
Reviewed by Adam Barth.
The methods are needed in implementating hit test related methods in the
Android WebView API.
The specific methods are:
[Web]HitTestResult::urlElement
[Web]HitTestResult::absoluteImageURL
[Web]HitTestResult::absoluteLinkURL
[Web]HitTestResult::isContentEditable
WebViewImpl::hitTestResultAt
* public/WebHitTestResult.h:
(WebKit):
(WebHitTestResult):
* public/WebView.h:
(WebKit):
(WebView):
* src/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::urlElement):
(WebKit):
(WebKit::WebHitTestResult::absoluteImageURL):
(WebKit::WebHitTestResult::absoluteLinkURL):
(WebKit::WebHitTestResult::isContentEditable):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hitTestResultAt):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
2012-11-05 Alok Priyadarshi <alokp@chromium.org>
[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
https://bugs.webkit.org/show_bug.cgi?id=99083
Reviewed by Stephen White.
Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers.
* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::paintContents):
* src/LinkHighlight.h:
(LinkHighlight):
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore::TEST_F):
2012-11-05 Alok Priyadarshi <alokp@chromium.org>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-05 Miguel Garcia <miguelg@chromium.org>
[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=101199
Reviewed by Julien Chaffraix.
Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection
until we can implement it properly.
* features.gypi:
2012-11-04 MORITA Hajime <morrita@google.com>
Shadow DOM should be able to be disabled per context.
https://bugs.webkit.org/show_bug.cgi?id=101173
Reviewed by Dimitri Glazkov.
* src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
2012-11-03 Dan Beam <dbeam@chromium.org>
Implement HTMLFormElement#requestAutocomplete and associated events
https://bugs.webkit.org/show_bug.cgi?id=100557
Reviewed by Adam Barth.
Implements an initial version of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html
The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing for
autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient. At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.
Currently this is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled.
Test: fast/forms/form-request-autocomplete.html
* public/WebAutofillClient.h:
(WebKit):
(WebAutofillClient):
(WebKit::WebAutofillClient::didRequestAutocomplete):
Added WebAutofillClient::didRequestAutocomplete to chrome's public WebKit interface.
* public/WebFormElement.h:
Added an enum that matches HTMLFormElement::AutocompleteResult (and added compile time assert) and a public method
(WebFormElement::finishRequestAutocomplete) to WebFormElement's public interface.
* src/AssertMatchingEnums.cpp:
Added a compile time assert to guarantee the HTMLFormElement::AutocompleteResult enum matches the
WebFormElement::AutocompleteResult enum.
* src/FrameLoaderClientImpl.cpp:
(WebKit):
(WebKit::FrameLoaderClientImpl::didRequestAutocomplete):
Implemented the added FrameLoaderClient::didRequestAutocomplete, which simply passes through to the
WebAutofillClient.
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
Implementing FrameLoaderClient::didRequestAutocomplete.
* src/WebFormElement.cpp:
(WebKit::WebFormElement::finishRequestAutocomplete):
(WebKit):
Added WebFormElement::finishRequestAutocomplete to allow chromium's renderer a public API to call to finish the
autocomplete request on a WebFormElement.
2012-11-02 Anders Carlsson <andersca@apple.com>
Add a PluginInactive plug-in unavailability reason
https://bugs.webkit.org/show_bug.cgi?id=101089
Reviewed by Sam Weinig.
* src/LocalizedStrings.cpp:
(WebCore::inactivePluginText):
(WebCore):
2012-11-02 Ian Vollick <vollick@chromium.org>
Support invalidation tracking for composited layers
https://bugs.webkit.org/show_bug.cgi?id=97801
Reviewed by Simon Fraser.
GraphicsLayers now store invalidated rects and can include them in
the layer tree dump.
(WebKit::WebWidget::isTrackingRepaints):
Used by the NonCompositedContentHost to determine if we are tracking
repaint rects.
(WebKit::WebWidget::isTrackingRepaints):
* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::updateGeometry):
Now calls GraphicsLayer::addRepaintRect when invalidated.
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::isTrackingRepaints):
Required as this is a GraphicsLayerClient.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::isTrackingRepaints):
Implementation of WebWidget::isTrackingRepaints.
2012-11-02 Stephen White <senorblanco@chromium.org>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-02 Kent Tamura <tkent@chromium.org>
Optimize DateTimeFormat::quoteAndAppendLiteral output
https://bugs.webkit.org/show_bug.cgi?id=101040
Reviewed by Kentaro Hara.
* tests/LocaleWinTest.cpp:
(TEST_F): Update test results.
2012-11-01 Kent Tamura <tkent@chromium.org>
Introduce ENABLE_DATE_AND_TIME_INPUT_TYPES, and clarify usage of other related flags
https://bugs.webkit.org/show_bug.cgi?id=101007
Reviewed by Kentaro Hara.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::openDateTimeChooser):
Follow the ChromeClient::openDateTimeChooser flag change.
Also, add an empty implemenatation for Android.
* src/ChromeClientImpl.h:
Follow the ChromeClient::openDateTimeChooser flag change.
* src/DateTimeChooserImpl.cpp: Wrapped with
ENABLE(INPUT_MULTIPLE_FIELDS_UI). This class is not used in Android.
* src/DateTimeChooserImpl.h: Ditto.
* src/LocalizedStrings.cpp: Follow the LocalizedString.h change.
2012-11-01 Alec Flett <alecflett@chromium.org>
IndexedDB: add methods to support id-based backend APIs
https://bugs.webkit.org/show_bug.cgi?id=100425
Reviewed by Tony Chang.
Chromium Proxy and WebIDB* support for new int64_t-based methods.
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::deleteObjectStore):
(WebKit::WebIDBDatabase::transaction):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::put):
(WebKit::WebIDBObjectStore::setIndexKeys):
(WebKit::WebIDBObjectStore::setIndexesReady):
(WebKit::WebIDBObjectStore::index):
(WebKit::WebIDBObjectStore::deleteIndex):
* public/WebIDBTransaction.h:
(WebKit::WebIDBTransaction::objectStore):
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::deleteObjectStore):
(WebKit):
(WebKit::IDBDatabaseBackendProxy::transaction):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::put):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/IDBTransactionBackendProxy.cpp:
(WebKit::IDBTransactionBackendProxy::objectStore):
* src/IDBTransactionBackendProxy.h:
(IDBTransactionBackendProxy):
* src/WebIDBMetadata.cpp:
(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):
* src/WebIDBTransactionImpl.cpp:
(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):
* src/WebIDBTransactionImpl.h:
* tests/IDBDatabaseBackendTest.cpp:
2012-11-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-01 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: expose Inspector.detached event factory to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=100967
Reviewed by Vsevolod Vlasov.
That way embedder will be able to send messages on behalf of the backend being destructed.
* public/WebDevToolsAgent.h:
(WebDevToolsAgent):
* src/WebDevToolsAgentImpl.cpp:
(SerializingFrontendChannel):
(WebKit::SerializingFrontendChannel::sendMessageToFrontend):
(WebKit::WebDevToolsAgent::inspectorDetachedEvent):
(WebKit):
(WebKit::WebDevToolsAgent::workerDisconnectedFromWorkerEvent):
(WebKit::WebDevToolsAgent::disconnectEventAsText):
2012-11-01 Vsevolod Vlasov <vsevik@chromium.org>
[Chromium] debug builds: Use after free under ~PageOverlay()
https://bugs.webkit.org/show_bug.cgi?id=100930
Reviewed by Pavel Feldman.
Changed members order in PageOverlay so that GraphicsLayer is destroyed before GraphicsLayerClient.
* src/PageOverlay.h:
(PageOverlay):
2012-11-01 James Robinson <jamesr@chromium.org>
[chromium] Avoid attempting to defer commits when they are already deferred
https://bugs.webkit.org/show_bug.cgi?id=100913
Reviewed by Adrienne Walker.
In threaded compositing mode, it's possible to load and unload FrameViews without any
intervening invalidations. In this case, we enter setIsAcceleratedCompositingActive
with commits already deferred. There's no need to defer again and doing so trips
an assertion in the implementation.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
2012-11-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-11-01 Yury Semikhatsky <yurys@chromium.org>
Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase
https://bugs.webkit.org/show_bug.cgi?id=100497
Reviewed by Alexander Pavlov.
Updated MemoryInstrumentationTest.ImageObserver so that it doesn't fail
when instrumentation of objects referenced by CachedImage changes.
* tests/MemoryInstrumentationTest.cpp:
2012-11-01 Kent Tamura <tkent@chromium.org>
Remove unused Locale::parseDateTime
https://bugs.webkit.org/show_bug.cgi?id=100910
Reviewed by Kentaro Hara.
* tests/LocaleMacTest.cpp: Remove tests for parseDateTime.
* tests/LocaleWinTest.cpp: Ditto.
2012-10-31 Keishi Hattori <keishi@webkit.org>
[Chromium] Page popup shows up at wrong locations when root view is scrolled
https://bugs.webkit.org/show_bug.cgi?id=100830
Reviewed by Kent Tamura.
We need to account for the scroll position when calculating the root view rectangle in the screen.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
2012-10-31 Stephen White <senorblanco@chromium.org>
Unreviewed, rolling out r133122.
http://trac.webkit.org/changeset/133122
https://bugs.webkit.org/show_bug.cgi?id=99083
Broke Chromium Win, Android, ChromeOS builds
* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::paintContents):
* src/LinkHighlight.h:
(LinkHighlight):
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore::TEST_F):
2012-10-31 Alok Priyadarshi <alokp@chromium.org>
[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
https://bugs.webkit.org/show_bug.cgi?id=99083
Reviewed by James Robinson.
Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers.
* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::paintContents):
* src/LinkHighlight.h:
(LinkHighlight):
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore::TEST_F):
2012-10-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-31 Stephen White <senorblanco@chromium.org>
Unreviewed, rolling out r133107.
http://trac.webkit.org/changeset/133107
https://bugs.webkit.org/show_bug.cgi?id=100425
Broke compile on Chromium Win
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::index):
* public/WebIDBTransaction.h:
(WebKit::WebIDBTransaction::objectStore):
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/IDBTransactionBackendProxy.cpp:
* src/IDBTransactionBackendProxy.h:
(IDBTransactionBackendProxy):
* src/WebIDBCallbacksImpl.cpp:
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBMetadata.cpp:
(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
* src/WebIDBTransactionImpl.cpp:
* src/WebIDBTransactionImpl.h:
* tests/IDBDatabaseBackendTest.cpp:
2012-10-31 Alec Flett <alecflett@chromium.org>
IndexedDB: add methods to support id-based backend APIs
https://bugs.webkit.org/show_bug.cgi?id=100425
Reviewed by Tony Chang.
Chromium Proxy and WebIDB* support for new int64_t-based methods.
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::deleteObjectStore):
(WebKit::WebIDBDatabase::transaction):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::put):
(WebKit::WebIDBObjectStore::setIndexKeys):
(WebKit::WebIDBObjectStore::setIndexesReady):
(WebKit::WebIDBObjectStore::index):
(WebKit::WebIDBObjectStore::deleteIndex):
* public/WebIDBTransaction.h:
(WebKit::WebIDBTransaction::objectStore):
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::deleteObjectStore):
(WebKit):
(WebKit::IDBDatabaseBackendProxy::transaction):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::put):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/IDBTransactionBackendProxy.cpp:
(WebKit::IDBTransactionBackendProxy::objectStore):
* src/IDBTransactionBackendProxy.h:
(IDBTransactionBackendProxy):
* src/WebIDBMetadata.cpp:
(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):
* src/WebIDBTransactionImpl.cpp:
(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):
* src/WebIDBTransactionImpl.h:
* tests/IDBDatabaseBackendTest.cpp:
2012-10-31 Tien-Ren Chen <trchen@chromium.org>
Apply transformation for highlights on non-composited contents
https://bugs.webkit.org/show_bug.cgi?id=100438
Reviewed by Adam Barth.
Non-composited content host layer "steals" the contents on the
RenderView layer, including the highlight layer.
The transformation for regular contents are applied by the paint
function of the non-composited content host however the highlight
uses its own WebLayer. Need to apply the same transformation to
the highlight layer as well.
* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::computeEnclosingCompositingLayer):
* src/LinkHighlight.h:
(LinkHighlight):
2012-10-31 Mike West <mkwst@chromium.org>
Prefer document->addConsoleMessage to document->domWindow->console->addMessage.
https://bugs.webkit.org/show_bug.cgi?id=100850
Reviewed by Adam Barth.
For historical reasons, a few places in WebCore talk to Console directly
via 'document()->domWindow()->console()->addMessage(...)'. This is more
safely wrapped by calling 'addConsoleMessage' on the Document itself.
No visible functionality should change; we'll simply avoid potential
null dereferences in the future.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addMessageToConsole):
2012-10-31 Kent Tamura <tkent@chromium.org>
Remove code to hide/reshow text caret for PagePopups
https://bugs.webkit.org/show_bug.cgi?id=100834
Reviewed by Hajime Morita.
All of form controls supporting PagePopups don't have a text
caret. We don't need to hide a text caret on opening a PagePopup,
and don't need to reshow it on closing the PagePopup.
We had this code because an old UI of input[type=date] had a text
caret.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::openPagePopup):
(WebKit::WebViewImpl::closePagePopup):
2012-10-31 Mike West <mkwst@chromium.org>
Script run from an isolated world should bypass a page's CSP.
https://bugs.webkit.org/show_bug.cgi?id=97398
Reviewed by Adam Barth.
* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
(WebKit):
(WebKit::WebFrameImpl::setIsolatedWorldContentSecurityPolicy):
* src/WebFrameImpl.h:
(WebFrameImpl):
Piping a Content Security Policy through WebFrame, in the same way
we're currently doing for SecurityOrigin. As a drive-by, this also
uses the static method on DOMWrapperWindow to set the security
origin, rather than routing through the frame's ScriptController.
2012-10-30 W. James MacLean <wjmaclean@chromium.org>
[chromium] Transform mouse/gesture event coordinates to account for pinch-zoom in compositor.
https://bugs.webkit.org/show_bug.cgi?id=100542
Reviewed by James Robinson.
Pinch-zoom in the compositor applies a transformation that WebCore does not know about.
We need to adjust mouse and gesture event coordinates to account for this in order that
hit testing work properly for these types while zoomed.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent): Modified to adjoint event coordinates to account for zoom.
2012-10-30 W. James MacLean <wjmaclean@chromium.org>
[chromium] Restrict link highlights to targets that display a hand-cursor
https://bugs.webkit.org/show_bug.cgi?id=99862
Reviewed by James Robinson.
To avoid applying highlights to inappropriate targets, such as large divs with
click handlers installed, test candidate targets and only highlight them if they
would normally display a hand cursor on mouse over. This is a heuristic, but has
been tested and found effective in practice.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::invokesHandCursor):
(WebKit::WebViewImpl::bestTouchLinkNode):
(WebKit::WebViewImpl::enableTouchHighlight):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/LinkHighlightTest.cpp:
(WebCore::TEST):
* tests/data/test_touch_link_highlight.html:
2012-10-30 Alok Priyadarshi <alokp@chromium.org>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-30 Dan Carney <dcarney@google.com>
Remove ensureAuxiliaryContext
https://bugs.webkit.org/show_bug.cgi?id=99975
Reviewed by Adam Barth.
Updated tests to use correct v8 context.
* tests/IDBBindingUtilitiesTest.cpp:
(WebKit::checkKeyFromValueAndKeyPathInternal):
(WebKit::checkKeyPathNullValue):
(WebKit::injectKey):
(WebKit::checkInjection):
(WebKit::checkInjectionFails):
(WebKit::checkKeyPathStringValue):
(WebKit::checkKeyPathNumberValue):
(WebKit::scriptExecutionContext):
(WebKit):
(WebKit::TEST):
2012-10-30 Kent Tamura <tkent@chromium.org>
Remove unused code for old input[type=date] UI
https://bugs.webkit.org/show_bug.cgi?id=100734
Reviewed by Hajime Morita.
* src/LocalizedStrings.cpp:
Follow the LocalizedStrings.h change.
* tests/LocaleMacTest.cpp:
(LocaleMacTest): Remove tests for Locale::dateFormatText.
* tests/LocaleWinTest.cpp:
(LocaleWinTest): Ditto.
2012-10-30 Kent Tamura <tkent@chromium.org>
Fix crash by calendar picker or suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=100728
Reviewed by Hajime Morita.
* src/DateTimeChooserImpl.h:
(DateTimeChooserImpl): Add a factory function, and made the constructor private.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::create): Added.
(WebKit::DateTimeChooserImpl::setValueAndClosePopup):
Protect this because JavaScript code might run during didChooseValue.
* src/ChromeClientImpl.h:
(ChromeClientImpl): Follow the ChromeClient change.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::openDateTimeChooser):
Use DateTimeChooserImpl::create.
2012-10-29 James Robinson <jamesr@chromium.org>
[chromium] Null-check WebViewImpl::m_client before calling invalidateRect() on it
https://bugs.webkit.org/show_bug.cgi?id=100716
Reviewed by Dirk Pranke.
This check was accidentally removed in r132862 and the value is null in at least some unit tests.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::invalidateRect):
2012-10-29 Vincent Scheib <scheib@chromium.org>
Unreviewed, rolling out r132845.
http://trac.webkit.org/changeset/132845
https://bugs.webkit.org/show_bug.cgi?id=99975
Broke chromium builds, linker errors from
IDBBindingUtilitiesTest
* tests/IDBBindingUtilitiesTest.cpp:
(WebCore::TEST):
2012-10-29 James Robinson <jamesr@chromium.org>
[chromium] Defer commits between page unload and first invalidation in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=100702
Reviewed by Adrienne Walker.
In threaded compositing mode, it's not terribly useful to commit after unloading a page and before receiving
the first invalidation for the new page since the document is likely not loaded enough to paint usefully.
This defers commits from the time compositing is deactivated (which in force compositing mode only happens
at FrameView destruction) until we get the first invalidation from WebCore.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::invalidateContentsAndRootView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::invalidateRect):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
2012-10-29 Stephen White <senorblanco@chromium.org>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-29 Dan Carney <dcarney@google.com>
Remove ensureAuxiliaryContext
https://bugs.webkit.org/show_bug.cgi?id=99975
Reviewed by Adam Barth.
Updated tests to use correct v8 context.
* tests/IDBBindingUtilitiesTest.cpp:
(WebKit::checkKeyFromValueAndKeyPathInternal):
(WebKit::checkKeyPathNullValue):
(WebKit::injectKey):
(WebKit::checkInjection):
(WebKit::checkInjectionFails):
(WebKit::checkKeyPathStringValue):
(WebKit::checkKeyPathNumberValue):
(WebKit::scriptExecutionContext):
(WebKit):
(WebKit::TEST):
2012-10-29 Patrick Dubroy <dubroy@chromium.org>
Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.
https://bugs.webkit.org/show_bug.cgi?id=100683
Reviewed by Pavel Feldman.
When in compact mode, style the Web Inspector toolbar using the same colors & gradients
as the Chromium toolbar (Chromium port only).
* src/js/devTools.css:
(body.compact.platform-mac #toolbar):
(body.compact.platform-mac.inactive #toolbar):
(body.platform-mac.inactive #toolbar .toolbar-label):
2012-10-29 Eugene Klyuchnikov <eustas.bug@gmail.com>
Web Inspector: Timeline: make cpu-monitoring feature available only on capable browsers
https://bugs.webkit.org/show_bug.cgi?id=100530
Reviewed by Yury Semikhatsky.
Motivation: cpu-monitoring feature looks like a glitch,
when it is not supported by browser.
* src/InspectorClientImpl.cpp: Implemented capability getter.
* src/InspectorClientImpl.h:
2012-10-29 Kent Tamura <tkent@chromium.org>
[Chromium] Merge LocalizedNumberICUTest into LocaleICUTest
https://bugs.webkit.org/show_bug.cgi?id=100648
Reviewed by Kentaro Hara.
LocalizedNumberICU was removed some months ago, and its features were
merged to LocaleICU. We merge the test too.
* WebKit.gypi: Remove LocalizedNumberICUTest.cpp
* tests/LocaleICUTest.cpp:
Move a #if because some headers are used unconditionally.
(testDecimalSeparator): Moved from LocalizedNumberICUTest.cpp.
(TEST_F): Ditto.
(testNumberIsReversible): Ditto.
(testNumbers): Ditto.
* tests/LocalizedNumberICUTest.cpp: Removed.
2012-10-29 Kent Tamura <tkent@chromium.org>
[Chromium] Rename LocalizedDateICUTest.cpp to LocaleICUTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=100643
Reviewed by Kentaro Hara.
LocalizedDateICU was removed some months ago, and LocalizedDateICUTest
actually had tests for LocaleICU.
* WebKit.gypi:
* tests/LocaleICUTest.cpp:
- Renamed from Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp.
- Rename LocalizedDateICUTest class to LocaleICUTest.
2012-10-29 Kent Tamura <tkent@chromium.org>
[Chromium-linux] Fix build.
* tests/LocalizedNumberICUTest.cpp:
(testNumberIsReversible): Rename an argument.
(testDecimalSeparator): Ditto.
2012-10-28 Kent Tamura <tkent@chromium.org>
Rename Localizer to Locale
https://bugs.webkit.org/show_bug.cgi?id=100634
Reviewed by Kentaro Hara.
* src/ColorChooserUIController.h:
(ColorChooserUIController):
Rename m_localizer to m_locale, and follow other renamings.
* src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::ColorChooserUIController): Follow renamings.
(WebKit::ColorChooserUIController::locale): Ditto.
* src/DateTimeChooserImpl.h:
(DateTimeChooserImpl):
Rename m_localizer to m_locale, and follow other renamings.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl): Follow renamings.
(WebKit::DateTimeChooserImpl::writeDocument): Ditto.
(WebKit::DateTimeChooserImpl::locale): Ditto.
* tests/LocaleMacTest.cpp:
(LocaleMacTest::formatTime): Ditto.
(testNumberIsReversible): Ditto.
* tests/LocalizedNumberICUTest.cpp:
(testNumberIsReversible): Ditto.
(testDecimalSeparator): Ditto.
2012-10-29 Kent Tamura <tkent@chromium.org>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-28 Kent Tamura <tkent@chromium.org>
Rename Localizer.{cpp,h} to PlatformLocale.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=100627
Reviewed by Yuta Kitamura.
* src/ColorChooserUIController.h: Follow the file name renaming.
* src/DateTimeChooserImpl.cpp: Ditto.
2012-10-27 Adam Barth <abarth@webkit.org>
[Chromium] Find-in-page reports matches in hidden iframes
https://bugs.webkit.org/show_bug.cgi?id=100604
Reviewed by Eric Seidel.
This is actually a regression caused by
http://trac.webkit.org/changeset/128784. This patch adds back some code
removed in WebFrameImpl::shouldScopeMatches in r128784.
This patch also introduces a test so that we don't make this mistake
again.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::shouldScopeMatches):
* tests/WebFrameTest.cpp:
* tests/data/find_in_hidden_frame.html: Added.
2012-10-26 Kent Tamura <tkent@chromium.org>
[Chromium] Convert Chromium template string to an LDML date format
https://bugs.webkit.org/show_bug.cgi?id=100128
Reviewed by Tony Chang.
* src/LocalizedStrings.cpp:
(WebCore): Include WebCore/platform/text/DateTimeFormat.h.
(WebCore::weekFormatInLDML):
Replace $1 with yyyy, $2 with ww, and quote other parts.
2012-10-26 James Robinson <jamesr@chromium.org>
[chromium] Allow embedder to enter/leave force compositing mode
https://bugs.webkit.org/show_bug.cgi?id=100458
Reviewed by Adrienne Walker.
This adds API for the embedder to decide when to enter and leave force compositing mode since it's
more efficient to only toggle this setting when the embedder is about to produce a frame.
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::enterForceCompositingMode):
* src/WebFrameImpl.cpp:
(WebKit::WebViewImpl::enterForceCompositingMode):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
2012-10-26 Dominic Mazzoni <dmazzoni@google.com>
AX: Notification should be sent when accessibilityIsIgnored changes
https://bugs.webkit.org/show_bug.cgi?id=99547
Reviewed by Chris Fleizach.
Adds new accessibility notifications.
* public/WebAccessibilityNotification.h:
* src/AssertMatchingEnums.cpp:
2012-10-26 Thiago Marcos P. Santos <thiago.santos@intel.com>
Add feature flags for CSS Device Adaptation
https://bugs.webkit.org/show_bug.cgi?id=95960
Reviewed by Kenneth Rohde Christiansen.
* features.gypi:
2012-10-26 Kent Tamura <tkent@chromium.org>
Disable ENABLE_INPUT_TYPE_WEEK on Chromium/Android
https://bugs.webkit.org/show_bug.cgi?id=100457
Reviewed by Kentaro Hara.
It was enabled accidentally. Week input is not implemented in
Android.
* features.gypi: Remove ENABLE_INPUT_TYPE_WEEK=1 in the common block,
add ENABLE_INPUT_TYPE_WEEK=0 in Android block, and add
ENABLE_INPUT_TYPE_WEEK=1 in non-Android block.
2012-10-26 Kent Tamura <tkent@chromium.org>
[Chromium-Win] Support shortTimeFormat
https://bugs.webkit.org/show_bug.cgi?id=100471
Reviewed by Kentaro Hara.
* tests/LocaleWinTest.cpp:
(TEST_F): Update test expectations for the behavior change.
2012-10-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r132514.
http://trac.webkit.org/changeset/132514
https://bugs.webkit.org/show_bug.cgi?id=100440
"Broke chromium content_browsertests AccessibilityAriaMenu
AccessibilityInputRange AccessibilityListMarkers" (Requested
by scheib on #webkit).
* public/WebAccessibilityNotification.h:
* src/AssertMatchingEnums.cpp:
2012-10-25 James Robinson <jamesr@chromium.org>
[chromium] Regression: navigating between composited pages doesn't cause redraw until scrolled
https://bugs.webkit.org/show_bug.cgi?id=100396
Reviewed by Adrienne Walker.
This partially reverts r132173. It's not valid to suppress invalidations in commitDocumentData since for small
or cached pages this could load up the whole document. Also adds and improves some of the tracing.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::commitDocumentData):
(WebKit::WebFrameImpl::createFrameView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scheduleComposite):
2012-10-25 Sami Kyostila <skyostil@chromium.org>
Composited/HW content have the red and blue channels inverted in DRT on Chromium Android
https://bugs.webkit.org/show_bug.cgi?id=98647
Reviewed by James Robinson.
WebLayerTreeView::compositeAndReadback() always gives back data in BGRA
ordering (i.e., the first byte in memory is blue). This matches Skia's
SkBitmap::kARGB_8888_Config ordering on all platforms except Android,
where Skia's native format is RGBA (i.e., red comes first in memory).
This mismatch causes layout test pixel comparison failures. This patch
fixes the problem by reordering the channels right after readback.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
2012-10-25 Dominic Mazzoni <dmazzoni@google.com>
AX: Notification should be sent when accessibilityIsIgnored changes
https://bugs.webkit.org/show_bug.cgi?id=99547
Reviewed by Chris Fleizach.
Adds new accessibility notifications.
* public/WebAccessibilityNotification.h:
* src/AssertMatchingEnums.cpp:
2012-10-25 Dominik Röttsches <dominik.rottsches@intel.com>
Conditionalize XHR timeout support
https://bugs.webkit.org/show_bug.cgi?id=100356
Reviewed by Adam Barth.
Adding XHR_TIMEOUT feature to conditionalize this on ports without network backend support.
Defaults to off on chromium until webkit.org/b/98397 is solved.
* features.gypi:
2012-10-25 Ben Wagner <bungeman@chromium.org>
Remove SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX define from skia_webkit.gyp, as it has been rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=100394
Reviewed by Dirk Pranke.
The define has been removed from the Skia code and the Chromium skia.gyp.
The pixel tests affected have already been rebaselined.
* skia_webkit.gyp:
2012-10-22 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Add supportMultipleWindows setting, needed for Android
https://bugs.webkit.org/show_bug.cgi?id=99716
Reviewed by Adam Barth.
Add supportMultipleWindows settings for reusing the same view when
opening popups. This is required for emulating the behavior of
Android WebView. Adding into WebCore, as other ports might want to
use this setting in the future.
* public/WebSettings.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchCreatePage):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setSupportsMultipleWindows):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
2012-10-24 Mihai Parparita <mihaip@chromium.org>
[Chromium] Allow pushState and related history APIs to be disabled per context
https://bugs.webkit.org/show_bug.cgi?id=99780
Reviewed by Adam Barth.
Add pushState context feature.
* public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowPushState):
* src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
2012-10-24 Mark Pilgrim <pilgrim@chromium.org>
[Chromium] Remove screen-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97474
Reviewed by Adam Barth.
Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.
* public/WebScreenInfo.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::screenInfo):
(WebKit):
* src/ChromeClientImpl.h:
(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):
* src/PlatformSupport.cpp:
(WebCore):
* src/WebPagePopupImpl.cpp:
2012-10-24 Sailesh Agrawal <sail@chromium.org>
Incorrect keycodes for numpad /, -, +, .
https://bugs.webkit.org/show_bug.cgi?id=99188
Reviewed by Tony Chang.
In r57951 we switched to mapping keys by character code.
This regressed the numpad keys which no longer match the Windows virtual key codes.
This CL fixes this by never mapping numpad keys by character code.
* src/mac/WebInputEventFactory.mm: Disallow mapping numpad keys by character code.
(WebKit::windowsKeyCodeForKeyEvent):
* tests/WebInputEventFactoryTestMac.mm: Test to verify that all numpad keys are correctly mapped.
(TEST):
2012-10-24 Terry Anderson <tdanderson@chromium.org>
Handle two-finger tap gestures in the same way as long-press gestures
https://bugs.webkit.org/show_bug.cgi?id=99947
Reviewed by Adam Barth.
Set the area of a two-finger tap gesture to be the area of the enclosing
rectangle for the first finger down.
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2012-10-24 Eric Uhrhane <ericu@chromium.org>
https://bugs.webkit.org/show_bug.cgi?id=99202
[Chromium] shift-click fails to spawn new window with target=_blank
Reviewed by Adam Barth
No new tests in WebKit-land--see
https://codereview.chromium.org/11235048/ for tests that I'll submit
once this lands.
* src/ChromeClientImpl.cpp:
Change currentEventShouldCauseBackgroundTab to updatePolicyForEvent; we
were looking up the right policy, then throwing it away if it wasn't
forcing a background tab.
(WebKit::ChromeClientImpl::updatePolicyForEvent):
(WebKit::ChromeClientImpl::getNavigationPolicy):
2012-10-24 Ben Wagner <bungeman@chromium.org>
Create skia_webkit.gyp to improve rebaselining.
https://bugs.webkit.org/show_bug.cgi?id=99759
Reviewed by Dirk Pranke.
This allows for code suppressions to be lifted atomically with new baselines.
* skia_webkit.gyp: Added.
2012-09-27 Yury Semikhatsky <yurys@chromium.org>
Web Inspector: provide memory instrumentation for ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=97786
Reviewed by Vsevolod Vlasov.
Added a test for ListHashSet memory instrumentation.
* tests/MemoryInstrumentationTest.cpp:
(WebCore::TEST):
(WebCore):
2012-10-24 Noel Gordon <noel.gordon@gmail.com>
[chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings
https://bugs.webkit.org/show_bug.cgi?id=100197
Reviewed by Kent Tamura.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setShouldRespectImageOrientation): set the WebCore page
setting for shouldRespectImageOrientation.
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
2012-10-23 Varun Jain <varunjain@chromium.org>
Context menu generated from touch gestures on textareas has
context of the cursor position instead of the position where the event occurs.
https://bugs.webkit.org/show_bug.cgi?id=99520
Reviewed by Kenneth Rohde Christiansen.
Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.
Also in this change, WebInputEvent::GestureTwoFingerTap now follows the same
code path as WebInputEvent::GestureLongPress, hence fixing this bug for both gestures.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
2012-10-23 Alec Flett <alecflett@chromium.org>
IndexedDB: refactor backend to use IDB*Metadata
https://bugs.webkit.org/show_bug.cgi?id=100055
Reviewed by Tony Chang.
Update tests to reflect refactoring.
* tests/IDBDatabaseBackendTest.cpp:
* tests/IDBFakeBackingStore.h:
2012-10-23 Stephen White <senorblanco@chromium.org>
[chromium] Roll chromium DEPS r163297:163557
https://bugs.webkit.org/show_bug.cgi?id=100146
Reviewed by Adrienne Walker.
2012-10-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
Add support for resolution media query
https://bugs.webkit.org/show_bug.cgi?id=99077
Reviewed by Antti Koivisto.
Add support for the RESOLUTION_MEDIA_QUERY feature flag.
* features.gypi:
2012-10-23 Kent Tamura <tkent@chromium.org>
Support full month names in DateTimeEditElement, and use them in input[type=month] by default
https://bugs.webkit.org/show_bug.cgi?id=100060
Reviewed by Kentaro Hara.
* tests/LocaleMacTest.cpp:
(TEST_F): Follow LocaleMac::monthFormat change.
* tests/LocalizedDateICUTest.cpp:
(TEST_F): Follow LocaleICU::monthFormat change.
2012-10-23 Dan Carney <dcarney@google.com>
When blocking localStorage, Firefox throws a security exception on access, and maybe so should we
https://bugs.webkit.org/show_bug.cgi?id=63257
Reviewed by Jochen Eisinger.
Add security check and security check cache.
* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::StorageAreaProxy):
(WebCore::StorageAreaProxy::length):
(WebCore::StorageAreaProxy::key):
(WebCore::StorageAreaProxy::getItem):
(WebCore::StorageAreaProxy::setItem):
(WebCore::StorageAreaProxy::removeItem):
(WebCore::StorageAreaProxy::clear):
(WebCore::StorageAreaProxy::contains):
(WebCore::StorageAreaProxy::canAccessStorage):
* src/StorageAreaProxy.h:
(StorageAreaProxy):
(WebCore::StorageAreaProxy::canAccessStorage):
2012-10-22 James Robinson <jamesr@chromium.org>
[chromium] Suppress compositor invalidations during FrameView recreation in force-compositing-mode
https://bugs.webkit.org/show_bug.cgi?id=99882
Reviewed by Adrienne Walker.
In force compositing mode, page navigation temporarily takes us in and out of compositing mode because the
root GraphicsLayer is owned by the FrameView which is destroyed and recreated. These changes generate
invalidations on the WebViewClient that trigger frames but aren't actually terribly useful. WebCore suppresses
repaints too early during page load to avoid flashing white or mostly white and to avoid impacting page load time.
This suppresses compositor invalidations during FrameView recreation.
Covered by chromium's page cycler performance tests.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::commitDocumentData):
(WebKit::WebFrameImpl::createFrameView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::scheduleComposite):
* src/WebViewImpl.h:
(WebViewImpl):
2012-10-22 Kent Tamura <tkent@chromium.org>
Introduce Localizer::standAloneMonthLabels
https://bugs.webkit.org/show_bug.cgi?id=99963
Reviewed by Kentaro Hara.
Note that we don't add tests to LocaleWinTest because new function
LocaleWin::standAloneMonthLabels is equivalent to monthLabels.
* tests/LocaleMacTest.cpp:
(LocaleMacTest::standAloneMonthLabel): Added a helper function.
(TEST_F): Add some tests. We don't test ru_ru locale because it has
different data on OSX versions.
* tests/LocalizedDateICUTest.cpp:
(LocalizedDateICUTest::standAloneMonthLabel): Added a helper function.
(TEST_F): Add some tests.
2012-10-22 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r132119.
http://trac.webkit.org/changeset/132119
https://bugs.webkit.org/show_bug.cgi?id=100019
Fails its own test on Mac platforms. (Requested by leviw on
#webkit).
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
2012-10-22 Varun Jain <varunjain@chromium.org>
Context menu generated from touch gestures on textareas has
context of the cursor position instead of the position where the event occurs.
https://bugs.webkit.org/show_bug.cgi?id=99520
Reviewed by Kenneth Rohde Christiansen.
Send a synthetic mouse down event for context menu-summoning-gesture events so
that textareas can correctly set cursors before receiving the context menu event.
Also in this change, WebInputEvent::GestureTwoFingerTap now follows the same
code path as WebInputEvent::GestureLongPress, hence fixing this bug for both gestures.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
2012-10-22 Adam Barth <abarth@webkit.org>
[Chromium] Roll Chromium DEPS to get new version of V8
https://bugs.webkit.org/show_bug.cgi?id=100015
Unreviewed.
* DEPS:
- Bigger is better.
2012-10-22 Keishi Hattori <keishi@webkit.org>
Remove monthFormatInLDML
https://bugs.webkit.org/show_bug.cgi?id=99971
Reviewed by Kent Tamura.
* src/LocalizedStrings.cpp:
2012-10-22 Keishi Hattori <keishi@webkit.org>
[Chromium] Rename WeekFormatInLDML to WeekFormatTemplate
https://bugs.webkit.org/show_bug.cgi?id=99972
Reviewed by Kent Tamura.
* src/LocalizedStrings.cpp:
(WebCore::weekFormatInLDML):
2012-10-22 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
[Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
https://bugs.webkit.org/show_bug.cgi?id=98514
Reviewed by Kenneth Rohde Christiansen.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
2012-10-22 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: merge "docked" state into the "dock side" enum.
https://bugs.webkit.org/show_bug.cgi?id=99717
Reviewed by Vsevolod Vlasov.
Otherwise, it is hard to manage these inter-dependent flags.
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::requestSetDockSide):
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
2012-10-21 Kent Tamura <tkent@chromium.org>
Page popup: Fix crash by events after closing
https://bugs.webkit.org/show_bug.cgi?id=99951
Reviewed by Hajime Morita.
- We should not handle events after closePopup call.
- We should uninstall a DOMWindowPagePopup supplement in closePopup.
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
Initialize m_closing.
(WebKit::WebPagePopupImpl::handleGestureEvent):
Don't handle events if m_closing.
(WebKit::WebPagePopupImpl::handleInputEvent): Ditto.
(WebKit::WebPagePopupImpl::handleKeyEvent): Ditto.
(WebKit::WebPagePopupImpl::closePopup):
- Uninstall a DOMWindowPagePopup supplement.
- Set m_closing.
* src/WebPagePopupImpl.h:
(WebPagePopupImpl): Declare m_closing.
2012-10-21 Terry Anderson <tdanderson@chromium.org>
[chromium] Storing the enclosing rect dimensions of the first finger for a two finger tap
https://bugs.webkit.org/show_bug.cgi?id=99763
Reviewed by Adam Barth.
Add a struct |twoFingerTap| inside the union |data| of a WebGestureEvent. The fields |firstFingerWidth|
and |firstFingerHeight| will represent the dimensions of the enclosing rectangle corresponding to the
first touch point in the gesture. These will be used in a future CL to perform target fuzzing on a
two-finger tap gesture.
Note: I chose not to name the two fields |width| and |height| so that they aren't confused with the
width and height of the gesture's bounding box, which contains the enclosing rectangles of both touch
points. My future fuzzing CL will only be concerned with the location and enclosing rectangle of the
first touch point.
* public/WebInputEvent.h:
2012-10-19 Yusuf Ozuysal <yusufo@google.com>
[chromium] Double-tap defaults to zoom (should only do this on Android)
https://bugs.webkit.org/show_bug.cgi?id=99600
Reviewed by Adam Barth.
Adds a web setting for enabling DoubleTapToZoom on a doubleTap gesture.
This gesture was just needed for mobile, and the patch that implemented it caused regressions on other platforms.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setDoubleTapToZoomEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::doubleTapToZoomEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
* tests/WebFrameTest.cpp:
2012-10-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r131944.
http://trac.webkit.org/changeset/131944
https://bugs.webkit.org/show_bug.cgi?id=99891
On second thoughts, not such a great idea (Requested by jamesr
on #webkit).
* public/WebView.h:
(WebKit):
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2012-10-19 Jochen Eisinger <jochen@chromium.org>
[chromium] when building a shared library component build, we must not depend on WebCore
Unreviewed build fix.
* WebKit.gyp:
2012-10-19 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r131936.
http://trac.webkit.org/changeset/131936
https://bugs.webkit.org/show_bug.cgi?id=99717
Broke the clang build
* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::requestDockWindow):
(WebKit::WebDevToolsFrontendClient::requestUndockWindow):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::requestAttachWindow):
(WebKit):
(WebKit::InspectorFrontendClientImpl::requestDetachWindow):
(WebKit::InspectorFrontendClientImpl::requestSetDockSide):
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
2012-10-19 Alexandre Elias <aelias@chromium.org>
[chromium] API to pass impl thread via WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=99863
Reviewed by James Robinson.
This adds an API to pass the compositor impl thread via WebView and
WebLayerTreeView. This is currently a no-op change, but in the future
this codepath will supercede WebCompositor. The goal is to avoid statics
in compositor initialization.
* public/WebView.h:
(WebKit):
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setCompositorImplThread):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2012-10-19 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: merge "docked" state into the "dock side" enum.
https://bugs.webkit.org/show_bug.cgi?id=99717
Reviewed by Vsevolod Vlasov.
* public/WebDevToolsFrontendClient.h:
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::requestSetDockSide):
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
2012-09-08 Alpha Lam <hclam@chromium.org>
[chromium] Implement deferred image decoding
https://bugs.webkit.org/show_bug.cgi?id=94240
Reviewed by Stephen White.
Adding new unit tests for deferred image decoding.
These tests are defined in DeferredImageDecoderTest.cpp. They verify
image decoding happens only when SkPicture is rasterized for both
scaled and non-scaled cases.
Tests: DeferredImageDecoderTest.drawIntoSkPicture
DeferredImageDecoderTest.drawScaledIntoSkPicture
* WebKit.gypi:
* public/WebSettings.h:
* src/WebKit.cpp:
(WebKit::shutdown):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
* tests/DeferredImageDecoderTest.cpp: Added.
(WebCore):
(DeferredImageDecoderTest):
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::TearDown):
(WebCore::TEST_F):
* tests/MockImageDecoder.h: Added.
(WebCore):
(MockImageDecoder):
(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::filenameExtension):
(WebCore::MockImageDecoder::frameBufferAtIndex):
(WebCore::MockImageDecoder::frameBufferRequestCount):
2012-10-19 Alpha Lam <hclam@chromium.org>
[chromium] Roll DEPS
Unreviewed DEPS roll.
* DEPS:
2012-10-19 Dongwoo Joshua Im <dw.im@samsung.com>
Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT
https://bugs.webkit.org/show_bug.cgi?id=99804
Reviewed by Julien Chaffraix.
CSS3 text related properties will be implemented under this flag,
including text decoration, text-align-last, and text-justify.
* features.gypi:
2012-10-19 Jochen Eisinger <jochen@chromium.org>
[chromium] fix the fix
Unreviewed build fix.
Forgot to invert the condition when to set the type to none in the
previous attempt.
* WebKit.gyp:
2012-10-19 Jochen Eisinger <jochen@chromium.org>
[chromium] Fix inside chromium build on Mac
Unreviewed build fix.
Xcode won't create a static library without any sources. So instead of
ommitting the sources, just override the webkit_test_support's type
with 'none'.
* WebKit.gyp:
2012-10-17 Ilya Tikhonovsky <loislo@chromium.org>
Web Inspector: NMI provide data for mixing with tcmalloc heap dumps.
https://bugs.webkit.org/show_bug.cgi?id=99457
Reviewed by Yury Semikhatsky.
Embedder's code wraps the map with counted objects info into InstrumentedObjectSizeProvider
and forces downstream code to make tcmalloc heap snapshot.
The default implementation is empty.
* public/WebDevToolsAgentClient.h:
(InstrumentedObjectSizeProvider):
(WebKit::WebDevToolsAgentClient::InstrumentedObjectSizeProvider::~InstrumentedObjectSizeProvider):
(WebKit::WebDevToolsAgentClient::dumpUncountedAllocatedObjects):
(WebDevToolsAgentClient):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::dumpUncountedAllocatedObjects):
(WebKit):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::getAllocatedObjects):
(WebKit::WebDevToolsAgentImpl::dumpUncountedAllocatedObjects):
(WebKit):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
2012-10-18 Kent Tamura <tkent@chromium.org>
Add shortMonthLabels and shortStandAloneMonthLabels to Localizer
https://bugs.webkit.org/show_bug.cgi?id=99787
* tests/LocaleMacTest.cpp:
(TEST_F): Disable tests depends on OS X versions.
2012-10-18 Kent Tamura <tkent@chromium.org>
Add shortMonthLabels and shortStandAloneMonthLabels to Localizer
https://bugs.webkit.org/show_bug.cgi?id=99787
Reviewed by Kentaro Hara.
* tests/LocaleMacTest.cpp:
(LocaleMacTest::shortMonthLabel): A helper.
(LocaleMacTest::shortStandAloneMonthLabel): Ditto.
(TEST_F): Added tests for some locales.
* tests/LocaleWinTest.cpp:
(LocaleWinTest::shortMonthLabel): A helper.
(TEST_F): Added tests for some locales. We don't test
LocaleWin::shortStandAloneMonthLabels because it is identical to
shortMonthLabels.
* tests/LocalizedDateICUTest.cpp:
(LocalizedDateICUTest::shortMonthLabel): A helper.
(LocalizedDateICUTest::shortStandAloneMonthLabel): Ditto.
(TEST_F): Added tests for some locales.
2012-10-18 Jochen Eisinger <jochen@chromium.org>
[chromium] Add a webkit_test_support target that WebTestingSupport
https://bugs.webkit.org/show_bug.cgi?id=99772
Reviewed by Adam Barth.
Before, embedders would need to compile the WebTestingSupport.cpp
themselves, which in turn depends on WebCore headers.
* WebKit.gyp:
2012-10-18 W. James MacLean <wjmaclean@chromium.org>
[chromium] Re-enable gesture highlight layout tests, fix GestureLongPress regression.
https://bugs.webkit.org/show_bug.cgi?id=99632
Reviewed by James Robinson.
Re-enable layout tests for gesture highlights. Includes fix for GestureTapCancel test.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
2012-10-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r131810.
http://trac.webkit.org/changeset/131810
https://bugs.webkit.org/show_bug.cgi?id=99762
Broke linux debug webkit_unit_tests (Requested by
danakj|gardening on #webkit).
* WebKit.gypi:
* public/WebSettings.h:
* src/WebKit.cpp:
(WebKit::shutdown):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
* tests/DeferredImageDecoderTest.cpp: Removed.
* tests/MockImageDecoder.h: Removed.
2012-10-18 Alpha Lam <hclam@chromium.org>
[chromium] Implement deferred image decoding
https://bugs.webkit.org/show_bug.cgi?id=94240
Reviewed by Stephen White.
Adding new unit tests for deferred image decoding.
These tests are defined in DeferredImageDecoderTest.cpp. They verify
image decoding happens only when SkPicture is rasterized for both
scaled and non-scaled cases.
Tests: DeferredImageDecoderTest.drawIntoSkPicture
DeferredImageDecoderTest.drawScaledIntoSkPicture
* WebKit.gypi:
* public/WebSettings.h:
* src/WebKit.cpp:
(WebKit::shutdown):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferredImageDecodingEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
* tests/DeferredImageDecoderTest.cpp: Added.
(WebCore):
(DeferredImageDecoderTest):
(WebCore::DeferredImageDecoderTest::SetUp):
(WebCore::DeferredImageDecoderTest::TearDown):
(WebCore::TEST_F):
* tests/MockImageDecoder.h: Added.
(WebCore):
(MockImageDecoder):
(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::filenameExtension):
(WebCore::MockImageDecoder::frameBufferAtIndex):
(WebCore::MockImageDecoder::frameBufferRequestCount):
2012-10-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-18 Pablo Flouret <pablof@motorola.com>
Implement css3-conditional's @supports rule
https://bugs.webkit.org/show_bug.cgi?id=86146
Reviewed by Antti Koivisto.
* features.gypi:
Add an ENABLE_CSS3_CONDITIONAL_RULES flag.
2012-10-18 Kent Tamura <tkent@chromium.org>
Add Localizer::monthFormat and implementations
https://bugs.webkit.org/show_bug.cgi?id=99704
* tests/LocaleMacTest.cpp:
(TEST_F): Remove tests for fr_FR and ru locales for a compatibility reason.
2012-10-18 Kent Tamura <tkent@chromium.org>
Add Localizer::monthFormat and implementations
https://bugs.webkit.org/show_bug.cgi?id=99704
Reviewed by Kentaro Hara.
* tests/LocaleMacTest.cpp:
(LocaleMacTest::monthFormat): A helper function.
(TEST_F): Added some tests.
* tests/LocaleWinTest.cpp:
(LocaleWinTest::monthFormat): A helper function.
(TEST_F): Added some tests.
* tests/LocalizedDateICUTest.cpp:
(LocalizedDateICUTest::monthFormat): A helper function.
(TEST_F): Added some tests.
2012-10-17 Mike West <mkwst@chromium.org>
Move mixed content logic out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45638
Reviewed by Eric Seidel.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::checkIfRunInsecureContent):
Use the new method location.
2012-10-17 Shashi Shekhar <shashishekhar@google.com>
Remove redundant sdk_build parameter.
https://bugs.webkit.org/show_bug.cgi?id=99648
Reviewed by Adam Barth.
sdk_build parameter is no longer needed.
* WebKitUnitTests.gyp:
2012-10-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-17 Alec Flett <alecflett@chromium.org>
IndexedDB: Explicitly send null/undefined/integers to frontend IDBCallbacks
https://bugs.webkit.org/show_bug.cgi?id=99619
Reviewed by Adam Barth.
Hook up new undefined/integer-based onSuccess handlers.
* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit):
* src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
* src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
(WebKit):
* src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
* tests/IDBAbortOnCorruptTest.cpp:
* tests/IDBDatabaseBackendTest.cpp:
2012-10-17 Sadrul Habib Chowdhury <sadrul@chromium.org>
plugins: Allow a plugin to dictate whether it can receive drag events or not.
https://bugs.webkit.org/show_bug.cgi?id=99355
Reviewed by Tony Chang.
Introduce WebPlugin::canProcessDrag() and use that to implement PluginViewBase::canProcessDrag.
* public/WebPlugin.h:
(WebKit::WebPlugin::canProcessDrag):
(WebPlugin):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::canProcessDrag):
(WebKit):
(WebKit::WebPluginContainerImpl::handleMouseEvent):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
2012-10-17 Jian Li <jianli@chromium.org>
[chromium] Remove legacy members from WebDraggableRegion
https://bugs.webkit.org/show_bug.cgi?id=99612
Reviewed by Adam Barth.
Those legacy members to support old syntax are not longer needed after
chromium side changes landed.
* public/WebDraggableRegion.h:
(WebDraggableRegion):
2012-10-17 Joshua Bell <jsbell@chromium.org>
[Chromium] IndexedDB: Delete obsolete public API method
https://bugs.webkit.org/show_bug.cgi?id=99603
Reviewed by Dimitri Glazkov.
Remove a stub that was necessary while the Chromium side of webkit.org/b/99097 was landing.
* public/WebIDBTransactionCallbacks.h:
2012-10-17 Keishi Hattori <keishi@webkit.org>
Localized date should be based on LDML
https://bugs.webkit.org/show_bug.cgi?id=99570
Reviewed by Kent Tamura.
* tests/LocaleMacTest.cpp:
(TEST_F): Updated expectations.
* tests/LocaleWinTest.cpp:
(TEST_F): Updated expectations.
2012-10-16 MORITA Hajime <morrita@google.com>
[Shadow DOM][V8] WebCore::V8DOMWindow::installPerContextProperties() is slow when shadowDOMEnabled flag is on.
https://bugs.webkit.org/show_bug.cgi?id=99428
Reviewed by Adam Barth.
* src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
2012-10-16 Alec Flett <alecflett@chromium.org>
IndexedDB: Stub out chromium success handlers for integers and undefined values
https://bugs.webkit.org/show_bug.cgi?id=99527
Reviewed by Adam Barth.
Add onSuccess stubs so that chromium IPC glue can land.
* public/WebIDBCallbacks.h:
(WebKit::WebIDBCallbacks::onSuccess):
2012-10-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-16 Jian Li <jianli@chromium.org>
Rename feature define ENABLE_WIDGET_REGION to ENABLE_DRAGGBALE_REGION
https://bugs.webkit.org/show_bug.cgi?id=98975
Reviewed by Adam Barth.
Renaming is needed to better match with the draggable region code.
* features.gypi:
* src/ChromeClientImpl.cpp:
(WebKit):
* src/ChromeClientImpl.h:
(ChromeClientImpl):
* src/WebDocument.cpp:
(WebKit::WebDocument::draggableRegions):
2012-10-16 Min Qin <qinmin@chromium.org>
Fix a bug that we are using scaled damage rect for plugins inside an iframe
https://bugs.webkit.org/show_bug.cgi?id=99488
Reviewed by Adam Barth.
There is a bug with a previous webkit patch: https://bugs.webkit.org/show_bug.cgi?id=98468
In that patch, we incorrectly applied the main frame's scale factor to inner iframes.
However, the damageRect is not scaled inside an iFrame. So doing the intersect will retrieve wrong result here.
In WebPluginContainerImpl::calculateGeometry, the windowRect also does not apply main frame's scale factor.
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::paint):
2012-10-16 Xianzhu Wang <wangxianzhu@chromium.org>
[Chromium] Android: Need a way to get appropriate font for some specific characters.
https://bugs.webkit.org/show_bug.cgi?id=67587
Reviewed by Adam Barth.
Define ENABLE_OPENTYPE_VERTICAL=1 on Android.
* features.gypi:
2012-10-16 Tommy Widenflycht <tommyw@google.com>
MediaStream API: Add the chromium API for RTCDataChannel
https://bugs.webkit.org/show_bug.cgi?id=99435
Reviewed by Adam Barth.
Adding checks for RTCDataChannel.
* src/AssertMatchingEnums.cpp:
2012-10-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-15 Peter Beverloo <peter@chromium.org>
[Chromium] Enable FAST_MOBILE_SCROLLING for Android
https://bugs.webkit.org/show_bug.cgi?id=99401
Reviewed by Adam Barth.
* features.gypi: Add the define to the Android-only section.
2012-10-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-15 Peter Beverloo <peter@chromium.org>
[Chromium] The default target for Android builds should be "all" instead of "All"
https://bugs.webkit.org/show_bug.cgi?id=98879
Reviewed by Adam Barth.
The default gyp target for Android builds is being overridden in Chromium's
envsetup_functions.sh to "All" (whereas the rest of Chromium and WebKit use "all"),
because Android wants to use a different list of main targets. There is
no need to do this for the WebKit project, and it's breaking ninja.
* gyp_webkit:
2012-10-15 Kent Tamura <tkent@chromium.org>
LocaleMacTest.formatDate is failing on Mac 10.8
https://bugs.webkit.org/show_bug.cgi?id=99330
It seems OS X 10.8 and 10.7 return different date formats for ja_JP
locale. We should not test such locales.
* tests/LocaleMacTest.cpp:
(TEST_F): Remove a test for ja_JP locale.
2012-10-15 Joshua Bell <jsbell@chromium.org>
IndexedDB: Pass type of error causing abort to IDBTransaction::onAbort
https://bugs.webkit.org/show_bug.cgi?id=99097
Reviewed by Tony Chang.
Plumbing to pass details about the cause of the transaction abort through to the
front end.
* public/WebIDBTransactionCallbacks.h:
(WebKit):
(WebKit::WebIDBTransactionCallbacks::onAbort):
* src/IDBTransactionCallbacksProxy.cpp:
(WebKit::IDBTransactionCallbacksProxy::onAbort):
* src/IDBTransactionCallbacksProxy.h:
(IDBTransactionCallbacksProxy):
* src/WebIDBTransactionCallbacksImpl.cpp:
(WebKit::WebIDBTransactionCallbacksImpl::onAbort):
* src/WebIDBTransactionCallbacksImpl.h:
(WebIDBTransactionCallbacksImpl):
2012-10-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-14 Sam Weinig <sam@webkit.org>
Make UserScript and UserStyleSheet value objects that are copyable
https://bugs.webkit.org/show_bug.cgi?id=99275
Reviewed by Tim Horton.
* src/WebViewImpl.cpp:
(WebKit::WebView::addUserScript):
(WebKit::WebView::addUserStyleSheet):
Update for new PageGroup function signatures.
2012-10-12 Adam Barth <abarth@webkit.org>
[Chromium] Remove used frameForEnteredContext API
https://bugs.webkit.org/show_bug.cgi?id=99201
Reviewed by Eric Seidel.
No one in Chromium-land understands the difference between
frameForEnteredContext and frameForCurrentContext. Rather than give
folks a confusing choice, let's just expose the one we most often want
to use.
I've already removed all callers of frameForEnteredContext downstream.
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit):
2012-10-12 Joshua Bell <jsbell@chromium.org>
[Chromium] IndexedDB: WebKit API plumbing to pass abort reason code/message to script
https://bugs.webkit.org/show_bug.cgi?id=99193
Reviewed by Adam Barth.
Add database error (code, message) to payload for back-end to front-end abort call,
so that scripts can determine why the abort occurred - e.g. ConstraintError during
indexing. This API change allows the Chromium plumbing to land; the real implementation
is in http://webkit.org/b/99097 and will land later.
* public/WebIDBTransactionCallbacks.h:
(WebKit):
(WebIDBTransactionCallbacks):
(WebKit::WebIDBTransactionCallbacks::onAbort):
2012-10-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-11 Kenichi Ishibashi <bashi@chromium.org>
[Chromium] Use harfbuzz-ng by default on Linux
https://bugs.webkit.org/show_bug.cgi?id=97281
Reviewed by Tony Chang.
* features.gypi: Enable WTF_USE_HARFBUZZ_NG when use_x11 == 1.
2012-10-11 Nat Duca <nduca@chromium.org>
Expose high-resolution on requestAnimationFrame callback
https://bugs.webkit.org/show_bug.cgi?id=66683
This changes requestAnimationFrame's animationStartTime argument
to be a high resolution DOM timestamp, per disucssion here:
http://lists.w3.org/Archives/Public/public-web-perf/2012Apr/0004.html
Reviewed by James Robinson.
* src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::animate):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateAnimations):
2012-10-11 Jay Civelli <jcivelli@chromium.org>
Test for a fix for a crasher when generating MHTML for a page containing SVG images.
https://bugs.webkit.org/show_bug.cgi?id=99105
Reviewed by Adam Barth.
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::addImageToResources):
2012-10-11 Adam Barth <abarth@webkit.org>
[Chromium] Improve the comment describing mainWorldScriptContext
https://bugs.webkit.org/show_bug.cgi?id=99092
Reviewed by James Robinson.
* public/WebFrame.h:
(WebFrame):
- Add some more text about what this API does so that folks who
call it know what they need to worry about.
2012-10-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-11 Mihai Balan <mibalan@adobe.com>
Always enable the experiments tab for WebKit nightly
Web Inspector: Enabling experiments tab in WebKit nightly.
https://bugs.webkit.org/show_bug.cgi?id=98923
Reviewed by Pavel Feldman.
Enabling Web Inspector experiments tab in WebKit nightly. This is done by adding a new
Preference key, Preferences.experimentsEnabled. Default values are true for WebKit and false
for Chromium. They can also be overridden as before (in Chromium)
* src/js/DevTools.js:
2012-10-11 Kent Tamura <tkent@chromium.org>
Introduce Localizer::isRTL, and use it in DateTimeChooserImpl
https://bugs.webkit.org/show_bug.cgi?id=98992
* tests/LocalizedDateICUTest.cpp:
(TEST_F): Re-enabled isRTL test.
2012-10-11 Kent Tamura <tkent@chromium.org>
[Chromium] Disable LocalizedDateICUTest.isRTL
https://bugs.webkit.org/show_bug.cgi?id=98992
* tests/LocalizedDateICUTest.cpp:
(TEST_F): Disabled.
2012-10-11 Kent Tamura <tkent@chromium.org>
[Chromium] Attempt to fix LocalizedDateICUTest.isRTL
https://bugs.webkit.org/show_bug.cgi?id=98992
* tests/LocalizedDateICUTest.cpp:
(TEST_F):
2012-10-11 Kent Tamura <tkent@chromium.org>
Introduce Localizer::isRTL, and use it in DateTimeChooserImpl
https://bugs.webkit.org/show_bug.cgi?id=98992
Reviewed by Kentaro Hara.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Use Localizer::isRTL.
* tests/LocaleMacTest.cpp:
(LocaleMacTest::isRTL): Added a helper function.
(TEST_F): Added tests.
* tests/LocaleWinTest.cpp:
(LocaleWinTest::isRTL): Added a helper function.
(TEST_F): Added tests.
* tests/LocalizedDateICUTest.cpp:
(LocalizedDateICUTest::isRTL): Added a helper function.
(TEST_F): Added tests.
2012-10-10 Kent Tamura <tkent@chromium.org>
[Chromium] Calendar picker: should use consistent Localizer object
https://bugs.webkit.org/show_bug.cgi?id=98983
Reviewed by Kentaro Hara.
In Source/WebKit/chromium/src/DateTimeChooserImpl.cpp, we used two
Localizer objects, one was m_localizer and another was 'localizer' local
object in writeDocument. We should use single Localizer object.
Also, Localizer::create(nullAtom) had unexpected behaviors in ICU
environment; e.g. Month labels in a calendar picker were numeric. This
patch fixes it, and this is covered by
fast/forms/date/calendar-picker-appearance.html.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
Use m_localizer.
2012-10-10 Justin Novosad <junov@chromium.org>
[Chromium] Smoother animation for non-RAF 2D canvas animations
https://bugs.webkit.org/show_bug.cgi?id=97918
Reviewed by Stephen White.
New unit test to verify the automatic flushing of deferred 2d canvas
layers when scripted animations are more than one full frame ahead
of the compositor. Also verifies that automatic flushing does not
kick-in when the skip on clear optimization fires
* DEPS:
* tests/Canvas2DLayerManagerTest.cpp:
(FakeCanvas2DLayerBridge::fakeSkipPendingDrawCommands):
To fake the skip on clear optimization
(FakeCanvas2DLayerBridge):
(Canvas2DLayerManagerTest):
(Canvas2DLayerManagerTest::doDeferredFrameTestTask):
Method that simulates a javascript scheduled action that draws to
a 2D canvas layer
(DeferredFrameTestTask):
Task object to simulate a scheduled action. This is so the unit
test can cover the TaskObserver behavior of Canvas2DLayerManager.
(Canvas2DLayerManagerTest::DeferredFrameTestTask::DeferredFrameTestTask):
(Canvas2DLayerManagerTest::deferredFrameTest):
The unit test implementation, which uses the WebThread run loop to
post tasks that touch the canvas layer.
2012-10-10 Leandro Gracia Gil <leandrogracia@chromium.org>
[Chromium] Update selection on long press to match normal delimiters.
https://bugs.webkit.org/show_bug.cgi?id=98947
Reviewed by Adam Barth.
Make the long press selection behaviour consistent.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::detectContentOnTouch):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebViewTest.cpp:
2012-10-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-10 Jon Lee <jonlee@apple.com>
[WK2] Activate plugins when user clicks on snapshot
https://bugs.webkit.org/show_bug.cgi?id=98328
<rdar://problem/12426681>
Reviewed by Brady Eidson.
* src/FrameLoaderClientImpl.h:
(WebKit::FrameLoaderClientImpl::recreatePlugin): Stub implementation of recreatePlugin().
2012-10-10 David Barton <dbarton@mathscribe.com>
Turn on ENABLE_MATHML for Chromium
https://bugs.webkit.org/show_bug.cgi?id=96960
Reviewed by Adam Barth.
* features.gypi:
2012-10-10 Varun Jain <varunjain@chromium.org>
[chromium] Spelling and grammar markers are pixelated in hidpi.
https://bugs.webkit.org/show_bug.cgi?id=98339
Reviewed by Stephen White.
We create separate bitmaps for markers in normal and hidpi mode as per
specification from UX and choose the right bitmap based on the current
device scale factor.
* src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::paint):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::paintRootLayer):
2012-10-10 Simon Fraser <simon.fraser@apple.com>
Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=98839
Reviewed by Sam Weinig.
Add a flag to layerTreeAsText() so that tests can optionally include this visible rect in
layer tree dumps. This output will be platform-specific, so we don't want to do it unconditionally.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::layerTreeAsText):
2012-10-08 Kent Tamura <tkent@chromium.org>
[Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName
https://bugs.webkit.org/show_bug.cgi?id=98714
Reviewed by Abhishek Arya.
* public/WebElement.h:
(WebElement):
- Add a comment to tagName().
- Add a comment to hasTagName().
- Declare hasHTMLTagName(), which is useful to check HTML tags.
* src/WebElement.cpp:
(WebKit::WebElement::hasHTMLTagName): Added.
2012-10-09 Jian Li <jianli@chromium.org>
Update the CSS property used to support draggable regions.
https://bugs.webkit.org/show_bug.cgi?id=97156
Reviewed by Adam Barth.
Update the code to use the new name annotatedRegions to work for
both features.
* public/WebDraggableRegion.h: Rename dashboardRegions to annotatedRegions.
(WebDraggableRegion):
* src/ChromeClientImpl.cpp: Rename dashboardRegions to annotatedRegions.
(WebKit::ChromeClientImpl::annotatedRegionsChanged):
* src/ChromeClientImpl.h: Rename dashboardRegions to annotatedRegions.
(ChromeClientImpl):
* src/WebDocument.cpp: Rename dashboardRegions to annotatedRegions.
(WebKit::WebDocument::draggableRegions):
2012-10-09 Sadrul Habib Chowdhury <sadrul@chromium.org>
[chromium] Add drop event for plugins.
https://bugs.webkit.org/show_bug.cgi?id=98827
Reviewed by Adam Barth.
Add conversion for drop events.
* public/WebDragStatus.h:
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleDragEvent):
2012-10-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r130811 and r130821.
http://trac.webkit.org/changeset/130811
http://trac.webkit.org/changeset/130821
https://bugs.webkit.org/show_bug.cgi?id=98831
Broke date-suggestion-picker-appearance-with-scroll-bar.html
(Requested by abarth|gardening on #webkit).
* src/FindInPageCoordinates.cpp:
(WebKit::toNormalizedRect):
* src/LinkHighlight.cpp:
(WebKit::convertTargetSpaceQuadToCompositedLayer):
* src/WebInputEventConversion.cpp:
(WebKit::convertLocationForRenderObject):
2012-10-09 Ben Murdoch <benm@google.com>
[chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources()
https://bugs.webkit.org/show_bug.cgi?id=97689
Reviewed by Adam Barth.
This change exposes the WebCore::SecurityOrigin::grantLoadLocalResources()
function to the Chromium WebKit API layer. This is needed in Chromium
to implement the Android WebView.loadDataWithBaseUrl function in a
compatible manner.
Please see crbug.com/152223 for further information and the chromium
side patch.
* public/WebSecurityOrigin.h:
(WebSecurityOrigin): Add grantLoadLocalResources() API.
* src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::grantLoadLocalResources):
Implement the API by calling through to the WebCore function
of the same name.
(WebKit):
2012-10-09 Julien Chaffraix <jchaffraix@webkit.org>
[Chromium] Chromium DEPS has a stray directory, turning our Win bots red
https://bugs.webkit.org/show_bug.cgi?id=98817
Reviewed by Dirk Pranke.
* DEPS: Removed the stray directory which solved the redness on several of our bots.
2012-10-09 Sadrul Habib Chowdhury <sadrul@chromium.org>
[chromium] Make sure events are transformed correctly for plugins.
https://bugs.webkit.org/show_bug.cgi?id=89250
Reviewed by Tony Chang.
The events arriving in WebPluginContainerImpl are in the coordinate
space of the page containing the plugin. Before the events are
dispatched to the plugin, it is necessary to convert them into the
plugin's own coordinate system.
* src/WebInputEventConversion.cpp:
(WebKit::convertLocationForRenderObject): Transforms an event location for the specified RenderObject.
(WebKit):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent): Refactored code to reduce code-duplication for mouse and wheel events.
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
* src/WebInputEventConversion.h:
(WebCore):
(WebKit):
(WebMouseEventBuilder):
(WebMouseWheelEventBuilder):
(WebTouchEventBuilder):
(WebGestureEventBuilder):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleMouseEvent):
(WebKit::WebPluginContainerImpl::handleWheelEvent):
2012-10-09 Garrett Casto <gcasto@chromium.org>
Allow users to specify a different hover image for TextFieldDecorationElement
https://bugs.webkit.org/show_bug.cgi?id=93662
Reviewed by Kent Tamura.
* public/WebTextFieldDecoratorClient.h:
(WebTextFieldDecoratorClient):
(WebKit::WebTextFieldDecoratorClient::imageNameForHoverState): Allow users to specify the name of the image for mouseover.
* src/TextFieldDecoratorImpl.cpp:
(WebKit::TextFieldDecoratorImpl::imageForReadonlyState):
(WebKit::TextFieldDecoratorImpl::imageForHoverState):
(WebKit):
* src/TextFieldDecoratorImpl.h:
(TextFieldDecoratorImpl):
2012-10-09 Keishi Hattori <keishi@webkit.org>
Page popup should be smarter about its layout
https://bugs.webkit.org/show_bug.cgi?id=98499
Reviewed by Kent Tamura.
* src/ColorChooserUIController.cpp:
(WebKit::ColorChooserUIController::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView.
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::init): We keep the originBoundsInRootView argument for MockPagePopupDriver.
(WebKit::WebPagePopupImpl::resize): WebPagePopupImpl isn't in charge of setting the popup position any more.
* src/WebPagePopupImpl.h:
(WebPagePopupImpl):
2012-10-08 Dirk Pranke <dpranke@chromium.org>
Chromium DEPS roll r160657:160764.
Unreviewed.
* DEPS:
2012-10-08 Alec Flett <alecflett@chromium.org>
IndexedDB: remove autogenerated objectStore/index id code
https://bugs.webkit.org/show_bug.cgi?id=98085
Reviewed by Tony Chang.
Remove support for unused createObjectStore/createIndex. These
methods will go away entirely when
https://bugs.webkit.org/show_bug.cgi?id=98682 is fixed.
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::createObjectStore):
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
2012-10-08 Sami Kyostila <skyostil@chromium.org>
Some non-scrollable elements are added to non-fast-scrollable region
https://bugs.webkit.org/show_bug.cgi?id=97927
Reviewed by James Robinson.
Test that a non-scrollable RenderLayer isn't added to the non-fast scrollable
region.
The test in this patch consists of a web page where both the html and
body elements clip horizontal overflow. This results in a hierarchy
where the body element gets a scrollable RenderLayer. However, that
layer isn't (interactively) scrollable because while the scroll geometry
is calculated based on the amount of overflow, the scroll bars are
hidden because of the "overflow-x: hidden" style.
Previously this layer would have made the entire page part of the
non-fast scrollable region. With this patch,
RenderLayer::allowScrolling() is used as a pre-requisite for expanding
the region, thus avoiding the problem.
* tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::TEST_F):
(WebKit):
* tests/data/clipped-body.html: Added.
2012-10-08 Sailesh Agrawal <sail@chromium.org>
Mac Chromium: Ignore system numpad modifier
https://bugs.webkit.org/show_bug.cgi?id=97161
Reviewed by Tony Chang.
On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms.
My fix is to only rely on keycode to decide when to set the numpad modifier.
This code is not exersided by layout tests so I added a new unit test for this.
* WebKit.gypi:
* WebKitUnitTests.gyp:
* src/mac/WebInputEventFactory.mm:
(WebKit::isKeypadEvent): Removed check for numpad modifier.
* tests/WebInputEventFactoryTestMac.mm: Added.
(TEST): Added new test for WebInputEventFactory::keyboardEvent().
2012-10-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed. Rolled DEPS.
* DEPS:
2012-10-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* src/WebGeolocationPermissionRequestManager.cpp:
(WebGeolocationPermissionRequestManager::remove):
* src/WebIDBMetadata.cpp:
(WebKit::WebIDBMetadata::WebIDBMetadata):
* src/WebIntent.cpp:
(WebKit::WebIntent::extrasValue):
* tests/MemoryInstrumentationTest.cpp:
* tests/WebSocketExtensionDispatcherTest.cpp:
(WebCore::TEST_F):
2012-10-06 Ilya Tikhonovsky <loislo@chromium.org>
Web Inspector: NMI fix String instrumentation the way it was discussed in WK97964
https://bugs.webkit.org/show_bug.cgi?id=98500
Reviewed by Benjamin Poulain.
Current instrumentation incorrectly covers the case when StringImpl object has been created via StringImpl::createWithTerminatingNullCharacter().
Looks like the only way to detect the strings that has been created from literals is to compare the addresses of buffer and stringImpl + 1.
* tests/MemoryInstrumentationTest.cpp:
2012-10-05 Terry Anderson <tdanderson@chromium.org>
[chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS
https://bugs.webkit.org/show_bug.cgi?id=98526
Reviewed by Stephen White.
This is causing some problems with picture serialization between chrome
and the mainline skia tools. (Once this change lands and is gardened in,
I will make the corresponding change in chromium/skia/skia.gyp)
* features.gypi:
2012-10-05 Adam Barth <abarth@webkit.org>
Unreviewed.
Disable WebFrameTest.DivScrollIntoEditableTest. The test depends on
some code that is conditionally compiled and therefore fails in some
configurations.
* tests/WebFrameTest.cpp:
2012-10-05 W. James MacLean <wjmaclean@chromium.org>
[chromium] Enhance support for transforms in LinkHighlight.
https://bugs.webkit.org/show_bug.cgi?id=94355
Reviewed by Adrienne Walker.
Improved handling of transformed highlight targets, where the transform goes beyond simple translation.
* src/LinkHighlight.cpp:
(WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates.
(WebKit):
(WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path.
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::bestTouchLinkNode):
2012-10-05 Julien Chaffraix <jchaffraix@webkit.org>
Unreviewed build fix after r130545.
* tests/WebFrameTest.cpp:
Avoid a warning about truncating the double constant on Windows. While touching the variable, changed
it to be proper camelCase.
2012-10-05 Oli Lan <olilan@chromium.org>
Allow EventHandler to handle longpress gestures, including longpress selection on Android.
https://bugs.webkit.org/show_bug.cgi?id=98173
Reviewed by Ryosuke Niwa.
This patch changes the longpress gesture handling code in WebViewImpl to call EventHandler::handleGestureEvent.
The WebCore part of this patch adds longpress handling to that method, including the long press selection behaviour
required for Android. This means that a long press gesture performed on word (that is not part of a link)
selects the word, without generating a context menu event.
A new test, WebViewTest.LongPressSelection has been added to test this.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebViewImpl):
* tests/WebViewTest.cpp:
* tests/data/longpress_selection.html: Added.
2012-10-05 Yusuf Ozuysal <yusufo@google.com>
[chromium] Support zooming focused node for mobile devices
https://bugs.webkit.org/show_bug.cgi?id=97958
Reviewed by Adam Barth.
This unforks the Android version of scrollFocusedNodeIntoRect().A new setting
autoZoomFocusedNodeToLegibleScale was added to turn it on, since not all
platforms with ENABLE(GESTURE_EVENTS) want this.
Test: WebFrameTest.DivScrollIntoEditableTest
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setAutoZoomFocusedNodeToLegibleScale):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::autoZoomFocusedNodeToLegibleScale):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
* tests/WebFrameTest.cpp:
* tests/data/get_scale_for_zoom_into_editable_test.html: Added.
2012-10-05 W. James MacLean <wjmaclean@chromium.org>
[chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel.
https://bugs.webkit.org/show_bug.cgi?id=97355
Reviewed by Adrienne Walker.
This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if
interrupted by GestureTap, and animate away if interrupted by GestureTapCancel.
* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimationIfNeeded):
* src/LinkHighlight.h:
(LinkHighlight):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::enableTouchHighlight):
2012-10-05 Mark Pilgrim <pilgrim@chromium.org>
[Chromium] Update some more #includes for Platform/ directory
https://bugs.webkit.org/show_bug.cgi?id=98534
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
* src/WebFormElement.cpp:
* src/WebFrameImpl.cpp:
* src/WebGeolocationClientMock.cpp:
* src/WebGeolocationError.cpp:
* src/WebGeolocationPermissionRequest.cpp:
* src/WebHistoryItem.cpp:
* src/WebHitTestResult.cpp:
* src/WebIDBTransactionImpl.h:
* src/WebIconLoadingCompletionImpl.h:
* src/WebImageDecoder.cpp:
* src/WebImageSkia.cpp:
* src/WebInputElement.cpp:
* src/WebKit.cpp:
* src/WebLabelElement.cpp:
* src/WebMediaStreamRegistry.cpp:
* src/WebNode.cpp:
* src/WebNotification.cpp:
* src/WebOptionElement.cpp:
* src/WebPageSerializer.cpp:
* src/WebPageSerializerImpl.cpp:
* src/WebPageSerializerImpl.h:
* src/WebPluginListBuilderImpl.cpp:
* src/WebPluginLoadObserver.h:
* src/WebPopupMenuImpl.cpp:
* src/WebPopupMenuImpl.h:
* src/WebRange.cpp:
* src/WebRegularExpression.cpp:
* src/WebScriptController.cpp:
* src/WebSecurityOrigin.cpp:
* src/WebSecurityPolicy.cpp:
* src/WebSelectElement.cpp:
* src/WebSerializedScriptValue.cpp:
* src/WebSessionDescriptionDescriptor.cpp:
* src/WebSettingsImpl.cpp:
* src/WebSocketImpl.cpp:
* src/WebSocketImpl.h:
* src/WebStorageEventDispatcherImpl.cpp:
* src/WebSurroundingText.cpp:
* src/WebURLLoadTiming.cpp:
* src/WorkerAsyncFileWriterChromium.cpp:
* src/WorkerFileSystemCallbacksBridge.cpp:
2012-10-05 Sadrul Habib Chowdhury <sadrul@chromium.org>
[chromium] Allow dragging into plugins.
https://bugs.webkit.org/show_bug.cgi?id=98277
Reviewed by Tony Chang.
Allow plugins to receive drag events. This will make it possible to
perform drag-n-drop into browser plugins (and other plugins if desired).
* public/WebDragStatus.h: Added.
(WebKit):
* public/WebPlugin.h:
(WebKit):
(WebPlugin):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleMouseEvent):
(WebKit::WebPluginContainerImpl::handleDragEvent):
(WebKit):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
2012-10-04 Kenichi Ishibashi <bashi@chromium.org>
[WebSocket] ExtensionParser should have its own file
https://bugs.webkit.org/show_bug.cgi?id=98475
Reviewed by Yuta Kitamura.
Add a test for parsing Sec-WebSocket-Extensions field.
* tests/WebSocketExtensionDispatcherTest.cpp:
(WebCore):
(WebCore::TEST_F):
2012-10-04 Kenichi Ishibashi <bashi@chromium.org>
[Chromium] Improve SocketStreamHandle::send() stability
https://bugs.webkit.org/show_bug.cgi?id=98459
Reviewed by Yuta Kitamura.
Avoid null dereference in SocketStreamHandleInternal::send().
No changes in behavior.
* src/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::send):
2012-10-04 Dirk Pranke <dpranke@chromium.org>
Chromium DEPS roll r160281:160322
Unreviewed.
* DEPS:
2012-10-04 Alexandre Elias <aelias@chromium.org>
[chromium] Scale plugin container by frameScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=98468
Reviewed by Adam Barth.
Plugin containers (for invalid plugins) weren't taking into account
frameScaleFactor, looking cut off when that was non-1.
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::paint):
2012-10-04 Alpha Lam <hclam@chromium.org>
Unreviewd. Chromium DEPS roll. Update to r160281.
* DEPS:
2012-10-04 Mark Pilgrim <pilgrim@chromium.org>
[Chromium] Update some #includes for Platform directory
https://bugs.webkit.org/show_bug.cgi?id=98440
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
* src/ApplicationCacheHost.cpp:
* src/AssociatedURLLoader.h:
* src/AsyncFileWriterChromium.cpp:
* src/AudioDestinationChromium.h:
* src/AutofillPopupMenuClient.cpp:
* src/ChromeClientImpl.cpp:
* src/ContextMenuClientImpl.cpp:
* src/DeliveredIntentClientImpl.h:
* src/DragClientImpl.cpp:
* src/DragScrollTimer.h:
* src/FrameLoaderClientImpl.cpp:
* src/InspectorClientImpl.cpp:
* src/InspectorClientImpl.h:
* src/InspectorFrontendClientImpl.cpp:
* src/NotificationPresenterImpl.cpp:
* src/PageWidgetDelegate.h:
* src/SocketStreamHandle.cpp:
* src/SocketStreamHandleInternal.h:
* src/SpeechInputClientImpl.cpp:
* src/StorageAreaProxy.cpp:
* src/StorageNamespaceProxy.cpp:
* src/UserMediaClientImpl.cpp:
* src/WebAccessibilityObject.cpp:
* src/WebAnimationControllerImpl.cpp:
* src/WebCommon.cpp:
* src/WebDOMEventListenerPrivate.h:
* src/WebDOMMessageEvent.cpp:
* src/WebDOMStringList.cpp:
* src/WebDataSourceImpl.cpp:
* src/WebDatabase.cpp:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:
* src/WebDocument.cpp:
* src/WebDocumentType.cpp:
* src/WebDragData.cpp:
* src/WebElement.cpp:
* src/WebEntities.cpp:
* src/WebFileChooserCompletionImpl.h:
* src/WebFileSystemCallbacksImpl.cpp:
* src/WebFontImpl.cpp:
2012-10-04 Alec Flett <alecflett@chromium.org>
IndexedDB: promote objectstore/index backend ids to the frontend
https://bugs.webkit.org/show_bug.cgi?id=97834
Reviewed by Tony Chang.
Support for marshalling additional IDBMetadata and new calls to
createObjectStore/createIndex.
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
* public/WebIDBMetadata.h:
(ObjectStore):
(Index):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::createIndex):
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::createObjectStore):
(WebKit):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBMetadata.cpp:
(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
2012-10-04 Simon Fraser <simon.fraser@apple.com>
Standardize on "flush" terminology for compositing layer flushing/syncing
https://bugs.webkit.org/show_bug.cgi?id=98321
Reviewed by Simon Fraser.
Rename compositing-related methods that refer to "syncing" to instead
refer to "flushing".
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::scheduleCompositingLayerFlush):
* src/ChromeClientImpl.h:
(ChromeClientImpl):
2012-10-05 Kent Tamura <tkent@chromium.org>
[Chromium] Enable the multiple fields UI for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98351
Reviewed by Hajime Morita.
* features.gypi:
Disable ENABLE_INPUT_TYPE_DATE_LEGACY_UI.
2012-10-04 Kent Tamura <tkent@chromium.org>
Add code for input[type=date] with the multiple fields UI
https://bugs.webkit.org/show_bug.cgi?id=98340
Reviewed by Hajime Morita.
* features.gypi: Add ENABLE_INPUT_TYPE_DATE_LEGACY_UI=1 for non-Android.
2012-10-03 Keishi Hattori <keishi@webkit.org>
Implement localizeValue for TimeInputType
https://bugs.webkit.org/show_bug.cgi?id=98237
Reviewed by Kent Tamura.
* tests/LocaleMacTest.cpp:
(LocaleMacTest::timeComponents):
(LocaleMacTest):
(LocaleMacTest::formatTime): Tests formatDateTime() for time.
(TEST_F):
2012-10-03 Dirk Pranke <dpranke@chromium.org>
Roll chromium to r160008
Unreviewed, deps roll.
* DEPS:
2012-10-03 Adam Barth <abarth@webkit.org>
Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER)
https://bugs.webkit.org/show_bug.cgi?id=98301
Reviewed by Eric Seidel.
* features.gypi:
2012-10-03 Jeff Timanus <twiz@chromium.org>
[chromium] Expose settings value to conditionally enable pinch-zoom scaling in the Chromium compositor. The
flag defaults to disabled, so this change should be a no-op for scaling/scrolling behaviour.
https://bugs.webkit.org/show_bug.cgi?id=93292
Reviewed by James Robinson.
* public/WebSettings.h:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setApplyPageScaleFactorInCompositor):
(WebKit):
(WebKit::WebSettingsImpl::applyPageScaleFactorInCompositor):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::applyScrollAndScale):
2012-10-03 Hans Wennborg <hans@chromium.org>
Speech JavaScript API: Add SpeechRecognition.interimResults attribute
https://bugs.webkit.org/show_bug.cgi?id=98279
Reviewed by Adam Barth.
Plumb interimResults through to Chromium.
* public/WebSpeechRecognitionParams.h:
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::interimResults):
(WebSpeechRecognitionParams):
* src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::start):
* src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):
2012-10-03 Hans Wennborg <hans@chromium.org>
Speech JavaScript API: Remove resultdeleted event
https://bugs.webkit.org/show_bug.cgi?id=98272
Reviewed by Adam Barth.
Remove didDeleteResult. This was never used, and has been removed from
the spec draft.
* public/WebSpeechRecognizerClient.h:
* src/SpeechRecognitionClientProxy.cpp:
* src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):
2012-10-02 Anders Carlsson <andersca@apple.com>
Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory
https://bugs.webkit.org/show_bug.cgi?id=98217
Reviewed by Andreas Kling.
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
2012-10-03 Tommy Widenflycht <tommyw@google.com>
MediaStream API: RTCPeerConnection should send down its handler via the FrameLoaderClient directly after creation.
https://bugs.webkit.org/show_bug.cgi?id=98149
Reviewed by Adam Barth.
Adding willStartUsingPeerConnectionHandler to the WebFrameClient.
* public/WebFrameClient.h:
(WebKit):
(WebFrameClient):
(WebKit::WebFrameClient::willStartUsingPeerConnectionHandler):
* src/FrameLoaderClientImpl.cpp:
(WebKit):
(WebKit::FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
2012-10-03 Peter Kotwicz <pkotwicz@google.com>
WebImage::framesFromData should skip corrupted frames
https://bugs.webkit.org/show_bug.cgi?id=98214
Reviewed by Adam Barth.
WebImage::framesFromData() should only return bitmaps for valid frames
of a .ico file.
* src/WebImageSkia.cpp:
(WebKit::WebImage::framesFromData):
* tests/WebImageTest.cpp:
(WebKit::TEST):
(WebKit):
* tests/data/valid_header_missing_bitmap.ico: Added.
2012-10-02 Yury Semikhatsky <yurys@chromium.org>
Provide memory instrumentation for HashCountedSet
https://bugs.webkit.org/show_bug.cgi?id=98138
Reviewed by Pavel Feldman.
Added unit test for HashCountedSet memory instrumentation.
* tests/MemoryInstrumentationTest.cpp:
2012-10-02 Kent Tamura <tkent@chromium.org>
[Chromium-Win] Implement LocaleWin::dateFormat
https://bugs.webkit.org/show_bug.cgi?id=98117
Reviewed by Kentaro Hara.
* tests/LocaleWinTest.cpp:
(TEST_F): Add tests for LocaleWin::dateFormat.
== Rolled over to ChangeLog-2012-10-19 ==
|