1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209
|
2013-02-24 Allan Sandfeld Jensen <allan.jensen@digia.com>
[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705
Reviewed by Kenneth Rohde Christiansen.
Do not resize window when default size is requested.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::setWindowRect):
2012-11-30 Mihai Maerean <mmaerean@adobe.com>
[CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=101192
Reviewed by Hajime Morita.
Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
Tests: No new tests because there is no functional change.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSRegionsEnabled):
2012-11-29 Alexey Proskuryakov <ap@apple.com>
[WK2] Forward cookie jar calls to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=103457
Reviewed by Darin Adler.
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::cookiesForDOM):
(PlatformStrategiesGtk::setCookiesFromDOM):
(PlatformStrategiesGtk::cookiesEnabled):
(PlatformStrategiesGtk::cookieRequestHeaderFieldValue):
(PlatformStrategiesGtk::getRawCookies):
(PlatformStrategiesGtk::deleteCookie):
(PlatformStrategiesGtk::getHostnamesWithCookies):
(PlatformStrategiesGtk::deleteCookiesForHostname):
(PlatformStrategiesGtk::deleteAllCookies):
2012-11-27 James Simonsen <simonjam@chromium.org>
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151
Reviewed by Adam Barth.
* webkit/webkitwebframe.cpp:
(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):
2012-11-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135786.
http://trac.webkit.org/changeset/135786
https://bugs.webkit.org/show_bug.cgi?id=103379
It made 3 plugin tests timeout on several platforms (Requested
by Ossy on #webkit).
* webkit/webkitwebframe.cpp:
(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):
2012-11-26 James Simonsen <simonjam@chromium.org>
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151
Reviewed by Adam Barth.
* webkit/webkitwebframe.cpp:
(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):
2012-11-25 Kaustubh Atrawalkar <kaustubh@motorola.com>
Remove deprecated load-done signal
https://bugs.webkit.org/show_bug.cgi?id=72712
Reviewed by Brent Fulgham.
Remove deprecated load-done signal and migrate to load-status.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit):
(WebKit::FrameLoaderClient::dispatchDidFinishLoad):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):
2012-09-26 Gustavo Noronha Silva <gns@gnome.org>
[GTK] Split SVG from WebCore to work-around make limitation
https://bugs.webkit.org/show_bug.cgi?id=97735
Reviewed by Carlos Garcia Campos.
Add a new libtool convenience library, libWebCoreSVG.la, to work-around
make limitation when linking libWebCore.
* GNUmakefile.am: link libWebCoreSVG.la into libwebkitgtk.
2012-11-21 Allan Sandfeld Jensen <allan.jensen@digia.com>
Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139
Reviewed by Julien Chaffraix.
Switched to using point in innerNodeFrame. While the use here seems wrong it has been
left functionally unchanged to be fixed by a later patch.
* webkit/webkithittestresult.cpp:
(WebKit::kit):
2012-11-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r135295.
http://trac.webkit.org/changeset/135295
https://bugs.webkit.org/show_bug.cgi?id=102834
This patch causes assertion to some layout tests on chromium
(Requested by jianli on #webkit).
* webkit/webkitwebframe.cpp:
(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):
2012-11-20 James Simonsen <simonjam@chromium.org>
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151
Reviewed by Adam Barth.
* webkit/webkitwebframe.cpp:
(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):
2012-11-20 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update NEWS and configure.ac for 1.11.2 release
* NEWS: Added release notes for 1.11.2.
2012-11-16 Martin Robinson <mrobinson@igalia.com>
[GTK] Move CredentialBackingStore usage from GtkAuthenticationDialog to ResourceHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=101840
Reviewed by Gustavo Noronha Silva.
Enable the CredentialStore by default for the WebKit1 GTK+ port. Before this value
didn't have an bearing on whether or not the persistent credential storage was used.
Now is does.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::shouldUseCredentialStorage): Enable credential storage by default.
2012-11-15 Gustavo Noronha Silva <gns@gnome.org>
[GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435
Reviewed by Martin Robinson.
More people have been reporting problems when linking WebCore because
the command line limit is being exceeded. Splitting WebCore a bit more
is in order.
* GNUmakefile.am: link libWebCorePlatform into libwebkitgtk
2012-11-15 Zan Dobersek <zandobersek@gmail.com>
Unreviewed build fix attempt after r134765.
* webkit/webkitviewportattributes.cpp:
(webkitViewportAttributesRecompute):
2012-11-12 Josh Rickmar <jrick@devio.us>
Add WebCore::Setting to block displaying and/or running insecure content on secure pages
https://bugs.webkit.org/show_bug.cgi?id=58378
Reviewed by Martin Robinson.
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
2012-11-05 Simon Fraser <simon.fraser@apple.com>
Fix layer borders to cleaning appear and disappear on switching
https://bugs.webkit.org/show_bug.cgi?id=101136
Reviewed by Sam Weinig.
Remove the GraphicsLayerClient methods showDebugBorders() and
showRepaintCounter().
* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextCairo.cpp:
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
2012-10-25 Martin Robinson <mrobinson@igalia.com>
[GTK] Move soup authentication from GtkAuthenticationDialog to WebCore
https://bugs.webkit.org/show_bug.cgi?id=99914
Reviewed by Carlos Garcia Campos.
The calls which actually authenticate a soup message are gone from the GtkAuthenticationDialog. Since the
GtkAuthenticationDialog exposed by the WebKitSoupAuthentication class in the GTK+ API work without a
ResourceHandle (they are more general), we add a WebKitSoupAuthDialogAuthenticationClient added to avoid
breaking API. This is unused by either Epiphany or internally in WebKitGTK+.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): The authentication dialog
now just takes the AuthenticationChallenge instead of the libsoup objects.
* webkit/webkitsoupauthdialog.cpp:
(WebKitSoupAuthDialogAuthenticationClient): Added this helper.
(sessionAuthenticate): Use the new WebKitSoupAuthDialogAuthenticationClient.
2012-11-02 Martin Robinson <mrobinson@igalia.com>
[GTK] Remove dependency on SoupPasswordManager
https://bugs.webkit.org/show_bug.cgi?id=100775
Reviewed by Carlos Garcia Campos.
Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.
* GNUmakefile.am: Use libsecret libs during WebKit1 library compilation.
2012-10-24 Brady Eidson <beidson@apple.com>
Add a strategy for loader customization.
https://bugs.webkit.org/show_bug.cgi?id=100278
Reviewed by Alexey Proskuryakov.
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::createLoaderStrategy):
* WebCoreSupport/PlatformStrategiesGtk.h:
(PlatformStrategiesGtk):
2012-10-23 Alexey Proskuryakov <ap@apple.com>
Add a strategy for shared workers
https://bugs.webkit.org/show_bug.cgi?id=100165
Reviewed by Brady Eidson.
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::createPasteboardStrategy):
(PlatformStrategiesGtk::createSharedWorkerStrategy):
(PlatformStrategiesGtk::createVisitedLinkStrategy):
* WebCoreSupport/PlatformStrategiesGtk.h:
2012-10-24 Priit Laes <plaes@plaes.org>
[GTK] Typos in user-visible strings: "coordintate"
https://bugs.webkit.org/show_bug.cgi?id=100252
Reviewed by Martin Robinson.
s/coordintate/coordinate
* webkit/webkithittestresult.cpp:
(webkit_hit_test_result_class_init):
2012-10-23 Martin Robinson <mrobinson@igalia.com>
[GTK][Soup] Implement the default authentication dialog via WebCoreSupport
https://bugs.webkit.org/show_bug.cgi?id=99351
Reviewed by Carlos Garcia Campos.
Instead of using a custom SoupSessionFeature to show the authentication dialog,
show it using the corresponding WebCore message.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Show the dialog when we need to authenticate. Also, so not show the dialog
if we are in DRT mode.
* webkit/webkitglobals.cpp:
(webkitInit): No longer install our SoupFeature.
2012-10-23 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update NEWS and configure.ac for 1.11.1 release
* NEWS: Added release notes for 1.11.1.
2012-10-23 Andras Becsi <andras.becsi@digia.com>
Remove devicePixelRatio from ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=99845
Reviewed by Adam Barth.
* webkit/webkitviewportattributes.cpp:
(webkitViewportAttributesRecompute):
Pass the device pixel ratio as a function argument.
2012-10-22 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
[Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
https://bugs.webkit.org/show_bug.cgi?id=98514
Reviewed by Kenneth Rohde Christiansen.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
2012-10-10 Brady Eidson <beidson@apple.com>
Switch ResourceLoader::resourceData() from SharedBuffer to ResourceBuffer
https://bugs.webkit.org/show_bug.cgi?id=98976
Reviewed by Anders Carlsson.
* webkit/webkitwebdatasource.cpp:
(webkit_web_data_source_get_data):
2012-10-10 Jon Lee <jonlee@apple.com>
[WK2] Activate plugins when user clicks on snapshot
https://bugs.webkit.org/show_bug.cgi?id=98328
<rdar://problem/12426681>
Reviewed by Brady Eidson.
* WebCoreSupport/FrameLoaderClientGtk.h:
(WebKit::FrameLoaderClient::recreatePlugin): Stub implementation of recreatePlugin().
2012-10-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r130853.
http://trac.webkit.org/changeset/130853
https://bugs.webkit.org/show_bug.cgi?id=98873
The rollout was incorrect (Requested by zdobersek on #webkit).
* webkit/webkitwebview.cpp:
(resizeWebViewFromAllocation):
(webkit_web_view_size_allocate):
(webkitWebViewMap):
2012-10-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r130838.
http://trac.webkit.org/changeset/130838
https://bugs.webkit.org/show_bug.cgi?id=98860
The patch is causing X errors (=> crashes) on GTK 64-bit
Release builder (Requested by zdobersek on #webkit).
* webkit/webkitwebview.cpp:
(resizeWebViewFromAllocation):
(webkit_web_view_size_allocate):
(webkitWebViewMap):
2012-10-09 Daniel Drake <dsd@laptop.org>
[GTK] Plugins don't display
https://bugs.webkit.org/show_bug.cgi?id=98789
Reviewed by Martin Robinson.
Fix a recent regression where plugin content was not being displayed.
Bringing webkit_web_view_size_allocate in line with the WebKit2
equivalent solves the issue.
* webkit/webkitwebview.cpp:
(resizeWebViewFromAllocation): pass allocation request to children
even when the allocation size does not change.
(webkit_web_view_size_allocate): don't bail too early if the
allocation size does not change.
2012-10-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::getPluginInfo):
* webkit/webkitfavicondatabase.cpp:
(webkitFaviconDatabaseImportFinished):
* webkit/webkitwebplugin.cpp:
(webkit_web_plugin_get_mimetypes):
2012-10-04 Simon Fraser <simon.fraser@apple.com>
Final part of "sync" to "flush" renaming
https://bugs.webkit.org/show_bug.cgi?id=98430
Reviewed by Tim Horton.
Change method names on GraphicsLayer and GraphicsLayerClient that
refer to "sync" to use the term "flush" instead, to be consistent
with the rest of the code.
* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextCairo.cpp:
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::syncLayersNow):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):
2012-10-04 Simon Fraser <simon.fraser@apple.com>
Standardize on "flush" terminology for compositing layer flushing/syncing
https://bugs.webkit.org/show_bug.cgi?id=98321
Reviewed by Simon Fraser.
Rename compositing-related methods that refer to "syncing" to instead
refer to "flushing".
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scheduleCompositingLayerFlush):
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
2012-10-02 Anders Carlsson <andersca@apple.com>
Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory
https://bugs.webkit.org/show_bug.cgi?id=98217
Reviewed by Andreas Kling.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::initialize):
2012-10-02 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Add API to get the web view that initiated a custom URI request to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=97895
Reviewed by Martin Robinson.
* WebCoreSupport/FrameNetworkingContextGtk.cpp:
(WebKit::FrameNetworkingContextGtk::initiatingPageID): Stub
implementation.
* WebCoreSupport/FrameNetworkingContextGtk.h:
(FrameNetworkingContextGtk): Added.
2012-10-02 Adrian Perez de Castro <aperez@igalia.com>
[GTK] Value not returned warning with geolocation disabled
https://bugs.webkit.org/show_bug.cgi?id=98148
Reviewed by Xan Lopez.
With geolocation disabled in the build, return a sensible value from
DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests.
This also avoids a compiler warning.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
2012-10-01 Brady Eidson <beidson@apple.com>
Remove the Safari 2 -> Safari 3 icon database import code.
https://bugs.webkit.org/show_bug.cgi?id=98113
Reviewed by Maciej Stachowiak.
Nuke the performImport() IconDatabaseClient method.
* webkit/webkitfavicondatabase.cpp:
(IconDatabaseClientGtk):
2012-10-01 Arnaud Renevier <a.renevier@sisa.samsung.com>
[Gtk] crash when accelerated composition is turned off
https://bugs.webkit.org/show_bug.cgi?id=98099
Reviewed by Martin Robinson.
frame->view()->updateLayoutAndStyleIfNeededRecursive() may reset root
compositing layer in flushAndRenderLayers. So, we check if compositing
is enabled afterwards, and return if it is not.
This bug is handled by LayoutTests/compositing/toggle-compositing.html
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):
2012-10-01 Claudio Saavedra <csaavedra@igalia.com>
[GTK] Save original uri for downloaded files
https://bugs.webkit.org/show_bug.cgi?id=95188
Reviewed by Carlos Garcia Campos.
gvfs stores metadata locally, and this information can later be
used by file management applications. Based on a patch by
Alexander Larsson <alexl@redhat.com>.
* webkit/webkitdownload.cpp:
(webkit_download_open_stream_for_uri): Save the download-uri as
file metadata.
2012-10-01 Claudio Saavedra <csaavedra@igalia.com>
[GTK] WebKitDownload: use more of GOwnPtr/GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=98009
Reviewed by Carlos Garcia Campos.
Use more GOwnPtr/GRefPtr in WebKitDownload
* webkit/webkitdownload.cpp:
(webkit_download_open_stream_for_uri): Use GRefPtr
for a GFile and GOwnPtr for GError.
(webkit_download_set_destination_uri): Ditto.
(webkit_download_received_data): Use GOwnPtr for GError.
2012-09-28 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Code inside FrameLoaderClient::canShowMIMEType() implementations can be shared among different WK ports
https://bugs.webkit.org/show_bug.cgi?id=97547
Reviewed by Adam Barth.
Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
inside WebKit::FrameLoaderClient::canShowMIMEType().
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::canShowMIMEType):
2012-09-28 Huang Dongsung <luxtella@company100.net>
[GTK] Enable CSS Shaders layout LayoutTests on GTK+
https://bugs.webkit.org/show_bug.cgi?id=97821
Reviewed by Martin Robinson.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSCustomFilterEnabled): Pass through to Settings object.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-09-27 Allan Sandfeld Jensen <allan.jensen@digia.com>
Unify event handling of middle mouse button.
https://bugs.webkit.org/show_bug.cgi?id=97690
Reviewed by Tony Chang.
Remove port specific handling of middle mouse button press.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::supportsGlobalSelection):
* WebCoreSupport/EditorClientGtk.h:
(EditorClient):
* webkit/webkitwebview.cpp:
(webkit_web_view_button_press_event):
2012-09-26 Gustavo Noronha Silva <gns@gnome.org>
Unreviewed build fix after 129707.
* webkit/webkitwebview.cpp:
(webkit_web_view_forward_context_menu_event):
2012-09-26 Martin Robinson <mrobinson@igalia.com>
[GTK] Use XDamage to simplify RedirectedXCompositeWindow
https://bugs.webkit.org/show_bug.cgi?id=97267
Reviewed by Alejandro G. Castro.
Use XDamage to queue redraws of the widget when redirecting accelerated compositing
to an offscreen window. This allows removing a finicky timer-based approach, improves
performance, and allows simplifying things greatly.
* GNUmakefile.am: Add the XDamage CFLAGS and LIBS.
* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext): Change the signature of compositeLayersToContext
to accept an enum that explains the composite purpose.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::redirectedWindowDamagedCallback): Added.
(WebKit::AcceleratedCompositingContext::initialize): Handle the situation where
the RedirectedXCompositeWindow returns a null pointer.
(WebKit::AcceleratedCompositingContext::enabled): Ditto.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Remove the code handling
the usable size of the RedirectedXCompositeWindow. The usable size is now always equal
to the size.
(WebKit::AcceleratedCompositingContext::compositeLayersToContext): When drawing for a
resize, first clear the entire context. Remove the double swap-buffer, as it's no
longer necessary.
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer): Handle the case that
the redirected window is null.
(WebKit::AcceleratedCompositingContext::resizeRootLayer): Instead of doing another
immediate layer flush, just recomposite the current layer state and schedule a new
flush. This should make resizing faster.
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers): We no longer need to
queue a redraw, unless we want to force one.
2012-09-26 Zan Dobersek <zandobersek@gmail.com>
[GTK] Enable some of the unstable CSS features
https://bugs.webkit.org/show_bug.cgi?id=97572
Reviewed by Martin Robinson.
Add a helper DumpRenderTreeSupportGtk method for enabling
the <style scoped> support in WebCore. This is used in DumpRenderTree.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setShadowDOMEnabled): Add missing
ENABLE(SHADOW_DOM) compilation guards.
(DumpRenderTreeSupportGtk::setStyleScopedEnabled):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk): Remove the 'enabled' parameter name from both
setShadowDOMEnabled and setStyleScopedEnabled method declarations as it adds
no information and is causing style warnings.
2012-09-25 Beth Dakin <bdakin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=95397
Need to merge didFirstVisuallyNonEmptyLayout and
didNewFirstVisuallyNonEmptyLayout
-and corresponding-
<rdar://problem/10791680>
Reviewed by Sam Weinig.
Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidLayout):
* WebCoreSupport/FrameLoaderClientGtk.h:
(FrameLoaderClient):
It is now necessary to opt into getting any of the
"layout milestone" notifications.
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
2012-09-25 Paweł Forysiuk <tuxator@o2.pl>
[GTK] Webkit 1.8.2 fails to build with MinGW with spellchecking enabled
https://bugs.webkit.org/show_bug.cgi?id=93255
Reviewed by Martin Robinson.
Build dies because of invalid cast. Additionaly word "interface" is in use with MinGW compiler.
* WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::checkSpellingOfString): Use String to avoid unneded casting
* webkit/webkitspellcheckerenchant.cpp:
(webkit_spell_checker_enchant_spell_checker_interface_init): rename interface -> checkerInterface
2012-09-24 Benjamin Poulain <bpoulain@apple.com>
Fix Geolocation error reporting in the test support
https://bugs.webkit.org/show_bug.cgi?id=97386
Reviewed by Sam Weinig.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setMockGeolocationPositionUnavailableError):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-09-24 Zan Dobersek <zandobersek@gmail.com>
[Gtk] Unskip the Shadow DOM layout tests
https://bugs.webkit.org/show_bug.cgi?id=90776
Reviewed by Ryosuke Niwa.
Add a method for enabling the Shadow DOM through RuntimeEnabledFeatures.
The method is called from DumpRenderTree when resetting state.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setShadowDOMEnabled):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-09-24 Joone Hur <joone.hur@intel.com>
[GTK] Implement GraphicsLayer using Clutter
https://bugs.webkit.org/show_bug.cgi?id=73767
Reviewed by Martin Robinson.
This patch is needed for enabling Accelerated Compositing(Clutter backend)
with the patches submitted in bug 92045 and 91940.
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
(WebKit::AcceleratedCompositingContext::scrollNonCompositedContents): Added to fix bulid break.
(WebKit):
2012-09-19 Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>
[gtk] add enable-media-stream to websettings
https://bugs.webkit.org/show_bug.cgi?id=94361
Reviewed by Martin Robinson.
Applications should be allowed to enable/disable MediaStream on webkitwebsettings.
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
2012-09-14 Zan Dobersek <zandobersek@gmail.com>
[GTK] Clear application cache between tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=96543
Reviewed by Philippe Normand.
Add a method to the DumpRenderTreeSupportGtk class that upon calling
clears the application cache and vacuums the database file.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearApplicationCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r128453.
http://trac.webkit.org/changeset/128453
https://bugs.webkit.org/show_bug.cgi?id=96681
Having tests use the same appcache directory leads to timeouts
(Requested by zdobersek on #webkit).
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearMemoryCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-09-13 Zan Dobersek <zandobersek@gmail.com>
[GTK] Clear application cache between tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=96543
Reviewed by Philippe Normand.
Add a method to the DumpRenderTreeSupportGtk class that upon calling
clears the application cache and vacuums the database file.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearApplicationCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-09-12 Siraj Razick <siraj.razick@collabora.co.uk>
[GTK] Update AcceleratedCompositingContextClutter to match AcceleratedCompositingContext.h API update
https://bugs.webkit.org/show_bug.cgi?id=96165
Reviewed by Martin Robinson.
Due to the refactoring done in bug #90085 AcceleratedCompositingContext API changed, as a result
AcceleratedCompositingContextClutter doesn't compile anymore. This patch is to update the
AcceleratedCompositingContextClutter implementations to match the API update, and Make webkit
AC backend compile again.
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer):
(WebKit::AcceleratedCompositingContext::setNonCompositedContentsNeedDisplay):
(WebKit::flushAndRenderLayersCallback):
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush):
(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers):
2012-09-11 Arnaud Renevier <a.renevier@sisa.samsung.com>
[Gtk] allow building with css-shaders
https://bugs.webkit.org/show_bug.cgi?id=95603
Reviewed by Martin Robinson.
Add enable-css-shaders property to WebKit WebSettings, and connects it
to WebCore settings setCSSCustomFilterEnabled.
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
2012-09-09 Emil A Eklund <eae@chromium.org>
Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
https://bugs.webkit.org/show_bug.cgi?id=81413
Reviewed by David Hyatt.
Update ChromeClientGtk and webkitwebview to call pixelSnappedBoundingBox.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::mouseDidMoveOverElement):
* webkit/webkitwebview.cpp:
(getLocationForKeyboardGeneratedContextMenu):
(webkit_web_view_query_tooltip):
2012-09-07 Martin Robinson <mrobinson@igalia.com>
[GTK] Move user agent helpers to WebCore
https://bugs.webkit.org/show_bug.cgi?id=95745
Reviewed by Carlos Garcia Campos.
Move the code for determining the user agent to WebCore and have WebKit1
use the new shared code.
* webkit/webkitwebsettings.cpp: Use the WebCore code to determine the user
agent in WebKit1.
2012-09-05 Sam Weinig <sam@webkit.org>
Part 2 of removing PlatformString.h, remove PlatformString.h
https://bugs.webkit.org/show_bug.cgi?id=95931
Reviewed by Adam Barth.
Remove PlatformString.h
* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/InspectorClientGtk.cpp:
* gdom/ConvertToGCharPrivate.h:
* webkit/webkitsecurityorigin.cpp:
* webkit/webkitwebdatasource.cpp:
* webkit/webkitwebhistoryitem.cpp:
* webkit/webkitwebresource.cpp:
2012-09-06 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Add API to get/set the security policy of a given URI scheme
https://bugs.webkit.org/show_bug.cgi?id=95549
Reviewed by Martin Robinson.
Add WebKitSecurityPolicy enum with flags that represent the
security policy of a URI scheme. Add methods to get and set the
security policy flags for a given URI scheme.
* docs/webkitgtk-sections.txt: Add new symbols.
* tests/testglobals.c:
(test_globals_security_policy):
(main):
* webkit/webkitglobals.cpp:
(webkit_set_security_policy_for_uri_scheme):
(webkit_get_security_policy_for_uri_scheme):
* webkit/webkitglobals.h:
2012-09-05 Kaustubh Atrawalkar <kaustubh@motorola.com>
[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
https://bugs.webkit.org/show_bug.cgi?id=92735
Reviewed by Hajime Morita.
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-09-04 Joanmarie Diggs <jdiggs@igalia.com>
[GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
https://bugs.webkit.org/show_bug.cgi?id=95740
Reviewed by Martin Robinson.
Updated unit test.
* tests/testatk.c:
(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.
2012-09-01 Joanmarie Diggs <jdiggs@igalia.com>
[Gtk] Incorrect/unexpected characters in the text of certain accessibles
https://bugs.webkit.org/show_bug.cgi?id=95180
Reviewed by Chris Fleizach.
Corrected a unit test in which the expected accessible text was wrong as
a result of this bug. In particular, the AtkText inserted into an empty
text field is expected to be the same text atk_text_get_text() returns.
That was not happening -- and presumably not noticed as a result of the
hard to read textual representation of the multibyte password field
bullets.
* tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Corrected the test and added a
comment so that one knows what the multibyte character is.
2012-08-31 José Dapena Paz <jdapena@igalia.com>
[GTK] Assert on ChromeClientGtk::scroll with delta (0, -1).
https://bugs.webkit.org/show_bug.cgi?id=95590
Change the assert to avoid hitting when the delta does not have any
value > 0.
Reviewed by Martin Robinson.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scroll):
2012-08-30 Benjamin Poulain <bpoulain@apple.com>
Replace JSC::UString by WTF::String
https://bugs.webkit.org/show_bug.cgi?id=95271
Reviewed by Geoffrey Garen.
Replace UString by String.
* gdom/ConvertToGCharPrivate.h:
(copyAsGchar):
2012-08-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Use ASCIILiteral for DEFINE_STATIC_LOCAL string
https://bugs.webkit.org/show_bug.cgi?id=95420
Reviewed by Benjamin Poulain.
As recommended by http://trac.webkit.org/wiki/EfficientStrings,
WebKit needs to use ASCIILiteral for the string of DEFINE_STATIC_LOCAL.
* webkit/webkitwebsettings.cpp:
(webkitPlatform):
(webkitOSVersion):
2012-08-29 José Dapena Paz <jdapena@igalia.com>
[Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070
Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.
Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.
Reviewed by Martin Robinson.
* webkit/webkitwebview.cpp:
(webkit_web_view_realize):
2012-08-28 Martin Robinson <mrobinson@igalia.com>
[GTK] Enable the edge distance anti-aliasing for accelerated compositing layers
https://bugs.webkit.org/show_bug.cgi?id=95272
Reviewed by No'am Rosenthal.
Turn on edge-distance anti-aliasing for GTK+ WebKit1. This
improves the quality of layer rendering.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::initialize):
2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r126914.
http://trac.webkit.org/changeset/126914
https://bugs.webkit.org/show_bug.cgi?id=95239
it breaks everything and fixes nothing (Requested by pizlo on
#webkit).
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::getPluginInfo):
* webkit/webkitfavicondatabase.cpp:
(webkitFaviconDatabaseImportFinished):
* webkit/webkitwebplugin.cpp:
(webkit_web_plugin_get_mimetypes):
2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::getPluginInfo):
* webkit/webkitfavicondatabase.cpp:
(webkitFaviconDatabaseImportFinished):
* webkit/webkitwebplugin.cpp:
(webkit_web_plugin_get_mimetypes):
2012-08-27 Zan Dobersek <zandobersek@gmail.com>
[GTK] Memory cache should be cleared in between test runs
https://bugs.webkit.org/show_bug.cgi?id=95105
Reviewed by Martin Robinson.
Add a DumpRenderTreeSupportGtk helper method that clears the
memory cache when called.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearMemoryCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r126836.
http://trac.webkit.org/changeset/126836
https://bugs.webkit.org/show_bug.cgi?id=95163
Broke all Apple ports, EFL, and Qt. (Requested by tkent on
#webkit).
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::getPluginInfo):
* webkit/webkitfavicondatabase.cpp:
(webkitFaviconDatabaseImportFinished):
* webkit/webkitwebplugin.cpp:
(webkit_web_plugin_get_mimetypes):
2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::getPluginInfo):
* webkit/webkitfavicondatabase.cpp:
(webkitFaviconDatabaseImportFinished):
* webkit/webkitwebplugin.cpp:
(webkit_web_plugin_get_mimetypes):
2012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Rename RegisterProtocolHandler API to NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=94920
Reviewed by Adam Barth.
Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
RegisterProtocolHandlerClientGtk is renamed to NavigatorContentUtilsClientGtk.
* GNUmakefile.am:
* WebCoreSupport/NavigatorContentUtilsClientGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp.
(WebKit):
(WebKit::NavigatorContentUtilsClient::create):
(WebKit::NavigatorContentUtilsClient::NavigatorContentUtilsClient):
(WebKit::NavigatorContentUtilsClient::registerProtocolHandler):
* WebCoreSupport/NavigatorContentUtilsClientGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/RegisterProtocolHandlerClientGtk.h.
(WebKit):
(NavigatorContentUtilsClient):
(WebKit::NavigatorContentUtilsClient::~NavigatorContentUtilsClient):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
* webkit/webkitwebviewprivate.h:
2012-08-23 Carlos Garcia Campos <cgarcia@igalia.com>
REGRESSION(r126306): it broke the plugin process
https://bugs.webkit.org/show_bug.cgi?id=94797
Reviewed by Xan Lopez.
* GNUmakefile.am:
2012-08-22 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Crash when finalizing WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=94699
Reviewed by Martin Robinson.
Create the offscreen window the first time accelerated compositing
is enabled, so that if it's never enabled the window won't be
created.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::initialize):
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer):
2012-08-22 Gustavo Noronha Silva <gns@gnome.org>
[GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435
Reviewed by Martin Robinson.
More people have been reporting problems when linking WebCore because
the command line limit is being exceeded. Splitting WebCore a bit more
is in order.
* GNUmakefile.am: link libWebCorePlatform into libwebkitgtk
2012-08-22 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Preferred languages and spellchecker APIs are not consistent in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=94683
Reviewed by Alejandro G. Castro.
* webkit/webkitspellcheckerenchant.cpp:
(updateSpellCheckingLanguages): Split the languages string to pass a
Vector to updateSpellCheckingLanguages().
2012-08-21 Joanmarie Diggs <jdiggs@igalia.com>
[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811
Reviewed by Chris Fleizach.
Part of the bug is due to objects which should claim to implement AtkText
failed to do so as a result of containing a mixture of inline and block
spans.
An updated unit test was provided.
* tests/testatk.c:
(testWebkitAtkCaretOffsets): Added instances of objects containing a
mixture of inline and block spans and tested that they implement AtkText
and contain the right textual contents.
2012-08-21 Kihong Kwon <kihong.kwon@samsung.com>
[EFL][GTK][BlackBerry] Fix build error in the DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=94586
Reviewed by Kentaro Hara.
Fix build error in the DeviceOrientationClientGtk.cpp.
It is occured because DeviceOrientation is changed to DeviceOrientationData in the WebCore.
* WebCoreSupport/DeviceOrientationClientGtk.cpp:
(WebKit::DeviceOrientationClientGtk::lastOrientation):
2012-08-21 Martin Robinson <mrobinson@igalia.com>
[GTK] Using a native window for the WebView breaks GtkOverlay
https://bugs.webkit.org/show_bug.cgi?id=90085
Reviewed by Alejandro G. Castro.
Rewrite AcceleratedCompositingContext for TextureMapperGL to be more similar to
the WebKit2 LayerTreeHost and switch from rendering directly to the widget window
to a window redirected to a pixmap via XComposite. The AcceleratedCompositingContext
now handles painting the non-composited content itself and no longer relies on the
ChromeClient backing store.
This fixes issues with using GtkOverlay WebKitWebView as well as making it possible
to run pixel tests with accelerated compositing turned on.
* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
Rename some methods to make them more similar to LayerTreeHost. Now we wait to render
the OpenGL context to the window until the widget's draw signal. Escape out of all
methods early if accelerated compositing is disabled.
* WebCoreSupport/ChromeClientGtk.cpp: Always check if accelerated compositing is on
before calling into AcceleratedCompositingContext methods. When AC is on, never paint
the backing store, deferring immediately to the AcceleratedCompositingContext. When
AC is turned on the backing store now shrinks to a small size to save memory.
* webkit/webkitwebview.cpp:
(resizeWebViewFromAllocation): ChromeClient is now responsible for talking to the
AcceleratedCompositingContext directly.
(webkit_web_view_size_allocate): Exit early if the allocation is not a resize. This
makes some deeper logic a bit simpler and avoids accidentally doing too much work for
widget movement.
(webkit_web_view_realize): We no longer need a native window.
2012-08-15 Joanmarie Diggs <jdiggs@igalia.com>
[Gtk] atk_text_set_caret_offset() fails for table cells
https://bugs.webkit.org/show_bug.cgi?id=83501
Reviewed by Chris Fleizach.
Update unit test to include setting the caret in a table cell via the AtkText interface.
* tests/testatk.c:
(testWebkitAtkCaretOffsets): Add setting the caret inside the text of a table cell.
2012-08-15 Joanmarie Diggs <jdiggs@igalia.com>
[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for paragraphs in list items whose text wraps
https://bugs.webkit.org/show_bug.cgi?id=83435
Reviewed by Chris Fleizach.
Updated unit test to include a paragraph in a list item when testing atk_text_get_text_at_offset().
* tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters):
2012-08-14 Adam Barth <abarth@webkit.org>
Delete Frame::domWindow() and Frame::existingDOMWindow()
https://bugs.webkit.org/show_bug.cgi?id=93990
Reviewed by Eric Seidel.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getPendingUnloadEventCount):
2012-08-13 Tom Sepez <tsepez@chromium.org>
[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
https://bugs.webkit.org/show_bug.cgi?id=93283
Reviewed by Eric Seidel.
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::redirectDataToPlugin):
2012-08-13 Martin Robinson <mrobinson@igalia.com>
[GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
https://bugs.webkit.org/show_bug.cgi?id=93600
Reviewed by Xan Lopez.
Instead of using the default editing signal handler for ::should-show-delete-interface-for-element,
do not use a default signal handler. This means that the result of the signal defaults to FALSE,
which is the expected value to ensure that the delete interface is not shown.
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Do not install a default signal handler.
2012-08-13 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Implementation of atk_editable_text_insert_text ignores 'length' parameter
https://bugs.webkit.org/show_bug.cgi?id=93804
Reviewed by Carlos Garcia Campos.
Update unit tests to also check inserting a partial string.
* tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Update test.
2012-08-10 Alice Cheng <alice_cheng@apple.com>
Part 1 of: Extend -webkit-user-select with a new value "all"
<rdar://problem/10161404>
https://bugs.webkit.org/show_bug.cgi?id=93562
Reviewed by Dan Bernstein.
Modify the enum to resolve ambiguous reference
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init): Modify the ambiguous enum
(webkit_web_view_select_all): Modify the ambiguous enum
2012-08-10 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Broken implementation of AtkText and AtkEditableText for password fields
https://bugs.webkit.org/show_bug.cgi?id=93621
Reviewed by Chris Fleizach.
Update unit test to ensure that password input fields behave
as expected when inserting and removing characters in them.
* tests/testatk.c:
(testWebkitAtkTextChangedNotifications): Updated unit test to
cover the special case of password input fields.
2012-08-09 Carlos Garcia Campos <cgarcia@igalia.com>
Handle SSL errors for SOUP
https://bugs.webkit.org/show_bug.cgi?id=90267
Reviewed by Martin Robinson.
Ignore SSL errors by default for compatibility.
* webkit/webkitglobals.cpp:
(webkitInit):
2012-08-07 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix GTK+ build with GTK2 after r120918.
* tests/testwebview.c:
2012-08-06 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update NEWS and configure.ac for 1.9.6 release
* NEWS: Added release notes for 1.9.6.
2012-08-06 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL] [GTK] Register Protocol Handler Client is never deleted
https://bugs.webkit.org/show_bug.cgi?id=92745
Reviewed by Gustavo Noronha Silva.
Added usage of OwnPtr to manage register protocol handler client pointer.
* WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp:
(WebKit::RegisterProtocolHandlerClient::create): Factory function returning smart pointer.
(WebKit):
* WebCoreSupport/RegisterProtocolHandlerClientGtk.h:
(RegisterProtocolHandlerClient):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
* webkit/webkitwebviewprivate.h:
2012-08-03 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269
Reviewed by Martin Robinson.
Remove enchant specific code from WebKitSpellCheckerEnchant and
implement it relying in the new TextCheckerEnchant class in WebCore.
* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(checkSpellingOfString):
(getGuessesForWord):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):
2012-08-02 Claudio Saavedra <csaavedra@igalia.com>
[GTK] Add WebKitNetworkResponse::suggested-filename property
https://bugs.webkit.org/show_bug.cgi?id=92878
Reviewed by Carlos Garcia Campos.
Webcore has API the suggested filename for a response, add
a property and getter for it in WebKitNetworkResponse.
* docs/webkitgtk-sections.txt: Add the symbols
* webkit/webkitnetworkresponse.cpp:
(_WebKitNetworkResponsePrivate): Add suggested_filename.
(webkit_network_response_finalize): Free it on finalize
(webkit_network_response_get_property): Add the getter call.
(webkit_network_response_class_init): Install the property.
(webkit_network_response_get_suggested_filename): New getter.
* webkit/webkitnetworkresponse.h: Add the declaration to header
file.
2012-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r124207.
http://trac.webkit.org/changeset/124207
https://bugs.webkit.org/show_bug.cgi?id=92773
Patch causes crashes on the 64-bit debug builder (and other
builders likely) (Requested by zdobersek on #webkit).
* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):
2012-07-31 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269
Reviewed by Martin Robinson.
Remove enchant specific code from WebKitSpellCheckerEnchant and
implement it relying in the new TextCheckerEnchant class in WebCore.
* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(checkSpellingOfString):
(getGuessesForWord):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):
2012-07-30 Martin Robinson <mrobinson@igalia.com>
[GTK] New lines automatically and repeatedly added to list items in Etherpad
https://bugs.webkit.org/show_bug.cgi?id=89971
Reviewed by Ryosuke Niwa.
Disable the deletion UI by default. This UI, which was enabled as a side-effect
of the addition of the private editing API, seems to expose a bug in Etherpad
which causes the continuous insertion of bullet points.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldShowDeleteInterface): Disable the deletion UI by default.
2012-07-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r123966 and r123967.
http://trac.webkit.org/changeset/123966
http://trac.webkit.org/changeset/123967
https://bugs.webkit.org/show_bug.cgi?id=92656
This patch is causing assertion failures on the debug bot
(also rolling out a dependent patch) (Requested by mrobinson
on #webkit).
* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):
2012-07-30 Claudio Saavedra <csaavedra@igalia.com>
[Gtk] Add WK1 API for snapshot retrieval
https://bugs.webkit.org/show_bug.cgi?id=92261
Reviewed by Martin Robinson.
Add API to WebKitWebView to retrieve a snapshot of its
visible contents as a cairo_surface_t.
* docs/webkitgtk-sections.txt: Add new symbols.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_snapshot): New
method to paint a webview snapshot.
* webkit/webkitwebview.h: Ditto.
2012-07-28 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269
Reviewed by Martin Robinson.
Remove enchant specific code from WebKitSpellCheckerEnchant and
implement it relying in the new TextCheckerEnchant class in WebCore.
* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(checkSpellingOfString):
(getGuessesForWord):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):
2012-07-26 Kaustubh Atrawalkar <kaustubh@motorola.com>
[DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091
Reviewed by Adam Barth.
Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-07-24 Kaustubh Atrawalkar <kaustubh@motorola.com>
[DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091
Reviewed by Adam Barth.
Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-07-23 Pierre Rossi <pierre.rossi@gmail.com>
Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
https://bugs.webkit.org/show_bug.cgi?id=91006
Reviewed by Ryosuke Niwa.
Remove numTouchEventHandlersChanged stub.
* WebCoreSupport/ChromeClientGtk.h:
2012-07-17 Vivek Galatage <vivekgalatage@gmail.com>
Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
https://bugs.webkit.org/show_bug.cgi?id=91196
Reviewed by Pavel Feldman.
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend):
* WebCoreSupport/InspectorClientGtk.h:
(InspectorClient):
2012-07-16 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Add RegisterProtocolHandlerClient to the Modules/protocolhandler
https://bugs.webkit.org/show_bug.cgi?id=90940
Reviewed by Hajime Morita.
As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
In order to support this, RegisterProtocolHandlerClientGtk class is added and webview registers
RegisterProtocolHandlerClientGtk. In addition, existing concrete functions in ChromeClientGtk are moved
to RegisterProtocolHandlerClientGtk.
* GNUmakefile.am:
* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
* WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp: Added.
(WebKit):
(WebKit::RegisterProtocolHandlerClient::RegisterProtocolHandlerClient):
(WebKit::RegisterProtocolHandlerClient::registerProtocolHandler):
* WebCoreSupport/RegisterProtocolHandlerClientGtk.h: Added.
(WebKit):
(RegisterProtocolHandlerClient):
(WebKit::RegisterProtocolHandlerClient::~RegisterProtocolHandlerClient):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
2012-07-16 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update NEWS and configure.ac for 1.9.5 release
* NEWS: Added release notes for 1.9.5.
2012-07-10 Adam Barth <abarth@webkit.org>
WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=90910
Reviewed by Eric Seidel.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
2012-07-10 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[GTK] Fix memory leaks by adopting allocation of GdkPixbuf
https://bugs.webkit.org/show_bug.cgi?id=90790
Reviewed by Carlos Garcia Campos.
Fixed a memory leak in WebKitFaviconDatabase by adopting an
allocation of GdkPixbuf.
* webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):
2012-07-10 Adam Barth <abarth@webkit.org>
LayoutTestController.dumpConfigurationForViewport should move to Internals
https://bugs.webkit.org/show_bug.cgi?id=45652
Reviewed by Eric Seidel.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-07-09 Adam Klein <adamk@chromium.org>
Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver
https://bugs.webkit.org/show_bug.cgi?id=90810
Reviewed by Ojan Vafai.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):
2012-07-09 Zan Dobersek <zandobersek@gmail.com>
[Gtk] Implement dumpFrameScrollPosition in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=89356
Reviewed by Martin Robinson.
Add a new method for returning the WebKitDOMDocument that is loaded
in a given frame, webkit_web_frame_get_dom_document.
* docs/webkitgtk-sections.txt:
* webkit/webkitwebframe.cpp:
(webkit_web_frame_get_dom_document):
* webkit/webkitwebframe.h:
* webkit/webkitwebview.cpp: State explicitly that the document being returned
when calling webkit_web_view_get_dom_document is loaded in the main frame.
Also call the webkit_web_frame_get_dom_document on WebKitWebView's main frame
to get the document.
2012-07-09 Zan Dobersek <zandobersek@gmail.com>
[Gtk] Unskip the CSS Regions layout tests
https://bugs.webkit.org/show_bug.cgi?id=90771
Reviewed by Martin Robinson.
Add a method to DumpRenderTreeSupportGtk for enabling or disabling
CSS Regions from DumpRenderTree.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSRegionsEnabled):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-07-09 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[GTK] Memory leak in webkitwebnavigationaction.cpp
https://bugs.webkit.org/show_bug.cgi?id=90787
Reviewed by Martin Robinson.
Fixed a memory leak in WebKitWebNavigationAction.
* webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_finalize): Free the g_strdup()'d string.
2012-07-07 Zan Dobersek <zandobersek@gmail.com>
REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html failing on GTK Linux 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=90719
Reviewed by Martin Robinson.
Follow the approach of the BlackBerry port outlined in r122035, using in exitFullScreenForElement
the fullscreen element to which the reference was saved when enterFullScreenForElement was called.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::exitFullScreenForElement):
2012-07-02 Benjamin Poulain <bpoulain@apple.com>
Do not do any logging initialization when logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=90228
Reviewed by Simon Fraser.
* webkit/webkitglobals.cpp:
(webkitInit):
2012-06-29 Tony Chang <tony@chromium.org>
[GTK] Enable CSS grid layout LayoutTests on GTK+
https://bugs.webkit.org/show_bug.cgi?id=90226
Reviewed by Martin Robinson.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled): Pass through to Settings object.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-06-29 Konrad Piascik <kpiascik@rim.com>
Don't hardcode target dpi of 160 (it should be 96 on desktop)
https://bugs.webkit.org/show_bug.cgi?id=88114
Reviewed by Adam Barth.
Updated the call to computeViewportAttributes.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
* webkit/webkitviewportattributes.cpp:
(webkitViewportAttributesRecompute):
2012-06-25 Mark Hahnenberg <mhahnenberg@apple.com>
JSLock should be per-JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=89123
Reviewed by Geoffrey Garen.
Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::gcCountJavascriptObjects):
2012-06-27 Martin Robinson <mrobinson@igalia.com>
[gtk] Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118
Reviewed by Gustavo Noronha Silva.
Work-around a bug in Pango by trying to detect apostrophes
that create contractions. This work-around is similar to one
found in gtkspell.
* webkit/webkitspellcheckerenchant.cpp:
(wordEndIsAContractionApostrophe): Added this helper which tries to detect
situations where a word end is both an apostrophe and followed by a alphabetic
character.
(checkSpellingOfString): When searching for the end of a word, skip over
apostrophes that appear to be part of contractions.
2012-06-27 Zan Dobersek <zandobersek@gmail.com>
[Gtk] Add support for the Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=87503
Reviewed by Carlos Garcia Campos.
Add the Gamepad feature dependencies libraries to the LIBADD
list for the libwebkitgtk library.
* GNUmakefile.am:
2012-06-25 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update NEWS and configure.ac for 1.9.4 release
* NEWS: Added release notes for 1.9.4.
2012-06-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r121058.
http://trac.webkit.org/changeset/121058
https://bugs.webkit.org/show_bug.cgi?id=89809
Patch causes plugins tests to crash in GTK debug builds
(Requested by zdobersek on #webkit).
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::gcCountJavascriptObjects):
2012-06-20 Mark Hahnenberg <mhahnenberg@apple.com>
JSLock should be per-JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=89123
Reviewed by Gavin Barraclough.
Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::gcCountJavascriptObjects):
2012-06-22 Amy Ousterhout <aousterh@chromium.org>
Renamed DeviceOrientation to DeviceOrientationData
https://bugs.webkit.org/show_bug.cgi?id=88663
Reviewed by Steve Block.
Updated files to use the renamed DeviceOrientationData instead of DeviceOrientation.
This change makes DeviceOrientationData consistent with DeviceMotionData.
* WebCoreSupport/DeviceOrientationClientGtk.h:
(DeviceOrientationClientGtk):
2012-06-21 Daniel Drake <dsd@laptop.org>
[GTK] Backport run-file-chooser to WebKit1
https://bugs.webkit.org/show_bug.cgi?id=87283
Reviewed by Gustavo Noronha Silva.
This is a relatively straightforward backport of Mario Sanchez
Prada's WebKit2 run-file-chooser signal work, intended for use by
OLPC and others who are not quite ready to move to WebKit2.
Add a new public class to the API, WebKitFileChooserRequest, to be
emitted along with a new WebKitWebView::run-file-chooser signal to
let client applications to provide their own file chooser dialog
when the use interacts with HTML Input elements of type 'file'.
* GNUmakefile.am: Added new source files and headers.
* webkit/webkitfilechooserrequest.cpp: Added.
(_WebKitFileChooserRequestPrivate):
(webkit_file_chooser_request_init):
(webkit_file_chooser_request_finalize):
(webkit_file_chooser_request_get_property):
(webkit_file_chooser_request_class_init):
(webkit_file_chooser_request_create):
(webkit_file_chooser_request_get_mime_types):
(webkit_file_chooser_request_get_mime_types_filter):
(webkit_file_chooser_request_get_select_multiple):
(webkit_file_chooser_request_select_files):
(webkit_file_chooser_request_get_selected_files):
* webkit/webkitfilechooserrequest.h: Added.
(_WebKitFileChooserRequest):
(_WebKitFileChooserRequestClass):
* webkit/webkitfilechooserrequestprivate.h: Added,
containing the prototype of webkit_file_chooser_request_create.
Provide private API to make a file chooser request from the
WebView, and provide a default handler for it.
* webkit/webkitwebview.cpp:
(fileChooserDialogResponseCallback): Handler for the 'response'
signal for the GtkFileChooserDialog used in the default
handler. It will call to webkit_file_chooser_request_select_files
or webkit_file_chooser_request_cancel as needed.
(webkitWebViewRealRunFileChooser): Default handler for the new
'run-file-chooser' signal. It will create a GtkFileChooserDialog,
connect to the 'response' signal and show it.
(webkit_web_view_class_init): Connect the 'run-file-chooser'
signal to the default handler, webkitWebViewRunFileChooser.
(webkit_web_view_new):
(webkitWebViewRunFileChooserRequest):
* webkit/webkitwebview.h:
(_WebKitWebViewClass): Added prototype for the handler of the new
'run-file-chooser' signal.
* webkit/webkitwebviewprivate.h: Added prototype for
private new function webkitWebViewRunFileChooserRequest.
Update runOpenPanel to use the new API, including a default handler
with similar behaviour to before.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::runOpenPanel): Now creates an instance of
WebKitFileChooserRequest and asks the WebView to emit the
new 'run-file-chooser' signal with it.
Added the new public header to the main header.
* webkit/webkit.h: Added webkitfilechooserrequest.h
New unit tests for the new WebKitFileChooserRequest API.
* tests/testwebview.c: Various WebKitFileChooserRequest tests,
including MIME type filtering and selection handling.
Updated documentation related files with the new API.
* docs/webkitgtk-docs.sgml: Added new section.
* docs/webkitgtk-sections.txt: Added new API.
* docs/webkitgtk.types: Added get_type function.
2012-06-19 Chang Wan Hong <jourmoon@company100.net>
Refine syncLayersTimeoutCallback for Accelerated Compositing.
https://bugs.webkit.org/show_bug.cgi?id=89538
Reviewed by Martin Robinson.
syncLayersTimeout reschedules the timer so that it can render each frame
every 1/60 seconds on animation. However, because it takes to time to execute
renderLayersToWindow, the timer is delayed. To fix this, we must reschedule
the timer before calling renderLayersToWindow.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):
2012-06-19 Sergio Villar Senin <svillar@igalia.com>
Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
https://bugs.webkit.org/show_bug.cgi?id=67582
Reviewed by David Levin.
Use synchronousNativeIconForPageURL() to retrieve favicons.
* webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):
2012-06-18 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
https://bugs.webkit.org/show_bug.cgi?id=89226
Reviewed by Martin Robinson.
Remove unnecesary functions incrementAccessibilityValue() and
decrementAccessibilityValue() from DumpRenderTreeSupportGtk.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-06-14 Alejandro G. Castro <alex@igalia.com>
[GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path
https://bugs.webkit.org/show_bug.cgi?id=73634
Add the new graphics layer client that uses cairo to render the
composition. The cairo transformations do not support perspective
so in perspective cases we have just a representation not the real
perspective transformation.
This patch adds a new implementation of already tested cases.
Reviewed by Martin Robinson.
* GNUmakefile.am:
* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Added.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::invalidateWidgetRect): We need to
invalidate the widget in this case because we do not directly
render to a texture but to the widget surface.
(WebKit::ChromeClient::paint): We can not render here, we have to
invalidate and wait for the widget rendering.
* webkit/webkitwebview.cpp:
(webkit_web_view_draw): In this case the renderLayersToWindow
requires the graphics context used to render in the window.
(webkit_web_view_realize): Small cleanup of the priv variable
definition.
2012-06-14 Zan Dobersek <zandobersek@gmail.com>
[Gtk] Add support in DumpRenderTree for tracking repaints
https://bugs.webkit.org/show_bug.cgi?id=87658
Reviewed by Martin Robinson.
Add methods to the DumpRenderTreeSupport class for controlling the
status of repaint tracking along with retreiving and resetting the
tracked repaints.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setTracksRepaints):
(DumpRenderTreeSupportGtk::isTrackingRepaints):
(DumpRenderTreeSupportGtk::trackedRepaintRects):
(DumpRenderTreeSupportGtk::resetTrackedRepaints):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-06-13 Amy Ousterhout <aousterh@chromium.org>
Rename currentDeviceMotion to lastMotion in DeviceMotionClient
https://bugs.webkit.org/show_bug.cgi?id=88854
Reviewed by Adam Barth.
Rename the function currentDeviceMotion to lastMotion in DeviceMotionClient.
This makes it consistent with the similar function lastOrientation in DeviceOrientationClient.
* WebCoreSupport/DeviceMotionClientGtk.cpp:
(WebKit::DeviceMotionClientGtk::lastMotion):
* WebCoreSupport/DeviceMotionClientGtk.h:
(DeviceMotionClientGtk):
2012-06-11 Kaustubh Atrawalkar <kaustubh@motorola.com>
[DRT] LTC:: counterValueForElementById() could be moved to Internals.
https://bugs.webkit.org/show_bug.cgi?id=84406
Reviewed by Hajime Morita.
Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
2012-06-07 Simon Pena <spena@igalia.com>
[GTK] deviceScaleFactor setting is not honored
https://bugs.webkit.org/show_bug.cgi?id=88511
Reviewed by Gustavo Noronha Silva.
Honor the deviceScaleFactor property in the paintWebView
method of the ChromeClientGtk.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::paintWebView):
2012-06-04 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[GTK] Memory leak in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=88214
Reviewed by Martin Robinson.
Fixed a memory leak in WebKitWebView by making
GeolocationClientMock to be owned by the WebView.
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
* webkit/webkitwebviewprivate.h:
2012-06-04 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update NEWS and configure.ac for 1.9.3 release
* NEWS: Added release notes for 1.9.3.
2012-06-04 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Remove geoclue dependency from WebKit API Layer
https://bugs.webkit.org/show_bug.cgi?id=87801
Reviewed by Martin Robinson.
Make GeolocationClient for WebKitGTK+ use the new Geoclue-based
geolocation provider available in WebCore.
* WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit):
(WebKit::GeolocationClient::GeolocationClient):
(WebKit::GeolocationClient::startUpdating):
(WebKit::GeolocationClient::stopUpdating):
(WebKit::GeolocationClient::setEnableHighAccuracy):
(WebKit::GeolocationClient::notifyPositionChanged):
(WebKit::GeolocationClient::notifyErrorOccurred):
* WebCoreSupport/GeolocationClientGtk.h:
(GeolocationClient):
2012-05-31 Hajime Morrita <morrita@chromium.org>
REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
https://bugs.webkit.org/show_bug.cgi?id=86859
Reviewed by Ryosuke Niwa.
* WebCoreSupport/TextCheckerClientGtk.h:
(WebKit::TextCheckerClientGtk::requestCheckingOfString):
2012-05-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r119113.
http://trac.webkit.org/changeset/119113
https://bugs.webkit.org/show_bug.cgi?id=88016
This caused multiple regressions (Requested by mrobinson on
#webkit).
* WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::checkSpellingOfString):
* webkit/webkitspellcheckerenchant.cpp:
(checkSpellingOfString):
2012-05-31 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[GTK] Memory leak in webkit_web_view_init
https://bugs.webkit.org/show_bug.cgi?id=87943
Reviewed by Martin Robinson.
Fixed a memory leak in webkit_web_view_init by making the
UserMediaClientGtk to be owned by the WebView.
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
* webkit/webkitwebviewprivate.h:
2012-05-31 Martin Robinson <mrobinson@igalia.com>
Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118
Reviewed by Gustavo Noronha Silva.
The Enchant spell checker was breaking words on apostrophes, because
apparently they were always being detected as Pango word-end
characters. To know whether or not the apostrophe is a
word end character requires looking at a string with a larger
granularity than one character.
Simplify the way the we break strings, by search for non-graphable
character manually to find word starts and ends. This has the side
effect of removing the dependency on Pango and eliminating one copy.
This change also cleans up some misbehavior on the part of the
WebCoreSupport layer which was not converting from Unicode character
offsets to UTF-16. These offsets can be different if any of the
characters in the UTF-16 string are surrogate pairs (non BMP
characters).
* WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::checkSpellingOfString): Properly
convert from Unicode offsets to UTF-16 offsets.
* webkit/webkitspellcheckerenchant.cpp:
(findByteOffsetToFirstNonGraphableCharacter): Added this helper.
(getExtentsOfNextWord): Ditto.
(wordIsSpelledCorrectlyInAtLeastOneDictionary): Ditto.
(checkSpellingOfString): Don't split words on apostrophes.
2012-05-30 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
https://bugs.webkit.org/show_bug.cgi?id=87756
Reviewed by Carlos Garcia Campos.
Fixed a memory leak in drag and drop by using adoptRef instead
of just getting a new reference of targetList.
* WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag):
2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42328
Reviewed by Eric Seidel.
* webkit/webkitwebinspector.cpp:
(webkit_web_inspector_set_property):
2012-05-25 Lu Guanqun <guanqun.lu@intel.com>
[GTK] fix compilation for webkitwebview.cpp
https://bugs.webkit.org/show_bug.cgi?id=87473
Reviewed by Martin Robinson.
When ACCELERATED_COMPOSITING and TEXTURE_MAPPER_GL is not set,
the local variable 'priv' won't be used. Therefore the following warning:
../../../Source/WebKit/gtk/webkit/webkitwebview.cpp: In function ‘void webkit_web_view_realize(GtkWidget*)’:
../../../Source/WebKit/gtk/webkit/webkitwebview.cpp:971:27: warning: unused variable ‘priv’ [-Wunused-variable]
* webkit/webkitwebview.cpp:
(webkit_web_view_realize):
== Rolled over to ChangeLog-2012-05-22 ==
|