1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376
|
# SPDX-FileCopyrightText: Ryan Roden-Corrent (rcorre) <ryan@rcorre.net>
#
# SPDX-License-Identifier: GPL-3.0-or-later
"""Tests for the CompletionView Object."""
from unittest import mock
import pytest
from qutebrowser.qt.core import QRect, QItemSelectionModel
from qutebrowser.completion import completionwidget
from qutebrowser.completion.models import completionmodel, listcategory
from qutebrowser.api import cmdutils
@pytest.fixture
def completionview(qtbot, status_command_stub, config_stub, win_registry,
mocker):
"""Create the CompletionView used for testing."""
# mock the Completer that the widget creates in its constructor
mocker.patch('qutebrowser.completion.completer.Completer', autospec=True)
mocker.patch(
'qutebrowser.completion.completiondelegate.CompletionItemDelegate',
return_value=None)
view = completionwidget.CompletionView(cmd=status_command_stub, win_id=0)
qtbot.add_widget(view)
return view
@pytest.fixture
def model():
return completionmodel.CompletionModel()
def test_set_model(completionview, model):
"""Ensure set_model actually sets the model and expands all categories."""
for _i in range(3):
model.add_category(listcategory.ListCategory('', [('foo',)]))
completionview.set_model(model)
assert completionview.model() is model
for i in range(3):
assert completionview.isExpanded(model.index(i, 0))
def test_set_pattern(completionview, model):
model.set_pattern = mock.Mock(spec=[])
completionview.set_model(model)
completionview.set_pattern('foo')
model.set_pattern.assert_called_with('foo')
assert not completionview.selectionModel().currentIndex().isValid()
def test_set_pattern_no_model(completionview):
"""Ensure that setting a pattern with no model does not fail."""
completionview.set_pattern('foo')
def test_maybe_update_geometry(completionview, config_stub, qtbot):
"""Ensure completion is resized only if shrink is True."""
with qtbot.assert_not_emitted(completionview.update_geometry):
completionview._maybe_update_geometry()
config_stub.val.completion.shrink = True
with qtbot.wait_signal(completionview.update_geometry):
completionview._maybe_update_geometry()
@pytest.mark.parametrize('which, tree, expected', [
('next', [['Aa']], ['Aa', None, None]),
('prev', [['Aa']], ['Aa', None, None]),
('next', [['Aa'], ['Ba']], ['Aa', 'Ba', 'Aa']),
('prev', [['Aa'], ['Ba']], ['Ba', 'Aa', 'Ba']),
('next', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']],
['Aa', 'Ab', 'Ac', 'Ba', 'Bb', 'Ca', 'Aa']),
('prev', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']],
['Ca', 'Bb', 'Ba', 'Ac', 'Ab', 'Aa', 'Ca']),
('next', [[], ['Ba', 'Bb']], ['Ba', 'Bb', 'Ba']),
('prev', [[], ['Ba', 'Bb']], ['Bb', 'Ba', 'Bb']),
('next', [[], [], ['Ca', 'Cb']], ['Ca', 'Cb', 'Ca']),
('prev', [[], [], ['Ca', 'Cb']], ['Cb', 'Ca', 'Cb']),
('next', [['Aa'], []], ['Aa', None]),
('prev', [['Aa'], []], ['Aa', None]),
('next', [['Aa'], [], []], ['Aa', None]),
('prev', [['Aa'], [], []], ['Aa', None]),
('next', [['Aa'], [], ['Ca', 'Cb']], ['Aa', 'Ca', 'Cb', 'Aa']),
('prev', [['Aa'], [], ['Ca', 'Cb']], ['Cb', 'Ca', 'Aa', 'Cb']),
('next', [[]], [None, None]),
('prev', [[]], [None, None]),
('next-category', [['Aa']], ['Aa', None, None]),
('prev-category', [['Aa']], ['Aa', None, None]),
('next-category', [['Aa'], ['Ba']], ['Aa', 'Ba', 'Aa']),
('prev-category', [['Aa'], ['Ba']], ['Ba', 'Aa', 'Ba']),
('next-category', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']],
['Aa', 'Ba', 'Ca', 'Aa']),
('prev-category', [['Aa', 'Ab', 'Ac'], ['Ba', 'Bb'], ['Ca']],
['Ca', 'Ba', 'Aa', 'Ca']),
('next-category', [[], ['Ba', 'Bb']], ['Ba', None, None]),
('prev-category', [[], ['Ba', 'Bb']], ['Ba', None, None]),
('next-category', [[], [], ['Ca', 'Cb']], ['Ca', None, None]),
('prev-category', [[], [], ['Ca', 'Cb']], ['Ca', None, None]),
('next-category', [['Aa'], [], []], ['Aa', None, None]),
('prev-category', [['Aa'], [], []], ['Aa', None, None]),
('next-category', [['Aa'], [], ['Ca', 'Cb']], ['Aa', 'Ca', 'Aa']),
('prev-category', [['Aa'], [], ['Ca', 'Cb']], ['Ca', 'Aa', 'Ca']),
('next-category', [[]], [None, None]),
('prev-category', [[]], [None, None]),
])
def test_completion_item_focus(which, tree, expected, completionview, model, qtbot):
"""Test that on_next_prev_item moves the selection properly.
Args:
which: the direction in which to move the selection.
tree: Each list represents a completion category, with each string
being an item under that category.
expected: expected argument from on_selection_changed for each
successive movement. None implies no signal should be
emitted.
"""
for catdata in tree:
cat = listcategory.ListCategory('', ((x,) for x in catdata))
model.add_category(cat)
completionview.set_model(model)
for entry in expected:
if entry is None:
with qtbot.assert_not_emitted(completionview.selection_changed):
completionview.completion_item_focus(which)
else:
with qtbot.wait_signal(completionview.selection_changed) as sig:
completionview.completion_item_focus(which)
assert sig.args == [entry]
@pytest.mark.parametrize('which', ['next', 'prev',
'next-category', 'prev-category',
'next-page', 'prev-page'])
def test_completion_item_focus_no_model(which, completionview, model, qtbot):
"""Test that selectionChanged is not fired when the model is None.
Validates #1812: help completion repeatedly completes
"""
with qtbot.assert_not_emitted(completionview.selection_changed):
completionview.completion_item_focus(which)
completionview.set_model(model)
completionview.set_model(None)
with qtbot.assert_not_emitted(completionview.selection_changed):
completionview.completion_item_focus(which)
def test_models_deleted_on_clear(completionview, model, qtbot):
"""Ensure set_model(None) deleted the model and selmodel."""
completionview.set_model(model)
selmod = completionview._selection_model()
completionview.set_model(None)
with qtbot.wait_signal(model.destroyed):
pass
with qtbot.wait_signal(selmod.destroyed):
pass
@pytest.mark.skip("Seems to disagree with reality, see #5897")
def test_completion_item_focus_fetch(completionview, model, qtbot):
"""Test that on_next_prev_item moves the selection properly."""
cat = mock.Mock(spec=[
'layoutChanged', 'layoutAboutToBeChanged', 'canFetchMore',
'fetchMore', 'rowCount', 'index', 'data'])
cat.canFetchMore = lambda *_: True
cat.rowCount = lambda *_: 2
cat.fetchMore = mock.Mock()
model.add_category(cat)
completionview.set_model(model)
# clear the fetchMore call that happens on set_model
cat.reset_mock()
# not at end, fetchMore shouldn't be called
completionview.completion_item_focus('next')
assert not cat.fetchMore.called
# at end, fetchMore should be called
completionview.completion_item_focus('next')
assert cat.fetchMore.called
class TestCompletionItemFocusPage:
"""Test :completion-item-focus with prev-page/next-page."""
@pytest.fixture(autouse=True)
def patch_heights(self, monkeypatch, completionview):
"""Patch the item/widget heights so that 10 items are always visible."""
monkeypatch.setattr(completionview, 'visualRect',
lambda _idx: QRect(0, 0, 100, 20))
monkeypatch.setattr(completionview, 'height', lambda: 200)
@pytest.mark.parametrize('which, expected', [
('prev-page', 'Last Item'),
('next-page', 'First Item'),
])
def test_no_selection(self, qtbot, completionview, model, which, expected):
"""With no selection, the first/last item should be selected."""
items = [("First Item",), ("Middle Item",), ("Last Item",)]
cat = listcategory.ListCategory('Test', items)
model.add_category(cat)
completionview.set_model(model)
with qtbot.wait_signal(completionview.selection_changed) as blocker:
completionview.completion_item_focus(which)
assert blocker.args == [expected]
@pytest.mark.parametrize('steps', [
# Select first item and go down
[('next', 'Item 1'), ('next-page', 'Item 10')],
# Go down twice
[('next', 'Item 1'), ('next-page', 'Item 10'), ('next-page', 'Item 19')],
# Last item via Page Down
[('next', 'Item 1'),
('next-page', 'Item 10'),
('next-page', 'Item 19'),
('next-page', 'Item 24')],
# Wrapping around via Page Down
[('next', 'Item 1'),
('next-page', 'Item 10'),
('next-page', 'Item 19'),
('next-page', 'Item 24'),
('next-page', 'Item 1')],
# Select last item and go up
[('prev', 'Item 24'), ('prev-page', 'Item 15')],
# Go up twice
[('prev', 'Item 24'), ('prev-page', 'Item 15'), ('prev-page', 'Item 6')],
# Last item via Page Up
[('prev', 'Item 24'),
('prev-page', 'Item 15'),
('prev-page', 'Item 6'),
('prev-page', 'Item 1')],
# Wrapping around via Page Up
[('prev', 'Item 24'),
('prev-page', 'Item 15'),
('prev-page', 'Item 6'),
('prev-page', 'Item 1'),
('prev-page', 'Item 24')],
])
def test_steps(self, completionview, qtbot, model, steps):
items = [("Item {}".format(i),) for i in range(1, 25)]
cat = listcategory.ListCategory('Test', items)
model.add_category(cat)
completionview.set_model(model)
for move, item in steps:
print('{:9} -> expecting {}'.format(move, item))
with qtbot.wait_signal(completionview.selection_changed) as blocker:
completionview.completion_item_focus(move)
assert blocker.args == [item]
def test_category_headers(self, completionview, qtbot, model):
for name, items in [
("First", [("Item {}".format(i),) for i in range(1, 9)]),
("Second", []),
("Third", [("Target item",)])]:
cat = listcategory.ListCategory(name, items)
model.add_category(cat)
completionview.set_model(model)
for move, item in [('next', 'Item 1'), ('next-page', 'Target item')]:
with qtbot.wait_signal(completionview.selection_changed) as blocker:
completionview.completion_item_focus(move)
assert blocker.args == [item]
@pytest.mark.parametrize('show', ['always', 'auto', 'never'])
@pytest.mark.parametrize('rows', [[], ['Aa'], ['Aa', 'Bb']])
@pytest.mark.parametrize('quick_complete', [True, False])
def test_completion_show(show, rows, quick_complete, completionview, model,
config_stub):
"""Test that the completion widget is shown at appropriate times.
Args:
show: The completion show config setting.
rows: Each entry represents a completion category with only one item.
quick_complete: The `completion.quick` config setting.
"""
config_stub.val.completion.show = show
config_stub.val.completion.quick = quick_complete
for name in rows:
cat = listcategory.ListCategory('', [(name,)])
model.add_category(cat)
assert not completionview.isVisible()
completionview.set_model(model)
assert completionview.isVisible() == (show == 'always' and len(rows) > 0)
completionview.completion_item_focus('next')
expected = (show != 'never' and len(rows) > 0 and
not (quick_complete and len(rows) == 1))
assert completionview.isVisible() == expected
completionview.set_model(None)
completionview.completion_item_focus('next')
assert not completionview.isVisible()
def test_completion_selection_clear_no_model(completionview):
completionview.show()
completionview.on_clear_completion_selection()
assert completionview.isVisible() is False
def test_completion_selection_clear_with_model(completionview, mocker):
selmod = mock.Mock(spec=QItemSelectionModel)
mocker.patch.object(completionview, "selectionModel", return_value=selmod)
completionview.show()
completionview.on_clear_completion_selection()
assert completionview.isVisible() is False
selmod.clearSelection.assert_called_once()
selmod.clearCurrentIndex.assert_called_once()
def test_completion_item_del(completionview, model):
"""Test that completion_item_del invokes delete_cur_item in the model."""
func = mock.Mock(spec=[])
cat = listcategory.ListCategory('', [('foo', 'bar')], delete_func=func)
model.add_category(cat)
completionview.set_model(model)
completionview.completion_item_focus('next')
completionview.completion_item_del()
func.assert_called_once_with(['foo', 'bar'])
def test_completion_item_del_no_selection(completionview, model):
"""Test that completion_item_del with an invalid index."""
func = mock.Mock(spec=[])
cat = listcategory.ListCategory('', [('foo',)], delete_func=func)
model.add_category(cat)
completionview.set_model(model)
with pytest.raises(cmdutils.CommandError, match='No item selected!'):
completionview.completion_item_del()
func.assert_not_called()
@pytest.mark.parametrize('sel', [True, False])
def test_completion_item_yank(completionview, model, mocker, sel):
"""Test that completion_item_yank invokes delete_cur_item in the model."""
m = mocker.patch(
'qutebrowser.completion.completionwidget.utils',
autospec=True)
cat = listcategory.ListCategory('', [('foo', 'bar')])
model.add_category(cat)
completionview.set_model(model)
completionview.completion_item_focus('next')
completionview.completion_item_yank(sel)
m.set_clipboard.assert_called_once_with('foo', sel)
@pytest.mark.parametrize('sel', [True, False])
def test_completion_item_yank_selected(completionview, model,
status_command_stub, mocker, sel):
"""Test that completion_item_yank yanks selected text."""
m = mocker.patch(
'qutebrowser.completion.completionwidget.utils',
autospec=True)
cat = listcategory.ListCategory('', [('foo', 'bar')])
model.add_category(cat)
completionview.set_model(model)
completionview.completion_item_focus('next')
status_command_stub.selectedText = mock.Mock(return_value='something')
completionview.completion_item_yank(sel)
m.set_clipboard.assert_called_once_with('something', sel)
def test_resize_no_model(completionview, qtbot):
"""Ensure no crash if resizeEvent is triggered with no model (#2854)."""
completionview.resizeEvent(None)
|