1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
|
# SPDX-FileCopyrightText: Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# SPDX-License-Identifier: GPL-3.0-or-later
import contextlib
import pytest
from qutebrowser.qt.core import Qt
from qutebrowser.mainwindow import messageview
from qutebrowser.utils import usertypes, message
@pytest.fixture
def view(qtbot, config_stub):
config_stub.val.messages.timeout = 100
mv = messageview.MessageView()
qtbot.add_widget(mv)
return mv
@pytest.mark.parametrize('level', [usertypes.MessageLevel.info,
usertypes.MessageLevel.warning,
usertypes.MessageLevel.error])
@pytest.mark.flaky # on macOS
def test_single_message(qtbot, view, level):
with qtbot.wait_exposed(view, timeout=5000):
view.show_message(message.MessageInfo(level, 'test'))
assert view._messages[0].isVisible()
def test_message_hiding(qtbot, view):
"""Messages should be hidden after the timer times out."""
with qtbot.wait_signal(view._clear_timer.timeout):
view.show_message(message.MessageInfo(usertypes.MessageLevel.info, 'test'))
assert not view._messages
def test_size_hint(view):
"""The message height should increase with more messages."""
view.show_message(message.MessageInfo(usertypes.MessageLevel.info, 'test1'))
height1 = view.sizeHint().height()
assert height1 > 0
view.show_message(message.MessageInfo(usertypes.MessageLevel.info, 'test2'))
height2 = view.sizeHint().height()
assert height2 == height1 * 2
def test_word_wrap(view, qtbot):
"""A long message should be wrapped."""
with qtbot.wait_signal(view._clear_timer.timeout):
view.show_message(message.MessageInfo(usertypes.MessageLevel.info, 'short'))
assert len(view._messages) == 1
height1 = view.sizeHint().height()
assert height1 > 0
text = ("Athene, the bright-eyed goddess, answered him at once: Father of "
"us all, Son of Cronos, Highest King, clearly that man deserved to be "
"destroyed: so let all be destroyed who act as he did. But my heart aches "
"for Odysseus, wise but ill fated, who suffers far from his friends on an "
"island deep in the sea.")
view.show_message(message.MessageInfo(usertypes.MessageLevel.info, text))
assert len(view._messages) == 1
height2 = view.sizeHint().height()
assert height2 > height1
assert view._messages[0].wordWrap()
@pytest.mark.parametrize("rich, higher, expected_format", [
(True, True, Qt.TextFormat.RichText),
(False, False, Qt.TextFormat.PlainText),
(None, False, Qt.TextFormat.PlainText),
])
@pytest.mark.parametrize("replace", ["test", None])
def test_rich_text(view, qtbot, rich, higher, expected_format, replace):
"""Rich text should be rendered appropriately.
This makes sure the title has been rendered as plain text by comparing the
heights of the two widgets. To ensure consistent results, we disable word-wrapping.
"""
level = usertypes.MessageLevel.info
text = 'with <h1>markup</h1>'
text2 = 'with <h1>markup</h1> 2'
info1 = message.MessageInfo(level, text, replace=replace)
info2 = message.MessageInfo(level, text2, replace=replace, rich=rich)
ctx = (
qtbot.wait_signal(view._clear_timer.timeout) if replace is None
else contextlib.nullcontext()
)
with ctx:
view.show_message(info1)
assert len(view._messages) == 1
view._messages[0].setWordWrap(False)
height1 = view.sizeHint().height()
assert height1 > 0
assert view._messages[0].textFormat() == Qt.TextFormat.PlainText # default
view.show_message(info2)
assert len(view._messages) == 1
view._messages[0].setWordWrap(False)
height2 = view.sizeHint().height()
assert height2 > 0
assert view._messages[0].textFormat() == expected_format
if higher:
assert height2 > height1
else:
assert height2 == height1
@pytest.mark.parametrize("info1, info2, count", [
# same
(
message.MessageInfo(usertypes.MessageLevel.info, 'test'),
message.MessageInfo(usertypes.MessageLevel.info, 'test'),
1,
),
# different text
(
message.MessageInfo(usertypes.MessageLevel.info, 'test'),
message.MessageInfo(usertypes.MessageLevel.info, 'test2'),
2,
),
# different level
(
message.MessageInfo(usertypes.MessageLevel.info, 'test'),
message.MessageInfo(usertypes.MessageLevel.error, 'test'),
2,
),
# different rich text
(
message.MessageInfo(usertypes.MessageLevel.info, 'test', rich=True),
message.MessageInfo(usertypes.MessageLevel.info, 'test', rich=False),
2,
),
# different replaces
(
message.MessageInfo(usertypes.MessageLevel.info, 'test'),
message.MessageInfo(usertypes.MessageLevel.info, 'test', replace='test'),
2,
),
])
def test_show_message_twice(view, info1, info2, count):
"""Show the exact same message twice -> only one should be shown."""
view.show_message(info1)
view.show_message(info2)
assert len(view._messages) == count
def test_show_message_twice_after_first_disappears(qtbot, view):
"""Show the same message twice after the first is gone."""
with qtbot.wait_signal(view._clear_timer.timeout):
view.show_message(message.MessageInfo(usertypes.MessageLevel.info, 'test'))
# Just a sanity check
assert not view._messages
view.show_message(message.MessageInfo(usertypes.MessageLevel.info, 'test'))
assert len(view._messages) == 1
def test_changing_timer_with_messages_shown(qtbot, view, config_stub):
"""When we change messages.timeout, the timer should be restarted."""
config_stub.val.messages.timeout = 900000 # 15s
view.show_message(message.MessageInfo(usertypes.MessageLevel.info, 'test'))
with qtbot.wait_signal(view._clear_timer.timeout):
config_stub.val.messages.timeout = 100
@pytest.mark.parametrize('count, expected', [(1, 100), (3, 300),
(5, 500), (7, 500)])
def test_show_multiple_messages_longer(view, count, expected):
"""When there are multiple messages, messages should be shown longer.
There is an upper maximum to avoid messages never disappearing.
"""
for message_number in range(1, count+1):
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, f"test {message_number}"))
assert view._clear_timer.interval() == expected
@pytest.mark.parametrize('replace1, replace2, length', [
(None, None, 2), # Two stacked messages
('testid', 'testid', 1), # Two replaceable messages
(None, 'testid', 2), # Stacked and replaceable
('testid', None, 2), # Replaceable and stacked
('testid1', 'testid2', 2), # Different IDs
])
def test_replaced_messages(view, replace1, replace2, length):
"""Show two stack=False messages which should replace each other."""
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test', replace=replace1))
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test 2', replace=replace2))
assert len(view._messages) == length
def test_replacing_different_severity(view):
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test', replace='testid'))
with pytest.raises(AssertionError):
view.show_message(message.MessageInfo(
usertypes.MessageLevel.error, 'test 2', replace='testid'))
def test_replacing_changed_text(view):
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test', replace='testid'))
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test 2'))
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test 3', replace='testid'))
assert len(view._messages) == 2
assert view._messages[0].text() == 'test 3'
assert view._messages[1].text() == 'test 2'
def test_replacing_geometry(qtbot, view):
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test', replace='testid'))
with qtbot.wait_signal(view.update_geometry):
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test 2', replace='testid'))
@pytest.mark.parametrize('button, count', [
(Qt.MouseButton.LeftButton, 0),
(Qt.MouseButton.MiddleButton, 0),
(Qt.MouseButton.RightButton, 0),
(Qt.MouseButton.BackButton, 2),
])
def test_click_messages(qtbot, view, button, count):
"""Messages should disappear when we click on them."""
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test mouse click'))
view.show_message(message.MessageInfo(
usertypes.MessageLevel.info, 'test mouse click 2'))
qtbot.mousePress(view, button)
assert len(view._messages) == count
|
