1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358
|
# SPDX-FileCopyrightText: Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# SPDX-License-Identifier: GPL-3.0-or-later
"""Tests for qutebrowser.utils.log."""
import logging
import argparse
import itertools
import sys
import warnings
import pytest
import _pytest.logging # pylint: disable=import-private-name
from qutebrowser import qutebrowser
from qutebrowser.utils import log
from qutebrowser.misc import utilcmds
from qutebrowser.api import cmdutils
@pytest.fixture(autouse=True)
def restore_loggers():
"""Fixture to save/restore the logging state.
Based on CPython's Lib/test/test_logging.py.
"""
logging.captureWarnings(False)
logger_dict = logging.getLogger().manager.loggerDict
with logging._lock:
saved_handlers = logging._handlers.copy()
saved_handler_list = logging._handlerList[:]
saved_loggers = saved_loggers = logger_dict.copy()
saved_name_to_level = logging._nameToLevel.copy()
saved_level_to_name = logging._levelToName.copy()
logger_states = {}
for name in saved_loggers:
logger_states[name] = getattr(saved_loggers[name], 'disabled', None)
root_logger = logging.getLogger("")
root_handlers = root_logger.handlers[:]
original_logging_level = root_logger.getEffectiveLevel()
yield
while root_logger.handlers:
h = root_logger.handlers[0]
root_logger.removeHandler(h)
if not isinstance(h, _pytest.logging.LogCaptureHandler):
h.close()
root_logger.setLevel(original_logging_level)
for h in root_handlers:
if not isinstance(h, _pytest.logging.LogCaptureHandler):
# https://github.com/qutebrowser/qutebrowser/issues/856
root_logger.addHandler(h)
with logging._lock:
logging._levelToName.clear()
logging._levelToName.update(saved_level_to_name)
logging._nameToLevel.clear()
logging._nameToLevel.update(saved_name_to_level)
logging._handlers.clear()
logging._handlers.update(saved_handlers)
logging._handlerList[:] = saved_handler_list
logger_dict = logging.getLogger().manager.loggerDict
logger_dict.clear()
logger_dict.update(saved_loggers)
for name, state in logger_states.items():
if state is not None:
saved_loggers[name].disabled = state
@pytest.fixture(scope='session')
def log_counter():
"""Counter for logger fixture to get unique loggers."""
return itertools.count()
@pytest.fixture
def logger(log_counter):
"""Fixture which provides a logger for tests.
Unique throwaway loggers are used to make sure the tests don't influence
each other.
"""
i = next(log_counter)
return logging.getLogger('qutebrowser-unittest-logger-{}'.format(i))
class TestLogFilter:
def _make_record(self, logger, name, level=logging.DEBUG):
"""Create a bogus logging record with the supplied logger name."""
return logger.makeRecord(name, level=level, fn=None, lno=0, msg="",
args=None, exc_info=None)
@pytest.mark.parametrize('filters, negated, category, logged', [
# Filter letting all messages through
(set(), False, 'eggs.bacon.spam', True),
(set(), False, 'eggs', True),
(set(), True, 'ham', True),
# Matching records
({'eggs', 'bacon'}, False, 'eggs', True),
({'eggs', 'bacon'}, False, 'bacon', True),
({'eggs'}, False, 'eggs.fried', True),
# Non-matching records
({'eggs', 'bacon'}, False, 'spam', False),
({'eggs'}, False, 'eggsauce', False),
({'fried'}, False, 'eggs.fried', False),
# Suppressed records
({'eggs', 'bacon'}, True, 'eggs', False),
({'eggs', 'bacon'}, True, 'bacon', False),
# Non-suppressed records
({'eggs', 'bacon'}, True, 'spam', True),
({'eggs'}, True, 'eggsauce', True),
])
def test_logfilter(self, logger, filters, negated, category, logged):
"""Ensure the multi-record filtering filterer filters multiple records.
(Blame @toofar for this comment)
"""
logfilter = log.LogFilter(filters, negated=negated)
record = self._make_record(logger, category)
assert logfilter.filter(record) == logged
def test_logfilter_benchmark(self, logger, benchmark):
record = self._make_record(logger, 'unfiltered')
filters = set(log.LOGGER_NAMES) # Extreme case
logfilter = log.LogFilter(filters, negated=False)
benchmark(lambda: logfilter.filter(record))
@pytest.mark.parametrize('only_debug', [True, False])
def test_debug(self, logger, only_debug):
"""Test if messages more important than debug are never filtered."""
logfilter = log.LogFilter({'eggs'}, only_debug=only_debug)
record = self._make_record(logger, 'bacon', level=logging.INFO)
assert logfilter.filter(record) == only_debug
@pytest.mark.parametrize(
'category, filter_str, logged_before, logged_after', [
('init', 'url,js', True, False),
('url', 'url,js', False, True),
('js', 'url,js', False, True),
('js', 'none', False, True),
]
)
def test_debug_log_filter_cmd(self, monkeypatch, logger, category,
filter_str, logged_before, logged_after):
"""Test the :debug-log-filter command handler."""
logfilter = log.LogFilter({"init"})
monkeypatch.setattr(log, 'console_filter', logfilter)
record = self._make_record(logger, category)
assert logfilter.filter(record) == logged_before
utilcmds.debug_log_filter('url,js')
assert logfilter.filter(record) == logged_after
def test_debug_log_filter_cmd_invalid(self, monkeypatch):
logfilter = log.LogFilter(set())
monkeypatch.setattr(log, 'console_filter', logfilter)
with pytest.raises(cmdutils.CommandError,
match='Invalid log category blabla'):
utilcmds.debug_log_filter('blabla')
@pytest.mark.parametrize('filter_str, expected_names, negated', [
('!js,misc', {'js', 'misc'}, True),
('js,misc', {'js', 'misc'}, False),
('js, misc', {'js', 'misc'}, False),
('JS, Misc', {'js', 'misc'}, False),
(None, set(), False),
('none', set(), False),
])
def test_parsing(self, filter_str, expected_names, negated):
logfilter = log.LogFilter.parse(filter_str)
assert logfilter.names == expected_names
assert logfilter.negated == negated
@pytest.mark.parametrize('filter_str, invalid', [
('js,!misc', '!misc'),
('blabla,js,blablub', 'blabla, blablub'),
])
def test_parsing_invalid(self, filter_str, invalid):
with pytest.raises(
log.InvalidLogFilterError,
match='Invalid log category {} - '
'valid categories: statusbar, .*'.format(invalid)):
log.LogFilter.parse(filter_str)
@pytest.mark.parametrize('data, expected', [
# Less data
(['one'], ['one']),
# Exactly filled
(['one', 'two'], ['one', 'two']),
# More data
(['one', 'two', 'three'], ['two', 'three']),
])
def test_ram_handler(logger, data, expected):
handler = log.RAMHandler(capacity=2)
handler.setLevel(logging.NOTSET)
logger.addHandler(handler)
for line in data:
logger.debug(line)
assert [rec.msg for rec in handler._data] == expected
assert handler.dump_log() == '\n'.join(expected)
@pytest.mark.integration
class TestInitLog:
"""Tests for init_log."""
def _get_default_args(self):
return argparse.Namespace(debug=True, loglevel='debug', color=True,
loglines=10, logfilter=None,
force_color=False, json_logging=False,
debug_flags=set())
@pytest.fixture(autouse=True)
def setup(self, mocker):
mocker.patch('qutebrowser.utils.qtlog.qtcore.qInstallMessageHandler',
autospec=True)
yield
# Make sure logging is in a sensible default state
args = self._get_default_args()
log.init_log(args)
@pytest.fixture
def args(self):
"""Fixture providing an argparse namespace for init_log."""
return self._get_default_args()
@pytest.fixture
def parser(self):
return qutebrowser.get_argparser()
@pytest.fixture
def empty_args(self, parser):
"""Logging commandline arguments without any customization."""
return parser.parse_args([])
def test_stderr_none(self, args):
"""Test init_log with sys.stderr = None."""
old_stderr = sys.stderr
sys.stderr = None
log.init_log(args)
sys.stderr = old_stderr
def test_python_warnings(self, args, caplog):
log.init_log(args)
with caplog.at_level(logging.WARNING):
warnings.warn("test warning", PendingDeprecationWarning)
expected = "PendingDeprecationWarning: test warning"
assert expected in caplog.records[0].message
def test_python_warnings_werror(self, args):
args.debug_flags = {'werror'}
log.init_log(args)
with pytest.raises(PendingDeprecationWarning):
warnings.warn("test warning", PendingDeprecationWarning)
@pytest.mark.parametrize('cli, conf, expected', [
(None, 'info', logging.INFO),
(None, 'warning', logging.WARNING),
('info', 'warning', logging.INFO),
('warning', 'info', logging.WARNING),
])
def test_init_from_config_console(self, cli, conf, expected, args,
config_stub):
args.debug = False
args.loglevel = cli
log.init_log(args)
config_stub.val.logging.level.console = conf
log.init_from_config(config_stub.val)
assert log.console_handler.level == expected
@pytest.mark.parametrize('conf, expected', [
('vdebug', logging.VDEBUG),
('debug', logging.DEBUG),
('info', logging.INFO),
('critical', logging.CRITICAL),
])
def test_init_from_config_ram(self, conf, expected, args, config_stub):
args.debug = False
log.init_log(args)
config_stub.val.logging.level.ram = conf
log.init_from_config(config_stub.val)
assert log.ram_handler.level == expected
def test_init_from_config_consistent_default(self, config_stub, empty_args):
"""Ensure config defaults are consistent with the builtin defaults."""
log.init_log(empty_args)
assert log.ram_handler.level == logging.DEBUG
assert log.console_handler.level == logging.INFO
log.init_from_config(config_stub.val)
assert log.ram_handler.level == logging.DEBUG
assert log.console_handler.level == logging.INFO
def test_init_from_config_format(self, config_stub, empty_args):
"""If we change to the debug level, make sure the format changes."""
log.init_log(empty_args)
assert log.console_handler.formatter._fmt == log.SIMPLE_FMT
config_stub.val.logging.level.console = 'debug'
log.init_from_config(config_stub.val)
assert log.console_handler.formatter._fmt == log.EXTENDED_FMT
def test_logfilter(self, parser):
args = parser.parse_args(['--logfilter', 'misc'])
log.init_log(args)
assert log.console_filter.names == {'misc'}
@pytest.mark.parametrize('suffix, expected', [
('', 'STUB: test_stub'),
('foo', 'STUB: test_stub (foo)'),
])
def test_stub(caplog, suffix, expected):
with caplog.at_level(logging.WARNING, 'misc'):
log.stub(suffix)
assert caplog.messages == [expected]
def test_py_warning_filter(caplog):
logging.captureWarnings(True)
with log.py_warning_filter(category=UserWarning):
warnings.warn("hidden", UserWarning)
with caplog.at_level(logging.WARNING):
warnings.warn("not hidden", UserWarning)
assert len(caplog.records) == 1
msg = caplog.messages[0].splitlines()[0]
assert msg.endswith("UserWarning: not hidden")
def test_py_warning_filter_error(caplog):
warnings.simplefilter('ignore')
warnings.warn("hidden", UserWarning)
with log.py_warning_filter('error'):
with pytest.raises(UserWarning):
warnings.warn("error", UserWarning)
def test_warning_still_errors():
# Mainly a sanity check after the tests messing with warnings above.
with pytest.raises(UserWarning):
warnings.warn("error", UserWarning)
|