1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
|
test_that("any_duplicated_linter skips allowed usages", {
linter <- any_duplicated_linter()
expect_lint("x <- any(y)", NULL, linter)
expect_lint("y <- duplicated(z)", NULL, linter)
# extended usage of any is not covered
expect_lint("any(duplicated(y), b)", NULL, linter)
expect_lint("any(b, duplicated(y))", NULL, linter)
})
test_that("any_duplicated_linter blocks simple disallowed usages", {
linter <- any_duplicated_linter()
lint_msg <- rex::rex("anyDuplicated(x, ...) > 0 is better")
expect_lint("any(duplicated(x))", lint_msg, linter)
expect_lint("any(duplicated(foo(x)))", lint_msg, linter)
# na.rm doesn't really matter for this since duplicated can't return NA
expect_lint("any(duplicated(x), na.rm = TRUE)", lint_msg, linter)
# also catch nested usage
expect_lint("foo(any(duplicated(x)))", lint_msg, linter)
})
test_that("any_duplicated_linter catches length(unique()) equivalencies too", {
linter <- any_duplicated_linter()
lint_msg_x <- rex::rex("anyDuplicated(x) == 0L is better than length(unique(x)) == length(x)")
lint_msg_df <- rex::rex("anyDuplicated(DF$col) == 0L is better than length(unique(DF$col)) == nrow(DF)")
# non-matches
## different variable
expect_lint("length(unique(x)) == length(y)", NULL, linter)
## different table
expect_lint("length(unique(DF$x)) == nrow(DT)", NULL, linter)
expect_lint("length(unique(l1$DF$x)) == nrow(l2$DF)", NULL, linter)
# lintable usage
expect_lint("length(unique(x)) == length(x)", lint_msg_x, linter)
# argument order doesn't matter
expect_lint("length(x) == length(unique(x))", lint_msg_x, linter)
# nrow-style equivalency
expect_lint("nrow(DF) == length(unique(DF$col))", lint_msg_df, linter)
expect_lint("nrow(DF) == length(unique(DF[['col']]))", lint_msg_df, linter)
# match with nesting too
expect_lint("nrow(l$DF) == length(unique(l$DF[['col']]))", lint_msg_df, linter)
# !=, <, and > usages are all alternative ways of writing a test for dupes
# technically, the direction of > / < matter, but writing
# length(unique(x)) > length(x) doesn't seem like it would ever happen.
expect_lint("length(unique(x)) != length(x)", lint_msg_x, linter)
expect_lint("length(unique(x)) < length(x)", lint_msg_x, linter)
expect_lint("length(x) > length(unique(x))", lint_msg_x, linter)
})
test_that("any_duplicated_linter catches expression with two types of lint", {
linter <- any_duplicated_linter()
lint_msg <- rex::rex("anyDuplicated(DF$col) == 0L is better than length(unique(DF$col)) == nrow(DF)")
expect_lint(
trim_some("{
any(duplicated(x))
length(unique(DF$col)) == nrow(DF)
}"),
list(
list(rex::rex("anyDuplicated(x, ...) > 0 is better"), line_number = 2L),
list(lint_msg, line_number = 3L)
),
linter
)
# ditto for different messages within the length(unique()) tests
expect_lint(
trim_some("{
length(unique(x)) == length(x)
length(unique(DF$col)) == nrow(DF)
}"),
list(
list(rex::rex("anyDuplicated(x) == 0L is better than length(unique(x)) == length(x)"), line_number = 2L),
list(lint_msg, line_number = 3L)
),
linter
)
})
|
