1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
|
test_that("comparison_negation_linter skips allowed usages", {
linter <- comparison_negation_linter()
# doesn't apply to joint statements
expect_lint("!(x == y | y == z)", NULL, linter)
# don't force de Morgan's laws
expect_lint("!(x & y)", NULL, linter)
# naive xpath will include !foo(x) cases
expect_lint("!any(x > y)", NULL, linter)
# ditto for tidyeval cases
expect_lint("!!target == 1 ~ 'target'", NULL, linter)
# ditto for !x[f == g]
expect_lint("!passes.test[stage == 1]", NULL, linter)
})
local({
linter <- comparison_negation_linter()
comparators <- c("==", "!=", ">=", ">", "<=", "<")
inverses <- c("!=", "==", "<", "<=", ">", ">=")
patrick::with_parameters_test_that(
"comparison_negation_linter blocks simple disallowed usages",
{
expect_lint(
sprintf("!(x %s y)", comparator),
rex::rex(sprintf("Use x %s y, not !(x %s y)", inverse, comparator)),
linter
)
expect_lint(
sprintf("!x %s y", comparator),
rex::rex(sprintf("Use x %s y, not !(x %s y)", inverse, comparator)),
linter
)
},
.test_name = comparators,
comparator = comparators,
inverse = inverses
)
})
test_that("comparison_negation_linter catches plain ! (no parens) + call", {
# Earlier logic would find the wrong node due to expr in length()
expect_lint(
"!length(x) > 0",
rex::rex("Use x <= y, not !(x > y)"),
comparison_negation_linter()
)
})
test_that("Lints vectorize", {
expect_lint(
trim_some("{
!(x > y)
!x == y
}"),
list(
list(rex::rex("Use x <= y, not !(x > y)."), line_number = 2L),
list(rex::rex("Use x != y, not !(x == y)."), line_number = 3L)
),
comparison_negation_linter()
)
})
|
