1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
|
test_that("expect_not_linter skips allowed usages", {
expect_lint("expect_true(x)", NULL, expect_not_linter())
# NB: also applies to tinytest, but it's sufficient to test testthat
expect_lint("testthat::expect_true(x)", NULL, expect_not_linter())
expect_lint("expect_false(x)", NULL, expect_not_linter())
expect_lint("testthat::expect_false(x)", NULL, expect_not_linter())
# not a strict ban on !
## (expect_false(x && y) is the same, but it's not clear which to prefer)
expect_lint("expect_true(!x || !y)", NULL, expect_not_linter())
})
test_that("expect_not_linter blocks simple disallowed usages", {
linter <- expect_not_linter()
lint_msg <- rex::rex("expect_false(x) is better than expect_true(!x), and vice versa.")
expect_lint("expect_true(!x)", lint_msg, linter)
expect_lint("testthat::expect_true(!x)", lint_msg, linter)
expect_lint("expect_false(!foo(x))", lint_msg, linter)
expect_lint("testthat::expect_true(!(x && y))", lint_msg, linter)
})
test_that("lints vectorize", {
lint_msg <- rex::rex("expect_false(x) is better than expect_true(!x), and vice versa.")
expect_lint(
trim_some("{
expect_true(!x)
expect_false(!y)
}"),
list(
list(lint_msg, line_number = 2L),
list(lint_msg, line_number = 3L)
),
expect_not_linter()
)
})
|
