1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
|
test_that("expect_null_linter skips allowed usages", {
linter <- expect_null_linter()
# NB: this usage should be expect_false(), but this linter should
# nevertheless apply (e.g. for maintainers not using expect_not_linter)
expect_lint("expect_true(!is.null(x))", NULL, linter)
# NB: also applies to tinytest, but it's sufficient to test testthat
expect_lint("testthat::expect_true(!is.null(x))", NULL, linter)
# length-0 could be NULL, but could be integer() or list(), so let it pass
expect_lint("expect_length(x, 0L)", NULL, linter)
# no false positive for is.null() at the wrong positional argument
expect_lint("expect_true(x, is.null(y))", NULL, linter)
})
test_that("expect_null_linter blocks simple disallowed usages", {
linter <- expect_null_linter()
expect_lint(
"expect_equal(x, NULL)",
rex::rex("expect_null(x) is better than expect_equal(x, NULL)"),
linter
)
# expect_identical is treated the same as expect_equal
expect_lint(
"testthat::expect_identical(x, NULL)",
rex::rex("expect_null(x) is better than expect_identical(x, NULL)"),
linter
)
# reverse order lints the same
expect_lint(
"expect_equal(NULL, x)",
rex::rex("expect_null(x) is better than expect_equal(x, NULL)"),
linter
)
# different equivalent usage
expect_lint(
"expect_true(is.null(foo(x)))",
rex::rex("expect_null(x) is better than expect_true(is.null(x))"),
linter
)
})
test_that("lints vectorize", {
expect_lint(
trim_some("{
expect_equal(x, NULL)
expect_identical(x, NULL)
expect_true(is.null(x))
}"),
list(
list("expect_equal", line_number = 2L),
list("expect_identical", line_number = 3L),
list("expect_true", line_number = 4L)
),
expect_null_linter()
)
})
|
