1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
|
test_that("returns the correct linting", {
ops <- c(
"+",
"-",
"~",
"=",
"==",
"!=",
"<=",
">=",
"<-",
":=",
"<<-",
"<",
">",
"->",
"->>",
"%%",
"/",
"*",
"|",
"||",
"&",
"&&",
"%>%",
"%Anything%",
"%+%",
NULL
)
linter <- infix_spaces_linter()
lint_msg <- rex::rex("Put spaces around all infix operators.")
expect_lint("blah", NULL, linter)
for (op in ops) {
expect_lint(paste0("1 ", op, " 2"), NULL, linter)
expect_lint(paste0("1 ", op, "\n2"), NULL, linter)
expect_lint(paste0("1 ", op, "\n 2"), NULL, linter)
expect_lint(paste0("1", op, "2"), lint_msg, linter)
# unary plus and minus can have no space before them
if (!op %in% ops[1L:2L]) {
expect_lint(paste0("1 ", op, "2"), lint_msg, linter)
}
expect_lint(paste0("1", op, " 2"), lint_msg, linter)
}
expect_lint("b <- 2E+4", NULL, linter)
expect_lint("a <- 1e-3", NULL, linter)
expect_lint("a[-1]", NULL, linter)
expect_lint("a[-1 + 1]", NULL, linter)
expect_lint("a[1 + -1]", NULL, linter)
expect_lint("fun(a=1)", lint_msg, linter)
})
test_that("The three `=` are all linted", {
linter <- infix_spaces_linter()
lint_msg <- rex::rex("Put spaces around all infix operators.")
# EQ_ASSIGN in the parse data
expect_lint("a=1", lint_msg, linter)
# EQ_FORMALS in the parse data
expect_lint("foo <- function(x=1) {}", lint_msg, linter)
# EQ_SUB in the parse data
expect_lint("foo(x=1)", lint_msg, linter)
})
test_that("exclude_operators works", {
lint_msg <- rex::rex("Put spaces around all infix operators.")
expect_lint("a+b", NULL, infix_spaces_linter(exclude_operators = "+"))
expect_lint(
trim_some("
a+b
a-b
"),
NULL,
infix_spaces_linter(exclude_operators = c("+", "-"))
)
# operators match on text, not hidden node
expect_lint("a<<-1", lint_msg, infix_spaces_linter(exclude_operators = "<-"))
expect_lint("a<<-1", NULL, infix_spaces_linter(exclude_operators = "<<-"))
expect_lint("a:=1", lint_msg, infix_spaces_linter(exclude_operators = "<-"))
expect_lint("a:=1", NULL, infix_spaces_linter(exclude_operators = ":="))
expect_lint("a->>1", lint_msg, infix_spaces_linter(exclude_operators = "->"))
expect_lint("a->>1", NULL, infix_spaces_linter(exclude_operators = "->>"))
expect_lint("a%any%1", NULL, infix_spaces_linter(exclude_operators = "%%"))
expect_lint("function(a=1) { }", NULL, infix_spaces_linter(exclude_operators = "="))
expect_lint("foo(a=1)", NULL, infix_spaces_linter(exclude_operators = "="))
})
# more tests specifically for assignment
test_that("assignment cases return the correct linting", {
linter <- infix_spaces_linter()
lint_msg <- rex::rex("Put spaces around all infix operators.")
expect_lint("fun(blah = 1)", NULL, linter)
expect_lint("blah <- 1", NULL, linter)
expect_lint("blah = 1", NULL, linter)
expect_lint("\"my = variable\" <- 42.0", NULL, linter)
expect_lint("if (0 < 1) x <- 42L", NULL, linter)
expect_lint(
trim_some("
if (0 < 1) {
x <- 42L
}"),
NULL,
linter
)
expect_lint("my = bad = variable = name <- 2.0", NULL, linter)
expect_lint("blah<- 1", lint_msg, linter)
expect_lint("blah <-1", lint_msg, linter)
expect_lint("blah= 1", lint_msg, linter)
expect_lint("blah =1", lint_msg, linter)
})
test_that("infix_spaces_linter can allow >1 spaces optionally", {
linter <- infix_spaces_linter(allow_multiple_spaces = FALSE)
lint_msg <- rex::rex("Put exactly one space on each side of infix operators.")
expect_lint("x ~ 1", lint_msg, linter)
expect_lint("x - 1", lint_msg, linter)
expect_lint("x / 1", lint_msg, linter)
})
test_that("exception for box::use()", {
linter <- infix_spaces_linter()
expect_lint("box::use(a/b)", NULL, linter)
expect_lint("box::use(./a/b)", NULL, linter)
expect_lint(
trim_some("
box::use(
a,
a/b,
../a,
alias = a/b/c[xyz = abc, ...],
)
"),
NULL,
linter
)
})
test_that("multi-line, multi-expression case is caught", {
expect_lint(
trim_some("
x +
y+
z
"),
rex::rex("Put spaces around all infix operators."),
infix_spaces_linter()
)
})
test_that("Rules around missing arguments are respected", {
linter <- infix_spaces_linter()
lint_msg <- rex::rex("Put spaces around all infix operators.")
expect_lint("switch(a = , b = 2)", NULL, linter)
expect_lint("alist(missing_arg = )", NULL, linter)
expect_lint("switch(a =, b = 2)", lint_msg, linter)
expect_lint("alist(missing_arg =)", lint_msg, linter)
})
test_that("native pipe is supported", {
skip_if_not_r_version("4.1.0")
linter <- infix_spaces_linter()
expect_lint("a |> foo()", NULL, linter)
expect_lint("a|>foo()", rex::rex("Put spaces around all infix operators."), linter)
})
test_that("mixed unary & binary operators aren't mis-lint", {
expect_lint(
"-1-1",
list(
message = rex::rex("Put spaces around all infix operators."),
column_number = 3L
),
infix_spaces_linter()
)
})
test_that("parse tags are accepted by exclude_operators", {
expect_lint("sum(x, na.rm=TRUE)", NULL, infix_spaces_linter(exclude_operators = "EQ_SUB"))
expect_lint("function(x, na.rm=TRUE) { }", NULL, infix_spaces_linter(exclude_operators = "EQ_FORMALS"))
expect_lint("x=1", NULL, infix_spaces_linter(exclude_operators = "EQ_ASSIGN"))
# uses parse_tag
expect_lint("1+1", NULL, infix_spaces_linter(exclude_operators = "'+'"))
# mixing
text <- "x=function(a=foo(bar=1)) { }"
col_assign <- list(column_number = 2L)
col_formals <- list(column_number = 13L)
col_sub <- list(column_number = 21L)
expect_lint(text, NULL, infix_spaces_linter(exclude_operators = c("EQ_SUB", "EQ_FORMALS", "EQ_ASSIGN")))
expect_lint(text, col_assign, infix_spaces_linter(exclude_operators = c("EQ_SUB", "EQ_FORMALS")))
expect_lint(text, col_formals, infix_spaces_linter(exclude_operators = c("EQ_SUB", "EQ_ASSIGN")))
expect_lint(text, col_sub, infix_spaces_linter(exclude_operators = c("EQ_FORMALS", "EQ_ASSIGN")))
expect_lint(text, list(col_assign, col_formals), infix_spaces_linter(exclude_operators = "EQ_SUB"))
expect_lint(text, list(col_assign, col_sub), infix_spaces_linter(exclude_operators = "EQ_FORMALS"))
expect_lint(text, list(col_formals, col_sub), infix_spaces_linter(exclude_operators = "EQ_ASSIGN"))
})
test_that("lints vectorize", {
lint_msg <- rex::rex("Put spaces around all infix operators.")
expect_lint(
trim_some("{
a<-1
1/2
b<-c<-2
d+e+f+g/3
}"),
list(
list(lint_msg, line_number = 2L),
list(lint_msg, line_number = 3L),
list(lint_msg, line_number = 4L, column_number = 4L),
list(lint_msg, line_number = 4L, column_number = 7L),
list(lint_msg, line_number = 5L, column_number = 4L),
list(lint_msg, line_number = 5L, column_number = 6L),
list(lint_msg, line_number = 5L, column_number = 8L),
list(lint_msg, line_number = 5L, column_number = 10L)
),
infix_spaces_linter()
)
})
|
