1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
|
test_that("inner_combine_linter lints a false positive-ish usage", {
# By default as.POSIXct.character picks up the format to apply from
# the first element and, since it succeeds, applies that to the remaining
# timestamps. Whereas when run individually, it won't succeed until
# the correct format is matched for each input. Nevertheless, it is
# still preferable to vectorize the call, while being sure to use a
# consistent format for the inputs. In this case, the correct equivalent
# call is as.POSIXct(c("2021-01-01 00:00:00", "2021-01-01 01:00:00")).
expect_lint(
"c(as.POSIXct('2021-01-01'), as.POSIXct('2021-01-01 01:00:00'))",
rex::rex("Combine inputs to vectorized functions first"),
inner_combine_linter()
)
})
local({
vector_funs <- c(
"as.Date", "as.POSIXct", "as.POSIXlt",
"sin", "cos", "tan", "sinpi", "cospi", "tanpi", "asin", "acos", "atan",
"log", "logb", "log2", "log10", "log1p", "exp", "expm1",
"sqrt", "abs",
"ymd", "ydm", "mdy", "myd", "dmy", "dym",
"yq", "ym", "my",
"ymd_hms", "ymd_hm", "ymd_h", "dmy_hms", "dmy_hm", "dmy_h",
"mdy_hms", "mdy_hm", "mdy_h", "ydm_hms", "ydm_hm", "ydm_h",
NULL
)
patrick::with_parameters_test_that(
"inner_combine_linter blocks simple vectorized calls:",
expect_lint(
sprintf("c(%1$s(x), %1$s(y))", vector_fun),
rex::rex("Combine inputs to vectorized functions first"),
inner_combine_linter()
),
.test_name = vector_funs,
vector_fun = vector_funs
)
})
patrick::with_parameters_test_that(
"inner_combine_linter blocks as.Date with identical passed arguments:",
expect_lint(
sprintf("c(as.Date(x, %1$s), as.Date(y, %1$s))", arg),
rex::rex("Combine inputs to vectorized functions first"),
inner_combine_linter()
),
.test_name = c("format", "origin", "tz", "tryFormats", "non-literal", "quoted arg name"),
arg = c("format = '%F'", "origin = '1900-01-01'", "tz = 'Asia/Jakarta'", "tryFormats = '%F'", "tz = tz", "'tz' = tz")
)
patrick::with_parameters_test_that(
"inner_combine_linter blocks as.POSIXct with identical passed arguments:",
expect_lint(
sprintf("c(as.POSIXct(x, %1$s), as.POSIXct(y, %1$s))", arg),
rex::rex("Combine inputs to vectorized functions first"),
inner_combine_linter()
),
.test_name = c("format", "origin", "tz", "non-literal"),
arg = c("format = '%F'", "origin = '1900-01-01'", "tz = 'UTC'", "tz = tz")
)
test_that("inner_combine_linter is order-agnostic for matching arguments", {
expect_lint(
"c(as.Date(x, format = f, tz = t), as.Date(y, tz = t, format = f))",
rex::rex("Combine inputs to vectorized functions first"),
inner_combine_linter()
)
})
test_that("c() with ...length()=1 is OK", {
expect_lint("c(exp())", NULL, inner_combine_linter())
})
skip_if_not_installed("tibble")
patrick::with_parameters_test_that(
"inner_combine_linter skips allowed usages:",
expect_lint(expr, NULL, inner_combine_linter()),
.cases = tibble::tribble(
~.test_name, ~expr,
"simple sin()", "x <- sin(1:10)",
"mixed sin()+cos()", "y <- c(sin(1:10), cos(2:20))",
"present/absent vector function", "c(log(x), 0.5)",
"absent/present vector function", "c(0.5, log(x))",
"mismatched arg (Date)", "c(as.Date(x, format = '%y'), as.Date(y, format = '%m'))",
"present/absent arg (Date)", "c(as.Date(x, format = '%y'), as.Date(y))",
"absent/present arg (Date)", "c(as.Date(x), as.Date(y, format = '%y'))",
"matched value, not arg (Date)", "c(as.Date(x, format = '%y'), as.Date(y, tz = '%y'))",
"mismatched arg (POSIXct)", "c(as.POSIXct(x, format = '%y'), as.POSIXct(y, format = '%m'))",
"present/absent arg (POSIXct)", "c(as.POSIXct(x, format = '%y'), as.POSIXct(y))",
"mismatched arg (log)", "c(log(x, base = 4), log(y, base = 5))",
"present/absent arg (log)", "c(log(x, base = 4), log(y))"
# TODO(#2486): Reactivate these.
# "unknown Date method argument", "c(as.Date(x, zoo = zzz), as.Date(y, zoo = zzz))",
# "known+unknown Date argument", "c(as.Date(x, format = '%y', zoo = zzz), as.Date(y, format = '%y', zoo = zzz))",
# "unknown POSIXct method argument", "c(as.POSIXct(x, zoo = zzz), as.POSIXct(y, zoo = zzz))",
)
)
test_that("lints vectorize", {
lint_msg <- rex::rex("Combine inputs to vectorized functions first")
expect_lint(
trim_some("{
c(sin(x), sin(y))
c(log(x), log(y))
}"),
list(
list(lint_msg, line_number = 2L),
list(lint_msg, line_number = 3L)
),
inner_combine_linter()
)
})
|
