1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
|
test_that("is_numeric_linter skips allowed usages involving ||", {
linter <- is_numeric_linter()
expect_lint("is.numeric(x) || is.integer(y)", NULL, linter)
# x is used, but not identically
expect_lint("is.numeric(x) || is.integer(foo(x))", NULL, linter)
# not totally crazy, e.g. if input accepts a vector or a list
expect_lint("is.numeric(x) || is.integer(x[[1]])", NULL, linter)
})
test_that("is_numeric_linter skips allowed usages involving %in%", {
linter <- is_numeric_linter()
# false positives for class(x) %in% c('integer', 'numeric') style
expect_lint("class(x) %in% 1:10", NULL, linter)
expect_lint("class(x) %in% 'numeric'", NULL, linter)
expect_lint("class(x) %in% c('numeric', 'integer', 'factor')", NULL, linter)
expect_lint("class(x) %in% c('numeric', 'integer', y)", NULL, linter)
})
test_that("is_numeric_linter blocks disallowed usages involving ||", {
linter <- is_numeric_linter()
lint_msg <- rex::rex("Use `is.numeric(x)` instead of the equivalent `is.numeric(x) || is.integer(x)`.")
expect_lint("is.numeric(x) || is.integer(x)", lint_msg, linter)
# order doesn't matter
expect_lint("is.integer(x) || is.numeric(x)", lint_msg, linter)
# identical expressions match too
expect_lint("is.integer(DT$x) || is.numeric(DT$x)", lint_msg, linter)
# line breaks don't matter
lines <- trim_some("
if (
is.integer(x)
|| is.numeric(x)
) TRUE
")
expect_lint(lines, lint_msg, linter)
# caught when nesting
expect_lint("all(y > 5) && (is.integer(x) || is.numeric(x))", lint_msg, linter)
# implicit nesting
expect_lint("is.integer(x) || is.numeric(x) || is.logical(x)", lint_msg, linter)
})
test_that("is_numeric_linter blocks disallowed usages involving %in%", {
linter <- is_numeric_linter()
lint_msg <- rex::rex('Use is.numeric(x) instead of class(x) %in% c("integer", "numeric")')
expect_lint("class(x) %in% c('integer', 'numeric')", lint_msg, linter)
expect_lint('class(x) %in% c("numeric", "integer")', lint_msg, linter)
})
test_that("raw strings are handled properly when testing in class", {
skip_if_not_r_version("4.0.0")
linter <- is_numeric_linter()
lint_msg <- rex::rex('Use is.numeric(x) instead of class(x) %in% c("integer", "numeric")')
expect_lint("class(x) %in% c(R'(numeric)', 'integer', 'factor')", NULL, linter)
expect_lint("class(x) %in% c('numeric', R'--(integer)--', y)", NULL, linter)
expect_lint("class(x) %in% c(R'(integer)', 'numeric')", lint_msg, linter)
expect_lint('class(x) %in% c("numeric", R"--[integer]--")', lint_msg, linter)
})
test_that("lints vectorize", {
expect_lint(
trim_some("{
is.numeric(x) || is.integer(x)
class(x) %in% c('integer', 'numeric')
}"),
list(
list(rex::rex("`is.numeric(x) || is.integer(x)`"), line_number = 2L),
list(rex::rex('class(x) %in% c("integer", "numeric")'), line_number = 3L)
),
is_numeric_linter()
)
})
|
