1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
|
test_that("lengths_linter skips allowed usages", {
linter <- lengths_linter()
expect_lint("length(x)", NULL, linter)
expect_lint("function(x) length(x) + 1L", NULL, linter)
expect_lint("vapply(x, fun, integer(length(y)))", NULL, linter)
expect_lint("sapply(x, sqrt, simplify = length(x))", NULL, linter)
# TODO(#1570): also throw a lint here, and for map(x, length)
expect_lint("lapply(x, length)", NULL, linter)
})
test_that("lengths_linter blocks simple disallowed base usages", {
linter <- lengths_linter()
lint_msg <- rex::rex("Use lengths() to find the length of each element in a list.")
expect_lint("sapply(x, length)", lint_msg, linter)
expect_lint("sapply(x, FUN = length)", lint_msg, linter)
expect_lint("sapply(FUN = length, x)", lint_msg, linter)
expect_lint("vapply(x, length, integer(1L))", lint_msg, linter)
})
test_that("lengths_linter blocks simple disallowed purrr usages", {
linter <- lengths_linter()
lint_msg <- rex::rex("Use lengths() to find the length of each element in a list.")
expect_lint("purrr::map_dbl(x, length)", lint_msg, linter)
expect_lint("map_dbl(x, .f = length)", lint_msg, linter)
expect_lint("map_dbl(.f = length, x)", lint_msg, linter)
expect_lint("map_int(x, length)", lint_msg, linter)
})
test_that("lengths_linter blocks simple disallowed usages with pipes", {
skip_if_not_r_version("4.1.0")
linter <- lengths_linter()
lint_msg <- rex::rex("Use lengths() to find the length of each element in a list.")
expect_lint("x |> sapply(length)", lint_msg, linter)
expect_lint("x %>% sapply(length)", lint_msg, linter)
expect_lint("x |> map_int(length)", lint_msg, linter)
expect_lint("x %>% map_int(length)", lint_msg, linter)
})
test_that("lints vectorize", {
lint_msg <- rex::rex("Use lengths() to find the length of each element in a list.")
expect_lint(
trim_some("{
sapply(x, length)
map_int(x, length)
}"),
list(
list(lint_msg, line_number = 2L),
list(lint_msg, line_number = 3L)
),
lengths_linter()
)
})
|
