1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
|
test_that("library_call_linter skips allowed usages", {
linter <- library_call_linter()
expect_lint(
trim_some("
library(dplyr)
print('test')
"),
NULL,
linter
)
expect_lint("print('test')",
NULL,
linter
)
expect_lint(
trim_some("
# comment
library(dplyr)
"),
NULL,
linter
)
expect_lint(
trim_some("
print('test')
# library(dplyr)
"),
NULL,
linter
)
expect_lint(
trim_some("
suppressPackageStartupMessages({
library(dplyr)
library(knitr)
})
"),
NULL,
linter
)
})
test_that("library_call_linter warns on disallowed usages", {
linter <- library_call_linter()
lint_message <- rex::rex("Move all library calls to the top of the script.")
expect_lint(
trim_some("
library(dplyr)
print('test')
library(tidyr)
"),
lint_message,
linter
)
expect_lint(
trim_some("
library(dplyr)
print('test')
library(tidyr)
library(purrr)
"),
list(
list(lint_message, line_number = 3L, column_number = 1L),
list(lint_message, line_number = 4L, column_number = 1L)
),
linter
)
expect_lint(
trim_some("
library(dplyr)
print('test')
print('test')
library(tidyr)
"),
lint_message,
linter
)
expect_lint(
trim_some("
library(dplyr)
print('test')
library(tidyr)
print('test')
"),
lint_message,
linter
)
expect_lint(
trim_some("
library(dplyr)
print('test')
library(tidyr)
print('test')
library(purrr)
"),
list(
list(lint_message, line_number = 3L, column_number = 1L),
list(lint_message, line_number = 5L, column_number = 1L)
),
linter
)
expect_lint(
trim_some("
library(dplyr)
print('test')
suppressMessages(library('lubridate', character.only = TRUE))
suppressMessages(library(tidyr))
print('test')
"),
list(
list(rex::rex("Unify consecutive calls to suppressMessages()"), line_number = 3L),
list(lint_message, line_number = 3L),
list(rex::rex("Use symbols in library calls to avoid the need for 'character.only'"), line_number = 3L),
list(lint_message, line_number = 4L)
),
linter
)
})
test_that("require() treated the same as library()", {
linter <- library_call_linter()
lint_message_library <- rex::rex("Move all library calls to the top of the script.")
lint_message_require <- rex::rex("Move all require calls to the top of the script.")
expect_lint(
trim_some("
library(dplyr)
require(tidyr)
"),
NULL,
linter
)
expect_lint(
trim_some("
library(dplyr)
print(letters)
require(tidyr)
"),
list(lint_message_require, line_number = 3L),
linter
)
expect_lint(
trim_some("
library(dplyr)
print(letters)
library(dbplyr)
require(tidyr)
"),
list(
list(lint_message_library, line_number = 3L),
list(lint_message_require, line_number = 4L)
),
linter
)
})
test_that("allow_preamble applies as intended", {
linter_preamble <- library_call_linter(allow_preamble = TRUE)
linter_no_preamble <- library_call_linter(allow_preamble = FALSE)
lint_msg <- rex::rex("Move all library calls to the top of the script.")
lines <- trim_some("
opts_chunk$set(eval = FALSE)
library(dplyr)
library(knitr)
print(letters)
")
expect_lint(lines, NULL, linter_preamble)
expect_lint(lines, list(list(line_number = 2L), list(line_number = 3L)), linter_no_preamble)
lines <- trim_some("
opts_chunk$set(eval = FALSE)
suppressPackageStartupMessages({
library(dplyr)
library(knitr)
})
print(letters)
")
expect_lint(lines, NULL, linter_preamble)
expect_lint(lines, list(list(line_number = 3L), list(line_number = 4L)), linter_no_preamble)
lines <- trim_some("
opts_chunk$set(eval = FALSE)
suppressPackageStartupMessages(library(dplyr))
library(knitr)
print(letters)
")
expect_lint(lines, NULL, linter_preamble)
expect_lint(lines, list(list(line_number = 2L), list(line_number = 3L)), linter_no_preamble)
lines <- trim_some("
opts_chunk$set(eval = FALSE)
library(dplyr)
suppressPackageStartupMessages(library(knitr))
print(letters)
")
expect_lint(lines, NULL, linter_preamble)
expect_lint(lines, list(list(line_number = 2L), list(line_number = 3L)), linter_no_preamble)
lines <- trim_some("
fun()
library(moreFun)
oops()
")
expect_lint(lines, NULL, linter_preamble)
expect_lint(lines, lint_msg, linter_no_preamble)
})
test_that("skips allowed usages of library()/character.only=TRUE", {
linter <- library_call_linter()
expect_lint("library(data.table)", NULL, linter)
expect_lint("function(pkg) library(pkg, character.only = TRUE)", NULL, linter)
expect_lint("function(pkgs) sapply(pkgs, require, character.only = TRUE)", NULL, linter)
})
test_that("blocks disallowed usages of strings in library()/require()", {
linter <- library_call_linter()
char_only_msg <- rex::rex("Use symbols in library calls", anything, "character.only")
direct_stub <- "Call library() directly, not vectorized with "
expect_lint(
'library("data.table")',
rex::rex("Use symbols, not strings, in library calls."),
linter
)
expect_lint('library("data.table", character.only = TRUE)', char_only_msg, linter)
expect_lint('suppressWarnings(library("data.table", character.only = TRUE))', char_only_msg, linter)
expect_lint(
"do.call(library, list(data.table))",
rex::rex(direct_stub, "do.call()"),
linter
)
expect_lint(
'do.call("library", list(data.table))',
rex::rex(direct_stub, "do.call()"),
linter
)
expect_lint(
'lapply("data.table", library, character.only = TRUE)',
rex::rex(direct_stub, "lapply()"),
linter
)
expect_lint(
'purr::map("data.table", library, character.only = TRUE)',
rex::rex(direct_stub, "map()"),
linter
)
})
test_that("character.only=TRUE is caught in *apply functions passed as strings", {
linter <- library_call_linter()
lib_msg <- rex::rex("Call library() directly, not vectorized with sapply()")
req_msg <- rex::rex("Call require() directly, not vectorized with sapply()")
expect_lint("sapply(pkgs, 'library', character.only = TRUE)", lib_msg, linter)
expect_lint('sapply(pkgs, "library", character.only = TRUE)', lib_msg, linter)
expect_lint("sapply(pkgs, 'require', character.only = TRUE)", req_msg, linter)
expect_lint('sapply(pkgs, "require", character.only = TRUE)', req_msg, linter)
})
test_that("character.only=TRUE is caught with multiple-line source", {
expect_lint(
trim_some('
suppressWarnings(library(
"data.table",
character.only = TRUE
))
'),
rex::rex("Use symbols in library calls", anything, "character.only"),
library_call_linter()
)
})
test_that("character.only=TRUE is caught inside purrr::walk as well", {
expect_lint(
'purr::walk("data.table", library, character.only = TRUE)',
rex::rex("Call library() directly, not vectorized with walk()"),
library_call_linter()
)
})
test_that("multiple lints are generated correctly", {
expect_lint(
trim_some('{
library("dplyr", character.only = TRUE)
print("not a library call")
require("gfile")
sapply(pkg_list, "library", character.only = TRUE)
purrr::walk(extra_list, require, character.only = TRUE)
}'),
list(
list(message = rex::rex("library calls", anything, "character.only")),
list(message = rex::rex("Move all require calls to the top of the script.")),
list(message = "symbols, not strings, in require calls"),
list(message = rex::rex("library() directly", anything, "vectorized with sapply()")),
list(message = rex::rex("require() directly", anything, "vectorized with walk()"))
),
library_call_linter()
)
})
patrick::with_parameters_test_that(
"library_call_linter skips allowed usages",
{
linter <- library_call_linter()
expect_lint(sprintf("%s(x)", call), NULL, linter)
expect_lint(sprintf("%s(x, y, z)", call), NULL, linter)
# intervening expression
expect_lint(sprintf("%1$s(x); y; %1$s(z)", call), NULL, linter)
# inline or potentially with gaps don't matter
expect_lint(
trim_some(glue::glue("
{call}(x)
y
stopifnot(z)
")),
NULL,
linter
)
# only suppressing calls with library()
expect_lint(
trim_some(glue::glue("
{call}(x)
{call}(y)
")),
NULL,
linter
)
},
.test_name = c("suppressMessages", "suppressPackageStartupMessages"),
call = c("suppressMessages", "suppressPackageStartupMessages")
)
patrick::with_parameters_test_that(
"library_call_linter blocks simple disallowed usages",
{
linter <- library_call_linter()
lint_msg <- sprintf("Unify consecutive calls to %s\\(\\)\\.", call)
# one test of inline usage
expect_lint(sprintf("%1$s(library(x)); %1$s(library(y))", call), lint_msg, linter)
expect_lint(
trim_some(glue::glue("
{call}(library(x))
{call}(library(y))
")),
lint_msg,
linter
)
expect_lint(
trim_some(glue::glue("
{call}(require(x))
{call}(require(y))
")),
lint_msg,
linter
)
expect_lint(
trim_some(glue::glue("
{call}(library(x))
# a comment on y
{call}(library(y))
")),
lint_msg,
linter
)
},
.test_name = c("suppressMessages", "suppressPackageStartupMessages"),
call = c("suppressMessages", "suppressPackageStartupMessages")
)
test_that("Namespace differences are detected", {
linter <- library_call_linter()
# totally different namespaces
expect_lint(
"ns::suppressMessages(library(x)); base::suppressMessages(library(y))",
NULL,
linter
)
# one namespaced, one not
expect_lint(
"ns::suppressMessages(library(x)); suppressMessages(library(y))",
NULL,
linter
)
})
test_that("Consecutive calls to different blocked calls is OK", {
expect_lint(
"suppressPackageStartupMessages(library(x)); suppressMessages(library(y))",
NULL,
library_call_linter()
)
})
test_that("Multiple violations across different calls are caught", {
linter <- library_call_linter()
expect_lint(
trim_some("
suppressPackageStartupMessages(library(x))
suppressPackageStartupMessages(library(x))
suppressMessages(library(x))
suppressMessages(library(x))
"),
list(
"Unify consecutive calls to suppressPackageStartupMessages",
"Unify consecutive calls to suppressMessages"
),
linter
)
expect_lint(
trim_some("
suppressMessages(library(A))
suppressPackageStartupMessages(library(A))
suppressMessages(library(A))
suppressPackageStartupMessages(library(A))
suppressPackageStartupMessages(library(A))
"),
list("Unify consecutive calls to suppressPackageStartupMessages", line_number = 4L),
linter
)
})
|
