1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
|
test_that("lint all files in a directory", {
# NB: not using .lintr in the test packages because
# R CMD check doesn't like hidden files in any subdirectory
withr::local_options(lintr.linter_file = "lintr_test_config")
the_dir <- test_path("dummy_packages", "package", "vignettes")
files <- list.files(the_dir)
lints <- lint_dir(the_dir, parse_settings = FALSE)
linted_files <- unique(names(lints))
expect_s3_class(lints, "lints")
expect_identical(sort(linted_files), sort(files))
})
test_that("lint all relevant directories in a package", {
withr::local_options(lintr.linter_file = "lintr_test_config")
the_pkg <- test_path("dummy_packages", "package")
files <- setdiff(
list.files(the_pkg, recursive = TRUE),
c("package.Rproj", "DESCRIPTION", "NAMESPACE", "lintr_test_config")
)
lintr:::read_settings(NULL)
lints <- lint_package(the_pkg, parse_settings = FALSE)
linted_files <- unique(names(lints))
# lintr paths contain backslash on windows, list.files uses forward slash.
linted_files <- gsub("\\", "/", linted_files, fixed = TRUE)
expect_s3_class(lints, "lints")
expect_identical(sort(linted_files), sort(files))
# Code coverage is not detected for default_linters.
# We want to ensure that object_name_linter uses namespace_imports correctly.
# assignment_linter is needed to cause a lint in all vignettes.
linters <- list(assignment_linter(), object_name_linter())
lintr:::read_settings(NULL)
lints <- lint_package(the_pkg, linters = linters, parse_settings = FALSE)
linted_files <- unique(names(lints))
# lintr paths contain backslash on windows, list.files uses forward slash.
linted_files <- gsub("\\", "/", linted_files, fixed = TRUE)
expect_s3_class(lints, "lints")
expect_identical(sort(linted_files), sort(files))
})
test_that("respects directory exclusions", {
the_dir <- withr::local_tempdir()
the_excluded_dir <- file.path(the_dir, "exclude-me")
dir.create(the_excluded_dir)
defaults_path <- test_path("default_linter_testcode.R")
file.copy(defaults_path, the_dir)
file.copy(defaults_path, the_excluded_dir)
file.copy(defaults_path, file.path(the_excluded_dir, "bad2.R"))
lints <- lint_dir(the_dir, exclusions = "exclude-me")
linted_files <- unique(names(lints))
expect_length(linted_files, 1L)
expect_identical(linted_files, "default_linter_testcode.R")
lints_norm <- lint_dir(the_dir, exclusions = "exclude-me", relative_path = FALSE)
linted_files <- unique(names(lints_norm))
expect_length(linted_files, 1L)
expect_identical(linted_files, normalize_path(file.path(the_dir, "default_linter_testcode.R")))
})
test_that("respect directory exclusions from settings", {
the_dir <- withr::local_tempdir()
the_excluded_dir <- file.path(the_dir, "exclude-me")
dir.create(the_excluded_dir)
defaults_path <- test_path("default_linter_testcode.R")
file.copy(defaults_path, the_dir)
file.copy(defaults_path, the_excluded_dir)
file.copy(defaults_path, file.path(the_excluded_dir, "bad2.R"))
cat("exclusions:\n 'exclude-me'\n", file = file.path(the_dir, ".lintr"))
lints <- lint_dir(the_dir)
linted_files <- unique(names(lints))
expect_length(linted_files, 1L)
})
test_that("lint_dir works with specific linters without specifying other arguments", {
withr::local_options(lintr.linter_file = "lintr_test_config")
the_dir <- test_path("dummy_packages", "package", "vignettes")
expect_length(lint_dir(the_dir, assignment_linter(), parse_settings = FALSE), 14L)
expect_length(lint_dir(the_dir, commented_code_linter(), parse_settings = FALSE), 0L)
})
test_that("typo in argument name gives helpful error", {
expect_error(lint_dir(litners = identity), "Found unknown arguments in `...`: `litners`")
})
test_that("linting empty directory passes", {
expect_length(lint_dir(withr::local_tempdir(), any_duplicated_linter()), 0L)
})
|
