1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
|
test_that("outer_negation_linter skips allowed usages", {
linter <- outer_negation_linter()
expect_lint("x <- any(y)", NULL, linter)
expect_lint("y <- all(z)", NULL, linter)
# extended usage of any is not covered
expect_lint("any(!a & b)", NULL, linter)
expect_lint("all(a | !b)", NULL, linter)
expect_lint("any(a, b)", NULL, linter)
expect_lint("all(b, c)", NULL, linter)
expect_lint("any(!a, b)", NULL, linter)
expect_lint("all(a, !b)", NULL, linter)
expect_lint("any(a, !b, na.rm = TRUE)", NULL, linter)
# ditto when na.rm is passed quoted
expect_lint("any(a, !b, 'na.rm' = TRUE)", NULL, linter)
})
test_that("outer_negation_linter blocks simple disallowed usages", {
linter <- outer_negation_linter()
not_all_msg <- rex::rex("!all(x) is better than any(!x)")
not_any_msg <- rex::rex("!any(x) is better than all(!x)")
expect_lint("any(!x)", not_all_msg, linter)
expect_lint("all(!foo(x))", not_any_msg, linter)
# na.rm doesn't change the recommendation
expect_lint("any(!x, na.rm = TRUE)", not_all_msg, linter)
# also catch nested usage
expect_lint("all(!(x + y))", not_any_msg, linter)
# catch when all inputs are negated
expect_lint("any(!x, !y)", not_all_msg, linter)
expect_lint("all(!x, !y, na.rm = TRUE)", not_any_msg, linter)
})
test_that("outer_negation_linter doesn't trigger on empty calls", {
linter <- outer_negation_linter()
# minimal version of issue
expect_lint("any()", NULL, linter)
# closer to what was is practically relevant, as another regression test
expect_lint("x %>% any()", NULL, linter)
})
test_that("lints vectorize", {
expect_lint(
trim_some("{
any(!x)
all(!y)
}"),
list(
list(rex::rex("!all(x)"), line_number = 2L),
list(rex::rex("!any(x)"), line_number = 3L)
),
outer_negation_linter()
)
})
|
