1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
|
test_that("redundant_ifelse_linter skips allowed usages", {
linter <- redundant_ifelse_linter()
expect_lint("ifelse(x > 5, 0, 2)", NULL, linter)
expect_lint("ifelse(x > 5, TRUE, NA)", NULL, linter)
expect_lint("ifelse(x > 5, FALSE, NA)", NULL, linter)
expect_lint("ifelse(x > 5, TRUE, TRUE)", NULL, linter)
expect_lint("ifelse(x > 5, 0L, 2L)", NULL, linter)
expect_lint("ifelse(x > 5, 0L, 10L)", NULL, linter)
})
test_that("redundant_ifelse_linter blocks simple disallowed usages", {
linter <- redundant_ifelse_linter()
expect_lint(
"ifelse(x > 5, TRUE, FALSE)",
rex::rex("Just use the logical condition (or its negation) directly"),
linter
)
expect_lint(
"ifelse(x > 5, FALSE, TRUE)",
rex::rex("Just use the logical condition (or its negation) directly"),
linter
)
# other ifelse equivalents from common packages
expect_lint(
"if_else(x > 5, TRUE, FALSE)",
rex::rex("Just use the logical condition (or its negation) directly"),
linter
)
expect_lint(
"fifelse(x > 5, FALSE, TRUE)",
rex::rex("Just use the logical condition (or its negation) directly"),
linter
)
})
test_that("redundant_ifelse_linter blocks usages equivalent to as.numeric, optionally", {
linter <- redundant_ifelse_linter()
expect_lint(
"ifelse(x > 5, 1L, 0L)",
rex::rex("Prefer as.integer(x) to ifelse(x, 1L, 0L)"),
linter
)
expect_lint(
"ifelse(x > 5, 0L, 1L)",
rex::rex("Prefer as.integer(!x) to ifelse(x, 0L, 1L)"),
linter
)
expect_lint(
"ifelse(x > 5, 1, 0)",
rex::rex("Prefer as.numeric(x) to ifelse(x, 1, 0)"),
linter
)
expect_lint(
"ifelse(x > 5, 0, 1)",
rex::rex("Prefer as.numeric(!x) to ifelse(x, 0, 1)"),
linter
)
# mixing int and num
expect_lint(
"ifelse(x > 5, 0, 1L)",
rex::rex("Prefer as.numeric(!x) to ifelse(x, 0, 1L)"),
linter
)
expect_lint(
"ifelse(x > 5, 0L, 1)",
rex::rex("Prefer as.numeric(!x) to ifelse(x, 0L, 1)"),
linter
)
expect_lint(
"ifelse(x > 5, 1, 0L)",
rex::rex("Prefer as.numeric(x) to ifelse(x, 1, 0L)"),
linter
)
expect_lint(
"ifelse(x > 5, 1L, 0)",
rex::rex("Prefer as.numeric(x) to ifelse(x, 1L, 0)"),
linter
)
# data.table/dplyr equivalents
expect_lint(
"dplyr::if_else(x > 5, 1L, 0L)",
rex::rex("Prefer as.integer(x) to if_else(x, 1L, 0L)"),
linter
)
expect_lint(
"data.table::fifelse(x > 5, 0L, 1L)",
rex::rex("Prefer as.integer(!x) to fifelse(x, 0L, 1L)"),
linter
)
expect_lint(
"if_else(x > 5, 1, 0)",
rex::rex("Prefer as.numeric(x) to if_else(x, 1, 0)"),
linter
)
expect_lint(
"fifelse(x > 5, 0, 1)",
rex::rex("Prefer as.numeric(!x) to fifelse(x, 0, 1)"),
linter
)
})
test_that("allow10 works as intended", {
linter <- redundant_ifelse_linter(allow10 = TRUE)
expect_lint("ifelse(x > 5, 1L, 0L)", NULL, linter)
expect_lint("ifelse(x > 5, 0L, 1L)", NULL, linter)
expect_lint("ifelse(x > 5, 1, 0)", NULL, linter)
expect_lint("ifelse(x > 5, 0, 1)", NULL, linter)
expect_lint("dplyr::if_else(x > 5, 1L, 0L)", NULL, linter)
expect_lint("data.table::fifelse(x > 5, 0L, 1L)", NULL, linter)
expect_lint("if_else(x > 5, 1, 0)", NULL, linter)
expect_lint("fifelse(x > 5, 0, 1)", NULL, linter)
})
test_that("ifelse(missing = ) gives correct lints", {
linter <- redundant_ifelse_linter()
expect_lint("if_else(x > 5, TRUE, FALSE, NA)", rex::rex("Just use the logical condition"), linter)
expect_lint("if_else(x > 5, TRUE, FALSE, TRUE)", NULL, linter)
expect_lint("if_else(x > 5, TRUE, FALSE, 5L)", NULL, linter)
expect_lint("if_else(x > 5, 1L, 0L, NA_integer_)", rex::rex("Prefer as.integer(x)"), linter)
expect_lint("if_else(x > 5, 1L, 0L, 2L)", NULL, linter)
expect_lint("if_else(x > 5, 1L, 0L, 5)", NULL, linter)
expect_lint("if_else(x > 5, 1, 0, NA_real_)", rex::rex("Prefer as.numeric(x)"), linter)
expect_lint("if_else(x > 5, 1, 0, 2)", NULL, linter)
expect_lint("if_else(x > 5, 1, 0, '5')", NULL, linter)
# TRUE/FALSE must be found in yes/no, not missing=
expect_lint("if_else(x > 5, 'a', TRUE, FALSE)", NULL, linter)
expect_lint("if_else(x > 5, 'a', 0L, 1L)", NULL, linter)
expect_lint("if_else(x > 5, 'a', 1, 0)", NULL, linter)
})
test_that("lints vectorize", {
expect_lint(
trim_some("{
ifelse(x > 0, TRUE, FALSE)
fifelse(y == 0, 1, 0)
}"),
list(
list("Just use the logical condition", line_number = 2L),
list(rex::rex("refer as.numeric(x)"), line_number = 3L)
),
redundant_ifelse_linter()
)
})
|
