1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
|
test_that("scalar_in_linter skips allowed usages", {
linter <- scalar_in_linter()
expect_lint("x %in% y", NULL, linter)
expect_lint("y %in% c('a', 'b')", NULL, linter)
expect_lint("c('a', 'b') %in% x", NULL, linter)
expect_lint("z %in% 1:3", NULL, linter)
# scalars on LHS are fine (often used as `"col" %in% names(DF)`)
expect_lint("3L %in% x", NULL, linter)
# this should be is.na(x), but it more directly uses the "always TRUE/FALSE, _not_ NA"
# aspect of %in%, so we delegate linting here to equals_na_linter()
expect_lint("x %in% NA", NULL, linter)
expect_lint("x %in% NA_character_", NULL, linter)
})
test_that("scalar_in_linter blocks simple disallowed usages", {
linter <- scalar_in_linter(in_operators = c("%chin%", "%notin%"))
lint_msg <- rex::rex("Use comparison operators (e.g. ==, !=, etc.) to match length-1 scalars instead of")
expect_lint("x %in% 1", lint_msg, linter)
expect_lint("x %chin% 'a'", lint_msg, linter)
expect_lint("x %notin% 1", lint_msg, linter)
})
test_that("scalar_in_linter blocks or skips based on configuration", {
linter_default <- scalar_in_linter()
linter_config <- scalar_in_linter(in_operators = "%notin%")
lint_msg <- rex::rex("Use comparison operators (e.g. ==, !=, etc.) to match length-1 scalars instead of")
# default
expect_lint("x %in% 1", lint_msg, linter_default)
expect_lint("x %notin% 1", NULL, linter_default)
expect_lint("x %notin% y", NULL, linter_default)
# configured
expect_lint("x %in% 1", lint_msg, linter_config)
expect_lint("x %notin% 1", lint_msg, linter_config)
expect_lint("x %notin% y", NULL, linter_config)
})
test_that("multiple lints are generated correctly", {
linter <- scalar_in_linter(in_operators = "%chin%")
expect_lint(
trim_some('{
x %in% 1
y %chin% "a"
}'),
list(
list("%in%", line_number = 2L),
list("%chin%", line_number = 3L)
),
linter
)
})
|
