1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
|
test_that("terminal_close_linter skips allowed cases", {
linter <- terminal_close_linter()
lines <- trim_some("
foo <- function(bar) {
tmp <- tempfile()
on.exit(close(tmp))
writeLines(bar, tmp)
return(invisible())
}
")
expect_lint(lines, NULL, linter)
lines <- trim_some("
foo <- function(bar) {
close <- bar + 1
return(close)
}
")
expect_lint(lines, NULL, linter)
lines <- trim_some("
foo <- function(bar) {
close <- bar + 1
close
}
")
expect_lint(lines, NULL, linter)
})
test_that("terminal_close_linter blocks simple cases", {
linter <- terminal_close_linter()
lint_msg <- rex::rex("Use on.exit(close(x)) to close connections")
expect_lint(
trim_some("
foo <- function(bar) {
tmp <- tempfile()
writeLines(bar, tmp)
return(close(tmp))
}
"),
list(lint_msg, line_number = 4L, column_number = 3L),
linter
)
expect_lint(
trim_some("
foo <- function(bar) {
tmp <- tempfile()
writeLines(bar, tmp)
close(tmp)
}
"),
list(lint_msg, line_number = 4L, column_number = 3L),
linter
)
# When multiple terminations happen, only lint the one
expect_lint(
trim_some("
foo <- function(bar) {
tmp1 <- tempfile()
tmp2 <- tempfile()
writeLines(bar, tmp1)
writeLines(bar, tmp2)
close(tmp1)
close(tmp2)
}
"),
list(lint_msg, line_number = 7L, column_number = 3L),
linter
)
})
|
