1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
|
test_that("trailing_blank_lines_linter doesn't block allowed usages", {
linter <- trailing_blank_lines_linter()
expect_lint("blah", NULL, linter)
expect_lint("blah <- 1 ", NULL, linter)
expect_lint("blah <- 1\nblah", NULL, linter)
expect_lint("blah <- 1\nblah\n \n blah", NULL, linter)
tmp <- withr::local_tempfile(lines = "lm(y ~ x)")
expect_lint(file = tmp, checks = NULL, linters = linter)
})
test_that("trailing_blank_lines_linter detects disallowed usages", {
linter <- trailing_blank_lines_linter()
lint_msg <- rex::rex("Remove trailing blank lines.")
expect_lint("blah <- 1\n", lint_msg, linter)
expect_lint("blah <- 1\n ", lint_msg, linter)
expect_lint("blah <- 1\n \n ", list(lint_msg, lint_msg), linter)
expect_lint("blah <- 1\n\n", list(lint_msg, lint_msg), linter)
expect_lint("blah <- 1\n\t\n", list(lint_msg, lint_msg), linter)
# Construct a test file without terminal newline
# cf. test-get_source_expressions.R
tmp2 <- withr::local_tempfile()
cat("lm(y ~ x)", file = tmp2)
expect_lint(
file = tmp2,
checks = list(
message = rex::rex("Add a terminal newline."),
line_number = 1L,
column_number = 10L
),
linters = linter
)
})
test_that("trailing_blank_lines_linter detects missing terminal newlines in Rmd/qmd docs", {
linter <- trailing_blank_lines_linter()
lint_msg <- rex::rex("Add a terminal newline")
tmp3 <- withr::local_tempfile(fileext = ".Rmd")
cat(
trim_some(
'---
title: "Some file"
---
```{r}
abc = 123
```
```{r child="some-file.Rmd"}
```'
),
file = tmp3
)
expect_lint(
file = tmp3,
# We can't get 4 here because the line is NA-masked in get_source_expressions(), so no line length info exists.
checks = list(lint_msg, line_number = 10L, column_number = 1L),
linters = linter
)
# Construct an Rmd file without R code (#1415)
tmp4 <- withr::local_tempfile(fileext = ".Rmd")
cat(
trim_some(
'---
title: "Some file"
---
No code and no terminal newline'
),
file = tmp4
)
expect_lint(
file = tmp4,
# We can't get 4 here because the line is NA-masked in get_source_expressions(), so no line length info exists.
checks = list(lint_msg, line_number = 5L, column_number = 1L),
linters = linter
)
# Construct a qmd file without terminal newline
tmp5 <- withr::local_tempfile(fileext = ".qmd")
cat(
trim_some(
'---
title: "Some file"
---
```{r}
abc = 123
```
```{r child="some-file.qmd"}
```'
),
file = tmp5
)
expect_lint(
file = tmp5,
# We can't get 4 here because the line is NA-masked in get_source_expressions(), so no line length info exists.
checks = list(lint_msg, line_number = 10L, column_number = 1L),
linters = linter
)
})
test_that("blank lines in knitr chunks produce lints", {
linter <- trailing_blank_lines_linter()
lint_msg <- rex::rex("Remove trailing blank lines.")
tmp6 <- withr::local_tempfile(
fileext = ".Rmd",
lines = trim_some(
'---
title: "Some file"
---
```{r}
abc = 123
```
\n'
)
)
expect_lint(
file = tmp6,
checks = list(lint_msg, line_number = 7L, column_number = 1L),
linters = linter
)
tmp7 <- withr::local_tempfile(
fileext = ".qmd",
lines = trim_some(
'---
title: "Some file"
---
```{r}
abc = 123
```
\n'
)
)
expect_lint(
file = tmp7,
checks = list(
list(lint_msg, line_number = 7L, column_number = 1L),
list(lint_msg, line_number = 8L, column_number = 1L),
list(lint_msg, line_number = 9L, column_number = 1L)
),
linters = linter
)
})
|
