1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
|
test_that("yoda_test_linter skips allowed usages", {
linter <- yoda_test_linter()
expect_lint("expect_equal(x, 2)", NULL, linter)
# namespace qualification doesn't matter
expect_lint("testthat::expect_identical(x, 'a')", NULL, linter)
# two variables can't be distinguished which is expected/actual (without
# playing quixotic games trying to parse that out from variable names)
expect_lint("expect_equal(x, y)", NULL, linter)
})
test_that("yoda_test_linter blocks simple disallowed usages", {
linter <- yoda_test_linter()
lint_msg <- rex::rex("Compare objects in tests in the order 'actual', 'expected', not the reverse.")
expect_lint("expect_equal(2, x)", lint_msg, linter)
expect_lint("testthat::expect_identical('a', x)", lint_msg, linter)
expect_lint("expect_setequal(2, x)", lint_msg, linter)
# complex literals are slightly odd
expect_lint("expect_equal(2 + 1i, x)", lint_msg, linter)
})
test_that("yoda_test_linter ignores strings in $ expressions", {
linter <- yoda_test_linter()
# the "key" here shows up at the same level of the parse tree as plain "key" normally would
expect_lint('expect_equal(x$"key", 2)', NULL, linter)
expect_lint('expect_equal(x@"key", 2)', NULL, linter)
})
# if we only inspect the first argument & ignore context, get false positives
local({
pipes <- pipes(exclude = c("%<>%", "%$%"))
linter <- yoda_test_linter()
patrick::with_parameters_test_that(
"yoda_test_linter ignores usage in pipelines",
expect_lint(sprintf("foo() %s expect_identical(2)", pipe), NULL, linter),
pipe = pipes,
.test_name = names(pipes)
)
})
test_that("yoda_test_linter throws a special message for placeholder tests", {
expect_lint(
"expect_equal(1, 1)",
rex::rex("Avoid storing placeholder tests like expect_equal(1, 1)"),
yoda_test_linter()
)
})
test_that("lints vectorize", {
expect_lint(
trim_some("{
expect_equal(1, 1)
expect_equal(2, foo(x))
}"),
list(
list("Avoid storing placeholder tests", line_number = 2L),
list("Compare objects in tests in the order 'actual', 'expected'", line_number = 3L)
),
yoda_test_linter()
)
})
|
