1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325
|
.__LINTERS__. <- new.env(parent = emptyenv())
##' Add a Linter
##'
##' Add a linter, to be used in subsequent calls to [lint()].
##'
##' @param name The name of the linter, as a string.
##' @param linter A [linter()].
##' @export
##' @example examples/example-linter.R
addLinter <- function(name, linter) {
assign(name, linter, envir = .__LINTERS__.)
}
##' Create a Linter
##'
##' Generate a linter, which can identify errors or problematic regions in a
##' project.
##'
##' @param apply Function that, given the content of a file, returns the indices
##' at which problems were found.
##' @param takes Function that, given a set of paths, returns the subset of
##' paths that this linter uses.
##' @param message Function that, given content and lines, returns an
##' informative message for the user. Typically generated with
##' [makeLinterMessage()].
##' @param suggestion String giving a prescribed fix for the linted problem.
##' @export
##' @example examples/example-linter.R
linter <- function(apply, takes, message, suggestion) {
result <- list(
apply = apply,
takes = takes,
message = message,
suggestion = suggestion
)
class(result) <- "linter"
result
}
getLinterApplicableFiles <- function(linter, files) {
result <- linter$takes(files)
if (is.numeric(result) || is.logical(result)) {
files[result]
} else {
result
}
}
applyLinter <- function(linter, ...) {
result <- linter$apply(...)
if (is.logical(result)) {
output <- which(result)
} else {
output <- as.numeric(result)
}
attributes(output) <- attributes(result)
output
}
isRCodeFile <- function(path) {
grepl("\\.[rR]$|\\.[rR]md$|\\.[rR]nw$", path)
}
addLinter("absolute.paths", linter(
apply = function(content, ...) {
content <- stripComments(content)
which(hasAbsolutePaths(content))
},
takes = isRCodeFile,
message = function(content, lines) {
makeLinterMessage("The following lines contain absolute paths",
content,
lines)
},
suggestion = "Paths should be to files within the project directory."
))
addLinter("filepath.capitalization", linter(
apply = function(content, project, path, files) {
content <- stripComments(content)
# Extract references between bounding (unescaped) quotes.
extractQuoted <- function(regex) {
matches <- gregexpr(regex, content, perl = TRUE)
results <- vector("list", length(content))
for (i in seq_along(matches)) {
x <- matches[[i]]
if (x[[1]] == -1L || length(x) %% 2 != 0) next
starts <- x[seq(1, length(x), by = 2)]
ends <- x[seq(2, length(x), by = 2)]
results[[i]] <- character(length(starts))
for (j in seq_along(starts)) {
results[[i]][[j]] <- substring(content[i], starts[j] + 1, ends[j] - 1)
}
}
results
}
# Extract targets from Markdown links.
extractLinked <- function() {
regex <- "\\]\\(.*?\\)"
matches <- gregexpr(regex, content, perl = TRUE)
results <- vector("list", length(content))
for (i in seq_along(matches)) {
x <- matches[[i]]
if (x[[1]] == -1L) next
results[[i]] <- character(length(x))
attr <- attributes(x)
for (j in seq_along(x)) {
raw <- x[[j]]
raw.length <- attr$match.length[[j]]
# skip past "](" and discard ")"
start <- as.integer(raw) + 2
end <- as.integer(raw) + raw.length - 2
results[[i]][[j]] <- substring(content[i], start, end)
}
}
results
}
# Inferred files within source documents; between matching quotes or in
# something that looks like a Markdown link.
inferredFiles <- list(
"single.quotes" = extractQuoted("(?!\\\\)\'"),
"double.quotes" = extractQuoted("(?!\\\\)\""),
"markdown.links" = extractLinked()
)
## Replace '\' with '/' in filepaths for consistency in comparisons
inferredFiles <- lapply(inferredFiles, function(x) {
lapply(x, function(xx) {
gsub("\\\\", "/", xx, perl = TRUE)
})
})
# Compare in case sensitive, case insensitive fashion
projectFiles <- files
projectFilesLower <- tolower(files)
badLines <- lapply(inferredFiles, function(regex) {
lapply(regex, function(x) {
which(
# Only examine paths containing a slash to reduce false positives
grepl("/", x, fixed = TRUE) &
(tolower(x) %in% projectFilesLower) &
(!(x %in% projectFiles))
)
})
})
indices <- Reduce(union, lapply(badLines, function(x) {
which(sapply(x, length) > 0)
}))
if (!length(indices)) return(integer())
from <- lapply(inferredFiles, function(x) x[indices])
to <- lapply(from, function(x) {
lapply(x, function(xx) {
projectFiles[tolower(xx) == projectFilesLower]
})
})
messages <- lapply(seq_along(from), function(regex) {
lapply(seq_along(regex), function(i) {
if (length(from[[regex]][[i]]))
paste(collapse = ", ",
paste("[",
sQuote(from[[regex]][[i]]),
" -> ",
sQuote(to[[regex]][[i]]),
"]", sep = "")
)
else
""
})
})
transposed <- transposeList(messages)
lint <- sapply(transposed, function(x) {
paste(x[x != ""], collapse = ", ")
})
indices <- as.numeric(indices)
attr(indices, "lint") <- lint
indices
},
takes = isRCodeFile,
message = function(content, lines) {
makeLinterMessage(
"The following lines contain paths to files not matching in case sensitivity",
content,
lines
)
},
suggestion = "Filepaths are case-sensitive on deployment server."
))
addLinter("browser", linter(
apply = function(content, ...) {
content <- stripComments(content)
which(hasBrowserCalls(content))
},
takes = isRCodeFile,
message = function(content, lines) {
makeLinterMessage("The following lines contain the browser() debugging function",
content,
lines)
},
suggestion = "The browser() debugging function should be removed."
))
addLinter("browseURL", linter(
apply = function(content, ...) {
content <- stripComments(content)
which(hasBrowseURLCalls(content))
},
takes = isRCodeFile,
message = function(content, lines) {
makeLinterMessage("The following lines contain calls to the browseURL function",
content,
lines)
},
suggestion = "Remove browseURL calls; browseURL does not work in deployed applications."
))
stripComments <- function(content) {
gsub("#.*", "", content, perl = TRUE)
}
hasBrowserCalls <- function(content) {
# look for calls to browser(); they will cause a debug halt, which is almost
# never wanted in a production application
grepl("\\bbrowser\\([^)]*\\)", content, perl = TRUE)
}
hasBrowseURLCalls <- function(content) {
# look for calls to browseURL(); browsers can't be opened on the server in
# deployed applications
grepl("\\bbrowseURL\\([^)]*\\)", content, perl = TRUE)
}
hasAbsolutePaths <- function(content) {
regex <- c(
"\\[(.*?)\\]\\(\\s*[a-zA-Z]:/[^\"\']", ## windows-style markdown references [Some image](C:/...)
"\\[(.*?)\\]\\(\\s*/[^/]", ## unix-style markdown references [Some image](/Users/...)
NULL ## so we don't worry about commas above
)
regexResults <- as.logical(Reduce(`+`, lapply(regex, function(rex) {
grepl(rex, content, perl = TRUE)
})))
# Strip out all strings in the document, and check to see if any of them
# resolve to absolute paths on the system.
sQuoteRegex <- "['](?:(?:\\\\.)|(?:[^'\\\\]))*?[']"
dQuoteRegex <- '["](?:(?:\\\\.)|(?:[^"\\\\]))*?["]'
extractedStrings <- lapply(c(sQuoteRegex, dQuoteRegex), function(regex) {
matches <- gregexpr(regex, content, perl = TRUE)
lapply(seq_along(matches), function(i) {
match <- matches[[i]]
if (c(match[[1]]) == -1L) return(character())
starts <- as.integer(match) + 1
ends <- starts + attr(match, "match.length") - 3
substring(content[[i]], starts, ends)
})
})
strings <- vector("list", length(extractedStrings[[1]]))
for (i in seq_along(extractedStrings[[1]])) {
strings[[i]] <- unique(c(extractedStrings[[1]][[i]], extractedStrings[[2]][[i]]))
strings[[i]] <- strings[[i]][nchar(strings[[i]]) >= 5]
}
lineHasAbsolutePath <- unlist(lapply(strings, function(x) {
any(
grepl("^/|^[a-zA-Z]:/|^~", x, perl = TRUE) &
file.exists(x) &
!dirExists(x) &
vapply(gregexpr("[~/]", x, perl = TRUE), USE.NAMES = FALSE, FUN.VALUE = numeric(1), length) >= 3
)
}))
as.logical(lineHasAbsolutePath + regexResults)
}
noMatch <- function(x) {
identical(attr(x, "match.length"), -1L)
}
transposeList <- function(list) {
unname(as.list(
as.data.frame(
t(
as.matrix(
as.data.frame(list, stringsAsFactors = FALSE)
)
), stringsAsFactors = FALSE)
))
}
|