1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
|
# frozen_string_literal: true
require "abstract_unit"
require "action_controller/metal/strong_parameters"
class LogOnUnpermittedParamsTest < ActiveSupport::TestCase
def setup
ActionController::Parameters.action_on_unpermitted_parameters = :log
end
def teardown
ActionController::Parameters.action_on_unpermitted_parameters = false
end
test "logs on unexpected param" do
request_params = { book: { pages: 65 }, fishing: "Turnips" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameter: :fishing. Context: { action: my_action, controller: my_controller }") do
params.permit(book: [:pages])
end
end
test "logs on unexpected params" do
request_params = { book: { pages: 65 }, fishing: "Turnips", car: "Mercedes" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameters: :fishing, :car. Context: { action: my_action, controller: my_controller }") do
params.permit(book: [:pages])
end
end
test "logs on unexpected nested param" do
params = ActionController::Parameters.new(
book: { pages: 65, title: "Green Cats and where to find then." })
assert_logged("Unpermitted parameter: :title. Context: { }") do
params.permit(book: [:pages])
end
end
test "logs on unexpected nested params" do
params = ActionController::Parameters.new(
book: { pages: 65, title: "Green Cats and where to find then.", author: "G. A. Dog" })
assert_logged("Unpermitted parameters: :title, :author. Context: { }") do
params.permit(book: [:pages])
end
end
test "logs on unexpected nested params with require" do
request_params = { book: { pages: 65, title: "Green Cats and where to find then.", author: "G. A. Dog" } }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameters: :title, :author. Context: { action: my_action, controller: my_controller }") do
params.require(:book).permit(:pages)
end
end
test "logs on unexpected param with deep_dup" do
request_params = { book: { pages: 3, author: "YY" } }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameter: :author. Context: { action: my_action, controller: my_controller }") do
params.deep_dup.permit(book: [:pages])
end
end
test "logs on unexpected params with slice" do
request_params = { food: "tomato", fishing: "Turnips", car: "Mercedes", music: "No. 9" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameters: :fishing, :car. Context: { action: my_action, controller: my_controller }") do
params.slice(:food, :fishing, :car).permit(:food)
end
end
test "logs on unexpected params with except" do
request_params = { food: "tomato", fishing: "Turnips", car: "Mercedes", music: "No. 9" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameters: :fishing, :car. Context: { action: my_action, controller: my_controller }") do
params.except(:music).permit(:food)
end
end
test "logs on unexpected params with extract!" do
request_params = { food: "tomato", fishing: "Turnips", car: "Mercedes", music: "No. 9" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameters: :fishing, :car. Context: { action: my_action, controller: my_controller }") do
params.extract!(:food, :fishing, :car).permit(:food)
end
assert_logged("Unpermitted parameter: :music. Context: { action: my_action, controller: my_controller }") do
params.permit(:food)
end
end
test "logs on unexpected params with transform_values" do
request_params = { food: "tomato", fishing: "Turnips", car: "Mercedes", music: "No. 9" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameters: :fishing, :car, :music. Context: { action: my_action, controller: my_controller }") do
params.transform_values { |v| v.upcase }.permit(:food)
end
end
test "logs on unexpected params with transform_keys" do
request_params = { food: "tomato", fishing: "Turnips", car: "Mercedes", music: "No. 9" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameters: :FISHING, :CAR, :MUSIC. Context: { action: my_action, controller: my_controller }") do
params.transform_keys { |k| k.upcase }.permit(:FOOD)
end
end
test "logs on unexpected param with deep_transform_keys" do
request_params = { book: { pages: 48, title: "Hope" } }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameter: :TITLE. Context: { action: my_action, controller: my_controller }") do
params.deep_transform_keys { |k| k.upcase }.permit(BOOK: [:PAGES])
end
end
test "logs on unexpected param with select" do
request_params = { food: "tomato", fishing: "Turnips", car: "Mercedes", music: "No. 9" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameter: :music. Context: { action: my_action, controller: my_controller }") do
params.select { |k| k == "music" }.permit(:food)
end
end
test "logs on unexpected params with reject" do
request_params = { food: "tomato", fishing: "Turnips", car: "Mercedes", music: "No. 9" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameters: :fishing, :car. Context: { action: my_action, controller: my_controller }") do
params.reject { |k| k == "music" }.permit(:food)
end
end
test "logs on unexpected param with compact" do
request_params = { food: "tomato", fishing: "Turnips", car: nil, music: nil }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameter: :fishing. Context: { action: my_action, controller: my_controller }") do
params.compact.permit(:food)
end
end
test "logs on unexpected param with merge" do
request_params = { food: "tomato" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameter: :album. Context: { action: my_action, controller: my_controller }") do
params.merge(album: "My favorites").permit(:food)
end
end
test "logs on unexpected param with reverse_merge" do
request_params = { food: "tomato" }
context = { "action" => "my_action", "controller" => "my_controller" }
params = ActionController::Parameters.new(request_params, context)
assert_logged("Unpermitted parameter: :album. Context: { action: my_action, controller: my_controller }") do
params.reverse_merge(album: "My favorites").permit(:food)
end
end
private
def assert_logged(message)
old_logger = ActionController::Base.logger
log = StringIO.new
ActionController::Base.logger = Logger.new(log)
begin
yield
log.rewind
assert_match message, log.read
ensure
ActionController::Base.logger = old_logger
end
end
end
|
