1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664
|
# frozen_string_literal: true
require "abstract_unit"
class Workshop
extend ActiveModel::Naming
include ActiveModel::Conversion
OUT_OF_SCOPE_BLOCK = proc do
raise "Not executed in controller's context" unless RedirectController === self
request.original_url
end
attr_accessor :id
def initialize(id)
@id = id
end
def persisted?
id.present?
end
def to_s
id.to_s
end
end
class RedirectController < ActionController::Base
# empty method not used anywhere to ensure methods like
# `status` and `location` aren't called on `redirect_to` calls
def status; raise "Should not be called!"; end
def location; raise "Should not be called!"; end
def simple_redirect
redirect_to action: "hello_world"
end
def redirect_with_status
redirect_to(action: "hello_world", status: 301)
end
def redirect_with_status_hash
redirect_to({ action: "hello_world" }, { status: 301 })
end
def redirect_with_protocol
redirect_to action: "hello_world", protocol: "https"
end
def url_redirect_with_status
redirect_to("http://www.example.com", status: :moved_permanently)
end
def url_redirect_with_status_hash
redirect_to("http://www.example.com", status: 301)
end
def relative_url_redirect_with_status
redirect_to("/things/stuff", status: :found)
end
def relative_url_redirect_with_status_hash
redirect_to("/things/stuff", status: 301)
end
def redirect_back_with_status
redirect_back_or_to "/things/stuff", status: 307
end
def redirect_back_with_status_and_fallback_location_to_another_host
redirect_back_or_to "http://www.rubyonrails.org/", status: 307
end
def safe_redirect_back_with_status
redirect_back_or_to "/things/stuff", status: 307, allow_other_host: false
end
def safe_redirect_back_with_status_and_fallback_location_to_another_host
redirect_back_or_to "http://www.rubyonrails.org/", status: 307, allow_other_host: false
end
def safe_redirect_to_root
redirect_to url_from("/")
end
def unsafe_redirect
redirect_to "http://www.rubyonrails.org/"
end
def unsafe_redirect_back
redirect_back_or_to "http://www.rubyonrails.org/"
end
def unsafe_redirect_malformed
redirect_to "http:///www.rubyonrails.org/"
end
def unsafe_redirect_protocol_relative_double_slash
redirect_to "//www.rubyonrails.org/"
end
def unsafe_redirect_protocol_relative_triple_slash
redirect_to "///www.rubyonrails.org/"
end
def unsafe_redirect_with_illegal_http_header_value_character
redirect_to "javascript:alert(document.domain)\b", allow_other_host: true
end
def only_path_redirect
redirect_to action: "other_host", only_path: true
end
def safe_redirect_with_fallback
redirect_to url_from(params[:redirect_url]) || "/fallback"
end
def redirect_back_with_explicit_fallback_kwarg
redirect_back(fallback_location: "/things/stuff", status: 307)
end
def host_redirect
redirect_to action: "other_host", only_path: false, host: "other.test.host"
end
def module_redirect
redirect_to controller: "module_test/module_redirect", action: "hello_world"
end
def redirect_to_url
redirect_to "http://www.rubyonrails.org/"
end
def redirect_to_url_with_stringlike
stringlike = Object.new
def stringlike.to_str
"http://www.rubyonrails.org/"
end
redirect_to stringlike
end
def redirect_to_url_with_unescaped_query_string
redirect_to "http://example.com/query?status=new"
end
def redirect_to_url_with_complex_scheme
redirect_to "x-test+scheme.complex:redirect"
end
def redirect_to_url_with_network_path_reference
redirect_to "//www.rubyonrails.org/"
end
def redirect_to_existing_record
redirect_to Workshop.new(5)
end
def redirect_to_new_record
redirect_to Workshop.new(nil)
end
def redirect_to_nil
redirect_to nil
end
def redirect_to_polymorphic
redirect_to [:internal, Workshop.new(5)]
end
def redirect_to_polymorphic_string_args
redirect_to ["internal", Workshop.new(5)]
end
def redirect_to_params
redirect_to ActionController::Parameters.new(status: 200, protocol: "javascript", f: "%0Aeval(name)")
end
def redirect_to_with_block
redirect_to proc { "http://www.rubyonrails.org/" }
end
def redirect_to_with_block_and_assigns
@url = "http://www.rubyonrails.org/"
redirect_to proc { @url }
end
def redirect_to_with_block_and_options
redirect_to proc { { action: "hello_world" } }
end
def redirect_to_out_of_scope_block
redirect_to Workshop::OUT_OF_SCOPE_BLOCK
end
def redirect_with_header_break
redirect_to "/lol\r\nwat"
end
def redirect_with_null_bytes
redirect_to "\000/lol\r\nwat"
end
def rescue_errors(e) raise e end
private
def dashboard_url(id, message)
url_for action: "dashboard", params: { "id" => id, "message" => message }
end
end
class RedirectTest < ActionController::TestCase
tests RedirectController
def test_simple_redirect
get :simple_redirect
assert_response :redirect
assert_equal "http://test.host/redirect/hello_world", redirect_to_url
end
def test_redirect_with_header_break
get :redirect_with_header_break
assert_response :redirect
assert_equal "http://test.host/lolwat", redirect_to_url
end
def test_redirect_with_null_bytes
get :redirect_with_null_bytes
assert_response :redirect
assert_equal "http://test.host/lolwat", redirect_to_url
end
def test_redirect_with_no_status
get :simple_redirect
assert_response 302
assert_equal "http://test.host/redirect/hello_world", redirect_to_url
end
def test_redirect_with_status
get :redirect_with_status
assert_response 301
assert_equal "http://test.host/redirect/hello_world", redirect_to_url
end
def test_redirect_with_status_hash
get :redirect_with_status_hash
assert_response 301
assert_equal "http://test.host/redirect/hello_world", redirect_to_url
end
def test_redirect_with_protocol
get :redirect_with_protocol
assert_response 302
assert_equal "https://test.host/redirect/hello_world", redirect_to_url
end
def test_url_redirect_with_status
get :url_redirect_with_status
assert_response 301
assert_equal "http://www.example.com", redirect_to_url
end
def test_url_redirect_with_status_hash
get :url_redirect_with_status_hash
assert_response 301
assert_equal "http://www.example.com", redirect_to_url
end
def test_relative_url_redirect_with_status
get :relative_url_redirect_with_status
assert_response 302
assert_equal "http://test.host/things/stuff", redirect_to_url
end
def test_relative_url_redirect_with_status_hash
get :relative_url_redirect_with_status_hash
assert_response 301
assert_equal "http://test.host/things/stuff", redirect_to_url
end
def test_relative_url_redirect_host_with_port
request.host = "test.host:1234"
get :relative_url_redirect_with_status
assert_response 302
assert_equal "http://test.host:1234/things/stuff", redirect_to_url
end
def test_simple_redirect_using_options
get :host_redirect
assert_response :redirect
assert_redirected_to action: "other_host", only_path: false, host: "other.test.host"
end
def test_module_redirect
get :module_redirect
assert_response :redirect
assert_redirected_to "http://test.host/module_test/module_redirect/hello_world"
end
def test_module_redirect_using_options
get :module_redirect
assert_response :redirect
assert_redirected_to controller: "module_test/module_redirect", action: "hello_world"
end
def test_redirect_to_url
get :redirect_to_url
assert_response :redirect
assert_redirected_to "http://www.rubyonrails.org/"
end
def test_redirect_to_url_with_stringlike
get :redirect_to_url_with_stringlike
assert_response :redirect
assert_redirected_to "http://www.rubyonrails.org/"
end
def test_redirect_to_url_with_unescaped_query_string
get :redirect_to_url_with_unescaped_query_string
assert_response :redirect
assert_redirected_to "http://example.com/query?status=new"
end
def test_redirect_to_url_with_complex_scheme
get :redirect_to_url_with_complex_scheme
assert_response :redirect
assert_equal "x-test+scheme.complex:redirect", redirect_to_url
end
def test_redirect_to_url_with_network_path_reference
get :redirect_to_url_with_network_path_reference
assert_response :redirect
assert_equal "//www.rubyonrails.org/", redirect_to_url
end
def test_redirect_back
referer = "http://www.example.com/coming/from"
@request.env["HTTP_REFERER"] = referer
get :redirect_back_with_status
assert_response 307
assert_equal referer, redirect_to_url
end
def test_redirect_back_with_no_referer
get :redirect_back_with_status
assert_response 307
assert_equal "http://test.host/things/stuff", redirect_to_url
end
def test_redirect_back_with_no_referer_redirects_to_another_host
get :redirect_back_with_status_and_fallback_location_to_another_host
assert_response 307
assert_equal "http://www.rubyonrails.org/", redirect_to_url
end
def test_safe_redirect_back_from_other_host
@request.env["HTTP_REFERER"] = "http://another.host/coming/from"
get :safe_redirect_back_with_status
assert_response 307
assert_equal "http://test.host/things/stuff", redirect_to_url
end
def test_safe_redirect_back_from_the_same_host
referer = "http://test.host/coming/from"
@request.env["HTTP_REFERER"] = referer
get :safe_redirect_back_with_status
assert_response 307
assert_equal referer, redirect_to_url
end
def test_safe_redirect_back_with_no_referer
get :safe_redirect_back_with_status
assert_response 307
assert_equal "http://test.host/things/stuff", redirect_to_url
end
def test_safe_redirect_back_with_no_referer_redirects_to_another_host
get :safe_redirect_back_with_status_and_fallback_location_to_another_host
assert_response 307
assert_equal "http://www.rubyonrails.org/", redirect_to_url
end
def test_safe_redirect_to_root
get :safe_redirect_to_root
assert_equal "http://test.host/", redirect_to_url
end
def test_redirect_back_with_explicit_fallback_kwarg
referer = "http://www.example.com/coming/from"
@request.env["HTTP_REFERER"] = referer
get :redirect_back_with_explicit_fallback_kwarg
assert_response 307
assert_equal referer, redirect_to_url
end
def test_redirect_to_record
with_routing do |set|
set.draw do
resources :workshops
ActionDispatch.deprecator.silence do
get ":controller/:action"
end
end
get :redirect_to_existing_record
assert_equal "http://test.host/workshops/5", redirect_to_url
assert_redirected_to Workshop.new(5)
get :redirect_to_new_record
assert_equal "http://test.host/workshops", redirect_to_url
assert_redirected_to Workshop.new(nil)
end
end
def test_polymorphic_redirect
with_routing do |set|
set.draw do
namespace :internal do
resources :workshops
end
ActionDispatch.deprecator.silence do
get ":controller/:action"
end
end
get :redirect_to_polymorphic
assert_equal "http://test.host/internal/workshops/5", redirect_to_url
assert_redirected_to [:internal, Workshop.new(5)]
end
end
def test_polymorphic_redirect_with_string_args
with_routing do |set|
set.draw do
namespace :internal do
resources :workshops
end
ActionDispatch.deprecator.silence do
get ":controller/:action"
end
end
error = assert_raises(ArgumentError) do
get :redirect_to_polymorphic_string_args
end
assert_equal("Please use symbols for polymorphic route arguments.", error.message)
end
end
def test_redirect_to_nil
error = assert_raise(ActionController::ActionControllerError) do
get :redirect_to_nil
end
assert_equal "Cannot redirect to nil!", error.message
end
def test_redirect_to_params
error = assert_raise(ActionController::UnfilteredParameters) do
get :redirect_to_params
end
assert_equal "unable to convert unpermitted parameters to hash", error.message
end
def test_redirect_to_with_block
get :redirect_to_with_block
assert_response :redirect
assert_redirected_to "http://www.rubyonrails.org/"
end
def test_redirect_to_with_block_and_assigns
get :redirect_to_with_block_and_assigns
assert_response :redirect
assert_redirected_to "http://www.rubyonrails.org/"
end
def test_redirect_to_out_of_scope_block
get :redirect_to_out_of_scope_block
assert_response :redirect
assert_redirected_to "http://test.host/redirect/redirect_to_out_of_scope_block"
end
def test_redirect_to_with_block_and_accepted_options
with_routing do |set|
set.draw do
ActionDispatch.deprecator.silence do
get ":controller/:action"
end
end
get :redirect_to_with_block_and_options
assert_response :redirect
assert_redirected_to "http://test.host/redirect/hello_world"
end
end
def test_unsafe_redirect
with_raise_on_open_redirects do
error = assert_raise(ActionController::Redirecting::UnsafeRedirectError) do
get :unsafe_redirect
end
assert_equal "Unsafe redirect to \"http://www.rubyonrails.org/\", pass allow_other_host: true to redirect anyway.", error.message
end
end
def test_unsafe_redirect_back
with_raise_on_open_redirects do
error = assert_raise(ActionController::Redirecting::UnsafeRedirectError) do
get :unsafe_redirect_back
end
assert_equal "Unsafe redirect to \"http://www.rubyonrails.org/\", pass allow_other_host: true to redirect anyway.", error.message
end
end
def test_unsafe_redirect_with_malformed_url
with_raise_on_open_redirects do
error = assert_raise(ActionController::Redirecting::UnsafeRedirectError) do
get :unsafe_redirect_malformed
end
assert_equal "Unsafe redirect to \"http:///www.rubyonrails.org/\", pass allow_other_host: true to redirect anyway.", error.message
end
end
def test_unsafe_redirect_with_protocol_relative_double_slash_url
with_raise_on_open_redirects do
error = assert_raise(ActionController::Redirecting::UnsafeRedirectError) do
get :unsafe_redirect_protocol_relative_double_slash
end
assert_equal "Unsafe redirect to \"//www.rubyonrails.org/\", pass allow_other_host: true to redirect anyway.", error.message
end
end
def test_unsafe_redirect_with_protocol_relative_triple_slash_url
with_raise_on_open_redirects do
error = assert_raise(ActionController::Redirecting::UnsafeRedirectError) do
get :unsafe_redirect_protocol_relative_triple_slash
end
assert_equal "Unsafe redirect to \"///www.rubyonrails.org/\", pass allow_other_host: true to redirect anyway.", error.message
end
end
def test_unsafe_redirect_with_illegal_http_header_value_character
with_raise_on_open_redirects do
error = assert_raise(ActionController::Redirecting::UnsafeRedirectError) do
get :unsafe_redirect_with_illegal_http_header_value_character
end
msg = "The redirect URL javascript:alert(document.domain)\b contains one or more illegal HTTP header field character. " \
"Set of legal characters defined in https://datatracker.ietf.org/doc/html/rfc7230#section-3.2.6"
assert_equal msg, error.message
end
end
def test_only_path_redirect
with_raise_on_open_redirects do
get :only_path_redirect
assert_response :redirect
assert_redirected_to "/redirect/other_host"
end
end
def test_url_from
with_raise_on_open_redirects do
get :safe_redirect_with_fallback, params: { redirect_url: "http://test.host/app" }
assert_response :redirect
assert_redirected_to "http://test.host/app"
end
end
def test_url_from_fallback
with_raise_on_open_redirects do
get :safe_redirect_with_fallback, params: { redirect_url: "http://www.rubyonrails.org/" }
assert_response :redirect
assert_redirected_to "http://test.host/fallback"
get :safe_redirect_with_fallback, params: { redirect_url: "" }
assert_response :redirect
assert_redirected_to "http://test.host/fallback"
end
end
def test_redirect_to_instrumentation
payload = nil
subscriber = proc do |event|
payload = event.payload
end
ActiveSupport::Notifications.subscribed(subscriber, "redirect_to.action_controller") do
get :simple_redirect
end
assert_equal request, payload[:request]
assert_equal 302, payload[:status]
assert_equal "http://test.host/redirect/hello_world", payload[:location]
end
private
def with_raise_on_open_redirects
old_raise_on_open_redirects = ActionController::Base.raise_on_open_redirects
ActionController::Base.raise_on_open_redirects = true
yield
ensure
ActionController::Base.raise_on_open_redirects = old_raise_on_open_redirects
end
end
module ModuleTest
class ModuleRedirectController < ::RedirectController
def module_redirect
redirect_to controller: "/redirect", action: "hello_world"
end
end
class ModuleRedirectTest < ActionController::TestCase
tests ModuleRedirectController
def test_simple_redirect
get :simple_redirect
assert_response :redirect
assert_equal "http://test.host/module_test/module_redirect/hello_world", redirect_to_url
end
def test_simple_redirect_using_options
get :host_redirect
assert_response :redirect
assert_redirected_to action: "other_host", only_path: false, host: "other.test.host"
end
def test_module_redirect
get :module_redirect
assert_response :redirect
assert_equal "http://test.host/redirect/hello_world", redirect_to_url
end
def test_module_redirect_using_options
get :module_redirect
assert_response :redirect
assert_redirected_to controller: "/redirect", action: "hello_world"
end
end
end
|