1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441
|
# frozen_string_literal: true
require_relative "abstract_unit"
require_relative "multibyte_test_helpers"
require "stringio"
require "fileutils"
require "tempfile"
require "tmpdir"
require "concurrent/atomics"
class LoggerTest < ActiveSupport::TestCase
include MultibyteTestHelpers
Logger = ActiveSupport::Logger
def setup
@message = "A debug message"
@integer_message = 12345
@output = StringIO.new
@logger = Logger.new(@output)
end
def test_log_outputs_to
assert Logger.logger_outputs_to?(@logger, @output), "Expected logger_outputs_to? @output to return true but was false"
assert Logger.logger_outputs_to?(@logger, @output, STDOUT), "Expected logger_outputs_to? @output or STDOUT to return true but was false"
assert_not Logger.logger_outputs_to?(@logger, STDOUT), "Expected logger_outputs_to? to STDOUT to return false, but was true"
assert_not Logger.logger_outputs_to?(@logger, STDOUT, STDERR), "Expected logger_outputs_to? to STDOUT or STDERR to return false, but was true"
assert_not Logger.logger_outputs_to?(@logger, "log/production.log")
end
def test_log_outputs_to_with_a_broadcast_logger
logger = ActiveSupport::BroadcastLogger.new(Logger.new(STDOUT))
assert(Logger.logger_outputs_to?(logger, STDOUT))
assert_not(Logger.logger_outputs_to?(logger, STDERR))
logger.broadcast_to(Logger.new(STDERR))
assert(Logger.logger_outputs_to?(logger, STDERR))
end
def test_log_outputs_to_with_a_filename
t = Tempfile.new ["development", "log"]
logger = ActiveSupport::BroadcastLogger.new(Logger.new(t.path))
assert Logger.logger_outputs_to?(logger, t)
assert Logger.logger_outputs_to?(logger, t.path)
assert Logger.logger_outputs_to?(logger, File.join(File.dirname(t.path), ".", File.basename(t.path)))
assert_not Logger.logger_outputs_to?(logger, "log/production.log")
assert_not Logger.logger_outputs_to?(logger, STDOUT)
ensure
logger.close
t.close true
end
def test_write_binary_data_to_existing_file
t = Tempfile.new ["development", "log"]
t.binmode
t.write "hi mom!"
t.close
f = File.open(t.path, "w")
f.binmode
logger = Logger.new f
logger.level = Logger::DEBUG
str = +"\x80"
str.force_encoding("ASCII-8BIT")
assert_nothing_raised do
logger.add Logger::DEBUG, str
end
ensure
logger.close
t.close true
end
def test_write_binary_data_create_file
fname = File.join Dir.tmpdir, "lol", "rofl.log"
FileUtils.mkdir_p File.dirname(fname)
f = File.open(fname, "w")
f.binmode
logger = Logger.new f
logger.level = Logger::DEBUG
str = +"\x80"
str.force_encoding("ASCII-8BIT")
assert_nothing_raised do
logger.add Logger::DEBUG, str
end
ensure
logger.close
File.unlink fname
end
def test_defaults_to_simple_formatter
logger = Logger.new(@output)
assert_instance_of ActiveSupport::Logger::SimpleFormatter, logger.formatter
end
def test_formatter_can_be_set_via_keyword_arg
custom_formatter = ::Logger::Formatter.new
logger = Logger.new(@output, formatter: custom_formatter)
assert_same custom_formatter, logger.formatter
end
def test_should_log_debugging_message_when_debugging
@logger.level = Logger::DEBUG
@logger.add(Logger::DEBUG, @message)
assert_includes @output.string, @message
end
def test_should_not_log_debug_messages_when_log_level_is_info
@logger.level = Logger::INFO
@logger.add(Logger::DEBUG, @message)
assert_not_includes @output.string, @message
end
def test_should_add_message_passed_as_block_when_using_add
@logger.level = Logger::INFO
@logger.add(Logger::INFO) { @message }
assert_includes @output.string, @message
end
def test_should_add_message_passed_as_block_when_using_shortcut
@logger.level = Logger::INFO
@logger.info { @message }
assert_includes @output.string, @message
end
def test_should_convert_message_to_string
@logger.level = Logger::INFO
@logger.info @integer_message
assert_includes @output.string, @integer_message.to_s
end
def test_should_convert_message_to_string_when_passed_in_block
@logger.level = Logger::INFO
@logger.info { @integer_message }
assert_includes @output.string, @integer_message.to_s
end
def test_should_not_evaluate_block_if_message_wont_be_logged
@logger.level = Logger::INFO
evaluated = false
@logger.add(Logger::DEBUG) { evaluated = true }
assert evaluated == false
end
def test_should_not_mutate_message
message_copy = @message.dup
@logger.info @message
assert_equal message_copy, @message
end
def test_should_know_if_its_loglevel_is_below_a_given_level
Logger::Severity.constants.each do |level|
next if level.to_s == "UNKNOWN"
@logger.level = Logger::Severity.const_get(level) - 1
assert @logger.public_send("#{level.downcase}?"), "didn't know if it was #{level.downcase}? or below"
end
end
def test_buffer_multibyte
@logger.level = Logger::INFO
@logger.info(UNICODE_STRING)
@logger.info(BYTE_STRING)
assert_includes @output.string, UNICODE_STRING
byte_string = @output.string.dup
byte_string.force_encoding("ASCII-8BIT")
assert_includes byte_string, BYTE_STRING
end
def test_silencing_everything_but_errors
@logger.silence do
@logger.debug "NOT THERE"
@logger.error "THIS IS HERE"
end
assert_not_includes @output.string, "NOT THERE"
assert_includes @output.string, "THIS IS HERE"
end
def test_unsilencing
@logger.level = Logger::INFO
@logger.debug "NOT THERE"
@logger.silence Logger::DEBUG do
@logger.debug "THIS IS HERE"
end
assert_not_includes @output.string, "NOT THERE"
assert_includes @output.string, "THIS IS HERE"
end
def test_logger_silencing_works_for_broadcast
another_output = StringIO.new
another_logger = ActiveSupport::Logger.new(another_output)
logger = ActiveSupport::BroadcastLogger.new(@logger, another_logger)
logger.debug "CORRECT DEBUG"
logger.silence do |logger|
assert_kind_of ActiveSupport::BroadcastLogger, logger
logger.debug "FAILURE"
logger.error "CORRECT ERROR"
end
assert_includes @output.string, "CORRECT DEBUG"
assert_includes @output.string, "CORRECT ERROR"
assert_not_includes @output.string, "FAILURE"
assert_includes another_output.string, "CORRECT DEBUG"
assert_includes another_output.string, "CORRECT ERROR"
assert_not another_output.string.include?("FAILURE")
end
def test_broadcast_silencing_does_not_break_plain_ruby_logger
another_output = StringIO.new
another_logger = ::Logger.new(another_output)
logger = ActiveSupport::BroadcastLogger.new(@logger, another_logger)
logger.debug "CORRECT DEBUG"
logger.silence do |logger|
assert_kind_of ActiveSupport::BroadcastLogger, logger
logger.debug "FAILURE"
logger.error "CORRECT ERROR"
end
assert_includes @output.string, "CORRECT DEBUG"
assert_includes @output.string, "CORRECT ERROR"
assert_not_includes @output.string, "FAILURE"
assert_includes another_output.string, "CORRECT DEBUG"
assert_includes another_output.string, "CORRECT ERROR"
assert_includes another_output.string, "FAILURE"
# We can't silence plain ruby Logger cause with thread safety
# but at least we don't break it
end
def test_logger_level_per_object_thread_safety
logger1 = Logger.new(StringIO.new)
logger2 = Logger.new(StringIO.new)
level = Logger::DEBUG
assert_equal level, logger1.level, "Expected level #{level_name(level)}, got #{level_name(logger1.level)}"
assert_equal level, logger2.level, "Expected level #{level_name(level)}, got #{level_name(logger2.level)}"
logger1.level = Logger::ERROR
assert_equal level, logger2.level, "Expected level #{level_name(level)}, got #{level_name(logger2.level)}"
end
def test_logger_level_main_thread_safety
@logger.level = Logger::INFO
assert_level(Logger::INFO)
latch = Concurrent::CountDownLatch.new
latch2 = Concurrent::CountDownLatch.new
t = Thread.new do
latch.wait
assert_level(Logger::INFO)
latch2.count_down
end
@logger.silence(Logger::ERROR) do
assert_level(Logger::ERROR)
latch.count_down
latch2.wait
end
t.join
end
def test_logger_level_local_thread_safety
@logger.level = Logger::INFO
assert_level(Logger::INFO)
thread_1_latch = Concurrent::CountDownLatch.new
thread_2_latch = Concurrent::CountDownLatch.new
threads = (1..2).collect do |thread_number|
Thread.new do
# force thread 2 to wait until thread 1 is already in @logger.silence
thread_2_latch.wait if thread_number == 2
@logger.silence(Logger::ERROR) do
assert_level(Logger::ERROR)
@logger.silence(Logger::DEBUG) do
# allow thread 2 to finish but hold thread 1
if thread_number == 1
thread_2_latch.count_down
thread_1_latch.wait
end
assert_level(Logger::DEBUG)
end
end
# allow thread 1 to finish
assert_level(Logger::INFO)
thread_1_latch.count_down if thread_number == 2
end
end
threads.each(&:join)
assert_level(Logger::INFO)
end
def test_logger_level_main_fiber_safety
previous_isolation_level = ActiveSupport::IsolatedExecutionState.isolation_level
ActiveSupport::IsolatedExecutionState.isolation_level = :fiber
@logger.level = Logger::INFO
assert_level(Logger::INFO)
fiber = Fiber.new do
assert_level(Logger::INFO)
end
@logger.silence(Logger::ERROR) do
assert_level(Logger::ERROR)
fiber.resume
end
ensure
ActiveSupport::IsolatedExecutionState.isolation_level = previous_isolation_level
end
def test_logger_level_local_fiber_safety
previous_isolation_level = ActiveSupport::IsolatedExecutionState.isolation_level
ActiveSupport::IsolatedExecutionState.isolation_level = :fiber
@logger.level = Logger::INFO
assert_level(Logger::INFO)
another_fiber = Fiber.new do
@logger.silence(Logger::ERROR) do
assert_level(Logger::ERROR)
@logger.silence(Logger::DEBUG) do
assert_level(Logger::DEBUG)
end
end
assert_level(Logger::INFO)
end
Fiber.new do
@logger.silence(Logger::ERROR) do
assert_level(Logger::ERROR)
@logger.silence(Logger::DEBUG) do
another_fiber.resume
assert_level(Logger::DEBUG)
end
end
assert_level(Logger::INFO)
end.resume
assert_level(Logger::INFO)
ensure
ActiveSupport::IsolatedExecutionState.isolation_level = previous_isolation_level
end
def test_logger_level_thread_safety
previous_isolation_level = ActiveSupport::IsolatedExecutionState.isolation_level
ActiveSupport::IsolatedExecutionState.isolation_level = :thread
@logger.level = Logger::INFO
assert_level(Logger::INFO)
enumerator = Enumerator.new do |yielder|
@logger.level = Logger::DEBUG
yielder.yield @logger.level
end
assert_equal Logger::DEBUG, enumerator.next
assert_level(Logger::DEBUG)
ensure
ActiveSupport::IsolatedExecutionState.isolation_level = previous_isolation_level
end
def test_temporarily_logging_at_a_noisier_level
@logger.level = Logger::INFO
@logger.debug "NOT THERE"
@logger.log_at Logger::DEBUG do
@logger.debug "THIS IS HERE"
end
@logger.debug "NOT THERE"
assert_not_includes @output.string, "NOT THERE"
assert_includes @output.string, "THIS IS HERE"
end
def test_temporarily_logging_at_a_quieter_level
@logger.log_at Logger::ERROR do
@logger.debug "NOT THERE"
@logger.error "THIS IS HERE"
end
assert_not_includes @output.string, "NOT THERE"
assert_includes @output.string, "THIS IS HERE"
end
def test_temporarily_logging_at_a_symbolic_level
@logger.log_at :error do
@logger.debug "NOT THERE"
@logger.error "THIS IS HERE"
end
assert_not_includes @output.string, "NOT THERE"
assert_includes @output.string, "THIS IS HERE"
end
def test_log_at_only_impact_receiver
logger2 = Logger.new(StringIO.new)
assert_equal Logger::DEBUG, logger2.level
assert_equal Logger::DEBUG, @logger.level
@logger.log_at :error do
assert_equal Logger::DEBUG, logger2.level
assert_equal Logger::ERROR, @logger.level
end
end
private
def level_name(level)
::Logger::Severity.constants.find do |severity|
Logger.const_get(severity) == level
end.to_s
end
def assert_level(level)
assert_equal level, @logger.level, "Expected level #{level_name(level)}, got #{level_name(@logger.level)}"
end
end
|