1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
|
import os
import unittest
import time
from commontest import old_test_dir, abs_output_dir, abs_restore_dir, Myrm, \
rdiff_backup, RBBin, SetConnections, os_system
from rdiff_backup import Globals, rpath
import rdiff_backup.Security as Security
class SecurityTest(unittest.TestCase):
various_files_dir = os.path.join(old_test_dir, b"various_file_types")
def test_vet_request_ro(self):
"""Test vetting of ConnectionRequests on read-only server"""
remote_cmd = b"%s --server --restrict-read-only foo" % RBBin
conn = SetConnections._init_connection(remote_cmd)
self.assertIsInstance(conn.os.getuid(), int)
with self.assertRaises(Security.Violation):
conn.os.remove(b"/tmp/foobar")
SetConnections.CloseConnections()
def test_vet_request_minimal(self):
"""Test vetting of ConnectionRequests on minimal server"""
remote_cmd = b"%s --server --restrict-update-only foo" % RBBin
conn = SetConnections._init_connection(remote_cmd)
self.assertIsInstance(conn.os.getuid(), int)
with self.assertRaises(Security.Violation):
conn.os.remove(b"/tmp/foobar")
SetConnections.CloseConnections()
def test_vet_rpath(self):
"""Test to make sure rpaths not in restricted path will be rejected"""
remote_cmd = b"%s --server --restrict-update-only foo" % RBBin
conn = SetConnections._init_connection(remote_cmd)
for rp in [
rpath.RPath(Globals.local_connection, b"blahblah"),
rpath.RPath(conn, b"foo/bar")
]:
conn.Globals.set("TEST_var", rp)
self.assertEqual(conn.Globals.get("TEST_var").path, rp.path)
for path in [b"foobar", b"/usr/local", b"foo/../bar"]:
with self.assertRaises(Security.Violation):
rp = rpath.RPath(conn, path)
conn.Globals.set("TEST_var", rp)
SetConnections.CloseConnections()
def test_vet_rpath_root(self):
"""Test vetting when restricted to root"""
remote_cmd = b"%s --server --restrict-update-only /" % RBBin
conn = SetConnections._init_connection(remote_cmd)
for rp in [
rpath.RPath(Globals.local_connection, "blahblah"),
rpath.RPath(conn, "foo/bar")
]:
conn.Globals.set("TEST_var", rp)
self.assertEqual(conn.Globals.get("TEST_var").path, rp.path)
SetConnections.CloseConnections()
def secure_rdiff_backup(self,
in_dir,
out_dir,
in_local,
restrict_args,
extra_args=b"",
expected_ret_code=0,
current_time=None):
"""Run rdiff-backup locally, with given restrict settings"""
if not current_time:
current_time = int(time.time())
# escape the %s of the remote schema with double %
prefix = (b'%b --current-time %i --remote-schema {h} ' %
(RBBin, current_time))
if in_local:
out_dir = (b'"%b %b --server::%b"' %
(RBBin, restrict_args, out_dir))
else:
in_dir = (b'"%b %b --server::%b"' % (RBBin, restrict_args, in_dir))
cmdline = b"%b %b %b %b" % (prefix, extra_args, in_dir, out_dir)
print("Executing:", cmdline)
exit_val = os_system(cmdline)
if expected_ret_code is not None:
self.assertEqual(exit_val, expected_ret_code)
def test_restrict_positive(self):
"""Test that --restrict switch doesn't get in the way
This makes sure that basic backups with the restrict operator
work, (initial backup, incremental, restore).
"""
Myrm(abs_output_dir)
self.secure_rdiff_backup(self.various_files_dir,
abs_output_dir,
1,
b'--restrict %b' % abs_output_dir,
current_time=10000)
# Note the backslash below -- eest for bug in path normalization
self.secure_rdiff_backup(self.various_files_dir, abs_output_dir, 1,
b'--restrict %b/' % abs_output_dir)
Myrm(abs_restore_dir)
self.secure_rdiff_backup(abs_output_dir,
abs_restore_dir,
1,
b'--restrict %b' % abs_restore_dir,
extra_args=b'-r now')
def test_restrict_negative(self):
"""Test that --restrict switch denies certain operations"""
# Backup to wrong directory
output2_dir = abs_output_dir + b"2"
Myrm(abs_output_dir)
Myrm(output2_dir)
self.secure_rdiff_backup(self.various_files_dir,
output2_dir,
1,
b'--restrict %b' % abs_output_dir,
expected_ret_code=Globals.RET_CODE_ERR)
# Restore to wrong directory
Myrm(abs_output_dir)
Myrm(abs_restore_dir)
rdiff_backup(1, 1, self.various_files_dir, abs_output_dir)
self.secure_rdiff_backup(abs_output_dir,
abs_restore_dir,
1,
b'--restrict %b' % output2_dir,
extra_args=b'-r now',
expected_ret_code=Globals.RET_CODE_ERR)
# Backup from wrong directory
Myrm(abs_output_dir)
wrong_files_dir = os.path.join(old_test_dir, b"foobar")
self.secure_rdiff_backup(self.various_files_dir,
abs_output_dir,
0,
b'--restrict %b' % wrong_files_dir,
expected_ret_code=Globals.RET_CODE_ERR)
def test_restrict_readonly_positive(self):
"""Test that --restrict-read-only switch doesn't impair normal ops"""
Myrm(abs_output_dir)
Myrm(abs_restore_dir)
self.secure_rdiff_backup(
self.various_files_dir, abs_output_dir, 0,
b'--restrict-read-only %b' % self.various_files_dir)
self.secure_rdiff_backup(abs_output_dir,
abs_restore_dir,
0,
b'--restrict-read-only %b' % abs_output_dir,
extra_args=b'-r now',
expected_ret_code=Globals.RET_CODE_WARN)
# there is a warning because log can't be opened in read-only mode
def test_restrict_readonly_negative(self):
"""Test that --restrict-read-only doesn't allow too much"""
# Backup to restricted directory
Myrm(abs_output_dir)
self.secure_rdiff_backup(self.various_files_dir,
abs_output_dir,
1,
b'--restrict-read-only %b' % abs_output_dir,
expected_ret_code=Globals.RET_CODE_ERR)
# Restore to restricted directory
Myrm(abs_output_dir)
Myrm(abs_restore_dir)
rdiff_backup(1, 1, self.various_files_dir, abs_output_dir)
self.secure_rdiff_backup(abs_output_dir,
abs_restore_dir,
1,
b'--restrict-read-only %b' % abs_restore_dir,
extra_args=b'-r now',
expected_ret_code=Globals.RET_CODE_ERR)
def test_restrict_updateonly_positive(self):
"""Test that --restrict-update-only allows intended use"""
Myrm(abs_output_dir)
rdiff_backup(1,
1,
self.various_files_dir,
abs_output_dir,
current_time=10000)
self.secure_rdiff_backup(self.various_files_dir, abs_output_dir, 1,
b'--restrict-update-only %b' % abs_output_dir)
def test_restrict_updateonly_negative(self):
"""Test that --restrict-update-only impairs unintended"""
Myrm(abs_output_dir)
self.secure_rdiff_backup(self.various_files_dir,
abs_output_dir,
1,
b'--restrict-update-only %b' % abs_output_dir,
expected_ret_code=Globals.RET_CODE_ERR)
Myrm(abs_output_dir)
Myrm(abs_restore_dir)
rdiff_backup(1, 1, self.various_files_dir, abs_output_dir)
self.secure_rdiff_backup(abs_output_dir,
abs_restore_dir,
1,
b'--restrict-update-only %b' %
abs_restore_dir,
extra_args=b'-r now',
expected_ret_code=Globals.RET_CODE_ERR)
def test_restrict_bug(self):
"""Test for bug 14209 --- mkdir outside --restrict arg"""
Myrm(abs_output_dir)
self.secure_rdiff_backup(self.various_files_dir,
abs_output_dir,
1,
b'--restrict foobar',
expected_ret_code=Globals.RET_CODE_ERR)
output = rpath.RPath(Globals.local_connection, abs_output_dir)
self.assertFalse(output.lstat())
def test_quoting_bug(self):
"""Test for bug 14545 --- quoting causes bad violation"""
Myrm(abs_output_dir)
self.secure_rdiff_backup(self.various_files_dir,
abs_output_dir,
1,
b'',
extra_args=b'--override-chars-to-quote e')
if __name__ == "__main__":
unittest.main()
|
