1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
|
start_server {tags {"bitops"}} {
test {BITFIELD signed SET and GET basics} {
r del bits
set results {}
lappend results [r bitfield bits set i8 0 -100]
lappend results [r bitfield bits set i8 0 101]
lappend results [r bitfield bits get i8 0]
set results
} {0 -100 101}
test {BITFIELD unsigned SET and GET basics} {
r del bits
set results {}
lappend results [r bitfield bits set u8 0 255]
lappend results [r bitfield bits set u8 0 100]
lappend results [r bitfield bits get u8 0]
set results
} {0 255 100}
test {BITFIELD signed SET and GET together} {
r del bits
set results [r bitfield bits set i8 0 255 set i8 0 100 get i8 0]
} {0 -1 100}
test {BITFIELD unsigned with SET, GET and INCRBY arguments} {
r del bits
set results [r bitfield bits set u8 0 255 incrby u8 0 100 get u8 0]
} {0 99 99}
test {BITFIELD with only key as argument} {
r del bits
set result [r bitfield bits]
assert {$result eq {}}
}
test {BITFIELD #<idx> form} {
r del bits
set results {}
r bitfield bits set u8 #0 65
r bitfield bits set u8 #1 66
r bitfield bits set u8 #2 67
r get bits
} {ABC}
test {BITFIELD basic INCRBY form} {
r del bits
set results {}
r bitfield bits set u8 #0 10
lappend results [r bitfield bits incrby u8 #0 100]
lappend results [r bitfield bits incrby u8 #0 100]
set results
} {110 210}
test {BITFIELD chaining of multiple commands} {
r del bits
set results {}
r bitfield bits set u8 #0 10
lappend results [r bitfield bits incrby u8 #0 100 incrby u8 #0 100]
set results
} {{110 210}}
test {BITFIELD unsigned overflow wrap} {
r del bits
set results {}
r bitfield bits set u8 #0 100
lappend results [r bitfield bits overflow wrap incrby u8 #0 257]
lappend results [r bitfield bits get u8 #0]
lappend results [r bitfield bits overflow wrap incrby u8 #0 255]
lappend results [r bitfield bits get u8 #0]
} {101 101 100 100}
test {BITFIELD unsigned overflow sat} {
r del bits
set results {}
r bitfield bits set u8 #0 100
lappend results [r bitfield bits overflow sat incrby u8 #0 257]
lappend results [r bitfield bits get u8 #0]
lappend results [r bitfield bits overflow sat incrby u8 #0 -255]
lappend results [r bitfield bits get u8 #0]
} {255 255 0 0}
test {BITFIELD signed overflow wrap} {
r del bits
set results {}
r bitfield bits set i8 #0 100
lappend results [r bitfield bits overflow wrap incrby i8 #0 257]
lappend results [r bitfield bits get i8 #0]
lappend results [r bitfield bits overflow wrap incrby i8 #0 255]
lappend results [r bitfield bits get i8 #0]
} {101 101 100 100}
test {BITFIELD signed overflow sat} {
r del bits
set results {}
r bitfield bits set u8 #0 100
lappend results [r bitfield bits overflow sat incrby i8 #0 257]
lappend results [r bitfield bits get i8 #0]
lappend results [r bitfield bits overflow sat incrby i8 #0 -255]
lappend results [r bitfield bits get i8 #0]
} {127 127 -128 -128}
test {BITFIELD overflow detection fuzzing} {
for {set j 0} {$j < 1000} {incr j} {
set bits [expr {[randomInt 64]+1}]
set sign [randomInt 2]
set range [expr {2**$bits}]
if {$bits == 64} {set sign 1} ; # u64 is not supported by BITFIELD.
if {$sign} {
set min [expr {-($range/2)}]
set type "i$bits"
} else {
set min 0
set type "u$bits"
}
set max [expr {$min+$range-1}]
# Compare Tcl vs Redis
set range2 [expr {$range*2}]
set value [expr {($min*2)+[randomInt $range2]}]
set increment [expr {($min*2)+[randomInt $range2]}]
if {$value > 9223372036854775807} {
set value 9223372036854775807
}
if {$value < -9223372036854775808} {
set value -9223372036854775808
}
if {$increment > 9223372036854775807} {
set increment 9223372036854775807
}
if {$increment < -9223372036854775808} {
set increment -9223372036854775808
}
set overflow 0
if {$value > $max || $value < $min} {set overflow 1}
if {($value + $increment) > $max} {set overflow 1}
if {($value + $increment) < $min} {set overflow 1}
r del bits
set res1 [r bitfield bits overflow fail set $type 0 $value]
set res2 [r bitfield bits overflow fail incrby $type 0 $increment]
if {$overflow && [lindex $res1 0] ne {} &&
[lindex $res2 0] ne {}} {
fail "OW not detected where needed: $type $value+$increment"
}
if {!$overflow && ([lindex $res1 0] eq {} ||
[lindex $res2 0] eq {})} {
fail "OW detected where NOT needed: $type $value+$increment"
}
}
}
test {BITFIELD overflow wrap fuzzing} {
for {set j 0} {$j < 1000} {incr j} {
set bits [expr {[randomInt 64]+1}]
set sign [randomInt 2]
set range [expr {2**$bits}]
if {$bits == 64} {set sign 1} ; # u64 is not supported by BITFIELD.
if {$sign} {
set min [expr {-($range/2)}]
set type "i$bits"
} else {
set min 0
set type "u$bits"
}
set max [expr {$min+$range-1}]
# Compare Tcl vs Redis
set range2 [expr {$range*2}]
set value [expr {($min*2)+[randomInt $range2]}]
set increment [expr {($min*2)+[randomInt $range2]}]
if {$value > 9223372036854775807} {
set value 9223372036854775807
}
if {$value < -9223372036854775808} {
set value -9223372036854775808
}
if {$increment > 9223372036854775807} {
set increment 9223372036854775807
}
if {$increment < -9223372036854775808} {
set increment -9223372036854775808
}
r del bits
r bitfield bits overflow wrap set $type 0 $value
r bitfield bits overflow wrap incrby $type 0 $increment
set res [lindex [r bitfield bits get $type 0] 0]
set expected 0
if {$sign} {incr expected [expr {$max+1}]}
incr expected $value
incr expected $increment
set expected [expr {$expected % $range}]
if {$sign} {incr expected $min}
if {$res != $expected} {
fail "WRAP error: $type $value+$increment = $res, should be $expected"
}
}
}
test {BITFIELD regression for #3221} {
r set bits 1
r bitfield bits get u1 0
} {0}
test {BITFIELD regression for #3564} {
for {set j 0} {$j < 10} {incr j} {
r del mystring
set res [r BITFIELD mystring SET i8 0 10 SET i8 64 10 INCRBY i8 10 99900]
assert {$res eq {0 0 60}}
}
r del mystring
}
test {BITFIELD_RO with only key as argument} {
set res [r bitfield_ro bits]
assert {$res eq {}}
}
test {BITFIELD_RO fails when write option is used} {
catch {r bitfield_ro bits set u8 0 100 get u8 0} err
assert_match {*ERR BITFIELD_RO only supports the GET subcommand*} $err
}
}
start_server {tags {"repl external:skip"}} {
start_server {} {
set master [srv -1 client]
set master_host [srv -1 host]
set master_port [srv -1 port]
set slave [srv 0 client]
test {BITFIELD: setup slave} {
$slave slaveof $master_host $master_port
wait_for_condition 50 100 {
[s 0 master_link_status] eq {up}
} else {
fail "Replication not started."
}
}
test {BITFIELD: write on master, read on slave} {
$master del bits
assert_equal 0 [$master bitfield bits set u8 0 255]
assert_equal 255 [$master bitfield bits set u8 0 100]
wait_for_ofs_sync $master $slave
assert_equal 100 [$slave bitfield_ro bits get u8 0]
}
test {BITFIELD_RO with only key as argument on read-only replica} {
set res [$slave bitfield_ro bits]
assert {$res eq {}}
}
test {BITFIELD_RO fails when write option is used on read-only replica} {
catch {$slave bitfield_ro bits set u8 0 100 get u8 0} err
assert_match {*ERR BITFIELD_RO only supports the GET subcommand*} $err
}
}
}
|
