1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
|
# frozen_string_literal: true
# Redmine - project management software
# Copyright (C) 2006-2022 Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../../test_helper', __FILE__)
class IssueRelationsControllerTest < Redmine::ControllerTest
fixtures :projects,
:users,
:roles,
:members,
:member_roles,
:issues,
:issue_statuses,
:issue_relations,
:enabled_modules,
:enumerations,
:trackers,
:projects_trackers
def setup
User.current = nil
@request.session[:user_id] = 3
end
def test_create
assert_difference 'IssueRelation.count' do
post(
:create,
:params => {
:issue_id => 1,
:relation => {
:issue_to_id => '2',
:relation_type => 'relates',
:delay => ''
}
}
)
end
relation = IssueRelation.order('id DESC').first
assert_equal 1, relation.issue_from_id
assert_equal 2, relation.issue_to_id
assert_equal 'relates', relation.relation_type
end
def test_create_on_invalid_issue
assert_no_difference 'IssueRelation.count' do
post(
:create,
:params => {
:issue_id => 999,
:relation => {
:issue_to_id => '2',
:relation_type => 'relates',
:delay => ''
}
}
)
assert_response 404
end
end
def test_create_xhr
assert_difference 'IssueRelation.count' do
post(
:create,
:params => {
:issue_id => 3,
:relation => {
:issue_to_id => '1',
:relation_type => 'relates',
:delay => ''
}
},
:xhr => true
)
assert_response :success
assert_equal 'text/javascript', response.media_type
end
relation = IssueRelation.order('id DESC').first
assert_equal 1, relation.issue_from_id
assert_equal 3, relation.issue_to_id
assert_include 'Bug #1', response.body
end
def test_create_should_accept_id_with_hash
assert_difference 'IssueRelation.count' do
post(
:create,
:params => {
:issue_id => 1,
:relation => {
:issue_to_id => '#2',
:relation_type => 'relates',
:delay => ''
}
}
)
end
relation = IssueRelation.order('id DESC').first
assert_equal 2, relation.issue_to_id
end
def test_create_should_strip_id
assert_difference 'IssueRelation.count' do
post(
:create,
:params => {
:issue_id => 1,
:relation => {
:issue_to_id => ' 2 ',
:relation_type => 'relates',
:delay => ''
}
}
)
end
relation = IssueRelation.order('id DESC').first
assert_equal 2, relation.issue_to_id
end
def test_create_should_not_break_with_non_numerical_id
assert_no_difference 'IssueRelation.count' do
assert_nothing_raised do
post(
:create,
:params => {
:issue_id => 1,
:relation => {
:issue_to_id => 'foo',
:relation_type => 'relates',
:delay => ''
}
}
)
end
end
end
def test_create_follows_relation_should_update_relations_list
issue1 = Issue.generate!(:subject => 'Followed issue',
:start_date => Date.yesterday,
:due_date => Date.today)
issue2 = Issue.generate!
assert_difference 'IssueRelation.count' do
post(
:create,
:params => {
:issue_id => issue2.id,
:relation => {
:issue_to_id => issue1.id,
:relation_type => 'follows',
:delay => ''
}
},
:xhr => true
)
end
assert_include 'Followed issue', response.body
end
def test_should_create_relations_with_visible_issues_only
with_settings :cross_project_issue_relations => '1' do
assert_nil Issue.visible(User.find(3)).find_by_id(4)
assert_no_difference 'IssueRelation.count' do
post(
:create,
:params => {
:issue_id => 1,
:relation => {
:issue_to_id => '4',
:relation_type => 'relates',
:delay => ''
}
}
)
end
end
end
def test_create_xhr_with_failure
assert_no_difference 'IssueRelation.count' do
post(
:create,
:params => {
:issue_id => 3,
:relation => {
:issue_to_id => '999',
:relation_type => 'relates',
:delay => ''
}
},
:xhr => true
)
assert_response :success
assert_equal 'text/javascript', response.media_type
end
assert_include 'Related issue cannot be blank', response.body
end
def test_create_duplicated_follows_relations_should_not_raise_exception
IssueRelation.create(
:issue_from => Issue.find(1), :issue_to => Issue.find(2),
:relation_type => IssueRelation::TYPE_PRECEDES
)
assert_no_difference 'IssueRelation.count' do
post(
:create,
:params => {
:issue_id => 2,
:relation => {
:issue_to_id => 1,
:relation_type => 'follows',
:delay => ''
}
},
:xhr => true
)
end
assert_response :success
assert_include 'has already been taken', response.body
end
def test_bulk_create_with_multiple_issue_to_id_issues
assert_difference 'IssueRelation.count', +3 do
post :create, :params => {
:issue_id => 1,
:relation => {
# js autocomplete adds a comma at the end
# issue to id should accept both id and hash with id
:issue_to_id => '2,3,#7, ',
:relation_type => 'relates',
:delay => ''
}
},
:xhr => true
end
assert_response :success
relations = IssueRelation.where(:issue_from_id => 1, :issue_to_id => [2, 3, 7])
assert_equal 3, relations.count
# all relations types should be 'relates'
relations.map {|r| assert_equal 'relates', r.relation_type}
# no error messages should be returned in the response
assert_not_include 'id=\"errorExplanation\"', response.body
end
def test_bulk_create_should_show_errors
with_settings :cross_project_issue_relations => '0' do
assert_difference 'IssueRelation.count', +3 do
post :create, :params => {
:issue_id => 1,
:relation => {
:issue_to_id => '1,2,3,4,5,7',
:relation_type => 'relates',
:delay => ''
}
},
:xhr => true
end
end
assert_response :success
assert_equal 'text/javascript', response.media_type
# issue #1 is invalid
assert_include 'Related issue is invalid: #1', response.body
# issues #4 and #5 can't be related by default
assert_include 'Related issue cannot be blank', response.body
assert_include 'Related issue doesn't belong to the same project', response.body
end
def test_destroy
assert_difference 'IssueRelation.count', -1 do
delete(:destroy, :params => {:id => '2'})
end
end
def test_destroy_invalid_relation
assert_no_difference 'IssueRelation.count' do
delete(:destroy, :params => {:id => '999'})
assert_response 404
end
end
def test_destroy_xhr
IssueRelation.create!(:relation_type => IssueRelation::TYPE_RELATES) do |r|
r.issue_from_id = 3
r.issue_to_id = 1
end
assert_difference 'IssueRelation.count', -1 do
delete(:destroy, :params => {:id => '2'}, :xhr => true)
assert_response :success
assert_equal 'text/javascript', response.media_type
assert_include 'relation-2', response.body
end
end
end
|
