1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
|
use strict;
use warnings;
use RT;
use RT::Test tests => undef;
# validate that when merging two tickets, the comments from both tickets
# are integrated into the new ticket
{
my $queue = RT::Queue->new(RT->SystemUser);
my ($id,$msg) = $queue->Create(Name => 'MergeTest-'.rand(25));
ok ($id,$msg);
my $t1 = RT::Ticket->new(RT->SystemUser);
my ($tid,$transid, $t1msg) =$t1->Create(
Queue => $queue->Name,
Subject => 'Merge test. orig',
);
ok ($tid, $t1msg);
($id, $msg) = $t1->Comment(Content => 'This is a Comment on the original');
ok($id,$msg);
my $txns = $t1->Transactions;
my $Comments = 0;
while (my $txn = $txns->Next) {
$Comments++ if ($txn->Type eq 'Comment');
}
is($Comments,1, "our first ticket has only one Comment");
my $t2 = RT::Ticket->new(RT->SystemUser);
my ($t2id,$t2transid, $t2msg) =$t2->Create ( Queue => $queue->Name, Subject => 'Merge test. duplicate');
ok ($t2id, $t2msg);
($id, $msg) = $t2->Comment(Content => 'This is a commet on the duplicate');
ok($id,$msg);
$txns = $t2->Transactions;
$Comments = 0;
while (my $txn = $txns->Next) {
$Comments++ if ($txn->Type eq 'Comment');
}
is($Comments,1, "our second ticket has only one Comment");
($id, $msg) = $t1->Comment(Content => 'This is a second Comment on the original');
ok($id,$msg);
$txns = $t1->Transactions;
$Comments = 0;
while (my $txn = $txns->Next) {
$Comments++ if ($txn->Type eq 'Comment');
}
is($Comments,2, "our first ticket now has two Comments");
($id,$msg) = $t2->MergeInto($t1->id);
ok($id,$msg);
$txns = $t1->Transactions;
$Comments = 0;
while (my $txn = $txns->Next) {
$Comments++ if ($txn->Type eq 'Comment');
}
is($Comments,3, "our first ticket now has three Comments - we merged safely");
}
# when you try to merge duplicate links on postgres, eveyrything goes to hell due to referential integrity constraints.
{
my $t = RT::Ticket->new(RT->SystemUser);
$t->Create(Subject => 'Main', Queue => 'general');
ok ($t->id);
my $t2 = RT::Ticket->new(RT->SystemUser);
$t2->Create(Subject => 'Second', Queue => 'general');
ok ($t2->id);
my $t3 = RT::Ticket->new(RT->SystemUser);
$t3->Create(Subject => 'Third', Queue => 'general');
ok ($t3->id);
my ($id,$val);
($id,$val) = $t->AddLink(Type => 'DependsOn', Target => $t3->id);
ok($id,$val);
($id,$val) = $t2->AddLink(Type => 'DependsOn', Target => $t3->id);
ok($id,$val);
($id,$val) = $t->MergeInto($t2->id);
ok($id,$val);
}
my $user = RT::Test->load_or_create_user(
Name => 'a user', Password => 'password',
);
ok $user && $user->id, 'loaded or created user';
# check rights
{
RT::Test->set_rights(
{ Principal => 'Everyone', Right => [qw(SeeQueue ShowTicket CreateTicket OwnTicket TakeTicket)] },
{ Principal => 'Owner', Right => [qw(ModifyTicket)] },
);
my $t = RT::Ticket->new(RT::CurrentUser->new($user));
$t->Create(Subject => 'Main', Queue => 'general');
ok ($t->id, "Created ticket");
my $t2 = RT::Ticket->new(RT::CurrentUser->new($user));
$t2->Create(Subject => 'Second', Queue => 'general');
ok ($t2->id, "Created ticket");
foreach my $ticket ( $t, $t2 ) {
ok( !$ticket->CurrentUserHasRight('ModifyTicket'), "can not modify" );
}
my ($status,$msg) = $t->MergeInto($t2->id);
ok(!$status, "Can not merge: $msg");
($status, $msg) = $t->SetOwner( $user->id );
ok( $status, "User took ticket");
ok( $t->CurrentUserHasRight('ModifyTicket'), "can modify after take" );
($status,$msg) = $t->MergeInto($t2->id);
ok(!$status, "Can not merge: $msg");
($status, $msg) = $t2->SetOwner( $user->id );
ok( $status, "User took ticket");
ok( $t2->CurrentUserHasRight('ModifyTicket'), "can modify after take" );
($status,$msg) = $t->MergeInto($t2->id);
ok($status, "Merged tickets: $msg");
}
# check Time* fields after merge
{
my @tickets;
my @values = (
{ Worked => 11, Estimated => 17, Left => 6 },
{ Worked => 7, Estimated => 12, Left => 5 },
);
for my $i (0 .. 1) {
my $t = RT::Ticket->new(RT->SystemUser);
$t->Create( Queue => 'general');
ok ($t->id);
push @tickets, $t;
foreach my $field ( keys %{ $values[ $i ] } ) {
my $method = "SetTime$field";
my ($status, $msg) = $t->$method( $values[ $i ]{ $field } );
ok $status, "changed $field on the ticket"
or diag "error: $msg";
}
}
my ($status, $msg) = $tickets[1]->MergeInto($tickets[0]->id);
ok($status,$msg);
my $t = RT::Ticket->new(RT->SystemUser);
$t->Load( $tickets[0]->id );
foreach my $field ( keys %{ $values[0] } ) {
my $method = "Time$field";
my $expected = 0;
$expected += $_->{ $field } foreach @values;
is $t->$method, $expected, "correct value";
my $from_history = 0;
my $txns = $t->Transactions;
while ( my $txn = $txns->Next ) {
next unless $txn->Type eq 'Set' && $txn->Field eq $method;
$from_history += $txn->NewValue - $txn->OldValue;
}
is $from_history, $expected, "history is correct";
}
}
# forbid merging tickets into non-ticket types
{
# create two tickets
my $ticket_1 = RT::Test->create_ticket(
Queue => 'General',
Subject => 'test ticket 1'
);
my $ticket_2 = RT::Test->create_ticket(
Queue => 'General',
Subject => 'test ticket 2'
);
# create a reminder on ticket_1
$ticket_1->Reminders->Add(
Subject => 'Test Reminder',
Owner => 'root',
);
# verify reminder was created
my $reminders = $ticket_1->Reminders->Collection;
is($reminders->Count, 1, "Reminder successfully added");
my $reminder = $reminders->First;
is($reminder->Subject, "Test Reminder");
# verify ticket cannot be merged into non-ticket type
my($status, $msg) = $ticket_2->MergeInto($reminder->Id);
ok(!$status, 'Only tickets can be merged');
like($msg, qr/Only tickets can be merged/);
# verify non-ticket type cannot merge into a ticket
($status, $msg) = $reminder->MergeInto($ticket_2->Id);
ok(!$status, 'Non-ticket types cannot merge into tickets');
like($msg, qr/Only tickets can be merged/);
}
done_testing();
|
