1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625
|
use strict;
use warnings;
use HTTP::Request::Common;
use HTTP::Cookies;
use LWP;
use RT::Test tests => undef;
my $cookie_jar = HTTP::Cookies->new;
my ($baseurl, $agent) = RT::Test->started_ok;
# give the agent a place to stash the cookies
$agent->cookie_jar($cookie_jar);
# create a regression queue if it doesn't exist
my $queue = RT::Test->load_or_create_queue( Name => 'Regression' );
ok $queue && $queue->id, 'loaded or created queue';
my $url = $agent->rt_base_url;
ok $agent->login, "logged in";
my $response = $agent->get($url."Search/Build.html");
ok $response->is_success, "Fetched ". $url ."Search/Build.html";
sub getQueryFromForm {
my $agent = shift;
$agent->form_name('BuildQuery');
# This pulls out the "hidden input" query from the page
my $q = $agent->current_form->find_input("Query")->value;
$q =~ s/^\s+//g;
$q =~ s/\s+$//g;
$q =~ s/\s+/ /g;
return $q;
}
sub selectedClauses {
my $agent = shift;
my @clauses = grep { defined } map { $_->value } $agent->current_form->find_input("clauses");
return [ @clauses ];
}
diag "add the first condition";
{
ok $agent->form_name('BuildQuery'), "found the form once";
$agent->field("AttachmentField", "Subject");
$agent->field("AttachmentOp", "LIKE");
$agent->field("ValueOfAttachment", "aaa");
$agent->submit("AddClause");
is getQueryFromForm($agent), "Subject LIKE 'aaa'";
}
diag "set the next condition";
{
ok($agent->form_name('BuildQuery'), "found the form again");
$agent->field("AttachmentField", "Subject");
$agent->field("AttachmentOp", "LIKE");
$agent->field("ValueOfAttachment", "bbb");
$agent->submit("AddClause");
is getQueryFromForm($agent), "Subject LIKE 'aaa' AND Subject LIKE 'bbb'",
'correct query';
}
$response = $agent->get($url."Search/Build.html?NewQuery=1");
ok( $response->is_success, "Fetched new query builder page" );
diag "add the first condition";
{
ok $agent->form_name('BuildQuery'), "found the form once";
$agent->field("ActorField", "Owner");
$agent->field("ActorOp", "=");
$agent->field("ValueOfActor", "Nobody");
$agent->submit;
is getQueryFromForm($agent), "Owner = 'Nobody'", 'correct query';
}
diag "set the next condition";
{
ok($agent->form_name('BuildQuery'), "found the form again");
$agent->field("QueueOp", "!=");
$agent->field("ValueOfQueue", "Regression");
$agent->submit;
is getQueryFromForm($agent), "Owner = 'Nobody' AND Queue != 'Regression'",
'correct query';
}
diag "We're going to delete the owner";
{
$agent->select("clauses", ["0"] );
$agent->click("DeleteClause");
ok $agent->form_name('BuildQuery'), "found the form";
is getQueryFromForm($agent), "Queue != 'Regression'", 'correct query';
}
diag "add a cond with OR and se number by the way";
{
$agent->field("AndOr", "OR");
$agent->select("idOp", ">");
$agent->field("ValueOfid" => "1234");
$agent->click("AddClause");
ok $agent->form_name('BuildQuery'), "found the form again";
is getQueryFromForm($agent), "Queue != 'Regression' OR id > 1234",
"added something as OR, and number not quoted";
is_deeply selectedClauses($agent), ["1"], 'the id that we just entered is still selected';
}
diag "Move the second one up a level";
{
$agent->click("Up");
ok $agent->form_name('BuildQuery'), "found the form again";
is getQueryFromForm($agent), "id > 1234 OR Queue != 'Regression'", "moved up one";
is_deeply selectedClauses($agent), ["0"], 'the one we moved up is selected';
}
diag "Move the second one right";
{
$agent->click("Right");
ok $agent->form_name('BuildQuery'), "found the form again";
is getQueryFromForm($agent), "Queue != 'Regression' OR ( id > 1234 )",
"moved over to the right (and down)";
is_deeply selectedClauses($agent), ["2"], 'the one we moved right is selected';
}
diag "Move the block up";
{
$agent->select("clauses", ["1"]);
$agent->click("Up");
ok $agent->form_name('BuildQuery'), "found the form again";
is getQueryFromForm($agent), "( id > 1234 ) OR Queue != 'Regression'", "moved up";
is_deeply selectedClauses($agent), ["0"], 'the one we moved up is selected';
}
diag "Can not move up the top most clause";
{
$agent->select("clauses", ["0"]);
$agent->click("Up");
ok $agent->form_name('BuildQuery'), "found the form again";
$agent->content_contains("error: can't move up", "i shouldn't have been able to hit up");
is_deeply selectedClauses($agent), ["0"], 'the one we tried to move is selected';
}
diag "Can not move left the left most clause";
{
$agent->click("Left");
ok($agent->form_name('BuildQuery'), "found the form again");
$agent->content_contains("error: can't move left", "i shouldn't have been able to hit left");
is_deeply selectedClauses($agent), ["0"], 'the one we tried to move is selected';
}
diag "Add a condition into a nested block";
{
$agent->select("clauses", ["1"]);
$agent->select("ValueOfStatus" => "stalled");
$agent->submit;
ok $agent->form_name('BuildQuery'), "found the form again";
is_deeply selectedClauses($agent), ["2"], 'the one we added is only selected';
is getQueryFromForm($agent),
"( id > 1234 AND Status = 'stalled' ) OR Queue != 'Regression'",
"added new one";
}
diag "click advanced, enter 'C1 OR ( C2 AND C3 )', apply, aggregators should stay the same.";
{
my $response = $agent->get($url."Search/Edit.html");
ok( $response->is_success, "Fetched /Search/Edit.html" );
ok($agent->form_name('BuildQueryAdvanced'), "found the form");
$agent->field("Query", "Status = 'new' OR ( Status = 'open' AND Subject LIKE 'office' )");
$agent->submit;
is( getQueryFromForm($agent),
"Status = 'new' OR ( Status = 'open' AND Subject LIKE 'office' )",
"no aggregators change"
);
}
# - new items go one level down
# - add items at currently selected level
# - if nothing is selected, add at end, one level down
#
# move left
# - error if nothing selected
# - same item should be selected after move
# - can't move left if you're at the top level
#
# move right
# - error if nothing selected
# - same item should be selected after move
# - can always move right (no max depth...should there be?)
#
# move up
# - error if nothing selected
# - same item should be selected after move
# - can't move up if you're first in the list
#
# move down
# - error if nothing selected
# - same item should be selected after move
# - can't move down if you're last in the list
#
# toggle
# - error if nothing selected
# - change all aggregators in the grouping
# - don't change any others
#
# delete
# - error if nothing selected
# - delete currently selected item
# - delete all children of a grouping
# - if delete leaves a node with no children, delete that, too
# - what should be selected?
#
# Clear
# - clears entire query
# - clears it from the session, too
# create a custom field with nonascii name and try to add a condition
{
my $cf = RT::CustomField->new( RT->SystemUser );
$cf->LoadByName( Name => "\x{442}", LookupType => RT::Ticket->CustomFieldLookupType, ObjectId => 0 );
if ( $cf->id ) {
is($cf->Type, 'Freeform', 'loaded and type is correct');
} else {
my ($return, $msg) = $cf->Create(
Name => "\x{442}",
Queue => 0,
Type => 'Freeform',
);
ok($return, 'created CF') or diag "error: $msg";
}
my $response = $agent->get($url."Search/Build.html?NewQuery=1");
ok( $response->is_success, "Fetched " . $url."Search/Build.html" );
ok($agent->form_name('BuildQuery'), "found the form once");
$agent->field("ValueOfCF.{\x{442}}", "\x{441}");
$agent->submit();
is( getQueryFromForm($agent),
"CF.{\x{442}} LIKE '\x{441}'",
"no changes, no duplicate condition with badly encoded text"
);
$cf->SetDisabled(1);
}
diag "input a condition, select (several conditions), click delete";
{
my $response = $agent->get( $url."Search/Edit.html" );
ok $response->is_success, "Fetched /Search/Edit.html";
ok $agent->form_name('BuildQueryAdvanced'), "found the form";
$agent->field("Query", "( Status = 'new' OR Status = 'open' )");
$agent->submit;
is( getQueryFromForm($agent),
"( Status = 'new' OR Status = 'open' )",
"query is the same"
);
$agent->select("clauses", [qw(0 1 2)]);
$agent->field( ValueOfid => 10 );
$agent->click("DeleteClause");
is( getQueryFromForm($agent),
"id < 10",
"replaced query successfuly"
);
}
diag "send query with not quoted negative number";
{
my $response = $agent->get($url."Search/Build.html?Query=Priority%20>%20-2");
ok( $response->is_success, "Fetched " . $url."Search/Build.html" );
is( getQueryFromForm($agent),
"Priority > -2",
"query is the same"
);
}
diag "click advanced, enter an invalid SQL IS restriction, apply and check that we corrected it";
{
my $response = $agent->get($url."Search/Edit.html");
ok( $response->is_success, "Fetched /Search/Edit.html" );
ok($agent->form_name('BuildQueryAdvanced'), "found the form");
$agent->field("Query", "Requestor.EmailAddress IS 'FOOBAR'");
$agent->submit;
is( getQueryFromForm($agent),
"Requestor.EmailAddress IS NULL",
"foobar is replaced by NULL"
);
}
diag "click advanced, enter an invalid SQL IS NOT restriction, apply and check that we corrected it";
{
my $response = $agent->get($url."Search/Edit.html");
ok( $response->is_success, "Fetched /Search/Edit.html" );
ok($agent->form_name('BuildQueryAdvanced'), "found the form");
$agent->field("Query", "Requestor.EmailAddress IS NOT 'FOOBAR'");
$agent->submit;
is( getQueryFromForm($agent),
"Requestor.EmailAddress IS NOT NULL",
"foobar is replaced by NULL"
);
}
diag "click advanced, enter a valid SQL, but the field is lower cased";
{
my $response = $agent->get($url."Search/Edit.html");
ok( $response->is_success, "Fetched /Search/Edit.html" );
ok($agent->form_name('BuildQueryAdvanced'), "found the form");
$agent->field("Query", "status = 'new'");
$agent->submit;
$agent->content_lacks( 'Unknown field:', 'no "unknown field" warning' );
is( getQueryFromForm($agent),
"Status = 'new'",
"field's case is corrected"
);
}
diag "make sure skipped order by field doesn't break search";
{
my $t = RT::Test->create_ticket( Queue => 'General', Subject => 'test' );
ok $t && $t->id, 'created a ticket';
$agent->get_ok($url."Search/Edit.html");
ok($agent->form_name('BuildQueryAdvanced'), "found the form");
$agent->field("Query", "id = ". $t->id);
$agent->submit;
$agent->follow_link_ok({id => 'page-results'});
ok( $agent->find_link(
text => $t->id,
url_regex => qr{/Ticket/Display\.html},
), "link to the ticket" );
$agent->follow_link_ok({id => 'page-edit_search'});
$agent->form_name('BuildQuery');
$agent->field('Order', 'DESC', 1);
$agent->field("OrderBy", 'Requestor.Name', 3);
$agent->submit;
$agent->form_name('BuildQuery');
is $agent->value('OrderBy', 1), 'id';
is $agent->value('OrderBy', 2), '';
is $agent->value('OrderBy', 3), 'Requestor.Name';
$agent->follow_link_ok({id => 'page-results'});
$agent->content_like(qr/class="fas fa-sort-down".*class="fas fa-sort-up"/s, 'orders');
ok( $agent->find_link(
text => $t->id,
url_regex => qr{/Ticket/Display\.html},
), "link to the ticket" );
}
diag "make sure the list of columns available in the 'Order by'/'Add Columns' dropdowns are complete";
{
$agent->get_ok($url . 'Search/Build.html');
my @orderby = qw(
AdminCc.City
AdminCc.Country
AdminCc.EmailAddress
AdminCc.Name
AdminCc.Organization
AdminCc.RealName
AdminCc.id
Cc.City
Cc.Country
Cc.EmailAddress
Cc.Name
Cc.Organization
Cc.RealName
Cc.id
Created
Creator
Custom.Ownership
Due
FinalPriority
InitialPriority
LastUpdated
LastUpdatedBy
Owner.City
Owner.Country
Owner.EmailAddress
Owner.Name
Owner.Organization
Owner.RealName
Owner.id
Priority
Queue
Requestor.City
Requestor.Country
Requestor.EmailAddress
Requestor.Name
Requestor.Organization
Requestor.RealName
Requestor.id
Resolved
SLA
Started
Starts
Status
Subject
TimeEstimated
TimeLeft
TimeWorked
Told
Type
id
);
my $orderby = join(' ', sort @orderby);
my @scraped_orderbys = $agent->scrape_text_by_attr('name', 'OrderBy');
my $first_orderby = shift @scraped_orderbys;
is ($first_orderby, $orderby);
foreach my $scraped_orderby ( @scraped_orderbys ) {
is ($scraped_orderby, '[none] '.$orderby);
}
my @formats = qw(
id
QueueName
Subject
Status
ExtendedStatus
UpdateStatus
Type
OwnerName
OwnerNameEdit
Requestors
Cc
AdminCc
CreatedBy
LastUpdatedBy
Priority
InitialPriority
FinalPriority
TimeWorked
TimeLeft
TimeEstimated
Starts
StartsRelative
Started
StartedRelative
Created
CreatedRelative
LastUpdated
LastUpdatedRelative
Told
ToldRelative
Due
DueRelative
Resolved
ResolvedRelative
SLA
RefersTo
ReferredToBy
DependsOn
DependedOnBy
MemberOf
Members
Parents
Children
Bookmark
Timer
UnreadMessages
NEWLINE
NBSP
AdminCc.id
AdminCc.Name
AdminCc.EmailAddress
AdminCc.Organization
AdminCc.RealName
AdminCc.City
AdminCc.Country
Cc.id
Cc.Name
Cc.EmailAddress
Cc.Organization
Cc.RealName
Cc.City
Cc.Country
Owner.id
Owner.Name
Owner.EmailAddress
Owner.Organization
Owner.RealName
Owner.City
Owner.Country
Requestor.id
Requestor.Name
Requestor.EmailAddress
Requestor.Organization
Requestor.RealName
Requestor.City
Requestor.Country
);
my $formats = join(' ', @formats);
my $scraped_formats = $agent->scrape_text_by_attr('name', 'SelectDisplayColumns');
is( $scraped_formats, $formats, 'Default format' );
my $cf = RT::Test->load_or_create_custom_field(
Name => 'Location',
Queue => 'General',
Type => 'FreeformSingle', );
isa_ok( $cf, 'RT::CustomField' );
my $user_cf = RT::Test->load_or_create_custom_field(
Name => 'Employee ID',
LookupType => RT::User->CustomFieldLookupType,
Type => 'FreeformSingle',
);
my $cr = RT::CustomRole->new( RT->SystemUser );
my ( $ret, $msg ) = $cr->Create(
Name => 'Engineer',
MaxValues => 0,
);
ok( $ret, "Created custom role: $msg" );
( $ret, $msg ) = $cr->AddToObject( ObjectId => 'General' );
ok( $ret, "Added CR to queue: $msg" );
ok($agent->form_name('BuildQuery'), "found the form");
$agent->field("ValueOfQueue", "General");
$agent->submit;
push @orderby, 'CustomField.{Location}';
push @orderby, 'Engineer', map { "Engineer.$_" } qw/City Country EmailAddress Name Organization RealName id/;
push @orderby, map {"$_.CustomField.{Employee ID}"} qw/AdminCc Cc Requestor Owner Engineer/;
$orderby = join(' ', sort @orderby);
@scraped_orderbys = $agent->scrape_text_by_attr('name', 'OrderBy');
$first_orderby = shift @scraped_orderbys;
is ($first_orderby, $orderby);
foreach my $scraped_orderby ( @scraped_orderbys ) {
is ($scraped_orderby, '[none] '.$orderby);
}
# Formats are not sorted, we need to insert new items accordingly
my @new_formats;
for my $format ( @formats ) {
push @new_formats, $format;
if ( $format eq 'NBSP' ) {
push @new_formats, 'CustomField.{Location}', 'CustomFieldView.{Location}';
}
elsif ( $format =~ /(\w+)\.Country/ ) {
push @new_formats, "$1.CustomField.{Employee ID}";
}
}
push @new_formats, 'CustomRole.{Engineer}',
map {"CustomRole.{Engineer}.$_"} qw/id Name EmailAddress Organization RealName City Country/, 'CustomField.{Employee ID}';
$formats = join(' ', @new_formats);
$scraped_formats = $agent->scrape_text_by_attr('name', 'SelectDisplayColumns');
is( $scraped_formats, $formats, 'Format with custom fields and custom roles' );
$cf->SetDisabled(1);
}
diag "make sure active and inactive statuses generate the correct query";
{
$agent->get_ok( $url . '/Search/Build.html?NewQuery=1' );
ok( $agent->form_name( 'BuildQuery' ), "found the form" );
$agent->field( ValueOfStatus => 'active' );
$agent->click( 'AddClause' );
is getQueryFromForm( $agent ), "Status = '__Active__'", "active status generated the correct query";
$agent->get_ok( $url . '/Search/Build.html?NewQuery=1' );
ok( $agent->form_name( 'BuildQuery' ), "found the form" );
$agent->field( ValueOfStatus => 'inactive' );
$agent->click( 'AddClause' );
is getQueryFromForm( $agent ), "Status = '__Inactive__'", "inactive status generated the correct query";
}
diag "test null values";
{
my $cf = RT::Test->load_or_create_custom_field(
Name => 'foo',
Type => 'FreeformSingle',
Queue => 0,
);
RT::Test->create_tickets(
{ Queue => 'General' },
{ Subject => 'ticket bar', 'CustomField-' . $cf->id => 'bar' },
{ Subject => 'ticket baz', 'CustomField-' . $cf->id => 'baz' },
{ Subject => 'ticket null' },
);
$agent->get_ok( '/Search/Build.html?NewQuery=1' );
$agent->submit_form(
form_name => 'BuildQuery',
fields => { 'CF.{foo}Op' => '=', 'ValueOfCF.{foo}' => 'NULL', },
button => 'DoSearch',
);
$agent->title_is( 'Found 2 tickets', 'found 2 tickets with CF.{foo} IS NULL' );
# the other ticket was created before the block
$agent->content_contains( 'ticket null', 'has ticket null' );
$agent->follow_link_ok( { text => 'Advanced' } );
$agent->text_lacks( q[CF.{foo} = 'NULL'] );
$agent->text_contains( 'CF.{foo} IS NULL', q["= 'NULL'" is converted to "IS NULL"] );
$agent->get_ok( '/Search/Build.html?NewQuery=1' );
$agent->submit_form(
form_name => 'BuildQuery',
fields => { 'CF.{foo}Op' => '!=', 'ValueOfCF.{foo}' => 'NULL', },
button => 'DoSearch',
);
$agent->title_is( 'Found 2 tickets', 'found 2 ticket with CF.{foo} IS NOT NULL' );
$agent->content_contains( 'ticket bar', 'has ticket bar' );
$agent->content_contains( 'ticket baz', 'has ticket baz' );
$agent->follow_link_ok( { text => 'Advanced' } );
$agent->text_lacks( q[CF.{foo} != 'NULL'] );
$agent->text_contains( 'CF.{foo} IS NOT NULL', q["!= 'NULL'" is converted to "IS NOT NULL"] );
}
done_testing;
|