1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
|
from pathlib import Path
import pytest
from rpmlint.checks.BinariesCheck import BinariesCheck
from rpmlint.filter import Filter
from rpmlint.lddparser import LddParser
from rpmlint.pkg import FakePkg, get_magic
from Testing import CONFIG, get_tested_path, IS_X86_64
@pytest.fixture(scope='function', autouse=True)
def binariescheck():
CONFIG.info = True
output = Filter(CONFIG)
test = BinariesCheck(CONFIG, output)
return output, test
def get_full_path(path):
return str(get_tested_path(Path('ldd', path)))
def lddparser(path, system_path=None):
if system_path is None:
system_path = path
return LddParser(get_full_path(path), system_path, True)
def run_elf_checks(test, pkg, pkgfile):
test._detect_attributes(get_magic(pkgfile.path))
test.run_elf_checks(pkg, pkgfile)
@pytest.mark.skipif(not IS_X86_64, reason='x86-64 only')
def test_unused_dependency():
ldd = lddparser('libtirpc.so.3.0.0')
assert not ldd.parsing_failed_reason
assert len(ldd.unused_dependencies) >= 1
assert 'liXXXsapi_krb5.so.2' in ldd.unused_dependencies
@pytest.mark.skipif(not IS_X86_64, reason='x86-64 only')
def test_undefined_symbol():
ldd = lddparser('libtirpc.so.3.0.0')
assert not ldd.parsing_failed_reason
assert len(ldd.undefined_symbols) >= 22
assert 'GSS_C_NT_HOSTBASED_SERVICE' in ldd.undefined_symbols
def test_ldd_parser_failure():
ldd = lddparser('not-existing-file')
assert 'not-existing-file: No such file or directory' in ldd.parsing_failed_reason
@pytest.mark.skipif(not IS_X86_64, reason='x86-64 only')
def test_dependencies():
ldd = lddparser('libtirpc.so.3.0.0')
assert not ldd.parsing_failed_reason
assert len(ldd.dependencies) == 5
assert any(d for d in ldd.dependencies if d.startswith('linux-vdso.so.1'))
@pytest.mark.skipif(not IS_X86_64, reason='x86-64 only')
def test_unused_dependency_in_package(binariescheck):
output, test = binariescheck
with FakePkg('fake') as pkg:
pkgfile = pkg.add_file(get_full_path('libtirpc.so.3.0.0'), '/lib64/x.so')
run_elf_checks(test, pkg, pkgfile)
assert not test.readelf_parser.parsing_failed_reason()
assert not test.ldd_parser.parsing_failed_reason
out = output.print_results(output.results)
assert 'E: unused-direct-shlib-dependency ' in out
@pytest.mark.skipif(not IS_X86_64, reason='x86-64 only')
def test_unused_dependency_in_package_for_executable(binariescheck):
output, test = binariescheck
with FakePkg('fake') as pkg:
pkgfile = pkg.add_file(get_full_path('appletviewer'), '/usr/bin/appletviewer')
run_elf_checks(test, pkg, pkgfile)
assert not test.readelf_parser.parsing_failed_reason()
assert not test.ldd_parser.parsing_failed_reason
out = output.print_results(output.results)
assert 'W: unused-direct-shlib-dependency ' in out
@pytest.mark.skipif(not IS_X86_64, reason='x86-64 only')
def test_opt_dependency(binariescheck):
output, test = binariescheck
with FakePkg('fake') as pkg:
pkgfile = pkg.add_file(get_full_path('opt-dependency'), '/bin/opt-dependency')
run_elf_checks(test, pkg, pkgfile)
assert not test.readelf_parser.parsing_failed_reason()
assert not test.ldd_parser.parsing_failed_reason
out = output.print_results(output.results)
assert 'E: linked-against-opt-library /bin/opt-dependency /opt/libfoo.so' in out
@pytest.mark.skipif(not IS_X86_64, reason='x86-64 only')
def test_usr_dependency(binariescheck):
output, test = binariescheck
with FakePkg('fake') as pkg:
pkgfile = pkg.add_file(get_full_path('usr-dependency'), '/bin/usr-dependency')
run_elf_checks(test, pkg, pkgfile)
assert not test.readelf_parser.parsing_failed_reason()
assert not test.ldd_parser.parsing_failed_reason
out = output.print_results(output.results)
assert 'W: linked-against-usr-library /bin/usr-dependency /usr/libfoo.so' in out
|
