1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
|
from mockdata.mock_python import (
IPythonMissingRequirePackage,
PythonDocFolderPackage,
PythonDocModulePackage,
PythonEggInfoFileackage,
PythonFlitFedoraMockPackage,
PythonFlitLeftoverRequirePackage,
PythonFlitMissingRequirePackage,
PythonFlitMockPackage,
PythonIcecreamLeftoverRequirePackage,
PythonIcecreamMissingRequirePackage,
PythonIcecreamPackage,
PythonJupyterEventsMockPackage,
PythonJupyterServerFileidMockPackage,
PythonMultiplePYCMockPackage,
PythonScikitBuildMockPackage,
PythonSinglePYCMockPackage,
)
import pytest
from rpmlint.checks.PythonCheck import PythonCheck
from rpmlint.filter import Filter
from Testing import CONFIG, get_tested_mock_package
@pytest.fixture(scope='function', autouse=True)
def pythoncheck():
CONFIG.info = True
output = Filter(CONFIG)
test = PythonCheck(CONFIG, output)
yield output, test
@pytest.fixture
def output(pythoncheck):
output, _test = pythoncheck
yield output
@pytest.fixture
def test(pythoncheck):
_output, test = pythoncheck
yield test
@pytest.mark.parametrize('package', [PythonDocFolderPackage])
def test_python_doc_in_package(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-doc-in-package /usr/lib/python2.7/site-packages/python-mypackage/doc' in out
assert 'W: python-doc-in-package /usr/lib/python2.7/site-packages/python-mypackage/docs' in out
assert 'W: python-doc-in-package /usr/lib/python3.10/site-packages/python-mypackage/doc' in out
assert 'W: python-doc-in-package /usr/lib/python3.10/site-packages/python-mypackage/docs' in out
assert 'W: python-doc-in-package /usr/lib64/python2.7/site-packages/python-mypackage/doc' in out
assert 'W: python-doc-in-package /usr/lib64/python2.7/site-packages/python-mypackage/docs' in out
assert 'W: python-doc-in-package /usr/lib64/python3.10/site-packages/python-mypackage/doc' in out
assert 'W: python-doc-in-package /usr/lib64/python3.10/site-packages/python-mypackage/docs' in out
@pytest.mark.parametrize('package', [PythonDocModulePackage])
def test_python_doc_module_in_package(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-doc-in-package /usr/lib/python2.7/site-packages/python-mypackage/doc' not in out
assert 'W: python-doc-in-package /usr/lib/python2.7/site-packages/python-mypackage/docs' not in out
assert 'W: python-doc-in-package /usr/lib/python3.10/site-packages/python-mypackage/doc' not in out
assert 'W: python-doc-in-package /usr/lib/python3.10/site-packages/python-mypackage/docs' not in out
assert 'W: python-doc-in-package /usr/lib64/python2.7/site-packages/python-mypackage/doc' not in out
assert 'W: python-doc-in-package /usr/lib64/python2.7/site-packages/python-mypackage/docs' not in out
assert 'W: python-doc-in-package /usr/lib64/python3.10/site-packages/python-mypackage/doc' not in out
assert 'W: python-doc-in-package /usr/lib64/python3.10/site-packages/python-mypackage/docs' not in out
@pytest.mark.parametrize('package', [PythonEggInfoFileackage])
def test_python_distutils_egg_info(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'E: python-egg-info-distutils-style /usr/lib/python2.7/site-packages/mydistutilspackage.egg-info' in out
assert 'E: python-egg-info-distutils-style /usr/lib/python3.10/site-packages/mydistutilspackage.egg-info' in out
assert 'E: python-egg-info-distutils-style /usr/lib64/python2.7/site-packages/mydistutilspackage.egg-info' in out
assert 'E: python-egg-info-distutils-style /usr/lib64/python3.10/site-packages/mydistutilspackage.egg-info' in out
@pytest.mark.parametrize('package', [get_tested_mock_package(
files=[
'/usr/lib/python2.7/site-packages/doc',
'/usr/lib/python2.7/site-packages/docs',
'/usr/lib/python3.10/site-packages/doc',
'/usr/lib/python3.10/site-packages/docs',
'/usr/lib64/python2.7/site-packages/doc',
'/usr/lib64/python2.7/site-packages/docs',
'/usr/lib64/python3.10/site-packages/doc',
'/usr/lib64/python3.10/site-packages/docs',
]
)])
def test_python_doc_in_site_packages(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'E: python-doc-in-site-packages /usr/lib/python2.7/site-packages/doc' in out
assert 'E: python-doc-in-site-packages /usr/lib/python2.7/site-packages/docs' in out
assert 'E: python-doc-in-site-packages /usr/lib/python3.10/site-packages/doc' in out
assert 'E: python-doc-in-site-packages /usr/lib/python3.10/site-packages/docs' in out
assert 'E: python-doc-in-site-packages /usr/lib64/python2.7/site-packages/doc' in out
assert 'E: python-doc-in-site-packages /usr/lib64/python2.7/site-packages/docs' in out
assert 'E: python-doc-in-site-packages /usr/lib64/python3.10/site-packages/doc' in out
assert 'E: python-doc-in-site-packages /usr/lib64/python3.10/site-packages/docs' in out
@pytest.mark.parametrize('package', [get_tested_mock_package(
files=[
'/usr/lib/python2.7/site-packages/src',
'/usr/lib/python3.10/site-packages/src',
'/usr/lib64/python2.7/site-packages/src',
'/usr/lib64/python3.10/site-packages/src',
]
)])
def test_python_src_in_site_packages(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'E: python-src-in-site-packages /usr/lib/python2.7/site-packages/src' in out
assert 'E: python-src-in-site-packages /usr/lib/python3.10/site-packages/src' in out
assert 'E: python-src-in-site-packages /usr/lib64/python2.7/site-packages/src' in out
assert 'E: python-src-in-site-packages /usr/lib64/python3.10/site-packages/src' in out
@pytest.mark.parametrize('package', [get_tested_mock_package(
files=[
'/usr/lib/python2.7/site-packages/test',
'/usr/lib/python2.7/site-packages/tests',
'/usr/lib/python3.10/site-packages/test',
'/usr/lib/python3.10/site-packages/tests',
'/usr/lib64/python2.7/site-packages/test',
'/usr/lib64/python2.7/site-packages/tests',
'/usr/lib64/python3.10/site-packages/test',
'/usr/lib64/python3.10/site-packages/tests',
]
)])
def test_python_tests_in_site_packages(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'E: python-tests-in-site-packages /usr/lib/python2.7/site-packages/test' in out
assert 'E: python-tests-in-site-packages /usr/lib/python2.7/site-packages/tests' in out
assert 'E: python-tests-in-site-packages /usr/lib/python3.10/site-packages/test' in out
assert 'E: python-tests-in-site-packages /usr/lib/python3.10/site-packages/tests' in out
assert 'E: python-tests-in-site-packages /usr/lib64/python2.7/site-packages/test' in out
assert 'E: python-tests-in-site-packages /usr/lib64/python2.7/site-packages/tests' in out
assert 'E: python-tests-in-site-packages /usr/lib64/python3.10/site-packages/test' in out
assert 'E: python-tests-in-site-packages /usr/lib64/python3.10/site-packages/tests' in out
@pytest.mark.parametrize('package', [PythonFlitMockPackage,
PythonJupyterServerFileidMockPackage,
PythonJupyterEventsMockPackage,
PythonScikitBuildMockPackage,
PythonFlitFedoraMockPackage,])
def test_python_dependencies_metadata(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-missing-require' not in out
assert 'W: python-leftover-require' not in out
@pytest.mark.parametrize('package', [PythonIcecreamPackage])
def test_python_dependencies_requires(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-missing-require' not in out
assert 'W: python-leftover-require' not in out
@pytest.mark.parametrize('package', [PythonIcecreamMissingRequirePackage])
def test_python_dependencies_missing_requires(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-missing-require' in out
@pytest.mark.parametrize('package', [PythonFlitMissingRequirePackage])
def test_python_dependencies_missing_metadata(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-missing-require' in out
@pytest.mark.parametrize('package', [
PythonIcecreamLeftoverRequirePackage,
PythonFlitLeftoverRequirePackage,
])
def test_python_dependencies_leftover(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-leftover-require' in out
@pytest.mark.parametrize('package', [PythonMultiplePYCMockPackage])
def test_python_pyc_multiple_versions(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-pyc-multiple-versions expected: 310' in out
@pytest.mark.parametrize('package', [PythonSinglePYCMockPackage])
def test_python_pyc_single_version(package, test, output):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-pyc-multiple-versions' not in out
@pytest.mark.parametrize('package', [
get_tested_mock_package(files=['/usr/share/doc/packages/python-blinker-doc/.doctrees']),
get_tested_mock_package(files=['/usr/lib/python3.11/site-packages/python-blinker/.doctrees']),
])
def test_python_sphinx_doctrees_leftover_warn(package, output, test):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-sphinx-doctrees-leftover' in out
@pytest.mark.parametrize('package', [
get_tested_mock_package(files=['/usr/lib/python3.11/site-packages/python-blinker/doctrees.py']),
get_tested_mock_package(files=['/usr/share/doc/packages/python-blinker-doc/doctrees']),
get_tested_mock_package(files=['/usr/share/doc/packages/python-blinker-doc/.doctrees.html']),
])
def test_python_sphinx_doctrees_leftover_nowarn(package, output, test):
test.check(package)
out = output.print_results(output.results)
assert 'W: python-sphinx-doctrees-leftover' not in out
@pytest.mark.parametrize('package', [IPythonMissingRequirePackage])
def test_python_dependencies_ipython(package, test, output):
test.check(package)
out = output.print_results(output.results)
requirements = [
'backcall',
'decorator',
'jedi',
'matplotlib-inline',
'pickleshare',
'prompt_toolkit',
'pygments',
'stack_data',
'traitlets',
]
for req in requirements:
assert f'W: python-missing-require {req}' in out
# typing_extensions is in section [:python_version < "3.10"]
assert 'W: python-missing-require typing_extensions' not in out
# req312 is in section [:python_version > "3.11"]
assert 'W: python-missing-require req312' in out
# leftover is in section [:python_version < "3.10"]
assert 'W: python-leftover-require python-leftover' in out
assert 'W: python-leftover-require python-no-leftover' not in out
|
