1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
|
# frozen_string_literal: true
module Shared
module List
def setup
(1..4).each do |counter|
node = ListMixin.new parent_id: 5
node.pos = counter
node.save!
end
end
def test_current_position
first_item = ListMixin.where(parent_id: 5).first
assert_equal 1, first_item.current_position
first_item.remove_from_list
assert_nil first_item.current_position
end
def test_reordering
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 2).first.move_lower
assert_equal [1, 3, 2, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 2).first.move_higher
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 1).first.move_to_bottom
assert_equal [2, 3, 4, 1], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 1).first.move_to_top
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 2).first.move_to_bottom
assert_equal [1, 3, 4, 2], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 4).first.move_to_top
assert_equal [4, 1, 3, 2], ListMixin.where(parent_id: 5).order('pos').map(&:id)
end
def test_move_to_bottom_with_next_to_last_item
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 3).first.move_to_bottom
assert_equal [1, 2, 4, 3], ListMixin.where(parent_id: 5).order('pos').map(&:id)
end
def test_next_prev
assert_equal ListMixin.where(id: 2).first, ListMixin.where(id: 1).first.lower_item
assert_nil ListMixin.where(id: 1).first.higher_item
assert_equal ListMixin.where(id: 3).first, ListMixin.where(id: 4).first.higher_item
assert_nil ListMixin.where(id: 4).first.lower_item
end
def test_injection
item = ListMixin.new(parent_id: 1)
assert_equal({ parent_id: 1 }, item.scope_condition)
assert_equal "pos", item.position_column
end
def test_insert
new = ListMixin.create(parent_id: 20)
assert_equal 1, new.pos
assert new.first?
assert new.last?
new = ListMixin.create(parent_id: 20)
assert_equal 2, new.pos
assert !new.first?
assert new.last?
new = ListMixin.acts_as_list_no_update { ListMixin.create(parent_id: 20) }
assert_equal_or_nil $default_position, new.pos
assert_equal $default_position.is_a?(Integer), new.first?
assert !new.last?
new = ListMixin.create(parent_id: 20)
assert_equal 3, new.pos
assert !new.first?
assert new.last?
new = ListMixin.create(parent_id: 0)
assert_equal 1, new.pos
assert new.first?
assert new.last?
end
def test_insert_at
new = ListMixin.create(parent_id: 20)
assert_equal 1, new.pos
new = ListMixin.create(parent_id: 20)
assert_equal 2, new.pos
new = ListMixin.create(parent_id: 20)
assert_equal 3, new.pos
new_noup = ListMixin.acts_as_list_no_update { ListMixin.create(parent_id: 20) }
assert_equal_or_nil $default_position, new_noup.pos
new4 = ListMixin.create(parent_id: 20)
assert_equal 4, new4.pos
new4.insert_at(3)
assert_equal 3, new4.pos
new.reload
assert_equal 4, new.pos
new.insert_at(2)
assert_equal 2, new.pos
new4.reload
assert_equal 4, new4.pos
new5 = ListMixin.create(parent_id: 20)
assert_equal 5, new5.pos
new5.insert_at(1)
assert_equal 1, new5.pos
new4.reload
assert_equal 5, new4.pos
new_noup.reload
assert_equal_or_nil $default_position, new_noup.pos
last1 = ListMixin.where('pos IS NOT NULL').order('pos').last
last2 = ListMixin.where('pos IS NOT NULL').order('pos').last
last1.insert_at(1)
last2.insert_at(1)
pos_list = ListMixin.where(parent_id: 20).order("pos ASC#{' NULLS FIRST' if ENV['DB'] == 'postgresql'}").map(&:pos)
assert_equal [$default_position, 1, 2, 3, 4, 5], pos_list
end
def test_insert_at_after_dup
new1 = ListMixin.create(parent_id: 20)
new2 = ListMixin.create(parent_id: 20)
new3 = ListMixin.create(parent_id: 20)
duped = new1.dup
duped.save
[new1, new2, new3, duped].map(&:reload)
assert_equal [1, 2, 3, 4], [duped.pos, new1.pos, new2.pos, new3.pos]
end
def test_delete_middle
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 2).first.destroy
assert_equal [1, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
assert_equal 1, ListMixin.where(id: 1).first.pos
assert_equal 2, ListMixin.where(id: 3).first.pos
assert_equal 3, ListMixin.where(id: 4).first.pos
ListMixin.where(id: 1).first.destroy
assert_equal [3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
assert_equal 1, ListMixin.where(id: 3).first.pos
assert_equal 2, ListMixin.where(id: 4).first.pos
ListMixin.acts_as_list_no_update { ListMixin.where(id: 3).first.destroy }
assert_equal [4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
assert_equal 2, ListMixin.where(id: 4).first.pos
end
def test_with_string_based_scope
new = ListWithStringScopeMixin.create(parent_id: 500)
assert_equal 1, new.pos
assert new.first?
assert new.last?
end
def test_nil_scope
new1, new2, new3 = ListMixin.create, ListMixin.create, ListMixin.create
new2.move_higher
assert_equal [new2, new1, new3].map(&:id), ListMixin.where(parent_id: nil).order('pos').map(&:id)
end
def test_update_position_when_scope_changes
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.create(parent_id: 6)
ListMixin.where(id: 2).first.move_within_scope(6)
assert_equal 2, ListMixin.where(id: 2).first.pos
assert_equal [1, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
assert_equal 1, ListMixin.where(id: 1).first.pos
assert_equal 2, ListMixin.where(id: 3).first.pos
assert_equal 3, ListMixin.where(id: 4).first.pos
ListMixin.where(id: 2).first.move_within_scope(5)
assert_equal [1, 3, 4, 2], ListMixin.where(parent_id: 5).order('pos').map(&:id)
end
def test_remove_from_list_should_then_fail_in_list?
assert_equal true, ListMixin.where(id: 1).first.in_list?
ListMixin.where(id: 1).first.remove_from_list
assert_equal false, ListMixin.where(id: 1).first.in_list?
end
def test_remove_from_list_should_set_position_to_nil
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 2).first.remove_from_list
assert_equal 1, ListMixin.where(id: 1).first.pos
assert_nil ListMixin.where(id: 2).first.pos
assert_equal 2, ListMixin.where(id: 3).first.pos
assert_equal 3, ListMixin.where(id: 4).first.pos
end
def test_remove_before_destroy_does_not_shift_lower_items_twice
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
ListMixin.where(id: 2).first.remove_from_list
ListMixin.where(id: 2).first.destroy
assert_equal [1, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
assert_equal 1, ListMixin.where(id: 1).first.pos
assert_equal 2, ListMixin.where(id: 3).first.pos
assert_equal 3, ListMixin.where(id: 4).first.pos
end
def test_before_destroy_callbacks_do_not_update_position_to_nil_before_deleting_the_record
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
# We need to trigger all the before_destroy callbacks without actually
# destroying the record so we can see the affect the callbacks have on
# the record.
list = ListMixin.where(id: 2).first
if list.respond_to?(:run_callbacks)
list.run_callbacks(:destroy)
else
list.send(:callback, :before_destroy)
end
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
assert_equal 1, ListMixin.where(id: 1).first.pos
assert_equal 2, ListMixin.where(id: 2).first.pos
assert_equal 2, ListMixin.where(id: 3).first.pos
assert_equal 3, ListMixin.where(id: 4).first.pos
end
def test_before_create_callback_adds_to_bottom
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
new = ListMixin.create(parent_id: 5)
assert_equal 5, new.pos
assert !new.first?
assert new.last?
assert_equal [1, 2, 3, 4, 5], ListMixin.where(parent_id: 5).order('pos').map(&:id)
end
def test_before_create_callback_adds_to_given_position
assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
new = ListMixin.new(parent_id: 5)
new.pos = 1
new.save!
assert_equal 1, new.pos
assert new.first?
assert !new.last?
assert_equal [5, 1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
new6 = ListMixin.new(parent_id: 5)
new6.pos = 3
new6.save!
assert_equal 3, new6.pos
assert !new6.first?
assert !new6.last?
assert_equal [5, 1, 6, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
new = ListMixin.new(parent_id: 5)
new.pos = 3
ListMixin.acts_as_list_no_update { new.save! }
assert_equal 3, new.pos
assert_equal 3, new6.pos
assert !new.first?
assert !new.last?
assert_equal [5, 1, 6, 7, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos, id').map(&:id)
end
def test_non_persisted_records_dont_get_lock_called
new = ListMixin.new(parent_id: 5)
new.destroy
end
def test_invalid_records_dont_get_inserted
new = ListMixinError.new(parent_id: 5, state: nil)
assert !new.valid?
new.insert_at(1)
assert !new.persisted?
end
def test_invalid_records_raise_error_with_insert_at!
new = ListMixinError.new(parent_id: 5, state: nil)
assert !new.valid?
assert_raises ActiveRecord::RecordInvalid do
new.insert_at!(1)
end
end
def test_find_or_create_doesnt_raise_deprecation_warning
assert_no_deprecation_warning_raised_by('ActiveRecord deprecation warning raised when using `find_or_create_by` when we didn\'t expect it') do
ListMixin.where(parent_id: 5).find_or_create_by(pos: 5)
end
end
end
end
|
