1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
|
# frozen_string_literal: true
require 'spec_helper'
if mongoid?
describe Bullet::Detector::Association do
context 'embeds_many' do
context 'posts => users' do
it 'should detect nothing' do
Mongoid::Post.all.each { |post| post.users.map(&:name) }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
end
end
context 'has_many' do
context 'posts => comments' do
it 'should detect non preload posts => comments' do
Mongoid::Post.all.each { |post| post.comments.map(&:name) }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Mongoid::Post, :comments)
end
it 'should detect preload post => comments' do
Mongoid::Post.includes(:comments).each { |post| post.comments.map(&:name) }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should detect unused preload post => comments' do
Mongoid::Post.includes(:comments).map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Mongoid::Post, :comments)
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should not detect unused preload post => comments' do
Mongoid::Post.all.map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
end
context 'category => posts, category => entries' do
it 'should detect non preload with category => [posts, entries]' do
Mongoid::Category.all.each do |category|
category.posts.map(&:name)
category.entries.map(&:name)
end
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Mongoid::Category, :posts)
expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Mongoid::Category, :entries)
end
it 'should detect preload with category => posts, but not with category => entries' do
Mongoid::Category.includes(:posts).each do |category|
category.posts.map(&:name)
category.entries.map(&:name)
end
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(
Mongoid::Category,
:posts
)
expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Mongoid::Category, :entries)
end
it 'should detect preload with category => [posts, entries]' do
Mongoid::Category.includes(:posts, :entries).each do |category|
category.posts.map(&:name)
category.entries.map(&:name)
end
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should detect unused preload with category => [posts, entries]' do
Mongoid::Category.includes(:posts, :entries).map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Mongoid::Category, :posts)
expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Mongoid::Category, :entries)
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should detect unused preload with category => entries, but not with category => posts' do
Mongoid::Category.includes(:posts, :entries).each { |category| category.posts.map(&:name) }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Mongoid::Category, :posts)
expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Mongoid::Category, :entries)
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
end
context 'post => comment' do
it 'should detect unused preload with post => comments' do
Mongoid::Post.includes(:comments).each { |post| post.comments.first.name }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Mongoid::Post, :comments)
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should detect preload with post => comments' do
Mongoid::Post.first.comments.map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
end
context 'scope preload_comments' do
it 'should detect preload post => comments with scope' do
Mongoid::Post.preload_comments.each { |post| post.comments.map(&:name) }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should detect unused preload with scope' do
Mongoid::Post.preload_comments.map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Mongoid::Post, :comments)
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
end
end
context 'belongs_to' do
context 'comment => post' do
it 'should detect non preload with comment => post' do
Mongoid::Comment.all.each { |comment| comment.post.name }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Mongoid::Comment, :post)
end
it 'should detect preload with one comment => post' do
Mongoid::Comment.first.post.name
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should detect preload with comment => post' do
Mongoid::Comment.includes(:post).each { |comment| comment.post.name }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should not detect preload with comment => post' do
Mongoid::Comment.all.map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should detect unused preload with comments => post' do
Mongoid::Comment.includes(:post).map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Mongoid::Comment, :post)
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
end
end
context 'has_one' do
context 'company => address' do
if Mongoid::VERSION !~ /\A3.0/
it 'should detect non preload association' do
Mongoid::Company.all.each { |company| company.address.name }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(
Mongoid::Company,
:address
)
end
end
it 'should detect preload association' do
Mongoid::Company.includes(:address).each { |company| company.address.name }
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should not detect preload association' do
Mongoid::Company.all.map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
it 'should detect unused preload association' do
criteria = Mongoid::Company.includes(:address)
criteria.map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Mongoid::Company, :address)
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
end
end
context 'call one association that in possible objects' do
it 'should not detect preload association' do
Mongoid::Post.all
Mongoid::Post.first.comments.map(&:name)
Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
expect(Bullet::Detector::Association).to be_completely_preloading_associations
end
end
end
end
|
