1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568
|
# frozen_string_literal: true
RSpec.describe DeclarativePolicy::Rule do
let(:ctx) { instance_double(DeclarativePolicy::Base) }
let(:pass_value) { true }
let(:cache_state) { true }
let(:score) { 17 }
let(:delegated_policies) { {} }
let(:manifest_condition) do
instance_double(DeclarativePolicy::ManifestCondition, pass?: pass_value, cached?: cache_state, score: score)
end
before do
allow(ctx).to receive(:condition).with(:foo).and_return(manifest_condition)
allow(ctx).to receive(:delegated_policies).and_return(delegated_policies)
end
describe 'combinators' do
let(:x) { DeclarativePolicy::Rule::Condition.new(:x) }
let(:y) { DeclarativePolicy::Rule::Condition.new(:y) }
describe '#or' do
it 'builds an Or node' do
expect(x.or(y).repr).to eq 'any?(x, y)'
expect((x | y).repr).to eq 'any?(x, y)'
end
end
describe '#and' do
it 'builds an And node' do
expect(x.and(y).repr).to eq 'all?(x, y)'
expect((x & y).repr).to eq 'all?(x, y)'
end
end
describe '#negate' do
it 'builds a Not node' do
expect(x.negate.repr).to eq '~x'
expect((~y).repr).to eq '~y'
end
end
end
describe DeclarativePolicy::Rule::Condition do
subject { described_class.new(:foo) }
describe '#pass?' do
it 'delegates to the underlying condition' do
expect(subject.pass?(ctx)).to eq pass_value
end
end
describe '#cached_pass?' do
context 'when cached' do
it 'calls pass?' do
expect(manifest_condition).to receive(:pass?)
expect(subject.cached_pass?(ctx)).to eq pass_value
end
end
context 'when not cached' do
let(:cache_state) { false }
it 'does not call pass' do
expect(manifest_condition).not_to receive(:pass?)
expect(subject.cached_pass?(ctx)).to be_nil
end
end
end
describe '#score' do
# see ManifestCondition for scoring rules when cached.
it 'delegates to the underlying condition' do
expect(subject.score(ctx)).to eq 17
end
end
describe '#simplify' do
it 'cannot be simplfied' do
expect(subject.simplify).to be subject
end
end
describe '#inspect' do
it 'is represented by the condition name' do
expect(subject.repr).to eq 'foo'
end
end
end
describe DeclarativePolicy::Rule::Not do
let(:underlying) { DeclarativePolicy::Rule::Condition.new(:foo) }
subject { described_class.new(underlying) }
describe '#pass?' do
it 'is the inverse of the underlying rule' do
expect(subject.pass?(ctx)).to eq !underlying.pass?(ctx)
end
end
describe '#cached_pass?' do
context 'when cached' do
it 'calls pass?' do
expect(manifest_condition).to receive(:pass?)
expect(subject.cached_pass?(ctx)).to eq !pass_value
end
end
context 'when not cached' do
let(:cache_state) { false }
it 'does not call pass' do
expect(manifest_condition).not_to receive(:pass?)
expect(subject.cached_pass?(ctx)).to be_nil
end
end
end
describe '#score' do
it 'delegates to the underlying condition' do
expect(subject.score(ctx)).to eq 17
end
end
describe '#simplify' do
it 'cannot be simplfied' do
expect(subject.simplify.repr).to eq subject.repr
end
context 'when there is double-negation' do
let(:underlying) { described_class.new(DeclarativePolicy::Rule::Condition.new(:foo)) }
it 'discards the negation' do
expect(subject.simplify.repr).to eq 'foo'
end
end
context "with DeMorgan's Law" do
let(:a) { DeclarativePolicy::Rule::Condition.new(:a) }
let(:b) { DeclarativePolicy::Rule::Condition.new(:b) }
context 'with !(a && b)' do
let(:underlying) { a & b }
it 'simplifies to (!a || !b)' do
expect(subject.simplify.repr).to eq((~a | ~b).repr)
end
end
context 'with !(a || b)' do
let(:underlying) { a | b }
it 'simplifies to (!a && !b)' do
expect(subject.simplify.repr).to eq((~a & ~b).repr)
end
end
end
end
describe '#inspect' do
it 'is represented by the condition name prefixed with ~' do
expect(subject.repr).to eq '~foo'
end
end
end
describe DeclarativePolicy::Rule::DelegatedCondition do
subject { described_class.new(:wibble, :foo) }
describe '#pass?' do
context 'when the delegate does not exist' do
it 'is false' do
expect(subject.pass?(ctx)).to be false
end
end
context 'when the delegate does exist' do
let(:delegated_policies) { { wibble: ctx } }
it 'is whatever the delegated condition returns' do
expect(subject.pass?(ctx)).to eq pass_value
end
end
end
describe '#cached_pass?' do
context 'when the delegate does not exist' do
it 'is false' do
expect(subject.cached_pass?(ctx)).to be false
end
end
context 'when the delegate does exist' do
let(:delegated_policies) { { wibble: ctx } }
context 'when cached' do
it 'calls pass?' do
expect(manifest_condition).to receive(:pass?)
expect(subject.cached_pass?(ctx)).to eq pass_value
end
end
context 'when not cached' do
let(:cache_state) { false }
it 'does not call pass' do
expect(manifest_condition).not_to receive(:pass?)
expect(subject.cached_pass?(ctx)).to be_nil
end
end
end
end
describe '#score' do
context 'when the delegate does not exist' do
it 'is zero' do
expect(subject.score(ctx)).to eq 0
end
end
context 'when the delegate does exist' do
let(:delegated_policies) { { wibble: ctx } }
it 'delegates to the underlying condition' do
expect(subject.score(ctx)).to eq 17
end
end
end
describe '#simplify' do
it 'cannot be simplfied' do
expect(subject.simplify.repr).to eq subject.repr
end
end
describe '#inspect' do
it 'is represented by the delegate name followed by the condition name' do
expect(subject.repr).to eq 'wibble.foo'
end
end
end
describe DeclarativePolicy::Rule::Ability do
let(:runner) { instance_double(DeclarativePolicy::Runner, score: 13, cached?: cache_state, pass?: pass_value) }
before do
allow(ctx).to receive(:runner).with(:do_foo).and_return(runner)
end
subject { described_class.new(:do_foo) }
describe '#pass?' do
it 'is equivalent to calling Policy#allowed?(ability)' do
expect(ctx).to receive(:allowed?).with(:do_foo).and_return(pass_value)
expect(subject.pass?(ctx)).to eq pass_value
end
end
describe '#cached_pass?' do
context 'when cached' do
it 'calls pass?' do
expect(runner).to receive(:pass?)
expect(subject.cached_pass?(ctx)).to eq pass_value
end
end
context 'when not cached' do
let(:cache_state) { false }
it 'does not call pass' do
expect(runner).not_to receive(:pass?)
expect(subject.cached_pass?(ctx)).to be_nil
end
end
end
describe '#score' do
it 'delegates to the runner' do
expect(subject.score(ctx)).to eq 13
end
end
describe '#simplify' do
it 'cannot be simplfied' do
expect(subject.simplify.repr).to eq subject.repr
end
end
describe '#inspect' do
it 'is represented by can and the ability name' do
expect(subject.repr).to eq 'can?(:do_foo)'
end
end
end
describe DeclarativePolicy::Rule::And do
let(:rules) do
[
DeclarativePolicy::Rule::Condition.new(:foo),
DeclarativePolicy::Rule::Condition.new(:bar),
DeclarativePolicy::Rule::Condition.new(:baz)
]
end
let(:bar) { { pass: true, cached: true, score: 7 } }
let(:baz) { { pass: true, cached: true, score: 8 } }
def cond(values)
instance_double(DeclarativePolicy::ManifestCondition,
pass?: values[:pass], cached?: values[:cached], score: values[:score])
end
before do
allow(ctx).to receive(:condition).with(:bar) { cond(bar) }
allow(ctx).to receive(:condition).with(:baz) { cond(baz) }
end
subject { described_class.new(rules) }
describe '#pass?' do
it 'is equivalent to rules.all? { _1.pass? }' do
expect(subject.pass?(ctx)).to be true
end
context 'when any rule does not pass' do
it 'does not pass' do
bar[:pass] = false
expect(subject.pass?(ctx)).to be false
end
end
end
describe '#cached_pass?' do
context 'when all rules are cached' do
it 'calls pass? on each rule' do
expect(subject.cached_pass?(ctx)).to be true
end
end
context 'when not fully cached' do
before do
baz[:cached] = false
end
it 'does not call pass' do
expect(subject.rules.last).not_to receive(:pass?)
expect(subject.cached_pass?(ctx)).to be_nil
end
end
context 'when not fully cached, but known to be false' do
before do
baz[:cached] = false
bar[:pass] = false
end
it 'is false' do
expect(subject.cached_pass?(ctx)).to be false
end
end
end
describe '#score' do
context 'when fully cached' do
it 'is zero' do
expect(subject.score(ctx)).to eq 0
end
end
context 'when not fully cached' do
before do
baz[:cached] = false
end
it 'is the sum of the score of the rules' do
expect(subject.score(ctx)).to eq(17 + 7 + 8)
end
end
context 'when not fully cached, but known to be false' do
before do
baz[:cached] = false
bar[:pass] = false
end
it 'is zero' do
expect(subject.score(ctx)).to eq 0
end
end
end
describe '#simplify' do
it 'cannot be simplfied' do
expect(subject.simplify.repr).to eq subject.repr
end
context 'when any of the rules are themselves AND nodes, or simplify to AND nodes' do
let(:new_rules) do
[
DeclarativePolicy::Rule::Condition.new(:x),
DeclarativePolicy::Rule::Condition.new(:y),
DeclarativePolicy::Rule::Condition.new(:w),
DeclarativePolicy::Rule::Condition.new(:z)
]
end
before do
x, y, w, z = new_rules
and_node = described_class.new([x, y])
demorgan_and = DeclarativePolicy::Rule::Not.new(DeclarativePolicy::Rule::Or.new([w, z]))
rules << and_node
rules << demorgan_and
end
it 'flattens out any nested rules' do
expect(subject.simplify.repr).to eq 'all?(foo, bar, baz, x, y, ~w, ~z)'
end
end
end
describe '#inspect' do
it 'is represented by all? and the rules' do
expect(subject.repr).to eq 'all?(foo, bar, baz)'
end
end
end
describe DeclarativePolicy::Rule::Or do
let(:rules) do
[
DeclarativePolicy::Rule::Condition.new(:foo),
DeclarativePolicy::Rule::Condition.new(:bar),
DeclarativePolicy::Rule::Condition.new(:baz)
]
end
let(:bar) { { pass: false, cached: true, score: 7 } }
let(:baz) { { pass: false, cached: true, score: 8 } }
def cond(values)
instance_double(DeclarativePolicy::ManifestCondition,
pass?: values[:pass], cached?: values[:cached], score: values[:score])
end
before do
allow(ctx).to receive(:condition).with(:bar) { cond(bar) }
allow(ctx).to receive(:condition).with(:baz) { cond(baz) }
end
subject { described_class.new(rules) }
describe '#pass?' do
it 'is equivalent to rules.any? { _1.pass? }' do
expect(subject.pass?(ctx)).to be true
end
context 'when no rule passes' do
let(:pass_value) { false }
it 'does not pass' do
expect(subject.pass?(ctx)).to be false
end
end
end
describe '#cached_pass?' do
context 'when all rules are cached' do
it 'is true' do
expect(subject.cached_pass?(ctx)).to be true
end
end
context 'when any false rule is not cached' do
before do
baz[:cached] = false
end
it 'is true' do
expect(subject.cached_pass?(ctx)).to be true
end
end
context 'when the true rule is not cached' do
let(:cache_state) { false }
it 'is unknown' do
expect(subject.cached_pass?(ctx)).to be_nil
end
end
end
describe '#score' do
context 'when fully cached' do
it 'is zero' do
expect(subject.score(ctx)).to eq 0
end
end
context 'when the true condition is not cached' do
let(:cache_state) { false }
it 'is the sum of the score of the rules' do
expect(subject.score(ctx)).to eq(17 + 7 + 8)
end
end
context 'when a false condition is not cached' do
before do
bar[:cached] = false
end
it 'is zero' do
expect(subject.score(ctx)).to eq 0
end
end
end
describe '#simplify' do
it 'cannot be simplfied' do
expect(subject.simplify.repr).to eq subject.repr
end
context 'when any of the rules are themselves OR nodes, or simplify to OR nodes' do
let(:new_rules) do
[
DeclarativePolicy::Rule::Condition.new(:x),
DeclarativePolicy::Rule::Condition.new(:y),
DeclarativePolicy::Rule::Condition.new(:w),
DeclarativePolicy::Rule::Condition.new(:z)
]
end
before do
x, y, w, z = new_rules
or_node = described_class.new([x, y])
demorgan_or = DeclarativePolicy::Rule::Not.new(DeclarativePolicy::Rule::And.new([w, z]))
rules << or_node
rules << demorgan_or
end
it 'flattens out any nested rules' do
expect(subject.simplify.repr).to eq 'any?(foo, bar, baz, x, y, ~w, ~z)'
end
end
end
describe '#inspect' do
it 'is represented by all? and the rules' do
expect(subject.repr).to eq 'any?(foo, bar, baz)'
end
end
end
end
|