1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
|
require 'flipper/adapters/active_record'
# Turn off migration logging for specs
ActiveRecord::Migration.verbose = false
RSpec.describe Flipper::Adapters::ActiveRecord do
subject { described_class.new }
before(:all) do
ActiveRecord::Base.establish_connection(adapter: 'sqlite3',
database: ':memory:')
end
before(:each) do
ActiveRecord::Base.connection.execute <<-SQL
CREATE TABLE flipper_features (
id integer PRIMARY KEY,
key text NOT NULL UNIQUE,
created_at datetime NOT NULL,
updated_at datetime NOT NULL
)
SQL
ActiveRecord::Base.connection.execute <<-SQL
CREATE TABLE flipper_gates (
id integer PRIMARY KEY,
feature_key text NOT NULL,
key text NOT NULL,
value text DEFAULT NULL,
created_at datetime NOT NULL,
updated_at datetime NOT NULL
)
SQL
ActiveRecord::Base.connection.execute <<-SQL
CREATE UNIQUE INDEX index_gates_on_keys_and_value on flipper_gates (feature_key, key, value)
SQL
end
after(:each) do
ActiveRecord::Base.connection.execute("DROP table IF EXISTS `flipper_features`")
ActiveRecord::Base.connection.execute("DROP table IF EXISTS `flipper_gates`")
end
it_should_behave_like 'a flipper adapter'
context 'requiring "flipper-active_record"' do
before do
Flipper.configuration = nil
Flipper.instance = nil
load 'flipper/adapters/active_record.rb'
ActiveSupport.run_load_hooks(:active_record, ActiveRecord::Base)
end
it 'configures itself' do
expect(Flipper.adapter.adapter).to be_a(Flipper::Adapters::ActiveRecord)
end
end
context "ActiveRecord connection_pool" do
before do
ActiveRecord::Base.clear_active_connections!
end
context "#features" do
it "does not hold onto connections" do
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.features
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
end
it "does not release previously held connection" do
ActiveRecord::Base.connection # establish a new connection
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.features
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
end
end
context "#get_all" do
it "does not hold onto connections" do
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.get_all
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
end
it "does not release previously held connection" do
ActiveRecord::Base.connection # establish a new connection
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.get_all
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
end
end
context "#add / #remove / #clear" do
let(:feature) { Flipper::Feature.new(:search, subject) }
it "does not hold onto connections" do
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.add(feature)
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.remove(feature)
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.clear(feature)
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
end
it "does not release previously held connection" do
ActiveRecord::Base.connection # establish a new connection
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.add(feature)
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.remove(feature)
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.clear(feature)
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
end
end
context "#get_multi" do
let(:feature) { Flipper::Feature.new(:search, subject) }
it "does not hold onto connections" do
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.get_multi([feature])
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
end
it "does not release previously held connection" do
ActiveRecord::Base.connection # establish a new connection
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.get_multi([feature])
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
end
end
context "#enable/#disable boolean" do
let(:feature) { Flipper::Feature.new(:search, subject) }
let(:gate) { feature.gate(:boolean)}
it "does not hold onto connections" do
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.enable(feature, gate, gate.wrap(true))
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.disable(feature, gate, gate.wrap(false))
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
end
it "does not release previously held connection" do
ActiveRecord::Base.connection # establish a new connection
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.enable(feature, gate, gate.wrap(true))
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.disable(feature, gate, gate.wrap(false))
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
end
end
context "#enable/#disable set" do
let(:feature) { Flipper::Feature.new(:search, subject) }
let(:gate) { feature.gate(:group) }
it "does not hold onto connections" do
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.enable(feature, gate, gate.wrap(:admin))
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
subject.disable(feature, gate, gate.wrap(:admin))
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(false)
end
it "does not release previously held connection" do
ActiveRecord::Base.connection # establish a new connection
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.enable(feature, gate, gate.wrap(:admin))
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
subject.disable(feature, gate, gate.wrap(:admin))
expect(ActiveRecord::Base.connection_handler.active_connections?).to be(true)
end
end
end
end
|
