1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628
|
require "helper"
class Journalist < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged
end
class Article < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged
end
class Novelist < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged, sequence_separator: "_"
def normalize_friendly_id(string)
super.tr("-", "_")
end
end
class SluggedTest < TestCaseClass
include FriendlyId::Test
include FriendlyId::Test::Shared::Core
include FriendlyId::Test::Shared::Slugged
def model_class
Journalist
end
test "should allow validations on the slug" do
model_class = Class.new(ActiveRecord::Base) do
self.table_name = "articles"
extend FriendlyId
friendly_id :name, use: :slugged
validates_length_of :slug, maximum: 1
def self.name
"Article"
end
end
instance = model_class.new name: "hello"
refute instance.valid?
end
test "should allow nil slugs" do
transaction do
m1 = model_class.create!
model_class.create!
assert_nil m1.slug
end
end
test "should not break validates_uniqueness_of" do
model_class = Class.new(ActiveRecord::Base) do
self.table_name = "journalists"
extend FriendlyId
friendly_id :name, use: :slugged
validates_uniqueness_of :slug_en
def self.name
"Journalist"
end
end
transaction do
instance = model_class.create! name: "hello", slug_en: "hello"
instance2 = model_class.create name: "hello", slug_en: "hello"
assert instance.valid?
refute instance2.valid?
end
end
test "should allow a record to reuse its own slug" do
with_instance_of(model_class) do |record|
old_id = record.friendly_id
record.slug = nil
record.save!
assert_equal old_id, record.friendly_id
end
end
test "should not update matching slug" do
klass = Class.new model_class do
def should_generate_new_friendly_id?
name_changed?
end
end
with_instance_of klass do |record|
old_id = record.friendly_id
record.name += " "
record.save!
assert_equal old_id, record.friendly_id
end
end
test "should set slug on create if unrelated validations fail" do
klass = Class.new model_class do
validates_presence_of :active
friendly_id :name, use: :slugged
def self.name
"Journalist"
end
end
transaction do
instance = klass.new name: "foo"
refute instance.save
refute instance.valid?
assert_equal "foo", instance.slug
end
end
test "should not set slug on create if slug validation fails" do
klass = Class.new model_class do
validates_presence_of :active
validates_length_of :slug, minimum: 2
friendly_id :name, use: :slugged
def self.name
"Journalist"
end
end
transaction do
instance = klass.new name: "x"
refute instance.save
refute instance.valid?
assert_nil instance.slug
end
end
test "should set slug on create if unrelated validations fail with custom slug_column" do
klass = Class.new(ActiveRecord::Base) do
self.table_name = "authors"
extend FriendlyId
validates_presence_of :active
friendly_id :name, use: :slugged, slug_column: :subdomain
def self.name
"Author"
end
end
transaction do
instance = klass.new name: "foo"
refute instance.save
refute instance.valid?
assert_equal "foo", instance.subdomain
end
end
test "should not set slug on create if custom slug column validations fail" do
klass = Class.new(ActiveRecord::Base) do
self.table_name = "authors"
extend FriendlyId
validates_length_of :subdomain, minimum: 2
friendly_id :name, use: :slugged, slug_column: :subdomain
def self.name
"Author"
end
end
transaction do
instance = klass.new name: "x"
refute instance.save
refute instance.valid?
assert_nil instance.subdomain
end
end
test "should keep new slug on save if unrelated validations fail" do
klass = Class.new model_class do
validates_presence_of :active
friendly_id :name, use: :slugged
def self.name
"Journalist"
end
end
transaction do
instance = klass.new name: "foo", active: true
assert instance.save
assert instance.valid?
instance.name = "foobar"
instance.slug = nil
instance.active = nil
refute instance.save
refute instance.valid?
assert_equal "foobar", instance.slug
end
end
test "should not update slug on save if slug validations fail" do
klass = Class.new model_class do
validates_length_of :slug, minimum: 2
friendly_id :name, use: :slugged
def self.name
"Journalist"
end
end
transaction do
instance = klass.new name: "foo", active: true
assert instance.save
assert instance.valid?
instance.name = "x"
instance.slug = nil
instance.active = nil
refute instance.save
assert_equal "foo", instance.slug
end
end
end
class SlugGeneratorTest < TestCaseClass
include FriendlyId::Test
def model_class
Journalist
end
test "should quote column names" do
model_class = Class.new(ActiveRecord::Base) do
# This has been added in 635731bb to fix MySQL/Rubinius. It may still
# be necessary, but causes an exception to be raised on Rails 4, so I'm
# commenting it out. If it causes MySQL/Rubinius to fail again we'll
# look for another solution.
# self.abstract_class = true
self.table_name = "journalists"
extend FriendlyId
friendly_id :name, use: :slugged, slug_column: "strange name"
end
begin
with_instance_of(model_class) { |record| assert model_class.friendly.find(record.friendly_id) }
rescue ActiveRecord::StatementInvalid
flunk "column name was not quoted"
end
end
test "should not resequence lower sequences on update" do
transaction do
m1 = model_class.create! name: "a b c d"
assert_equal "a-b-c-d", m1.slug
model_class.create! name: "a b c d"
m1 = model_class.friendly.find(m1.id)
m1.save!
assert_equal "a-b-c-d", m1.slug
end
end
test "should correctly sequence slugs that end with numbers" do
transaction do
record1 = model_class.create! name: "Peugeot 206"
assert_equal "peugeot-206", record1.slug
record2 = model_class.create! name: "Peugeot 206"
assert_match(/\Apeugeot-206-([a-z0-9]+-){4}[a-z0-9]+\z/, record2.slug)
end
end
test "should correctly sequence slugs with underscores" do
transaction do
Novelist.create! name: "wordsfail, buildings tumble"
record2 = Novelist.create! name: "word fail"
assert_equal "word_fail", record2.slug
end
end
test "should correctly sequence numeric slugs" do
transaction do
n2 = 2.times.map { Article.create name: "123" }.last
assert_match(/\A123-.*/, n2.friendly_id)
end
end
end
class SlugSeparatorTest < TestCaseClass
include FriendlyId::Test
class Journalist < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged, sequence_separator: ":"
end
def model_class
Journalist
end
test "should sequence with configured sequence separator" do
with_instance_of model_class do |record|
record2 = model_class.create! name: record.name
assert record2.friendly_id.match(/:.*\z/)
end
end
test "should detect when a stored slug has been cleared" do
with_instance_of model_class do |record|
record.slug = nil
assert record.should_generate_new_friendly_id?
end
end
test "should correctly sequence slugs that uses single dashes as sequence separator" do
model_class = Class.new(ActiveRecord::Base) do
self.table_name = "journalists"
extend FriendlyId
friendly_id :name, use: :slugged, sequence_separator: "-"
def self.name
"Journalist"
end
end
transaction do
record1 = model_class.create! name: "Peugeot 206"
assert_equal "peugeot-206", record1.slug
record2 = model_class.create! name: "Peugeot 206"
assert_match(/\Apeugeot-206-([a-z0-9]+-){4}[a-z0-9]+\z/, record2.slug)
end
end
test "should sequence blank slugs without a separator" do
with_instance_of model_class, name: "" do |record|
assert_match(/\A([a-z0-9]+-){4}[a-z0-9]+\z/, record.slug)
end
end
end
class SlugLimitTest < TestCaseClass
include FriendlyId::Test
class Journalist < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged, slug_limit: 40
end
def model_class
Journalist
end
test "should limit slug size" do
transaction do
m1 = model_class.create! name: "a" * 50
assert_equal m1.slug, "a" * 40
m2 = model_class.create! name: m1.name
m2.save!
# "aaa-<uid>"
assert_match(/\Aa{3}-/, m2.slug)
end
end
end
class DefaultScopeTest < TestCaseClass
include FriendlyId::Test
class Journalist < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged
default_scope -> { where(active: true).order("id ASC") }
end
test "friendly_id should correctly sequence a default_scoped ordered table" do
transaction do
3.times { assert Journalist.create name: "a", active: true }
end
end
test "friendly_id should correctly sequence a default_scoped scoped table" do
transaction do
assert Journalist.create name: "a", active: false
assert Journalist.create name: "a", active: true
end
end
end
class UuidAsPrimaryKeyFindTest < TestCaseClass
include FriendlyId::Test
class MenuItem < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged
before_create :init_primary_key
def self.primary_key
"uuid_key"
end
# Overwrite the method added by FriendlyId
def self.primary_key_type
:uuid
end
private
def init_primary_key
self.uuid_key = SecureRandom.uuid
end
end
def model_class
MenuItem
end
test "should have a uuid_key as a primary key" do
assert_equal "uuid_key", model_class.primary_key
assert_equal :uuid, model_class.primary_key_type
end
test "should be findable by the UUID primary key" do
with_instance_of(model_class) do |record|
assert model_class.friendly.find record.id
end
end
test "should handle a string that simply contains a UUID correctly" do
with_instance_of(model_class) do |record|
assert_raises(ActiveRecord::RecordNotFound) do
model_class.friendly.find "test-#{SecureRandom.uuid}"
end
end
end
end
class UnderscoreAsSequenceSeparatorRegressionTest < TestCaseClass
include FriendlyId::Test
class Manual < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged, sequence_separator: "_"
end
test "should not create duplicate slugs" do
3.times do
transaction do
assert Manual.create! name: "foo"
rescue
flunk "Tried to insert duplicate slug"
end
end
end
end
# https://github.com/norman/friendly_id/issues/148
class FailedValidationAfterUpdateRegressionTest < TestCaseClass
include FriendlyId::Test
class Journalist < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged
validates_presence_of :slug_de
end
test "to_param should return the unchanged value if the slug changes before validation fails" do
transaction do
journalist = Journalist.create! name: "Joseph Pulitzer", slug_de: "value"
assert_equal "joseph-pulitzer", journalist.to_param
assert journalist.valid?
assert journalist.persisted?
journalist.name = "Joe Pulitzer"
journalist.slug_de = nil
assert !journalist.valid?
assert_equal "joseph-pulitzer", journalist.to_param
end
end
end
# https://github.com/norman/friendly_id/issues/947
class GeneratingSlugWithValidationSkippedTest < TestCaseClass
include FriendlyId::Test
class Journalist < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged
end
test "should generate slug when skipping validation" do
transaction do
m1 = Journalist.new
m1.name = "Bob Timesletter"
m1.save(validate: false)
assert_equal "bob-timesletter", m1.slug
end
end
test "should generate slug when #valid? called" do
transaction do
m1 = Journalist.new
m1.name = "Bob Timesletter"
m1.valid?
m1.save(validate: false)
assert_equal "bob-timesletter", m1.slug
end
end
end
class ToParamTest < TestCaseClass
include FriendlyId::Test
class Journalist < ActiveRecord::Base
extend FriendlyId
validates_presence_of :active
validates_length_of :slug, minimum: 2
friendly_id :name, use: :slugged
attr_accessor :to_param_in_callback
after_save do
self.to_param_in_callback = to_param
end
end
test "to_param should return nil if record is unpersisted" do
assert_nil Journalist.new.to_param
end
test "to_param should return original slug if record failed validation" do
journalist = Journalist.new name: "Clark Kent", active: nil
refute journalist.save
assert_equal "clark-kent", journalist.to_param
end
test "to_param should clear slug attributes if slug attribute fails validation" do
journalist = Journalist.new name: "x", active: true
refute journalist.save
assert_nil journalist.to_param
end
test "to_param should clear slug attribute if slug attribute fails validation and unrelated validation fails" do
journalist = Journalist.new name: "x", active: nil
refute journalist.save
assert_nil journalist.to_param
end
test "to_param should use slugged attribute if record saved successfully" do
transaction do
journalist = Journalist.new name: "Clark Kent", active: true
assert journalist.save
assert_equal "clark-kent", journalist.to_param
end
end
test "to_param should use new slug if existing record changes but fails to save" do
transaction do
journalist = Journalist.new name: "Clark Kent", active: true
assert journalist.save
journalist.name = "Superman"
journalist.slug = nil
journalist.active = nil
refute journalist.save
assert_equal "superman", journalist.to_param
end
end
test "to_param should use original slug if new slug attribute is not valid" do
transaction do
journalist = Journalist.new name: "Clark Kent", active: true
assert journalist.save
journalist.name = "x"
journalist.slug = nil
journalist.active = nil
refute journalist.save
assert_equal "clark-kent", journalist.to_param
end
end
test "to_param should use new slug if existing record changes successfully" do
transaction do
journalist = Journalist.new name: "Clark Kent", active: true
assert journalist.save
journalist.name = "Superman"
journalist.slug = nil
assert journalist.save
assert_equal "superman", journalist.to_param
end
end
test "to_param should use new slug within callbacks if new record is saved successfully" do
transaction do
journalist = Journalist.new name: "Clark Kent", active: true
assert journalist.save
assert_equal "clark-kent", journalist.to_param_in_callback, "value of to_param in callback should use the new slug value"
end
end
test "to_param should use new slug within callbacks if existing record changes successfully" do
transaction do
journalist = Journalist.new name: "Clark Kent", active: true
assert journalist.save
assert journalist.valid?
journalist.name = "Superman"
journalist.slug = nil
assert journalist.save, "save should be successful"
assert_equal "superman", journalist.to_param_in_callback, "value of to_param in callback should use the new slug value"
end
end
end
class ConfigurableRoutesTest < TestCaseClass
include FriendlyId::Test
class Article < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged, routes: :friendly
end
class Novel < ActiveRecord::Base
extend FriendlyId
friendly_id :name, use: :slugged, routes: :default
end
test "to_param should return a friendly id when the routes option is set to :friendly" do
transaction do
article = Article.create! name: "Titanic Hits; Iceberg Sinks"
assert_equal "titanic-hits-iceberg-sinks", article.to_param
end
end
test "to_param should return the id when the routes option is set to anything but friendly" do
transaction do
novel = Novel.create! name: "Don Quixote"
assert_equal novel.id.to_s, novel.to_param
end
end
end
|