1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Gitlab::Error::ResponseError do
before do
@request_double = double(base_uri: 'https://gitlab.com/api/v3', path: '/foo', options: {})
end
let(:expected_messages) do
[
%r{Server responded with code \d+, message: Displayed message. Request URI: https://gitlab.com/api/v3/foo},
%r{Server responded with code \d+, message: Displayed error_description. Request URI: https://gitlab.com/api/v3/foo},
%r{Server responded with code \d+, message: Displayed error. Request URI: https://gitlab.com/api/v3/foo},
%r{Server responded with code \d+, message: 'embed_entity' \(foo: bar\) \(sna: fu\), 'password' too short. Request URI: https://gitlab.com/api/v3/foo},
%r{Server responded with code \d+, message: First message. Second message.. Request URI: https://gitlab.com/api/v3/foo},
%r{Server responded with code \d+, message: 'error' Spam detected. Request URI: https://gitlab.com/api/v3/foo}
]
end
# Set up some response scenarios to test.
[
{ code: 401, parsed_response: Gitlab::ObjectifiedHash.new(message: 'Displayed message', error_description: 'should not be displayed', error: 'also will not be displayed') },
{ code: 404, parsed_response: Gitlab::ObjectifiedHash.new(error_description: 'Displayed error_description', error: 'also will not be displayed') },
{ code: 401, parsed_response: Gitlab::ObjectifiedHash.new(error: 'Displayed error') },
{ code: 500, parsed_response: Gitlab::ObjectifiedHash.new(embed_entity: { foo: ['bar'], sna: ['fu'] }, password: ['too short']) },
{ code: 403, parsed_response: Array.new(['First message.', 'Second message.']) },
{ code: 400, parsed_response: Gitlab::ObjectifiedHash.new(message: { error: 'Spam detected' }) }
].each_with_index do |data, index|
it 'returns the expected message' do
response_double = double(**data, request: @request_double)
expect(described_class.new(response_double).message).to match expected_messages[index]
end
end
it 'builds an error message from text' do
headers = { 'content-type' => 'text/plain' }
response_double = double('response', body: 'Retry later', to_s: 'Retry text', parsed_response: { message: 'Retry hash' }, code: 429, options: {}, headers: headers, request: @request_double)
expect(described_class.new(response_double).send(:build_error_message)).to match(/Retry text/)
end
it 'builds an error message from parsed json' do
headers = { 'content-type' => 'application/json' }
response_double = double('response', body: 'Retry later', to_s: 'Retry text', parsed_response: { message: 'Retry hash' }, code: 429, options: {}, headers: headers, request: @request_double)
expect(described_class.new(response_double).send(:build_error_message)).to match(/Retry hash/)
end
describe 'parsing errors' do
let(:headers) { { 'content-type' => 'application/json' } }
let(:response_double) do
double('response', body: 'Retry later', to_s: 'Retry text', code: status, options: {}, headers: headers, request: @request_double)
end
let(:status) { 429 }
before do
allow(response_double).to receive(:parsed_response)
.and_raise(Gitlab::Error::Parsing)
end
it 'builds an error message from text' do
expect(described_class.new(response_double).send(:build_error_message)).to match(/Retry text/)
end
end
describe '#error_code' do
it 'returns the value when available' do
headers = { 'content-type' => 'application/json' }
response_double = double(
'response',
body: 'Retry later',
to_s: 'Retry text',
parsed_response: { message: 'Retry hash' },
code: 400,
error_code: 'conflict',
options: {},
headers: headers,
request: @request_double
)
expect(described_class.new(response_double).error_code).to eq 'conflict'
end
it 'returns nothing when unavailable' do
headers = { 'content-type' => 'application/json' }
response_double = double(
'response',
body: 'Retry later',
to_s: 'Retry text',
parsed_response: { message: 'Retry hash' },
code: 400,
options: {},
headers: headers,
request: @request_double
)
expect(described_class.new(response_double).error_code).to eq ''
end
end
end
|
