1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363
|
# frozen_string_literal: true
require "spec_helper"
describe GraphQL::Backtrace do
class LazyError
def raise_err
raise "Lazy Boom"
end
end
class ErrorAnalyzer < GraphQL::Analysis::Analyzer
def on_enter_operation_definition(node, parent_node, visitor)
if node.name == "raiseError"
raise GraphQL::AnalysisError, "this should not be wrapped by a backtrace, but instead, returned to the client"
end
end
def result
end
end
class NilInspectObject
# Oops, this is evil, but it happens and we should handle it.
def inspect; nil; end
end
module ErrorTrace
def initialize(required_arg:, **_rest)
super(**_rest)
end
def execute_multiplex(multiplex:)
super
raise "Instrumentation Boom"
end
end
let(:resolvers) {
{
"Query" => {
"field1" => Proc.new { :something },
"field2" => Proc.new { :something },
"nilInspect" => Proc.new { NilInspectObject.new },
"nestedList" => Proc.new { [ { thing: { name: "abc" } }, { thing: { name: :boom } } ] },
},
"Thing" => {
"name" => Proc.new { |obj| obj[:name] == :boom ? raise("Boom!") : obj[:name] },
"listField" => Proc.new { :not_a_list },
"raiseField" => Proc.new { |o, a| raise("This is broken: #{a[:message]}") },
"executionError" => Proc.new { raise GraphQL::ExecutionError, "Client-facing error" }
},
"ThingWrapper" => {
"thing" => Proc.new { |obj| obj[:thing] },
},
"OtherThing" => {
"strField" => Proc.new { LazyError.new },
},
}
}
let(:schema) {
defn = <<-GRAPHQL
type Query {
field1: Thing
field2: OtherThing
nilInspect: Thing
nestedList: [ThingWrapper]
}
type Thing {
name: String
listField: [OtherThing]
raiseField(message: String!): Int
executionError: Int
}
type ThingWrapper {
thing: Thing
}
type OtherThing {
strField: String
}
GRAPHQL
schema_class = GraphQL::Schema.from_definition(defn, default_resolve: resolvers)
schema_class.class_exec {
lazy_resolve(LazyError, :raise_err)
query_analyzer(ErrorAnalyzer)
}
schema_class
}
let(:backtrace_schema) {
Class.new(schema) do
use GraphQL::Backtrace
end
}
describe "GraphQL backtrace helpers" do
it "raises a TracedError when enabled" do
assert_raises(GraphQL::Backtrace::TracedError) {
backtrace_schema.execute("query BrokenList { field1 { listField { strField } } }")
}
assert_raises(GraphQL::Execution::Interpreter::ListResultFailedError) {
schema.execute("query BrokenList { field1 { listField { strField } } }")
}
end
it "works for objects inside lists" do
assert_raises(GraphQL::Backtrace::TracedError) do
backtrace_schema.execute("{ nestedList { thing { name } } }")
end
end
it "doesn't wrap GraphQL::ExecutionError" do
assert_equal ["Client-facing error"], backtrace_schema.execute("{ field1 { executionError } }")["errors"].map { |e| e["message"] }
end
it "annotates crashes from user code" do
err = assert_raises(GraphQL::Backtrace::TracedError) {
backtrace_schema.execute <<-GRAPHQL, root_value: "Root"
query($msg: String = \"Boom\") {
field1 {
boomError: raiseField(message: $msg)
}
}
GRAPHQL
}
# The original error info is present
assert_instance_of RuntimeError, err.cause
b = err.cause.backtrace
assert_backtrace_includes(b, file: "backtrace_spec.rb", method: "block")
assert_backtrace_includes(b, file: "field.rb", method: "resolve")
assert_backtrace_includes(b, file: "runtime.rb", method: "evaluate_selection")
assert_backtrace_includes(b, file: "interpreter.rb", method: "run_all")
# GraphQL backtrace is present
expected_graphql_backtrace = [
"3:13: Thing.raiseField as boomError",
"2:11: Query.field1",
"1:9: query",
]
assert_equal expected_graphql_backtrace, err.graphql_backtrace
hash_inspect = { message: "Boom" }.inspect
# The message includes the GraphQL context
rendered_table = [
'Loc | Field | Object | ' + "Arguments".ljust(hash_inspect.size) + ' | Result',
'3:13 | Thing.raiseField as boomError | :something | ' + hash_inspect + ' | #<RuntimeError: This is broken: Boom>',
'2:11 | Query.field1 | "Root" | ' + "{}".ljust(hash_inspect.size) + ' | {}',
'1:9 | query | "Root" | ' + {"msg" => "Boom"}.inspect.ljust(hash_inspect.size) + ' | {field1: {...}}',
].join("\n")
assert_includes err.message, "\n" + rendered_table
# The message includes the original error message
assert_includes err.message, "This is broken: Boom"
assert_includes err.message, "spec/graphql/backtrace_spec.rb:49", "It includes the original backtrace"
assert_includes err.message, "more lines"
end
it "annotates crashes from user code when using inline fragments" do
err = assert_raises(GraphQL::Backtrace::TracedError) {
backtrace_schema.execute <<-GRAPHQL, root_value: "Root"
query($msg: String = \"Boom\") {
field1 {
... on Thing {
boomError: raiseField(message: $msg)
}
}
}
GRAPHQL
}
# GraphQL backtrace is present
expected_graphql_backtrace = [
"4:15: Thing.raiseField as boomError",
"2:11: Query.field1",
"1:9: query",
]
assert_equal expected_graphql_backtrace, err.graphql_backtrace
hash_inspect = { message: "Boom" }.inspect
# The message includes the GraphQL context
rendered_table = [
'Loc | Field | Object | ' + "Arguments".ljust(hash_inspect.size) + ' | Result',
'4:15 | Thing.raiseField as boomError | :something | ' + hash_inspect + ' | #<RuntimeError: This is broken: Boom>',
'2:11 | Query.field1 | "Root" | ' + "{}".ljust(hash_inspect.size) + ' | {}',
'1:9 | query | "Root" | ' + {"msg" => "Boom"}.inspect.ljust(hash_inspect.size) + ' | {field1: {...}}',
].join("\n")
assert_includes err.message, "\n" + rendered_table
# The message includes the original error message
assert_includes err.message, "This is broken: Boom"
assert_includes err.message, "spec/graphql/backtrace_spec.rb:49", "It includes the original backtrace"
assert_includes err.message, "more lines"
end
it "annotates errors from Query#result" do
query_str = "query StrField { field2 { strField } __typename }"
context = { backtrace: true }
query = GraphQL::Query.new(schema, query_str, context: context)
err = assert_raises(GraphQL::Backtrace::TracedError) {
query.result
}
assert_instance_of RuntimeError, err.cause
end
it "annotates errors inside lazy resolution" do
# Test context-based flag
err = assert_raises(GraphQL::Backtrace::TracedError) {
schema.execute("query StrField { field2 { strField } __typename }", context: { backtrace: true })
}
assert_instance_of RuntimeError, err.cause
b = err.cause.backtrace
assert_backtrace_includes(b, file: "backtrace_spec.rb", method: "raise_err")
assert_backtrace_includes(b, file: "schema.rb", method: "sync_lazy")
assert_backtrace_includes(b, file: "interpreter.rb", method: "run_all")
expected_graphql_backtrace = [
"1:27: OtherThing.strField",
"1:18: Query.field2",
"1:1: query StrField",
]
assert_equal(expected_graphql_backtrace, err.graphql_backtrace)
rendered_table = [
'Loc | Field | Object | Arguments | Result',
'1:27 | OtherThing.strField | :something | {} | #<RuntimeError: Lazy Boom>',
'1:18 | Query.field2 | nil | {} | {strField: (unresolved)}',
'1:1 | query StrField | nil | {} | {field2: {...}, __typename: "Query"}',
].join("\n")
assert_includes err.message, rendered_table
end
it "returns analysis errors to the client" do
res = backtrace_schema.execute("query raiseError { __typename }")
assert_equal "this should not be wrapped by a backtrace, but instead, returned to the client", res["errors"].first["message"]
end
it "always stringifies the #inspect response" do
# test the schema plugin
err = assert_raises(GraphQL::Backtrace::TracedError) {
backtrace_schema.execute("query { nilInspect { raiseField(message: \"pop!\") } }")
}
hash_inspect = {message: "pop!"}.inspect # `=>` on Ruby < 3.4
rendered_table = [
'Loc | Field | Object | ' + "Arguments".ljust(hash_inspect.size) + ' | Result',
'1:22 | Thing.raiseField | | ' + hash_inspect + ' | #<RuntimeError: This is broken: pop!>',
'1:9 | Query.nilInspect | nil | ' + "{}".ljust(hash_inspect.size) + ' | {}',
'1:1 | query | nil | ' + "{}".ljust(hash_inspect.size) + ' | {nilInspect: {...}}',
'',
''
].join("\n")
table = err.message.split("GraphQL Backtrace:\n").last
assert_equal rendered_table, table
end
it "raises original exception instead of a TracedError when error does not occur during resolving" do
instrumentation_schema = Class.new(schema) do
trace_with(ErrorTrace, required_arg: true)
end
assert_raises(RuntimeError) {
instrumentation_schema.execute(GraphQL::Introspection::INTROSPECTION_QUERY, context: { backtrace: true })
}
end
end
# This will get brittle when execution code moves between files
# but I'm not sure how to be sure that the backtrace contains the right stuff!
def assert_backtrace_includes(backtrace, file:, method:)
includes_tag = if RUBY_VERSION < "3.4"
backtrace.any? { |s| s.include?(file) && s.include?("`" + method) }
elsif method == "block"
backtrace.any? { |s| s.include?(file) && s.include?("'block") }
else
backtrace.any? { |s| s.include?(file) && s.include?("#{method}'") }
end
assert includes_tag, "Backtrace should include #{file} inside method #{method}\n\n#{backtrace.join("\n")}"
end
it "works with stand-alone validation" do
res = backtrace_schema.validate("{ __typename }")
assert_equal [], res
end
it "works with stand-alone analysis" do
example_analyzer = Class.new(GraphQL::Analysis::Analyzer) do
def result
:finished
end
end
query = GraphQL::Query.new(backtrace_schema, "{ __typename }")
result = GraphQL::Analysis.analyze_query(query, [example_analyzer])
assert_equal [:finished], result
end
it "works with multiplex analysis" do
example_analyzer = Class.new(GraphQL::Analysis::Analyzer) do
def result
:finished
end
end
query = GraphQL::Query.new(backtrace_schema, "{ __typename }")
multiplex = GraphQL::Execution::Multiplex.new(
schema: schema,
queries: [query],
context: {},
max_complexity: nil,
)
result = GraphQL::Analysis.analyze_multiplex(multiplex, [example_analyzer])
assert_equal [:finished], result
end
it "works with multiplex queries" do
res = backtrace_schema.multiplex([
{ query: 'query { __typename }' },
{ query: 'query { __typename }' },
])
expected_res = [
{"data" => { "__typename" => "Query" }},
{"data" => { "__typename" => "Query" }},
]
assert_graphql_equal expected_res, res
end
it "includes other trace modules when backtrace is active" do
custom_trace = Module.new
schema = Class.new(GraphQL::Schema) do
trace_with(custom_trace)
end
query = GraphQL::Query.new(schema, "{ __typename }", context: { backtrace: true })
assert_includes query.current_trace.class.ancestors, custom_trace
end
describe "When validators are used" do
class ValidatorBacktraceSchema < GraphQL::Schema
class Query < GraphQL::Schema::Object
field :greeting, String do
argument :name, String, validates: { length: { minimum: 5 }}
end
def greeting(name:)
"Hello, #{name}!"
end
end
query(Query)
use GraphQL::Backtrace
end
it "works properly" do
assert_equal "Hello, Albert!", ValidatorBacktraceSchema.execute("{ greeting(name: \"Albert\") }")["data"]["greeting"]
assert_equal ["name is too short (minimum is 5)"], ValidatorBacktraceSchema.execute("{ greeting(name: \"Tim\") }")["errors"].map { |e| e["message"] }
end
end
end
|