1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496
|
# frozen_string_literal: true
require "helper"
RSpec.describe HTTP2::Framer do
let(:f) { Framer.new }
context "common header" do
let(:frame) do
{
length: 4,
type: :headers,
flags: %i[end_stream end_headers],
stream: 15
}
end
let(:bytes) { [0, 0x04, 0x01, 0x5, 0x0000000F].pack("CnCCN") }
it "should generate common 9 byte header" do
expect(f.common_header(frame, buffer: "".b)).to eq bytes
end
it "should parse common 9 byte header" do
expect(f.read_common_header(bytes)).to eq frame
end
it "should generate a large frame" do
f = Framer.new
f.remote_max_frame_size = (2**24) - 1
frame = {
length: (2**18) + (2**16) + 17,
type: :headers,
flags: %i[end_stream end_headers],
stream: 15
}
bytes = [5, 17, 0x01, 0x5, 0x0000000F].pack("CnCCN")
expect(f.common_header(frame, buffer: "".b)).to eq bytes
expect(f.read_common_header(bytes)).to eq frame
end
it "should raise exception on invalid frame type when sending" do
expect do
frame[:type] = :bogus
f.common_header(frame, buffer: "".b)
end.to raise_error(CompressionError, /invalid.*type/i)
end
it "should raise exception on invalid stream ID" do
expect do
frame[:stream] = Framer::MAX_STREAM_ID + 1
f.common_header(frame, buffer: "".b)
end.to raise_error(CompressionError, /stream/i)
end
it "should raise exception on invalid frame flag" do
expect do
frame[:flags] = [:bogus]
f.common_header(frame, buffer: "".b)
end.to raise_error(CompressionError, /frame flag/)
end
it "should raise exception on invalid frame size" do
expect do
frame[:length] = 2**24
f.common_header(frame, buffer: "".b)
end.to raise_error(CompressionError, /too large/)
end
end
context "DATA" do
it "should generate and parse bytes" do
frame = {
length: 4,
type: :data,
flags: [:end_stream],
stream: 1,
payload: "text"
}
bytes = f.generate(frame)
expect(bytes).to eq [0, 0x4, 0x0, 0x1, 0x1, *"text".bytes].pack("CnCCNC*")
expect(f.parse(bytes)).to eq frame
end
end
context "HEADERS" do
it "should generate and parse bytes" do
frame = {
length: 12,
type: :headers,
flags: %i[end_stream end_headers],
stream: 1,
payload: "header-block"
}
bytes = f.generate(frame)
expect(bytes).to eq [0, 0xc, 0x1, 0x5, 0x1, *"header-block".bytes].pack("CnCCNC*")
expect(f.parse(bytes)).to eq frame
end
it "should carry an optional stream priority" do
frame = {
length: 16,
type: :headers,
flags: [:end_headers],
stream: 1,
dependency: 15,
weight: 12,
exclusive: false,
payload: "header-block"
}
bytes = f.generate(frame)
expect(bytes).to eq [0, 0x11, 0x1, 0x24, 0x1, 0xf, 0xb, *"header-block".bytes].pack("CnCCNNCC*")
expect(f.parse(bytes)).to eq frame
end
end
context "PRIORITY" do
it "should generate and parse bytes" do
frame = {
length: 5,
type: :priority,
stream: 1,
dependency: 15,
weight: 12,
exclusive: true
}
bytes = f.generate(frame)
expect(bytes).to eq [0, 0x5, 0x2, 0x0, 0x1, 0x8000000f, 0xb].pack("CnCCNNC")
expect(f.parse(bytes)).to eq frame
end
end
context "RST_STREAM" do
it "should generate and parse bytes" do
frame = {
length: 4,
type: :rst_stream,
stream: 1,
error: :stream_closed
}
bytes = f.generate(frame)
expect(bytes).to eq [0, 0x4, 0x3, 0x0, 0x1, 0x5].pack("CnCCNN")
expect(f.parse(bytes)).to eq frame
end
end
context "SETTINGS" do
let(:frame) do
{
type: :settings,
flags: [],
stream: 0,
payload: [
[:settings_max_concurrent_streams, 10],
[:settings_header_table_size, 2048]
]
}
end
it "should generate and parse bytes" do
bytes = f.generate(frame)
expect(bytes).to eq [0, 12, 0x4, 0x0, 0x0, 3, 10, 1, 2048].pack("CnCCNnNnN")
parsed = f.parse(bytes)
parsed.delete(:length)
frame.delete(:length)
expect(parsed).to eq frame
end
it "should generate settings when id is given as an integer" do
frame[:payload][1][0] = 1
bytes = f.generate(frame)
expect(bytes).to eq [0, 12, 0x4, 0x0, 0x0, 3, 10, 1, 2048].pack("CnCCNnNnN")
end
it "should ignore custom settings when sending" do
frame[:payload] = [
[:settings_max_concurrent_streams, 10],
[:settings_initial_window_size, 20],
[55, 30]
]
buf = f.generate(frame)
frame[:payload].slice!(2) # cut off the extension
frame[:length] = 12 # frame length should be computed WITHOUT extensions
expect(f.parse(buf)).to eq frame
end
it "should ignore custom settings when receiving" do
frame[:payload] = [
[:settings_max_concurrent_streams, 10],
[:settings_initial_window_size, 20]
]
buf = f.generate(frame)
buf.setbyte(2, 18) # add 6 to the frame length
buf << "\x00\x37\x00\x00\x00\x1e"
parsed = f.parse(buf)
parsed.delete(:length)
frame.delete(:length)
expect(parsed).to eq frame
end
it "should raise exception on sending invalid stream ID" do
expect do
frame[:stream] = 1
f.generate(frame)
end.to raise_error(CompressionError, /Invalid stream ID/)
end
it "should raise exception on receiving invalid stream ID" do
expect do
buf = f.generate(frame)
buf.setbyte(8, 1)
f.parse(buf)
end.to raise_error(ProtocolError, /Invalid stream ID/)
end
it "should raise exception on sending invalid setting" do
expect do
frame[:payload] = [[:random, 23]]
f.generate(frame)
end.to raise_error(CompressionError, /Unknown settings ID/)
end
it "should raise exception on receiving invalid payload length" do
expect do
buf = f.generate(frame)
buf.setbyte(2, 11) # change payload length
f.parse(buf)
end.to raise_error(ProtocolError, /Invalid settings payload length/)
end
end
context "PUSH_PROMISE" do
it "should generate and parse bytes" do
frame = {
length: 11,
type: :push_promise,
flags: [:end_headers],
stream: 1,
promise_stream: 2,
payload: "headers"
}
bytes = f.generate(frame)
expect(bytes).to eq [0, 0xb, 0x5, 0x4, 0x1, 0x2, *"headers".bytes].pack("CnCCNNC*")
expect(f.parse(bytes)).to eq frame
end
end
context "PING" do
let(:frame) do
{
length: 8,
stream: 1,
type: :ping,
flags: [:ack],
payload: "12345678"
}
end
it "should generate and parse bytes" do
bytes = f.generate(frame)
expect(bytes).to eq [0, 0x8, 0x6, 0x1, 0x1, *"12345678".bytes].pack("CnCCNC*")
expect(f.parse(bytes)).to eq frame
end
it "should raise exception on invalid payload" do
expect do
frame[:payload] = "1234"
f.generate(frame)
end.to raise_error(CompressionError, /Invalid payload size/)
end
end
context "GOAWAY" do
let(:frame) do
{
length: 13,
stream: 1,
type: :goaway,
last_stream: 2,
error: :no_error,
payload: "debug"
}
end
it "should generate and parse bytes" do
bytes = f.generate(frame)
expect(bytes).to eq [0, 0xd, 0x7, 0x0, 0x1, 0x2, 0x0, *"debug".bytes].pack("CnCCNNNC*")
expect(f.parse(bytes)).to eq frame
end
it "should treat debug payload as optional" do
frame.delete :payload
frame[:length] = 0x8
bytes = f.generate(frame)
expect(bytes).to eq [0, 0x8, 0x7, 0x0, 0x1, 0x2, 0x0].pack("CnCCNNN")
expect(f.parse(bytes)).to eq frame
end
end
context "WINDOW_UPDATE" do
it "should generate and parse bytes" do
frame = {
length: 4,
type: :window_update,
increment: 10
}
bytes = f.generate(frame)
expect(bytes).to eq [0, 0x4, 0x8, 0x0, 0x0, 0xa].pack("CnCCNN")
parsed_frame = f.parse(bytes)
frame.each do |k, v|
expect(parsed_frame[k]).to eq(v)
end
end
it "should break when the increment is too large" do
frame = {
length: 4,
type: :window_update,
increment: 0x7fffffff + 1
}
expect { f.generate(frame) }.to raise_error(CompressionError)
end
end
context "CONTINUATION" do
it "should generate and parse bytes" do
frame = {
length: 12,
type: :continuation,
stream: 1,
flags: [:end_headers],
payload: "header-block"
}
bytes = f.generate(frame)
expect(bytes).to eq [0, 0xc, 0x9, 0x4, 0x1, *"header-block".bytes].pack("CnCCNC*")
expect(f.parse(bytes)).to eq frame
end
end
context "ALTSVC" do
it "should generate and parse bytes" do
frame = {
length: 44,
type: :altsvc,
stream: 1,
max_age: 1_402_290_402, # 4
port: 8080, # 2
proto: "h2-13", # 1 + 5
host: "www.example.com", # 1 + 15
origin: "www.example.com" # 15
}
bytes = f.generate(frame)
expected = [0, 43, 0xa, 0, 1, 1_402_290_402, 8080].pack("CnCCNNn")
expected << [5, *"h2-13".bytes].pack("CC*")
expected << [15, *"www.example.com".bytes].pack("CC*")
expected << [*"www.example.com".bytes].pack("C*")
expect(bytes).to eq expected
expect(f.parse(bytes)).to eq frame
end
end
context "Padding" do
let(:frame) do
{
length: 12,
type: type,
stream: 1,
payload: "example data"
}
end
%i[data headers push_promise].each do |type|
let(:type) { type }
if type == :push_promise
let(:frame) do
{
length: 12,
type: type,
stream: 1,
payload: "example data",
promise_stream: 2
}
end
end
[1, 256].each do |padlen|
context "generating #{type} frame padded #{padlen}" do
let(:normal) { f.generate(frame) }
let(:padded) { f.generate(frame.merge(padding: padlen)) }
it "should generate a frame with padding" do
expect(padded.bytesize).to eq normal.bytesize + padlen
end
it "should fill padded octets with zero" do
trailer_len = padlen - 1
expect(padded[-trailer_len, trailer_len]).to match(/\A\0*\z/)
end
it "should parse a frame with padding" do
expect(f.parse(padded)).to eq \
f.parse(normal).merge(padding: padlen)
end
it "should preserve payload" do
expect(f.parse(padded)[:payload]).to eq frame[:payload]
end
end
end
end
context "generating with invalid padding length" do
[0, 257, 1334].each do |padlen|
it "should raise error on trying to generate data frame padded with invalid #{padlen}" do
expect do
f.generate(frame.merge(padding: padlen))
end.to raise_error(CompressionError, /padding/i)
end
end
it "should raise error when adding a padding would make frame too large" do
frame[:payload] = "q" * (f.remote_max_frame_size - 200)
frame[:length] = frame[:payload].size
frame[:padding] = 210 # would exceed 4096
expect do
f.generate(frame)
end.to raise_error(CompressionError, /padding/i)
end
end
context "parsing frames with invalid paddings" do
let(:padded) { f.generate(frame.merge(padding: 123)) }
it "should raise exception when the given padding is longer than the payload" do
padded.setbyte(9, 240)
expect { f.parse(padded) }.to raise_error(ProtocolError, /padding/)
end
end
end
it "should determine frame length" do
frames = [
[{ type: :data, stream: 1, flags: [:end_stream], payload: "abc" }, 3],
[{ type: :headers, stream: 1, payload: "abc" }, 3],
[{ type: :priority, stream: 3, dependency: 30, exclusive: false, weight: 1 }, 5],
[{ type: :rst_stream, stream: 3, error: 100 }, 4],
[{ type: :settings, payload: [[:settings_max_concurrent_streams, 10]] }, 6],
[{ type: :push_promise, promise_stream: 5, payload: "abc" }, 7],
[{ type: :ping, payload: "blob" * 2 }, 8],
[{ type: :goaway, last_stream: 5, error: 20, payload: "blob" }, 12],
[{ type: :window_update, stream: 1, increment: 1024 }, 4],
[{ type: :continuation, stream: 1, payload: "abc" }, 3]
]
frames.each do |(frame, size)|
bytes = f.generate(frame)
expect(bytes.slice(1, 2).unpack1("n")).to eq size
expect(bytes.getbyte(0)).to eq 0
end
end
it "should parse single frame at a time" do
frames = [
{ type: :headers, stream: 1, payload: "headers" },
{ type: :data, stream: 1, flags: [:end_stream], payload: "abc" }
]
buf = f.generate(frames[0]) << f.generate(frames[1])
expect(f.parse(buf)).to eq frames[0]
expect(f.parse(buf)).to eq frames[1]
end
it "should process full frames only" do
frame = { type: :headers, stream: 1, payload: "headers" }
bytes = f.generate(frame)
expect(f.parse(bytes.slice(0...-1))).to be_nil
expect(f.parse(bytes)).to eq frame
expect(bytes).to be_empty
end
it "should ignore unknown extension frames" do
frame = { type: :headers, stream: 1, payload: "headers" }
bytes = f.generate(frame)
bytes = "#{bytes}#{bytes}".b # Two HEADERS frames in bytes
bytes.setbyte(3, 42) # Make the first unknown type 42
expect(f.parse(bytes)[:type]).to be_nil
expect(f.parse(bytes)).to eq frame # should generate only one HEADERS
expect(bytes).to be_empty
end
end
|